Timeline
Nov 13, 2015:
- 9:51 PM Changeset in webkit [192455] by
-
- 3 edits in trunk/PerformanceTests
Eliminate a request for layout every time an item is added to the stage of the graphics benchmark
https://bugs.webkit.org/show_bug.cgi?id=151289
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-11-13
Reviewed by Simon Fraser.
Cache the stage size when it is created instead of requesting every time
an object is added via clientWidth and clientHeight.
- Animometer/resources/extensions.js:
(Insets.elementPadding):
- Animometer/tests/resources/stage.js:
(Stage):
(Stage.prototype.get size):
- 8:03 PM Changeset in webkit [192454] by
-
- 5 edits2 deletes in trunk/Source
Unreviewed, rolling out r192445, r192451, and r192452.
https://bugs.webkit.org/show_bug.cgi?id=151291
Broke Mavericks build (and thus EWS) (Requested by ap on
#webkit).
Reverted changesets:
"Add identifier strings for a bunch of context menu items"
https://bugs.webkit.org/show_bug.cgi?id=151272
http://trac.webkit.org/changeset/192445
"Try to fix the 32-bit build"
http://trac.webkit.org/changeset/192451
"Try to fix the 32-bit build"
http://trac.webkit.org/changeset/192452
- 5:18 PM Changeset in webkit [192453] by
-
- 4 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r192416 and r192443.
https://bugs.webkit.org/show_bug.cgi?id=151285
Broke 32-bit in some mysterious way I need to understand
(Requested by kling on #webkit).
Reverted changesets:
"[JSC] JSPropertyNameEnumerator could be destructorless."
https://bugs.webkit.org/show_bug.cgi?id=151242
http://trac.webkit.org/changeset/192416
"Follow-up for 32-bit test failures after..."
https://bugs.webkit.org/show_bug.cgi?id=151242
http://trac.webkit.org/changeset/192443
- 4:56 PM Changeset in webkit [192452] by
-
- 2 edits in trunk/Source/WebKit2
Try to fix the 32-bit build
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::createShareMenuItem):
- 4:41 PM Changeset in webkit [192451] by
-
- 2 edits in trunk/Source/WebKit2
Try to fix the 32-bit build
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::menuItemIdentifier):
- 4:40 PM Changeset in webkit [192450] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r192401.
https://bugs.webkit.org/show_bug.cgi?id=151282
"caused crashes on animometer" (Requested by thorton on
#webkit).
Reverted changeset:
"Restore CodeBlock jettison code I accidentally removed"
https://bugs.webkit.org/show_bug.cgi?id=151241
http://trac.webkit.org/changeset/192401
- 4:30 PM Changeset in webkit [192449] by
-
- 2 edits in trunk/Tools
Unreviewed, change JavaScriptCore watchlist to exclude inspector things.
- Scripts/webkitpy/common/config/watchlist:
- 4:05 PM Changeset in webkit [192448] by
-
- 2 edits in trunk/Source/WebKit2
WK2 iOS interaction tests in LayoutTests/fast/events/ios are flaky
https://bugs.webkit.org/show_bug.cgi?id=151199
<rdar://problem/23518459>
Reviewed by Tim Horton.
While transforming touch positions from document to global coordinates, HIDEventGenerator
sometimes uses an old scale of the webview in computing the transformed position. This happens
in spite of how we force the UI script to run after the UI process receives a layer tree commit
because we invoke the callback before calling WebPageProxy::didCommitLayerTree, which is where
we actually use the layer transaction information to update the WKWebView.
To fix this, we run the drawing-ensured callbacks after committing the layer tree, so the
callbacks will have updated information about the web view's scale and dimensions.
- UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
- 4:00 PM Changeset in webkit [192447] by
-
- 7 edits in trunk
Support printing in WKWebView
https://bugs.webkit.org/show_bug.cgi?id=151276
<rdar://problem/23525715>
Reviewed by Beth Dakin.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _printOperationWithPrintInfo:]):
(-[WKWebView _printOperationWithPrintInfo:forFrame:]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
Expose SPI similar to what we have on WKView.
- MiniBrowser/mac/MainMenu.xib:
- MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController printWebView:]):
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController printWebView:]):
Hook up printing to Minibrowser!
- 3:47 PM Changeset in webkit [192446] by
-
- 2 edits in trunk/Source/WebKit2
Follow-up to r192437. Add availability macros.
Reviewed by Tim Horton.
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- 3:37 PM Changeset in webkit [192445] by
-
- 5 edits2 adds in trunk/Source
Add identifier strings for a bunch of context menu items
https://bugs.webkit.org/show_bug.cgi?id=151272
Reviewed by Dan Bernstein.
Source/WebCore:
Have NSMenuItem conform to NSUserInterfaceItemIdentification.
- platform/spi/mac/NSMenuSPI.h:
Source/WebKit2:
- UIProcess/API/Cocoa/WKMenuItemIdentifiers.mm: Added.
- UIProcess/API/Cocoa/WKMenuItemIdentifiersPrivate.h: Added.
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::menuItemIdentifier):
(WebKit::WebContextMenuProxyMac::createShareMenuItem):
(WebKit::WebContextMenuProxyMac::createContextMenuItem):
- WebKit2.xcodeproj/project.pbxproj:
- 3:11 PM Changeset in webkit [192444] by
-
- 12 edits in trunk
Always render at least a device pixel line when border/outline width > 0.
https://bugs.webkit.org/show_bug.cgi?id=151269
This matches Firefox behaviour.
Reviewed by Simon Fraser.
Source/WebCore:
Existing test is modified to reflect the new behaviour.
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertLineWidth):
- rendering/BorderEdge.cpp:
(WebCore::BorderEdge::BorderEdge): Deleted.
- rendering/BorderEdge.h:
LayoutTests:
- fast/borders/hidpi-border-width-flooring-expected.html:
- fast/borders/hidpi-border-width-flooring.html:
- 2:16 PM Changeset in webkit [192443] by
-
- 3 edits in trunk/Source/JavaScriptCore
Follow-up for 32-bit test failures after...
[JSC] JSPropertyNameEnumerator could be destructorless.
<https://webkit.org/b/151242>
Reviewed by Mark Lam
Apparently copied space allocations need to be in multiples of 8 bytes.
Have JSPropertyNameEnumerator do what other copied space clients already do
and round the allocation size up to a multiple of 8.
Added a little helper function to compute the allocation size so this doesn't
have to be repeated everywhere.
- runtime/JSPropertyNameEnumerator.cpp:
(JSC::JSPropertyNameEnumerator::finishCreation):
(JSC::JSPropertyNameEnumerator::visitChildren):
(JSC::JSPropertyNameEnumerator::copyBackingStore):
- runtime/JSPropertyNameEnumerator.h:
- 1:51 PM Changeset in webkit [192442] by
-
- 5 edits in branches/safari-601.1.46.60-branch/Source
Versioning.
- 1:49 PM Changeset in webkit [192441] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo][MediaFoundation] Video rendered at wrong position.
https://bugs.webkit.org/show_bug.cgi?id=151271
Reviewed by Alex Christensen.
The source rectangle used when blitting a frame to the graphics context
should have offset (0, 0).
- platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
(WebCore::MediaPlayerPrivateMediaFoundation::Direct3DPresenter::paintCurrentFrame):
- 1:47 PM Changeset in webkit [192440] by
-
- 1 copy in branches/safari-601.1.46.60-branch
New Branch.
- 1:36 PM Changeset in webkit [192439] by
-
- 10 edits1 add in trunk/Source/JavaScriptCore
sub IC does not properly handle exception handling now that try/catch is compiled in the FTL
https://bugs.webkit.org/show_bug.cgi?id=151080
Reviewed by Geoffrey Garen.
This patch implements proper exception handling for ArithSubs with binaryUseKind as
UntypedUse inside try/catch. We implement this in a very similar way as we implement
exception handling from GetById/PutById/LazySlowPaths callOperation calls. We do the needed
spilling if the result is the same register as the left/right register because in the event
of an exception, we don't want to do value recovery on the garbage result, we
want to do it on the original lhs/rhs of the operation.
This patch also does some refactoring. No longer does OSRExitDescriptor
have a long list of booleans that correspond to different OSR exit types.
It now just has an enum property called ExceptionType that tells us
what type of exception handler the OSR exit is. Then, we can just ask
interesting questions about the OSR exit and get answers based on its
ExceptionType property.
- ftl/FTLCompile.cpp:
(JSC::FTL::mmAllocateDataSection):
- ftl/FTLExceptionHandlerManager.cpp:
(JSC::FTL::ExceptionHandlerManager::addNewExit):
(JSC::FTL::ExceptionHandlerManager::callOperationExceptionTarget):
(JSC::FTL::ExceptionHandlerManager::lazySlowPathExceptionTarget):
(JSC::FTL::ExceptionHandlerManager::getByIdOSRExit):
(JSC::FTL::ExceptionHandlerManager::subOSRExit):
(JSC::FTL::ExceptionHandlerManager::getCallOSRExitCommon):
(JSC::FTL::ExceptionHandlerManager::getOrPutByIdCallOperationExceptionTarget): Deleted.
- ftl/FTLExceptionHandlerManager.h:
- ftl/FTLExitThunkGenerator.cpp:
(JSC::FTL::ExitThunkGenerator::emitThunk):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::lower):
(JSC::FTL::DFG::LowerDFGToLLVM::compileArithAddOrSub):
(JSC::FTL::DFG::LowerDFGToLLVM::compilePutById):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstruct):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstructVarargs):
(JSC::FTL::DFG::LowerDFGToLLVM::compileInvalidationPoint):
(JSC::FTL::DFG::LowerDFGToLLVM::getById):
(JSC::FTL::DFG::LowerDFGToLLVM::lazySlowPath):
(JSC::FTL::DFG::LowerDFGToLLVM::callCheck):
(JSC::FTL::DFG::LowerDFGToLLVM::appendOSRExitArgumentsForPatchpointIfWillCatchException):
(JSC::FTL::DFG::LowerDFGToLLVM::emitBranchToOSRExitIfWillCatchException):
(JSC::FTL::DFG::LowerDFGToLLVM::lowBlock):
(JSC::FTL::DFG::LowerDFGToLLVM::appendOSRExitDescriptor):
(JSC::FTL::DFG::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::DFG::LowerDFGToLLVM::buildExitArguments):
- ftl/FTLOSRExit.cpp:
(JSC::FTL::OSRExitDescriptor::OSRExitDescriptor):
(JSC::FTL::OSRExitDescriptor::willArriveAtExitFromIndirectExceptionCheck):
(JSC::FTL::OSRExitDescriptor::mightArriveAtOSRExitFromGenericUnwind):
(JSC::FTL::OSRExitDescriptor::mightArriveAtOSRExitFromCallOperation):
(JSC::FTL::OSRExitDescriptor::needsRegisterRecoveryOnGenericUnwindOSRExitPath):
(JSC::FTL::OSRExitDescriptor::isExceptionHandler):
(JSC::FTL::OSRExitDescriptor::validateReferences):
(JSC::FTL::OSRExit::OSRExit):
(JSC::FTL::OSRExit::codeLocationForRepatch):
(JSC::FTL::OSRExit::gatherRegistersToSpillForCallIfException):
(JSC::FTL::OSRExit::spillRegistersToSpillSlot):
(JSC::FTL::OSRExit::recoverRegistersFromSpillSlot):
- ftl/FTLOSRExit.h:
- ftl/FTLOSRExitCompilationInfo.h:
(JSC::FTL::OSRExitCompilationInfo::OSRExitCompilationInfo):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileFTLOSRExit):
- tests/stress/ftl-try-catch-arith-sub-exception.js: Added.
(assert):
(let.o.valueOf):
(baz):
(foo):
(bar):
- 1:29 PM Changeset in webkit [192438] by
-
- 1 copy in tags/Safari-601.1.46.60
New tag.
- 11:46 AM Changeset in webkit [192437] by
-
- 15 edits in trunk/Source
Web Inspector: Provide a way to override the WKWebView remote inspector name
https://bugs.webkit.org/show_bug.cgi?id=151075
Reviewed by Tim Horton.
Source/WebCore:
- page/Page.cpp:
(WebCore::Page::remoteInspectionNameOverride):
(WebCore::Page::setRemoteInspectionNameOverride):
- page/Page.h:
- page/PageDebuggable.cpp:
(WebCore::PageDebuggable::name):
(WebCore::PageDebuggable::setNameOverride):
- page/PageDebuggable.h:
Source/WebKit2:
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _remoteInspectionNameOverride]):
(-[WKWebView _setRemoteInspectionNameOverride:]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setRemoteInspectionNameOverride):
(WebKit::WebPageProxy::creationParameters):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::remoteInspectionNameOverride):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::m_shouldDispatchFakeMouseMoveEvents):
(WebKit::WebPage::setRemoteInspectionNameOverride):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 11:13 AM Changeset in webkit [192436] by
-
- 10 edits3 adds in trunk/Source/JavaScriptCore
Allow any LeftHandSideExpression as a valid AssignmentElement
https://bugs.webkit.org/show_bug.cgi?id=151026
Patch by Caitlin Potter <caitpotter88@gmail.com> on 2015-11-13
Reviewed by Geoffrey Garen.
- bytecompiler/NodesCodegen.cpp:
(JSC::AssignmentElementNode::collectBoundIdentifiers):
(JSC::AssignmentElementNode::bindValue):
(JSC::AssignmentElementNode::toString):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::isAssignmentLocation):
(JSC::ASTBuilder::createAssignmentElement):
- parser/NodeConstructors.h:
(JSC::AssignmentElementNode::AssignmentElementNode):
- parser/Nodes.h:
(JSC::AssignmentElementNode::assignmentTarget):
(JSC::AssignmentElementNode::divotStart):
(JSC::AssignmentElementNode::divotEnd):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::createAssignmentElement):
(JSC::Parser<LexerType>::parseDestructuringPattern):
- parser/Parser.h:
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::operatorStackPop):
- 11:10 AM Changeset in webkit [192435] by
-
- 2 edits in trunk/LayoutTests
[GTK] GTK gardening.
Unreviewed.
- platform/gtk/TestExpectations: Update the expectation for a renamed
test and mark as failing some of the tests from imported/blink.
- 10:52 AM Changeset in webkit [192434] by
-
- 2 edits in trunk/Source/JavaScriptCore
op_assert should declare that it uses the first register argument
https://bugs.webkit.org/show_bug.cgi?id=151183
Reviewed by Geoffrey Garen.
op_assert(conditionRegister, lineNumber) should declare that it
*uses* (in terms of use-def) the firstconditionRegisterand
it does not define any variables.
- bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
- 10:36 AM Changeset in webkit [192433] by
-
- 3 edits2 adds in trunk
Element::focus() should acquire the ownership of Frame.
https://bugs.webkit.org/show_bug.cgi?id=150204
<rdar://problem/23136794>
Reviewed by Brent Fulgham.
Source/WebCore:
The FrameSelection::setSelection method sometimes releases the last reference to a frame.
When this happens, the Element::updateFocusAppearance would attempt to use dereferenced memory.
Instead, we should ensure that the Frame lifetime is guaranteed to extend through the duration
of the method call.
Test: editing/selection/focus-iframe-removal-crash.html
- dom/Element.cpp:
(WebCore::Element::updateFocusAppearance):
LayoutTests:
- editing/selection/focus-iframe-removal-crash-expected.txt: Added.
- editing/selection/focus-iframe-removal-crash.html: Added.
- 10:11 AM Changeset in webkit [192432] by
-
- 15 edits2 adds in trunk
Hardware keyboard spacebar scrolls too far on iOS
https://bugs.webkit.org/show_bug.cgi?id=151227
<rdar://problem/23500681>
Reviewed by Simon Fraser.
There were two bugs conspiring here to make spacebar scrolling very wrong on iOS:
1) Incoming key events were being handled twice
- fix this by only propagating the event to super if we don't end up handling the event ourselves
2) _scrollByOffset was not converting the offset delta out of content coordinates
- fix this by doing the relevant conversion and renaming the function to make it more clear exactly what it does
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _scrollByContentOffset:]):
(-[WKWebView _scrollByOffset:]): Deleted.
- UIProcess/API/Cocoa/WKWebViewInternal.h:
Rename to _scrollByContentOffset to make it clear that this is
in content coordinates, and do the conversion from content coordinates
(apply the scale) so that we scroll by the right amount.
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::doneWithKeyEvent):
Pass whether the event was handled through to WKContentView.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKWebEvent dealloc]):
Add WKWebEvent, which is a WebEvent and retains a reference to the UIEvent
from which it came.
(-[WKContentView _handleKeyUIEvent:]):
Only pass the event to super immediately if we don't try to handle it.
We'll re-send it to super asynchronously if we decide not to handle it.
(-[WKContentView handleKeyEvent:]):
If we're in the middle of resending an event we didn't handle the first
time, just ignore it.
Make a WKWebEvent and store the UIEvent on it.
(-[WKContentView _didHandleKeyEvent:eventWasHandled:]):
If the event wasn't handled, and is one of our special events with a
wrapped UIEvent, resend it to super. We'll ignore it as noted above.
(-[WKContentView _interpretKeyEvent:isCharEvent:]):
Factor out unobscured content rect retrieval.
Make use of Scrollbar::pageStep to match the Mac behavior of not
scrolling quite a whole page when scrolling with the spacebar.
- fast/events/ios/keyboard-scrolling-distance-expected.txt: Added.
- fast/events/ios/keyboard-scrolling-distance.html: Added.
Add a test that records how much we scroll when pressing the spacebar.
The test is at a fixed scale of 1.5 to expose the bug fixed by this patch.
- WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
- WebKitTestRunner/UIScriptContext/UIScriptContext.h:
- WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::setDidEndScrollingCallback):
(WTR::UIScriptController::didEndScrollingCallback):
(WTR::UIScriptController::platformSetDidEndScrollingCallback):
- WebKitTestRunner/UIScriptContext/UIScriptController.h:
- WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
- WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
(-[TestRunnerWKWebView dealloc]):
(-[TestRunnerWKWebView _didFinishScrolling]):
- WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::platformSetDidEndScrollingCallback):
(WTR::UIScriptController::platformClearAllCallbacks):
Expose _didFinishScrolling on WKWebView to the UIScriptController.
- 10:08 AM Changeset in webkit [192431] by
-
- 2 edits in trunk/Tools
[Win] Unreviewed test fix.
- Scripts/webkitpy/port/win.py:
(WinPort.results_directory): Our 'results_directory' should be an absolute path (even when not
using Cygwin), but should be in DOS format for non-Cygwin clients.
- 9:56 AM Changeset in webkit [192430] by
-
- 2 edits in trunk/LayoutTests
Removing a deleted test from mac-wk2 test expectations.
https://bugs.webkit.org/show_bug.cgi?id=151103
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 9:03 AM Changeset in webkit [192429] by
-
- 8 edits in branches/safari-601.1.46-branch
Merge r192269. rdar://problem/23189742
- 9:03 AM Changeset in webkit [192428] by
-
- 3 edits2 adds in branches/safari-601.1.46-branch
Merge r192120. rdar://problem/23189774
- 9:03 AM Changeset in webkit [192427] by
-
- 7 edits2 adds in branches/safari-601.1.46-branch
Merge r192042. rdar://problem/23189765
- 9:03 AM Changeset in webkit [192426] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebKit2
Merge r191872. rdar://problem/23395972
- 9:03 AM Changeset in webkit [192425] by
-
- 4 edits2 adds in branches/safari-601.1.46-branch
Merge r190595. rdar://problem/23432378
- 9:03 AM Changeset in webkit [192424] by
-
- 8 edits2 adds in branches/safari-601.1.46-branch
Merge r190446. rdar://problem/23432369
- 9:03 AM Changeset in webkit [192423] by
-
- 79 edits2 copies1 add in branches/safari-601.1.46-branch
Merge r188647. rdar://problem/23432373
- 9:03 AM Changeset in webkit [192422] by
-
- 18 edits4 adds in branches/safari-601.1.46-branch
Merge r188530. rdar://problem/23432371
- 9:03 AM Changeset in webkit [192421] by
-
- 8 edits5 adds in branches/safari-601.1.46-branch
Merge r188514. rdar://problem/23432371
- 9:02 AM Changeset in webkit [192420] by
-
- 18 edits4 adds in branches/safari-601.1.46-branch
Merge r188512. rdar://problem/23432371
- 9:02 AM Changeset in webkit [192419] by
-
- 7 edits in branches/safari-601.1.46-branch/Source
Merge r190574. rdar://problem/22846841
- 9:02 AM Changeset in webkit [192418] by
-
- 4 edits in branches/safari-601.1.46-branch/Source/WebKit2
Merge r189635. rdar://problem/22846841
- 9:02 AM Changeset in webkit [192417] by
-
- 4 edits in branches/safari-601.1.46-branch/Source/WebKit2
Merge r189628. rdar://problem/22846841
- 7:59 AM Changeset in webkit [192416] by
-
- 4 edits in trunk/Source/JavaScriptCore
[JSC] JSPropertyNameEnumerator could be destructorless.
<https://webkit.org/b/151242>
Reviewed by Mark Lam.
Make JSPropertyNameEnumerator destructorless and have it store the property names
cache in CopiedSpace. This was the most popular occupant of 64-byte destructor cells
in MarkedSpace, so making it destructorless gets rid of some ill-filled MarkedBlocks.
- heap/CopyToken.h:
- runtime/JSPropertyNameEnumerator.cpp:
(JSC::JSPropertyNameEnumerator::finishCreation):
(JSC::JSPropertyNameEnumerator::visitChildren):
(JSC::JSPropertyNameEnumerator::copyBackingStore):
(JSC::JSPropertyNameEnumerator::destroy): Deleted.
- runtime/JSPropertyNameEnumerator.h:
- 5:49 AM WebKitGTK/Gardening/Howto edited by
- (diff)
- 4:50 AM Changeset in webkit [192415] by
-
- 3 edits in trunk/LayoutTests
[css-grid] Fix swap-lines-if-start-is-further-endward-than-end-line.html
https://bugs.webkit.org/show_bug.cgi?id=151257
Reviewed by Mario Sanchez Prada.
I forgot to add a link to resources/grid.css stylesheet when I
added this test so it was not actually testing Grid Layout
code.
- fast/css-grid-layout/swap-lines-if-start-is-further-endward-than-end-line-expected.html:
- fast/css-grid-layout/swap-lines-if-start-is-further-endward-than-end-line.html:
- 4:48 AM Changeset in webkit [192414] by
-
- 3 edits in trunk/Source/WebCore
[css-grid] Remove unused GridResolvedPosition constructor
https://bugs.webkit.org/show_bug.cgi?id=151133
Reviewed by Mario Sanchez Prada.
No new tests required, just deleting dead code.
- rendering/style/GridResolvedPosition.cpp:
(WebCore::GridResolvedPosition::GridResolvedPosition): Deleted.
- rendering/style/GridResolvedPosition.h:
- 3:13 AM Changeset in webkit [192413] by
-
- 4 edits2 adds in trunk
ASSERTION FAILED: m_isEngaged in WTF::Optional::value
https://bugs.webkit.org/show_bug.cgi?id=151094
Reviewed by Darin Adler.
Source/WebCore:
That ASSERT was hit because the precondition was incorrectly
met, i.e., we're considering that the main axis length was
definite when it was actually not. The problem is that to
determine whether it was indefinite or not we're using
RenderBox::hasDefiniteLogicalHeight() which did not perfectly
match RenderBox::computePercentageLogicalHeight() for the case
of RenderTables. So computePercentageLogicalHeight() was
returning Nullopt (i.e. indefinite) while
hasDefiniteLogicalHeight() was returning true (so definite).
Some checks were refactored in a helper function to solve the
inconsistency so that both functions behave the same way even
in this particular situation.
Test: css3/flexbox/inline-flex-percentage-height-in-table-crash.html
- rendering/RenderBox.cpp:
(WebCore::tableCellShouldHaveZeroInitialSize):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::percentageLogicalHeightIsResolvable):
(WebCore::RenderBox::percentageLogicalHeightIsResolvableFromBlock):
- rendering/RenderBox.h:
LayoutTests:
- css3/flexbox/inline-flex-percentage-height-in-table-crash-expected.txt: Added.
- css3/flexbox/inline-flex-percentage-height-in-table-crash.html: Added.
- 2:47 AM Changeset in webkit [192412] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, really fix the Mac CMake build after r192376.
- PlatformMac.cmake:
- 2:43 AM Changeset in webkit [192411] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix the Mac CMake build after r192376.
- PlatformMac.cmake:
Nov 12, 2015:
- 11:57 PM Changeset in webkit [192410] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Fix wrong test case for window_create since r192196
https://bugs.webkit.org/show_bug.cgi?id=151247
Reviewed by Gyuyoung Kim.
r192196 introduces new test cases for window_create but there are typos which hide bug
This patch fixes typos and split ewk_view_create_window test case.
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
- 10:13 PM Changeset in webkit [192409] by
-
- 6 edits in trunk/Source/JavaScriptCore
[JSC] Do not generate an Add when adding a zero immediate to something
https://bugs.webkit.org/show_bug.cgi?id=151171
Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-11-12
Reviewed by Geoffrey Garen.
Avoid generating an add if one of arguments is a zero immediate.
On x86, the add32/64() were also used internally for branchAdd32/64.
I split the code that sets flag to add32AndSetFlags() to make sure
we always force the flags before testing.
I could have used CMp to set the flags but I would gain nothing from
that, cmp is just a SUB.
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::add32):
(JSC::MacroAssemblerARM64::add64):
- assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::add32):
- assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::add32):
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::add32):
(JSC::MacroAssemblerX86Common::branchAdd32):
(JSC::MacroAssemblerX86Common::add32AndSetFlags):
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::add32):
(JSC::MacroAssemblerX86_64::add64):
(JSC::MacroAssemblerX86_64::branchAdd64):
(JSC::MacroAssemblerX86_64::add64AndSetFlags):
- 10:03 PM Changeset in webkit [192408] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Deleting a probe should remove probe breakpoint actions only.
https://bugs.webkit.org/show_bug.cgi?id=151245
Reviewed by Brian Burg.
Fixed breakpoint action filter.
- UserInterface/Models/Breakpoint.js:
(WebInspector.Breakpoint.prototype.clearActions):
Missing return in named function expression.
- 8:03 PM FeatureFlags edited by
- Added some flag details and links to spec. This is following Eric … (diff)
- 7:42 PM Changeset in webkit [192407] by
-
- 2 edits in tags/Safari-602.1.11.1/Source/WebCore
Merged r192405. rdar://problem/23529113
- 7:41 PM Changeset in webkit [192406] by
-
- 2 edits in tags/Safari-602.1.11.1/Source/WebCore
Merged r192404. rdar://problem/23529113
- 7:37 PM Changeset in webkit [192405] by
-
- 2 edits in trunk/Source/WebCore
Follow up to the previous change
- platform/spi/cocoa/QuartzCoreSPI.h:
Somehow this escaped.
- 7:35 PM Changeset in webkit [192404] by
-
- 2 edits in trunk/Source/WebCore
Try to fix the Watch/TV build
- platform/spi/cocoa/QuartzCoreSPI.h:
Be more accurate about where we need these.
- 7:32 PM Changeset in webkit [192403] by
-
- 5 edits in tags/Safari-602.1.11.1/Source
Versioning.
- 7:30 PM Changeset in webkit [192402] by
-
- 1 copy in tags/Safari-602.1.11.1
New tag.
- 6:53 PM Changeset in webkit [192401] by
-
- 2 edits in trunk/Source/JavaScriptCore
Restore CodeBlock jettison code I accidentally removed
https://bugs.webkit.org/show_bug.cgi?id=151241
Reviewed by Andreas Kling.
I meant to add this back in <http://trac.webkit.org/changeset/190827>
but I missed.
- bytecode/CodeBlock.cpp:
(JSC::timeToLive):
(JSC::CodeBlock::shouldJettisonDueToOldAge):
- 5:43 PM November 2015 Meeting edited by
- (diff)
- 5:30 PM Changeset in webkit [192400] by
-
- 15 edits in trunk/Source/JavaScriptCore
B3 should be able to compile programs with CheckAdd, CheckSub, and CheckMul
https://bugs.webkit.org/show_bug.cgi?id=151213
Reviewed by Benjamin Poulain.
This adds lowering code for CheckAdd, CheckSub, and CheckMul along with support for CheckNeg
(i.e. CheckSub with the left child being zero).
This adds tests for these things, by simulating what JS would do: if there is overflow, revert
to double math. To write the test, I needed support for IToD so I added that support.
This also fixes a memory corruption bug in the register allocator.
Also fixes a bug in opcode_generator.rb where we were emitting stray "return" statements inside
switch statements. I think this was benign, but I'm not sure, so I fixed it.
Note that I had to convert CheckMul handling to always use a three-operand form. That's because
there is no other way to tell Air that we need the original value alive. This means that on X86
we'll emit an extra Move just before the checked mul. That's probably fine since that's
necessary anyway.
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::branchMul64):
(JSC::MacroAssemblerX86_64::branchSub64):
- b3/B3CheckSpecial.cpp:
(JSC::B3::CheckSpecial::generate):
- b3/B3Const32Value.cpp:
(JSC::B3::Const32Value::mulConstant):
(JSC::B3::Const32Value::checkAddConstant):
(JSC::B3::Const32Value::checkSubConstant):
(JSC::B3::Const32Value::checkMulConstant):
(JSC::B3::Const32Value::divConstant):
- b3/B3Const32Value.h:
- b3/B3Const64Value.cpp:
(JSC::B3::Const64Value::mulConstant):
(JSC::B3::Const64Value::checkAddConstant):
(JSC::B3::Const64Value::checkSubConstant):
(JSC::B3::Const64Value::checkMulConstant):
(JSC::B3::Const64Value::divConstant):
- b3/B3Const64Value.h:
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::appendUnOp):
(JSC::B3::Air::LowerToAir::ensureSpecial):
(JSC::B3::Air::LowerToAir::ensureCheckSpecial):
(JSC::B3::Air::LowerToAir::fillStackmap):
(JSC::B3::Air::LowerToAir::lower):
- b3/B3ReduceStrength.cpp:
- b3/B3Value.cpp:
(JSC::B3::Value::mulConstant):
(JSC::B3::Value::checkAddConstant):
(JSC::B3::Value::checkSubConstant):
(JSC::B3::Value::checkMulConstant):
(JSC::B3::Value::divConstant):
- b3/B3Value.h:
- b3/air/AirIteratedRegisterCoalescing.cpp:
(JSC::B3::Air::iteratedRegisterCoalescing):
- b3/air/AirOpcode.opcodes:
- b3/air/opcode_generator.rb:
- b3/testb3.cpp:
(JSC::B3::testCheckMegaCombo):
(JSC::B3::testCheckAddImm):
(JSC::B3::testCheckAdd):
(JSC::B3::testCheckAdd64):
(JSC::B3::testCheckAddFold):
(JSC::B3::testCheckAddFoldFail):
(JSC::B3::testCheckSubImm):
(JSC::B3::testCheckSub):
(JSC::B3::doubleSub):
(JSC::B3::testCheckSub64):
(JSC::B3::testCheckSubFold):
(JSC::B3::testCheckSubFoldFail):
(JSC::B3::testCheckNeg):
(JSC::B3::testCheckNeg64):
(JSC::B3::testCheckMul):
(JSC::B3::testCheckMul64):
(JSC::B3::testCheckMulFold):
(JSC::B3::testCheckMulFoldFail):
(JSC::B3::genericTestCompare):
(JSC::B3::run):
- 5:04 PM CommitQueue edited by
- Update and clarify who can set the commit-queue flag on a bug. (diff)
- 5:00 PM Changeset in webkit [192399] by
-
- 2 edits in trunk/Tools
Add my apple.com email address to contributors.json
- Scripts/webkitpy/common/config/contributors.json:
- 4:54 PM Changeset in webkit [192398] by
-
- 2 edits in trunk/Tools
webkitpy: Remove extraneous word "the" from the description of command attach-to-bug
- Scripts/webkitpy/tool/commands/upload.py:
(AttachToBug):
- 4:49 PM Changeset in webkit [192397] by
-
- 6 edits in trunk/Source/WebKit2
Add a context menu delegate method that takes a userInfo parameter
https://bugs.webkit.org/show_bug.cgi?id=151232
Reviewed by Tim Horton.
- UIProcess/API/APIContextMenuClient.h:
(API::ContextMenuClient::menuFromProposedMenu):
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
- UIProcess/Cocoa/UIDelegate.h:
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::ContextMenuClient::menuFromProposedMenu):
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::WebContextMenuProxyMac::showContextMenu):
- 4:24 PM Changeset in webkit [192396] by
-
- 50 edits6 adds in trunk
Modern IDB: Pipe through cursor functions from client to server.
https://bugs.webkit.org/show_bug.cgi?id=151197
Reviewed by Alex Christensen.
Source/WebCore:
Tests: storage/indexeddb/modern/cursor-1.html
storage/indexeddb/modern/opencursor-failures.html
This patch implements most IDBCursor considerations at the IDL level, as well as pipes the
appropriate messages through from client to server.
All operations currently end in errors. Bug 151196 will fix that by making cursors functional.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/IDBCursor.h:
(WebCore::IDBCursor::isKeyCursor): Deleted.
- Modules/indexeddb/IDBCursorWithValue.h:
- Modules/indexeddb/IDBGetResult.h:
- Modules/indexeddb/IDBKeyData.h:
(WebCore::IDBKeyData::string):
(WebCore::IDBKeyData::date):
(WebCore::IDBKeyData::number):
(WebCore::IDBKeyData::array):
- Modules/indexeddb/IndexedDB.h:
- Modules/indexeddb/client/IDBAnyImpl.cpp:
(WebCore::IDBClient::IDBAny::IDBAny):
(WebCore::IDBClient::IDBAny::idbCursor):
(WebCore::IDBClient::IDBAny::idbCursorWithValue):
(WebCore::IDBClient::IDBAny::idbIndex):
(WebCore::IDBClient::IDBAny::idbObjectStore):
(WebCore::IDBClient::IDBAny::modernIDBCursor):
- Modules/indexeddb/client/IDBAnyImpl.h:
(WebCore::IDBClient::IDBAny::create):
- Modules/indexeddb/client/IDBConnectionToServer.cpp:
(WebCore::IDBClient::IDBConnectionToServer::openCursor):
(WebCore::IDBClient::IDBConnectionToServer::didOpenCursor):
(WebCore::IDBClient::IDBConnectionToServer::iterateCursor):
(WebCore::IDBClient::IDBConnectionToServer::didIterateCursor):
- Modules/indexeddb/client/IDBConnectionToServer.h:
- Modules/indexeddb/client/IDBConnectionToServerDelegate.h:
- Modules/indexeddb/client/IDBCursorImpl.cpp:
(WebCore::IDBClient::IDBCursor::create):
(WebCore::IDBClient::IDBCursor::IDBCursor):
(WebCore::IDBClient::IDBCursor::sourcesDeleted):
(WebCore::IDBClient::IDBCursor::effectiveObjectStore):
(WebCore::IDBClient::IDBCursor::transaction):
(WebCore::IDBClient::IDBCursor::direction):
(WebCore::IDBClient::IDBCursor::key):
(WebCore::IDBClient::IDBCursor::primaryKey):
(WebCore::IDBClient::IDBCursor::value):
(WebCore::IDBClient::IDBCursor::source):
(WebCore::IDBClient::IDBCursor::update):
(WebCore::IDBClient::IDBCursor::advance):
(WebCore::IDBClient::IDBCursor::continueFunction):
(WebCore::IDBClient::IDBCursor::uncheckedIteratorCursor):
(WebCore::IDBClient::IDBCursor::deleteFunction):
(WebCore::IDBClient::IDBCursor::setGetResult):
- Modules/indexeddb/client/IDBCursorImpl.h:
(WebCore::IDBClient::IDBCursor::info):
(WebCore::IDBClient::IDBCursor::setRequest):
(WebCore::IDBClient::IDBCursor::clearRequest):
(WebCore::IDBClient::IDBCursor::request):
- Modules/indexeddb/client/IDBCursorWithValueImpl.cpp:
(WebCore::IDBClient::IDBCursorWithValue::create):
(WebCore::IDBClient::IDBCursorWithValue::IDBCursorWithValue):
(WebCore::IDBClient::IDBCursorWithValue::~IDBCursorWithValue):
- Modules/indexeddb/client/IDBCursorWithValueImpl.h:
- Modules/indexeddb/client/IDBIndexImpl.cpp:
(WebCore::IDBClient::IDBIndex::openCursor):
(WebCore::IDBClient::IDBIndex::openKeyCursor):
- Modules/indexeddb/client/IDBIndexImpl.h:
(WebCore::IDBClient::IDBIndex::modernObjectStore):
(WebCore::IDBClient::IDBIndex::isDeleted):
- Modules/indexeddb/client/IDBObjectStoreImpl.cpp:
(WebCore::IDBClient::IDBObjectStore::openCursor):
(WebCore::IDBClient::IDBObjectStore::deleteFunction):
- Modules/indexeddb/client/IDBObjectStoreImpl.h:
- Modules/indexeddb/client/IDBRequestImpl.cpp:
(WebCore::IDBClient::IDBRequest::create):
(WebCore::IDBClient::IDBRequest::IDBRequest):
(WebCore::IDBClient::IDBRequest::~IDBRequest):
(WebCore::IDBClient::IDBRequest::source):
(WebCore::IDBClient::IDBRequest::resultCursor):
(WebCore::IDBClient::IDBRequest::willIterateCursor):
(WebCore::IDBClient::IDBRequest::didOpenOrIterateCursor):
(WebCore::IDBClient::IDBRequest::requestCompleted):
- Modules/indexeddb/client/IDBRequestImpl.h:
(WebCore::IDBClient::IDBRequest::modernResult):
- Modules/indexeddb/client/IDBTransactionImpl.cpp:
(WebCore::IDBClient::IDBTransaction::requestOpenCursor):
(WebCore::IDBClient::IDBTransaction::doRequestOpenCursor):
(WebCore::IDBClient::IDBTransaction::openCursorOnServer):
(WebCore::IDBClient::IDBTransaction::didOpenCursorOnServer):
(WebCore::IDBClient::IDBTransaction::iterateCursor):
(WebCore::IDBClient::IDBTransaction::iterateCursorOnServer):
(WebCore::IDBClient::IDBTransaction::didIterateCursorOnServer):
- Modules/indexeddb/client/IDBTransactionImpl.h:
- Modules/indexeddb/client/TransactionOperation.h:
(WebCore::IDBClient::createTransactionOperation):
- Modules/indexeddb/legacy/LegacyCursor.cpp:
(WebCore::LegacyCursor::source):
- Modules/indexeddb/legacy/LegacyCursor.h:
(WebCore::LegacyCursor::continueFunction): Deleted.
(WebCore::LegacyCursor::isKeyCursor): Deleted.
- Modules/indexeddb/legacy/LegacyCursorWithValue.h:
- Modules/indexeddb/server/IDBBackingStore.h:
- Modules/indexeddb/server/IDBConnectionToClient.cpp:
(WebCore::IDBServer::IDBConnectionToClient::didOpenCursor):
(WebCore::IDBServer::IDBConnectionToClient::didIterateCursor):
- Modules/indexeddb/server/IDBConnectionToClient.h:
- Modules/indexeddb/server/IDBConnectionToClientDelegate.h:
- Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::openCursor):
(WebCore::IDBServer::IDBServer::iterateCursor):
- Modules/indexeddb/server/IDBServer.h:
- Modules/indexeddb/server/MemoryIDBBackingStore.cpp:
(WebCore::IDBServer::MemoryIDBBackingStore::openCursor):
(WebCore::IDBServer::MemoryIDBBackingStore::iterateCursor):
- Modules/indexeddb/server/MemoryIDBBackingStore.h:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::openCursor):
(WebCore::IDBServer::UniqueIDBDatabase::performOpenCursor):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformOpenCursor):
(WebCore::IDBServer::UniqueIDBDatabase::iterateCursor):
(WebCore::IDBServer::UniqueIDBDatabase::performIterateCursor):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformIterateCursor):
- Modules/indexeddb/server/UniqueIDBDatabase.h:
- Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::deleteRecord):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::openCursor):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::iterateCursor):
- Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h:
- Modules/indexeddb/shared/IDBCursorInfo.cpp: Added.
(WebCore::IDBCursorInfo::objectStoreCursor):
(WebCore::IDBCursorInfo::indexCursor):
(WebCore::IDBCursorInfo::IDBCursorInfo):
(WebCore::IDBCursorInfo::isDirectionForward):
(WebCore::IDBCursorInfo::isolatedCopy):
- Modules/indexeddb/shared/IDBCursorInfo.h: Added.
(WebCore::IDBCursorInfo::identifier):
(WebCore::IDBCursorInfo::sourceIdentifier):
(WebCore::IDBCursorInfo::cursorSource):
(WebCore::IDBCursorInfo::cursorDirection):
(WebCore::IDBCursorInfo::cursorType):
- Modules/indexeddb/shared/IDBResultData.cpp:
(WebCore::IDBResultData::openCursorSuccess):
(WebCore::IDBResultData::iterateCursorSuccess):
- Modules/indexeddb/shared/IDBResultData.h:
- Modules/indexeddb/shared/InProcessIDBServer.cpp:
(WebCore::InProcessIDBServer::didOpenCursor):
(WebCore::InProcessIDBServer::didIterateCursor):
(WebCore::InProcessIDBServer::openCursor):
(WebCore::InProcessIDBServer::iterateCursor):
- Modules/indexeddb/shared/InProcessIDBServer.h:
- bindings/js/IDBBindingUtilities.cpp:
(WebCore::idbKeyDataToJSValue):
- bindings/js/IDBBindingUtilities.h:
- platform/CrossThreadCopier.cpp:
(WebCore::IDBCursorInfo>::copy):
- platform/CrossThreadCopier.h:
LayoutTests:
- storage/indexeddb/modern/cursor-1-expected.txt: Added.
- storage/indexeddb/modern/cursor-1.html: Added.
- storage/indexeddb/modern/opencursor-failures-expected.txt: Added.
- storage/indexeddb/modern/opencursor-failures.html: Added.
- 4:23 PM WebComponents2015 created by
- 4:22 PM November 2015 Meeting edited by
- (diff)
- 4:21 PM Changeset in webkit [192395] by
-
- 4 edits in trunk/Tools
[Win] webkitpy is applying abspath to DOS paths, yielding invalid paths
https://bugs.webkit.org/show_bug.cgi?id=151156
Reviewed by Anders Carlsson.
My earlier patch was incomplete. There are some Python libraries that want
to receive UNIX style paths, even though all of our applications and tools
use DOS paths. To handle this special case, we need to track a UNIX-style
absolute path that can be given to things like the Python socket server.
When we cut over to all-native Windows Python we can get rid of this
special case code.
- Scripts/webkitpy/common/system/filesystem.py:
(FileSystem.abspath): Add special code for Cygwin to convert a DOS-style
path into something Cygwin can use internally.
- Scripts/webkitpy/port/base.py:
(Port.results_directory): Remove custom Windows code. Instead, override
the method in the windows port object.
(Port.abs_results_directory): Add stub.
(Port.to.start_websocket_server): For Cygwin, use special cygwin absolute
path.
- Scripts/webkitpy/port/win.py:
(WinPort.init): Added to initialze new _abs_results_directory value.
(WinPort.abs_results_directory): Added,
(WinPort.results_directory): Modified to also create a value for
_abs_results_directory
- 4:15 PM Changeset in webkit [192394] by
-
- 7 edits1 delete in trunk/Source/WebCore
Delete PlatformMenuDescription.h
https://bugs.webkit.org/show_bug.cgi?id=151229
Reviewed by Beth Dakin.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- page/ContextMenuClient.h:
- platform/ContextMenu.h:
- platform/ContextMenuItem.h:
- platform/PlatformMenuDescription.h: Removed.
- 3:55 PM Changeset in webkit [192393] by
-
- 8 edits in trunk/Source
ContextMenuAction and WebMenuItemTag shouldn't have to be in sync
https://bugs.webkit.org/show_bug.cgi?id=151226
Reviewed by Tim Horton.
Source/WebCore:
- page/ContextMenuController.cpp:
- platform/ContextMenuItem.h:
Remove now unneeded comments. Also, remove ContextMenuItemTagOpenLinkInThisWindow since it wasn't used by any of our remaining ports.
Source/WebKit/mac:
- WebView/WebHTMLView.mm:
(toAction):
(toTag):
Add conversion functions.
(-[WebMenuTarget forwardContextMenuAction:]):
Use toAction.
(createMenuItem):
Use toTag.
(setMenuItemTarget): Deleted.
(setMenuTargets): Deleted.
(-[WebHTMLView menuForEvent:]):
Don't call setMenuTargets, that's already done when we create the menu items.
- WebView/WebUIDelegatePrivate.h:
Add missing menu item tags. This does break ABI, but the menu item tags were already out of sync
so it's very likely that nobody is relying on this.
Source/WebKit2:
- Shared/API/c/WKSharedAPICast.h:
(WebKit::toAPI):
(WebKit::toImpl):
Remove ContextMenuItemTagOpenLinkInThisWindow.
- 3:50 PM Changeset in webkit [192392] by
-
- 3 edits in trunk/LayoutTests
Layout Test js/regress/ftl-object-sub.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=150730
Reviewed by Benjamin Poulain.
Shorten test time by 10x. Looks like we don't need it to run that long
after all. This should fix the timeouts. Also undid the test expectations.
- TestExpectations:
- js/regress/script-tests/ftl-object-sub.js:
(foo):
- 3:27 PM Changeset in webkit [192391] by
-
- 2 edits in trunk/Source/JavaScriptCore
Web Inspector: Reduce list of saved console messages
https://bugs.webkit.org/show_bug.cgi?id=151225
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-11-12
Reviewed by Geoffrey Garen.
Inspector saves messages so that when an inspector frontend opens it can report
these messages to the frontend. However we were saving a rather large list of
1000 messages. Most pages do not produce a large number of console messages.
However pages that live for a long time can generate many errors over time,
especially periodic engine issues such as cross-origin access errors. This could
result in a lot of wasted memory for console messages that may never be used.
Likewise when an inspector first open sending all 1000 messages to the frontend
results in a poor experience.
Lets reduce the list of saved messages. Developer will still be able to see
all messages as long as they have Web Inspector open at the time the messages
are generated.
- inspector/agents/InspectorConsoleAgent.cpp:
Reduce the list from 1000 to 100. Also, when expiring
messages from this list, chunk in 10s instead of 100s.
- 3:12 PM Changeset in webkit [192390] by
-
- 2 edits in trunk/Source/JavaScriptCore
Adjust timeout values in ExecutionTimeLimitTest.
https://bugs.webkit.org/show_bug.cgi?id=151223
Reviewed by Geoffrey Garen.
Some bots were not happy with the existing time out values. I adjusted them to give
the system a little more time to fire the timer events, and this made the bots happy.
- API/tests/ExecutionTimeLimitTest.cpp:
(testExecutionTimeLimit):
- 2:12 PM Changeset in webkit [192389] by
-
- 4 edits2 adds in trunk
Ignore visited background color when deciding if the input renderer needs to be painted natively.
https://bugs.webkit.org/show_bug.cgi?id=151211
rdar://problem/21449823
Reviewed by Antti Koivisto.
Source/WebCore:
Test: fast/css/pseudo-visited-background-color-on-input.html
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isControlStyled):
- rendering/style/RenderStyle.h:
LayoutTests:
- fast/css/pseudo-visited-background-color-on-input-expected.html: Added.
- fast/css/pseudo-visited-background-color-on-input.html: Added.
- 2:07 PM Changeset in webkit [192388] by
-
- 3 edits3 adds in trunk
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>
Reviewed by Myles Maxfield.
Source/WebCore:
Added fast/text/text-combine-shrink-on-color-change.html
- rendering/RenderCombineText.cpp:
(WebCore::RenderCombineText::styleDidChange):
LayoutTests:
- fast/text/text-combine-shrink-on-color-change.html: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
- platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.
- 2:06 PM FiveYearPlanFall2015 edited by
- (diff)
- 2:05 PM Changeset in webkit [192387] by
-
- 4 edits in trunk/Source/WebCore
Use ContextMenuItemTagNoAction instead of ContextMenuItemCustomTagNoAction
https://bugs.webkit.org/show_bug.cgi?id=151222
Reviewed by Joseph Pecoraro.
- bindings/js/JSInspectorFrontendHostCustom.cpp:
(WebCore::populateContextMenuItems):
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::checkOrEnableIfNeeded): Deleted.
- platform/ContextMenuItem.h:
- 2:00 PM GTKSecurity2015 edited by
- (diff)
- 1:57 PM Changeset in webkit [192386] by
-
- 2 edits in trunk/Source/WebKit/mac
Fix build.
- WebView/WebHTMLView.mm:
(fixMenusReceivedFromOldClients):
- 1:55 PM Changeset in webkit [192385] by
-
- 2 edits in trunk/Tools
Unreviewed, add Michael Saboff to the JavaScriptCore watchlist, per request.
- Scripts/webkitpy/common/config/watchlist:
- 1:47 PM Changeset in webkit [192384] by
-
- 3 edits in trunk/Source/WebKit/mac
Remove a couple of unused menu item tag enums
https://bugs.webkit.org/show_bug.cgi?id=151220
Reviewed by Sam Weinig.
Also, move the old internal tags away from the SPI header.
- WebView/WebHTMLView.mm:
(fixMenusReceivedFromOldClients):
- WebView/WebUIDelegatePrivate.h:
- 1:40 PM Changeset in webkit [192383] by
-
- 7 edits in trunk/Source/WebInspectorUI
Web Inspector: Auto-log inspect node selected elements to the console
https://bugs.webkit.org/show_bug.cgi?id=151178
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-11-12
Reviewed by Brian Burg.
Auto-logging user selected elements to the console helps with
quick use in the console. $0 is not very discoverable, and $n
values are expendable. This also makes it convenient to use the
inspect node toolbar search option to select a few different
nodes and use each of them in the console without extra work.
- UserInterface/Controllers/DOMTreeManager.js:
(WebInspector.DOMTreeManager.prototype.inspectNodeObject.nodeAvailable):
(WebInspector.DOMTreeManager.prototype.inspectNodeObject):
Log selected nodes to the console. Treat this as a synthetic log that
will not immediately open the console like normal evaluation results.
- UserInterface/Controllers/JavaScriptLogViewController.js:
(WebInspector.JavaScriptLogViewController.prototype.appendImmediateExecutionWithResult.saveResultCallback):
(WebInspector.JavaScriptLogViewController.prototype.appendImmediateExecutionWithResult):
(WebInspector.JavaScriptLogViewController.prototype.consolePromptTextCommitted.printResult):
(WebInspector.JavaScriptLogViewController.prototype.consolePromptTextCommitted):
Initialize ConsoleCommandResultMessage's synthetic properties.
- UserInterface/Views/DOMTreeOutline.js:
(WebInspector.DOMTreeOutline.prototype._populateContextMenu.logElement):
(WebInspector.DOMTreeOutline.prototype._populateContextMenu):
- UserInterface/Controllers/RuntimeManager.js:
Create a global for the special "console" object group used in multiple places.
- UserInterface/Models/ConsoleCommandResultMessage.js:
(WebInspector.ConsoleCommandResultMessage):
(WebInspector.ConsoleCommandResultMessage.prototype.get synthetic):
Add a synthetic property.
- UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView.prototype.didAppendConsoleMessageView):
When the ConsoleResult is a synthetic result, do not auto-open the console.
- 1:29 PM Changeset in webkit [192382] by
-
- 2 edits in trunk/Source/WebCore
[Cocoa] Font fallback is not language-sensitive
https://bugs.webkit.org/show_bug.cgi?id=147390
Reviewed by Dean Jackson.
Test: fast/text/fallback-language-han-2.html
- platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontCache::systemFallbackForCharacters):
- 1:22 PM Changeset in webkit [192381] by
-
- 11 edits in trunk/Source
ContextMenuController::contextMenuItemSelected only needs the action and title, not the full item
https://bugs.webkit.org/show_bug.cgi?id=151217
Reviewed by Joseph Pecoraro.
Source/WebCore:
- inspector/InspectorFrontendHost.cpp:
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
- page/ContextMenuController.h:
- page/ContextMenuProvider.h:
Source/WebKit/mac:
- WebView/WebHTMLView.mm:
(-[WebMenuTarget forwardContextMenuAction:]):
Source/WebKit/win:
- WebView.cpp:
(WebView::onMenuCommand):
Source/WebKit2:
- WebProcess/WebPage/WebContextMenu.cpp:
(WebKit::WebContextMenu::itemSelected):
- 1:21 PM Changeset in webkit [192380] by
-
- 2 edits in trunk/LayoutTests
Marking storage/indexeddb/modern/idbindex-properties-basic.html as flaky on mac-wk1
https://bugs.webkit.org/show_bug.cgi?id=151219
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 1:19 PM Changeset in webkit [192379] by
-
- 2 edits in trunk/Tools
Unreviewed, add watchlist for Source/JavaScriptCore and add myself, Saam, and Mark.
- Scripts/webkitpy/common/config/watchlist:
- 1:05 PM GTKSecurity2015 created by
- 1:05 PM November 2015 Meeting edited by
- (diff)
- 1:02 PM Changeset in webkit [192378] by
-
- 13 edits in trunk/Source
Remove an unused function
https://bugs.webkit.org/show_bug.cgi?id=151215
Reviewed by Joseph Pecoraro.
Source/WebCore:
- loader/EmptyClients.h:
- page/ContextMenuClient.h:
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected): Deleted.
Source/WebKit/mac:
- WebCoreSupport/WebContextMenuClient.h:
- WebCoreSupport/WebContextMenuClient.mm:
(WebContextMenuClient::contextMenuItemSelected): Deleted.
Source/WebKit/win:
- WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::contextMenuItemSelected): Deleted.
- WebCoreSupport/WebContextMenuClient.h:
Source/WebKit2:
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::contextMenuItemSelected): Deleted.
- WebProcess/WebCoreSupport/WebContextMenuClient.h:
- 12:59 PM FiveYearPlanFall2015 edited by
- (diff)
- 12:47 PM FiveYearPlanFall2015 edited by
- (diff)
- 12:46 PM FiveYearPlanFall2015 edited by
- (diff)
- 12:46 PM FiveYearPlanFall2015 created by
- 12:43 PM November 2015 Meeting edited by
- (diff)
- 12:41 PM Changeset in webkit [192377] by
-
- 5 edits in trunk/Source/JavaScriptCore
B3 should be able to compile Patchpoints with Register and Any constraints
https://bugs.webkit.org/show_bug.cgi?id=151209
Reviewed by Geoffrey Garen.
Most of this patch is about adding tests, since Register constraints already worked but
were untested, and almost all forms of the Any constraint worked.
One change that I'm making is that Patchpoints now default to forCall effects rather
than no effects. I think this is better because if a client of Patchpoint never supplies
any effects, it's best to assume the worst.
My testing uncovered only one real bug: moveConstants() would turn all non-zero double
constants into Loads, so the optimization to fold constants into a Stackmap would stop
working. Instead of telling the Stackmap that the double value it wanted is actually a
constant, we would tell it that it's a register and it would emit code to materialize
the double into that register. I worked around this by having moveConstants() create
ConstDoubleValue's just for the Stackmaps, which lowerToAir() recognizes and does the
right thing with (i.e. folds into the stackmap instead of materializing).
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::fillStackmap):
(JSC::B3::Air::LowerToAir::lower):
- b3/B3MoveConstants.cpp:
- b3/B3PatchpointValue.cpp:
(JSC::B3::PatchpointValue::PatchpointValue):
- b3/testb3.cpp:
(JSC::B3::testPatchpointCallArg):
(JSC::B3::testPatchpointFixedRegister):
(JSC::B3::testPatchpointAny):
(JSC::B3::testPatchpointAnyImm):
(JSC::B3::testPatchpointManyImms):
(JSC::B3::testSimpleCheck):
(JSC::B3::run):
- 12:08 PM EncouragingOpenSourceContributionsFall2015 created by
- 12:06 PM November 2015 Meeting edited by
- (diff)
- 12:06 PM Changeset in webkit [192376] by
-
- 17 edits2 deletes in trunk
Enable cross-platform context menus by default
https://bugs.webkit.org/show_bug.cgi?id=151173
Reviewed by Tim Horton.
.:
- Source/cmake/OptionsEfl.cmake:
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSInspectorFrontendHostCustom.cpp:
(WebCore::JSInspectorFrontendHost::showContextMenu):
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::addInspectElementItem): Deleted.
- platform/ContextMenu.cpp:
- platform/ContextMenu.h:
- platform/ContextMenuItem.cpp:
- platform/ContextMenuItem.h:
(WebCore::ContextMenuItem::isNull): Deleted.
- platform/mac/ContextMenuItemMac.mm: Removed.
(WebCore::menuToArray): Deleted.
(WebCore::ContextMenuItem::ContextMenuItem): Deleted.
(WebCore::createPlatformMenuItemDescription): Deleted.
(WebCore::ContextMenuItem::~ContextMenuItem): Deleted.
(WebCore::ContextMenuItem::platformDescription): Deleted.
(WebCore::ContextMenuItem::type): Deleted.
(WebCore::ContextMenuItem::action): Deleted.
(WebCore::ContextMenuItem::title): Deleted.
(WebCore::ContextMenuItem::platformSubMenu): Deleted.
(WebCore::ContextMenuItem::setType): Deleted.
(WebCore::ContextMenuItem::setAction): Deleted.
(WebCore::ContextMenuItem::setTitle): Deleted.
(WebCore::ContextMenuItem::setSubMenu): Deleted.
(WebCore::ContextMenuItem::setChecked): Deleted.
(WebCore::ContextMenuItem::setEnabled): Deleted.
(WebCore::ContextMenuItem::enabled): Deleted.
(WebCore::ContextMenuItem::checked): Deleted.
- platform/mac/ContextMenuMac.mm: Removed.
(WebCore::ContextMenu::ContextMenu): Deleted.
(WebCore::ContextMenu::~ContextMenu): Deleted.
(WebCore::ContextMenu::appendItem): Deleted.
(WebCore::ContextMenu::insertItem): Deleted.
(WebCore::ContextMenu::itemCount): Deleted.
(WebCore::ContextMenu::setPlatformDescription): Deleted.
(WebCore::ContextMenu::platformDescription): Deleted.
(WebCore::ContextMenu::releasePlatformDescription): Deleted.
(WebCore::contextMenuItemVector): Deleted.
(WebCore::platformMenuDescription): Deleted.
Source/WebKit/mac:
- WebView/WebHTMLView.mm:
(createMenuItem):
(customMenuFromDefaultItems):
Source/WebKit2:
- Shared/WebContextMenuItemData.cpp:
(WebKit::WebContextMenuItemData::WebContextMenuItemData): Deleted.
- WebProcess/WebPage/WebContextMenu.cpp:
(WebKit::WebContextMenu::menuItemsWithUserData): Deleted.
Source/WTF:
- wtf/Platform.h:
- 12:05 PM November 2015 Meeting edited by
- Added a note for the encouraging open source contribution session (diff)
- 12:02 PM Changeset in webkit [192375] by
-
- 8 edits in trunk/Tools
Support building configuration Production of DumpRenderTree and WebKitTestRunner for iOS
https://bugs.webkit.org/show_bug.cgi?id=151191
Reviewed by Andy Estes.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove hardcoded SKIP_INTALL.
Will override this setting in DumpRenderTree.xcconfig.
- DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: When building for iOS we now
compile source file DumpRenderTreeMain.mm to produce a built product and make the Apple
Internal build system happy. Do not waste time coping OpenType font files (*.otf files)
and skip installation when building for iOS since we are not interested in the build product
and are only building this target to make the Apple Internal build system happy.
- DumpRenderTree/mac/DumpRenderTreeMain.mm:
(main): Added dummy implementation for iOS so that we build an actual command line tool to
make the Apple Internal build system happy.
- WebKitTestRunner/Configurations/Base.xcconfig: Add iOS-specific definition for WEBKIT_UMBRELLA_FRAMEWORKS_DIR.
- WebKitTestRunner/Configurations/DebugRelease.xcconfig: Remove variable WEBKIT_UMBRELLA_FRAMEWORKS_DIR.
- WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Build file WebKitTestRunner/mac/main.mm
on iOS Only to produce a built product and make the Apple Internal build system happy. No need
to define OTHER_LDFLAGS when building this target for iOS as the default linker flags are sufficient.
- WebKitTestRunner/mac/main.mm:
(main): Added dummy implementation for iOS so that we build an actual command line tool to
make the Apple Internal build system happy.
- 12:02 PM Changeset in webkit [192374] by
-
- 2 edits in trunk/Tools
Unreviewed, add watchlist for history/ and add myself.
- Scripts/webkitpy/common/config/watchlist:
- 11:57 AM Changeset in webkit [192373] by
-
- 2 edits in trunk/Tools
Unreviewed, update my watchlists.
- Scripts/webkitpy/common/config/watchlist:
- 11:37 AM Changeset in webkit [192372] by
-
- 7 edits2 adds in trunk
[Cocoa] Font fallback is not language-sensitive
https://bugs.webkit.org/show_bug.cgi?id=147390
Reviewed by Dean Jackson.
Source/WebCore:
This re-applies r190754 in a somewhat more performant way.
Test: fast/text/fallback-language-han-2.html
- platform/graphics/Font.cpp:
(WebCore::CharacterFallbackMapKey::CharacterFallbackMapKey):
(WebCore::CharacterFallbackMapKey::operator==):
(WebCore::CharacterFallbackMapKeyHash::hash):
(WebCore::Font::systemFallbackFontForCharacter):
- platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontCache::systemFallbackForCharacters):
LayoutTests:
This patch adds a mismatch test to make sure a codepoint gets rendered differently given two different langs.
- fast/text/fallback-language-han-2-expected-mismatch.html: Added.
- fast/text/fallback-language-han-2.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- 11:30 AM November 2015 Meeting edited by
- (diff)
- 11:29 AM ColorDiscussionFall2015 created by
- 11:22 AM Changeset in webkit [192371] by
-
- 8 edits in trunk/Tools
Rename webkitdirs::willUseIOS{Device, Simulator}SDKWhenBuilding() to willUseIOS{Device, Simulator}SDK()
https://bugs.webkit.org/show_bug.cgi?id=151207
Rubber-stamped by Alexey Proskuryakov.
The functions webkitdirs::willUseIOS{Device, Simulator}SDKWhenBuilding() are not specific to building
iOS software. We should rename these functions to webkitdirs::willUseIOS{Device, Simulator}SDK() to
convey their general-purpose nature of determining whether we are using the iphoneos or iphonesimulator SDK.
- Scripts/build-jsc:
- Scripts/build-layouttestrelay:
- Scripts/build-webkit:
- Scripts/copy-webkitlibraries-to-product-directory:
- Scripts/run-api-tests:
(runTest):
(prepareEnvironmentForRunningTestTool):
- Scripts/run-javascriptcore-tests:
- Scripts/webkitdirs.pm:
(XcodeOptions):
(willUseIOSDeviceSDK): Formerly named willUseIOSDeviceSDKWhenBuilding.
(willUseIOSSimulatorSDK): Formerly name willUseIOSSimulatorSDKWhenBuilding.
(isIOSWebKit):
(runIOSWebKitApp):
(willUseIOSDeviceSDKWhenBuilding): Deleted.
(willUseIOSSimulatorSDKWhenBuilding): Deleted.
- 11:19 AM Changeset in webkit [192370] by
-
- 3 edits in trunk/Tools
run-api-tests fails to run with public iOS SDK
https://bugs.webkit.org/show_bug.cgi?id=151076
Reviewed by Alexey Proskuryakov.
Use the command line tool simctl as the sim tool was removed from the public iOS 9 SDK.
A side benefit of this change it is sufficient to run the tests without launching Simulator.app
to boot the simulator device beforehand because simctl will boot the device for us.
Additionally, use Perl pragma sigtrap to install signal handlers to catch SIG{HUP, INT, PIPE, TERM}
signals and ultimately run our END block so that we shutdown the simulator device (if applicable).
This makes Control-C terminate the app gracefully.
- Scripts/run-api-tests:
(runTest):
(listAllTests):
(prepareEnvironmentForRunningTestTool): When running for iOS Simulator use setupIOSWebKitEnvironment()
to setup the environment variables for iOS instead of using setupMacWebKitEnvironment(). We also
prefix the name of these environment variables with "SIMCTL_CHILD_" so that simctl sets these environment
variables in the simulator environment.
- Scripts/webkitdirs.pm:
(shutDownIOSSimulatorDevice): Added.
(restartIOSSimulatorDevice): Added.
- 11:18 AM November 2015 Meeting edited by
- Added web inspector discussion notes (diff)
- 11:17 AM WebInspectorDiscussionFall2015 created by
- 10:39 AM Changeset in webkit [192369] by
-
- 4 edits6 adds in trunk
popstate event should be dispatched asynchronously
https://bugs.webkit.org/show_bug.cgi?id=36202
<rdar://problem/7761279>
Based on an original patch by Mihai Parparita <mihaip@chromium.org>.
Reviewed by Brent Fulgham.
Source/WebCore:
Tests: fast/loader/remove-iframe-during-history-navigation-different.html
fast/loader/remove-iframe-during-history-navigation-same.html
fast/loader/stateobjects/popstate-is-asynchronous.html
- dom/Document.cpp:
(WebCore::Document::enqueuePopstateEvent):
Use enqueueWindowEvent().
LayoutTests:
- fast/loader/remove-iframe-during-history-navigation-different-expected.txt: Added.
- fast/loader/remove-iframe-during-history-navigation-different.html: Added.
Imported from Blink.
- fast/loader/remove-iframe-during-history-navigation-same-expected.txt: Added.
- fast/loader/remove-iframe-during-history-navigation-same.html: Added.
Ditto.
- fast/loader/stateobjects/popstate-fires-on-history-traversal.html:
Modified to account for popstate firing asynchronously.
- fast/loader/stateobjects/popstate-is-asynchronous-expected.txt: Added.
- fast/loader/stateobjects/popstate-is-asynchronous.html: Added.
Based on Mihai's original test. Modified to pass in current WebKit.
- 10:21 AM Changeset in webkit [192368] by
-
- 2 edits in trunk/Source/WebCore
Fix build failure due to missing NeverDestroyed.h include after r192169
https://bugs.webkit.org/show_bug.cgi?id=151186
Reviewed by Darin Adler.
- rendering/RenderCombineText.cpp:
- 10:17 AM Changeset in webkit [192367] by
-
- 2 edits in trunk/Source/WebCore
Fix build failure due to missing forward declaration of FontVariantSettings after r191968
https://bugs.webkit.org/show_bug.cgi?id=151185
Reviewed by Myles C. Maxfield.
- css/CSSFontFaceSource.h:
- 10:12 AM Changeset in webkit [192366] by
-
- 3 edits in trunk/Source/JavaScriptCore
Move some prototypes to header files.
https://bugs.webkit.org/show_bug.cgi?id=151194
Reviewed by Michael Saboff.
- assembler/MacroAssemblerPrinter.cpp:
(JSC::printIndent):
- assembler/MacroAssemblerPrinter.h:
(JSC::MacroAssembler::print):
- 10:08 AM b3Discussion2015 edited by
- added newlines (diff)
- 10:07 AM b3Discussion2015 created by
- added b3 discussion notes
- 10:07 AM November 2015 Meeting edited by
- added link to b3 discussion notes, which I'll upload soon (diff)
- 10:03 AM NetworkCleanupDiscussion2015 edited by
- (diff)
- 10:03 AM Changeset in webkit [192365] by
-
- 19 edits4 adds in trunk
[MediaStream] Reflect media stream tracks as HTMLMediaElement tracks
https://bugs.webkit.org/show_bug.cgi?id=151145
Reviewed by Jer Noble.
Source/WebCore:
Test: fast/mediastream/MediaStream-video-element.html
- WebCore.xcodeproj/project.pbxproj: Add new header files.
- html/track/AudioTrack.h: Add comments to clean things up slightly.
- html/track/VideoTrack.h: Ditto.
Create a AudioTrackPrivateMediaStream or VideoTrackPrivateMediaStream for each track in
the MediaStream.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::load): Call updateTracks.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::didAddTrack): Ditto.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::didRemoveTrack): Ditto.
(WebCore::updateTracksOfType): New, template function to update audio or video tracks.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateTracks): New.
- platform/mediastream/AudioTrackPrivateMediaStream.h: Added.
- platform/mediastream/MediaStreamPrivate.cpp:
(WebCore::MediaStreamPrivate::currentFrameImage): Fix a typo, early return if the track is
not active OR there is no active video track.
- platform/mediastream/MediaStreamPrivate.h:
(WebCore::MediaStreamPrivate::activeVideoTrack): Accessor for active video track, if any.
- platform/mediastream/VideoTrackPrivateMediaStream.h: Added.
- platform/mediastream/mac/AVAudioCaptureSource.mm:
(WebCore::AVAudioCaptureSource::updateStates): Set current states.
- platform/mediastream/mac/AVMediaCaptureSource.mm:
(WebCore::AVMediaCaptureSource::states): Set source ID.
(WebCore::AVMediaCaptureSource::capabilities): Set source ID directly.
- platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSource::AVVideoCaptureSource):
(WebCore::AVVideoCaptureSource::updateStates): Set states here instead of in the constructor.
- platform/mock/MockRealtimeMediaSource.cpp:
(WebCore::MockRealtimeMediaSource::capabilities): Set source ID directly.
- platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSource::updateStates): Set source type.
LayoutTests:
- fast/mediastream/MediaStream-video-element-expected.txt: Added.
- fast/mediastream/MediaStream-video-element.html: Added.
- fast/mediastream/resources/getUserMedia-helper.js: Return early on error.
- platform/gtk/TestExpectations: Skip new test.
- platform/ios-simulator/TestExpectations: Ditto.
- platform/mac-wk2/TestExpectations: Ditto.
- platform/win/TestExpectations: Ditto.
- 9:54 AM Changeset in webkit [192364] by
-
- 2 edits in trunk/Source/WebKit2
Fixed the build.
- PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm:
(PluginServiceInitializer):
- 9:02 AM Changeset in webkit [192363] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: timeline event markers are added to overview even when not capturing a timeline recording
https://bugs.webkit.org/show_bug.cgi?id=151166
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-11-12
Reviewed by Timothy Hatcher.
- UserInterface/Models/TimelineRecording.js:
(WebInspector.TimelineRecording.prototype.addEventMarker):
Do not add event markers when not capturing. This would have resulted in more
and more markers showing in the Timeline for page loads when the Timeline was
not active. For example reloading when a non-Timeline tab was active.
- 6:12 AM Changeset in webkit [192362] by
-
- 2 edits in trunk/Tools
[EFL] fix EvasGL configuration error
https://bugs.webkit.org/show_bug.cgi?id=151180
Reviewed by Csaba Osztrogonác.
EvasGL backend and depth, stencil buffer size should be specified before elm_win_add to let EvasGL keep quiet.
Additionally, duplicated elm_config_accel_preference_set() call is eleminated.
- MiniBrowser/efl/main.c:
(window_create):
(elm_main):
- 5:34 AM Changeset in webkit [192361] by
-
- 17 edits in trunk
XHR abort() event firing does not match spec
https://bugs.webkit.org/show_bug.cgi?id=98404
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
- web-platform-tests/XMLHttpRequest/abort-after-receive-expected.txt:
- web-platform-tests/XMLHttpRequest/abort-after-timeout-expected.txt:
- web-platform-tests/XMLHttpRequest/abort-during-upload-expected.txt:
- web-platform-tests/XMLHttpRequest/abort-event-abort-expected.txt:
- web-platform-tests/XMLHttpRequest/abort-event-order-expected.txt:
- web-platform-tests/XMLHttpRequest/xmlhttprequest-timeout-aborted-expected.txt:
- web-platform-tests/XMLHttpRequest/xmlhttprequest-timeout-worker-aborted-expected.txt:
Source/WebCore:
Introducing explicit sendFlag as in the specification.
Previously, sendFlag was computed using !!m_loader.
But this does not work well for loadstart events since sendFlag should be true but m_loader is still null at that time.
Updated abort event firing test according specification.
For instance, compared to previously, the abort event is not fired in DONE state or if sendFlag is not set.
Covered by rebased tests.
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::callReadyStateChangeListener): Compute whether dispatching the load event before calling XHR readystatechange event callback.
(WebCore::XMLHttpRequest::setWithCredentials): Replacing m_loader by m_sendFlag to align with the spec.
(WebCore::XMLHttpRequest::open): Unsetting m_sendFlag..
(WebCore::XMLHttpRequest::initSend): Replacing m_loader by m_sendFlag to align with the spec.
(WebCore::XMLHttpRequest::createRequest): Setting m_sendFlag.
(WebCore::XMLHttpRequest::abort): Checking m_sendFlag and updating code to follow the specification.
(WebCore::XMLHttpRequest::genericError): Unsetting m_sendFlag.
(WebCore::XMLHttpRequest::setRequestHeader): Replacing m_loader by m_sendFlag to align with the spec.
(WebCore::XMLHttpRequest::didFinishLoading): Ditto.
(WebCore::XMLHttpRequest::didReachTimeout): Ditto.
- xml/XMLHttpRequest.h: Added m_sendFlag.
LayoutTests:
Rebasing test expectations.
- fast/events/event-fire-order-expected.txt:
- fast/events/event-fire-order.html: Updated so that it does not expect any event when aborting just after open().
- http/tests/xmlhttprequest/onloadend-event-after-sync-requests.html: Updated to expect load event and not abort event when XHR state is DONE.
- http/tests/xmlhttprequest/upload-onloadend-event-after-sync-requests.html: Ditto.
- platform/gtk/TestExpectations: Removing timeout expectation for imported/w3c/web-platform-tests/XMLHttpRequest/interfaces.html
- 5:19 AM Changeset in webkit [192360] by
-
- 2 edits in trunk/Tools
[EFL] Fix EFL 1.16 with enabled NEON support
https://bugs.webkit.org/show_bug.cgi?id=151188
Unreviewed buildfix, disable NEON temporarily after r192358.
- efl/jhbuild.modules:
- 3:19 AM Changeset in webkit [192359] by
-
- 3 edits in trunk/Source/WebCore
[GStreamer] Use RunLoop::timer in MediaPlayerPrivateGStreamerBase for GL drawing
https://bugs.webkit.org/show_bug.cgi?id=151099
Reviewed by Philippe Normand.
Instead of the GThreadSafeMainLoopSource.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::repaint):
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase): Deleted.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
- 2:50 AM Changeset in webkit [192358] by
-
- 2 edits1 delete in trunk/Tools
[EFL] Bump EFL version to 1.16.0
https://bugs.webkit.org/show_bug.cgi?id=150228
Reviewed by Gyuyoung Kim.
- efl/jhbuild.modules:
- efl/patches/efl-remove-XPrint.patch: Removed.
- 2:31 AM Changeset in webkit [192357] by
-
- 19 edits in trunk
Remove ENABLE(SATURATED_LAYOUT_ARITHMETIC) guards
https://bugs.webkit.org/show_bug.cgi?id=150972
Reviewed by Darin Adler.
.:
- Source/cmake/OptionsMac.cmake:
- Source/cmake/WebKitFeatures.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- platform/LayoutUnit.h:
(WebCore::operator*):
(WebCore::LayoutUnit::LayoutUnit): Deleted.
(WebCore::LayoutUnit::fromFloatCeil): Deleted.
(WebCore::LayoutUnit::fromFloatFloor): Deleted.
(WebCore::LayoutUnit::fromFloatRound): Deleted.
(WebCore::LayoutUnit::ceil): Deleted.
(WebCore::LayoutUnit::round): Deleted.
(WebCore::LayoutUnit::floor): Deleted.
(WebCore::LayoutUnit::setValue): Deleted.
(WebCore::operator/): Deleted.
(WebCore::operator+): Deleted.
(WebCore::operator-): Deleted.
(WebCore::operator+=): Deleted.
(WebCore::operator-=): Deleted.
- rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
- rendering/LayoutState.h:
(WebCore::LayoutState::LayoutState):
- rendering/RenderView.h:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
- 2:20 AM Changeset in webkit [192356] by
-
- 2 edits in trunk/Tools
[EFL] fix EvasGL configuration error
https://bugs.webkit.org/show_bug.cgi?id=151180
Reviewed by Gyuyoung Kim.
EvasGL backend and depth, stencil buffer size should be specified before elm_win_add to let EvasGL keep quiet
- MiniBrowser/efl/main.c:
(window_create):
