⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 14, 2015:

11:56 PM Changeset in webkit [192459] by Gyuyoung Kim
  • 3 edits in trunk/Source/WebCore

[EFL][GTK] Remove use of String::format() in versionForUAString()
​https://bugs.webkit.org/show_bug.cgi?id=151250

Reviewed by Darin Adler.

As String::format() will be deprecated due to the security problem, reimplement
versionForUAString() using a macro.

  • platform/efl/UserAgentEfl.cpp:

(WebCore::versionForUAString):

  • platform/gtk/UserAgentGtk.cpp:

(WebCore::platformVersionForUAString):
(WebCore::versionForUAString):

9:23 PM Changeset in webkit [192458] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Regression(r188820): Downloads of data URLs is broken
​https://bugs.webkit.org/show_bug.cgi?id=150900
rdar://problem/23399223

Reviewed by Darin Adler.

No test, the current test infrastructure only allows testing policy decisions, not the actual download.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::continueAfterContentPolicy):

Use normal download path for data URLs instead of trying to convert the main resource load.
Since we decode data URLs locally there is no associated resource load on WebKit side.

6:40 PM WindowsWithoutCygwin edited by mmaxfield@apple.com
(diff)
5:18 PM WindowsWithoutCygwin edited by mmaxfield@apple.com
(diff)
3:51 PM WindowsWithoutCygwin edited by mmaxfield@apple.com
(diff)
1:13 PM Changeset in webkit [192457] by msaboff@apple.com
  • 3 edits
    3 adds in trunk

REGRESSION (r190370): CrashTracer: [USER] com.apple.WebKit.WebContent at com.apple.JavaScriptCore: JSC::JITCode::execute + 158
​https://bugs.webkit.org/show_bug.cgi?id=151279

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

We need to restore callee saves even when we take the slow path in a polymorphic call stub.
Move the restoration to the top of the stub so that it is done for all paths.

  • jit/Repatch.cpp:

(JSC::linkPolymorphicCall):

LayoutTests:

New regression test.

  • js/regress-151279-expected.txt: Added.
  • js/regress-151279.html: Added.
  • js/script-tests/regress-151279.js: Added.
1:09 PM BuildingQtOnLinux edited by BJ Burg
Add disclaimer about QT not existing any more in WebKit. (diff)
1:39 AM Changeset in webkit [192456] by n_wang@apple.com
  • 11 edits
    2 adds in trunk

AX: add a new trait for elements in fieldset on iOS
​https://bugs.webkit.org/show_bug.cgi?id=151281

Reviewed by Chris Fleizach.

Source/WebCore:

Added a new trait for elements in the fieldset, so VoiceOver can speak the legend
information for those elements.

Test: accessibility/ios-simulator/fieldset-traits.html

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityCanFuzzyHitTest]):
(-[WebAccessibilityObjectWrapper _accessibilityTableAncestor]):
(-[WebAccessibilityObjectWrapper _accessibilityFieldsetAncestor]):
(-[WebAccessibilityObjectWrapper _accessibilityTraitsFromAncestors]):

Tools:

  • DumpRenderTree/AccessibilityUIElement.cpp:

(assistiveTechnologySimulatedFocusCallback):
(fieldsetAncestorElementCallback):
(childAtIndexCallback):
(getElementTextLengthCallback):
(hasContainedByFieldsetTraitCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:
  • DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(AccessibilityUIElement::elementTextLength):
(AccessibilityUIElement::hasContainedByFieldsetTrait):
(AccessibilityUIElement::fieldsetAncestorElement):
(AccessibilityUIElement::url):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::scrollPageDown):
(WTR::AccessibilityUIElement::scrollPageLeft):
(WTR::AccessibilityUIElement::scrollPageRight):
(WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
(WTR::AccessibilityUIElement::fieldsetAncestorElement):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
  • WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:

(WTR::AccessibilityUIElement::identifier):
(WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
(WTR::AccessibilityUIElement::fieldsetAncestorElement):
(WTR::AccessibilityUIElement::rowCount):

LayoutTests:

  • accessibility/ios-simulator/fieldset-traits-expected.txt: Added.
  • accessibility/ios-simulator/fieldset-traits.html: Added.

Nov 13, 2015:

9:51 PM Changeset in webkit [192455] by commit-queue@webkit.org
  • 3 edits in trunk/PerformanceTests

Eliminate a request for layout every time an item is added to the stage of the graphics benchmark
​https://bugs.webkit.org/show_bug.cgi?id=151289

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2015-11-13
Reviewed by Simon Fraser.

Cache the stage size when it is created instead of requesting every time
an object is added via clientWidth and clientHeight.

  • Animometer/resources/extensions.js:

(Insets.elementPadding):

  • Animometer/tests/resources/stage.js:

(Stage):
(Stage.prototype.get size):

8:03 PM Changeset in webkit [192454] by commit-queue@webkit.org
  • 5 edits
    2 deletes in trunk/Source

Unreviewed, rolling out r192445, r192451, and r192452.
​https://bugs.webkit.org/show_bug.cgi?id=151291

Broke Mavericks build (and thus EWS) (Requested by ap on
#webkit).

Reverted changesets:

"Add identifier strings for a bunch of context menu items"
​https://bugs.webkit.org/show_bug.cgi?id=151272
​http://trac.webkit.org/changeset/192445

"Try to fix the 32-bit build"
​http://trac.webkit.org/changeset/192451

"Try to fix the 32-bit build"
​http://trac.webkit.org/changeset/192452

5:18 PM Changeset in webkit [192453] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r192416 and r192443.
​https://bugs.webkit.org/show_bug.cgi?id=151285

Broke 32-bit in some mysterious way I need to understand
(Requested by kling on #webkit).

Reverted changesets:

"[JSC] JSPropertyNameEnumerator could be destructorless."
​https://bugs.webkit.org/show_bug.cgi?id=151242
​http://trac.webkit.org/changeset/192416

"Follow-up for 32-bit test failures after..."
​https://bugs.webkit.org/show_bug.cgi?id=151242
​http://trac.webkit.org/changeset/192443

4:56 PM Changeset in webkit [192452] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix the 32-bit build

  • UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::createShareMenuItem):

4:41 PM Changeset in webkit [192451] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix the 32-bit build

  • UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::menuItemIdentifier):

4:40 PM Changeset in webkit [192450] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r192401.
​https://bugs.webkit.org/show_bug.cgi?id=151282

"caused crashes on animometer" (Requested by thorton on
#webkit).

Reverted changeset:

"Restore CodeBlock jettison code I accidentally removed"
​https://bugs.webkit.org/show_bug.cgi?id=151241
​http://trac.webkit.org/changeset/192401

4:30 PM Changeset in webkit [192449] by keith_miller@apple.com
  • 2 edits in trunk/Tools

Unreviewed, change JavaScriptCore watchlist to exclude inspector things.

  • Scripts/webkitpy/common/config/watchlist:
4:05 PM Changeset in webkit [192448] by Wenson Hsieh
  • 2 edits in trunk/Source/WebKit2

WK2 iOS interaction tests in LayoutTests/fast/events/ios are flaky
​https://bugs.webkit.org/show_bug.cgi?id=151199
<rdar://problem/23518459>

Reviewed by Tim Horton.

While transforming touch positions from document to global coordinates, HIDEventGenerator
sometimes uses an old scale of the webview in computing the transformed position. This happens
in spite of how we force the UI script to run after the UI process receives a layer tree commit
because we invoke the callback before calling WebPageProxy::didCommitLayerTree, which is where
we actually use the layer transaction information to update the WKWebView.

To fix this, we run the drawing-ensured callbacks after committing the layer tree, so the
callbacks will have updated information about the web view's scale and dimensions.

  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):

4:00 PM Changeset in webkit [192447] by timothy_horton@apple.com
  • 7 edits in trunk

Support printing in WKWebView
​https://bugs.webkit.org/show_bug.cgi?id=151276
<rdar://problem/23525715>

Reviewed by Beth Dakin.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _printOperationWithPrintInfo:]):
(-[WKWebView _printOperationWithPrintInfo:forFrame:]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:

Expose SPI similar to what we have on WKView.

  • MiniBrowser/mac/MainMenu.xib:
  • MiniBrowser/mac/WK1BrowserWindowController.m:

(-[WK1BrowserWindowController printWebView:]):

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController printWebView:]):
Hook up printing to Minibrowser!

3:47 PM Changeset in webkit [192446] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebKit2

Follow-up to r192437. Add availability macros.

Reviewed by Tim Horton.

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
3:37 PM Changeset in webkit [192445] by andersca@apple.com
  • 5 edits
    2 adds in trunk/Source

Add identifier strings for a bunch of context menu items
​https://bugs.webkit.org/show_bug.cgi?id=151272

Reviewed by Dan Bernstein.

Source/WebCore:

Have NSMenuItem conform to NSUserInterfaceItemIdentification.

  • platform/spi/mac/NSMenuSPI.h:

Source/WebKit2:

  • UIProcess/API/Cocoa/WKMenuItemIdentifiers.mm: Added.
  • UIProcess/API/Cocoa/WKMenuItemIdentifiersPrivate.h: Added.
  • UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::menuItemIdentifier):
(WebKit::WebContextMenuProxyMac::createShareMenuItem):
(WebKit::WebContextMenuProxyMac::createContextMenuItem):

  • WebKit2.xcodeproj/project.pbxproj:
3:11 PM Changeset in webkit [192444] by Alan Bujtas
  • 12 edits in trunk

Always render at least a device pixel line when border/outline width > 0.
​https://bugs.webkit.org/show_bug.cgi?id=151269

This matches Firefox behaviour.

Reviewed by Simon Fraser.

Source/WebCore:

Existing test is modified to reflect the new behaviour.

  • css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertLineWidth):

  • rendering/BorderEdge.cpp:

(WebCore::BorderEdge::BorderEdge): Deleted.

  • rendering/BorderEdge.h:

LayoutTests:

  • fast/borders/hidpi-border-width-flooring-expected.html:
  • fast/borders/hidpi-border-width-flooring.html:
2:16 PM Changeset in webkit [192443] by akling@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Follow-up for 32-bit test failures after...
[JSC] JSPropertyNameEnumerator could be destructorless.
<​https://webkit.org/b/151242>

Reviewed by Mark Lam

Apparently copied space allocations need to be in multiples of 8 bytes.
Have JSPropertyNameEnumerator do what other copied space clients already do
and round the allocation size up to a multiple of 8.

Added a little helper function to compute the allocation size so this doesn't
have to be repeated everywhere.

  • runtime/JSPropertyNameEnumerator.cpp:

(JSC::JSPropertyNameEnumerator::finishCreation):
(JSC::JSPropertyNameEnumerator::visitChildren):
(JSC::JSPropertyNameEnumerator::copyBackingStore):

  • runtime/JSPropertyNameEnumerator.h:
1:51 PM Changeset in webkit [192442] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.46.60-branch/Source

Versioning.

1:49 PM Changeset in webkit [192441] by peavo@outlook.com
  • 2 edits in trunk/Source/WebCore

[WinCairo][MediaFoundation] Video rendered at wrong position.
​https://bugs.webkit.org/show_bug.cgi?id=151271

Reviewed by Alex Christensen.

The source rectangle used when blitting a frame to the graphics context
should have offset (0, 0).

  • platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:

(WebCore::MediaPlayerPrivateMediaFoundation::Direct3DPresenter::paintCurrentFrame):

1:47 PM Changeset in webkit [192440] by bshafiei@apple.com
  • 1 copy in branches/safari-601.1.46.60-branch

New Branch.

1:36 PM Changeset in webkit [192439] by sbarati@apple.com
  • 10 edits
    1 add in trunk/Source/JavaScriptCore

sub IC does not properly handle exception handling now that try/catch is compiled in the FTL
​https://bugs.webkit.org/show_bug.cgi?id=151080

Reviewed by Geoffrey Garen.

This patch implements proper exception handling for ArithSubs with binaryUseKind as
UntypedUse inside try/catch. We implement this in a very similar way as we implement
exception handling from GetById/PutById/LazySlowPaths callOperation calls. We do the needed
spilling if the result is the same register as the left/right register because in the event
of an exception, we don't want to do value recovery on the garbage result, we
want to do it on the original lhs/rhs of the operation.

This patch also does some refactoring. No longer does OSRExitDescriptor
have a long list of booleans that correspond to different OSR exit types.
It now just has an enum property called ExceptionType that tells us
what type of exception handler the OSR exit is. Then, we can just ask
interesting questions about the OSR exit and get answers based on its
ExceptionType property.

  • ftl/FTLCompile.cpp:

(JSC::FTL::mmAllocateDataSection):

  • ftl/FTLExceptionHandlerManager.cpp:

(JSC::FTL::ExceptionHandlerManager::addNewExit):
(JSC::FTL::ExceptionHandlerManager::callOperationExceptionTarget):
(JSC::FTL::ExceptionHandlerManager::lazySlowPathExceptionTarget):
(JSC::FTL::ExceptionHandlerManager::getByIdOSRExit):
(JSC::FTL::ExceptionHandlerManager::subOSRExit):
(JSC::FTL::ExceptionHandlerManager::getCallOSRExitCommon):
(JSC::FTL::ExceptionHandlerManager::getOrPutByIdCallOperationExceptionTarget): Deleted.

  • ftl/FTLExceptionHandlerManager.h:
  • ftl/FTLExitThunkGenerator.cpp:

(JSC::FTL::ExitThunkGenerator::emitThunk):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::lower):
(JSC::FTL::DFG::LowerDFGToLLVM::compileArithAddOrSub):
(JSC::FTL::DFG::LowerDFGToLLVM::compilePutById):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstruct):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstructVarargs):
(JSC::FTL::DFG::LowerDFGToLLVM::compileInvalidationPoint):
(JSC::FTL::DFG::LowerDFGToLLVM::getById):
(JSC::FTL::DFG::LowerDFGToLLVM::lazySlowPath):
(JSC::FTL::DFG::LowerDFGToLLVM::callCheck):
(JSC::FTL::DFG::LowerDFGToLLVM::appendOSRExitArgumentsForPatchpointIfWillCatchException):
(JSC::FTL::DFG::LowerDFGToLLVM::emitBranchToOSRExitIfWillCatchException):
(JSC::FTL::DFG::LowerDFGToLLVM::lowBlock):
(JSC::FTL::DFG::LowerDFGToLLVM::appendOSRExitDescriptor):
(JSC::FTL::DFG::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::DFG::LowerDFGToLLVM::buildExitArguments):

  • ftl/FTLOSRExit.cpp:

(JSC::FTL::OSRExitDescriptor::OSRExitDescriptor):
(JSC::FTL::OSRExitDescriptor::willArriveAtExitFromIndirectExceptionCheck):
(JSC::FTL::OSRExitDescriptor::mightArriveAtOSRExitFromGenericUnwind):
(JSC::FTL::OSRExitDescriptor::mightArriveAtOSRExitFromCallOperation):
(JSC::FTL::OSRExitDescriptor::needsRegisterRecoveryOnGenericUnwindOSRExitPath):
(JSC::FTL::OSRExitDescriptor::isExceptionHandler):
(JSC::FTL::OSRExitDescriptor::validateReferences):
(JSC::FTL::OSRExit::OSRExit):
(JSC::FTL::OSRExit::codeLocationForRepatch):
(JSC::FTL::OSRExit::gatherRegistersToSpillForCallIfException):
(JSC::FTL::OSRExit::spillRegistersToSpillSlot):
(JSC::FTL::OSRExit::recoverRegistersFromSpillSlot):

  • ftl/FTLOSRExit.h:
  • ftl/FTLOSRExitCompilationInfo.h:

(JSC::FTL::OSRExitCompilationInfo::OSRExitCompilationInfo):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileFTLOSRExit):

  • tests/stress/ftl-try-catch-arith-sub-exception.js: Added.

(assert):
(let.o.valueOf):
(baz):
(foo):
(bar):

1:29 PM Changeset in webkit [192438] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.46.60

New tag.

11:46 AM Changeset in webkit [192437] by Joseph Pecoraro
  • 15 edits in trunk/Source

Web Inspector: Provide a way to override the WKWebView remote inspector name
​https://bugs.webkit.org/show_bug.cgi?id=151075

Reviewed by Tim Horton.

Source/WebCore:

  • page/Page.cpp:

(WebCore::Page::remoteInspectionNameOverride):
(WebCore::Page::setRemoteInspectionNameOverride):

  • page/Page.h:
  • page/PageDebuggable.cpp:

(WebCore::PageDebuggable::name):
(WebCore::PageDebuggable::setNameOverride):

  • page/PageDebuggable.h:

Source/WebKit2:

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _remoteInspectionNameOverride]):
(-[WKWebView _setRemoteInspectionNameOverride:]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setRemoteInspectionNameOverride):
(WebKit::WebPageProxy::creationParameters):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::remoteInspectionNameOverride):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::m_shouldDispatchFakeMouseMoveEvents):
(WebKit::WebPage::setRemoteInspectionNameOverride):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
11:13 AM Changeset in webkit [192436] by commit-queue@webkit.org
  • 10 edits
    3 adds in trunk/Source/JavaScriptCore

Allow any LeftHandSideExpression as a valid AssignmentElement
​https://bugs.webkit.org/show_bug.cgi?id=151026

Patch by Caitlin Potter <​caitpotter88@gmail.com> on 2015-11-13
Reviewed by Geoffrey Garen.

  • bytecompiler/NodesCodegen.cpp:

(JSC::AssignmentElementNode::collectBoundIdentifiers):
(JSC::AssignmentElementNode::bindValue):
(JSC::AssignmentElementNode::toString):

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::isAssignmentLocation):
(JSC::ASTBuilder::createAssignmentElement):

  • parser/NodeConstructors.h:

(JSC::AssignmentElementNode::AssignmentElementNode):

  • parser/Nodes.h:

(JSC::AssignmentElementNode::assignmentTarget):
(JSC::AssignmentElementNode::divotStart):
(JSC::AssignmentElementNode::divotEnd):

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::createAssignmentElement):
(JSC::Parser<LexerType>::parseDestructuringPattern):

  • parser/Parser.h:
  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::operatorStackPop):

11:10 AM Changeset in webkit [192435] by clopez@igalia.com
  • 2 edits in trunk/LayoutTests

[GTK] GTK gardening.

Unreviewed.

  • platform/gtk/TestExpectations: Update the expectation for a renamed

test and mark as failing some of the tests from imported/blink.

10:52 AM Changeset in webkit [192434] by Yusuke Suzuki
  • 2 edits in trunk/Source/JavaScriptCore

op_assert should declare that it uses the first register argument
​https://bugs.webkit.org/show_bug.cgi?id=151183

Reviewed by Geoffrey Garen.

op_assert(conditionRegister, lineNumber) should declare that it
*uses* (in terms of use-def) the first conditionRegister and
it does not define any variables.

  • bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):

10:36 AM Changeset in webkit [192433] by jiewen_tan@apple.com
  • 3 edits
    2 adds in trunk

Element::focus() should acquire the ownership of Frame.
​https://bugs.webkit.org/show_bug.cgi?id=150204
<rdar://problem/23136794>

Reviewed by Brent Fulgham.

Source/WebCore:

The FrameSelection::setSelection method sometimes releases the last reference to a frame.
When this happens, the Element::updateFocusAppearance would attempt to use dereferenced memory.
Instead, we should ensure that the Frame lifetime is guaranteed to extend through the duration
of the method call.

Test: editing/selection/focus-iframe-removal-crash.html

  • dom/Element.cpp:

(WebCore::Element::updateFocusAppearance):

LayoutTests:

  • editing/selection/focus-iframe-removal-crash-expected.txt: Added.
  • editing/selection/focus-iframe-removal-crash.html: Added.
10:11 AM Changeset in webkit [192432] by timothy_horton@apple.com
  • 15 edits
    2 adds in trunk

Hardware keyboard spacebar scrolls too far on iOS
​https://bugs.webkit.org/show_bug.cgi?id=151227
<rdar://problem/23500681>

Reviewed by Simon Fraser.

There were two bugs conspiring here to make spacebar scrolling very wrong on iOS:

1) Incoming key events were being handled twice

  • fix this by only propagating the event to super if we don't end up handling the event ourselves

2) _scrollByOffset was not converting the offset delta out of content coordinates

  • fix this by doing the relevant conversion and renaming the function to make it more clear exactly what it does
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _scrollByContentOffset:]):
(-[WKWebView _scrollByOffset:]): Deleted.

  • UIProcess/API/Cocoa/WKWebViewInternal.h:

Rename to _scrollByContentOffset to make it clear that this is
in content coordinates, and do the conversion from content coordinates
(apply the scale) so that we scroll by the right amount.

  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::doneWithKeyEvent):
Pass whether the event was handled through to WKContentView.

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKWebEvent dealloc]):
Add WKWebEvent, which is a WebEvent and retains a reference to the UIEvent
from which it came.

(-[WKContentView _handleKeyUIEvent:]):
Only pass the event to super immediately if we don't try to handle it.
We'll re-send it to super asynchronously if we decide not to handle it.

(-[WKContentView handleKeyEvent:]):
If we're in the middle of resending an event we didn't handle the first
time, just ignore it.

Make a WKWebEvent and store the UIEvent on it.

(-[WKContentView _didHandleKeyEvent:eventWasHandled:]):
If the event wasn't handled, and is one of our special events with a
wrapped UIEvent, resend it to super. We'll ignore it as noted above.

(-[WKContentView _interpretKeyEvent:isCharEvent:]):
Factor out unobscured content rect retrieval.
Make use of Scrollbar::pageStep to match the Mac behavior of not
scrolling quite a whole page when scrolling with the spacebar.

  • fast/events/ios/keyboard-scrolling-distance-expected.txt: Added.
  • fast/events/ios/keyboard-scrolling-distance.html: Added.

Add a test that records how much we scroll when pressing the spacebar.
The test is at a fixed scale of 1.5 to expose the bug fixed by this patch.

  • WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
  • WebKitTestRunner/UIScriptContext/UIScriptContext.h:
  • WebKitTestRunner/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::setDidEndScrollingCallback):
(WTR::UIScriptController::didEndScrollingCallback):
(WTR::UIScriptController::platformSetDidEndScrollingCallback):

  • WebKitTestRunner/UIScriptContext/UIScriptController.h:
  • WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
  • WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:

(-[TestRunnerWKWebView dealloc]):
(-[TestRunnerWKWebView _didFinishScrolling]):

  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::platformSetDidEndScrollingCallback):
(WTR::UIScriptController::platformClearAllCallbacks):
Expose _didFinishScrolling on WKWebView to the UIScriptController.

10:08 AM Changeset in webkit [192431] by Brent Fulgham
  • 2 edits in trunk/Tools

[Win] Unreviewed test fix.

  • Scripts/webkitpy/port/win.py:

(WinPort.results_directory): Our 'results_directory' should be an absolute path (even when not
using Cygwin), but should be in DOS format for non-Cygwin clients.

9:56 AM Changeset in webkit [192430] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Removing a deleted test from mac-wk2 test expectations.
​https://bugs.webkit.org/show_bug.cgi?id=151103

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
9:03 AM Changeset in webkit [192429] by matthew_hanson@apple.com
  • 8 edits in branches/safari-601.1.46-branch

Merge r192269. rdar://problem/23189742

9:03 AM Changeset in webkit [192428] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-601.1.46-branch

Merge r192120. rdar://problem/23189774

9:03 AM Changeset in webkit [192427] by matthew_hanson@apple.com
  • 7 edits
    2 adds in branches/safari-601.1.46-branch

Merge r192042. rdar://problem/23189765

9:03 AM Changeset in webkit [192426] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merge r191872. rdar://problem/23395972

9:03 AM Changeset in webkit [192425] by matthew_hanson@apple.com
  • 4 edits
    2 adds in branches/safari-601.1.46-branch

Merge r190595. rdar://problem/23432378

9:03 AM Changeset in webkit [192424] by matthew_hanson@apple.com
  • 8 edits
    2 adds in branches/safari-601.1.46-branch

Merge r190446. rdar://problem/23432369

9:03 AM Changeset in webkit [192423] by matthew_hanson@apple.com
  • 79 edits
    2 copies
    1 add in branches/safari-601.1.46-branch

Merge r188647. rdar://problem/23432373

9:03 AM Changeset in webkit [192422] by matthew_hanson@apple.com
  • 18 edits
    4 adds in branches/safari-601.1.46-branch

Merge r188530. rdar://problem/23432371

9:03 AM Changeset in webkit [192421] by matthew_hanson@apple.com
  • 8 edits
    5 adds in branches/safari-601.1.46-branch

Merge r188514. rdar://problem/23432371

9:02 AM Changeset in webkit [192420] by matthew_hanson@apple.com
  • 18 edits
    4 adds in branches/safari-601.1.46-branch

Merge r188512. rdar://problem/23432371

9:02 AM Changeset in webkit [192419] by matthew_hanson@apple.com
  • 7 edits in branches/safari-601.1.46-branch/Source

Merge r190574. rdar://problem/22846841

9:02 AM Changeset in webkit [192418] by matthew_hanson@apple.com
  • 4 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merge r189635. rdar://problem/22846841

9:02 AM Changeset in webkit [192417] by matthew_hanson@apple.com
  • 4 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merge r189628. rdar://problem/22846841

7:59 AM Changeset in webkit [192416] by akling@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

[JSC] JSPropertyNameEnumerator could be destructorless.
<​https://webkit.org/b/151242>

Reviewed by Mark Lam.

Make JSPropertyNameEnumerator destructorless and have it store the property names
cache in CopiedSpace. This was the most popular occupant of 64-byte destructor cells
in MarkedSpace, so making it destructorless gets rid of some ill-filled MarkedBlocks.

  • heap/CopyToken.h:
  • runtime/JSPropertyNameEnumerator.cpp:

(JSC::JSPropertyNameEnumerator::finishCreation):
(JSC::JSPropertyNameEnumerator::visitChildren):
(JSC::JSPropertyNameEnumerator::copyBackingStore):
(JSC::JSPropertyNameEnumerator::destroy): Deleted.

  • runtime/JSPropertyNameEnumerator.h:
5:49 AM WebKitGTK/Gardening/Howto edited by clopez@igalia.com
(diff)
4:50 AM Changeset in webkit [192415] by svillar@igalia.com
  • 3 edits in trunk/LayoutTests

[css-grid] Fix swap-lines-if-start-is-further-endward-than-end-line.html
​https://bugs.webkit.org/show_bug.cgi?id=151257

Reviewed by Mario Sanchez Prada.

I forgot to add a link to resources/grid.css stylesheet when I
added this test so it was not actually testing Grid Layout
code.

  • fast/css-grid-layout/swap-lines-if-start-is-further-endward-than-end-line-expected.html:
  • fast/css-grid-layout/swap-lines-if-start-is-further-endward-than-end-line.html:
4:48 AM Changeset in webkit [192414] by svillar@igalia.com
  • 3 edits in trunk/Source/WebCore

[css-grid] Remove unused GridResolvedPosition constructor
​https://bugs.webkit.org/show_bug.cgi?id=151133

Reviewed by Mario Sanchez Prada.

No new tests required, just deleting dead code.

  • rendering/style/GridResolvedPosition.cpp:

(WebCore::GridResolvedPosition::GridResolvedPosition): Deleted.

  • rendering/style/GridResolvedPosition.h:
3:13 AM Changeset in webkit [192413] by svillar@igalia.com
  • 4 edits
    2 adds in trunk

ASSERTION FAILED: m_isEngaged in WTF::Optional::value
​https://bugs.webkit.org/show_bug.cgi?id=151094

Reviewed by Darin Adler.

Source/WebCore:

That ASSERT was hit because the precondition was incorrectly
met, i.e., we're considering that the main axis length was
definite when it was actually not. The problem is that to
determine whether it was indefinite or not we're using
RenderBox::hasDefiniteLogicalHeight() which did not perfectly
match RenderBox::computePercentageLogicalHeight() for the case
of RenderTables. So computePercentageLogicalHeight() was
returning Nullopt (i.e. indefinite) while
hasDefiniteLogicalHeight() was returning true (so definite).

Some checks were refactored in a helper function to solve the
inconsistency so that both functions behave the same way even
in this particular situation.

Test: css3/flexbox/inline-flex-percentage-height-in-table-crash.html

  • rendering/RenderBox.cpp:

(WebCore::tableCellShouldHaveZeroInitialSize):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::percentageLogicalHeightIsResolvable):
(WebCore::RenderBox::percentageLogicalHeightIsResolvableFromBlock):

  • rendering/RenderBox.h:

LayoutTests:

  • css3/flexbox/inline-flex-percentage-height-in-table-crash-expected.txt: Added.
  • css3/flexbox/inline-flex-percentage-height-in-table-crash.html: Added.
2:47 AM Changeset in webkit [192412] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed, really fix the Mac CMake build after r192376.

  • PlatformMac.cmake:
2:43 AM Changeset in webkit [192411] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix the Mac CMake build after r192376.

  • PlatformMac.cmake:
Note: See TracTimeline for information about the timeline view.