Timeline
Dec 8, 2015:
- 10:45 PM Changeset in webkit [193810] by
-
- 2 edits in trunk/LayoutTests
Skip storage/indexeddb/index-multientry.html once again
- platform/mac-wk1/TestExpectations: Skip:
- storage/indexeddb/index-multientry.html
- 9:48 PM Changeset in webkit [193809] by
-
- 36 edits in trunk/Source/WebCore
Convert resetAnimValToBaseVal take a reference to a SVGAnimatedType
https://bugs.webkit.org/show_bug.cgi?id=152036
Reviewed by Zalan Bujtas.
Change resetAnimValToBaseVal() to take a reference at the last argument.
- svg/SVGAnimateElementBase.cpp:
(WebCore::SVGAnimateElementBase::resetAnimatedType):
- svg/SVGAnimatedAngle.cpp:
(WebCore::SVGAnimatedAngleAnimator::resetAnimValToBaseVal):
- svg/SVGAnimatedAngle.h:
- svg/SVGAnimatedBoolean.cpp:
(WebCore::SVGAnimatedBooleanAnimator::resetAnimValToBaseVal):
- svg/SVGAnimatedBoolean.h:
- svg/SVGAnimatedColor.h:
- svg/SVGAnimatedEnumeration.cpp:
(WebCore::SVGAnimatedEnumerationAnimator::resetAnimValToBaseVal):
- svg/SVGAnimatedEnumeration.h:
- svg/SVGAnimatedInteger.cpp:
(WebCore::SVGAnimatedIntegerAnimator::resetAnimValToBaseVal):
- svg/SVGAnimatedInteger.h:
- svg/SVGAnimatedIntegerOptionalInteger.cpp:
(WebCore::SVGAnimatedIntegerOptionalIntegerAnimator::resetAnimValToBaseVal):
- svg/SVGAnimatedIntegerOptionalInteger.h:
- svg/SVGAnimatedLength.cpp:
(WebCore::SVGAnimatedLengthAnimator::resetAnimValToBaseVal):
- svg/SVGAnimatedLength.h:
- svg/SVGAnimatedLengthList.cpp:
(WebCore::SVGAnimatedLengthListAnimator::resetAnimValToBaseVal):
- svg/SVGAnimatedLengthList.h:
- svg/SVGAnimatedNumber.cpp:
(WebCore::SVGAnimatedNumberAnimator::resetAnimValToBaseVal):
- svg/SVGAnimatedNumber.h:
- svg/SVGAnimatedNumberList.cpp:
(WebCore::SVGAnimatedNumberListAnimator::resetAnimValToBaseVal):
- svg/SVGAnimatedNumberList.h:
- svg/SVGAnimatedNumberOptionalNumber.cpp:
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::resetAnimValToBaseVal):
- svg/SVGAnimatedNumberOptionalNumber.h:
- svg/SVGAnimatedPath.cpp:
(WebCore::SVGAnimatedPathAnimator::resetAnimValToBaseVal):
- svg/SVGAnimatedPath.h:
- svg/SVGAnimatedPointList.cpp:
(WebCore::SVGAnimatedPointListAnimator::resetAnimValToBaseVal):
- svg/SVGAnimatedPointList.h:
- svg/SVGAnimatedPreserveAspectRatio.cpp:
(WebCore::SVGAnimatedPreserveAspectRatioAnimator::resetAnimValToBaseVal):
- svg/SVGAnimatedPreserveAspectRatio.h:
- svg/SVGAnimatedRect.cpp:
(WebCore::SVGAnimatedRectAnimator::resetAnimValToBaseVal):
- svg/SVGAnimatedRect.h:
- svg/SVGAnimatedString.cpp:
(WebCore::SVGAnimatedStringAnimator::resetAnimValToBaseVal):
- svg/SVGAnimatedString.h:
- svg/SVGAnimatedTransformList.cpp:
(WebCore::SVGAnimatedTransformListAnimator::resetAnimValToBaseVal):
- svg/SVGAnimatedTransformList.h:
- svg/SVGAnimatedTypeAnimator.h:
(WebCore::SVGAnimatedTypeAnimator::resetFromBaseValue):
(WebCore::SVGAnimatedTypeAnimator::resetFromBaseValues):
- 8:15 PM Changeset in webkit [193808] by
-
- 3 edits in trunk/Websites/webkit.org
Wide tables should be scrollable on narrow mobile screens.
https://bugs.webkit.org/show_bug.cgi?id=151941
Reviewed by Timothy Hatcher.
- wp-content/themes/webkit/scripts/global.js:
(inView):
(onMovement):
(updateImages):
(enableScrollableTables):
(update): Deleted.
- wp-content/themes/webkit/style.css:
(.pagination .prev-post):
(article .scrollable):
(.scrollable .scrollable-padding):
- 8:10 PM Changeset in webkit [193807] by
-
- 2 edits in trunk/Websites/webkit.org
Fix Code Style Guidelines code parsing.
https://bugs.webkit.org/show_bug.cgi?id=152024
Reviewed by Timothy Hatcher.
- wp-content/plugins/table-of-contents.php:
- 7:58 PM Changeset in webkit [193806] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Workaround arrow function issue in TimelineOverviewGraph.js
https://bugs.webkit.org/show_bug.cgi?id=152031
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-12-08
Reviewed by Timothy Hatcher.
- UserInterface/Views/TimelineOverviewGraph.js:
(WebInspector.TimelineOverviewGraph.prototype._needsSelectedRecordLayout):
Workaround an existing arrow function issue by moving off of arrow functions here.
- 7:57 PM Changeset in webkit [193805] by
-
- 2 edits in trunk/Source/WebCore
Remove Mavericks-specific code from FontCacheMac
https://bugs.webkit.org/show_bug.cgi?id=152030
Reviewed by Simon Fraser.
Mavericks is no longer a supported platform.
No new tests because there is no behavior change.
- platform/graphics/mac/FontCacheMac.mm:
(WebCore::platformLookupFallbackFont):
(WebCore::platformFontWithFamilySpecialCase): Deleted.
- 6:30 PM Changeset in webkit [193804] by
-
- 7 edits in trunk/Source/JavaScriptCore
[JSC] Improve how B3 lowers Add() and Sub() on x86
https://bugs.webkit.org/show_bug.cgi?id=152026
Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-12-08
Reviewed by Geoffrey Garen.
The assembler was missing some important x86 forms of
ADD and SUB that were making our lowering
unfriendly with register allocation.
First, we were missing a 3 operand version of Add
implement with LEA. As a result, an Add would
be lowered as:
Move op1->srcDest
Add op2, srcDest
The problem with such code is that op2 and srcDest
interferes. It is impossible to assign them the same
machine register.
With the new Add form, we have:
Add op1, op2, dest
without interferences between any of those values.
The add is implement by a LEA without scaling or displacement.
This patch also adds missing forms of Add and Sub with
direct addressing for arguments. This avoids dealing with Tmps
that only exist for those operations.
Finally, the lowering of adding something to itself was updated accordingly.
Such operation is transformed in Shl by 2. The lowering of Shl
was adding an explicit Move, preventing the use of LEA when it
is useful.
Instead of having an explicit move, I changed the direct addressing
forms to only be selected if the two operands are different.
A Move is then added by appendBinOp() if needed.
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::add32):
(JSC::MacroAssemblerX86Common::x86Lea32):
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::add64):
(JSC::MacroAssemblerX86_64::x86Lea64):
(JSC::MacroAssemblerX86_64::sub64):
- assembler/X86Assembler.h:
(JSC::X86Assembler::addq_rm):
(JSC::X86Assembler::subq_mr):
(JSC::X86Assembler::subq_rm):
(JSC::X86Assembler::subq_im):
(JSC::X86Assembler::leal_mr):
(JSC::X86Assembler::leaq_mr):
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::appendBinOp):
(JSC::B3::Air::LowerToAir::lower):
- b3/air/AirOpcode.opcodes:
- b3/testb3.cpp:
(JSC::B3::testAddArgMem):
(JSC::B3::testAddMemArg):
(JSC::B3::testAddImmMem):
(JSC::B3::testAddArg32):
(JSC::B3::testAddArgMem32):
(JSC::B3::testAddMemArg32):
(JSC::B3::testAddImmMem32):
(JSC::B3::testSubArgMem):
(JSC::B3::testSubMemArg):
(JSC::B3::testSubImmMem):
(JSC::B3::testSubMemImm):
(JSC::B3::testSubMemArg32):
(JSC::B3::testSubArgMem32):
(JSC::B3::testSubImmMem32):
(JSC::B3::testSubMemImm32):
(JSC::B3::run):
- 6:01 PM Changeset in webkit [193803] by
-
- 5 edits in tags/Safari-602.1.13.2/Source/WebKit/mac
Roll out r193661. rdar://problem/23639610
- 5:59 PM Changeset in webkit [193802] by
-
- 2 edits in tags/Safari-602.1.13.2/Source/WebKit/mac
Roll out r193675. rdar://problem/23639610
- 5:59 PM Changeset in webkit [193801] by
-
- 4 edits in trunk
Modern IDB: storage/indexeddb/objectstore-cursor.html fails.
https://bugs.webkit.org/show_bug.cgi?id=152023
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (At least one failing test now passes).
- Modules/indexeddb/server/MemoryObjectStoreCursor.cpp:
(WebCore::IDBServer::MemoryObjectStoreCursor::MemoryObjectStoreCursor):
(WebCore::IDBServer::MemoryObjectStoreCursor::setReverseIteratorFromRemainingRange): Make sure the
found iterator is actually in the target range.
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 5:58 PM Changeset in webkit [193800] by
-
- 2 edits in tags/Safari-602.1.13.2/Source/WebKit/mac
Roll out r193676. rdar://problem/23639610
- 5:56 PM Changeset in webkit [193799] by
-
- 10 edits1 delete in tags/Safari-602.1.13.2/Source
Roll out r193645. rdar://problem/23751214
- 5:18 PM Changeset in webkit [193798] by
-
- 2 edits in trunk/Source/WebCore
Changing <video> src during 'ended' event can leave screen sleep disabled
https://bugs.webkit.org/show_bug.cgi?id=152018
Reviewed by Eric Carlson.
Resetting a HTMLMediaElement's src during 'ended' introduces a race condition: whether
the 'mediaPlayerRateChanged()' notification will fire before createMediaPlayer() destroys
the old MediaPlayer firing said notification.
To break the race condition, always update the sleep disabling assertion after destroying
the media player (by creating a new one).
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::createMediaPlayer):
- 4:40 PM Changeset in webkit [193797] by
-
- 2 edits in trunk/LayoutTests
Skipping fast/canvas/canvas-too-large-to-draw.html on win
https://bugs.webkit.org/show_bug.cgi?id=152009
Unreviewed test gardening.
- platform/win/TestExpectations:
- 4:36 PM Changeset in webkit [193796] by
-
- 2 edits in trunk/LayoutTests
Rebaseline fast/block/float/overhanging-tall-block.html for win after r193511
https://bugs.webkit.org/show_bug.cgi?id=151906
Unreviewed test gardening.
- platform/win/fast/block/float/overhanging-tall-block-expected.txt:
- 4:30 PM Changeset in webkit [193795] by
-
- 5 edits in trunk/Source/JavaScriptCore
Factoring out common DFG code for bitwise and shift operators.
https://bugs.webkit.org/show_bug.cgi?id=152019
Reviewed by Michael Saboff.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileBitwiseOp):
(JSC::DFG::SpeculativeJIT::compileShiftOp):
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 4:23 PM Changeset in webkit [193794] by
-
- 2 edits in trunk/LayoutTests
Skipping fast/canvas/canvas-too-large-to-draw.html on ElCapitan Debug
https://bugs.webkit.org/show_bug.cgi?id=152009
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 4:12 PM Changeset in webkit [193793] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG and FTL should be resilient against cases where both snippet operands are constant.
https://bugs.webkit.org/show_bug.cgi?id=152017
Reviewed by Michael Saboff.
The DFG front end may not always constant fold cases where both operands are
constant. As a result, the DFG and FTL back ends needs to be resilient against
this when using snippet generators since the generators do not support the case
where both operands are constant. The strategy for handling this 2 const operands
case is to treat at least one of them as a variable if both are constant.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileValueAdd):
- Also remove the case for folding 2 constant operands. It is the front end's job to do so, not the back end here.
(JSC::DFG::SpeculativeJIT::compileArithSub):
(JSC::DFG::SpeculativeJIT::compileArithMul):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileValueAdd):
(JSC::FTL::DFG::LowerDFGToLLVM::compileArithMul):
- 4:08 PM Changeset in webkit [193792] by
-
- 2 edits in trunk/LayoutTests
Modern IDB: IDBTransaction::hasPendingActivity() was wrong, leading to premature GC of the wrapper.
https://bugs.webkit.org/show_bug.cgi?id=151507
Reviewed by Beth Dakin.
A handful of tests were marked flaky and tracked back to this bug.
Ever since the presumed fix for this bug (r192687) the flakiness dashboard says they pass.
- platform/mac-wk1/TestExpectations: Re-enable the no-longer-flaky tests.
- 4:04 PM Changeset in webkit [193791] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Add a hidden property to TreeOutline
https://bugs.webkit.org/show_bug.cgi?id=152014
Reviewed by Timothy Hatcher.
- UserInterface/Views/NavigationSidebarPanel.js:
Removed static property for "hidden" CSS class. No longer used.
(WebInspector.NavigationSidebarPanel.prototype.set contentTreeOutline):
Fixed bug in order of visibleTreeOutlines add/remove.
(WebInspector.NavigationSidebarPanel.prototype.createContentTreeOutline):
- UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel):
(WebInspector.TimelineSidebarPanel.prototype._changeViewMode):
- UserInterface/Views/TreeOutline.js:
(WebInspector.TreeOutline):
(WebInspector.TreeOutline.prototype.get hidden):
(WebInspector.TreeOutline.prototype.set hidden):
Added hidden property, set DOM element hidden attribute.
(WebInspector.TreeElement.prototype.set hidden):
Remove CSS class, set DOM element hidden attribute.
(WebInspector.TreeElement.prototype._attach):
(WebInspector.TreeElement.prototype.expand):
- 3:57 PM Changeset in webkit [193790] by
-
- 2 edits in trunk/LayoutTests
More IDB TestExpectations gardening.
Reviewed by Alex Christensen.
- platform/mac-wk1/TestExpectations:
- 3:42 PM Changeset in webkit [193789] by
-
- 2 edits in trunk/LayoutTests
Unreviewed IDB layout test gardening (Adding some flaky crashes)
- platform/mac-wk1/TestExpectations:
- 3:05 PM Changeset in webkit [193788] by
-
- 12 edits4 adds in trunk/Source/JavaScriptCore
Snippefy shift operators for the baseline JIT.
https://bugs.webkit.org/show_bug.cgi?id=151875
Reviewed by Geoffrey Garen.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- jit/JIT.h:
- jit/JITArithmetic.cpp:
(JSC::JIT::emitBitBinaryOpFastPath):
- Don't need GPRInfo:: qualifiers. Removed them to reduce verbosity.
- Also removed the emitStoreInt32() case for storing the result on 32-bit ports.
This is because:
- The client should not make assumptions about whether the snippet fast path only include cases where the result tag already contain the IntTag.
The "(op1 == result op2 == result)" condition for skipping the IntTag storage, is only valid for the bitand, bitor, and bitxor implementations.
It is invalid for the lshift implementation that uses this code now.
Instead, we'll always unconditionally store what the result tag that the
snippet computed for us.
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitSlow_op_lshift):
(JSC::JIT::emitRightShiftFastPath):
(JSC::JIT::emit_op_rshift):
(JSC::JIT::emitSlow_op_rshift):
(JSC::JIT::emit_op_urshift):
(JSC::JIT::emitSlow_op_urshift):
- jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_lshift): Deleted.
(JSC::JIT::emitSlow_op_lshift): Deleted.
(JSC::JIT::emitRightShift): Deleted.
(JSC::JIT::emitRightShiftSlowCase): Deleted.
(JSC::JIT::emit_op_rshift): Deleted.
(JSC::JIT::emitSlow_op_rshift): Deleted.
(JSC::JIT::emit_op_urshift): Deleted.
(JSC::JIT::emitSlow_op_urshift): Deleted.
- jit/JITLeftShiftGenerator.cpp: Added.
(JSC::JITLeftShiftGenerator::generateFastPath):
- jit/JITLeftShiftGenerator.h: Added.
(JSC::JITLeftShiftGenerator::JITLeftShiftGenerator):
- jit/JITRightShiftGenerator.cpp: Added.
(JSC::JITRightShiftGenerator::generateFastPath):
- jit/JITRightShiftGenerator.h: Added.
(JSC::JITRightShiftGenerator::JITRightShiftGenerator):
- tests/stress/op_lshift.js:
- tests/stress/op_rshift.js:
- tests/stress/op_urshift.js:
- Fixed some values and added others that are meaningful for testing shifts.
- tests/stress/resources/binary-op-test.js:
(stringifyIfNeeded):
(generateBinaryTests):
- Fixed the test generator to give unique names to all the generated test functions. Without this, multiple tests may end up using the same global test function. As a result, with enough test values to test, the function may get prematurely JITted, and the computed expected result which is supposed to be computed by the LLINT, may end up being computed by a JIT instead.
- 3:05 PM Changeset in webkit [193787] by
-
- 12 edits in trunk/Source/WebKit2
Progress towards implementing downloads with NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=151883
Patch by Alex Christensen <achristensen@webkit.org> on 2015-12-08
Reviewed by Brady Eidson.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload):
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::~NetworkLoad):
(WebKit::NetworkLoad::continueDidReceiveResponse):
(WebKit::NetworkLoad::convertTaskToDownload):
(WebKit::NetworkLoad::willPerformHTTPRedirection):
(WebKit::NetworkLoad::didReceiveChallenge):
(WebKit::NetworkLoad::didReceiveResponse):
(WebKit::NetworkLoad::didReceiveData):
(WebKit::NetworkLoad::didCompleteWithError):
(WebKit::NetworkLoad::didBecomeDownload):
(WebKit::NetworkLoad::didReceiveResponseAsync):
(WebKit::NetworkLoad::continueCanAuthenticateAgainstProtectionSpace):
- NetworkProcess/NetworkLoad.h:
- NetworkProcess/NetworkLoadClient.h:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::cleanup):
(WebKit::NetworkResourceLoader::didConvertToDownload):
(WebKit::NetworkResourceLoader::abort):
(WebKit::NetworkResourceLoader::didConvertHandleToDownload): Deleted.
- NetworkProcess/NetworkResourceLoader.h:
- NetworkProcess/NetworkSession.h:
(WebKit::NetworkSessionTaskClient::~NetworkSessionTaskClient):
(WebKit::NetworkSession::~NetworkSession): Deleted.
- NetworkProcess/cache/NetworkCacheSpeculativeLoad.h:
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(-[NetworkSessionDelegate URLSession:downloadTask:didWriteData:totalBytesWritten:totalBytesExpectedToWrite:]):
(-[NetworkSessionDelegate URLSession:dataTask:didBecomeDownloadTask:]):
(WebKit::NetworkSession::NetworkSession):
(WebKit::NetworkSession::~NetworkSession):
(WebKit::NetworkSession::createDataTaskWithRequest):
- Shared/Downloads/Download.h:
- Shared/Downloads/DownloadManager.h:
(WebKit::DownloadManager::isDownloading):
(WebKit::DownloadManager::activeDownloadCount):
- 3:02 PM Changeset in webkit [193786] by
-
- 5 edits in trunk
Modern IDB: Fire blocked events for delete requests that are blocked.
https://bugs.webkit.org/show_bug.cgi?id=152015
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (Previous failing tests now pass, and previously timing-out tests now complete).
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::maybeDeleteDatabase):
(WebCore::IDBServer::UniqueIDBDatabase::handleDelete):
(WebCore::IDBServer::UniqueIDBDatabase::deleteOrRunTransactionsTimerFired):
- Modules/indexeddb/server/UniqueIDBDatabase.h:
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 2:18 PM Changeset in webkit [193785] by
-
- 2 edits in trunk/LayoutTests
More IDB TestExpectations gardening.
Reviewed by Alex Christensen.
- platform/mac-wk1/TestExpectations:
- 2:12 PM Changeset in webkit [193784] by
-
- 17 edits4 adds in trunk
Modern IDB: Fire blocked events for upgrade requests that are blocked.
https://bugs.webkit.org/show_bug.cgi?id=152007
Reviewed by Alex Christensen.
Source/WebCore:
Test: storage/indexeddb/modern/blocked-open-db-requests.html
And some that used to fail now pass.
And some that used to timeout now complete.
- Modules/indexeddb/client/IDBConnectionToServer.cpp:
(WebCore::IDBClient::IDBConnectionToServer::notifyOpenDBRequestBlocked):
- Modules/indexeddb/client/IDBConnectionToServer.h:
- Modules/indexeddb/client/IDBDatabaseImpl.cpp:
(WebCore::IDBClient::IDBDatabase::IDBDatabase):
- Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp:
(WebCore::IDBClient::IDBOpenDBRequest::requestBlocked):
- Modules/indexeddb/client/IDBOpenDBRequestImpl.h:
- Modules/indexeddb/client/IDBRequestImpl.cpp:
(WebCore::IDBClient::IDBRequest::dispatchEvent):
- Modules/indexeddb/server/IDBConnectionToClient.cpp:
(WebCore::IDBServer::IDBConnectionToClient::notifyOpenDBRequestBlocked):
- Modules/indexeddb/server/IDBConnectionToClient.h:
- Modules/indexeddb/server/IDBConnectionToClientDelegate.h:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::handleOpenDatabaseOperations): When a request that would
result in a version change transaction is blocked by open connections, notify it.
- Modules/indexeddb/shared/InProcessIDBServer.cpp:
(WebCore::InProcessIDBServer::notifyOpenDBRequestBlocked):
- Modules/indexeddb/shared/InProcessIDBServer.h:
LayoutTests:
- platform/mac-wk1/TestExpectations:
- storage/indexeddb/modern/blocked-open-db-requests-expected.txt: Added.
- storage/indexeddb/modern/blocked-open-db-requests.html: Added.
- storage/indexeddb/modern/resources/blocked-open-db-requests.js: Added.
- storage/indexeddb/modern/deleteobjectstore-1.html: Fix subtly broken test.
- storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures.html: Ditto.
- 1:49 PM Changeset in webkit [193783] by
-
- 9 edits1 add in trunk/Source
Create a Sandbox SPI header
https://bugs.webkit.org/show_bug.cgi?id=151981
Reviewed by Andy Estes.
Source/JavaScriptCore:
- inspector/remote/RemoteInspector.mm:
Source/WebKit2:
- PluginProcess/mac/PluginProcessShim.mm:
- Shared/ios/ChildProcessIOS.mm:
- Shared/mac/ChildProcessMac.mm:
- Shared/mac/SandboxUtilities.mm:
Source/WTF:
- WTF.xcodeproj/project.pbxproj:
- wtf/spi/darwin/SandboxSPI.h: Added.
- 1:45 PM Changeset in webkit [193782] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
DFG::UnificationPhase should merge isProfitableToUnbox, since this may have been set in ByteCodeParser
https://bugs.webkit.org/show_bug.cgi?id=152011
rdar://problem/23777875
Reviewed by Michael Saboff.
Previously UnificationPhase did not merge this because we used to only set this in FixupPhase, which runs after unification. But now
ByteCodeParser may set isProfitableToUnbox as part of how it handles the ArgumentCount of an inlined varargs call, so UnificationPhase
needs to merge it after unifying.
Also changed the order of unification since this makes the bug more obvious and easier to test.
- dfg/DFGUnificationPhase.cpp:
(JSC::DFG::UnificationPhase::run):
- tests/stress/varargs-with-unused-count.js: Added.
- 1:44 PM Changeset in webkit [193781] by
-
- 17 edits3 adds in trunk
Polymorphic operand types for DFG and FTL div.
https://bugs.webkit.org/show_bug.cgi?id=151747
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Perf on benchmarks is neutral. The new JSRegress ftl-object-div test shows
a speed up not from the div operator itself, but from the fact that the
polymorphic operand types support now allow the test function to run without OSR
exiting, thereby realizing the DFG and FTL's speed up on other work that the test
function does.
This patch has passed the layout tests on x86_64 with a debug build.
It passed the JSC tests with x86 and x86_64 debug builds.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArithDiv):
- ftl/FTLCompileBinaryOp.cpp:
(JSC::FTL::generateBinaryArithOpFastPath):
(JSC::FTL::generateBinaryOpFastPath):
- ftl/FTLInlineCacheDescriptor.h:
- ftl/FTLInlineCacheDescriptorInlines.h:
(JSC::FTL::ArithDivDescriptor::ArithDivDescriptor):
(JSC::FTL::ArithDivDescriptor::icSize):
- ftl/FTLInlineCacheSize.cpp:
(JSC::FTL::sizeOfArithDiv):
- ftl/FTLInlineCacheSize.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::lower):
(JSC::FTL::DFG::LowerDFGToLLVM::compileArithMul):
- Fixed a cut-paste bug where the op_mul IC was using the op_sub IC size. This bug is benign because the op_sub IC size turns out to be larger than op_mul needs.
(JSC::FTL::DFG::LowerDFGToLLVM::compileArithDiv):
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_div):
- Fixed a bug where the scratchFPR was not allocated for the 64bit port.
This bug is benign because the scratchFPR is only needed if we are
using scratchGPR register (used for branchConvertDoubleToInt32()) is
the scratchFPR is never needed. However, we should fix this anyway to be correct.X86Registers::r8. Since we're always using regT2 for the scratchT2,
- tests/stress/op_div.js:
- Fixed some test values.
LayoutTests:
- js/regress/ftl-object-div-expected.txt: Added.
- js/regress/ftl-object-div.html: Added.
- js/regress/script-tests/ftl-object-div.js: Added.
(o1.valueOf):
(foo):
- 1:41 PM Changeset in webkit [193780] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Compile error.
https://bugs.webkit.org/show_bug.cgi?id=152008
Reviewed by Brent Fulgham.
GLuint is undefined.
- platform/graphics/GraphicsContext3D.h:
- 1:35 PM Changeset in webkit [193779] by
-
- 3 edits in trunk/Source/WebCore
Light cleanup in TextPainter.
https://bugs.webkit.org/show_bug.cgi?id=151994
Reviewed by Darin Adler.
No change in functionality.
- rendering/TextPainter.cpp:
(WebCore::TextPainter::TextPainter):
- rendering/TextPainter.h: Address post review comment.
(WebCore::ShadowApplier::isLastShadowIteration):
(WebCore::ShadowApplier::shadowIsCompletelyCoveredByText):
- 1:07 PM Changeset in webkit [193778] by
-
- 3 edits in trunk/Source/WebKit/mac
Follow-up to:
Add support for WebViewAdditions
https://bugs.webkit.org/show_bug.cgi?id=151967
Rubber-stamped by Dan Bernstein.
We should use the Web prefix for all category names.
- WebView/WebView.mm:
(-[WebView updateWebViewAdditions]):
- WebView/WebViewInternal.h:
- 1:05 PM Changeset in webkit [193777] by
-
- 10 edits1 copy in tags/Safari-602.1.13.2/Source
Merged r193645. rdar://problem/23751214
- 1:03 PM Changeset in webkit [193776] by
-
- 2 edits in tags/Safari-602.1.13.2/Source/WebKit/mac
Merged r193676. rdar://problem/23639610
- 1:02 PM Changeset in webkit [193775] by
-
- 2 edits in tags/Safari-602.1.13.2/Source/WebKit/mac
Merged r193675. rdar://problem/23639610
- 1:00 PM Changeset in webkit [193774] by
-
- 5 edits in tags/Safari-602.1.13.2/Source/WebKit/mac
Merged r193661. rdar://problem/23639610
- 12:44 PM Changeset in webkit [193773] by
-
- 3 edits2 adds in trunk
Do not insert positioned renderers to multiple gPositionedDescendantsMap.
https://bugs.webkit.org/show_bug.cgi?id=151878
rdar://problem/22229889
Reviewed by Simon Fraser.
We insert positioned renderers into a static map (RenderBlock::gPositionedDescendantsMap) to keep track of them.
This static map is at block level. A particular absolute positioned object is added to its closest ancestor that
returns true for RenderElement::canContainAbsolutelyPositionedObjects().
canContainAbsolutelyPositionedObjects() returns true if the ancestor is either positioned or has transform.
If this container's style changes so that it's no longer positioned and it has no transform anymore,
we need to clear its static map of positioned objects (they'll get re-inserted to another ancestor at next layout).
This patch addresses the case when the renderer does not have transforms anymore.
Source/WebCore:
Test: fast/block/positioning/crash-when-transform-is-removed.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleWillChange):
LayoutTests:
- fast/block/positioning/crash-when-transform-is-removed-expected.txt: Added.
- fast/block/positioning/crash-when-transform-is-removed.html: Added.
- 12:43 PM Changeset in webkit [193772] by
-
- 2 edits in trunk/Websites/webkit.org
Fix social meta for home page.
https://bugs.webkit.org/show_bug.cgi?id=151764
Reviewed by Timothy Hatcher.
- wp-content/plugins/social-meta.php:
- 12:42 PM Changeset in webkit [193771] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Global Breakpoints should always be visible
https://bugs.webkit.org/show_bug.cgi?id=151066
Reviewed by Timothy Hatcher.
- UserInterface/Views/DebuggerSidebarPanel.js:
(WebInspector.DebuggerSidebarPanel):
Turn off filtering for Global Breakpoints elements.
- UserInterface/Views/NavigationSidebarPanel.js:
(WebInspector.NavigationSidebarPanel.prototype.suppressFilteringOnTreeElements):
Allow filtering to be turned off for specific tree elements.
(WebInspector.NavigationSidebarPanel.prototype.applyFiltersToTreeElement):
Make element visible if filtering suppressed.
(WebInspector.NavigationSidebarPanel.prototype._checkForEmptyFilterResults):
Visible elements with filtering disabled aren't considered when
showing/hiding the empty content placeholder.
- 12:37 PM Changeset in webkit [193770] by
-
- 2 edits in trunk/LayoutTests
Marking fast/canvas/canvas-too-large-to-draw.html as flaky on ElCapitan Debug
https://bugs.webkit.org/show_bug.cgi?id=152009
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 12:33 PM Changeset in webkit [193769] by
-
- 2 edits in tags/Safari-602.1.13.2
Merged r193647. rdar://problem/23806716
- 12:33 PM Changeset in webkit [193768] by
-
- 2 edits in tags/Safari-602.1.13.2/Source/WebKit2
Merged r193489. rdar://problem/23766021
- 12:31 PM Changeset in webkit [193767] by
-
- 2 edits in tags/Safari-602.1.13.2/Source/WebKit2
Merged r193483. rdar://problem/23766021
- 12:24 PM Changeset in webkit [193766] by
-
- 62 edits13 adds1 delete in trunk
[ES6] "super" and "this" should be lexically bound inside an arrow function and should live in a JSLexicalEnvironment
https://bugs.webkit.org/show_bug.cgi?id=149338
Source/JavaScriptCore:
Patch by Aleksandr Skachkov <gskachkov@gmail.com> on 2015-12-05
Reviewed by Saam Barati.
Implemented new version of the lexically bound 'this' in arrow function. In current version
'this' is stored inside of the lexical environment of the function. To store and load we use
op_get_from_scope and op_put_to_scope operations. Also new implementation prevent raising TDZ
error for arrow functions that are declared before super() but invoke after.
- builtins/BuiltinExecutables.cpp:
(JSC::createExecutableInternal):
- bytecode/BytecodeList.json:
- bytecode/BytecodeUseDef.h:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
- bytecode/EvalCodeCache.h:
(JSC::EvalCodeCache::getSlow):
- bytecode/ExecutableInfo.h:
(JSC::ExecutableInfo::ExecutableInfo):
(JSC::ExecutableInfo::isDerivedConstructorContext):
(JSC::ExecutableInfo::isArrowFunctionContext):
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::isArrowFunction):
(JSC::UnlinkedCodeBlock::isDerivedConstructorContext):
(JSC::UnlinkedCodeBlock::isArrowFunctionContext):
- bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::generateUnlinkedFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
- bytecode/UnlinkedFunctionExecutable.h:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::initializeArrowFunctionContextScopeIfNeeded):
(JSC::BytecodeGenerator::variable):
(JSC::BytecodeGenerator::emitNewArrowFunctionExpression):
(JSC::BytecodeGenerator::emitLoadArrowFunctionLexicalEnvironment):
(JSC::BytecodeGenerator::emitLoadThisFromArrowFunctionLexicalEnvironment):
(JSC::BytecodeGenerator::emitLoadNewTargetFromArrowFunctionLexicalEnvironment):
(JSC::BytecodeGenerator::emitLoadDerivedConstructorFromArrowFunctionLexicalEnvironment):
(JSC::BytecodeGenerator::emitPutNewTargetToArrowFunctionContextScope):
(JSC::BytecodeGenerator::emitPutDerivedConstructorToArrowFunctionContextScope):
(JSC::BytecodeGenerator::emitPutThisToArrowFunctionContextScope):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::isDerivedConstructorContext):
(JSC::BytecodeGenerator::usesArrowFunction):
(JSC::BytecodeGenerator::needsToUpdateArrowFunctionContext):
(JSC::BytecodeGenerator::usesEval):
(JSC::BytecodeGenerator::usesThis):
(JSC::BytecodeGenerator::newTarget):
(JSC::BytecodeGenerator::makeFunction):
- bytecompiler/NodesCodegen.cpp:
(JSC::ThisNode::emitBytecode):
(JSC::SuperNode::emitBytecode):
(JSC::EvalFunctionCallNode::emitBytecode):
(JSC::FunctionCallValueNode::emitBytecode):
(JSC::FunctionNode::emitBytecode):
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::evaluate):
- dfg/DFGAbstractInterpreterInlines.h:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.cpp:
- dfg/DFGClobberize.h:
- dfg/DFGDoesGC.cpp:
- dfg/DFGFixupPhase.cpp:
- dfg/DFGNodeType.h:
- dfg/DFGObjectAllocationSinkingPhase.cpp:
- dfg/DFGPredictionPropagationPhase.cpp:
- dfg/DFGPromotedHeapLocation.cpp:
- dfg/DFGPromotedHeapLocation.h:
- dfg/DFGSafeToExecute.h:
- dfg/DFGSpeculativeJIT.cpp:
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
- dfg/DFGSpeculativeJIT64.cpp:
- ftl/FTLCapabilities.cpp:
- ftl/FTLLowerDFGToLLVM.cpp:
- ftl/FTLOperations.cpp:
(JSC::FTL::operationMaterializeObjectInOSR):
- interpreter/Interpreter.cpp:
(JSC::eval):
- jit/JIT.cpp:
- jit/JIT.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emitNewFuncExprCommon):
- jit/JITOpcodes32_64.cpp:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createArrowFunctionExpr):
(JSC::ASTBuilder::usesArrowFunction):
- parser/Nodes.h:
(JSC::ScopeNode::usesArrowFunction):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseFunctionInfo):
- parser/ParserModes.h:
- runtime/CodeCache.cpp:
(JSC::CodeCache::getGlobalCodeBlock):
(JSC::CodeCache::getProgramCodeBlock):
(JSC::CodeCache::getEvalCodeBlock):
(JSC::CodeCache::getModuleProgramCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
- runtime/CodeCache.h:
- runtime/CommonIdentifiers.h:
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/Executable.cpp:
(JSC::ScriptExecutable::ScriptExecutable):
(JSC::EvalExecutable::create):
(JSC::EvalExecutable::EvalExecutable):
(JSC::ProgramExecutable::ProgramExecutable):
(JSC::ModuleProgramExecutable::ModuleProgramExecutable):
(JSC::FunctionExecutable::FunctionExecutable):
- runtime/Executable.h:
(JSC::ScriptExecutable::isArrowFunctionContext):
(JSC::ScriptExecutable::isDerivedConstructorContext):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::createEvalCodeBlock):
- runtime/JSGlobalObject.h:
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):
- tests/es6.yaml:
- tests/stress/arrowfunction-activation-sink-osrexit.js:
- tests/stress/arrowfunction-activation-sink.js:
- tests/stress/arrowfunction-lexical-bind-newtarget.js: Added.
- tests/stress/arrowfunction-lexical-bind-supercall-1.js: Added.
- tests/stress/arrowfunction-lexical-bind-supercall-2.js: Added.
- tests/stress/arrowfunction-lexical-bind-supercall-3.js: Added.
- tests/stress/arrowfunction-lexical-bind-supercall-4.js: Added.
- tests/stress/arrowfunction-lexical-bind-this-1.js:
- tests/stress/arrowfunction-lexical-bind-this-7.js: Added.
- tests/stress/arrowfunction-tdz-1.js: Added.
- tests/stress/arrowfunction-tdz-2.js: Added.
- tests/stress/arrowfunction-tdz-3.js: Added.
- tests/stress/arrowfunction-tdz-4.js: Added.
- tests/stress/arrowfunction-tdz.js: Removed.
LayoutTests:
Patch by Skachkov Oleksandr <gskachkov@gmail.com> on 2015-12-08
Reviewed by Saam Barati.
- js/arrowfunction-supercall-expected.txt: Added.
- js/arrowfunction-supercall.html: Added.
- js/arrowfunction-tdz-expected.txt: Added new expectation.
- js/script-tests/arrowfunction-supercall.js: Added.
- js/script-tests/arrowfunction-tdz.js: Added new cases.
- 11:49 AM Changeset in webkit [193765] by
-
- 5 edits in trunk/Tools
https://bugs.webkit.org/show_bug.cgi?id=151243
<rdar://problem/22955197>
Patch by Aakash Jain <aakash_jain@apple.com> on 2015-12-08
Reviewed by Alexey Proskuryakov.
- LayoutTestRelay/LayoutTestRelay/main.m:
(getTestingSimDevice): Use separate testing device for each worker.
- Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run): Perform cleanup even if setup fails.
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.default_child_processes): Calculate number of simulators to use.
(IOSSimulatorPort.child_processes): Gets the number of simulators from options variable.
(IOSSimulatorPort.setup_test_run): Handle mulitple simulators.
(IOSSimulatorPort._quit_ios_simulator): Same
(IOSSimulatorPort.clean_up_test_run): Same
(IOSSimulatorPort.check_sys_deps): Same
(IOSSimulatorPort.testing_device): Same
(IOSSimulatorPort.reset_preferences): Same
(IOSSimulatorPort.get_simulator_path): Return simulator path.
(IOSSimulatorPort._createSimulatorApp): Create the copy of simulator app.
- Scripts/webkitpy/xcode/simulator.py:
(Device.delete): Delete the simulator device.
(Simulator.delete_device): Same
(Simulator.wait_until_device_is_booted): Wait for device booting.
- 11:35 AM Changeset in webkit [193764] by
-
- 11 edits in trunk/Source
[MediaStream] Rename UserMediaClient and UserMediaController methods
https://bugs.webkit.org/show_bug.cgi?id=152001
Reviewed by Brady Eidson.
Source/WebCore:
No new tests, no behavior change.
- Modules/mediastream/UserMediaClient.h:
(WebCore::UserMediaClient::~UserMediaClient):
- Modules/mediastream/UserMediaController.h:
(WebCore::UserMediaController::client):
(WebCore::UserMediaController::from):
(WebCore::UserMediaController::requestUserMediaAccess):
(WebCore::UserMediaController::cancelUserMediaAccessRequest):
(WebCore::UserMediaController::requestPermission): Deleted.
(WebCore::UserMediaController::cancelRequest): Deleted.
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::constraintsValidated):
(WebCore::UserMediaRequest::contextDestroyed):
- platform/mock/UserMediaClientMock.h:
Source/WebKit/mac:
- WebCoreSupport/WebUserMediaClient.h:
- WebCoreSupport/WebUserMediaClient.mm:
(WebUserMediaClient::pageDestroyed):
(WebUserMediaClient::requestUserMediaAccess):
(WebUserMediaClient::cancelUserMediaAccessRequest):
(-[WebUserMediaPolicyListener initWithUserMediaRequest:]):
(-[WebUserMediaPolicyListener cancelUserMediaAccessRequest]):
(WebUserMediaClient::requestPermission): Deleted.
(WebUserMediaClient::cancelRequest): Deleted.
(-[WebUserMediaPolicyListener cancelRequest]): Deleted.
Source/WebKit2:
- WebProcess/WebCoreSupport/WebUserMediaClient.cpp:
(WebKit::WebUserMediaClient::pageDestroyed):
(WebKit::WebUserMediaClient::requestUserMediaAccess):
(WebKit::WebUserMediaClient::cancelUserMediaAccessRequest):
(WebKit::WebUserMediaClient::requestPermission): Deleted.
(WebKit::WebUserMediaClient::cancelRequest): Deleted.
- WebProcess/WebCoreSupport/WebUserMediaClient.h:
- 11:34 AM Changeset in webkit [193763] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Remove an unused variable from WebKitWebContext
https://bugs.webkit.org/show_bug.cgi?id=151999
Patch by Tomas Popela <tpopela@redhat.com> on 2015-12-08
Reviewed by Carlos Garcia Campos.
- UIProcess/API/gtk/WebKitWebContext.cpp:
- 11:29 AM Changeset in webkit [193762] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Do not exit fullscreen mode during auto-PiP.
https://bugs.webkit.org/show_bug.cgi?id=151889
Reviewed by Darin Adler.
When auto-PiPing, do not exit fullscreen mode, as that causes a two-step animation upon returing from auto-PiP.
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::applicationDidBecomeActive): Handle the case where we open Safari after an
auto-PiP by clicking on a link; if so, hide the fullscreen window.
(WebVideoFullscreenInterfaceAVKit::didStartPictureInPicture): Do not exit fullscreen during auto-PiP.
(WebVideoFullscreenInterfaceAVKit::shouldExitFullscreenWithReason): Ditto.
- 11:20 AM Changeset in webkit [193761] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Remove unneeded function.
https://bugs.webkit.org/show_bug.cgi?id=151989
Reviewed by Brent Fulgham.
- platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
(WebCore::MediaPlayerPrivateMediaFoundation::CustomVideoPresenter::createOptimalVideoType):
(MFCreateMediaType): Deleted.
- 11:11 AM Changeset in webkit [193760] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Adopt WebFullScreenVideoRootViewController.
https://bugs.webkit.org/show_bug.cgi?id=151996
Reviewed by Dan Bernstein.
Adopt WebFullScreenVideoRootViewController from WebKitAdditions. If it is not available, create and use
a generic UIViewController subclass.
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(createFullScreenVideoRootViewControllerClass):
(allocWebFullScreenVideoRootViewControllerInstance):
(WebVideoFullscreenInterfaceAVKit::setupFullscreen):
- 10:53 AM Changeset in webkit [193759] by
-
- 5 edits in tags/Safari-602.1.13.2/Source
Versioning.
- 10:00 AM Changeset in webkit [193758] by
-
- 2 edits in trunk/Source/WebCore
ImmutableNFANodeBuilder's move constructor moves an uninitialized member variable into itself
https://bugs.webkit.org/show_bug.cgi?id=151982
Reviewed by Darin Adler.
- contentextensions/ImmutableNFANodeBuilder.h:
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::ImmutableNFANodeBuilder):
- 9:50 AM Changeset in webkit [193757] by
-
- 2 edits in trunk/Source/WebCore
[Cocoa] ResourceUsageOverlay should query kernel for VM page size.
<https://webkit.org/b/151920>
Reviewed by Andy Estes.
Read the vm.pagesize sysctl to find the correct page size for memory usage calculations.
This fixes broken math on systems that have different hw.pagesize and vm.pagesize.
- page/cocoa/ResourceUsageOverlayCocoa.mm:
(WebCore::vmPageSize):
(WebCore::pagesPerVMTag):
(WebCore::runSamplerThread):
- 9:39 AM Changeset in webkit [193756] by
-
- 7 edits in trunk/Source
Add diagnostic logging to measure speculative revalidation accuracy
https://bugs.webkit.org/show_bug.cgi?id=151953
<rdar://problem/23092196>
Reviewed by Darin Adler.
Source/WebCore:
Add diagnostic logging to measure speculative revalidation accuracy.
- page/DiagnosticLoggingKeys.cpp:
(WebCore::DiagnosticLoggingKeys::entryRightlyNotWarmedUpKey):
(WebCore::DiagnosticLoggingKeys::entryWronglyNotWarmedUpKey):
(WebCore::DiagnosticLoggingKeys::successfulSpeculativeWarmupWithRevalidationKey):
(WebCore::DiagnosticLoggingKeys::successfulSpeculativeWarmupWithoutRevalidationKey):
(WebCore::DiagnosticLoggingKeys::unknownEntryRequestKey):
(WebCore::DiagnosticLoggingKeys::wastedSpeculativeWarmupWithRevalidationKey):
(WebCore::DiagnosticLoggingKeys::wastedSpeculativeWarmupWithoutRevalidationKey):
- page/DiagnosticLoggingKeys.h:
Source/WebKit2:
We track the following:
- Resources we knew about AND did not get requested
- We did not speculate (Good)
- We speculated but did not go to network (Bad)
- We speculated and went to network (Very bad)
- Resources we did not know about (Neutral)
- Resources we knew about AND got requested
- We did not speculate (Bad)
- We speculated but did not go to network (Good)
- We speculated and went to network (Very good)
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::Cache::retrieve):
- NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:
(WebKit::NetworkCache::allSpeculativeLoadingDiagnosticMessages):
(WebKit::NetworkCache::printSpeculativeLoadingDiagnosticMessageCounts):
(WebKit::NetworkCache::logSpeculativeLoadingDiagnosticMessage):
(WebKit::NetworkCache::SpeculativeLoadManager::ExpiringEntry::ExpiringEntry):
(WebKit::NetworkCache::SpeculativeLoadManager::PreloadedEntry::PreloadedEntry):
(WebKit::NetworkCache::SpeculativeLoadManager::PreloadedEntry::wasRevalidated):
(WebKit::NetworkCache::SpeculativeLoadManager::PendingFrameLoad::markLoadAsCompleted):
(WebKit::NetworkCache::SpeculativeLoadManager::retrieve):
(WebKit::NetworkCache::SpeculativeLoadManager::addPreloadedEntry):
(WebKit::NetworkCache::SpeculativeLoadManager::revalidateEntry):
(WebKit::NetworkCache::SpeculativeLoadManager::preloadEntry):
(WebKit::NetworkCache::SpeculativeLoadManager::startSpeculativeRevalidation):
(WebKit::NetworkCache::makeSubresourcesKey): Deleted.
(WebKit::NetworkCache::constructRevalidationRequest): Deleted.
(WebKit::NetworkCache::responseNeedsRevalidation): Deleted.
(WebKit::NetworkCache::SpeculativeLoadManager::PendingFrameLoad::saveToDiskIfReady): Deleted.
(WebKit::NetworkCache::SpeculativeLoadManager::retrieveEntryFromStorage): Deleted.
(WebKit::NetworkCache::SpeculativeLoadManager::satisfyPendingRequests): Deleted.
- NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.h:
- 9:37 AM Changeset in webkit [193755] by
-
- 4 edits in trunk
Modern IDB: storage/indexeddb/index-cursor.html fails.
https://bugs.webkit.org/show_bug.cgi?id=151973
Reviewed by Darin Adler.
Source/WebCore:
No new tests (At least one failing test now passes).
- Modules/indexeddb/server/MemoryIndexCursor.cpp:
(WebCore::IDBServer::MemoryIndexCursor::MemoryIndexCursor): When the initial cursor creation
generates an iterator outside of the cursor's IDBKeyRange, invalidate the iterator.
LayoutTests:
- platform/mac-wk1/TestExpectations:
- 9:35 AM Changeset in webkit [193754] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix the !ENABLE(DFG_JIT) build after r193649
https://bugs.webkit.org/show_bug.cgi?id=151985
Reviewed by Saam Barati.
- jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_loop_hint):
- 8:42 AM Changeset in webkit [193753] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. Remove unnecessary check for 0 in commitSize().
Change suggested by Darin Adler in bug #130237.
- interpreter/JSStack.cpp:
(JSC::commitSize):
- 8:42 AM Changeset in webkit [193752] by
-
- 4 edits in trunk
[EFL] REGRESSION(r173394): MiniBrowser stucked in an infinite loop if NETWORK_CACHE is disabled
https://bugs.webkit.org/show_bug.cgi?id=137692
Reviewed by Darin Adler.
Source/WebKit2:
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::maximumBufferingTime): Disable caching if NETWORK_CACHE is disabled.
LayoutTests:
- platform/efl/TestExpectations: Unskip now passing tests.
- 8:16 AM Changeset in webkit [193751] by
-
- 12 edits in trunk/LayoutTests
[EFL][AX] Rebaseline failing AX tests since r185662
https://bugs.webkit.org/show_bug.cgi?id=151991
Unreviewed EFL rebaseline.
- platform/efl/TestExpectations:
- platform/efl/accessibility/image-link-expected.txt:
- platform/efl/accessibility/image-map2-expected.txt:
- platform/efl/accessibility/lists-expected.txt:
- platform/efl/accessibility/table-attributes-expected.txt:
- platform/efl/accessibility/table-cell-spans-expected.txt:
- platform/efl/accessibility/table-cells-expected.txt:
- platform/efl/accessibility/table-detection-expected.txt:
- platform/efl/accessibility/table-one-cell-expected.txt:
- platform/efl/accessibility/table-sections-expected.txt:
- platform/efl/accessibility/table-with-rules-expected.txt:
- 8:02 AM Changeset in webkit [193750] by
-
- 4 edits in trunk
[EFL] some ax tests have been failed since r186692
https://bugs.webkit.org/show_bug.cgi?id=146887
Reviewed by Mario Sanchez Prada.
Source/WebCore:
The tests were failing because there are now two WebCore accessibility
roles which need to implement the AtkTable interface: TableRole and
GridRole. Because the latter was not added in r186692, any tests with
ARIA role grid that accessed cells via coordinates stopped working.
No new tests; instead unskipped all the broken table tests which now pass.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(getInterfaceMaskFromObject):
LayoutTests:
- platform/efl/TestExpectations: Removed failing tests.
- 7:38 AM Changeset in webkit [193749] by
-
- 2 edits in trunk/Source/JavaScriptCore
[EFL] Remove the flag to check timer state in IncrementalSweeper
https://bugs.webkit.org/show_bug.cgi?id=151988
Reviewed by Gyuyoung Kim.
- heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::scheduleTimer):
(JSC::IncrementalSweeper::IncrementalSweeper):
(JSC::IncrementalSweeper::cancelTimer):
- 6:20 AM Changeset in webkit [193748] by
-
- 3 edits in trunk/Source/WebCore
[ThreadedCompositor] Add support for Cairo GL-backed ImageBuffer.
https://bugs.webkit.org/show_bug.cgi?id=151986
Reviewed by Žan Doberšek.
This patch adds a support for accelerated 2d canvas which uses cairo-gl as its
backend to the threaded compositor. Basically, it applies same way to support
WebGL for the threaded compositor.
Unfortunately, we cannot swap the buffer for the accelerated 2d canvas because
it should preserve the buffer of the previous frame when drawing new contents.
Because of that, the surface of the accelerated 2d canvas will be copied for
each frame.
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBufferData::ImageBufferData):
(WebCore::ImageBufferData::createCompositorBuffer): Prepare a texture
surface to push the rendered result to the compositing thread.
(WebCore::ImageBufferData::swapBuffersIfNeeded): Copies the contents
of the canvas's surface to the compositing texture.
(WebCore::ImageBufferData::createCairoGLSurface): Moved to the inside
of ImageBufferData.
- 3:18 AM Changeset in webkit [193747] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Mac][GTK] Fix JSC FTL build
https://bugs.webkit.org/show_bug.cgi?id=151915
Reviewed by Csaba Osztrogonác.
- CMakeLists.txt: Don't pass version-script option to ld on Darwin because this platform's linker
doesn't support this option.
- 3:07 AM Changeset in webkit [193746] by
-
- 11 edits in trunk
[GTK] 15 accessibility tests fail since r186692.
https://bugs.webkit.org/show_bug.cgi?id=148938
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Failing tests rebaselined.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole): Treat GridCellRole and CellRole the same.
(roleIsTextType): Treat GridCellRole and CellRole the same.
LayoutTests:
- platform/gtk/TestExpectations: Removed failing tests.
- platform/gtk/accessibility/roles-computedRoleString-expected.txt: Rebaselined.
- platform/gtk/accessibility/table-attributes-expected.txt: Rebaselined.
- platform/gtk/accessibility/table-cell-spans-expected.txt: Rebaselined.
- platform/gtk/accessibility/table-cells-expected.txt: Rebaselined.
- platform/gtk/accessibility/table-detection-expected.txt: Rebaselined.
- platform/gtk/accessibility/table-sections-expected.txt: Rebaselined.
- platform/gtk/accessibility/table-with-rules-expected.txt: Rebaselined.
- 2:45 AM WebKitGTK/2.10.x edited by
- (diff)
- 2:26 AM Changeset in webkit [193745] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. Use pageSize() instead of getpagesize() after r193648
- interpreter/JSStack.cpp:
(JSC::commitSize):
- 2:00 AM Changeset in webkit [193744] by
-
- 7 edits1 copy in trunk
[EFL] Add API to provide preferences before creating ewk_view
https://bugs.webkit.org/show_bug.cgi?id=151587
Reviewed by Gyuyoung Kim.
Source/WebKit2:
This patch adds ewk_view_configuration_settings_get to provide preferences
before createing ewk_view.
- PlatformEfl.cmake:
- UIProcess/API/efl/ewk_view_configuration.cpp:
(EwkViewConfiguration::EwkViewConfiguration):
(ewk_view_configuration_settings_get):
- UIProcess/API/efl/ewk_view_configuration.h:
- UIProcess/API/efl/ewk_view_configuration_private.h:
(EwkViewConfiguration::pageGroup):
- UIProcess/API/efl/tests/test_ewk2_view_configuration.cpp:
(TEST_F): Added test case for ewk_view_configuration_settings_get().
Tools:
- MiniBrowser/efl/main.c:
(on_key_down):
(quit):
(window_create):
Moved settings related code to configuration() not to update settings
whenever ewk_view is created.
(configuration):
(elm_main):
- 1:17 AM Changeset in webkit [193743] by
-
- 3 edits2 adds in trunk
[cairo] Solid stroke of lines with thickness less than 1 pixel broken after r191658
https://bugs.webkit.org/show_bug.cgi?id=151947
Reviewed by Martin Robinson.
Source/WebCore:
Test: mathml/presentation/radical-bar-visibility.html
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawLine): Force a minimal thickness of 1px
LayoutTests:
Add a test to check that the radical overbar appears on the screen when it has thickness less than 1px.
- mathml/presentation/radical-bar-visibility-expected-mismatch.html: Added.
- mathml/presentation/radical-bar-visibility.html: Added.
- 1:14 AM Changeset in webkit [193742] by
-
- 1 copy in tags/Safari-602.1.13.2
New tag.
- 1:12 AM Changeset in webkit [193741] by
-
- 2 edits in trunk/Tools
Unreviewed. Fix GTK+ API tests after r193639.
The new jhbuild version needs some more variables ot be present in
the builtin dict, even if they are set to None.
- jhbuild/jhbuildutils.py:
(enter_jhbuild_environment_if_available):
- 12:55 AM Changeset in webkit [193740] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Merged r191748. rdar://problem/23787113
- 12:55 AM Changeset in webkit [193739] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Merged r191746. rdar://problem/23787113
- 12:54 AM Changeset in webkit [193738] by
-
- 7 edits2 copies in branches/safari-601-branch
Merged r191731. rdar://problem/23787113
- 12:53 AM Changeset in webkit [193737] by
-
- 4 edits5 copies in branches/safari-601-branch
Merged r192604. rdar://problem/23787086
- 12:51 AM Changeset in webkit [193736] by
-
- 3 edits2 copies in branches/safari-601-branch
Merged r192433. rdar://problem/23787115
- 12:51 AM Changeset in webkit [193735] by
-
- 4 edits2 copies in branches/safari-601-branch
Merged r192389. rdar://problem/23787083
- 12:50 AM Changeset in webkit [193734] by
-
- 4 edits6 copies in branches/safari-601-branch
Merged r192369. rdar://problem/23787108
- 12:49 AM Changeset in webkit [193733] by
-
- 3 edits2 copies in branches/safari-601-branch
Merged r192316. rdar://problem/23787100
- 12:47 AM Changeset in webkit [193732] by
-
- 4 edits2 copies in branches/safari-601-branch
Merged r192281. rdar://problem/23787092
- 12:45 AM Changeset in webkit [193731] by
-
- 2 edits in branches/safari-601.4-branch/Source/WebCore
Merged r191748. rdar://problem/23787113
- 12:45 AM Changeset in webkit [193730] by
-
- 2 edits in branches/safari-601.4-branch/Source/WebCore
Merged r191746. rdar://problem/23787113
- 12:44 AM Changeset in webkit [193729] by
-
- 7 edits2 copies in branches/safari-601.4-branch
Merged r191731. rdar://problem/23787113
- 12:42 AM Changeset in webkit [193728] by
-
- 4 edits5 copies in branches/safari-601.4-branch
Merged r192604. rdar://problem/23787086
- 12:41 AM Changeset in webkit [193727] by
-
- 3 edits2 copies in branches/safari-601.4-branch
Merged r192433. rdar://problem/23787115
- 12:40 AM Changeset in webkit [193726] by
-
- 4 edits2 copies in branches/safari-601.4-branch
Merged r192389. rdar://problem/23787083
- 12:38 AM Changeset in webkit [193725] by
-
- 4 edits6 copies in branches/safari-601.4-branch
Merged r192369. rdar://problem/23787108
- 12:36 AM Changeset in webkit [193724] by
-
- 3 edits2 copies in branches/safari-601.4-branch
Merged r192316. rdar://problem/23787100
- 12:36 AM Changeset in webkit [193723] by
-
- 8 edits in trunk/Source/WebCore
[ThreadedCompositor] Support WebGL for OpenGL.
https://bugs.webkit.org/show_bug.cgi?id=143300
Reviewed by Žan Doberšek.
To remove pixel transfer operation, this patch adds m_compositorFBO which uses same depth and stencil
buffer with m_fbo but uses m_compositorTexture as a color attachment in GraphicsContext3D.
Because switching target framebuffer is cheaper than pixel transfer operation and switching color
attachment of m_fbo. In Threaded Compositor, when WebGL renders a scene, prepareTexture swaps
m_fbo with m_compositorFBO and send the color attachment to the compositor thread.
This patch only supports WebGL for OpenGL. OpenGLES will be covered in following-up patches.
No new tests needed.
- platform/graphics/GraphicsContext3D.h:
- platform/graphics/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::proxy):
(WebCore::GraphicsContext3DPrivate::swapBuffersIfNeeded):
Implement interfaces to pass a rendered texture to the compositing
thread.
- platform/graphics/GraphicsContext3DPrivate.h:
- platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::~GraphicsContext3D):
Create additional compositing texture and FBO to swaping buffers for
threaded compositor.
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::reshapeFBOs):
(WebCore::GraphicsContext3D::attachDepthAndStencilBufferIfNeeded):
Split attaching depth and stencil buffer codes from reshapeFBOs
to make complete framebuffer with not only m_fbo but m_compositorFBO also.
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::prepareTexture):
If we are in the threaded compositor, we will swap m_fbo with
m_compositorFBO instead of copying it.
- 12:35 AM Changeset in webkit [193722] by
-
- 4 edits2 copies in branches/safari-601.4-branch
Merged r192281. rdar://problem/23787092
- 12:26 AM Changeset in webkit [193721] by
-
- 9 edits in trunk
[GTK] Notify WebCore when notification is clicked
https://bugs.webkit.org/show_bug.cgi?id=151951
Reviewed by Carlos Garcia Campos.
Source/WebKit2:
- UIProcess/API/gtk/WebKitNotification.cpp:
(webkit_notification_class_init): new clicked signal.
(webkit_notification_clicked): method to emit the clicked signal.
- UIProcess/API/gtk/WebKitNotification.h:
- UIProcess/API/gtk/WebKitNotificationProvider.cpp:
(WebKitNotificationProvider::notificationClickedCallback): handle the clicked signal and tell WebProcess about the click.
(WebKitNotificationProvider::show): connect to the clicked signal in addition to closed.
- UIProcess/API/gtk/WebKitNotificationProvider.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(notifyNotificationClicked): handle the click on our libnotify notification.
(webkitWebViewShowNotification): add the "default" action to our libnotify notification to be notified of the click.
- UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
Tools:
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
(testWebViewNotification): test the new API.
- 12:17 AM Changeset in webkit [193720] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebCore
Merged r191748. rdar://problem/23787044
- 12:17 AM Changeset in webkit [193719] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebCore
Merged r191746. rdar://problem/23787044
- 12:16 AM Changeset in webkit [193718] by
-
- 7 edits2 copies in branches/safari-601.1.46-branch
Merged r191731. rdar://problem/23787044
- 12:15 AM Changeset in webkit [193717] by
-
- 4 edits5 copies in branches/safari-601.1.46-branch
Merged r192604. rdar://problem/23786994
- 12:13 AM Changeset in webkit [193716] by
-
- 3 edits2 copies in branches/safari-601.1.46-branch
Merged r192433. rdar://problem/23787047
- 12:12 AM Changeset in webkit [193715] by
-
- 4 edits2 copies in branches/safari-601.1.46-branch
Merged r192389. rdar://problem/23786983
- 12:11 AM Changeset in webkit [193714] by
-
- 4 edits6 copies in branches/safari-601.1.46-branch
Merged r192369. rdar://problem/23787037
- 12:10 AM Changeset in webkit [193713] by
-
- 3 edits2 copies in branches/safari-601.1.46-branch
Merged r192316. rdar://problem/23787021
- 12:08 AM Changeset in webkit [193712] by
-
- 4 edits2 copies in branches/safari-601.1.46-branch
Merged r192281. rdar://problem/23787006
- 12:01 AM Changeset in webkit [193711] by
-
- 2 edits in branches/safari-601.1.46.60-branch/Source/WebCore
Merged r191748. rdar://problem/23787044
- 12:00 AM Changeset in webkit [193710] by
-
- 2 edits in branches/safari-601.1.46.60-branch/Source/WebCore
Merged r191746. rdar://problem/23787044
Dec 7, 2015:
- 11:59 PM Changeset in webkit [193709] by
-
- 7 edits2 copies in branches/safari-601.1.46.60-branch
Merged r191731. rdar://problem/23787044
- 11:55 PM Changeset in webkit [193708] by
-
- 4 edits5 copies in branches/safari-601.1.46.60-branch
Merged r192604. rdar://problem/23786994
- 11:53 PM Changeset in webkit [193707] by
-
- 3 edits2 copies in branches/safari-601.1.46.60-branch
Merged r192433. rdar://problem/23787047
- 11:51 PM Changeset in webkit [193706] by
-
- 4 edits2 copies in branches/safari-601.1.46.60-branch
Merged r192389. rdar://problem/23786983
- 11:50 PM Changeset in webkit [193705] by
-
- 4 edits6 copies in branches/safari-601.1.46.60-branch
Merged r192369. rdar://problem/23787037
- 11:48 PM Changeset in webkit [193704] by
-
- 3 edits2 copies in branches/safari-601.1.46.60-branch
Merged r192316. rdar://problem/23787021
- 11:46 PM Changeset in webkit [193703] by
-
- 4 edits2 copies in branches/safari-601.1.46.60-branch
Merged r192281. rdar://problem/23787006
- 9:41 PM Changeset in webkit [193702] by
-
- 27 edits4 adds in branches/safari-601.1.46-branch
Merge r192992. rdar://problem/23769716
- 9:41 PM Changeset in webkit [193701] by
-
- 10 edits2 adds in branches/safari-601.1.46-branch
Merge r192732. rdar://problem/23769731
- 9:41 PM Changeset in webkit [193700] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebKit/mac
Merge r191261. rdar://problem/23769749
- 9:41 PM Changeset in webkit [193699] by
-
- 10 edits in branches/safari-601.1.46-branch/Source
Merge r191260. rdar://problem/23769749
- 9:40 PM Changeset in webkit [193698] by
-
- 4 edits in branches/safari-601.1.46-branch
Merge r191251. rdar://problem/23769757
- 9:40 PM Changeset in webkit [193697] by
-
- 4 edits in branches/safari-601.1.46-branch
Merge r190876. rdar://problem/23769722
- 9:40 PM Changeset in webkit [193696] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebCore
Merge r192367. rdar://problem/23769708
- 9:40 PM Changeset in webkit [193695] by
-
- 2 edits in branches/safari-601.1.46-branch/LayoutTests
Merge r191986. rdar://problem/23769708
- 9:40 PM Changeset in webkit [193694] by
-
- 21 edits7 adds in branches/safari-601.1.46-branch
Merge r191968. rdar://problem/23769708
- 9:40 PM Changeset in webkit [193693] by
-
- 14 edits2 adds in branches/safari-601.1.46-branch
Merge r191331. rdar://problem/23769700
- 9:40 PM Changeset in webkit [193692] by
-
- 26 edits1 delete in branches/safari-601.1.46-branch/Source
Merge r191014. rdar://problem/23769740
- 9:37 PM Changeset in webkit [193691] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebCore
Build fix.
- 9:05 PM Changeset in webkit [193690] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebCore
Merge r193635. rdar://problem/23785592
- 8:59 PM Changeset in webkit [193689] by
-
- 2 edits in trunk/LayoutTests
Move an IDB test from the "generic failure" section to the "fails because no workers" section.
Rubberstamped by Andy Estes.
- platform/mac-wk1/TestExpectations:
- 8:34 PM Changeset in webkit [193688] by
-
- 3 edits in trunk/Source/WebCore
Make paintTextWithShadows a member function (TextPainter).
https://bugs.webkit.org/show_bug.cgi?id=151979
Reviewed by Simon Fraser.
This patch also simplifies paintTextWithShadows and
rearranges some of the functions' arguments.
No change in functionality.
- rendering/TextPainter.cpp:
(WebCore::TextPainter::drawTextOrEmphasisMarks):
(WebCore::TextPainter::paintTextWithShadows):
(WebCore::TextPainter::paintEmphasisMarksIfNeeded):
(WebCore::TextPainter::paintTextWithStyle):
(WebCore::TextPainter::paintText):
(WebCore::drawTextOrEmphasisMarks): Deleted.
(WebCore::paintTextWithShadows): Deleted.
- rendering/TextPainter.h:
- 8:05 PM Changeset in webkit [193687] by
-
- 2 edits in trunk/Source/JavaScriptCore
Small style fixes in B3MoveConstants.cpp
https://bugs.webkit.org/show_bug.cgi?id=151980
Reviewed by Benjamin Poulain.
- b3/B3MoveConstants.cpp:
- 7:35 PM Changeset in webkit [193686] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] On x86, we should XOR registers instead of moving a zero immediate
https://bugs.webkit.org/show_bug.cgi?id=151977
Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-12-07
Reviewed by Filip Pizlo.
It is smaller and the frontend has special support
for xor.
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::move):
(JSC::MacroAssemblerX86Common::signExtend32ToPtr):
- 7:23 PM Changeset in webkit [193685] by
-
- 4 edits in trunk/PerformanceTests
Update suites for benchmark
https://bugs.webkit.org/show_bug.cgi?id=151957
Reviewed by Simon Fraser.
- Animometer/runner/animometer.html: Use spacers instead of relying on
justify-content center to center the content. That allows the opening screen
to grow downward when expanding the list of choices, otherwise it expands
from the center, and off the top edge of the screen.
- Animometer/runner/resources/animometer.css:
(.tree): Don't overflow scroll.
(.tree > li > label.tree-label:before): Use better glyphs.
(.tree > li > :checked ~ label.tree-label:before):
(main): Using flex-start for justify-content so that if the section grows too
big it gets pinned to the top edge of the document instead of growing past it.
(.spacer): Make the spacers have a minimum 20px and grow evenly.
(section#home): Add a min-height so that the border will expand if the suite
tests shown make the section grow past the height.
- Animometer/runner/resources/animometer.js: Update the selectors.
(window.suitesManager._treeElement):
(window.suitesManager._suitesElements):
(window.suitesManager._editsElements):
- 7:04 PM Changeset in webkit [193684] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix a typo from r193683
Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-12-07
- ftl/FTLCommonValues.cpp:
(JSC::FTL::CommonValues::CommonValues):
- 6:56 PM Changeset in webkit [193683] by
-
- 35 edits4 adds in trunk/Source/JavaScriptCore
[JSC] Add Float support to B3
https://bugs.webkit.org/show_bug.cgi?id=151974
Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-12-07
Reviewed by Filip Pizlo.
This patch adds comprehensive float support to B3.
The new phase reduceDoubleToFloat() gives us a primitive
version of what LLVM was giving us on floats.
It needs to support conversions accross Phis but that can
be added later.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::moveDoubleConditionallyFloat):
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::sqrtFloat):
(JSC::MacroAssemblerX86Common::loadFloat):
(JSC::MacroAssemblerX86Common::storeFloat):
(JSC::MacroAssemblerX86Common::convertDoubleToFloat):
(JSC::MacroAssemblerX86Common::convertFloatToDouble):
(JSC::MacroAssemblerX86Common::addFloat):
(JSC::MacroAssemblerX86Common::divFloat):
(JSC::MacroAssemblerX86Common::subFloat):
(JSC::MacroAssemblerX86Common::mulFloat):
(JSC::MacroAssemblerX86Common::branchDouble):
(JSC::MacroAssemblerX86Common::branchFloat):
(JSC::MacroAssemblerX86Common::moveConditionallyDouble):
(JSC::MacroAssemblerX86Common::moveConditionallyFloat):
(JSC::MacroAssemblerX86Common::jumpAfterFloatingPointCompare):
(JSC::MacroAssemblerX86Common::moveConditionallyAfterFloatingPointCompare):
- assembler/X86Assembler.h:
(JSC::X86Assembler::addss_rr):
(JSC::X86Assembler::addss_mr):
(JSC::X86Assembler::cvtsd2ss_mr):
(JSC::X86Assembler::cvtss2sd_mr):
(JSC::X86Assembler::movss_rm):
(JSC::X86Assembler::movss_mr):
(JSC::X86Assembler::mulss_rr):
(JSC::X86Assembler::mulss_mr):
(JSC::X86Assembler::subss_rr):
(JSC::X86Assembler::subss_mr):
(JSC::X86Assembler::ucomiss_rr):
(JSC::X86Assembler::ucomiss_mr):
(JSC::X86Assembler::divss_rr):
(JSC::X86Assembler::divss_mr):
(JSC::X86Assembler::sqrtss_rr):
(JSC::X86Assembler::sqrtss_mr):
- b3/B3Const32Value.cpp:
(JSC::B3::Const32Value::bitwiseCastConstant):
- b3/B3Const32Value.h:
- b3/B3ConstDoubleValue.cpp:
(JSC::B3::ConstDoubleValue::doubleToFloatConstant):
(JSC::B3::ConstDoubleValue::sqrtConstant):
- b3/B3ConstDoubleValue.h:
- b3/B3ConstFloatValue.cpp: Added.
(JSC::B3::ConstFloatValue::~ConstFloatValue):
(JSC::B3::ConstFloatValue::negConstant):
(JSC::B3::ConstFloatValue::addConstant):
(JSC::B3::ConstFloatValue::subConstant):
(JSC::B3::ConstFloatValue::mulConstant):
(JSC::B3::ConstFloatValue::bitwiseCastConstant):
(JSC::B3::ConstFloatValue::floatToDoubleConstant):
(JSC::B3::ConstFloatValue::sqrtConstant):
(JSC::B3::ConstFloatValue::divConstant):
(JSC::B3::ConstFloatValue::equalConstant):
(JSC::B3::ConstFloatValue::notEqualConstant):
(JSC::B3::ConstFloatValue::lessThanConstant):
(JSC::B3::ConstFloatValue::greaterThanConstant):
(JSC::B3::ConstFloatValue::lessEqualConstant):
(JSC::B3::ConstFloatValue::greaterEqualConstant):
(JSC::B3::ConstFloatValue::dumpMeta):
- b3/B3ConstFloatValue.h: Copied from Source/JavaScriptCore/b3/B3ConstDoubleValue.h.
- b3/B3Generate.cpp:
(JSC::B3::generateToAir):
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::tryOpcodeForType):
(JSC::B3::Air::LowerToAir::opcodeForType):
(JSC::B3::Air::LowerToAir::appendUnOp):
(JSC::B3::Air::LowerToAir::appendBinOp):
(JSC::B3::Air::LowerToAir::appendShift):
(JSC::B3::Air::LowerToAir::tryAppendStoreUnOp):
(JSC::B3::Air::LowerToAir::tryAppendStoreBinOp):
(JSC::B3::Air::LowerToAir::moveForType):
(JSC::B3::Air::LowerToAir::relaxedMoveForType):
(JSC::B3::Air::LowerToAir::createGenericCompare):
(JSC::B3::Air::LowerToAir::createBranch):
(JSC::B3::Air::LowerToAir::createCompare):
(JSC::B3::Air::LowerToAir::createSelect):
(JSC::B3::Air::LowerToAir::lower):
- b3/B3MemoryValue.cpp:
(JSC::B3::MemoryValue::accessByteSize): Deleted.
- b3/B3MemoryValue.h:
- b3/B3MoveConstants.cpp:
- b3/B3Opcode.cpp:
(WTF::printInternal):
- b3/B3Opcode.h:
- b3/B3Procedure.cpp:
(JSC::B3::Procedure::addIntConstant):
- b3/B3ReduceDoubleToFloat.cpp: Added.
(JSC::B3::reduceDoubleToFloat):
- b3/B3ReduceDoubleToFloat.h: Copied from Source/JavaScriptCore/b3/B3Type.cpp.
- b3/B3ReduceStrength.cpp:
- b3/B3Type.cpp:
(WTF::printInternal):
- b3/B3Type.h:
(JSC::B3::isFloat):
(JSC::B3::sizeofType):
- b3/B3Validate.cpp:
- b3/B3Value.cpp:
(JSC::B3::Value::doubleToFloatConstant):
(JSC::B3::Value::floatToDoubleConstant):
(JSC::B3::Value::sqrtConstant):
(JSC::B3::Value::asTriState):
(JSC::B3::Value::effects):
(JSC::B3::Value::key):
(JSC::B3::Value::checkOpcode):
(JSC::B3::Value::typeFor):
- b3/B3Value.h:
- b3/B3ValueInlines.h:
(JSC::B3::Value::isConstant):
(JSC::B3::Value::hasFloat):
(JSC::B3::Value::asFloat):
(JSC::B3::Value::hasNumber):
(JSC::B3::Value::isNegativeZero):
(JSC::B3::Value::representableAs):
(JSC::B3::Value::asNumber):
- b3/B3ValueKey.cpp:
(JSC::B3::ValueKey::materialize):
- b3/B3ValueKey.h:
(JSC::B3::ValueKey::ValueKey):
(JSC::B3::ValueKey::floatValue):
- b3/air/AirArg.h:
(JSC::B3::Air::Arg::typeForB3Type):
(JSC::B3::Air::Arg::widthForB3Type):
- b3/air/AirFixPartialRegisterStalls.cpp:
- b3/air/AirOpcode.opcodes:
- b3/testb3.cpp:
(JSC::B3::testAddArgFloat):
(JSC::B3::testAddArgsFloat):
(JSC::B3::testAddArgImmFloat):
(JSC::B3::testAddImmArgFloat):
(JSC::B3::testAddImmsFloat):
(JSC::B3::testAddArgFloatWithUselessDoubleConversion):
(JSC::B3::testAddArgsFloatWithUselessDoubleConversion):
(JSC::B3::testAddArgsFloatWithEffectfulDoubleConversion):
(JSC::B3::testMulArgFloat):
(JSC::B3::testMulArgsFloat):
(JSC::B3::testMulArgImmFloat):
(JSC::B3::testMulImmArgFloat):
(JSC::B3::testMulImmsFloat):
(JSC::B3::testMulArgFloatWithUselessDoubleConversion):
(JSC::B3::testMulArgsFloatWithUselessDoubleConversion):
(JSC::B3::testMulArgsFloatWithEffectfulDoubleConversion):
(JSC::B3::testDivArgFloat):
(JSC::B3::testDivArgsFloat):
(JSC::B3::testDivArgImmFloat):
(JSC::B3::testDivImmArgFloat):
(JSC::B3::testDivImmsFloat):
(JSC::B3::testDivArgFloatWithUselessDoubleConversion):
(JSC::B3::testDivArgsFloatWithUselessDoubleConversion):
(JSC::B3::testDivArgsFloatWithEffectfulDoubleConversion):
(JSC::B3::testSubArgFloat):
(JSC::B3::testSubArgsFloat):
(JSC::B3::testSubArgImmFloat):
(JSC::B3::testSubImmArgFloat):
(JSC::B3::testSubImmsFloat):
(JSC::B3::testSubArgFloatWithUselessDoubleConversion):
(JSC::B3::testSubArgsFloatWithUselessDoubleConversion):
(JSC::B3::testSubArgsFloatWithEffectfulDoubleConversion):
(JSC::B3::testClzMem32):
(JSC::B3::testSqrtArg):
(JSC::B3::testSqrtImm):
(JSC::B3::testSqrtMem):
(JSC::B3::testSqrtArgWithUselessDoubleConversion):
(JSC::B3::testSqrtArgWithEffectfulDoubleConversion):
(JSC::B3::testDoubleArgToInt64BitwiseCast):
(JSC::B3::testDoubleImmToInt64BitwiseCast):
(JSC::B3::testTwoBitwiseCastOnDouble):
(JSC::B3::testBitwiseCastOnDoubleInMemory):
(JSC::B3::testInt64BArgToDoubleBitwiseCast):
(JSC::B3::testInt64BImmToDoubleBitwiseCast):
(JSC::B3::testTwoBitwiseCastOnInt64):
(JSC::B3::testBitwiseCastOnInt64InMemory):
(JSC::B3::testFloatImmToInt32BitwiseCast):
(JSC::B3::testBitwiseCastOnFloatInMemory):
(JSC::B3::testInt32BArgToFloatBitwiseCast):
(JSC::B3::testInt32BImmToFloatBitwiseCast):
(JSC::B3::testTwoBitwiseCastOnInt32):
(JSC::B3::testBitwiseCastOnInt32InMemory):
(JSC::B3::testConvertDoubleToFloatArg):
(JSC::B3::testConvertDoubleToFloatImm):
(JSC::B3::testConvertDoubleToFloatMem):
(JSC::B3::testConvertFloatToDoubleArg):
(JSC::B3::testConvertFloatToDoubleImm):
(JSC::B3::testConvertFloatToDoubleMem):
(JSC::B3::testConvertDoubleToFloatToDoubleToFloat):
(JSC::B3::testLoadFloatConvertDoubleConvertFloatStoreFloat):
(JSC::B3::testFroundArg):
(JSC::B3::testFroundMem):
(JSC::B3::testStore32):
(JSC::B3::modelLoad):
(JSC::B3::float>):
(JSC::B3::double>):
(JSC::B3::testLoad):
(JSC::B3::testStoreFloat):
(JSC::B3::testReturnFloat):
(JSC::B3::simpleFunctionFloat):
(JSC::B3::testCallSimpleFloat):
(JSC::B3::functionWithHellaFloatArguments):
(JSC::B3::testCallFunctionWithHellaFloatArguments):
(JSC::B3::testSelectCompareFloat):
(JSC::B3::testSelectCompareFloatToDouble):
(JSC::B3::testSelectDoubleCompareFloat):
(JSC::B3::testSelectFloatCompareFloat):
(JSC::B3::populateWithInterestingValues):
(JSC::B3::floatingPointOperands):
(JSC::B3::int64Operands):
(JSC::B3::run):
(JSC::B3::testStore): Deleted.
(JSC::B3::posInfinity): Deleted.
(JSC::B3::negInfinity): Deleted.
(JSC::B3::doubleOperands): Deleted.
- ftl/FTLB3Output.cpp:
(JSC::FTL::Output::loadFloatToDouble):
- ftl/FTLB3Output.h:
(JSC::FTL::Output::fround):
- ftl/FTLCommonValues.cpp:
(JSC::FTL::CommonValues::CommonValues):
- ftl/FTLCommonValues.h:
- 6:46 PM Changeset in webkit [193682] by
-
- 21 edits2 adds in trunk/Source
FTL B3 should be able to flag the tag constants as being super important so that B3 can hoist them and Air can force them into registers
https://bugs.webkit.org/show_bug.cgi?id=151955
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Taught B3 about the concept of "fast constants". A client of B3 can now tell B3 which
constants are super important. B3 will not spill the constant in that case and will ensure
that the constant is materialized only once: statically once, and dynamically once per
procedure execution. The hoistFastConstants() algorithm in B3MoveConstants.cpp achieves this
by first picking the lowest common dominator of all uses of each fast constant, and then
picking the materialization point by finding the lowest dominator of that dominator that is
tied for lowest block frequency. In practice, the second step ensures that this is the lowest
point in the program that is not in a loop (i.e. executes no more than once dynamically per
procedure invocation).
Taught Air about the concept of "fast tmps". B3 tells Air that a tmp is fast if it is used to
hold the materialization of a fast constant. IRC will use the lowest possible spill score for
fast tmps. In practice, this ensures that fast constants are never spilled.
Added a small snippet of code to FTL::LowerDFGToLLVM that makes both of the tag constants
into fast constants.
My hope is that this very brute-force heuristic is good enough that we don't have to think
about constants for a while. Based on my experience with how LLVM's constant hoisting works
out, the heuristic in this patch is going to be tough to beat. LLVM's constant hoisting does
good things when it hoists the tags, and usually causes nothing but problems when it hoists
anything else. This is because there is no way a low-level compiler to really understand how
a constant materialization impacts some operation's contribution to the overall execution
time of a procedure. But, in the FTL we know that constant materializations for type checks
are a bummer because we are super comfortable placing type checks on the hottest of paths. So
those are the last paths where extra instructions should be added by the compiler. On the
other hand, all other large constant uses are on relatively cold paths, or paths that are
already expensive for other reasons. For example, global variable accesses have to
materialize a pointer to the global. But that's not really a big deal, since a load from a
global involves first the load itself and then type checks on the result - so probably the
constant materialization is just not interesting. A store to a global often involves a store
barrier, so the constant materialization is really not interesting. This patch codifies this
heuristic in a pact between Air, B3, and the FTL: FTL demands that B3 pin the two tags in
registers, and B3 relays the demand to Air.
- JavaScriptCore.xcodeproj/project.pbxproj:
- b3/B3CFG.h: Added.
(JSC::B3::CFG::CFG):
(JSC::B3::CFG::root):
(JSC::B3::CFG::newMap):
(JSC::B3::CFG::successors):
(JSC::B3::CFG::predecessors):
(JSC::B3::CFG::index):
(JSC::B3::CFG::node):
(JSC::B3::CFG::numNodes):
(JSC::B3::CFG::dump):
- b3/B3Dominators.h: Added.
(JSC::B3::Dominators::Dominators):
- b3/B3IndexMap.h:
(JSC::B3::IndexMap::resize):
(JSC::B3::IndexMap::size):
(JSC::B3::IndexMap::operator[]):
- b3/B3LowerMacros.cpp:
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::tmp):
- b3/B3MoveConstants.cpp:
- b3/B3Opcode.h:
(JSC::B3::constPtrOpcode):
(JSC::B3::isConstant):
- b3/B3Procedure.cpp:
(JSC::B3::Procedure::Procedure):
(JSC::B3::Procedure::resetReachability):
(JSC::B3::Procedure::invalidateCFG):
(JSC::B3::Procedure::dump):
(JSC::B3::Procedure::deleteValue):
(JSC::B3::Procedure::dominators):
(JSC::B3::Procedure::addFastConstant):
(JSC::B3::Procedure::isFastConstant):
(JSC::B3::Procedure::addDataSection):
- b3/B3Procedure.h:
(JSC::B3::Procedure::size):
(JSC::B3::Procedure::cfg):
(JSC::B3::Procedure::setLastPhaseName):
- b3/B3ReduceStrength.cpp:
- b3/B3ValueInlines.h:
(JSC::B3::Value::isConstant):
(JSC::B3::Value::isInteger):
- b3/B3ValueKey.h:
(JSC::B3::ValueKey::canMaterialize):
(JSC::B3::ValueKey::isConstant):
- b3/air/AirCode.cpp:
(JSC::B3::Air::Code::findNextBlock):
(JSC::B3::Air::Code::addFastTmp):
- b3/air/AirCode.h:
(JSC::B3::Air::Code::specials):
(JSC::B3::Air::Code::isFastTmp):
(JSC::B3::Air::Code::setLastPhaseName):
- b3/air/AirIteratedRegisterCoalescing.cpp:
- dfg/DFGDominators.h:
- dfg/DFGSSACalculator.cpp:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::lower):
Source/WTF:
Remove some remaining DFG-specific snippets from Dominators. This used to be a non-template
DFG class, and some time ago I hoisted it into WTF and made it generic. But since the only
user of the class was the DFG, this class still had a handful of DFG-specific snippets that
didn't compile when I started using it from B3.
Also renamed immediateDominatorOf() to idom(). This is the sort of abbreviation that we
wouldn't ordinarily want to have in WebKit. But WebKit does allow for abbreviations that are
"more canonical". The term "idom" is definitely more canonical than "immediateDominatorOf".
- wtf/Dominators.h:
(WTF::Dominators::dominates):
(WTF::Dominators::idom):
(WTF::Dominators::forAllStrictDominatorsOf):
(WTF::Dominators::NaiveDominators::dominates):
(WTF::Dominators::NaiveDominators::dump):
(WTF::Dominators::ValidationContext::handleErrors):
- 6:38 PM Changeset in webkit [193681] by
-
- 27 edits3 adds in branches/safari-601-branch
Merge r192992. rdar://problem/23769780
- 6:38 PM Changeset in webkit [193680] by
-
- 10 edits2 adds in branches/safari-601-branch
Merge r192732. rdar://problem/23769794
- 6:14 PM Changeset in webkit [193679] by
-
- 3 edits3 adds in trunk
[INTL] Implement String.prototype.toLocaleUpperCase in ECMA-402
https://bugs.webkit.org/show_bug.cgi?id=147609
Patch by Andy VanWagoner <thetalecrafter@gmail.com> on 2015-12-07
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
Refactor most of toLocaleLowerCase to static function used by both
toLocaleUpperCase and toLocaleLowerCase.
Add toLocaleUpperCase using icu u_strToUpper.
- runtime/StringPrototype.cpp:
(JSC::StringPrototype::finishCreation):
(JSC::toLocaleCase):
(JSC::stringProtoFuncToLocaleLowerCase):
(JSC::stringProtoFuncToLocaleUpperCase):
LayoutTests:
- js/script-tests/string-toLocaleUpperCase.js: Added.
- js/string-toLocaleUpperCase-expected.txt: Added.
- js/string-toLocaleUpperCase.html: Added.
- 5:53 PM Changeset in webkit [193678] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Follow-up merge of r191014. rdar://problem/23769801
- 5:42 PM Changeset in webkit [193677] by
-
- 2 edits in trunk/Websites/webkit.org
Implemented a workaround for sharp SVG WebKit logo.
https://bugs.webkit.org/show_bug.cgi?id=151971
Reviewed by Timothy Hatcher.
- wp-content/themes/webkit/images/webkit.svg:
- 5:11 PM Changeset in webkit [193676] by
-
- 2 edits in trunk/Source/WebKit/mac
Build fix after r193675.
- WebView/WebViewData.h:
- 4:59 PM Changeset in webkit [193675] by
-
- 2 edits in trunk/Source/WebKit/mac
Build fix after r193661.
Reviewed by Beth Dakin.
- WebView/WebViewData.h:
- 4:31 PM Changeset in webkit [193674] by
-
- 4 edits in trunk/Source/JavaScriptCore
CRASH: CodeBlock::setOptimizationThresholdBasedOnCompilationResult + 567
https://bugs.webkit.org/show_bug.cgi?id=151892
Reviewed by Geoffrey Garen.
Reverted the change made in change set r193491.
The updated change is to finish all concurrent compilations and install the resulting
code blocks before we make any state changes due to debugger activity. After all code
blocks have been installed, we make the debugger state changes, including jettisoning
all optimized code blocks.
This means that we will discard the optimized code blocks we just installed,
but we won't do that while on the install code block path.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::setOptimizationThresholdBasedOnCompilationResult): Reverted r193491.
- debugger/Debugger.cpp:
(JSC::Debugger::setSteppingMode):
(JSC::Debugger::registerCodeBlock):
(JSC::Debugger::toggleBreakpoint):
(JSC::Debugger::clearBreakpoints):
(JSC::Debugger::clearDebuggerRequests):
Call Heap::completeAllDFGPlans() before updating code blocks for debugging changes.
- heap/Heap.h: Made completeAllDFGPlans() public.
- 4:23 PM Changeset in webkit [193673] by
-
- 2 edits in branches/safari-601-branch/Source/WebKit/mac
Merge r191261. rdar://problem/23769808
- 4:23 PM Changeset in webkit [193672] by
-
- 10 edits in branches/safari-601-branch/Source
Merge r191260. rdar://problem/23769808
- 4:23 PM Changeset in webkit [193671] by
-
- 4 edits in branches/safari-601-branch
Merge r191251. rdar://problem/23769811
- 4:23 PM Changeset in webkit [193670] by
-
- 4 edits in branches/safari-601-branch
Merge r190876. rdar://problem/23769786
- 4:23 PM Changeset in webkit [193669] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Merge r192367. rdar://problem/23769775
- 4:23 PM Changeset in webkit [193668] by
-
- 2 edits in branches/safari-601-branch/LayoutTests
Merge r191986. rdar://problem/23769775
- 4:23 PM Changeset in webkit [193667] by
-
- 21 edits in branches/safari-601-branch
Merge r191968. rdar://problem/23769775
- 4:23 PM Changeset in webkit [193666] by
-
- 14 edits in branches/safari-601-branch
Merge r191331. rdar://problem/23769766
- 4:23 PM Changeset in webkit [193665] by
-
- 26 edits1 delete in branches/safari-601-branch/Source
Merge r191014. rdar://problem/23769801
- 4:22 PM Changeset in webkit [193664] by
-
- 7 edits in trunk/Source/WebKit2
Unreviewed, rolling out r193655.
https://bugs.webkit.org/show_bug.cgi?id=151970
This change broke existing LayoutTests on mac-wk2 (Requested
by ryanhaddad on #webkit).
Reverted changeset:
"UIProcess should determine AppNap state for WebPage"
https://bugs.webkit.org/show_bug.cgi?id=151964
http://trac.webkit.org/changeset/193655
- 4:08 PM Changeset in webkit [193663] by
-
- 2 edits in trunk/LayoutTests
[Mac] Remove Mavericks-specific TestExpectations lines
https://bugs.webkit.org/show_bug.cgi?id=151913
Reviewed by Alexey Proskuryakov.
Mavericks is no longer a supported OS.
- platform/mac/TestExpectations:
- 4:02 PM Changeset in webkit [193662] by
-
- 4 edits in trunk/Source/JavaScriptCore
FTL lowering should tell B3 the right block frequencies
https://bugs.webkit.org/show_bug.cgi?id=151531
Reviewed by Geoffrey Garen.
This glues together the DFG's view of basic block execution counts and B3's block frequencies.
This further improves our performance on imaging-gaussian-blur. It appears to improve the steady
state throughput by almost 4%.
- ftl/FTLB3Output.h:
(JSC::FTL::Output::setFrequency):
(JSC::FTL::Output::newBlock):
(JSC::FTL::Output::insertNewBlocksBefore):
(JSC::FTL::Output::callWithoutSideEffects):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::lower):
(JSC::FTL::DFG::LowerDFGToLLVM::compileBlock):
- ftl/FTLOutput.h:
(JSC::FTL::Output::setFrequency):
(JSC::FTL::Output::insertNewBlocksBefore):
- 3:47 PM Changeset in webkit [193661] by
-
- 5 edits in trunk/Source/WebKit/mac
Add support for WebViewAdditions
https://bugs.webkit.org/show_bug.cgi?id=151967
Reviewed by Sam Weinig.
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::respondToChangedSelection):
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView updateWebViewAdditions]):
- WebView/WebViewData.h:
- WebView/WebViewInternal.h:
- 3:43 PM Changeset in webkit [193660] by
-
- 2 edits6 deletes in trunk/LayoutTests
Modern IDB: Miscellaneous test cleanup.
https://bugs.webkit.org/show_bug.cgi?id=151968
Reviewed by Sam Weinig.
- Reorganize TestExpectations a bit.
- Remove two tests that primarily test features that have been removed from the spec.
- platform/mac-wk1/TestExpectations:
- storage/indexeddb/cursor-continueprimarykey-expected.txt: Removed.
- storage/indexeddb/cursor-continueprimarykey.html: Removed.
- storage/indexeddb/factory-basics-expected.txt: Removed.
- storage/indexeddb/factory-basics.html: Removed.
- storage/indexeddb/resources/cursor-continueprimarykey.js: Removed.
- storage/indexeddb/resources/factory-basics.js: Removed.
- 3:15 PM Changeset in webkit [193659] by
-
- 2 edits in trunk/Source/JavaScriptCore
Update JSC feature list for rest parameters and generators
https://bugs.webkit.org/show_bug.cgi?id=151740
Reviewed by Joseph Pecoraro.
- features.json:
- 3:12 PM Changeset in webkit [193658] by
-
- 4 edits in trunk
Modern IDB: storage/indexeddb/factory-deletedatabase.html fails.
https://bugs.webkit.org/show_bug.cgi?id=151966
Source/WebCore:
Reviewed by Sam Weinig.
No new tests (At least one failing test now passes).
- Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp:
(WebCore::IDBClient::IDBOpenDBRequest::onDeleteDatabaseSuccess): The spec says that the result of
deleteDatabase should be undefined. Without explicitly making it undefined, it's incorrectly null.
LayoutTests:
Reviewed by Sam Weinig.
- platform/mac-wk1/TestExpectations:
- 3:07 PM Changeset in webkit [193657] by
-
- 7 edits in trunk
Modern IDB: storage/indexeddb/cursor-continue-validity.html fails.
https://bugs.webkit.org/show_bug.cgi?id=151961
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (At least one failing test now passes).
When an index cursor's iterator was invalidated, there were some cases where it did
not correctly find the next iterator to pick up where it left off.
- Modules/indexeddb/client/IDBCursorImpl.cpp:
(WebCore::IDBClient::IDBCursor::update):
(WebCore::IDBClient::IDBCursor::deleteFunction):
- Modules/indexeddb/server/IndexValueStore.cpp:
(WebCore::IDBServer::IndexValueStore::find):
(WebCore::IDBServer::IndexValueStore::loggingString):
- Modules/indexeddb/server/IndexValueStore.h:
LayoutTests:
- platform/mac-wk1/TestExpectations:
- storage/indexeddb/cursor-finished-expected.txt:
- 3:01 PM Changeset in webkit [193656] by
-
- 3 edits in trunk/Source/WebCore
Refactor TextPainter::paintText() into sub methods.
https://bugs.webkit.org/show_bug.cgi?id=151962
Reviewed by Myles C. Maxfield.
No change in functionality.
- rendering/TextPainter.cpp:
(WebCore::TextPainter::paintTextWithEmphasisIfNeeded):
(WebCore::TextPainter::paintTextWithStyle):
(WebCore::TextPainter::paintText):
- rendering/TextPainter.h:
- 2:52 PM Changeset in webkit [193655] by
-
- 7 edits in trunk/Source/WebKit2
UIProcess should determine AppNap state for WebPage
https://bugs.webkit.org/show_bug.cgi?id=151964
Reviewed by Anders Carlson.
Step 1 in unifying this with the iOS process suppression mechanism is to move the decision out of the WebContent process.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::dispatchViewStateChange):
(WebKit::WebPageProxy::setPageActivityState):
(WebKit::WebPageProxy::updateActivityToken):
(WebKit::WebPageProxy::preferencesDidChange):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::isInWindow):
(WebKit::WebPageProxy::didUpdateViewState):
- UIProcess/WebPageProxy.messages.in:
- WebPage now propagates PageActivityState to the WebPageProxy, for use determining the supression state of the WebProcess.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::m_shouldDispatchFakeMouseMoveEvents):
(WebKit::WebPage::setPageActivityState):
(WebKit::WebPage::setUserActivityStarted):
(WebKit::WebPage::setViewState):
(WebKit::WebPage::updatePreferences):
(WebKit::WebPage::updateUserActivity): Deleted.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebPage no longer determines when to update it's own UserActivity - instead, let the UI process do so. As such, no longer need to track whether process supression is enabled. Instead, add message to
- 2:44 PM Changeset in webkit [193654] by
-
- 3 edits in trunk/Source/WebKit2
[WK2] Regression(r187691): If a page is showing an auth pane in one tab, any new tabs with same page hang until credentials are entered in first tab
https://bugs.webkit.org/show_bug.cgi?id=151960
<rdar://problem/23618112>
Reviewed by Alex Christensen.
After r187691, if a page is showing an auth pane in one tab, any new
tabs with same page hang until credentials are entered in first tab.
This is because we coalescing all authentication challenges from the
same domain, no matter what tab they are for. This can be confusing
so we now only coalesce authentication challenges within each tab,
by leveraging the pageID (in addition to the domain).
- Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::shouldCoalesceChallenge):
(WebKit::AuthenticationManager::coalesceChallengesMatching):
(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):
- Shared/Authentication/AuthenticationManager.h:
- 2:32 PM Changeset in webkit [193653] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG ASSERTION FAILED: m_plan.weakReferences.contains(structure).
https://bugs.webkit.org/show_bug.cgi?id=151952
Reviewed by Mark Lam.
Fix a bug revealed by the new ftl-has-a-bad-time.js test. It turns out that our handling of
structures reachable from the compiler wasn't accounting for having a bad time.
- dfg/DFGStructureRegistrationPhase.cpp:
(JSC::DFG::StructureRegistrationPhase::run):
- 2:27 PM Changeset in webkit [193652] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
Merge r193635. rdar://problem/23581586
- 2:23 PM Changeset in webkit [193651] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Clean up virtual functions in MediaPlayerPrivateGStreamerBase
https://bugs.webkit.org/show_bug.cgi?id=151940
Reviewed by Carlos Garcia Campos.
- Using 'override' when appropriate
- Explicitly marking methods as virtual when they are inherently virtual
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
- 2:14 PM Changeset in webkit [193650] by
-
- 6 edits in trunk/PerformanceTests
Update options for benchmark
https://bugs.webkit.org/show_bug.cgi?id=151956
Reviewed by Simon Fraser.
Move "Fix test complexity" and "Adaptive" checkboxes into a radio group.
Move "Show running results" into a radio group, and add options to remove the HUD.
- Animometer/runner/animometer.html: Get rid of the preamble. Wrap the options
in a form for easier referencing in JS.
- Animometer/runner/resources/animometer.css: Show the surrounding border if the
body's display-minimal class name is set.
- Animometer/runner/resources/animometer.js:
Update the way optionsManager gets and sets default values. Include support for
radio groups.
(window.optionsManager.valueForOption):
(window.optionsManager.updateUIFromLocalStorage):
(window.optionsManager.updateLocalStorageFromUI):
(window.benchmarkRunnerClient.willStartFirstIteration):
(window.sectionsManager.setupRunningSectionStyle):
(window.suitesManager._treeElement): Fly-by whitespace fix.
(window.suitesManager._suitesElements): Ditto.
(window.suitesManager.updateEditsElementsState): Update options check.
(window.suitesManager.updateDisplay): Add a new update function for the HUD.
Attach a class to the body depending on the user's choice.
(window.benchmarkController.initialize): Add an event listener when the form
radio buttons update.
(window.benchmarkController.onFormChanged):
(window.optionsManager._optionsElements): Deleted.
(window.optionsManager._adaptiveTestElement): Deleted.
(window.benchmarkController.onChangeAdaptiveTestCheckbox): Deleted.
- Animometer/tests/resources/main.js:
(Benchmark.prototype.update): Update options checks.
- Animometer/tests/resources/stage.js: Update option check.
(StageBenchmark.prototype.showResults):
- 2:10 PM WebKitGTK/2.10.x edited by
- (diff)
- 2:03 PM Changeset in webkit [193649] by
-
- 23 edits in trunk/Source
Add op_watchdog opcode that is generated when VM has a watchdog
https://bugs.webkit.org/show_bug.cgi?id=151954
Reviewed by Mark Lam.
Source/JavaScriptCore:
This patch also makes watchdog a private member
of VM and adds a getter function.
- API/JSContextRef.cpp:
(JSContextGroupClearExecutionTimeLimit):
- bytecode/BytecodeList.json:
- bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitLoopHint):
(JSC::BytecodeGenerator::emitWatchdog):
(JSC::BytecodeGenerator::retrieveLastBinaryOp):
- bytecompiler/BytecodeGenerator.h:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileCheckWatchdogTimer):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_loop_hint):
(JSC::JIT::emitSlow_op_loop_hint):
(JSC::JIT::emit_op_watchdog):
(JSC::JIT::emitSlow_op_watchdog):
(JSC::JIT::emit_op_new_regexp):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter.asm:
- runtime/VM.cpp:
(JSC::VM::ensureWatchdog):
- runtime/VM.h:
(JSC::VM::watchdog):
- runtime/VMEntryScope.cpp:
(JSC::VMEntryScope::VMEntryScope):
(JSC::VMEntryScope::~VMEntryScope):
- runtime/VMInlines.h:
(JSC::VM::shouldTriggerTermination):
Source/WebCore:
No new tests because JSC already has tests for this.
- bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::scheduleExecutionTermination):
(WebCore::WorkerScriptController::isTerminatingExecution):
- 1:35 PM Changeset in webkit [193648] by
-
- 3 edits in trunk/Source/JavaScriptCore
Crashes on PPC64 due to mprotect() on address not aligned to the page size
https://bugs.webkit.org/show_bug.cgi?id=130237
Reviewed by Mark Lam.
Make sure that commitSize is at least as big as the page size.
- interpreter/JSStack.cpp:
(JSC::commitSize):
(JSC::JSStack::JSStack):
(JSC::JSStack::growSlowCase):
- interpreter/JSStack.h:
- 1:09 PM Changeset in webkit [193647] by
-
- 2 edits in trunk
Fix internal Windows build
https://bugs.webkit.org/show_bug.cgi?id=151950
Reviewed by Brent Fulgham.
- Source/cmake/tools/scripts/auto-version.pl:
- 12:57 PM Changeset in webkit [193646] by
-
- 6 edits1 move1 add1 delete in trunk/Source
Web Inspector: Uncaught Exception page should have better styles and handle more error cases
https://bugs.webkit.org/show_bug.cgi?id=151923
Reviewed by Timothy Hatcher.
Source/WebCore:
Add a check for InspectorFrontendAPI before calling it. This can fail
easily if an uncaught exception stalls initial loading, or whenever
the Inspector frontend is reloaded.
- inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::evaluateOnLoad):
Source/WebInspectorUI:
Restructure the Uncaught Exception reporting page to act more like
a modal sheet. Distinguish between uncaught exceptions before and
after the frontend is initially loaded. If the frontend is loaded,
add a clickable link that dismisses the sheet and ignores the error.
If the inspector finished loading, then only show at most one
exception at a time, since subsequent interactions can cause spurious
errors when the sheet is active.
Split existing code into multiple functions so it's easier to follow.
Add miscellaneous guards against internal corruption and weird cases.
- UserInterface/Base/Main.js:
(WebInspector.contentLoaded): Store the flag on the global object
in case WebInspector becomes shadowed or otherwise unusable.
- UserInterface/Debug/UncaughtExceptionReporter.css: Renamed from Source/WebInspectorUI/UserInterface/Debug/CatchEarlyErrors.css.
(div.sheet-container):
(div.uncaught-exception-sheet):
(div.uncaught-exception-sheet a):
(div.uncaught-exception-sheet a:active):
(div.uncaught-exception-sheet h2):
(div.uncaught-exception-sheet h1 > img):
(div.uncaught-exception-sheet h2 > img):
(div.uncaught-exception-sheet dl):
(div.uncaught-exception-sheet dt):
(div.uncaught-exception-sheet dd):
(div.uncaught-exception-sheet ul):
(div.uncaught-exception-sheet li):
- UserInterface/Debug/UncaughtExceptionReporter.js: Renamed from CatchEarlyErrors.js.
(stopEventPropagation): Allow clicking whitelisted links on the sheet.
(blockEventHandlers):
(unblockEventHandlers):
(handleUncaughtException):
(dismissErrorSheet):
(createErrorSheet.insertWordBreakCharacters):
(createErrorSheet):
(handleLinkClick):
- UserInterface/Main.html:
- UserInterface/Protocol/MessageDispatcher.js:
(WebInspector.dispatchMessageFromBackend): Don't try to dispatch
messages from the backend when showing the error sheet. They will
probably fail, so suspend dispatching until the sheet is dismissed.
- 12:37 PM Changeset in webkit [193645] by
-
- 10 edits1 add in trunk/Source
Hook up request and show for typing candidates in WK1
https://bugs.webkit.org/show_bug.cgi?id=151831
-and corresponding-
<rdar://problem/23751214>
Reviewed by Enrica Casucci.
Source/WebCore:
New SPI that is needed.
- WebCore.xcodeproj/project.pbxproj:
- platform/spi/mac/NSSpellCheckerSPI.h: Added.
Request candidates for editable content whenever selection changes.
- editing/Editor.cpp:
(WebCore::Editor::respondToChangedSelection):
Implement requestCandidatesForSelection on the EditorClient.
- loader/EmptyClients.h:
- page/EditorClient.h:
(WebCore::EditorClient::requestCandidatesForSelection):
Source/WebKit/mac:
Add member variables to WebEditorClient. One is a WeakPtrFactory for the
asynchronous handlers, and the other caches the VisibleSelection at the time
candidates were requested so that we can make sure the candidates are still
valid once we receive them.
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::WebEditorClient):
Call [NSSpellChecker requestCandidatesForSelectedRange] with the appropriate
parameters.
(WebEditorClient::requestCandidatesForSelection):
Two helpers to compute information that we need for both of the handlers
below.
(candidateRangeForSelection):
(candidateWouldReplaceText):
In this handler, we just need to call [NSSpellChecker showCandidates] with
the appropriate parameters.
(WebEditorClient::handleRequestedCandidates):
Once a candidate is accepted, it should be inserted in the right way.
(WebEditorClient::handleAcceptedCandidate):
Source/WebKit2:
Empty client for now.
- WebProcess/WebCoreSupport/WebEditorClient.h:
- 12:35 PM Changeset in webkit [193644] by
-
- 4 edits in trunk/LayoutTests
[Streams API] pipeTo tests are failing
https://bugs.webkit.org/show_bug.cgi?id=151949
Unreviewed.
- TestExpectations:
- platform/mac/TestExpectations:
- platform/win/TestExpectations: Moved the flag from Mac and Win to general as GTK+ is failing too.
- 12:27 PM Changeset in webkit [193643] by
-
- 13 edits in trunk
Modern IDB: Fix "old versions" when upgrading databases.
https://bugs.webkit.org/show_bug.cgi?id=151948
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (5 failing tests now pass, and updated results for a 6th test).
This includes the old version on the IDBVersionChangeEvent, as well as the version the
IDBDatabase is left with if the version change transaction is aborted.
Primary mechanism of the fix is to include the original IDBDatabaseInfo along with
IDBTransactionInfos that represent version change transactions.
- Modules/indexeddb/client/IDBDatabaseImpl.cpp:
(WebCore::IDBClient::IDBDatabase::willAbortTransaction):
(WebCore::IDBClient::IDBDatabase::didAbortTransaction):
- Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp:
(WebCore::IDBClient::IDBOpenDBRequest::onUpgradeNeeded):
- Modules/indexeddb/client/IDBTransactionImpl.cpp:
(WebCore::IDBClient::IDBTransaction::IDBTransaction): Deleted.
(WebCore::IDBClient::IDBTransaction::finishAbortOrCommit): Deleted.
- Modules/indexeddb/client/IDBTransactionImpl.h:
(WebCore::IDBClient::IDBTransaction::info):
(WebCore::IDBClient::IDBTransaction::originalDatabaseInfo):
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::startVersionChangeTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::commitTransaction):
- Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseConnection::createVersionChangeTransaction):
- Modules/indexeddb/shared/IDBTransactionInfo.cpp:
(WebCore::IDBTransactionInfo::versionChange):
(WebCore::IDBTransactionInfo::IDBTransactionInfo):
(WebCore::IDBTransactionInfo::isolatedCopy):
- Modules/indexeddb/shared/IDBTransactionInfo.h:
(WebCore::IDBTransactionInfo::originalDatabaseInfo):
LayoutTests:
- platform/mac-wk1/TestExpectations:
- storage/indexeddb/database-basics-expected.txt:
- storage/indexeddb/modern/deletedatabase-2-expected.txt:
- 11:48 AM Changeset in webkit [193642] by
-
- 4 edits in trunk/Websites/webkit.org
Address UX issues with the Contribute menu.
https://bugs.webkit.org/show_bug.cgi?id=151874
Reviewed by Timothy Hatcher.
- wp-content/themes/webkit/functions.php:
- wp-content/themes/webkit/header.php:
- wp-content/themes/webkit/style.css:
(time, mark, audio, video):
(footer, header, hgroup, menu, nav, section):
(html):
(body):
(ol, ul):
(blockquote, q):
(q:before, q:after):
(table):
(p:empty):
(.admin-bar p > a[name]::before):
(.screen-reader-text):
(.screen-reader-text:focus):
(pre):
(code):
(.feature-header:after):
(.feature.opened .feature-header:after):
(footer nav a:hover):
(header .menu-item-has-children .label-toggle::after):
(header .menu-item):
(.sub-menu-layer):
(.sub-menu-layer .menu-item:first-child):
(.menu > .menu-item > .menu-toggle:checked + .sub-menu):
(@media only screen and (max-width: 920px)):
(header .menu-item > .menu-toggle:checked + a > .label-toggle::after):
(header .menu):
(header .menu-toggle:checked ~ ul):
(header .sub-menu-layer:before):
(header .menu > .menu-item > .menu-toggle:checked ~ .sub-menu):
(footer nav li):
(@media only screen and (max-width: 690px)):
(.feature-filters:after):
(.feature-filters.opened:after):
(#wpadminbar):
(.table-of-contents label:after):
(.menu-toggle:checked ~ .table-of-contents label:after):
(.table-of-contents h6):
(header nav .menu-item-has-children .label-toggle): Deleted.
(header nav .menu-item): Deleted.
(header .menu > .menu-item-has-children:hover > a::before): Deleted.
(.menu > .menu-item > .menu-toggle:checked ~ .sub-menu): Deleted.
(header nav .menu-toggle:checked ~ ul): Deleted.
(header .menu-toggle:checked ~ .sub-menu): Deleted.
(@media only screen and (max-width: 782px)): Deleted.
- 11:21 AM Changeset in webkit [193641] by
-
- 3 edits in trunk/LayoutTests
Unreviewed.
http://webkit.org/b/147933 and though count queuing strategy and writable stream abort tests are fixed, there
are still issues with pipeTo. For that I created http://webkit.org/b/151949.
- platform/mac/TestExpectations:
- platform/win/TestExpectations:
- 11:17 AM Changeset in webkit [193640] by
-
- 28 edits2 adds in trunk/Source/JavaScriptCore
FTL B3 should be able to make JS->JS calls
https://bugs.webkit.org/show_bug.cgi?id=151901
Reviewed by Saam Barati.
This adds support for the Call and InvalidationPoint opcodes in DFG IR. This required doing some
clean-up in the OSR exit code. We don't want the B3 FTL to use a bunch of vectors to hold
side-state, so the use of OSRExitDescriptorImpl is not right. It makes sense in the LLVM FTL
because that code needs some way of saving some state from LowerDFGToLLVM to compile(), but
that's not how B3 FTL works. It turns out that for B3 FTL, there isn't anything in
OSRExitDescriptorImpl that the code in LowerDFGToLLVM can't just capture in a lambda.
This also simplifies some stackmap-related APIs, since I got tired of writing boilerplate.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/AbstractMacroAssembler.h:
(JSC::AbstractMacroAssembler::replaceWithAddressComputation):
(JSC::AbstractMacroAssembler::addLinkTask):
- b3/B3CheckSpecial.cpp:
(JSC::B3::CheckSpecial::generate):
- b3/B3Effects.h:
- b3/B3PatchpointSpecial.cpp:
(JSC::B3::PatchpointSpecial::generate):
- b3/B3Procedure.cpp:
(JSC::B3::Procedure::addDataSection):
(JSC::B3::Procedure::callArgAreaSize):
(JSC::B3::Procedure::requestCallArgAreaSize):
(JSC::B3::Procedure::frameSize):
- b3/B3Procedure.h:
(JSC::B3::Procedure::releaseByproducts):
(JSC::B3::Procedure::code):
- b3/B3StackmapGenerationParams.cpp: Added.
(JSC::B3::StackmapGenerationParams::usedRegisters):
(JSC::B3::StackmapGenerationParams::proc):
(JSC::B3::StackmapGenerationParams::StackmapGenerationParams):
- b3/B3StackmapGenerationParams.h: Added.
(JSC::B3::StackmapGenerationParams::value):
(JSC::B3::StackmapGenerationParams::reps):
(JSC::B3::StackmapGenerationParams::size):
(JSC::B3::StackmapGenerationParams::at):
(JSC::B3::StackmapGenerationParams::operator[]):
(JSC::B3::StackmapGenerationParams::begin):
(JSC::B3::StackmapGenerationParams::end):
(JSC::B3::StackmapGenerationParams::context):
(JSC::B3::StackmapGenerationParams::addLatePath):
- b3/B3StackmapValue.h:
- b3/B3ValueRep.h:
(JSC::B3::ValueRep::doubleValue):
(JSC::B3::ValueRep::withOffset):
- b3/air/AirGenerationContext.h:
- b3/testb3.cpp:
(JSC::B3::testSimplePatchpoint):
(JSC::B3::testSimplePatchpointWithoutOuputClobbersGPArgs):
(JSC::B3::testSimplePatchpointWithOuputClobbersGPArgs):
(JSC::B3::testSimplePatchpointWithoutOuputClobbersFPArgs):
(JSC::B3::testSimplePatchpointWithOuputClobbersFPArgs):
(JSC::B3::testPatchpointWithEarlyClobber):
(JSC::B3::testPatchpointCallArg):
(JSC::B3::testPatchpointFixedRegister):
(JSC::B3::testPatchpointAny):
(JSC::B3::testPatchpointLotsOfLateAnys):
(JSC::B3::testPatchpointAnyImm):
(JSC::B3::testPatchpointManyImms):
(JSC::B3::testPatchpointWithRegisterResult):
(JSC::B3::testPatchpointWithStackArgumentResult):
(JSC::B3::testPatchpointWithAnyResult):
(JSC::B3::testSimpleCheck):
(JSC::B3::testCheckLessThan):
(JSC::B3::testCheckMegaCombo):
(JSC::B3::testCheckAddImm):
(JSC::B3::testCheckAddImmCommute):
(JSC::B3::testCheckAddImmSomeRegister):
(JSC::B3::testCheckAdd):
(JSC::B3::testCheckAdd64):
(JSC::B3::testCheckSubImm):
(JSC::B3::testCheckSubBadImm):
(JSC::B3::testCheckSub):
(JSC::B3::testCheckSub64):
(JSC::B3::testCheckNeg):
(JSC::B3::testCheckNeg64):
(JSC::B3::testCheckMul):
(JSC::B3::testCheckMulMemory):
(JSC::B3::testCheckMul2):
(JSC::B3::testCheckMul64):
(JSC::B3::genericTestCompare):
- ftl/FTLExceptionHandlerManager.cpp:
- ftl/FTLExceptionHandlerManager.h:
- ftl/FTLJSCall.cpp:
- ftl/FTLJSCall.h:
- ftl/FTLJSCallBase.cpp:
(JSC::FTL::JSCallBase::emit):
- ftl/FTLJSCallBase.h:
- ftl/FTLJSCallVarargs.cpp:
- ftl/FTLJSCallVarargs.h:
- ftl/FTLJSTailCall.cpp:
(JSC::FTL::DFG::getRegisterWithAddend):
(JSC::FTL::JSTailCall::emit):
(JSC::FTL::JSTailCall::JSTailCall): Deleted.
- ftl/FTLJSTailCall.h:
(JSC::FTL::JSTailCall::stackmapID):
(JSC::FTL::JSTailCall::estimatedSize):
(JSC::FTL::JSTailCall::operator<):
(JSC::FTL::JSTailCall::patchpoint): Deleted.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstruct):
(JSC::FTL::DFG::LowerDFGToLLVM::compileInvalidationPoint):
(JSC::FTL::DFG::LowerDFGToLLVM::lazySlowPath):
(JSC::FTL::DFG::LowerDFGToLLVM::callCheck):
(JSC::FTL::DFG::LowerDFGToLLVM::appendOSRExitArgumentsForPatchpointIfWillCatchException):
(JSC::FTL::DFG::LowerDFGToLLVM::emitBranchToOSRExitIfWillCatchException):
(JSC::FTL::DFG::LowerDFGToLLVM::lowBlock):
(JSC::FTL::DFG::LowerDFGToLLVM::appendOSRExitDescriptor):
(JSC::FTL::DFG::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::DFG::LowerDFGToLLVM::blessSpeculation):
(JSC::FTL::DFG::LowerDFGToLLVM::emitOSRExitCall):
(JSC::FTL::DFG::LowerDFGToLLVM::buildExitArguments):
(JSC::FTL::DFG::LowerDFGToLLVM::exitValueForNode):
- ftl/FTLOSRExit.cpp:
(JSC::FTL::OSRExitDescriptor::OSRExitDescriptor):
(JSC::FTL::OSRExitDescriptor::emitOSRExit):
(JSC::FTL::OSRExitDescriptor::emitOSRExitLater):
(JSC::FTL::OSRExitDescriptor::prepareOSRExitHandle):
(JSC::FTL::OSRExit::OSRExit):
(JSC::FTL::OSRExit::codeLocationForRepatch):
(JSC::FTL::OSRExit::recoverRegistersFromSpillSlot):
(JSC::FTL::OSRExit::willArriveAtExitFromIndirectExceptionCheck):
(JSC::FTL::OSRExit::needsRegisterRecoveryOnGenericUnwindOSRExitPath):
- ftl/FTLOSRExit.h:
(JSC::FTL::OSRExitDescriptorImpl::OSRExitDescriptorImpl):
(JSC::FTL::OSRExit::considerAddingAsFrequentExitSite):
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
(JSC::FTL::compileFTLOSRExit):
- ftl/FTLState.h:
- 10:54 AM Changeset in webkit [193639] by
-
- 5 edits in trunk/Tools
'jhbuild build' should fail immediately when building any module fails
https://bugs.webkit.org/show_bug.cgi?id=145697
Reviewed by Carlos Garcia Campos.
- efl/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
- gtk/jhbuildrc: Update jhbuildrc to account for the removal of the use_lib64 option.
Everything is placed under lib instead of lib64 now.
- jhbuild/jhbuild-wrapper: Update jhbuild to the latest upstream commit, and pass
--exit-on-error when running 'jhbuild build'.
- jhbuild/jhbuildrc_common.py:
(init): Don't override PKG_CONFIG_PATH, CMAKE_PREFIX_PATH, or CMAKE_LIBRARY_PATH. Modern
jhbuild should be able to handle these for us without breaking things....
- 10:49 AM Changeset in webkit [193638] by
-
- 3 edits in trunk/Tools
Add support to import w3c tests from a repository with a different root that the main repo dir
https://bugs.webkit.org/show_bug.cgi?id=151751
Reviewed by Ryosuke Niwa and Youenn Fablet.
We should be able to import tests from repositories that are not pure test repositories and where tests are kept
in a different directory than the repository root.
This patch introduces a new parameter tests_directory that we will use as root directory to search for
tests. All paths will be flattened when copying tests to have a less complicated directory structure. This
requires having the copy_path lists including tuples of origin and destination directories.
- Scripts/webkitpy/w3c/test_downloader.py:
(TestDownloader._add_test_suite_paths): Adds the paths as a tuple of origin and destination directory.
(TestDownloader.copy_tests): Uses the origin and destination tuple for the paths to copy when copying files.
- Scripts/webkitpy/w3c/test_importer_unittest.py:
(TestImporterTest.test_tests_directory): Test.
- 10:35 AM Changeset in webkit [193637] by
-
- 3 edits in trunk/Source/WebCore
Update Objective-C code generator to pass a reference to calling object for partial interfaces
https://bugs.webkit.org/show_bug.cgi?id=151739
Patch by Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au> on 2015-12-07
Reviewed by Darin Adler.
The fix updates the Objective-C code generator to pass a reference to calling object for partial interfaces.
The change from pass by pointer to pass by reference was introduced in r192849.
- bindings/scripts/CodeGeneratorObjC.pm:
(GenerateImplementation):
- bindings/scripts/test/ObjC/DOMTestInterface.mm:
(-[DOMTestInterface supplementalStr1]):
(-[DOMTestInterface supplementalStr2]):
(-[DOMTestInterface setSupplementalStr2:]):
(-[DOMTestInterface supplementalStr3]):
(-[DOMTestInterface setSupplementalStr3:]):
(-[DOMTestInterface supplementalNode]):
(-[DOMTestInterface setSupplementalNode:]):
(-[DOMTestInterface builtinAttribute]):
(-[DOMTestInterface setBuiltinAttribute:]):
(-[DOMTestInterface supplementalMethod1]):
(-[DOMTestInterface supplementalMethod2:objArg:]):
(-[DOMTestInterface supplementalMethod3]):
(-[DOMTestInterface supplementalMethod4]):
(-[DOMTestInterface builtinFunction]):
- 10:30 AM Changeset in webkit [193636] by
-
- 5 edits in trunk/Source/JavaScriptCore
Rename Watchdog::didFire to Watchdog::shouldTerminate because that's what didFire really meant
https://bugs.webkit.org/show_bug.cgi?id=151944
Reviewed by Mark Lam.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
- runtime/VMInlines.h:
(JSC::VM::shouldTriggerTermination):
- runtime/Watchdog.cpp:
(JSC::Watchdog::terminateSoon):
(JSC::Watchdog::shouldTerminateSlow):
(JSC::Watchdog::didFireSlow): Deleted.
- runtime/Watchdog.h:
(JSC::Watchdog::shouldTerminate):
(JSC::Watchdog::didFire): Deleted.
- 10:15 AM Changeset in webkit [193635] by
-
- 2 edits in trunk/Source/WebCore
Crash in MemoryCache::pruneDeadResourcesToSize()
https://bugs.webkit.org/show_bug.cgi?id=151833
<rdar://problem/22392235>
Reviewed by David Kilzer.
MemoryCache::pruneDeadResourcesToSize() is iterating over m_allResources
(which is a vector of LRUList). It first destroys decoded data for each
resource in the LRUList. Then, if it does not suffice to reach the
target size, and starts actually removing resources from the cache.
The issue is that this code alters m_allResources (and its LRULists) as
it is iterating over it. We tried to deal with this in various ways:
- Increment the iterator before removing the resource pointed by the iterator.
- Protect the next resource in the LRUList and abort early if it is no longer in the cache.
This adds code complexity and apparently does not correctly handle all
the edge cases as we still see crashes in this code. In particular, I
suspect that 2. may not be sufficient if it is possible for the next
resource to be moved to another LRUList (in which case, next->inCache()
would still return true but the iterator would however become invalid).
To make the code simpler and more robust, this patch copies the LRUList
(and refs the CachedResources) before iterating over it. This is a lot
safer and should hopefully fix the crashes we see in this function.
No new tests, no reproduction case.
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::pruneDeadResourcesToSize):
- 10:02 AM Changeset in webkit [193634] by
-
- 2 edits in trunk/Source/WebKit2
[GTK][Mac] socketpair assertion failure
https://bugs.webkit.org/show_bug.cgi?id=151293
Reviewed by Carlos Garcia Campos.
- Platform/IPC/unix/ConnectionUnix.cpp: Don't use SEQPACKET sockets on Darwin.
- 9:31 AM Changeset in webkit [193633] by
-
- 9 edits1 move in trunk/Source/JavaScriptCore
Rename JITBitwiseBinaryOpGenerator to JITBitBinaryOpGenerator.
https://bugs.webkit.org/show_bug.cgi?id=151945
Reviewed by Saam Barati.
The lshift operator also need to inherit from JITBitBinaryOpGenerator. Calling
it "BitBinaryOp" makes more sense than "BitwiseBinaryOp" in that case, and still
makes sense for the bitand, bitor, and bitxor operators.
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- jit/JIT.h:
- jit/JITArithmetic.cpp:
(JSC::JIT::emitBitBinaryOpFastPath):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emitSlow_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emitSlow_op_bitor):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emitSlow_op_bitxor):
(JSC::JIT::emitBitwiseBinaryOpFastPath): Deleted.
- jit/JITBitAndGenerator.h:
(JSC::JITBitAndGenerator::JITBitAndGenerator):
- jit/JITBitBinaryOpGenerator.h: Copied from Source/JavaScriptCore/jit/JITBitwiseBinaryOpGenerator.h.
(JSC::JITBitBinaryOpGenerator::JITBitBinaryOpGenerator):
(JSC::JITBitwiseBinaryOpGenerator::JITBitwiseBinaryOpGenerator): Deleted.
- jit/JITBitOrGenerator.h:
(JSC::JITBitOrGenerator::JITBitOrGenerator):
- jit/JITBitXorGenerator.h:
(JSC::JITBitXorGenerator::JITBitXorGenerator):
- jit/JITBitwiseBinaryOpGenerator.h: Removed.
- 9:30 AM Changeset in webkit [193632] by
-
- 14 edits in trunk
Modern IDB: Add some more custom exception messages, passing some more tests..
https://bugs.webkit.org/show_bug.cgi?id=151912
Reviewed by Andy Estes.
Source/WebCore:
No new tests (Covered by existing tests).
- Modules/indexeddb/client/IDBObjectStoreImpl.cpp:
(WebCore::IDBClient::IDBObjectStore::index):
- Modules/indexeddb/client/IDBTransactionImpl.cpp:
(WebCore::IDBClient::IDBTransaction::objectStore):
LayoutTests:
- platform/mac-wk1/TestExpectations:
- storage/indexeddb/exceptions-expected.txt:
- storage/indexeddb/get-keyrange-expected.txt:
- storage/indexeddb/invalid-keys-expected.txt:
- storage/indexeddb/keypath-edges-expected.txt:
- storage/indexeddb/keyrange-expected.txt:
- storage/indexeddb/transaction-active-flag-expected.txt:
- storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
- storage/indexeddb/resources/exceptions.js:
- storage/indexeddb/resources/transaction-and-objectstore-calls.js:
- 9:28 AM Changeset in webkit [193631] by
-
- 2 edits in trunk/Source/JavaScriptCore
[B3] Typo fix after r193386 to fix the build
https://bugs.webkit.org/show_bug.cgi?id=151860
Reviewed by Filip Pizlo.
- b3/B3StackmapSpecial.cpp:
(JSC::B3::StackmapSpecial::isArgValidForValue):
- 9:15 AM Changeset in webkit [193630] by
-
- 18 edits4 adds in trunk/Source
[ThreadedCompositor] Add support for PlatformLayer.
https://bugs.webkit.org/show_bug.cgi?id=143299
Reviewed by Žan Doberšek.
Source/WebCore:
This patch implements TextureMapperPlatformLayerProxy and TextureMapperPlatformLayerBuffer to
send a texture (actual texture or BitmapTexture) to the compositing thread directly.
Platform layer renderers should implement TextureMapperPlatformLayerProxyProvider to establish
a connection to the compositing thread. After the connection has been established, the renderer
can render its contents to the TextureMapperPlatformLayerBuffer and pass it to the compositing thread
via TextureMapperPlatformLayer proxy.
The buffer can be an unmanaged texture (a.k.a. platform texture) or BitmapTexture.
For the unmanaged texture, the renderer should manage its life cycle itself. For the BitmapTexture,
it will be managed by TextureMapperPlatformLayerProxy. In that case, used (swapped) buffer will be
recycled because the renderer will use same size and format until it changes its size.
No new tests needed.
- PlatformGTK.cmake:
Adds TextureMapperPlatformLayerBuffer and TextureMapperPlaytformLayerProxy.
- platform/graphics/GraphicsContext3DPrivate.cpp:
- platform/graphics/GraphicsContext3DPrivate.h:
- platform/graphics/cairo/ImageBufferCairo.cpp:
- platform/graphics/cairo/ImageBufferDataCairo.h:
Adds mock implementation.
- platform/graphics/PlatformLayer.h:
Adds TextureMapperPlatformLayerProxyProvider as a PlatformLayer for the Threaded Compositor
- platform/graphics/texmap/BitmapTextureGL.h:
(WebCore::BitmapTextureGL::internalFormat): Adds a getter to check the
internal format of texture to check reusability.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
- platform/graphics/texmap/TextureMapperLayer.cpp:
- platform/graphics/texmap/TextureMapperLayer.h:
Exclude GraphicsLayerTextureMapper from build when we are using Coordinated Graphics.
- platform/graphics/texmap/TextureMapperPlatformLayerBuffer.cpp: Added.
- platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h: Added.
- platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp: Added.
- platform/graphics/texmap/TextureMapperPlatformLayerProxy.h: Added.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::GraphicsLayer::create):
Because we removed GraphicsLayerTextureMapper from build, we need to add own factory function.
(WebCore::CoordinatedGraphicsLayer::setContentsToPlatformLayer):
(WebCore::CoordinatedGraphicsLayer::syncPlatformLayer):
(WebCore::CoordinatedGraphicsLayer::platformLayerWillBeDestroyed):
(WebCore::CoordinatedGraphicsLayer::setPlatformLayerNeedsDisplay):
Implements sync operations for TextureMapperPlatformLayerProxy
Source/WebKit2:
- Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
(WebKit::CoordinatedGraphicsScene::paintToCurrentGLContext):
Swap pending buffers of TextureMapperPlatformLayerProxies before painting contents.
(WebKit::CoordinatedGraphicsScene::syncPlatformLayerIfNeeded):
In threaded compositor, CoordinatedGraphicsScence only cares about creation and deletion
of platform layers.
(WebKit::CoordinatedGraphicsScene::onNewBufferAvailable):
Whenever new buffer comes via TextureMapperPlatformLayerProxy, CoordinatedGraphicsScene will
update the scene if it is needed.
- 9:12 AM Changeset in webkit [193629] by
-
- 2 edits in trunk/LayoutTests
Marking fast/dom/Window/property-access-on-cached-window-after-frame-removed.html as failing on Win
https://bugs.webkit.org/show_bug.cgi?id=151759
Unreviewed test gardening.
- platform/win/TestExpectations:
- 9:05 AM Changeset in webkit [193628] by
-
- 2 edits in trunk/LayoutTests
Removing Yosemite flag from flaky test http/tests/cache/disk-cache/disk-cache-request-max-stale.html
https://bugs.webkit.org/show_bug.cgi?id=151661
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 8:51 AM Changeset in webkit [193627] by
-
- 3 edits in trunk/Source/JavaScriptCore
[EFL] Implement scheduleTimer and cancelTimer in IncrementalSweeper class
https://bugs.webkit.org/show_bug.cgi?id=151656
Reviewed by Csaba Osztrogonác.
Support IncremntalSweeper using Ecore_Timer.
- heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::IncrementalSweeper):
(JSC::IncrementalSweeper::scheduleTimer):
(JSC::IncrementalSweeper::cancelTimer):
- heap/IncrementalSweeper.h:
- 8:24 AM Changeset in webkit [193626] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Allow applications to force Accelerated Compositing mode
https://bugs.webkit.org/show_bug.cgi?id=150558
Patch by Mario Sanchez Prada <mario@endlessm.com> on 2015-12-07
Reviewed by Carlos Garcia Campos.
Enable forcing Accelerated Compositing mode to be always on if
a WEBKIT_FORCE_COMPOSITING_MODE environment variable is set.
This can be useful for controlled environments where we know that
AC always on works well enough, to get smoother animations.
- UIProcess/gtk/WebPreferencesGtk.cpp:
(WebKit::WebPreferences::platformInitializeStore): Set forceCompositingMode
setting to true if the environment variable is found.
- 8:22 AM Changeset in webkit [193625] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening. Mark some of blink tests to failure since r190629.
- platform/efl/TestExpectations:
- 8:18 AM Changeset in webkit [193624] by
-
- 3 edits in trunk/Tools
Mock TestRepositories in W3C importer tests
https://bugs.webkit.org/show_bug.cgi?id=151938
Reviewed by Youenn Fablet.
The test importer tests should use a fake repository instead of using the real one. The reason why this happened
is because the test repository method reading the file was using the filesystem directly instead of taking the
host one. This patch changes that.
- Scripts/webkitpy/w3c/test_downloader.py:
(TestDownloader.load_test_repositories): Take a filesystem and use it. If we get no filesystem, we use the
default one.
(TestDownloader.init): When loading the repositories, pass the host filesystem.
- Scripts/webkitpy/w3c/test_importer_unittest.py:
(TestImporterTest.test_harnesslinks_conversion):
(TestImporterTest.test_submodules_generation): Use a fake test repository file.
- 5:49 AM Changeset in webkit [193623] by
-
- 2 edits in trunk/Tools
TestNetscapePlugIn: Address review comment on r193607
<http://webkit.org/b/151881>
- DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
(testSetStatus): Initializing std::unique_ptr<char[]> with
nullptr is redundant.
- 4:36 AM Changeset in webkit [193622] by
-
- 7 edits in trunk
[GTK] Add webkit_uri_request_get_http_method
https://bugs.webkit.org/show_bug.cgi?id=151601
Source/WebKit2:
Patch by Jon Forsberg <jon.orebro@gmail.com> on 2015-12-07
Reviewed by Martin Robinson.
Add a method to get the HTTP method of a WebKitURIRequest.
- UIProcess/API/gtk/WebKitURIRequest.cpp:
(webkit_uri_request_get_http_method):
- UIProcess/API/gtk/WebKitURIRequest.h:
- UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
Tools:
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2015-12-07
Reviewed by Martin Robinson.
Add test case to check HTTP method of WebKitURIRequest.
- TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
(testURIRequestHTTPMethod):
(serverCallback):
(beforeAll):
- TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
(sendRequestCallback):
- 4:02 AM Changeset in webkit [193621] by
-
- 3 edits in trunk/Source/WebCore
Fix GTK+ build with GStreamer GL
https://bugs.webkit.org/show_bug.cgi?id=151939
Reviewed by Žan Doberšek.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
(WebCore::MediaPlayerPrivateGStreamerBase::drawCallback):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
- 3:56 AM Changeset in webkit [193620] by
-
- 14 edits4 adds in trunk
[GTK] Add WebKitWebPage::console-message-sent signal to Web Extensions API
https://bugs.webkit.org/show_bug.cgi?id=79918
Reviewed by Gustavo Noronha Silva.
Source/WebKit2:
Add WebKitConsoleMessage boxed type that is passed to the
WebKitWebPage::console-message-sent signal with all the details
about the message.
- PlatformGTK.cmake: Add new files to compilation.
- UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt: Add new symbols.
- UIProcess/API/gtk/docs/webkit2gtk-4.0.types: Add webkit_console_message_get_type.
- UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section to the docs.
- WebProcess/InjectedBundle/API/APIInjectedBundlePageUIClient.h:
(API::InjectedBundle::PageUIClient::willAddMessageToConsole): Add
paramaters for all console message details.
- WebProcess/InjectedBundle/API/gtk/WebKitConsoleMessage.cpp: Added.
(webkit_console_message_copy):
(webkit_console_message_free):
(webkit_console_message_get_source):
(webkit_console_message_get_level):
(webkit_console_message_get_text):
(webkit_console_message_get_line):
(webkit_console_message_get_source_id):
- WebProcess/InjectedBundle/API/gtk/WebKitConsoleMessage.h: Added.
- WebProcess/InjectedBundle/API/gtk/WebKitConsoleMessagePrivate.h: Added.
(_WebKitConsoleMessage::_WebKitConsoleMessage):
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(webkitWebPageDidSendConsoleMessage): Emit the
WebKitWebPage::console-message-sent signal.
(didReceiveResponseForResource): Generate a console message in
case of HTTP failure >= 400 for consistency with the inspector.
(didFailLoadForResource): Generate a console message in case of
resource load failure for consistency with the inspector.
(webkit_web_page_class_init): Add WebKitWebPage::console-message-sent signal.
(webkitWebPageCreate): Set custom UI client.
- WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h:
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
(WebKit::InjectedBundlePageUIClient::willAddMessageToConsole):
- WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::addMessageToConsole): Pass all the
console message details to the ui client.
Tools:
Add unit tests to check the different console messages.
- TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
- TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp: Added.
(ConsoleMessageTest::ConsoleMessage::operator==):
(ConsoleMessageTest::consoleMessageReceivedCallback):
(ConsoleMessageTest::ConsoleMessageTest):
(ConsoleMessageTest::~ConsoleMessageTest):
(ConsoleMessageTest::waitUntilConsoleMessageReceived):
(testWebKitConsoleMessageConsoleAPI):
(testWebKitConsoleMessageJavaScriptException):
(testWebKitConsoleMessageNetworkError):
(testWebKitConsoleMessageSecurityError):
(beforeAll):
(afterAll):
- TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
(consoleMessageSentCallback):
(pageCreatedCallback):
- 3:46 AM Changeset in webkit [193619] by
-
- 5 edits in trunk
[EFL] MiniBrowser doesn't exit when called ewk_view_try_close()
https://bugs.webkit.org/show_bug.cgi?id=151934
Reviewed by Csaba Osztrogonác.
Source/WebKit2:
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_try_close):
Called window_close callback immediately when WKPageTryClose returns true.
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F): Improved test cases for try_close to test when content does not contain
onbeforeunload callback.
Tools:
- MiniBrowser/efl/main.c:
(on_window_deletion): Revert the changes of r192767.
- 3:01 AM Changeset in webkit [193618] by
-
- 2 edits in trunk/Tools
[GTK] update-webkitgtk-libs cannot build mesa
https://bugs.webkit.org/show_bug.cgi?id=151535
Reviewed by Martin Robinson.
Upgrade to newer mesa in order to build successfully against LLVM 3.7. Add missing
dependency of mesa on LLVM, to ensure LLVM is built first. Build LLVM unconditionally, even
on architectures where FTL is not supported, to ensure mesa is always buildable, since LLVM
does not have a stable API and we cannot expect mesa to be buildable unless we control the
LLVM version. Build mesa with --disable-egl since --enable-egl conflicts with
--enable-xlib-glx. This fixes update-webkitgtk-libs on distros with LLVM 3.7.
- gtk/jhbuild.modules:
- 1:11 AM Changeset in webkit [193617] by
-
- 2 edits in trunk/Tools
[GTK][Mac] libWebExtensionTest link error
https://bugs.webkit.org/show_bug.cgi?id=150802
Reviewed by Carlos Garcia Campos.
- TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: add dependencies to the webextension library.
- 12:28 AM Changeset in webkit [193616] by
-
- 3 edits in trunk/Source/WebKit2
[EFL] Moving preference settings from EwkView to WebPreferencesEfl
https://bugs.webkit.org/show_bug.cgi?id=151928
Reviewed by Gyuyoung Kim.
It implements WebPreferences::platformInitializeStore() in WebPreferencesEfl.cpp.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
- UIProcess/efl/WebPreferencesEfl.cpp:
(WebKit::WebPreferences::platformInitializeStore):
