Timeline

Dec 10, 2015:

11:59 PM Changeset in webkit [193949] by beidson@apple.com

• 6 edits in trunk

Modern IDB: storage/indexeddb/objectstore-count.html fails.
​https://bugs.webkit.org/show_bug.cgi?id=152167

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (At least one failing test now passes).

• Modules/indexeddb/IDBKeyRangeData.h:

(WebCore::IDBKeyRangeData::allKeys):

• Modules/indexeddb/client/IDBObjectStoreImpl.cpp:

(WebCore::IDBClient::IDBObjectStore::count): If the passed in IDBKeyRange* is nullptr, use IDBKeyRangeData::allKeys.
(WebCore::IDBClient::IDBObjectStore::doCount): Change an isNull check to a more correct !isValid() check.

LayoutTests:

• platform/mac-wk1/TestExpectations:
• storage/indexeddb/objectstore-count-expected.txt:

11:45 PM Changeset in webkit [193948] by youenn.fablet@crf.canon.fr

• 7 edits in trunk/Source

Binding and builtin generators should lowercase RTCXX as rtcXX and not rTCXX
​https://bugs.webkit.org/show_bug.cgi?id=152121

Reviewed by Darin Adler.

Source/JavaScriptCore:

• Scripts/builtins/builtins_generator.py:

(WK_lcfirst): Added RTC special rule.

Source/WebCore:

No change in behavior.

• bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::finishCreation): Using rtcXX in lieu of rTCXX.

• bindings/js/WebCoreJSBuiltinInternals.h:

(WebCore::JSBuiltinInternalFunctions::JSBuiltinInternalFunctions): Ditto.
(WebCore::JSBuiltinInternalFunctions::rtcPeerConnectionInternals): Added.
(WebCore::JSBuiltinInternalFunctions::visit): Ditto.
(WebCore::JSBuiltinInternalFunctions::init): Ditto.
(WebCore::JSBuiltinInternalFunctions::rTCPeerConnectionInternals): Deleted.

• bindings/js/WebCoreJSBuiltins.h:

(WebCore::JSBuiltinFunctions::JSBuiltinFunctions): Using rtcXX in lieu of rTCXX.
(WebCore::JSBuiltinFunctions::rtcPeerConnectionBuiltins): Added.
(WebCore::JSBuiltinFunctions::rtcPeerConnectionInternalsBuiltins): Added.
(WebCore::JSBuiltinFunctions::rTCPeerConnectionBuiltins): Deleted.
(WebCore::JSBuiltinFunctions::rTCPeerConnectionInternalsBuiltins): Deleted.

• bindings/scripts/CodeGenerator.pm:

(WK_lcfirst): Added RTC special rule.

11:31 PM Changeset in webkit [193947] by Alan Bujtas

• 3 edits
  2 adds in trunk

ASSERTION FAILED: !simpleLineLayout() in WebCore::RenderText::collectSelectionRectsForLineBoxes
​https://bugs.webkit.org/show_bug.cgi?id=152115

Reviewed by Simon Fraser.

document.execCommand("indent") generates a blockquote wrapper and moves the indented content inside.
If the indented content is already inside a selection, we need to make sure that newly created flow uses
normal line layout.
This patch fixes the generic case as re-parenting an already selected renderer is not specific to document.execCommand("indent").

Source/WebCore:

Test: fast/block/selection-inside-simple-line-layout.html

• rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseForWithReason):
(WebCore::SimpleLineLayout::printReason):

LayoutTests:

• fast/block/selection-inside-simple-line-layout-expected.txt: Added.
• fast/block/selection-inside-simple-line-layout.html: Added.

9:26 PM Changeset in webkit [193946] by Nikita Vasilyev

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: debugger dashboard's switching arrows are positioned too close to the dashboard border
​https://bugs.webkit.org/show_bug.cgi?id=151867

Reviewed by Timothy Hatcher.

• UserInterface/Views/DashboardContainerView.css:

(.dashboard-container .advance-arrow):

8:26 PM Changeset in webkit [193945] by beidson@apple.com

• 2 edits in trunk/LayoutTests

Unreviewed TestExpectations gardening.

• platform/mac-wk1/TestExpectations: Move 3 failing IDB tests to the "Skipped because of Workers" section.

8:06 PM Changeset in webkit [193944] by eric.carlson@apple.com

• 40 edits
  6 adds
  3 deletes in trunk

[MediaStream] Expose media capture devices persistent permissions to WebCore
​https://bugs.webkit.org/show_bug.cgi?id=152087

Source/WebCore:

Reviewed by Chris Dumez.

No new tests, an existing test was updated to test the change.

• CMakeLists.txt: Add UserMediaPermissionCheck.cpp.

• Modules/mediastream/MediaDevicesRequest.cpp:

(WebCore::MediaDevicesRequest::~MediaDevicesRequest): Clear the permission checker client.
(WebCore::MediaDevicesRequest::contextDestroyed): Ditto.
(WebCore::MediaDevicesRequest::start): Create a permission checker and start it running.
(WebCore::MediaDevicesRequest::didCompleteCheck): Start the media source checker.
(WebCore::MediaDevicesRequest::didCompleteRequest): Only include a track's label if the

page has permission to use a capture device.

• Modules/mediastream/MediaDevicesRequest.h:

• Modules/mediastream/UserMediaClient.h: Include prototypes for permission checker.

(WebCore::UserMediaClient::~UserMediaClient):

• Modules/mediastream/MediaStreamTrackSourcesRequest.cpp: Removed, not longer used.
• Modules/mediastream/MediaStreamTrackSourcesRequest.h:

• Modules/mediastream/UserMediaController.h:

(WebCore::UserMediaController::checkUserMediaPermission): New.
(WebCore::UserMediaController::cancelUserMediaPermissionCheck): Ditto.

• Modules/mediastream/UserMediaPermissionCheck.cpp: Added.

(WebCore::UserMediaPermissionCheck::create):
(WebCore::UserMediaPermissionCheck::UserMediaPermissionCheck):
(WebCore::UserMediaPermissionCheck::~UserMediaPermissionCheck):
(WebCore::UserMediaPermissionCheck::securityOrigin):
(WebCore::UserMediaPermissionCheck::contextDestroyed):
(WebCore::UserMediaPermissionCheck::start):
(WebCore::UserMediaPermissionCheck::setDeviceAccessMode):

• Modules/mediastream/UserMediaPermissionCheck.h: Added.

(WebCore::UserMediaPermissionCheckClient::~UserMediaPermissionCheckClient):
(WebCore::UserMediaPermissionCheck::setClient):

• WebCore.xcodeproj/project.pbxproj: Add UserMediaPermissionCheck.cpp|.h

• platform/mock/UserMediaClientMock.h: Removed, it is no longer used.

• testing/Internals.cpp: Remove UserMediaClientMock.h include, it is gone.

Source/WebKit/mac:

Reviewed by Chris Dumez.

Add methods and helpers for WK1 permission checker interface.

• WebCoreSupport/WebUserMediaClient.h:
• WebCoreSupport/WebUserMediaClient.mm:

(userMediaRequestsMap):
(AddRequestToRequestMap):
(RemoveRequestFromRequestMap):
(userMediaCheckMap):
(AddPermissionCheckToMap):
(RemovePermissionCheckFromMap):
(WebUserMediaClient::WebUserMediaClient):
(WebUserMediaClient::requestUserMediaAccess):
(WebUserMediaClient::cancelUserMediaAccessRequest):
(WebUserMediaClient::checkUserMediaPermission):
(WebUserMediaClient::cancelUserMediaPermissionCheck):
(-[WebUserMediaPolicyListener allow]):
(-[WebUserMediaPolicyListener deny]):
(-[WebUserMediaPolicyCheckerListener initWithUserMediaPermissionCheck:]):
(-[WebUserMediaPolicyCheckerListener cancelUserMediaPermissionCheck]):
(-[WebUserMediaPolicyCheckerListener allow]):
(-[WebUserMediaPolicyCheckerListener deny]):
(-[WebUserMediaPolicyCheckerListener denyOnlyThisRequest]):
(-[WebUserMediaPolicyCheckerListener shouldClearCache]):
(AddRequestToMap): Deleted.
(RemoveRequestFromMap): Deleted.

• WebView/WebUIDelegatePrivate.h:

Source/WebKit2:

Reviewed by Chris Dumez.

• CMakeLists.txt: Add UserMediaPermissionCheckProxy.cpp and WKUserMediaPermissionCheck.cpp.

• Shared/API/APIObject.h: Define UserMediaPermissionCheck.

• Shared/API/c/WKBase.h: Add WKUserMediaPermissionCheckRef typedef.

• UIProcess/API/APIUIClient.h:

(API::UIClient::checkUserMediaPermissionForOrigin): New.

• UIProcess/API/C/WKAPICast.h: Add WKUserMediaPermissionCheckRef/UserMediaPermissionCheckProxy mapping.

• UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient): Implement checkUserMediaPermissionForOrigin.

• UIProcess/API/C/WKPageUIClient.h: Add WKCheckUserMediaPermissionCallback typedef and add checkUserMediaPermissionForOrigin to WKPageUIClientV6.

• UIProcess/API/C/WKUserMediaPermissionCheck.cpp: Added.

(WKUserMediaPermissionCheckGetTypeID):
(WKUserMediaPermissionCheckSetHasPermission):

• UIProcess/API/C/WKUserMediaPermissionCheck.h: Added.

• UIProcess/UserMediaPermissionCheckProxy.cpp: Added.

(WebKit::UserMediaPermissionCheckProxy::UserMediaPermissionCheckProxy):
(WebKit::UserMediaPermissionCheckProxy::setHasPermission):
(WebKit::UserMediaPermissionCheckProxy::invalidate):

• UIProcess/UserMediaPermissionCheckProxy.h: Added.

(WebKit::UserMediaPermissionCheckProxy::create):

• UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::invalidateRequests):
(WebKit::UserMediaPermissionRequestManagerProxy::createRequest):
(WebKit::UserMediaPermissionRequestManagerProxy::didReceiveUserMediaPermissionDecision):
(WebKit::UserMediaPermissionRequestManagerProxy::createUserMediaPermissionCheck):
(WebKit::UserMediaPermissionRequestManagerProxy::didCompleteUserMediaPermissionCheck):

• UIProcess/UserMediaPermissionRequestManagerProxy.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::requestUserMediaPermissionForFrame):
(WebKit::WebPageProxy::checkUserMediaPermissionForFrame):
(WebKit::WebPageProxy::requestNotificationPermission):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:

• WebKit2.xcodeproj/project.pbxproj: Add UserMediaPermissionCheckProxy.*, and WKUserMediaPermissionCheck.*.

• WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:

(WebKit::UserMediaPermissionRequestManager::startUserMediaRequest): Renamed from startRequest.
(WebKit::UserMediaPermissionRequestManager::cancelUserMediaRequest): Renamed from cancelRequest.
(WebKit::UserMediaPermissionRequestManager::didReceiveUserMediaPermissionDecision): m_requestToIDMap ->

m_userMediaRequestToIDMap.remove.

(WebKit::UserMediaPermissionRequestManager::startUserMediaPermissionCheck): New, start the request.
(WebKit::UserMediaPermissionRequestManager::cancelUserMediaPermissionCheck): New, cancel

the request.

(WebKit::UserMediaPermissionRequestManager::didCompleteUserMediaPermissionCheck): New,

all the request completion method.

(WebKit::UserMediaPermissionRequestManager::startRequest): Deleted.
(WebKit::UserMediaPermissionRequestManager::cancelRequest): Deleted.

• WebProcess/MediaStream/UserMediaPermissionRequestManager.h:

• WebProcess/WebCoreSupport/WebUserMediaClient.cpp:

(WebKit::WebUserMediaClient::requestUserMediaAccess): startRequest -> startUserMediaRequest.
(WebKit::WebUserMediaClient::cancelUserMediaAccessRequest): cancelRequest -> cancelUserMediaRequest.
(WebKit::WebUserMediaClient::checkUserMediaPermission): New.
(WebKit::WebUserMediaClient::cancelUserMediaPermissionCheck): New.

• WebProcess/WebCoreSupport/WebUserMediaClient.h:

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didCompleteUserMediaPermissionCheck): New.

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in: Add DidCompleteUserMediaPermissionCheck.

Tools:

Add support for the new user media permission checker page UI client method.

Reviewed by Chris Dumez.

• WebKitTestRunner/TestController.cpp:

(WTR::decidePolicyForUserMediaPermissionRequest):
(WTR::checkUserMediaPermissionForOrigin):
(WTR::TestController::createOtherPage): Add checkUserMediaPermissionForOrigin.
(WTR::TestController::createWebViewWithOptions): Ditto.
(WTR::TestController::resetStateToConsistentValues): Clear m_userMediaOriginPermissions.
(WTR::originUserVisibleName): New, create a string for the origin.
(WTR::TestController::handleCheckOfUserMediaPermissionForOrigin): Set the WKUserMediaPermissionCheckRef

according to the state of the origin permission map.

(WTR::TestController::handleUserMediaPermissionRequest): Remember both the origin and the

request so we can update the origin permission map in decidePolicyForUserMediaPermissionRequestIfPossible.

(WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Update the

origin permission map.

• WebKitTestRunner/TestController.h:

LayoutTests:

Reviewed by Chris Dumez.

• fast/mediastream/MediaDevices-enumerateDevices-expected.txt:
• fast/mediastream/MediaDevices-enumerateDevices.html:

8:03 PM Changeset in webkit [193943] by fpizlo@apple.com

• 11 edits in trunk/Source/JavaScriptCore

FTL B3 should be able to run quicksort asm.js test
​https://bugs.webkit.org/show_bug.cgi?id=152105

Reviewed by Geoffrey Garen.

This covers making all of the changes needed to run quicksort.js from AsmBench.

• Reintroduced float types to FTLLower since we now have B3::Float.

• Gave FTL::Output the ability to speak of load types and store types separately from LValue types. This dodges the problem that B3 doesn't have types for Int8 and Int16 but supports loads and stores of that type.

• Implemented Mod in B3 and wrote tests.

I also fixed a pre-existing bug in a test that appeared to only manifest in release builds.

Currently, B3's performance on asm.js tests is not good. It should be easy to fix:

• B3 should strength-reduce the shifting madness that happens in asm.js memory accesses ​https://bugs.webkit.org/show_bug.cgi?id=152106

• B3 constant hoisting should have a story for the asm.js heap constant ​https://bugs.webkit.org/show_bug.cgi?id=152107

• b3/B3CCallValue.h:
• b3/B3Const32Value.cpp:

(JSC::B3::Const32Value::divConstant):
(JSC::B3::Const32Value::modConstant):
(JSC::B3::Const32Value::bitAndConstant):

• b3/B3Const32Value.h:
• b3/B3Const64Value.cpp:

(JSC::B3::Const64Value::divConstant):
(JSC::B3::Const64Value::modConstant):
(JSC::B3::Const64Value::bitAndConstant):

• b3/B3Const64Value.h:
• b3/B3ReduceStrength.cpp:
• b3/B3Validate.cpp:
• b3/B3Value.cpp:

(JSC::B3::Value::divConstant):
(JSC::B3::Value::modConstant):
(JSC::B3::Value::bitAndConstant):

• b3/B3Value.h:
• b3/testb3.cpp:

(JSC::B3::testChillDiv64):
(JSC::B3::testMod):
(JSC::B3::testSwitch):
(JSC::B3::run):

• ftl/FTLB3Output.cpp:

(JSC::FTL::Output::load16ZeroExt32):
(JSC::FTL::Output::store):
(JSC::FTL::Output::store32As8):
(JSC::FTL::Output::store32As16):
(JSC::FTL::Output::loadFloatToDouble): Deleted.

• ftl/FTLB3Output.h:

(JSC::FTL::Output::mul):
(JSC::FTL::Output::div):
(JSC::FTL::Output::chillDiv):
(JSC::FTL::Output::rem):
(JSC::FTL::Output::neg):
(JSC::FTL::Output::load32):
(JSC::FTL::Output::load64):
(JSC::FTL::Output::loadPtr):
(JSC::FTL::Output::loadFloat):
(JSC::FTL::Output::loadDouble):
(JSC::FTL::Output::store32):
(JSC::FTL::Output::store64):
(JSC::FTL::Output::storePtr):
(JSC::FTL::Output::storeFloat):
(JSC::FTL::Output::storeDouble):
(JSC::FTL::Output::addPtr):
(JSC::FTL::Output::extractValue):
(JSC::FTL::Output::call):
(JSC::FTL::Output::operation):

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::DFG::LowerDFGToLLVM::compilePutByVal):
(JSC::FTL::DFG::LowerDFGToLLVM::compileArrayPush):
(JSC::FTL::DFG::LowerDFGToLLVM::compileArrayPop):

• ftl/FTLOutput.cpp:

(JSC::FTL::Output::Output):
(JSC::FTL::Output::store):
(JSC::FTL::Output::check):
(JSC::FTL::Output::load):

• ftl/FTLOutput.h:

(JSC::FTL::Output::load32):
(JSC::FTL::Output::load64):
(JSC::FTL::Output::loadPtr):
(JSC::FTL::Output::loadFloat):
(JSC::FTL::Output::loadDouble):
(JSC::FTL::Output::store32As8):
(JSC::FTL::Output::store32As16):
(JSC::FTL::Output::store32):
(JSC::FTL::Output::store64):
(JSC::FTL::Output::storePtr):
(JSC::FTL::Output::storeFloat):
(JSC::FTL::Output::storeDouble):
(JSC::FTL::Output::addPtr):
(JSC::FTL::Output::loadFloatToDouble): Deleted.
(JSC::FTL::Output::store16): Deleted.

7:51 PM Changeset in webkit [193942] by mmaxfield@apple.com

• 2 edits in trunk/Source/WebCore

Build fix

Unreviewed.

• platform/graphics/cocoa/FontCocoa.mm:

(WebCore::smallCapsTrueTypeDictionary):

7:41 PM Changeset in webkit [193941] by fpizlo@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Consider still matching an address expression even if B3 has already assigned a Tmp to it
​https://bugs.webkit.org/show_bug.cgi?id=150777

Reviewed by Geoffrey Garen.

We need some heuristic for when an address should be computed as a separate instruction. It's
usually profitable to sink the address into the memory access. The previous heuristic meant that
the address would get separate instructions if it was in a separate block from the memory access.
This was messing up codegen of things like PutByVal out-of-bounds, where the address is computed
in one block and then used in another. I don't think that which block owns the address
computation should factor into any heuristic here, since it's so fragile: the compiler may lower
something by splitting blocks and we don't want this to ruin performance.

So, this replaces that heuristic with a more sensible one: the address computation gets its own
instruction if it has a lot of uses. In practice this means that we always sink the address
computation into the memory access.

• b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::effectiveAddr):

6:24 PM Changeset in webkit [193940] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Mordernize viewport dumping
​https://bugs.webkit.org/show_bug.cgi?id=152159

Reviewed by Zalan Bujtas.

Use groupings to simplify the viewport configuration dumping code.

• page/ViewportConfiguration.cpp:

(WebCore::operator<<):
(WebCore::ViewportConfiguration::description):

6:08 PM Changeset in webkit [193939] by dbates@webkit.org

• 6 edits
  1 copy
  4 adds in trunk

[CSP] eval() is not blocked for stringified literals
​https://bugs.webkit.org/show_bug.cgi?id=152158
<rdar://problem/15775625>

Reviewed by Saam Barati.

Source/JavaScriptCore:

Fixes an issue where stringified literals can be eval()ed despite being disallowed by
Content Security Policy of the page.

• interpreter/Interpreter.cpp:

(JSC::eval): Throw a JavaScript EvalError exception if eval() is disallowed for the page
and return undefined.

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval): Ditto.

LayoutTests:

Update test LayoutTests/http/tests/security/contentSecurityPolicy/eval-blocked.html to be
more comprehensive.

Add tests to ensure that we block eval() from within an external JavaScript script when the
policy of the page disallows eval() and that we block eval() inside a subframe that disallows
eval() when the page in the main frame allows eval().

• http/tests/security/contentSecurityPolicy/eval-blocked-expected.txt:
• http/tests/security/contentSecurityPolicy/eval-blocked-in-external-script-expected.txt: Added.
• http/tests/security/contentSecurityPolicy/eval-blocked-in-external-script.html: Added.
• http/tests/security/contentSecurityPolicy/eval-blocked-in-subframe-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/eval-blocked-expected.txt.
• http/tests/security/contentSecurityPolicy/eval-blocked-in-subframe.html: Added.
• http/tests/security/contentSecurityPolicy/eval-blocked.html:
• http/tests/security/contentSecurityPolicy/resources/eval-blocked-in-external-script.js: Added.

6:06 PM Changeset in webkit [193938] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Fix jsc symlink creation on iOS
​https://bugs.webkit.org/show_bug.cgi?id=152155

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-12-10
Reviewed by Dan Bernstein.

• JavaScriptCore.xcodeproj/project.pbxproj:

Switch from INSTALL_PATH_ACTUAL to just INSTALL_PATH.
Remove now unnecessary INSTALL_PATH_PREFIX use as well.

5:37 PM Changeset in webkit [193937] by Joseph Pecoraro

• 12 edits
  1 move in trunk/Source

Remote Inspector: Verify the identity of the other side of XPC connections
​https://bugs.webkit.org/show_bug.cgi?id=152153

Reviewed by Brian Burg.

Source/JavaScriptCore:

• JavaScriptCore.xcodeproj/project.pbxproj:

Link with the Security framework.

• inspector/remote/RemoteInspectorXPCConnection.h:
• inspector/remote/RemoteInspectorXPCConnection.mm:

(auditTokenHasEntitlement):
(Inspector::RemoteInspectorXPCConnection::handleEvent):
(Inspector::RemoteInspectorXPCConnection::RemoteInspectorXPCConnection): Deleted.
When receiving the first message, verify the XPC connection
is connected to who we thought we were connected to and
Bail if it isn't.

Source/WebCore:

• WebCore.xcodeproj/project.pbxproj:
• platform/network/mac/CertificateInfoMac.mm:

Use the new header.

Source/WebKit2:

• Shared/mac/SandboxUtilities.mm:
• UIProcess/ApplicationStateTracker.mm:

Use new header.

Source/WTF:

• WTF.xcodeproj/project.pbxproj:
• wtf/spi/cocoa/SecuritySPI.h: Renamed from Source/WebCore/platform/spi/cocoa/SecuritySPI.h.

Push this down into WTF from WebCore and add a new method.

5:35 PM Changeset in webkit [193936] by beidson@apple.com

• 19 edits in trunk

Modern IDB: storage/indexeddb/delete-in-upgradeneeded-close-in-versionchange.html fails
​https://bugs.webkit.org/show_bug.cgi?id=152144

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (At least two failing tests now pass, and other incorrect tests updated to be more correct).

• An IDBOpenDBRequest resulting in a versionchange transaction should not have the onsuccess event fire if the database connection was closed during the versionchange transaction. onerror should fire instead.
• When firing an event at an IDBRequest, it should not have the transaction as an additional target if the transaction has finished.
• When firing an event at an IDBRequest, it should not have the database as an additional target if the database is closed or is closing.

• Modules/indexeddb/client/IDBDatabaseImpl.h:

(WebCore::IDBClient::IDBDatabase::isClosingOrClosed):

• Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp:

(WebCore::IDBClient::IDBOpenDBRequest::fireErrorAfterVersionChangeCompletion):
(WebCore::IDBClient::IDBOpenDBRequest::fireErrorAfterVersionChangeAbort): Deleted.

• Modules/indexeddb/client/IDBOpenDBRequestImpl.h:

• Modules/indexeddb/client/IDBRequestImpl.cpp:

(WebCore::IDBClient::IDBRequest::dispatchEvent): Don't add finished transactions or closed databases as event targets.

• Modules/indexeddb/client/IDBTransactionImpl.cpp:

(WebCore::IDBClient::IDBTransaction::notifyDidAbort):
(WebCore::IDBClient::IDBTransaction::dispatchEvent): If this was a versionchange transaction completing, possibly fire

the error event on the OpenDBRequest instead of the success event.

• Modules/indexeddb/client/IDBTransactionImpl.h:

(WebCore::IDBClient::IDBTransaction::isFinished):

LayoutTests:

• platform/mac-wk1/TestExpectations:
• storage/indexeddb/modern/abort-requests-cancelled-expected.txt:
• storage/indexeddb/modern/aborted-put-expected.txt:
• storage/indexeddb/modern/createobjectstore-basic-expected.txt:
• storage/indexeddb/modern/deletedatabase-2-expected.txt:
• storage/indexeddb/modern/deletedatabase-2.html:
• storage/indexeddb/modern/deleteindex-2-expected.txt:
• storage/indexeddb/modern/deleteobjectstore-1-expected.txt:
• storage/indexeddb/modern/opendatabase-versions-expected.txt:
• storage/indexeddb/modern/opendatabase-versions.html:
• storage/indexeddb/modern/versionchange-abort-then-reopen-expected.txt:

5:21 PM Changeset in webkit [193935] by Brent Fulgham

• 2 edits in trunk

[Win] Support building under Cygwin or native Perl
​https://bugs.webkit.org/show_bug.cgi?id=152145
<rdar://problem/23839868>

Reviewed by David Kilzer.

• Source/cmake/tools/scripts/auto-version.pl: Correct handling of mixed DOS filenames when used in a

Cygwin context.

5:19 PM Changeset in webkit [193934] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

Simple line layout: Use TextPainter to draw simple line text.
​https://bugs.webkit.org/show_bug.cgi?id=152150

Reviewed by Simon Fraser.

No change in functionality.

• rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::paintFlow):

• rendering/TextPainter.h:

4:31 PM Changeset in webkit [193933] by commit-queue@webkit.org

• 21 edits in trunk/Source/JavaScriptCore

[JSC] Add a Modulo operator to B3, and a chill variant
​https://bugs.webkit.org/show_bug.cgi?id=152110

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-12-10
Reviewed by Geoffrey Garen.

It is basically refactoring the Div and ChillDiv
code to be used by both opcodes.

• b3/B3Common.h:

(JSC::B3::chillDiv):
(JSC::B3::chillMod):

• b3/B3Const32Value.cpp:

(JSC::B3::Const32Value::modConstant):

• b3/B3Const32Value.h:
• b3/B3Const64Value.cpp:

(JSC::B3::Const64Value::modConstant):

• b3/B3Const64Value.h:
• b3/B3ConstDoubleValue.cpp:

(JSC::B3::ConstDoubleValue::modConstant):

• b3/B3ConstDoubleValue.h:
• b3/B3LowerMacros.cpp:
• b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::lower):
(JSC::B3::Air::LowerToAir::lowerX86Div):

• b3/B3Opcode.cpp:

(WTF::printInternal):

• b3/B3Opcode.h:
• b3/B3ReduceStrength.cpp:
• b3/B3Validate.cpp:
• b3/B3Value.cpp:

(JSC::B3::Value::modConstant):
(JSC::B3::Value::effects):
(JSC::B3::Value::key):
(JSC::B3::Value::typeFor):

• b3/B3Value.h:
• b3/testb3.cpp:

(JSC::B3::testModArgDouble):
(JSC::B3::testModArgsDouble):
(JSC::B3::testModArgImmDouble):
(JSC::B3::testModImmArgDouble):
(JSC::B3::testModImmsDouble):
(JSC::B3::testModArgFloat):
(JSC::B3::testModArgsFloat):
(JSC::B3::testModArgImmFloat):
(JSC::B3::testModImmArgFloat):
(JSC::B3::testModImmsFloat):
(JSC::B3::testModArg):
(JSC::B3::testModArgs):
(JSC::B3::testModImms):
(JSC::B3::testModArg32):
(JSC::B3::testModArgs32):
(JSC::B3::testModImms32):
(JSC::B3::testChillModArg):
(JSC::B3::testChillModArgs):
(JSC::B3::testChillModImms):
(JSC::B3::testChillModArg32):
(JSC::B3::testChillModArgs32):
(JSC::B3::testChillModImms32):
(JSC::B3::run):

• ftl/FTLB3Output.h:

(JSC::FTL::Output::mod):
(JSC::FTL::Output::chillMod):
(JSC::FTL::Output::doubleMod):
(JSC::FTL::Output::rem): Deleted.
(JSC::FTL::Output::doubleRem): Deleted.

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::compileArithMod):

• ftl/FTLOutput.cpp:

(JSC::FTL::Output::chillMod):

• ftl/FTLOutput.h:

(JSC::FTL::Output::mod):
(JSC::FTL::Output::doubleMod):
(JSC::FTL::Output::rem): Deleted.
(JSC::FTL::Output::doubleRem): Deleted.

4:05 PM Changeset in webkit [193932] by mmaxfield@apple.com

• 2 edits in trunk/Source/WebCore

[Font Features] r193894 introduces leaks
​https://bugs.webkit.org/show_bug.cgi?id=152154

Reviewed by Joe Pecoraro.

• platform/graphics/cocoa/FontCocoa.mm:

(WebCore::smallCapsTrueTypeDictionary):
(WebCore::createCTFontWithoutSynthesizableFeatures):

4:00 PM Changeset in webkit [193931] by Ryan Haddad

• 1 edit
  1 add in trunk/LayoutTests

Rebaselining fast/text/emoji.html for Yosemite.
​https://bugs.webkit.org/show_bug.cgi?id=152147

Unreviewed test gardening.

• platform/mac-yosemite/fast/text/emoji-expected.txt: Added.

3:39 PM Changeset in webkit [193930] by mmaxfield@apple.com

• 4 edits in trunk

Build fix

Unreviewed.

Source/WebCore:

• platform/graphics/cocoa/FontCocoa.mm:

(WebCore::Font::variantCapsSupportsCharacterForSynthesis):

LayoutTests:

• platform/mac/TestExpectations:

3:30 PM Changeset in webkit [193929] by Alan Bujtas

• 5 edits in trunk/Source/WebCore

TextPainter: Add support for painting multiple text runs.
​https://bugs.webkit.org/show_bug.cgi?id=152148

Reviewed by Simon Fraser.

This is in preparation for adding simple line layout as a client.

No change in functionality.

• rendering/InlineTextBox.cpp:

(WebCore::drawSkipInkUnderline): Decouple underline skipping intersection calculation and text painter.
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintDecoration):

• rendering/InlineTextBox.h:
• rendering/TextPainter.cpp:

(WebCore::TextPainter::TextPainter):
(WebCore::TextPainter::paintTextWithShadows):
(WebCore::TextPainter::paintTextAndEmphasisMarksIfNeeded):
(WebCore::TextPainter::paintText):
(WebCore::TextPainter::dashesForIntersectionsWithRect): Deleted.

• rendering/TextPainter.h:

(WebCore::TextPainter::setTextPaintStyle):
(WebCore::TextPainter::setSelectionPaintStyle):
(WebCore::TextPainter::setIsHorizontal):
(WebCore::TextPainter::setFont):
(WebCore::TextPainter::addEmphasis):
(WebCore::TextPainter::addTextShadow):

3:02 PM Changeset in webkit [193928] by bshafiei@apple.com

• 5 edits in tags/Safari-602.1.13.3/Source

Versioning.

2:59 PM Changeset in webkit [193927] by bshafiei@apple.com

• 1 copy in tags/Safari-602.1.13.3

New tag.

2:38 PM Changeset in webkit [193926] by Matt Baker

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: debugger popover should have source location link when showing function source
​https://bugs.webkit.org/show_bug.cgi?id=151866

Reviewed by Brian Burg.

Added source code location link to function popover header.

• UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype._showPopoverForFunction.didGetDetails):
Create source code location link from response payload.
(WebInspector.SourceCodeTextEditor.prototype._showPopoverForFunction):

1:42 PM Changeset in webkit [193925] by Ryan Haddad

• 1 edit
  1 add in trunk/LayoutTests

Adding iOS-simulator expectations for compositing/layers-inside-overflow-scroll.html
​https://bugs.webkit.org/show_bug.cgi?id=152132

Unreviewed test gardening.

• platform/ios-simulator/compositing/layers-inside-overflow-scroll-expected.txt: Added.

1:26 PM Changeset in webkit [193924] by achristensen@apple.com

• 12 edits
  1 copy
  2 adds in trunk

REGRESSION (r192796) WKBundlePageResourceLoadClient should be able to setHTTPBody in willSendRequestForFrame
​https://bugs.webkit.org/show_bug.cgi?id=152022
rdar://problem/23763584

Reviewed by Darin Adler.

Source/WebKit2:

• Shared/API/c/WKURLRequest.cpp:

(WKURLRequestCopyHTTPMethod):
(WKURLRequestCopyWithHTTPBody):
(WKURLRequestSetDefaultTimeoutInterval):

• Shared/API/c/WKURLRequest.h:

Make WKURLRequestCopyWithHTTPBody SPI for testing.

• Shared/API/c/mac/WKURLRequestNS.mm:

(WKURLRequestCreateWithNSURLRequest):
Crash if someone tries to use an NSURLRequest with HTTPBodyStream, which will not work with the network process.

• WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.cpp:

(WebKit::InjectedBundlePageResourceLoadClient::willSendRequestForFrame):
Use an HTTP body if the client's willSendRequestForFrame returned one.
This is the functional change of this patch.

Tools:

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::willSendRequestForFrame):

• WebKitTestRunner/InjectedBundle/TestRunner.h:

(WTR::TestRunner::setWillSendRequestReturnsNull):
(WTR::TestRunner::willSendRequestReturnsNullOnRedirect):
(WTR::TestRunner::setWillSendRequestReturnsNullOnRedirect):
(WTR::TestRunner::setWillSendRequestAddsHTTPBody):
(WTR::TestRunner::willSendRequestHTTPBody):
Added setWillSendRequestAddsHTTPBody that uses new SPI for testing.

LayoutTests:

• TestExpectations:
• http/tests/misc/resources/post-echo.cgi: Copied from LayoutTests/http/tests/xmlhttprequest/resources/post-echo.cgi.
• http/tests/misc/will-send-request-with-client-provided-http-body-expected.txt: Added.
• http/tests/misc/will-send-request-with-client-provided-http-body.html: Added.
• platform/wk2/TestExpectations:

New test for WK2 only.

12:44 PM Changeset in webkit [193923] by commit-queue@webkit.org

• 3 edits in trunk/Tools

Remove additional simulator checks before running layout-tests
​https://bugs.webkit.org/show_bug.cgi?id=152146

Patch by Aakash Jain <​aakash_jain@apple.com> on 2015-12-10
Reviewed by Darin Adler.

• Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort.check_sys_deps): Removed additional simulators verifications.

• Scripts/webkitpy/xcode/simulator.py:

(Simulator._boot_and_shutdown_simulator_device): Deleted.
(Simulator.check_simulator_device_and_erase_if_needed): Deleted.

12:22 PM Changeset in webkit [193922] by enrica@apple.com

• 5 edits in trunk

Change skin tone support for two emoji.
​https://bugs.webkit.org/show_bug.cgi?id=152147
rdar://problem/23716993
rdar://problem/23716344

Reviewed by Darin Adler.

Source/WebCore:

Horse race emoji (1F3C7) should no longer have skin tone variation.
Sleuth/Spy emoji (!F575) should instead have skin tone variation.

• platform/text/TextBreakIterator.cpp:

(WebCore::cursorMovementIterator):

LayoutTests:

• fast/text/emoji.html:
• platform/mac/fast/text/emoji-expected.txt:

11:19 AM Changeset in webkit [193921] by matthew_hanson@apple.com

• 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Merge r190911. rdar://problem/23432368

11:19 AM Changeset in webkit [193920] by matthew_hanson@apple.com

• 3 edits in branches/safari-601.1.46-branch/LayoutTests

Merge r193641. rdar://problem/23814343

11:18 AM Changeset in webkit [193919] by matthew_hanson@apple.com

• 8 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merge r193481. rdar://problem/23110745

11:18 AM Changeset in webkit [193918] by matthew_hanson@apple.com

• 8 edits in branches/safari-601.1.46-branch/Source

Merge r193382. rdar://problem/23814344

11:18 AM Changeset in webkit [193917] by matthew_hanson@apple.com

• 13 edits
  6 adds
  4 deletes in branches/safari-601.1.46-branch

Merge r193286. rdar://problem/23814343

11:18 AM Changeset in webkit [193916] by matthew_hanson@apple.com

• 5 edits
  3 adds in branches/safari-601.1.46-branch

Merge r192772. rdar://problem/23797213

11:18 AM Changeset in webkit [193915] by matthew_hanson@apple.com

• 4 edits in branches/safari-601.1.46-branch/Source/WebCore

Merge r192758. rdar://problem/23814314

10:54 AM Changeset in webkit [193914] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Skip unsupported css3/font-variant-* tests on Win
​https://bugs.webkit.org/show_bug.cgi?id=149774

Unreviewed test gardening.

• platform/win/TestExpectations:

10:14 AM Changeset in webkit [193913] by Nikita Vasilyev

• 14 edits in trunk/Source/WebInspectorUI

Web Inspector: [Meta] Unify z-index values in Inspector's CSS
​https://bugs.webkit.org/show_bug.cgi?id=151978

Introduce CSS variables for z-index due to recurring issues with incorrectly overlapping elements.

From now on, all z-index values >= 64 must be defined as variables.
Values below 64 must not.

Reviewed by Timothy Hatcher.

• UserInterface/Views/Variables.css:

(:root):
Introduce z-index variables.

• UserInterface/Debug/UncaughtExceptionReporter.css:

(.sheet-container):

• UserInterface/Views/BoxModelDetailsSectionRow.css:

(.details-section .row.box-model .editing):

• UserInterface/Views/CompletionSuggestionsView.css:

(.completion-suggestions):

• UserInterface/Views/DashboardContainerView.css:

(.dashboard-container .advance-arrow):

• UserInterface/Views/DataGrid.css:

(.data-grid .resizer):

• UserInterface/Views/DetailsSection.css:

(.details-section > .header):
(.details-section .details-section > .header):

• UserInterface/Views/FindBanner.css:

(.find-banner):
(.find-banner > button.segmented:active):

• UserInterface/Views/Main.css:

(#docked-resizer):
(.message-text-view):
(.bouncy-highlight):

• UserInterface/Views/Popover.css:

(.popover):

• UserInterface/Views/Resizer.css:

(.resizer):
(.glass-pane-for-drag):

• UserInterface/Views/TimelineOverview.css:

(.timeline-overview > .scroll-container):

• UserInterface/Views/VisualStyleSelectorSection.css:

(.details-section.visual-style-selector-section > .content > .selectors > .selector-list > .section-divider):

10:03 AM Changeset in webkit [193912] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r193500.
​https://bugs.webkit.org/show_bug.cgi?id=152143

do not want to have to disable canvas-to-large-to-draw test
(Requested by bfulgham on #webkit).

Reverted changeset:

"Place an upper bound on canvas pixel count"
​https://bugs.webkit.org/show_bug.cgi?id=151825
​http://trac.webkit.org/changeset/193500

9:41 AM Changeset in webkit [193911] by dbates@webkit.org

• 88 edits in trunk/LayoutTests

[iOS][WK2] Update expected results for editing tests

• platform/ios-simulator-wk2/editing/deleting/delete-3608462-fix-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/4278698-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/before-after-input-element-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/editable-html-element-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/editing-empty-divs-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-3778059-fix-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-3851164-fix-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-at-end-01-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-br-009-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-br-at-tabspan-001-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-br-at-tabspan-002-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-br-at-tabspan-003-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-br-quoted-001-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-br-quoted-002-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-br-quoted-003-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-br-quoted-004-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-br-quoted-005-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-br-quoted-006-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-div-009-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-div-010-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-div-011-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-div-012-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-div-013-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-div-014-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-div-015-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-div-016-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-div-017-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-div-018-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-div-019-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-div-020-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-div-022-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-div-023-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-div-024-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-div-025-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-div-026-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-div-027-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-paragraph-01-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-paragraph-02-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-paragraph-03-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-paragraph-04-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-paragraph-05-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-tab-003-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-text-at-tabspan-001-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-text-at-tabspan-002-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-text-at-tabspan-003-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/insert-text-with-newlines-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/line-break-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/multiple-lines-selected-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/paragraph-separator-01-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/paragraph-separator-02-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/paragraph-separator-03-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/paragraph-separator-in-table-1-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/paragraph-separator-in-table-2-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/redo-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/return-key-with-selection-001-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/return-key-with-selection-002-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/return-key-with-selection-003-expected.txt:
• platform/ios-simulator-wk2/editing/inserting/typing-002-expected.txt:
• platform/ios-simulator-wk2/editing/style/apple-style-editable-mix-expected.txt:
• platform/ios-simulator-wk2/editing/style/block-style-001-expected.txt:
• platform/ios-simulator-wk2/editing/style/block-style-002-expected.txt:
• platform/ios-simulator-wk2/editing/style/block-style-003-expected.txt:
• platform/ios-simulator-wk2/editing/style/block-styles-007-expected.txt:
• platform/ios-simulator-wk2/editing/style/create-block-for-style-001-expected.txt:
• platform/ios-simulator-wk2/editing/style/create-block-for-style-002-expected.txt:
• platform/ios-simulator-wk2/editing/style/create-block-for-style-003-expected.txt:
• platform/ios-simulator-wk2/editing/style/create-block-for-style-004-expected.txt:
• platform/ios-simulator-wk2/editing/style/create-block-for-style-005-expected.txt:
• platform/ios-simulator-wk2/editing/style/create-block-for-style-006-expected.txt:
• platform/ios-simulator-wk2/editing/style/create-block-for-style-007-expected.txt:
• platform/ios-simulator-wk2/editing/style/create-block-for-style-008-expected.txt:
• platform/ios-simulator-wk2/editing/style/create-block-for-style-009-expected.txt:
• platform/ios-simulator-wk2/editing/style/create-block-for-style-010-expected.txt:
• platform/ios-simulator-wk2/editing/style/create-block-for-style-011-expected.txt:
• platform/ios-simulator-wk2/editing/style/create-block-for-style-012-expected.txt:
• platform/ios-simulator-wk2/editing/style/create-block-for-style-013-expected.txt:
• platform/ios-simulator-wk2/editing/style/designmode-expected.txt:
• platform/ios-simulator-wk2/editing/style/relative-font-size-change-001-expected.txt:
• platform/ios-simulator-wk2/editing/style/relative-font-size-change-002-expected.txt:
• platform/ios-simulator-wk2/editing/style/relative-font-size-change-003-expected.txt:
• platform/ios-simulator-wk2/editing/style/relative-font-size-change-004-expected.txt:
• platform/ios-simulator-wk2/editing/style/style-3681552-fix-002-expected.txt:
• platform/ios-simulator-wk2/editing/style/style-3998892-fix-expected.txt:
• platform/ios-simulator-wk2/editing/style/style-boundary-001-expected.txt:
• platform/ios-simulator-wk2/editing/style/style-boundary-004-expected.txt:
• platform/ios-simulator-wk2/editing/style/table-selection-expected.txt:
• platform/ios-simulator-wk2/editing/style/unbold-in-bold-expected.txt:

9:33 AM Changeset in webkit [193910] by Csaba Osztrogonác

• 2 edits in trunk/Source/JavaScriptCore

[B3] Add new files to the cmake build system
​https://bugs.webkit.org/show_bug.cgi?id=152120

Reviewed by Filip Pizlo.

• CMakeLists.txt:

9:03 AM Changeset in webkit [193909] by beidson@apple.com

• 2 edits in trunk/Source/WebCore

Followup for:
Modern IDB: storage/indexeddb/intversion-close-between-events.html fails.
​https://bugs.webkit.org/show_bug.cgi?id=152096

Implementing Darin Adler's review feedback that came after the patch landed.

• bindings/js/JSIDBDatabaseCustom.cpp:

(WebCore::JSIDBDatabase::transaction): No need to explicitly cast to Vector<String>.

8:50 AM Changeset in webkit [193908] by Csaba Osztrogonác

• 2 edits in trunk/Source/JavaScriptCore

[B3] Use mark pragmas only if it is supported
​https://bugs.webkit.org/show_bug.cgi?id=152123

Reviewed by Mark Lam.

• ftl/FTLB3Output.h:

8:38 AM Changeset in webkit [193907] by Yusuke Suzuki

• 1 edit
  15 adds in trunk/LayoutTests

[ES6] Add several generator related JSRegress tests to measure performance change after optimization
​https://bugs.webkit.org/show_bug.cgi?id=151785

Reviewed by Saam Barati.

Before starting optimization for ES6 Generators, add several JSRegress tests to measure that.

• js/regress/generator-create-expected.txt: Added.
• js/regress/generator-create.html: Added.
• js/regress/generator-fib-expected.txt: Added.
• js/regress/generator-fib.html: Added.
• js/regress/generator-function-create-expected.txt: Added.
• js/regress/generator-function-create.html: Added.
• js/regress/generator-sunspider-access-nsieve-expected.txt: Added.
• js/regress/generator-sunspider-access-nsieve.html: Added.
• js/regress/generator-with-several-types-expected.txt: Added.
• js/regress/generator-with-several-types.html: Added.
• js/regress/script-tests/generator-create.js: Added.

(gen):

• js/regress/script-tests/generator-fib.js: Added.

(result):

• js/regress/script-tests/generator-function-create.js: Added.

(createGeneratorFunction.gen):
(createGeneratorFunction):

• js/regress/script-tests/generator-sunspider-access-nsieve.js: Added.

(prime):
(sieve):

• js/regress/script-tests/generator-with-several-types.js: Added.

(g1):
(g2):
(g3):

8:11 AM Changeset in webkit [193906] by Csaba Osztrogonác

• 2 edits in trunk/Source/JavaScriptCore

[B3] Typo fix in testb3.cpp
​https://bugs.webkit.org/show_bug.cgi?id=152126

Reviewed by Mark Lam.

• b3/testb3.cpp:

(JSC::B3::populateWithInterestingValues):

8:07 AM Changeset in webkit [193905] by Csaba Osztrogonác

• 2 edits in trunk/Source/JavaScriptCore

[B3] Fix unused-but-set-variable warning
​https://bugs.webkit.org/show_bug.cgi?id=152122

Reviewed by Mark Lam.

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::lower):

8:04 AM Changeset in webkit [193904] by Csaba Osztrogonác

• 2 edits in trunk/Source/JavaScriptCore

[B3] Make GCC ignore warnings in FTLB3Output.h
​https://bugs.webkit.org/show_bug.cgi?id=152124

Reviewed by Mark Lam.

• ftl/FTLB3Output.h:

8:03 AM Changeset in webkit [193903] by Carlos Garcia Campos

• 2 edits in trunk/LayoutTests

Unreviewed. Fix ambiguous expectations added in r193895.

• platform/gtk/TestExpectations:

8:02 AM Changeset in webkit [193902] by Csaba Osztrogonác

• 2 edits in trunk/Source/JavaScriptCore

[EFL] Remove the unused IncrementalSweeper::m_isTimerFrozen member after r193749
​https://bugs.webkit.org/show_bug.cgi?id=152127

Reviewed by Mark Lam.

• heap/IncrementalSweeper.h:

4:12 AM Changeset in webkit [193901] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebKit2

[CoordinatedGraphics] Reserve capacity for the children vector in CoordinatedGraphicsScene::setLayerChildrenIfNeeded()
​https://bugs.webkit.org/show_bug.cgi?id=152117

Reviewed by Martin Robinson.

• Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::setLayerChildrenIfNeeded): Reserve the capacity
for the new Vector that will contain the same number of items as the Vector
on the CoordinatedGraphicsLayerState object.

4:01 AM Changeset in webkit [193900] by Csaba Osztrogonác

• 2 edits in trunk/Source/JavaScriptCore

Source/JavaScriptCore/create_hash_table shouldn't be too verbose
​https://bugs.webkit.org/show_bug.cgi?id=151861

Reviewed by Darin Adler.

• create_hash_table:

2:50 AM Changeset in webkit [193899] by youenn.fablet@crf.canon.fr

• 11 edits
  5 adds in trunk

JSC Builtins should use safe array methods
​https://bugs.webkit.org/show_bug.cgi?id=151501

Reviewed by Darin Adler.

Source/JavaScriptCore:

Adding @push and @shift to Array prototype.
Using @push in TypedArray built-in.

Covered by added test in LayoutTests/js/builtins

• builtins/TypedArray.prototype.js:

(filter):

• runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::finishCreation):

• runtime/CommonIdentifiers.h:

Source/WebCore:

Using @push and @shift in internal arrays in lieu of push and shift.
This cannot be disrupted by user scripts except if arrays are also made accessible to user scripts.

Covered by added tests for ReadableStream constructs.

• Modules/mediastream/RTCPeerConnectionInternals.js:

(runNext):
(enqueueOperation):

• Modules/streams/ReadableStreamInternals.js:

(enqueueInReadableStream):
(readFromReadableStreamReader):

• Modules/streams/StreamInternals.js:

(dequeueValue):
(enqueueValueWithSize):

LayoutTests:

Adding shielding test for TypedArray.prototype.filter and stream enqueuing of values and read promises.

• js/builtins/resources/shielding-typedarray.js: Added.

(Array.prototype.push):
(try.array.Int8Array.from.string_appeared_here.filter):

• js/builtins/shielding-typedarray-expected.txt: Added.
• js/builtins/shielding-typedarray.html: Added.
• streams/streams-promises-expected.txt:
• streams/streams-promises.html:

2:24 AM Changeset in webkit [193898] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

[TexMap] pixel coverage multiplication in TiledBackingStore can overflow
​https://bugs.webkit.org/show_bug.cgi?id=152055

Reviewed by Carlos Garcia Campos.

The computation of the pixel coverage in TiledBackingStore can easily overflow
when the candidate size is relatively large (for instance when the backed
layer is transformed in a way that increases its perceived size). This can result
in missing tiles for this specific backing store, at least until the layer in
question is transformed again into a shape that produces a smaller candidate size.

To avoid the integer overflow, the multiplication is done in a safe manner,
defaulting to the max positive value an integer can hold in case the overflow
is detected.

• platform/graphics/texmap/coordinated/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::adjustForContentsRect):

2:23 AM Changeset in webkit [193897] by zandobersek@gmail.com

• 4 edits in trunk/Source/WebCore

[TexMap] Clean up BitmapTexturePool
​https://bugs.webkit.org/show_bug.cgi?id=152073

Reviewed by Daniel Bates.

Move BitmapTexturePoolEntry class under the BitmapTexturePool class, renaming
it to simply Entry and keeping it private. Have the constructor take in an
rvalue reference to the RefPtr<BitmapTexture> object. Remove the static
compareTimeLastUsed() function and use a lambda directly in its place.

Remove the default BitmapTexturePool constructor, which isn't used anywhere.
Have the constructor and some methods accept or return RefPtr objects, possibly
via rvalue references. Clean up the header file by removing a few unnecessary
header includes and using forward declarations where possible.

In the BitmapTexturePool implementation file, mark the two const variables as
static. The ::acquireTexture() method now uses the std::find_if() algorithm
to find a fitting Entry object in the Vector. The same method is also moved
upwards so we follow the order of declaration in the header. ::createTexture()
inlines the return of the new expression into the adoptRef() call in the return
statement.

TextureMapperGL constructor is updated to pass a copied RefPtr object into the
BitmapTexturePool constructor.

• platform/graphics/texmap/BitmapTexturePool.cpp:

(WebCore::BitmapTexturePool::BitmapTexturePool):
(WebCore::BitmapTexturePool::acquireTexture):
(WebCore::BitmapTexturePool::releaseUnusedTexturesTimerFired):
(WebCore::BitmapTexturePool::createTexture):

• platform/graphics/texmap/BitmapTexturePool.h:

(WebCore::BitmapTexturePool::Entry::Entry):
(WebCore::BitmapTexturePool::Entry::markUsed):
(WebCore::BitmapTexturePoolEntry::BitmapTexturePoolEntry): Deleted.
(WebCore::BitmapTexturePoolEntry::markUsed): Deleted.
(WebCore::BitmapTexturePoolEntry::compareTimeLastUsed): Deleted.

• platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::TextureMapperGL):

2:15 AM Changeset in webkit [193896] by Michael Catanzaro

• 2 edits in trunk/Source/WebCore

[GTK] RenderThemeGtk::platformActiveSelectionBackgroundColor, et. al. should not clobber state of cached GtkStyleContexts
​https://bugs.webkit.org/show_bug.cgi?id=151533

Reviewed by Carlos Garcia Campos.

Remove the style context cache to simplify the code, drastically reduce the number of
expensive save/restore operations performed on style contexts, and avoid unwanted
side-effects in RenderThemeGtk::styleColor. This is also a speculative fix for improper
button rendering with certain custom themes, and a simplification that will make it easier
to fix bug #150550.

This change does have performance implications, which I intend to check on the perf bot
after landing to ensure that removing the cache does not have a significant negative impact
on performance; I have no clue whether this will be a net performance win or loss. However,
this is a bit tricky, because the bot is running GTK+ 3.16, whereas I expect save/restore
might be much more expensive in GTK+ 3.20, and I do not want to make performance decisions
except based on the latest GTK+ due to large changes in the implementation of
GtkStyleContext.

• rendering/RenderThemeGtk.cpp:

(WebCore::createStyleContext):
(WebCore::getStockIconForWidgetType):
(WebCore::getStockSymbolicIconForWidgetType):
(WebCore::RenderThemeGtk::initMediaColors):
(WebCore::RenderThemeGtk::adjustRepaintRect):
(WebCore::setToggleSize):
(WebCore::paintToggle):
(WebCore::RenderThemeGtk::setCheckboxSize):
(WebCore::RenderThemeGtk::setRadioSize):
(WebCore::RenderThemeGtk::paintButton):
(WebCore::getComboBoxMetrics):
(WebCore::RenderThemeGtk::paintMenuList):
(WebCore::RenderThemeGtk::paintTextField):
(WebCore::RenderThemeGtk::paintSliderTrack):
(WebCore::RenderThemeGtk::paintSliderThumb):
(WebCore::RenderThemeGtk::adjustSliderThumbSize):
(WebCore::RenderThemeGtk::paintProgressBar):
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeGtk::paintInnerSpinButton):
(WebCore::styleColor):
(WebCore::gtkStyleChangedCallback): Deleted.
(WebCore::styleContextMap): Deleted.
(WebCore::getStyleContext): Deleted.

1:20 AM Changeset in webkit [193895] by Carlos Garcia Campos

• 2 edits in trunk/LayoutTests

Unreviewed. GTK+ gardening: skip HLS tests crashing in debug after r192102.

• platform/gtk/TestExpectations:

12:37 AM Changeset in webkit [193894] by mmaxfield@apple.com

• 14 edits
  10 adds in trunk

font-variant-caps does not work if the font does not support font features
​https://bugs.webkit.org/show_bug.cgi?id=149774

Reviewed by Antti Koivisto.

Source/WebCore:

This test implements synthesis for small-caps and all-small-caps. It does so by
moving font variant selection into a higher level (ComplexTextController).
In general, the approach is to use the pure font feature until we encounter
a character which needs to be uppercased, and which the font feature does not
support uppercasing. In this situation, we try again with synthesis. In this
case, synthesis means artificially uppercasing letters and rendering them with
a smaller font.

We require system support to know which glyphs a particular font feature supports.
Therefore, on operating systems which do not include this support, we will simply
say that the font feature does not support any glyphs.

Test: css3/font-variant-small-caps-synthesis.html

css3/font-variant-petite-caps-synthesis.html

• platform/graphics/Font.cpp:

(WebCore::Font::noSmallCapsFont): Return the same font, but without smcp or c2sc.
This function utilizes a cache.

• platform/graphics/Font.h:

(WebCore::Font::variantFont): Small caps should never go through this function
anymore.

• platform/graphics/FontCascade.h: Because we're moving variant selection into

a higher level, we remove the FontVariant argument from the lower-level call.

• platform/graphics/FontCascadeFonts.cpp:

(WebCore::FontCascadeFonts::glyphDataForVariant): Use early-return style.
(WebCore::FontCascadeFonts::glyphDataForNormalVariant): Ditto.

• platform/graphics/cocoa/FontCascadeCocoa.mm:

(WebCore::FontCascade::fontForCombiningCharacterSequence): Because we're moving
variant selection into a higher level, we remove the FontVariant argument from
the lower-level call.

• platform/graphics/cocoa/FontCocoa.mm:

(WebCore::Font::smallCapsSupportsCharacter):
(WebCore::Font::allSmallCapsSupportsCharacter):
(WebCore::smallCapsOpenTypeDictionary): Helper function for
smallCapsSupportsCharacter().
(WebCore::smallCapsTrueTypeDictionary): Ditto.
(WebCore::unionBitVectors):
(WebCore::Font::glyphsSupportedBySmallCaps): Compute a bit vector of supported
glyphs.
(WebCore::Font::glyphsSupportedByAllSmallCaps): Ditto.
(WebCore::createDerivativeFont): Moving common code into its own helper function.
(WebCore::Font::createFontWithoutSmallCaps):
(WebCore::Font::platformCreateScaledFont): Use the common code.

• platform/graphics/mac/ComplexTextController.cpp:

(WebCore::capitalized): What is the capitalized form of a character?
(WebCore::ComplexTextController::collectComplexTextRuns): Implement the core
logic of this patch. This includes the retry when we encounter a character which
is not supported by the font feature.

• platform/spi/cocoa/CoreTextSPI.h:

LayoutTests:

Adding two new font which include lowercase characters which respond to 'smcp' and 'c2sc'.

The character mappings are:

OpenType:
'smcp': f
'c2sc': g

TrueType:
kLowerCaseType / kLowerCaseSmallCapsSelector: r
kUpperCaseType / kUpperCaseSmallCapsSelector: u

• css3/font-variant-all-expected.html:
• css3/font-variant-all.html:
• css3/font-variant-small-caps-synthesis-expected.html: Added.
• css3/font-variant-small-caps-synthesis.html: Added.
• css3/font-variant-petite-caps-synthesis-expected.html: Added.
• css3/font-variant-petite-caps-synthesis.html: Added.
• css3/resources/FontWithFeaturesLowercaseSmallCaps.otf: Added.
• css3/resources/FontWithFeaturesLowercaseSmallCaps.ttf: Added.
• platform/mac/TestExpectations:
• platform/mac/fast/writing-mode/broken-ideograph-small-caps-expected.txt:

12:32 AM WebKitGTK/Gardening/Calendar edited by Martin Robinson

(diff)

12:28 AM Changeset in webkit [193893] by zandobersek@gmail.com

• 6 edits in trunk/Source/WebCore

[TexMap] Remove the TEXMAP_OPENGL_ES_2 define
​https://bugs.webkit.org/show_bug.cgi?id=152069

Reviewed by Alex Christensen.

Remove the TEXMAP_OPENGL_ES_2 macro define and clean up the code
that it was (not) guarding.

• platform/graphics/texmap/BitmapTexture.h:
• platform/graphics/texmap/BitmapTextureGL.cpp: Remove the TEXMAP_OPENGL_ES_2

guard. Keep the GL_UNSIGNED_INT_8_8_8_8_REV define for OS(DARWIN), but use
the GraphicsContext3D constants for other values.
(WebCore::BitmapTextureGL::updateContentsNoSwizzle):
(WebCore::BitmapTextureGL::initializeStencil): Remove the TEXMAP_OPENGL_ES_2
guard and default to calling the renderbufferStorage() function with the
GraphicsContext3D::STENCIL_INDEX8 argument.

• platform/graphics/texmap/BitmapTexturePool.h:
• platform/graphics/texmap/TextureMapper.h:
• platform/graphics/texmap/TextureMapperGL.cpp: Remove both the TEXMAP_OPENGL_ES_2

guard and the code it guarded. Because we were defining TEXMAP_OPENGL_ES_2 and not
USE_TEXMAP_OPENGL_ES_2, the guarded defines were always enforced, but they're never
actually used in this file anyway.

Dec 9, 2015:

11:09 PM Changeset in webkit [193892] by beidson@apple.com

• 12 edits
  4 copies in trunk

Modern IDB: storage/indexeddb/objectstore-basics.html fails.
​https://bugs.webkit.org/show_bug.cgi?id=152101

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (Multiple tests updated to the new error messaging cover it).

• Modules/indexeddb/client/IDBObjectStoreImpl.cpp:

(WebCore::IDBClient::IDBObjectStore::putOrAdd): Add plenty of detailed error messaging.

LayoutTests:

• platform/mac-wk1/TestExpectations:
• platform/wk2/storage/indexeddb/mozilla/bad-keypath-expected.txt: Copied from LayoutTests/storage/indexeddb/mozilla/bad-keypath-expected.txt.
• platform/wk2/storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt: Copied from LayoutTests/storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt.
• platform/wk2/storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt: Copied from LayoutTests/storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt.
• platform/wk2/storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt: Copied from LayoutTests/storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt.
• storage/indexeddb/invalid-keys-expected.txt:
• storage/indexeddb/key-type-binary-expected.txt:
• storage/indexeddb/keypath-edges-expected.txt:
• storage/indexeddb/mozilla/bad-keypath-expected.txt:
• storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
• storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
• storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
• storage/indexeddb/objectstore-basics-expected.txt:

8:59 PM Changeset in webkit [193891] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

TextPainter: Make before and after selection painting more explicit.
​https://bugs.webkit.org/show_bug.cgi?id=152104

Reviewed by Myles C. Maxfield.

Instead of swapping start end end positions and expecting TextPainter::drawTextOrEmphasisMarks()
to recognize it, we call painting with 0 - startPosition and endPosition - length.

No change in functionality.

• rendering/TextPainter.cpp:

(WebCore::TextPainter::drawTextOrEmphasisMarks):
(WebCore::TextPainter::paintTextAndEmphasisMarksIfNeeded):
(WebCore::TextPainter::paintText):
(WebCore::TextPainter::paintEmphasisMarksIfNeeded): Deleted.
(WebCore::TextPainter::paintTextWithStyle): Deleted.

• rendering/TextPainter.h:

7:50 PM Changeset in webkit [193890] by fpizlo@apple.com

• 7 edits
  1 add in trunk/Source

FTL B3 should have basic GetById support
​https://bugs.webkit.org/show_bug.cgi?id=152035

Reviewed by Saam Barati.

Source/JavaScriptCore:

Adds basic GetById support. This was so easy to do. Unlike the LLVM code for this, the B3 code is
entirely self-contained within the getById() method in LowerDFG.

I discovered that we weren't folding Check(NotEqual(x, 0)) to Check(x). This was preventing us
from generating good code for Check(NotEqual(BitAnd(x, tagMask), 0)), since the BitAnd was
concealed. This was an easy strength reduction rule to add.

Finally, I found it easier to say append(value, rep) than append(ConstrainedValue(value, rep)), so
I added that API. The old ConstrainedValue form is still super useful in other places, like
compileCallOrConstruct(), where the two-argument form would be awkward. It's great to have both
APIs to pick from.

• b3/B3ReduceStrength.cpp:
• b3/B3StackmapValue.cpp:

(JSC::B3::StackmapValue::~StackmapValue):
(JSC::B3::StackmapValue::append):

• b3/B3StackmapValue.h:
• dfg/DFGCommon.h:
• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::getById):

Source/WTF:

When dealing with shared task lambdas, you often want to force a value to be allocated so that it
has reference semantics, but you still want the lambda to execute OK when we pop stack. In PL we
usually call this a "box". This is easy to do if the value that happened to be stack-allocated
is also RefCounted, but that's rare, since stack-allocated values often have copy semantics. So,
I've added a Box type to WTF. Behind the scenes, it allocates your object with fast malloc inside
a ThreadSAfeRefCounted. When you pass Box<T>, you're passing the reference. This makes it a lot
easier to work with by-reference capture.

• WTF.xcodeproj/project.pbxproj:
• wtf/Box.h: Added.

(WTF::Box::Box):
(WTF::Box::create):
(WTF::Box::get):
(WTF::Box::operator*):
(WTF::Box::operator->):
(WTF::Box::operator bool):
(WTF::Box::Data::Data):

7:42 PM Changeset in webkit [193889] by dbates@webkit.org

• 2 edits in trunk/Websites/bugs.webkit.org

REGRESSION: code-review-tests.html fails with error "Received an error at line 214"
​https://bugs.webkit.org/show_bug.cgi?id=152103

Reviewed by Darin Adler.

Fixes an issue where opening the file code-review-test.html in Safari shows the error message
"FAIL: Received an error at line 214" and in the console there is a JavaScript TypeError:

undefined is not an object (evaluating '$('.overallComments textarea').val().trim')

Notice that test testReaddDiscardedCommentWithPreviousComment() is the only test that appends
the toolbar, which inserts the overall comments textarea. The test testSaveCommentsWithMissingLineIds()
assumes that the own properties of the window object are enumerated in the same order as they
were defined in the file code-review-test.html such that the test testReaddDiscardedCommentWithPreviousComment()
is executed before test testSaveCommentsWithMissingLineIds(). The behavior of JavaScriptCore with
respect to the enumeration order of properties on the window object have changed since the
test testSaveCommentsWithMissingLineIds() was written such that the order of the own properties
on the window object do not reflect the order in which they were defined in the file. We should
append the toolbar before running the tests and explicitly execute the tests in chosen order so
as to be able to reason of the test results regardless of the enumeration ordering of the
properties in the DOM window object.

Also, removed duplicate 'd' in the name of function "testReaddDiscardedCommentWithPreviousComment"
such that it reads "testReadDiscardedCommentWithPreviousComment".

• code-review-test.html:

7:16 PM Changeset in webkit [193888] by Simon Fraser

• 4 edits
  6 adds in branches/safari-601.1.46-branch

Merge r191590. rdar://problem/23432368

7:16 PM Changeset in webkit [193887] by Simon Fraser

• 3 edits in branches/safari-601.1.46-branch/Source/WebCore

Merge r190914. rdar://problem/23432368

7:16 PM Changeset in webkit [193886] by Simon Fraser

• 22 edits in branches/safari-601.1.46-branch/Source/WebCore

Merge r190910. rdar://problem/23432368

6:53 PM Changeset in webkit [193885] by dbates@webkit.org

• 6 edits
  3 adds in trunk

[iOS] Suspend and resume device motion and device orientation updates when page is hidden and visible, respectively
​https://bugs.webkit.org/show_bug.cgi?id=151840
<rdar://problem/23753931>

Reviewed by Simon Fraser.

.:

Add a manual test that can be used to verify that we suspend dispatching device motion and
device orientation events when the page is hidden.

• ManualTests/ios/resources/suspend-orientation-and-motion-events-when-page-becomes-hidden.js: Added.

(resetTest):
(checkEvent):
(handleVisibilityChange):

• ManualTests/ios/suspend-orientation-and-motion-events-when-page-becomes-hidden.html: Added.

Source/WebCore:

• dom/Document.cpp:

(WebCore::Document::suspendDeviceMotionAndOrientationUpdates): Added.
(WebCore::Document::resumeDeviceMotionAndOrientationUpdates): Added.
(WebCore::Document::platformSuspendOrStopActiveDOMObjects): Moved logic to suspend device motion and
orientation updates from here to Document::suspendDeviceMotionAndOrientationUpdates().
(WebCore::Document::suspendActiveDOMObjects): Modified to call Document::suspendDeviceMotionAndOrientationUpdates().
(WebCore::Document::resumeActiveDOMObjects): Modified to call Document::resumeDeviceMotionAndOrientationUpdates().

• dom/Document.h:
• page/Page.cpp:

(WebCore::Page::setIsVisibleInternal): Suspend device motion and orientation updates when the page is hidden and
resume updates when the page is visible.
(WebCore::Page::suspendDeviceMotionAndOrientationUpdates): Added.
(WebCore::Page::resumeDeviceMotionAndOrientationUpdates): Added.

• page/Page.h:

6:51 PM Changeset in webkit [193884] by dbates@webkit.org

• 10 edits in trunk/Source/WebCore

Unify iOS Frame::setTimersPaused() logic and Frame::{suspend, resume}ActiveDOMObjectsAndAnimations()
​https://bugs.webkit.org/show_bug.cgi?id=152006

Reviewed by Simon Fraser.

Currently we have almost identical logic to suspend and resume a web page for iOS and non-iOS ports.
We should unify this logic instead of duplicating it.

• dom/ActiveDOMObject.h: Remove iOS-specific enumeration DocumentWillBePaused and standardize on

enumerator PageWillBeSuspended.

• dom/Document.cpp:

(WebCore::Document::didBecomeCurrentDocumentInFrame): Unify iOS and non-iOS-specific code.
(WebCore::Document::suspendScheduledTasks): Ignore subsequent calls to this function so long as the reason for
the first invocation was ActiveDOMObject::PageWillBeSuspended. Such a subsequent call may occur as part of
handling a scroll or zoom gesture.

• dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::suspendActiveDOMObjects): Ignore subsequent calls to this function
so long as the reason for the first invocation was ActiveDOMObject::PageWillBeSuspended. Such a subsequent
call may occur as part of the process of a page being added to the page cache.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::suspend): Remove case for ActiveDOMObject::DocumentWillBePaused as this
enumerator is being removed.

• page/DOMTimer.cpp:

(WebCore::DOMTimer::install): Write logic that used Frame::timersPaused() terms of
ScriptExecutionContext::activeDOMObjectsAreSuspended() as we are removing Frame::timersPaused().
(WebCore::DOMTimer::fired): Remove iOS-specific assertion with respect to Frame::timersPaused().
This function already asserts the equivalent condition that ScriptExecutionContext::activeDOMObjectsAreSuspended()
evaluates to false. Clean up iOS-specific code that depends on the ScriptExecutionContext being a
Document object by taking advantage of the fact that this assumption is true when shouldBeginObservingChanges
evaluates to true.

• page/Frame.cpp:

(WebCore::Frame::Frame): Remove instance variable m_timersPausedCount and unify the iOS and non-iOS logic.
(WebCore::Frame::suspendActiveDOMObjectsAndAnimations): Standardize on the iOS logic for suspending
DOM objects and animations because it is more comprehensive on what it suspends and works with the deferred
loading machinery (Page::setDefersLoading() - see remarks in Frame::resumeActiveDOMObjectsAndAnimations() for
more details). Specifically, make use of Frame::clearTimers() to suspend non-scripted animations (i.e. non-requestAnimationFrame()
animations), auto-scroll timer, and pending relayouts. And use Document::suspendScheduledTasks() to suspend
all other tasks, including WebSQL database callbacks, active DOM objects, scripted animations and execution of
<script async>/<script defer> JavaScript scripts.
(WebCore::Frame::resumeActiveDOMObjectsAndAnimations): Standardize on the iOS logic for resuming
DOM objects and animations for symmetry and because it works with the deferred loading machinery. We call
Document::resumeScheduledTasks() (which calls Document::resumeActiveDOMObjects()) instead of calling
Document::resumeActiveDOMObjects() directly because the former will ultimately process the queue of pending
tasks (Document::m_pendingTasks).

• page/Frame.h: Remove instance variable m_timersPausedCount.

(WebCore::Frame::timersPaused): Deleted.

• page/ios/FrameIOS.mm:

(WebCore::Frame::setTimersPaused): Write this function in terms of Page::{suspend, resume}ActiveDOMObjectsAndAnimations().
We need to keep this function for Legacy WebKit on iOS.
(WebCore::Frame::setTimersPausedInternal): Deleted.

• rendering/RenderElement.cpp:

(WebCore::shouldRepaintForImageAnimation): Remove iOS-specific code to early return when Frame::timersPaused()
evaluates to true. This function already has the equivalent code to early return when Document::activeDOMObjectsAreSuspended()
evaluates to true.

6:50 PM Changeset in webkit [193883] by dbates@webkit.org

• 2 edits in trunk/Source/WebKit2

[iOS] Bail out if the page proxy is invalid when WebPageProxy::processWillBecome{Foreground, Suspended}() are called
​https://bugs.webkit.org/show_bug.cgi?id=151877

Reviewed by Darin Adler.

We cannot assume that a WebPageProxy is in a valid state when WebPageProxy::processWillBecome{Foreground, Suspended}()
are called because these callbacks may occur after the web process crashed and before a
WebPageProxy attaches to a new web process (and hence is considered in a valid state).

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::processWillBecomeSuspended): Early return if the page proxy is invalid.
(WebKit::WebPageProxy::processWillBecomeForeground): Ditto.

5:18 PM Changeset in webkit [193882] by bshafiei@apple.com

• 5 edits in branches/safari-601.4-branch/Source

Versioning.

5:12 PM Changeset in webkit [193881] by bshafiei@apple.com

• 5 edits in branches/safari-601-branch/Source

Versioning.

5:08 PM Changeset in webkit [193880] by bshafiei@apple.com

• 5 edits in branches/safari-601.1.46.60-branch/Source

Versioning.

4:59 PM Changeset in webkit [193879] by bshafiei@apple.com

• 1 copy in tags/Safari-601.5.5

New tag.

4:53 PM Changeset in webkit [193878] by beidson@apple.com

• 6 edits
  3 adds in trunk

Modern IDB: storage/indexeddb/metadata.html fails
​https://bugs.webkit.org/show_bug.cgi?id=152099

Reviewed by Alex Christensen.

Source/WebCore:

Test: storage/indexeddb/modern/abort-objectstore-info.html

And at least one existing failure now passes.

We did not properly reset object store info when version change transactions aborted.

• Modules/indexeddb/client/IDBObjectStoreImpl.cpp:

(WebCore::IDBClient::IDBObjectStore::IDBObjectStore):
(WebCore::IDBClient::IDBObjectStore::rollbackInfoForVersionChangeAbort):

• Modules/indexeddb/client/IDBObjectStoreImpl.h:

• Modules/indexeddb/client/IDBTransactionImpl.cpp:

(WebCore::IDBClient::IDBTransaction::abort):

LayoutTests:

• platform/mac-wk1/TestExpectations:
• storage/indexeddb/modern/abort-objectstore-info-expected.txt: Added.
• storage/indexeddb/modern/abort-objectstore-info.html: Added.
• storage/indexeddb/modern/resources/abort-objectstore-info.js: Added.

3:57 PM Changeset in webkit [193877] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r193864.
​https://bugs.webkit.org/show_bug.cgi?id=152100

caused all inspector tests to assert in WK2 Debug (Requested
by brrian on #webkit).

Reverted changeset:

"Web Inspector: reproducible debug ASSERT when inspecting the
inspector (WK2)"
​https://bugs.webkit.org/show_bug.cgi?id=152080
​http://trac.webkit.org/changeset/193864

3:51 PM Changeset in webkit [193876] by Simon Fraser

• 3 edits in trunk/Source/WebCore

Adjust layer backing store format
​https://bugs.webkit.org/show_bug.cgi?id=152097
rdar://problem/23305376

Reviewed by Tim Horton.

Call setBackingStoreFormat() on UIWebView tile grid layers, and on compositing
layers which can allocate backing store.

• platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(WebCore::setBackingStoreFormat):
(PlatformCALayerCocoa::commonInit):

• platform/ios/LegacyTileGridTile.mm:

(WebCore::setBackingStoreFormat):
(WebCore::LegacyTileGridTile::LegacyTileGridTile):

3:40 PM Changeset in webkit [193875] by beidson@apple.com

• 4 edits in trunk

Modern IDB: storage/indexeddb/intversion-close-between-events.html fails.
​https://bugs.webkit.org/show_bug.cgi?id=152096

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (At least one failing test now passes).

• bindings/js/JSIDBDatabaseCustom.cpp:

(WebCore::JSIDBDatabase::transaction): In addition to JSArrays, treat DOMStringLists as a valid string sequence.

LayoutTests:

• platform/mac-wk1/TestExpectations:

3:23 PM Changeset in webkit [193874] by bshafiei@apple.com

• 1 copy in tags/Safari-601.4.2

New tag.

3:21 PM Changeset in webkit [193873] by akling@apple.com

• 7 edits in trunk/Source

[iOS] ResourceUsageOverlay should work on iOS.
<​https://webkit.org/b/152021>

Reviewed by Antti Koivisto.

Source/WebCore:

Make ResourceUsageOverlay work on iOS and on Mac desktops with UI-side compositing.

• page/ResourceUsageOverlay.cpp:

(WebCore::ResourceUsageOverlay::initialize): Move the overlay to the top of the view on iOS for now.

• page/ResourceUsageOverlay.h:
• page/cocoa/ResourceUsageOverlayCocoa.mm:

(WebCore::createColor): Make a custom CGColor factory since we can't use CGColorCreateGenericRGB on iOS.
(WebCore::MemoryCategoryInfo::MemoryCategoryInfo):
(WebCore::ResourceUsageOverlay::platformInitialize): Put the overlay CALayer into a container layer and
hook it up with GraphicsLayer::setContentsToPlatformLayer so it works with all compositing modes.
(WebCore::showText): Move CGContextSaveGState call to the top of the function to preserve everything.
(WebCore::drawGraphLabel):
(WebCore::drawCpuHistory):
(WebCore::drawGCHistory):
(WebCore::ResourceUsageOverlay::platformDraw): Flip the CGContext if needed.
(WebCore::runSamplerThread): Update the layer rects on each thread iteration. This shouldn't be
necessary but it papers over an issue where the containing layer would shrink down to 0x0 and
disappear. Added a FIXME for this.

• platform/spi/cocoa/MachVMSPI.h: Add purgeable VM SPI.

Source/WTF:

• wtf/Platform.h: Enable RESOURCE_USAGE_OVERLAY for all COCOA platforms.

3:07 PM Changeset in webkit [193872] by Matt Baker

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: when a marked-dirty subview is attached to a parent View, dirtyDescendantsCount gets out of sync
​https://bugs.webkit.org/show_bug.cgi?id=151876

Reviewed by Brian Burg.

• UserInterface/Base/Main.js:

Use root view singleton instead of creating it explicitly.

• UserInterface/Views/View.js:

(WebInspector.View):
(WebInspector.View.rootView):
Singleton root view access. Lazily create and return a view backed
by the document's body element.
(WebInspector.View.prototype.isDescendantOf):
(WebInspector.View.prototype.insertSubviewBefore):
(WebInspector.View.prototype.removeSubview):
(WebInspector.View.prototype.didMoveToWindow):
Notify the view when it becomes, or is no longer, descended from the root view.
(WebInspector.View.prototype.didMoveToParent):
Notify the view when it's added to, or removed from, a parent view.
(WebInspector.View._scheduleLayoutForView):
(WebInspector.View._cancelScheduledLayoutForView):
(WebInspector.View.prototype.makeRootView): Deleted.
No longer needed.
(WebInspector.View.prototype.didAttach): Deleted.
(WebInspector.View.prototype.didDetach): Deleted.
Replaced by didMoveToParent.

2:46 PM Changeset in webkit [193871] by beidson@apple.com

• 4 edits in trunk

Modern IDB: storage/indexeddb/database-closepending-flag.html fails.
​https://bugs.webkit.org/show_bug.cgi?id=152095

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (At least one failing test now passes).

The server-side checks the closepending flag before dispatching the event to the client,
but due to the inherent asynchronous race between server and client, the client needs to
check its closePending flag as well.

• Modules/indexeddb/client/IDBDatabaseImpl.cpp:

(WebCore::IDBClient::IDBDatabase::fireVersionChangeEvent): Don't fire if m_closePending is set.

LayoutTests:

• platform/mac-wk1/TestExpectations:

2:45 PM Changeset in webkit [193870] by BJ Burg

• 4 edits
  1 move
  2 adds in trunk/Source/WebInspectorUI

Web Inspector: control whether to collect and dump protocol messages using a WebInspector.Setting
​https://bugs.webkit.org/show_bug.cgi?id=151635

Reviewed by Timothy Hatcher.

When closing and reopening the inspector, the setting for whether
to dump protocol messages should be persisted. Otherwise, enabling
dumping from the debug-only UI will miss the initial flood of
messages that are processed when the Inspector loads initial data.

To support a persistent setting, and build some infrastructure for
more advanced uses of collected protocol messages, this patch adds
a new object to trace protocol events. It gets callbacks for each
and implements the console-dumping functionality previously baked in
to InspectorBackend.

In follow-up patches, other protocol tracers will be added to save
protocol data to disk, marshall it to a higher inspection level,
or provide more fine-grained control over what is logged.

This change moves Setting.js into the Base/ directory,
since it is used by Views, Models, and now Protocol classes.

• UserInterface/Base/Setting.js: Renamed from Source/WebInspectorUI/UserInterface/Models/Setting.js.

(WebInspector.Setting):
(WebInspector.Setting.prototype.get name):
(WebInspector.Setting.prototype.get value):
(WebInspector.Setting.prototype.set value):

• UserInterface/Main.html:
• UserInterface/Protocol/InspectorBackend.js:

(InspectorBackendClass):
(InspectorBackendClass.prototype.set dumpInspectorProtocolMessages):
(InspectorBackendClass.prototype.get dumpInspectorProtocolMessages):

We still want to support the legacy way to enable dumping:
InspectorBackend.dumpInspectorProtocolMessages = true. This
is because some tests always use it, and it's easier to set this
flag in a custom Bootstrap.js file than to configure the Setting.

(InspectorBackendClass.prototype.set dumpInspectorTimeStats):
(InspectorBackendClass.prototype.get dumpInspectorTimeStats):

We still want to support the legacy way to enable dumping:
InspectorBackend.dumpInspectorTimeStats = true. This is
because MessageDispatcher checks this flag for its logging.

(InspectorBackendClass.prototype.set activeTracer):
(InspectorBackendClass.prototype.get activeTracer):

Set the active tracer, finalizing and removing any active tracer
if one exists. If removing a custom tracer (setting to null), then
re-sync activeTracer with the automatic tracing Setting.

(InspectorBackendClass.prototype.dispatch):
(InspectorBackendClass.prototype._startOrStopAutomaticTracing):

Sync the Setting with activeTracer. If an custom tracer is active,
don't replace it with the automatic logging tracer.

(InspectorBackendClass.prototype._sendCommandToBackendWithCallback):
(InspectorBackendClass.prototype._sendCommandToBackendExpectingPromise):
(InspectorBackendClass.prototype._sendMessageToBackend):
(InspectorBackendClass.prototype._dispatchResponse):
(InspectorBackendClass.prototype._dispatchEvent):
(InspectorBackendClass.prototype._flushPendingScripts):

• UserInterface/Protocol/LoggingProtocolTracer.js: Added.

(WebInspector.LoggingProtocolTracer):
(WebInspector.LoggingProtocolTracer.prototype.set dumpMessagesToConsole):
(WebInspector.LoggingProtocolTracer.prototype.get dumpMessagesToConsole):
(WebInspector.LoggingProtocolTracer.prototype.set dumpTimingDataToConsole):
(WebInspector.LoggingProtocolTracer.prototype.get dumpTimingDataToConsole):
(WebInspector.LoggingProtocolTracer.prototype.logFrontendException):
(WebInspector.LoggingProtocolTracer.prototype.logProtocolError):
(WebInspector.LoggingProtocolTracer.prototype.logFrontendRequest):
(WebInspector.LoggingProtocolTracer.prototype.logWillHandleResponse):
(WebInspector.LoggingProtocolTracer.prototype.logDidHandleResponse):
(WebInspector.LoggingProtocolTracer.prototype.logWillHandleEvent):
(WebInspector.LoggingProtocolTracer.prototype.logDidHandleEvent):
(WebInspector.LoggingProtocolTracer.prototype._processEntry):

• UserInterface/Protocol/ProtocolTracer.js: Added.

(WebInspector.ProtocolTracer.prototype.logStarted):
(WebInspector.ProtocolTracer.prototype.logFrontendException):
(WebInspector.ProtocolTracer.prototype.logProtocolError):
(WebInspector.ProtocolTracer.prototype.logFrontendRequest):
(WebInspector.ProtocolTracer.prototype.logWillHandleResponse):
(WebInspector.ProtocolTracer.prototype.logDidHandleResponse):
(WebInspector.ProtocolTracer.prototype.logWillHandleEvent):
(WebInspector.ProtocolTracer.prototype.logDidHandleEvent): (WebInspector.ProtocolTracer.prototype.logFinished):
(WebInspector.ProtocolTracer):

• UserInterface/Test.html:

2:39 PM Changeset in webkit [193869] by matthew_hanson@apple.com

• 4 edits
  3 adds in branches/safari-601.1.46-branch

Merge r192639. rdar://problem/23814338

2:39 PM Changeset in webkit [193868] by matthew_hanson@apple.com

• 3 edits
  3 adds in branches/safari-601.1.46-branch

Merge r192388. rdar://problem/23814336

2:36 PM Changeset in webkit [193867] by beidson@apple.com

• 6 edits in trunk/LayoutTests

Modern IDB: Some tests expect UInt8Array to be a valid key.
​https://bugs.webkit.org/show_bug.cgi?id=152092

Reviewed by Alex Christensen.

Everything that expected UInt8Array to be a valid key needs to be updated to expect it to be invalid.

• platform/mac-wk1/TestExpectations:
• storage/indexeddb/factory-cmp-expected.txt:
• storage/indexeddb/key-type-binary-expected.txt:
• storage/indexeddb/resources/factory-cmp.js:
• storage/indexeddb/resources/key-type-binary.js:

2:32 PM Changeset in webkit [193866] by bshafiei@apple.com

• 1 copy in tags/Safari-601.1.46.60.1

New tag.

2:22 PM Changeset in webkit [193865] by beidson@apple.com

• 4 edits in trunk/LayoutTests

Modern IDB: storage/indexeddb/createIndex-after-failure.html fails.
​https://bugs.webkit.org/show_bug.cgi?id=152078

Reviewed by Alex Christensen.

• platform/mac-wk1/TestExpectations:
• storage/indexeddb/createIndex-after-failure-expected.txt:
• storage/indexeddb/resources/createIndex-after-failure.js:

2:11 PM Changeset in webkit [193864] by BJ Burg

• 2 edits in trunk/Source/WebKit2

Web Inspector: reproducible debug ASSERT when inspecting the inspector (WK2)
​https://bugs.webkit.org/show_bug.cgi?id=152080

Reviewed by Timothy Hatcher.

We hit an assert underneath ChildProcessProxy::addMessageReceiver because
we tried to connect the inspector page and inspected page more than once.
This relationship is already set up in the constructor of WebProcessProxy.

• UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::eagerlyCreateInspectorPage):

2:11 PM Changeset in webkit [193863] by bshafiei@apple.com

• 5 edits in branches/safari-601.1.46-branch/Source

Versioning.

2:07 PM Changeset in webkit [193862] by bshafiei@apple.com

• 1 copy in tags/Safari-601.1.46.85

New tag.

2:06 PM Changeset in webkit [193861] by Ryan Haddad

• 1 edit
  1 add in trunk/LayoutTests

Baseline fast/dom/HTMLProgressElement/native-progress-bar.html for iOS
​https://bugs.webkit.org/show_bug.cgi?id=152094

Unreviewed test gardening.

• platform/ios-simulator/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt: Added.

1:48 PM Changeset in webkit [193860] by Ryan Haddad

• 1 edit
  1 add in trunk/LayoutTests

Baseline fast/text/text-combine-shrink-on-color-change.html for iOS
​https://bugs.webkit.org/show_bug.cgi?id=151218

Unreviewed test gardening.

• platform/ios-simulator/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

1:42 PM Changeset in webkit [193859] by hyatt@apple.com

• 12 edits
  3 adds in trunk

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

Picture element needs to respond to dynamic viewport changes.
​https://bugs.webkit.org/show_bug.cgi?id=152013
<rdar://problem/23766375>

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/picture.

• css/MediaQueryEvaluator.cpp:

(WebCore::MediaQueryEvaluator::evalCheckingViewportDependentResults):
Add new evaluation method that adds viewport dependent results to a vector. A follow-up patch
will refactor the style resolver code to use this function instead of the special style resolver one, in order to
get rid of the code duplication. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152089.

• css/MediaQueryEvaluator.h:

(WebCore::MediaQueryResult::MediaQueryResult):

• css/StyleResolver.h:

(WebCore::MediaQueryResult::MediaQueryResult): Deleted.
Move MediaQueryResult into a header since it is used in multiple places now and not just by the style
resolver.

• dom/Document.cpp:

(WebCore::Document::evaluateMediaQueryList):
(WebCore::Document::checkViewportDependentPictures):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::applyContentDispositionAttachmentSandbox):
(WebCore::Document::addViewportDependentPicture):
(WebCore::Document::removeViewportDependentPicture):

• dom/Document.h:

The document now maintains a HashSet of viewport-dependent pictures, and it checks them whenever the
viewport changes. If their media queries stay the same, then nothing happens. If they change, then
the <picture> will go back and re-check all its <source> elements to see what the new best candidate is.

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
Revised to check for viewport dependencies and to cache viewport-dependent results on the <picture> elements.
When a <picture> is found to be viewport-dependent (or not) it is also added to or removed from the document's
set of tracked pictures.

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::HTMLPictureElement):
(WebCore::HTMLPictureElement::~HTMLPictureElement):
(WebCore::HTMLPictureElement::didMoveToNewDocument):
(WebCore::HTMLPictureElement::create):
(WebCore::HTMLPictureElement::sourcesChanged):
(WebCore::HTMLPictureElement::viewportChangeAffectedPicture):

• html/HTMLPictureElement.h:

New caching of results and updating of the document HashSet when the picture gets destroyed or moves to
a different document.

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::parseAttribute):

• html/HTMLSourceElement.h:

Cache the media attribute in a parsed form. A follow-up patch will improve the <video>/<audio>
code to make use of this parsed result. Tracked by ​https://bugs.webkit.org/show_bug.cgi?id=152090.

LayoutTests:

• fast/picture/resources/resize-test.js: Added.
• fast/picture/viewport-resize-expected.txt: Added.
• fast/picture/viewport-resize.html: Added.

1:34 PM Changeset in webkit [193858] by BJ Burg

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: zoom with Ctrl +/- doesn't work correctly when inspector is docked
​https://bugs.webkit.org/show_bug.cgi?id=152076

Reviewed by Timothy Hatcher.

When computing the new width or height of the inspector, take the zoom level into
account. window.inner{Width,Height} are in document pixels, but we need to specify
device pixels to InspectorFrontendHost.

• UserInterface/Base/Main.js:

1:22 PM Changeset in webkit [193857] by Alan Bujtas

• 4 edits in trunk/Source/WebCore

TextPainter: Rename start and end position to selectionStart and selectionEnd.
​https://bugs.webkit.org/show_bug.cgi?id=152088

Reviewed by Myles C. Maxfield.

They actually mean selection start/end.

No change in functionality.

• rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):

• rendering/TextPainter.cpp:

(WebCore::TextPainter::TextPainter):
(WebCore::TextPainter::paintText):

• rendering/TextPainter.h:

1:14 PM Changeset in webkit [193856] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Run atleast one simulator even if max process limit is low
​https://bugs.webkit.org/show_bug.cgi?id=152081
<rdar://problem/23819694>

Patch by Aakash Jain <​aakash_jain@apple.com> on 2015-12-09
Reviewed by Alexey Proskuryakov.

1:07 PM Changeset in webkit [193855] by mark.lam@apple.com

• 1 edit
  9 moves in trunk/LayoutTests

Rename ftl-object-* tests to ftl-polymorphic-*.
​https://bugs.webkit.org/show_bug.cgi?id=152091

Reviewed by Saam Barati.

This is because those tests are actually testing the effects of polymorphic
operands on performance, and not the correctness of operations on objects.

• js/regress/ftl-object-div-expected.txt: Removed.
• js/regress/ftl-object-div.html: Removed.
• js/regress/ftl-object-mul-expected.txt: Removed.
• js/regress/ftl-object-mul.html: Removed.
• js/regress/ftl-object-sub-expected.txt: Removed.
• js/regress/ftl-object-sub.html: Removed.
• js/regress/ftl-polymorphic-div-expected.txt: Copied from LayoutTests/js/regress/ftl-object-div-expected.txt.
• js/regress/ftl-polymorphic-div.html: Copied from LayoutTests/js/regress/ftl-object-div.html.
• js/regress/ftl-polymorphic-mul-expected.txt: Copied from LayoutTests/js/regress/ftl-object-mul-expected.txt.
• js/regress/ftl-polymorphic-mul.html: Copied from LayoutTests/js/regress/ftl-object-mul.html.
• js/regress/ftl-polymorphic-sub-expected.txt: Copied from LayoutTests/js/regress/ftl-object-sub-expected.txt.
• js/regress/ftl-polymorphic-sub.html: Copied from LayoutTests/js/regress/ftl-object-sub.html.
• js/regress/script-tests/ftl-object-div.js: Removed.
• js/regress/script-tests/ftl-object-mul.js: Removed.
• js/regress/script-tests/ftl-object-sub.js: Removed.
• js/regress/script-tests/ftl-polymorphic-div.js: Copied from LayoutTests/js/regress/script-tests/ftl-object-div.js.
• js/regress/script-tests/ftl-polymorphic-mul.js: Copied from LayoutTests/js/regress/script-tests/ftl-object-mul.js.
• js/regress/script-tests/ftl-polymorphic-sub.js: Copied from LayoutTests/js/regress/script-tests/ftl-object-sub.js.

12:22 PM Changeset in webkit [193854] by sbarati@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Update generators' features.json to indicate that we have a spec compliant implementation
​https://bugs.webkit.org/show_bug.cgi?id=152085

Reviewed by Joseph Pecoraro.

• features.json:

12:14 PM WebKitGTK/Gardening/Calendar edited by clopez@igalia.com

(diff)

12:12 PM Changeset in webkit [193853] by clopez@igalia.com

• 10 edits in trunk/LayoutTests

[GTK] Unreviewed GTK Gardening.

Rebaseline media tests after r190054 and r190200.

• platform/gtk/media/audio-controls-rendering-expected.txt:
• platform/gtk/media/controls-strict-expected.txt:
• platform/gtk/media/media-controls-clone-expected.txt:
• platform/gtk/media/video-controls-rendering-expected.txt:
• platform/gtk/media/video-display-toggle-expected.txt:
• platform/gtk/media/video-empty-source-expected.txt:
• platform/gtk/media/video-no-audio-expected.txt:
• platform/gtk/media/video-volume-slider-expected.txt:
• platform/gtk/media/video-zoom-controls-expected.txt:

11:58 AM Changeset in webkit [193852] by bshafiei@apple.com

• 2 edits in tags/Safari-602.1.13.2/Source/WebKit/mac

Merged r193676. rdar://problem/23639610

11:58 AM Changeset in webkit [193851] by sbarati@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Update features.json w.r.t tail calls
​https://bugs.webkit.org/show_bug.cgi?id=152072

Reviewed by Michael Saboff.

• features.json:

11:57 AM Changeset in webkit [193850] by bshafiei@apple.com

• 2 edits in tags/Safari-602.1.13.2/Source/WebKit/mac

Merged r193675. rdar://problem/23639610

11:55 AM Changeset in webkit [193849] by bshafiei@apple.com

• 5 edits in tags/Safari-602.1.13.2/Source/WebKit/mac

Merged r193661. rdar://problem/23639610

11:48 AM Changeset in webkit [193848] by bshafiei@apple.com

• 10 edits
  1 copy in tags/Safari-602.1.13.2/Source

Merged r193645. rdar://problem/23751214

11:20 AM Changeset in webkit [193847] by Gyuyoung Kim

• 2 edits in trunk/Source/WebKit2

[EFL] Need to change expectation result in ewk_settings_offline_web_application_cache_enabled API test
​https://bugs.webkit.org/show_bug.cgi?id=152063

Reviewed by Csaba Osztrogonác.

Expect false initial value of ewk_settings_offline_web_application_cache_enabled_get()
because r193812 didn't enable it by default.

• UIProcess/API/efl/tests/test_ewk2_settings.cpp:

(TEST_F):

10:58 AM Changeset in webkit [193846] by bshafiei@apple.com

• 28 edits in branches/safari-601.1.46-branch

Merged r190505. rdar://problem/23822557

10:53 AM Changeset in webkit [193845] by bshafiei@apple.com

• 28 edits in branches/safari-601-branch

Merged r190505. rdar://problem/23822539

10:52 AM Changeset in webkit [193844] by yoon@igalia.com

• 4 edits in trunk/Source/WebKit2

[ThreadedCompositor] Add support for HiDPI
​https://bugs.webkit.org/show_bug.cgi?id=152071

Reviewed by Carlos Garcia Campos.

• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::ThreadedCompositor::setDeviceScaleFactor): Added to receive the
device scale factor from the layer tree host.
(WebKit::ThreadedCompositor::renderLayerTree):
Apply device scale factor before rendering the page.

• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
• WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:

(WebKit::ThreadedCoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged):
Send a updated device scale factor to the compositing thread.

10:32 AM Changeset in webkit [193843] by ryuan.choi@navercorp.com

• 5 edits in trunk/Source/WebKit2

[CoordinatedGraphics] Remove unnecessary guards in CoordinatedDrawingArea
​https://bugs.webkit.org/show_bug.cgi?id=152068

Reviewed by Gyuyoung Kim.

CoordinatedDrawingArea is only for UI side compositor of CoordinatedGraphics.
So, COORDINATED_GRAPHICS_MULTIPROCESS guards are not necessary.
This patch also removes COORDINATED_GRAPHICS_MULTIPROCESS guards from DrawingAreaImpl
because of same reason.

• UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:

(WebKit::CoordinatedDrawingAreaProxy::CoordinatedDrawingAreaProxy): Deleted.

• WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:

(WebKit::CoordinatedDrawingArea::CoordinatedDrawingArea): Deleted.

• WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:
• WebProcess/WebPage/DrawingAreaImpl.h:

10:31 AM Changeset in webkit [193842] by sbarati@apple.com

• 4 edits in trunk/Source/JavaScriptCore

we should emit op_watchdog after op_enter
​https://bugs.webkit.org/show_bug.cgi?id=151972

Reviewed by Mark Lam.

This also solves the issue of watchdog not being
observed when we loop purely through tail calls.

• API/tests/ExecutionTimeLimitTest.cpp:

(testExecutionTimeLimit):

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitProfiledOpcode):
(JSC::BytecodeGenerator::emitEnter):
(JSC::BytecodeGenerator::emitLoopHint):

• bytecompiler/BytecodeGenerator.h:

10:24 AM Changeset in webkit [193841] by jdiggs@igalia.com

• 7 edits
  4 adds in trunk

AX: [GTK] Anonymous render block flow elements should be exposed as ATK_ROLE_SECTION; not ATK_ROLE_PANEL
​https://bugs.webkit.org/show_bug.cgi?id=152070

Reviewed by Mario Sanchez Prada.

Source/WebCore:

Map the element to WebCore AccessibilityRole DivRole for GTK. This is being
done in the shared layer rather than in the platform layer because we want all
subsequent logic to treat anonymous render block flow elements as divs.

No new tests. We already have sufficient test coverage. The expectations
been updated accordingly.

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

LayoutTests:

• platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt: Added.
• platform/gtk/accessibility/gtk/media-controls-panel-title-expected.txt: Added.
• platform/gtk/accessibility/gtk/replaced-objects-in-anonymous-blocks-expected.txt: Added.
• platform/gtk/accessibility/image-link-expected.txt: Updated
• platform/gtk/accessibility/image-with-alt-and-map-expected.txt: Updated.
• platform/gtk/accessibility/lists-expected.txt: Updated.
• platform/gtk/accessibility/media-emits-object-replacement-expected.txt: Updated.

10:19 AM Changeset in webkit [193840] by commit-queue@webkit.org

• 9 edits in trunk

form.elements should reflect the element ordering after the HTML tree builder algorithm
​https://bugs.webkit.org/show_bug.cgi?id=148870
rdar://problem/22589879

Patch by Keith Rollin <Keith Rollin> on 2015-12-09
Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline existing test.

• web-platform-tests/html/semantics/forms/the-form-element/form-elements-nameditem-02-expected.txt:

Source/WebCore:

form.elements should return form-associated elements in tree order.
However, when presented with an HTML fragment like the following,
forms.elements is not built in tree order. Instead, the elements
appear in forms.element in the same order they appear in the HTML --
that is in the same order as they are parsed.

<form id=form>

<table>

<tr>

<td><input type="radio" name="radio1" id="r1" value=1></td>
<td><input type="radio" name="radio2" id="r2" value=2></td>
<input type="radio" name="radio0" id="r0" value=0>

</tr>

</table>

</form>

The reason why elements appear in forms.elements in parse order is
because they register themselves with the designated form when they
are created. At this time, they are not in the DOM tree, so the form
can only assume that the element will be appended to the DOM tree,
with the result that it records the elements in the HTML fragment
above as [r1, r2, r0].

However, it's not always the case that the newly-created element will
be appended to the current tree. In the HTML fragment above, the r0
input element is hoised out of the table element. It ends up being the
preceding sibling of the table element, with the result that the
actual tree-order of the input elements is [r0, r1, r2].

Because the problem is due to registering form-associated elements
with the form *before* the elements are added to the DOM tree, the
solution is to defer that registration until afterwards. With the new
element in the tree, the form can now use its current location in the
tree to correctly place the element in form.elements.

Existing tests now pass:

• imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-elements-nameditem-02-html

• html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::FormAssociatedElement):
(WebCore::FormAssociatedElement::insertedInto):
(WebCore::FormAssociatedElement::removedFrom):
(WebCore::FormAssociatedElement::formRemovedFromTree):
(WebCore::FormAssociatedElement::formWillBeDestroyed):

• html/FormAssociatedElement.h:
• html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::HTMLFormControlElement):

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::HTMLImageElement):
(WebCore::HTMLImageElement::insertedInto):
(WebCore::HTMLImageElement::removedFrom):

• html/HTMLImageElement.h:
• html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::HTMLObjectElement):

10:11 AM Changeset in webkit [193839] by bshafiei@apple.com

• 4 edits
  6 deletes in branches/safari-601.1.46.60-branch

Roll out r192369. rdar://problem/23787037

9:48 AM Changeset in webkit [193838] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Replacing Yosemite flag with Release flag for two flaky xmlhttprequest tests.
​https://bugs.webkit.org/show_bug.cgi?id=151729

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

9:47 AM WebKitGTK/Gardening/Calendar edited by Carlos Garcia Campos

(diff)

9:44 AM Changeset in webkit [193837] by bshafiei@apple.com

• 4 edits
  6 deletes in branches/safari-601.4-branch

Roll out r192369. rdar://problem/23787108

9:37 AM Changeset in webkit [193836] by yoon@igalia.com

• 5 edits in trunk/Source/WebCore

[ThreadedCompositor] Support HTML5 Video
​https://bugs.webkit.org/show_bug.cgi?id=143301

Reviewed by Žan Doberšek.

This patch implements HTML5 Video supports in Threaded Compositor.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::GstVideoFrameHolder::GstVideoFrameHolder):
Added to support GStreamer GL by ensuring unmapping of the swapped
GstVideoFrame performed at GStreamer GL's gl thread.
(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture):
Modified to upload decoded frame to the given texture instead of
creating a texture itself because we should use a texture from the
proxy when we are using the threaded compositor.
(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):
Implements two ways to send a texture from GStreamer to the compositor.

1. If we are not using GStreamer GL, we are going to acquire a free texture

from a TextureMapperPlatformLayerProxy and upload the decoded frame to the
texture. This should be done at the compositing thread because we
don't have a Gst's GL thread.

2. If we are using GStreamer GL, we map a texture for the given frame

and passes it to the compositing thread. The mapped frame will be
freed if it is swapped out or the layer is removed.

(WebCore::MediaPlayerPrivateGStreamerBase::paintToTextureMapper):
Modified to aquire a new texture itself.

• platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp:

Adds a way to pass a function to the compositing thread to allocate /
upload textures at the compositing thread.

9:34 AM Changeset in webkit [193835] by Jon Davis

• 4 edits in trunk/Websites/webkit.org

Fixed broken link: ​https://webkit.org/old/security/security-group-members.html
​https://bugs.webkit.org/show_bug.cgi?id=152010

Reviewed by Timothy Hatcher.

• .htaccess:
• security-policy.md:
• wp-content/themes/webkit/style.css:

(article h4):
(article h5):

8:54 AM Changeset in webkit [193834] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Marking inspector/debugger/command-line-api-exception.html as flaky on Mac
​https://bugs.webkit.org/show_bug.cgi?id=152029

Unreviewed test gardening.

• platform/mac/TestExpectations:

7:41 AM Changeset in webkit [193833] by Jon Davis

• 2 edits in trunk/Websites/webkit.org

Fixed function call reference.

• wp-content/themes/webkit/scripts/global.js:

7:34 AM Changeset in webkit [193832] by calvaris@igalia.com

• 4 edits in trunk

[Streams API] pipeThrough test failing
​https://bugs.webkit.org/show_bug.cgi?id=152061

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

• web-platform-tests/streams-api/readable-streams/pipe-through-expected.txt: Expectations.

Source/WebCore:

Test: imported/w3c/web-platform-tests/streams-api/readable-streams/pipe-through.html

• Modules/streams/ReadableStream.js:

(pipeThrough): Mimic destructuring for the streams parameter.

7:01 AM Changeset in webkit [193831] by jdiggs@igalia.com

• 1 edit
  1 move
  1 delete in trunk/LayoutTests

AX: [GTK] Remove duplicate/platform media-emits-object-replacement.html and move expectations where they belong
​https://bugs.webkit.org/show_bug.cgi?id=152064

Unreviewed test gardening.

• accessibility/gtk/media-emits-object-replacement.html: Removed.
• platform/gtk/accessibility/media-emits-object-replacement-expected.txt: Renamed from LayoutTests/accessibility/gtk/media-emits-object-replacement-expected.txt.

6:52 AM Changeset in webkit [193830] by mario@webkit.org

• 9 edits in trunk

[GTK] Crash in WebProcess when loading large content with custom URI schemes
​https://bugs.webkit.org/show_bug.cgi?id=144262

Reviewed by Carlos Garcia Campos.

Source/WebKit2:

Properly handle scenarios where errors happen after reading the first
chunk of data coming from the GInputStream provided by the application.

• UIProcess/API/gtk/WebKitWebContextPrivate.h:
• UIProcess/API/gtk/WebKitWebContext.cpp:

(webkitWebContextIsLoadingCustomProtocol): New, checks whether a load
is still in progress, after the startLoading method has been called.

• UIProcess/API/gtk/WebKitURISchemeRequest.cpp:

(webkitURISchemeRequestReadCallback): Early return if the stream has been
cancelled on finish_error, so that we make sure we don't keep on reading
the GInputStream after that point.
(webkit_uri_scheme_request_finish_error): Don't send a didFailWithError
message to the Network process if the load is not longer in progress.

• Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.cpp:

(WebKit::CustomProtocolManagerImpl::didFailWithError): Handle the case where
an error is notified from the UI process after the first chunk has been read.
(WebKit::CustomProtocolManagerImpl::didReceiveResponse): Handle the case where
data might no longer be available if an error happened even before this point.

• WebProcess/soup/WebKitSoupRequestInputStream.h:
• WebProcess/soup/WebKitSoupRequestInputStream.cpp:

(webkitSoupRequestInputStreamDidFailWithError): Notify the custom GInputStream
that we no longer want to keep reading data in chunks due to a specific error.
(webkitSoupRequestInputStreamReadAsync): Early finish the GTask with a specific
error whenever webkitSoupRequestInputStreamDidFailWithError() has been called.

Tools:

Added new unit test to check the additional scenarios we now
handle for custom URI schemes.

• TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:

(generateHTMLContent): New helper function to generate big enough content.
(testWebContextURIScheme): New unit test.

6:46 AM Changeset in webkit [193829] by fred.wang@free.fr

• 4 edits
  2 adds in trunk

Bad position of large operators inside an munderover element
​https://bugs.webkit.org/show_bug.cgi?id=151916

Reviewed by Alejandro G. Castro.

Source/WebCore:

Test: mathml/opentype/large-operators-munderover.html

• rendering/mathml/RenderMathMLOperator.h:

(WebCore::RenderMathMLOperator::isVertical): Expose the direction of the operator.

• rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::layout): Remove call to horizontal stretching for vertical operators.

LayoutTests:

• mathml/opentype/large-operators-munderover-expected.txt: Added.
• mathml/opentype/large-operators-munderover.html: Added.

Add a test to verify the position and size of a large operator used as an munderover base.

6:03 AM Changeset in webkit [193828] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

[TexMap] TextureMapperTiledBackingStore should notify the ImageObserver of the data access
​https://bugs.webkit.org/show_bug.cgi?id=152053

Reviewed by Martin Robinson.

TextureMapperTiledBackingStore should call ImageObserver::didDraw() on the Image's
observer after updating the tile with the Image's data. This way the CachedImage
(i.e. the observer) can mark the data access with the current timestamp, avoiding
removing the decoded data in the very near future during a cache purge.

• platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:

(WebCore::TextureMapperTiledBackingStore::updateContentsFromImageIfNeeded):

6:00 AM Changeset in webkit [193827] by ryuan.choi@navercorp.com

• 8 edits in trunk

Source/WebKit2:
[CoordinatedGraphics][EFL] Fix unhandled web process message when launching MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=152048

Reviewed by Gyuyoung Kim.

WebPage should be initialized before updating preferences.

• UIProcess/API/C/CoordinatedGraphics/WKView.cpp:

(WKViewInitialize): Deleted.

• UIProcess/API/C/CoordinatedGraphics/WKView.h:
• UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
Calls WKViewSetIsActive instead of WKViewInitialize not to change the behavior
of EFL port.

• UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::WebView):
Initialize just before creating WebPage because there is not use case to separate
initializing WebPage from creating in CoordinatedGraphics.
(WebKit::WebView::initialize): Deleted.

• UIProcess/CoordinatedGraphics/WebView.h:

Tools:
[EFL] Fix unhandled web process message when launching MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=152048

Reviewed by Gyuyoung Kim.

• TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:

(TestWebKitAPI::TEST):

5:32 AM Changeset in webkit [193826] by Carlos Garcia Campos

• 11 edits in trunk

[GTK] Add API to handle beforeunload events
​https://bugs.webkit.org/show_bug.cgi?id=139090

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

beforeunload is fired when a page is about to be closed, to ask
the user for confirmation. This happens when reloading a page,
when navigating to another page or when the page is closed by a
user action (a tab or window closed). In the first two cases, the
event is automatically fired by WebCore, but in the case of a user
action we need additional API to ensure the event is fired before
the page is closed. A new script dialog type has been added to
handle beforeunload events and webkit_web_view_try_close() to
allow applications to try to close the page.

• UIProcess/API/gtk/WebKitScriptDialog.cpp:

(webkit_script_dialog_confirm_set_confirmed): BeforeUnloadConfirm
dialogs can also be confirmed.

• UIProcess/API/gtk/WebKitScriptDialog.h: Add

WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM script dialog type.

• UIProcess/API/gtk/WebKitUIClient.cpp: Implement

canRunBeforeUnloadConfirmPanel() and runBeforeUnloadConfirmPanel().

• UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewCreateJavaScriptDialog): Add secondaryText optional
parameter for BeforeUnloadConfirm dialogs. Do not set the default
response if the dialog was created without buttons.
(webkitWebViewScriptDialog): Handle
WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM script dialog type to
create a message dialog for beforeunlos events.
(webkit_web_view_class_init): Update documentation of
WebKitWebView::close and WebKitWebView::script-dialog.
(webkitWebViewRunJavaScriptBeforeUnloadConfirm): Emit WebKitWebView::script-dialog.
(webkit_web_view_try_close): Try to close the page.

• UIProcess/API/gtk/WebKitWebView.h:
• UIProcess/API/gtk/WebKitWebViewPrivate.h:
• UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.

Tools:

• MiniBrowser/gtk/BrowserWindow.c:

(browserWindowConstructed):
(browserWindowDeleteEvent):
(browser_window_class_init):
Handle delete-event to prevent the window from being closed when
the page has beforeunload handlers. Use
webkit_web_view_try_close() when the window is requested to be
closed.

• TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:

(testWebViewJavaScriptDialogs):
Add a test case for the WEBKIT_SCRIPT_DIALOG_BEFORE_UNLOAD_CONFIRM
script dialog type.

5:30 AM Changeset in webkit [193825] by jdiggs@igalia.com

• 2 edits in trunk/LayoutTests

[AX][GTK] Accessibility gardening
​https://bugs.webkit.org/show_bug.cgi?id=152062

Unreviewed test gardening.

Skip two tests specific to AX API, mark a test which is timing out, remove passing
test from failures.

• platform/gtk/TestExpectations:

5:09 AM Changeset in webkit [193824] by calvaris@igalia.com

• 12 edits
  54 adds
  5 deletes in trunk/LayoutTests

[Streams API] Import the web-platform-tests directly from the spec
​https://bugs.webkit.org/show_bug.cgi?id=152051

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

These are the web platform tests imported directly (or almost) from the Streams API repository. Tests work out
of the box (all but a small flakiness that we are forcing as failure to not disrupt the execution of the rest of
tests).

To make them work we are importing also the service worker test helpers that is used by the tests.

• web-platform-tests/service-workers/service-workers/resources/README.txt: Added.
• web-platform-tests/service-workers/service-workers/resources/test-helpers.js: Added. Imported from the web-platform-tests.
• web-platform-tests/streams-api/README.txt: Added.
• web-platform-tests/streams-api/byte-length-queuing-strategy-expected.txt: Added.
• web-platform-tests/streams-api/byte-length-queuing-strategy.html: Added.
• web-platform-tests/streams-api/byte-length-queuing-strategy.js: Added.
• web-platform-tests/streams-api/count-queuing-strategy-expected.txt: Added.
• web-platform-tests/streams-api/count-queuing-strategy.html: Added.
• web-platform-tests/streams-api/count-queuing-strategy.js: Added.
• web-platform-tests/streams-api/readable-streams/bad-strategies-expected.txt: Added.
• web-platform-tests/streams-api/readable-streams/bad-strategies.html: Added.
• web-platform-tests/streams-api/readable-streams/bad-strategies.js: Added.
• web-platform-tests/streams-api/readable-streams/bad-underlying-sources-expected.txt: Added.
• web-platform-tests/streams-api/readable-streams/bad-underlying-sources.html: Added.
• web-platform-tests/streams-api/readable-streams/bad-underlying-sources.js: Added.
• web-platform-tests/streams-api/readable-streams/brand-checks-expected.txt: Added.
• web-platform-tests/streams-api/readable-streams/brand-checks.html: Added.
• web-platform-tests/streams-api/readable-streams/brand-checks.js: Added.
• web-platform-tests/streams-api/readable-streams/cancel-expected.txt: Added.
• web-platform-tests/streams-api/readable-streams/cancel.html: Added. There's a test with a forced failure

because it is flaky.

• web-platform-tests/streams-api/readable-streams/cancel.js: Added.
• web-platform-tests/streams-api/readable-streams/count-queuing-strategy-integration-expected.txt: Added.
• web-platform-tests/streams-api/readable-streams/count-queuing-strategy-integration.html: Added.
• web-platform-tests/streams-api/readable-streams/count-queuing-strategy-integration.js: Added.
• web-platform-tests/streams-api/readable-streams/garbage-collection-expected.txt: Added.
• web-platform-tests/streams-api/readable-streams/garbage-collection.html: Added.
• web-platform-tests/streams-api/readable-streams/garbage-collection.js: Added.
• web-platform-tests/streams-api/readable-streams/general-expected.txt: Added.
• web-platform-tests/streams-api/readable-streams/general.html: Added.
• web-platform-tests/streams-api/readable-streams/general.js: Added.
• web-platform-tests/streams-api/readable-streams/pipe-through-expected.txt: Added.
• web-platform-tests/streams-api/readable-streams/pipe-through.html: Added.
• web-platform-tests/streams-api/readable-streams/pipe-through.js: Added.
• web-platform-tests/streams-api/readable-streams/readable-stream-reader-expected.txt: Added.
• web-platform-tests/streams-api/readable-streams/readable-stream-reader.html: Added.
• web-platform-tests/streams-api/readable-streams/readable-stream-reader.js: Added.
• web-platform-tests/streams-api/readable-streams/tee-expected.txt: Added.
• web-platform-tests/streams-api/readable-streams/tee.html: Added.
• web-platform-tests/streams-api/readable-streams/tee.js: Added.
• web-platform-tests/streams-api/readable-streams/templated-expected.txt: Added.
• web-platform-tests/streams-api/readable-streams/templated.html: Added.
• web-platform-tests/streams-api/readable-streams/templated.js: Added.
• web-platform-tests/streams-api/resources/rs-test-templates.js: Added.
• web-platform-tests/streams-api/resources/rs-utils.js: Added.
• web-platform-tests/streams-api/resources/test-initializer.js: Added.
• web-platform-tests/streams-api/resources/test-utils.js: Added.

LayoutTests:

Removed the tests that are already imported directly from the spec.

• streams/brand-checks-expected.txt: Added.
• streams/brand-checks.html: Added. This includes some tests that vanished from the spec.
• streams/reference-implementation/bad-strategies-expected.txt:
• streams/reference-implementation/bad-strategies.html:
• streams/reference-implementation/bad-underlying-sources.html: Removed.
• streams/reference-implementation/brand-checks-expected.txt:
• streams/reference-implementation/brand-checks.html:
• streams/reference-implementation/byte-length-queuing-strategy-expected.txt:
• streams/reference-implementation/byte-length-queuing-strategy.html:
• streams/reference-implementation/count-queuing-strategy-expected.txt:
• streams/reference-implementation/count-queuing-strategy.html:
• streams/reference-implementation/readable-stream-cancel.html: Removed.
• streams/reference-implementation/readable-stream-reader.html: Removed.
• streams/reference-implementation/readable-stream-tee.html: Removed.
• streams/reference-implementation/readable-stream-templated-expected.txt:
• streams/reference-implementation/readable-stream-templated.html:
• streams/reference-implementation/readable-stream.html: Removed.

4:00 AM Changeset in webkit [193823] by jdiggs@igalia.com

• 2 edits in trunk/LayoutTests

[AX][GTK] combobox-descendants-orientation-crash.html needs new baseline after r190648
​https://bugs.webkit.org/show_bug.cgi?id=152052

Unreviewed test gardening.

• accessibility/gtk/combobox-descendants-orientation-crash-expected.txt:

3:43 AM Changeset in webkit [193822] by Gyuyoung Kim

• 2 edits in trunk/Source/WebKit2

[EFL] Missing to set ignoreTLSError to NetworkProcess
​https://bugs.webkit.org/show_bug.cgi?id=152047

Reviewed by Csaba Osztrogonác.

NetworkProcess has been enabled for all ports since r192796 though, EFL port
didn't send the ignoreTLSError value to NetworkProcess. This has caused failure of EFL API tests
related with ssl feature.

• UIProcess/efl/WebProcessPoolEfl.cpp:

(WebKit::WebProcessPool::setIgnoreTLSErrors):

3:37 AM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro

(diff)

3:33 AM Changeset in webkit [193821] by jdiggs@igalia.com

• 3 edits
  2 copies in trunk/LayoutTests

AX: The aria-table-content.html layout test should be more cross-platform friendly
​https://bugs.webkit.org/show_bug.cgi?id=152002

Reviewed by Mario Sanchez Prada.

Use 'debug' to dump the role instead of 'shouldBe' with a hard-coded role.

• accessibility/aria-table-content-expected.txt: Updated
• accessibility/aria-table-content.html: Updated
• platform/gtk/accessibility/aria-table-content-expected.txt: Added
• platform/efl/accessibility/aria-table-content-expected.txt: Added

3:27 AM Changeset in webkit [193820] by zandobersek@gmail.com

• 2 edits
  1 add
  1 delete in trunk/Source/WebCore

Make MainThreadSharedTimerGtk implementation GLib-specific
​https://bugs.webkit.org/show_bug.cgi?id=152044

Reviewed by Carlos Garcia Campos.

MainThreadSharedTimerGtk has implementation that only directly depends
on GLib, and not GTK+. Because of that it can be moved under
Source/WebCore/platform/glib and slightly renamed.

• PlatformGTK.cmake:
• platform/glib/MainThreadSharedTimerGLib.cpp: Renamed from Source/WebCore/platform/gtk/MainThreadSharedTimerGtk.cpp.

(WebCore::MainThreadSharedTimer::MainThreadSharedTimer):
(WebCore::MainThreadSharedTimer::setFireInterval):
(WebCore::MainThreadSharedTimer::stop):
(WebCore::MainThreadSharedTimer::invalidate):

• platform/gtk/MainThreadSharedTimerGtk.cpp:

(WebCore::MainThreadSharedTimer::MainThreadSharedTimer): Deleted.
(WebCore::MainThreadSharedTimer::setFireInterval): Deleted.
(WebCore::MainThreadSharedTimer::stop): Deleted.
(WebCore::MainThreadSharedTimer::invalidate): Deleted.

3:26 AM Changeset in webkit [193819] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

[TextureMapper] TextureMapperShaderProgram::setMatrix() should use TransformationMatrix::FloatMatrix4
​https://bugs.webkit.org/show_bug.cgi?id=152042

Reviewed by Martin Robinson.

• platform/graphics/texmap/TextureMapperShaderProgram.cpp:

(WebCore::TextureMapperShaderProgram::setMatrix): Instead of manually writing out
the complete matrix in a C array, simply use TransformationMatrix::FloatMatrix4
and fill that via the TransformationMatrix::toColumnMajorFloatArray() method
called on the passed-in TransformationMatrix.

3:22 AM Changeset in webkit [193818] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

[Soup] Attach the SocketStreamHandleSoup write-ready source to the thread-default context
​https://bugs.webkit.org/show_bug.cgi?id=152041

Reviewed by Carlos Garcia Campos.

• platform/network/soup/SocketStreamHandleSoup.cpp:

(WebCore::SocketStreamHandle::beginWaitingForSocketWritability): Attach the
write-ready source to the thread-default context, instead of implicitly
relying on the default context for dispatching.

3:20 AM Changeset in webkit [193817] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

[Soup] SocketStreamHandle should call g_source_destroy() on the write-ready source
​https://bugs.webkit.org/show_bug.cgi?id=152040

Reviewed by Carlos Garcia Campos.

• platform/network/soup/SocketStreamHandleSoup.cpp:

(WebCore::SocketStreamHandle::stopWaitingForSocketWritability): Instead of
calling the g_source_get_id()-g_source_remove() pair, destroy the source via
the g_source_destroy() call. Also use nullptr to clear out the pointer
variable.

3:12 AM Changeset in webkit [193816] by jdiggs@igalia.com

• 2 edits in trunk/LayoutTests

[AX][GTK] media-emits-object-replacement.html needs new baseline
​https://bugs.webkit.org/show_bug.cgi?id=152050

Unreviewed test gardening.

• accessibility/gtk/media-emits-object-replacement-expected.txt:

3:09 AM Changeset in webkit [193815] by mario@webkit.org

• 3 edits in trunk/Tools

Refactored initialization code in LoadTrackingTest.

Rubber-stamped by Carlos Garcia Campos.

Small refactoring to make sure that the state of a LoadTrackingTest
gets properly reset before loading new web content.

• TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
• TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:

(LoadTrackingTest::reset): New, refactored code from *load*() and go*()
functions and reset the remaining local variables.
(LoadTrackingTest::loadURI): Call reset();
(LoadTrackingTest::loadHtml): Ditto.
(LoadTrackingTest::loadPlainText): Ditto.
(LoadTrackingTest::loadBytes): Ditto.
(LoadTrackingTest::loadRequest): Ditto.
(LoadTrackingTest::reload): Ditto.
(LoadTrackingTest::goBack): Ditto.
(LoadTrackingTest::goForward): Ditto.

2:47 AM WebKitGTK/Gardening/Calendar edited by Emanuele Aina

Add me to the gardening schedule (diff)

2:38 AM WebKitGTK/Gardening/Calendar edited by ltilve@igalia.com

(diff)

2:35 AM WebKitGTK/Gardening/Calendar edited by ltilve@igalia.com

(diff)

2:35 AM Changeset in webkit [193814] by zandobersek@gmail.com

• 2 edits
  2 adds
  1 delete in trunk/Source/WebCore

Make AudioBusGtk implementation GLib-specific
​https://bugs.webkit.org/show_bug.cgi?id=152049

Reviewed by Philippe Normand.

AudioBusGtk only depends on GLib, so it should be moved to
Source/WebCore/platform/audio/glib and the implementation file
renamed to AudioBusGLib.cpp.

The hard-coded webkitgtk path component can be addressed later.

• PlatformGTK.cmake: Update the build target.
• platform/audio/glib/AudioBusGLib.cpp: Renamed from Source/WebCore/platform/audio/gtk/AudioBusGtk.cpp.

(WebCore::AudioBus::loadPlatformResource):

• platform/audio/gtk/AudioBusGtk.cpp:

(WebCore::AudioBus::loadPlatformResource): Deleted.

2:30 AM WebKitGTK/Gardening/Calendar edited by tpopela@redhat.com

(diff)

2:19 AM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro

Add myself to schedule (diff)

2:17 AM WebKitGTK/Gardening/Calendar edited by clopez@igalia.com

(diff)

2:09 AM WebKitGTK/Gardening/Calendar edited by clopez@igalia.com

(diff)

2:09 AM Changeset in webkit [193813] by jdiggs@igalia.com

• 7 edits in trunk

AX: [EFL] Consider deferring to WebCore Accessibility for table exposure
​https://bugs.webkit.org/show_bug.cgi?id=144898

Reviewed by Darin Adler.

Source/WebCore:

Stop unconditionally exposing all HTMLTableElement nodes as AccessibilityTables
for WebKitEfl.

No new tests. Several existing tests already cover table exposure. They have
been updated accordingly.

• accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::computeIsTableExposableThroughAccessibility):

LayoutTests:

• platform/efl/accessibility/table-detection-expected.txt: Updated to reflect new behavior.
• platform/efl/accessibility/table-hierarchy-expected.txt: Updated to reflect new behavior.
• platform/efl/accessibility/table-one-cell-expected.txt: Updated to reflect new behavior.
• platform/efl/accessibility/table-with-rules-expected.txt: Updated to reflect new behavior.

2:07 AM WebKitGTK/Gardening/Calendar edited by clopez@igalia.com

(diff)

1:58 AM Changeset in webkit [193812] by Gyuyoung Kim

• 4 edits in trunk

[EFL] REGRESSION(r193616): WKPreferences test has been failed since r193616
​https://bugs.webkit.org/show_bug.cgi?id=151942

Reviewed by Darin Adler.

Source/WebKit2:

As wkpreference settings were moved from EwkView to WKPreferenceEfl, the offline-web-application-cache feature
is enabled by default when running API test. It seems this option should be enabled by MiniBrowser.

• UIProcess/efl/WebPreferencesEfl.cpp:

(WebKit::WebPreferences::platformInitializeStore): Remove to enable web application cache feature here.

Tools:

• MiniBrowser/efl/main.c:

(window_create): Enable offline web application cache feature on MiniBrowser.
(elm_main):

1:42 AM Changeset in webkit [193811] by ryuan.choi@navercorp.com

• 5 edits in trunk/Source/WebKit2

[CoordinatedGraphics] layerTreeHost always exist in CoordinatedDrawingArea
​https://bugs.webkit.org/show_bug.cgi?id=151987

Reviewed by Darin Adler.

CoordinatedGraphics using UI side compositor always forces accelerated compositing.
This patch cleans up dead code for layerTreeHost which always exists.

• UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:

(WebKit::CoordinatedDrawingAreaProxy::paint): Deleted.
(WebKit::CoordinatedDrawingAreaProxy::setBackingStoreIsDiscardable): Deleted.
(WebKit::CoordinatedDrawingAreaProxy::update): Deleted.
(WebKit::CoordinatedDrawingAreaProxy::didUpdateBackingStoreState): Deleted.
(WebKit::CoordinatedDrawingAreaProxy::exitAcceleratedCompositingMode): Deleted.
(WebKit::CoordinatedDrawingAreaProxy::incorporateUpdate): Deleted.
(WebKit::CoordinatedDrawingAreaProxy::enterAcceleratedCompositingMode): Deleted.
(WebKit::CoordinatedDrawingAreaProxy::discardBackingStoreSoon): Deleted.
(WebKit::CoordinatedDrawingAreaProxy::discardBackingStore): Deleted.

• UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h:

(WebKit::CoordinatedDrawingAreaProxy::setBackingStoreIsDiscardable):

• WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.cpp:

(WebKit::CoordinatedDrawingArea::CoordinatedDrawingArea): Deleted.
(WebKit::CoordinatedDrawingArea::layerHostDidFlushLayers): Deleted.
(WebKit::CoordinatedDrawingArea::scheduleCompositingLayerFlush): Deleted.
(WebKit::CoordinatedDrawingArea::didUpdate): Deleted.
(WebKit::CoordinatedDrawingArea::enterAcceleratedCompositingMode): Deleted.
(WebKit::CoordinatedDrawingArea::scheduleDisplay): Deleted.
(WebKit::CoordinatedDrawingArea::displayTimerFired): Deleted.
(WebKit::CoordinatedDrawingArea::display): Deleted.
(WebKit::shouldPaintBoundsRect): Deleted.
(WebKit::CoordinatedDrawingArea::attachViewOverlayGraphicsLayer): Deleted.

• WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h: