⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Dec 19, 2015:

10:27 PM Changeset in webkit [194318] by mitz@apple.com
  • 136 edits
    1 delete in trunk

[Mac] WebKit contains dead source code for OS X Mavericks and earlier
​https://bugs.webkit.org/show_bug.cgi?id=152462

Reviewed by Alexey Proskuryakov.

Source/bmalloc:

  • Configurations/DebugRelease.xcconfig: Removed definition of MACOSX_DEPLOYMENT_TARGET for OS X 10.9.

Source/JavaScriptCore:

  • Removed build setting definitions for OS X 10.9 and earlier, and simplified defintions that became uniform across all OS X versions as a result:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/FeatureDefines.xcconfig:
  • Configurations/Version.xcconfig:
  • API/JSBase.h: Removed check against MAC_OS_X_VERSION_MIN_REQUIRED that was always true.

Source/ThirdParty/ANGLE:

  • Configurations/DebugRelease.xcconfig: Removed definitions of MACOSX_DEPLOYMENT_TARGET for OS X 10.8 and 10.9.

Source/WebCore:

  • Removed build setting definitions for OS X 10.9 and earlier, and simplified defintions that became uniform across all OS X versions as a result:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/FeatureDefines.xcconfig:
  • Configurations/Version.xcconfig:
  • Removed support for animating default buttons:
  • rendering/RenderButton.cpp:

(WebCore::RenderButton::RenderButton): Removed m_default initialization.
(WebCore::RenderButton::styleDidChange): Removed checking for animating default button and

starting the animation timer.

(WebCore::RenderButton::timerFired): Deleted.

  • rendering/RenderButton.h: Removed m_timer and m_default member variables
  • rendering/RenderTheme.h:

(WebCore::RenderTheme::defaultButtonHasAnimation): Deleted.

  • rendering/RenderThemeMac.h: Deleted override.
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::defaultButtonHasAnimation): Deleted.

  • Simplified expressions involving MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was never getting compiled:
  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
  • editing/mac/DictionaryLookup.h:
  • editing/mac/DictionaryLookup.mm:
  • html/canvas/WebGLDrawBuffers.cpp:
  • loader/DocumentLoader.cpp:
  • loader/cache/CachedFont.cpp:
  • loader/cocoa/DiskCacheMonitorCocoa.h:
  • page/cocoa/SettingsCocoa.mm:
  • platform/Scrollbar.cpp:
  • platform/cocoa/MemoryPressureHandlerCocoa.mm:
  • platform/cocoa/NetworkExtensionContentFilter.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
  • platform/graphics/cg/ImageSourceCG.cpp:
  • platform/graphics/cocoa/FontCacheCoreText.cpp:
  • platform/graphics/cocoa/FontCascadeCocoa.mm:
  • platform/graphics/mac/GraphicsContext3DMac.mm:
  • platform/mac/NSScrollerImpDetails.h:
  • platform/mac/ScrollAnimatorMac.mm:
  • platform/mac/ScrollViewMac.mm:
  • platform/mac/ScrollbarThemeMac.mm:
  • platform/mac/ThemeMac.mm:
  • platform/mac/WebCoreFullScreenPlaceholderView.h:
  • platform/mac/WebCoreFullScreenPlaceholderView.mm:
  • platform/network/cf/CookieJarCFNet.cpp:
  • platform/network/cf/ResourceRequest.h:
  • platform/spi/cf/CFNetworkSPI.h:
  • platform/spi/cocoa/CoreTextSPI.h:
  • platform/spi/cocoa/NSButtonCellSPI.h:
  • platform/spi/cocoa/NSColorSPI.h:
  • platform/spi/cocoa/QuartzCoreSPI.h:
  • platform/spi/mac/LookupSPI.h:
  • platform/spi/mac/NSFontSPI.h:
  • platform/spi/mac/NSImmediateActionGestureRecognizerSPI.h:
  • platform/spi/mac/NSPopoverSPI.h:
  • platform/spi/mac/NSSharingServicePickerSPI.h:
  • platform/spi/mac/NSSharingServiceSPI.h:
  • platform/spi/mac/TUCallSPI.h:
  • platform/sql/SQLiteDatabase.cpp:

Source/WebInspectorUI:

  • Removed build setting definitions for OS X 10.9 and earlier, and simplified defintions that became uniform across all OS X versions as a result:
  • Configurations/Base.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/Version.xcconfig:
  • Scripts/copy-user-interface-resources.pl: Removed code to delete Images/Legacy.
  • UserInterface/Images/Legacy: Removed this empty directory.

Source/WebKit/mac:

  • Removed build setting definitions for OS X 10.9 and earlier, and simplified defintions that became uniform across all OS X versions as a result:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/FeatureDefines.xcconfig:
  • Configurations/Version.xcconfig:
  • Configurations/WebKitLegacy.xcconfig:
  • Simplified expressions involving MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was never getting compiled:
  • WebCoreSupport/WebInspectorClient.mm:
  • WebView/WebDynamicScrollBarsView.mm:
  • WebView/WebHTMLView.mm:
  • WebView/WebImmediateActionController.h:
  • WebView/WebImmediateActionController.mm:
  • WebView/WebView.mm:
  • WebView/WebViewData.h:
  • WebView/WebViewData.mm:
  • WebView/WebViewInternal.h:

Source/WebKit2:

  • Removed build setting definitions for OS X 10.9 and earlier, and simplified defintions that became uniform across all OS X versions as a result:
  • Configurations/BaseTarget.xcconfig:
  • Configurations/BaseXPCService.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/FeatureDefines.xcconfig:
  • Configurations/Version.xcconfig:
  • Configurations/WebKit.xcconfig:
  • Removed the definition of BUNDLE_LOCALIZATION_KEY:
  • Configurations/WebContentService.Development.xcconfig:
  • Configurations/WebContentService.xcconfig:
  • Added CFBundleFollowParentLocalization set to true:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-OSX.plist:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-iOS.plist:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX-10.9-10.10.plist:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist:
  • WebKit2.xcodeproj/project.pbxproj: Removed the “Add CFBundle Localization Info.plist Key” script build phases from the Web Content Service targets.
  • Simplified expressions involving MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was never getting compiled:
  • DatabaseProcess/mac/com.apple.WebKit.Databases.sb.in:
  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:
  • NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
  • Platform/IPC/mac/ConnectionMac.mm:
  • Platform/IPC/mac/ImportanceAssertion.h:
  • Platform/mac/MenuUtilities.h:
  • Platform/mac/MenuUtilities.mm:
  • Platform/mac/StringUtilities.h:
  • Platform/mac/StringUtilities.mm:
  • Shared/API/Cocoa/WKFoundation.h:
  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:
  • UIProcess/API/Cocoa/WKViewPrivate.h:
  • UIProcess/API/Cocoa/WKWebView.mm:
  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/API/mac/WKView.mm:
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:
  • UIProcess/Cocoa/WebViewImpl.h:
  • UIProcess/Cocoa/WebViewImpl.mm:
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:
  • UIProcess/mac/PageClientImpl.mm:
  • UIProcess/mac/WKImmediateActionController.h:
  • UIProcess/mac/WKImmediateActionController.mm:
  • UIProcess/mac/WebInspectorProxyMac.mm:
  • WebProcess/WebPage/FindController.cpp:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/com.apple.WebProcess.sb.in:
  • config.h:

Source/WTF:

  • Configurations/DebugRelease.xcconfig: Removed definition of MACOSX_DEPLOYMENT_TARGET for OS X 10.9.
  • Simplified expressions involving MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was never getting compiled:
  • wtf/FeatureDefines.h:
  • wtf/MainThread.h:
  • wtf/OSObjectPtr.h:
  • wtf/Platform.h:
  • wtf/mac/DeprecatedSymbolsUsedBySafari.mm:
  • wtf/spi/darwin/XPCSPI.h:

Tools:

  • Removed definitions of MACOSX_DEPLOYMENT_TARGET and WEBKIT_SYSTEM_INTERFACE_LIBRARY for OS X 10.9:
  • DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
  • LayoutTestRelay/Configurations/DebugRelease.xcconfig:
  • MiniBrowser/Configurations/DebugRelease.xcconfig:
  • TestWebKitAPI/Configurations/DebugRelease.xcconfig:
  • WebKitTestRunner/Configurations/DebugRelease.xcconfig:
  • Simplified expressions involving MAC_OS_X_VERSION_MIN_REQUIRED and removed code that was never getting compiled:
  • DumpRenderTree/mac/TextInputController.m:
  • MiniBrowser/mac/BrowserWindowController.m:
  • TestWebKitAPI/Tests/mac/AttributedString.mm:
  • WebKitTestRunner/mac/EventSenderProxy.mm:

WebKitLibraries:

  • libWebKitSystemInterfaceMavericks.a: Removed.
1:42 PM Changeset in webkit [194317] by Sukolsak Sakshuwong
  • 1 edit in trunk/Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

Make Intl headers private in Xcode

1:04 PM Changeset in webkit [194316] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

[JSC] Streamline Tmp indexing inside the register allocator
​https://bugs.webkit.org/show_bug.cgi?id=152420

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-12-19
Reviewed by Filip Pizlo.

AirIteratedRegisterCoalescing has been accumulating a bit of mess over time.

When it started, every map addressed by Tmp was using Tmp hashing.
That caused massive performance problems. Everything perf sensitive was moved
to direct array addressing by the absolute Tmp index. This left the code
with half of the function using Tmp, the other half using indices.

With this patch, almost everything is moved to absolute indexing.
There are a few advantages to this:
-No more conversion churn for Floating Point registers.
-Most of the functions can now be shared between GP and FP.
-A bit of clean up since the core algorithm only deals with integers now.

This patch also changes the index type to be a template argument.
That will allow future specialization of "m_interferenceEdges" based
on the expected problem size.

Finally, the code related to the program modification (register assignment
and spilling) was moved to the wrapper "IteratedRegisterCoalescing".

The current split is:
-AbstractColoringAllocator: common core. Share as much as possible between

GP and FP.

-ColoringAllocator: the remaining parts of the algorithm, everything that

is specific to GP, FP.

-IteratedRegisterCoalescing: the "iterated" part of the algorithm.

Try to allocate and modify the code as needed.

The long term plan is:
-Move selectSpill() and the coloring loop to AbstractColoringAllocator.
-Specialize m_interferenceEdges to make it faster.

  • b3/air/AirIteratedRegisterCoalescing.cpp:
  • b3/air/AirTmpInlines.h:

(JSC::B3::Air::AbsoluteTmpMapper<Arg::GP>::lastMachineRegisterIndex):
(JSC::B3::Air::AbsoluteTmpMapper<Arg::FP>::lastMachineRegisterIndex):

11:01 AM Changeset in webkit [194315] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] FTLB3Output generates some invalid ZExt32
​https://bugs.webkit.org/show_bug.cgi?id=151905

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-12-19
Reviewed by Filip Pizlo.

FTLLowerDFGToLLVM calls zeroExt() to int32 in some cases.
We were generating ZExt32 with Int32 as return type :(

  • ftl/FTLB3Output.h:

(JSC::FTL::Output::zeroExt):

8:52 AM Changeset in webkit [194314] by commit-queue@webkit.org
  • 15 edits in trunk/Source/JavaScriptCore

[JSC] Add EqualOrUnordered to B3
​https://bugs.webkit.org/show_bug.cgi?id=152425

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-12-19
Reviewed by Mark Lam.

Add EqualOrUnordered to B3 and use it to implements
FTL::Output's NotEqualAndOrdered.

  • b3/B3ConstDoubleValue.cpp:

(JSC::B3::ConstDoubleValue::equalOrUnordered):

  • b3/B3ConstDoubleValue.h:
  • b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::createGenericCompare):
(JSC::B3::Air::LowerToAir::lower):

  • b3/B3Opcode.cpp:

(WTF::printInternal):

  • b3/B3Opcode.h:
  • b3/B3ReduceDoubleToFloat.cpp:

(JSC::B3::reduceDoubleToFloat):

  • b3/B3ReduceStrength.cpp:
  • b3/B3Validate.cpp:
  • b3/B3Value.cpp:

(JSC::B3::Value::equalOrUnordered):
(JSC::B3::Value::returnsBool):
(JSC::B3::Value::effects):
(JSC::B3::Value::key):
(JSC::B3::Value::typeFor):

  • b3/B3Value.h:
  • b3/testb3.cpp:

(JSC::B3::testBranchEqualOrUnorderedArgs):
(JSC::B3::testBranchNotEqualAndOrderedArgs):
(JSC::B3::testBranchEqualOrUnorderedDoubleArgImm):
(JSC::B3::testBranchEqualOrUnorderedFloatArgImm):
(JSC::B3::testBranchEqualOrUnorderedDoubleImms):
(JSC::B3::testBranchEqualOrUnorderedFloatImms):
(JSC::B3::testBranchEqualOrUnorderedFloatWithUselessDoubleConversion):
(JSC::B3::run):

  • ftl/FTLB3Output.h:

(JSC::FTL::Output::doubleNotEqualAndOrdered):
(JSC::FTL::Output::doubleNotEqual): Deleted.

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::boolify):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::doubleNotEqualAndOrdered):
(JSC::FTL::Output::doubleNotEqual): Deleted.

5:26 AM Changeset in webkit [194313] by Antti Koivisto
  • 17 edits
    2 adds in trunk

Cache redirects as separate entries
​https://bugs.webkit.org/show_bug.cgi?id=152424

Reviewed by Alex Christensen.

Source/WebCore:

Test: http/tests/cache/disk-cache/disk-cache-redirect.html

  • platform/network/ResourceRequestBase.h:

Source/WebKit2:

We are currently caching redirect chains. This has correctness issues and can be inefficient in cases
where multiple URLs redirect to the same destination.

After this patch we write a cache entry for each redirect individually.

  • NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::sharedWillSendRedirectedRequest):

  • NetworkProcess/NetworkLoad.h:

(WebKit::NetworkLoad::currentRequest):
(WebKit::NetworkLoad::clearCurrentRequest):

  • NetworkProcess/NetworkLoadClient.h:

Add original request as a parameter for willSendRedirectedRequest.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::~NetworkResourceLoader):
(WebKit::NetworkResourceLoader::canUseCache):

Factor to a function.

(WebKit::NetworkResourceLoader::isSynchronous):
(WebKit::NetworkResourceLoader::start):
(WebKit::NetworkResourceLoader::retrieveCacheEntry):

Factor to a function.
Call dispatchWillSendRequestForCacheEntry for cached redirects.

(WebKit::NetworkResourceLoader::startNetworkLoad):

Make this take request as argument instead of always loading originalRequest().

(WebKit::NetworkResourceLoader::abort):
(WebKit::NetworkResourceLoader::didFinishLoading):

Remove redirect chain code.
Store cache entry for current request instead of the original request.

(WebKit::NetworkResourceLoader::didFailLoading):
(WebKit::NetworkResourceLoader::willSendRedirectedRequest):

Write cache entry for redirect.

(WebKit::NetworkResourceLoader::continueWillSendRequest):

If we are playing back cached redirect continue with another cache lookup.

(WebKit::NetworkResourceLoader::didRetrieveCacheEntry):

No need to synthesize fake willSendRequest anymore.

(WebKit::NetworkResourceLoader::validateCacheEntry):
(WebKit::NetworkResourceLoader::dispatchWillSendRequestForCacheEntry):

Route via web process willSendRequest so cached redirects looks exactly like network ones.

(WebKit::NetworkResourceLoader::messageSenderConnection):

  • NetworkProcess/NetworkResourceLoader.h:
  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::makeUseDecision):

Ignore validation headers for cached redirects.

(WebKit::NetworkCache::makeRetrieveDecision):
(WebKit::NetworkCache::makeStoreDecision):
(WebKit::NetworkCache::Cache::retrieve):
(WebKit::NetworkCache::Cache::store):

Rename originalRequest -> request since it is not really the original request anymore in all cases.

(WebKit::NetworkCache::Cache::storeRedirect):

Stored redirects include the network layer generated ResourceRequest instead of body data.

(WebKit::NetworkCache::Cache::update):

  • NetworkProcess/cache/NetworkCache.h:
  • NetworkProcess/cache/NetworkCacheEntry.cpp:

(WebKit::NetworkCache::Entry::Entry):

New constructor for making redirect entries.

(WebKit::NetworkCache::Entry::encodeAsStorageRecord):
(WebKit::NetworkCache::Entry::decodeStorageRecord):

Encoding support.

  • NetworkProcess/cache/NetworkCacheEntry.h:

(WebKit::NetworkCache::Entry::varyingRequestHeaders):
(WebKit::NetworkCache::Entry::redirectRequest):

  • NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:

(WebKit::NetworkCache::SpeculativeLoad::~SpeculativeLoad):
(WebKit::NetworkCache::SpeculativeLoad::willSendRedirectedRequest):

  • NetworkProcess/cache/NetworkCacheSpeculativeLoad.h:
  • NetworkProcess/cache/NetworkCacheStatistics.cpp:

(WebKit::NetworkCache::cachedEntryReuseFailureToDiagnosticKey):

LayoutTests:

  • http/tests/cache/disk-cache/disk-cache-redirect-expected.txt: Added.
  • http/tests/cache/disk-cache/disk-cache-redirect.html: Added.
  • http/tests/cache/disk-cache/resources/generate-response.cgi:
1:01 AM Changeset in webkit [194312] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[JSC] B3: Add indexed addressing when lowering BitwiseCast
​https://bugs.webkit.org/show_bug.cgi?id=152432

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-12-19
Reviewed by Geoffrey Garen.

The MacroAssembler supports it, we should use it.

  • b3/air/AirOpcode.opcodes:
  • b3/testb3.cpp:

(JSC::B3::testBitwiseCastOnDoubleInMemoryIndexed):
(JSC::B3::testBitwiseCastOnInt64InMemoryIndexed):

Dec 18, 2015:

10:44 PM Changeset in webkit [194311] by Matt Baker
  • 10 edits in trunk/Source/WebInspectorUI

Web Inspector: Make it possible to debug injected scripts when the Debug UI is enabled
​https://bugs.webkit.org/show_bug.cgi?id=152445

Reviewed by Joseph Pecoraro.

  • UserInterface/Base/Main.js:

Added function to check for debug UI.

  • UserInterface/Base/Object.js:

Added notification for debug UI enabled state change.

  • UserInterface/Base/Utilities.js:

(isWebInspectorInternalScript):
(isWebInspectorDebugScript):
Added functions to check for internal and debug inspector scripts.

  • UserInterface/Controllers/DebuggerManager.js:

(WebInspector.DebuggerManager):
Maintain a list of inspector debug scripts, so that the manager can
add and remove them when the debug UI is enabled/disabled.
(WebInspector.DebuggerManager.prototype.get knownNonResourceScripts):
(WebInspector.DebuggerManager.prototype.reset):
Clear the list of inspector debug scripts.
(WebInspector.DebuggerManager.prototype.debuggerDidPause):
(WebInspector.DebuggerManager.prototype.scriptDidParse):
Skip internal inspector scripts. Debug inspector scripts are tracked,
and an added event is dispatched if the debug UI is enabled.
(WebInspector.DebuggerManager.prototype._debugUIEnabledDidChange):
Dispatch added/removed events for inspector debug scripts.

  • UserInterface/Debug/Bootstrap.js:

(WebInspector.runBootstrapOperations):
Expose changes to the debug UI setting to the reset of the UI, by dispatching
a WebInspector.Notification.DebugUIEnabledDidChange event.

  • UserInterface/Protocol/RemoteObject.js:

(WebInspector.RemoteObject.prototype.findFunctionSourceCodeLocation):
Only resolve inspector debug source locations when the debug UI is enabled.

  • UserInterface/Test/Test.js:

Reimplemented debug UI check for tests. Always returns false.

  • UserInterface/Views/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel.prototype._addScript):
Removed check for inspector debug scripts. DebuggerManager filters scripts as needed.
(WebInspector.DebuggerSidebarPanel.prototype._scriptRemoved):
Handle DebuggerManager ScriptRemoved events. Only applies to debug scripts.

  • UserInterface/Views/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel):
(WebInspector.ResourceSidebarPanel.prototype._scriptWasRemoved):
Handle DebuggerManager ScriptRemoved events. Only applies to debug scripts.
(WebInspector.ResourceSidebarPanel.prototype._scriptWasAdded):
Removed check for inspector debug scripts. DebuggerManager filters scripts as needed.

6:32 PM Changeset in webkit [194310] by akling@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

Make JSString::SafeView less of a footgun.
<​https://webkit.org/b/152376>

Reviewed by Darin Adler.

Remove the "operator StringView()" convenience helper on JSString::SafeString since that
made it possible to casually turn the return value from JSString::view() into an unsafe
StringView local on the stack with this pattern:

StringView view = someJSValue.toString(exec)->view(exec);

The JSString* returned by toString() above will go out of scope by the end of the statement
and does not stick around to protect itself from garbage collection.

It will now look like this instead:

JSString::SafeView view = someJSValue.toString(exec)->view(exec);

To be extra clear, the following is not safe:

StringView view = someJSValue.toString(exec)->view(exec).get();

By the end of that statement, the JSString::SafeView goes out of scope, and the JSString*
is no longer protected from GC.

I added a couple of forwarding helpers to the SafeView class, and if you need a StringView
object from it, you can call .get() just like before.

Finally I also removed the JSString::SafeView() constructor, since nobody was instantiating
empty SafeView objects anyway. This way we don't have to worry about null members.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncJoin):

  • runtime/FunctionConstructor.cpp:

(JSC::constructFunctionSkippingEvalEnabledCheck):

  • runtime/JSGenericTypedArrayViewPrototypeFunctions.h:

(JSC::genericTypedArrayViewProtoFuncJoin):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::decode):
(JSC::globalFuncParseInt):
(JSC::globalFuncParseFloat):
(JSC::globalFuncEscape):
(JSC::globalFuncUnescape):

  • runtime/JSONObject.cpp:

(JSC::JSONProtoFuncParse):

  • runtime/JSString.cpp:

(JSC::JSString::getPrimitiveNumber):
(JSC::JSString::toNumber):

  • runtime/JSString.h:

(JSC::JSString::SafeView::is8Bit):
(JSC::JSString::SafeView::length):
(JSC::JSString::SafeView::characters8):
(JSC::JSString::SafeView::characters16):
(JSC::JSString::SafeView::operator[]):
(JSC::JSString::SafeView::SafeView):
(JSC::JSString::SafeView::get):
(JSC::JSString::SafeView::operator StringView): Deleted.

  • runtime/StringPrototype.cpp:

(JSC::stringProtoFuncCharAt):
(JSC::stringProtoFuncCharCodeAt):
(JSC::stringProtoFuncIndexOf):
(JSC::stringProtoFuncNormalize):

6:31 PM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro
(diff)
6:07 PM Changeset in webkit [194309] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.46.88

New tag.

6:07 PM Changeset in webkit [194308] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.5.8

New tag.

6:04 PM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro
More Dec 18 gardening (diff)
5:40 PM Changeset in webkit [194307] by Simon Fraser
  • 2 edits in trunk/Source/WebKit/ios

Turn off "shrink-to-fit" viewport scaling in UIWebViews
​https://bugs.webkit.org/show_bug.cgi?id=152451
rdar://problem/23960882

Reviewed by Tim Horton.

Disable the "shrink to fit" behavior in UIWebViews. This disables it entirely,
even when the page has "shrink-to-fit=yes" in the viewport meta tag.

Not testable because we can't test actual UIWebView scaling behavior.

  • WebCoreSupport/WebChromeClientIOS.mm:

(dictionaryForViewportArguments):

5:31 PM Changeset in webkit [194306] by Michael Catanzaro
  • 2 edits in trunk/LayoutTests

[GTK] Mark fast/regions/overflow/overflow-region-float.html as passing

Unreviewed test gardening. This test has been passing since r191658.

  • platform/gtk/TestExpectations:
4:25 PM Changeset in webkit [194305] by peavo@outlook.com
  • 2 edits in trunk/Source/WebCore

[WinCairo] Empty context menu item.
​https://bugs.webkit.org/show_bug.cgi?id=152423

Reviewed by Alex Christensen.

The context menu contains a submenu item with no text.

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::populate):

4:19 PM Changeset in webkit [194304] by sbarati@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

BytecodeGenerator::pushLexicalScopeInternal and pushLexicalScope should use enums instead of bools
​https://bugs.webkit.org/show_bug.cgi?id=152450

Reviewed by Geoffrey Garen and Joseph Pecoraro.

This makes comprehending the call sites of these functions
easier without looking up the header of the function.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::initializeDefaultParameterValuesAndSetupFunctionScopeStack):
(JSC::BytecodeGenerator::initializeArrowFunctionContextScopeIfNeeded):
(JSC::BytecodeGenerator::emitPrefillStackTDZVariables):
(JSC::BytecodeGenerator::pushLexicalScope):
(JSC::BytecodeGenerator::pushLexicalScopeInternal):
(JSC::BytecodeGenerator::emitPushFunctionNameScope):
(JSC::BytecodeGenerator::emitPushCatchScope):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::lastOpcodeID):

  • bytecompiler/NodesCodegen.cpp:

(JSC::BlockNode::emitBytecode):
(JSC::ForNode::emitBytecode):
(JSC::ForInNode::emitMultiLoopBytecode):
(JSC::ForOfNode::emitBytecode):
(JSC::SwitchNode::emitBytecode):
(JSC::ClassExprNode::emitBytecode):

4:16 PM Changeset in webkit [194303] by Michael Catanzaro
  • 7 edits in trunk/Source

Avoid triggering clang's -Wundefined-bool-conversion
​https://bugs.webkit.org/show_bug.cgi?id=152408

Reviewed by Mark Lam.

Source/JavaScriptCore:

Add ASSERT_THIS_GC_OBJECT_LOOKS_VALID and ASSERT_THIS_GC_OBJECT_INHERITS to avoid use of
ASSERT(this) by ASSERT_GC_OBJECT_LOOKS_VALID and ASSERT_GC_OBJECT_INHERITS.

  • heap/GCAssertions.h:

Source/WebCore:

Remove use of ASSERT(this).

  • dom/TreeScope.cpp:

(WebCore::TreeScope::adoptIfNeeded):

  • page/Frame.cpp:

(WebCore::Frame::createView):

Source/WebKit2:

Use ASSERT_THIS_GC_OBJECT_INHERITS where needed.

  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::JSNPObject::callMethod):
(WebKit::JSNPObject::callObject):
(WebKit::JSNPObject::callConstructor):
(WebKit::JSNPObject::deleteProperty):

3:56 PM Changeset in webkit [194302] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skipping fast/scrolling/rtl-point-in-iframe.html on ios-simulator since it tests wheel events.
​https://bugs.webkit.org/show_bug.cgi?id=152442

Unreviewed test gardening.

  • platform/ios-simulator/TestExpectations:
3:55 PM Changeset in webkit [194301] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Remove the 'ignoreViewportScalingConstraints' Setting, which was unused
​https://bugs.webkit.org/show_bug.cgi?id=152435

Reviewed by Tim Horton.

r177110 added a WebCore setting called ignoreViewportScalingConstraints,
but it was never used, so remove it.

  • page/Settings.in:
3:38 PM Changeset in webkit [194300] by bshafiei@apple.com
  • 5 edits in tags/Safari-602.1.14.0.1/Source

Versioning.

3:34 PM Changeset in webkit [194299] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.14.0.1

New tag.

3:06 PM Changeset in webkit [194298] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Rebaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator
​https://bugs.webkit.org/show_bug.cgi?id=152437

Unreviewed test gardening.

  • platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
3:05 PM Changeset in webkit [194297] by matthew_hanson@apple.com
  • 12 edits in branches/safari-601.1.46-branch

Merge r194246. rdar://problem/23824469

3:05 PM Changeset in webkit [194296] by matthew_hanson@apple.com
  • 6 edits in branches/safari-601.1.46-branch/Source

Merge r194206. rdar://problem/23824469

2:34 PM Changeset in webkit [194295] by andersca@apple.com
  • 12 edits
    11 deletes in trunk/Source/WebKit2

Get rid of WebDatabaseManager, it's been replaced by WebsiteDataStore
​https://bugs.webkit.org/show_bug.cgi?id=152318

Reviewed by Tim Horton.

Build fixes by Ossy.

  • DerivedSources.make:
  • Shared/API/APIObject.h:
  • Shared/API/c/WKBase.h:
  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKContext.cpp:

(WKContextGetDatabaseManager): Deleted.

  • UIProcess/API/C/WKContext.h:
  • UIProcess/API/C/WKDatabaseManager.cpp: Removed.

(WKDatabaseManagerGetTypeID): Deleted.
(WKDatabaseManagerGetOriginKey): Deleted.
(WKDatabaseManagerGetOriginQuotaKey): Deleted.
(WKDatabaseManagerGetOriginUsageKey): Deleted.
(WKDatabaseManagerGetDatabaseDetailsKey): Deleted.
(WKDatabaseManagerGetDatabaseDetailsNameKey): Deleted.
(WKDatabaseManagerGetDatabaseDetailsDisplayNameKey): Deleted.
(WKDatabaseManagerGetDatabaseDetailsExpectedUsageKey): Deleted.
(WKDatabaseManagerGetDatabaseDetailsCurrentUsageKey): Deleted.
(WKDatabaseManagerGetDatabaseDetailsCreationTimeKey): Deleted.
(WKDatabaseManagerGetDatabaseDetailsModificationTimeKey): Deleted.
(WKDatabaseManagerSetClient): Deleted.
(WKDatabaseManagerGetDatabasesByOrigin): Deleted.
(WKDatabaseManagerGetDatabaseOrigins): Deleted.
(WKDatabaseManagerDeleteDatabasesWithNameForOrigin): Deleted.
(WKDatabaseManagerDeleteDatabasesForOrigin): Deleted.
(WKDatabaseManagerDeleteAllDatabases): Deleted.
(WKDatabaseManagerSetQuotaForOrigin): Deleted.

  • UIProcess/API/C/WKDatabaseManager.h: Removed.
  • UIProcess/WebDatabaseManagerProxy.cpp: Removed.

(WebKit::WebDatabaseManagerProxy::supplementName): Deleted.
(WebKit::WebDatabaseManagerProxy::originKey): Deleted.
(WebKit::WebDatabaseManagerProxy::originQuotaKey): Deleted.
(WebKit::WebDatabaseManagerProxy::originUsageKey): Deleted.
(WebKit::WebDatabaseManagerProxy::databaseDetailsKey): Deleted.
(WebKit::WebDatabaseManagerProxy::databaseDetailsNameKey): Deleted.
(WebKit::WebDatabaseManagerProxy::databaseDetailsDisplayNameKey): Deleted.
(WebKit::WebDatabaseManagerProxy::databaseDetailsExpectedUsageKey): Deleted.
(WebKit::WebDatabaseManagerProxy::databaseDetailsCurrentUsageKey): Deleted.
(WebKit::WebDatabaseManagerProxy::databaseDetailsCreationTimeKey): Deleted.
(WebKit::WebDatabaseManagerProxy::databaseDetailsModificationTimeKey): Deleted.
(WebKit::WebDatabaseManagerProxy::create): Deleted.
(WebKit::WebDatabaseManagerProxy::WebDatabaseManagerProxy): Deleted.
(WebKit::WebDatabaseManagerProxy::~WebDatabaseManagerProxy): Deleted.
(WebKit::WebDatabaseManagerProxy::initializeClient): Deleted.
(WebKit::WebDatabaseManagerProxy::processPoolDestroyed): Deleted.
(WebKit::WebDatabaseManagerProxy::processDidClose): Deleted.
(WebKit::WebDatabaseManagerProxy::shouldTerminate): Deleted.
(WebKit::WebDatabaseManagerProxy::refWebContextSupplement): Deleted.
(WebKit::WebDatabaseManagerProxy::derefWebContextSupplement): Deleted.
(WebKit::WebDatabaseManagerProxy::getDatabasesByOrigin): Deleted.
(WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin): Deleted.
(WebKit::WebDatabaseManagerProxy::getDatabaseOrigins): Deleted.
(WebKit::WebDatabaseManagerProxy::didGetDatabaseOrigins): Deleted.
(WebKit::WebDatabaseManagerProxy::deleteDatabaseWithNameForOrigin): Deleted.
(WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin): Deleted.
(WebKit::WebDatabaseManagerProxy::deleteAllDatabases): Deleted.
(WebKit::WebDatabaseManagerProxy::setQuotaForOrigin): Deleted.
(WebKit::WebDatabaseManagerProxy::didModifyOrigin): Deleted.
(WebKit::WebDatabaseManagerProxy::didModifyDatabase): Deleted.

  • UIProcess/WebDatabaseManagerProxy.h: Removed.
  • UIProcess/WebDatabaseManagerProxy.messages.in: Removed.
  • UIProcess/WebDatabaseManagerProxyClient.cpp: Removed.

(WebKit::WebDatabaseManagerProxyClient::didModifyOrigin): Deleted.
(WebKit::WebDatabaseManagerProxyClient::didModifyDatabase): Deleted.

  • UIProcess/WebDatabaseManagerProxyClient.h: Removed.
  • UIProcess/WebProcessPool.cpp:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:
  • WebProcess/WebCoreSupport/WebDatabaseManager.cpp: Removed.

(WebKit::WebDatabaseManager::supplementName): Deleted.
(WebKit::WebDatabaseManager::WebDatabaseManager): Deleted.
(WebKit::WebDatabaseManager::initialize): Deleted.
(WebKit::WebDatabaseManager::getDatabasesByOrigin): Deleted.
(WebKit::WebDatabaseManager::getDatabaseOrigins): Deleted.
(WebKit::WebDatabaseManager::deleteDatabaseWithNameForOrigin): Deleted.
(WebKit::WebDatabaseManager::deleteDatabasesForOrigin): Deleted.
(WebKit::WebDatabaseManager::deleteAllDatabases): Deleted.
(WebKit::WebDatabaseManager::closeAllDatabases): Deleted.
(WebKit::WebDatabaseManager::setQuotaForOrigin): Deleted.
(WebKit::WebDatabaseManager::dispatchDidModifyOrigin): Deleted.
(WebKit::WebDatabaseManager::dispatchDidModifyDatabase): Deleted.

  • WebProcess/WebCoreSupport/WebDatabaseManager.h: Removed.
  • WebProcess/WebCoreSupport/WebDatabaseManager.messages.in: Removed.
  • WebProcess/WebCoreSupport/ios/WebDatabaseManagerIOS.mm: Removed.

(WebKit::WebDatabaseManager::dispatchDidAddNewOrigin): Deleted.
(WebKit::WebDatabaseManager::dispatchDidDeleteDatabase): Deleted.
(WebKit::WebDatabaseManager::dispatchDidDeleteDatabaseOrigin): Deleted.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::processWillSuspendImminently):
(WebKit::m_webSQLiteDatabaseTracker): Deleted.

2:03 PM Changeset in webkit [194294] by mark.lam@apple.com
  • 14 edits
    1 add in trunk/Source/JavaScriptCore

Replace SpecialFastCase profiles with ResultProfiles.
​https://bugs.webkit.org/show_bug.cgi?id=152433

Reviewed by Saam Barati.

This is in preparation for upcoming work to enhance the DFG predictions to deal
with untyped operands.

This patch also enhances some of the arithmetic slow paths (for the LLINT and
baseline JIT) to collect result profiling info. This profiling info is not put
to use yet.

(JSC::CodeBlock::dumpRareCaseProfile):
(JSC::CodeBlock::dumpResultProfile):
(JSC::CodeBlock::printLocationAndOp):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::shrinkToFit):
(JSC::CodeBlock::dumpValueProfiles):
(JSC::CodeBlock::rareCaseProfileCountForBytecodeOffset):
(JSC::CodeBlock::resultProfileForBytecodeOffset):
(JSC::CodeBlock::updateResultProfileForBytecodeOffset):
(JSC::CodeBlock::capabilityLevel):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::couldTakeSlowCase):
(JSC::CodeBlock::addResultProfile):
(JSC::CodeBlock::numberOfResultProfiles):
(JSC::CodeBlock::specialFastCaseProfileCountForBytecodeOffset):
(JSC::CodeBlock::couldTakeSpecialFastCase):
(JSC::CodeBlock::addSpecialFastCaseProfile): Deleted.
(JSC::CodeBlock::numberOfSpecialFastCaseProfiles): Deleted.
(JSC::CodeBlock::specialFastCaseProfile): Deleted.
(JSC::CodeBlock::specialFastCaseProfileForBytecodeOffset): Deleted.

  • bytecode/ValueProfile.cpp: Added.

(WTF::printInternal):

  • bytecode/ValueProfile.h:

(JSC::getRareCaseProfileBytecodeOffset):
(JSC::ResultProfile::ResultProfile):
(JSC::ResultProfile::bytecodeOffset):
(JSC::ResultProfile::specialFastPathCount):
(JSC::ResultProfile::didObserveNonInt32):
(JSC::ResultProfile::didObserveDouble):
(JSC::ResultProfile::didObserveNonNegZeroDouble):
(JSC::ResultProfile::didObserveNegZeroDouble):
(JSC::ResultProfile::didObserveNonNumber):
(JSC::ResultProfile::didObserveInt32Overflow):
(JSC::ResultProfile::setObservedNonNegZeroDouble):
(JSC::ResultProfile::setObservedNegZeroDouble):
(JSC::ResultProfile::setObservedNonNumber):
(JSC::ResultProfile::setObservedInt32Overflow):
(JSC::ResultProfile::addressOfFlags):
(JSC::ResultProfile::addressOfSpecialFastPathCount):
(JSC::ResultProfile::hasBits):
(JSC::ResultProfile::setBit):
(JSC::getResultProfileBytecodeOffset):

  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_div):
(JSC::JIT::emit_op_mul):

  • jit/JITDivGenerator.cpp:

(JSC::JITDivGenerator::generateFastPath):

  • jit/JITDivGenerator.h:

(JSC::JITDivGenerator::JITDivGenerator):

  • jit/JITMulGenerator.cpp:

(JSC::JITMulGenerator::generateFastPath):

  • jit/JITMulGenerator.h:

(JSC::JITMulGenerator::JITMulGenerator):

  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

1:52 PM Changeset in webkit [194293] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

verboseDFGByteCodeParsing option should show the bytecode it is parsing.
​https://bugs.webkit.org/show_bug.cgi?id=152434

Reviewed by Michael Saboff.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

1:29 PM Changeset in webkit [194292] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.46.60.2

New tag.

1:29 PM Changeset in webkit [194291] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.4.4

New tag.

1:28 PM Changeset in webkit [194290] by Brent Fulgham
  • 3 edits in trunk/Source/WebCore

Place an upper bound on canvas pixel count
​https://bugs.webkit.org/show_bug.cgi?id=151825
<rdar://problem/23324916>

Reviewed by Simon Fraser (Relanded by Brent Fulgham)

Malformed JavaScript can attempt to create lots of canvas contexts. Limit the amount of memory
we will use for this purpose to some percentage of system RAM.

  • html/HTMLCanvasElement.cpp:

(WebCore::removeFromActivePixelMemory): Added helper function
(WebCore::HTMLCanvasElement::~HTMLCanvasElement): Call new 'releaseImageBufferAndContext' method
to ensure ImageBuffer and graphics context state are properly cleaned up.
(WebCore::maxActivePixels): Use one quarter of the system RAM, or 2 GB (whichever is more) as
an upper bound on active pixel memory.
(WebCore::HTMLCanvasElement::getContext): If we are attempting to create a context that will cause
us to exceed the allowed active pixel count, fail.
(WebCore::HTMLCanvasElement::releaseImageBufferAndContext): Added helper function
(WebCore::HTMLCanvasElement::setSurfaceSize): Use the new 'releaseImageBufferAndContext' method
to handle active pixel memory counts.
(WebCore::HTMLCanvasElement::createImageBuffer): Refuse to create a backing buffer if it will
exceed our available pixel memory.

1:11 PM Changeset in webkit [194289] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601-branch/Source/WebCore

Merge r193932. rdar://problem/23886464

1:11 PM Changeset in webkit [194288] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601-branch/LayoutTests

Merge r193914. rdar://problem/23769758

1:11 PM Changeset in webkit [194287] by matthew_hanson@apple.com
  • 14 edits
    8 adds in branches/safari-601-branch

Merge r193894. rdar://problem/23769758

1:03 PM Changeset in webkit [194286] by bshafiei@apple.com
  • 5 edits in tags/Safari-602.1.13.0.2/Source

Versioning.

12:40 PM Changeset in webkit [194285] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.13.0.2

New tag.

11:56 AM Changeset in webkit [194284] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[GTK] Unreviewed, update POTFILES.in after r194272

  • POTFILES.in:
11:49 AM Changeset in webkit [194283] by bshafiei@apple.com
  • 4 edits in branches/safari-601.1.46-branch/Source/WebCore

Merged r192582. rdar://problem/23957053

11:49 AM Changeset in webkit [194282] by matthew_hanson@apple.com
  • 4 edits in branches/safari-601.4-branch/Source/WebCore

Merge r192582. rdar://problem/23910980

11:48 AM Changeset in webkit [194281] by bshafiei@apple.com
  • 4 edits in branches/safari-601.1.46.60-branch/Source/WebCore

Merged r192582. rdar://problem/23957053

11:46 AM Changeset in webkit [194280] by Michael Catanzaro
  • 2 edits in trunk/Source/WebKit2

[GTK] Unreviewed, fix GtkDoc after r193620

  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
11:42 AM Changeset in webkit [194279] by matthew_hanson@apple.com
  • 4 edits in branches/safari-601-branch/Source/WebCore

Merge r192582. rdar://problem/23910980

11:37 AM Changeset in webkit [194278] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Fix the !ENABLE(VIDEO) build after r192953 for <picture> element introduction
​https://bugs.webkit.org/show_bug.cgi?id=152431

Since r192953, HTMLSourceElement is built even if video is disabled,
since it is used by the picture element.

But build was broken with -no-video, since HTMLMediaElement usage
should be guarded by VIDEO guards, and its JS bindings were still
under a video conditional.

Patch by Olivier Blin <Olivier Blin> on 2015-12-18
Reviewed by Alex Christensen.

No new tests, build fix only.

  • html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::insertedInto):
(WebCore::HTMLSourceElement::removedFrom):

  • html/HTMLSourceElement.idl:
11:11 AM Changeset in webkit [194277] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Marking inspector/console/messagesCleared.html as a flaky timeout on mac-wk2 debug
​https://bugs.webkit.org/show_bug.cgi?id=152025

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
10:41 AM Changeset in webkit [194276] by Michael Catanzaro
  • 2 edits in trunk/Tools

Unreviewed, add WebKitGTK+ Bugzilla email to committers list

This is to make it easy to CC it on Bugzilla.

  • Scripts/webkitpy/common/config/contributors.json:
10:31 AM Changeset in webkit [194275] by beidson@apple.com
  • 4 edits in trunk

Modern IDB: Refactor when opening the backing store takes place.
​https://bugs.webkit.org/show_bug.cgi?id=152405

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (At least one failing test now passes).

  • Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::openDatabaseConnection): Move the "open backing store" logic

from here to performCurrentOpenOperation.

(WebCore::IDBServer::UniqueIDBDatabase::performCurrentOpenOperation): If the database backing store is

not open yet, kick off opening it here.

(WebCore::IDBServer::UniqueIDBDatabase::handleDatabaseOperations): Rework this stuff to be better.

LayoutTests:

  • platform/mac-wk1/TestExpectations:
10:19 AM Changeset in webkit [194274] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

WebPage::didCompleteUserMediaPermissionCheck and WebPage::didReceiveUserMediaPermissionDecision are exported
​https://bugs.webkit.org/show_bug.cgi?id=152429

Reviewed by Tim Horton.

  • WebProcess/WebPage/WebPage.h: Removed WK_EXPORT specifiers from these two declarations.
10:16 AM Changeset in webkit [194273] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Pasteboard get messed up after running kill-old-processes
​https://bugs.webkit.org/show_bug.cgi?id=152426

Patch by Aakash Jain <​aakash_jain@apple.com> on 2015-12-18
Reviewed by Alexey Proskuryakov.

  • BuildSlaveSupport/kill-old-processes:

(main): Do not kill pasteboard anymore.

10:08 AM Changeset in webkit [194272] by achristensen@apple.com
  • 7 edits
    11 copies
    1 move
    1 delete in trunk/Source/WebKit2

Move networking code from Shared to NetworkProcess
​https://bugs.webkit.org/show_bug.cgi?id=152421

Reviewed by Antti Koivisto.

Since recently removing the non-NetworkProcess configurations, this code is no longer shared with the WebProcess.

  • CMakeLists.txt:
  • DerivedSources.make:
  • NetworkProcess/CustomProtocols: Copied from Source/WebKit2/Shared/Network/CustomProtocols.
  • NetworkProcess/Downloads: Copied from Source/WebKit2/Shared/Downloads.
  • NetworkProcess/Downloads/Download.cpp: Copied from Source/WebKit2/Shared/Downloads/Download.cpp.
  • NetworkProcess/Downloads/Download.h: Copied from Source/WebKit2/Shared/Downloads/Download.h.
  • NetworkProcess/Downloads/DownloadID.h: Copied from Source/WebKit2/Shared/Downloads/DownloadID.h.
  • NetworkProcess/Downloads/DownloadManager.cpp: Copied from Source/WebKit2/Shared/Downloads/DownloadManager.cpp.
  • NetworkProcess/Downloads/DownloadManager.h: Copied from Source/WebKit2/Shared/Downloads/DownloadManager.h.
  • NetworkProcess/NetworkProcessCreationParameters.cpp: Copied from Source/WebKit2/Shared/Network/NetworkProcessCreationParameters.cpp.
  • NetworkProcess/NetworkProcessCreationParameters.h: Copied from Source/WebKit2/Shared/Network/NetworkProcessCreationParameters.h.
  • NetworkProcess/NetworkProcessSupplement.h: Copied from Source/WebKit2/Shared/Network/NetworkProcessSupplement.h.
  • NetworkProcess/NetworkResourceLoadParameters.cpp: Copied from Source/WebKit2/Shared/Network/NetworkResourceLoadParameters.cpp.
  • NetworkProcess/NetworkResourceLoadParameters.h: Copied from Source/WebKit2/Shared/Network/NetworkResourceLoadParameters.h.
  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • PlatformMac.cmake:
  • Shared/Downloads: Removed.
  • Shared/Downloads/Download.cpp: Removed.
  • Shared/Downloads/Download.h: Removed.
  • Shared/Downloads/DownloadAuthenticationClient.cpp: Removed.
  • Shared/Downloads/DownloadAuthenticationClient.h: Removed.
  • Shared/Downloads/DownloadID.h: Removed.
  • Shared/Downloads/DownloadManager.cpp: Removed.
  • Shared/Downloads/DownloadManager.h: Removed.
  • Shared/Downloads/cocoa: Removed.
  • Shared/Downloads/cocoa/DownloadCocoa.mm: Removed.
  • Shared/Downloads/efl: Removed.
  • Shared/Downloads/efl/DownloadSoupErrorsEfl.cpp: Removed.
  • Shared/Downloads/gtk: Removed.
  • Shared/Downloads/gtk/DownloadSoupErrorsGtk.cpp: Removed.
  • Shared/Downloads/ios: Removed.
  • Shared/Downloads/ios/DownloadIOS.mm: Removed.
  • Shared/Downloads/mac: Removed.
  • Shared/Downloads/mac/DownloadMac.mm: Removed.
  • Shared/Downloads/soup: Removed.
  • Shared/Downloads/soup/DownloadSoup.cpp: Removed.
  • Shared/Downloads/soup/DownloadSoupErrors.h: Removed.
  • Shared/Network: Removed.
  • Shared/Network/CustomProtocols: Removed.
  • Shared/Network/CustomProtocols/Cocoa: Removed.
  • Shared/Network/CustomProtocols/Cocoa/CustomProtocolManagerCocoa.mm: Removed.
  • Shared/Network/CustomProtocols/CustomProtocolManager.h: Removed.
  • Shared/Network/CustomProtocols/CustomProtocolManager.messages.in: Removed.
  • Shared/Network/CustomProtocols/soup: Removed.
  • Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.cpp: Removed.
  • Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.h: Removed.
  • Shared/Network/CustomProtocols/soup/CustomProtocolManagerSoup.cpp: Removed.
  • Shared/Network/NetworkProcessCreationParameters.cpp: Removed.
  • Shared/Network/NetworkProcessCreationParameters.h: Removed.
  • Shared/Network/NetworkProcessSupplement.h: Removed.
  • Shared/Network/NetworkResourceLoadParameters.cpp: Removed.
  • Shared/Network/NetworkResourceLoadParameters.h: Removed.
  • WebKit2.xcodeproj/project.pbxproj:
8:36 AM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro
Dec 18 gardening (diff)
8:34 AM Changeset in webkit [194271] by Michael Catanzaro
  • 2 edits in trunk/LayoutTests

[GTK] Unreviewed gardening

css3/flexbox/multiline-reverse-wrap-baseline.html consistently passes for GTK since
r191623, but fails on Apple ports, so add a GTK-specific Pass expectation.

  • platform/gtk/TestExpectations:
8:25 AM Changeset in webkit [194270] by Michael Catanzaro
  • 2 edits in trunk/LayoutTests

[GTK] Unreviewed gardening
​https://bugs.webkit.org/show_bug.cgi?id=142292

fast/images/animated-gif-body-outside-viewport.html and
fast/images/animated-gif-window-resizing.html are flaky; mark them
accordingly.

  • platform/gtk/TestExpectations:
8:20 AM Changeset in webkit [194269] by Michael Catanzaro
  • 2 edits in trunk/LayoutTests

[GTK] Unreviewed gardening

Remove failure expectation for fast/events/drag-and-drop-autoscroll-inner-frame.html which
has been consistently passing since r192511.

  • platform/gtk/TestExpectations:
7:57 AM Changeset in webkit [194268] by Michael Catanzaro
  • 2 edits in trunk/Source/WebKit2

LayerTreeHostGtk triggers -Wunused-private-field
​https://bugs.webkit.org/show_bug.cgi?id=152410

Reviewed by Carlos Garcia Campos.

Remove the unused member variable.

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
3:10 AM Changeset in webkit [194267] by calvaris@igalia.com
  • 4 edits in trunk/LayoutTests/imported/w3c

[Streams API] imported/w3c/web-platform-tests/streams-api/readable-streams/cancel.html has a flaky test
​https://bugs.webkit.org/show_bug.cgi?id=152065

Reviewed by Youenn Fablet.

​https://github.com/whatwg/streams/pull/414 and ​https://github.com/whatwg/streams/issues/413 was closed. Changes
I did on the spec were integrated so they were brought back to the imported tests in WebKit.

  • web-platform-tests/streams-api/README.txt: Updated version.
  • web-platform-tests/streams-api/readable-streams/cancel-expected.txt: Expectations.
  • web-platform-tests/streams-api/readable-streams/cancel.js: Changed to cancel test.
1:59 AM Changeset in webkit [194266] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601-branch/Source/WebKit2

Merge r188606. rdar://problem/23905024

1:59 AM Changeset in webkit [194265] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601-branch/Source/WebKit2

Merge r188602. rdar://problem/23905024

12:10 AM Changeset in webkit [194264] by achristensen@apple.com
  • 27 edits
    1 add in trunk/Source/WebKit2

Add types for DownloadID and TaskIdentifier
​https://bugs.webkit.org/show_bug.cgi?id=152401

Reviewed by Brady Eidson.

DownloadID and TaskIdentifier used to both be just uint64_t's.
It is confusing to distinguish between them, so now they both have names.
We need a HashMap<TaskIdentifier, DownloadID> instead of a HashMap<uint64_t, uint64_t>.

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::storageSession):
(WebKit::NetworkConnectionToWebProcess::startDownload):
(WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload):

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:
  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcess::downloadRequest):
(WebKit::NetworkProcess::resumeDownload):
(WebKit::NetworkProcess::cancelDownload):
(WebKit::NetworkProcess::getNetworkProcessStatistics):
(WebKit::NetworkProcess::logDiagnosticMessage):
(WebKit::NetworkProcess::logDiagnosticMessageWithResult):
(WebKit::NetworkProcess::logDiagnosticMessageWithValue):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/NetworkSession.h:
  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSession::createDataTaskWithRequest):
(WebKit::NetworkSession::dataTaskForIdentifier):
(WebKit::NetworkDataTask::resume):
(WebKit::NetworkDataTask::taskIdentifier): Deleted.

  • Shared/Downloads/Download.cpp:

(WebKit::Download::Download):
(WebKit::Download::messageSenderDestinationID):

  • Shared/Downloads/Download.h:

(WebKit::Download::downloadID):

  • Shared/Downloads/DownloadID.h: Added.

(WebKit::DownloadID::DownloadID):
(WebKit::DownloadID::operator==):
(WebKit::DownloadID::downloadID):
(IPC::ArgumentCoder<WebKit::DownloadID>::encode):
(IPC::ArgumentCoder<WebKit::DownloadID>::decode):
(WTF::DownloadIDHash::hash):
(WTF::DownloadIDHash::equal):
(WTF::HashTraits<WebKit::DownloadID>::emptyValue):
(WTF::HashTraits<WebKit::DownloadID>::constructDeletedValue):
(WTF::HashTraits<WebKit::DownloadID>::isDeletedValue):

  • Shared/Downloads/DownloadManager.cpp:

(WebKit::DownloadManager::DownloadManager):
(WebKit::DownloadManager::startDownload):
(WebKit::DownloadManager::convertHandleToDownload):
(WebKit::DownloadManager::resumeDownload):
(WebKit::DownloadManager::cancelDownload):

  • Shared/Downloads/DownloadManager.h:

(WebKit::DownloadManager::isDownloading):

  • UIProcess/API/C/WKDownload.cpp:

(WKDownloadGetID):
(WKDownloadCopyRequest):

  • UIProcess/Downloads/DownloadProxy.h:

(WebKit::DownloadProxy::downloadID):
(WebKit::DownloadProxy::request):
(WebKit::DownloadProxy::resumeData):

  • UIProcess/Downloads/DownloadProxyMap.cpp:

(WebKit::DownloadProxyMap::createDownloadProxy):
(WebKit::DownloadProxyMap::downloadFinished):
(WebKit::DownloadProxyMap::processDidClose):

  • UIProcess/Downloads/DownloadProxyMap.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::frameDidBecomeFrameSet):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForResponse):
(WebKit::WebPageProxy::decidePolicyForResponseSync):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::invalidatePolicyListener):
(WebKit::WebFrame::didReceivePolicyDecision):
(WebKit::WebFrame::startDownload):
(WebKit::WebFrame::convertMainResourceLoadToDownload):

  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setSessionID):
(WebKit::WebPage::didReceivePolicyDecision):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
Note: See TracTimeline for information about the timeline view.