Timeline

Dec 25, 2015:

9:28 PM Changeset in webkit [194421] by Alan Bujtas

• 16 edits
  2 adds in trunk

Subpixel rendering: Add subpixel support for outline.
​https://bugs.webkit.org/show_bug.cgi?id=152560

Source/WebCore:

Reviewed by Simon Fraser.

This patch adds support for subpixel outline-width/outline-offset.

Test: fast/borders/hidpi-outline-hairline-painting.html

• css/CSSPropertyNames.in:
• page/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

• platform/graphics/GraphicsContext.h:
• platform/graphics/mac/GraphicsContextMac.mm:

(WebCore::GraphicsContext::drawFocusRing):

• rendering/RenderElement.cpp:

(WebCore::RenderElement::computeMaxOutlineSize):
(WebCore::RenderElement::paintOutline):

• rendering/RenderImage.cpp:

(WebCore::RenderImage::paintAreaElementFocusRing):

• rendering/RenderInline.cpp:

(WebCore::RenderInline::paintOutlineForLine):

• rendering/RenderObject.cpp:

(WebCore::RenderObject::adjustRectForOutlineAndShadow):

• rendering/RenderView.cpp:

(WebCore::RenderView::setMaximalOutlineSize):

• rendering/RenderView.h:
• rendering/style/OutlineValue.h:

(WebCore::OutlineValue::offset):
(WebCore::OutlineValue::OutlineValue): Deleted.

• rendering/style/RenderStyle.h:

LayoutTests:

Unable to ref-test other outline types.

Reviewed by Simon Fraser.

• fast/borders/hidpi-outline-hairline-painting-expected.html: Added.
• fast/borders/hidpi-outline-hairline-painting.html: Added.

12:46 PM Changeset in webkit [194420] by ap@apple.com

• 2 edits in trunk/Source/WebCore

ASSERT(m_nsResponse) in ResourceResponse::platformCertificateInfo() when running tests in iOS simulator
​https://bugs.webkit.org/show_bug.cgi?id=152559

Reviewed by Andy Estes.

Fix a regression from r194378.

• platform/network/cocoa/ResourceResponseCocoa.mm:

(WebCore::ResourceResponse::platformCertificateInfo):

4:22 AM Changeset in webkit [194419] by ddkilzer@apple.com

• 35 edits in trunk/Source

ResourceError should store failingURL as URL instead of String to avoid reparsing and to address FIXME comments in ResourceErrorCF.cpp and ResourceErrorMac.mm
<​http://webkit.org/b/146391>

Reviewed by Antti Koivisto.

Source/WebCore:

• loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
(WebCore::DocumentThreadableLoader::didReceiveResponse):
(WebCore::DocumentThreadableLoader::preflightFailure):

• loader/DocumentThreadableLoader.h:

(WebCore::DocumentThreadableLoader::preflightFailure):

• Switch type of 'url' argument of preflightFailure() from String to URL.
• Update for type change of 'failingURL' argument to ResourceError().

• loader/EmptyClients.h:
• loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadResourceSynchronously):

• loader/MediaResourceLoader.cpp:

(WebCore::MediaResourceLoader::responseReceived):

• loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::loadDataURL):

• loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::MainThreadBridge::cancel):

• loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

• Update for type change of 'failingURL' argument to ResourceError().

• page/EventSource.cpp:

(WebCore::EventSource::didFailAccessControlCheck):

• Convert failingURL() to String explicitly.

• platform/efl/ErrorsEfl.cpp:

(WebCore::cancelledError):
(WebCore::blockedError):
(WebCore::blockedByContentBlockerError):
(WebCore::cannotShowURLError):
(WebCore::interruptedForPolicyChangeError):
(WebCore::cannotShowMIMETypeError):
(WebCore::fileDoesNotExistError):
(WebCore::pluginWillHandleLoadError):
(WebCore::downloadCancelledByUserError):
(WebCore::downloadDestinationError):

• platform/gtk/ErrorsGtk.cpp:

(WebCore::cancelledError):
(WebCore::blockedError):
(WebCore::blockedByContentBlockerError):
(WebCore::cannotShowURLError):
(WebCore::interruptedForPolicyChangeError):
(WebCore::cannotShowMIMETypeError):
(WebCore::fileDoesNotExistError):
(WebCore::pluginWillHandleLoadError):
(WebCore::downloadCancelledByUserError):
(WebCore::downloadDestinationError):

• Update for type change of 'failingURL' argument to ResourceError().

• platform/network/ResourceErrorBase.h:

(WebCore::ResourceErrorBase::failingURL):

• Change return type from String to URL.

(WebCore::ResourceErrorBase::ResourceErrorBase):

• platform/network/cf/ResourceError.h:

(WebCore::ResourceError::ResourceError):

• Change type of 'failingURL' from String to URL.

• platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::ResourceError):

• Change type of 'failingURL' from String to URL.

(WebCore::ResourceError::platformLazyInit):

• Clean up code and address FIXME by parsing CFURLRef using URL() constructor.

(WebCore::ResourceError::cfError):

• Clean up code and address FIXME after switching type of m_failingURL.

• platform/network/curl/ResourceError.h:

(WebCore::ResourceError::ResourceError):

• Change type of 'failingURL' from String to URL.

• platform/network/mac/ResourceErrorMac.mm:

(WebCore::createNSErrorFromResourceErrorBase):
(WebCore::ResourceError::platformLazyInit):

• Clean up code and address FIXME after switching type of m_failingURL.

• platform/network/soup/ResourceError.h:

(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::timeoutError):

• platform/network/soup/ResourceErrorSoup.cpp:

(WebCore::failingURI):
(WebCore::ResourceError::timeoutError):

• platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::ResourceHandle::timeoutFired):

• Change type of 'failingURL' from String to URL.

• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::didFail):

• Convert failingURL() to String explicitly.
• Also switch to using makeString().

Source/WebKit/win:

• WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::cancelledError):
(WebFrameLoaderClient::blockedError):
(WebFrameLoaderClient::cannotShowURLError):
(WebFrameLoaderClient::interruptedForPolicyChangeError):
(WebFrameLoaderClient::cannotShowMIMETypeError):
(WebFrameLoaderClient::fileDoesNotExistError):
(WebFrameLoaderClient::pluginWillHandleLoadError):
(WebFrameLoaderClient::dispatchDidFailToStartPlugin):
(WebFrameLoaderClient::createJavaAppletWidget):

• WebDownloadCFNet.cpp:

(WebDownload::cancelAuthenticationChallenge):

• WebError.cpp:

(WebError::init):

• Update for type change of 'failingURL' argument to ResourceError().

Source/WebKit2:

• NetworkProcess/Downloads/efl/DownloadSoupErrorsEfl.cpp:

(WebKit::platformDownloadNetworkError):

• NetworkProcess/Downloads/gtk/DownloadSoupErrorsGtk.cpp:

(WebKit::platformDownloadNetworkError):

• NetworkProcess/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::didReceiveResponse):

• NetworkProcess/Downloads/soup/DownloadSoupErrors.h:
• Shared/soup/WebCoreArgumentCodersSoup.cpp:

(IPC::ArgumentCoder<ResourceError>::encodePlatformData):
(IPC::ArgumentCoder<ResourceError>::decodePlatformData):

• UIProcess/API/gtk/WebKitLoaderClient.cpp:

(LoaderClient::didFailProvisionalLoadWithErrorForFrame):
(LoaderClient::didFailLoadWithErrorForFrame):

• UIProcess/API/gtk/WebKitURISchemeRequest.cpp:

(webkit_uri_scheme_request_finish_error):

• WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp:

(WebKit::internalError):

• WebProcess/WebCoreSupport/gtk/WebErrorsGtk.cpp:

(WebKit::internalError):

• Update for type change of 'failingURL' argument to ResourceError().

Dec 24, 2015:

11:25 PM Changeset in webkit [194418] by Alan Bujtas

• 3 edits
  4 adds in trunk

ASSERTION FAILED: x2 >= x1 in WebCore::RenderElement::drawLineForBoxSide
​https://bugs.webkit.org/show_bug.cgi?id=151210

Reviewed by Simon Fraser.

Source/WebCore:

"IntRect outer = snappedIntRect(inner)" explicitly converts inner to LayoutRect first and
returns a snapped IntRect. When inner (after the inflate) overflows LayoutUnit,
the snapped rect might become smaller than the inner rect.

This patch also enables outline painting on subpixel positions.

Tests: fast/borders/hidpi-outline-on-subpixel-position.html

fast/borders/outline-offset-overflow.html

• rendering/RenderElement.cpp:

(WebCore::RenderElement::paintOutline):

LayoutTests:

"IntRect outer = snappedIntRect(inner)" explicitly converts inner to LayoutRect and
returns a snapped IntRect. When inner (after the inflate) overflows LayoutUnit,
the snapped outer rect becomes smaller than the inner rect.

This patch also enables outline painting on subpixel positions.

• fast/borders/hidpi-outline-on-subpixel-position-expected.html: Added.
• fast/borders/hidpi-outline-on-subpixel-position.html: Added.
• fast/borders/outline-offset-overflow-expected.txt: Added.
• fast/borders/outline-offset-overflow.html: Added.

9:37 PM Changeset in webkit [194417] by Simon Fraser

• 11 edits in trunk/Source/WebCore

Use an enum for RenderElement's baseTypeFlags
​https://bugs.webkit.org/show_bug.cgi?id=152553

Reviewed by Zalan Bujtas.

Use an enum, rather than unsigned, for the BaseTypeFlags bit mask.

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::RenderBlock):

• rendering/RenderBlock.h:
• rendering/RenderBox.cpp:

(WebCore::RenderBox::RenderBox):

• rendering/RenderBox.h:
• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::RenderBoxModelObject):

• rendering/RenderBoxModelObject.h:
• rendering/RenderElement.cpp:

(WebCore::RenderElement::RenderElement):

• rendering/RenderElement.h:
• rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::RenderLayerModelObject):

• rendering/RenderLayerModelObject.h:

12:47 PM Changeset in webkit [194416] by Simon Fraser

• 7 edits in trunk

Remove the unused #define _USE_MATH_DEFINES
​https://bugs.webkit.org/show_bug.cgi?id=152034

Reviewed by Tim Horton.

Source/WebCore:

_USE_MATH_DEFINES was added in r123968 but no longer does anything.

• platform/graphics/cg/GraphicsContextCG.cpp:
• platform/graphics/cg/PDFDocumentImage.cpp:
• rendering/mathml/RenderMathMLMenclose.cpp:
• rendering/mathml/RenderMathMLOperator.cpp:

Tools:

Update this test to use piDouble from MathExtras.h, and
std::numeric_limits<>.

• TestWebKitAPI/Tests/WTF/MediaTime.cpp:

2:42 AM Changeset in webkit [194415] by youenn.fablet@crf.canon.fr

• 3 edits in trunk/Tools

Python SCM should be able to retrieve untracked files - Generic changes
​https://bugs.webkit.org/show_bug.cgi?id=152536

Reviewed by Brent Fulgham.

This patch introduces SCM.untracked_files to retrieve a list of untracked files.
No support is yet added to GIT and SVN specific implementations.

• Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM.untracked_files):

• Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

(SCMTest._shared_test_untracked_files):