⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 1, 2016:

10:55 PM Changeset in webkit [194495] by Simon Fraser
  • 5 edits in trunk/Source

Fix the iOS and EFL builds, after an over-eager commit-queue commit.

Source/WebKit/mac:

  • History/WebHistoryItem.mm:

(-[WebHistoryItem initFromDictionaryRepresentation:]):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::restoreViewState):

  • WebProcess/WebPage/efl/WebPageEfl.cpp:

(WebKit::WebPage::restorePageState):

10:06 PM Changeset in webkit [194494] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

Unreviewed, fix copyright dates. It's super annoying when we forget to update these, and I
just forgot to do so in the last commit. Also update the date of the last commit in the
ChangeLog.

  • b3/air/AirIteratedRegisterCoalescing.cpp:
  • b3/air/AirOpcode.opcodes:
  • b3/air/AirTmpWidth.cpp:
  • b3/air/AirTmpWidth.h:
  • ftl/FTLB3Output.cpp:
  • ftl/FTLB3Output.h:
10:03 PM Changeset in webkit [194493] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

FTL B3 should be able to run all of the old V8v7 tests
https://bugs.webkit.org/show_bug.cgi?id=152579

Reviewed by Saam Barati.

Fixes some silly bugs that were preventing us from running all of the old V8v7 tests.

IRC's analysis of when to turn a Move into a Move32 when spilling is based on the premise
that if the dst has a 32-bit def width, then the src must also have a 32-bit def width. But
that doesn't happen if the src is an immediate.

This changes that condition in IRC to use the combined use/def width of both src and dst
rather than being clever. This is great because it's the combined width that determines the
size of the spill slot.

Also added some more debug support to TmpWidth.

This also fixes Air's description of DivDouble; previously it claimed to be a 32-bit
operation. Also implements Output::unsignedToDouble(), since we already had everything we
needed to implement this optimally.

  • b3/air/AirIteratedRegisterCoalescing.cpp:
  • b3/air/AirOpcode.opcodes:
  • b3/air/AirTmpWidth.cpp:

(JSC::B3::Air::TmpWidth::recompute):
(JSC::B3::Air::TmpWidth::Widths::dump):

  • b3/air/AirTmpWidth.h:

(JSC::B3::Air::TmpWidth::Widths::Widths):

  • ftl/FTLB3Output.cpp:

(JSC::FTL::Output::doubleToUInt):
(JSC::FTL::Output::unsignedToDouble):

  • ftl/FTLB3Output.h:

(JSC::FTL::Output::zeroExt):
(JSC::FTL::Output::zeroExtPtr):
(JSC::FTL::Output::intToDouble):
(JSC::FTL::Output::castToInt32):
(JSC::FTL::Output::unsignedToDouble): Deleted.

9:56 PM Changeset in webkit [194492] by Simon Fraser
  • 11 edits in trunk/Source

Fix naming in HistoryItem to refer to scrollPositions
https://bugs.webkit.org/show_bug.cgi?id=152646

Reviewed by Zalan Bujtas.
Source/WebCore:

HistoryItem stores a scrollPosition, so call it that.

No behavior change.

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::HistoryItem):
(WebCore::HistoryItem::scrollPosition):
(WebCore::HistoryItem::setScrollPosition):
(WebCore::HistoryItem::clearScrollPosition):
(WebCore::HistoryItem::scrollPoint): Deleted.
(WebCore::HistoryItem::setScrollPoint): Deleted.
(WebCore::HistoryItem::clearScrollPoint): Deleted.

  • history/HistoryItem.h:
  • loader/HistoryController.cpp:

(WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
(WebCore::HistoryController::clearScrollPositionAndViewState):
(WebCore::HistoryController::restoreScrollPositionAndViewState):
(WebCore::HistoryController::updateForClientRedirect):

Source/WebKit/mac:

HistoryItem stores a scrollPosition, so call it that.

  • History/WebHistoryItem.mm:

(-[WebHistoryItem scrollPoint]):

Source/WebKit2:

HistoryItem stores a scrollPosition, so call it that.

No behavior change.

  • Shared/SessionState.cpp:

(WebKit::FrameState::encode):
(WebKit::FrameState::decode):

  • Shared/SessionState.h:
  • UIProcess/mac/LegacySessionStateCoding.cpp:

(WebKit::encodeFrameStateNode):
(WebKit::decodeBackForwardTreeNode):

  • WebProcess/WebCoreSupport/SessionStateConversion.cpp:

(WebKit::toFrameState):
(WebKit::applyFrameState):

9:53 PM Changeset in webkit [194491] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: shadow visual sidebar section can be confused with the box shadow section
https://bugs.webkit.org/show_bug.cgi?id=148107

Patch by Devin Rousso <Devin Rousso> on 2016-01-01
Reviewed by Brian Burg.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Views/VisualStyleDetailsPanel.js:

(WebInspector.VisualStyleDetailsPanel):
Changed title of "Shadow" sub-section in "Background" to "Box Shadow".

9:51 PM Changeset in webkit [194490] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: The Computed Styles Properties section shows warning icons and doesn't update if collapsed
https://bugs.webkit.org/show_bug.cgi?id=152609

Patch by Devin Rousso <Devin Rousso> on 2016-01-01
Reviewed by Brian Burg.

  • UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded):
If the CodeMirror instance is read-only, don't add any warning icons.

  • UserInterface/Views/ComputedStyleDetailsPanel.js:

(WebInspector.ComputedStyleDetailsPanel):
(WebInspector.ComputedStyleDetailsPanel.prototype._handleCollapsedStateChanged):
The properties text editor will now refresh whenever the details section
becomes un-collapsed.

  • UserInterface/Views/DetailsSection.js:

(WebInspector.DetailsSection.prototype.set collapsed):
Now fires an event with the current collapsed state as data.

9:50 PM Changeset in webkit [194489] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Simple line layout: Add support for toggling simple line layout from command line.
https://bugs.webkit.org/show_bug.cgi?id=152636

Reviewed by Simon Fraser.

No change in functionality.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseForWithReason):
(WebCore::SimpleLineLayout::toggleSimpleLineLayout):

9:48 PM Changeset in webkit [194488] by beidson@apple.com
  • 8 edits in trunk

Modern IDB: storage/indexeddb/database-deletepending-flag.html fails.
https://bugs.webkit.org/show_bug.cgi?id=152600

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (At least one failing test now passes, and at least 2 crashing tests now timeout).

  • Modules/indexeddb/server/IDBBackingStore.h:
  • Modules/indexeddb/server/MemoryIDBBackingStore.cpp:

(WebCore::IDBServer::MemoryIDBBackingStore::deleteBackingStore):

  • Modules/indexeddb/server/MemoryIDBBackingStore.h:
  • Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::performCurrentDeleteOperation):
(WebCore::IDBServer::UniqueIDBDatabase::deleteBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::didDeleteBackingStore):

  • Modules/indexeddb/server/UniqueIDBDatabase.h:

LayoutTests:

  • platform/mac-wk1/TestExpectations:
8:45 PM Changeset in webkit [194487] by Simon Fraser
  • 17 edits
    6 adds in trunk

Fix reload and programmatic scrolling in RTL documents
https://bugs.webkit.org/show_bug.cgi?id=152639

Reviewed by Zalan Bujtas.
Source/WebCore:

Reloading a left-scrolled RTL document would cause the content to appear
at an odd offset, and programmatic sideways scrolls in RTL documents also
jumped to the wrong location.

Fix by resolving offset/position confusion in ScrollableArea::scrollPositionChanged()
and the scrolling tree.

ScrollableArea::scrollPositionChanged() was erroneously passing a scrollPosition
to setScrollOffset().

ScrollingTreeFrameScrollingNode* were confused about offsets and positions. It
turns out that the layer position is just -scrollPosition, but minimumScrollPosition()
and maximumScrollPosition() need fixing to return positions, not offsets.

ScrollingTreeFrameScrollingNode::viewToContentsOffset() was also doing incorrect
math with scrollOrigin, which was detected by a failing test.

Add more logging to the Scrolling channel.

Tests: fast/scrolling/programmatic-document-rtl-scroll.html

fast/scrolling/programmatic-document-rtl-scrollIntoView.html
fast/scrolling/scroll-position-on-reload-rtl.html

  • page/FrameView.cpp:

(WebCore::FrameView::requestScrollPositionUpdate):

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::shouldHandleWheelEventSynchronously):

  • page/scrolling/ScrollingTreeFrameScrollingNode.cpp:

(WebCore::ScrollingTreeFrameScrollingNode::scrollBy):
(WebCore::ScrollingTreeFrameScrollingNode::viewToContentsOffset):

  • page/scrolling/ScrollingTreeFrameScrollingNode.h:
  • page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.mm:

(WebCore::ScrollingTreeFrameScrollingNodeIOS::scrollPosition):
(WebCore::ScrollingTreeFrameScrollingNodeIOS::setScrollLayerPosition):
(WebCore::ScrollingTreeFrameScrollingNodeIOS::updateChildNodesAfterScroll):
(WebCore::ScrollingTreeFrameScrollingNodeIOS::minimumScrollPosition):
(WebCore::ScrollingTreeFrameScrollingNodeIOS::maximumScrollPosition):

  • page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:

(WebCore::ScrollingTreeFrameScrollingNodeMac::immediateScrollBy):
(WebCore::ScrollingTreeFrameScrollingNodeMac::scrollPosition):
(WebCore::ScrollingTreeFrameScrollingNodeMac::setScrollPosition):
(WebCore::ScrollingTreeFrameScrollingNodeMac::setScrollLayerPosition):
(WebCore::ScrollingTreeFrameScrollingNodeMac::minimumScrollPosition):
(WebCore::ScrollingTreeFrameScrollingNodeMac::maximumScrollPosition):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::setScrollOffset):
(WebCore::ScrollView::scrollTo):
(WebCore::ScrollView::setScrollPosition):
(WebCore::ScrollView::updateScrollbars):

  • platform/ScrollView.h:
  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::scrollPositionChanged):
(WebCore::ScrollableArea::setScrollOffsetFromAnimation):
(WebCore::ScrollableArea::scrollPositionFromOffset):
(WebCore::ScrollableArea::scrollOffsetFromPosition):

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::scrollPositionFromOffset):
(WebCore::ScrollableArea::scrollOffsetFromPosition):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::setScrollOffset):

  • rendering/RenderListBox.h:

Source/WebKit2:

Reloading a left-scrolled RTL document would cause the content to appear
at an odd offset, and programmatic sideways scrolls in RTL documents also
jumped to the wrong location.

Fix by resolving offset/position confusion in ScrollableArea::scrollPositionChanged()
and the scrolling tree.

ScrollableArea::scrollPositionChanged() was erroneously passing a scrollPosition
to setScrollOffset().

ScrollingTreeFrameScrollingNode* were confused about offsets and positions. It
turns out that the layer position is just -scrollPosition, but minimumScrollPosition()
and maximumScrollPosition() need fixing to return positions, not offsets.

ScrollingTreeFrameScrollingNode::viewToContentsOffset() was also doing incorrect
math with scrollOrigin, which was detected by a failing test.

Add more logging to the Scrolling channel.

  • WebProcess/Plugins/PDF/DeprecatedPDFPlugin.h:
  • WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm:

(WebKit::PDFPlugin::setScrollOffset):

LayoutTests:

New tests for programmatic scrolling (2 kinds!) in RTL documents, and
reloading a scrolled RTL document.

  • fast/scrolling/programmatic-document-rtl-scroll-expected.html: Added.
  • fast/scrolling/programmatic-document-rtl-scroll.html: Added.
  • fast/scrolling/programmatic-document-rtl-scrollIntoView-expected.txt: Added.
  • fast/scrolling/programmatic-document-rtl-scrollIntoView.html: Added.
  • fast/scrolling/scroll-position-on-reload-rtl-expected.txt: Added.
  • fast/scrolling/scroll-position-on-reload-rtl.html: Added.
8:44 PM Changeset in webkit [194486] by Simon Fraser
  • 3 edits
    2 adds in trunk

REGRESSION (r194448): Scrolling overflow:scroll goes too far
https://bugs.webkit.org/show_bug.cgi?id=152645

Reviewed by Zalan Bujtas.

Source/WebCore:

Fix a bug introduced in r194448: use the scrollPosition, not the scrollOrigin
to compute the overhang amount.

Test: fast/scrolling/overflow-scroll-past-max.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::overhangAmount):

LayoutTests:

Test that scrolls and overflow div with wheel events, then checks that it has
not passed the max scroll offset.

  • fast/scrolling/overflow-scroll-past-max-expected.txt: Added.
  • fast/scrolling/overflow-scroll-past-max.html: Added.
6:41 PM Changeset in webkit [194485] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[WebGL] Blacklisted OpenGL contexts are not safe to use
https://bugs.webkit.org/show_bug.cgi?id=152513
<rdar://problem/23127838>

Reviewed by Zalan Bujtas.

When the GPU has blacklisted an OpenGL context, it is not safe to use -- even to
attempt to release GL resources. Instead, our only correct behavior is to terminate
the WebProcess.

  • platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::checkGPUStatusIfNecessary): If the context was lost
because the GPU blacklisted it, terminate the process.

4:33 PM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro
(diff)
4:26 PM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro
(diff)
4:21 PM Changeset in webkit [194484] by Michael Catanzaro
  • 2 edits in trunk/LayoutTests

[GTK] Several IndexedDB tests failing

Unreviewed gardening.

  • platform/gtk/TestExpectations:
4:03 PM Changeset in webkit [194483] by Michael Catanzaro
  • 2 edits in trunk/LayoutTests

[GTK] http/tests/misc/detached-frame-console.html is crashing

Unreviewed gardening.

  • platform/gtk/TestExpectations:
3:51 PM Changeset in webkit [194482] by Michael Catanzaro
  • 2 edits in trunk/LayoutTests

[GTK] http/tests/media/clearkey/clear-key-hls-aes128.html is crashing

Unreviewed gardening.

  • platform/gtk/TestExpectations:
3:43 PM Changeset in webkit [194481] by Michael Catanzaro
  • 2 edits in trunk/LayoutTests

[GTK] Expect missing results for CSS table anonymous objects tests

Unreviewed gardening.

  • platform/gtk/TestExpectations:
1:22 PM Changeset in webkit [194480] by Michael Catanzaro
  • 6 edits
    1 add in trunk

[SOUP] REGRESSION(r192761): Broke resource URIs for applications that use g_resource_load in a web extension
https://bugs.webkit.org/show_bug.cgi?id=152634

Reviewed by Carlos Garcia Campos.

Source/WebKit2:

Load GResource URIs locally, not in the network process. Applications expect calling
g_resource_load in a web extension to make it possible to load resource URIs, but that
doesn't work now that the network process is in use. Loading them locally solves this.

  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoad):

Tools:

  • TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:

(testLoadFromGResource): Added test.
(beforeAll):

  • TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:

(registerGResource): Added.
(webkit_web_extension_initialize_with_user_data): Load the test gresource.

  • TestWebKitAPI/Tests/WebKit2Gtk/resources/boring.html: Added.
  • TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Add an HTML file.
8:30 AM Changeset in webkit [194479] by jeffm@apple.com
  • 29 edits in trunk

Update user-visible copyright strings to include 2016
https://bugs.webkit.org/show_bug.cgi?id=152531

Reviewed by Alexey Proskuryakov.

Source/JavaScriptCore:

  • Info.plist:

Source/WebCore:

  • Info.plist:

Source/WebKit/mac:

  • Info.plist:

Source/WebKit2:

  • DatabaseProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService.Development/Info.plist:
  • DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService/Info.plist:
  • Info.plist:
  • NetworkProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info-OSX.plist:
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info-iOS.plist:
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX-10.9-10.10.plist:
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX.plist:
  • NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-iOS.plist:
  • PluginProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64-10.9-10.10.Info.plist:
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist:
  • PluginProcess/EntryPoint/mac/XPCService/PluginService.Development/Info.plist:
  • WebProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-OSX.plist:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info-iOS.plist:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX-10.9-10.10.plist:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist:

WebKitLibraries:

  • win/tools/scripts/COPYRIGHT-END-YEAR:

Dec 31, 2015:

11:53 PM Changeset in webkit [194478] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Change RenderLayer::scrollTo() to take a ScrollPosition
https://bugs.webkit.org/show_bug.cgi?id=152633

Reviewed by Zalan Bujtas.

RenderLayer::scrollTo() took x and y offsets. Change this to take a position,
like ScrollView::scrollTo() and fix the one caller.

Preserve the dubious behavior of the adjustForIOSCaretWhenScrolling() code by converting
to and from offsets, even though testing suggests that this code can just be removed,
even with an extra wide caret for testing.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::setScrollOffset):

  • rendering/RenderLayer.h:
7:17 PM Changeset in webkit [194477] by Simon Fraser
  • 7 edits in trunk/Source

Rename documentScrollOffsetRelativeTo* functions
https://bugs.webkit.org/show_bug.cgi?id=152632

Reviewed by Zalan Bujtas.

ScrollView::documentScrollOffsetRelativeTo* functions return scroll positions,
not offsets, so rename them and fix their return types, and fix callers. Make
their code more similar.

Source/WebCore:

  • platform/ScrollView.cpp:

(WebCore::ScrollView::documentScrollPositionRelativeToViewOrigin):
(WebCore::ScrollView::documentScrollPositionRelativeToScrollableAreaOrigin):
(WebCore::ScrollView::viewToContents):
(WebCore::ScrollView::contentsToView):
(WebCore::ScrollView::documentScrollOffsetRelativeToViewOrigin): Deleted.
(WebCore::ScrollView::documentScrollOffsetRelativeToScrollableAreaOrigin): Deleted.

  • platform/ScrollView.h:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::scrollRectToVisible):

Source/WebKit2:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::determinePrimarySnapshottedPlugIn):
(WebKit::WebPage::plugInIntersectsSearchRect):

7:16 PM Changeset in webkit [194476] by Simon Fraser
  • 17 edits in trunk

[iOS WK2] Fix incorrect scrollPosition handling
https://bugs.webkit.org/show_bug.cgi?id=152630

Reviewed by Zalan Bujtas.
Source/WebCore:

WebPage::updateVisibleContentRects() was setting the ScrollView's scroll position
to a scrollOffset, which was counteracted by ScrollView::unobscuredContentRect()
adding the scrollOrigin to the scrollPosition, which resulted in the correct
rects, but an incorrect scrollPosition. Fix.

  • platform/ios/ScrollViewIOS.mm:

(WebCore::ScrollView::unobscuredContentRect):

Source/WebKit2:

WebPage::updateVisibleContentRects() was setting the ScrollView's scroll position
to a scrollOffset, which was counteracted by ScrollView::unobscuredContentRect()
adding the scrollOrigin to the scrollPosition, which resulted in the correct
rects, but an incorrect scrollPosition. Fix.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::updateVisibleContentRects):

LayoutTests:

These tests now load with a 0,0 scroll position, so don't dump out the "scrolled to" text,
which matches Mac behavior.

  • platform/ios-simulator-wk2/fast/multicol/pagination/BottomToTop-bt-expected.txt:
  • platform/ios-simulator-wk2/fast/multicol/pagination/BottomToTop-lr-expected.txt:
  • platform/ios-simulator-wk2/fast/multicol/pagination/BottomToTop-rl-expected.txt:
  • platform/ios-simulator-wk2/fast/multicol/pagination/BottomToTop-tb-expected.txt:
  • platform/ios-simulator-wk2/fast/multicol/pagination/RightToLeft-bt-expected.txt:
  • platform/ios-simulator-wk2/fast/multicol/pagination/RightToLeft-lr-expected.txt:
  • platform/ios-simulator-wk2/fast/multicol/pagination/RightToLeft-rl-dynamic-expected.txt:
  • platform/ios-simulator-wk2/fast/multicol/pagination/RightToLeft-rl-expected.txt:
  • platform/ios-simulator-wk2/fast/multicol/pagination/RightToLeft-tb-expected.txt:
  • platform/ios-simulator-wk2/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
  • platform/ios-simulator-wk2/fast/multicol/vertical-rl/column-rules-expected.txt:
  • platform/ios-simulator-wk2/fast/multicol/vertical-rl/float-paginate-complex-expected.txt:
5:25 PM Changeset in webkit [194475] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

Fix typo in FIXME comment

  • dom/make_event_factory.pl:

(generateImplementation): FIXEME => FIXME.

4:42 PM Changeset in webkit [194474] by Michael Catanzaro
  • 2 edits in trunk/Source/WebKit2

Unreviewed, fix a log message

  • WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::didReceiveResponse):

4:19 PM Changeset in webkit [194473] by ddkilzer@apple.com
  • 3 edits in trunk/Tools

REGRESSION (r194470): Fix warnings uncovered by migrating to WTF_MOVE
<https://bugs.webkit.org/show_bug.cgi?id=152601>

Ignore unknown pragmas on older clangs. Fixes the following
build failure:

Tools/TestWebKitAPI/Tests/WTF/NakedPtr.cpp:184:34: error: unknown warning group '-Wself-move', ignored [-Werror,-Wunknown-pragmas]
#pragma clang diagnostic ignored "-Wself-move"


1 error generated.

  • TestWebKitAPI/Tests/WTF/NakedPtr.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WTF/RefPtr.cpp:

(TestWebKitAPI::TEST):

3:49 PM Changeset in webkit [194472] by ddkilzer@apple.com
  • 24 edits in trunk/Source

Stop using USE(CFNETWORK) path on iOS
Source/WebCore:

https://bugs.webkit.org/show_bug.cgi?id=142540

Step 1/2: Do everything but turn off USE(CFNETWORK) internally.

Original patch by Antti Koivisto <Antti Koivisto> on 2015-03-10
Reviewed by Daniel Bates.

Unify OS X and iOS code paths.

This patch just fixes the NSURLConnection code path on iOS. It
doesn't yet delete any unnecessary code.

Changes covered by most existing tests.

  • loader/DocumentLoader.h:
  • loader/ResourceLoader.cpp:
  • loader/ResourceLoader.h:
  • loader/mac/DocumentLoaderMac.cpp:
  • Update for iOS to use NSURLConnection loader.
  • page/mac/PageMac.mm:

(WebCore::Page::platformInitialize): Always use the correct
runloop on iOS regardless of which thread this was called on.
(WebCore::Page::addSchedulePair): Update for iOS to use
NSURLConnection loader.
(WebCore::Page::removeSchedulePair): Ditto.

  • platform/ios/wak/WebCoreThread.h:

(WebThreadRunLoop): No longer needs to be exported.
(WebThreadNSRunLoop): Export for WebKitLegacy.

  • platform/network/ios/QuickLook.mm: Fix header order.

(WebQuickLookHandleAsDelegate): Make delegate objects implement
WebCoreResourceLoaderDelegate protocol. This unifies the
-clearHandle and -detachHandle methods that were used on iOS and
OS X, respectively.
(-[WebQuickLookHandleAsDelegate clearHandle]): Deleted.
(-[WebQuickLookHandleAsDelegate detachHandle]): Renamed from
-clearHandle.
(WebResourceLoaderQuickLookDelegate): Make delegate objects
implement WebCoreResourceLoaderDelegate protocol.
(-[WebResourceLoaderQuickLookDelegate clearHandle]): Deleted.
(-[WebResourceLoaderQuickLookDelegate detachHandle]): Renamed from
-clearHandle.
(WebCore::QuickLookHandle::~QuickLookHandle): Call
-detachHandle instead of -clearHandle.

  • platform/network/mac/ResourceHandleMac.mm:
  • Update for iOS to use NSURLConnection loader.
  • platform/network/mac/WebCoreResourceHandleAsDelegate.h:

(WebCoreResourceLoaderDelegate): Define new protocol.

  • platform/network/mac/WebCoreResourceHandleAsDelegate.mm:

(-[WebCoreResourceHandleAsDelegate detachHandle]): Gratuitous
nullptr fix.

  • platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.h:

(WebCoreResourceHandleAsOperationQueueDelegate): Implement
WebCoreResourceLoaderDelegate protocol.

  • platform/spi/cocoa/NSURLDownloadSPI.h: Declare more

NSURDownload SPI to clean up other source files and make
source compile on iOS with NSURLConnection code path.

Source/WebKit/mac:

https://bugs.webkit.org/show_bug.cgi?id=142540

Step 1/2: Do everything but turn off USE(CFNETWORK) internally.

Original patch by Antti Koivisto <Antti Koivisto> on 2015-03-10
Reviewed by Daniel Bates.

  • Misc/WebDownload.h: Add header guard to make

NSURLDownloadSPI.h work when pre-declaring NSURLDownload object.

  • Misc/WebKitVersionChecks.h: Define

WEBKIT_FIRST_VERSION_WITH_LOADING_DURING_COMMON_RUNLOOP_MODES
for iOS.

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]): Use
the correct runloop on iOS.

  • WebView/WebViewPrivate.h:

(-[WebView(WebPendingPublic) scheduleInRunLoop:forMode:]):
(-[WebView(WebPendingPublic) unscheduleFromRunLoop:forMode:]):

  • These are available on iOS now.

Source/WebKit2:

https://bugs.webkit.org/show_bug.cgi?id=142540

Step 1/2: Do everything but turn off USE(CFNETWORK) internally.

Original patch by Antti Koivisto <Antti Koivisto> on 2015-03-10
Reviewed by Daniel Bates.

  • NetworkProcess/Downloads/ios/DownloadIOS.mm: This is now the

USE(CFNETWORK) && !USE(NETWORK_SESSION) code path.

  • NetworkProcess/Downloads/mac/DownloadMac.mm: This is now the

!USE(CFNETWORK) && !USE(NETWORK_SESSION) code path. Make use of
NSURLDownloadSPI.h. Ignore a deprecated delcaration warning now
that we're using actual header declarations internally.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess): Update for
iOS to use NSURLConnection loader.

Source/WTF:

<https://webkit.org/b/142540>

Step 1/2: Do everything but turn off USE(CFNETWORK) internally.

Original patch by Antti Koivisto <Antti Koivisto> on 2015-03-10
Reviewed by Daniel Bates.

  • wtf/SchedulePair.h: Update macros to match WebCore.
2:51 PM Changeset in webkit [194471] by aestes@apple.com
  • 3 edits in trunk/Tools

Update the style checker to advise using WTFMove() instead of WTF::move()
https://bugs.webkit.org/show_bug.cgi?id=152601

Reviewed by Daniel Bates.

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_wtf_move):

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_wtf_move):

2:49 PM Changeset in webkit [194470] by aestes@apple.com
  • 12 edits in trunk

Fix warnings uncovered by migrating to WTF_MOVE
https://bugs.webkit.org/show_bug.cgi?id=152601

Reviewed by Daniel Bates.

Source/JavaScriptCore:

  • create_regex_tables: Moving a return value prevented copy elision.
  • ftl/FTLUnwindInfo.cpp:

(JSC::FTL::parseUnwindInfo): Ditto.

  • replay/EncodedValue.h: Ditto.

Source/WebCore:

  • Modules/encryptedmedia/MediaKeys.cpp:

(WebCore::MediaKeys::createSession): Moving a return value prevented copy elision.

Source/WebKit2:

  • UIProcess/API/APIUIClient.h:

(API::UIClient::actionsForElement): Moving a return value passed to the function by value is redundant, since it
will be implicitly moved in this case.

  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::UIClient::actionsForElement): Ditto.

Tools:

Ignored -Wself-move warnings in these two API tests. It's useful to test that these classes properly handle
self-move, even if doing so would trigger a warning.

  • TestWebKitAPI/Tests/WTF/NakedPtr.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WTF/RefPtr.cpp:

(TestWebKitAPI::TEST):

2:47 PM Changeset in webkit [194469] by aestes@apple.com
  • 2 edits in trunk/Source/WTF

Rename WTF_MOVE to WTFMove
https://bugs.webkit.org/show_bug.cgi?id=152601

Reviewed by Daniel Bates.

Our coding style guidelines say that macros that expand to function calls should be named like functions,
so WTFMove() is a more appropriate name.

  • wtf/StdLibExtras.h:
1:29 PM Changeset in webkit [194468] by beidson@apple.com
  • 3 edits in trunk/Source/WebCore

Review feedback followup for:
Modern IDB: Only fire blocked events after all open connections have handled their versionchange events.
https://bugs.webkit.org/show_bug.cgi?id=152593

Suggested by Andy Estes.

  • Modules/indexeddb/client/IDBDatabaseImpl.cpp:

(WebCore::IDBClient::IDBDatabase::dispatchEvent): Use downcast instead of static_cast.

Add traits to support downcast<>:

  • Modules/indexeddb/client/IDBVersionChangeEventImpl.h:

(isType):

1:09 PM Changeset in webkit [194467] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

Move decoration context setup calls to InlineTextBox::paintDecoration.
https://bugs.webkit.org/show_bug.cgi?id=152622

Reviewed by Simon Fraser.

No change in functionality.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintDecoration):

  • rendering/InlineTextBox.h:
12:07 PM Changeset in webkit [194466] by Simon Fraser
  • 16 edits in trunk/Source/WebCore

More scrollOffset/scrollPosition disambiguation, in RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=152617

Reviewed by Zalan Bujtas.

Change RenderLayer's m_scrollOffset to be m_scrollPosition, since it stores
scroll positions (negative in RTL overflow). scrollOffset() was accurately
named already, but fix the return type, and remove the unnecessary scrollXOffset()/
scrollYOffset() variants, fixing callers to use .x() and .y().

scrollToOffset() was also accurately named, but fix its argument.

Fix functions related to saving scroll positions on Element to refer to scroll positions.

No behavior change.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::scrollTo):

  • dom/Element.cpp:

(WebCore::Element::removedFrom):
(WebCore::Element::savedLayerScrollPosition):
(WebCore::Element::setSavedLayerScrollPosition):
(WebCore::Element::savedLayerScrollOffset): Deleted.
(WebCore::Element::setSavedLayerScrollOffset): Deleted.

  • dom/Element.h:
  • dom/ElementRareData.h:

(WebCore::ElementRareData::savedLayerScrollPosition):
(WebCore::ElementRareData::setSavedLayerScrollPosition):
(WebCore::ElementRareData::savedLayerScrollOffset): Deleted.
(WebCore::ElementRareData::setSavedLayerScrollOffset): Deleted.

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::forwardEvent):

  • platform/graphics/IntPoint.h:

(WebCore::IntPoint::isZero):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::baselinePosition):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::scrollLeft):
(WebCore::RenderBox::scrollTop):
(WebCore::RenderBox::scrolledContentOffset):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::~RenderLayer):
(WebCore::RenderLayer::scrollByRecursively):
(WebCore::RenderLayer::clampScrollOffset):
(WebCore::RenderLayer::scrollToOffset):
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::scrollPosition):
(WebCore::RenderLayer::maximumScrollPosition):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGeometry):

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::start):
(WebCore::RenderMarquee::timerFired):

  • rendering/RenderTreeAsText.cpp:

(WebCore::write):

11:57 AM Changeset in webkit [194465] by Alan Bujtas
  • 4 edits
    2 adds in trunk

text-decoration: line-through is mispositioned when text has overline/underline too.
https://bugs.webkit.org/show_bug.cgi?id=152619

Reviewed by Simon Fraser.

Line-through painting was mistakenly calling drawLineForText with overline/underline positioning.

Source/WebCore:

Test: fast/css3-text/css3-text-decoration/text-decoration-line-through-mispositioned.html

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration): Deleted.

  • rendering/TextDecorationPainter.cpp:

(WebCore::TextDecorationPainter::paintTextDecoration):

LayoutTests:

  • fast/css3-text/css3-text-decoration/text-decoration-line-through-mispositioned-expected.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-line-through-mispositioned.html: Added.
11:53 AM Changeset in webkit [194464] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] The install-dependencies script has a syntax error
https://bugs.webkit.org/show_bug.cgi?id=152613

Patch by Martin Robinson <mrobinson@igalia.com> on 2015-12-31
Reviewed by Michael Catanzaro.

  • gtk/install-dependencies: Add the missing 'then.'
11:35 AM Changeset in webkit [194463] by Simon Fraser
  • 10 edits in trunk/Source

Clarify that scrollPositionChangedViaPlatformWidget takes offsets
https://bugs.webkit.org/show_bug.cgi?id=152606

Reviewed by Zalan Bujtas.

scrollPositionChangedViaPlatformWidget actually gets scroll offsets, since the
values we get from AppKit are zero-based, so rename to scrollOffsetChangedViaPlatformWidget().

Change ScrollableArea's setScrollPosition() and requestScrollPositionUpdate() to take
ScrollPositions.

Add a FIXME noting that willRevealEdge events are probably broken in RTL documents.

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::sendWillRevealEdgeEventsIfNeeded):

  • page/FrameView.cpp:

(WebCore::FrameView::setScrollPosition):
(WebCore::FrameView::scrollOffsetChangedViaPlatformWidgetImpl):
(WebCore::FrameView::scrollPositionChanged):
(WebCore::FrameView::requestScrollPositionUpdate):
(WebCore::FrameView::scrollPositionChangedViaPlatformWidgetImpl): Deleted.

  • page/FrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::scrollOffsetChangedViaPlatformWidget):
(WebCore::ScrollView::handleDeferredScrollUpdateAfterContentSizeChange):
(WebCore::ScrollView::scrollTo):
(WebCore::ScrollView::setScrollPosition):
(WebCore::ScrollView::scrollPositionChangedViaPlatformWidget): Deleted.

  • platform/ScrollView.h:

(WebCore::ScrollView::scrollOffsetChangedViaPlatformWidgetImpl):
(WebCore::ScrollView::scrollPositionChangedViaPlatformWidgetImpl): Deleted.

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::notifyScrollPositionChanged):

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::requestScrollPositionUpdate):

Source/WebKit/mac:

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _frameOrBoundsChanged]):

11:33 AM Changeset in webkit [194462] by Alan Bujtas
  • 3 edits
    2 adds in trunk

Simple line layout: Text with stroke width is not positioned correctly.
https://bugs.webkit.org/show_bug.cgi?id=152614

Reviewed by Simon Fraser.

Visual overflow should not affect text position.

Source/WebCore:

Test: fast/text/simple-line-layout-text-position-with-stroke.html

  • rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::paintFlow):

LayoutTests:

  • fast/text/simple-line-layout-text-position-with-stroke-expected.html: Added.
  • fast/text/simple-line-layout-text-position-with-stroke.html: Added.
11:27 AM Changeset in webkit [194461] by Alan Bujtas
  • 3 edits
    2 adds in trunk

Simple line layout: Nested block with pseudo first-line parent should bail out of simple line layout.
https://bugs.webkit.org/show_bug.cgi?id=152599

Reviewed by Simon Fraser.

We should bail out of simple line layout if any of the ancestors have pseudo first-line style.
(see RenderBlock::firstLineBlock())

Source/WebCore:

Test: fast/block/line-layout/first-line-should-bail-out-of-simple-line-layout.html

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseForWithReason):

LayoutTests:

  • fast/block/line-layout/first-line-should-bail-out-of-simple-line-layout-expected.html: Added.
  • fast/block/line-layout/first-line-should-bail-out-of-simple-line-layout.html: Added.
11:17 AM Changeset in webkit [194460] by Matt Baker
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: "No Filter Results" message overlaps Debugger sidebar sections
https://bugs.webkit.org/show_bug.cgi?id=150608

Reviewed by Brian Burg.

  • UserInterface/Views/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel.showResourcesWithIssuesOnlyFilterFunction):
Style cleanup.
(WebInspector.DebuggerSidebarPanel):
Add breakpoints tree to the details section before adding Global Breakpoint
elements, since adding them will trigger filtering.
(WebInspector.DebuggerSidebarPanel.prototype._treeSelectionDidChange):
Simplified selection management between the various tree outlines.
(WebInspector.DebuggerSidebarPanel.prototype._updatePauseReasonSection):
Style cleanup.
(WebInspector.DebuggerSidebarPanel.prototype.get hasSelectedElement): Deleted.
Defer to the base class implementation.
(WebInspector.DebuggerSidebarPanel.prototype._treeSelectionDidChange.deselectCallStackContentTreeElements): Deleted.
(WebInspector.DebuggerSidebarPanel.prototype._treeSelectionDidChange.deselectBreakpointContentTreeElements): Deleted.
(WebInspector.DebuggerSidebarPanel.prototype._treeSelectionDidChange.deselectPauseReasonContentTreeElements): Deleted.
These are no longer needed, since the list of visible tree elements list can be used
to manage tree element selection is a more general way.

  • UserInterface/Views/NavigationSidebarPanel.css:

Empty content placeholders are now inserted into the DOM as a sibling of the
tree that was filtered. As such, they can be a child of a details section, or
the sidebar's content element.
(.sidebar > .panel.navigation > .content .empty-content-placeholder):
Styles for all empty content placeholders.
(.sidebar > .panel.navigation > .content > .empty-content-placeholder):
Styles for empty content placeholders that fill the sidebar's content element.
(.sidebar > .panel.navigation > .content .message):
Styles for all empty content placeholders.
(.sidebar > .panel.navigation > .empty-content-placeholder): Deleted.
(.sidebar > .panel.navigation > .empty-content-placeholder > .message): Deleted.

  • UserInterface/Views/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel):
Track the tree outline which currently has a selection.
Manage a map of content placeholders
(WebInspector.NavigationSidebarPanel.prototype.set contentTreeOutline):
(WebInspector.NavigationSidebarPanel.prototype.get hasSelectedElement):
Check all visible content trees for a selected element.
(WebInspector.NavigationSidebarPanel.prototype.createContentTreeOutline):
(WebInspector.NavigationSidebarPanel.prototype.treeElementForRepresentedObject):
Check all visible content trees for the represented object.
(WebInspector.NavigationSidebarPanel.prototype.showEmptyContentPlaceholder):
(WebInspector.NavigationSidebarPanel.prototype.hideEmptyContentPlaceholder):
(WebInspector.NavigationSidebarPanel.prototype.updateEmptyContentPlaceholder):
No sidebars currently have more than one filterable content tree outline, but in
the future we will want to support this. Empty content placeholder visibility
is now done per tree outline.
(WebInspector.NavigationSidebarPanel.prototype.show):
Focus the tree outline that most recently had the selection, or the
first tree outline in the visible tree list, if it exists.
(WebInspector.NavigationSidebarPanel.prototype._checkForEmptyFilterResults.checkTreeOutlineForEmptyFilterResults):
Tree is considered filtered if no visible filterable tree elements are found.
(WebInspector.NavigationSidebarPanel.prototype._checkForEmptyFilterResults):
Check all visible trees that support filtering.
(WebInspector.NavigationSidebarPanel.prototype._updateFilter):
Support for filtering multiple content trees.
(WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
Check if the element's tree outline supports filtering, before applying filters.
(WebInspector.NavigationSidebarPanel.prototype._treeSelectionDidChange):
Update the selected tree outline.
(WebInspector.NavigationSidebarPanel.prototype._createEmptyContentPlaceholderIfNeeded):
Create a new empty content placeholder element for the tree.
(WebInspector.NavigationSidebarPanel.prototype.get contentTreeOutlineElement): Deleted.
No longer used.

  • UserInterface/Views/TimelineSidebarPanel.js:

(WebInspector.TimelineSidebarPanel.prototype.get hasSelectedElement): Deleted.
Defer to the base class implementation.

11:07 AM WebKitGTK/Gardening/Calendar edited by Martin Robinson
(diff)
11:05 AM Changeset in webkit [194459] by Martin Robinson
  • 2 edits in trunk/LayoutTests

Mark some tests as failing on WebKitGTK+.

Unreviewed gardening.

  • platform/gtk/TestExpectations:
10:50 AM Changeset in webkit [194458] by Michael Catanzaro
  • 2 edits in trunk

[GTK][CMake] Do not override default values of build options with the default value
https://bugs.webkit.org/show_bug.cgi?id=152615

Reviewed by Martin Robinson.

Override the default value of build options only when the default value for the GTK+ port
is actually different than the default value in WebKitFeatures.cmake. This way we don't
accidentally override changes to default values in WebKitFeatures.cmake. We should use the
values in WebKitFeatures.cmake except when we make an active choice to do otherwise.

  • Source/cmake/OptionsGTK.cmake:
10:50 AM Changeset in webkit [194457] by Simon Fraser
  • 6 edits in trunk/Source/WebCore

Change ScrollView::scrollTo() to take a ScrollPosition
https://bugs.webkit.org/show_bug.cgi?id=152607

Reviewed by Zalan Bujtas.

Make it more explicit that ScrollView::scrollTo() takes a ScrollPosition, and
change the name and type of the m_scrollOffset member variable.

  • page/FrameView.cpp:

(WebCore::FrameView::scrollTo):
(WebCore::FrameView::wheelEvent):

  • page/FrameView.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::unobscuredContentRectInternal):
(WebCore::ScrollView::setScrollOffset):
(WebCore::ScrollView::scrollTo):

  • platform/ScrollView.h:
10:50 AM Changeset in webkit [194456] by Michael Catanzaro
  • 3 edits in trunk

[CMake] Add error checking to WEBKIT_OPTION_DEFAULT_PORT_VALUE et. al.
https://bugs.webkit.org/show_bug.cgi?id=144069

Reviewed by Martin Robinson.

  • Source/cmake/OptionsWin.cmake:

Do not set options that no longer exist.

  • Source/cmake/WebKitFeatures.cmake:

Add error checking to ensure that option names passed to WEBKIT_OPTION_DEFAULT_PORT_VALUE,
WEBKIT_OPTION_CONFLICT, and WEBKIT_OPTION_DEPEND are actually valid options that have been
previously-defined. Also, add ENABLE_SVG_OTF_CONVERTER build option, defaulted to off since
no CMake port was using it.

9:54 AM Changeset in webkit [194455] by Martin Robinson
  • 2 edits in trunk/LayoutTests

Mark WOFF2 test as failing on WebKitGTK+

Unreviewed. Gardening.

  • platform/gtk/TestExpectations:
9:12 AM Changeset in webkit [194454] by Michael Catanzaro
  • 2 edits in trunk

[CMake] Add error checking to catch option manipulation after WEBKIT_OPTION_END
https://bugs.webkit.org/show_bug.cgi?id=152611

Reviewed by Martin Robinson.

If WEBKIT_OPTION_DEFINE is called after WEBKIT_OPTION_END, the option never makes its way
into FEATURE_DEFINES and so will be inconsistently set (available to most of the build, but
not to the DOM bindings generator, for example).

If WEBKIT_OPTION_DEFAULT_PORT_VALUE, WEBKIT_OPTION_CONFLICT, or WEBKIT_OPTION_DEPEND are
called after WEBKIT_OPTION_END, they don't do anything.

Add error checking to catch these bugs.

  • Source/cmake/WebKitFeatures.cmake:
8:47 AM Changeset in webkit [194453] by ChangSeok Oh
  • 2 edits in trunk/LayoutTests

[GTK] Unreviewed gardening at 2015-12-31

Mark fast/text/text-combine-placement.html as crashing.

  • platform/gtk/TestExpectations:
8:46 AM WebKitGTK/Gardening/Calendar edited by ChangSeok Oh
(diff)
6:38 AM WebKitGTK/AddingNewWebKit2API edited by Michael Catanzaro
Add note about autocleanups (diff)
Note: See TracTimeline for information about the timeline view.