Context Navigation

← Previous Period
Next Period →

Timeline

Jan 17, 2016:

8:41 PM Changeset in webkit [195186] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

Add quotes around ${CMAKE_SHARED_LINKER_FLAGS} in case it is unset
https://bugs.webkit.org/show_bug.cgi?id=153175

Patch by Jeremy Huddleston Sequoia <jeremyhu@apple.com> on 2016-01-17
Reviewed by Michael Catanzaro.

PlatformGTK.cmake:

7:20 PM Changeset in webkit [195185] by Simon Fraser

5 edits
9 adds in trunk

More displaylist tests, and minor cleanup
https://bugs.webkit.org/show_bug.cgi?id=153198

Reviewed by Zalan Bujtas.

Source/WebCore:

Have the DisplayListRecorder's constructor push the recorder onto the GraphicsContext,
and remove that code from GraphicsLayerCA.

Tests: displaylists/extent-includes-shadow.html

displaylists/extent-includes-transforms.html

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::recursiveCommitChanges):

platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::Recorder):

LayoutTests:

A couple more display list tests that check that the computed extent of an item
includes shadows and transforms.

WK1 results differ in that they disable should-subpixel-quantize-fonts in the state
(which is a bug).

Move some shared JS into a helper file.

displaylists/extent-includes-shadow-expected.txt: Added.
displaylists/extent-includes-shadow.html: Added.
displaylists/extent-includes-transforms-expected.txt: Added.
displaylists/extent-includes-transforms.html: Added.
displaylists/layer-dispay-list.html:
displaylists/resources/dump-target-display-list.js: Added.

(doTest):

platform/mac-wk1/displaylists/extent-includes-shadow-expected.txt: Added.
platform/mac-wk1/displaylists/extent-includes-transforms-expected.txt: Added.

2:24 PM Changeset in webkit [195184] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Ensure that CF_AVAILABLE is undefined when building webkit-gtk

https://bugs.webkit.org/show_bug.cgi?id=152720

This change ensures that CF_AVAILABLE is correctly a no-op to
address build failure that was observed when building on older
versions of OSX. Previously, CF_AVAILABLE may have been unexpectedly
re-defined to the system header value based on include-order.

Patch by Jeremy Huddleston Sequoia <jeremyhu@apple.com> on 2016-01-17
Reviewed by Michael Catanzaro.

API/WebKitAvailability.h:

10:09 AM Changeset in webkit [195183] by Michael Catanzaro

5 edits in trunk

[CMake] Do not build bmalloc when USE_SYSTEM_MALLOC is ON
https://bugs.webkit.org/show_bug.cgi?id=153190

Reviewed by Csaba Osztrogonác.

Build bmalloc when NOT USE_SYSTEM_MALLOC rather than when NOT WIN32.

Source/CMakeLists.txt:
Source/cmake/OptionsWin.cmake:

Source/WTF:

wtf/CMakeLists.txt:

1:15 AM Changeset in webkit [195182] by Julien Brianceau

5 edits in trunk/Source/JavaScriptCore

[mips] Fix regT2 and regT3 trampling in MacroAssembler
https://bugs.webkit.org/show_bug.cgi?id=153131

Mips $t2 and $t3 registers were used as temporary registers
in MacroAssemblerMIPS.h, whereas they are mapped to regT2
and regT3 in LLInt and GPRInfo.

This patch rearranges register mapping for the mips architecture:

use $t0 and $t1 as temp registers in LLInt (as in MacroAssembler)
use $t7 and $t8 as temp registers in MacroAssembler (as in LLInt)
remove $t6 from temp registers list in LLInt
update GPRInfo.h accordingly
add mips macroScratchRegisters() list in RegisterSet.cpp

Reviewed by Michael Saboff.

assembler/MacroAssemblerMIPS.h:
jit/GPRInfo.h:

(JSC::GPRInfo::toRegister):
(JSC::GPRInfo::toIndex):

jit/RegisterSet.cpp:

(JSC::RegisterSet::macroScratchRegisters):
(JSC::RegisterSet::calleeSaveRegisters):

offlineasm/mips.rb:

12:13 AM Changeset in webkit [195181] by beidson@apple.com

227 edits in trunk/LayoutTests

Modern IDB: .js test files should not log database names.
https://bugs.webkit.org/show_bug.cgi?id=153181

Reviewed by Alex Christensen.

We'll be sharing .js files as well as test expectations between different HTML test files,
and logging the filename is counter to this goal, as it will change depending on the HTML
driver running the test.

storage/indexeddb/resources/shared.js:

(setDBNameFromPath): eval() setting the filename instead of evalAndLog().

platform/wk2/storage/indexeddb/aborted-versionchange-closes-expected.txt:
platform/wk2/storage/indexeddb/create-and-remove-object-store-expected.txt:
platform/wk2/storage/indexeddb/cursor-continue-dir-expected.txt:
platform/wk2/storage/indexeddb/cursor-continue-expected.txt:
platform/wk2/storage/indexeddb/cursor-finished-expected.txt:
platform/wk2/storage/indexeddb/database-basics-expected.txt:
platform/wk2/storage/indexeddb/index-count-expected.txt:
platform/wk2/storage/indexeddb/intversion-abort-in-initial-upgradeneeded-expected.txt:
platform/wk2/storage/indexeddb/intversion-close-in-oncomplete-expected.txt:
platform/wk2/storage/indexeddb/intversion-close-in-upgradeneeded-expected.txt:
platform/wk2/storage/indexeddb/invalid-keys-expected.txt:
platform/wk2/storage/indexeddb/key-type-array-expected.txt:
platform/wk2/storage/indexeddb/keypath-arrays-expected.txt:
platform/wk2/storage/indexeddb/keypath-edges-expected.txt:
platform/wk2/storage/indexeddb/mozilla/bad-keypath-expected.txt:
platform/wk2/storage/indexeddb/mozilla/clear-expected.txt:
platform/wk2/storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
platform/wk2/storage/indexeddb/mozilla/cursors-expected.txt:
platform/wk2/storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt:
platform/wk2/storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
platform/wk2/storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
platform/wk2/storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
platform/wk2/storage/indexeddb/mozilla/readonly-transactions-expected.txt:
platform/wk2/storage/indexeddb/object-lookups-in-versionchange-expected.txt:
platform/wk2/storage/indexeddb/objectstore-count-expected.txt:
platform/wk2/storage/indexeddb/open-cursor-expected.txt:
platform/wk2/storage/indexeddb/request-result-cache-expected.txt:
platform/wk2/storage/indexeddb/transaction-abort-expected.txt:
platform/wk2/storage/indexeddb/transaction-active-flag-expected.txt:
platform/wk2/storage/indexeddb/transaction-after-close-expected.txt:
platform/wk2/storage/indexeddb/transaction-read-only-expected.txt:
platform/wk2/storage/indexeddb/version-change-exclusive-expected.txt:
storage/indexeddb/aborted-versionchange-closes-expected.txt:
storage/indexeddb/clone-exception-expected.txt:
storage/indexeddb/closed-cursor-expected.txt:
storage/indexeddb/create-and-remove-object-store-expected.txt:
storage/indexeddb/create-object-store-options-expected.txt:
storage/indexeddb/createIndex-after-failure-expected.txt:
storage/indexeddb/createObjectStore-name-argument-required-expected.txt:
storage/indexeddb/createObjectStore-null-name-expected.txt:
storage/indexeddb/cursor-added-bug-expected.txt:
storage/indexeddb/cursor-advance-expected.txt:
storage/indexeddb/cursor-basics-expected.txt:
storage/indexeddb/cursor-cast-expected.txt:
storage/indexeddb/cursor-continue-dir-expected.txt:
storage/indexeddb/cursor-continue-expected.txt:
storage/indexeddb/cursor-continue-validity-expected.txt:
storage/indexeddb/cursor-delete-expected.txt:
storage/indexeddb/cursor-finished-expected.txt:
storage/indexeddb/cursor-inconsistency-expected.txt:
storage/indexeddb/cursor-index-delete-expected.txt:
storage/indexeddb/cursor-key-order-expected.txt:
storage/indexeddb/cursor-overloads-expected.txt:
storage/indexeddb/cursor-prev-no-duplicate-expected.txt:
storage/indexeddb/cursor-primary-key-order-expected.txt:
storage/indexeddb/cursor-properties-expected.txt:
storage/indexeddb/cursor-reverse-bug-expected.txt:
storage/indexeddb/cursor-skip-deleted-expected.txt:
storage/indexeddb/cursor-update-expected.txt:
storage/indexeddb/cursor-update-value-argument-required-expected.txt:
storage/indexeddb/cursor-value-expected.txt:
storage/indexeddb/database-basics-expected.txt:
storage/indexeddb/database-close-expected.txt:
storage/indexeddb/database-closepending-flag-expected.txt:
storage/indexeddb/database-deletepending-flag-expected.txt:
storage/indexeddb/database-wrapper-expected.txt:
storage/indexeddb/delete-closed-database-object-expected.txt:
storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-expected.txt:
storage/indexeddb/delete-in-upgradeneeded-close-in-versionchange-expected.txt:
storage/indexeddb/delete-range-expected.txt:
storage/indexeddb/deleteIndex-expected.txt:
storage/indexeddb/deleteObjectStore-name-argument-required-expected.txt:
storage/indexeddb/deleteObjectStore-null-name-expected.txt:
storage/indexeddb/deleted-objects-expected.txt:
storage/indexeddb/deletedatabase-blocked-expected.txt:
storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-expected.txt:
storage/indexeddb/deletedatabase-not-blocked-expected.txt:
storage/indexeddb/deletedatabase-transaction-expected.txt:
storage/indexeddb/dont-wedge-expected.txt:
storage/indexeddb/duplicates-expected.txt:
storage/indexeddb/error-causes-abort-by-default-expected.txt:
storage/indexeddb/exception-in-event-aborts-expected.txt:
storage/indexeddb/exceptions-expected.txt:
storage/indexeddb/factory-deletedatabase-expected.txt:
storage/indexeddb/get-keyrange-expected.txt:
storage/indexeddb/index-basics-expected.txt:
storage/indexeddb/index-count-expected.txt:
storage/indexeddb/index-cursor-expected.txt:
storage/indexeddb/index-duplicate-keypaths-expected.txt:
storage/indexeddb/index-get-key-argument-required-expected.txt:
storage/indexeddb/index-multientry-expected.txt:
storage/indexeddb/index-population-expected.txt:
storage/indexeddb/index-unique-expected.txt:
storage/indexeddb/intversion-abort-in-initial-upgradeneeded-expected.txt:
storage/indexeddb/intversion-bad-parameters-expected.txt:
storage/indexeddb/intversion-blocked-expected.txt:
storage/indexeddb/intversion-close-between-events-expected.txt:
storage/indexeddb/intversion-close-in-oncomplete-expected.txt:
storage/indexeddb/intversion-close-in-upgradeneeded-expected.txt:
storage/indexeddb/intversion-encoding-expected.txt:
storage/indexeddb/intversion-gated-on-delete-expected.txt:
storage/indexeddb/intversion-long-queue-expected.txt:
storage/indexeddb/intversion-omit-parameter-expected.txt:
storage/indexeddb/intversion-open-in-upgradeneeded-expected.txt:
storage/indexeddb/intversion-open-with-version-expected.txt:
storage/indexeddb/intversion-pending-version-changes-ascending-expected.txt:
storage/indexeddb/intversion-pending-version-changes-descending-expected.txt:
storage/indexeddb/intversion-pending-version-changes-same-expected.txt:
storage/indexeddb/intversion-persistence-expected.txt:
storage/indexeddb/intversion-revert-on-abort-expected.txt:
storage/indexeddb/intversion-two-opens-no-versions-expected.txt:
storage/indexeddb/intversion-upgrades-expected.txt:
storage/indexeddb/invalid-keys-expected.txt:
storage/indexeddb/key-generator-expected.txt:
storage/indexeddb/key-sort-order-across-types-expected.txt:
storage/indexeddb/key-sort-order-date-expected.txt:
storage/indexeddb/key-type-array-expected.txt:
storage/indexeddb/key-type-binary-expected.txt:
storage/indexeddb/key-type-infinity-expected.txt:
storage/indexeddb/keypath-arrays-expected.txt:
storage/indexeddb/keypath-basics-expected.txt:
storage/indexeddb/keypath-edges-expected.txt:
storage/indexeddb/keypath-fetch-key-expected.txt:
storage/indexeddb/keypath-intrinsic-properties-expected.txt:
storage/indexeddb/lazy-index-population-expected.txt:
storage/indexeddb/lazy-index-types-expected.txt:
storage/indexeddb/list-ordering-expected.txt:
storage/indexeddb/metadata-expected.txt:
storage/indexeddb/metadata-race-expected.txt:
storage/indexeddb/modern/abort-objectstore-info-expected.txt:
storage/indexeddb/modern/blocked-open-db-requests-expected.txt:
storage/indexeddb/modern/memory-index-not-deleted-with-objectstore-expected.txt:
storage/indexeddb/modern/transaction-scheduler-4-expected.txt:
storage/indexeddb/mozilla/add-twice-failure-expected.txt:
storage/indexeddb/mozilla/autoincrement-indexes-expected.txt:
storage/indexeddb/mozilla/bad-keypath-expected.txt:
storage/indexeddb/mozilla/clear-expected.txt:
storage/indexeddb/mozilla/create-index-unique-expected.txt:
storage/indexeddb/mozilla/create-index-with-integer-keys-expected.txt:
storage/indexeddb/mozilla/create-objectstore-basics-expected.txt:
storage/indexeddb/mozilla/create-objectstore-null-name-expected.txt:
storage/indexeddb/mozilla/cursor-mutation-expected.txt:
storage/indexeddb/mozilla/cursor-mutation-objectstore-only-expected.txt:
storage/indexeddb/mozilla/cursor-update-updates-indexes-expected.txt:
storage/indexeddb/mozilla/cursors-expected.txt:
storage/indexeddb/mozilla/delete-result-expected.txt:
storage/indexeddb/mozilla/event-source-expected.txt:
storage/indexeddb/mozilla/global-data-expected.txt:
storage/indexeddb/mozilla/index-prev-no-duplicate-expected.txt:
storage/indexeddb/mozilla/indexes-expected.txt:
storage/indexeddb/mozilla/key-requirements-delete-null-key-expected.txt:
storage/indexeddb/mozilla/key-requirements-expected.txt:
storage/indexeddb/mozilla/key-requirements-inline-and-passed-expected.txt:
storage/indexeddb/mozilla/key-requirements-put-no-key-expected.txt:
storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
storage/indexeddb/mozilla/object-cursors-expected.txt:
storage/indexeddb/mozilla/object-identity-expected.txt:
storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-expected.txt:
storage/indexeddb/mozilla/object-store-remove-values-expected.txt:
storage/indexeddb/mozilla/objectstorenames-expected.txt:
storage/indexeddb/mozilla/odd-result-order-expected.txt:
storage/indexeddb/mozilla/put-get-values-expected.txt:
storage/indexeddb/mozilla/readonly-transactions-expected.txt:
storage/indexeddb/mozilla/readwrite-transactions-expected.txt:
storage/indexeddb/mozilla/readyState-expected.txt:
storage/indexeddb/mozilla/remove-index-expected.txt:
storage/indexeddb/mozilla/remove-objectstore-expected.txt:
storage/indexeddb/mozilla/versionchange-abort-expected.txt:
storage/indexeddb/mutating-cursor-expected.txt:
storage/indexeddb/noblobs-expected.txt:
storage/indexeddb/object-lookups-in-versionchange-expected.txt:
storage/indexeddb/objectStore-required-arguments-expected.txt:
storage/indexeddb/objectstore-autoincrement-expected.txt:
storage/indexeddb/objectstore-basics-expected.txt:
storage/indexeddb/objectstore-clear-expected.txt:
storage/indexeddb/objectstore-count-expected.txt:
storage/indexeddb/objectstore-cursor-expected.txt:
storage/indexeddb/objectstore-removeobjectstore-expected.txt:
storage/indexeddb/open-cursor-expected.txt:
storage/indexeddb/open-during-transaction-expected.txt:
storage/indexeddb/open-ordering-expected.txt:
storage/indexeddb/opencursor-key-expected.txt:
storage/indexeddb/optional-arguments-expected.txt:
storage/indexeddb/pending-activity-expected.txt:
storage/indexeddb/persistence-expected.txt:
storage/indexeddb/prefetch-bugfix-108071-expected.txt:
storage/indexeddb/prefetch-invalidation-expected.txt:
storage/indexeddb/prefetch-race-expected.txt:
storage/indexeddb/queued-commands-expected.txt:
storage/indexeddb/readonly-expected.txt:
storage/indexeddb/readonly-properties-expected.txt:
storage/indexeddb/request-continue-abort-expected.txt:
storage/indexeddb/request-event-propagation-expected.txt:
storage/indexeddb/request-result-cache-expected.txt:
storage/indexeddb/set_version_blocked-expected.txt:
storage/indexeddb/setversion-blocked-by-versionchange-close-expected.txt:
storage/indexeddb/setversion-not-blocked-expected.txt:
storage/indexeddb/structured-clone-expected.txt:
storage/indexeddb/transaction-abort-expected.txt:
storage/indexeddb/transaction-active-flag-expected.txt:
storage/indexeddb/transaction-after-close-expected.txt:
storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
storage/indexeddb/transaction-basics-expected.txt:
storage/indexeddb/transaction-complete-with-js-recursion-cross-frame-expected.txt:
storage/indexeddb/transaction-complete-with-js-recursion-expected.txt:
storage/indexeddb/transaction-coordination-across-databases-expected.txt:
storage/indexeddb/transaction-coordination-within-database-expected.txt:
storage/indexeddb/transaction-crash-in-tasks-expected.txt:
storage/indexeddb/transaction-crash-on-abort-expected.txt:
storage/indexeddb/transaction-error-expected.txt:
storage/indexeddb/transaction-event-propagation-expected.txt:
storage/indexeddb/transaction-ordering-expected.txt:
storage/indexeddb/transaction-overlapping-expected.txt:
storage/indexeddb/transaction-read-only-expected.txt:
storage/indexeddb/transaction-readwrite-exclusive-expected.txt:
storage/indexeddb/transaction-rollback-expected.txt:
storage/indexeddb/transaction-scope-sequencing-expected.txt:
storage/indexeddb/transaction-starvation-expected.txt:
storage/indexeddb/transaction-storeNames-required-expected.txt:
storage/indexeddb/unblocked-version-changes-expected.txt:
storage/indexeddb/value-undefined-expected.txt:
storage/indexeddb/values-odd-types-expected.txt:
storage/indexeddb/version-change-abort-expected.txt:
storage/indexeddb/version-change-event-expected.txt:
storage/indexeddb/version-change-exclusive-expected.txt:

Jan 16, 2016:

8:54 PM Changeset in webkit [195180] by mmaxfield@apple.com

34 edits
8 deletes in trunk

Remove TextRun::allowsRoundingHacks()
https://bugs.webkit.org/show_bug.cgi?id=153185

Reviewed by Simon Fraser.

Source/WebCore:

Rounding hacks are disallowed by default, and are only re-enabled on iOS 4 and
earlier, which are not supported OSes. Because they are disallowed on all
supported configurations, remove support for them wholesale.

No new tests.

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal):

platform/graphics/FontCascade.cpp:
platform/graphics/FontCascade.h:

(WebCore::FontCascade::isRoundingHackCharacter): Deleted.

platform/graphics/StringTruncator.cpp:

(WebCore::stringWidth):
(WebCore::truncateString):
(WebCore::StringTruncator::centerTruncate):
(WebCore::StringTruncator::rightTruncate):
(WebCore::StringTruncator::width):
(WebCore::StringTruncator::leftTruncate):
(WebCore::StringTruncator::rightClipToCharacter):
(WebCore::StringTruncator::rightClipToWord):

platform/graphics/StringTruncator.h:
platform/graphics/TextRun.cpp:

(WebCore::TextRun::setAllowsRoundingHacks): Deleted.
(WebCore::TextRun::allowsRoundingHacks): Deleted.

platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun):
(WebCore::TextRun::applyRunRounding): Deleted.
(WebCore::TextRun::applyWordRounding): Deleted.
(WebCore::TextRun::disableRoundingHacks): Deleted.

platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advanceInternal):

platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

platform/mac/DragImageMac.mm:

(WebCore::widthWithFont): Deleted.
(WebCore::drawAtPoint): Deleted.

rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::fileTextValue):
(WebCore::RenderFileUploadControl::paintObject): Deleted.

rendering/RenderListBox.cpp:

(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::updateFromElement): Deleted.

rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::getAverageCharWidth): Deleted.

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::fileListNameForWidth):

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::fileListNameForWidth):

rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::constructTextRun): Deleted.

rendering/svg/SVGTextMetrics.cpp:

(WebCore::SVGTextMetrics::constructTextRun): Deleted.

testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState): Deleted.
(WebCore::Internals::allowRoundingHacks): Deleted.

testing/Internals.h:
testing/Internals.idl:

Source/WebKit/ios:

Misc/WebUIKitSupport.mm:

(WebKitInitialize): Deleted.

Source/WebKit/mac:

Misc/WebKitNSStringExtras.mm:

(-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]): Deleted.
(-[NSString _web_widthWithFont:]): Deleted.

WebView/WebView.mm:

(+[WebView _setAllowsRoundingHacks:]): Deleted.
(+[WebView _allowsRoundingHacks]): Deleted.

WebView/WebViewPrivate.h:

Tools:

DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting): Deleted.

LayoutTests:

platform/mac/fast/text/rounding-hacks-expansion.html: Removed.
platform/mac/fast/text/rounding-hacks.html: Removed.
platform/mac/platform/mac/fast/text/rounding-hacks-expansion-expected.png: Removed.
platform/mac/platform/mac/fast/text/rounding-hacks-expansion-expected.txt: Removed.
platform/mac/platform/mac/fast/text/rounding-hacks-expected.png: Removed.
platform/mac/platform/mac/fast/text/rounding-hacks-expected.txt: Removed.
svg/text/svg-font-word-rounding-hacks-spaces-expected.html: Removed.
svg/text/svg-font-word-rounding-hacks-spaces.html: Removed.

4:21 PM Changeset in webkit [195179] by akling@apple.com

4 edits in trunk/Source/WebCore

Allocate style sheet media queries in BumpArena.
<https://webkit.org/b/153188>

Reviewed by Antti Koivisto.

Teach the CSS parser to allocate MediaQuery and MediaQueryExp from BumpArena as well.

css/CSSGrammar.y.in:
css/MediaQuery.h:
css/MediaQueryExp.h:

4:04 PM Changeset in webkit [195178] by commit-queue@webkit.org

8 edits in trunk

[ES6] Arrow function syntax. Arrow function should support the destructuring parameters.
https://bugs.webkit.org/show_bug.cgi?id=146934

Patch by Skachkov Oleksandr <gskachkov@gmail.com> on 2016-01-16
Reviewed by Saam Barati.
Source/JavaScriptCore:

Added support of destructuring parameters, before arrow function expect only simple parameters,
e.g. (), (x), (x, y) or x in assigment expressio. To support destructuring parameters added
additional check that check for destructuring paramters if check does not pass for simple parameters.

parser/Parser.cpp:

(JSC::Parser<LexerType>::isArrowFunctionParameters):
(JSC::Parser<LexerType>::parseAssignmentExpression):

parser/Parser.h:

LayoutTests:

js/arrowfunction-syntax-errors-expected.txt:
js/arrowfunction-syntax-expected.txt:
js/script-tests/arrowfunction-syntax-errors.js:
js/script-tests/arrowfunction-syntax.js:

4:00 PM Changeset in webkit [195177] by Michael Catanzaro

2 edits in trunk/Source/WebCore

[GTK] Add a couple comments to ScrollbarThemeGtk
https://bugs.webkit.org/show_bug.cgi?id=153184

Reviewed by Carlos Garcia Campos.

platform/gtk/ScrollbarThemeGtk.cpp:

(WebCore::ScrollbarThemeGtk::paint):

1:05 PM Changeset in webkit [195176] by timothy@apple.com

2 edits in trunk/Websites/webkit.org

Fix some responsive issues on smaller screens.

wp-content/themes/webkit/style.css:

(.timeline .time):
(@media (max-width: 900px)):
(.timeline:before):
(.timeline > li):
(.timeline > li:before):
(.timeline .content):
(.timeline li .time::before):

12:53 PM Changeset in webkit [195175] by commit-queue@webkit.org

1 edit
2 adds in trunk/LayoutTests

Web Inspector: Add tests for Array Utilities like lowerBound/upperBound
https://bugs.webkit.org/show_bug.cgi?id=153177

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-16
Reviewed by Timothy Hatcher.

inspector/unit-tests/array-utilities-expected.txt: Added.
inspector/unit-tests/array-utilities.html: Added.

12:50 PM Changeset in webkit [195174] by commit-queue@webkit.org

4 edits in trunk

.:
[GTK] Use -Wl,-all_load on darwin to include contents of all static archives

https://bugs.webkit.org/show_bug.cgi?id=153117

Patch by Jeremy Huddleston Sequoia <jeremyhu@apple.com> on 2016-01-16
Reviewed by Michael Catanzaro.

Source/cmake/OptionsGTK.cmake:

Source/WebKit2:
Remove a now-irrelevant darwin build hack
https://bugs.webkit.org/show_bug.cgi?id=153117

Patch by Jeremy Huddleston Sequoia <jeremyhu@apple.com> on 2016-01-16
Reviewed by Michael Catanzaro.

PlatformGTK.cmake:

12:37 PM Changeset in webkit [195173] by akling@apple.com

3 edits in trunk/Source/WebCore

Give RuleSet a BumpArena and start using it for RuleDataVectors.
<https://webkit.org/b/153169>

Reviewed by Antti Koivisto.

Since RuleSet only supports appending rules and doesn't need to worry about removing them,
it's a great candidate for BumpArena optimizations.

Give each RuleSet its own BumpArena and teach them how to allocate RuleDataVector objects
out of them.

There are more things that can be done here, ideally all the sub-allocations inside RuleSet
that happen via e.g Vector and HashMap would also come out of the BumpArena.

css/RuleSet.cpp:

(WebCore::RuleSet::RuleSet):
(WebCore::RuleSet::addToRuleSet):
(WebCore::RuleSet::copyShadowPseudoElementRulesFrom):

css/RuleSet.h:

(WebCore::RuleSet::RuleDataVector::create):
(WebCore::RuleSet::RuleSet): Deleted.

11:07 AM Changeset in webkit [195172] by Simon Fraser

4 edits in trunk

Source/WebCore:
Fix flakiness of displaylists/layer-dispay-list.html

When toggling "uses display list drawing" on a GraphicsLayerCA, do
a repaint.

platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setUsesDisplayListDrawing):

LayoutTests:
This test needs to force layout before calling setElementUsesDisplayListDrawing(),
so that the layer already has its "drawsContents" property updated.

displaylists/layer-dispay-list.html:

11:03 AM Changeset in webkit [195171] by jhoneycutt@apple.com

3 edits in trunk/Source/WebKit2

[iOS] Replace deprecated -[UIDocumentMenuViewController
_setIgnoreApplicationEntitlementForImport:]

<https://bugs.webkit.org/show_bug.cgi?id=145690>
<rdar://problem/20636577>

Reviewed by Brent Fulgham.

Platform/spi/ios/UIKitSPI.h:

Replace deprecated SPI with newer SPI.

UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel presentWithParameters:resultListener:]):
(-[WKFileUploadPanel _showDocumentPickerMenu]):
Ditto.

10:12 AM Changeset in webkit [195170] by Simon Fraser

17 edits in trunk/Source

Remove GraphicsContext::drawConvexPolygon() and GraphicsContext::clipConvexPolygon()
https://bugs.webkit.org/show_bug.cgi?id=153174

Reviewed by Zalan Bujtas.

GraphicsContext::drawConvexPolygon() and GraphicsContext::clipConvexPolygon() were
poorly named (non-convex polygons are allowed), and just syntactic sugar over
clipPath() and drawPath().

Remove them, but add a convenience function to create a Path from a Vector of
points. For CG, we can use the more efficient CGPathAddLines().
Source/WebCore:

Add TextStream dumping for Path.

platform/graphics/GraphicsContext.h:
platform/graphics/Path.cpp:

(WebCore::Path::polygonPathFromPoints):
(WebCore::Path::dump):
(WebCore::operator<<):

platform/graphics/Path.h:
platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::setPlatformShouldAntialias):
(WebCore::addConvexPolygonToContext): Deleted.
(WebCore::GraphicsContext::drawConvexPolygon): Deleted.
(WebCore::GraphicsContext::clipConvexPolygon): Deleted.

platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::addConvexPolygonToPath): Deleted.
(WebCore::GraphicsContext::drawConvexPolygon): Deleted.
(WebCore::GraphicsContext::clipConvexPolygon): Deleted.

platform/graphics/cg/PathCG.cpp:

(WebCore::Path::polygonPathFromPoints):
(WebCore::Path::moveTo):
(WebCore::Path::addLineTo):
(WebCore::Path::addQuadCurveTo):
(WebCore::Path::addBezierCurveTo):
(WebCore::Path::addArcTo):

platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::Item::sizeInBytes): Deleted.
(WebCore::DisplayList::ClipConvexPolygon::ClipConvexPolygon): Deleted.
(WebCore::DisplayList::ClipConvexPolygon::apply): Deleted.
(WebCore::DisplayList::operator<<): Deleted.
(WebCore::DisplayList::addConvexPolygonToPath): Deleted.
(WebCore::DisplayList::DrawConvexPolygon::DrawConvexPolygon): Deleted.
(WebCore::DisplayList::DrawConvexPolygon::localBounds): Deleted.
(WebCore::DisplayList::DrawConvexPolygon::apply): Deleted.

platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::ClipConvexPolygon::create): Deleted.
(WebCore::DisplayList::ClipConvexPolygon::points): Deleted.
(WebCore::DisplayList::ClipConvexPolygon::antialias): Deleted.
(WebCore::DisplayList::DrawConvexPolygon::create): Deleted.
(WebCore::DisplayList::DrawConvexPolygon::points): Deleted.
(WebCore::DisplayList::DrawConvexPolygon::antialiased): Deleted.

platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::drawConvexPolygon): Deleted.
(WebCore::DisplayList::Recorder::clipConvexPolygon): Deleted.

platform/graphics/displaylists/DisplayListRecorder.h:
rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::clipBorderSidePolygon):

rendering/RenderElement.cpp:

(WebCore::RenderElement::drawLineForBoxSide):

rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::paintMenuListButtonDecorations):

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMenuListButtonDecorations):

Source/WebKit/win:

FullscreenVideoController.cpp:

(HUDSlider::draw):

8:46 AM Changeset in webkit [195169] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Add Platform.cpp to ANGLESupport

https://bugs.webkit.org/show_bug.cgi?id=153120

Patch by Jeremy Huddleston Sequoia <jeremyhu@apple.com> on 2016-01-16
Reviewed by Darin Adler.

No new tests, only addresses a build failure.

CMakeLists.txt:

7:15 AM Changeset in webkit [195168] by Michael Catanzaro

2 edits in trunk/Source/WebKit2

[GTK] Unreviewed. Fix a typo in an API comment.

UIProcess/API/gtk/WebKitWebViewSessionState.cpp:

1:44 AM Changeset in webkit [195167] by Carlos Garcia Campos

2 edits in trunk/Source/WebCore

[GTK] List box selections stopped working again with GTK+ from current git master
https://bugs.webkit.org/show_bug.cgi?id=153122

Reviewed by Michael Catanzaro.

The problem is that the ListBox selection implementation is
wrong. We are using a similar implementation to GtkEntry, but
GtkTreeView doesn't have a child CSS node for selections.

rendering/RenderThemeGtk.cpp:

(WebCore::styleColor): Don't use a child style context for ListBox selections.
(WebCore::createStyleContext): Remove ListBoxSelection.

1:36 AM Changeset in webkit [195166] by Carlos Garcia Campos

2 edits in trunk/Source/WebKit2

[GTK] GVariant runtime critical errors when encoding session data
https://bugs.webkit.org/show_bug.cgi?id=153130

Reviewed by Michael Catanzaro.

It happens when the FrameState has children, because the recursive
serialization is wrong. Also fix serialization of
documentSequenceNumber and itemSequenceNumber that are gint64, not
guint64.

UIProcess/API/gtk/WebKitWebViewSessionState.cpp:

(encodeFrameState): Let the caller open/init the given
builder. Use a new builder to encode child states recursively.
(encodePageState): Do the builder open/close for the FrameState encoding.
(decodeFrameState): Get the variant of every child.

12:49 AM Changeset in webkit [195165] by Carlos Garcia Campos