Timeline
Jan 21, 2016:
- 11:24 PM Changeset in webkit [195446] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] The IRC allocator can mess up the degree of Tmps interfering with move-related Tmps
https://bugs.webkit.org/show_bug.cgi?id=153340
Reviewed by Filip Pizlo.
The JavaScriptCore tests uncovered an interested bug in the iterated register
coalescing allocator. When coalescing a move under the right conditions, it is
possible to mess-up the graph for the Tmps interfering with the coalesced Tmps.
Some context first:
-When coalescing a move, we alias one Tmp to another. Let say that we had
Move X, Y
the coalescing may alias Y to X: Y->X.
-Since X and Y are equivalent after coalescing, any interference
edge with Y is "moved" to X.
The way this was done was to add an edge to X for every edge there was with Y.
Say we had an edge R--Y, we add an edge R--X.
Adding an edge increases the degree of R and Y. The degree of R was then
fixed by calling decrementDegree() on it.
-decrementDegree() is non trivial. It will move the Tmp to the right list
for further processing if the Tmp's degree becomes lower than the number
of available registers.
The bug appear in a particular case. Say we have 3 Tmp, A, B, and C.
-A and B are move related, they can be coalesced.
-A has an interference edge with C.
-B does not have and interfence edge with C.
-C's degree is exactly the number of avaialble registers/colors minus one (k - 1).
-> This implies C is already in its list.
We coalesce A and B into B (A->B).
-The first step, addEdgeDistinct() adds an edge between B and C. The degrees of
B and C are increased by one. The degree of C becomes k.
-Next, decrementDegree() is called on C. Its degree decreases to k-1.
Because of the change from k to k-1, decrementDegree() adds C to a list again.
We have two kinds of bugs depending on the test:
-A Tmp can be added to the simplifyWorklist several time.
-A Tmp can be in both simplifyWorklist and freezeWorklist (because its move-related
status changed since the last decrementDegree()).
In both cases, the Tmps interfering with the duplicated Tmp will end up with
a degree lower than their real value.
- b3/air/AirIteratedRegisterCoalescing.cpp:
- 10:45 PM Changeset in webkit [195445] by
-
- 9 edits2 adds in trunk
REGRESSION (r168244): Content in horizontal-bt page is offset such that only the end is viewable and there is a white gap at the top
https://bugs.webkit.org/show_bug.cgi?id=136019
Reviewed by Dan Bernstein.
Source/WebCore:
In horizontal-bt documents (where the page starts scrolled to the bottom, and scrolling up goes into negative scroll positions),
the position of the root content layer would be set incorrectly by the scrolling thread, resulting in misplaced
content.
Fix by having the renamed "yPositionForRootContentLayer" take scroll origin into
account, and being more consistent about using scrollOrigin to position this layer.
Test: fast/scrolling/programmatic-horizontal-bt-document-scroll.html
- page/FrameView.cpp:
(WebCore::FrameView::yPositionForFooterLayer): Moved
(WebCore::FrameView::positionForRootContentLayer): Take scrollOrigin, and subtract it from the computed value.
(WebCore::FrameView::yPositionForRootContentLayer): Renamed.
- page/FrameView.h:
- page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::updateScrollPositionAfterAsyncScroll): We've already pushed the new scrollPosition onto the FrameView,
so we can just use the member function to compute the positionForContentsLayer.
- page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
(WebCore::ScrollingTreeFrameScrollingNodeMac::setScrollLayerPosition): This is the bug fix; FrameView::positionForRootContentLayer()
now takes scrollOrigin into account.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateRootLayerPosition): Rather than using the documentRect, position the root content layer
in terms of the scroll origin (which is -documentRect.location()).
Source/WebKit2:
Now call frameView.positionForRootContentLayer(), and add a FIXME questioning the
behavior in horizontal b-t documents. However, this code isn't hit now that we always
do extended backgrounds, so never have shadow layers.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::shadowLayerPositionForFrame):
LayoutTests:
Test that scrolls a horizontal-bt document.
- fast/scrolling/programmatic-horizontal-bt-document-scroll-expected.html: Added.
- fast/scrolling/programmatic-horizontal-bt-document-scroll.html: Added.
- 10:44 PM Changeset in webkit [195444] by
-
- 2 edits in trunk/Tools
Fix the lldb WebCoreLayoutUnitProvider to not dynamically look up the LayoutUnit denominator
https://bugs.webkit.org/show_bug.cgi?id=153334
Reviewed by Zalan Bujtas.
Evaluating expressions in the LayoutUnit summary provider seems to cause
re-entrancy problems in lldb python bindings, so just hardcode the LayoutUnit
denominator to 64.
- lldb/lldb_webkit.py:
(WebCoreLayoutUnitProvider.to_string):
- 10:39 PM Changeset in webkit [195443] by
-
- 11 edits6 adds in trunk
Modern IDB: Support populating/extracting database metadata with SQLite backend.
Source/WebCore:
Nhttps://bugs.webkit.org/show_bug.cgi?id=153318
Reviewed by Alex Christensen.
No new tests (Covered by current tests).
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/client/IDBDatabaseImpl.cpp:
(WebCore::IDBClient::IDBDatabase::willAbortTransaction): Committing transactions can abort if the commit
ends in error.
- Modules/indexeddb/client/IDBTransactionImpl.cpp:
(WebCore::IDBClient::IDBTransaction::didCommit): Before a committing transaction is aborted, notify the
IDBDatabase that it aborted.
Copied over from WK2:
- Modules/indexeddb/server/IDBSerialization.cpp: Added.
(WebCore::serializeIDBKeyPath):
(WebCore::deserializeIDBKeyPath):
(WebCore::serializeIDBKeyData):
(WebCore::deserializeIDBKeyData):
- Modules/indexeddb/server/IDBSerialization.h: Added.
- Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::createBackingStore): Optionally create a SQLite backing store.
Mostly copied over verbatim from WebKit2's UniqueIDBDatabaseBackingStoreSQLite.cpp:
- Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::idbKeyCollate):
(WebCore::IDBServer::v1RecordsTableSchema):
(WebCore::IDBServer::v1RecordsTableSchemaAlternate):
(WebCore::IDBServer::v2RecordsTableSchema):
(WebCore::IDBServer::v2RecordsTableSchemaAlternate):
(WebCore::IDBServer::createOrMigrateRecordsTableIfNecessary):
(WebCore::IDBServer::SQLiteIDBBackingStore::ensureValidRecordsTable):
(WebCore::IDBServer::SQLiteIDBBackingStore::createAndPopulateInitialDatabaseInfo):
(WebCore::IDBServer::SQLiteIDBBackingStore::extractExistingDatabaseInfo):
(WebCore::IDBServer::SQLiteIDBBackingStore::getOrEstablishDatabaseInfo):
(WebCore::IDBServer::SQLiteIDBBackingStore::beginTransaction):
(WebCore::IDBServer::SQLiteIDBBackingStore::abortTransaction):
(WebCore::IDBServer::SQLiteIDBBackingStore::commitTransaction):
(WebCore::IDBServer::SQLiteIDBBackingStore::createObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::unregisterCursor):
- Modules/indexeddb/server/SQLiteIDBBackingStore.h:
Copied over from WK2:
- Modules/indexeddb/server/SQLiteIDBCursor.cpp: Added.
(WebCore::IDBServer::SQLiteIDBCursor::maybeCreate):
(WebCore::IDBServer::SQLiteIDBCursor::SQLiteIDBCursor):
(WebCore::IDBServer::buildIndexStatement):
(WebCore::IDBServer::buildObjectStoreStatement):
(WebCore::IDBServer::SQLiteIDBCursor::establishStatement):
(WebCore::IDBServer::SQLiteIDBCursor::createSQLiteStatement):
(WebCore::IDBServer::SQLiteIDBCursor::objectStoreRecordsChanged):
(WebCore::IDBServer::SQLiteIDBCursor::resetAndRebindStatement):
(WebCore::IDBServer::SQLiteIDBCursor::bindArguments):
(WebCore::IDBServer::SQLiteIDBCursor::advance):
(WebCore::IDBServer::SQLiteIDBCursor::advanceUnique):
(WebCore::IDBServer::SQLiteIDBCursor::advanceOnce):
(WebCore::IDBServer::SQLiteIDBCursor::internalAdvanceOnce):
(WebCore::IDBServer::SQLiteIDBCursor::iterate):
- Modules/indexeddb/server/SQLiteIDBCursor.h: Added.
(WebCore::IDBServer::SQLiteIDBCursor::identifier):
(WebCore::IDBServer::SQLiteIDBCursor::transaction):
(WebCore::IDBServer::SQLiteIDBCursor::objectStoreID):
(WebCore::IDBServer::SQLiteIDBCursor::currentKey):
(WebCore::IDBServer::SQLiteIDBCursor::currentPrimaryKey):
(WebCore::IDBServer::SQLiteIDBCursor::currentValueBuffer):
(WebCore::IDBServer::SQLiteIDBCursor::didError):
Copied over from WK2:
- Modules/indexeddb/server/SQLiteIDBTransaction.cpp: Added.
(WebCore::IDBServer::SQLiteIDBTransaction::SQLiteIDBTransaction):
(WebCore::IDBServer::SQLiteIDBTransaction::~SQLiteIDBTransaction):
(WebCore::IDBServer::SQLiteIDBTransaction::begin):
(WebCore::IDBServer::SQLiteIDBTransaction::commit):
(WebCore::IDBServer::SQLiteIDBTransaction::reset):
(WebCore::IDBServer::SQLiteIDBTransaction::rollback):
(WebCore::IDBServer::SQLiteIDBTransaction::maybeOpenCursor):
(WebCore::IDBServer::SQLiteIDBTransaction::closeCursor):
(WebCore::IDBServer::SQLiteIDBTransaction::notifyCursorsOfChanges):
(WebCore::IDBServer::SQLiteIDBTransaction::clearCursors):
(WebCore::IDBServer::SQLiteIDBTransaction::inProgress):
- Modules/indexeddb/server/SQLiteIDBTransaction.h: Added.
(WebCore::IDBServer::SQLiteIDBTransaction::transactionIdentifier):
(WebCore::IDBServer::SQLiteIDBTransaction::mode):
(WebCore::IDBServer::SQLiteIDBTransaction::sqliteTransaction):
- page/Page.cpp:
(WebCore::Page::setSessionID): If the new SessionID is different from the last one,
clear the IDBConnectionToServer.
(WebCore::Page::idbConnection): Always ask the DatabaseProvider; It handles whether or not
the session is ephemeral.
LayoutTests:
https://bugs.webkit.org/show_bug.cgi?id=153318
Reviewed by Alex Christensen.
- platform/mac-wk1/TestExpectations: Skip all of the tests that run against the SQLite backend and currently fail (which is most of them!)
- 9:54 PM Changeset in webkit [195442] by
-
- 3 edits2 adds in trunk
REGRESSION (r195305): Web Inspector: WebInspector.Object can dispatch constructor-level events multiple times
https://bugs.webkit.org/show_bug.cgi?id=153269
<rdar://problem/24253106>
Reviewed by Timothy Hatcher.
Source/WebInspectorUI:
Bring back object.hasOwnProperty("_listeners") check.
- UserInterface/Base/Object.js:
(WebInspector.Object.prototype.dispatchEventToListeners.dispatch):
(WebInspector.Object.prototype.dispatchEventToListeners):
(WebInspector.Object):
Check !object._listeners before !object.hasOwnProperty("_listeners")
because !object._listeners is more common case thus we can exit earlier
most of the time.
LayoutTests:
- inspector/unit-tests/object-expected.txt: Added.
- inspector/unit-tests/object.html: Added.
- 9:49 PM Changeset in webkit [195441] by
-
- 2 edits in trunk/Source/WebCore
CMake build fix after r195302.
- PlatformMac.cmake:
- 9:22 PM Changeset in webkit [195440] by
-
- 6 edits in trunk/Source/JavaScriptCore
Add some missing WTF_MAKE_FAST_ALLOCATED in JavaScriptCore.
<https://webkit.org/b/153335>
Reviewed by Alex Christensen.
Saw these things getting system malloc()'ed in an Instruments trace.
- inspector/InspectorAgentBase.h:
- jit/CallFrameShuffleData.h:
- jit/CallFrameShuffler.h:
- jit/RegisterAtOffsetList.h:
- runtime/GenericOffset.h:
- 8:21 PM Changeset in webkit [195439] by
-
- 23 edits3 adds in trunk
[ES6] Catch parameter should accept BindingPattern
https://bugs.webkit.org/show_bug.cgi?id=152385
Reviewed by Saam Barati.
Source/JavaScriptCore:
This patch implements destructuring in catch parameter.
Catch parameter accepts binding pattern and binding identifier.
It creates lexical bindings. And "yield" and "let" are specially
handled as is the same to function parameters.
In addition to that, we make destructuring parsing errors more descriptive.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitPushCatchScope):
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp:
(JSC::TryNode::emitBytecode):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createTryStatement):
- parser/NodeConstructors.h:
(JSC::TryNode::TryNode):
- parser/Nodes.h:
- parser/Parser.cpp:
(JSC::Parser<LexerType>::createBindingPattern):
(JSC::Parser<LexerType>::tryParseDestructuringPatternExpression):
(JSC::Parser<LexerType>::parseBindingOrAssignmentElement):
(JSC::destructuringKindToVariableKindName):
(JSC::Parser<LexerType>::parseDestructuringPattern):
(JSC::Parser<LexerType>::parseTryStatement):
(JSC::Parser<LexerType>::parseFormalParameters):
(JSC::Parser<LexerType>::parseFunctionParameters):
- parser/Parser.h:
(JSC::Parser::destructuringKindFromDeclarationType):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createTryStatement):
- tests/es6.yaml:
- tests/es6/destructuring_in_catch_heads.js: Added.
(test):
- tests/stress/catch-parameter-destructuring.js: Added.
(shouldBe):
(shouldThrow):
(prototype.call):
(catch):
(shouldThrow.try.throw.get error):
(initialize):
(array):
(generator.gen):
(generator):
- tests/stress/catch-parameter-syntax.js: Added.
(testSyntax):
(testSyntaxError):
- tests/stress/reserved-word-with-escape.js:
(testSyntaxError.String.raw.a):
(String.raw.SyntaxError.Cannot.use.the.keyword.string_appeared_here.as.a.name):
- tests/stress/yield-named-variable.js:
LayoutTests:
- js/dom/reserved-words-as-property-expected.txt:
- js/let-syntax-expected.txt:
- js/mozilla/strict/12.14.1-expected.txt:
- js/mozilla/strict/script-tests/12.14.1.js:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T10-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T13-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T5-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T7-expected.txt:
- sputnik/Conformance/12_Statement/12.14_The_try_Statement/S12.14_A16_T8-expected.txt:
- 7:47 PM Changeset in webkit [195438] by
-
- 4 edits in trunk/Source/WebCore
createElementFromSavedToken shouldn't have the code to create a non-HTML element
https://bugs.webkit.org/show_bug.cgi?id=153327
Reviewed by Chris Dumez.
Since HTMLConstructionSite::createElementFromSavedToken is only used to instantiate a formatting element,
there is no need for it to support creating a non-HTML elements. Remove the branch and assert that this
is indeed the case.
createElementFromSavedToken is called in HTMLTreeBuilder::callTheAdoptionAgency and HTMLConstructionSite's
reconstructTheActiveFormattingElements. In both cases, the stack item passed to createElementFromSavedToken
is guaranteed to be in the list of active formatting elements, which only contains formatting elements.
No new tests since there is no behavioral change.
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::insertHTMLHeadElement):
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
(WebCore::HTMLConstructionSite::insertFormattingElement):
(WebCore::HTMLConstructionSite::createElement): Returns Ref<Element> instead of PassRefPtr<Element>.
(WebCore::HTMLConstructionSite::createHTMLElement): Ditto.
(WebCore::HTMLConstructionSite::createElementFromSavedToken): Ditto. Removed the code to instantiate
a non-HTML element. Also assert that an element created by this function is a formatting tag.
- html/parser/HTMLConstructionSite.h:
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLConstructionSite::isFormattingTag): Put into HTMLConstructionSite to add an assertion.
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
- 7:40 PM Changeset in webkit [195437] by
-
- 5 edits in branches/safari-601.1.46-branch/Source
Versioning.
- 7:40 PM Changeset in webkit [195436] by
-
- 5 edits in branches/safari-601-branch/Source
Versioning.
- 7:36 PM Changeset in webkit [195435] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fix build.
- b3/B3EliminateCommonSubexpressions.cpp:
- 7:31 PM Changeset in webkit [195434] by
-
- 8 edits in trunk/Source/JavaScriptCore
B3 CSE should be able to match a full redundancy even if none of the matches dominate the value in question
https://bugs.webkit.org/show_bug.cgi?id=153321
Reviewed by Benjamin Poulain.
I once learned that LLVM's GVN can manufacture Phi functions. I don't know the details
but I'm presuming that it involves:
if (p)
tmp1 = *ptr
else
tmp2 = *ptr
tmp3 = *ptr Replace this with Phi(tmp1, tmp2).
This adds such an optimization to our CSE. The idea is that we search through basic
blocks until we find the value we want, a side effect, or the start of the procedure. If
we find a value that matches our search criteria, we record it and ignore the
predecessors. If we find a side effect or the start of the procedure, we give up the
whole search. This ensures that if we come out of the search without giving up, we'll
have a set of matches that are fully redundant.
CSE could then create a Phi graph by using SSACalculator. But the recent work on FixSSA
revealed a much more exciting option: create a stack slot! In case there is more than one
match, CSE now creates a stack slot that each match stores to, and replaces the redundant
instruction with a loadfrom the stack slot. The stack slot is anonymous, which ensures
that FixSSA will turn it into an optimal Phi graph or whatever.
This is a significant speed-up on Octane/richards.
- b3/B3DuplicateTails.cpp:
- b3/B3EliminateCommonSubexpressions.cpp:
- b3/B3FixSSA.cpp:
(JSC::B3::fixSSA):
- b3/B3Generate.cpp:
(JSC::B3::generateToAir):
- b3/B3Procedure.h:
(JSC::B3::Procedure::setFrontendData):
(JSC::B3::Procedure::frontendData):
- b3/testb3.cpp:
- ftl/FTLState.cpp:
(JSC::FTL::State::State):
- 6:21 PM Changeset in webkit [195433] by
-
- 2 edits in trunk/Source/JavaScriptCore
Air should know that CeilDouble has the partial register stall issue
https://bugs.webkit.org/show_bug.cgi?id=153338
Rubber stamped by Benjamin Poulain.
This is a 8% speed-up on Kraken with B3 enabled, mostly because of a 2.4x speed-up on
audio-oscillator.
- b3/air/AirFixPartialRegisterStalls.cpp:
- 6:06 PM Changeset in webkit [195432] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Add toggle-able list of classes for each element
https://bugs.webkit.org/show_bug.cgi?id=152678
Patch by Devin Rousso <Devin Rousso> on 2016-01-21
Reviewed by Timothy Hatcher.
Adds a button to the CSS sidebar that, when toggled, displays a section
directly above it containing all the classes for the selected node that,
when toggled, adds or removes the class from the node.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Protocol/RemoteObject.js:
(WebInspector.RemoteObject.prototype.callFunction.mycallback):
(WebInspector.RemoteObject.prototype.callFunction):
Add extra handling of arguments to allow nicer looking calls by other classes.
- UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
Changed next-sibling selector (+) to general-sibling selector (~).
(.sidebar > .panel.details.css-style > .content ~ :matches(.options-container, .class-list-container)):
(.sidebar > .panel.details.css-style > .content:not(.supports-new-rule, .has-filter-bar) ~ :matches(.options-container, .class-list-container)):
(.sidebar > .panel.details.css-style > .content ~ .options-container > .toggle-class-toggle):
(.sidebar > .panel.details.css-style > .content ~ .options-container > .toggle-class-toggle.selected):
(.sidebar > .panel.details.css-style > .content ~ .options-container > .toggle-class-toggle:not(.selected):hover):
(.sidebar > .panel.details.css-style > .content ~ .class-list-container):
(.sidebar > .panel.details.css-style > .content ~ .class-list-container[hidden]):
(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class):
(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > input[type="checkbox"]):
(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .add-class-icon):
(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class > .class-name-input):
(.sidebar > .panel.details.css-style > .content ~ .class-list-container > .new-class:not(.active) > .class-name-input):
(.sidebar > .panel.details.css-style > .content ~ .class-list-container > *:matches(.new-class, .class-toggle)):
- UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
(WebInspector.CSSStyleDetailsSidebarPanel):
Also changed the few instances of "var" to "let".
(WebInspector.CSSStyleDetailsSidebarPanel.prototype.refresh):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype.addEventListeners):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._handleNodeAttributeModified):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._handleNodeAttributeRemoved):
Adds listeners to the DOMNode specifically listening for changes to the
class attribute and repopulates the class toggle list if fired.
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._classToggleButtonClicked):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._addClassContainerClicked):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._addClassInputKeyPressed):
If the Enter key is pressed, add a new class equal to the input value.
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._addClassInputBlur):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._populateClassToggles):
Loops through all the classes, including previously removed ones, for the
selected node and creates a toggle for each.
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._createToggleForClassName.classNameToggleChanged):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._createToggleForClassName):
Creates a toggle element for the given className and adds it to the container.
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._toggleClass.resolvedNode.toggleClass):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._toggleClass.resolvedNode):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._toggleClass):
Uses the Element.classList to toggle the given className on the selected node.
- 6:05 PM Changeset in webkit [195431] by
-
- 3 edits3 adds in trunk
[INTL] Implement Array.prototype.toLocaleString in ECMA-402
https://bugs.webkit.org/show_bug.cgi?id=147614
Patch by Andy VanWagoner <andy@instructure.com> on 2016-01-21
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
The primary changes in the ECMA-402 version, and the existing implementation
are passing the arguments on to each element's toLocaleString call, and
missing/undefined/null elements become empty string instead of being skipped.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncToLocaleString):
LayoutTests:
- js/array-toLocaleString-expected.txt: Added.
- js/array-toLocaleString.html: Added.
- js/script-tests/array-toLocaleString.js: Added.
- 6:00 PM Changeset in webkit [195430] by
-
- 5 edits in trunk/Source/WebCore
CGImageSource sometimes retains temporary SharedBuffer data indefinitely, doubling memory cost.
<https://webkit.org/b/153325>
Reviewed by Anders Carlsson.
After a resource has finished downloading, and has been cached to disk cache,
we mmap() the disk cached version so we can throw out the temporary download buffer.
Due to the way CGImageSource works on Mac/iOS, it's not possible to replace the data
being decoded once the image has been fully decoded once. When doing the replacement,
we'd end up with the SharedBuffer wrapping the mmap() data, and the CGImageSource
keeping the old SharedBuffer::DataBuffer alive, effectively doubling the memory cost.
This patch adds a CachedResource::didReplaceSharedBufferContents() callback that
CachedImage implements to throw out the decoded data. This is currently the only way
to make CGImageSource drop the retain it holds on the SharedBuffer::DataBuffer.
The downside of this approach is that we'll sometimes incur the cost of one additional
image decode after an image downloads and is cached for the first time.
I put a FIXME in there since we could do better with a little help from CGImageSource.
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::didReplaceSharedBufferContents):
- loader/cache/CachedImage.h:
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::tryReplaceEncodedData):
- loader/cache/CachedResource.h:
(WebCore::CachedResource::didReplaceSharedBufferContents):
- 4:47 PM Changeset in webkit [195429] by
-
- 2 edits in trunk/Source/WebKit2
Move _allowsDoubleTapGestures implementation out of category
https://bugs.webkit.org/show_bug.cgi?id=153329
<rdar://problem/24289768>
Reviewed by Simon Fraser.
We were generating a linker warning because the implementation
was located inside the WKPrivate category.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _allowsDoubleTapGestures]): Move this out of
the category.
- 3:57 PM Changeset in webkit [195428] by
-
- 2 edits in trunk/LayoutTests
Rebaseline fast/block/float/overhanging-tall-block.html for ios-simulator-wk2
https://bugs.webkit.org/show_bug.cgi?id=152440
Reviewed by Zalan Bujtas.
- platform/ios-simulator-wk2/fast/block/float/overhanging-tall-block-expected.txt:
- 3:52 PM Changeset in webkit [195427] by
-
- 1 copy in tags/Safari-601.1.46.93
New tag.
- 3:52 PM Changeset in webkit [195426] by
-
- 1 copy in tags/Safari-601.5.11
New tag.
- 3:45 PM Changeset in webkit [195425] by
-
- 2 edits in trunk/Source/JavaScriptCore
[B3][Win64] Compile fixes.
https://bugs.webkit.org/show_bug.cgi?id=153312
Reviewed by Alex Christensen.
Since MSVC has several overloads of sin, cos, pow, and log, we need to specify
which one we want to use.
- ftl/FTLB3Output.h:
(JSC::FTL::Output::doubleSin):
(JSC::FTL::Output::doubleCos):
(JSC::FTL::Output::doublePow):
(JSC::FTL::Output::doubleLog):
- 3:34 PM Changeset in webkit [195424] by
-
- 4 edits in trunk/Source/WebKit2
[iOS] Crash in _endPotentialTapAndEnableDoubleTapGesturesIfNecessary
https://bugs.webkit.org/show_bug.cgi?id=153326
<rdar://problem/24264339>
Reviewed by Anders Carlsson.
UIKit's UIGestureRecognizer could call back into the WKContentView
after the associated WKWebView has disappeared. The fix is to
explicitly null the WKWebView reference as we deallocate.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView dealloc]): Tell the WKContentView we are going away.
- UIProcess/ios/WKContentView.h:
- UIProcess/ios/WKContentView.mm:
(-[WKContentView _webViewDestroyed]):
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _endPotentialTapAndEnableDoubleTapGesturesIfNecessary]):
Only do something if the WKWebView is still around.
- 3:15 PM Changeset in webkit [195423] by
-
- 5 edits1 copy487 adds in trunk/LayoutTests
Modern IDB: Make -private copies of each w3c IDB test.
https://bugs.webkit.org/show_bug.cgi?id=153319
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- indexeddb/support.js: If the test filename ends with -private.htm(l), enable private browsing.
- indexeddb/abort-in-initial-upgradeneeded-private-expected.txt: Added.
- indexeddb/abort-in-initial-upgradeneeded-private.html: Added.
- indexeddb/close-in-upgradeneeded-private-expected.txt: Added.
- indexeddb/close-in-upgradeneeded-private.html: Added.
- indexeddb/cursor-overloads-private-expected.txt: Added.
- indexeddb/cursor-overloads-private.html: Added.
- indexeddb/idb_webworkers-private-expected.txt: Added.
- indexeddb/idb_webworkers-private.html: Added.
- indexeddb/idbcursor-advance-continue-async-private-expected.txt: Added.
- indexeddb/idbcursor-advance-continue-async-private.html: Added.
- indexeddb/idbcursor-advance-invalid-private-expected.txt: Added.
- indexeddb/idbcursor-advance-invalid-private.html: Added.
- indexeddb/idbcursor-advance-private-expected.txt: Added.
- indexeddb/idbcursor-advance-private.html: Added.
- indexeddb/idbcursor-continue-private-expected.txt: Added.
- indexeddb/idbcursor-continue-private.html: Added.
- indexeddb/idbcursor-direction-index-keyrange-private-expected.txt: Added.
- indexeddb/idbcursor-direction-index-keyrange-private.html: Added.
- indexeddb/idbcursor-direction-index-private-expected.txt: Added.
- indexeddb/idbcursor-direction-index-private.html: Added.
- indexeddb/idbcursor-direction-objectstore-keyrange-private-expected.txt: Added.
- indexeddb/idbcursor-direction-objectstore-keyrange-private.html: Added.
- indexeddb/idbcursor-direction-objectstore-private-expected.txt: Added.
- indexeddb/idbcursor-direction-objectstore-private.html: Added.
- indexeddb/idbcursor-direction-private-expected.txt: Added.
- indexeddb/idbcursor-direction-private.html: Added.
- indexeddb/idbcursor-key-private-expected.txt: Added.
- indexeddb/idbcursor-key-private.html: Added.
- indexeddb/idbcursor-primarykey-private-expected.txt: Added.
- indexeddb/idbcursor-primarykey-private.html: Added.
- indexeddb/idbcursor-reused-private-expected.txt: Added.
- indexeddb/idbcursor-reused-private.html: Added.
- indexeddb/idbcursor-source-private-expected.txt: Added.
- indexeddb/idbcursor-source-private.html: Added.
- indexeddb/idbcursor_advance_index-private-expected.txt: Added.
- indexeddb/idbcursor_advance_index-private.html: Added.
- indexeddb/idbcursor_advance_index2-private-expected.txt: Added.
- indexeddb/idbcursor_advance_index2-private.html: Added.
- indexeddb/idbcursor_advance_index3-private-expected.txt: Added.
- indexeddb/idbcursor_advance_index3-private.html: Added.
- indexeddb/idbcursor_advance_index5-private-expected.txt: Added.
- indexeddb/idbcursor_advance_index5-private.html: Added.
- indexeddb/idbcursor_advance_index6-private-expected.txt: Added.
- indexeddb/idbcursor_advance_index6-private.html: Added.
- indexeddb/idbcursor_advance_index7-private-expected.txt: Added.
- indexeddb/idbcursor_advance_index7-private.html: Added.
- indexeddb/idbcursor_advance_index8-private-expected.txt: Added.
- indexeddb/idbcursor_advance_index8-private.html: Added.
- indexeddb/idbcursor_advance_index9-private-expected.txt: Added.
- indexeddb/idbcursor_advance_index9-private.html: Added.
- indexeddb/idbcursor_advance_objectstore-private-expected.txt: Added.
- indexeddb/idbcursor_advance_objectstore-private.html: Added.
- indexeddb/idbcursor_advance_objectstore2-private-expected.txt: Added.
- indexeddb/idbcursor_advance_objectstore2-private.html: Added.
- indexeddb/idbcursor_advance_objectstore3-private-expected.txt: Added.
- indexeddb/idbcursor_advance_objectstore3-private.html: Added.
- indexeddb/idbcursor_advance_objectstore4-private-expected.txt: Added.
- indexeddb/idbcursor_advance_objectstore4-private.html: Added.
- indexeddb/idbcursor_advance_objectstore5-private-expected.txt: Added.
- indexeddb/idbcursor_advance_objectstore5-private.html: Added.
- indexeddb/idbcursor_continue_index-private-expected.txt: Added.
- indexeddb/idbcursor_continue_index-private.html: Added.
- indexeddb/idbcursor_continue_index2-private-expected.txt: Added.
- indexeddb/idbcursor_continue_index2-private.html: Added.
- indexeddb/idbcursor_continue_index3-private-expected.txt: Added.
- indexeddb/idbcursor_continue_index3-private.html: Added.
- indexeddb/idbcursor_continue_index4-private-expected.txt: Added.
- indexeddb/idbcursor_continue_index4-private.html: Added.
- indexeddb/idbcursor_continue_index5-private-expected.txt: Added.
- indexeddb/idbcursor_continue_index5-private.html: Added.
- indexeddb/idbcursor_continue_index6-private-expected.txt: Added.
- indexeddb/idbcursor_continue_index6-private.html: Added.
- indexeddb/idbcursor_continue_index7-private-expected.txt: Added.
- indexeddb/idbcursor_continue_index7-private.html: Added.
- indexeddb/idbcursor_continue_index8-private-expected.txt: Added.
- indexeddb/idbcursor_continue_index8-private.html: Added.
- indexeddb/idbcursor_continue_invalid-private-expected.txt: Added.
- indexeddb/idbcursor_continue_invalid-private.html: Added.
- indexeddb/idbcursor_continue_objectstore-private-expected.txt: Added.
- indexeddb/idbcursor_continue_objectstore-private.html: Added.
- indexeddb/idbcursor_continue_objectstore2-private-expected.txt: Added.
- indexeddb/idbcursor_continue_objectstore2-private.html: Added.
- indexeddb/idbcursor_continue_objectstore3-private-expected.txt: Added.
- indexeddb/idbcursor_continue_objectstore3-private.html: Added.
- indexeddb/idbcursor_continue_objectstore4-private-expected.txt: Added.
- indexeddb/idbcursor_continue_objectstore4-private.html: Added.
- indexeddb/idbcursor_continue_objectstore5-private-expected.txt: Added.
- indexeddb/idbcursor_continue_objectstore5-private.html: Added.
- indexeddb/idbcursor_continue_objectstore6-private-expected.txt: Added.
- indexeddb/idbcursor_continue_objectstore6-private.html: Added.
- indexeddb/idbcursor_delete_index-private-expected.txt: Added.
- indexeddb/idbcursor_delete_index-private.html: Added.
- indexeddb/idbcursor_delete_index2-private-expected.txt: Added.
- indexeddb/idbcursor_delete_index2-private.html: Added.
- indexeddb/idbcursor_delete_index3-private-expected.txt: Added.
- indexeddb/idbcursor_delete_index3-private.html: Added.
- indexeddb/idbcursor_delete_index4-private-expected.txt: Added.
- indexeddb/idbcursor_delete_index4-private.html: Added.
- indexeddb/idbcursor_delete_index5-private-expected.txt: Added.
- indexeddb/idbcursor_delete_index5-private.html: Added.
- indexeddb/idbcursor_delete_objectstore-private-expected.txt: Added.
- indexeddb/idbcursor_delete_objectstore-private.html: Added.
- indexeddb/idbcursor_delete_objectstore2-private-expected.txt: Added.
- indexeddb/idbcursor_delete_objectstore2-private.html: Added.
- indexeddb/idbcursor_delete_objectstore3-private-expected.txt: Added.
- indexeddb/idbcursor_delete_objectstore3-private.html: Added.
- indexeddb/idbcursor_delete_objectstore4-private-expected.txt: Added.
- indexeddb/idbcursor_delete_objectstore4-private.html: Added.
- indexeddb/idbcursor_delete_objectstore5-private-expected.txt: Added.
- indexeddb/idbcursor_delete_objectstore5-private.html: Added.
- indexeddb/idbcursor_iterating-private-expected.txt: Added.
- indexeddb/idbcursor_iterating-private.html: Added.
- indexeddb/idbcursor_iterating_index-private-expected.txt: Added.
- indexeddb/idbcursor_iterating_index-private.html: Added.
- indexeddb/idbcursor_iterating_index2-private-expected.txt: Added.
- indexeddb/idbcursor_iterating_index2-private.html: Added.
- indexeddb/idbcursor_iterating_objectstore-private-expected.txt: Added.
- indexeddb/idbcursor_iterating_objectstore-private.html: Added.
- indexeddb/idbcursor_iterating_objectstore2-private-expected.txt: Added.
- indexeddb/idbcursor_iterating_objectstore2-private.html: Added.
- indexeddb/idbcursor_update_index-private-expected.txt: Added.
- indexeddb/idbcursor_update_index-private.html: Added.
- indexeddb/idbcursor_update_index2-private-expected.txt: Added.
- indexeddb/idbcursor_update_index2-private.html: Added.
- indexeddb/idbcursor_update_index3-private-expected.txt: Added.
- indexeddb/idbcursor_update_index3-private.html: Added.
- indexeddb/idbcursor_update_index4-private-expected.txt: Added.
- indexeddb/idbcursor_update_index4-private.html: Added.
- indexeddb/idbcursor_update_index5-private-expected.txt: Added.
- indexeddb/idbcursor_update_index5-private.html: Added.
- indexeddb/idbcursor_update_index6-private-expected.txt: Added.
- indexeddb/idbcursor_update_index6-private.html: Added.
- indexeddb/idbcursor_update_index7-private-expected.txt: Added.
- indexeddb/idbcursor_update_index7-private.html: Added.
- indexeddb/idbcursor_update_objectstore-private-expected.txt: Added.
- indexeddb/idbcursor_update_objectstore-private.html: Added.
- indexeddb/idbcursor_update_objectstore2-private-expected.txt: Added.
- indexeddb/idbcursor_update_objectstore2-private.html: Added.
- indexeddb/idbcursor_update_objectstore3-private-expected.txt: Added.
- indexeddb/idbcursor_update_objectstore3-private.html: Added.
- indexeddb/idbcursor_update_objectstore4-private-expected.txt: Added.
- indexeddb/idbcursor_update_objectstore4-private.html: Added.
- indexeddb/idbcursor_update_objectstore5-private-expected.txt: Added.
- indexeddb/idbcursor_update_objectstore5-private.html: Added.
- indexeddb/idbcursor_update_objectstore6-private-expected.txt: Added.
- indexeddb/idbcursor_update_objectstore6-private.html: Added.
- indexeddb/idbcursor_update_objectstore7-private-expected.txt: Added.
- indexeddb/idbcursor_update_objectstore7-private.html: Added.
- indexeddb/idbcursor_update_objectstore8-private-expected.txt: Added.
- indexeddb/idbcursor_update_objectstore8-private.html: Added.
- indexeddb/idbdatabase_close-private-expected.txt: Added.
- indexeddb/idbdatabase_close-private.html: Added.
- indexeddb/idbdatabase_close2-private-expected.txt: Added.
- indexeddb/idbdatabase_close2-private.html: Added.
- indexeddb/idbdatabase_createObjectStore-createIndex-emptyname-private-expected.txt: Added.
- indexeddb/idbdatabase_createObjectStore-createIndex-emptyname-private.html: Added.
- indexeddb/idbdatabase_createObjectStore-private-expected.txt: Added.
- indexeddb/idbdatabase_createObjectStore-private.html: Added.
- indexeddb/idbdatabase_createObjectStore10-1000ends-private-expected.txt: Added.
- indexeddb/idbdatabase_createObjectStore10-1000ends-private.html: Added.
- indexeddb/idbdatabase_createObjectStore10-emptyname-private-expected.txt: Added.
- indexeddb/idbdatabase_createObjectStore10-emptyname-private.html: Added.
- indexeddb/idbdatabase_createObjectStore11-private-expected.txt: Added.
- indexeddb/idbdatabase_createObjectStore11-private.html: Added.
- indexeddb/idbdatabase_createObjectStore2-private-expected.txt: Added.
- indexeddb/idbdatabase_createObjectStore2-private.html: Added.
- indexeddb/idbdatabase_createObjectStore3-private-expected.txt: Added.
- indexeddb/idbdatabase_createObjectStore3-private.html: Added.
- indexeddb/idbdatabase_createObjectStore4-private-expected.txt: Added.
- indexeddb/idbdatabase_createObjectStore4-private.html: Added.
- indexeddb/idbdatabase_createObjectStore5-private-expected.txt: Added.
- indexeddb/idbdatabase_createObjectStore5-private.html: Added.
- indexeddb/idbdatabase_createObjectStore6-private-expected.txt: Added.
- indexeddb/idbdatabase_createObjectStore6-private.html: Added.
- indexeddb/idbdatabase_createObjectStore7-private-expected.txt: Added.
- indexeddb/idbdatabase_createObjectStore7-private.html: Added.
- indexeddb/idbdatabase_createObjectStore8-parameters-private-expected.txt: Added.
- indexeddb/idbdatabase_createObjectStore8-parameters-private.html: Added.
- indexeddb/idbdatabase_createObjectStore9-invalidparameters-private-expected.txt: Added.
- indexeddb/idbdatabase_createObjectStore9-invalidparameters-private.html: Added.
- indexeddb/idbdatabase_deleteObjectStore-private-expected.txt: Added.
- indexeddb/idbdatabase_deleteObjectStore-private.html: Added.
- indexeddb/idbdatabase_deleteObjectStore2-private-expected.txt: Added.
- indexeddb/idbdatabase_deleteObjectStore2-private.html: Added.
- indexeddb/idbdatabase_deleteObjectStore3-private-expected.txt: Added.
- indexeddb/idbdatabase_deleteObjectStore3-private.html: Added.
- indexeddb/idbdatabase_deleteObjectStore4-not_reused-private-expected.txt: Added.
- indexeddb/idbdatabase_deleteObjectStore4-not_reused-private.html: Added.
- indexeddb/idbdatabase_transaction-private-expected.txt: Added.
- indexeddb/idbdatabase_transaction-private.html: Added.
- indexeddb/idbdatabase_transaction2-private-expected.txt: Added.
- indexeddb/idbdatabase_transaction2-private.html: Added.
- indexeddb/idbdatabase_transaction3-private-expected.txt: Added.
- indexeddb/idbdatabase_transaction3-private.html: Added.
- indexeddb/idbdatabase_transaction4-private-expected.txt: Added.
- indexeddb/idbdatabase_transaction4-private.html: Added.
- indexeddb/idbdatabase_transaction5-private-expected.txt: Added.
- indexeddb/idbdatabase_transaction5-private.html: Added.
- indexeddb/idbfactory_cmp-private-expected.txt: Added.
- indexeddb/idbfactory_cmp-private.html: Added.
- indexeddb/idbfactory_cmp2-private-expected.txt: Added.
- indexeddb/idbfactory_cmp2-private.html: Added.
- indexeddb/idbfactory_deleteDatabase-private-expected.txt: Added.
- indexeddb/idbfactory_deleteDatabase-private.html: Added.
- indexeddb/idbfactory_deleteDatabase2-private-expected.txt: Added.
- indexeddb/idbfactory_deleteDatabase2-private.html: Added.
- indexeddb/idbfactory_deleteDatabase3-private-expected.txt: Added.
- indexeddb/idbfactory_deleteDatabase3-private.html: Added.
- indexeddb/idbfactory_deleteDatabase4-private-expected.txt: Added.
- indexeddb/idbfactory_deleteDatabase4-private.html: Added.
- indexeddb/idbfactory_open-private-expected.txt: Added.
- indexeddb/idbfactory_open-private.html: Added.
- indexeddb/idbfactory_open10-private-expected.txt: Added.
- indexeddb/idbfactory_open10-private.html: Added.
- indexeddb/idbfactory_open11-private-expected.txt: Added.
- indexeddb/idbfactory_open11-private.html: Added.
- indexeddb/idbfactory_open12-private-expected.txt: Added.
- indexeddb/idbfactory_open12-private.html: Added.
- indexeddb/idbfactory_open2-private-expected.txt: Added.
- indexeddb/idbfactory_open2-private.html: Added.
- indexeddb/idbfactory_open3-private-expected.txt: Added.
- indexeddb/idbfactory_open3-private.html: Added.
- indexeddb/idbfactory_open4-private-expected.txt: Added.
- indexeddb/idbfactory_open4-private.html: Added.
- indexeddb/idbfactory_open5-private-expected.txt: Added.
- indexeddb/idbfactory_open5-private.html: Added.
- indexeddb/idbfactory_open6-private-expected.txt: Added.
- indexeddb/idbfactory_open6-private.html: Added.
- indexeddb/idbfactory_open7-private-expected.txt: Added.
- indexeddb/idbfactory_open7-private.html: Added.
- indexeddb/idbfactory_open8-private-expected.txt: Added.
- indexeddb/idbfactory_open8-private.html: Added.
- indexeddb/idbfactory_open9-private-expected.txt: Added.
- indexeddb/idbfactory_open9-private.html: Copied from LayoutTests/imported/w3c/indexeddb/idbfactory_open9.htm.
- indexeddb/idbfactory_open9.htm:
- indexeddb/idbindex-multientry-arraykeypath-private-expected.txt: Added.
- indexeddb/idbindex-multientry-arraykeypath-private.html: Added.
- indexeddb/idbindex-multientry-big-private-expected.txt: Added.
- indexeddb/idbindex-multientry-big-private.html: Added.
- indexeddb/idbindex-multientry-private-expected.txt: Added.
- indexeddb/idbindex-multientry-private.html: Added.
- indexeddb/idbindex_count-private-expected.txt: Added.
- indexeddb/idbindex_count-private.html: Added.
- indexeddb/idbindex_count2-private-expected.txt: Added.
- indexeddb/idbindex_count2-private.html: Added.
- indexeddb/idbindex_count3-private-expected.txt: Added.
- indexeddb/idbindex_count3-private.html: Added.
- indexeddb/idbindex_count4-private-expected.txt: Added.
- indexeddb/idbindex_count4-private.html: Added.
- indexeddb/idbindex_get-private-expected.txt: Added.
- indexeddb/idbindex_get-private.html: Added.
- indexeddb/idbindex_get2-private-expected.txt: Added.
- indexeddb/idbindex_get2-private.html: Added.
- indexeddb/idbindex_get3-private-expected.txt: Added.
- indexeddb/idbindex_get3-private.html: Added.
- indexeddb/idbindex_get4-private-expected.txt: Added.
- indexeddb/idbindex_get4-private.html: Added.
- indexeddb/idbindex_get5-private-expected.txt: Added.
- indexeddb/idbindex_get5-private.html: Added.
- indexeddb/idbindex_get6-private-expected.txt: Added.
- indexeddb/idbindex_get6-private.html: Added.
- indexeddb/idbindex_get7-private-expected.txt: Added.
- indexeddb/idbindex_get7-private.html: Added.
- indexeddb/idbindex_getKey-private-expected.txt: Added.
- indexeddb/idbindex_getKey-private.html: Added.
- indexeddb/idbindex_getKey2-private-expected.txt: Added.
- indexeddb/idbindex_getKey2-private.html: Added.
- indexeddb/idbindex_getKey3-private-expected.txt: Added.
- indexeddb/idbindex_getKey3-private.html: Added.
- indexeddb/idbindex_getKey4-private-expected.txt: Added.
- indexeddb/idbindex_getKey4-private.html: Added.
- indexeddb/idbindex_getKey5-private-expected.txt: Added.
- indexeddb/idbindex_getKey5-private.html: Added.
- indexeddb/idbindex_getKey6-private-expected.txt: Added.
- indexeddb/idbindex_getKey6-private.html: Added.
- indexeddb/idbindex_getKey7-private-expected.txt: Added.
- indexeddb/idbindex_getKey7-private.html: Added.
- indexeddb/idbindex_indexNames-private-expected.txt: Added.
- indexeddb/idbindex_indexNames-private.html: Added.
- indexeddb/idbindex_openCursor-private-expected.txt: Added.
- indexeddb/idbindex_openCursor-private.html: Added.
- indexeddb/idbindex_openCursor2-private-expected.txt: Added.
- indexeddb/idbindex_openCursor2-private.html: Added.
- indexeddb/idbindex_openKeyCursor-private-expected.txt: Added.
- indexeddb/idbindex_openKeyCursor-private.html: Added.
- indexeddb/idbindex_openKeyCursor2-private-expected.txt: Added.
- indexeddb/idbindex_openKeyCursor2-private.html: Added.
- indexeddb/idbindex_openKeyCursor3-private-expected.txt: Added.
- indexeddb/idbindex_openKeyCursor3-private.html: Added.
- indexeddb/idbkeyrange-private-expected.txt: Added.
- indexeddb/idbkeyrange-private.html: Added.
- indexeddb/idbkeyrange_incorrect-private-expected.txt: Added.
- indexeddb/idbkeyrange_incorrect-private.html: Added.
- indexeddb/idbobjectstore_add-private-expected.txt: Added.
- indexeddb/idbobjectstore_add-private.html: Added.
- indexeddb/idbobjectstore_add10-private-expected.txt: Added.
- indexeddb/idbobjectstore_add10-private.html: Added.
- indexeddb/idbobjectstore_add11-private-expected.txt: Added.
- indexeddb/idbobjectstore_add11-private.html: Added.
- indexeddb/idbobjectstore_add12-private-expected.txt: Added.
- indexeddb/idbobjectstore_add12-private.html: Added.
- indexeddb/idbobjectstore_add13-private-expected.txt: Added.
- indexeddb/idbobjectstore_add13-private.html: Added.
- indexeddb/idbobjectstore_add14-private-expected.txt: Added.
- indexeddb/idbobjectstore_add14-private.html: Added.
- indexeddb/idbobjectstore_add15-private-expected.txt: Added.
- indexeddb/idbobjectstore_add15-private.html: Added.
- indexeddb/idbobjectstore_add16-private-expected.txt: Added.
- indexeddb/idbobjectstore_add16-private.html: Added.
- indexeddb/idbobjectstore_add2-private-expected.txt: Added.
- indexeddb/idbobjectstore_add2-private.html: Added.
- indexeddb/idbobjectstore_add3-private-expected.txt: Added.
- indexeddb/idbobjectstore_add3-private.html: Added.
- indexeddb/idbobjectstore_add4-private-expected.txt: Added.
- indexeddb/idbobjectstore_add4-private.html: Added.
- indexeddb/idbobjectstore_add5-private-expected.txt: Added.
- indexeddb/idbobjectstore_add5-private.html: Added.
- indexeddb/idbobjectstore_add6-private-expected.txt: Added.
- indexeddb/idbobjectstore_add6-private.html: Added.
- indexeddb/idbobjectstore_add7-private-expected.txt: Added.
- indexeddb/idbobjectstore_add7-private.html: Added.
- indexeddb/idbobjectstore_add8-private-expected.txt: Added.
- indexeddb/idbobjectstore_add8-private.html: Added.
- indexeddb/idbobjectstore_add9-private-expected.txt: Added.
- indexeddb/idbobjectstore_add9-private.html: Added.
- indexeddb/idbobjectstore_clear-private-expected.txt: Added.
- indexeddb/idbobjectstore_clear-private.html: Added.
- indexeddb/idbobjectstore_clear2-private-expected.txt: Added.
- indexeddb/idbobjectstore_clear2-private.html: Added.
- indexeddb/idbobjectstore_clear3-private-expected.txt: Added.
- indexeddb/idbobjectstore_clear3-private.html: Added.
- indexeddb/idbobjectstore_clear4-private-expected.txt: Added.
- indexeddb/idbobjectstore_clear4-private.html: Added.
- indexeddb/idbobjectstore_count-private-expected.txt: Added.
- indexeddb/idbobjectstore_count-private.html: Added.
- indexeddb/idbobjectstore_count2-private-expected.txt: Added.
- indexeddb/idbobjectstore_count2-private.html: Added.
- indexeddb/idbobjectstore_count3-private-expected.txt: Added.
- indexeddb/idbobjectstore_count3-private.html: Added.
- indexeddb/idbobjectstore_count4-private-expected.txt: Added.
- indexeddb/idbobjectstore_count4-private.html: Added.
- indexeddb/idbobjectstore_createIndex-private-expected.txt: Added.
- indexeddb/idbobjectstore_createIndex-private.html: Added.
- indexeddb/idbobjectstore_createIndex10-private-expected.txt: Added.
- indexeddb/idbobjectstore_createIndex10-private.html: Added.
- indexeddb/idbobjectstore_createIndex11-private-expected.txt: Added.
- indexeddb/idbobjectstore_createIndex11-private.html: Added.
- indexeddb/idbobjectstore_createIndex12-private-expected.txt: Added.
- indexeddb/idbobjectstore_createIndex12-private.html: Added.
- indexeddb/idbobjectstore_createIndex13-private-expected.txt: Added.
- indexeddb/idbobjectstore_createIndex13-private.html: Added.
- indexeddb/idbobjectstore_createIndex2-private-expected.txt: Added.
- indexeddb/idbobjectstore_createIndex2-private.html: Added.
- indexeddb/idbobjectstore_createIndex3-usable-right-away-private-expected.txt: Added.
- indexeddb/idbobjectstore_createIndex3-usable-right-away-private.html: Added.
- indexeddb/idbobjectstore_createIndex4-deleteIndex-event_order-private-expected.txt: Added.
- indexeddb/idbobjectstore_createIndex4-deleteIndex-event_order-private.html: Added.
- indexeddb/idbobjectstore_createIndex5-emptykeypath-private-expected.txt: Added.
- indexeddb/idbobjectstore_createIndex5-emptykeypath-private.html: Added.
- indexeddb/idbobjectstore_createIndex6-event_order-private-expected.txt: Added.
- indexeddb/idbobjectstore_createIndex6-event_order-private.html: Added.
- indexeddb/idbobjectstore_createIndex7-event_order-private-expected.txt: Added.
- indexeddb/idbobjectstore_createIndex7-event_order-private.html: Added.
- indexeddb/idbobjectstore_createIndex8-valid_keys-private-expected.txt: Added.
- indexeddb/idbobjectstore_createIndex8-valid_keys-private.html: Added.
- indexeddb/idbobjectstore_createIndex9-emptyname-private-expected.txt: Added.
- indexeddb/idbobjectstore_createIndex9-emptyname-private.html: Added.
- indexeddb/idbobjectstore_delete-private-expected.txt: Added.
- indexeddb/idbobjectstore_delete-private.html: Added.
- indexeddb/idbobjectstore_delete2-private-expected.txt: Added.
- indexeddb/idbobjectstore_delete2-private.html: Added.
- indexeddb/idbobjectstore_delete3-private-expected.txt: Added.
- indexeddb/idbobjectstore_delete3-private.html: Added.
- indexeddb/idbobjectstore_delete4-private-expected.txt: Added.
- indexeddb/idbobjectstore_delete4-private.html: Added.
- indexeddb/idbobjectstore_delete5-private-expected.txt: Added.
- indexeddb/idbobjectstore_delete5-private.html: Added.
- indexeddb/idbobjectstore_delete6-private-expected.txt: Added.
- indexeddb/idbobjectstore_delete6-private.html: Added.
- indexeddb/idbobjectstore_delete7-private-expected.txt: Added.
- indexeddb/idbobjectstore_delete7-private.html: Added.
- indexeddb/idbobjectstore_deleteIndex-private-expected.txt: Added.
- indexeddb/idbobjectstore_deleteIndex-private.html: Added.
- indexeddb/idbobjectstore_deleted-private-expected.txt: Added.
- indexeddb/idbobjectstore_deleted-private.html: Added.
- indexeddb/idbobjectstore_get-private-expected.txt: Added.
- indexeddb/idbobjectstore_get-private.html: Added.
- indexeddb/idbobjectstore_get2-private-expected.txt: Added.
- indexeddb/idbobjectstore_get2-private.html: Added.
- indexeddb/idbobjectstore_get3-private-expected.txt: Added.
- indexeddb/idbobjectstore_get3-private.html: Added.
- indexeddb/idbobjectstore_get4-private-expected.txt: Added.
- indexeddb/idbobjectstore_get4-private.html: Added.
- indexeddb/idbobjectstore_get5-private-expected.txt: Added.
- indexeddb/idbobjectstore_get5-private.html: Added.
- indexeddb/idbobjectstore_get6-private-expected.txt: Added.
- indexeddb/idbobjectstore_get6-private.html: Added.
- indexeddb/idbobjectstore_get7-private-expected.txt: Added.
- indexeddb/idbobjectstore_get7-private.html: Added.
- indexeddb/idbobjectstore_index-private-expected.txt: Added.
- indexeddb/idbobjectstore_index-private.html: Added.
- indexeddb/idbobjectstore_openCursor-private-expected.txt: Added.
- indexeddb/idbobjectstore_openCursor-private.html: Added.
- indexeddb/idbobjectstore_openCursor_invalid-private-expected.txt: Added.
- indexeddb/idbobjectstore_openCursor_invalid-private.html: Added.
- indexeddb/idbobjectstore_put-private-expected.txt: Added.
- indexeddb/idbobjectstore_put-private.html: Added.
- indexeddb/idbobjectstore_put10-private-expected.txt: Added.
- indexeddb/idbobjectstore_put10-private.html: Added.
- indexeddb/idbobjectstore_put11-private-expected.txt: Added.
- indexeddb/idbobjectstore_put11-private.html: Added.
- indexeddb/idbobjectstore_put12-private-expected.txt: Added.
- indexeddb/idbobjectstore_put12-private.html: Added.
- indexeddb/idbobjectstore_put13-private-expected.txt: Added.
- indexeddb/idbobjectstore_put13-private.html: Added.
- indexeddb/idbobjectstore_put14-private-expected.txt: Added.
- indexeddb/idbobjectstore_put14-private.html: Added.
- indexeddb/idbobjectstore_put15-private-expected.txt: Added.
- indexeddb/idbobjectstore_put15-private.html: Added.
- indexeddb/idbobjectstore_put16-private-expected.txt: Added.
- indexeddb/idbobjectstore_put16-private.html: Added.
- indexeddb/idbobjectstore_put2-private-expected.txt: Added.
- indexeddb/idbobjectstore_put2-private.html: Added.
- indexeddb/idbobjectstore_put3-private-expected.txt: Added.
- indexeddb/idbobjectstore_put3-private.html: Added.
- indexeddb/idbobjectstore_put4-private-expected.txt: Added.
- indexeddb/idbobjectstore_put4-private.html: Added.
- indexeddb/idbobjectstore_put5-private-expected.txt: Added.
- indexeddb/idbobjectstore_put5-private.html: Added.
- indexeddb/idbobjectstore_put6-private-expected.txt: Added.
- indexeddb/idbobjectstore_put6-private.html: Added.
- indexeddb/idbobjectstore_put7-private-expected.txt: Added.
- indexeddb/idbobjectstore_put7-private.html: Added.
- indexeddb/idbobjectstore_put8-private-expected.txt: Added.
- indexeddb/idbobjectstore_put8-private.html: Added.
- indexeddb/idbobjectstore_put9-private-expected.txt: Added.
- indexeddb/idbobjectstore_put9-private.html: Added.
- indexeddb/idbtransaction-oncomplete-private-expected.txt: Added.
- indexeddb/idbtransaction-oncomplete-private.html: Added.
- indexeddb/idbtransaction-private-expected.txt: Added.
- indexeddb/idbtransaction-private.html: Added.
- indexeddb/idbtransaction_abort-private-expected.txt: Added.
- indexeddb/idbtransaction_abort-private.html: Added.
- indexeddb/idbversionchangeevent-private-expected.txt: Added.
- indexeddb/idbversionchangeevent-private.html: Added.
- indexeddb/index_sort_order-private-expected.txt: Added.
- indexeddb/index_sort_order-private.html: Added.
- indexeddb/key_invalid-private-expected.txt: Added.
- indexeddb/key_invalid-private.html: Added.
- indexeddb/key_valid-private-expected.txt: Added.
- indexeddb/key_valid-private.html: Added.
- indexeddb/keygenerator-constrainterror-private-expected.txt: Added.
- indexeddb/keygenerator-constrainterror-private.html: Added.
- indexeddb/keygenerator-overflow-private-expected.txt: Added.
- indexeddb/keygenerator-overflow-private.html: Added.
- indexeddb/keygenerator-private-expected.txt: Added.
- indexeddb/keygenerator-private.html: Added.
- indexeddb/keyorder-private-expected.txt: Added.
- indexeddb/keyorder-private.html: Added.
- indexeddb/keypath-private-expected.txt: Added.
- indexeddb/keypath-private.html: Added.
- indexeddb/keypath_invalid-private-expected.txt: Added.
- indexeddb/keypath_invalid-private.html: Added.
- indexeddb/keypath_maxsize-private-expected.txt: Added.
- indexeddb/keypath_maxsize-private.html: Added.
- indexeddb/list_ordering-private-expected.txt: Added.
- indexeddb/list_ordering-private.html: Added.
- indexeddb/objectstore_keyorder-private-expected.txt: Added.
- indexeddb/objectstore_keyorder-private.html: Added.
- indexeddb/request_bubble-and-capture-private-expected.txt: Added.
- indexeddb/request_bubble-and-capture-private.html: Added.
- indexeddb/string-list-ordering-private-expected.txt: Added.
- indexeddb/string-list-ordering-private.html: Added.
- indexeddb/transaction-create_in_versionchange-private-expected.txt: Added.
- indexeddb/transaction-create_in_versionchange-private.html: Added.
- indexeddb/transaction-lifetime-blocked-private-expected.txt: Added.
- indexeddb/transaction-lifetime-blocked-private.html: Added.
- indexeddb/transaction-lifetime-private-expected.txt: Added.
- indexeddb/transaction-lifetime-private.html: Added.
- indexeddb/transaction-requestqueue-private-expected.txt: Added.
- indexeddb/transaction-requestqueue-private.html: Added.
- indexeddb/transaction_bubble-and-capture-private-expected.txt: Added.
- indexeddb/transaction_bubble-and-capture-private.html: Added.
- indexeddb/value-private-expected.txt: Added.
- indexeddb/value-private.html: Added.
- indexeddb/value_recursive-private-expected.txt: Added.
- indexeddb/value_recursive-private.html: Added.
- indexeddb/writer-starvation-private-expected.txt: Added.
- indexeddb/writer-starvation-private.html: Added.
LayoutTests:
- platform/wk2/TestExpectations:
- 2:56 PM Changeset in webkit [195422] by
-
- 4 edits in trunk/Source/JavaScriptCore
[JSC] foldPathConstants() makes invalid assumptions with Switch
https://bugs.webkit.org/show_bug.cgi?id=153324
Reviewed by Filip Pizlo.
If a Switch() has two cases pointing to the same basic block, foldPathConstants()
was adding two override for that block with two different constants.
If the block with the Switch dominates the target, both override were equally valid
and we were assuming any of the constants as the value in the target block.
See testSwitchTargettingSameBlockFoldPathConstant() for an example that breaks.
This patch adds checks to ignore any block that is reached more than
once by the control value.
- b3/B3FoldPathConstants.cpp:
- b3/B3Generate.cpp:
(JSC::B3::generateToAir):
- b3/testb3.cpp:
(JSC::B3::testSwitchTargettingSameBlock):
(JSC::B3::testSwitchTargettingSameBlockFoldPathConstant):
(JSC::B3::run):
- 1:51 PM Changeset in webkit [195421] by
-
- 7 edits in trunk/Source
Add the ability to update WebKitAdditions to WK2
https://bugs.webkit.org/show_bug.cgi?id=153320
-and corresponding-
rdar://problem/23639629
Reviewed by Anders Carlsson.
Source/WebCore:
This SPI is un-used now.
- platform/spi/mac/NSSpellCheckerSPI.h:
Source/WebKit2:
- UIProcess/API/Cocoa/WKWebView.mm:
- UIProcess/API/mac/WKView.mm:
- UIProcess/Cocoa/WebViewImpl.h:
(WebKit::WebViewImpl::createWeakPtr):
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::updateWebViewImplAdditions):
(WebKit::WebViewImpl::showCandidates):
(WebKit::WebViewImpl::webViewImplAdditionsWillDestroyView):
(WebKit::trackingAreaOptions):
(WebKit::WebViewImpl::~WebViewImpl):
(WebKit::WebViewImpl::becomeFirstResponder):
(WebKit::WebViewImpl::selectionDidChange):
(WebKit::WebViewImpl::handleRequestedCandidates):
(WebKit::textCheckingResultFromNSTextCheckingResult):
- 1:37 PM Changeset in webkit [195420] by
-
- 3 edits in trunk/Source/WTF
REGRESSION(r195417): many tests crash
https://bugs.webkit.org/show_bug.cgi?id=153316
Reviewed by Saam Barati.
This rolls out the StdLibExtras.h change, and simplifies RangeSet to not use binary search.
That's fine for now, since B3 doesn't stress RangeSet enough right now.
- wtf/RangeSet.h:
(WTF::RangeSet::contains):
(WTF::RangeSet::overlaps):
(WTF::RangeSet::clear):
(WTF::RangeSet::findRange):
- wtf/StdLibExtras.h:
(WTF::binarySearchImpl):
(WTF::binarySearch):
(WTF::tryBinarySearch):
(WTF::approximateBinarySearch):
- 12:16 PM Changeset in webkit [195419] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, undo DFGCommon.h change that accidentally enabled the B3 JIT.
- dfg/DFGCommon.h:
- 12:15 PM Changeset in webkit [195418] by
-
- 4 edits in trunk/Source/JavaScriptCore
Move32 should have an Imm, Tmp form
https://bugs.webkit.org/show_bug.cgi?id=153313
Reviewed by Mark Lam.
This enables some useful optimizations, like constant propagation in fixObviousSpills().
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::zeroExtend32ToPtr):
(JSC::MacroAssemblerX86Common::move):
- b3/air/AirOpcode.opcodes:
- 11:54 AM Changeset in webkit [195417] by
-
- 15 edits5 adds in trunk/Source
B3 should have load elimination
https://bugs.webkit.org/show_bug.cgi?id=153288
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
This adds a complete GCSE pass that includes load elimination. It would have been super hard
to make this work as part of the reduceStrength() fixpoint, since GCSE needs to analyze
control flow and reduceStrength() is messing with control flow. So, I did a compromise: I
factored out the pure CSE that reduceStrength() was already doing, and now we have:
- reduceStrength() still does pure CSE using the new PureCSE helper.
- eliminateCommonSubexpressions() is a separate phase that does general CSE. It uses the PureCSE helper for pure values and does its own special thing for memory values.
Unfortunately, this doesn't help any benchmark right now. It doesn't hurt anything, either,
and it's likely to become a bigger pay-off once we implement other features, like mapping
FTL's abstract heaps onto B3's heap ranges.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- b3/B3EliminateCommonSubexpressions.cpp: Added.
(JSC::B3::eliminateCommonSubexpressions):
- b3/B3EliminateCommonSubexpressions.h: Added.
- b3/B3Generate.cpp:
(JSC::B3::generateToAir):
- b3/B3HeapRange.h:
(JSC::B3::HeapRange::HeapRange):
- b3/B3InsertionSet.h:
(JSC::B3::InsertionSet::InsertionSet):
(JSC::B3::InsertionSet::isEmpty):
(JSC::B3::InsertionSet::code):
(JSC::B3::InsertionSet::appendInsertion):
- b3/B3MemoryValue.h:
- b3/B3PureCSE.cpp: Added.
(JSC::B3::PureCSE::PureCSE):
(JSC::B3::PureCSE::~PureCSE):
(JSC::B3::PureCSE::clear):
(JSC::B3::PureCSE::process):
- b3/B3PureCSE.h: Added.
- b3/B3ReduceStrength.cpp:
- b3/B3ReduceStrength.h:
- b3/B3Validate.cpp:
Source/WTF:
I needed a way to track sets of ranges, where there is a high likelihood that all of the
ranges overlap. So I created RangeSet. It's a usually-sorted list of coalesced ranges.
Practically this means that right now, FTL B3 will end up with two kinds of range sets: a set
that just contains top and a set that contains nothing. In the future, most sets will either
be top of empty but some of them will contain a handful of other things.
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/MathExtras.h:
(WTF::leftShiftWithSaturation):
(WTF::nonEmptyRangesOverlap):
(WTF::rangesOverlap):
- wtf/RangeSet.h: Added.
(WTF::RangeSet::RangeSet):
(WTF::RangeSet::~RangeSet):
(WTF::RangeSet::add):
(WTF::RangeSet::contains):
(WTF::RangeSet::overlaps):
(WTF::RangeSet::clear):
(WTF::RangeSet::dump):
(WTF::RangeSet::dumpRaw):
(WTF::RangeSet::compact):
(WTF::RangeSet::overlapsNonEmpty):
(WTF::RangeSet::subsumesNonEmpty):
(WTF::RangeSet::findRange):
- wtf/StdLibExtras.h:
(WTF::binarySearchImpl):
(WTF::binarySearch):
(WTF::tryBinarySearch):
(WTF::approximateBinarySearch):
- 11:16 AM Changeset in webkit [195416] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
Fix bug in TypedArray.prototype.set and add tests
https://bugs.webkit.org/show_bug.cgi?id=153309
Reviewed by Michael Saboff.
This patch fixes an issue with TypedArray.prototype.set where we would
assign a double to an unsigned without checking that the double was
in the range of the unsigned. Additionally, the patch also adds
tests for set for cases that were not covered before.
- runtime/JSGenericTypedArrayViewPrototypeFunctions.h:
(JSC::genericTypedArrayViewProtoFuncSet):
- tests/stress/typedarray-set.js: Added.
- 11:00 AM Changeset in webkit [195415] by
-
- 2 edits in trunk/Source/WebCore
GraphicsContext: low quality drawImage and drawImageBuffer should use InterpolationLow
https://bugs.webkit.org/show_bug.cgi?id=49002
Reviewed by Chris Dumez.
When using low quality image scaling for images which are getting painted often,
the code used InterpolationNone, which make the images look even worse than they should.
Not easily testable.
- platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawImageBuffer):
(WebCore::GraphicsContext::drawConsumingImageBuffer):
- 10:58 AM Changeset in webkit [195414] by
-
- 1 edit1 delete in trunk/LayoutTests
Remove a ios-simulator-wk2 specific expectation file since the results are identical on wk1 and wk2
https://bugs.webkit.org/show_bug.cgi?id=152139
Unreviewed test gardening.
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt: Removed.
- 10:27 AM Changeset in webkit [195413] by
-
- 5 edits in branches/safari-601.1.46-branch/Source
Versioning.
- 10:25 AM Changeset in webkit [195412] by
-
- 16 edits1 move1 add in trunk/Source
Make it possible to enable VIDEO_PRESENTATION_MODE on other Cocoa platforms.
https://bugs.webkit.org/show_bug.cgi?id=153218
Reviewed by Eric Carlson.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
No new tests. Code refactoring.
- Configurations/FeatureDefines.xcconfig:
- WebCore.xcodeproj/project.pbxproj:
Move WebVideoFullscreenInterface.h from ios to cocoa.
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::webkitSupportsPresentationMode):
The declaration of supportsPictureInPicture() has been moved to WebVideoFullscreenInterface.h
so include that header instead. Guard the supportsPictureInPicture() call with PLATFORM(COCOA)
as that method is only defined in Cocoa.
- platform/cocoa/WebVideoFullscreenInterface.h: Renamed from Source/WebCore/platform/ios/WebVideoFullscreenInterface.h.
Also move the declaration of supportsPictureInPicture() here.
- platform/graphics/MediaPlayer.cpp:
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
Implementations of methods related to the video fullscreen layer are now guarded by
PLATFORM(IOS) (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE)) instead. - platform/ios/WebVideoFullscreenInterfaceAVKit.h:
Declaration of supportsPictureInPicture() has been moved to WebVideoFullscreenInterface.h
- platform/mac/WebVideoFullscreenInterfaceMac.mm: Added.
(WebCore::supportsPictureInPicture):
Return false for now.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/Platform.h:
- 9:50 AM Changeset in webkit [195411] by
-
- 13 edits4 adds in trunk
A crash reproducible in Path::isEmpty() under RenderSVGShape::paint()
https://bugs.webkit.org/show_bug.cgi?id=149613
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-01-21
Reviewed by Darin Adler.
Source/WebCore:
When RenderSVGRoot::layout() realizes its layout size has changed and
it has resources which have relative sizes, it marks all the clients of
the resources for invalidates regardless whether they belong to the
same RenderSVGRoot or not. But it reruns the layout only for its children.
If one of these clients comes before the current RenderSVGRoot in the render
tree, ee end up having renderer marked for invalidation at rendering time.
This also prevents scheduling the layout if the same renderer is marked
for another invalidation later. We prevent this because we do not want
to schedule another layout for a renderer which is already marked for
invalidation. This can cause crash if the renderer is an RenderSVGPath.
The fix is to mark "only" the clients of a resource which belong to the
same RenderSVGRoot of the resource. Also we need to run the layout for
all the resources which belong to different RenderSVGRoots before running
the layout for an SVG renderer.
Tests: svg/custom/filter-update-different-root.html
svg/custom/pattern-update-different-root.html
- rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::markAllClientsForInvalidation):
We should not mark any client outside the current root for invalidation
- rendering/svg/RenderSVGResourceContainer.h: Remove unneeded private keyword.
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::addResourceForClientInvalidation):
Code clean up; use findTreeRootObject() instead of repeating the same code.
- rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::isEmpty): Avoid crashing if RenderSVGShape::isEmpty()
is called before calling RenderSVGShape::layout().
- rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::layout): findTreeRootObject() now returns a pointer.
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::findTreeRootObject): I do think nothing
guarantees that an SVG renderer has to have an RenderSVGRoot in its
ancestors. So change this function to return a pointer. Also Provide
the non-const version of this function.
(WebCore::SVGRenderSupport::layoutDifferentRootIfNeeded): Runs the layout
if needed for all the resources which belong to different RenderSVGRoots.
(WebCore::SVGRenderSupport::layoutChildren): Make sure all the renderer's
resources which belong to different RenderSVGRoots are laid out before
running the layout for this renderer.
- rendering/svg/SVGRenderSupport.h: Remove a mysterious comment.
- rendering/svg/SVGResources.cpp:
(WebCore::SVGResources::layoutDifferentRootIfNeeded): Run the layout for
all the resources which belong to different RenderSVGRoots outside the
context of their RenderSVGRoots.
- rendering/svg/SVGResources.h:
(WebCore::SVGResources::clipper):
(WebCore::SVGResources::markerStart):
(WebCore::SVGResources::markerMid):
(WebCore::SVGResources::markerEnd):
(WebCore::SVGResources::masker):
(WebCore::SVGResources::filter):
(WebCore::SVGResources::fill):
(WebCore::SVGResources::stroke):
Code clean up; use nullptr instead of 0.
LayoutTests:
When running the layout of an SVG root and it has resources which are
referenced by clients in other SVG roots, make sure we run the layout
for these resources before running the layout for their clients.
- svg/custom/filter-update-different-root-expected.html: Added.
- svg/custom/filter-update-different-root.html: Added.
Without this patch this test crashes because we paint a dirty RenderSVGShape.
- svg/custom/pattern-update-different-root-expected.html: Added.
- svg/custom/pattern-update-different-root.html: Added.
Without this patch this test works fine but it is good to have it to catch
cases where the SVG root needs to run re-layout for its children resources
and hence their clients if its size has changed.
- svg/custom/unicode-in-tspan-multi-svg-crash-expected.txt:
- svg/custom/unicode-in-tspan-multi-svg-crash.html:
This test was ported from Blink in http://trac.webkit.org/changeset/166420.
The expectation of this test was changed in Blink:
https://src.chromium.org/viewvc/blink?revision=158480&view=revision.
- 9:15 AM Changeset in webkit [195410] by
-
- 21 edits2 copies in trunk/Source/WebCore
[EME] Correctly report errors when generating key requests from AVContentKeySession.
https://bugs.webkit.org/show_bug.cgi?id=151963
Reviewed by Eric Carlson.
WebIDL's "unsigned long" is a 32-bit unsigned integer, and C++'s "unsigned long" is (or, can
be) a 64-bit integer on 64-bit platforms. Casting a negative integer to a 64-bit integer
results in a number which cannot be accurately stored in a double-length floating point
number. Previously, the mac CDM code would work around this issue by returning the absolute
value of NSError code returned by media frameworks. Instead, fix the underlying problem by
storing the MediaKeyError's systemCode as a uint32_t (which more accurately represents the
size of a WebIDL "unsigned long" on all platforms.)
Check the error code issued by -contentKeyRequestDataForApp:contentIdentifier:options:error:.
- Modules/encryptedmedia/CDM.h:
- Modules/encryptedmedia/CDMSessionClearKey.cpp:
(WebCore::CDMSessionClearKey::generateKeyRequest):
(WebCore::CDMSessionClearKey::update):
- Modules/encryptedmedia/CDMSessionClearKey.h:
- Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::keyRequestTimerFired):
(WebCore::MediaKeySession::addKeyTimerFired):
(WebCore::MediaKeySession::sendError):
- Modules/encryptedmedia/MediaKeySession.h:
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.handleReadyStateChange):
- WebCore.xcodeproj/project.pbxproj:
- html/MediaKeyError.h:
(WebCore::MediaKeyError::create):
(WebCore::MediaKeyError::systemCode):
- html/MediaKeyEvent.h:
- platform/graphics/CDMSession.h:
- platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.cpp:
(WebCore::CDMSessionAVFoundationCF::generateKeyRequest):
(WebCore::CDMSessionAVFoundationCF::update):
- platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.h:
- platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.h:
- platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:
(WebCore::CDMSessionAVContentKeySession::generateKeyRequest):
(WebCore::CDMSessionAVContentKeySession::update):
(WebCore::CDMSessionAVContentKeySession::generateKeyReleaseMessage):
- platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm:
(WebCore::CDMSessionAVFoundationObjC::generateKeyRequest):
(WebCore::CDMSessionAVFoundationObjC::update):
- platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.h:
- platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:
(WebCore::CDMSessionAVStreamSession::generateKeyRequest):
(WebCore::CDMSessionAVStreamSession::update):
(WebCore::CDMSessionAVStreamSession::generateKeyReleaseMessage):
- platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:
(WebCore::CDMSessionMediaSourceAVFObjC::layerDidReceiveError):
(WebCore::CDMSessionMediaSourceAVFObjC::rendererDidReceiveError):
(WebCore::CDMSessionMediaSourceAVFObjC::systemCodeForError): Deleted.
- testing/MockCDM.cpp:
(WebCore::MockCDMSession::generateKeyRequest):
(WebCore::MockCDMSession::update):2016-01-15 Simon Fraser <Simon Fraser>
- 7:47 AM Changeset in webkit [195409] by
-
- 2 edits in trunk/Tools
display-profiler-output should be able to display code blocks sorted by machine counts
https://bugs.webkit.org/show_bug.cgi?id=153298
Reviewed by Oliver Hunt.
- Scripts/display-profiler-output:
- 7:27 AM Changeset in webkit [195408] by
-
- 3 edits in trunk/Tools
Ensure to use compatible liborc version with wanted gstreamer version
https://bugs.webkit.org/show_bug.cgi?id=153276
For example gst-plugins-base-1.4.4 fails to build with liborc-0.4.24.
The user may have a very recent liborc installed on his system.
Patch by Julien Isorce <j.isorce@samsung.com> on 2016-01-21
Reviewed by Philippe Normand.
- efl/jhbuild.modules: add liborc-0.4.17 and make it a gst dependency.
- gtk/jhbuild.modules: add liborc-0.4.17 and make it a gst depencendy.
- 4:51 AM Changeset in webkit [195407] by
-
- 2 edits in trunk/Source/JavaScriptCore
[B3][CMake] Add missing source file.
https://bugs.webkit.org/show_bug.cgi?id=153303
Reviewed by Csaba Osztrogonác.
- CMakeLists.txt:
- 1:17 AM Changeset in webkit [195406] by
-
- 2 edits in trunk/Source/WebCore
[SOUP] GResource resources should be cached indefinitely in memory cache
https://bugs.webkit.org/show_bug.cgi?id=153275
Reviewed by Žan Doberšek.
GResources can't change so they will always return the same data,
we never need to revalidate them.
- loader/cache/CachedResource.cpp:
(WebCore::shouldCacheSchemeIndefinitely):
- 12:35 AM Changeset in webkit [195405] by
-
- 15 edits1 copy4 moves1 add in trunk
AX: [IOS] Implement next/previous text marker functions using TextIterator
https://bugs.webkit.org/show_bug.cgi?id=153292
<rdar://problem/24268243>
Reviewed by Chris Fleizach.
Source/WebCore:
Added support for the refactored next/previous text marker functions on iOS. And
made text marker tests working on iOS.
Also, fixed an issue in AXObjectCache where creating a range with a replaced node
at the start or end might exclude that node.
Tests: accessibility/text-marker/text-marker-previous-next.html
accessibility/text-marker/text-marker-with-user-select-none.html
- accessibility/AXObjectCache.cpp:
(WebCore::characterOffsetsInOrder):
(WebCore::resetNodeAndOffsetForReplacedNode):
(WebCore::AXObjectCache::rangeForUnorderedCharacterOffsets):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(+[WebAccessibilityTextMarker textMarkerWithVisiblePosition:cache:]):
(+[WebAccessibilityTextMarker textMarkerWithCharacterOffset:cache:]):
(+[WebAccessibilityTextMarker startOrEndTextMarkerForRange:isStart:cache:]):
(-[WebAccessibilityTextMarker dataRepresentation]):
(-[WebAccessibilityTextMarker visiblePosition]):
(-[WebAccessibilityTextMarker characterOffset]):
(-[WebAccessibilityTextMarker isIgnored]):
(-[WebAccessibilityTextMarker accessibilityObject]):
(-[WebAccessibilityTextMarker description]):
(-[WebAccessibilityObjectWrapper stringForTextMarkers:]):
(blockquoteLevel):
(-[WebAccessibilityObjectWrapper textMarkerRange]):
(-[WebAccessibilityObjectWrapper accessibilityObjectForTextMarker:]):
(-[WebAccessibilityObjectWrapper nextMarkerForMarker:]):
(-[WebAccessibilityObjectWrapper previousMarkerForMarker:]):
(-[WebAccessibilityObjectWrapper textMarkerForPoint:]):
(-[WebAccessibilityObjectWrapper nextMarkerForCharacterOffset:]):
(-[WebAccessibilityObjectWrapper previousMarkerForCharacterOffset:]):
(-[WebAccessibilityObjectWrapper rangeForTextMarkers:]):
(-[WebAccessibilityObjectWrapper lengthForTextMarkers:]):
(-[WebAccessibilityObjectWrapper startOrEndTextMarkerForTextMarkers:isStart:]):
(-[WebAccessibilityObjectWrapper textMarkerRangeForMarkers:]):
(-[WebAccessibilityObjectWrapper accessibilityIdentifier]):
Tools:
Made text marker tests available on iOS.
- DumpRenderTree/AccessibilityTextMarker.h:
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/ios/AccessibilityTextMarkerIOS.mm: Added.
(AccessibilityTextMarker::AccessibilityTextMarker):
(AccessibilityTextMarker::~AccessibilityTextMarker):
(AccessibilityTextMarker::isEqual):
(AccessibilityTextMarker::platformTextMarker):
(AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
(AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
(AccessibilityTextMarkerRange::isEqual):
(AccessibilityTextMarkerRange::platformTextMarkerRange):
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::pathDescription):
(AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
(AccessibilityUIElement::textMarkerRangeForElement):
(AccessibilityUIElement::selectedTextMarkerRange):
(AccessibilityUIElement::resetSelectedTextMarkerRange):
(AccessibilityUIElement::textMarkerRangeLength):
(AccessibilityUIElement::textMarkerRangeForMarkers):
(AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(AccessibilityUIElement::accessibilityElementForTextMarker):
(AccessibilityUIElement::endTextMarkerForBounds):
(AccessibilityUIElement::startTextMarkerForBounds):
(AccessibilityUIElement::textMarkerForPoint):
(AccessibilityUIElement::previousTextMarker):
(AccessibilityUIElement::nextTextMarker):
(AccessibilityUIElement::stringForTextMarkerRange):
(AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
(AccessibilityUIElement::indexForTextMarker):
(AccessibilityUIElement::isTextMarkerValid):
(AccessibilityUIElement::textMarkerForIndex):
(AccessibilityUIElement::startTextMarker):
(AccessibilityUIElement::endTextMarker):
(AccessibilityUIElement::setSelectedVisibleTextRange):
(AccessibilityUIElement::getLinkedUIElements):
- DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
(AccessibilityTextMarkerRange::platformTextMarkerRange):
- DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::removeSelection):
(AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
(AccessibilityUIElement::setSelectedVisibleTextRange):
(AccessibilityUIElement::supportedActions):
- WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
(WTR::AccessibilityUIElement::textMarkerRangeForElement):
(WTR::AccessibilityUIElement::textMarkerRangeLength):
(WTR::AccessibilityUIElement::previousTextMarker):
(WTR::AccessibilityUIElement::nextTextMarker):
(WTR::AccessibilityUIElement::stringForTextMarkerRange):
(WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
(WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForBounds):
(WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
(WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
LayoutTests:
- accessibility/mac/previous-next-text-marker-expected.txt: Removed.
- accessibility/mac/previous-next-text-marker.html: Removed.
- accessibility/mac/text-marker-with-user-select-none-expected.txt: Removed.
- accessibility/mac/text-marker-with-user-select-none.html: Removed.
- accessibility/text-marker: Added.
- accessibility/text-marker/text-marker-previous-next-expected.txt: Added.
- accessibility/text-marker/text-marker-previous-next.html: Added.
- accessibility/text-marker/text-marker-with-user-select-none-expected.txt: Added.
- accessibility/text-marker/text-marker-with-user-select-none.html: Added.
- platform/efl/TestExpectations:
- platform/gtk/TestExpectations:
- platform/ios-simulator/TestExpectations:
- platform/win/TestExpectations:
Jan 20, 2016:
- 11:59 PM Changeset in webkit [195404] by
-
- 1 edit1 copy in branches/safari-601-branch/LayoutTests
Merged r188383. rdar://problem/24208102
- 11:58 PM Changeset in webkit [195403] by
-
- 6 edits2 copies in branches/safari-601-branch
Merged r188377. rdar://problem/24208102
- 11:57 PM Changeset in webkit [195402] by
-
- 7 edits2 copies in branches/safari-601-branch
Merged r188263. rdar://problem/24208102
- 11:16 PM Changeset in webkit [195401] by
-
- 6 edits in branches/safari-601.1.46-branch/Source/WebCore
Merged r195132. rdar://problem/24154424
- 11:13 PM Changeset in webkit [195400] by
-
- 5 edits15 copies in branches/safari-601.1.46-branch
Merged r195075. rdar://problem/24001776
- 11:11 PM Changeset in webkit [195399] by
-
- 4 edits4 copies in branches/safari-601.1.46-branch
Merged r195162. rdar://problem/23978912
- 8:47 PM Changeset in webkit [195398] by
-
- 2 edits1 delete in trunk/Source/JavaScriptCore
Unreviewed, rolling out r195375.
https://bugs.webkit.org/show_bug.cgi?id=153300
Caused crashes on GuardMalloc (Requested by ap on #webkit).
Reverted changeset:
"TypedArray's .buffer does not return the JSArrayBuffer that
was passed to it on creation."
https://bugs.webkit.org/show_bug.cgi?id=153281
http://trac.webkit.org/changeset/195375
- 7:50 PM Changeset in webkit [195397] by
-
- 5 edits2 adds in trunk
http://victordarras.fr/cssgame/ doesn't work in Safari.
https://bugs.webkit.org/show_bug.cgi?id=153285
<rdar://problem/24212369>
Reviewed by Tim Horton.
This patch adds support for hittesting ClipPathOperation::Reference.
Source/WebCore:
Tests: svg/clip-path/hittest-clip-path-reference-miss.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
- rendering/RenderObject.h:
(WebCore::RenderObject::isSVGResourceClipper):
- rendering/svg/RenderSVGResourceClipper.h:
(isType):
LayoutTests:
- svg/clip-path/hittest-clip-path-reference-miss-expected.html: Added.
- svg/clip-path/hittest-clip-path-reference-miss.html: Added.
- 7:20 PM Changeset in webkit [195396] by
-
- 2 edits in trunk/Tools
Unreviewed, revert accidental unreviewed commit.
- Scripts/display-profiler-output:
- 7:12 PM Changeset in webkit [195395] by
-
- 57 edits11 adds in trunk
B3 should have basic path specialization
https://bugs.webkit.org/show_bug.cgi?id=153200
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
This adds two different kind of path specializations:
- Check(Select) where the Select results are constants is specialized into a Branch instead of a Select and duplicated paths where the results of the Select are folded.
- Tail duplication. A jump to a small block causes the block's contents to be copied over the Jump.
Both optimizations required being able to clone Values. We can now do that using
proc.clone(value).
Check(Select) specialization needed some utilities for walking graphs of Values.
Tail duplication needed SSA fixup, so I added a way to demote values to anonymous stack
slots (B3's equivalent of non-SSA variables) and a way to "fix SSA", i.e. to allocate
anonymous stack slots to SSA values along with an optimal Phi graph.
This is a big speed-up on Octane/deltablue. It's a 2.2% speed-up on Octane overall.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- b3/B3ArgumentRegValue.cpp:
(JSC::B3::ArgumentRegValue::dumpMeta):
(JSC::B3::ArgumentRegValue::cloneImpl):
- b3/B3ArgumentRegValue.h:
- b3/B3BasicBlock.cpp:
(JSC::B3::BasicBlock::append):
(JSC::B3::BasicBlock::appendNonTerminal):
(JSC::B3::BasicBlock::removeLast):
- b3/B3BasicBlock.h:
(JSC::B3::BasicBlock::values):
- b3/B3BasicBlockInlines.h:
(JSC::B3::BasicBlock::appendNew):
(JSC::B3::BasicBlock::appendNewNonTerminal):
(JSC::B3::BasicBlock::replaceLastWithNew):
- b3/B3BlockInsertionSet.h:
- b3/B3BreakCriticalEdges.cpp: Added.
(JSC::B3::breakCriticalEdges):
- b3/B3BreakCriticalEdges.h: Added.
- b3/B3CCallValue.cpp:
(JSC::B3::CCallValue::~CCallValue):
(JSC::B3::CCallValue::cloneImpl):
- b3/B3CCallValue.h:
- b3/B3CheckValue.cpp:
(JSC::B3::CheckValue::convertToAdd):
(JSC::B3::CheckValue::cloneImpl):
(JSC::B3::CheckValue::CheckValue):
- b3/B3CheckValue.h:
- b3/B3Const32Value.cpp:
(JSC::B3::Const32Value::dumpMeta):
(JSC::B3::Const32Value::cloneImpl):
- b3/B3Const32Value.h:
- b3/B3Const64Value.cpp:
(JSC::B3::Const64Value::dumpMeta):
(JSC::B3::Const64Value::cloneImpl):
- b3/B3Const64Value.h:
- b3/B3ConstDoubleValue.cpp:
(JSC::B3::ConstDoubleValue::dumpMeta):
(JSC::B3::ConstDoubleValue::cloneImpl):
- b3/B3ConstDoubleValue.h:
- b3/B3ConstFloatValue.cpp:
(JSC::B3::ConstFloatValue::dumpMeta):
(JSC::B3::ConstFloatValue::cloneImpl):
- b3/B3ConstFloatValue.h:
- b3/B3ControlValue.cpp:
(JSC::B3::ControlValue::dumpMeta):
(JSC::B3::ControlValue::cloneImpl):
- b3/B3ControlValue.h:
- b3/B3DuplicateTails.cpp: Added.
(JSC::B3::duplicateTails):
- b3/B3DuplicateTails.h: Added.
- b3/B3FixSSA.cpp: Added.
(JSC::B3::demoteValues):
(JSC::B3::fixSSA):
- b3/B3FixSSA.h: Added.
- b3/B3Generate.cpp:
(JSC::B3::generateToAir):
- b3/B3IndexSet.h:
(JSC::B3::IndexSet::Iterable::Iterable):
(JSC::B3::IndexSet::values):
(JSC::B3::IndexSet::indices):
- b3/B3InsertionSet.cpp:
(JSC::B3::InsertionSet::insertIntConstant):
(JSC::B3::InsertionSet::insertBottom):
(JSC::B3::InsertionSet::execute):
- b3/B3InsertionSet.h:
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::run):
(JSC::B3::Air::LowerToAir::tmp):
- b3/B3MemoryValue.cpp:
(JSC::B3::MemoryValue::dumpMeta):
(JSC::B3::MemoryValue::cloneImpl):
- b3/B3MemoryValue.h:
- b3/B3OriginDump.cpp: Added.
(JSC::B3::OriginDump::dump):
- b3/B3OriginDump.h:
(JSC::B3::OriginDump::OriginDump):
(JSC::B3::OriginDump::dump): Deleted.
- b3/B3PatchpointValue.cpp:
(JSC::B3::PatchpointValue::dumpMeta):
(JSC::B3::PatchpointValue::cloneImpl):
(JSC::B3::PatchpointValue::PatchpointValue):
- b3/B3PatchpointValue.h:
- b3/B3Procedure.cpp:
(JSC::B3::Procedure::addBlock):
(JSC::B3::Procedure::clone):
(JSC::B3::Procedure::addIntConstant):
(JSC::B3::Procedure::addBottom):
(JSC::B3::Procedure::addBoolConstant):
(JSC::B3::Procedure::deleteValue):
- b3/B3Procedure.h:
- b3/B3ReduceStrength.cpp:
- b3/B3SSACalculator.cpp: Added.
(JSC::B3::SSACalculator::Variable::dump):
(JSC::B3::SSACalculator::Variable::dumpVerbose):
(JSC::B3::SSACalculator::Def::dump):
(JSC::B3::SSACalculator::SSACalculator):
(JSC::B3::SSACalculator::~SSACalculator):
(JSC::B3::SSACalculator::reset):
(JSC::B3::SSACalculator::newVariable):
(JSC::B3::SSACalculator::newDef):
(JSC::B3::SSACalculator::nonLocalReachingDef):
(JSC::B3::SSACalculator::reachingDefAtTail):
(JSC::B3::SSACalculator::dump):
- b3/B3SSACalculator.h: Added.
(JSC::B3::SSACalculator::Variable::index):
(JSC::B3::SSACalculator::Variable::Variable):
(JSC::B3::SSACalculator::Def::variable):
(JSC::B3::SSACalculator::Def::block):
(JSC::B3::SSACalculator::Def::value):
(JSC::B3::SSACalculator::Def::Def):
(JSC::B3::SSACalculator::variable):
(JSC::B3::SSACalculator::computePhis):
(JSC::B3::SSACalculator::phisForBlock):
(JSC::B3::SSACalculator::reachingDefAtHead):
- b3/B3StackSlotKind.h:
- b3/B3StackSlotValue.cpp:
(JSC::B3::StackSlotValue::dumpMeta):
(JSC::B3::StackSlotValue::cloneImpl):
- b3/B3StackSlotValue.h:
- b3/B3SwitchValue.cpp:
(JSC::B3::SwitchValue::dumpMeta):
(JSC::B3::SwitchValue::cloneImpl):
(JSC::B3::SwitchValue::SwitchValue):
- b3/B3SwitchValue.h:
- b3/B3UpsilonValue.cpp:
(JSC::B3::UpsilonValue::dumpMeta):
(JSC::B3::UpsilonValue::cloneImpl):
- b3/B3UpsilonValue.h:
- b3/B3Validate.cpp:
- b3/B3Value.cpp:
(JSC::B3::Value::replaceWithNop):
(JSC::B3::Value::replaceWithPhi):
(JSC::B3::Value::dump):
(JSC::B3::Value::cloneImpl):
(JSC::B3::Value::dumpChildren):
(JSC::B3::Value::deepDump):
- b3/B3Value.h:
(JSC::B3::DeepValueDump::DeepValueDump):
(JSC::B3::DeepValueDump::dump):
(JSC::B3::deepDump):
- b3/B3ValueInlines.h:
(JSC::B3::Value::asNumber):
(JSC::B3::Value::walk):
- b3/B3ValueKey.cpp:
(JSC::B3::ValueKey::intConstant):
(JSC::B3::ValueKey::dump):
- b3/B3ValueKey.h:
(JSC::B3::ValueKey::ValueKey):
(JSC::B3::ValueKey::opcode):
(JSC::B3::ValueKey::type):
(JSC::B3::ValueKey::childIndex):
- b3/air/AirCode.h:
(JSC::B3::Air::Code::forAllTmps):
(JSC::B3::Air::Code::isFastTmp):
- b3/air/AirIteratedRegisterCoalescing.cpp:
- b3/air/AirUseCounts.h:
(JSC::B3::Air::UseCounts::UseCounts):
(JSC::B3::Air::UseCounts::operator[]):
(JSC::B3::Air::UseCounts::dump):
- b3/testb3.cpp:
(JSC::B3::testSelectInvert):
(JSC::B3::testCheckSelect):
(JSC::B3::testCheckSelectCheckSelect):
(JSC::B3::testPowDoubleByIntegerLoop):
(JSC::B3::run):
- runtime/Options.h:
Source/WTF:
- wtf/GraphNodeWorklist.h:
(WTF::GraphNodeWorklist::push):
(WTF::GraphNodeWorklist::pushAll):
(WTF::GraphNodeWorklist::isEmpty):
(WTF::GraphNodeWorklist::notEmpty):
- 6:13 PM Changeset in webkit [195394] by
-
- 11 edits280 adds2 deletes in trunk/LayoutTests
Modern IDB: Add -private.html variants of every storage/indexeddb test that doesn't already have them.
https://bugs.webkit.org/show_bug.cgi?id=153272
Reviewed by Alex Christensen.
This includes some cleanups to the shared js files to make each test more resilient to being run twice.
- TestExpectations:
- platform/mac-wk1/TestExpectations:
- platform/wk2/TestExpectations:
- storage/indexeddb/clone-exception-private-expected.txt: Added.
- storage/indexeddb/clone-exception-private.html: Added.
- storage/indexeddb/closed-cursor-private-expected.txt: Added.
- storage/indexeddb/closed-cursor-private.html: Added.
- storage/indexeddb/connection-leak-private-expected.txt: Added.
- storage/indexeddb/connection-leak-private.html: Added.
- storage/indexeddb/cursor-cast-private-expected.txt: Added.
- storage/indexeddb/cursor-cast-private.html: Added.
- storage/indexeddb/cursor-leak-private-expected.txt: Added.
- storage/indexeddb/cursor-leak-private.html: Added.
- storage/indexeddb/cursor-overloads-private-expected.txt: Added.
- storage/indexeddb/cursor-overloads-private.html: Added.
- storage/indexeddb/cursor-request-cycle-private-expected.txt: Added.
- storage/indexeddb/cursor-request-cycle-private.html: Added.
- storage/indexeddb/deleteIndex-bug110792-private-expected.txt: Added.
- storage/indexeddb/deleteIndex-bug110792-private.html: Added.
- storage/indexeddb/deletedatabase-delayed-by-versionchange-private-expected.txt: Removed.
- storage/indexeddb/deletedatabase-transaction-private-expected.txt: Added.
- storage/indexeddb/deletedatabase-transaction-private.html: Added.
- storage/indexeddb/dont-commit-on-blocked-private-expected.txt: Added.
- storage/indexeddb/dont-commit-on-blocked-private.html: Added.
- storage/indexeddb/lazy-index-population-private-expected.txt: Added.
- storage/indexeddb/lazy-index-population-private.html: Added.
- storage/indexeddb/metadata-race-private-expected.txt: Added.
- storage/indexeddb/metadata-race-private.html: Added.
- storage/indexeddb/modern/abort-objectstore-info-private-expected.txt: Added.
- storage/indexeddb/modern/abort-objectstore-info-private.html: Added.
- storage/indexeddb/modern/abort-requests-cancelled-private-expected.txt: Added.
- storage/indexeddb/modern/abort-requests-cancelled-private.html: Added.
- storage/indexeddb/modern/aborted-put-private-expected.txt: Added.
- storage/indexeddb/modern/aborted-put-private.html: Added.
- storage/indexeddb/modern/autoincrement-abort-private-expected.txt: Added.
- storage/indexeddb/modern/autoincrement-abort-private.html: Added.
- storage/indexeddb/modern/basic-add-private-expected.txt: Added.
- storage/indexeddb/modern/basic-add-private.html: Added.
- storage/indexeddb/modern/basic-put-private-expected.txt: Added.
- storage/indexeddb/modern/basic-put-private.html: Added.
- storage/indexeddb/modern/blocked-open-db-requests-private-expected.txt: Added.
- storage/indexeddb/modern/blocked-open-db-requests-private.html: Added.
- storage/indexeddb/modern/create-index-failures-private-expected.txt: Added.
- storage/indexeddb/modern/create-index-failures-private.html: Added.
- storage/indexeddb/modern/createobjectstore-basic-private-expected.txt: Added.
- storage/indexeddb/modern/createobjectstore-basic-private.html: Added.
- storage/indexeddb/modern/createobjectstore-failures-private-expected.txt: Added.
- storage/indexeddb/modern/createobjectstore-failures-private.html: Added.
- storage/indexeddb/modern/cursor-1-private-expected.txt: Added.
- storage/indexeddb/modern/cursor-1-private.html: Added.
- storage/indexeddb/modern/cursor-2-private-expected.txt: Added.
- storage/indexeddb/modern/cursor-2-private.html: Added.
- storage/indexeddb/modern/cursor-3-private-expected.txt: Added.
- storage/indexeddb/modern/cursor-3-private.html: Added.
- storage/indexeddb/modern/cursor-4-private-expected.txt: Added.
- storage/indexeddb/modern/cursor-4-private.html: Added.
- storage/indexeddb/modern/cursor-5-private-expected.txt: Added.
- storage/indexeddb/modern/cursor-5-private.html: Added.
- storage/indexeddb/modern/cursor-6-private-expected.txt: Added.
- storage/indexeddb/modern/cursor-6-private.html: Added.
- storage/indexeddb/modern/cursor-7-private-expected.txt: Added.
- storage/indexeddb/modern/cursor-7-private.html: Added.
- storage/indexeddb/modern/cursor-8-private-expected.txt: Added.
- storage/indexeddb/modern/cursor-8-private.html: Added.
- storage/indexeddb/modern/date-basic-private-expected.txt: Added.
- storage/indexeddb/modern/date-basic-private.html: Added.
- storage/indexeddb/modern/deletedatabase-1-private-expected.txt: Added.
- storage/indexeddb/modern/deletedatabase-1-private.html: Added.
- storage/indexeddb/modern/deletedatabase-2-private-expected.txt: Added.
- storage/indexeddb/modern/deletedatabase-2-private.html: Added.
- storage/indexeddb/modern/deletedatabase-null-name-exception-private-expected.txt: Added.
- storage/indexeddb/modern/deletedatabase-null-name-exception-private.html: Added.
- storage/indexeddb/modern/deletedatabase-request-event-private-expected.txt: Added.
- storage/indexeddb/modern/deletedatabase-request-event-private.html: Added.
- storage/indexeddb/modern/deletedatabase-request-private-expected.txt: Added.
- storage/indexeddb/modern/deletedatabase-request-private.html: Added.
- storage/indexeddb/modern/deleteindex-1-private-expected.txt: Added.
- storage/indexeddb/modern/deleteindex-1-private.html: Added.
- storage/indexeddb/modern/deleteindex-2-private-expected.txt: Added.
- storage/indexeddb/modern/deleteindex-2-private.html: Added.
- storage/indexeddb/modern/deleteobjectstore-1-private-expected.txt: Added.
- storage/indexeddb/modern/deleteobjectstore-1-private.html: Added.
- storage/indexeddb/modern/double-abort-private-expected.txt: Added.
- storage/indexeddb/modern/double-abort-private.html: Added.
- storage/indexeddb/modern/double-open-private-expected.txt: Added.
- storage/indexeddb/modern/double-open-private.html: Added.
- storage/indexeddb/modern/get-index-failures-private-expected.txt: Added.
- storage/indexeddb/modern/get-index-failures-private.html: Added.
- storage/indexeddb/modern/get-keyrange-private-expected.txt: Added.
- storage/indexeddb/modern/get-keyrange-private.html: Added.
- storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures-private-expected.txt: Added.
- storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures-private.html: Added.
- storage/indexeddb/modern/idbdatabase-transaction-failures-private-expected.txt: Added.
- storage/indexeddb/modern/idbdatabase-transaction-failures-private.html: Added.
- storage/indexeddb/modern/idbindex-properties-basic-private-expected.txt: Added.
- storage/indexeddb/modern/idbindex-properties-basic-private.html: Added.
- storage/indexeddb/modern/idbobjectstore-clear-1-private-expected.txt: Added.
- storage/indexeddb/modern/idbobjectstore-clear-1-private.html: Added.
- storage/indexeddb/modern/idbobjectstore-clear-2-private-expected.txt: Added.
- storage/indexeddb/modern/idbobjectstore-clear-2-private.html: Added.
- storage/indexeddb/modern/idbobjectstore-count-1-private-expected.txt: Added.
- storage/indexeddb/modern/idbobjectstore-count-1-private.html: Added.
- storage/indexeddb/modern/idbobjectstore-count-failures-private-expected.txt: Added.
- storage/indexeddb/modern/idbobjectstore-count-failures-private.html: Added.
- storage/indexeddb/modern/idbobjectstore-delete-1-private-expected.txt: Added.
- storage/indexeddb/modern/idbobjectstore-delete-1-private.html: Added.
- storage/indexeddb/modern/idbobjectstore-delete-2-private-expected.txt: Added.
- storage/indexeddb/modern/idbobjectstore-delete-2-private.html: Added.
- storage/indexeddb/modern/idbobjectstore-delete-failures-private-expected.txt: Added.
- storage/indexeddb/modern/idbobjectstore-delete-failures-private.html: Added.
- storage/indexeddb/modern/idbobjectstore-get-failures-private-expected.txt: Added.
- storage/indexeddb/modern/idbobjectstore-get-failures-private.html: Added.
- storage/indexeddb/modern/idbobjectstore-put-and-clear-failures-private-expected.txt: Added.
- storage/indexeddb/modern/idbobjectstore-put-and-clear-failures-private.html: Added.
- storage/indexeddb/modern/idbtransaction-objectstore-failures-private-expected.txt: Added.
- storage/indexeddb/modern/idbtransaction-objectstore-failures-private.html: Added.
- storage/indexeddb/modern/index-1-private-expected.txt: Added.
- storage/indexeddb/modern/index-1-private.html: Added.
- storage/indexeddb/modern/index-2-private-expected.txt: Added.
- storage/indexeddb/modern/index-2-private.html: Added.
- storage/indexeddb/modern/index-3-private-expected.txt: Added.
- storage/indexeddb/modern/index-3-private.html: Added.
- storage/indexeddb/modern/index-4-private-expected.txt: Added.
- storage/indexeddb/modern/index-4-private.html: Added.
- storage/indexeddb/modern/index-5-private-expected.txt: Added.
- storage/indexeddb/modern/index-5-private.html: Added.
- storage/indexeddb/modern/index-cursor-1-private-expected.txt: Added.
- storage/indexeddb/modern/index-cursor-1-private.html: Added.
- storage/indexeddb/modern/index-cursor-2-private-expected.txt: Added.
- storage/indexeddb/modern/index-cursor-2-private.html: Added.
- storage/indexeddb/modern/index-cursor-3-private-expected.txt: Added.
- storage/indexeddb/modern/index-cursor-3-private.html: Added.
- storage/indexeddb/modern/index-get-count-basic-private-expected.txt: Added.
- storage/indexeddb/modern/index-get-count-basic-private.html: Added.
- storage/indexeddb/modern/index-get-count-failures-private-expected.txt: Added.
- storage/indexeddb/modern/index-get-count-failures-private.html: Added.
- storage/indexeddb/modern/keypath-basic-private-expected.txt: Added.
- storage/indexeddb/modern/keypath-basic-private.html: Added.
- storage/indexeddb/modern/memory-index-not-deleted-with-objectstore-private-expected.txt: Added.
- storage/indexeddb/modern/memory-index-not-deleted-with-objectstore-private.html: Added.
- storage/indexeddb/modern/objectstore-attributes-private-expected.txt: Added.
- storage/indexeddb/modern/objectstore-attributes-private.html: Added.
- storage/indexeddb/modern/objectstore-cursor-advance-failures-private-expected.txt: Added.
- storage/indexeddb/modern/objectstore-cursor-advance-failures-private.html: Added.
- storage/indexeddb/modern/objectstore-cursor-continue-failures-private-expected.txt: Added.
- storage/indexeddb/modern/objectstore-cursor-continue-failures-private.html: Added.
- storage/indexeddb/modern/opencursor-failures-private-expected.txt: Added.
- storage/indexeddb/modern/opencursor-failures-private.html: Added.
- storage/indexeddb/modern/opendatabase-request-event-private-expected.txt: Added.
- storage/indexeddb/modern/opendatabase-request-event-private.html: Added.
- storage/indexeddb/modern/opendatabase-request-private-expected.txt: Added.
- storage/indexeddb/modern/opendatabase-request-private.html: Added.
- storage/indexeddb/modern/opendatabase-success-after-versionchange-private-expected.txt: Added.
- storage/indexeddb/modern/opendatabase-success-after-versionchange-private.html: Added.
- storage/indexeddb/modern/opendatabase-versions-private-expected.txt: Added.
- storage/indexeddb/modern/opendatabase-versions-private.html: Added.
- storage/indexeddb/modern/request-readystate-private-expected.txt: Added.
- storage/indexeddb/modern/request-readystate-private.html: Added.
- storage/indexeddb/modern/resources/opendatabase-request-event.js:
- storage/indexeddb/modern/resources/opendatabase-versions.js:
- storage/indexeddb/modern/resources/request-readystate.js:
- storage/indexeddb/modern/resources/versionchange-abort-then-reopen.js:
- storage/indexeddb/modern/transaction-scheduler-1-private-expected.txt: Added.
- storage/indexeddb/modern/transaction-scheduler-1-private.html: Added.
- storage/indexeddb/modern/transaction-scheduler-2-private-expected.txt: Added.
- storage/indexeddb/modern/transaction-scheduler-2-private.html: Added.
- storage/indexeddb/modern/transaction-scheduler-3-private-expected.txt: Added.
- storage/indexeddb/modern/transaction-scheduler-3-private.html: Added.
- storage/indexeddb/modern/transaction-scheduler-4-private-expected.txt: Added.
- storage/indexeddb/modern/transaction-scheduler-4-private.html: Added.
- storage/indexeddb/modern/transaction-scheduler-5-private-expected.txt: Added.
- storage/indexeddb/modern/transaction-scheduler-5-private.html: Added.
- storage/indexeddb/modern/transaction-scheduler-6-private-expected.txt: Added.
- storage/indexeddb/modern/transaction-scheduler-6-private.html: Added.
- storage/indexeddb/modern/transactions-stop-on-navigation-private-expected.txt: Added.
- storage/indexeddb/modern/transactions-stop-on-navigation-private.html: Added.
- storage/indexeddb/modern/versionchange-abort-then-reopen-private-expected.txt: Added.
- storage/indexeddb/modern/versionchange-abort-then-reopen-private.html: Added.
- storage/indexeddb/modern/versionchange-event-private-expected.txt: Added.
- storage/indexeddb/modern/versionchange-event-private.html: Added.
- storage/indexeddb/mozilla/add-twice-failure-private-expected.txt: Added.
- storage/indexeddb/mozilla/add-twice-failure-private.html: Added.
- storage/indexeddb/mozilla/autoincrement-indexes-private-expected.txt: Added.
- storage/indexeddb/mozilla/autoincrement-indexes-private.html: Added.
- storage/indexeddb/mozilla/bad-keypath-private-expected.txt: Added.
- storage/indexeddb/mozilla/bad-keypath-private.html: Added.
- storage/indexeddb/mozilla/clear-private-expected.txt: Added.
- storage/indexeddb/mozilla/clear-private.html: Added.
- storage/indexeddb/mozilla/create-index-unique-private-expected.txt: Added.
- storage/indexeddb/mozilla/create-index-unique-private.html: Added.
- storage/indexeddb/mozilla/create-index-with-integer-keys-private-expected.txt: Added.
- storage/indexeddb/mozilla/create-index-with-integer-keys-private.html: Added.
- storage/indexeddb/mozilla/create-objectstore-basics-private-expected.txt: Added.
- storage/indexeddb/mozilla/create-objectstore-basics-private.html: Added.
- storage/indexeddb/mozilla/create-objectstore-null-name-private-expected.txt: Added.
- storage/indexeddb/mozilla/create-objectstore-null-name-private.html: Added.
- storage/indexeddb/mozilla/cursor-mutation-objectstore-only-private-expected.txt: Added.
- storage/indexeddb/mozilla/cursor-mutation-objectstore-only-private.html: Added.
- storage/indexeddb/mozilla/cursor-mutation-private-expected.txt: Added.
- storage/indexeddb/mozilla/cursor-mutation-private.html: Added.
- storage/indexeddb/mozilla/cursor-update-updates-indexes-private-expected.txt: Added.
- storage/indexeddb/mozilla/cursor-update-updates-indexes-private.html: Added.
- storage/indexeddb/mozilla/cursors-private-expected.txt: Added.
- storage/indexeddb/mozilla/cursors-private.html: Added.
- storage/indexeddb/mozilla/delete-result-private-expected.txt: Added.
- storage/indexeddb/mozilla/delete-result-private.html: Added.
- storage/indexeddb/mozilla/event-source-private-expected.txt: Added.
- storage/indexeddb/mozilla/event-source-private.html: Added.
- storage/indexeddb/mozilla/global-data-private-expected.txt: Added.
- storage/indexeddb/mozilla/global-data-private.html: Added.
- storage/indexeddb/mozilla/index-prev-no-duplicate-private-expected.txt: Added.
- storage/indexeddb/mozilla/index-prev-no-duplicate-private.html: Added.
- storage/indexeddb/mozilla/indexes-private-expected.txt: Added.
- storage/indexeddb/mozilla/indexes-private.html: Added.
- storage/indexeddb/mozilla/key-requirements-delete-null-key-private-expected.txt: Added.
- storage/indexeddb/mozilla/key-requirements-delete-null-key-private.html: Added.
- storage/indexeddb/mozilla/key-requirements-inline-and-passed-private-expected.txt: Added.
- storage/indexeddb/mozilla/key-requirements-inline-and-passed-private.html: Added.
- storage/indexeddb/mozilla/key-requirements-private-expected.txt: Added.
- storage/indexeddb/mozilla/key-requirements-private.html: Added.
- storage/indexeddb/mozilla/key-requirements-put-no-key-private-expected.txt: Added.
- storage/indexeddb/mozilla/key-requirements-put-no-key-private.html: Added.
- storage/indexeddb/mozilla/key-requirements-put-null-key-private-expected.txt: Added.
- storage/indexeddb/mozilla/key-requirements-put-null-key-private.html: Added.
- storage/indexeddb/mozilla/object-cursors-private-expected.txt: Added.
- storage/indexeddb/mozilla/object-cursors-private.html: Added.
- storage/indexeddb/mozilla/object-identity-private-expected.txt: Added.
- storage/indexeddb/mozilla/object-identity-private.html: Added.
- storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-private-expected.txt: Added.
- storage/indexeddb/mozilla/object-store-inline-autoincrement-key-added-on-put-private.html: Added.
- storage/indexeddb/mozilla/object-store-remove-values-private-expected.txt: Added.
- storage/indexeddb/mozilla/object-store-remove-values-private.html: Added.
- storage/indexeddb/mozilla/objectstorenames-private-expected.txt: Added.
- storage/indexeddb/mozilla/objectstorenames-private.html: Added.
- storage/indexeddb/mozilla/odd-result-order-private-expected.txt: Added.
- storage/indexeddb/mozilla/odd-result-order-private.html: Added.
- storage/indexeddb/mozilla/open-database-null-name-private-expected.txt: Added.
- storage/indexeddb/mozilla/open-database-null-name-private.html: Added.
- storage/indexeddb/mozilla/put-get-values-private-expected.txt: Added.
- storage/indexeddb/mozilla/put-get-values-private.html: Added.
- storage/indexeddb/mozilla/readonly-transactions-private-expected.txt: Added.
- storage/indexeddb/mozilla/readonly-transactions-private.html: Added.
- storage/indexeddb/mozilla/readwrite-transactions-private-expected.txt: Added.
- storage/indexeddb/mozilla/readwrite-transactions-private.html: Added.
- storage/indexeddb/mozilla/readyState-private-expected.txt: Added.
- storage/indexeddb/mozilla/readyState-private.html: Added.
- storage/indexeddb/mozilla/remove-index-private-expected.txt: Added.
- storage/indexeddb/mozilla/remove-index-private.html: Added.
- storage/indexeddb/mozilla/remove-objectstore-private-expected.txt: Added.
- storage/indexeddb/mozilla/remove-objectstore-private.html: Added.
- storage/indexeddb/mozilla/versionchange-abort-private-expected.txt: Added.
- storage/indexeddb/mozilla/versionchange-abort-private.html: Added.
- storage/indexeddb/noblobs-private-expected.txt: Added.
- storage/indexeddb/noblobs-private.html: Added.
- storage/indexeddb/object-lookups-in-versionchange-private-expected.txt: Added.
- storage/indexeddb/object-lookups-in-versionchange-private.html: Added.
- storage/indexeddb/open-bad-versions-private-expected.txt: Added.
- storage/indexeddb/open-bad-versions-private.html: Added.
- storage/indexeddb/optional-arguments-private-expected.txt: Added.
- storage/indexeddb/optional-arguments-private.html: Added.
- storage/indexeddb/pending-version-change-stuck-works-with-terminate-private-expected.txt: Added.
- storage/indexeddb/pending-version-change-stuck-works-with-terminate-private.html: Added.
- storage/indexeddb/prefetch-invalidation-private-expected.txt: Added.
- storage/indexeddb/prefetch-invalidation-private.html: Added.
- storage/indexeddb/prefetch-race-private-expected.txt: Added.
- storage/indexeddb/prefetch-race-private.html: Added.
- storage/indexeddb/primary-key-unique-to-objectstore-private-expected.txt: Added.
- storage/indexeddb/primary-key-unique-to-objectstore-private.html: Added.
- storage/indexeddb/request-leak-private-expected.txt: Added.
- storage/indexeddb/request-leak-private.html: Added.
- storage/indexeddb/request-result-cache-private-expected.txt: Added.
- storage/indexeddb/request-result-cache-private.html: Added.
- storage/indexeddb/resources/primary-key-unique-to-objectstore.js:
- storage/indexeddb/resources/shared.js:
- storage/indexeddb/resources/version-change-event-basic.js:
- storage/indexeddb/structured-clone-private-expected.txt: Added.
- storage/indexeddb/structured-clone-private.html: Added.
- storage/indexeddb/transaction-complete-with-js-recursion-cross-frame-private-expected.txt: Added.
- storage/indexeddb/transaction-complete-with-js-recursion-cross-frame-private.html: Added.
- storage/indexeddb/transaction-complete-with-js-recursion-private-expected.txt: Added.
- storage/indexeddb/transaction-complete-with-js-recursion-private.html: Added.
- storage/indexeddb/transaction-crash-in-tasks-private-expected.txt: Added.
- storage/indexeddb/transaction-crash-in-tasks-private.html: Added.
- storage/indexeddb/transaction-ordering-private-expected.txt: Added.
- storage/indexeddb/transaction-ordering-private.html: Added.
- storage/indexeddb/transaction-overlapping-private-expected.txt: Added.
- storage/indexeddb/transaction-overlapping-private.html: Added.
- storage/indexeddb/transaction-starvation-private-expected.txt: Removed.
- storage/indexeddb/version-change-event-basic-private-expected.txt: Added.
- storage/indexeddb/version-change-event-basic-private.html: Added.
- storage/indexeddb/version-change-event-private-expected.txt: Added.
- storage/indexeddb/version-change-event-private.html: Added.
- 5:49 PM Changeset in webkit [195393] by
-
- 2 edits in trunk/Source/WebCore
ResourceHandleCFURLConnectionDelegateWithOperationQueue delegate methods don't NULL-check m_handle->client()
<https://webkit.org/b/152675>
<rdar://problem/24034044>
Reviewed by Brent Fulgham.
- platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveData):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didFinishLoading):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didFail):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willCacheResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didSendBodyData):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveDataArray):
- Add NULL check for m_handle->client() as is done in the WebCoreResourceHandleAsOperationQueueDelegate class in WebCoreResourceHandleAsOperationQueueDelegate.mm. (The NULL check for -connection:didReceiveResponse: is currently missing, but there are crashes there, too, that are covered by Bug 152673.)
- 4:41 PM Changeset in webkit [195392] by
-
- 2 edits in trunk/Source/WebCore
Use TinyLRUCache in caching the CGColorRef in WebCore::cachedCGColor()
https://bugs.webkit.org/show_bug.cgi?id=153279
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-01-20
Reviewed by Dean Jackson.
Reuse the new template TinyLRUCache in caching the CGColor instead of
having the same code repeated twice.
- platform/graphics/cg/ColorCG.cpp:
(WebCore::leakCGColor):
(WebCore::RetainPtr<CGColorRef>>::createValueForKey):
(WebCore::cachedCGColor):
- 4:20 PM Changeset in webkit [195391] by
-
- 3 edits in trunk/Tools
Refactor compareIterations to remove duplicate code.
https://bugs.webkit.org/show_bug.cgi?id=152913
Reviewed by Daniel Bates.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue.prototype.compareIterations): Refactored to remove duplicate code.
(BuildbotQueue.prototype.sortIterations): Add binding to call to compareIterations.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added tests in order to ensure
the same behavior before and after refactor.
- 3:40 PM Changeset in webkit [195390] by
-
- 6 edits in trunk/LayoutTests
Update ios-simulator specific -expected.txt files after most recent WPT revision in r194580
https://bugs.webkit.org/show_bug.cgi?id=152139
Unreviewed test gardening.
- platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-checkValidity-expected.txt:
- platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt:
- platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt:
- platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/input-textselection-01-expected.txt:
- platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/the-label-element/labelable-elements-expected.txt:
- 3:38 PM Changeset in webkit [195389] by
-
- 8 edits in tags/Safari-602.1.17
Roll out r195178. rdar://problem/24265144
- 3:25 PM Changeset in webkit [195388] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Fix a typo in the Air definition of CeilDouble/CeilFloat
https://bugs.webkit.org/show_bug.cgi?id=153286
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-01-20
Reviewed by Mark Lam.
- b3/air/AirOpcode.opcodes:
The second argument should a Def. The previous definition was
adding useless constraints on the allocation of the second argument.
- 3:11 PM Changeset in webkit [195387] by
-
- 3 edits in trunk/Source/JavaScriptCore
[JSC] The register allocator can use a dangling pointer when selecting a spill candidate
https://bugs.webkit.org/show_bug.cgi?id=153287
Reviewed by Mark Lam.
A tricky bug I discovered while experimenting with live range breaking.
We have the following initial conditions:
-UseCounts is slow, so we only compute it once for all the iterations
of the allocator.
-The only new Tmps we create are for spills and refills. They are unspillable
by definition so it is fine to not update UseCounts accordingly.
But, in selectSpill(), we go over all the spill candidates and select the best
one based on its score. The score() lambda uses useCounts, it cannot be used
with a new Tmps created for something we already spilled.
The first time we use score is correct, we started by skipping all the unspillable
Tmps from the candidate. The next use was incorrect: we were checking unspillableTmps
*after* calling score().
The existing tests did not catch this due to back luck. I added an assertion
to find similar problems in the future.
- b3/air/AirIteratedRegisterCoalescing.cpp:
- b3/air/AirUseCounts.h:
- 3:00 PM Changeset in webkit [195386] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: InspectorCSSAgent does not call disable in willDestroyFrontendAndBackend
https://bugs.webkit.org/show_bug.cgi?id=153289
<rdar://problem/24242600>
Reviewed by Joseph Pecoraro.
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::willDestroyFrontendAndBackend): Call disable().
- 2:57 PM Changeset in webkit [195385] by
-
- 2 edits in branches/safari-601.1.46-branch/Source/WebCore
<rdar://problem/24242600> CrashTracer: com.apple.WebKit.WebContent at …pector::CSSFrontendDispatcher::mediaQueryResultChanged + 316
Reviewed by Joseph Pecoraro.
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::willDestroyFrontendAndBackend): Call disable().
(WebCore::InspectorCSSAgent::mediaQueryResultChanged): Add null check.
- 2:55 PM Changeset in webkit [195384] by
-
- 2 edits in branches/safari-601-branch/Source/WebCore
<rdar://problem/24242600> CrashTracer: com.apple.WebKit.WebContent at …pector::CSSFrontendDispatcher::mediaQueryResultChanged + 316
Reviewed by Joseph Pecoraro.
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::willDestroyFrontendAndBackend): Call disable().
(WebCore::InspectorCSSAgent::mediaQueryResultChanged): Add null check.
- 2:55 PM Changeset in webkit [195383] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix CLoop build after bug https://bugs.webkit.org/show_bug.cgi?id=152766
Unreviewed build fix.
- inspector/agents/InspectorScriptProfilerAgent.h:
- 2:54 PM Changeset in webkit [195382] by
-
- 3 edits in trunk/LayoutTests
Follow up to r195361. Removing ios-simulator-wk2 fast/viewport/ios directory pass expectation, explicitly re-enabling passing tests
https://bugs.webkit.org/show_bug.cgi?id=153110
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator/TestExpectations:
- 2:49 PM Changeset in webkit [195381] by
-
- 6 edits in trunk
[INTL] Implement Date.prototype.toLocaleTimeString in ECMA-402
https://bugs.webkit.org/show_bug.cgi?id=147613
Patch by Andy VanWagoner <thetalecrafter@gmail.com> on 2016-01-20
Reviewed by Darin Adler.
Source/JavaScriptCore:
Implement toLocaleTimeString in builtin JavaScript.
- builtins/DatePrototype.js:
(toLocaleTimeString.toDateTimeOptionsTimeTime):
(toLocaleTimeString):
- runtime/DatePrototype.cpp:
(JSC::DatePrototype::finishCreation):
LayoutTests:
Added tests for toLocaleTimeString.
- js/date-toLocaleString-expected.txt:
- js/script-tests/date-toLocaleString.js:
- 2:27 PM Changeset in webkit [195380] by
-
- 132 edits in trunk/LayoutTests
Modern IDB: Make storage/indexeddb/modern tests more modern.
https://bugs.webkit.org/show_bug.cgi?id=153284
Reviewed by Alex Christensen.
- storage/indexeddb/modern/abort-requests-cancelled-expected.txt:
- storage/indexeddb/modern/aborted-put-expected.txt:
- storage/indexeddb/modern/autoincrement-abort-expected.txt:
- storage/indexeddb/modern/basic-add-expected.txt:
- storage/indexeddb/modern/basic-put-expected.txt:
- storage/indexeddb/modern/create-index-failures-expected.txt:
- storage/indexeddb/modern/createobjectstore-basic-expected.txt:
- storage/indexeddb/modern/createobjectstore-failures-expected.txt:
- storage/indexeddb/modern/cursor-1-expected.txt:
- storage/indexeddb/modern/cursor-2-expected.txt:
- storage/indexeddb/modern/cursor-3-expected.txt:
- storage/indexeddb/modern/cursor-4-expected.txt:
- storage/indexeddb/modern/cursor-5-expected.txt:
- storage/indexeddb/modern/cursor-6-expected.txt:
- storage/indexeddb/modern/cursor-7-expected.txt:
- storage/indexeddb/modern/cursor-8-expected.txt:
- storage/indexeddb/modern/date-basic-expected.txt:
- storage/indexeddb/modern/deletedatabase-1-expected.txt:
- storage/indexeddb/modern/deletedatabase-2-expected.txt:
- storage/indexeddb/modern/deleteindex-1-expected.txt:
- storage/indexeddb/modern/deleteindex-2-expected.txt:
- storage/indexeddb/modern/deleteobjectstore-1-expected.txt:
- storage/indexeddb/modern/double-abort-expected.txt:
- storage/indexeddb/modern/get-index-failures-expected.txt:
- storage/indexeddb/modern/get-keyrange-expected.txt:
- storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures-expected.txt:
- storage/indexeddb/modern/idbdatabase-transaction-failures-expected.txt:
- storage/indexeddb/modern/idbindex-properties-basic-expected.txt:
- storage/indexeddb/modern/idbobjectstore-clear-1-expected.txt:
- storage/indexeddb/modern/idbobjectstore-clear-2-expected.txt:
- storage/indexeddb/modern/idbobjectstore-count-1-expected.txt:
- storage/indexeddb/modern/idbobjectstore-count-failures-expected.txt:
- storage/indexeddb/modern/idbobjectstore-delete-1-expected.txt:
- storage/indexeddb/modern/idbobjectstore-delete-2-expected.txt:
- storage/indexeddb/modern/idbobjectstore-delete-failures-expected.txt:
- storage/indexeddb/modern/idbobjectstore-get-failures-expected.txt:
- storage/indexeddb/modern/idbobjectstore-put-and-clear-failures-expected.txt:
- storage/indexeddb/modern/idbtransaction-objectstore-failures-expected.txt:
- storage/indexeddb/modern/index-1-expected.txt:
- storage/indexeddb/modern/index-2-expected.txt:
- storage/indexeddb/modern/index-3-expected.txt:
- storage/indexeddb/modern/index-4-expected.txt:
- storage/indexeddb/modern/index-5-expected.txt:
- storage/indexeddb/modern/index-cursor-1-expected.txt:
- storage/indexeddb/modern/index-cursor-2-expected.txt:
- storage/indexeddb/modern/index-cursor-3-expected.txt:
- storage/indexeddb/modern/index-get-count-basic-expected.txt:
- storage/indexeddb/modern/index-get-count-failures-expected.txt:
- storage/indexeddb/modern/keypath-basic-expected.txt:
- storage/indexeddb/modern/objectstore-attributes-expected.txt:
- storage/indexeddb/modern/objectstore-cursor-advance-failures-expected.txt:
- storage/indexeddb/modern/objectstore-cursor-continue-failures-expected.txt:
- storage/indexeddb/modern/opencursor-failures-expected.txt:
- storage/indexeddb/modern/opendatabase-success-after-versionchange-expected.txt:
- storage/indexeddb/modern/opendatabase-versions-expected.txt:
- storage/indexeddb/modern/resources/abort-requests-cancelled.js:
- storage/indexeddb/modern/resources/aborted-put.js:
- storage/indexeddb/modern/resources/autoincrement-abort.js:
- storage/indexeddb/modern/resources/basic-add.js:
- storage/indexeddb/modern/resources/basic-put.js:
- storage/indexeddb/modern/resources/create-index-failures.js:
- storage/indexeddb/modern/resources/createobjectstore-basic.js:
- storage/indexeddb/modern/resources/createobjectstore-failures.js:
- storage/indexeddb/modern/resources/cursor-1.js:
- storage/indexeddb/modern/resources/cursor-2.js:
- storage/indexeddb/modern/resources/cursor-3.js:
- storage/indexeddb/modern/resources/cursor-4.js:
- storage/indexeddb/modern/resources/cursor-5.js:
- storage/indexeddb/modern/resources/cursor-6.js:
- storage/indexeddb/modern/resources/cursor-7.js:
- storage/indexeddb/modern/resources/cursor-8.js:
- storage/indexeddb/modern/resources/date-basic.js:
- storage/indexeddb/modern/resources/deletedatabase-1.js:
- storage/indexeddb/modern/resources/deletedatabase-2.js:
- storage/indexeddb/modern/resources/deletedatabase-null-name-exception.js:
- storage/indexeddb/modern/resources/deletedatabase-request-event.js:
- storage/indexeddb/modern/resources/deletedatabase-request.js:
- storage/indexeddb/modern/resources/deleteindex-1.js:
- storage/indexeddb/modern/resources/deleteindex-2.js:
- storage/indexeddb/modern/resources/deleteobjectstore-1.js:
- storage/indexeddb/modern/resources/double-abort.js:
- storage/indexeddb/modern/resources/double-open.js:
- storage/indexeddb/modern/resources/get-index-failures.js:
- storage/indexeddb/modern/resources/get-keyrange.js:
- storage/indexeddb/modern/resources/idbdatabase-deleteobjectstore-failures.js:
- storage/indexeddb/modern/resources/idbdatabase-transaction-failures.js:
- storage/indexeddb/modern/resources/idbindex-properties-basic.js:
- storage/indexeddb/modern/resources/idbobjectstore-clear-1.js:
- storage/indexeddb/modern/resources/idbobjectstore-clear-2.js:
- storage/indexeddb/modern/resources/idbobjectstore-count-1.js:
- storage/indexeddb/modern/resources/idbobjectstore-count-failures.js:
- storage/indexeddb/modern/resources/idbobjectstore-delete-1.js:
- storage/indexeddb/modern/resources/idbobjectstore-delete-2.js:
- storage/indexeddb/modern/resources/idbobjectstore-delete-failures.js:
- storage/indexeddb/modern/resources/idbobjectstore-get-failures.js:
- storage/indexeddb/modern/resources/idbobjectstore-put-and-clear-failures.js:
- storage/indexeddb/modern/resources/idbtransaction-objectstore-failures.js:
- storage/indexeddb/modern/resources/index-1.js:
- storage/indexeddb/modern/resources/index-2.js:
- storage/indexeddb/modern/resources/index-3.js:
- storage/indexeddb/modern/resources/index-4.js:
- storage/indexeddb/modern/resources/index-5.js:
- storage/indexeddb/modern/resources/index-cursor-1.js:
- storage/indexeddb/modern/resources/index-cursor-2.js:
- storage/indexeddb/modern/resources/index-cursor-3.js:
- storage/indexeddb/modern/resources/index-get-count-basic.js:
- storage/indexeddb/modern/resources/index-get-count-failures.js:
- storage/indexeddb/modern/resources/keypath-basic.js:
- storage/indexeddb/modern/resources/objectstore-attributes.js:
- storage/indexeddb/modern/resources/objectstore-cursor-advance-failures.js:
- storage/indexeddb/modern/resources/objectstore-cursor-continue-failures.js:
- storage/indexeddb/modern/resources/opencursor-failures.js:
- storage/indexeddb/modern/resources/opendatabase-request-event.js:
- storage/indexeddb/modern/resources/opendatabase-request.js:
- storage/indexeddb/modern/resources/opendatabase-success-after-versionchange.js:
- storage/indexeddb/modern/resources/opendatabase-versions.js:
- storage/indexeddb/modern/resources/request-readystate.js:
- storage/indexeddb/modern/resources/transaction-scheduler-1.js:
- storage/indexeddb/modern/resources/transaction-scheduler-2.js:
- storage/indexeddb/modern/resources/transaction-scheduler-3.js:
- storage/indexeddb/modern/resources/transaction-scheduler-5.js:
- storage/indexeddb/modern/resources/transaction-scheduler-6.js:
- storage/indexeddb/modern/resources/versionchange-abort-then-reopen.js:
- storage/indexeddb/modern/resources/versionchange-event.js:
- storage/indexeddb/modern/transaction-scheduler-1-expected.txt:
- storage/indexeddb/modern/transaction-scheduler-2-expected.txt:
- storage/indexeddb/modern/transaction-scheduler-3-expected.txt:
- storage/indexeddb/modern/transaction-scheduler-5-expected.txt:
- storage/indexeddb/modern/transaction-scheduler-6-expected.txt:
- storage/indexeddb/modern/versionchange-abort-then-reopen-expected.txt:
- storage/indexeddb/modern/versionchange-event-expected.txt:
- 2:18 PM Changeset in webkit [195379] by
-
- 9 edits in branches/safari-601-branch/Source
- 2:18 PM Changeset in webkit [195378] by
-
- 44 edits4 deletes in branches/safari-601-branch
- 2:18 PM Changeset in webkit [195377] by
-
- 15 edits2 deletes in branches/safari-601-branch
- 1:51 PM Changeset in webkit [195376] by
-
- 30 edits12 adds in trunk
Web Inspector: Hook the sampling profiler into the Timelines UI
https://bugs.webkit.org/show_bug.cgi?id=152766
<rdar://problem/24066360>
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
This patch adds some necessary functions to SamplingProfiler::StackFrame
to allow it to give data to the Inspector for the timelines UI. i.e, the
sourceID of the executable of a stack frame.
This patch also swaps in the SamplingProfiler in place of the
LegacyProfiler inside InspectorScriptProfilerAgent. It adds
the necessary protocol data to allow the SamplingProfiler's
data to hook into the timelines UI.
- debugger/Debugger.cpp:
(JSC::Debugger::setProfilingClient):
(JSC::Debugger::willEvaluateScript):
(JSC::Debugger::didEvaluateScript):
(JSC::Debugger::toggleBreakpoint):
- debugger/Debugger.h:
- debugger/ScriptProfilingScope.h:
(JSC::ScriptProfilingScope::ScriptProfilingScope):
(JSC::ScriptProfilingScope::~ScriptProfilingScope):
- inspector/agents/InspectorScriptProfilerAgent.cpp:
(Inspector::InspectorScriptProfilerAgent::willDestroyFrontendAndBackend):
(Inspector::InspectorScriptProfilerAgent::startTracking):
(Inspector::InspectorScriptProfilerAgent::stopTracking):
(Inspector::InspectorScriptProfilerAgent::isAlreadyProfiling):
(Inspector::InspectorScriptProfilerAgent::willEvaluateScript):
(Inspector::InspectorScriptProfilerAgent::didEvaluateScript):
(Inspector::InspectorScriptProfilerAgent::addEvent):
(Inspector::buildSamples):
(Inspector::InspectorScriptProfilerAgent::trackingComplete):
(Inspector::buildAggregateCallInfoInspectorObject): Deleted.
(Inspector::buildInspectorObject): Deleted.
(Inspector::buildProfileInspectorObject): Deleted.
- inspector/agents/InspectorScriptProfilerAgent.h:
- inspector/protocol/ScriptProfiler.json:
- jsc.cpp:
(functionSamplingProfilerStackTraces):
- runtime/SamplingProfiler.cpp:
(JSC::SamplingProfiler::start):
(JSC::SamplingProfiler::stop):
(JSC::SamplingProfiler::clearData):
(JSC::SamplingProfiler::StackFrame::displayName):
(JSC::SamplingProfiler::StackFrame::displayNameForJSONTests):
(JSC::SamplingProfiler::StackFrame::startLine):
(JSC::SamplingProfiler::StackFrame::startColumn):
(JSC::SamplingProfiler::StackFrame::sourceID):
(JSC::SamplingProfiler::StackFrame::url):
(JSC::SamplingProfiler::stackTraces):
(JSC::SamplingProfiler::stackTracesAsJSON):
(JSC::displayName): Deleted.
(JSC::SamplingProfiler::stacktracesAsJSON): Deleted.
- runtime/SamplingProfiler.h:
(JSC::SamplingProfiler::StackFrame::StackFrame):
(JSC::SamplingProfiler::getLock):
(JSC::SamplingProfiler::setTimingInterval):
(JSC::SamplingProfiler::totalTime):
(JSC::SamplingProfiler::setStopWatch):
(JSC::SamplingProfiler::stackTraces): Deleted.
- tests/stress/sampling-profiler-anonymous-function.js:
(platformSupportsSamplingProfiler.baz):
(platformSupportsSamplingProfiler):
- tests/stress/sampling-profiler-basic.js:
(platformSupportsSamplingProfiler.nothing):
(platformSupportsSamplingProfiler.top):
- tests/stress/sampling-profiler/samplingProfiler.js:
(doesTreeHaveStackTrace):
Source/WebInspectorUI:
The main change in this patch is to swap in the SamplingProfiler
in place of the LegacyProfiler. To do this, we've created a data
structure called CallingContextTree which aggregates the SamplingProfiler's
data into an easy to manage tree. To see how the data structure works,
consider the following program:
`
function bar() { run code here for a long time. }
function baz() { run code here for a long time. }
function foo() { bar(); baz(); }
foo();
`
From this program, we will create a tree like this:
(program)
|
|
foo
| |
/ \
/ \
bar baz
From this type of tree, we can easily create a CPUProfile payload
object. Because the Timelines UI knows how to interact with the
CPUProfile object and display it, we currently map the tree to this object
to make it trivially easy to display the SamplingProfiler's data. In the future,
we may want to find ways to work directly with the CallingContextTree instead
of mapping it into another object.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Controllers/TimelineManager.js:
- UserInterface/Main.html:
- UserInterface/Models/CallingContextTree.js: Added.
- UserInterface/Models/ScriptInstrument.js:
- UserInterface/Protocol/ScriptProfilerObserver.js:
- UserInterface/TestStub.html:
- UserInterface/Views/ScriptTimelineView.js:
LayoutTests:
- inspector/sampling-profiler: Added.
- inspector/sampling-profiler/basic-expected.txt: Added.
- inspector/sampling-profiler/basic.html: Added.
- inspector/sampling-profiler/call-frame-with-dom-functions-expected.txt: Added.
- inspector/sampling-profiler/call-frame-with-dom-functions.html: Added.
- inspector/sampling-profiler/eval-source-url-expected.txt: Added.
- inspector/sampling-profiler/eval-source-url.html: Added.
- inspector/sampling-profiler/many-call-frames-expected.txt: Added.
- inspector/sampling-profiler/many-call-frames.html: Added.
- inspector/sampling-profiler/named-function-expression-expected.txt: Added.
- inspector/sampling-profiler/named-function-expression.html: Added.
- inspector/script-profiler/event-type-API-expected.txt:
- inspector/script-profiler/event-type-API.html:
- inspector/script-profiler/event-type-Microtask-expected.txt:
- inspector/script-profiler/event-type-Microtask.html:
- inspector/script-profiler/event-type-Other-expected.txt:
- inspector/script-profiler/event-type-Other.html:
- inspector/script-profiler/tracking-expected.txt:
- inspector/script-profiler/tracking.html:
- 1:49 PM Changeset in webkit [195375] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
TypedArray's .buffer does not return the JSArrayBuffer that was passed to it on creation.
https://bugs.webkit.org/show_bug.cgi?id=153281
Reviewed by Geoffrey Garen.
When creating an JSArrayBuffer we should make sure that the backing ArrayBuffer uses the
new JSArrayBuffer as its wrapper. This causes issues when we get the buffer of a Typed Array
created by passing a JSArrayBuffer as the backing ArrayBuffer does not have a reference to
the original JSArrayBuffer and a new object is created.
- runtime/JSArrayBuffer.cpp:
(JSC::JSArrayBuffer::finishCreation):
- tests/stress/typedarray-buffer-neutered.js: Added.
(arrays.typedArrays.map):
- 1:32 PM Changeset in webkit [195374] by
-
- 1 edit4 adds in trunk/LayoutTests
CSP: Add tests to ensure that alternative text of an image is rendered when CSP blocks its load
https://bugs.webkit.org/show_bug.cgi?id=153280
Reviewed by Alexey Proskuryakov.
These tests were inspired by the Blink test
<https://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/contentSecurityPolicy/image-blocked-alt-content.html?revision=186800>.
- http/tests/security/contentSecurityPolicy/image-blocked-alt-text-expected.html: Added.
- http/tests/security/contentSecurityPolicy/image-blocked-alt-text.html: Added.
- http/tests/security/contentSecurityPolicy/image-data-URL-blocked-alt-text-expected.html: Added.
- http/tests/security/contentSecurityPolicy/image-data-URL-blocked-alt-text.html: Added.
- 1:00 PM Changeset in webkit [195373] by
-
- 1 edit2 adds in branches/safari-601.1.46-branch/LayoutTests
Merge r195158. rdar://problem/24208157
- 1:00 PM Changeset in webkit [195372] by
-
- 2 edits in branches/safari-601.1.46-branch/LayoutTests
Merge r195089. rdar://problem/24101168
- 1:00 PM Changeset in webkit [195371] by
-
- 5 edits3 adds in branches/safari-601.1.46-branch
Merge r195088. rdar://problem/24101168
- 12:59 PM Changeset in webkit [195370] by
-
- 5 edits in branches/safari-601.1.46-branch/Source
Merge r195082. rdar://problem/23633319
- 12:59 PM Changeset in webkit [195369] by
-
- 3 edits in branches/safari-601.1.46-branch
Merge r188377. rdar://problem/24208161
- 12:59 PM Changeset in webkit [195368] by
-
- 6 edits in branches/safari-601.1.46-branch
Merge r188263. rdar://problem/24208161
- 12:59 PM Changeset in webkit [195367] by
-
- 46 edits2 copies273 adds in trunk/LayoutTests
CSP: Merge from Blink many new tests and changes to existing tests
https://bugs.webkit.org/show_bug.cgi?id=153277
<rdar://problem/24260782>
Reviewed by Brent Fulgham.
Merge new Content Security Policy tests from Blink as well as changes made to existing tests
as of Blink r202656: <https://src.chromium.org/viewvc/blink/trunk/LayoutTests/http/tests/security/contentSecurityPolicy/?pathrev=202656>.
Many of these new tests fail and have been marked accordingly with associated WebKit bugs in
TestExpectations. We also do not run CSP 1.1 tests as we do not compile with ENABLE(CSP_NEXT)
enabled (see <https://bugs.webkit.org/show_bug.cgi?id=85558>). We will look to enable CSP 1.1
and make all these merged tests pass in subsequent commits.
One non-mechanical change I made is that I removed the sub-test for shared workers when
merging http/tests/security/contentSecurityPolicy/worker-without-own-csp.html as WebKit does
not support shared workers. I also swapped the argument order in the call to assert_equals()
in the remaining sub-test so that the expected result, "xhr allowed", is the second argument (as
expected by assert_equals()) and hence the failure message would read well.
The tests http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-overrides-xfo.html,
http/tests/security/contentSecurityPolicy/1.1/{script, style}hash-default-src.html do not have
expected results and are skipped for now. These tests do not have expected results because no
expected results were committed to Blink and it is not straightforward to generate the expected
result without reasoning about the test or compiling Blink. When it comes time to enable CSP 1.1
support we can generate the expected results and verify correctness.
- TestExpectations:
- http/tests/security/contentSecurityPolicy/1.1/child-src/frame-about-blank-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/frame-about-blank-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/frame-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/frame-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/frame-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/frame-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/frame-redirect-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/frame-redirect-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/worker-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/worker-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/worker-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/worker-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/worker-shared-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/worker-shared-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/worker-shared-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/child-src/worker-shared-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-cross-none-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-cross-none-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-cross-self-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-cross-self-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-cross-star-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-cross-star-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-cross-url-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-cross-url-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-cross-url-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-cross-url-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-same-none-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-same-none-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-same-self-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-same-self-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-same-star-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-same-star-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-same-url-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-same-url-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-same-url-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-cross-in-same-url-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-cross-none-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-cross-none-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-cross-self-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-cross-self-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-cross-star-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-cross-star-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-cross-url-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-cross-url-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-cross-url-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-cross-url-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-same-none-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-same-none-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-same-self-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-same-self-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-same-star-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-same-star-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-same-url-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-same-url-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-same-url-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-nested-same-in-same-url-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-none-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-none-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-overrides-xfo.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-protocolless-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-protocolless-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-self-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-self-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-self-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-self-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-star-allow-crossorigin-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-star-allow-crossorigin.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-star-allow-sameorigin-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-star-allow-sameorigin.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-url-allow-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-url-allow.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-url-block-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/frame-ancestors-url-block.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/meta-outside-head-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/meta-outside-head.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/plugintypes-affects-child-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/plugintypes-affects-child.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/plugintypes-invalid.html:
- http/tests/security/contentSecurityPolicy/1.1/referrer-always-http-http-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-always-http-http.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-always-http-https-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-always-http-https.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-always-https-http-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-always-https-http.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-always-https-https-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-always-https-https.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-default-http-http-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-default-http-http.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-default-http-https-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-default-http-https.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-default-https-http-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-default-https-http.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-default-https-https-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-default-https-https.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-empty-http-http-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-empty-http-http.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-empty-http-https-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-empty-http-https.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-empty-https-http-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-empty-https-http.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-empty-https-https-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-empty-https-https.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-invalid-http-http-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-invalid-http-http.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-invalid-http-https-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-invalid-http-https.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-invalid-https-http-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-invalid-https-http.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-invalid-https-https-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-invalid-https-https.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-never-http-http-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-never-http-http.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-never-http-https-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-never-http-https.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-never-https-http-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-never-https-http.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-never-https-https-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-never-https-https.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-origin-http-http-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-origin-http-http.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-origin-http-https-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-origin-http-https.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-origin-https-http-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-origin-https-http.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-origin-https-https-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/referrer-origin-https-https.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/report-uri-effective-directive-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/reportonly-in-meta-ignored-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/reportonly-in-meta-ignored.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scripthash-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/scripthash-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scripthash-basic-blocked-error-event-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/scripthash-basic-blocked-error-event.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scripthash-basic-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/scripthash-basic-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scripthash-default-src.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scripthash-ignore-unsafeinline-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/scripthash-ignore-unsafeinline.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scripthash-malformed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/scripthash-malformed.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scripthash-unicode-normalization-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/scripthash-unicode-normalization.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-and-scripthash-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-and-scripthash.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-basic-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-basic-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/source-list-parsing-03-expected.txt.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-ignore-unsafeinline-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-ignore-unsafeinline.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-invalidnonce-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/source-list-parsing-07-expected.txt.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-invalidnonce.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-redirect-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-redirect.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics.html:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image-from-script.html:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-cross-origin-image.html:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image-from-script.html:
- http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-block-image.html:
- http/tests/security/contentSecurityPolicy/1.1/stylehash-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylehash-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylehash-basic-blocked-error-event-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylehash-basic-blocked-error-event.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylehash-basic-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylehash-basic-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylehash-default-src.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylehash-svg-style-basic-blocked-error-event-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylehash-svg-style-basic-blocked-error-event.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylenonce-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylenonce-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylenonce-basic-blocked-error-event-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylenonce-basic-blocked-error-event.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylenonce-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylenonce-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylenonce-svg-style-basic-blocked-error-event-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/stylenonce-svg-style-basic-blocked-error-event.html: Added.
- http/tests/security/contentSecurityPolicy/blob-urls-match-self.html:
- http/tests/security/contentSecurityPolicy/connect-src-eventsource-redirect-to-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/connect-src-eventsource-redirect-to-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-redirect-to-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/connect-src-xmlhttprequest-redirect-to-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/csp-header-is-sent-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/csp-header-is-sent.html: Added.
- http/tests/security/contentSecurityPolicy/eval-allowed-in-report-only-mode-and-sends-report-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/eval-allowed-in-report-only-mode-and-sends-report.html: Added.
- http/tests/security/contentSecurityPolicy/eval-blocked-and-sends-report-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/eval-blocked-and-sends-report.html: Added.
- http/tests/security/contentSecurityPolicy/frame-src-cross-origin-load-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/frame-src-cross-origin-load.html: Added.
- http/tests/security/contentSecurityPolicy/icon-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/icon-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/icon-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/icon-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/image-document-default-src-none-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/image-document-default-src-none.html: Added.
- http/tests/security/contentSecurityPolicy/inline-event-handler-blocked-after-injecting-meta-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/inline-event-handler-blocked-after-injecting-meta.html: Added.
- http/tests/security/contentSecurityPolicy/manifest-src-allowed-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/manifest-src-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/manifest-src-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/manifest-src-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/manifest.test/manifest.json: Added.
- http/tests/security/contentSecurityPolicy/object-in-svg-foreignobject-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/object-in-svg-foreignobject.html: Added.
- http/tests/security/contentSecurityPolicy/object-src-applet-archive-codebase-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/object-src-applet-archive-codebase.html: Added.
- http/tests/security/contentSecurityPolicy/object-src-applet-archive-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/object-src-applet-archive.html: Added.
- http/tests/security/contentSecurityPolicy/object-src-applet-code-codebase-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/object-src-applet-code-codebase.html: Added.
- http/tests/security/contentSecurityPolicy/object-src-applet-code-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/object-src-applet-code.html: Added.
- http/tests/security/contentSecurityPolicy/object-src-does-not-affect-child-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/object-src-does-not-affect-child.html: Added.
- http/tests/security/contentSecurityPolicy/object-src-param-code-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/object-src-param-code-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/object-src-param-movie-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/object-src-param-movie-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/object-src-param-src-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/object-src-param-src-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/object-src-param-url-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/object-src-param-url-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/plugin-in-iframe-with-csp-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/plugin-in-iframe-with-csp.html: Added.
- http/tests/security/contentSecurityPolicy/redirect-does-not-match-paths-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/redirect-does-not-match-paths.html: Added.
- http/tests/security/contentSecurityPolicy/register-bypassing-scheme-partial-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/register-bypassing-scheme-partial.html: Added.
- http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt:
- http/tests/security/contentSecurityPolicy/report-and-enforce.html:
- http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt:
- http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt:
- http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt:
- http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt:
- http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-expected.txt:
- http/tests/security/contentSecurityPolicy/report-multiple-violations-01-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/report-multiple-violations-01.html: Added.
- http/tests/security/contentSecurityPolicy/report-multiple-violations-02-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/report-multiple-violations-02.html: Added.
- http/tests/security/contentSecurityPolicy/report-only-expected.txt:
- http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt:
- http/tests/security/contentSecurityPolicy/report-same-origin-with-cookies-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-from-javascript-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-scheme-relative-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/report-uri-scheme-relative.html: Added.
- http/tests/security/contentSecurityPolicy/resources/alert-pass.js: Added.
- http/tests/security/contentSecurityPolicy/resources/child-src-test.js: Added.
(window.onload):
(injectFrame):
(iframeLoaded):
(injectFrameRedirectingTo):
(injectWorker):
(injectSharedWorker):
- http/tests/security/contentSecurityPolicy/resources/csp-header-is-sent.js: Added.
(async_test.xhr.onload):
(async_test):
(test):
- http/tests/security/contentSecurityPolicy/resources/fail-to-inject-script.js: Added.
(s.onerror):
(s.onload):
- http/tests/security/contentSecurityPolicy/resources/frame-ancestors-and-x-frame-options.pl: Added.
- http/tests/security/contentSecurityPolicy/resources/frame-ancestors-test.js: Added.
(injectNestedIframe):
(injectIFrame):
(iframeLoaded):
(crossOriginFrameShouldBeBlocked.window.onload):
(crossOriginFrameShouldBeBlocked):
(crossOriginFrameShouldBeAllowed.window.onload):
(crossOriginFrameShouldBeAllowed):
(sameOriginFrameShouldBeBlocked.window.onload):
(sameOriginFrameShouldBeBlocked):
(sameOriginFrameShouldBeAllowed.window.onload):
(sameOriginFrameShouldBeAllowed):
(window.onload):
(testNestedIFrame):
- http/tests/security/contentSecurityPolicy/resources/frame-ancestors.pl: Added.
- http/tests/security/contentSecurityPolicy/resources/frame-in-frame.pl: Added.
- http/tests/security/contentSecurityPolicy/resources/generate-csp-report.html: Added.
- http/tests/security/contentSecurityPolicy/resources/iframe-redirect-not-allowed.html: Added.
- http/tests/security/contentSecurityPolicy/resources/image-document-default-src-none-iframe.php: Added.
- http/tests/security/contentSecurityPolicy/resources/multiple-iframe-test.js:
- http/tests/security/contentSecurityPolicy/resources/nph-cached-csp.pl:
- http/tests/security/contentSecurityPolicy/resources/object-src-param.js: Added.
(appendObjectElement.window.onload):
(appendObjectElement):
- http/tests/security/contentSecurityPolicy/resources/post-message.js: Added.
- http/tests/security/contentSecurityPolicy/resources/redir.php: Added.
- http/tests/security/contentSecurityPolicy/resources/redirect-does-not-match-paths.js: Added.
(test):
(async_test.img.onload):
(async_test):
(async_test.xhr.onload):
- http/tests/security/contentSecurityPolicy/resources/redirect.pl: Added.
- http/tests/security/contentSecurityPolicy/resources/referrer-test-endpoint.php: Added.
- http/tests/security/contentSecurityPolicy/resources/referrer-test.js: Added.
(ReferrerTest.bindHandler):
(ReferrerTest.base):
(ReferrerTest.generateFrameURL):
(ReferrerTest.injectFrame):
(expectFullReferrer):
(expectNoReferrer):
(expectOriginReferrer):
- http/tests/security/contentSecurityPolicy/resources/referrer-test.php: Added.
- http/tests/security/contentSecurityPolicy/resources/sandbox.php:
- http/tests/security/contentSecurityPolicy/resources/script-redirect-not-allowed.js: Added.
- http/tests/security/contentSecurityPolicy/resources/script-set-value.js: Added.
- http/tests/security/contentSecurityPolicy/resources/style-set-red.css: Added.
(p):
- http/tests/security/contentSecurityPolicy/resources/stylesheet-redirect-not-allowed.css: Added.
(body):
- http/tests/security/contentSecurityPolicy/resources/test-csp-header.pl: Added.
- http/tests/security/contentSecurityPolicy/resources/worker.php: Added.
- http/tests/security/contentSecurityPolicy/resources/xhr-redirect-not-allowed.pl: Added.
- http/tests/security/contentSecurityPolicy/sandbox-report-only-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/sandbox-report-only.html: Added.
- http/tests/security/contentSecurityPolicy/script-src-appended-script-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/script-src-appended-script.html: Added.
- http/tests/security/contentSecurityPolicy/script-src-blocked-error-event-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/script-src-blocked-error-event.html: Added.
- http/tests/security/contentSecurityPolicy/script-src-redirect-expected.txt:
- http/tests/security/contentSecurityPolicy/script-src-redirect.html:
- http/tests/security/contentSecurityPolicy/source-list-parsing-03-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-03.html:
- http/tests/security/contentSecurityPolicy/source-list-parsing-07-expected.txt:
- http/tests/security/contentSecurityPolicy/source-list-parsing-07.html:
- http/tests/security/contentSecurityPolicy/source-list-parsing-paths-03-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/source-list-parsing-paths-03.html: Added.
- http/tests/security/contentSecurityPolicy/style-src-blocked-error-event-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/style-src-blocked-error-event.html: Added.
- http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp.html: Added.
- http/tests/security/contentSecurityPolicy/worker-connect-src-allowed.html:
- http/tests/security/contentSecurityPolicy/worker-connect-src-blocked.html:
- http/tests/security/contentSecurityPolicy/worker-eval-blocked.html:
- http/tests/security/contentSecurityPolicy/worker-function-function-blocked.html:
- http/tests/security/contentSecurityPolicy/worker-importscripts-blocked-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/worker-importscripts-blocked.html: Added.
- http/tests/security/contentSecurityPolicy/worker-multiple-csp-headers-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/worker-multiple-csp-headers.html: Added.
- http/tests/security/contentSecurityPolicy/worker-script-src-expected.txt:
- http/tests/security/contentSecurityPolicy/worker-script-src.html:
- http/tests/security/contentSecurityPolicy/worker-set-timeout-blocked.html:
- http/tests/security/contentSecurityPolicy/worker-without-own-csp-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/worker-without-own-csp.html: Added.
- platform/wk2/TestExpectations:
- 12:59 PM Changeset in webkit [195366] by
-
- 1 edit in branches/safari-601.1.46-branch/Source/WebCore/ChangeLog
Merge r187693. rdar://problem/24208161
- 12:27 PM Changeset in webkit [195365] by
-
- 3 edits in trunk/Source/JavaScriptCore
Pack RegisterAtOffset harder.
<https://webkit.org/b/152501>
Reviewed by Michael Saboff.
Pack the register index and the offset into a single pointer-sized word instead of two.
This reduces memory consumption by 620 kB on mobile theverge.com.
The packing doesn't succeed on MSVC for some reason, so I've left out the static
assertion about class size in those builds.
- jit/RegisterAtOffset.cpp:
- jit/RegisterAtOffset.h:
- 12:02 PM Changeset in webkit [195364] by
-
- 5 edits in branches/safari-601.3.9.1-branch/Source
Versioning.
- 12:00 PM Changeset in webkit [195363] by
-
- 1 copy in tags/Safari-601.3.9.1.2
New tag.
- 11:58 AM Changeset in webkit [195362] by
-
- 3 edits in trunk/Source/JavaScriptCore
[B3][Win64] Compile fix.
https://bugs.webkit.org/show_bug.cgi?id=153278
Reviewed by Filip Pizlo.
MSVC does not accept that a class declared as exported also have members declared as exported.
- b3/B3Const32Value.h:
- b3/B3ControlValue.h:
- 11:56 AM Changeset in webkit [195361] by
-
- 2 edits in trunk/LayoutTests
Marking three fast/viewport/ios/width-is-device-width-overflowing* tests as flaky on ios-simulator.
https://bugs.webkit.org/show_bug.cgi?id=153110
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 11:32 AM Changeset in webkit [195360] by
-
- 6 edits1 add in trunk/Source/JavaScriptCore
[ES6] Fix various issues with TypedArrays.
https://bugs.webkit.org/show_bug.cgi?id=153245
Reviewed by Geoffrey Garen.
This patch fixes a couple of issues with TypedArrays:
1) We were not checking if a view had been neutered and throwing an error
if it had in the our TypedArray.prototype functions.
2) The TypedArray.prototype.set function had a couple of minor issues with
checking for the offset being negative.
3) The JSArrayBufferView class did not check if the backing store had
been neutered when computing the offset even though the view's vector
pointer had been set to NULL. This meant that under some conditions we
could, occasionally, return a garbage number as the offset. Now, we only
neuter views if the backing ArrayBuffer's view is actually transfered.
- jsc.cpp:
(GlobalObject::finishCreation):
(functionNeuterTypedArray):
- runtime/JSArrayBufferView.h:
(JSC::JSArrayBufferView::isNeutered):
- runtime/JSArrayBufferViewInlines.h:
(JSC::JSArrayBufferView::byteOffset):
- runtime/JSGenericTypedArrayViewPrototypeFunctions.h:
(JSC::genericTypedArrayViewProtoFuncSet):
(JSC::genericTypedArrayViewProtoFuncEntries):
(JSC::genericTypedArrayViewProtoFuncCopyWithin):
(JSC::genericTypedArrayViewProtoFuncFill):
(JSC::genericTypedArrayViewProtoFuncIndexOf):
(JSC::genericTypedArrayViewProtoFuncJoin):
(JSC::genericTypedArrayViewProtoFuncKeys):
(JSC::genericTypedArrayViewProtoFuncLastIndexOf):
(JSC::genericTypedArrayViewProtoFuncReverse):
(JSC::genericTypedArrayViewPrivateFuncSort):
(JSC::genericTypedArrayViewProtoFuncSlice):
(JSC::genericTypedArrayViewProtoFuncSubarray):
(JSC::typedArrayViewProtoFuncValues):
- runtime/JSTypedArrayViewPrototype.cpp:
(JSC::typedArrayViewPrivateFuncLength):
(JSC::typedArrayViewPrivateFuncSort): Deleted.
- tests/stress/typedarray-functions-with-neutered.js: Added.
(getGetter):
(unit):
(args.new.Int32Array):
(arrays.typedArrays.map):
(checkProtoFunc.throwsCorrectError):
(checkProtoFunc):
(test):
- 11:30 AM Changeset in webkit [195359] by
-
- 2 edits in trunk/Tools
Botwatcher's dashboard should show an 'X' when the build is broken
https://bugs.webkit.org/show_bug.cgi?id=152507
Reviewed by David Kilzer.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
(BuildbotStaticAnalyzerQueueView.prototype.appendStaticAnalyzerQueueStatus):
(BuildbotStaticAnalyzerQueueView.prototype.update):
- 11:27 AM Changeset in webkit [195358] by
-
- 2 edits in trunk/Source/WebKit2
Fix CMake build after r195300.
- PlatformMac.cmake:
Include editing/mac to find DataDetection.h.
- 10:23 AM Changeset in webkit [195357] by
-
- 11 edits in trunk/Source/WebKit2
Ask UI Process before sending redirect requests when downloading
https://bugs.webkit.org/show_bug.cgi?id=153041
Reviewed by Darin Adler.
- NetworkProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::continueCanAuthenticateAgainstProtectionSpace):
(WebKit::DownloadManager::continueWillSendRequest):
(WebKit::DownloadManager::convertHandleToDownload):
- NetworkProcess/Downloads/DownloadManager.h:
- NetworkProcess/Downloads/PendingDownload.cpp:
(WebKit::PendingDownload::willSendRedirectedRequest):
(WebKit::PendingDownload::continueWillSendRequest):
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::continueCanAuthenticateAgainstProtectionSpace):
(WebKit::NetworkProcess::continueWillSendRequest):
(WebKit::NetworkProcess::setCacheModel):
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- UIProcess/API/APIDownloadClient.h:
(API::DownloadClient::didCancel):
(API::DownloadClient::processDidCrash):
(API::DownloadClient::canAuthenticateAgainstProtectionSpace):
(API::DownloadClient::willSendRequest):
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::didReceiveAuthenticationChallenge):
(WebKit::DownloadProxy::canAuthenticateAgainstProtectionSpace):
(WebKit::DownloadProxy::willSendRequest):
(WebKit::DownloadProxy::didReceiveResponse):
- UIProcess/Downloads/DownloadProxy.h:
- UIProcess/Downloads/DownloadProxy.messages.in:
- 9:59 AM Changeset in webkit [195356] by
-
- 6 edits1 move in trunk/Source
Refactor AtomicStringKeyedMRUCache to be a generic LRU cache
https://bugs.webkit.org/show_bug.cgi?id=153109
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-01-20
Reviewed by Darin Adler.
Source/WebCore:
Replace the template specialization of AtomicStringKeyedMRUCache with
template derived from TinyLRUCachePolicy. Override the functions which
are needed for creating the values and the null value. Also replace the
static function which was returning a NeverDestroyed AtomicStringKeyedMRUCache
with a singleton function 'cache' inside the derived template.
- WebCore.xcodeproj/project.pbxproj:
- platform/text/AtomicStringKeyedMRUCache.h: Removed.
- platform/text/cf/HyphenationCF.cpp:
(WebCore::canHyphenate):
(WebCore::lastHyphenLocation):
(WebCore::AtomicStringKeyedMRUCache<RetainPtr<CFLocaleRef>>::createValueForNullKey): Deleted.
(WebCore::AtomicStringKeyedMRUCache<RetainPtr<CFLocaleRef>>::createValueForKey): Deleted.
(WebCore::cfLocaleCache): Deleted.
- platform/text/hyphen/HyphenationLibHyphen.cpp:
(WebCore::countLeadingSpaces):
(WebCore::lastHyphenLocation):
(WebCore::AtomicStringKeyedMRUCache<RefPtr<HyphenationDictionary>>::createValueForNullKey): Deleted.
(WebCore::AtomicStringKeyedMRUCache<RefPtr<HyphenationDictionary>>::createValueForKey): Deleted.
(WebCore::hyphenDictionaryCache): Deleted.
Source/WTF:
Refactor AtomicStringKeyedMRUCache, move it to WTF project and rename it
to be TinyLRUCache. Define another template and call it TinyLRUCachePolicy.
This one can be overridden for different keys and values. Its function is
creating the cached values.
- WTF.xcodeproj/project.pbxproj:
- wtf/TinyLRUCache.h: Added.
(WebCore::TinyLRUCachePolicy::isKeyNull):
(WebCore::TinyLRUCachePolicy::createValueForNullKey):
(WebCore::TinyLRUCachePolicy::createValueForKey):
(WebCore::TinyLRUCache::get):
- 9:16 AM Changeset in webkit [195355] by
-
- 11 edits81 deletes in trunk
Drop support for obsolete Node.isSupported()
https://bugs.webkit.org/show_bug.cgi?id=153164
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C test now that one more check is passing.
- web-platform-tests/dom/historical-expected.txt:
Source/WebCore:
Drop support for obsolete Node.isSupported(). Chrome and Firefox already
dropped it.
No new tests, already covered by existing test.
- dom/Node.cpp:
(WebCore::Node::isSupportedForBindings):
- dom/Node.h:
- dom/Node.idl:
LayoutTests:
Drop obsolete DOM tests.
- dom/html/level2/html/HTMLBodyElement07-expected.txt: Removed.
- dom/html/level2/html/HTMLBodyElement07.html: Removed.
- dom/html/level2/html/HTMLBodyElement07.js: Removed.
- dom/html/level2/html/HTMLBodyElement08-expected.txt: Removed.
- dom/html/level2/html/HTMLBodyElement08.html: Removed.
- dom/html/level2/html/HTMLBodyElement08.js: Removed.
- dom/html/level2/html/HTMLBodyElement09-expected.txt: Removed.
- dom/html/level2/html/HTMLBodyElement09.html: Removed.
- dom/html/level2/html/HTMLBodyElement09.js: Removed.
- dom/html/level2/html/HTMLBodyElement10-expected.txt: Removed.
- dom/html/level2/html/HTMLBodyElement10.html: Removed.
- dom/html/level2/html/HTMLBodyElement10.js: Removed.
- dom/html/level2/html/HTMLBodyElement11-expected.txt: Removed.
- dom/html/level2/html/HTMLBodyElement11.html: Removed.
- dom/html/level2/html/HTMLBodyElement11.js: Removed.
- dom/html/level2/html/HTMLBodyElement12-expected.txt: Removed.
- dom/html/level2/html/HTMLBodyElement12.html: Removed.
- dom/html/level2/html/HTMLBodyElement12.js: Removed.
- dom/html/level2/html/HTMLDocument22-expected.txt: Removed.
- dom/html/level2/html/HTMLDocument22.html: Removed.
- dom/html/level2/html/HTMLDocument22.js: Removed.
- dom/html/level2/html/HTMLDocument23-expected.txt: Removed.
- dom/html/level2/html/HTMLDocument23.html: Removed.
- dom/html/level2/html/HTMLDocument23.js: Removed.
- dom/html/level2/html/HTMLDocument24-expected.txt: Removed.
- dom/html/level2/html/HTMLDocument24.html: Removed.
- dom/html/level2/html/HTMLDocument24.js: Removed.
- dom/html/level2/html/HTMLDocument25-expected.txt: Removed.
- dom/html/level2/html/HTMLDocument25.html: Removed.
- dom/html/level2/html/HTMLDocument25.js: Removed.
- dom/html/level2/html/HTMLDocument26-expected.txt: Removed.
- dom/html/level2/html/HTMLDocument26.html: Removed.
- dom/html/level2/html/HTMLDocument26.js: Removed.
- dom/html/level2/html/HTMLDocument27-expected.txt: Removed.
- dom/html/level2/html/HTMLDocument27.html: Removed.
- dom/html/level2/html/HTMLDocument27.js: Removed.
- dom/svg/level3/xpath/Conformance_isSupported_3-expected.txt: Removed.
- dom/svg/level3/xpath/Conformance_isSupported_3.js: Removed.
- dom/svg/level3/xpath/Conformance_isSupported_3.svg: Removed.
- dom/svg/level3/xpath/Conformance_isSupported_empty-expected.txt: Removed.
- dom/svg/level3/xpath/Conformance_isSupported_empty.js: Removed.
- dom/svg/level3/xpath/Conformance_isSupported_empty.svg: Removed.
- dom/svg/level3/xpath/Conformance_isSupported_null-expected.txt: Removed.
- dom/svg/level3/xpath/Conformance_isSupported_null.js: Removed.
- dom/svg/level3/xpath/Conformance_isSupported_null.svg: Removed.
- dom/xhtml/level2/html/HTMLBodyElement07-expected.txt: Removed.
- dom/xhtml/level2/html/HTMLBodyElement07.js: Removed.
- dom/xhtml/level2/html/HTMLBodyElement07.xhtml: Removed.
- dom/xhtml/level2/html/HTMLBodyElement08-expected.txt: Removed.
- dom/xhtml/level2/html/HTMLBodyElement08.js: Removed.
- dom/xhtml/level2/html/HTMLBodyElement08.xhtml: Removed.
- dom/xhtml/level2/html/HTMLBodyElement09-expected.txt: Removed.
- dom/xhtml/level2/html/HTMLBodyElement09.js: Removed.
- dom/xhtml/level2/html/HTMLBodyElement09.xhtml: Removed.
- dom/xhtml/level2/html/HTMLBodyElement10-expected.txt: Removed.
- dom/xhtml/level2/html/HTMLBodyElement10.js: Removed.
- dom/xhtml/level2/html/HTMLBodyElement10.xhtml: Removed.
- dom/xhtml/level2/html/HTMLBodyElement11-expected.txt: Removed.
- dom/xhtml/level2/html/HTMLBodyElement11.js: Removed.
- dom/xhtml/level2/html/HTMLBodyElement11.xhtml: Removed.
- dom/xhtml/level2/html/HTMLBodyElement12-expected.txt: Removed.
- dom/xhtml/level2/html/HTMLBodyElement12.js: Removed.
- dom/xhtml/level2/html/HTMLBodyElement12.xhtml: Removed.
- dom/xhtml/level2/html/HTMLDocument22-expected.txt: Removed.
- dom/xhtml/level2/html/HTMLDocument22.js: Removed.
- dom/xhtml/level2/html/HTMLDocument22.xhtml: Removed.
- dom/xhtml/level2/html/HTMLDocument23-expected.txt: Removed.
- dom/xhtml/level2/html/HTMLDocument23.js: Removed.
- dom/xhtml/level2/html/HTMLDocument23.xhtml: Removed.
- dom/xhtml/level2/html/HTMLDocument24-expected.txt: Removed.
- dom/xhtml/level2/html/HTMLDocument24.js: Removed.
- dom/xhtml/level2/html/HTMLDocument24.xhtml: Removed.
- dom/xhtml/level2/html/HTMLDocument25-expected.txt: Removed.
- dom/xhtml/level2/html/HTMLDocument25.js: Removed.
- dom/xhtml/level2/html/HTMLDocument25.xhtml: Removed.
- dom/xhtml/level2/html/HTMLDocument26-expected.txt: Removed.
- dom/xhtml/level2/html/HTMLDocument26.js: Removed.
- dom/xhtml/level2/html/HTMLDocument26.xhtml: Removed.
- dom/xhtml/level2/html/HTMLDocument27-expected.txt: Removed.
- dom/xhtml/level2/html/HTMLDocument27.js: Removed.
- dom/xhtml/level2/html/HTMLDocument27.xhtml: Removed.
- fast/dom/features-expected.txt:
- fast/dom/features.html:
- 5:25 AM Changeset in webkit [195354] by
-
- 1 copy in releases/WebKitGTK/webkit-2.10.5
WebKitGTK+ 2.10.5
- 5:19 AM Changeset in webkit [195353] by
-
- 4 edits in releases/WebKitGTK/webkit-2.10
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.10.5 release.
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit2:
- gtk/NEWS: Add release notes for 2.10.5
- 4:46 AM Changeset in webkit [195352] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r195312 - Fixed compilation of AXObjectCache in case of !HAVE(ACCESSIBILITY).
https://bugs.webkit.org/show_bug.cgi?id=153243
Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-19
Reviewed by Chris Fleizach.
No new tests needed.
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::AXObjectCache):
(WebCore::nodeHasRole): Deleted.
- 4:43 AM Changeset in webkit [195351] by
-
- 5 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2
Merge r195231 - [EFL][GTK][WK2] Fix UIProcess build with GStreamer and without VIDEO
https://bugs.webkit.org/show_bug.cgi?id=153135
Patch by Olivier Blin <Olivier Blin> on 2016-01-18
Reviewed by Michael Catanzaro.
GStreamer builds fail when WebAudio is enabled but VIDEO disabled.
This change makes the flag more consistent around the
decicePolicyForInstallMissingMediaPluginsPermissionRequest() method:
ENABLE(VIDEO) && USE(GSTREAMER) everywhere, while the code used to
test either one or the other.
This does not enable InstallMissingMediaPlugins for WebAudio, since no
code makes use of this in WebKitWebAudioSourceGStreamer.
It also fixes a naming typo for the following method:
decidePolicyForInstallMissingMediaPluginsPermissionRequest()
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::decidePolicyForInstallMissingMediaPluginsPermissionRequest):
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/PageClient.h:
- UIProcess/efl/WebViewEfl.h:
- UIProcess/gstreamer/WebPageProxyGStreamer.cpp:
(WebKit::WebPageProxy::requestInstallMissingMediaPlugins):
- 4:38 AM Changeset in webkit [195350] by
-
- 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore
Merge r195349 - Unreviewed. Fix compile warning when building with GTK+ < 3.14.
- rendering/RenderThemeGtk.cpp:
(WebCore::loadThemedIcon):
- 4:12 AM Changeset in webkit [195349] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix compile warning when building with GTK+ < 3.14.
- rendering/RenderThemeGtk.cpp:
(WebCore::loadThemedIcon):
- 2:49 AM Changeset in webkit [195348] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Speculative cmake buildfix after r195317.
- PlatformMac.cmake:
- 1:07 AM Changeset in webkit [195347] by
-
- 1 copy in releases/WebKitGTK/webkit-2.11.4
WebKitGTK+ 2.11.4
- 1:04 AM Changeset in webkit [195346] by
-
- 4 edits in trunk
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.11.4 release.
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit2:
- gtk/NEWS: Add release notes for 2.11.4.
