⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jan 25, 2016:

11:32 PM Changeset in webkit [195584] by youenn.fablet@crf.canon.fr
  • 5 edits in trunk/Source/WebCore

WebCoreJSBuiltins do not use to do conditional include
​https://bugs.webkit.org/show_bug.cgi?id=153306

Reviewed by Alex Christensen.

Removing compilation guards as builtin generator adds them in the files themselves.
Fixing MediaDevices.js to generate MEDIA_STREAM compilation guard.

No change in behavior.

  • Modules/mediastream/MediaDevices.js: Changing @optional to @conditional.
  • Modules/mediastream/NavigatorUserMedia.js: Making it @conditional.
  • bindings/js/WebCoreJSBuiltins.cpp:
  • bindings/js/WebCoreJSBuiltins.h:
11:28 PM Changeset in webkit [195583] by youenn.fablet@crf.canon.fr
  • 3 edits
    4 adds in trunk/LayoutTests

imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection.html asserts frequently
​https://bugs.webkit.org/show_bug.cgi?id=152436

Reviewed by Alexey Proskuryakov.

LayoutTests/imported/w3c:

Adding temporary tests that splits garbage collection readable stream
tests in worker and window mode.

  • web-platform-tests/streams-api/readable-streams/garbage-collection-1-expected.txt: Added.
  • web-platform-tests/streams-api/readable-streams/garbage-collection-1.html: Added.
  • web-platform-tests/streams-api/readable-streams/garbage-collection-2-expected.txt: Added.
  • web-platform-tests/streams-api/readable-streams/garbage-collection-2.html: Added.

LayoutTests:

  • platform/mac/TestExpectations: Marked imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection.html as crash/pass.
10:12 PM Changeset in webkit [195582] by commit-queue@webkit.org
  • 11 edits in trunk

Fix internal Windows build
​https://bugs.webkit.org/show_bug.cgi?id=153469

Patch by Alex Christensen <​achristensen@webkit.org> on 2016-01-25
Reviewed by Brent Fulgham.

.:

  • Source/cmake/WebKitMacros.cmake:

Pass the GPERF_EXECUTABLE that we found to make-hash-tools.pl.

Source/WebCore:

  • CMakeLists.txt:

Pass the GPERF_EXECUTABLE that we found to perl scripts so they can use it instead of just calling gperf.
This is needed for builds where gperf is not in the PATH.

  • DerivedSources.make:

Pass "gperf" as the gperf command to retain existing functionality on mac.

  • bindings/scripts/preprocess-idls.pl:

(CygwinPathIfNeeded):

  • bindings/scripts/preprocessor.pm:

(applyPreprocessor):
Add /cygdrive/c/cygwin/bin to the PATH before calling cygpath.
This is needed for builds where we are using cygwin, but C:/cygwin/bin is not in the PATH.

  • css/makeSelectorPseudoClassAndCompatibilityElementMap.py:
  • css/makeSelectorPseudoElementsMap.py:
  • css/makeprop.pl:
  • platform/network/create-http-header-name-table:

Use the gperf executable passed in as a command line parameter if it is given.

9:43 PM Changeset in webkit [195581] by commit-queue@webkit.org
  • 7 edits
    9 adds in trunk

[ES6] Arrow function syntax. Arrow function specific features. Lexical bind "arguments"
​https://bugs.webkit.org/show_bug.cgi?id=145132

Patch by Skachkov Oleksandr <​gskachkov@gmail.com> on 2016-01-25
Reviewed by Saam Barati.
Source/JavaScriptCore:

Added support of ES6 arrow function specific feature, lexical bind of arguments.
​http://www.ecma-international.org/ecma-262/6.0/#sec-arrow-function-definitions-runtime-semantics-evaluation
'arguments' variable in arrow function must resolve to a binding in a lexically enclosing environment.
In srict mode it points to arguments object, and in non-stric mode it points to arguments object or varible
with name 'arguments' if it was declared.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

  • parser/Parser.h:

(JSC::Scope::Scope):
(JSC::Scope::setSourceParseMode):
(JSC::Scope::isArrowFunction):
(JSC::Scope::collectFreeVariables):
(JSC::Scope::setIsArrowFunction):

  • tests/es6.yaml:
  • tests/stress/arrowfunction-lexical-bind-arguments-non-strict-1.js: Added.
  • tests/stress/arrowfunction-lexical-bind-arguments-non-strict-2.js: Added.
  • tests/stress/arrowfunction-lexical-bind-arguments-strict.js: Added.

Source/WebInspectorUI:

Current patch is implementing lexical bind of arguments, so in this callback we need
to return to ordinary function.

  • UserInterface/Base/Object.js:

(WebInspector.Object.singleFireEventListener.let.wrappedCallback):
(WebInspector.Object.singleFireEventListener):

LayoutTests:

  • js/arrowfunction-lexical-bind-arguments-non-strict-expected.txt: Added.
  • js/arrowfunction-lexical-bind-arguments-non-strict.html: Added.
  • js/arrowfunction-lexical-bind-arguments-strict-expected.txt: Added.
  • js/arrowfunction-lexical-bind-arguments-strict.html: Added.
  • js/script-tests/arrowfunction-lexical-bind-arguments-non-strict.js: Added.
  • js/script-tests/arrowfunction-lexical-bind-arguments-strict.js: Added.
9:41 PM Changeset in webkit [195580] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

DisplayList items can log paths now
​https://bugs.webkit.org/show_bug.cgi?id=153417

Reviewed by Zalan Bujtas.

Now that Path supports TextStream logging, clean up its output a little and
enable dumping of Paths in DisplayListItems.

  • platform/graphics/Path.cpp:

(WebCore::operator<<):

  • platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::operator<<):

9:40 PM Changeset in webkit [195579] by Simon Fraser
  • 4 edits in trunk

Give the layout test results file a <title> showing the date and time the tests were run
​https://bugs.webkit.org/show_bug.cgi?id=153187

Reviewed by Darin Adler.

Tools:

Include a 'date' property in the JSON with the date and time the tests completed.

  • Scripts/webkitpy/layout_tests/models/test_run_results.py:

(summarize_results):

LayoutTests:

Generate a <title> element from the 'date' property in the JSON.

  • fast/harness/results.html:
8:01 PM Changeset in webkit [195578] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

[JSC] We should never use x18 on iOS ARM64
​https://bugs.webkit.org/show_bug.cgi?id=153461

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-01-25
Reviewed by Filip Pizlo.

The register x18 is reserved in the iOS variant of the ARM64 ABI.

The weird thing is: if you use it, its value will change completely
randomly. It looks like it is changed by the system on interrupts.

This patch adds x18 to the reserved register and add assertions
to the assembler to prevent similar problems in the future.

  • assembler/ARM64Assembler.h:

(JSC::ARM64Assembler::xOrSp):
(JSC::ARM64Assembler::xOrZr):

  • assembler/AbstractMacroAssembler.h:

(JSC::isIOS): Deleted.

  • assembler/AssemblerCommon.h:

(JSC::isIOS):

  • jit/RegisterSet.cpp:

(JSC::RegisterSet::reservedHardwareRegisters):

7:13 PM Changeset in webkit [195577] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Fix the comment.

  • rendering/style/RenderStyle.h:
7:12 PM Changeset in webkit [195576] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r195550.
​https://bugs.webkit.org/show_bug.cgi?id=153471

broke animometer bot (and now we have crash logs!) (Requested
by kling on #webkit).

Reverted changeset:

"Restore CodeBlock jettison code Geoff accidentally removed"
​https://bugs.webkit.org/show_bug.cgi?id=151241
​http://trac.webkit.org/changeset/195550

6:57 PM Changeset in webkit [195575] by akling@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

MarkedSpace should have more precise allocators.
<​https://webkit.org/b/153448>
<rdar://problem/23897477>

Reviewed by Geoffrey Garen.

The four classes responsible for the bulk of MarkedBlock allocations today are:

  • FunctionCodeBlock (640 bytes)
  • UnlinkedFunctionCodeBlock (304 bytes)
  • FunctionExecutable (168 bytes)
  • UnlinkedFunctionExecutable (144 bytes)

Due to the size class distribution in MarkedSpace, we've been wasting quite a lot
of heap space on these objects. Our "precise" allocators allowed allocation sizes
in 16-byte increments up to 128 bytes, but after that point, we'd only allocate
in 256-byte size increments.

Thus each instance of those classes would waste space as follows:

  • FunctionCodeBlock (768-byte cell, 128 bytes wasted)
  • UnlinkedFunctionCodeBlock (512-byte cell, 208 bytes wasted)
  • FunctionExecutable(256-byte cell, 88 bytes wasted)
  • UnlinkedFunctionExecutable(256-byte cell, 112 bytes wasted)

This patch raises the limit for precise allocations from 128 to 768, allowing us
to allocate these objects with far better space efficiency.

The cost of this is 7kB worth of MarkedAllocators and 70 (~2x) more allocators to
iterate whenever we iterate all the allocators.

  • heap/MarkedSpace.h:
  • heap/MarkedSpace.cpp:

(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::resetAllocators):
(JSC::MarkedSpace::forEachAllocator):
(JSC::MarkedSpace::isPagedOut):

6:18 PM Changeset in webkit [195574] by enrica@apple.com
  • 13 edits
    2 moves in trunk/Source

Add support for DataDetectors in WK (iOS).
​https://bugs.webkit.org/show_bug.cgi?id=152989
rdar://problem/22855960

Reviewed by Tim Horton.

Source/WebCore:

Adding new helper functions for data detection related tasks.
The patch also fixes a bug when creating DOM ranges from DDQueryRange
spanning multiple fragments.

  • editing/cocoa/DataDetection.h:
  • editing/cocoa/DataDetection.mm:

(WebCore::DataDetection::isDataDetectorLink):
(WebCore::DataDetection::dataDetectorIdentifier):
(WebCore::detectItemAtPositionWithRange):
(WebCore::DataDetection::detectItemAroundHitTestResult):
(WebCore::resultIsURL):
(WebCore::removeResultLinksFromAnchor):
(WebCore::searchForLinkRemovingExistingDDLinks):
(WebCore::DataDetection::detectContentInRange):

Source/WebKit2:

Moving InteractionInformationAtPosition files to platform folder,
since this is only used on iOS and changing from .cpp to .mm.
The structure is extended to include data detection specific fields
and the relevant encode/decode functions have been updated to
handle the new fields.
The patch also adds a new WKUIDelegatePrivate method to allow
the client to provide additional context for data detection actions.

  • Platform/spi/ios/UIKitSPI.h:
  • Shared/InteractionInformationAtPosition.cpp: Removed.
  • Shared/InteractionInformationAtPosition.h: Removed.
  • Shared/ios/InteractionInformationAtPosition.h: Copied from Shared/InteractionInformationAtPosition.h.
  • Shared/ios/InteractionInformationAtPosition.mm: Copied from Shared/InteractionInformationAtPosition.cpp.

(WebKit::InteractionInformationAtPosition::encode):
(WebKit::InteractionInformationAtPosition::decode):

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WKActionSheetAssistant.h:
  • UIProcess/ios/WKActionSheetAssistant.mm:

(-[WKActionSheetAssistant showDataDetectorsSheet]):

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView actionSheetAssistantDidStopInteraction:]):
(-[WKContentView dataDetectionContextForActionSheetAssistant:]):
(-[WKContentView selectedTextForActionSheetAssistant:]):
(-[WKContentView _dataForPreviewItemController:atPosition:type:]):

  • UIProcess/ios/WebPageProxyIOS.mm:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getPositionInformation):

5:56 PM Changeset in webkit [195573] by clopez@igalia.com
  • 29 edits
    1 add in trunk/LayoutTests

[GTK] Unreviewed GTK gardening.

Skip all inspector/sampling-profiler tests meanwhile the feature is not enabled on the GTK+ port.
Report and mark a new regression on test inspector/dom-debugger/node-removed.html timing out.
Rebaseline a bunch of tests after r194847.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/forms/auto-fill-button/input-auto-fill-button-expected.txt: Rebaseline after r194847.
  • platform/gtk/fast/forms/auto-fill-button/input-auto-fill-button-expected.png: Added. Rebaseline after r194847.
  • platform/gtk/tables/mozilla/bugs/bug1188-expected.png: Rebaseline after r194847.
  • platform/gtk/tables/mozilla/bugs/bug1188-expected.txt: Rebaseline after r194847.
  • platform/gtk/tables/mozilla/bugs/bug18359-expected.png: Rebaseline after r194847.
  • platform/gtk/tables/mozilla/bugs/bug18359-expected.txt: Rebaseline after r194847.
  • platform/gtk/tables/mozilla/bugs/bug2479-3-expected.png: Rebaseline after r194847.
  • platform/gtk/tables/mozilla/bugs/bug2479-3-expected.txt: Rebaseline after r194847.
  • platform/gtk/tables/mozilla/bugs/bug2479-4-expected.png: Rebaseline after r194847.
  • platform/gtk/tables/mozilla/bugs/bug2479-4-expected.txt: Rebaseline after r194847.
  • platform/gtk/tables/mozilla/bugs/bug29326-expected.png: Rebaseline after r194847.
  • platform/gtk/tables/mozilla/bugs/bug29326-expected.txt: Rebaseline after r194847.
  • platform/gtk/tables/mozilla/bugs/bug33855-expected.png: Rebaseline after r194847.
  • platform/gtk/tables/mozilla/bugs/bug33855-expected.txt: Rebaseline after r194847.
  • platform/gtk/tables/mozilla/bugs/bug4382-expected.png: Rebaseline after r194847.
  • platform/gtk/tables/mozilla/bugs/bug4382-expected.txt: Rebaseline after r194847.
  • platform/gtk/tables/mozilla/bugs/bug96334-expected.png: Rebaseline after r194847.
  • platform/gtk/tables/mozilla/bugs/bug96334-expected.txt: Rebaseline after r194847.
  • platform/gtk/tables/mozilla/core/margins-expected.png: Rebaseline after r194847.
  • platform/gtk/tables/mozilla/core/margins-expected.txt: Rebaseline after r194847.
  • platform/gtk/tables/mozilla/dom/tableDom-expected.png: Rebaseline after r194847.
  • platform/gtk/tables/mozilla/dom/tableDom-expected.txt: Rebaseline after r194847.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png: Rebaseline after r194847.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt: Rebaseline after r194847.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Rebaseline after r194847.
  • platform/gtk/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt: Rebaseline after r194847.
  • platform/gtk/transforms/2d/zoom-menulist-expected.png: Rebaseline after r194847.
  • platform/gtk/transforms/2d/zoom-menulist-expected.txt: Rebaseline after r194847.
5:56 PM WebKitGTK/Gardening/Calendar edited by clopez@igalia.com
(diff)
5:19 PM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro
sign up for tomorrow since I missed last week too (diff)
4:43 PM Changeset in webkit [195572] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.46-branch/LayoutTests

Merge r195492. rdar://problem/24001780

4:43 PM Changeset in webkit [195571] by matthew_hanson@apple.com
  • 6 edits
    8 adds in branches/safari-601.1.46-branch

Merge r195477. rdar://problem/24001780

4:43 PM Changeset in webkit [195570] by matthew_hanson@apple.com
  • 4 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merge r195424. rdar://problem/24222456

4:43 PM Changeset in webkit [195569] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Merge r195393. rdar://problem/24042909

4:43 PM Changeset in webkit [195568] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-601.1.46-branch

Merge r195150. rdar://problem/24208162

4:35 PM Changeset in webkit [195567] by mmaxfield@apple.com
  • 3 edits in trunk/Source/WebCore

Remove broken cache from CSSFontFaceSource
​https://bugs.webkit.org/show_bug.cgi?id=153440

Reviewed by Simon Fraser.

This cache has been broken since 2013 (r158085). Given we didn't notice a perf
hit when it broke, and the fact it's been broken for years, it clearly isn't
necessary.

​https://bugs.webkit.org/show_bug.cgi?id=153414 consists of a fairly invasive
change to CSSFontFaceSource; this patch includes a working version of this
cache, along with an easy way to enable/disable it (to measure possible perf
changes).

This patch is a short-term cleanup patch in the mean time until the above
invasive change gets landed.

No new tests because there is no behavior (or performance!) change.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::font):
(WebCore::CSSFontFaceSource::~CSSFontFaceSource): Deleted.
(WebCore::CSSFontFaceSource::pruneTable): Deleted.
(WebCore::CSSFontFaceSource::fontLoaded): Deleted.

  • css/CSSFontFaceSource.h:
4:25 PM Changeset in webkit [195566] by sbarati@apple.com
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Have top-level ScriptTimelineDataGridNode events show sample counts
​https://bugs.webkit.org/show_bug.cgi?id=153447
<rdar://problem/24334137>

Reviewed by Joseph Pecoraro.

  • UserInterface/Models/ScriptTimelineRecord.js:

(WebInspector.ScriptTimelineRecord):
(WebInspector.ScriptTimelineRecord.prototype.get profile):
(WebInspector.ScriptTimelineRecord.prototype.get callCount):
(WebInspector.ScriptTimelineRecord.prototype.isGarbageCollection):
(WebInspector.ScriptTimelineRecord.prototype._initializeProfileFromPayload):

  • UserInterface/Views/ScriptTimelineDataGridNode.js:

(WebInspector.ScriptTimelineDataGridNode.prototype.get data):

4:16 PM Changeset in webkit [195565] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the simulator build.

  • platform/spi/cocoa/DataDetectorsCoreSPI.h:
3:54 PM Changeset in webkit [195564] by weinig@apple.com
  • 5 edits
    2 copies in trunk/Source/WebCore

Roll back in r195559 with a build fix.

  • WebCore.xcodeproj/project.pbxproj:
  • editing/cocoa/DataDetection.mm:
  • platform/cocoa/DataDetectorsCoreSoftLink.mm: Added.
  • platform/cocoa/DataDetectorsCoreSoftLink.h: Added.
  • platform/spi/cocoa/DataDetectorsCoreSPI.h:
3:44 PM Changeset in webkit [195563] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix the comment about FTL_USES_B3.

  • dfg/DFGCommon.h:
3:41 PM Changeset in webkit [195562] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Switch FTL to B3 on X86_64/Mac
​https://bugs.webkit.org/show_bug.cgi?id=153445

Rubber stamped by Geoffrey Garen.

This finally switches from LLVM to B3 in the FTL on X86_64 on the Mac. We recommend that other
X86_64 platforms make the switch as well. We will be focusing our performance work on B3 rather
than LLVM in the future. ARM64 support is also coming soon, so we will be able to remove FTL
LLVM code once that lands.

Right now this mostly appears as perf-neutral on the major tests. However, it does have the
following immediate benefits:

  • Dramatic reduction in FTL compile times, on the order of 5x-10x. This means huge speed-ups in shorter-running tests like V8Spider (21%) and JSRegress (8%).
  • It makes the FTL simpler and more robust because we don't have to do stackmap section parsing. This makes it easier to add new FTL features. We are already working on features, like the sampling profiler, which will only have a FTL B3 implementation.
  • Speed-ups on some throughput benchmarks like mandreel, richards, imaging-gaussian-blur. It's still a slow down on other throughput benchmarks, though.

We started writing B3 in October, so it's pretty awesome that the throughput of the code it
generates is already on par with LLVM.

This does not fundamentally change how the FTL works. FTL was built to lower DFG IR to a C-like
SSA IR, and then rely on powerful SSA optimizations and comprehensive instruction selection and
register allocation to turn that code into something that runs fast. B3 also has a C-like SSA
IR, has an instruction selector that is in some ways more powerful than LLVM's (B3 does global
instruction selection rather than block-local like LLVM), and it has a register allocator that
is in some ways more powerful also (B3 uses IRC, a mature graph coloring allocator, while LLVM
does not do graph coloring). We expect FTL B3's performance to improve a lot after we turn it
on and can focus our efforts on tuning it.

I didn't find any test regressions after running both JSC tests and layout tests. Basic
browsing still works. JetStream performance difference is within the margin of error. EWS is
happy.

  • dfg/DFGCommon.h:
3:38 PM Changeset in webkit [195561] by Ryan Haddad
  • 4 edits
    2 deletes in trunk/Source/WebCore

Unreviewed, rolling out r195559.
​https://bugs.webkit.org/show_bug.cgi?id=153458

This change broke the iOS build (Requested by ryanhaddad on
#webkit).

Reverted changeset:

"Fix the ASAN build."
​http://trac.webkit.org/changeset/195559

Patch by Commit Queue <​commit-queue@webkit.org> on 2016-01-25

3:33 PM Changeset in webkit [195560] by Antti Koivisto
  • 8 edits in trunk/Source/WebCore

Resolving direction and writing mode properties should not mutate document
​https://bugs.webkit.org/show_bug.cgi?id=153446

Reviewed by Andreas Kling.

Replace directionSetOnDocumentElement/writingModeSetOnDocumentElement document flags them with style flags.

  • css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyValueDirection):
(WebCore::StyleBuilderCustom::resetEffectiveZoom):
(WebCore::StyleBuilderCustom::applyValueWebkitWritingMode):
(WebCore::StyleBuilderCustom::applyValueWebkitTextOrientation):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForElement):

  • dom/Document.cpp:

(WebCore::Document::Document):

  • dom/Document.h:

(WebCore::Document::markers):
(WebCore::Document::directionSetOnDocumentElement): Deleted.
(WebCore::Document::writingModeSetOnDocumentElement): Deleted.
(WebCore::Document::setDirectionSetOnDocumentElement): Deleted.
(WebCore::Document::setWritingModeSetOnDocumentElement): Deleted.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):

  • rendering/style/RenderStyle.h:
  • style/StyleResolveForDocument.cpp:

(WebCore::Style::resolveForDocument):

3:12 PM Changeset in webkit [195559] by weinig@apple.com
  • 4 edits
    2 adds in trunk/Source/WebCore

Fix the ASAN build.

  • WebCore.xcodeproj/project.pbxproj:
  • editing/cocoa/DataDetection.mm:
  • platform/cocoa/DataDetectorsCoreSoftLink.mm: Added.
  • platform/cocoa/DataDetectorsCoreSoftLink.h: Added.
  • platform/spi/cocoa/DataDetectorsCoreSPI.h:
3:08 PM Changeset in webkit [195558] by commit-queue@webkit.org
  • 13 edits in trunk

Unreviewed, rolling out r195543.
​https://bugs.webkit.org/show_bug.cgi?id=153451

regressed performance of test bots by ~6% (Requested by dydz
on #webkit).

Reverted changeset:

"WebKitTestRunner: Credential cache is not cleared between
tests"
​https://bugs.webkit.org/show_bug.cgi?id=153407
​http://trac.webkit.org/changeset/195543

2:37 PM Changeset in webkit [195557] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

Failing to upload to flakiness dashboard should not be a hard error
​https://bugs.webkit.org/show_bug.cgi?id=153444
<rdar://problem/22146294>

Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._upload_json_files): If JSON file is not generated, do not try to upload it.

2:35 PM Changeset in webkit [195556] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Marking imported/w3c/indexeddb/keyorder-private.html as flaky on mac-wk1
​https://bugs.webkit.org/show_bug.cgi?id=153438

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
2:13 PM Changeset in webkit [195555] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

[WK2][NetworkCache] Enable speculative revalidation
​https://bugs.webkit.org/show_bug.cgi?id=153443
<rdar://problem/23092196>

Reviewed by Antti Koivisto.

Enable speculative revalidation to better evaluate performance and
robustness.

  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::registerUserDefaultsIfNeeded):

2:07 PM Changeset in webkit [195554] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Marking imported/w3c/web-platform-tests/XMLHttpRequest/getresponseheader-chunked-trailer.htm as flaky
on ios-simulator, removing flaky expectation that was incorrectly added for a different WPT LayoutTest.
​https://bugs.webkit.org/show_bug.cgi?id=153371

Unreviewed test gardening.

  • platform/ios-simulator/TestExpectations:
1:40 PM Changeset in webkit [195553] by Beth Dakin
  • 2 edits in trunk/Source/WebKit/mac

Build fix.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView initWithFrame:]):
(-[WebHTMLView insertText:]):

1:38 PM Changeset in webkit [195552] by Beth Dakin
  • 4 edits in trunk/Source/WebKit/mac

WK1: Handle soft spaces after accepted candidates
​https://bugs.webkit.org/show_bug.cgi?id=153442
-and corresponding-
rdar://problem/23958418

Reviewed by Tim Horton.

The space at the end of candidates is a soft space. If that space exists,
cache the range of the space in m_softSpaceRange.

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::handleAcceptedCandidate):

New ivar in WebHTMLViewPrivate softSpaceRange keeps track to the NSRange of a
soft space if the last text that was inserted has a soft space at the end.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView initWithFrame:]):
(-[WebHTMLView _setSoftSpaceRange:]):

When new text is inserted, find out if it is being inserted right after a
soft space. If it is, then [NSSpellChecker deletesAutospaceBeforeString] will
tell us if the space needs to be removed. If that is the case, then set the
replacementString to the soft space.
(-[WebHTMLView insertText:]):

  • WebView/WebHTMLViewInternal.h:
1:12 PM Changeset in webkit [195551] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

[Win] Another build fix after r195545

  • CMakeLists.txt:

r195548 didn't change all the pre-builds back to post-builds.

1:04 PM Changeset in webkit [195550] by akling@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Restore CodeBlock jettison code Geoff accidentally removed
​https://bugs.webkit.org/show_bug.cgi?id=151241

Rubber-stamped by Geoffrey Garen.

Geoff meant to add this back in <​http://trac.webkit.org/changeset/190827>
but missed.

Then he added it back in, but it was rolled out due to a crash on Animometer.
I can no longer produce a crash on Animometer, either with today's version of
the benchmark, or the one that existed at the time of the rollout.

Given this, let's roll it back in and see how it goes.

  • bytecode/CodeBlock.cpp:

(JSC::timeToLive):
(JSC::CodeBlock::shouldJettisonDueToOldAge):

12:47 PM Changeset in webkit [195549] by fpizlo@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

mandreel should run just as fast in FTL B3 as FTL LLVM
​https://bugs.webkit.org/show_bug.cgi?id=153394

Reviewed by Gavin Barraclough.

This fixes two performance bugs and one disassembler bug.

  • B3 now turns Branches into Jumps when they are dominated by a Check on the same condition. This is like the opposite of foldPathConstants() was doing.
  • Air now supports adding to 8-bit or 16-bit memory locations on x86. B3 now knows how to lower Store8(Add(Load8Z(...))) and various other things to these new instructions.
  • Disassembler now knows to print out the instruction's width, whenever it has one. Previously, we'd print movb, movw, movl, and movq as "mov", which is unhelpful if you're storing an immediate, for example.

This adds a bunch of tests for the new instruction forms. This is a big speed-up on
mandreel. It makes us just as fast as LLVM on that benchmark.

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::add32):
(JSC::MacroAssemblerX86Common::add8):
(JSC::MacroAssemblerX86Common::add16):
(JSC::MacroAssemblerX86Common::add32AndSetFlags):
(JSC::MacroAssemblerX86Common::clz32AfterBsr):

  • assembler/X86Assembler.h:

(JSC::X86Assembler::addl_rm):
(JSC::X86Assembler::addb_rm):
(JSC::X86Assembler::addw_rm):
(JSC::X86Assembler::addl_ir):
(JSC::X86Assembler::addl_im):
(JSC::X86Assembler::addb_im):
(JSC::X86Assembler::addw_im):
(JSC::X86Assembler::addq_rr):

  • b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::addr):
(JSC::B3::Air::LowerToAir::loadPromiseAnyOpcode):
(JSC::B3::Air::LowerToAir::loadPromise):
(JSC::B3::Air::LowerToAir::tryAppendStoreBinOp):
(JSC::B3::Air::LowerToAir::lower):

  • b3/B3PureCSE.cpp:

(JSC::B3::PureCSE::clear):
(JSC::B3::PureCSE::findMatch):
(JSC::B3::PureCSE::process):

  • b3/B3PureCSE.h:
  • b3/B3ReduceStrength.cpp:
  • b3/air/AirOpcode.opcodes:
  • b3/testb3.cpp:

(JSC::B3::testNegPtr):
(JSC::B3::testStoreAddLoad32):
(JSC::B3::testStoreAddLoadImm32):
(JSC::B3::testStoreAddLoad8):
(JSC::B3::testStoreAddLoadImm8):
(JSC::B3::testStoreAddLoad16):
(JSC::B3::testStoreAddLoadImm16):
(JSC::B3::testStoreAddLoad64):
(JSC::B3::testStoreAddLoadImm64):
(JSC::B3::testStoreAddLoad32Index):
(JSC::B3::testStoreAddLoadImm32Index):
(JSC::B3::testStoreAddLoad8Index):
(JSC::B3::testStoreAddLoadImm8Index):
(JSC::B3::testStoreAddLoad16Index):
(JSC::B3::testStoreAddLoadImm16Index):
(JSC::B3::testStoreAddLoad64Index):
(JSC::B3::testStoreAddLoadImm64Index):
(JSC::B3::testStoreSubLoad):
(JSC::B3::run):
(JSC::B3::testStoreAddLoad): Deleted.

  • disassembler/udis86/udis86_syn-att.c:

(ud_translate_att):

12:37 PM Changeset in webkit [195548] by achristensen@apple.com
  • 3 edits in trunk/Source/WebCore

[Win] Fix clean build after r195545.

  • CMakeLists.txt:
  • PlatformWin.cmake:

I got a little carried away. WebCore already had a pre-build event. It was correct before r195545.

12:29 PM Changeset in webkit [195547] by Beth Dakin
  • 6 edits in trunk/Source

Handle soft spaces after accepted candidates
​https://bugs.webkit.org/show_bug.cgi?id=153331
-and corresponding-
rdar://problem/23958418

Reviewed by Darin Adler.

Source/WebCore:

Candidates now come with built-in spaces, so we should not insert a space for
them.

  • editing/Editor.cpp:

(WebCore::Editor::handleAcceptedCandidate):

New SPI to properly handle these soft spaces.

  • platform/spi/mac/NSSpellCheckerSPI.h:

Source/WebKit2:

New member variable m_softSpaceRange keeps track to the NSRange of a soft
space if the last text that was inserted has a soft space at the end.

  • UIProcess/Cocoa/WebViewImpl.h:
  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::WebViewImpl):

The space at the end of candidates is a soft space. If that space exists,
cache the range of the space in m_softSpaceRange.
(WebKit::WebViewImpl::handleAcceptedCandidate):

When new text is inserted, find out if it is being inserted right after a
soft space. If it is, then [NSSpellChecker deletesAutospaceBeforeString] will
tell us if the space needs to be removed. If that is the case, then set the
replacementString to the soft space.
(WebKit::WebViewImpl::insertText):

12:25 PM Changeset in webkit [195546] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Marking inspector/heap/garbageCollected.html as flaky on mac-wk1 debug
​https://bugs.webkit.org/show_bug.cgi?id=153039

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
12:12 PM Changeset in webkit [195545] by achristensen@apple.com
  • 11 edits in trunk/Source

[Win] Copy forwarding headers before building a project
​https://bugs.webkit.org/show_bug.cgi?id=153434

Reviewed by Brent Fulgham.

Source/JavaScriptCore:

  • CMakeLists.txt:
  • PlatformWin.cmake:

Source/WebCore:

  • CMakeLists.txt:
  • PlatformWin.cmake:

Source/WebKit:

  • PlatformWin.cmake:

Source/WTF:

  • wtf/CMakeLists.txt:
  • wtf/PlatformWin.cmake:
11:48 AM Changeset in webkit [195544] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Reduce unnecessary forced layouts in TimelineOverview
​https://bugs.webkit.org/show_bug.cgi?id=153392
<rdar://problem/24312344>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-01-25
Reviewed by Timothy Hatcher.

  • UserInterface/Views/TimelineOverview.js:

(WebInspector.TimelineOverview.prototype.layout):
Ignore setting the scrollLeft if we would be setting it to 0.
This helps avoid a forced layout in common cases.

10:41 AM Changeset in webkit [195543] by dbates@webkit.org
  • 13 edits in trunk

WebKitTestRunner: Credential cache is not cleared between tests
​https://bugs.webkit.org/show_bug.cgi?id=153407
<rdar://problem/24280834>

Reviewed by Brady Eidson.

Source/WebKit2:

Add SPI to call NetworkStorageSession::switchToNewTestingSession() to create a new testing session.
The new testing session will have an empty credential cache.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::switchToNewTestingSession): Added.

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in: Added message SwitchToNewTestingSession().
  • UIProcess/API/C/WKContext.cpp:

(WKContextResetTestingNetworkSession): Added.

  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::resetTestingNetworkSession): Added.

  • UIProcess/WebProcessPool.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::switchToNewTestingSession): Added.

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in: Added message SwitchToNewTestingSession().

Tools:

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues): Reset testing network session
to clear cached credentials.

10:38 AM Changeset in webkit [195542] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Marking http/tests/loading/preload-no-store-frame-src.html as failing on ios-simulator
​https://bugs.webkit.org/show_bug.cgi?id=152446

Unreviewed test gardening.

  • platform/ios-simulator/TestExpectations:
10:20 AM Changeset in webkit [195541] by beidson@apple.com
  • 4 edits in trunk

Modern IDB: Implement getIndexRecord in the SQLite backing store.
​https://bugs.webkit.org/show_bug.cgi?id=153425

Reviewed by Darin Adler.

Source/WebCore:

No new tests (Some failures now pass, other failures progressed closer to passing).

  • Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::getIndexRecord):

LayoutTests:

  • platform/mac-wk1/TestExpectations:
9:55 AM Changeset in webkit [195540] by eric.carlson@apple.com
  • 3 edits
    2 adds in trunk

Media "ended" event incorrectly fires when currentTime is set
​https://bugs.webkit.org/show_bug.cgi?id=150348
<rdar://problem/24247974>

Reviewed by Jer Noble.

Source/WebCore:

Test: media/media-ended-fired-once.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::invalidateCachedTime): Always mark m_cachedTime as invalid.

LayoutTests:

  • media/media-ended-fired-once-expected.txt: Added.
  • media/media-ended-fired-once.html: Added.
9:49 AM Changeset in webkit [195539] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Do not convert GlyphBufferAdvance to FloatSize
​https://bugs.webkit.org/show_bug.cgi?id=153421

Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-01-25
Reviewed by Simon Fraser.

No new tests needed.

  • platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::DrawGlyphs::computeBounds):

9:23 AM Changeset in webkit [195538] by rniwa@webkit.org
  • 20 edits
    2 adds in trunk

document.createElement should be able to create a custom element
​https://bugs.webkit.org/show_bug.cgi?id=153173

Reviewed by Darin Adler.

Source/WebCore:

Added the support for constructing a custom element via document.createElement.

Extracted HTMLElementFactory::createKnownElement, which returns nullptr when the specified name doesn't match
any builtin element instead of out of HTMLUnknownElement, out of HTMLElementFactory::createElement.

Test: fast/custom-elements/Document-createElement.html

  • bindings/js/JSCustomElementInterface.cpp:

(WebCore::JSCustomElementInterface::constructHTMLElement): Added. Constructs a custom element by invoking its
constructor. We allow exceptions to be thrown by the constructor so the caller is responsible for checking
any exceptions in the ExecState before preceeding if the returned value is null.

  • bindings/js/JSCustomElementInterface.h:

(WebCore::JSCustomElementInterface::constructSVGElement): Added.

  • bindings/js/JSElementCustom.cpp:

(WebCore::toJSNewlyCreated): Exit early if the element is a custom element as the wrapper had already been
created by super() call inside the custom element'c constructor.

  • bindings/js/JSMainThreadExecState.h:

(WebCore::JSMainThreadExecState):

  • bindings/js/JSMainThreadExecStateInstrumentation.h:

(WebCore::JSMainThreadExecState::instrumentFunctionInternal): Generalized from instrumentFunctionCall so that
we can use it for both call and construct.
(WebCore::JSMainThreadExecState::instrumentFunctionCall): Specialized the above function for call.
(WebCore::JSMainThreadExecState::instrumentFunctionConstruct): Ditto for construct.

  • dom/CustomElementDefinitions.cpp:

(WebCore::CustomElementDefinitions::findInterface): Added.

  • dom/CustomElementDefinitions.h:
  • dom/Document.cpp:

(WebCore::createHTMLElementWithNameValidation): Extracted from createElement.
(WebCore::Document::createElementForBindings): Renamed from createElement. Specifies
ShouldCreateCustomElement::Create to create a custom element before using fallback elements.

  • dom/Document.h:
  • dom/Document.idl:
  • dom/Node.h:

(WebCore::Node::isCustomElement): Added. This flag is used to identify a custom element.
(WebCore::Node::setIsCustomElement): Added.

  • dom/make_names.pl: Extracted createKnownElement from createElement for createHTMLElementWithNameValidation.
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::createInspectorStyleSheetForDocument): Use qualified name object to instantiate
a style element and set type content attribute.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setNodeName): Use createElementForBindings here since we might be creating an
arbitrary element here. Also use RefPtr instead of raw pointers while mutating DOM for safety.

Source/WebKit/win:

Use createElementForBindings here since this is a C++ binding for Windows.

  • DOMCoreClasses.cpp:

(DOMDocument::createElement):

Source/WebKit2:

Use createElementForBindings here since this is for SPI.

  • WebProcess/InjectedBundle/API/mac/WKDOMDocument.mm:

(-[WKDOMDocument createElement:]):
(-[WKDOMDocument createTextNode:]):

LayoutTests:

Add a test for creating a custom elemnet via document.createElement.
The behavior is to be documented later.

  • fast/custom-elements/Document-createElement-expected.txt: Added.
  • fast/custom-elements/Document-createElement.html: Added.
9:13 AM Changeset in webkit [195537] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebCore

REGRESSION(r192773): [GTK] maps.google.com unresponsive/stalls since r192773
​https://bugs.webkit.org/show_bug.cgi?id=153194

Reviewed by Michael Catanzaro.

In r192773 we implemented the JavaScriptCore garbage collector
timers for the GTK+ port. Those timers schedule sources in the
current thread default main context, but JS web worker threads
implementation doesn't use WTF::RunLoop, but its own WorkerRunLoop
class that doesn't create a GMainContext for the new thread. This
means that for web sites using workers, we are now doing garbage
collection of worker VMs in the main thread which ends up in a
deadlock at some point. We need to ensure that worker threads
create a GMainContext and push it as the default one for the
thread before the WorkerGlobalScope is created. This way when the
worker Heap is created, the GC timers use the right context to
schedule their sources. And then we need to check if there are
sources pending in the thread main context on every worker run
loop iteration.

  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::runInMode):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread):

8:19 AM Changeset in webkit [195536] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: timelines clear button should be inactive if nothing can be cleared
​https://bugs.webkit.org/show_bug.cgi?id=132756

Patch by Johan K. Jensen <​jj@johanjensen.dk> on 2016-01-25
Reviewed by Timothy Hatcher.

  • UserInterface/Views/TimelineRecordingContentView.js:

(WebInspector.TimelineRecordingContentView.prototype.shown):
Enable clear button if timeline is not readonly and contains data, when switching timelines.
(WebInspector.TimelineRecordingContentView.prototype._capturingStarted):
Enable clear button when a capturing starts.
(WebInspector.TimelineRecordingContentView.prototype._recordingReset):
Disable clear button after resetting recording.

8:18 AM Changeset in webkit [195535] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r195533.
​https://bugs.webkit.org/show_bug.cgi?id=153423

It is again breaking builds of several ports (Requested by
youenn on #webkit).

Reverted changeset:

"WebCoreJSBuiltins do not use to do conditional include"
​https://bugs.webkit.org/show_bug.cgi?id=153306
​http://trac.webkit.org/changeset/195533

8:17 AM Changeset in webkit [195534] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Timelines: "Timer Installed150ms delay" — no space before the delay number
​https://bugs.webkit.org/show_bug.cgi?id=153416

Reviewed by Timothy Hatcher.

Fix for tree element subtitle rule that regressed in ​https://bugs.webkit.org/show_bug.cgi?id=153146.

  • UserInterface/Views/TreeOutline.css:

(.tree-outline .item .alternate-subtitle::before):
Em dash should be inserted before both subtitle types.

6:06 AM Changeset in webkit [195533] by youenn.fablet@crf.canon.fr
  • 4 edits in trunk/Source/WebCore

WebCoreJSBuiltins do not use to do conditional include
​https://bugs.webkit.org/show_bug.cgi?id=153306

Reviewed by Alex Christensen.

Removing compilation guards as builtin generator adds them in the files themselves.
Fixing MediaDevices.js to generate MEDIA_STREAM compilation guard.

No change in behavior.

  • Modules/mediastream/MediaDevices.js: Changing @optional to @conditional.
  • bindings/js/WebCoreJSBuiltins.cpp:
  • bindings/js/WebCoreJSBuiltins.h:
3:57 AM Changeset in webkit [195532] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r195531.
​https://bugs.webkit.org/show_bug.cgi?id=153420

It is breaking builds of several ports (Requested by youenn on
#webkit).

Reverted changeset:

"WebCoreJSBuiltins do not use to do conditional include"
​https://bugs.webkit.org/show_bug.cgi?id=153306
​http://trac.webkit.org/changeset/195531

3:36 AM Changeset in webkit [195531] by youenn.fablet@crf.canon.fr
  • 3 edits in trunk/Source/WebCore

WebCoreJSBuiltins do not use to do conditional include
​https://bugs.webkit.org/show_bug.cgi?id=153306

Reviewed by Alex Christensen.

Removing compilation guards as builtin generator adds them in the files themselves.

No change in behavior.

  • bindings/js/WebCoreJSBuiltins.cpp:
  • bindings/js/WebCoreJSBuiltins.h:
2:53 AM Changeset in webkit [195530] by youenn.fablet@crf.canon.fr
  • 21 edits
    22 adds in trunk

[Fetch API] Implement Fetch API Headers
​https://bugs.webkit.org/show_bug.cgi?id=152384

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

  • web-platform-tests/fetch/api/headers/headers-basic-expected.txt: Added.
  • web-platform-tests/fetch/api/headers/headers-basic.html: Added.
  • web-platform-tests/fetch/api/headers/headers-casing-expected.txt: Added.
  • web-platform-tests/fetch/api/headers/headers-casing.html: Added.
  • web-platform-tests/fetch/api/headers/headers-errors-expected.txt: Added.
  • web-platform-tests/fetch/api/headers/headers-errors.html: Added.
  • web-platform-tests/fetch/api/headers/headers-idl-expected.txt: Added.
  • web-platform-tests/fetch/api/headers/headers-idl.html: Added.
  • web-platform-tests/fetch/api/headers/headers-nameshake-expected.txt: Added.
  • web-platform-tests/fetch/api/headers/headers-nameshake.html: Added.
  • web-platform-tests/fetch/api/headers/headers-normalize-expected.txt: Added.
  • web-platform-tests/fetch/api/headers/headers-normalize.html: Added.
  • web-platform-tests/fetch/api/headers/headers-structure-expected.txt: Added.
  • web-platform-tests/fetch/api/headers/headers-structure.html: Added.

Source/WebCore:

Adding Fetch Headers API as a wapper around HTTPHeaderMap.

Tests: imported/w3c/web-platform-tests/fetch/api/headers/headers-basic.html

imported/w3c/web-platform-tests/fetch/api/headers/headers-casing.html
imported/w3c/web-platform-tests/fetch/api/headers/headers-errors.html
imported/w3c/web-platform-tests/fetch/api/headers/headers-idl.html
imported/w3c/web-platform-tests/fetch/api/headers/headers-nameshake.html
imported/w3c/web-platform-tests/fetch/api/headers/headers-normalize.html
imported/w3c/web-platform-tests/fetch/api/headers/headers-structure.html

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • Modules/fetch/FetchHeaders.cpp: Added.

(WebCore::FetchHeaders::initializeWith):
(WebCore::isForbiddenHeaderName):
(WebCore::isForbiddenResponseHeaderName):
(WebCore::isSimpleHeader):
(WebCore::canWriteHeader):
(WebCore::FetchHeaders::append):
(WebCore::FetchHeaders::remove):
(WebCore::FetchHeaders::get):
(WebCore::FetchHeaders::has):
(WebCore::FetchHeaders::set):

  • Modules/fetch/FetchHeaders.h: Added.

(WebCore::FetchHeaders::create):
(WebCore::FetchHeaders::~FetchHeaders):
(WebCore::FetchHeaders::internalHeaders):
(WebCore::FetchHeaders::FetchHeaders):

  • Modules/fetch/FetchHeaders.idl: Added.
  • Modules/fetch/FetchHeaders.js: Added.

(initializeFetchHeaders):

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/WebCoreBuiltinNames.h:
  • bindings/js/WebCoreJSBuiltins.cpp:
  • bindings/js/WebCoreJSBuiltins.h:

(WebCore::JSBuiltinFunctions::JSBuiltinFunctions):
(WebCore::JSBuiltinFunctions::fetchHeadersBuiltins):

  • platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::contains):
(WebCore::HTTPHeaderMap::remove):

  • platform/network/HTTPHeaderMap.h:

LayoutTests:

  • js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
  • js/dom/global-constructors-attributes-expected.txt:
  • platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
  • platform/efl/js/dom/global-constructors-attributes-expected.txt:
  • platform/gtk/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
  • platform/win/js/dom/global-constructors-attributes-expected.txt:
1:24 AM Changeset in webkit [195529] by svillar@igalia.com
  • 6 edits in trunk

[css-grid] grid shorthand must reset gap properties to their initial values
​https://bugs.webkit.org/show_bug.cgi?id=153354

Reviewed by Darin Adler.

Source/WebCore:

Both 'grid-row-gap' & 'grid-column-gap' are considered reset-only subproperties of the
'grid' shorthand meaning that, even thought the shorthand does not offer a way to set
their values, it must in any case reset them to the initial ones.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseGridShorthand):

  • css/CSSPropertyNames.in:

LayoutTests:

  • fast/css-grid-layout/grid-shorthand-get-set-expected.txt:
  • fast/css-grid-layout/grid-shorthand-get-set.html:
12:18 AM Changeset in webkit [195528] by akling@apple.com
  • 24 edits in trunk/Source/JavaScriptCore

Reduce number of Structures created at startup.
<​https://webkit.org/b/153399>

Reviewed by Darin Adler.

For *Constructor and *Prototype objects that are only created once per JSGlobalObject,
build up the Structures using addPropertyWithoutTransition() helpers to avoid creating
tons of transitions that would just end up floating around and never getting used.

  • inspector/JSInjectedScriptHostPrototype.cpp:

(Inspector::JSInjectedScriptHostPrototype::finishCreation):

  • inspector/JSJavaScriptCallFramePrototype.cpp:

(Inspector::JSJavaScriptCallFramePrototype::finishCreation):

  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::finishCreation):

  • runtime/ConsolePrototype.cpp:

(JSC::ConsolePrototype::finishCreation):

  • runtime/DatePrototype.cpp:

(JSC::DatePrototype::finishCreation):

  • runtime/JSArrayBufferConstructor.cpp:

(JSC::JSArrayBufferConstructor::finishCreation):

  • runtime/JSArrayBufferPrototype.cpp:

(JSC::JSArrayBufferPrototype::finishCreation):

  • runtime/JSObject.cpp:

(JSC::JSObject::putDirectNativeFunctionWithoutTransition):
(JSC::JSObject::putDirectBuiltinFunctionWithoutTransition): Deleted.

  • runtime/JSObject.h:
  • runtime/JSPromiseConstructor.cpp:

(JSC::JSPromiseConstructor::addOwnInternalSlots):

  • runtime/JSPromisePrototype.cpp:

(JSC::JSPromisePrototype::addOwnInternalSlots):

  • runtime/JSTypedArrayViewConstructor.cpp:

(JSC::JSTypedArrayViewConstructor::finishCreation):

  • runtime/JSTypedArrayViewPrototype.cpp:

(JSC::JSTypedArrayViewPrototype::finishCreation):

  • runtime/MapIteratorPrototype.cpp:

(JSC::MapIteratorPrototype::finishCreation):

  • runtime/MapPrototype.cpp:

(JSC::MapPrototype::finishCreation):

  • runtime/NumberPrototype.cpp:

(JSC::NumberPrototype::finishCreation):

  • runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::finishCreation):

  • runtime/ObjectPrototype.cpp:

(JSC::ObjectPrototype::finishCreation):

  • runtime/SetIteratorPrototype.cpp:

(JSC::SetIteratorPrototype::finishCreation):

  • runtime/SetPrototype.cpp:

(JSC::SetPrototype::finishCreation):

  • runtime/StringPrototype.cpp:

(JSC::StringPrototype::finishCreation):

  • runtime/WeakMapPrototype.cpp:

(JSC::WeakMapPrototype::finishCreation):

  • runtime/WeakSetPrototype.cpp:

(JSC::WeakSetPrototype::finishCreation):

Jan 24, 2016:

11:55 PM Changeset in webkit [195527] by beidson@apple.com
  • 18 edits in trunk

Modern IDB: Implement deleteIndex and getCount for the SQLite backing store.
​https://bugs.webkit.org/show_bug.cgi?id=153415

Reviewed by Darin Adler.

Source/WebCore:

No new tests (Handful of tests now pass, improvements on a handful of others).

  • Modules/indexeddb/server/IDBBackingStore.h:
  • Modules/indexeddb/server/MemoryIDBBackingStore.cpp:

(WebCore::IDBServer::MemoryIDBBackingStore::deleteIndex):

  • Modules/indexeddb/server/MemoryIDBBackingStore.h:
  • Modules/indexeddb/server/MemoryObjectStore.cpp:

(WebCore::IDBServer::MemoryObjectStore::takeIndexByIdentifier):
(WebCore::IDBServer::MemoryObjectStore::deleteIndex):
(WebCore::IDBServer::MemoryObjectStore::deleteAllIndexes):
(WebCore::IDBServer::MemoryObjectStore::takeIndexByName): Deleted.

  • Modules/indexeddb/server/MemoryObjectStore.h:
  • Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::getCount):

  • Modules/indexeddb/server/SQLiteIDBBackingStore.h:
  • Modules/indexeddb/server/SQLiteIDBCursor.cpp:

(WebCore::IDBServer::SQLiteIDBCursor::maybeCreateBackingStoreCursor):
(WebCore::IDBServer::SQLiteIDBCursor::SQLiteIDBCursor):

  • Modules/indexeddb/server/SQLiteIDBCursor.h:
  • Modules/indexeddb/server/SQLiteIDBTransaction.cpp:

(WebCore::IDBServer::SQLiteIDBTransaction::maybeOpenBackingStoreCursor):

  • Modules/indexeddb/server/SQLiteIDBTransaction.h:
  • Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::deleteIndex):
(WebCore::IDBServer::UniqueIDBDatabase::performDeleteIndex):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformDeleteIndex):

  • Modules/indexeddb/server/UniqueIDBDatabase.h:
  • Modules/indexeddb/shared/IDBObjectStoreInfo.cpp:

(WebCore::IDBObjectStoreInfo::deleteIndex):

  • Modules/indexeddb/shared/IDBObjectStoreInfo.h:

LayoutTests:

  • platform/mac-wk1/TestExpectations:
11:45 PM Changeset in webkit [195526] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

Report upload progress to NetworkLoadClient when using NetworkSession
​https://bugs.webkit.org/show_bug.cgi?id=153388

Patch by Alex Christensen <​achristensen@webkit.org> on 2016-01-24
Reviewed by Darin Adler.

This fixes http/tests/xmlhttprequest/upload-onload-event.html and a few other tests.

  • NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::didBecomeDownload):
(WebKit::NetworkLoad::didSendData):
(WebKit::NetworkLoad::didReceiveResponseAsync):

  • NetworkProcess/NetworkLoad.h:
  • NetworkProcess/NetworkSession.h:

(WebKit::NetworkSessionTaskClient::~NetworkSessionTaskClient):

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate initWithNetworkSession:]):
(-[WKNetworkSessionDelegate URLSession:task:didSendBodyData:totalBytesSent:totalBytesExpectedToSend:]):
(-[WKNetworkSessionDelegate URLSession:task:willPerformHTTPRedirection:newRequest:completionHandler:]):

11:04 PM Changeset in webkit [195525] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, speculative fix for:
Modern IDB: Some IDB tests crash in ~SQLiteIDBBackingStore
​https://bugs.webkit.org/show_bug.cgi?id=153418

No new tests.

  • Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::~SQLiteIDBBackingStore): Clear the global object

before wiping out the VM.

10:13 PM Changeset in webkit [195524] by Gyuyoung Kim
  • 18 edits in trunk/Source

Reduce PassRefPtr uses in dom - 4
​https://bugs.webkit.org/show_bug.cgi?id=153270

Reviewed by Darin Adler.

As a step to remove PassRefPtr uses, this patch reduces the uses in WebCore/dom.

Source/WebCore:

  • bindings/js/JSDeviceMotionEventCustom.cpp:

(WebCore::JSDeviceMotionEvent::initDeviceMotionEvent):

  • dom/DeviceMotionData.cpp:

(WebCore::DeviceMotionData::create):
(WebCore::DeviceMotionData::DeviceMotionData):

  • dom/DeviceMotionData.h:
  • dom/Document.cpp:

(WebCore::Document::setBodyOrFrameset):
(WebCore::Document::setFocusedElement):
(WebCore::Document::setDecoder):
(WebCore::Document::pushCurrentScript):

  • dom/Document.h:
  • dom/Event.cpp:

(WebCore::Event::cloneFor):

  • dom/Event.h:
  • dom/MouseEvent.cpp:

(WebCore::MouseEvent::cloneFor):

  • dom/MouseEvent.h:
  • dom/NodeIterator.cpp:

(WebCore::NodeIterator::NodePointer::NodePointer):
(WebCore::NodeIterator::NodeIterator):

  • dom/NodeIterator.h:

(WebCore::NodeIterator::create):

  • html/RadioInputType.cpp:

(WebCore::RadioInputType::handleKeydownEvent):

  • platform/ios/DeviceMotionClientIOS.mm:

(WebCore::DeviceMotionClientIOS::motionChanged):

  • xml/XSLTProcessor.cpp:

(WebCore::XSLTProcessor::createDocumentFromSource):

Source/WebKit/win:

  • Plugins/PluginView.cpp:

(WebCore::PluginView::focusPluginElement):

Source/WebKit2:

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::focusPluginElement):

9:23 PM Changeset in webkit [195523] by mmaxfield@apple.com
  • 9 edits in trunk/Source/WebCore

[Font Loading] General cleanup
​https://bugs.webkit.org/show_bug.cgi?id=153403

Reviewed by Darin Adler.

It turns out that CSSFontFaceSource::m_hasExternalSVGFont exactly equals
whether or not CSSFontFaceSource::m_font is a CachedSVGFont. Therefore,
the variable is redundant.

In addition, it was being passed to functions on CSSFontFaceSource::m_font,
which means it was always true inside the CachedSVGFont subclass and
always false for the CachedFont. Therefore, there is no reason pass this
variable to these functions because its value can be determined at
authorship time.

No new tests because there is no behavior change.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::font):
(WebCore::CSSFontFaceSource::CSSFontFaceSource): Deleted.

  • css/CSSFontFaceSource.h:
  • css/CSSFontSelector.cpp:

(WebCore::createFontFace):

  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::ensureCustomFontData):
(WebCore::CachedFont::createFont):

  • loader/cache/CachedFont.h:
  • loader/cache/CachedSVGFont.cpp:

(WebCore::CachedSVGFont::createFont):
(WebCore::CachedSVGFont::ensureCustomFontData):

  • loader/cache/CachedSVGFont.h:
  • platform/network/HTTPParsers.cpp:

(WebCore::isValidHTTPToken):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::uppercaseKnownHTTPMethod):

8:00 PM Changeset in webkit [195522] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: add support for placing Views in DataGrid column headers
​https://bugs.webkit.org/show_bug.cgi?id=153387
<rdar://problem/24310797>

Reviewed by Timothy Hatcher.

This patch adds a new DataGrid column property, headerView, allowing a
custom View object to be placed in a column's header cell. The grid ensures
that the left and right edges of the view are kept in sync as columns are
resized. As most views use absolute positioning and are styled in CSS, the
vertical position and height of the view isn't set by the grid.

  • UserInterface/Views/DataGrid.js:

(WebInspector.DataGrid.prototype.insertColumn):
If the new column includes the headerView column data property,
it should take priority over titleDOMFragment and title text.
The specified View object is inserted into the DOM under the
column's <th> element, and added as a subview of the data grid.
(WebInspector.DataGrid.prototype.layout):
Update header views after performing default layout.
(WebInspector.DataGrid.prototype._showColumn):
Set hidden column property false instead of deleting it.
(WebInspector.DataGrid.prototype._positionHeaderViews):
Update the left and right style positions for all Views embedded in
column header cells, then update their layouts.
(WebInspector.DataGrid.prototype.resizerDragging):
Update header views after column resizers are repositioned.

5:19 PM Changeset in webkit [195521] by Chris Dumez
  • 3 edits in trunk/LayoutTests

Unreviewed, update test after r195497

This test did not make much sense as it was, after the behavior change
in r195497.

  • fast/dom/Document/document-charset-expected.txt:
  • fast/dom/Document/document-charset.html:
5:11 PM Changeset in webkit [195520] by Chris Dumez
  • 45 edits
    2 adds in trunk

An XMLDocument interface should be exposed on the global Window object
​https://bugs.webkit.org/show_bug.cgi?id=153378
<rdar://problem/24315465>

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline several W3C DOM and HTML tests now that more checks are
passing.

  • web-platform-tests/dom/interfaces-expected.txt:
  • web-platform-tests/dom/nodes/Document-constructor-expected.txt:
  • web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

Expose an XMLDocument interface on the global Window object, as per:

DOMImplementation.createDocument() now returns an XMLDocument instead
of a Document, as per:

Previously, WebKit would alias XMLDocument to Document which caused
some W3C tests to fail.

Chrome and Firefox already match the specification here.

No new tests, already covered by existing tests.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSDocumentCustom.cpp:

(WebCore::createNewDocumentWrapper):

  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):

  • dom/DOMImplementation.h:
  • dom/DOMImplementation.idl:
  • dom/Document.cpp:

(WebCore::Document::cloneDocumentWithoutChildren):

  • dom/Document.h:

(WebCore::Document::isXMLDocument):
(WebCore::Document::create): Deleted.
(WebCore::Document::createNonRenderedPlaceholder): Deleted.

  • dom/XMLDocument.h: Added.

(WebCore::XMLDocument::create):
(WebCore::XMLDocument::createXHTML):
(WebCore::XMLDocument::XMLDocument):
(isType):

  • dom/XMLDocument.idl: Added.
  • inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::patchDocument):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::setOuterHTML):

  • page/DOMWindow.idl:
  • page/PageSerializer.cpp:

(WebCore::SerializerMarkupAccumulator::SerializerMarkupAccumulator):

  • svg/SVGDocument.cpp:

(WebCore::SVGDocument::SVGDocument):

  • svg/SVGDocument.h:
  • svg/SVGDocument.idl:
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::responseXML):

  • xml/XSLTProcessor.cpp:

(WebCore::XSLTProcessor::createDocumentFromSource):

LayoutTests:

Rebaseline some layout tests now that XMLDocument is exposed.

  • fast/dom/DOMImplementation/createDocument-namespace-err-expected.txt:
  • fast/dom/DOMImplementation/script-tests/createDocument-namespace-err.js:
  • fast/dom/Document/clone-node-expected.txt:
  • fast/dom/Document/clone-node.html:
  • fast/dom/Document/xml-document-focus-expected.txt:
  • fast/dom/Document/xml-document-focus.xml:
  • fast/dom/dom-parse-serialize-display-expected.txt:
  • fast/dom/dom-parse-serialize-expected.txt:
  • fast/dom/wrapper-classes-expected.txt:
  • fast/dom/wrapper-classes.html:
  • fast/dom/xmlserializer-serialize-to-string-exception-expected.txt:
  • fast/xmlhttprequest/xmlhttprequest-bad-mimetype-expected.txt:
  • http/tests/xmlhttprequest/supported-xml-content-types-expected.txt:
  • platform/mac/fast/dom/Window/window-lookup-precedence-expected.txt:
4:58 PM Changeset in webkit [195519] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Highlight timeline range handles on hover
​https://bugs.webkit.org/show_bug.cgi?id=153395
<rdar://problem/24312364>

Reviewed by Timothy Hatcher.

  • UserInterface/Views/TimelineRuler.css:

(.timeline-ruler > .selection-handle.clamped):
Gardening. No need to repeat "1px solid".

(.timeline-ruler > .selection-handle:hover, .timeline-ruler > .selection-handle:active):
":active" pseudo selector is needed to keep the handle highligted while it's being dragged
regardress if the mouse cursor is hovering over it or not.

3:43 PM Changeset in webkit [195518] by Simon Fraser
  • 3 edits in trunk/LayoutTests

New WK1 baselines.

  • platform/mac-wk1/displaylists/extent-includes-shadow-expected.txt:
  • platform/mac-wk1/displaylists/extent-includes-transforms-expected.txt:
3:42 PM Changeset in webkit [195517] by beidson@apple.com
  • 9 edits in trunk

Modern IDB: Support IDBObjectStore.createIndex in the SQLite backing store.
​https://bugs.webkit.org/show_bug.cgi?id=153410

Reviewed by Darin Adler.

Source/WebCore:

No new tests (Covered by unskipping many existing tests).

  • Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::~SQLiteIDBBackingStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedHasIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedPutIndexRecord):

  • Modules/indexeddb/server/SQLiteIDBBackingStore.h:
  • Modules/indexeddb/server/SQLiteIDBCursor.cpp:

(WebCore::IDBServer::SQLiteIDBCursor::maybeCreateBackingStoreCursor):
(WebCore::IDBServer::SQLiteIDBCursor::SQLiteIDBCursor):

  • Modules/indexeddb/server/SQLiteIDBCursor.h:
  • Modules/indexeddb/server/SQLiteIDBTransaction.cpp:

(WebCore::IDBServer::SQLiteIDBTransaction::maybeOpenBackingStoreCursor):

  • Modules/indexeddb/server/SQLiteIDBTransaction.h:

LayoutTests:

  • platform/mac-wk1/TestExpectations:
12:39 PM Changeset in webkit [195516] by Simon Fraser
  • 7 edits in trunk

Make the dumped display list representation a bit more compact
​https://bugs.webkit.org/show_bug.cgi?id=153409

Reviewed by Zalan Bujtas.
Source/WebCore:

Don't make a group for every display list item.

  • platform/graphics/displaylists/DisplayList.cpp:

(WebCore::DisplayList::DisplayList::asText):

LayoutTests:

Updated results.

  • displaylists/extent-includes-shadow-expected.txt:
  • displaylists/extent-includes-transforms-expected.txt:
  • displaylists/layer-dispay-list-expected.txt:
  • displaylists/replay-skip-clipped-rect-expected.txt:
12:39 PM Changeset in webkit [195515] by Simon Fraser
  • 14 edits
    3 adds in trunk

Add testing for display list replay, and skip clipped-out items on replay
​https://bugs.webkit.org/show_bug.cgi?id=153408

Reviewed by Zalan Bujtas.
Source/WebCore:

Make it possible to save and serialize a DisplayList of Items which were
actually applied on replay, so that replay-time optimizations can be tested.

This exposes internals.setElementTracksDisplayListReplay() and
internals.replayDisplayListForElement().

Do a trivial replay-time optimization, which is to skip items whose extents are
outside the replay clip.

Test: displaylists/replay-skip-clipped-rect.html

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::GraphicsLayer):

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::setIsTrackingDisplayListReplay):
(WebCore::GraphicsLayer::isTrackingDisplayListReplay):
(WebCore::GraphicsLayer::replayDisplayListAsText):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::layerDisplayListMap): Use a singleton map to store the replay display lists
to avoid bloating GraphicsLayerCA for test-only code. The map stores a pair of the
replay list and a clip rect, which are both dumped. Dumping the clip rect ensures that
we're reporting the replay for the correct tile in a test (since there will be a replay
for each tile).
(WebCore::GraphicsLayerCA::~GraphicsLayerCA):
(WebCore::GraphicsLayerCA::platformCALayerPaintContents):
(WebCore::GraphicsLayerCA::setIsTrackingDisplayListReplay):
(WebCore::GraphicsLayerCA::replayDisplayListAsText):

  • platform/graphics/ca/GraphicsLayerCA.h:
  • platform/graphics/displaylists/DisplayList.h:

(WebCore::DisplayList::DisplayList::appendItem):

  • platform/graphics/displaylists/DisplayListReplayer.cpp:

(WebCore::DisplayList::Replayer::replay): In the unlikely event of tracking replays,
allocate a new DisplayList and append to it items which actually get applied.

  • platform/graphics/displaylists/DisplayListReplayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::setIsTrackingDisplayListReplay):
(WebCore::RenderLayerBacking::replayDisplayListAsText):

  • rendering/RenderLayerBacking.h:
  • testing/Internals.cpp:

(WebCore::Internals::setElementTracksDisplayListReplay):
(WebCore::Internals::replayDisplayListForElement):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Test that a clipped-out rectangle is not painted.

In order to get the rect into the display list, we need to make the target
compositing layer be tiled, and to be clipped by an ancestor so that only the
second tile renders. (This complexity is required because in simpler scenarios,
the rect is clipped out at recording time.)

  • displaylists/replay-skip-clipped-rect-expected.txt: Added.
  • displaylists/replay-skip-clipped-rect.html: Added.
  • displaylists/resources/dump-target-replay-list.js: Added.

(doTest):

12:39 PM Changeset in webkit [195514] by Simon Fraser
  • 2 edits in trunk/LayoutTests

Layout Test displaylists/extent-includes-transforms.html is flaky on mac-wk1
​https://bugs.webkit.org/show_bug.cgi?id=153308

Reviewed by Dan Bernstein.

Rather than assuming that a zero-delay timer will fire after the next layer flush,
force a flush with testRunner.display(), which fixes flakiness.

  • displaylists/resources/dump-target-display-list.js:

(doTest):

9:06 AM Changeset in webkit [195513] by mitz@apple.com
  • 2 edits in trunk/Tools

Added project.xcworkspace and xcuserdata to this project’s svn:ignore.

  • LayoutTestRelay/LayoutTestRelay.xcodeproj: Added property svn:ignore.
Note: See TracTimeline for information about the timeline view.