⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 15, 2016:

11:14 PM Changeset in webkit [196627] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.5.17.1.1/Source

Versioning.

11:12 PM Changeset in webkit [196626] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.5.17.1.1

New tag.

11:10 PM Changeset in webkit [196625] by mark.lam@apple.com
  • 14 edits in trunk/LayoutTests

[ARMv7] Some JSC test fails due to exhausting the JIT code heap on the no LLINT test configuration.
​https://bugs.webkit.org/show_bug.cgi?id=151611

Reviewed by Saam Barati.

These tests are only failing because they are compiling too much with the LLINT
disabled. As a result, they are using more JIT code heap space than is allowed
by the OS.

This patch excludes these tests from the noLLINT configuration on 32-bit ARM.

  • js/script-tests/dfg-float32array.js:
  • js/script-tests/dfg-float64array.js:
  • js/script-tests/dfg-int16array.js:
  • js/script-tests/dfg-int32array-overflow-values.js:
  • js/script-tests/dfg-int32array.js:
  • js/script-tests/dfg-int8array.js:
  • js/script-tests/dfg-osr-entry-hoisted-clobbered-structure-check.js:
  • js/script-tests/dfg-uint16array.js:
  • js/script-tests/dfg-uint32array-overflow-values.js:
  • js/script-tests/dfg-uint32array.js:
  • js/script-tests/dfg-uint8array.js:
  • js/script-tests/dfg-uint8clampedarray.js:
  • js/script-tests/regress-141098.js:
10:42 PM Changeset in webkit [196624] by mitz@apple.com
  • 2 edits
    4 deletes in trunk/Source/WebKit2

Removed unused files after r196478.

  • Configurations/DatabaseProcess.xcconfig: Removed.
  • Configurations/NetworkProcess.xcconfig: Removed.
  • Configurations/PluginProcess.xcconfig: Removed.
  • Configurations/WebContentProcess.xcconfig: Removed.
  • WebKit2.xcodeproj/project.pbxproj:
9:39 PM Changeset in webkit [196623] by ChangSeok Oh
  • 2 edits in trunk/Source/WebKit2

[ThreadedCompositor] position:fixed elements do not have their own layers when threaded compositor is enabled.
​https://bugs.webkit.org/show_bug.cgi?id=154100

Reviewed by Carlos Garcia Campos.

Currently, fixed elements are redrawn to a backing store every time layout or scroll happens.
It results in the bad effect on performance-wise. Letting fixed element have separate layers is
necessary when threaded compositor is enabled at least. Because async scrolling requires it.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::updatePreferences):

9:36 PM Changeset in webkit [196622] by Brent Fulgham
  • 27 edits
    8 adds in trunk

[Mac] Gather some rudimentary statistics during resource load
​https://bugs.webkit.org/show_bug.cgi?id=153575
<rdar://problem/24075254>

Reviewed by Brady Eidson.

Source/WebCore:

Tested by: http/tests/navigation/statistics.html

  • CMakeLists.txt:
  • PlatformWin.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::updateLastHandledUserGestureTimestamp): Log user interaction
with the ResourceLoadObserver.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::willSendRequest): Track load statistics if the
user interacted with the document.

  • loader/ResourceLoadObserver.cpp: Added.
  • loader/ResourceLoadObserver.h: Added.
  • loader/ResourceLoadStatistics.cpp: Added.
  • loader/ResourceLoadStatistics.h: Added.
  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequestInternal): Track load statistics.

  • page/Settings.cpp:

(WebCore::Settings::setResourceLoadStatisticsEnabled): Added.

  • page/Settings.h:

(WebCore::Settings::resourceLoadStatisticsEnabled): Added.

  • platform/Logging.h:
  • testing/Internals.cpp:

(WebCore::Internals::resourceLoadStatisticsForOrigin):
(WebCore::Internals::setResourceLoadStatisticsEnabled):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit/mac:

  • Misc/WebKitNSStringExtras.h:
  • Misc/WebKitNSStringExtras.mm:

(+[NSString _webkit_localStorageDirectoryWithBundleIdentifier:]): Added.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences resourceLoadStatisticsEnabled]): Added.
(-[WebPreferences setResourceLoadStatisticsEnabled:]): Added.

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(WebKitInitializeApplicationCachePathIfNecessary):
(WebKitInitializeApplicationStatisticsStoragePathIfNecessary): Added.
(-[WebView _commonInitializationWithFrameName:groupName:]): Add call to new
initialization method.
(-[WebView _preferencesChanged:]): Track changes in the user's desire to
monitor resource load statistics.
(+[WebView _applicationWillTerminate]): Write statistics to disk (if preferences
say to do so.)

Tools:

  • MiniBrowser/mac/SettingsController.h:
  • MiniBrowser/mac/SettingsController.m:

(-[SettingsController _populateMenu]): Add menu item for new debug flag.
(-[SettingsController toggleResourceLoadStatisticsEnabled:]): Added.
(-[SettingsController resourceLoadStatisticsEnabled]): Added.

  • MiniBrowser/mac/WK1BrowserWindowController.m:

(-[WK1BrowserWindowController didChangeSettings]): React to changes in
users's desire to track resource load statistics.

LayoutTests:

  • http/tests/navigation/resources/redirect-on-reload-updates-history-item-statistics.php: Added.
  • http/tests/navigation/resources/redirect-updates-history-item-done-statistics.html: Added.
  • http/tests/navigation/statistics-expected.txt: Added.
  • http/tests/navigation/statistics.html: Added.
9:32 PM Changeset in webkit [196621] by Chris Dumez
  • 12 edits in trunk

The following properties should exist on the global object: AudioTrackList, AudioTrack, VideoTrackList, VideoTrack
​https://bugs.webkit.org/show_bug.cgi?id=154250
<rdar://problem/24660829>

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

Rebaseline now that more checks are passing.

  • web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

The following properties should exist on the global object:

  • AudioTrackList, AudioTrack, VideoTrackList, VideoTrack

These interfaces are not marked as [NoInterfaceObject] in:

No new tests, already covered by existing tests.

  • html/track/AudioTrack.idl:
  • html/track/AudioTrackList.idl:
  • html/track/VideoTrack.idl:
  • html/track/VideoTrackList.idl:

LayoutTests:

Rebaseline now that AudioTrackList, AudioTrack, VideoTrackList and VideoTrack
are exposed on the global Window object.

  • js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
9:15 PM Changeset in webkit [196620] by Nikita Vasilyev
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Non-overlay scrollbars obscure the ends of lines in the console and sidebars
​https://bugs.webkit.org/show_bug.cgi?id=154276

Reviewed by Timothy Hatcher.

  • UserInterface/Views/DataGrid.css:

(.data-grid .data-container):

  • UserInterface/Views/DatabaseContentView.css:

(.storage-view.query):

  • UserInterface/Views/LogContentView.css:

(.content-view.log):
Replace all occurrences of "overflow-y: overlay" with "overflow-y: auto".

9:11 PM Changeset in webkit [196619] by bshafiei@apple.com
  • 5 edits in tags/Safari-602.1.18.10

Merged r196589. rdar://problem/24644805

9:11 PM Changeset in webkit [196618] by bshafiei@apple.com
  • 5 edits in tags/Safari-602.1.18.10/Source

Versioning.

9:08 PM Changeset in webkit [196617] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.18.10

New tag.

8:51 PM Changeset in webkit [196616] by commit-queue@webkit.org
  • 7 edits in trunk/Source/JavaScriptCore

[JSC] BranchAdd can override arguments of its stackmap
​https://bugs.webkit.org/show_bug.cgi?id=154274

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-02-15
Reviewed by Filip Pizlo.

With the 3 operands BranchAdd added in r196513, we can run into
a register allocation such that the destination register is also
used by a value in the stack map.

It use to be that BranchAdd was a 2 operand instruction.
In that form, the destination is also one of the source and
can be recovered through Sub. There is no conflict between
destination and the stackmap.

After r196513, the destination has its own value. It is uncommon
on x86 because of the aggressive aliasing but that can happen.
On ARM, that's a standard form since there is no need for aliasing.

Since the arguments of the stackmap are of type EarlyUse,
they appeared as not interfering with the destination. When the register
allocator gives the same register to the destination and something in
the stack map, the result of BranchAdd destroys the value kept alive
for the stackmap.

In this patch, I introduce a concept very similar to ForceLateUse
to keep the argument of the stackmap live in CheckAdd. The new
role is "ForceLateUseUnlessRecoverable".

In this mode, anything that is not also an input argument becomes
LateUse. As such, it interferes with the destination of CheckAdd.
The arguments are recovered by the slow patch of CheckAdd. They
remain Early use.

This new modes ensure that destination can be aliased to the source
when that's useful, while making sure it is not aliased with another
value that needs to be live on exit.

  • b3/B3CheckSpecial.cpp:

(JSC::B3::CheckSpecial::forEachArg):

  • b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::lower):

  • b3/B3PatchpointSpecial.cpp:

(JSC::B3::PatchpointSpecial::forEachArg):

  • b3/B3StackmapSpecial.cpp:

(JSC::B3::StackmapSpecial::forEachArgImpl):
(WTF::printInternal):

  • b3/B3StackmapSpecial.h:
  • b3/B3StackmapValue.h:
8:41 PM Changeset in webkit [196615] by Hunseop Jeong
  • 104 edits
    4 adds in trunk/LayoutTests

[EFL] Rebaseline after r196244.

Unreviewed test gardening.

  • platform/efl/compositing/geometry/clipping-foreground-expected.txt:
  • platform/efl/compositing/geometry/root-layer-update-expected.txt:
  • platform/efl/compositing/overflow/ancestor-overflow-expected.txt:
  • platform/efl/compositing/overflow/nested-scrolling-expected.txt:
  • platform/efl/compositing/overflow/overflow-scroll-expected.txt:
  • platform/efl/compositing/overflow/parent-overflow-expected.txt:
  • platform/efl/compositing/overflow/scrollbar-painting-expected.txt:
  • platform/efl/compositing/reflections/nested-reflection-on-overflow-expected.txt:
  • platform/efl/compositing/sibling-positioning-expected.txt:
  • platform/efl/css3/unicode-bidi-isolate-basic-expected.txt:
  • platform/efl/fast/block/positioning/auto/vertical-rl/007-expected.txt:
  • platform/efl/fast/block/positioning/vertical-rl/fixed-positioning-expected.txt:
  • platform/efl/fast/borders/border-antialiasing-expected.txt:
  • platform/efl/fast/clip/001-expected.txt:
  • platform/efl/fast/clip/013-expected.txt:
  • platform/efl/fast/clip/014-expected.txt:
  • platform/efl/fast/clip/016-expected.txt:
  • platform/efl/fast/clip/outline-overflowClip-expected.txt:
  • platform/efl/fast/css/clip-zooming-expected.txt:
  • platform/efl/fast/forms/validation-message-appearance-expected.txt:
  • platform/efl/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt:
  • platform/efl/fast/line-grid/line-grid-inside-columns-expected.txt:
  • platform/efl/fast/line-grid/line-grid-into-columns-expected.txt:
  • platform/efl/fast/lists/scrolled-marker-paint-expected.txt:
  • platform/efl/fast/multicol/client-rects-expected.txt:
  • platform/efl/fast/multicol/column-break-with-balancing-expected.txt:
  • platform/efl/fast/multicol/column-rules-expected.txt:
  • platform/efl/fast/multicol/column-rules-stacking-expected.txt:
  • platform/efl/fast/multicol/columns-shorthand-parsing-expected.txt:
  • platform/efl/fast/multicol/float-paginate-complex-expected.txt:
  • platform/efl/fast/multicol/float-paginate-empty-lines-expected.txt:
  • platform/efl/fast/multicol/float-paginate-expected.txt:
  • platform/efl/fast/multicol/layers-in-multicol-expected.txt:
  • platform/efl/fast/multicol/layers-split-across-columns-expected.txt:
  • platform/efl/fast/multicol/max-height-columns-block-expected.txt:
  • platform/efl/fast/multicol/nested-columns-expected.txt:
  • platform/efl/fast/multicol/newmulticol/client-rects-expected.txt:
  • platform/efl/fast/multicol/overflow-across-columns-expected.txt:
  • platform/efl/fast/multicol/overflow-across-columns-percent-height-expected.txt:
  • platform/efl/fast/multicol/overflow-unsplittable-expected.txt:
  • platform/efl/fast/multicol/paginate-block-replaced-expected.txt:
  • platform/efl/fast/multicol/pagination/BottomToTop-bt-expected.txt:
  • platform/efl/fast/multicol/pagination/BottomToTop-lr-expected.txt:
  • platform/efl/fast/multicol/pagination/BottomToTop-rl-expected.txt:
  • platform/efl/fast/multicol/pagination/BottomToTop-tb-expected.txt:
  • platform/efl/fast/multicol/pagination/LeftToRight-bt-expected.txt:
  • platform/efl/fast/multicol/pagination/LeftToRight-rl-expected.txt:
  • platform/efl/fast/multicol/pagination/LeftToRight-tb-expected.txt:
  • platform/efl/fast/multicol/pagination/LeftToRight-tb-hittest-expected.txt:
  • platform/efl/fast/multicol/pagination/RightToLeft-bt-expected.txt:
  • platform/efl/fast/multicol/pagination/RightToLeft-lr-expected.txt:
  • platform/efl/fast/multicol/pagination/RightToLeft-rl-dynamic-expected.txt:
  • platform/efl/fast/multicol/pagination/RightToLeft-rl-expected.txt:
  • platform/efl/fast/multicol/pagination/RightToLeft-rl-hittest-expected.txt:
  • platform/efl/fast/multicol/pagination/RightToLeft-tb-expected.txt:
  • platform/efl/fast/multicol/pagination/TopToBottom-bt-expected.txt:
  • platform/efl/fast/multicol/pagination/TopToBottom-lr-expected.txt:
  • platform/efl/fast/multicol/pagination/TopToBottom-rl-expected.txt:
  • platform/efl/fast/multicol/positive-leading-expected.txt:
  • platform/efl/fast/multicol/scrolling-column-rules-expected.txt:
  • platform/efl/fast/multicol/scrolling-overflow-expected.txt:
  • platform/efl/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
  • platform/efl/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/efl/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/efl/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/efl/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/efl/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
  • platform/efl/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/efl/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/efl/fast/multicol/span/span-margin-collapsing-expected.txt:
  • platform/efl/fast/multicol/table-vertical-align-expected.txt:
  • platform/efl/fast/multicol/tall-image-behavior-expected.txt:
  • platform/efl/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt:
  • platform/efl/fast/multicol/vertical-lr/column-rules-expected.txt:
  • platform/efl/fast/multicol/vertical-lr/float-multicol-expected.txt:
  • platform/efl/fast/multicol/vertical-lr/float-paginate-complex-expected.txt:
  • platform/efl/fast/multicol/vertical-lr/float-paginate-expected.txt:
  • platform/efl/fast/multicol/vertical-lr/nested-columns-expected.txt:
  • platform/efl/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
  • platform/efl/fast/multicol/vertical-rl/column-rules-expected.txt:
  • platform/efl/fast/multicol/vertical-rl/float-multicol-expected.txt:
  • platform/efl/fast/multicol/vertical-rl/float-paginate-complex-expected.txt:
  • platform/efl/fast/multicol/vertical-rl/float-paginate-expected.txt:
  • platform/efl/fast/multicol/vertical-rl/nested-columns-expected.txt:
  • platform/efl/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
  • platform/efl/fast/overflow/float-in-relpositioned-expected.txt:
  • platform/efl/fast/overflow/overflow-auto-position-absolute-expected.txt:
  • platform/efl/fast/overflow/overflow-rtl-expected.txt:
  • platform/efl/fast/overflow/paged-x-div-expected.txt:
  • platform/efl/fast/overflow/paged-x-div-with-column-gap-expected.txt:
  • platform/efl/fast/overflow/paged-x-on-root-expected.txt:
  • platform/efl/fast/overflow/paged-x-with-column-gap-expected.txt:
  • platform/efl/fast/overflow/paged-y-div-expected.txt:
  • platform/efl/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
  • platform/efl/fast/regions/repaint/region-painting-via-layout-expected.txt:
  • platform/efl/fast/repaint/box-shadow-h-expected.txt:
  • platform/efl/fast/repaint/box-shadow-v-expected.txt:
  • platform/efl/fast/repaint/layer-outline-expected.txt:
  • platform/efl/fast/repaint/layer-outline-horizontal-expected.txt:
  • platform/efl/fast/table/edge-offsets-expected.txt:
  • platform/efl/fast/transforms/overflow-with-transform-expected.txt:
  • platform/efl/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt: Added.
  • platform/efl/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt: Added.
  • platform/efl/printing/single-line-must-not-be-split-into-two-pages-expected.txt:
  • platform/efl/scrollbars/scrollbars-on-positioned-content-expected.txt:
  • platform/efl/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt: Added.
  • platform/efl/svg/custom/image-rescale-clip-expected.txt: Added.
8:07 PM Changeset in webkit [196614] by weinig@apple.com
  • 6 edits
    1 delete in trunk/Source/WebCore

Stop using NSMapTable in places where we were only using it to be GC safe
<rdar://problem/24063723>
​https://bugs.webkit.org/show_bug.cgi?id=154264

Reviewed by Dan Bernstein.

Switch from NSMapTable to HashMap.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMInternal.mm:
  • bindings/objc/WebScriptObject.mm:
  • bridge/objc/objc_instance.mm:
  • platform/spi/cocoa/NSPointerFunctionsSPI.h: Removed. No longer used.
6:32 PM Changeset in webkit [196613] by commit-queue@webkit.org
  • 2 edits in trunk

Re-enable INTL on WinCairo
​https://bugs.webkit.org/show_bug.cgi?id=154256

Patch by Alex Christensen <​achristensen@webkit.org> on 2016-02-15
Reviewed by Michael Catanzaro.

  • Source/cmake/OptionsWin.cmake:

Peavo updated icu and it works, so let's re-enable INTL on WinCairo to catch Windows build failures.

6:22 PM Changeset in webkit [196612] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.46-branch/Source

Versioning.

5:53 PM Changeset in webkit [196611] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Rebaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator after r196607

Unreviewed test gardening.

  • platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
4:50 PM Changeset in webkit [196610] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Visual sidebar minor regression fixes
​https://bugs.webkit.org/show_bug.cgi?id=154237
<rdar://problem/24653135>

Patch by Devin Rousso <Devin Rousso> on 2016-02-15
Reviewed by Timothy Hatcher.

  • UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css:

(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-special-property-placeholder):
Do not display the placeholder, as it is not used in comma separated value
property editors.

(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item > .titles > .subtitle::before):
(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-comma-separated-keyword-list > .visual-style-comma-separated-keyword-item > .titles > .subtitle): Deleted.
Added ::before to get rid of the "-" on subtitle elements (r196266).

  • UserInterface/Views/VisualStyleDetailsPanel.js:

(WebInspector.VisualStyleDetailsPanel.prototype.widthDidChange):
Recalculates the width for all comma separated value elements (r196266).

(WebInspector.VisualStyleDetailsPanel.prototype._updateSections):
Only open/close sections with properties that have values when a new node
or selector item is selected.

(WebInspector.VisualStyleDetailsPanel.prototype._populateBorderSection):
Make copies of the default unit lists to prevent modifying the values used
later in other sections (r194728).

4:20 PM Changeset in webkit [196609] by achristensen@apple.com
  • 4 edits in trunk/Source/WebKit2

Implement content sniffing check with NetworkSession
​https://bugs.webkit.org/show_bug.cgi?id=154261

Reviewed by Andy Estes.

This fixes http/tests/xmlhttprequest/small-chunks-response-text.html when using NetworkSession.

  • NetworkProcess/NetworkDataTask.h:

(WebKit::NetworkDataTask::create):

  • NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::NetworkLoad):

  • NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTask::NetworkDataTask):
Content sniffing is enabled by default. Disable it if the NetworkLoadParameters say not to.
This is analogous to behavior in ResourceHandle::createNSURLConnection.

4:17 PM Changeset in webkit [196608] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.46.100

New tag.

3:58 PM Changeset in webkit [196607] by Chris Dumez
  • 3 edits in trunk/LayoutTests/imported/w3c

Re-sync W3C web-platform-tests' html/dom/interfaces.html
​https://bugs.webkit.org/show_bug.cgi?id=154259

Reviewed by Ryosuke Niwa.

Re-sync W3C web-platform-tests' html/dom/interfaces.html after:

  • web-platform-tests/html/dom/interfaces-expected.txt:
  • web-platform-tests/html/dom/interfaces.html:
3:57 PM Changeset in webkit [196606] by Matt Baker
  • 9 edits
    2 deletes in trunk/Source/WebInspectorUI

Web Inspector: eliminate the linear and rendering frames TimelineOverview subclasses
​https://bugs.webkit.org/show_bug.cgi?id=154000
<rdar://problem/24553105>

Reviewed by Timothy Hatcher.

This patch eliminates the TimelineOverview subclasses, and moves logic for switching between
a time-based or frame-based graph into the overview itself. The values of the overview's start
time, current time, and end time now match the values in the timeline recording regardless of the
current view mode. When viewing the rendering frames graph, the recording times are ignored and
all frames are included. The overview maintains separate zoom level and ruler selection settings
for each view mode.

  • UserInterface/Main.html:
  • UserInterface/Views/LinearTimelineOverview.js: Removed.
  • UserInterface/Views/RenderingFrameTimelineOverview.js: Removed.

Removed TimelineOverview subclasses.

  • UserInterface/Views/RenderingFrameTimelineOverviewGraph.js:

(WebInspector.RenderingFrameTimelineOverviewGraph.prototype.get height):
Set FPS graph height to 108 pixels.

  • UserInterface/Views/TimelineOverview.css:

(.timeline-overview:not(.frames) > .graphs-container > .timeline-overview-graph:nth-child(even)):
(.timeline-overview:not(.frames) > .graphs-container > .timeline-overview-graph:not(:first-child)):
(.timeline-overview > .graphs-container > .timeline-overview-graph:nth-child(even)): Deleted.
(.timeline-overview > .graphs-container > .timeline-overview-graph:not(:first-child)): Deleted.
Disable alternating graph styles when showing FPS instrument.

  • UserInterface/Views/TimelineOverview.js:

(WebInspector.TimelineOverview):
Create separate settings for timelines and FPS view modes.
(WebInspector.TimelineOverview.prototype.get viewMode):
(WebInspector.TimelineOverview.prototype.set viewMode):
(WebInspector.TimelineOverview.prototype.set startTime):
Adjust the current ruler selection when start time changes. Not necessary
when showing the FPS instrument, which doesn't have a start time.
(WebInspector.TimelineOverview.prototype.get secondsPerPixel):
(WebInspector.TimelineOverview.prototype.set secondsPerPixel):
Now a wrapper around the corresponding view mode setting.
(WebInspector.TimelineOverview.prototype.set pixelAlignDuration):
(WebInspector.TimelineOverview.prototype.get scrollStartTime):
(WebInspector.TimelineOverview.prototype.set scrollStartTime):
Now a wrapper around the corresponding view mode setting.
(WebInspector.TimelineOverview.prototype.get visibleDuration):
(WebInspector.TimelineOverview.prototype.get height):
Return the sum height of all visible overview graphs.
(WebInspector.TimelineOverview.prototype.shown):
Show overview graphs for the current view mode.
(WebInspector.TimelineOverview.prototype.hidden):
(WebInspector.TimelineOverview.prototype.reset):
(WebInspector.TimelineOverview.prototype.recordWasFiltered):
(WebInspector.TimelineOverview.prototype.selectRecord):
(WebInspector.TimelineOverview.prototype.updateLayoutIfNeeded):
(WebInspector.TimelineOverview.prototype.layout):
Layout for both view modes is largely identical, and differs only in the treatment
of the overview's start time, current time, and end time. Time-based instruments
use time values from the recording, while the FPS instrument has a fixed start time
of zero, and a current and end time pinned to the last rendering frame.
(WebInspector.TimelineOverview.prototype._handleScrollEvent):
(WebInspector.TimelineOverview.prototype._handleWheelEvent):
(WebInspector.TimelineOverview._handleGestureStart):
(WebInspector.TimelineOverview.prototype._handleGestureChange):
(WebInspector.TimelineOverview.prototype._instrumentAdded):
(WebInspector.TimelineOverview.prototype._instrumentRemoved):
(WebInspector.TimelineOverview.prototype._timelineRulerMouseClicked):
(WebInspector.TimelineOverview.prototype._timeRangeSelectionChanged):
Save the selection for the current view mode.
(WebInspector.TimelineOverview.prototype._recordSelected):
(WebInspector.TimelineOverview.prototype._resetSelection.reset):
(WebInspector.TimelineOverview.prototype._resetSelection):
(WebInspector.TimelineOverview.prototype._canShowTimelineType):
(WebInspector.TimelineOverview.prototype._viewModeDidChange):
Sets zoom level, ruler selection, and graph visibility based on current view mode.
(WebInspector.TimelineOverview.prototype._createViewModeSettings):
Helper function for creating an object to track the zoom level and ruler
selection of each view mode.
(WebInspector.TimelineOverview.prototype.get _currentSettings):
Internal getter for retrieving the settings for the current view mode.
(WebInspector.TimelineOverview.prototype.canShowTimeline): Deleted.
Not needed now that the overview contains all timelines.

  • UserInterface/Views/TimelineOverviewGraph.js:

(WebInspector.TimelineOverviewGraph):
(WebInspector.TimelineOverviewGraph.prototype.shown):
(WebInspector.TimelineOverviewGraph.prototype.hidden):
Toggle CSS hidden class.

  • UserInterface/Views/TimelineRecordFrame.js:

No need to query offsetHeight now that TimelineOverviewGraph has a height property.

  • UserInterface/Views/TimelineRecordingContentView.js:

(WebInspector.TimelineRecordingContentView):
Create a single timeline overview.
(WebInspector.TimelineRecordingContentView.prototype.get timelineOverviewHeight):
(WebInspector.TimelineRecordingContentView.prototype.shown):
(WebInspector.TimelineRecordingContentView.prototype.hidden):
(WebInspector.TimelineRecordingContentView.prototype.recordWasFiltered):
(WebInspector.TimelineRecordingContentView.prototype._currentContentViewDidChange):
Update the timeline overview's mode based on the current timeline view.
(WebInspector.TimelineRecordingContentView.prototype._contentViewSelectionPathComponentDidChange):
(WebInspector.TimelineRecordingContentView.prototype._updateTimes):
Removed special handling for the FPS overview.
Removed selection start time adjustment, which is now handled internally by TimelineOverview.
(WebInspector.TimelineRecordingContentView.prototype._updateTimelineOverviewHeight):
(WebInspector.TimelineRecordingContentView.prototype._recordingReset):
(WebInspector.TimelineRecordingContentView.prototype._timeRangeSelectionChanged):
(WebInspector.TimelineRecordingContentView.prototype._updateFrameSelection):

  • UserInterface/Views/TimelineSidebarPanel.js:

(WebInspector.TimelineSidebarPanel):
(WebInspector.TimelineSidebarPanel.prototype.matchTreeElementAgainstCustomFilters):
(WebInspector.TimelineSidebarPanel.prototype.saveStateToCookie):
(WebInspector.TimelineSidebarPanel.prototype._renderingFrameTimelineTimesUpdated):
(WebInspector.TimelineSidebarPanel.prototype._contentBrowserCurrentContentViewDidChange):
Refresh the view mode when the content view changes.
(WebInspector.TimelineSidebarPanel.prototype._recordingSelected):
(WebInspector.TimelineSidebarPanel.prototype._viewModeSelected):
(WebInspector.TimelineSidebarPanel.prototype._viewModeForTimeline):
(WebInspector.TimelineSidebarPanel.prototype._updateViewModeIfNeeded):
Sync the tree outline, frames chart, and navigation bar with the current view mode.
(WebInspector.TimelineSidebarPanel.prototype.shown):
Refreshing the frame selection is unnecessary. It's updated by the recording content
view whenever the ruler selection changes.
(WebInspector.TimelineSidebarPanel.prototype.get viewMode): Deleted.
No longer public, since the timeline overview now owns the view mode. Internally the sidebar
still tracks the current state so it can determine when the value has changed.
(WebInspector.TimelineSidebarPanel.prototype.showTimelineOverview):
(WebInspector.TimelineSidebarPanel.prototype.showTimelineViewForTimeline):
The sidebar should only be synced to the overview after the content view has changed.
(WebInspector.TimelineSidebarPanel.prototype.updateFrameSelection):
Removed unnecessary assertion.
(WebInspector.TimelineSidebarPanel.prototype._changeViewMode): Deleted.
Replaced by _updateViewModeIfNeeded.

3:57 PM Changeset in webkit [196605] by rniwa@webkit.org
  • 5 edits
    1 move
    1 add
    2 deletes in trunk/Websites/perf.webkit.org

v1 UI and v2 UI should share statistics.js
​https://bugs.webkit.org/show_bug.cgi?id=154262

Reviewed by Chris Dumez.

Share statistics.js between v1 and v2 UI.

  • public/index.html:
  • public/js/shared.js: Deleted.
  • public/js/statistics.js: Removed.
  • public/shared: Added.
  • public/shared/statistics.js: Moved from Websites/perf.webkit.org/public/v2/js/statistics.js.
  • public/v2/index.html:
  • public/v2/js/statistics.js: Removed.
  • public/v3/index.html:
  • tools/detect-changes.js:
3:39 PM Changeset in webkit [196604] by mmaxfield@apple.com
  • 24 edits
    2 copies
    2 adds in trunk

[Font Loading] Implement FontFace JavaScript object
​https://bugs.webkit.org/show_bug.cgi?id=153345

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/text/font-face-javascript.html

This patch implements the FontFace Javascript object. This object mostly consists of
style getters / setters, which we implement by parsing input strings and generating
output strings similarly to getComputedStyle(). This object also has a load() function
which returns a promise which will be fulfilled or rejected depending on the load.
There is also a "loaded" attribute which exposes this promise directly. Also, a status
field is exposed so script knows what the state of the load is.

Currently, loading depends on our CachedResourceLoader which is part of the Document,
so this API is not available in a non-document context.

Another caveat is that immediate-mode font loading (where the content provides an
ArrayBuffer containing the bytes of the font file) is forthcoming. This requires
changing the relationship between CSSFontFaceSource and CachedFont.

CSSFontFace has been modified to keep a strong reference to the CSSFontSelector. This
is because the lifetime of the CSSFontFace can now outlive the CSSFontSelector. When
the CSSFontSelector is removed from the Document, it explicitly clears its constituent
CSSFontFaces, thereby breaking the reference cycle.

Test: fast/text/font-face-javascript-expected.html

  • CMakeLists.txt: Add new files.
  • DerivedSources.cpp: Ditto.
  • DerivedSources.make: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSDOMPromise.cpp:

(WebCore::DeferredWrapper::globalObject): Remove whitespace.
(WebCore::DeferredWrapper::deferred): Allow access to the inner JSC object.

  • bindings/js/JSDOMPromise.h:

(WebCore::DOMPromise::deferred): Ditto.

  • bindings/js/JSFontFaceCustom.cpp: Copied from Source/WebCore/bindings/js/JSDOMPromise.cpp.

(WebCore::JSFontFace::loaded):
(WebCore::JSFontFace::load):

  • css/CSSFontFace.cpp:

(WebCore::CSSFontFace::CSSFontFace):
(WebCore::CSSFontFace::adoptSource):
(WebCore::CSSFontFace::updateStatus): Enforce the state machine's transitions.
(WebCore::CSSFontFace::fontLoaded):
(WebCore::CSSFontFace::pump):
(WebCore::CSSFontFace::load):

  • css/CSSFontFace.h:

(WebCore::CSSFontFaceClient::~CSSFontFaceClient):
(WebCore::CSSFontFace::create):
(WebCore::CSSFontFace::status):

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::appendSources): Update for new CSSFontFace API.
(WebCore::CSSFontSelector::registerLocalFontFacesForFamily): Ditto.
(WebCore::CSSFontSelector::addFontFaceRule): Ditto.
(WebCore::CSSFontSelector::kick): Ditto.
(WebCore::appendSources): Deleted.
(WebCore::registerLocalFontFacesForFamily): Deleted.

  • css/CSSFontSelector.h:
  • css/CSSUnicodeRangeValue.cpp: Use for serializing the "unicodeRange" property.
  • css/FontFace.cpp:

(WebCore::createPromise): Implement the remaining Javascript API functions.
(WebCore::valueFromDictionary):
(WebCore::FontFace::create):
(WebCore::FontFace::FontFace):
(WebCore::FontFace::parseString):
(WebCore::FontFace::status):
(WebCore::FontFace::kick):
(WebCore::FontFace::load):
(WebCore::FontFace::fulfillPromise):
(WebCore::FontFace::rejectPromise):
(WebCore::parseString): Deleted.

  • css/FontFace.h:

(WebCore::FontFace::promise):
(WebCore::FontFace::backing):
(WebCore::FontFace::create): Deleted.

  • css/FontFace.idl: Copied from Source/WebCore/bindings/js/JSDOMPromise.cpp.

LayoutTests:

  • fast/text/font-face-javascript-expected.txt: Added.
  • fast/text/font-face-javascript.html: Added.
  • js/dom/global-constructors-attributes-expected.txt:
  • platform/efl/js/dom/global-constructors-attributes-expected.txt:
  • platform/gtk/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
  • platform/win/js/dom/global-constructors-attributes-expected.txt:
2:37 PM Changeset in webkit [196603] by jer.noble@apple.com
  • 61 edits in trunk/Source/WebCore

Null-deref crash in DefaultAudioDestinationNode::suspend()
​https://bugs.webkit.org/show_bug.cgi?id=154248

Reviewed by Alex Christensen.

Drive-by fix: AudioContext should be a reference, not a pointer.

  • Modules/webaudio/AnalyserNode.cpp:

(WebCore::AnalyserNode::AnalyserNode):

  • Modules/webaudio/AnalyserNode.h:

(WebCore::AnalyserNode::create):

  • Modules/webaudio/AudioBasicInspectorNode.cpp:

(WebCore::AudioBasicInspectorNode::AudioBasicInspectorNode):
(WebCore::AudioBasicInspectorNode::connect):
(WebCore::AudioBasicInspectorNode::disconnect):
(WebCore::AudioBasicInspectorNode::checkNumberOfChannelsForInput):
(WebCore::AudioBasicInspectorNode::updatePullStatus):

  • Modules/webaudio/AudioBasicInspectorNode.h:
  • Modules/webaudio/AudioBasicProcessorNode.cpp:

(WebCore::AudioBasicProcessorNode::AudioBasicProcessorNode):
(WebCore::AudioBasicProcessorNode::checkNumberOfChannelsForInput):

  • Modules/webaudio/AudioBasicProcessorNode.h:
  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::create):
(WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
(WebCore::AudioBufferSourceNode::renderFromBuffer):
(WebCore::AudioBufferSourceNode::setBuffer):
(WebCore::AudioBufferSourceNode::startPlaying):
(WebCore::AudioBufferSourceNode::looping):
(WebCore::AudioBufferSourceNode::setLooping):

  • Modules/webaudio/AudioBufferSourceNode.h:
  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::AudioContext):
(WebCore::AudioContext::createBufferSource):
(WebCore::AudioContext::createMediaElementSource):
(WebCore::AudioContext::createMediaStreamDestination):
(WebCore::AudioContext::createScriptProcessor):
(WebCore::AudioContext::createBiquadFilter):
(WebCore::AudioContext::createWaveShaper):
(WebCore::AudioContext::createPanner):
(WebCore::AudioContext::createConvolver):
(WebCore::AudioContext::createDynamicsCompressor):
(WebCore::AudioContext::createAnalyser):
(WebCore::AudioContext::createGain):
(WebCore::AudioContext::createDelay):
(WebCore::AudioContext::createChannelSplitter):
(WebCore::AudioContext::createChannelMerger):
(WebCore::AudioContext::createOscillator):

  • Modules/webaudio/AudioContext.h:

(WebCore::operator==):
(WebCore::operator!=):

  • Modules/webaudio/AudioDestinationNode.cpp:

(WebCore::AudioDestinationNode::AudioDestinationNode):
(WebCore::AudioDestinationNode::render):
(WebCore::AudioDestinationNode::updateIsEffectivelyPlayingAudio):

  • Modules/webaudio/AudioDestinationNode.h:
  • Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::AudioNode):
(WebCore::AudioNode::connect):
(WebCore::AudioNode::disconnect):
(WebCore::AudioNode::setChannelCount):
(WebCore::AudioNode::setChannelCountMode):
(WebCore::AudioNode::setChannelInterpretation):
(WebCore::AudioNode::scriptExecutionContext):
(WebCore::AudioNode::processIfNecessary):
(WebCore::AudioNode::checkNumberOfChannelsForInput):
(WebCore::AudioNode::propagatesSilence):
(WebCore::AudioNode::pullInputs):
(WebCore::AudioNode::enableOutputsIfNecessary):
(WebCore::AudioNode::deref):
(WebCore::AudioNode::finishDeref):

  • Modules/webaudio/AudioNode.h:

(WebCore::AudioNode::context):

  • Modules/webaudio/AudioNodeInput.cpp:

(WebCore::AudioNodeInput::connect):
(WebCore::AudioNodeInput::disconnect):
(WebCore::AudioNodeInput::disable):
(WebCore::AudioNodeInput::enable):
(WebCore::AudioNodeInput::updateInternalBus):
(WebCore::AudioNodeInput::bus):
(WebCore::AudioNodeInput::internalSummingBus):
(WebCore::AudioNodeInput::sumAllConnections):
(WebCore::AudioNodeInput::pull):

  • Modules/webaudio/AudioNodeOutput.cpp:

(WebCore::AudioNodeOutput::setNumberOfChannels):
(WebCore::AudioNodeOutput::updateNumberOfChannels):
(WebCore::AudioNodeOutput::propagateChannelCount):
(WebCore::AudioNodeOutput::pull):
(WebCore::AudioNodeOutput::bus):
(WebCore::AudioNodeOutput::fanOutCount):
(WebCore::AudioNodeOutput::paramFanOutCount):
(WebCore::AudioNodeOutput::addInput):
(WebCore::AudioNodeOutput::removeInput):
(WebCore::AudioNodeOutput::disconnectAllInputs):
(WebCore::AudioNodeOutput::addParam):
(WebCore::AudioNodeOutput::removeParam):
(WebCore::AudioNodeOutput::disconnectAllParams):
(WebCore::AudioNodeOutput::disable):
(WebCore::AudioNodeOutput::enable):

  • Modules/webaudio/AudioNodeOutput.h:

(WebCore::AudioNodeOutput::context):

  • Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::value):
(WebCore::AudioParam::smooth):
(WebCore::AudioParam::calculateSampleAccurateValues):
(WebCore::AudioParam::calculateFinalValues):
(WebCore::AudioParam::calculateTimelineValues):
(WebCore::AudioParam::connect):
(WebCore::AudioParam::disconnect):

  • Modules/webaudio/AudioParam.h:

(WebCore::AudioParam::create):
(WebCore::AudioParam::AudioParam):

  • Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::valueForContextTime):

  • Modules/webaudio/AudioParamTimeline.h:
  • Modules/webaudio/AudioScheduledSourceNode.cpp:

(WebCore::AudioScheduledSourceNode::AudioScheduledSourceNode):
(WebCore::AudioScheduledSourceNode::updateSchedulingInfo):
(WebCore::AudioScheduledSourceNode::start):
(WebCore::AudioScheduledSourceNode::finish):

  • Modules/webaudio/AudioScheduledSourceNode.h:
  • Modules/webaudio/AudioSummingJunction.cpp:

(WebCore::AudioSummingJunction::AudioSummingJunction):
(WebCore::AudioSummingJunction::~AudioSummingJunction):
(WebCore::AudioSummingJunction::changedOutputs):
(WebCore::AudioSummingJunction::updateRenderingState):

  • Modules/webaudio/AudioSummingJunction.h:

(WebCore::AudioSummingJunction::context):

  • Modules/webaudio/BiquadFilterNode.cpp:

(WebCore::BiquadFilterNode::BiquadFilterNode):

  • Modules/webaudio/BiquadFilterNode.h:

(WebCore::BiquadFilterNode::create):

  • Modules/webaudio/BiquadProcessor.cpp:

(WebCore::BiquadProcessor::BiquadProcessor):

  • Modules/webaudio/BiquadProcessor.h:
  • Modules/webaudio/ChannelMergerNode.cpp:

(WebCore::ChannelMergerNode::create):
(WebCore::ChannelMergerNode::ChannelMergerNode):
(WebCore::ChannelMergerNode::checkNumberOfChannelsForInput):

  • Modules/webaudio/ChannelMergerNode.h:
  • Modules/webaudio/ChannelSplitterNode.cpp:

(WebCore::ChannelSplitterNode::create):
(WebCore::ChannelSplitterNode::ChannelSplitterNode):

  • Modules/webaudio/ChannelSplitterNode.h:
  • Modules/webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::ConvolverNode):
(WebCore::ConvolverNode::setBuffer):

  • Modules/webaudio/ConvolverNode.h:

(WebCore::ConvolverNode::create):

  • Modules/webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::DefaultAudioDestinationNode):
(WebCore::DefaultAudioDestinationNode::resume):
(WebCore::DefaultAudioDestinationNode::suspend):
(WebCore::DefaultAudioDestinationNode::close):

  • Modules/webaudio/DefaultAudioDestinationNode.h:

(WebCore::DefaultAudioDestinationNode::create):

  • Modules/webaudio/DelayNode.cpp:

(WebCore::DelayNode::DelayNode):

  • Modules/webaudio/DelayNode.h:

(WebCore::DelayNode::create):

  • Modules/webaudio/DelayProcessor.cpp:

(WebCore::DelayProcessor::DelayProcessor):

  • Modules/webaudio/DelayProcessor.h:
  • Modules/webaudio/DynamicsCompressorNode.cpp:

(WebCore::DynamicsCompressorNode::DynamicsCompressorNode):

  • Modules/webaudio/DynamicsCompressorNode.h:

(WebCore::DynamicsCompressorNode::create):

  • Modules/webaudio/GainNode.cpp:

(WebCore::GainNode::GainNode):
(WebCore::GainNode::checkNumberOfChannelsForInput):

  • Modules/webaudio/GainNode.h:

(WebCore::GainNode::create):

  • Modules/webaudio/MediaElementAudioSourceNode.cpp:

(WebCore::MediaElementAudioSourceNode::create):
(WebCore::MediaElementAudioSourceNode::MediaElementAudioSourceNode):
(WebCore::MediaElementAudioSourceNode::setFormat):

  • Modules/webaudio/MediaElementAudioSourceNode.h:
  • Modules/webaudio/MediaStreamAudioDestinationNode.cpp:

(WebCore::MediaStreamAudioDestinationNode::create):
(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):

  • Modules/webaudio/MediaStreamAudioDestinationNode.h:
  • Modules/webaudio/MediaStreamAudioSourceNode.cpp:

(WebCore::MediaStreamAudioSourceNode::MediaStreamAudioSourceNode):
(WebCore::MediaStreamAudioSourceNode::setFormat):

  • Modules/webaudio/OfflineAudioDestinationNode.cpp:

(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
(WebCore::OfflineAudioDestinationNode::offlineRender):
(WebCore::OfflineAudioDestinationNode::notifyComplete):

  • Modules/webaudio/OfflineAudioDestinationNode.h:

(WebCore::OfflineAudioDestinationNode::create):

  • Modules/webaudio/OscillatorNode.cpp:

(WebCore::OscillatorNode::create):
(WebCore::OscillatorNode::OscillatorNode):

  • Modules/webaudio/OscillatorNode.h:
  • Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::PannerNode):
(WebCore::PannerNode::pullInputs):
(WebCore::PannerNode::process):
(WebCore::PannerNode::listener):
(WebCore::PannerNode::setPanningModel):

  • Modules/webaudio/PannerNode.h:

(WebCore::PannerNode::create):

  • Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::create):
(WebCore::ScriptProcessorNode::ScriptProcessorNode):
(WebCore::ScriptProcessorNode::initialize):
(WebCore::ScriptProcessorNode::fireProcessEvent):

  • Modules/webaudio/ScriptProcessorNode.h:
  • Modules/webaudio/WaveShaperNode.cpp:

(WebCore::WaveShaperNode::WaveShaperNode):
(WebCore::WaveShaperNode::setOversample):

  • Modules/webaudio/WaveShaperNode.h:

(WebCore::WaveShaperNode::create):

2:36 PM Changeset in webkit [196602] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Null-deref crash in DefaultAudioDestinationNode::suspend()
​https://bugs.webkit.org/show_bug.cgi?id=154248

Reviewed by Alex Christensen.

Null-check scriptExecutionContext() before deref.

  • Modules/webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::resume):
(WebCore::DefaultAudioDestinationNode::suspend):
(WebCore::DefaultAudioDestinationNode::close):

2:33 PM Changeset in webkit [196601] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[EFL] Update Tools/efl/install-dependencies
​https://bugs.webkit.org/show_bug.cgi?id=154239

Reviewed by Michael Catanzaro.

  • efl/install-dependencies:
2:25 PM Changeset in webkit [196600] by achristensen@apple.com
  • 11 edits
    4 adds in trunk/Source/WebKit2

Move Download authentication code to AuthenticationManager
​https://bugs.webkit.org/show_bug.cgi?id=154132

Reviewed by Sam Weinig.

When a video element makes a request that receives an authentication challenge, the
AuthenticationManager receives an AuthenticationChallenge without an AuthenticationClient.
As a result, Download::receivedCredential and other functions were being called, which
sent a message to the challenge's sender. This functionality is not specific to downloads,
so I moved it from Download to AuthenticationManager.

This fixes http/tests/media/video-auth.html when using NetworkSession
because I use AuthenticationManager::receivedCredential if there is no AuthenticationClient
instead of improperly asserting that there is always an AuthenticationClient if there is no
completionHandler.

  • NetworkProcess/Downloads/Download.h:
  • NetworkProcess/Downloads/ios/DownloadIOS.mm:

(WebKit::Download::platformDidFinish):
(WebKit::Download::receivedCredential): Deleted.
(WebKit::Download::receivedRequestToContinueWithoutCredential): Deleted.
(WebKit::Download::receivedCancellation): Deleted.
(WebKit::Download::receivedRequestToPerformDefaultHandling): Deleted.
(WebKit::Download::receivedChallengeRejection): Deleted.

  • NetworkProcess/Downloads/mac/DownloadMac.mm:

(WebKit::Download::platformDidFinish):
(WebKit::Download::receivedCredential): Deleted.
(WebKit::Download::receivedRequestToContinueWithoutCredential): Deleted.
(WebKit::Download::receivedCancellation): Deleted.
(WebKit::Download::receivedRequestToPerformDefaultHandling): Deleted.
(WebKit::Download::receivedChallengeRejection): Deleted.

  • NetworkProcess/Downloads/soup/DownloadSoup.cpp:

(WebKit::Download::platformDidFinish):
(WebKit::Download::receivedCredential): Deleted.
(WebKit::Download::receivedRequestToContinueWithoutCredential): Deleted.
(WebKit::Download::receivedCancellation): Deleted.
(WebKit::Download::continueWithoutCredential): Deleted.
(WebKit::Download::useCredential): Deleted.
(WebKit::Download::cancelAuthenticationChallenge): Deleted.
(WebKit::Download::receivedRequestToPerformDefaultHandling): Deleted.
(WebKit::Download::receivedChallengeRejection): Deleted.

  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • PlatformMac.cmake:
  • Shared/Authentication/AuthenticationManager.cpp:

(WebKit::AuthenticationManager::didReceiveAuthenticationChallenge):
(WebKit::AuthenticationManager::useCredentialForSingleChallenge):
(WebKit::AuthenticationManager::continueWithoutCredentialForChallenge):
(WebKit::AuthenticationManager::continueWithoutCredentialForSingleChallenge):
(WebKit::AuthenticationManager::cancelChallenge):
(WebKit::AuthenticationManager::cancelSingleChallenge):
(WebKit::AuthenticationManager::performDefaultHandling):
(WebKit::AuthenticationManager::performDefaultHandlingForSingleChallenge):
(WebKit::AuthenticationManager::rejectProtectionSpaceAndContinue):
(WebKit::AuthenticationManager::rejectProtectionSpaceAndContinueForSingleChallenge):

  • Shared/Authentication/AuthenticationManager.h:

(WebKit::AuthenticationManager::outstandingAuthenticationChallengeCount):

  • Shared/Authentication/cocoa: Added.
  • Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm: Added.

(WebKit::AuthenticationManager::receivedCredential):
(WebKit::AuthenticationManager::receivedRequestToContinueWithoutCredential):
(WebKit::AuthenticationManager::receivedCancellation):
(WebKit::AuthenticationManager::receivedRequestToPerformDefaultHandling):
(WebKit::AuthenticationManager::receivedChallengeRejection):

  • Shared/Authentication/soup: Added.
  • Shared/Authentication/soup/AuthenticationManagerSoup.cpp: Added.

(WebKit::AuthenticationManager::receivedCredential):
(WebKit::AuthenticationManager::receivedRequestToContinueWithoutCredential):
(WebKit::AuthenticationManager::receivedCancellation):
(WebKit::AuthenticationManager::receivedRequestToPerformDefaultHandling):
(WebKit::AuthenticationManager::receivedChallengeRejection):

  • WebKit2.xcodeproj/project.pbxproj:
2:03 PM Changeset in webkit [196599] by Chris Dumez
  • 22 edits
    1 copy
    1 add in trunk

XMLHttpRequest / XMLHttpRequestUpload should inherit XMLHttpRequestEventTarget
​https://bugs.webkit.org/show_bug.cgi?id=154230

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline now that more checks are passing.

  • web-platform-tests/XMLHttpRequest/interfaces-expected.txt:

Source/WebCore:

MLHttpRequest / XMLHttpRequestUpload should inherit XMLHttpRequestEventTarget
as per:
​https://xhr.spec.whatwg.org/#xmlhttprequesteventtarget

Firefox and Chrome already match the specification.

No new tests, already covered by existing tests.

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • xml/XMLHttpRequest.h:
  • xml/XMLHttpRequest.idl:
  • xml/XMLHttpRequestEventTarget.h: Added.
  • xml/XMLHttpRequestEventTarget.idl: Copied from Source/WebCore/xml/XMLHttpRequestUpload.idl.
  • xml/XMLHttpRequestUpload.h:
  • xml/XMLHttpRequestUpload.idl:

LayoutTests:

Rebaseline tests now that XMLHttpRequestEventTarget is exposed on the
global objects.

  • js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
  • js/dom/global-constructors-attributes-expected.txt:
  • platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
  • platform/efl/js/dom/global-constructors-attributes-expected.txt:
  • platform/gtk/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
  • platform/win/js/dom/global-constructors-attributes-expected.txt:
1:38 PM Changeset in webkit [196598] by jiewen_tan@apple.com
  • 13 edits
    2 adds in trunk

Refine SimulatedMouseEvent to support Event.isTrusted
​https://bugs.webkit.org/show_bug.cgi?id=154133
<rdar://problem/24616246>

Reviewed by Darin Adler.

Source/WebCore:

This patch extracts everything related to create/dispatch SimulatedMouseEvent from MouseEvent.h/cpp
and EventDispatcher.h/cpp, and produces SimulateClick.h/cpp which will handle simulated click solely.
After that, we hide the SimulatedMouseEvent and only expose simulateClick to be called. The reason is
that we both want to tell whether the call sites are from user agent/bindings and keep the
SimulatedMouseEvent intact.

Also, this patch separate Element::dispatchSimulatedClick into two: one for the user agent, and another
for the bindings. Therefore, HTMLElement.click will be treated as untrusted.

Some of the changes in this patch referred Blink r200401:
​https://codereview.chromium.org/1285793004

Modified test:
LayoutTests/imported/blink/fast/events/event-trusted.html

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Element.cpp:

(WebCore::Element::dispatchSimulatedClick):
(WebCore::Element::dispatchSimulatedClickForBindings):

  • dom/Element.h:
  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchSimulatedClick): Deleted.

  • dom/EventDispatcher.h:
  • dom/MouseEvent.cpp:

(WebCore::SimulatedMouseEvent::create): Deleted.
(WebCore::SimulatedMouseEvent::~SimulatedMouseEvent): Deleted.
(WebCore::SimulatedMouseEvent::SimulatedMouseEvent): Deleted.

  • dom/MouseEvent.h:
  • dom/SimulatedClick.cpp: Added.

(WebCore::simulateMouseEvent):
(WebCore::simulateClick):

  • dom/SimulatedClick.h: Added.
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::click):

LayoutTests:

  • imported/blink/fast/events/event-trusted-expected.txt:
  • imported/blink/fast/events/event-trusted.html:
1:37 PM Changeset in webkit [196597] by timothy@apple.com
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Show inherited CSS variables in the Style sidebar
​https://bugs.webkit.org/show_bug.cgi?id=154215
rdar://problem/24644058

Reviewed by Joseph Pecoraro.

  • UserInterface/Models/CSSProperty.js:

(WebInspector.CSSProperty.isInheritedPropertyName): Added.
(WebInspector.CSSProperty.prototype.update): Use WebInspector.CSSProperty.isInheritedPropertyName.

  • UserInterface/Models/DOMNodeStyles.js:

(WebInspector.DOMNodeStyles.prototype._parseStyleDeclarationPayload): Use WebInspector.CSSProperty.isInheritedPropertyName.

1:30 PM Changeset in webkit [196596] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Sidebars are defaulting to their minimum width, instead of a good width
​https://bugs.webkit.org/show_bug.cgi?id=154218
rdar://problem/24644192

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/SidebarPanel.js:

(WebInspector.SidebarPanel): Default the setting value to 300 instead of 0, so the minimum isn't used.

1:25 PM Changeset in webkit [196595] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Marking animations/animation-delay-changed.html as flaky on ios-simulator
​https://bugs.webkit.org/show_bug.cgi?id=154253

Unreviewed test gardening.

  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-simulator/TestExpectations:
1:23 PM Changeset in webkit [196594] by commit-queue@webkit.org
  • 12 edits
    5 adds in trunk

Web Inspector: Web Workers have no access to console for debugging
​https://bugs.webkit.org/show_bug.cgi?id=26237

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-15
Reviewed by Timothy Hatcher.

LayoutTests/imported/w3c:

  • web-platform-tests/streams-api/readable-streams/garbage-collection-expected.txt:

Update test results for a console.warn message that the test produces from a Worker.

Source/JavaScriptCore:

  • inspector/ConsoleMessage.h:

Add accessor for MessageLevel.

Source/WebCore:

This adds the most basic console message support to Workers.
Messages logged from workers get surfaced through the Page's console.
This lacks support for logging and interacting with arguments,
which would be addressed when adding more complete Worker
debugging tools.

Test: inspector/console/messageAdded-from-worker.html

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:

Add new files.

  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::~WorkerScriptController):
(WebCore::WorkerScriptController::initScript):
Set the ConsoleClient for the Worker's global object. We route
the messages to the Page's console.

  • bindings/js/WorkerScriptController.h:
  • workers/WorkerConsoleClient.h: Added.
  • workers/WorkerConsoleClient.cpp: Added.

(WebCore::WorkerConsoleClient::WorkerConsoleClient):
(WebCore::WorkerConsoleClient::~WorkerConsoleClient):
(WebCore::WorkerConsoleClient::profile):
(WebCore::WorkerConsoleClient::profileEnd):
(WebCore::WorkerConsoleClient::count):
(WebCore::WorkerConsoleClient::time):
(WebCore::WorkerConsoleClient::timeEnd):
(WebCore::WorkerConsoleClient::timeStamp):
Stub most console methods in a Worker.

(WebCore::WorkerConsoleClient::messageWithTypeAndLevel):
Send worker log messages to the global scope and on to the main page.

  • workers/WorkerGlobalScope.h:
  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::addConsoleMessage):
(WebCore::WorkerGlobalScope::addMessageToWorkerConsole):
Ideally we want to converge on simple addConsoleMessage
APIs that just take a ConsoleMessage, without a barrage
of parameters. Add these versions now.

LayoutTests:

  • inspector/console/messageAdded-from-worker-expected.txt: Added.
  • inspector/console/messageAdded-from-worker.html: Added.
  • inspector/console/resources/worker-console-log.js: Added.
1:16 PM Changeset in webkit [196593] by timothy@apple.com
  • 5 edits
    2 adds in trunk

Web Inspector: CSS variables are not formatted correctly
​https://bugs.webkit.org/show_bug.cgi?id=154217
rdar://problem/24644154

Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

  • UserInterface/Views/CodeMirrorFormatters.js:

(newlineBeforeToken): Check for variable-2 token in the maybeprop state.

LayoutTests:

  • inspector/codemirror/prettyprinting-css-rules-expected.txt:
  • inspector/codemirror/prettyprinting-css-rules.html:
  • inspector/codemirror/resources/prettyprinting/css-rule-tests/css-variables-expected.css: Added.
  • inspector/codemirror/resources/prettyprinting/css-rule-tests/css-variables.css: Added.
1:13 PM Changeset in webkit [196592] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: CodeMirror styles needs updated for CSS variables
​https://bugs.webkit.org/show_bug.cgi?id=154216
rdar://problem/24644146

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/SyntaxHighlightingDefaultTheme.css:

(.cm-s-default .cm-m-css:matches(.cm-atom, .cm-meta, .cm-variable-2, .cm-variable-3, .cm-property)): Added .cm-variable-2.
(.cm-s-default .basic-block-has-not-executed.cm-m-css:matches(.cm-atom, .cm-meta, .cm-variable-2, .cm-variable-3, .cm-property)): Ditto.

1:08 PM Changeset in webkit [196591] by mark.lam@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

[ARMv7] stress/op_rshift.js and stress/op_urshift.js are failing.
​https://bugs.webkit.org/show_bug.cgi?id=151514

Reviewed by Filip Pizlo.

The issue turns out to be trivial: on ARMv7 (and traditional ARM too), arithmetic
shift right (ASR) and logical shift right (LSR) takes an immediate shift amount
from 1-32. See ​http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0204j/Cjacbgca.html.
An immediate shift amount of 0 is interpreted as a shift of 32 bits.

Meanwhile, our macro assembler is expecting the immediate shift value to be
between 0-31. As a result, a shift amount of 0 is being wrongly encoded with 0
bits which means shift right by 32 bits.

The fix is to check if the shift amount is 0, and if so, emit a move. Else,
emit the right shift as usual.

This issue does not affect left shifts, as the immediate shift amount for left
shifts is between 0-31 as our macro assembler expects.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::rshift32):
(JSC::MacroAssemblerARM::urshift32):
(JSC::MacroAssemblerARM::sub32):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::rshift32):
(JSC::MacroAssemblerARMv7::urshift32):

  • tests/stress/op_rshift.js:
  • tests/stress/op_urshift.js:
  • Un-skip these tests. They should always pass now.
12:49 PM Changeset in webkit [196590] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

CMake build fix.

  • PlatformMac.cmake:
12:30 PM Changeset in webkit [196589] by achristensen@apple.com
  • 5 edits in trunk

Fix internal Windows build of projects built after WebKit
​https://bugs.webkit.org/show_bug.cgi?id=154249
rdar://problem/24644805

Reviewed by Chris Dumez.

Source/WebKit:

  • PlatformWin.cmake:

Copy all generated headers to ForwardingHeaders/WebKit, not just WebKit.h.
This should fix problems related to not finding headers from other projects, such as AccessibleApplication.h.
WebKit.h, WebKitCOMAPI.h, and CFDictionaryPropertyBag.h were copied correctly, so this should copy the rest
of the needed headers.

Tools:

  • DumpRenderTree/PlatformWin.cmake:
  • MiniBrowser/win/CMakeLists.txt:

Don't include DerivedSources/WebKit/Interfaces to make MiniBrowser and DumpRenderTree
more like projects built internally after WebKit. They should only need to use what
is in ForwardingHeaders/WebKit.

12:09 PM Changeset in webkit [196588] by Chris Dumez
  • 3 edits
    2 adds in trunk

Regression(r196563): It is no longer possible to call window.addEventListener without an explicit 'this'
​https://bugs.webkit.org/show_bug.cgi?id=154245

Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch adds support for calling the EventListener API without an
explicit 'this' value. If no explicit 'this' value is passed, then we
fall back to using the global object. This matches Chrome and Firefox's
behavior. It also fixes the Dromaeo/cssquery-dojo.html test.

Test: fast/dom/Window/addEventListener-implicit-this.html

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateFunctionCastedThis):

LayoutTests:

Add a layout test to cover the use of the EventListener API without an
explicit 'this' value.

  • fast/dom/Window/addEventListener-implicit-this-expected.txt: Added.
  • fast/dom/Window/addEventListener-implicit-this.html: Added.
12:09 PM Changeset in webkit [196587] by fpizlo@apple.com
  • 3 edits
    1 add in trunk/Source/JavaScriptCore

Parser::parseVariableDeclarationList should null check the node before attempting to create a new CommaExpr
​https://bugs.webkit.org/show_bug.cgi?id=154244
rdar://problem/24290670

Reviewed by Michael Saboff.

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::appendToCommaExpr): Catch the bug sooner in debug.

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseVariableDeclarationList): Fix the bug.

  • tests/stress/for-let-comma.js: Added. This used to crash in debug and release.
12:01 PM Changeset in webkit [196586] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.46-branch/Source/bmalloc

Merged r196536. rdar://problem/24620164

11:59 AM Changeset in webkit [196585] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/bmalloc

Merged r196424. rdar://problem/24620164

11:58 AM Changeset in webkit [196584] by bshafiei@apple.com
  • 4 edits in branches/safari-601.1.46-branch/Source/bmalloc

Merged r196421. rdar://problem/24620164

11:56 AM Changeset in webkit [196583] by barraclough@apple.com
  • 2 edits in trunk/Source/WebCore

Organize, deduplicate & comment JSDOMWindowCustom getOwnPropertySlot
​https://bugs.webkit.org/show_bug.cgi?id=154224

Reviewed by Chris Dumez.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess):
(WebCore::jsDOMWindowGetOwnPropertySlotNamedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):

  • organized property access sequence into a more logical order, removed duplicated code & added comments.

(WebCore::namedItemGetter): Deleted.

  • there was no need for a custom callback here; merged functionality into jsDOMWindowGetOwnPropertySlotNamedItemGetter.

(WebCore::jsDOMWindowGetOwnPropertySlotCrossOrigin): Deleted.

  • renamed to jsDOMWindowGetOwnPropertySlotRestrictedAccess (this now also handles frameless access).
10:54 AM Changeset in webkit [196582] by dbates@webkit.org
  • 6 edits in trunk

CSP: 'sandbox' should be ignored in report-only mode
​https://bugs.webkit.org/show_bug.cgi?id=153167
<rdar://problem/22708669>

Reviewed by Brent Fulgham.

Source/WebCore:

Merged from Blink (patch by Mike West):
<​https://src.chromium.org/viewvc/blink?revision=165322&view=revision>

  • page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::reportInvalidDirectiveInReportOnlyMode): Added. Logs a
console message to the console to explain that the specified directive is invalid in
report-only mode.

  • page/csp/ContentSecurityPolicy.h:
  • page/csp/ContentSecurityPolicyDirectiveList.cpp:

(WebCore::ContentSecurityPolicyDirectiveList::applySandboxPolicy): Do not apply sandbox
policy when in report-only mode and call ContentSecurityPolicy::reportInvalidDirectiveInReportOnlyMode()
to log a message to the console.

LayoutTests:

Remove the entry from the TestExpectations file for the test
http/tests/security/contentSecurityPolicy/sandbox-report-only.html as it now passes.

10:53 AM Changeset in webkit [196581] by dbates@webkit.org
  • 5 edits in trunk

CSP: Allow schemeless source expressions to match an HTTP or HTTPS resource
​https://bugs.webkit.org/show_bug.cgi?id=154177
<rdar://problem/22708772>

Reviewed by Brent Fulgham.

Source/WebCore:

Allow a schemeless source expression to match an HTTP or HTTPS subresource when the page is
delivered over HTTP as per section Matching Source Expressions of the Content Security Policy
2.0 spec., <​https://www.w3.org/TR/2015/CR-CSP2-20150721/> (21 July 2015).

Currently we have logic that implements this functionality, but it is guarded behind the compile-
time macro ENABLE(CSP_NEXT) that is disabled by default. Instead we should always compile such
code. In subsequent commits we will move more code out from under the ENABLE(CSP_NEXT)-guard
towards removing the ENABLE_CSP_NEXT macro entirely.

  • page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::protocolMatchesSelf):

LayoutTests:

Update test case and expected result to test that a schemeless source expression
matches an HTTPS subresource (and does not trigger a Content Security Policy violation)
when the page is served over HTTP.

  • http/tests/security/contentSecurityPolicy/source-list-parsing-10-expected.txt:
  • http/tests/security/contentSecurityPolicy/source-list-parsing-10.html: Change "no" to "yes"

so that we consider it a success (and continue printing "PASS") when we load and execute the
script, <​https://127.0.0.1:8443/security/contentSecurityPolicy/resources/script.js>.

9:52 AM Changeset in webkit [196580] by timothy@apple.com
  • 2 edits in trunk/Websites/webkit.org

Fix byline to avoid bumping into content sticks out.

  • wp-content/themes/webkit/style.css:

(article .byline): Bump padding to avoid content with negative margins.

9:44 AM Changeset in webkit [196579] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Rebaseline imported/w3c/web-platform-tests/html/dom/interfaces.html for ios-simulator after r196563

Unreviewed test gardening.

  • platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
7:53 AM Changeset in webkit [196578] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Source/WebCore

[cmake] Consolidated Linux-specific file lists.
​https://bugs.webkit.org/show_bug.cgi?id=154219

Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-02-15
Reviewed by Gyuyoung Kim.

No new tests needed.

  • PlatformEfl.cmake: Moved Linux files and include dir to Linux.cmake.
  • PlatformGTK.cmake: Ditto.
  • platform/Linux.cmake: Added.
5:30 AM Changeset in webkit [196577] by Hunseop Jeong
  • 344 edits in trunk/LayoutTests

Unreviewed. EFL gardening after r195740.

  • platform/efl/tables/mozilla/bugs/bug10269-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug10269-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug10296-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug103533-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug106158-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug108340-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug110566-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug11321-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug113235-3-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug11944-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug119786-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug12384-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug1261-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug12910-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug13105-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug13118-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug133756-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug133756-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug13484-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug13526-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug138725-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug14159-3-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug149275-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug17130-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug1828-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug18558-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug2050-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug20579-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug21299-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug21918-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug221784-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug221784-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug22246-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug22246-2a-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug2267-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug23072-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug23151-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug23299-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug24503-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug24627-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug2469-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug2479-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug24880-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug25086-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug2516-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug25367-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug2585-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug26178-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug27038-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug27038-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug275625-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug2757-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug278266-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug278385-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug2886-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug29157-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug2973-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug3037-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug3037-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug30418-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug30985-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug3191-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug32205-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug32205-5-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug32447-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug3263-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug3309-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug34538-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug35662-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug3718-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug39209-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug40828-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug4284-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug4429-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug44523-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug45055-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug4520-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug46268-3-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug46268-5-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug46268-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug46480-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug46480-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug4739-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug48028-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug48028-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug51140-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug55527-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug55545-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug55694-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug56405-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug57300-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug57378-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug57828-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug5798-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug5799-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug5838-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug58402-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug59354-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug60013-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug60749-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug60992-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug63785-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug650-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug67864-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug67915-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug69187-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug709-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug7112-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug7112-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug75250-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug8032-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug82946-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug8361-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug83786-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug8381-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug9072-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug9271-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug93363-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug96343-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug965-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug97138-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug99923-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug99948-expected.txt:
  • platform/efl/tables/mozilla/collapsing_borders/bug127040-expected.txt:
  • platform/efl/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
  • platform/efl/tables/mozilla/core/captions-expected.txt:
  • platform/efl/tables/mozilla/core/col_widths_auto_auto-expected.txt:
  • platform/efl/tables/mozilla/core/col_widths_auto_autoPer-expected.txt:
  • platform/efl/tables/mozilla/core/col_widths_fix_autoPer-expected.txt:
  • platform/efl/tables/mozilla/core/row_span-expected.txt:
  • platform/efl/tables/mozilla/dom/appendCol2-expected.txt:
  • platform/efl/tables/mozilla/dom/appendRowsExpand1-expected.txt:
  • platform/efl/tables/mozilla/dom/appendTbodyExpand1-expected.txt:
  • platform/efl/tables/mozilla/dom/deleteCellsRebuild1-expected.txt:
  • platform/efl/tables/mozilla/dom/deleteCellsShrink1-expected.txt:
  • platform/efl/tables/mozilla/dom/deleteCellsShrink2-expected.txt:
  • platform/efl/tables/mozilla/dom/deleteCol1-expected.txt:
  • platform/efl/tables/mozilla/dom/deleteCol2-expected.txt:
  • platform/efl/tables/mozilla/dom/deleteCol3-expected.txt:
  • platform/efl/tables/mozilla/dom/deleteColGroup1-expected.txt:
  • platform/efl/tables/mozilla/dom/deleteColGroup2-expected.txt:
  • platform/efl/tables/mozilla/dom/deleteRowsRebuild1-expected.txt:
  • platform/efl/tables/mozilla/dom/deleteRowsShrink1-expected.txt:
  • platform/efl/tables/mozilla/dom/deleteTbodyExpand1-expected.txt:
  • platform/efl/tables/mozilla/dom/deleteTbodyRebuild1-expected.txt:
  • platform/efl/tables/mozilla/dom/insertCellsExpand1-expected.txt:
  • platform/efl/tables/mozilla/dom/insertCellsExpand2-expected.txt:
  • platform/efl/tables/mozilla/dom/insertCellsRebuild1-expected.txt:
  • platform/efl/tables/mozilla/dom/insertCellsRebuild2-expected.txt:
  • platform/efl/tables/mozilla/dom/insertRowsExpand1-expected.txt:
  • platform/efl/tables/mozilla/dom/insertRowsRebuild1-expected.txt:
  • platform/efl/tables/mozilla/dom/tableDom-expected.txt:
  • platform/efl/tables/mozilla/marvin/body_col-expected.txt:
  • platform/efl/tables/mozilla/marvin/body_tbody-expected.txt:
  • platform/efl/tables/mozilla/marvin/body_tfoot-expected.txt:
  • platform/efl/tables/mozilla/marvin/body_thead-expected.txt:
  • platform/efl/tables/mozilla/marvin/col_span-expected.txt:
  • platform/efl/tables/mozilla/marvin/table_frame_border-expected.txt:
  • platform/efl/tables/mozilla/marvin/table_frame_box-expected.txt:
  • platform/efl/tables/mozilla/marvin/table_rules_all-expected.txt:
  • platform/efl/tables/mozilla/marvin/table_rules_none-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_align_center-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_align_left-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_align_right-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_border_0-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_border_1-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_border_2-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_border_3-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_caption_align_bot-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_caption_align_top-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_cellspacing-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_default-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_id-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_row_th_nowrap-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_td_align_center-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_td_align_left-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_td_align_right-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_td_colspan-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_td_height-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_td_nowrap-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_td_rowspan-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_th_align_center-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_th_align_left-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_th_align_right-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_th_colspan-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_th_height-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_th_rowspan-expected.txt:
  • platform/efl/tables/mozilla/marvin/tbody_align_center-expected.txt:
  • platform/efl/tables/mozilla/marvin/tbody_align_char-expected.txt:
  • platform/efl/tables/mozilla/marvin/tbody_align_justify-expected.txt:
  • platform/efl/tables/mozilla/marvin/tbody_align_left-expected.txt:
  • platform/efl/tables/mozilla/marvin/tbody_align_right-expected.txt:
  • platform/efl/tables/mozilla/marvin/tbody_char-expected.txt:
  • platform/efl/tables/mozilla/marvin/tfoot_align_center-expected.txt:
  • platform/efl/tables/mozilla/marvin/tfoot_align_char-expected.txt:
  • platform/efl/tables/mozilla/marvin/tfoot_align_justify-expected.txt:
  • platform/efl/tables/mozilla/marvin/tfoot_align_left-expected.txt:
  • platform/efl/tables/mozilla/marvin/tfoot_align_right-expected.txt:
  • platform/efl/tables/mozilla/marvin/tfoot_char-expected.txt:
  • platform/efl/tables/mozilla/marvin/thead_align_center-expected.txt:
  • platform/efl/tables/mozilla/marvin/thead_align_char-expected.txt:
  • platform/efl/tables/mozilla/marvin/thead_align_justify-expected.txt:
  • platform/efl/tables/mozilla/marvin/thead_align_left-expected.txt:
  • platform/efl/tables/mozilla/marvin/thead_align_right-expected.txt:
  • platform/efl/tables/mozilla/marvin/thead_char-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_caption_align_bottom-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_caption_align_top-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_table-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_table_align_center-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_table_align_left-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_table_align_right-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_table_bgcolor_name-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_table_border-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_table_border_none-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_table_border_px-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_table_cellpadding-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_table_cellpadding_pct-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_table_cellspacing-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_table_cellspacing_pct-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_table_frame_void-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_table_rules_groups-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_table_rules_none-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_table_style-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tbody_align_center-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tbody_align_char-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tbody_align_left-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tbody_align_right-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tbody_class-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tbody_id-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tbody_style-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_td_bgcolor_name-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_td_class-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_td_colspan-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_td_height-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_td_id-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_td_nowrap-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_td_rowspan-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_td_style-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tfoot_align_center-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tfoot_align_char-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tfoot_align_left-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tfoot_align_right-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tfoot_class-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tfoot_id-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tfoot_style-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_th_bgcolor_name-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_th_class-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_th_colspan-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_th_height-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_th_id-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_th_nowrap-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_th_style-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_thead_align_center-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_thead_align_char-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_thead_align_left-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_thead_align_right-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_thead_class-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_thead_id-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_thead_style-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tr_bgcolor_name-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tr_class-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tr_id-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tr_style-expected.txt:
  • platform/efl/tables/mozilla/other/body_col-expected.txt:
  • platform/efl/tables/mozilla/other/cellspacing-expected.txt:
  • platform/efl/tables/mozilla/other/move_row-expected.txt:
  • platform/efl/tables/mozilla/other/padding-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug101759-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug104898-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug106336-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug11945-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug14159-2-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug178855-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug18770-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug24880-1-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug25707-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-11-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-12-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-13-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-14-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-16-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-17-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3166-18-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug32205-1-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug32205-4-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug4294-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug51000-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug65372-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug6933-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug7113-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug73629-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug92868_1-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/core/backgrounds-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/core/captions3-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/core/conflicts-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/dom/appendCells1-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/dom/appendCellsRebuild1-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/dom/appendCol1-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_frame_above-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_frame_below-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_frame_hsides-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_frame_void-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_colgroup_width_px-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_rules_all-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_rules_cols-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/x_table_rules_rows-expected.txt:
4:28 AM Changeset in webkit [196576] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore
Fix the !(ENABLE(SVG_FONTS)
ENABLE(SVG_OTF_CONVERTER)) build after r196322

​https://bugs.webkit.org/show_bug.cgi?id=154104

Reviewed by Myles C. Maxfield.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::CSSFontFaceSource):

2:30 AM Changeset in webkit [196575] by Antti Koivisto
  • 5 edits
    2 adds in trunk

Add test for class change style invalidation optimization
​https://bugs.webkit.org/show_bug.cgi?id=154226

Reviewed by Myles Maxfield.

Test for ​https://trac.webkit.org/r196383

Source/WebCore:

Add internals.styleChangeType function.

Test: fast/css/style-invalidation-class-change-descendants.html

  • testing/Internals.cpp:

(WebCore::Internals::nodeNeedsStyleRecalc):
(WebCore::asString):
(WebCore::Internals::styleChangeType):
(WebCore::Internals::description):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

  • fast/css/style-invalidation-class-change-descendants-expected.txt: Added.
  • fast/css/style-invalidation-class-change-descendants.html: Added.
1:50 AM Changeset in webkit [196574] by Hunseop Jeong
  • 2 edits in trunk/LayoutTests

Unreviewed. EFL gardening. Mark more video tests to failure.

  • platform/efl/TestExpectations: Added more crash tests and moved the tests to upper position.
1:12 AM Changeset in webkit [196573] by commit-queue@webkit.org
  • 9 edits in trunk/Source/JavaScriptCore

[JSC] Improve the interface of Inst::shouldTryAliasingDef()
​https://bugs.webkit.org/show_bug.cgi?id=154227

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-02-15
Reviewed by Andreas Kling.

Using Optional<> instead of a bool+reference looks cleaner
at the call sites.

  • b3/B3CheckSpecial.cpp:

(JSC::B3::CheckSpecial::shouldTryAliasingDef):

  • b3/B3CheckSpecial.h:
  • b3/air/AirCustom.h:

(JSC::B3::Air::PatchCustom::shouldTryAliasingDef):

  • b3/air/AirInst.h:
  • b3/air/AirInstInlines.h:

(JSC::B3::Air::Inst::shouldTryAliasingDef):

  • b3/air/AirIteratedRegisterCoalescing.cpp:
  • b3/air/AirSpecial.cpp:

(JSC::B3::Air::Special::shouldTryAliasingDef):

  • b3/air/AirSpecial.h:
12:39 AM Changeset in webkit [196572] by Gyuyoung Kim
  • 2 edits in trunk/Source/WebKit2

[CMake][Mac] Remove WKNPAPIPlugInContainer.mm in WebKit2/PlatformMac.cmake
​https://bugs.webkit.org/show_bug.cgi?id=154234

Reviewed by Csaba Osztrogonác.

  • PlatformMac.cmake: Remove WKNPAPIPlugInContainer.mm.

Feb 14, 2016:

9:10 PM Changeset in webkit [196571] by Simon Fraser
  • 3 edits
    2 adds in trunk

[CSS Filters] When applying an SVG filter on a composited image using CSS the image is rendered without the filter
​https://bugs.webkit.org/show_bug.cgi?id=154108

Reviewed by Sam Weinig.
Source/WebCore:

When checking whether we can directly composite an image, we need to check for software-rendered
filters.

Test: compositing/filters/simple-image-with-svg-filter.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::isDirectlyCompositedImage):

LayoutTests:

  • compositing/filters/simple-image-with-svg-filter-expected.html: Added.
  • compositing/filters/simple-image-with-svg-filter.html: Added.
8:49 PM Changeset in webkit [196570] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

Unreviewed, land an additional Mac CMake build fix.

  • PlatformMac.cmake:
8:47 PM Changeset in webkit [196569] by Chris Dumez
  • 3 edits in trunk/Source/WebKit/win

Unreviewed Window build fix.

  • WebCoreStatistics.cpp:
  • WebJavaScriptCollector.cpp:
8:43 PM Changeset in webkit [196568] by Chris Dumez
  • 46 edits in trunk/Source/WebCore

Drop the [EventTarget] WebKit-specific IDL extended attribute
​https://bugs.webkit.org/show_bug.cgi?id=154171

Reviewed by Sam Weinig.

Drop the [EventTarget] WebKit-specific IDL extended attribute now that
all interfaces inherit EventTarget when they should.

No new tests, no Web-Exposed behavior change.

  • Modules/battery/BatteryManager.idl:
  • Modules/encryptedmedia/MediaKeySession.idl:
  • Modules/indexeddb/IDBDatabase.idl:
  • Modules/indexeddb/IDBOpenDBRequest.idl:
  • Modules/indexeddb/IDBRequest.idl:
  • Modules/indexeddb/IDBTransaction.idl:
  • Modules/mediasession/MediaRemoteControls.idl:
  • Modules/mediasource/MediaSource.idl:
  • Modules/mediasource/SourceBuffer.idl:
  • Modules/mediasource/SourceBufferList.idl:
  • Modules/mediastream/MediaStream.idl:
  • Modules/mediastream/MediaStreamTrack.idl:
  • Modules/mediastream/RTCDTMFSender.idl:
  • Modules/mediastream/RTCDataChannel.idl:
  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/notifications/Notification.idl:
  • Modules/speech/SpeechSynthesisUtterance.idl:
  • Modules/webaudio/AudioContext.idl:
  • Modules/webaudio/AudioNode.idl:
  • Modules/webaudio/OfflineAudioContext.idl:
  • Modules/websockets/WebSocket.idl:
  • bindings/scripts/CodeGeneratorGObject.pm:

(ImplementsInterface):
(SkipFunction): Deleted.
(GenerateCFile): Deleted.

  • bindings/scripts/CodeGeneratorJS.pm:

(InstanceNeedsVisitChildren):
(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/TestEventTarget.idl:
  • bindings/scripts/test/TestNode.idl:
  • css/FontLoader.idl:
  • dom/EventTarget.idl:
  • dom/MessagePort.idl:
  • dom/Node.idl:
  • dom/WebKitNamedFlow.idl:
  • fileapi/FileReader.idl:
  • html/MediaController.idl:
  • html/track/AudioTrackList.idl:
  • html/track/TextTrack.idl:
  • html/track/TextTrackCue.idl:
  • html/track/TextTrackList.idl:
  • html/track/VideoTrackList.idl:
  • loader/appcache/DOMApplicationCache.idl:
  • page/DOMWindow.idl:
  • page/EventSource.idl:
  • page/Performance.idl:
  • workers/WorkerGlobalScope.idl:
  • xml/XMLHttpRequest.idl:
  • xml/XMLHttpRequestUpload.idl:
7:53 PM Changeset in webkit [196567] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed attempt to fix the Mac CMake build after r196136

  • PlatformMac.cmake:
7:47 PM Changeset in webkit [196566] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Unreviewed attempt to fix the Windows build.

  • Modules/webdatabase/Database.cpp:
  • bridge/c/c_utility.cpp:
  • platform/MemoryPressureHandler.cpp:
6:23 PM Changeset in webkit [196565] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.5.17.1/Source

Versioning.

6:22 PM Changeset in webkit [196564] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.5.17.1

New tag.

6:17 PM Changeset in webkit [196563] by Chris Dumez
  • 29 edits
    3 adds in trunk

Window and WorkerGlobalScope should inherit EventTarget
​https://bugs.webkit.org/show_bug.cgi?id=154170
<rdar://problem/24642377>

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline now that a couple of checks are passing.

  • web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

Window and WorkerGlobalScope should inherit EventTarget instead of
duplicating the EventTarget API in their IDL. These were the last
interfaces that needed fixing. The next step will be to get rid
of the [EventTarget] IDL extended attribute and rely entirely
on the EventTarget inheritance.

Test:

  • fast/frames/detached-frame-eventListener.html
  • Covered by existing tests.
  • WebCore.xcodeproj/project.pbxproj:

Add JSEventTargetCustom.h header to the project.

  • bindings/js/JSDOMWindowCustom.cpp:

Drop custom bindings for Window's addEventListener() and
removeEventListener(). The only reason these needed custom
code was to add a check for frameless windows. The frameless
Window checks was moved to the respective methods in the
JSEventTarget generated bindings.

  • bindings/js/JSDOMWindowShell.cpp:

(WebCore::JSDOMWindowShell::setWindow):
Set WindowPrototype's prototype to EventTarget's prototype.

  • bindings/js/JSDOMWindowShell.h:
  • bindings/js/JSDictionary.cpp:

Include "DOMWindow.h" to fix the build.

  • bindings/js/JSEventTargetCustom.cpp:

(WebCore::JSEventTarget::toWrapped):
Handle DOMWindow and WorkerGlobalScope explicitely in toWrapped()
and get rid of the DOM_EVENT_TARGET_INTERFACES_FOR_EACH(TRY_TO_UNWRAP_WITH_INTERFACE)
now that all interfaces inherit EventTarget when they should.
The reason DOMWindow and WorkerGlobalScope still need special
handling is because their wrappers (JSDOMWindow /
JSWorkerGlobalScope) do not subclass JSEventTarget.

(WebCore::JSEventTargetOrGlobalScope::create):

  • bindings/js/JSEventTargetCustom.h: Added.

(WebCore::JSEventTargetOrGlobalScope::wrapped):
(WebCore::JSEventTargetOrGlobalScope::operator JSC::JSObject&):
(WebCore::JSEventTargetOrGlobalScope::JSEventTargetOrGlobalScope):
Add a wrapper type for JSEventTarget / JSDOMWindow and
JSWorkerGlobalScope for use in the generated bindings. This is
needed because JSDOMWindow and JSWorkerGlobalScope do not
subclass JSEventTarget. Subclassing JSEventTarget would be
complicated for them because they already subclass
JSDOMWindowBase / JSWorkerGlobalScopeBase, which subclasses
JSDOMGlobalObject.

  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::initScript):
Set WorkerGlobalScopePrototype's prototype to EventTarget's prototype.

  • bindings/scripts/CodeGeneratorJS.pm:

(ShouldGenerateToJSDeclaration):
Do not generate to toJS() implementation for interfaces that use
the [CustomProxyToJSObject] IDL extended attribute, even if they
inherit EventTarget.

(GetCastingHelperForThisObject):
To initialize castedThis from thisValue JSValue, we now use the
JSEventTargetOrGlobalScope wrapper for the EventTarget
implementation. This is to work around the fact that JSDOMWindow
and JSWorkerGlobalScope do not subclass JSEventTarget.

(GenerateFunctionCastedThis):

  • Drop code handling [WorkerGlobalScope] IDL extended attribute as there is no such attribute.
  • Use auto instead of auto* type for castedThis because JSEventTargetOrGlobalScope::create() returns a unique_ptr.
  • Do not check that castedThis inherits JSEventTarget in the EventTarget bindings code as this no longer holds true.

(GenerateImplementation):
Generate frameless window() and security checks for EventTarget
methods when thisValue is a JSDOMWindow.

  • dom/EventTarget.idl:

Add [JSCustomHeader] IDL Extended attribute as we need a header
to expose JSEventTargetOrGlobalScope class.

  • page/DOMWindow.idl:
  • workers/WorkerGlobalScope.idl:

Inherit EventTarget and stop duplicating the EventTarget API.
This matches the HTML specification.

LayoutTests:

  • fast/frames/detached-frame-eventListener-expected.txt: Added.
  • fast/frames/detached-frame-eventListener.html: Added.

Add test case to cover the use of the EventListener API on a detached
frame.

  • fast/loader/window-clearing-expected.txt:

Rebaseline now that window has one more object in its prototype chain.

  • http/tests/security/cross-frame-access-call-expected.txt:
  • http/tests/security/cross-frame-access-call.html:

Add test coverage for cross-origin access to window.dispatchEvent() which
should not be allowed, in addition to window.addEventListener() and
window.removeEventListener() which were already tested.

5:42 PM Changeset in webkit [196562] by BJ Burg
  • 7 edits in trunk/Source

WKAutomationDelegate's requestAutomationSession should take a suggested session identifier
​https://bugs.webkit.org/show_bug.cgi?id=154012
<rdar://problem/24557697>

Reviewed by Darin Adler.

Source/JavaScriptCore:

Add a string parameter to the client method for requesting a new session.

  • inspector/remote/RemoteInspector.h:

Source/WebKit2:

Add a string parameter to the delegate method for requesting a new session.

  • UIProcess/API/APIAutomationClient.h:

(API::AutomationClient::didRequestAutomationSession):
(API::AutomationClient::requestAutomationSession): Deleted.
Rename the client method to better match the delegate method's name.

  • UIProcess/API/Cocoa/_WKAutomationDelegate.h:
  • UIProcess/Cocoa/AutomationClient.h:
  • UIProcess/Cocoa/AutomationClient.mm:

(WebKit::AutomationClient::AutomationClient):
(WebKit::AutomationClient::requestAutomationSession):

5:26 PM Changeset in webkit [196561] by Darin Adler
  • 3 edits in trunk/Source/WebCore

Small tweaks to some SimpleLineLayout code
​https://bugs.webkit.org/show_bug.cgi?id=154229

Reviewed by Zalan Bujtas.

  • rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::paintFlow): Use std::ceil instead of ceilf.
Use auto instead of const auto& for a for loop where the local object is
copied and not a reference.
(WebCore::SimpleLineLayout::hitTestFlow): Use modern for loop.
(WebCore::SimpleLineLayout::collectFlowOverflow): Use std::ceil instead of
ceilf. Use a modern for loop, and use slightly more descriptive local
variable names.
(WebCore::SimpleLineLayout::computeBoundingBox): Use auto instead of
const auto& as above.
(WebCore::SimpleLineLayout::computeFirstRunLocation): Use auto and use
the name "range" for the range rather than the name "it", since the range
is not an iterator.
(WebCore::SimpleLineLayout::collectAbsoluteRects): Use auto instead of
const auto& as above.
(WebCore::SimpleLineLayout::collectAbsoluteQuads): Ditto.
(WebCore::SimpleLineLayout::showLineLayoutForFlow): Use modern for loop.

  • rendering/SimpleLineLayoutResolver.cpp:

(WebCore::SimpleLineLayout::RunResolver::Run::text): Convert from a String
to a StringView using the StringView constructor instead of writing out
explicit 8-bit and 16-bit cases.

1:57 AM Changeset in webkit [196560] by Antti Koivisto
  • 5 edits
    2 adds in trunk/Source/WebCore

Factor class change style invalidation code into a class
​https://bugs.webkit.org/show_bug.cgi?id=154163

Reviewed by Andreas Kling.

Factor this piece of functionality out of Element and into ClassChangeInvalidation class.

  • CMakeLists.txt:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Element.cpp:

(WebCore::classStringHasClassName):
(WebCore::Element::classAttributeChanged):
(WebCore::collectClasses): Deleted.
(WebCore::computeClassChange): Deleted.
(WebCore::invalidateStyleForClassChange): Deleted.

  • style/ClassChangeInvalidation.cpp: Added.

(WebCore::Style::ClassChangeInvalidation::computeClassChange):
(WebCore::Style::ClassChangeInvalidation::invalidateStyle):

  • style/ClassChangeInvalidation.h: Added.

(WebCore::Style::ClassChangeInvalidation::needsInvalidation):
(WebCore::Style::ClassChangeInvalidation::ClassChangeInvalidation):
(WebCore::Style::ClassChangeInvalidation::~ClassChangeInvalidation):

Note: See TracTimeline for information about the timeline view.