Context Navigation

← Previous Period
Next Period →

Timeline

Mar 19, 2016:

6:57 PM Changeset in webkit [198473] by jh718.park@samsung.com

10 edits in trunk/Source/WebCore

Purge PassRefPtr from WebCore/html/shadow
https://bugs.webkit.org/show_bug.cgi?id=155681

Reviewed by Darin Adler.

No new tests, no new behaviours.

html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::updateImageControls):
(WebCore::HTMLImageElement::tryCreateImageControls):
(WebCore::HTMLImageElement::createImageControls): Deleted.

html/HTMLImageElement.h:
html/shadow/ImageControlsRootElement.h:
html/shadow/MediaControls.h:
html/shadow/MediaControlsApple.cpp:

(WebCore::MediaControls::tryCreate):
(WebCore::MediaControlsApple::tryCreateControls):
(WebCore::MediaControlsApple::showClosedCaptionTrackList):
(WebCore::MediaControlsApple::hideClosedCaptionTrackList):
(WebCore::MediaControlsApple::eventListener):
(WebCore::MediaControls::create): Deleted.
(WebCore::MediaControlsApple::createControls): Deleted.

html/shadow/MediaControlsApple.h:
html/shadow/mac/ImageControlsButtonElementMac.cpp:

(WebCore::ImageControlsButtonElementMac::tryCreate):
(WebCore::ImageControlsButtonElementMac::maybeCreate): Deleted.

html/shadow/mac/ImageControlsButtonElementMac.h:
html/shadow/mac/ImageControlsRootElementMac.cpp:

(WebCore::ImageControlsRootElement::tryCreate):
(WebCore::ImageControlsRootElement::maybeCreate): Deleted.

2:16 PM Changeset in webkit [198472] by gskachkov@gmail.com

10 edits in trunk

[ES6] Arrow function syntax. Update syntax error text 'super is only valid inside functions' to more suitable
https://bugs.webkit.org/show_bug.cgi?id=155491

Reviewed by Saam Barati.

Source/JavaScriptCore:

Current message 'super is only valid inside of funcitons' is not correct
after patch for https://bugs.webkit.org/show_bug.cgi?id=153864 because
it is allow to use 'super' in eval. Current patch replace old message by
'Super is only valid inside functions or 'eval' inside a function' and
fix tests that rely on this message.

parser/Parser.cpp:

(JSC::Parser<LexerType>::parseMemberExpression):

tests/stress/generator-with-super.js:

(shouldThrow):

tests/stress/modules-syntax-error.js:
tests/stress/super-in-lexical-scope.js:
tests/stress/tagged-templates-syntax.js:

LayoutTests:

js/class-syntax-super-expected.txt:
js/script-tests/class-syntax-super.js:
sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.27-expected.txt:

11:54 AM Changeset in webkit [198471] by Antti Koivisto

2 edits in trunk/Source/WebCore

Data URL DecodeTask may get deleted outside main thread
https://bugs.webkit.org/show_bug.cgi?id=155584
rdar://problem/24492104

Reviewed by David Kilzer.

Follow-up: fix a possible null pointer crash.

platform/network/DataURLDecoder.cpp:

(WebCore::DataURLDecoder::DecodingResultDispatcher::startTimer):

If timer fires under startOneShot m_decodeTask may become zero before schedule() is called.
Fix by copying schedule context to a local before calling startOneShot.

11:46 AM Changeset in webkit [198470] by Chris Dumez

7 edits in trunk/Source/WebKit2

Add a setting to let the client toggle support for network cache speculative validation
https://bugs.webkit.org/show_bug.cgi?id=155622
<rdar://problem/25233209>

Reviewed by Darin Adler.

Add SPI to toggle support for network cache speculative validation.
Enable network cache speculative validation by default for now, until
I have a chance to update the clients to use the new SPI.

UIProcess/API/APIProcessPoolConfiguration.h:
UIProcess/API/C/WKContext.cpp:

(WKContextSetDiskCacheSpeculativeValidationEnabled):

UIProcess/API/C/WKContextPrivate.h:
UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:

(-[_WKProcessPoolConfiguration diskCacheSpeculativeValidationEnabled]):
(-[_WKProcessPoolConfiguration setDiskCacheSpeculativeValidationEnabled:]):

UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeNetworkProcess):

11:13 AM Changeset in webkit [198469] by mark.lam@apple.com

14 edits in trunk

ES6 spec requires that ErrorPrototype not be an Error object.
https://bugs.webkit.org/show_bug.cgi?id=155680

Reviewed by Michael Saboff.

Source/JavaScriptCore:

The ES6 spec states that Error.prototype should not be an instance of Error:
https://tc39.github.io/ecma262/#sec-properties-of-the-error-prototype-object

"The Error prototype object is an ordinary object. It is not an Error instance
and does not have an ErrorData internal slot."

This patch changes ErrorPrototype to conform to the above specification.

runtime/ErrorConstructor.cpp:

(JSC::ErrorConstructor::finishCreation):

runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::ErrorPrototype):
(JSC::ErrorPrototype::finishCreation):
(JSC::ErrorPrototype::getOwnPropertySlot):

runtime/ErrorPrototype.h:

(JSC::ErrorPrototype::create):

runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::finishCreation):

runtime/NativeErrorPrototype.cpp:

(JSC::NativeErrorPrototype::NativeErrorPrototype):
(JSC::NativeErrorPrototype::finishCreation):

runtime/NativeErrorPrototype.h:

(JSC::NativeErrorPrototype::create):

updated to no longer need a JSGlobalObject argument.

tests/es6/miscellaneous_built-in_prototypes_are_not_instances.js:
updated to match the kangax version of this test.

LayoutTests:

Updated the appropriate tests to expect the toString() value of Error.prototype
to now be "[object Object]" instead of "[object Error]". Also rebased the test
results accordingly.

fast/dom/DOMException/prototype-object-expected.txt:
fast/dom/DOMException/prototype-object.html:
js/dom/native-error-prototype-expected.txt:
js/dom/script-tests/native-error-prototype.js:
sputnik/Conformance/15_Native_Objects/15.11_Error/15.11.4/S15.11.4_A2.html:

12:17 AM Changeset in webkit [198468] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

https://bugs.webkit.org/show_bug.cgi?id=155664
Consider to cap the size of session history data.

In iOS, if the total history entries data exceeds a threshold (2MB at the moment), don't
accumulate more data into the session state blob.

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2016-03-19
Reviewed by Darin Adler.

UIProcess/mac/LegacySessionStateCoding.cpp:

(WebKit::encodeSessionHistory): Stop encoding further history entries data into session state

if the total size exceed 2MB in iOS.

Mar 18, 2016:

10:05 PM Changeset in webkit [198467] by dbates@webkit.org

3 edits
2 adds in trunk/LayoutTests

Update AutoFill button in input fields
https://bugs.webkit.org/show_bug.cgi?id=155619

Update expected results for Windows and GTK ports. Add expected result for the EFL port.

platform/efl/fast/forms/auto-fill-button/input-contacts-auto-fill-button-expected.txt: Added.
platform/gtk/fast/forms/auto-fill-button/input-contacts-auto-fill-button-expected.txt:
platform/win/fast/forms/auto-fill-button/input-contacts-auto-fill-button-expected.txt:

9:06 PM Changeset in webkit [198466] by rniwa@webkit.org

2 edits in trunk/Websites/perf.webkit.org

Build fix after r198464.

public/v3/components/analysis-results-viewer.js:

(AnalysisResultsViewer.prototype._buildRowsForPointsAndTestGroups):

8:33 PM pywebsocket: a WebSocket server for layout tests edited by citizenJ@yopmail.com

(diff)

8:33 PM Changeset in webkit [198465] by rniwa@webkit.org

3 edits in trunk/Websites/perf.webkit.org

Build fix after r198234.

public/api/commits.php:

(main): Typo: fetch_latest_reported -> fetch_last_reported.

public/include/commit-log-fetcher.php:

(CommitLogFetcher::format_single_commit): commits should be an array.

8:29 PM Changeset in webkit [198464] by rniwa@webkit.org

3 edits in trunk/Websites/perf.webkit.org

Perf Dashboard v3 confuses better and worse on A/B task page
https://bugs.webkit.org/show_bug.cgi?id=155675
<rdar://problem/25208723>

Reviewed by Joseph Pecoraro.

The analysis results viewer on v3 UI sometimes treats regressions as progressions and vice versa when
the first set (i.e. set A) of the revisions used in an A/B testing never appears in the original graph,
and its latest commit time matches that of the second set, which appears in the original graph.

Because the analysis results viewer compares results in the increasing row number, this results in
B to be compared to A instead of A to be compared to B. Fixed the bug by preventing the wrong ordering
to occur in _buildRowsForPointsAndTestGroups by always inserting a root set A before B when B appears
and A doesn't appear in the original graph.

public/v3/components/analysis-results-viewer.js:

(AnalysisResultsViewer.prototype._collectRootSetsInTestGroups): Remember the succeeding root set B
when creating an entry for root set A.
(AnalysisResultsViewer.prototype._buildRowsForPointsAndTestGroups): Fixed the bug. Also un-duplicated
the code to create a new row.
(AnalysisResultsViewer.RootSetInTestGroup): Now takes a succeeding root set. e.g. it's B for A and
undefined for B in A/B testing.
(AnalysisResultsViewer.RootSetInTestGroup.prototype.succeedingRootSet): Added.

public/v3/components/time-series-chart.js:

(TimeSeriesChart.computeTimeGrid): Fixed the bug that we would end up showing 0 AM instead of dates
when both dates and months change.

7:50 PM Changeset in webkit [198463] by rniwa@webkit.org

1 edit
2 adds in trunk/Websites/perf.webkit.org

Add unit tests for measurement-set.js and measurement-adapter.js
https://bugs.webkit.org/show_bug.cgi?id=155673

Reviewed by Daniel Bates.

Add tests which were supposed to be added in r198462.

unit-tests/measurement-adaptor-tests.js: Added.
unit-tests/measurement-set-tests.js: Added.

(assert.notReached): Added.
(global.RemoteAPI.getJSON): Added.
(global.RemoteAPI.getJSONWithStatus): Added. A mock.

7:17 PM Changeset in webkit [198462] by rniwa@webkit.org

15 edits
1 add in trunk/Websites/perf.webkit.org

Add unit tests for measurement-set.js and measurement-adapter.js
https://bugs.webkit.org/show_bug.cgi?id=155673

Reviewed by Darin Adler.

Added mocha unit tests for MeasurementSet and MeasurementAdapter classes along with the necessary
refactoring to run these tests in node.

getJSON and getJSONStatus are now under RemoteAPI so that unit tests can mock them.

Removed the dependency on v2 UI's TimeSeries and Measurement class by adding a new implementation
of TimeSeries in v3 and removing the dependency on Measurement in chart-pane-status-view.js with
new helper methods on Build and CommitLog.

Many js files now use 'use strict' (node doesn't support class syntax in non-strict mode) and
module.exports to export symbols in node's require function.

public/v3/index.html:
public/v3/main.js:
public/v3/models/analysis-results.js:

(AnalysisResults.fetch):

public/v3/models/analysis-task.js:

(AnalysisTask.fetchAll):

public/v3/models/builder.js:

(Build):
(Build.prototype.builder): Added. Used by ChartPaneStatusView.
(Build.prototype.buildNumber): Ditto.
(Build.prototype.buildTime): Ditto.

public/v3/models/commit-log.js:

(CommitLog.prototype.diff): Ditto.
(CommitLog.fetchBetweenRevisions):

public/v3/models/data-model.js:

(DataModelObject.cachedFetch):

public/v3/models/measurement-adaptor.js:

(MeasurementAdaptor.prototype.applyToAnalysisResults): Renamed from adoptToAnalysisResults.
(MeasurementAdaptor.prototype.applyTo): Renamed from adoptToSeries. Now shares a lot more
code with applyToAnalysisResults. The code to set 'series' and 'seriesIndex' has been moved
to TimeSeries.append. 'measurement' is no longer needed as this patch removes its only use
in ChartPaneStatusView.

public/v3/models/measurement-cluster.js:

(MeasurementCluster.prototype.addToSeries): Use TimeSeries.append instead of directly mutating
series._series.

public/v3/models/measurement-set.js:

(Array.prototype.includes): Added a polyfill for node.
(MeasurementSet.prototype._fetchSecondaryClusters): Removed a bogus assertion. When fetchBetween
is called with a mixture of clusters that have been fetched and not fetched, this assertion fails.
(MeasurementSet.prototype._fetch):
(TimeSeries.prototype.findById): Moved to time-series.js.
(TimeSeries.prototype.dataBetweenPoints): Ditto.
(TimeSeries.prototype.firstPoint): Ditto.
(TimeSeries.prototype.fetchedTimeSeries): Moved the code to extend the last point to TimeSeries'
extendToFuture.

public/v3/models/repository.js:
public/v3/models/root-set.js:

(MeasurementRootSet): Ignore repositories that had not been defined (e.g. it could be added after
manifest.json had been downloaded but before a given root set is created for an A/B testing).

public/v3/models/time-series.js:

(TimeSeries): Added.
(TimeSeries.prototype.append): Added.
(TimeSeries.prototype.extendToFuture): Added.
(TimeSeries.prototype.firstPoint): Moved from measurement-set.js.
(TimeSeries.prototype.lastPoint): Added.
(TimeSeries.prototype.previousPoint): Added.
(TimeSeries.prototype.nextPoint): Added.
(TimeSeries.prototype.findPointByIndex): Added.
(TimeSeries.prototype.findById): Moved from measurement-set.js.
(TimeSeries.prototype.findPointAfterTime): Added.
(TimeSeries.prototype.dataBetweenPoints): Moved from measurement-set.js.

public/v3/pages/chart-pane-status-view.js:

(ChartPaneStatusView.prototype.render): Use newly added helper functions on Build.
(ChartPaneStatusView.prototype._formatTime): Added.
(ChartPaneStatusView.prototype.setCurrentRepository):
(ChartPaneStatusView.prototype.computeChartStatusLabels): Rewrote the code using RootSet object on
currentPoint and previousPoint instead of Measurement class from v2 UI. Also sort the results using
sortByNamePreferringOnesWithURL.

public/v3/remote.js:

(RemoteAPI.getJSON): Moved under RemoteAPI.
(RemoteAPI.getJSONWithStatus): Ditto.
(PrivilegedAPI):
(PrivilegedAPI.requestCSRFToken):

6:37 PM Changeset in webkit [198461] by commit-queue@webkit.org

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Bullet misaligned when expanding console log message
https://bugs.webkit.org/show_bug.cgi?id=155669
<rdar://problem/25250721>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-03-18
Reviewed by Timothy Hatcher.

UserInterface/Views/ObjectTreeView.css:

(.object-tree):
(.object-tree .object-tree): Deleted.
Make object tree's inline-block again.

UserInterface/Views/ConsoleMessageView.css:

(.console-top-level-message .object-tree):
(.console-top-level-message .object-tree .object-tree):
Since the Console is the only place that requires a non-inline-block
object-tree, and only at the top level, have the console override
the styles of object trees as it needs.

6:31 PM Changeset in webkit [198460] by commit-queue@webkit.org

5 edits in trunk

Update AutoFill button in input fields.
https://bugs.webkit.org/show_bug.cgi?id=155619.
rdar://problem/24486939.

Patch by Zhuo Li <zachli@apple.com> on 2016-03-18
Reviewed by Daniel Bates.

Source/WebCore:

css/html.css:

(input::-webkit-contacts-auto-fill-button):
Use the new AutoFill button.

LayoutTests:

fast/forms/auto-fill-button/input-contacts-auto-fill-button-expected.txt:

Update the test results.

platform/ios-simulator/fast/forms/auto-fill-button/input-contacts-auto-fill-button-expected.txt:

Ditto.

5:55 PM Changeset in webkit [198459] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Uncaught Exception: TypeError: undefined is not an object (evaluating 'this._treeOutlineDataGridSynchronizer.treeElementForDataGridNode')
https://bugs.webkit.org/show_bug.cgi?id=155671
<rdar://problem/25249401>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-03-18
Reviewed by Timothy Hatcher.

UserInterface/Views/TimelineDataGrid.js:

(WebInspector.TimelineDataGrid.prototype._sort):

5:42 PM Changeset in webkit [198458] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

[JSC] Limit DFG's Validate symbols to its compilation unit
https://bugs.webkit.org/show_bug.cgi?id=155670

Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-03-18
Reviewed by Filip Pizlo.

dfg/DFGValidate.cpp:

5:05 PM Changeset in webkit [198457] by achristensen@apple.com

13 edits in trunk/Source

Give NSURLSessionConfiguration information about parent process
https://bugs.webkit.org/show_bug.cgi?id=155661
Source/WebCore:

Reviewed by Anders Carlsson.

platform/spi/cf/CFNetworkSPI.h:

Add newly-used SPI declarations.

Source/WebKit2:

rdar://problem/25225850

Reviewed by Anders Carlsson.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):

NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkSession.h:

(WebKit::NetworkSession::sessionID):

NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::partitionName):
(WebKit::NetworkProcess::sourceApplicationAuditData):
(WebKit::NetworkProcess::cfURLCacheOrigins):

NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::globalCustomProtocolManager):
(WebKit::globalSourceApplicationAuditTokenData):
(WebKit::NetworkSession::setCustomProtocolManager):
(WebKit::NetworkSession::setSourceApplicationAuditTokenData):
(WebKit::NetworkSession::defaultSession):
(WebKit::NetworkSession::NetworkSession):
Tell the NSURLSessionConfiguration what the source application bundle identifier
and audit token data are so we can correctly keep track of which application is using data.
This also gives CFNetwork enough information to determine if the application is allowed to
use cell data in Settings, so it seems like we do not need to explicitly set allowsCellularAccess.

NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::sourceApplicationAuditData):
(WebKit::RemoteNetworkingContext::sourceApplicationIdentifier):

WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::WebFrameNetworkingContext::sourceApplicationAuditData):
(WebKit::WebFrameNetworkingContext::sourceApplicationIdentifier):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

WebProcess/WebProcess.h:
WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformTerminate):
(WebKit::WebProcess::sourceApplicationAuditData):
(WebKit::WebProcess::initializeSandbox):
I moved the calls to getAuditToken from RemoteNetworkingContext.mm and WebFrameNetworkingContext.mm
to NetworkProcessCocoa.mm and WebProcessCocoa.mm, respectively, to share with NetworkSession code,
which does not use NetworkingContexts.

5:04 PM Changeset in webkit [198456] by Simon Fraser

2 edits in trunk/Source/WebKit2

Build fix after r198455.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::layerTreeCommitComplete):

5:00 PM Changeset in webkit [198455] by Simon Fraser

16 edits
2 adds in trunk

Sideways-scrollable RTL document has wrong initial and reload offset in WKWebView
https://bugs.webkit.org/show_bug.cgi?id=155660
Source/WebCore:

rdar://problem/22212662

Reviewed by Tim Horton.

There were two problems with the scroll position of RTL documents on initial and reload
in WKWebView.

First, in the delegatesScrolling() code path, ScrollView::updateScrollbars() needs to
tell someone that the scroll origin changed, to trigger a scroll to the page origin.

Secondly, WKWebView had scrollPosition/scrollOffset confusion in various places.

Test: fast/scrolling/rtl-initial-scroll-position.html

platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars):

Source/WebKit2:

Reviewed by Tim Horton.

There were two problems with the scroll position of RTL documents on initial and reload
in WKWebView.

First, in the delegatesScrolling() code path, ScrollView::updateScrollbars() needs to
tell someone that the scroll origin changed, to trigger a scroll to the page origin.

Secondly, WKWebView had scrollPosition/scrollOffset confusion in various places. In
the restorePageState() code path, WebCore passes an exposedRect; this patch makes
it explicit that it's an exposedContentRect, and passes scrollOrigin so that it can
be mapped into scrollOffset-relative coordinates that the UIScrollView wants.

When reloading an RTL page, there was an additional issue; restorePageState()
restored the exposedRect, but then we'd see the origin change as a programmatic scroll
to 0,0, clobbering the exposedRect. Fix by using a "_commitDidRestoreExposedRect" flag
on the WKWebView that is used to ignore the programmatic scroll in that case.

Ideally these changes would fix fast/scrolling/scroll-position-on-reload-rtl.html, but the
test still fails because of timing differences between OS X and iOS.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLayerTree:]):
(-[WKWebView _layerTreeCommitComplete]):
(-[WKWebView _restorePageStateToExposedRect:scrollOrigin:scale:]):
(-[WKWebView _scrollToContentScrollPosition:scrollOrigin:]):
(-[WKWebView _restorePageStateToExposedRect:scale:]): Deleted.
(-[WKWebView _scrollToContentOffset:scrollOrigin:]): Deleted.

UIProcess/API/Cocoa/WKWebViewInternal.h:
UIProcess/PageClient.h:
UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
UIProcess/ios/PageClientImplIOS.h:
UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::requestScroll):
(WebKit::PageClientImpl::layerTreeCommitComplete):
(WebKit::PageClientImpl::restorePageState):

UIProcess/ios/WKContentView.h:
UIProcess/ios/WKContentView.mm:

(-[WKContentView _layerTreeCommitComplete]):

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::layerTreeCommitComplete):
(WebKit::WebPageProxy::restorePageState):

UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::restorePageState):

LayoutTests:

Reviewed by Tim Horton.

Test for initial scroll position in an RTL page.

fast/scrolling/rtl-initial-scroll-position-expected.html: Added.
fast/scrolling/rtl-initial-scroll-position.html: Added.

4:59 PM Changeset in webkit [198454] by Ryan Haddad

3 edits in trunk/Source/WebCore

Unreviewed, rolling out r198443.

This change caused API test failures on El Capitan

Reverted changeset:

"CRASH in WebCore::MediaResourceLoader::requestResource + 698"
https://bugs.webkit.org/show_bug.cgi?id=155651
http://trac.webkit.org/changeset/198443

4:53 PM Changeset in webkit [198453] by beidson@apple.com

2 edits in trunk/Source/WebKit2

NSURLSession: Set download resume data when a download fails due to an error.
https://bugs.webkit.org/show_bug.cgi?id=155665

Reviewed by Alex Christensen.

NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:didCompleteWithError:]): Save the resume data from the

NSError userInfo if it exists.

4:50 PM Changeset in webkit [198452] by commit-queue@webkit.org

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Fix ObjectTree Map styling, key/value look cramped
https://bugs.webkit.org/show_bug.cgi?id=155668

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-03-18
Reviewed by Timothy Hatcher.

UserInterface/Views/ObjectTreeArrayIndexTreeElement.css:

(.tree-outline .item.object-tree-array-index):

UserInterface/Views/ObjectTreeMapEntryTreeElement.css:

(.tree-outline .item.object-tree-map-entry):
When creating generic tree outline styles generic object tree
styles were getting overriden by generic tree outline styles
with higher specificity.

4:45 PM Changeset in webkit [198451] by Darin Adler

3 edits
2 adds in trunk

ASSERTION FAILED: m_isValid == valid() in WebCore::HTMLFormControlElement::isValidFormControlElement
https://bugs.webkit.org/show_bug.cgi?id=139481

Reviewed by Daniel Bates.

Source/WebCore:

Test: fast/forms/validity-assertion-inserting-into-datalist.html

html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::insertedInto): Set the flags that will cause
"will validate" to be recomputed *before* calling willValidate().

LayoutTests:

fast/forms/validity-assertion-inserting-into-datalist-expected.txt: Added.
fast/forms/validity-assertion-inserting-into-datalist.html: Added.

4:23 PM Changeset in webkit [198450] by Chris Dumez

7 edits
6 adds in trunk

Speculative revalidation requests do not have their HTTP user-agent set
https://bugs.webkit.org/show_bug.cgi?id=155620
<rdar://problem/24657567>

Reviewed by Brady Eidson.

Source/WebCore:

Export a couple of symbols so they can be used from WebKit2.

Test: http/tests/cache/disk-cache/speculative-validation/validation-request.html

platform/network/ResourceRequestBase.h:

Source/WebKit2:

Speculative revalidation requests do not have their HTTP user-agent set
which could lead to different content getting returned by the server.

To address the problem, we save the original request's 'user-agent' in
the disk cache and re-use it later on for speculative validation
requests.

NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:

(WebKit::NetworkCache::constructRevalidationRequest):
(WebKit::NetworkCache::SpeculativeLoadManager::revalidateEntry):
(WebKit::NetworkCache::SpeculativeLoadManager::preloadEntry):

NetworkProcess/cache/NetworkCacheSubresourcesEntry.cpp:

(WebKit::NetworkCache::SubresourceInfo::encode):
(WebKit::NetworkCache::SubresourceInfo::decode):
(WebKit::NetworkCache::SubresourceInfo::SubresourceInfo):
(WebKit::NetworkCache::SubresourceInfo::operator=):
(WebKit::NetworkCache::SubresourcesEntry::SubresourcesEntry):
(WebKit::NetworkCache::SubresourcesEntry::updateSubresourceLoads):
(WebKit::NetworkCache::SubresourcesEntry::decodeStorageRecord): Deleted.

NetworkProcess/cache/NetworkCacheSubresourcesEntry.h:

(WebKit::NetworkCache::SubresourceInfo::SubresourceInfo):

LayoutTests:

Add layout test coverage.

http/tests/cache/disk-cache/speculative-validation/resources/request-headers-script.php: Added.
http/tests/cache/disk-cache/speculative-validation/resources/validation-request-frame.php: Added.
http/tests/cache/disk-cache/speculative-validation/validation-request-expected.txt: Added.
http/tests/cache/disk-cache/speculative-validation/validation-request.html: Added.

4:22 PM Changeset in webkit [198449] by matthew_hanson@apple.com

1 copy in tags/Safari-601.1.46.121

New Tag.

4:22 PM Changeset in webkit [198448] by matthew_hanson@apple.com

1 copy in tags/Safari-601.6.11

New Tag.

4:14 PM Changeset in webkit [198447] by mark.lam@apple.com

28 edits in trunk

ES6 spec requires that RegExpPrototype not be a RegExp object.
https://bugs.webkit.org/show_bug.cgi?id=155654

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

The ES6 spec states that RegExp.prototype should not be an instance of RegExp:
https://tc39.github.io/ecma262/#sec-properties-of-the-regexp-prototype-object

"The RegExp prototype object is an ordinary object. It is not a RegExp instance
and does not have a RegExpMatcher internal slot or any of the other internal
slots of RegExp instance objects."

This patch changes RegExpPrototype to conform to the above specifications.

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::RegExpConstructor):
(JSC::RegExpConstructor::finishCreation):

runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::RegExpPrototype):
(JSC::RegExpPrototype::finishCreation):
(JSC::RegExpPrototype::getOwnPropertySlot):
(JSC::RegExpPrototype::visitChildren):
(JSC::regExpProtoFuncTest):

runtime/RegExpPrototype.h:

(JSC::RegExpPrototype::create):
(JSC::RegExpPrototype::createStructure):
(JSC::RegExpPrototype::emptyRegExp):

tests/es6.yaml:
This patch makes the es6/miscellaneous_built-in_prototypes_are_not_instances.js test now pass. However, the kangax version of this test still fails because it also checks Error objects (which will be fixed in a subsequent patch).

tests/mozilla/ecma_2/shell.js:

(stringify):
(test):
(getFailedCases):
(err):

tests/stress/static-getter-in-names.js:

(shouldBe):

LayoutTests:

Rebase all the test results.

fast/regex/script-tests/toString.js:
fast/regex/toString-expected.txt:
ietestcenter/Javascript/15.10.6-expected.txt:
ietestcenter/Javascript/15.10.7.1-1-expected.txt:
ietestcenter/Javascript/15.10.7.2-1-expected.txt:
ietestcenter/Javascript/15.10.7.3-1-expected.txt:
ietestcenter/Javascript/15.10.7.4-1-expected.txt:
ietestcenter/Javascript/15.10.7.5-1-expected.txt:
ietestcenter/Javascript/TestCases/15.10.6.js: