Context Navigation

← Previous Period
Next Period →

Timeline

Mar 26, 2016:

8:07 PM Changeset in webkit [198724] by mitz@apple.com

2 edits in trunk/Source/WebKit2

Tried to fix the build.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _takeViewSnapshot]):

8:06 PM FeatureFlags edited by Dr Alex Gouaillard

(diff)

7:13 PM Changeset in webkit [198723] by mitz@apple.com

2 edits in trunk/Source/WebKit2

Tried to fix the build.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _takeViewSnapshot]):

6:05 PM Changeset in webkit [198722] by achristensen@apple.com

2 edits in trunk/Source/WebCore

Mac CMake build fix.

PlatformMac.cmake:

Link with AVFoundation libraries.

5:59 PM Changeset in webkit [198721] by dino@apple.com

1 edit in trunk/Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm

Fix the build by removing the #endif I left in on my last attempt.

UIProcess/API/Cocoa/WKWebView.mm:

5:44 PM Changeset in webkit [198720] by dino@apple.com

2 edits in trunk/Source/WebKit2

Fix build after my most recent commit.

UIProcess/API/Cocoa/WKWebView.mm:

(WebKit::bufferFormat): Delete the WebKitAdditions include.

4:50 PM Changeset in webkit [198719] by dino@apple.com

10 edits in trunk/Source

Move extended color detection into Open Source
https://bugs.webkit.org/show_bug.cgi?id=155909
<rdar://problem/25369754>

Reviewed by Anders Carlsson.

The code for detecting extended color displays
was hidden while the iPad Pro 9.7" was in development.
Now it is public, move the detection to Open Source.

While doing this, add a new method to PlatformScreen
so that we have a more obvious way to detect such
displays.

Source/WebCore:

platform/PlatformScreen.h: Add screenSupportsExtendedColor.

platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(PlatformCALayerCocoa::commonInit): Set the backing
store format to the RGBA10XR if we're on an extended
display.

platform/ios/LegacyTileGridTile.mm:

(WebCore::LegacyTileGridTile::LegacyTileGridTile): Ditto.
(WebCore::setBackingStoreFormat): Deleted. Now set directly
in the constructor.

platform/ios/PlatformScreenIOS.mm:

(WebCore::screenDepthPerComponent): Cleanup.
(WebCore::screenSupportsExtendedColor): Implement the
iOS version of this using MobileGestalt.

platform/mac/PlatformScreenMac.mm:

(WebCore::displayFromWidget): Whitespace cleanup.
(WebCore::screenForWidget):
(WebCore::screenForWindow):
(WebCore::screenSupportsExtendedColor): Default implementation
returns false for all screens at the moment.

platform/spi/cocoa/QuartzCoreSPI.h: New constant.
platform/spi/ios/MobileGestaltSPI.h: Ditto.

Source/WebKit2:

Shared/mac/RemoteLayerBackingStore.mm:

(WebKit::bufferFormat): No need to use WebKitAdditions any
more.

1:07 PM Changeset in webkit [198718] by ggaren@apple.com

7 edits in trunk/Source/bmalloc

2016-03-26 Geoffrey Garen <ggaren@apple.com>

Unreviewed, rolling out r198702, r198704.

Caused a memory regression on PLUM.

Reverted changeset:

bmalloc: fix an ASSERT on iOS
https://bugs.webkit.org/show_bug.cgi?id=155911
http://trac.webkit.org/changeset/198704

bmalloc: support physical page sizes that don't match the virtual page size
https://bugs.webkit.org/show_bug.cgi?id=155898
http://trac.webkit.org/changeset/198702

11:37 AM Changeset in webkit [198717] by mmaxfield@apple.com

3 edits in trunk/Source/WebCore

[OS X] Layout sometimes flakily assumes overlay scrollbars when clicky-scroll-wheel-mouse is attached and system preference detects scrollbar mode
https://bugs.webkit.org/show_bug.cgi?id=155912

Reviewed by Simon Fraser.

When the system preference is set to detect the scrollbar type (overlay or
always-on, and a clicky scroll wheel mouse is connected, AppKit
asynchronously tells all the NSScrollerImpPairs about the kind of scrollbar
it should be using. However, when this notification is delivered, it may
be in between FrameViews, which means we may not have any
NSScrollerImpPairs created to listen to the notification.

r198444 solved this by asking if we missed any update whenever we create
an NSScrollerImpPair. This works partially; however, there is a significant
amount of layout which occurs before we create the first ScrollAnimatorMac.
This layout will ask the ScrollbarThemeMac if overlay scrollbars are
enabled, and the results will be stale (because we haven't created any the
NSScrollerImpPairs yet).

Luckly, AppKit fires a notification when it discovers what kind of
scrollbars should be used. We can rely on this notification in the event
that we don't have any NSScrollerImpPairs created.

Covered (as best as possible) by existing RTL scrollbar tests. However,
the system preference that governs this is not currently testable.

platform/mac/ScrollbarThemeMac.mm:

(+[WebScrollbarPrefsObserver registerAsObserver]):

platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::ScrollAnimatorMac): Remove the old code.

5:53 AM Changeset in webkit [198716] by Gyuyoung Kim

2 edits in trunk/LayoutTests

Remove duplicated tests in EFL TextExpectations.

Unreviewed EFL gardening.

platform/efl/TestExpectations: Clean up duplicated pathes.

12:31 AM Changeset in webkit [198715] by mitz@apple.com

3 edits in trunk/Source/WebKit2

Treat SHA-1-signed certificates as insecure by default.

Reviewed by Sam Weinig.

UIProcess/API/APIPageConfiguration.h: Initialize m_treatsSHA1SignedCertificatesAsInsecure to true.
UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]): Initialize _treatsSHA1SignedCertificatesAsInsecure to YES.

12:08 AM Changeset in webkit [198714] by commit-queue@webkit.org

5 edits in trunk/LayoutTests

ES6 Class syntax. Invoking method of parent class in constructor before super() lead to crash
https://bugs.webkit.org/show_bug.cgi?id=152108

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-03-26
Reviewed by Ryosuke Niwa.

js/arrowfunction-superproperty-expected.txt:
js/script-tests/arrowfunction-superproperty.js:
js/script-tests/class-syntax-name.js:
js/script-tests/class-syntax-string-and-numeric-names.js:

Remove stale FIXMEs from LayoutTests where the bugs have been fixed.

Mar 25, 2016:

11:51 PM Changeset in webkit [198713] by commit-queue@webkit.org

4 edits in trunk/Source/JavaScriptCore

Misc. JavaScriptCore built-ins cleanups
https://bugs.webkit.org/show_bug.cgi?id=155920

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-03-25
Reviewed by Mark Lam.

builtins/RegExpPrototype.js:

(match):
No need for an else after an if that always returns.

builtins/TypedArrayConstructor.js:

(of):
Fix error message to use the correct function name.

(allocateInt8Array):
(allocateInt16Array):
(allocateInt32Array):
(allocateUint32Array):
(allocateUint16Array):
(allocateUint8Array):
(allocateUint8ClampedArray):
(allocateFloat32Array):
(allocateFloat64Array):
Cleanup style to be like all the other code.

tests/stress/typedarray-of.js:

Test the exception message.

10:36 PM Changeset in webkit [198712] by commit-queue@webkit.org

2 edits in trunk/WebKitLibraries

Web Inspector: make at the root should not create a WebKitLibraries/--lvm directory
https://bugs.webkit.org/show_bug.cgi?id=155918

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-03-25
Reviewed by Timothy Hatcher.

Makefile:

Remove no longer used --llvm option.

10:31 PM Changeset in webkit [198711] by commit-queue@webkit.org

5 edits
3 adds in trunk

Date.prototype.toLocaleDateString uses overridable Object.create
https://bugs.webkit.org/show_bug.cgi?id=155917

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-03-25
Reviewed by Mark Lam.

Source/JavaScriptCore:

builtins/DatePrototype.js:

(toLocaleString.toDateTimeOptionsAnyAll):
(toLocaleDateString.toDateTimeOptionsDateDate):
(toLocaleTimeString.toDateTimeOptionsTimeTime):
Switch from @Object.create to @Object.@create to guarentee we are
using the built-in create method and not user defined code.

runtime/CommonIdentifiers.h:
runtime/ObjectConstructor.cpp:

(JSC::ObjectConstructor::finishCreation):
Setup the @create private symbol.

LayoutTests:

js/regress-155917-expected.txt: Added.
js/regress-155917.html: Added.
js/script-tests/regress-155917.js: Added.

(Object.create):

9:37 PM Changeset in webkit [198710] by matthew_hanson@apple.com

5 edits in branches/safari-601-branch/Source

Versioning.

9:35 PM Changeset in webkit [198709] by matthew_hanson@apple.com

1 copy in tags/Safari-601.6.13

New Tag.

8:47 PM Changeset in webkit [198708] by commit-queue@webkit.org

4 edits in trunk/Source/JavaScriptCore

[JSC] Put the x86 Assembler on a binary diet
https://bugs.webkit.org/show_bug.cgi?id=155683

Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-03-25
Reviewed by Darin Adler.

The MacroAssemblers are heavily inlined. This is unfortunately
important for baseline JIT where many branches can be eliminated
at compile time.

This inlining causes a lot of binary bloat. The phases
lowering to ASM are massively large.

This patch improves the situation a bit for x86 through
many small improvements:

-Every instruction starts with ensureSpace(). The slow

path realloc the buffer.
From that slow path, only fastRealloc() was a function
call. What is around does not need to be fast, I moved
the whole grow() function out of line for those cases.

-When testing multiple registers for REX requirements,

we had something like this:

byteRegRequiresRex(reg) regRequiresRex(index)

byteRegRequiresRex(rm)
regRequiresRex(base)

Those were producing multiple test-and-branch. Those branches
are effectively random so we don't have to care about individual
branches being predictable.

The new code effectively does:

byteRegRequiresRex(reg | rm)
regRequiresRex(index | base)

-Change "ModRmMode" to have the value we can OR directly

to the generated ModRm.
This is important because some ModRM code is so large
that is goes out of line;

-Finally, a big change on how we write to the AssemblerBuffer.

Previously, instructions were written byte by byte into
the assembler buffer of the MacroAssembler.

The problem with that is the compiler cannot prove that
the buffer pointer and the AssemblerBuffer are not pointing
to the same memory.

Because of that, before any write, all the local register
were pushed back to the AssemblerBuffer memory, then everything
was read back after the write to compute the next write.

I attempted to use the "restrict" keyword and wrapper types
to help Clang with that but nothing worked.

The current solution is to keep a local copy of the index
and the buffer pointer in the scope of each instruction.
That is done by AssemblerBuffer::LocalWriter.

Since LocalWriter only exists locally, it stays in
register and we don't have all the memory churn between
each byte writing. This also allows clang to combine
obvious cases since there are no longer observable side
effects between bytes.

This patch reduces the binary size by 66k. It is a small
speed-up on Sunspider.

assembler/AssemblerBuffer.h:

(JSC::AssemblerBuffer::ensureSpace):
(JSC::AssemblerBuffer::LocalWriter::LocalWriter):
(JSC::AssemblerBuffer::LocalWriter::~LocalWriter):
(JSC::AssemblerBuffer::LocalWriter::putByteUnchecked):
(JSC::AssemblerBuffer::LocalWriter::putShortUnchecked):
(JSC::AssemblerBuffer::LocalWriter::putIntUnchecked):
(JSC::AssemblerBuffer::LocalWriter::putInt64Unchecked):
(JSC::AssemblerBuffer::LocalWriter::putIntegralUnchecked):
(JSC::AssemblerBuffer::putIntegral):
(JSC::AssemblerBuffer::outOfLineGrow):

assembler/MacroAssemblerX86Common.h:
assembler/X86Assembler.h:

(JSC::X86Assembler::X86InstructionFormatter::byteRegRequiresRex):
(JSC::X86Assembler::X86InstructionFormatter::regRequiresRex):
(JSC::X86Assembler::X86InstructionFormatter::LocalBufferWriter::LocalBufferWriter):
(JSC::X86Assembler::X86InstructionFormatter::LocalBufferWriter::emitRex):
(JSC::X86Assembler::X86InstructionFormatter::LocalBufferWriter::emitRexW):
(JSC::X86Assembler::X86InstructionFormatter::LocalBufferWriter::emitRexIf):
(JSC::X86Assembler::X86InstructionFormatter::LocalBufferWriter::emitRexIfNeeded):
(JSC::X86Assembler::X86InstructionFormatter::LocalBufferWriter::putModRm):
(JSC::X86Assembler::X86InstructionFormatter::LocalBufferWriter::putModRmSib):
(JSC::X86Assembler::X86InstructionFormatter::LocalBufferWriter::registerModRM):
(JSC::X86Assembler::X86InstructionFormatter::LocalBufferWriter::memoryModRM):
(JSC::X86Assembler::X86InstructionFormatter::oneByteOp): Deleted.
(JSC::X86Assembler::X86InstructionFormatter::oneByteOp_disp32): Deleted.
(JSC::X86Assembler::X86InstructionFormatter::oneByteOp_disp8): Deleted.
(JSC::X86Assembler::X86InstructionFormatter::twoByteOp): Deleted.
(JSC::X86Assembler::X86InstructionFormatter::threeByteOp): Deleted.
(JSC::X86Assembler::X86InstructionFormatter::oneByteOp64): Deleted.
(JSC::X86Assembler::X86InstructionFormatter::oneByteOp64_disp32): Deleted.
(JSC::X86Assembler::X86InstructionFormatter::oneByteOp64_disp8): Deleted.
(JSC::X86Assembler::X86InstructionFormatter::twoByteOp64): Deleted.
(JSC::X86Assembler::X86InstructionFormatter::oneByteOp8): Deleted.
(JSC::X86Assembler::X86InstructionFormatter::twoByteOp8): Deleted.
(JSC::X86Assembler::X86InstructionFormatter::emitRex): Deleted.
(JSC::X86Assembler::X86InstructionFormatter::emitRexW): Deleted.
(JSC::X86Assembler::X86InstructionFormatter::emitRexIf): Deleted.
(JSC::X86Assembler::X86InstructionFormatter::emitRexIfNeeded): Deleted.
(JSC::X86Assembler::X86InstructionFormatter::putModRm): Deleted.
(JSC::X86Assembler::X86InstructionFormatter::putModRmSib): Deleted.
(JSC::X86Assembler::X86InstructionFormatter::registerModRM): Deleted.
(JSC::X86Assembler::X86InstructionFormatter::memoryModRM): Deleted.

8:45 PM Changeset in webkit [198707] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Sometimes clearing focused nodes in ProfileView leaves a dangling call stack that can never be removed
https://bugs.webkit.org/show_bug.cgi?id=155915

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-03-25
Reviewed by Timothy Hatcher.

UserInterface/Views/ProfileDataGridTree.js:

(WebInspector.ProfileDataGridTree.prototype.addFocusNode):
(WebInspector.ProfileDataGridTree.prototype.rollbackFocusNode):
(WebInspector.ProfileDataGridTree.prototype.clearFocusNodes):
(WebInspector.ProfileDataGridTree.prototype._focusChanged):
(WebInspector.ProfileDataGridTree.prototype._saveFocusedNodeOriginalParent):
(WebInspector.ProfileDataGridTree.prototype._restoreFocusedNodeToOriginalParent):
Be a little more explicit about saving and resotring nodes.
When restoring, work around a DataGrid issue by temporarily
collapsing and expanding the part of the node we are being
reattached to. This is a cheap workaround for an otherwise
complex DataGrid / DataGridTree issue.

7:09 PM Changeset in webkit [198706] by Dewei Zhu

2 edits in trunk/Tools

Dromaeo patch used by run-benchmark should not include an invalid address.
https://bugs.webkit.org/show_bug.cgi?id=155910

Reviewed by Ryosuke Niwa.

Should not use invalid 'http://127.0.0.1/Icons/w3c_home' in the patched version of test.

Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch:

6:12 PM Changeset in webkit [198705] by sbarati@apple.com

2 edits in trunk/Source/JavaScriptCore

RegExp.prototype.test should be an intrinsic again
https://bugs.webkit.org/show_bug.cgi?id=155861

Reviewed by Yusuke Suzuki.

runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::finishCreation):

5:50 PM Changeset in webkit [198704] by ggaren@apple.com

2 edits in trunk/Source/bmalloc

bmalloc: fix an ASSERT on iOS
https://bugs.webkit.org/show_bug.cgi?id=155911

Reviewed by Gavin Barraclough.

bmalloc/VMAllocate.h:

(bmalloc::vmValidatePhysical): Call through to vmValidatePhysical because
the vmValidate function validates virtual sizes rather than physical
sizes.

5:21 PM Changeset in webkit [198703] by jer.noble@apple.com

3 edits
8 adds in trunk

[Mac] Audio tracks in alternate groups are not represented correctly as AudioTracks
https://bugs.webkit.org/show_bug.cgi?id=155891
<rdar://problem/24841372>

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/video-track-alternate-groups.html

Previously, we created an AudioTrack for every AVPlayerItemTrack, and additionally, a
AudioTrack for every AVMediaSelectionOption that did not have an associated AVAssetTrack.
This caused a number of issues with various types of media, including media with fallback
tracks.

Now, we will create an AudioTrack for every AVMediaSelectionOption, and only create an
AudioTrack for every AVPlayerItem track if no AVMediaSelectionGroups (and thus no
AVMediaSeletionOptions) exist.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::determineChangedTracksFromNewTracksAndOldItems):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateAudioTracks):

LayoutTests:

media/content/audio-tracks-alternate-group-with-fallback.mp4: Added.
media/content/audio-tracks-no-alternate-group.mp4: Added.
media/content/audio-tracks-some-in-alternate-group.mp4: Added.
media/track/video-track-alternate-groups-expected.txt: Added.
media/track/video-track-alternate-groups.html: Added.
platform/mac-yosemite/media/track/video-track-alternate-groups-expected.txt: Added.

4:56 PM WebKitGTK/2.12.x edited by Michael Catanzaro

(diff)

4:46 PM Changeset in webkit [198702] by ggaren@apple.com

7 edits in trunk/Source/bmalloc

bmalloc: support physical page sizes that don't match the virtual page size
https://bugs.webkit.org/show_bug.cgi?id=155898

Reviewed by Gavin Barraclough.

This is a memory savings on iOS devices where the virtual page size
is 16kB but the physical page size is 4kB.

bmalloc/Chunk.h:

(bmalloc::Chunk::Chunk): smallPageSize is now unrelated to the OS's
page size -- it just reflects the optimal unit of memory to recycle
between small objects.

We only need to round up to largeAlignment because small objects allocate
as subsets of large objects now.

(bmalloc::Chunk::page):
(bmalloc::Object::pageBegin):
(bmalloc::Object::line): Adopt smallPageSize.

bmalloc/Heap.cpp:

(bmalloc::Heap::initializeLineMetadata):
(bmalloc::Heap::allocateSmallPage):
(bmalloc::Heap::allocateLarge): Adopt smallPageSize.

(bmalloc::Heap::splitAndAllocate):
(bmalloc::Heap::tryAllocateXLarge):
(bmalloc::Heap::shrinkXLarge): Adopt vmPageSizePhysical(). We want the
physical page size because that's the unit at which the hardware MMU
will recycle memory.

bmalloc/Sizes.h: Adopt smallPageSize.

bmalloc/VMAllocate.h:

(bmalloc::vmPageSizePhysical):
(bmalloc::vmPageSize): Distinguish between page size, which is the virtual
memory page size advertised by the OS, and physical page size, which the
true hardware page size.

(bmalloc::vmSize):
(bmalloc::vmValidate):
(bmalloc::vmValidatePhysical):
(bmalloc::tryVMAllocate):
(bmalloc::vmDeallocatePhysicalPages):
(bmalloc::vmAllocatePhysicalPages):
(bmalloc::vmDeallocatePhysicalPagesSloppy):
(bmalloc::vmAllocatePhysicalPagesSloppy): Adopt vmPageSize() and
vmPageSizePhyiscal().

bmalloc/Vector.h:

(bmalloc::Vector::initialCapacity):
(bmalloc::Vector<T>::shrink):
(bmalloc::Vector<T>::shrinkCapacity):
(bmalloc::Vector<T>::growCapacity): Adopt vmPageSize(). We'd prefer to
use vmPageSizePhysical() but mmap() doesn't support it.

bmalloc/XLargeMap.cpp: #include.

4:45 PM Changeset in webkit [198701] by Alan Bujtas

7 edits in trunk/Source/WebCore

RenderImage::repaintOrMarkForLayout fails when the renderer is detached.
https://bugs.webkit.org/show_bug.cgi?id=155885
<rdar://problem/25359164>

Reviewed by Simon Fraser.

Making containingBlockFor* functions standalone ensures that we don't
call them on an invalid object.

Covered by existing tests.

dom/Element.cpp:

(WebCore::layoutOverflowRectContainsAllDescendants):

rendering/LogicalSelectionOffsetCaches.h:

(WebCore::LogicalSelectionOffsetCaches::LogicalSelectionOffsetCaches):

rendering/RenderElement.cpp:

(WebCore::containingBlockForFixedPosition):
(WebCore::containingBlockForAbsolutePosition):
(WebCore::containingBlockForObjectInFlow):
(WebCore::RenderElement::containingBlockForFixedPosition): Deleted.
(WebCore::RenderElement::containingBlockForAbsolutePosition): Deleted.
(WebCore::isNonRenderBlockInline): Deleted.
(WebCore::RenderElement::containingBlockForObjectInFlow): Deleted.

rendering/RenderElement.h:
rendering/RenderInline.cpp:

(WebCore::RenderInline::styleWillChange):

rendering/RenderObject.cpp:

(WebCore::RenderObject::containingBlock):

4:44 PM Changeset in webkit [198700] by ggaren@apple.com

15 edits
1 copy
2 deletes in trunk/Source/bmalloc

2016-03-25 Geoffrey Garen <ggaren@apple.com>

Unreviewed, rolling in r198679.

r198679 was just a rename. The regression was caused by r198675 and then
fixed in r198693.

Restored changeset:

"bmalloc: Renamed LargeChunk => Chunk"
https://bugs.webkit.org/show_bug.cgi?id=155894
http://trac.webkit.org/changeset/198679

4:27 PM Changeset in webkit [198699] by bshafiei@apple.com

7 edits in tags/Safari-602.1.25.0.1

Merged r198698. rdar://problem/25352879

4:23 PM Changeset in webkit [198698] by mark.lam@apple.com

7 edits in trunk

ES6's throwing of TypeErrors on access of RegExp.prototype flag properties breaks websites.
https://bugs.webkit.org/show_bug.cgi?id=155904

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

There exists a JS library XRegExp (see http://xregexp.com) that extends the regexp
implementation. XRegExp does feature testing by comparing RegExp.prototype.sticky
to undefined. See:

Example 1. https://github.com/slevithan/xregexp/blob/28a2b033c5951477bed8c7c867ddf7e89c431cd4/tests/perf/index.html

...
} else if (knownVersion[version]) {

Hack around ES6 incompatibility in XRegExp versions prior to 3.0.0
if (parseInt(version, 10) < 3) {

delete RegExp.prototype.sticky;

}
...

Example 2. https://github.com/slevithan/xregexp/blob/d0e665d4068cec4d15919215b098b2373f1f12e9/tests/perf/versions/xregexp-all-v2.0.0.js

...
Check for flag y support (Firefox 3+)

hasNativeY = RegExp.prototype.sticky !== undef,

...

The ES6 spec states that we should throw a TypeError here because RegExp.prototype
is not a RegExp object, and the sticky getter is only allowed to be called on
RegExp objects. See https://tc39.github.io/ecma262/2016/#sec-get-regexp.prototype.sticky.
As a result, websites that uses XRegExp can break (e.g. some Atlassian tools).

As a workaround, we'll return undefined instead of throwing on access of these
flag properties that may be used for feature testing.

runtime/RegExpPrototype.cpp:

(JSC::regExpProtoGetterGlobal):
(JSC::regExpProtoGetterIgnoreCase):
(JSC::regExpProtoGetterMultiline):
(JSC::regExpProtoGetterSticky):
(JSC::regExpProtoGetterUnicode):

LayoutTests:

ietestcenter/Javascript/TestCases/15.10.7.2-1.js:

(ES5Harness.registerTest.test):

ietestcenter/Javascript/TestCases/15.10.7.3-1.js:

(ES5Harness.registerTest.test):

ietestcenter/Javascript/TestCases/15.10.7.4-1.js:

(ES5Harness.registerTest.test):

updated these tests to not expect a TypeError due to the workaround.

js/pic/cached-named-property-getter.html:
updated this test to use the source property (which still throws a TypeError) instead of the ignoreCase property which no longer does.

4:15 PM Changeset in webkit [198697] by dino@apple.com

6 edits in trunk/Source

Remove use of extern "C" to include QuartzCore files
https://bugs.webkit.org/show_bug.cgi?id=155905
Source/WebCore:

<rdar://problem/25364798>

Reviewed by Anders Carlson.

We can avoid having to wrap constants in extern "C", since they
are mangled the same in both C and C++.

platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm: Now that

QuartzCoreSPI.h has CABackdropLayer, remove the duplicate entry.

platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm: Ditto.
platform/spi/cocoa/QuartzCoreSPI.h: Include the framework private

file. Repace EXTERN_C with "extern".

Source/WebKit2:

Reviewed by Anders Carlson.

We can avoid having to wrap constants in extern "C", since they
are mangled the same in both C and C++.

UIProcess/mac/RemoteLayerTreeHost.mm: Remove the

mention of CABackdropLayer.

4:06 PM Changeset in webkit [198696] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

Add a compile time flag for using QTKit
https://bugs.webkit.org/show_bug.cgi?id=155868

Patch by Alex Christensen <achristensen@webkit.org> on 2016-03-25
Reviewed by Daniel Bates.

platform/graphics/MediaPlayer.cpp:

(WebCore::buildMediaEnginesVector):

platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
platform/graphics/mac/MediaTimeQTKit.h:
platform/graphics/mac/MediaTimeQTKit.mm:
platform/mac/WebVideoFullscreenController.mm:

(SOFT_LINK_CLASS):
(-[WebVideoFullscreenController setVideoElement:]):
(-[WebVideoFullscreenController updatePowerAssertions]):

4:04 PM Changeset in webkit [198695] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

[JSC] fix divide-by-zero in String.prototype.padStart/padEnd
https://bugs.webkit.org/show_bug.cgi?id=155903

Patch by Caitlin Potter <caitp@igalia.com> on 2016-03-25
Reviewed by Filip Pizlo.

runtime/StringPrototype.cpp:

(JSC::padString):

3:55 PM Changeset in webkit [198694] by benjamin@webkit.org

2 edits in trunk/Source/JavaScriptCore

[JSC] materialize-past-butterfly-allocation.js time out in debug

tests/stress/materialize-past-butterfly-allocation.js:

The test times out on the debug bots. We suspect there is nothing
wrong, just overkill loops.

3:04 PM Changeset in webkit [198693] by ggaren@apple.com

2 edits in trunk/Source/bmalloc

2016-03-25 Geoffrey Garen <ggaren@apple.com>

Unreviewed, try to fix a crash seen on the bots.

bmalloc/Allocator.cpp: (bmalloc::Allocator::reallocate): We have to take the lock even if we're only reading our own data becuse LargeObject contains validation code that will read our neighbors' data as well.

3:01 PM Changeset in webkit [198692] by Beth Dakin

7 edits in trunk/Source/WebCore

Autoscrolling from a drag selection does not work in full screen, or when the
window is against the screen edge
https://bugs.webkit.org/show_bug.cgi?id=155858
-and corresponding-
rdar://problem/9338465

Reviewed by Simon Fraser.

WebKit2 has always had this bug. Since WebKit1 scrolling in handled largely
by AppKit, we did not have this bug because AppKit adjusts the autoscroll
amount whenever the window is at the edge of the screen and the user is
trying to autoscroll in that direction. This patch employs the same technique
in WebCore.

Instead of using EventHandler::lastKnownMousePosition() as the autoscroll
amount, use EventHandler::effectiveMousePositionForSelectionAutoscroll()
which will adjust the lastKnownMousePosition if the window is at the edge of
the screen.

page/AutoscrollController.cpp:

(WebCore::AutoscrollController::autoscrollTimerFired):

For most ports, effectiveMousePositionForSelectionAutoscroll() will just
return m_lastKnownMousePosition. We override it in EventHandlerMac to return
an adjusted amount.

page/EventHandler.cpp:

(WebCore::EventHandler::effectiveMousePositionForSelectionAutoscroll):

page/EventHandler.h:
page/mac/EventHandlerMac.mm:

(WebCore::autoscrollAdjustmentFactorForScreenBoundaries):
(WebCore::EventHandler::effectiveMousePositionForSelectionAutoscroll):

Make screenForDisplayID available as on PlatformScreen.h instead of just
being a static function in the implementation file.

platform/PlatformScreen.h:
platform/mac/PlatformScreenMac.mm:

(WebCore::screenForDisplayID):

2:55 PM Changeset in webkit [198691] by rniwa@webkit.org

11 edits
2 adds
2 deletes in trunk/Websites/perf.webkit.org

Migrate admin-regenerate-manifest.js to mocha.js and test v3 UI code
https://bugs.webkit.org/show_bug.cgi?id=155863

Reviewed by Joseph Pecoraro.

Replaced admin-regenerate-manifest.js by a new mocha.js tests using the new server testing capability
added in r198642 and tested v3 UI code (parsing manifest.json and creating models). Also removed
/admin/regenerate-manifest since it has been superseded by /api/manifest.

This patch also extracts manifest.js out of main.js so that it could be used and tested without the
DOM support in node.

public/admin/regenerate-manifest.php: Deleted.
public/include/db.php: Fixed a regression from r198642 since CONFIG_DIR now doesn't end with

a trailing backslash.

public/include/manifest.php:

(ManifestGenerator::bug_trackers): Avoid a warning message when there are no repositories.

public/v3/index.html:
public/v3/main.js:

(main):

public/v3/models/bug-tracker.js:

(BugTracker.prototype.newBugUrl): Added.
(BugTracker.prototype.repositories): Added.

public/v3/models/manifest.js: Added. Extracted from main.js.

(Manifest.fetch): Moved from main.js' fetchManifest.
(Manifest._didFetchManifest): Moved from main.js' didFetchManifest.

public/v3/models/platform.js:

(Platform.prototype.hasTest): Fixed the bug that "test" here was shadowing the function parameter of
the same name. This is tested by the newly added test cases.

server-tests/api-build-requests-tests.js:
server-tests/api-manifest.js: Added. Migrated test cases from tests/admin-regenerate-manifest.js

with additional assertions for v3 UI model objects.

server-tests/resources/test-server.js:

(TestServer.prototype.start):
(TestServer.prototype.testConfig): Renamed from _constructTestConfig now that this is a public API.
Also no longer takes dataDirectory as an argument since it's always the same.
(TestServer.prototype._ensureDataDirectory): Fixed a bug that we weren't making public/data.
(TestServer.prototype.cleanDataDirectory): Added. Remove all files inside public/data between tests.
(TestServer.prototype.inject): Added. Calls before, etc... because always calling before had an
unintended side effect of slowing down unit tests even through they don't need Postgres or Apache.

tests/admin-regenerate-manifest.js: Removed.
tools/js/database.js:
tools/js/v3-models.js:

1:57 PM Changeset in webkit [198690] by Matt Baker

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Clicking a result in Quick Open dialog dismisses the dialog, does nothing
https://bugs.webkit.org/show_bug.cgi?id=155892
<rdar://problem/25361220>

Reviewed by Timothy Hatcher.

UserInterface/Views/OpenResourceDialog.js:

(WebInspector.OpenResourceDialog):
Allow repeat selection so clicking a selected element makes a selection
and dismisses the dialog.

(WebInspector.OpenResourceDialog.prototype._populateResourceTreeOutline):
Suppress select and deselect. Only user clicks should cause a selection event.

(WebInspector.OpenResourceDialog.prototype._handleBlurEvent):
Prevent the dialog from being dismissed before tree item selection occurs.

(WebInspector.OpenResourceDialog.prototype._treeSelectionDidChange):
Set the represented object (dialog result) and dismiss.

1:52 PM Changeset in webkit [198689] by Ryan Haddad

2 edits in trunk/LayoutTests

Marking compositing/repaint/become-overlay-composited-layer.html as flaky on ios-sim-wk2
https://bugs.webkit.org/show_bug.cgi?id=155737

Unreviewed test gardening.

platform/ios-simulator-wk2/TestExpectations:

1:45 PM Changeset in webkit [198688] by commit-queue@webkit.org

4 edits in trunk/Source/WebInspectorUI

Unreviewed, rolling out r198619.
https://bugs.webkit.org/show_bug.cgi?id=155902

Switching to Console tab sometimes results in blank tab.
(Requested by JoePeck on #webkit).

Reverted changeset:

"Web Inspector: Large repaints while typing in the console
tab"
https://bugs.webkit.org/show_bug.cgi?id=155627
http://trac.webkit.org/changeset/198619

1:37 PM Changeset in webkit [198687] by beidson@apple.com

5 edits
1 add
4 deletes in trunk

Soften push/replaceState frequency restrictions.
<rdar://problem/25228439> and https://bugs.webkit.org/show_bug.cgi?id=155901
.:

Rubber-stamped by Timothy Hatcher.

ManualTests/state-objects-time-limit.html: Added.

Source/WebCore:

Rubber-stamped by Timothy Hatcher.

Covered by existing LayoutTests and a new Manual Test.

page/History.cpp:

(WebCore::History::stateObjectAdded): Allow 100 state object operations every 30 seconds.

page/History.h:

LayoutTests:

Rubber-stamped by Timothy Hatcher.

fast/loader/stateobjects/pushstate-frequency-with-user-gesture-expected.txt: Removed.
fast/loader/stateobjects/pushstate-frequency-with-user-gesture.html: Removed.
fast/loader/stateobjects/replacestate-frequency-with-user-gesture-expected.txt: Removed.
fast/loader/stateobjects/replacestate-frequency-with-user-gesture.html: Removed.

1:30 PM Changeset in webkit [198686] by Ryan Haddad

15 edits
1 move
1 add in trunk/Source/bmalloc

Unreviewed, rolling out r198679.

This change caused flaky LayoutTest crashes

Reverted changeset:

"bmalloc: Renamed LargeChunk => Chunk"
https://bugs.webkit.org/show_bug.cgi?id=155894
http://trac.webkit.org/changeset/198679

12:50 PM Changeset in webkit [198685] by matthew_hanson@apple.com

3 edits
2 adds in branches/safari-601.1.46-branch

Merge r197856. rdar://problem/25152411

12:32 PM Changeset in webkit [198684] by enrica@apple.com

2 edits in trunk/Source/WebCore

Data Detection creates multiple links even when the detected content is within the same node.
https://bugs.webkit.org/show_bug.cgi?id=155860
rdar://problem/25319579

Reviewed by Tim Horton.

If the detected content spans over multiple query fragments,
we need to check if consecutive fragments are all within the
same node. This way we can avoid creating multiple ranges and
consequntly more links.

editing/cocoa/DataDetection.mm:

(WebCore::DataDetection::detectContentInRange):

12:25 PM Changeset in webkit [198683] by hyatt@apple.com

6 edits
6 adds in trunk

Implement the allow-end value of the hanging-punctuation CSS property.
https://bugs.webkit.org/show_bug.cgi?id=104996

Reviewed by Simon Fraser.

Source/WebCore:

Added new tests in fast/text.

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::constructLine):
Fix a bug where empty RenderInlines were incorrectly excluding their end borders if
they occurred at the end of a line. Needed to adequately test allow-end and empty
inline borders.

rendering/RenderText.cpp:

(WebCore::RenderText::isHangableStopOrComma):
Helper function that identifies the hangable stops and commas.

rendering/RenderText.h:

Add new isHangableStopOrComma function to RenderText.

rendering/line/BreakingContext.h:

(WebCore::BreakingContext::lineBreak):
(WebCore::BreakingContext::lineWidth):
(WebCore::BreakingContext::atEnd):
(WebCore::BreakingContext::fitsOnLineOrHangsAtEnd):
(WebCore::BreakingContext::clearLineBreakIfFitsOnLine):
(WebCore::BreakingContext::commitLineBreakAtCurrentWidth):
(WebCore::BreakingContext::handleBR):
(WebCore::BreakingContext::handleEmptyInline):
(WebCore::BreakingContext::handleReplaced):
(WebCore::tryHyphenating):
(WebCore::BreakingContext::computeAdditionalBetweenWordsWidth):
(WebCore::BreakingContext::handleText):
(WebCore::BreakingContext::commitAndUpdateLineBreakIfNeeded):
Modified breaking rules to handle allow-end. The basic idea is to see if you can
fit without the comma and only hang if you do, and if nothing else gets added to the
line after the comma. This involves tracking a new state, m_hangsAtEnd, that can
be set/cleared while iterating over the objects that will end up on the line.

LayoutTests:

fast/text/hanging-punctuation-allow-end-basic-expected.html: Added.
fast/text/hanging-punctuation-allow-end-basic.html: Added.
fast/text/hanging-punctuation-allow-end-expected.html: Added.
fast/text/hanging-punctuation-allow-end-inlines-expected.html: Added.
fast/text/hanging-punctuation-allow-end-inlines.html: Added.
fast/text/hanging-punctuation-allow-end.html: Added.

11:44 AM Changeset in webkit [198682] by dbates@webkit.org

3 edits
2 adds in trunk

Add WebKitSystemInterface for iOS 9.3
https://bugs.webkit.org/show_bug.cgi?id=155893

Rubber-stamped by Alexey Proskuryakov.

Tools:

Scripts/copy-webkitlibraries-to-product-directory:

WebKitLibraries:

libWebKitSystemInterfaceIOSDevice9.3.a: Added.
libWebKitSystemInterfaceIOSSimulator9.3.a: Added.

11:42 AM Changeset in webkit [198681] by dbates@webkit.org

2 edits in trunk

REGRESSION (r197358): WebKitSystemInterface.h copied into directory named "--llvm"
https://bugs.webkit.org/show_bug.cgi?id=155838

Reviewed by Alexey Proskuryakov.

Do not pass command line flag --llvm when calling script copy-webkitlibraries-to-product-directory
to avoid copying the WebKitSystemInterface libraries to an incorrect location. The --llvm flag was
removed from copy-webkitlibraries-to-product-directory in <http://trac.webkit.org/changeset/197358>.

WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme:

11:42 AM Changeset in webkit [198680] by ggaren@apple.com

2 edits in trunk/Source/bmalloc

bmalloc: stress_aligned fails when allocating a zero-sized object with XLarge alignment
https://bugs.webkit.org/show_bug.cgi?id=155896

Reviewed by Andreas Kling.

We normally filter zero-sized allocations into small allocations, but
a zero-sized allocation can sneak through if it requires sufficiently
large alignment.

bmalloc/Heap.cpp:

(bmalloc::Heap::tryAllocateXLarge): Set a floor on allocation size to
catch zero-sized allocations.

11:32 AM Changeset in webkit [198679] by ggaren@apple.com

15 edits
1 move
1 delete in trunk/Source/bmalloc

bmalloc: Renamed LargeChunk => Chunk
https://bugs.webkit.org/show_bug.cgi?id=155894

Reviewed by Michael Saboff.

A Chunk can contain both small and large objects now.

bmalloc.xcodeproj/project.pbxproj:
bmalloc/Allocator.cpp:

(bmalloc::Allocator::allocate):

bmalloc/BoundaryTag.h:

(bmalloc::BoundaryTag::isFree):

bmalloc/Chunk.h: Copied from Source/bmalloc/bmalloc/LargeChunk.h.

(bmalloc::Chunk::pages):
(bmalloc::Chunk::begin):
(bmalloc::Chunk::end):
(bmalloc::Chunk::Chunk):
(bmalloc::Chunk::get):
(bmalloc::Chunk::beginTag):
(bmalloc::Chunk::endTag):
(bmalloc::Chunk::offset):
(bmalloc::Chunk::object):
(bmalloc::Chunk::page):
(bmalloc::Chunk::line):
(bmalloc::SmallLine::begin):
(bmalloc::SmallPage::begin):
(bmalloc::SmallPage::end):
(bmalloc::Object::Object):
(bmalloc::Object::begin):
(bmalloc::LargeChunk::pages): Deleted.
(bmalloc::LargeChunk::begin): Deleted.
(bmalloc::LargeChunk::end): Deleted.
(bmalloc::LargeChunk::LargeChunk): Deleted.
(bmalloc::LargeChunk::get): Deleted.
(bmalloc::LargeChunk::beginTag): Deleted.
(bmalloc::LargeChunk::endTag): Deleted.
(bmalloc::LargeChunk::offset): Deleted.
(bmalloc::LargeChunk::object): Deleted.
(bmalloc::LargeChunk::page): Deleted.
(bmalloc::LargeChunk::line): Deleted.

bmalloc/Deallocator.cpp:
bmalloc/FreeList.cpp:
bmalloc/Heap.cpp:

(bmalloc::Heap::allocateLarge):

bmalloc/LargeChunk.h: Removed.
bmalloc/LargeObject.h:

(bmalloc::LargeObject::LargeObject):
(bmalloc::LargeObject::merge):
(bmalloc::LargeObject::split):

bmalloc/Object.h:

(bmalloc::Object::chunk):

bmalloc/ObjectType.cpp:
bmalloc/Sizes.h:
bmalloc/SmallAllocator.h: Removed.
bmalloc/VMHeap.cpp:

(bmalloc::VMHeap::VMHeap):
(bmalloc::VMHeap::allocateChunk):
(bmalloc::VMHeap::allocateLargeChunk): Deleted.

bmalloc/VMHeap.h:

(bmalloc::VMHeap::allocateLargeObject):
(bmalloc::VMHeap::deallocateLargeObject):

bmalloc/Zone.cpp:

(bmalloc::enumerator):

bmalloc/Zone.h:

(bmalloc::Zone::chunks):
(bmalloc::Zone::addChunk):
(bmalloc::Zone::largeChunks): Deleted.
(bmalloc::Zone::addLargeChunk): Deleted.

11:18 AM Changeset in webkit [198678] by BJ Burg

30 edits in trunk/Source

Web Inspector: protocol generator should prefix C++ filenames with the protocol group
https://bugs.webkit.org/show_bug.cgi?id=155859
<rdar://problem/25349859>

Reviewed by Alex Christensen and Joseph Pecoraro.

Source/JavaScriptCore:

Like for generated Objective-C files, we should use the 'protocol group' name
as the prefix for generated C++ files so that headers from different protocol
groups have unambiguous names.

inspector/scripts/codegen/cpp_generator.py:

(CppGenerator):
(CppGenerator.init):
(CppGenerator.protocol_name):
Make all C++ code generators extend the CppGenerator python class and use the
protocol_name() instance method. This matches a recent change to the ObjC generator.

inspector/scripts/codegen/cpp_generator_templates.py:

(CppGeneratorTemplates):
Drive-by cleanup to use #pragma once instead of header guards.

inspector/scripts/codegen/generate_cpp_alternate_backend_dispatcher_header.py:

(CppAlternateBackendDispatcherHeaderGenerator):
(CppAlternateBackendDispatcherHeaderGenerator.init):
(CppAlternateBackendDispatcherHeaderGenerator.output_filename):
(CppAlternateBackendDispatcherHeaderGenerator.generate_output):

inspector/scripts/codegen/generate_cpp_backend_dispatcher_header.py:

(CppBackendDispatcherHeaderGenerator):
(CppBackendDispatcherHeaderGenerator.init):
(CppBackendDispatcherHeaderGenerator.output_filename):
(CppBackendDispatcherHeaderGenerator.generate_output):

inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:

(CppBackendDispatcherImplementationGenerator):
(CppBackendDispatcherImplementationGenerator.init):
(CppBackendDispatcherImplementationGenerator.output_filename):
(CppBackendDispatcherImplementationGenerator.generate_output):

inspector/scripts/codegen/generate_cpp_frontend_dispatcher_header.py:

(CppFrontendDispatcherHeaderGenerator):
(CppFrontendDispatcherHeaderGenerator.init):
(CppFrontendDispatcherHeaderGenerator.output_filename):
(CppFrontendDispatcherHeaderGenerator.generate_output):

inspector/scripts/codegen/generate_cpp_frontend_dispatcher_implementation.py:

(CppFrontendDispatcherImplementationGenerator):
(CppFrontendDispatcherImplementationGenerator.init):
(CppFrontendDispatcherImplementationGenerator.output_filename):
(CppFrontendDispatcherImplementationGenerator.generate_output):

inspector/scripts/codegen/generate_cpp_protocol_types_header.py:

(CppProtocolTypesHeaderGenerator):
(CppProtocolTypesHeaderGenerator.init):
(CppProtocolTypesHeaderGenerator.output_filename):
(CppProtocolTypesHeaderGenerator.generate_output):

inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:

(CppProtocolTypesImplementationGenerator):
(CppProtocolTypesImplementationGenerator.init):
(CppProtocolTypesImplementationGenerator.output_filename):
(CppProtocolTypesImplementationGenerator.generate_output):
Use the protocol_name() instance method to compute generated protocol file names.

inspector/scripts/codegen/models.py:

Explicitly set the 'protocol_group' for the Inspector protocol.

Rebaseline generator test results.

inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
inspector/scripts/tests/expected/enum-values.json-result:
inspector/scripts/tests/expected/events-with-optional-parameters.json-result:
inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:
inspector/scripts/tests/expected/same-type-id-different-domain.json-result:
inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result:
inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result:
inspector/scripts/tests/expected/type-declaration-array-type.json-result:
inspector/scripts/tests/expected/type-declaration-enum-type.json-result:
inspector/scripts/tests/expected/type-declaration-object-type.json-result:
inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:

Source/WebKit2:

Adjust header include and build system paths.

CMakeLists.txt:

Revert the workaround introduced in r198659 since this change fixes the
underlying issue.

DerivedSources.make:
UIProcess/Automation/WebAutomationSession.cpp:
UIProcess/Automation/WebAutomationSession.h:
WebKit2.xcodeproj/project.pbxproj:

11:14 AM Changeset in webkit [198677] by achristensen@apple.com

6 edits in trunk/Source/WebCore

Revert most of r198673.

platform/graphics/MediaPlayer.cpp:

(WebCore::buildMediaEnginesVector):

platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
platform/graphics/mac/MediaTimeQTKit.h:
platform/graphics/mac/MediaTimeQTKit.mm:
platform/mac/WebVideoFullscreenController.mm:

11:07 AM Changeset in webkit [198676] by keith_miller@apple.com

4 edits in trunk/Source/JavaScriptCore

putByIndexBeyondVectorLengthWithoutAttributes should not crash if it can't ensureLength
https://bugs.webkit.org/show_bug.cgi?id=155730

Reviewed by Saam Barati.

This patch makes ensureLength return a boolean indicating if it was able to set the length.
ensureLength also no longer sets the butterfly to null if the allocation of the butterfly
fails. All of ensureLengths callers including putByIndexBeyondVectorLengthWithoutAttributes
have been adapted to throw an out of memory error if ensureLength fails.

runtime/JSArray.cpp:

(JSC::JSArray::setLength):
(JSC::JSArray::unshiftCountWithAnyIndexingType):

runtime/JSObject.cpp:

(JSC::JSObject::putByIndexBeyondVectorLengthWithoutAttributes):
(JSC::JSObject::ensureLengthSlow):

runtime/JSObject.h:

(JSC::JSObject::ensureLength):

11:07 AM Changeset in webkit [198675] by ggaren@apple.com

19 edits
2 deletes in trunk/Source/bmalloc

bmalloc: small and large objects should share memory
https://bugs.webkit.org/show_bug.cgi?id=155866

Reviewed by Andreas Kling.

This patch cuts our VM footprint in half. (VM footprint usually doesn't
matter, but on iOS there's an artificial VM limit around 700MB, and if
you hit it you jetsam / crash.)

It's also a step toward honoring the hardware page size at runtime,
which will reduce memory usage on iOS.

This patch is a small improvement in peak memory usage because it allows
small and large objects to recycle each other's memory. The tradeoff is
that we require more metadata, which causes more memory usage after
shrinking down from peak memory usage. In the end, we have some memory
wins and some losses, and a small win in the mean on our standard memory
benchmarks.

bmalloc.xcodeproj/project.pbxproj: Removed SuperChunk.

bmalloc/Allocator.cpp:

(bmalloc::Allocator::reallocate): Adopt a new Heap API for shrinking
large objects because it's a little more complicated than it used to be.

Don't check for equality in the XLarge case because we don't do it in
other cases, and it's unlikely that we'll be called for no reason.

bmalloc/BumpAllocator.h:

(bmalloc::BumpAllocator::allocate): Don't ASSERT isSmall because that's
an old concept from when small and large objects were in distinct memory
regions.

bmalloc/Deallocator.cpp:

(bmalloc::Deallocator::deallocateSlowCase): Large objects are not
segregated anymore.

(bmalloc::Deallocator::deallocateLarge): Deleted.

bmalloc/Deallocator.h:

(bmalloc::Deallocator::deallocateFastCase): Don't ASSERT isSmall(). See
above.

bmalloc/Heap.cpp:

(bmalloc::Heap::scavenge):
(bmalloc::Heap::scavengeSmallPage):
(bmalloc::Heap::scavengeSmallPages): New helpers for returning cached
small pages to the large object heap.

(bmalloc::Heap::allocateSmallPage): Allocate small pages from the large
object heap. This is how we accomplish sharing.

(bmalloc::Heap::deallocateSmallLine): Handle large objects since we can
encounter them on this code path now.

(bmalloc::Heap::splitAndAllocate): Fixed a bug where we would sometimes
not split even though we could.

Allocating a large object also requires ref'ing its small line so that
we can alias memory between small and large objects.

(bmalloc::Heap::allocateLarge): Return cached small pages before
allocating a large object that would fit in a cached small page. This
allows some large allocations to reuse small object memory.

(bmalloc::Heap::shrinkLarge): New helper.

(bmalloc::Heap::deallocateLarge): Deleted.

bmalloc/Heap.h:

bmalloc/LargeChunk.h:

(bmalloc::LargeChunk::pageBegin):
(bmalloc::LargeChunk::pageEnd):
(bmalloc::LargeChunk::lines):
(bmalloc::LargeChunk::pages):
(bmalloc::LargeChunk::begin):
(bmalloc::LargeChunk::end):
(bmalloc::LargeChunk::LargeChunk):
(bmalloc::LargeChunk::get):
(bmalloc::LargeChunk::endTag):
(bmalloc::LargeChunk::offset):
(bmalloc::LargeChunk::object):
(bmalloc::LargeChunk::page):
(bmalloc::LargeChunk::line):
(bmalloc::SmallLine::begin):
(bmalloc::SmallLine::end):
(bmalloc::SmallPage::begin):
(bmalloc::SmallPage::end):
(bmalloc::Object::Object):
(bmalloc::Object::begin):
(bmalloc::Object::pageBegin):
(bmalloc::Object::line):
(bmalloc::Object::page): I merged all the SmallChunk metadata and code
into LargeChunk. Now we use a single class to track both small and large
metadata, so we can share memory between small and large objects.

I'm going to rename this class to Chunk in a follow-up patch.

bmalloc/Object.h:

(bmalloc::Object::chunk): Updated for LargeChunk transition.

bmalloc/ObjectType.cpp:

(bmalloc::objectType):

bmalloc/ObjectType.h:

(bmalloc::isXLarge):
(bmalloc::isSmall): Deleted. The difference between small and large
objects is now stored in metadata and is not a property of their
virtual address range.

bmalloc/SegregatedFreeList.h: One more entry because we cover all of

what used to be the super chunk in a large chunk now.

bmalloc/Sizes.h: Removed bit masking helpers because we don't use

address masks to distinguish small vs large object type anymore.

bmalloc/SmallChunk.h: Removed.

bmalloc/SmallPage.h:

(bmalloc::SmallPage::SmallPage): Store object type per page because any
given page can be used for large objects or small objects.

bmalloc/SuperChunk.h: Removed.

bmalloc/VMHeap.cpp:

(bmalloc::VMHeap::VMHeap):
(bmalloc::VMHeap::allocateLargeChunk):
(bmalloc::VMHeap::allocateSmallChunk): Deleted.
(bmalloc::VMHeap::allocateSuperChunk): Deleted.

bmalloc/VMHeap.h:

(bmalloc::VMHeap::allocateLargeObject):
(bmalloc::VMHeap::deallocateLargeObject):
(bmalloc::VMHeap::allocateSmallPage): Deleted.
(bmalloc::VMHeap::deallocateSmallPage): Deleted. Removed super chunk and
small chunk support.

bmalloc/Zone.cpp:

(bmalloc::enumerator):

bmalloc/Zone.h:

(bmalloc::Zone::largeChunks):
(bmalloc::Zone::addLargeChunk):
(bmalloc::Zone::superChunks): Deleted.
(bmalloc::Zone::addSuperChunk): Deleted. Removed super chunk and
small chunk support.

10:37 AM Changeset in webkit [198674] by commit-queue@webkit.org

7 edits
2 adds in trunk

[JSC] implement String.prototype.padStart() and String.prototype.padEnd() proposal
https://bugs.webkit.org/show_bug.cgi?id=155795

Patch by Caitlin Potter <caitp@igalia.com> on 2016-03-25
Reviewed by Darin Adler.

Source/JavaScriptCore:

Implements ECMAScript proposal http://tc39.github.io/proposal-string-pad-start-end/
Currently at Stage 3.

runtime/JSString.h:
runtime/StringPrototype.cpp:

(JSC::StringPrototype::finishCreation):
(JSC::repeatCharacter):
(JSC::repeatStringPattern):
(JSC::padString):
(JSC::stringProtoFuncPadEnd):
(JSC::stringProtoFuncPadStart):

tests/es6.yaml:
tests/es6/String.prototype_methods_String.prototype.padEnd.js: Added.
tests/es6/String.prototype_methods_String.prototype.padStart.js: Added.

LayoutTests:

js/Object-getOwnPropertyNames-expected.txt:
js/script-tests/Object-getOwnPropertyNames.js:

10:24 AM Changeset in webkit [198673] by achristensen@apple.com

8 edits in trunk/Source

Add a compile time flag for using QTKit
https://bugs.webkit.org/show_bug.cgi?id=155868

Reviewed by Dan Bates.

Source/WebCore:

platform/graphics/MediaPlayer.cpp:

(WebCore::buildMediaEnginesVector):

platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
platform/graphics/mac/MediaTimeQTKit.h:
platform/graphics/mac/MediaTimeQTKit.mm:
platform/mac/WebVideoFullscreenController.mm:

Source/WTF:

wtf/Platform.h:

10:12 AM Changeset in webkit [198672] by achristensen@apple.com

2 edits in trunk/Source/WebKit2

Remove unused lambda capture after r196984.

NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
resourceResponse is not used in the lambda.

10:00 AM Changeset in webkit [198671] by achristensen@apple.com

2 edits in trunk/Source/WebKit2

Fix Mac CMake build.

PlatformMac.cmake:

9:25 AM Changeset in webkit [198670] by commit-queue@webkit.org

2 edits in trunk

Detect correct number of processors on windows
https://bugs.webkit.org/show_bug.cgi?id=155884

Patch by Bill Ming <mbbill@gmail.com> on 2016-03-25
Reviewed by Alex Christensen.

Tools/Scripts/run-jsc-stress-tests:

9:14 AM Changeset in webkit [198669] by Brent Fulgham

5 edits in trunk

[Win] Improve CMake build performance
https://bugs.webkit.org/show_bug.cgi?id=155871
<rdar://problem/24747822>

Reviewed by Alex Christensen.

Add a flag to the PROCESS_ALLINONE_FILE macro so that it does not remove
the files contained in the passed all-in-one file, since this breaks
dependency checking and generation of the derived sources from the IDL.
Instead, include the header files in the project so that all files get
generated.

Source/cmake/WebKitMacros: Updated for 'DerivedSources.cpp' use case.

Source/WebCore:

Treat DerivedSources.cpp as an 'All-in-one' file. Pass a flag to the
PROCESS_ALLINONE_FILE macro so that it does not remove the contents of
the file, since this breaks dependency checking and generation of the
sources from the IDL files. Instead, include the header files in the
project so that all files get generated.

CMakeLists.txt: Updated for 'DerivedSources.cpp'
DerivedSources.cpp: Add some generated files that were missing.

9:05 AM Changeset in webkit [198668] by dbates@webkit.org

2 edits in trunk/Tools

Use webkitdirs::determineXcodeSDK() instead of webkitdirs::willUseIOSDeviceSDK()
in copy-webkitlibraries-to-product-directory
https://bugs.webkit.org/show_bug.cgi?id=155869

Reviewed by Alexey Proskuryakov.

It is sufficient and more direct to call webkitdirs::determineXcodeSDK() instead of
webkitdirs::willUseIOSDeviceSDK() to process the --sdk/--device/--ios-simulator command
line argument.

Scripts/copy-webkitlibraries-to-product-directory:

8:23 AM Changeset in webkit [198667] by Matt Baker

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Scrolling/selection is broken in Quick Open dialog resource tree
https://bugs.webkit.org/show_bug.cgi?id=155877
<rdar://problem/25356149>

Reviewed by Timothy Hatcher.

Dialog and tree outline now use "display: flex", causing the height of the
tree outline to be based on the height of the dialog. Overflow scrolling
in the tree outline now has the expected behavior.

UserInterface/Views/OpenResourceDialog.css:

(.open-resource-dialog):
(.open-resource-dialog > .tree-outline):

7:47 AM Changeset in webkit [198666] by commit-queue@webkit.org

6 edits in trunk

Turned on ENABLE_REQUEST_ANIMATION_FRAME by default for any port.
https://bugs.webkit.org/show_bug.cgi?id=155882

Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-03-25
Reviewed by Michael Catanzaro.

It was already enabled in all trunk ports, and is required for
WebInspectorUI to work.

Source/cmake/OptionsGTK.cmake: Removed duplication of default value.
Source/cmake/OptionsMac.cmake: Ditto.
Source/cmake/WebKitFeatures.cmake: Turned

ENABLE_REQUEST_ANIMATION_FRAME ON.

Tools:

Scripts/webkitperl/FeatureList.pm:

7:19 AM Changeset in webkit [198665] by youenn.fablet@crf.canon.fr

32 edits
12 adds in trunk

[Fetch API] Add basic loading of resources
https://bugs.webkit.org/show_bug.cgi?id=155637

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebasing test expectations.
Updating scheme-blob.js to ensure generated test names are stable run after run.

web-platform-tests/fetch/api/basic/accept-header-expected.txt:
web-platform-tests/fetch/api/basic/integrity-expected.txt:
web-platform-tests/fetch/api/basic/mode-no-cors-expected.txt:
web-platform-tests/fetch/api/basic/mode-same-origin-expected.txt:
web-platform-tests/fetch/api/basic/request-forbidden-headers-expected.txt:
web-platform-tests/fetch/api/basic/request-headers-expected.txt:
web-platform-tests/fetch/api/basic/scheme-about-expected.txt:
web-platform-tests/fetch/api/basic/scheme-blob-expected.txt:
web-platform-tests/fetch/api/basic/scheme-blob-worker-expected.txt:
web-platform-tests/fetch/api/basic/scheme-blob.js:

(checkFetchResponse): Deleted.
(checkKoUrl): Deleted.

web-platform-tests/fetch/api/basic/scheme-data-expected.txt:
web-platform-tests/fetch/api/basic/scheme-others-expected.txt:
web-platform-tests/fetch/api/basic/stream-response-expected.txt:

Source/WebCore:

Adding support for basic fetch for Window (no support for Worker yet).
A FetchResponse object is created for every fetch task.
But it will only be exposed to JS at promise fulfillment time, i.e. once initial response headers are retrieved.

Updating Blob resource handle to add Content-Type and Content-Length header and notifying of error in case of erroneous HTTP method.

Fetch is limited to same origin requests currently due to some WPT tests that would timeout otherwise.

Tests: http/tests/fetch/closing-while-fetching.html

http/tests/fetch/get-response-body-while-loading.html

Also covered by rebased tests.

Modules/fetch/DOMWindowFetch.cpp: Creating a FetchResponse to start fetching.

(WebCore::DOMWindowFetch::fetch):

Modules/fetch/DOMWindowFetch.h:
Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::consume):
(WebCore::FetchBody::consumeArrayBuffer): Handling of body promises in case of data stored as a buffer.
(WebCore::FetchBody::consumeText): Passing the promise as a reference.
(WebCore::blobFromArrayBuffer): Helper routine.
(WebCore::FetchBody::fulfillTextPromise): Helper routine.
(WebCore::FetchBody::loadedAsArrayBuffer): Updated to handle storing of data as a buffer.
(WebCore::FetchBody::loadedAsText):
(WebCore::FetchBody::bodyForInternalRequest): Helper routine to generate the request body data to be sent as part of the fetch request.
(WebCore::FetchBody::extractFromText):

Modules/fetch/FetchBody.h:

(WebCore::FetchBody::loadingBody):
(WebCore::FetchBody::FetchBody):

Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::loadBlob): Updated to cope with the change that FetchLoader::start does not return a boolean anymore
but will directly call failure callbacks.
(WebCore::FetchBodyOwner::loadedBlobAsText): Moving it closer to other blob loading routines.
(WebCore::FetchBodyOwner::finishBlobLoading):

Modules/fetch/FetchBodyOwner.h:

(WebCore::FetchBodyOwner::body):
(WebCore::FetchBodyOwner::loadedBlobAsArrayBuffer):

Modules/fetch/FetchHeaders.cpp:

(WebCore::FetchHeaders::fill):
(WebCore::FetchHeaders::filterAndFill): Helper routine to fill headers from a HTTPHeaderMap after being filtered.

Modules/fetch/FetchHeaders.h:

(WebCore::FetchHeaders::internalHeaders):

Modules/fetch/FetchLoader.cpp:

(WebCore::FetchLoader::start):
(WebCore::FetchLoader::didFailRedirectCheck):

Modules/fetch/FetchLoader.h:
Modules/fetch/FetchRequest.cpp:

(WebCore::FetchRequest::internalRequest): Routine used to create the ResourceRequest transmitted to ThreadableLoader.

Modules/fetch/FetchRequest.h:

Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::fetch): Start fetching by creating a FetchLoader based on passed request.
(WebCore::FetchResponse::BodyLoader::didSucceed): FetchLoader callback.
(WebCore::FetchResponse::BodyLoader::didFail): Ditto.
(WebCore::FetchResponse::BodyLoader::BodyLoader): Ditto.
(WebCore::FetchResponse::BodyLoader::didReceiveResponse): Ditto.
(WebCore::FetchResponse::BodyLoader::didFinishLoadingAsArrayBuffer): Ditto.
(WebCore::FetchResponse::BodyLoader::start): Starting fetch loader.
(WebCore::FetchResponse::BodyLoader::stop): Stopping fetch loader.
(WebCore::FetchResponse::stop): Stop loader if any.

Modules/fetch/FetchResponse.h:
platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::doStart: Notifying the loader with an error if verb is not GET.
(WebCore::BlobResourceHandle::notifyResponseOnSuccess): Adding support for Content-Type and Content-Lenth headers.
(WebCore::BlobResourceHandle::createAsync): Removing GET verb check.

LayoutTests:

TestExpectations: Removed flaky test expectations.
http/tests/fetch/closing-while-fetching-expected.txt: Added.
http/tests/fetch/closing-while-fetching.html: Added.
http/tests/fetch/get-response-body-while-loading-expected.txt: Added.
http/tests/fetch/get-response-body-while-loading.html: Added.
http/tests/resources/download-json-with-delay.php: Added.
platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/request-headers-expected.txt: Added.

7:08 AM Changeset in webkit [198664] by commit-queue@webkit.org