Timeline

May 1, 2016:

11:14 PM Changeset in webkit [200318] by n_wang@apple.com

• 5 edits in trunk

AX: Crash at WebCore::AccessibilityObject::getAttribute const + 9
​https://bugs.webkit.org/show_bug.cgi?id=157256

Reviewed by Chris Fleizach.

Source/WebCore:

When the <label> for the input element has no renderer, it will cause
crash when we ask for the title element text. Fixed it by getting the
aria-label attribute directly from the <label> element instead of its
accessibility object.

Test case covered in accessibility/mac/aria-label-on-label-element.html.

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::titleElementText):

LayoutTests:

• accessibility/mac/aria-label-on-label-element-expected.txt:
• accessibility/mac/aria-label-on-label-element.html:

11:05 PM Changeset in webkit [200317] by Darin Adler

• 26 edits in trunk/Source/WebCore

Stop using string-based enumerations in TextTrack, and eliminate support for string-based enumerations
​https://bugs.webkit.org/show_bug.cgi?id=157253

Reviewed by Chris Dumez.

This was the most difficult case to convert from the old style of enumeration to enum class.
Afterward there is a bit of messy duplication, but it still seems like an improvement overall.

After this patch, I plan to change the rule for the name of the enumeration; instead of
living at the top level of the WebCore namespace, we will look for them inside the class for the
first interface defined in the same file along with the enumeration, and remove the name prefix,
if the interfaces's name is a prefix of the enumerations's name.

Once that's done, next step is to do something in the bindings for dictionaries. And adopt both the
enumeration and dictionary mechanisms more widely, and remove the old use of "dictionary" as a type name.

• Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::removeSourceBuffer): Use enum values instead of keywords.

• Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::textTrackModeChanged): Ditto.

• bindings/js/JSTextTrackCustom.cpp:

(WebCore::JSTextTrack::setKind): Deleted.

• bindings/scripts/CodeGenerator.pm:

(IsStringBasedEnumType): Deleted.

• bindings/scripts/CodeGeneratorJS.pm:

(GetEnumerationImplementationContent): Removed IsStringBasedEnumType check.
(GenerateParametersCheck): Ditto.
(GenerateImplementation): Ditto.
(GetNativeType): Ditto.
(JSValueToNative): Ditto.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadInternal): Use enum values instead of keywords.
(WebCore::HTMLMediaElement::textTrackModeChanged): Ditto.
(WebCore::HTMLMediaElement::textTrackKindChanged): Ditto.
(WebCore::HTMLMediaElement::textTrackAddCues): Ditto.
(WebCore::HTMLMediaElement::textTrackAddCue): Ditto.
(WebCore::HTMLMediaElement::addTextTrack): Ditto.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Ditto.
(WebCore::HTMLMediaElement::setSelectedTextTrack): Ditto.
(WebCore::HTMLMediaElement::configureTextTracks): Ditto.
(WebCore::HTMLMediaElement::hasClosedCaptions): Ditto.
(WebCore::HTMLMediaElement::configureTextTrackDisplay): Ditto.
(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): Ditto.
(WebCore::toPlatform): Added helpers for the outOfBandTrackSources function.
(WebCore::HTMLMediaElement::outOfBandTrackSources): Removed unneeded fastHasAttribute
check since getNonEmptyURLAttribute already returns an empty URL when the attribute is
not present. Changed to use enum values instead of keywords.

• html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::parseAttribute): Use new setKindKeywordIgnoringASCIICase
function rather than calling setKind and convertToASCIILowercase. Also use ensureTrack
instead of track since the latter is a cover that calls it and dumbs down the return type.
(WebCore::HTMLTrackElement::kind): Changed return type to const AtomicString& since
that's what we will have for kind keywords and because it matches what we normally have
for attribute getting fuctions. Also use ensureTrack.
(WebCore::HTMLTrackElement::setKind): Changed argument to AtomicString so we don't waste
time making a string and then destroying it before turning it into an AtomicString so it
can be an attribute value.
(WebCore::HTMLTrackElement::srclang): Changed return type to const AtomicString& as is
customary and efficient for attribute value convenience functions. Also use fastGetAttribute.
(WebCore::HTMLTrackElement::setSrclang): Deleted.
(WebCore::HTMLTrackElement::label): Ditto.
(WebCore::HTMLTrackElement::setLabel): Deleted.
(WebCore::HTMLTrackElement::setIsDefault): Deleted.
(WebCore::HTMLTrackElement::scheduleLoad): Use enum values instead of keywords.

• html/HTMLTrackElement.h: Use pragma once. Update for changes mentioned above.

Also mark things final instead of override as per our recent style discussion.

• html/HTMLTrackElement.idl: Use [Reflect] for srclang and label.

• html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay): Use enum value
instead of keyword.
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Ditto.

• html/track/AudioTrack.cpp:

(WebCore::AudioTrack::AudioTrack): Use new base class MediaTrackBase.

• html/track/AudioTrack.h: Use pragma once. Make base class be MediaTrackBase instead

of TrackBase.

• html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::setMode): Change argument type to enum instead of string.
(WebCore::toPrivate): Added. Helper for setModeInternal.
(WebCore::InbandTextTrack::setModeInternal): Change argument type to enum instead of string.
(WebCore::InbandTextTrack::updateKindFromPrivate): Use enum instead of string to call setKind.

• html/track/InbandTextTrack.h: Use pragma once. Use TextTrackMode for argument types.

• html/track/TextTrack.cpp:

(WebCore::captionsKeyword): Converted this to a non-member function since it is now
private to this file.
(WebCore::descriptionsKeyword): Ditto.
(WebCore::chaptersKeyword): Ditto.
(WebCore::metadataKeyword): Ditto.
(WebCore::forcedKeyword): Ditto.
(WebCore::TextTrack::disabledKeyword): Deleted.
(WebCore::TextTrack::hiddenKeyword): Deleted.
(WebCore::TextTrack::showingKeyword): Deleted.
(WebCore::TextTrack::TextTrack): Moved some initialization to be done in the header where
the data members are defined. Put the code that is the equivalent to setKindInternal here,
because it turns out it's not needed anywhere else. Over time we might change the types
involved and there's no need to have that be across multiple functions.
(WebCore::TextTrack::~TextTrack): Removed unneeded call to clearClient, right when the
object is about to be destroyed. Perhaps there was an illusion that the old call might
be a virtual function call that invokes the clearClient from a derived class, but that
doesn't work in a destructor, so this code was only clearing out the data member and
that does not need to be done.
(WebCore::TextTrack::isValidKind): Deleted.
(WebCore::TextTrack::enabled): Use enum value instead of keyword.
(WebCore::TextTrack::kindKeyword): Added. Function for callers who need a string, not the
enum value.
(WebCore::TextTrack::setKind): Take enum value instead of keyword. Also changed since
we store the kind in a data member in this class, not inherited.
(WebCore::TextTrack::setKindKeywordIgnoringASCIICase): Added. For HTMLTrackElement to use
when setting the kind attribute.
(WebCore::TextTrack::setMode): Take enum value instread of keyword. Also removed assertion
since the enum already makes it intrinsically clear what values are valid, unlike a string.
(WebCore::TextTrack::cues): Use enum value instead of keyword.
(WebCore::TextTrack::activeCues): Ditto.
(WebCore::TextTrack::addCue): Ditto.
(WebCore::TextTrack::ensureVTTRegionList): Changed return type to reference.
(WebCore::TextTrack::regions): Use enum value instead of keyword.
(WebCore::TextTrack::addRegion): Use reference.
(WebCore::TextTrack::cueDidChange): Ditto.
(WebCore::TextTrack::isRendered): Use enum values instead of keywords. Also write to be
a boolean expression instead of a couple different if statements.
(WebCore::TextTrack::ensureTextTrackCueList): Changed return type to reference.
(WebCore::TextTrack::isMainProgramContent): Use enum value instead of keyword.
(WebCore::TextTrack::containsOnlyForcedSubtitles): Ditto.

• html/track/TextTrack.h: Use pragma once. Removed unneeded include. Added enums for

TextTrackKind and TextTrackMode. Updated for changes to functions listed above.
Added m_mode and m_kind and initialized those data members and some others.

• html/track/TextTrack.idl: Tweaked formatting. Used ImplementedAs for the kind

attribute rather than using a CustomSetter. This preserves the strange behavior
where setting kind does nothing when !ENABLE(MEDIA_SOURCE). If we discover we don't
need that, then we won't need ImplementedAs any more either.

• html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::dispatchEvent): Use enum instad of keyword.
(WebCore::TextTrackCue::isActive): Ditto.

• html/track/TrackBase.cpp:

(WebCore::TrackBase::TrackBase): Removed unneeded initialization that is handled in
the data member definition in the header now.
(WebCore::MediaTrackBase::MediaTrackBase): Added. Calls through to TrackBase.
(WebCore::MediaTrackBase::setKind): Moved to MediaTrackBase from TrackBase, because
this isn't needed for text tracks.
(WebCore::MediaTrackBase::setKindInternal): Ditto.

• html/track/TrackBase.h: Use pragma once. Move kind, setKind, isValidKind, defaultKindKeyword,

setKindInternal, and m_kind all to a derived class, MediaTrackBase, since TextTrack doesn't need
any of those any more. Later we might adopt enumerations more and it's possible the need for
MediaTrackBase will go away.

• html/track/VideoTrack.cpp:

(WebCore::VideoTrack::VideoTrack): Updated to use MediaTrackBase.
(WebCore::VideoTrack::setLanguage): Ditto.

• html/track/VideoTrack.h: Use pragma once. Removed unneeded header include.

Derive from MediaTrackBase instead of TrackBase.

• page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::sortedTrackListForMenu): Use enum values instead
of keywords.
(WebCore::CaptionUserPreferences::textTrackSelectionScore): Ditto.

• page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::textTrackSelectionScore): Ditto.
(WebCore::CaptionUserPreferencesMediaAF::sortedTrackListForMenu): Ditto. Also used
kindKeyword since we want a string for logging.

• platform/cocoa/WebPlaybackSessionModelMediaElement.mm:

(WebPlaybackSessionModelMediaElement::updateLegibleOptions): Ditto.

9:21 PM Changeset in webkit [200316] by Chris Dumez

• 30 edits in trunk/Source/WebCore

Pass reference instead of pointer to IDL attribute setters if not nullable
​https://bugs.webkit.org/show_bug.cgi?id=157250

Reviewed by Darin Adler.

Update the bindings generator so that we pass wrapper types by reference
to attribute setters instead of by raw pointer when the attribute is not
marked as nullable in the IDL.

There is no intended Web-exposed behavior change.

• Modules/speech/SpeechSynthesisUtterance.idl:
• Modules/webaudio/ConvolverNode.idl:
• bindings/js/JSDataCueCustom.cpp:

(WebCore::constructJSDataCue):

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

• bindings/scripts/CodeGeneratorObjC.pm:

(GenerateImplementation):

• bindings/scripts/test/JS/JSTestInterface.cpp:
• bindings/scripts/test/JS/JSTestObj.cpp:
• bindings/scripts/test/ObjC/DOMTestInterface.mm:
• bindings/scripts/test/ObjC/DOMTestObj.mm:

Rebaseline bindings tests.

• dom/Document.cpp:

(WebCore::Document::moveNodeIteratorsToNewDocument):

• dom/NodeIterator.cpp:

(WebCore::NodeIterator::NodePointer::NodePointer):
(WebCore::NodeIterator::NodePointer::moveToNext):
(WebCore::NodeIterator::NodePointer::moveToPrevious):
(WebCore::NodeIterator::NodeIterator):
(WebCore::NodeIterator::~NodeIterator):
(WebCore::NodeIterator::updateForNodeRemoval):
(WebCore::NodeIterator::NodePointer::clear): Deleted.
(WebCore::NodeIterator::nextNode): Deleted.

• dom/NodeIterator.h:
• dom/Traversal.cpp:

(WebCore::NodeIteratorBase::NodeIteratorBase):

• dom/Traversal.h:

(WebCore::NodeIteratorBase::root):

• dom/TreeWalker.cpp:

(WebCore::TreeWalker::setCurrentNode):
(WebCore::TreeWalker::setCurrent):
(WebCore::TreeWalker::parentNode):
(WebCore::TreeWalker::firstChild):
(WebCore::TreeWalker::lastChild):
(WebCore::TreeWalker::traverseSiblings):
(WebCore::TreeWalker::previousNode):
(WebCore::TreeWalker::nextNode):

• dom/TreeWalker.h:

(WebCore::TreeWalker::currentNode):

• dom/TreeWalker.idl:
• html/HTMLAttachmentElement.idl:
• html/HTMLInputElement.idl:
• html/HTMLTableElement.idl:
• html/track/DataCue.cpp:

(WebCore::DataCue::DataCue):
(WebCore::DataCue::setData):
(WebCore::toDataCue): Deleted.

• html/track/DataCue.h:
• html/track/DataCue.idl:

5:32 PM Changeset in webkit [200315] by commit-queue@webkit.org

• 12 edits
  2 deletes in trunk

Unreviewed, rolling out r200264 and r200266.
​https://bugs.webkit.org/show_bug.cgi?id=157251

This change caused existing LayoutTest media/media-source
/media-source-stalled-holds-sleep-assertion.html to time out
on Mac on every run. (Requested by ryanhaddad on #webkit).

Reverted changesets:

"[Mac] AirPlay fails if target is set before AVPlayer has been
created"
​https://bugs.webkit.org/show_bug.cgi?id=157147
​http://trac.webkit.org/changeset/200264

"[Mac] AirPlay fails if target is set before AVPlayer has been
created"
​https://bugs.webkit.org/show_bug.cgi?id=157147
​http://trac.webkit.org/changeset/200266

5:21 PM Changeset in webkit [200314] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Drop CanUseWTFOptionalForParameter() from bindings generator
​https://bugs.webkit.org/show_bug.cgi?id=157247

Reviewed by Darin Adler.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):
(CanUseWTFOptionalForParameter): Deleted.

5:17 PM Changeset in webkit [200313] by Darin Adler

• 13 edits in trunk/Source

Update Fetch to use enum class instead of string for enumerations
​https://bugs.webkit.org/show_bug.cgi?id=157241

Reviewed by Chris Dumez.

Source/WebCore:

• Modules/fetch/FetchOptions.h: Changed this class into a struct,

getting rid of all the getter and setter functions. Moved all the
enumeration types out of this class to the WebCore namespace level
and gave them all the names and values that match the ones from the
IDL file.

• Modules/fetch/FetchRequest.cpp:

(WebCore::setReferrerPolicy): Updated for the changes to FetchOptions.
The string matching here will likely go away when we change dictionary
so it sets up a structure, which will parse the enumeration values, but
that won't be for a while, so this stays for now.
(WebCore::setMode): Ditto.
(WebCore::setCredentials): Ditto.
(WebCore::setCache): Ditto.
(WebCore::setRedirect): Ditto.
(WebCore::buildOptions): Updated for changes to FetchOptions.
(WebCore::buildHeaders): Ditto.
(WebCore::FetchRequest::create): Ditto.
(WebCore::FetchRequest::type): Moved this to the header and changed its
return type to the enum; it's not just a single return statement.
(WebCore::FetchRequest::destination): Ditto.
(WebCore::FetchRequest::referrerPolicy): Ditto.
(WebCore::FetchRequest::mode): Ditto.
(WebCore::FetchRequest::credentials): Ditto.
(WebCore::FetchRequest::cache): Ditto.
(WebCore::FetchRequest::redirect): Ditto.

• Modules/fetch/FetchRequest.h: Changed all the getters that return

enumerations to return the enum class values instead of strings.
Put all the inline versions here in the header.

• bindings/scripts/CodeGenerator.pm: Removed the seven enum types that

are in FetchRequest.idl from the list of "string-based" enums.

• dom/Document.cpp:

(WebCore::Document::Document): Updated for the change where I
renamed ReferrerPolicy to ReferrerHeaderPolicy, at least for now.
(WebCore::Document::processReferrerPolicy): Ditto.
(WebCore::Document::applyContentDispositionAttachmentSandbox): Ditto.

• dom/Document.h: Ditto.
• loader/FrameNetworkingContext.h: Ditto.
• page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::generateReferrerHeader): Ditto.

• page/SecurityPolicy.h: Ditto.

• platform/ReferrerPolicy.h: Renamed this enum from ReferrerPolicy to

ReferrerHeaderPolicy, since the one specified in the Fetch API has the
name ReferrerPolicy. I think the best way to resolve this longer term is
to merge them since they really do represent the same concept, although
the one from the Fetch API has a few more features.

Source/WebKit2:

• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::loadResource): Updated for the change where I
renamed ReferrerPolicy to ReferrerHeaderPolicy, at least for now.
(WebKit::WebLoaderStrategy::schedulePluginStreamLoad): Ditto.

2:30 PM Changeset in webkit [200312] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Unreviewed attempt to fix Windows build after r200288.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):

2:08 PM Changeset in webkit [200311] by Konstantin Tokarev

• 2 edits in trunk/Source/WebKit2

Fixed build with !ENABLED(DATABASE_PROCESS).

Unreviewed build fix.

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::grantSandboxExtensionsToDatabaseProcessForBlobs):

1:58 PM Changeset in webkit [200310] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Unreviewed attempt to fix Windows build after r200288.

• bindings/scripts/CodeGeneratorJS.pm:

(GetEnumerationImplementationContent):

1:00 PM Changeset in webkit [200309] by youenn.fablet@crf.canon.fr

• 165 edits
  82 adds in trunk/LayoutTests

Sync web-platform-tests up to revision 4af8373
​https://bugs.webkit.org/show_bug.cgi?id=157170

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Rebasing expectations.

• resources/ImportExpectations: Skipping new test suites.

Skipping IndexedDB until we decide whether to continue having these tests here.

• resources/TestRepositories: Updating revision to 4af8373.
• resources/web-platform-tests-modules.json:
• web-platform-tests/IndexedDB/idbindex-multientry-big-expected.txt:
• web-platform-tests/IndexedDB/idbindex_get7-expected.txt:
• web-platform-tests/IndexedDB/idbindex_getKey7-expected.txt:
• web-platform-tests/IndexedDB/idbindex_openCursor2-expected.txt:
• web-platform-tests/IndexedDB/idbindex_openKeyCursor3-expected.txt:
• web-platform-tests/README.md:
• web-platform-tests/XMLHttpRequest/OWNERS:
• web-platform-tests/XMLHttpRequest/XMLHttpRequest-withCredentials-expected.txt:
• web-platform-tests/XMLHttpRequest/XMLHttpRequest-withCredentials.js:

(test_withCredentials.): Deleted.

• web-platform-tests/XMLHttpRequest/abort-during-open.htm:
• web-platform-tests/XMLHttpRequest/abort-during-open.js: Added.

(test.async_test.test.step.client.onreadystatechange):
(test.async_test.test.step):

• web-platform-tests/XMLHttpRequest/abort-during-open.worker.js: Added.
• web-platform-tests/XMLHttpRequest/data-uri-expected.txt:
• web-platform-tests/XMLHttpRequest/data-uri.htm:
• web-platform-tests/XMLHttpRequest/formdata-set-expected.txt:
• web-platform-tests/XMLHttpRequest/formdata-set.htm:
• web-platform-tests/XMLHttpRequest/interfaces-expected.txt:
• web-platform-tests/XMLHttpRequest/resources/auth7/corsenabled.py: Added.

(main):

• web-platform-tests/XMLHttpRequest/resources/auth7/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/dom/lists/w3c-import.log.
• web-platform-tests/XMLHttpRequest/resources/auth8/corsenabled-no-authorize.py: Added.

(main):

• web-platform-tests/XMLHttpRequest/resources/auth8/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/dom/lists/w3c-import.log.
• web-platform-tests/XMLHttpRequest/resources/auth9/auth.py: Added.

(main):

• web-platform-tests/XMLHttpRequest/resources/auth9/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/dom/lists/w3c-import.log.
• web-platform-tests/XMLHttpRequest/responseurl-expected.txt: Added.
• web-platform-tests/XMLHttpRequest/responseurl.html: Added.
• web-platform-tests/XMLHttpRequest/send-authentication-basic-setrequestheader-and-arguments-expected.txt: Added.
• web-platform-tests/XMLHttpRequest/send-authentication-basic-setrequestheader-and-arguments.htm: Added.
• web-platform-tests/XMLHttpRequest/send-authentication-cors-setrequestheader-no-cred-expected.txt: Added.
• web-platform-tests/XMLHttpRequest/send-authentication-cors-setrequestheader-no-cred.htm: Added.
• web-platform-tests/XMLHttpRequest/send-entity-body-document-expected.txt:
• web-platform-tests/XMLHttpRequest/send-send.htm:
• web-platform-tests/XMLHttpRequest/send-send.js: Added.

(test):

• web-platform-tests/XMLHttpRequest/send-send.worker.js: Added.
• web-platform-tests/XMLHttpRequest/setrequestheader-bogus-name-expected.txt:
• web-platform-tests/XMLHttpRequest/setrequestheader-bogus-name.htm:
• web-platform-tests/XMLHttpRequest/setrequestheader-bogus-value-expected.txt:
• web-platform-tests/XMLHttpRequest/setrequestheader-bogus-value.htm:
• web-platform-tests/XMLHttpRequest/w3c-import.log:
• web-platform-tests/common/OWNERS:
• web-platform-tests/dom/collections/HTMLCollection-as-proto-length-get-throws-expected.txt: Added.
• web-platform-tests/dom/collections/HTMLCollection-as-proto-length-get-throws.html: Added.
• web-platform-tests/dom/collections/HTMLCollection-supported-property-indices-expected.txt: Added.
• web-platform-tests/dom/collections/HTMLCollection-supported-property-indices.html: Added.
• web-platform-tests/dom/collections/w3c-import.log:
• web-platform-tests/dom/events/Event-constructors-expected.txt:
• web-platform-tests/dom/events/Event-constructors.html:
• web-platform-tests/dom/events/Event-defaultPrevented-after-dispatch-expected.txt: Added.
• web-platform-tests/dom/events/Event-defaultPrevented-after-dispatch.html: Added.
• web-platform-tests/dom/events/Event-dispatch-bubbles-false-expected.txt:
• web-platform-tests/dom/events/Event-dispatch-bubbles-false.html:
• web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt:
• web-platform-tests/dom/events/ProgressEvent-expected.txt:
• web-platform-tests/dom/events/ProgressEvent.html:
• web-platform-tests/dom/events/w3c-import.log:
• web-platform-tests/dom/interfaces-expected.txt:
• web-platform-tests/dom/interfaces.html:
• web-platform-tests/dom/lists/DOMTokenList-value-expected.txt: Added.
• web-platform-tests/dom/lists/DOMTokenList-value.html: Added.
• web-platform-tests/dom/lists/w3c-import.log:
• web-platform-tests/dom/nodes/CharacterData-appendChild-expected.txt: Added.
• web-platform-tests/dom/nodes/CharacterData-appendChild.html: Added.
• web-platform-tests/dom/nodes/DOMImplementation-createDocument-expected.txt:
• web-platform-tests/dom/nodes/DOMImplementation-createDocument.html:
• web-platform-tests/dom/nodes/Document-Element-getElementsByTagName.js:

(test_getElementsByTagName):

• web-platform-tests/dom/nodes/Document-characterSet-normalization-expected.txt:
• web-platform-tests/dom/nodes/Document-characterSet-normalization.html:
• web-platform-tests/dom/nodes/Document-createElement-namespace-expected.txt:
• web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.html: Added.
• web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.svg: Added.
• web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xhtml: Added.
• web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xml: Added.
• web-platform-tests/dom/nodes/Document-createElement-namespace.html:
• web-platform-tests/dom/nodes/Document-createEvent-expected.txt:
• web-platform-tests/dom/nodes/Document-createEvent.html:
• web-platform-tests/dom/nodes/Document-createEvent.js:
• web-platform-tests/dom/nodes/Document-getElementsByTagName-expected.txt:
• web-platform-tests/dom/nodes/Document-getElementsByTagName-xhtml-expected.txt:
• web-platform-tests/dom/nodes/Document-getElementsByTagName-xhtml.xhtml:
• web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt:
• web-platform-tests/dom/nodes/Element-hasAttributes-expected.txt: Added.
• web-platform-tests/dom/nodes/Element-hasAttributes.html: Added.
• web-platform-tests/dom/nodes/Element-insertAdjacentElement-expected.txt: Added.
• web-platform-tests/dom/nodes/Element-insertAdjacentElement.html: Added.
• web-platform-tests/dom/nodes/Element-insertAdjacentText-expected.txt: Added.
• web-platform-tests/dom/nodes/Element-insertAdjacentText.html: Added.
• web-platform-tests/dom/nodes/Node-contains-xml-expected.txt: Added.
• web-platform-tests/dom/nodes/Node-contains-xml.xml: Added.
• web-platform-tests/dom/nodes/Node-isSameNode-expected.txt: Added.
• web-platform-tests/dom/nodes/Node-isSameNode.html: Added.
• web-platform-tests/dom/nodes/Node-parentElement.html:
• web-platform-tests/dom/nodes/Node-replaceChild-expected.txt:
• web-platform-tests/dom/nodes/Node-replaceChild.html:
• web-platform-tests/dom/nodes/attributes-expected.txt:
• web-platform-tests/dom/nodes/attributes.html:
• web-platform-tests/dom/nodes/attributes.js:

(attr_is):

• web-platform-tests/dom/nodes/case-expected.txt:
• web-platform-tests/dom/nodes/case.js:

(get_qualified_name):
(test_get_elements_tag_name):

• web-platform-tests/dom/nodes/insert-adjacent-expected.txt: Added.
• web-platform-tests/dom/nodes/insert-adjacent.html: Added.
• web-platform-tests/dom/nodes/remove-unscopable-expected.txt: Added.
• web-platform-tests/dom/nodes/remove-unscopable.html: Added.
• web-platform-tests/dom/nodes/rootNode-expected.txt: Added.
• web-platform-tests/dom/nodes/rootNode.html: Added.
• web-platform-tests/dom/nodes/w3c-import.log:
• web-platform-tests/dom/ranges/Range-stringifier-expected.txt: Added.
• web-platform-tests/dom/ranges/Range-stringifier.html: Added.
• web-platform-tests/dom/ranges/w3c-import.log:
• web-platform-tests/dom/traversal/TreeWalker-acceptNode-filter.html:
• web-platform-tests/dom/traversal/TreeWalker-basic.html:
• web-platform-tests/dom/traversal/TreeWalker-currentNode.html:
• web-platform-tests/dom/traversal/TreeWalker-previousNodeLastChildReject.html:
• web-platform-tests/dom/traversal/TreeWalker-previousSiblingLastChildSkip.html:
• web-platform-tests/dom/traversal/TreeWalker-traversal-reject.html:
• web-platform-tests/dom/traversal/TreeWalker-traversal-skip-most.html:
• web-platform-tests/dom/traversal/TreeWalker-traversal-skip.html:
• web-platform-tests/dom/traversal/TreeWalker-walking-outside-a-tree.html:
• web-platform-tests/fetch/api/cors/cors-preflight.js:
• web-platform-tests/fetch/api/credentials/cookies.js:

(cookies):

• web-platform-tests/fetch/api/policies/referrer-origin-expected.txt:
• web-platform-tests/fetch/api/policies/referrer-origin.js:

(promise_test):

• web-platform-tests/fetch/api/request/request-consume.html:
• web-platform-tests/fetch/api/request/resources/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/dom/lists/w3c-import.log.
• web-platform-tests/fetch/api/request/w3c-import.log:
• web-platform-tests/fetch/api/resources/utils.js:

(validateStreamFromString):

• web-platform-tests/fetch/api/response/response-cancel-stream-expected.txt:
• web-platform-tests/fetch/api/response/response-consume-stream-expected.txt:
• web-platform-tests/fetch/api/response/w3c-import.log:
• web-platform-tests/html/OWNERS:
• web-platform-tests/html/dom/documents/dom-tree-accessors/Document.getElementsByClassName-null-undef.html:
• web-platform-tests/html/dom/documents/dom-tree-accessors/Element.getElementsByClassName-null-undef.html:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByClassName-same.html:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-case-xhtml.xhtml:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-case.html:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-id-xhtml.xhtml:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-id.html:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-namespace-xhtml.xhtml:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-namespace.html:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-xhtml.xhtml:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements.html:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-param-xhtml.xhtml:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-param.html:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-same.html:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.head-01.html:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.head-02.html:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-01.html:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-02.xhtml:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-03.html:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-04.xhtml:
• web-platform-tests/html/dom/elements/global-attributes/id-name-specialcase.html:
• web-platform-tests/html/dom/elements/global-attributes/id-name.html:
• web-platform-tests/html/dom/interfaces-expected.txt:
• web-platform-tests/html/dom/interfaces.html:
• web-platform-tests/html/resources/common.js:

(isVoidElement): Deleted.

• web-platform-tests/html/semantics/document-metadata/the-link-element/resources/stylesheet.css: Added.

(body):

• web-platform-tests/html/semantics/document-metadata/the-link-element/resources/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/dom/lists/w3c-import.log.
• web-platform-tests/html/semantics/document-metadata/the-link-element/stylesheet-with-base-expected.html: Added.
• web-platform-tests/html/semantics/document-metadata/the-link-element/stylesheet-with-base.html: Added.
• web-platform-tests/html/semantics/document-metadata/the-link-element/stylesheet.css: Added.

(body):

• web-platform-tests/html/semantics/document-metadata/the-link-element/w3c-import.log:
• web-platform-tests/html/semantics/embedded-content/the-canvas-element/2d.scaled.png: Added.
• web-platform-tests/html/semantics/embedded-content/the-canvas-element/w3c-import.log:
• web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-ignored-in-media-element-expected.txt: Added.
• web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-ignored-in-media-element.html: Added.
• web-platform-tests/html/semantics/embedded-content/the-embed-element/w3c-import.log:
• web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-with-base-expected.html: Added.
• web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-with-base.html: Added.
• web-platform-tests/html/semantics/embedded-content/the-iframe-element/w3c-import.log:
• web-platform-tests/html/semantics/embedded-content/the-img-element/document-base-url-expected.html: Added.
• web-platform-tests/html/semantics/embedded-content/the-img-element/document-base-url.html: Added.
• web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/viewport-change-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/resources/cat.jpg: Added.
• web-platform-tests/html/semantics/embedded-content/the-img-element/resources/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/dom/lists/w3c-import.log.
• web-platform-tests/html/semantics/embedded-content/the-img-element/w3c-import.log:
• web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt:
• web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput.html:
• web-platform-tests/html/semantics/forms/form-submission-0/getactionurl-expected.txt: Added.
• web-platform-tests/html/semantics/forms/form-submission-0/getactionurl.html: Added.
• web-platform-tests/html/semantics/forms/form-submission-0/w3c-import.log:
• web-platform-tests/html/semantics/forms/textfieldselection/selection-after-content-change-expected.txt: Added.
• web-platform-tests/html/semantics/forms/textfieldselection/selection-after-content-change.html: Added.
• web-platform-tests/html/semantics/forms/textfieldselection/w3c-import.log:
• web-platform-tests/html/semantics/forms/the-form-element/form-autocomplete-expected.txt:
• web-platform-tests/html/semantics/forms/the-form-element/form-autocomplete.html:
• web-platform-tests/html/semantics/forms/the-input-element/checkbox.html:
• web-platform-tests/html/semantics/forms/the-input-element/selection-expected.txt: Added.
• web-platform-tests/html/semantics/forms/the-input-element/selection.html: Added.
• web-platform-tests/html/semantics/forms/the-input-element/w3c-import.log:
• web-platform-tests/html/semantics/forms/the-legend-element/legend-form-expected.txt:
• web-platform-tests/html/semantics/forms/the-legend-element/legend-form.html:
• web-platform-tests/html/semantics/grouping-content/the-ol-element/ol.start-reflection-1.html:
• web-platform-tests/html/semantics/grouping-content/the-ol-element/ol.start-reflection-2.html:
• web-platform-tests/html/semantics/links/linktypes/alternate-css-expected.html: Added.
• web-platform-tests/html/semantics/links/linktypes/alternate-css.html: Added.
• web-platform-tests/html/semantics/links/linktypes/alternate.css: Added.

(div):

• web-platform-tests/html/semantics/links/linktypes/preferred.css: Added.

(div):

• web-platform-tests/html/semantics/links/linktypes/w3c-import.log:
• web-platform-tests/html/semantics/selectors/pseudo-classes/default-expected.txt:
• web-platform-tests/html/semantics/selectors/pseudo-classes/default.html:
• web-platform-tests/html/semantics/selectors/pseudo-classes/focus-autofocus-expected.txt: Added.
• web-platform-tests/html/semantics/selectors/pseudo-classes/focus-autofocus.html: Added.
• web-platform-tests/html/semantics/selectors/pseudo-classes/focus-expected.txt:
• web-platform-tests/html/semantics/selectors/pseudo-classes/focus.html:
• web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange-expected.txt:
• web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange.html:
• web-platform-tests/html/semantics/selectors/pseudo-classes/link-expected.txt:
• web-platform-tests/html/semantics/selectors/pseudo-classes/link.html:
• web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly-expected.txt:
• web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly.html:
• web-platform-tests/html/semantics/selectors/pseudo-classes/w3c-import.log:
• web-platform-tests/html/semantics/tabular-data/the-table-element/insertRow-method-03-expected.txt: Added.
• web-platform-tests/html/semantics/tabular-data/the-table-element/insertRow-method-03.html: Added.
• web-platform-tests/html/semantics/tabular-data/the-table-element/tFoot-expected.txt: Added.
• web-platform-tests/html/semantics/tabular-data/the-table-element/tFoot.html: Added.
• web-platform-tests/html/semantics/tabular-data/the-table-element/tHead-expected.txt: Added.
• web-platform-tests/html/semantics/tabular-data/the-table-element/tHead.html: Added.
• web-platform-tests/html/semantics/tabular-data/the-table-element/w3c-import.log:
• web-platform-tests/lint.whitelist:
• web-platform-tests/media/OWNERS:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-add.https.html:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-delete.https.html:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https.html:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-matchAll.https.html:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-put.https.html:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-keys.https.html:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-match.https.html:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage.https.html:
• web-platform-tests/service-workers/cache-storage/serviceworker/credentials.html:
• web-platform-tests/streams/byte-length-queuing-strategy.js:

(test):

• web-platform-tests/streams/count-queuing-strategy.js:

(test):

• web-platform-tests/streams/readable-streams/bad-strategies.js:

(get string_appeared_here):
(promise_test):

• web-platform-tests/streams/readable-streams/bad-underlying-sources.https-expected.txt:
• web-platform-tests/streams/readable-streams/bad-underlying-sources.js:

(promise_test):
(promise_test.t.const.closed.new.ReadableStream.start):

• web-platform-tests/streams/readable-streams/cancel.js:

(promise_test): Deleted.

• web-platform-tests/streams/readable-streams/general.https-expected.txt:
• web-platform-tests/streams/readable-streams/general.js:

(test):
(promise_test):
(promise_test.t.const.rs.new.ReadableStream.pull):
(promise_test.t.const.rs.new.ReadableStream.start): Deleted.

• web-platform-tests/streams/readable-streams/readable-stream-reader.js:

(test):

• web-platform-tests/streams/readable-streams/templated.https-expected.txt:
• web-platform-tests/streams/resources/rs-test-templates.js:

(self.templatedRSEmpty):

LayoutTests:

• platform/ios-simulator/TestExpectations: Marking some tests as failing.
• platform/wk2/imported/w3c/web-platform-tests/html/semantics/document-metadata/styling/LinkStyle-expected.txt:

12:22 PM Changeset in webkit [200308] by bshafiei@apple.com

• 5 edits in tags/Safari-602.1.30.2/Source

Versioning.

12:19 PM Changeset in webkit [200307] by bshafiei@apple.com

• 1 copy in tags/Safari-602.1.30.2

New tag.

11:56 AM Changeset in webkit [200306] by mitz@apple.com

• 1 edit
  1 delete in trunk/Source/WebInspectorUI

WebInspectorUI.framework/Versions/A/Resources/Images/Legacy is empty
​https://bugs.webkit.org/show_bug.cgi?id=157248

Reviewed by Timothy Hatcher.

• UserInterface/Images/Legacy: Removed.

10:52 AM Changeset in webkit [200305] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Unreviewed, rebaseline bindings tests after r200300.

• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsStringWithCache):

9:37 AM Changeset in webkit [200304] by Darin Adler

• 5 edits in trunk/Source/WebCore

Use enum class instead of string-based enums in RTC code
​https://bugs.webkit.org/show_bug.cgi?id=157242

Reviewed by Alex Christensen.

• Modules/mediastream/RTCConfiguration.cpp:

(WebCore::RTCConfiguration::RTCConfiguration): Don't initialize members here,
do it in the header instead.
(WebCore::RTCConfiguration::initialize): Initialize data members to enum values,
not strings.

• Modules/mediastream/RTCConfiguration.h: Tried to keep this class compiling.

Added the new enum class, and changed to use that instead of strings. But note,
this should not even be a class. Needs to become a dictionary.

• Modules/mediastream/RTCConfiguration.idl: Updated the names and values of the

enums to match the current RTC specification. Again, as I said, this should be
a dictionary, not an interface.

• bindings/scripts/CodeGenerator.pm: Removed the RTC enumerations from the list

of string-based enums.

7:09 AM Changeset in webkit [200303] by youenn.fablet@crf.canon.fr

• 3 edits
  4 adds in trunk/LayoutTests/imported/w3c

Fix 157169

Update W3C importer files related to csswg-test files after r200234
​https://bugs.webkit.org/show_bug.cgi?id=157169

Reviewed by Ryosuke Niwa.

Updating ImportExpectations to import css-scoping-1 test suite only from css wg test repository.
Updating TestRepositories to set the current csswg-test revision to b2daa426addd5ccb8e9ce1c5d800f9d82603f1ec.
Rerun test importer to add some additional files (document, license...).

• csswg-test/CONTRIBUTING.md: Added.
• csswg-test/LICENSE: Added.
• csswg-test/README.md: Added.
• csswg-test/w3c-import.log: Added.
• resources/ImportExpectations:
• resources/TestRepositories:

Apr 30, 2016:

11:07 PM Changeset in webkit [200302] by Antti Koivisto

• 3 edits
  2 adds in trunk

REGRESSION (r199640): position:absolute generated content inherits text-decoration from its element
​https://bugs.webkit.org/show_bug.cgi?id=157199
<rdar://problem/26013111>

Reviewed by Zalan Bujtas.

Source/WebCore:

Test: fast/css/text-decoration-inheritance-pseudo.html

• css/StyleResolver.cpp:

(WebCore::doesNotInheritTextDecoration):
(WebCore::StyleResolver::adjustRenderStyle):

There was an accidental logic change here. Even if element is null other conditions may make this test true.

LayoutTests:

• fast/css/text-decoration-inheritance-pseudo-expected.html: Added.
• fast/css/text-decoration-inheritance-pseudo.html: Added.

10:42 PM Changeset in webkit [200301] by Alan Bujtas

• 4 edits
  2 adds in trunk

Some content causes deep recursion.
​https://bugs.webkit.org/show_bug.cgi?id=157230
<rdar://problem/7694756>

Reviewed by Antti Koivisto.

This patch sets a limit(512) on content nesting for the render tree. Elements injected over the limit
are still accessible through DOM APIs but

1. we stop generating renderers for them -they behave like display: none.
2. their layout related computed style values are set to default (e.g. window.computedStyle(document.elementById("over512").width -> auto)

Source/WebCore:

Test: fast/block/nested-renderers.html

• page/Settings.h:
• style/StyleTreeResolver.cpp: Skip renderer constructing and continue with the sibling node.

(WebCore::Style::TreeResolver::resolveComposedTree):

LayoutTests:

• fast/block/nested-renderers-expected.html: Added.
• fast/block/nested-renderers.html: Added.

9:50 PM Changeset in webkit [200300] by Darin Adler

• 6 edits in trunk/Source/WebCore

Update XMLHttpRequest to use enum class instead of string for enumeration
​https://bugs.webkit.org/show_bug.cgi?id=157238

Reviewed by Chris Dumez.

• bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::response): Rewrite to use responseType function
instead of responseTypeCode function.

• bindings/scripts/CodeGenerator.pm: Removed XMLHttpRequestResponseType

from the list of enumerations that use a string-based implementation.

• bindings/scripts/CodeGeneratorJS.pm:

(GetEnumerationImplementationContent): Use emptyString instead of ASCIILiteral
when the string constant is empty, to avoid the assertion.

• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::XMLHttpRequest): Move simple scalar data member
initialization to where the data members are defined in the header.
(WebCore::XMLHttpRequest::responseText): Use m_responseType instead of
m_responseTypeCode.
(WebCore::XMLHttpRequest::didCacheResponseJSON): Ditto.
(WebCore::XMLHttpRequest::responseXML): Ditto.
(WebCore::XMLHttpRequest::responseBlob): Ditto.
(WebCore::XMLHttpRequest::responseArrayBuffer): Ditto.
(WebCore::XMLHttpRequest::setResponseType): Ditto.
(WebCore::XMLHttpRequest::responseType): Moved to header now that it's a
trivial function that should be inlined.
(WebCore::XMLHttpRequest::open): Use m_responseType instead of
m_responseTypeCode.
(WebCore::XMLHttpRequest::responseMIMEType): Removed one redundant check.
(WebCore::XMLHttpRequest::status): Ditto.
(WebCore::XMLHttpRequest::statusText): Ditto.
(WebCore::shouldDecodeResponse): Moved here from the header. This is now
a non-member function that gets passed a response type. It uses a switch
now instead of ordering the types so that the binary ones are all at the
end of the list.
(WebCore::XMLHttpRequest::didReceiveData): Use the new shouldDecodeResponse.
Also removed an unnecessary check that non-decoded responses are of type
"arraybuffer" or "blob"; that's the same check that shouldDecodeResponse does.

• xml/XMLHttpRequest.h: Removed some unneeded includes and forward declarations.

Removed a comment about the State values needing to be stable numbers; for one
thing the bindings already check that these values have no changed. It's not a
valuable comment. Removed ResponseTypeCode, responseTypeCode, and
m_responseTypeCode. Changed the type of the result of responseType and the
argument to setResponseType from a string to XMLHttpRequestResponseType.
Removed shouldDecodeResponse. Added the initial values for lots of data members
that are simple scalars, matching what was set in the constructor before.

9:17 PM Changeset in webkit [200299] by Darin Adler

• 24 edits in trunk

Streamline and remove unused bindings generation code
​https://bugs.webkit.org/show_bug.cgi?id=157237

Reviewed by Chris Dumez.

Source/WebCore:

• Modules/notifications/NotificationCenter.idl: Replace non-standard "int"

with standard "long", which means the same thing.

• bindings/scripts/CodeGenerator.pm:

(UpdateFile): Use a better perl idiom for open.
(IsTypedArrayType): Use a hash instead of a list of checks in the code.
(IsRefPtrType): Use GetArrayOrSequenceType. Add handling for "any", which
is not a "RefPtr" type.
(IsWrapperType): Build on top of IsRefPtr type so we don't have to repeat
the list.
(getInterfaceExtendedAttributesFromName): Added a FIXME about why this is no good.
(ComputeIsCallbackInterface): Renamed.
(IsCallbackInterface): Added a cache so we don't keep reading the same file
over and over again. Added a FIXME about why this is no good.
(ComputeIsFunctionOnlyCallbackInterface): Ditto.
(IsFunctionOnlyCallbackInterface): Ditto.

• bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForType): Use GetArrayOrSequenceType.
(IsScriptProfileType): Deleted.
(AddTypedefForScriptProfileType): Deleted.
(AddClassForwardIfNeeded): Streamlined the code and made the ScriptProfileNode
special case easier to read.
(GenerateParametersCheckExpression): Use GetArrayOrSequenceType.
(GetFunctionLength): Tweaked formatting and argument names.
(GenerateImplementation): Merged a couple checks into a single if statement.
(WillConvertUndefinedToDefaultParameterValue): Streamlined the function by
using a hash instead of a sequence of if statements for most cases.
(GetNativeType): Use GetArrayOrSequenceType.
(JSValueToNative): Do the integer conversion based on a hash rather than
with lots of separate lines of code. Moved more of the simple names down to
the bottom of the function and streamlined the logic. Removed unnecessary
includes of the DOM headers directly, since our header file includes those.
(NativeToJSValue): Factored out the global object handling so it works across
more cases. Simplified the logic for dates. Use IsNumericType instead of
IsPrimitiveType to guard code that is right only for the numeric types.
Removed code to handle "Symbol" since we don't ever use that.

• bindings/scripts/test/JS/JSTestCallback.cpp:
• bindings/scripts/test/JS/JSTestCallbackFunction.cpp:
• bindings/scripts/test/JS/JSTestInterface.cpp:
• bindings/scripts/test/JS/JSTestObj.cpp:
• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

Regenerated.

• bindings/scripts/test/TestObj.idl: Removed test coverage for Symbol, which

we never use anywhere.

• html/canvas/EXTBlendMinMax.idl: Replace non-standard "int" with standard

"long", which means the same thing.

• html/canvas/EXTTextureFilterAnisotropic.idl: Ditto.
• html/canvas/EXTsRGB.idl: Ditto.
• html/canvas/OESStandardDerivatives.idl: Ditto.
• html/canvas/OESVertexArrayObject.idl: Ditto.
• html/canvas/WebGLCompressedTextureATC.idl: Ditto.
• html/canvas/WebGLCompressedTexturePVRTC.idl: Ditto.
• html/canvas/WebGLCompressedTextureS3TC.idl: Ditto.
• html/canvas/WebGLDebugRendererInfo.idl: Ditto.
• html/canvas/WebGLDepthTexture.idl: Ditto.

Tools:

• WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
• WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:

Replace non-standard "int" with standard "long", which means the same thing.

3:06 PM Changeset in webkit [200298] by Chris Dumez

• 46 edits in trunk

[Web IDL] Pass even more types by reference
​https://bugs.webkit.org/show_bug.cgi?id=157231

Reviewed by Darin Adler.

Source/WebCore:

Pass even more types by reference when the parameters are not marked as
nullable in the IDL.

• Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::generateKeyRequest):
(WebCore::MediaKeySession::keyRequestTimerFired):
(WebCore::MediaKeySession::update):
(WebCore::MediaKeySession::addKeyTimerFired):

• Modules/encryptedmedia/MediaKeySession.h:
• Modules/encryptedmedia/MediaKeys.cpp:

(WebCore::MediaKeys::createSession):

• Modules/encryptedmedia/MediaKeys.h:
• Modules/encryptedmedia/MediaKeys.idl:
• Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::appendBuffer):
(WebCore::SourceBuffer::resetParserState): Deleted.

• Modules/mediasource/SourceBuffer.h:
• Modules/mediastream/RTCDataChannel.cpp:

(WebCore::RTCDataChannel::send):

• Modules/mediastream/RTCDataChannel.h:
• Modules/webaudio/AnalyserNode.h:

(WebCore::AnalyserNode::getFloatFrequencyData):
(WebCore::AnalyserNode::getByteFrequencyData):
(WebCore::AnalyserNode::getByteTimeDomainData):

• Modules/webaudio/AnalyserNode.idl:
• Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::createPeriodicWave):

• Modules/webaudio/AudioContext.h:
• Modules/webaudio/AudioParam.h:

(WebCore::AudioParam::setValueCurveAtTime):

• Modules/webaudio/AudioParam.idl:
• Modules/webaudio/BiquadFilterNode.cpp:

(WebCore::BiquadFilterNode::getFrequencyResponse):

• Modules/webaudio/BiquadFilterNode.h:
• Modules/webaudio/BiquadFilterNode.idl:
• Modules/webaudio/PeriodicWave.cpp:

(WebCore::PeriodicWave::create):
(WebCore::PeriodicWave::createSine): Deleted.

• Modules/webaudio/PeriodicWave.h:
• Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::send):

• Modules/websockets/WebSocket.h:
• bindings/js/JSWebGLRenderingContextBaseCustom.cpp:

(WebCore::dataFunctionf):
(WebCore::dataFunctioni):
(WebCore::dataFunctionMatrix):

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):
(ShouldPassWrapperByReference):

• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionDomStringListFunction):

• bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::constructJSTestOverloadedConstructors2):

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::webkitAddKey):
(WebCore::HTMLMediaElement::webkitCancelKeyRequest): Deleted.

• html/HTMLMediaElement.h:
• html/HTMLMediaElement.idl:
• html/ImageData.cpp:

(WebCore::ImageData::create):
(WebCore::ImageData::ImageData):

• html/ImageData.h:
• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::getImageData):

• html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::texImage3D):
(WebCore::WebGL2RenderingContext::texSubImage3D):
(WebCore::WebGL2RenderingContext::compressedTexImage3D):
(WebCore::WebGL2RenderingContext::compressedTexSubImage3D):
(WebCore::WebGL2RenderingContext::uniform1uiv):
(WebCore::WebGL2RenderingContext::uniform2uiv):
(WebCore::WebGL2RenderingContext::uniform3uiv):
(WebCore::WebGL2RenderingContext::uniform4uiv):
(WebCore::WebGL2RenderingContext::uniformMatrix2x3fv):
(WebCore::WebGL2RenderingContext::uniformMatrix3x2fv):
(WebCore::WebGL2RenderingContext::uniformMatrix2x4fv):
(WebCore::WebGL2RenderingContext::uniformMatrix4x2fv):
(WebCore::WebGL2RenderingContext::uniformMatrix3x4fv):
(WebCore::WebGL2RenderingContext::uniformMatrix4x3fv):
(WebCore::WebGL2RenderingContext::vertexAttribI4iv):
(WebCore::WebGL2RenderingContext::vertexAttribI4uiv):
(WebCore::WebGL2RenderingContext::clearBufferiv):
(WebCore::WebGL2RenderingContext::clearBufferuiv):
(WebCore::WebGL2RenderingContext::clearBufferfv):
(WebCore::WebGL2RenderingContext::getActiveUniforms):
(WebCore::WebGL2RenderingContext::texSubImage2D):

• html/canvas/WebGL2RenderingContext.h:
• html/canvas/WebGL2RenderingContext.idl:
• html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::texSubImage2D):

• html/canvas/WebGLRenderingContext.h:
• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::bufferData):
(WebCore::WebGLRenderingContextBase::bufferSubData):
(WebCore::WebGLRenderingContextBase::compressedTexImage2D):
(WebCore::WebGLRenderingContextBase::compressedTexSubImage2D):
(WebCore::WebGLRenderingContextBase::readPixels):
(WebCore::WebGLRenderingContextBase::texImage2D):
(WebCore::WebGLRenderingContextBase::uniform1fv):
(WebCore::WebGLRenderingContextBase::uniform1iv):
(WebCore::WebGLRenderingContextBase::uniform2fv):
(WebCore::WebGLRenderingContextBase::uniform2iv):
(WebCore::WebGLRenderingContextBase::uniform3fv):
(WebCore::WebGLRenderingContextBase::uniform3iv):
(WebCore::WebGLRenderingContextBase::uniform4fv):
(WebCore::WebGLRenderingContextBase::uniform4iv):
(WebCore::WebGLRenderingContextBase::uniformMatrix2fv):
(WebCore::WebGLRenderingContextBase::uniformMatrix3fv):
(WebCore::WebGLRenderingContextBase::uniformMatrix4fv):
(WebCore::WebGLRenderingContextBase::vertexAttrib1fv):
(WebCore::WebGLRenderingContextBase::vertexAttrib2fv):
(WebCore::WebGLRenderingContextBase::vertexAttrib3fv):
(WebCore::WebGLRenderingContextBase::vertexAttrib4fv):
(WebCore::WebGLRenderingContextBase::validateCompressedTexFuncData):
(WebCore::WebGLRenderingContextBase::validateUniformParameters):
(WebCore::WebGLRenderingContextBase::validateUniformMatrixParameters):
(WebCore::WebGLRenderingContextBase::vertexAttribfvImpl):
(WebCore::WebGLRenderingContextBase::validateSettableTexFormat): Deleted.
(WebCore::WebGLRenderingContextBase::uniform1i): Deleted.
(WebCore::WebGLRenderingContextBase::uniform2i): Deleted.
(WebCore::WebGLRenderingContextBase::uniform3f): Deleted.
(WebCore::WebGLRenderingContextBase::uniform3i): Deleted.
(WebCore::WebGLRenderingContextBase::uniform4f): Deleted.
(WebCore::WebGLRenderingContextBase::uniform4i): Deleted.
(WebCore::WebGLRenderingContextBase::useProgram): Deleted.
(WebCore::WebGLRenderingContextBase::vertexAttribPointer): Deleted.
(WebCore::WebGLRenderingContextBase::validateCompressedTexDimensions): Deleted.
(WebCore::WebGLRenderingContextBase::validateBufferDataParameters): Deleted.

• html/canvas/WebGLRenderingContextBase.h:
• html/canvas/WebGLRenderingContextBase.idl:
• testing/Internals.cpp:

(WebCore::Internals::createTimeRanges):

• testing/Internals.h:

LayoutTests:

Update test now that slightly different exceptions are thrown.

• media/encrypted-media/encrypted-media-v2-syntax-expected.txt:
• media/encrypted-media/encrypted-media-v2-syntax.html:

2:58 PM Changeset in webkit [200297] by rniwa@webkit.org

• 4 edits
  4 deletes in trunk

Node.prototype.rootNode is not Web compatible
​https://bugs.webkit.org/show_bug.cgi?id=157233

Reviewed by Chris Dumez.

Source/WebCore:

Turns out that the name rootNode is not Web compatible. Remove the method for now
until we can come up with a better name in ​https://github.com/whatwg/dom/issues/241.

No new tests since we're just removing a method.

• dom/Node.idl:

LayoutTests:

Removed tests for Node.prototype.rootNode.

• fast/dom/Node/rootNode-expected.txt: Removed.
• fast/dom/Node/rootNode.html: Removed.
• fast/shadow-dom/Node-interface-rootNode-expected.txt: Removed.
• fast/shadow-dom/Node-interface-rootNode.html: Removed.
• js/dom/dom-static-property-for-in-iteration-expected.txt:

2:41 PM Changeset in webkit [200296] by Darin Adler

• 2 edits in trunk/Source/WebCore

Try to fix GTK build.

• testing/Internals.h: Added conditional around include of

MediaSessionInterruptionProvider.h.

2:21 PM Changeset in webkit [200295] by Konstantin Tokarev

• 2 edits in trunk/Source/JavaScriptCore

Guard ObjC-specific code in Heap.cpp with USE(FOUNDATION)
​https://bugs.webkit.org/show_bug.cgi?id=157236

Reviewed by Darin Adler.

This also fixes build with GCC 4.8 which does not provide
has_include.

• heap/Heap.cpp:

1:26 PM Changeset in webkit [200294] by Darin Adler

• 32 edits in trunk/Source/WebCore

Stop using old-style string-based enums in Internals.idl
​https://bugs.webkit.org/show_bug.cgi?id=157235

Reviewed by Chris Dumez.

• bindings/scripts/CodeGenerator.pm: Removed the six enumeration names

that are used in Internals.idl.
(GenerateCompileTimeCheckForEnumsIfNeeded): Unrelated cleanup. Tighten
code and use static_assert instead of COMPILE_ASSERT.
(IsStringType): Marked this function as deprecated. Calling a function
just to check if something is specifically "DOMString" isn't a good pattern.
Lots of call sites were checking "DOMString" directly and there is no
reason to mix the two different idioms.

• bindings/scripts/CodeGeneratorJS.pm:

(GetEnumerationImplementationContent): Use GenerateConditionalString.
(GenerateImplementation): Use static_assert instead of COMPILE_ASSERT.
(GenerateCallbackHeader): Tighten code. Remove peculiar code that was
trying to emit COMPILE_ASSERT(false); not an important case to detect, and
if we did want to detect it, then having the code generator report an error
is better than COMPILE_ASSERT when compiling the output.
(NativeToJSValue): Stop using IsStringType.

• bindings/scripts/CodeGeneratorObjC.pm:

(GetClassName): Stop using IsStringType.
(GetPropertyAttributes): Ditto.
(ConversionNeeded): Ditto.
(GetObjCTypeGetter): Ditto.
(AddIncludesForType): Ditto.
(GenerateImplementation): Removed unused @needsAssert. It was a write-only
variable.

• bindings/scripts/IDLParser.pm:

(parseEnum): Put the extended attributes into the enumeration object.

• bindings/scripts/test/TestObj.idl: Added test cases for the Conditional

extended attribute, used with enumerations.

• bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
• bindings/scripts/test/JS/JSTestCallback.cpp:
• bindings/scripts/test/JS/JSTestCallback.h:
• bindings/scripts/test/JS/JSTestCallbackFunction.h:
• bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
• bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
• bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
• bindings/scripts/test/JS/JSTestEventConstructor.cpp:
• bindings/scripts/test/JS/JSTestEventTarget.cpp:
• bindings/scripts/test/JS/JSTestException.cpp:
• bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
• bindings/scripts/test/JS/JSTestGlobalObject.cpp:
• bindings/scripts/test/JS/JSTestInterface.cpp:
• bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
• bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
• bindings/scripts/test/JS/JSTestNondeterministic.cpp:
• bindings/scripts/test/JS/JSTestObj.cpp:
• bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
• bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
• bindings/scripts/test/JS/JSTestTypedefs.cpp:
• bindings/scripts/test/JS/JSattribute.cpp:
• bindings/scripts/test/JS/JSreadonly.cpp:

Regenerated.

• testing/Internals.cpp:

(WebCore::toResourceRequestCachePolicy): Take enum instead of string.
(WebCore::Internals::setOverrideCachePolicy): Ditto.
(WebCore::toResourceLoadPriority): Ditto.
(WebCore::Internals::setOverrideResourceLoadPriority): Ditto.
(WebCore::toAutoFillButtonType): Ditto.
(WebCore::Internals::setShowAutoFillButton): Ditto.
(WebCore::interruptingCategoryFromString): Deleted.
(WebCore::Internals::sendMediaSessionStartOfInterruptionNotification): Ditto.
(WebCore::Internals::sendMediaSessionEndOfInterruptionNotification): Ditto.
(WebCore::Internals::sendMediaControlEvent): Ditto.
(WebCore::Internals::installMockPageOverlay): Ditto.

• testing/Internals.h: Added enum class and use those instead of strings for

enumerations defined in the IDL.

• testing/Internals.idl: Renamed enumerations that conflict with ones that already

exist in WebCore; added Internals prefix. Made MediaSessionInterruptingCategory and
MediaControlEvent conditional to match the functions they are used on. Added some
FIXMEs about peculiarities of some of the enumerations.

1:05 PM Changeset in webkit [200293] by Yusuke Suzuki

• 3 edits
  1 add in trunk/Source/JavaScriptCore

Assertion failure for destructuring assignment with new.target and unary operator
​https://bugs.webkit.org/show_bug.cgi?id=157149

Reviewed by Saam Barati.

The caller of parseDefaultValueForDestructuringPattern() should propagate errors.
And this patch also cleans up createSavePoint and createSavePointForError; introducing SavePointWithError.

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseSourceElements):
(JSC::Parser<LexerType>::parseDestructuringPattern):
Add propagateErorr() for parseDefaultValueForDestructuringPattern.

(JSC::Parser<LexerType>::parseAssignmentExpression):

• parser/Parser.h:

(JSC::Parser::restoreLexerState):
(JSC::Parser::internalSaveState):
(JSC::Parser::createSavePointForError):
(JSC::Parser::createSavePoint):
(JSC::Parser::internalRestoreState):
(JSC::Parser::restoreSavePointWithError):
(JSC::Parser::restoreSavePoint):

• tests/stress/default-value-parsing-should-propagate-error.js: Added.

(testSyntaxError):
(testSyntaxError.f):

12:34 PM Changeset in webkit [200292] by Darin Adler

• 2 edits in trunk/Source/WebCore

Fixed expected results from bindings tests.

• bindings/scripts/test/JS/JSTestObj.cpp: Regenerated.

12:16 PM Changeset in webkit [200291] by Darin Adler

• 64 edits in trunk

Next batch of conversions to use C++ enum class instead of strings for enumerations
​https://bugs.webkit.org/show_bug.cgi?id=157232

Reviewed by Chris Dumez.

Source/WebCore:

• Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::error): Use ResponseType.
(WebCore::FetchResponse::redirect): Ditto.
(WebCore::FetchResponse::FetchResponse): Ditto.
(WebCore::FetchResponse::clone): Ditto.
(WebCore::FetchResponse::type): Return ResponseType.
(WebCore::FetchResponse::startFetching): Use auto.

• Modules/fetch/FetchResponse.h: Added ResponseType and used it for the return value

of the type function, and also to replace FetchResponse::Type.

• Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::externalDeviceType): Return DeviceType.

• Modules/mediacontrols/MediaControlsHost.h: Added DeviceType and use it for the

return value for the externalDeviceType function.

• Modules/mediasession/MediaSession.cpp:

(WebCore::MediaSession::parseKind): Deleted.
(WebCore::MediaSession::MediaSession): Use MediaSessionKind.
(WebCore::MediaSession::kind): Deleted.

• Modules/mediasession/MediaSession.h: Added MediaSessionKind and use it as the

argument to MediaSession::create and the return type for the kind function.
Probably didn't get this 100% right because this code does not seem to be compiled.

• Modules/mediasession/MediaSession.idl: Added default value for kind, as specified

in the current version of the specification for this class.

• Modules/mediasession/MediaSessionManager.cpp:

(WebCore::MediaSessionManager::didReceiveStartOfInterruptionNotification):
Tried to update for changes above.
(WebCore::MediaSessionManager::didReceiveEndOfInterruptionNotification): Ditto.

• Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::endOfStream): Changed to take Optional<EndOfStreamError>
instead of overloading and taking const AtomicString&.
(WebCore::MediaSource::streamEndedWithError): Ditto. Also removed exception code.
(WebCore::MediaSource::addSourceBuffer): Updated to use EndOfStreamError. Also
used an if statement.
(WebCore::MediaSource::sourceBufferDidChangeActiveState): Updated to take a reference
instead of a pointer.

• Modules/mediasource/MediaSource.h: Added EndOfStreamError and changed as above.

• Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::segmentsKeyword): Deleted.
(WebCore::SourceBuffer::sequenceKeyword): Deleted.
(WebCore::SourceBuffer::TrackBuffer::TrackBuffer): Initialize booleans where they are
defined rather than in this constructor.
(WebCore::SourceBuffer::create): Use Ref instead of RefPtr.
(WebCore::SourceBuffer::SourceBuffer): Initialize many data members where they are
defined rather than in this constructor.
(WebCore::SourceBuffer::setTimestampOffset): Use AppendMode.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveRenderingError): Ditto.
(WebCore::SourceBuffer::decodeError): Deleted.
(WebCore::SourceBuffer::networkError): Deleted.
(WebCore::SourceBuffer::setActive): Pass reference instead of pointer.
(WebCore::SourceBuffer::sourceBufferPrivateDidEndStream): Deleted. No callers.
(WebCore::SourceBuffer::appendError): Use AppendMode.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): Ditto.
(WebCore::SourceBuffer::setMode): Take AppendMode.

• Modules/mediasource/SourceBuffer.h: Added AppendMode, removed various string

constant functions, initialize more data emebers in this header. Removed unused
sourceBufferPrivateDidEndStream function.

• Modules/mediastream/MediaDeviceInfo.cpp:

(WebCore::MediaDeviceInfo::MediaDeviceInfo): Take MediaDeviceKind instead of string.
(WebCore::MediaDeviceInfo::create): Ditto.
(WebCore::MediaDeviceInfo::audioInputType): Deleted.
(WebCore::MediaDeviceInfo::audioOutputType): Deleted.
(WebCore::MediaDeviceInfo::videoInputType): Deleted.

• Modules/mediastream/MediaDeviceInfo.h: Aedded MediaDeviceKind and used it.
• Modules/mediastream/MediaDeviceInfo.idl: Changed type of the kind attribute

to be MediaDeviceKind as in the specification.

• Modules/mediastream/MediaDevicesRequest.cpp:

(WebCore::MediaDevicesRequest::didCompleteTrackSourceInfoRequest): Fix loop to not
churn the reference countds. Also updated to use String instead of AtomicString for
label, and MediaDeviceKind instead of string for kind.

• Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::readyState): Return MediaStreamTrackState.

• Modules/mediastream/MediaStreamTrack.h: Added MediaStreamTrackState and used it

for the return value from the readyState function.

• Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::state): Return AudioContextState.

• Modules/webaudio/AudioContext.h: Added AudioContextState and used it.

• Modules/webaudio/WaveShaperNode.cpp:

(WebCore::processorType): Added.
(WebCore::WaveShaperNode::setOversample): Take OverSampletype instead of a string.
(WebCore::WaveShaperNode::oversample): Return OverSampleType.

• Modules/webaudio/WaveShaperNode.h: Added OverSampleType and used it.
• Modules/webaudio/WaveShaperNode.idl: Removed unneeded [SetterRaisesException].

• bindings/scripts/CodeGenerator.pm: Removed special cases for 18 enumerations that

either don't exist or were converted to no longer pass strings in to the C++ DOM.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeaderContentHeader): Use #pragma once instead of header guards.
(GetEnumerationValueName): Added logic to handle names with "-" and starting with
a numeric digit.
(GetEnumerationImplementationContent): Changed functions so they do more of the
binding work. Added JSValueTraits specialization so we can generate bindings for
a vector of any enumeration. Added special cases for null string. Removed special
case to keep the style checker happy.
(GenerateHeader): Removed the #endif that matched the header guards in
GenerateHeaderContentHeader.
(GenerateImplementation): Use the $type local variable rather than writing out
$attribute->signature->type or $attributeType. Fixed code path that checks for
valid enumeration values to work for non-string-based enumerations.
(CanUseWTFOptionalForParameter): Turn this function off for the new enumerations.
For now, leave it on for the old string-based enumerations.
(GenerateParametersCheck): Added appropriate parameter checking for the new
enumerations.
(GenerateCallbackHeader): Removed the #endif that matched the header guards in
GenerateHeaderContentHeader.
(GetNativeType): Use "auto" instead of the enumeration name in generated code.
(JSValueToNative): Updated since the name of enumerationValueMyEnum was changed
to parseMyEnum.
(NativeToJSValue): Took out call to stringValue, since we now overload the
jsStringWithCache function instead.

• bindings/scripts/test/JS/JSTestActiveDOMObject.h:
• bindings/scripts/test/JS/JSTestCallback.h:
• bindings/scripts/test/JS/JSTestCallbackFunction.h:
• bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.h:
• bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.h:
• bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
• bindings/scripts/test/JS/JSTestEventConstructor.h:
• bindings/scripts/test/JS/JSTestEventTarget.h:
• bindings/scripts/test/JS/JSTestException.h:
• bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
• bindings/scripts/test/JS/JSTestGlobalObject.h:
• bindings/scripts/test/JS/JSTestInterface.h:
• bindings/scripts/test/JS/JSTestJSBuiltinConstructor.h:
• bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
• bindings/scripts/test/JS/JSTestNamedConstructor.h:
• bindings/scripts/test/JS/JSTestNode.h:
• bindings/scripts/test/JS/JSTestNondeterministic.h:
• bindings/scripts/test/JS/JSTestObj.cpp:
• bindings/scripts/test/JS/JSTestObj.h:
• bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
• bindings/scripts/test/JS/JSTestOverrideBuiltins.h:
• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
• bindings/scripts/test/JS/JSTestTypedefs.h:
• bindings/scripts/test/JS/JSattribute.h:
• bindings/scripts/test/JS/JSreadonly.h:

Regenerated.

• crypto/CryptoKey.cpp:

(WebCore::CryptoKey::type): Use CryptoKeyType.
(WebCore::CryptoKey::usages): Use KeyUsage.

• crypto/CryptoKey.h: Added KeyUsage and use CryptoKeyType.

• css/FontFaceSet.cpp:

(WebCore::FontFaceSet::status): Use FontFaceSetLoadStatus.

• css/FontFaceSet.h: Added FontFaceSetLoadStatus and used it.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::playInternal): Use kind instead of kindEnum.

• html/HTMLVideoElement.cpp:

(WebCore::presentationModeFullscreen): Deleted.
(WebCore::presentationModePictureInPicture): Deleted.
(WebCore::presentationModeInline): Deleted.
(WebCore::HTMLVideoElement::webkitSupportsPresentationMode): Use VideoPresentationMode.
(WebCore::toFullscreenMode): Ditto.
(WebCore::HTMLVideoElement::webkitSetPresentationMode): Ditto.
(WebCore::toPresentationMode): Ditto.
(WebCore::HTMLVideoElement::webkitPresentationMode): Ditto.

• html/HTMLVideoElement.h: Added VideoPresentationMode and used it.

• html/canvas/CanvasRenderingContext2D.cpp: Tweaked formatting. Changed

DefaultSmoothingQuality macro to a constant.
(WebCore::toWindRule): Replaces parseWinding.
(WebCore::CanvasRenderingContext2D::fill): Use CanvasWindingRule instead of string.
(WebCore::CanvasRenderingContext2D::clip): Ditto.
(WebCore::CanvasRenderingContext2D::fillInternal): Ditto.
(WebCore::CanvasRenderingContext2D::clipInternal): Ditto.
(WebCore::CanvasRenderingContext2D::isPointInPath): Ditto.
(WebCore::CanvasRenderingContext2D::isPointInStroke): Ditto.
(WebCore::CanvasRenderingContext2D::isPointInPathInternal): Ditto.
(WebCore::smoothingToInterpolationQuality): Ditto.
(WebCore::CanvasRenderingContext2D::imageSmoothingQuality): Ditto.
(WebCore::CanvasRenderingContext2D::setImageSmoothingQuality): Ditto.

• html/canvas/CanvasRenderingContext2D.h: Added CanvasWindingRule and

ImageSmoothingQuality, and use them throughout the class.

• platform/graphics/SourceBufferPrivateClient.h: Removed unused

sourceBufferPrivateDidEndStream function.

Tools:

• Scripts/webkitpy/style/checker.py: Skip the bindings script tests when doing style

checking. We don't want to waste time trying to make our generated code match our style.

11:06 AM Changeset in webkit [200290] by n_wang@apple.com

• 4 edits
  2 adds in trunk

AX: @aria-label attribute should work on <label> element
​https://bugs.webkit.org/show_bug.cgi?id=157219

Reviewed by Chris Fleizach.

Source/WebCore:

When there's aria-label on a <label> element, we shouldn't expose it
as the titleUIElement. Instead, we return its aria-label as a title.

Test: accessibility/mac/aria-label-on-label-element.html

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::titleElementText):

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::exposesTitleUIElement):

LayoutTests:

• accessibility/mac/aria-label-on-label-element-expected.txt: Added.
• accessibility/mac/aria-label-on-label-element.html: Added.