Timeline

May 2, 2016:

10:47 PM Changeset in webkit [200361] by Darin Adler

• 63 edits in trunk/Source

Change IDL enumerations to be nested in their C++ class instead of at WebCore namespace level
​https://bugs.webkit.org/show_bug.cgi?id=157257

Reviewed by Chris Dumez.

Source/WebCore:

Chris and Alex requested this alternate style, where the enum class for each enumeration
goes inside the class for the interface the enumeration is used in. Also made a rule that
keeps the names short and not redundant with the class name they are nested in.

• Modules/fetch/FetchOptions.h: Moved all the enum class types into the struct.

• Modules/fetch/FetchRequest.cpp:

(WebCore::setReferrerPolicy): Updated.
(WebCore::setMode): Ditto.
(WebCore::setCredentials): Ditto.
(WebCore::setCache): Ditto.
(WebCore::setRedirect): Ditto.
(WebCore::buildOptions): Ditto.
(WebCore::buildHeaders): Ditto.
(WebCore::FetchRequest::create): Ditto.

• Modules/fetch/FetchRequest.h: Used "using" to repeat the types from FetchOptions

here in FetchRequest. That way the generated bindings can find the types, and we don't
need to do any trick like [ImplementedAs] in thd IDL to make it work.

• Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::error): Updated.
(WebCore::FetchResponse::redirect): Ditto.
(WebCore::FetchResponse::FetchResponse): Ditto.
(WebCore::FetchResponse::startFetching): Ditto.

• Modules/fetch/FetchResponse.h: Moved enum class into the class.

• Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::externalDeviceType): Updated.

• Modules/mediacontrols/MediaControlsHost.h: Moved enum classs into the class.

• Modules/mediasession/MediaSession.cpp:

(WebCore::MediaSession::MediaSession): Updated.

• Modules/mediasession/MediaSession.h: Moved enum classs into the class.

• Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::addSourceBuffer): Updated.
(WebCore::MediaSource::removeSourceBuffer): Ditto.

• Modules/mediasource/MediaSource.h: Moved enum class into the class.

• Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveRenderingError): Updated.
(WebCore::SourceBuffer::appendError): Ditto.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): Ditto.
(WebCore::SourceBuffer::textTrackModeChanged): Ditto.

• Modules/mediasource/SourceBuffer.h: Removed incorrect forward declaration

of EndOfStreamError that also now seems to be unneeded. Moved enum class into
the class.

• Modules/mediastream/MediaDeviceInfo.cpp:

(WebCore::MediaDeviceInfo::MediaDeviceInfo): Updated.
(WebCore::MediaDeviceInfo::create): Ditto.

• Modules/mediastream/MediaDeviceInfo.h: Moved enum class into the class.

• Modules/mediastream/MediaDevicesRequest.cpp:

(WebCore::MediaDevicesRequest::didCompleteTrackSourceInfoRequest): Updated.

• Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::readyState): Updated.

• Modules/mediastream/MediaStreamTrack.h: Moved enum class into the class.

• Modules/mediastream/RTCConfiguration.h: Moved enum classes into the class.

• Modules/webaudio/AudioContext.h: Moved enum class into the class.

• Modules/webaudio/WaveShaperNode.cpp:

(WebCore::processorType): Updated.
(WebCore::WaveShaperNode::oversample): Ditto.

• Modules/webaudio/WaveShaperNode.h: Moved enum class into the class.

• bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::response): Updated.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody): Removed unneeded $interfaceName argument.
(GetAttributeGetterName): Ditto.
(GetAttributeSetterName): Ditto.
(GetFunctionName): Tweaked style.
(AttributeShouldBeOnInstanceForCompatibility): Deleted. Was a function that
always returned 0.
(AttributeShouldBeOnInstance): Removed the call to the function above.
(IsClassNameWordBoundary): Added. Helper for function below.
(IsPrefixRemovable): Ditto.
(GetEnumerationClassName): Added an $interface argument and changed this
so it creates a nested name inside the class rather than a top level name
for use at the WebCore namespace level.
(GetEnumerationClassIdentifier): Added. Calls GetEnumerationClassName and
makes a flattened name without "::" that can be used in an identifier.
(GenerateEnumerationImplementationContent): Renamed from GetXXX. Added an
$interface argument, so it can pass that along to the functions above.
(GenerateHeader): Updated to not pass $interfaceName.
(GeneratePropertiesHashTable): Ditto.
(GenerateOverloadedFunction): Removed unneeded $interfaceName argument.
(GenerateImplementation): Updated for changes above. Tweaked formatting.
(GenerateFunctionCastedThis): Removed unneeded $interfaceName argument.
(GenerateParametersCheck): Ditto. Also streamlined implementation a bit
and made the IsEnumType section call the new functions.
(GenerateCallbackImplementation): Ditto.
(JSValueToNative): Added an $interface argument and pass it along when
dealing with enumerations.
(GeneratePrototypeDeclaration): Removed unneeded $interfaceName argument.
(GenerateConstructorDeclaration): Ditto.
(GenerateConstructorDefinitions): Ditto.
(GenerateConstructorDefinition): Ditto.
(GenerateConstructorHelperMethods): Ditto.

• bindings/scripts/test/JS/JSTestObj.cpp: Regenerated.

• bindings/scripts/test/TestObj.idl: Added some new enums that test some

of the logic above.

• crypto/CryptoKey.cpp:

(WebCore::CryptoKey::CryptoKey): Updated.
(WebCore::CryptoKey::usages): Ditto.

• crypto/CryptoKey.h: Moved enum class types inside the CryptoKey class.

Added comments about the two similar but distinct types named
CryptoKeyUsage and CryptoKey::Usage.

• css/FontFace.cpp:

(WebCore::FontFace::status): Updated.

• css/FontFace.h: Moved enum class into the class.

• css/FontFaceSet.cpp:

(WebCore::FontFaceSet::status): Updated.

• css/FontFaceSet.h: Moved enum class into the class.

• dom/Document.cpp:

(WebCore::Document::Document): Updated for the name change back from
ReferrerHeaderPolicy to ReferrerPolicy.
(WebCore::Document::processReferrerPolicy): Ditto.
(WebCore::Document::applyContentDispositionAttachmentSandbox): Ditto.

• dom/Document.h: More of the same.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadInternal): Updated.
(WebCore::HTMLMediaElement::textTrackModeChanged): Ditto.
(WebCore::HTMLMediaElement::textTrackKindChanged): Ditto.
(WebCore::HTMLMediaElement::textTrackAddCues): Ditto.
(WebCore::HTMLMediaElement::textTrackAddCue): Ditto.
(WebCore::HTMLMediaElement::addTextTrack): Ditto.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Ditto.
(WebCore::HTMLMediaElement::setSelectedTextTrack): Ditto.
(WebCore::HTMLMediaElement::configureTextTracks): Ditto.
(WebCore::HTMLMediaElement::hasClosedCaptions): Ditto.
(WebCore::HTMLMediaElement::configureTextTrackDisplay): Ditto.
(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): Ditto.
(WebCore::toPlatform): Ditto.
(WebCore::HTMLMediaElement::outOfBandTrackSources): Ditto.

• html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::scheduleLoad): Ditto.

• html/HTMLVideoElement.h: Moved enum class into class.

• html/HTMLVideoElement.idl: Added the missing conditional on

VideoPresentationMode, and also moved it to the bottom of the file
to work around what is apparently a bug in the IDL parser.

• html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::toWindRule): Updated.
(WebCore::CanvasRenderingContext2D::fill): Ditto.
(WebCore::CanvasRenderingContext2D::clip): Ditto.
(WebCore::CanvasRenderingContext2D::fillInternal): Ditto.
(WebCore::CanvasRenderingContext2D::clipInternal): Ditto.
(WebCore::CanvasRenderingContext2D::isPointInPath): Ditto.
(WebCore::CanvasRenderingContext2D::isPointInPathInternal): Ditto.
(WebCore::smoothingToInterpolationQuality): Ditto.

• html/canvas/CanvasRenderingContext2D.h: Moved enum class types into the class.

• html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay): Updated.
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Ditto.

• html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::setMode): Updated.
(WebCore::toPrivate): Ditto.
(WebCore::InbandTextTrack::setModeInternal): Ditto.
(WebCore::InbandTextTrack::updateKindFromPrivate): Ditto.

• html/track/InbandTextTrack.h: Ditto.
• html/track/TextTrack.cpp:

(WebCore::TextTrack::TextTrack): Ditto.
(WebCore::TextTrack::enabled): Ditto.
(WebCore::TextTrack::kindKeyword): Ditto.
(WebCore::TextTrack::setKind): Ditto.
(WebCore::TextTrack::setKindKeywordIgnoringASCIICase): Ditto.
(WebCore::TextTrack::setMode): Ditto.
(WebCore::TextTrack::cues): Ditto.
(WebCore::TextTrack::activeCues): Ditto.
(WebCore::TextTrack::addCue): Ditto.
(WebCore::TextTrack::regions): Ditto.
(WebCore::TextTrack::isRendered): Ditto.
(WebCore::TextTrack::isMainProgramContent): Ditto.
(WebCore::TextTrack::containsOnlyForcedSubtitles): Ditto.

• html/track/TextTrack.h: Moved enum class types into the class.

• html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::dispatchEvent): Updated.
(WebCore::TextTrackCue::isActive): Ditto.

• loader/FrameNetworkingContext.h: Ditto.
• page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::sortedTrackListForMenu): Ditto.
(WebCore::CaptionUserPreferences::textTrackSelectionScore): Ditto.

• page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::textTrackSelectionScore): Ditto.
(WebCore::CaptionUserPreferencesMediaAF::sortedTrackListForMenu): Ditto.

• page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::generateReferrerHeader): Updated since we
changed ReferrerHeaderPolicy back to ReferrerPolicy.

• page/SecurityPolicy.h: Ditto.

• platform/ReferrerPolicy.h: Changed ReferrerHeaderPolicy name back

to ReferrerPolicy now that nesting inside a class eliminated the conflict;
still should merge them and that FIXME remains.

• platform/cocoa/WebPlaybackSessionModelMediaElement.mm:

(WebPlaybackSessionModelMediaElement::updateForEventName): Updated.
(WebPlaybackSessionModelMediaElement::updateLegibleOptions): Ditto.

• testing/Internals.cpp:

(WebCore::toResourceRequestCachePolicy): Updated.
(WebCore::Internals::setOverrideCachePolicy): Ditto.
(WebCore::toResourceLoadPriority): Ditto.
(WebCore::Internals::setOverrideResourceLoadPriority): Ditto.
(WebCore::toAutoFillButtonType): Ditto.
(WebCore::Internals::setShowAutoFillButton): Ditto.

• testing/Internals.h: Moved enum class types into class.

• testing/Internals.idl: Removed the "Internals" prefixes we added

to resolve ambiguity before. Nesting these in the class now takes care
of the ambiguity instead.

• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::responseText): Updated.
(WebCore::XMLHttpRequest::didCacheResponseJSON): Ditto.
(WebCore::XMLHttpRequest::responseXML): Ditto.
(WebCore::XMLHttpRequest::responseBlob): Ditto.
(WebCore::XMLHttpRequest::responseArrayBuffer): Ditto.
(WebCore::XMLHttpRequest::setResponseType): Ditto.
(WebCore::XMLHttpRequest::open): Ditto.
(WebCore::shouldDecodeResponse): Ditto.

• xml/XMLHttpRequest.h: Moved the enum class into the class.

Source/WebKit2:

• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::loadResource): Updated since we changed
ReferrerHeaderPolicy back to ReferrerPolicy.
(WebKit::WebLoaderStrategy::schedulePluginStreamLoad): Ditto.

8:39 PM Changeset in webkit [200360] by Simon Fraser

• 7 edits
  4 adds in trunk

Don't run transitions to/from 'auto' values
​https://bugs.webkit.org/show_bug.cgi?id=38243
rdar://problem/20904225

Reviewed by Dean Jackson.
Source/WebCore:

The specified behavior of transitions and animations is to not animate when either endpoint is 'auto'.
Previously, we were treating 'auto' as zero and interpolating, which caused unwanted animations
on fandango.com, airbnb.com and others.

Fix by having blend() return the from value if progress is 0, otherwise the to value. The
isZero() check can be removed, since this was effectively picking up auto value for one endpoint.

Tests: transitions/lengthsize-transition-to-from-auto.html

transitions/transition-to-from-auto.html

• platform/Length.cpp:

(WebCore::blend):

LayoutTests:

• platform/mac-wk2/transitions/default-timing-function-expected.txt: New baseline.
• transitions/default-timing-function.html: Set explicit start value.
• transitions/interrupted-all-transition.html: Set explicit start value.
• transitions/lengthsize-transition-to-from-auto-expected.txt: Added.
• transitions/lengthsize-transition-to-from-auto.html: Added.
• transitions/transition-to-from-auto-expected.txt: Added.
• transitions/transition-to-from-auto.html: Added.
• transitions/zero-duration-in-list.html: Set explicit start value.

7:58 PM Changeset in webkit [200359] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebInspectorUI

Unreviewed, rolling out r200337.
​https://bugs.webkit.org/show_bug.cgi?id=157294

Console hangs when evaluating expresisons (Requested by
JoePeck on #webkit).

Reverted changeset:

"Web Inspector: Adding a new console message shouldn't modify
DOM when the console log is hidden"
​https://bugs.webkit.org/show_bug.cgi?id=155629
​http://trac.webkit.org/changeset/200337

7:52 PM Changeset in webkit [200358] by Chris Dumez

• 8 edits
  2 adds in trunk

Indexing CSSStyleDeclaration object with out-of-range index should return undefined
​https://bugs.webkit.org/show_bug.cgi?id=157283

Reviewed by Darin Adler.

Source/WebCore:

Indexing CSSStyleDeclaration object with out-of-range index should return undefined,
as per:

• ​http://heycam.github.io/webidl/#idl-indexed-properties
• ​http://heycam.github.io/webidl/#getownproperty-guts

WebKit was incorrectly returning the empty string in this case. We however, still
return the empty string if calling the indexed property getter via item(), as is
expected.

The new behavior matches Firefox and the Web IDL specification. Chrome returns the
empty string in this case though.

Test: fast/dom/indexed-getters-returning-string.html

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::item):

• css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::item):

LayoutTests:

Rebaseline a couple of existing tests due to the slight behavior change.
Also add a new layout test for more extensive testing.

• fast/dom/CSSStyleDeclaration/css-computed-style-item-expected.txt:
• fast/dom/CSSStyleDeclaration/css-style-item-expected.txt:
• fast/dom/CSSStyleDeclaration/script-tests/css-computed-style-item.js:
• fast/dom/CSSStyleDeclaration/script-tests/css-style-item.js:
• fast/dom/indexed-getters-returning-string-expected.txt: Added.
• fast/dom/indexed-getters-returning-string.html: Added.

7:25 PM Changeset in webkit [200357] by dino@apple.com

• 18 edits
  2 adds in trunk

Specifying a longhand property should not serialize to a shorthand property
​https://bugs.webkit.org/show_bug.cgi?id=157180

Patch by Antoine Quint <Antoine Quint> on 2016-05-02
Reviewed by Dean Jackson.

Source/WebCore:

Ensure that we don't serialize to a shorthand property when the required longhand components
are not specified, per ​http://www.w3.org/TR/cssom-1/#serialize-a-css-declaration-block.

Test: fast/css/no-shorthand-with-incomplete-longhands.html

• css/StyleProperties.cpp:

(WebCore::StyleProperties::getLayeredShorthandValue):
Returning an empty string here means that calling getPropertyValue() with
the shorthand property matching the currently processed longhand property
in asText() will return an empty string as well and the shorthand property
will be disregarded.

LayoutTests:

A fair few tests relied on reading from a shorthand value when it was incorrect
to produce one, so we fix those incorrect assertions. We also add a new test that
goes through all the longhand properties for a given shorthand property and checks
that none of the longhand properties will yield a shorthand value.

• cssom/cssvalue-comparison-expected.txt:
• cssom/cssvalue-comparison.html:
• fast/css/background-position-serialize-expected.txt:
• fast/css/background-position-serialize.html:
• fast/css/no-shorthand-with-incomplete-longhands-expected.txt: Added.
• fast/css/no-shorthand-with-incomplete-longhands.html: Added.
• fast/css/remove-shorthand-expected.txt:
• fast/css/script-tests/image-set-setting.js:

(testComputedStyle):

• fast/css/uri-token-parsing-expected.txt:
• fast/css/uri-token-parsing.html:
• fast/css/webkit-mask-crash-implicit-expected.txt:
• fast/css/webkit-mask-crash-implicit.html:
• fast/dom/Element/setAttributeNode-for-existing-attribute.html:
• fast/dom/background-shorthand-csstext-expected.txt:
• fast/dom/background-shorthand-csstext.html:
• http/tests/security/contentSecurityPolicy/inline-style-allowed-while-cloning-objects-expected.txt:
• http/tests/security/contentSecurityPolicy/inline-style-allowed-while-cloning-objects.html:

7:17 PM Changeset in webkit [200356] by dino@apple.com

• 2 edits in trunk/Source/WebCore

REGRESSION: Page layout of Manga/Picture books and all Fixed Layout ePubs corrupted
​https://bugs.webkit.org/show_bug.cgi?id=157292
<rdar://problem/25750144>

Reviewed by Tim Horton.

The scroll state restoration fixes caused a regression in UIWebViews.
Code in UIKit checks for a non-zero page scale in a history item, and
r199233 changed the initialization from 0 to 1.

• history/HistoryItem.h: Use 0 instead of 1 as the initial m_scale.

7:00 PM Changeset in webkit [200355] by commit-queue@webkit.org

• 2 edits
  1 add in trunk/Source/JavaScriptCore

Web Inspector: Reflect.toString() should be [object Object] not [object Reflect]
​https://bugs.webkit.org/show_bug.cgi?id=157288

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-02
Reviewed by Darin Adler.

• runtime/ReflectObject.cpp:
• tests/stress/reflect.js: Added.

6:39 PM Changeset in webkit [200354] by eric.carlson@apple.com

• 2 edits in trunk/Source/WebCore

[Mac] AirPlay fails if target is set before AVPlayer has been created
​https://bugs.webkit.org/show_bug.cgi?id=157147
<rdar://problem/24197592>

Reviewed by Dean Jackson.

No new tests, it won't be possible to test this until
​https://bugs.webkit.org/show_bug.cgi?id=157290 has been fixed.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):

6:34 PM Changeset in webkit [200353] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Unexpected "Script Element #" resources in Debugger Sidebar
​https://bugs.webkit.org/show_bug.cgi?id=157280

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-02
Reviewed by Timothy Hatcher.

• UserInterface/Views/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel.prototype._addScript):
Don't include Script Element resources in the debugger sidebar by default.

6:01 PM Changeset in webkit [200352] by beidson@apple.com

• 7 edits in trunk/Source

Const-ify some IDB code.
​https://bugs.webkit.org/show_bug.cgi?id=157287

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (Refactor only).

• Modules/indexeddb/client/IDBConnectionToServerDelegate.h:
• Modules/indexeddb/shared/InProcessIDBServer.cpp:

(WebCore::InProcessIDBServer::deleteDatabase):
(WebCore::InProcessIDBServer::openDatabase):
(WebCore::InProcessIDBServer::abortTransaction):
(WebCore::InProcessIDBServer::commitTransaction):
(WebCore::InProcessIDBServer::didFinishHandlingVersionChangeTransaction):

• Modules/indexeddb/shared/InProcessIDBServer.h:

Source/WebKit2:

• WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:

(WebKit::WebIDBConnectionToServer::deleteDatabase):
(WebKit::WebIDBConnectionToServer::openDatabase):
(WebKit::WebIDBConnectionToServer::abortTransaction):
(WebKit::WebIDBConnectionToServer::commitTransaction):
(WebKit::WebIDBConnectionToServer::didFinishHandlingVersionChangeTransaction):

• WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:

5:51 PM Changeset in webkit [200351] by Jon Davis

• 2 edits in trunk/Source/JavaScriptCore

Add Resource Timing entry to the Feature Status page.
​https://bugs.webkit.org/show_bug.cgi?id=157285

Reviewed by Timothy Hatcher.

• features.json:

5:51 PM Changeset in webkit [200350] by commit-queue@webkit.org

• 9 edits
  2 moves
  2 adds
  2 deletes in trunk

Make console a namespace object (like Math/JSON), allowing functions to be called unbound
​https://bugs.webkit.org/show_bug.cgi?id=157286
<rdar://problem/26052830>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-02
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

This changes console to be a global namespace object, like Math and JSON.
It just holds a bunch of functions, that can be used on their own, unbound.
For example, [1,2,3].forEach(console.log) and var log = console.log; log(1)
used to throw exceptions and now do not.

Previously console was an Object/Prototype pair, so functions were on
ConsolePrototype (console.proto.log) and they needed to be called
Console objects as the this value. Now, console is just a standard
object with a bunch of functions. Since there is no console prototype the
functions can be passed around and called as expected and they will
just do the right thing.

For compatability with other browsers, console was made enumerable
on the global object.

• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:

Add new files and remove old files.

• runtime/CommonIdentifiers.h:

Add "console".

• runtime/ConsoleObject.cpp: Renamed from Source/JavaScriptCore/runtime/ConsolePrototype.cpp.

(JSC::ConsoleObject::ConsoleObject):
(JSC::ConsoleObject::finishCreation):
(JSC::valueToStringWithUndefinedOrNullCheck):
(JSC::consoleLogWithLevel):
(JSC::consoleProtoFuncDebug):
(JSC::consoleProtoFuncError):
(JSC::consoleProtoFuncLog):
(JSC::consoleProtoFuncInfo):
(JSC::consoleProtoFuncWarn):
(JSC::consoleProtoFuncClear):
(JSC::consoleProtoFuncDir):
(JSC::consoleProtoFuncDirXML):
(JSC::consoleProtoFuncTable):
(JSC::consoleProtoFuncTrace):
(JSC::consoleProtoFuncAssert):
(JSC::consoleProtoFuncCount):
(JSC::consoleProtoFuncProfile):
(JSC::consoleProtoFuncProfileEnd):
(JSC::consoleProtoFuncTakeHeapSnapshot):
(JSC::consoleProtoFuncTime):
(JSC::consoleProtoFuncTimeEnd):
(JSC::consoleProtoFuncTimeStamp):
(JSC::consoleProtoFuncGroup):
(JSC::consoleProtoFuncGroupCollapsed):
(JSC::consoleProtoFuncGroupEnd):
Console functions no longer need to check if the this object is
a Console object. They will always just work now.

• runtime/MathObject.cpp:
• runtime/MathObject.h:
• runtime/ConsoleObject.h: Renamed from Source/JavaScriptCore/runtime/ConsolePrototype.h.

(JSC::ConsoleObject::create):
(JSC::ConsoleObject::createStructure):
ConsoleObject is a basic object like MathObject.

• runtime/JSConsole.cpp: Removed.
• runtime/JSConsole.h: Removed.
• runtime/JSGlobalObject.h:
• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):
Remove JSConsole / ConsolePrototype in favor of the single ConsoleObject.

LayoutTests:

• js/console-expected.txt: Added.
• js/console.html: Added.

5:11 PM Changeset in webkit [200349] by bshafiei@apple.com

• 5 edits in tags/Safari-602.1.30.3/Source

Versioning.

5:07 PM Changeset in webkit [200348] by bshafiei@apple.com

• 1 copy in tags/Safari-602.1.30.3

New tag.

4:47 PM Changeset in webkit [200347] by Antti Koivisto

• 4 edits
  2 adds in trunk

REGRESSION(r199964): Animation on pseudo elements doesn't trigger if first frame matches the current style
​https://bugs.webkit.org/show_bug.cgi?id=157284

Reviewed by Simon Fraser.

Source/WebCore:

r199964 accidentally changed the logic for computing style change for animations.

Test: fast/css/animation-pseudo-style-change.html

• style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::updateBeforeOrAfterPseudoElement):

If there is an animated style determine the style change using it rather than the originally resolved style.

• style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolveElement):

Here too.

LayoutTests:

• fast/css/animation-pseudo-style-change-expected.html: Added.
• fast/css/animation-pseudo-style-change.html: Added.

4:14 PM Changeset in webkit [200346] by beidson@apple.com

• 23 edits
  1 add in trunk

Add the ability to accumulate logs for specific logging channels to help diagnose test timeouts.
​https://bugs.webkit.org/show_bug.cgi?id=157274

Reviewed by Alex Christensen.
Source/WebCore:

• platform/Logging.cpp:

(WebCore::setLogChannelToAccumulate): Set the given log channel to accumulate logging,

and dirty the initializeLoggingChannelsIfNecessary flag.

(WebCore::initializeLoggingChannelsIfNecessary): Change from being a one-time-only call to a

one-time-for-each-time-somebody-calls-setLogChannelToAccumulate call.

• platform/Logging.h:

• testing/js/WebCoreTestSupport.cpp:

(WebCoreTestSupport::setLogChannelToAccumulate):
(WebCoreTestSupport::initializeLoggingChannelsIfNecessary):

• testing/js/WebCoreTestSupport.h:

Source/WTF:

This patch changes WTFLog to add the logging string to the logging accumulator if the logging channel says so.
It also adds support for using this new accumulation mechanism.

• WTF.xcodeproj/project.pbxproj:

• wtf/Assertions.cpp:

(WTF::resetAccumulatedLogs):
(WTF::getAndResetAccumulatedLogs):

• wtf/Assertions.h:

• wtf/LoggingAccumulator.h: Added. Expose functions to get accumulated logs and to reset the accumulation.

• wtf/text/WTFString.cpp:

(WTF::String::format): Update to handle %@ on CF (Well, really ObjC) platforms.

Tools:

Add the new accumulate method to DRT's TestRunner, dump the accumulated logs if there's a timeout,
and reset them in between tests:

• DumpRenderTree/TestRunner.cpp:

(accummulateLogsForChannel):
(TestRunner::staticFunctions):
(TestRunner::waitToDumpWatchdogTimerFired):
(TestRunner::setAccummulateLogsForChannel):

• DumpRenderTree/TestRunner.h:
• DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebViewToConsistentStateBeforeTesting):

Also add the new method to WKTR's TestRunner, but just stubbed for now:

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::accummulateLogsForChannel):

• WebKitTestRunner/InjectedBundle/TestRunner.h:

LayoutTests:

For the tests that are known flakes that are not imported, add the "accumulate IndexedDB logs" command.

• storage/indexeddb/modern/resources/256-open-databases.js:
• storage/indexeddb/modern/resources/abort-requests-cancelled.js:
• storage/indexeddb/modern/resources/autoincrement-abort.js:
• storage/indexeddb/resources/intversion-open-in-upgradeneeded.js:
• storage/indexeddb/resources/odd-strings.js:

4:07 PM Changeset in webkit [200345] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Prefer "Console Evaluation" to "Eval Code" if we know it was a console evaluation
​https://bugs.webkit.org/show_bug.cgi?id=157278

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-02
Reviewed by Timothy Hatcher.

• Localizations/en.lproj/localizedStrings.js:

"Console Evaluation" string.

• UserInterface/Controllers/DebuggerManager.js:

(WebInspector.DebuggerManager.prototype._sourceCodeLocationFromPayload): Deleted.
Delete an assert that would throw when the location is noSourceID:-1:-1.

• UserInterface/Models/CallFrame.js:

(WebInspector.CallFrame.fromDebuggerPayload):
(WebInspector.CallFrame.fromPayload):
(WebInspector.CallFrame):
When this is in a Console Evalution provide better values.

• UserInterface/Models/GarbageCollection.js:

(WebInspector.GarbageCollection):
Drive-by address a common assertions seen while paused.

3:21 PM Changeset in webkit [200344] by Simon Fraser

• 4 edits in trunk/Source

Sort the project file.

Source/WebCore:

• WebCore.xcodeproj/project.pbxproj:

Source/WebKit2:

• WebKit2.xcodeproj/project.pbxproj:

3:19 PM Changeset in webkit [200343] by Simon Fraser

• 10 edits in trunk/Source/WebCore

Make Length, LengthSize and LengthPoint blending not use member functions
​https://bugs.webkit.org/show_bug.cgi?id=157281

Reviewed by Zalan Bujtas.

Having blend() be a member function is ambiguous because it's hard to tell which are
the 'from' and 'to' values. Fix Length, LengthSize and LengthPoint accordingly.

No behavior change.

• page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):

• platform/Length.cpp:

(WebCore::blendMixedTypes):
(WebCore::blend):
(WebCore::Length::blendMixedTypes): Deleted.

• platform/Length.h:

(WebCore::Length::blend): Deleted.

• platform/LengthPoint.h:

(WebCore::blend):
(WebCore::LengthPoint::blend): Deleted.

• platform/LengthSize.h:

(WebCore::blend):
(WebCore::LengthSize::blend): Deleted.

• platform/graphics/filters/FilterOperation.cpp:

(WebCore::BlurFilterOperation::blend):

• platform/graphics/transforms/TranslateTransformOperation.cpp:

(WebCore::TranslateTransformOperation::blend):

• rendering/style/BasicShapes.cpp:

(WebCore::BasicShapePolygon::blend):
(WebCore::BasicShapeInset::blend):

• rendering/style/BasicShapes.h:

(WebCore::BasicShapeCenterCoordinate::blend):
(WebCore::BasicShapeRadius::blend):

3:19 PM Changeset in webkit [200342] by Simon Fraser

• 13 edits in trunk/Source

Fix shouldUpdateScrollLayerPositionSynchronously() for non-main frames. Remove updatesScrollLayerPositionOnMainThread()
​https://bugs.webkit.org/show_bug.cgi?id=157277

Reviewed by Dean Jackson, Tim Horton.

Source/WebCore:

shouldUpdateScrollLayerPositionSynchronously() gave an answer for the main frame even if
called for a subframe. This could have caused scroll snapping, and isRubberBandInProgress()
to give wrong answers sometimes. Fix by passing in the FrameView.

I was unable to easily come up with a testcase to detect the incorrect behavior.

Remove updatesScrollLayerPositionOnMainThread() which is unused by all ports.

• page/FrameView.cpp:

(WebCore::FrameView::isScrollSnapInProgress):
(WebCore::FrameView::shouldUpdateCompositingLayersAfterScrolling):
(WebCore::FrameView::isRubberBandInProgress):
(WebCore::FrameView::updatesScrollLayerPositionOnMainThread): Deleted.

• page/FrameView.h:
• page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::updateSynchronousScrollingReasons):
(WebCore::ScrollingCoordinator::shouldUpdateScrollLayerPositionSynchronously):

• page/scrolling/ScrollingCoordinator.h:
• page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::updateTiledScrollingIndicator):

• platform/ScrollableArea.h:
• platform/win/PopupMenuWin.h:
• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::setupFontSubpixelQuantization):

• rendering/RenderLayer.h:
• rendering/RenderListBox.h:

Source/WebKit2:

Remove updatesScrollLayerPositionOnMainThread() which is unused by all ports.

• WebProcess/Plugins/PDF/DeprecatedPDFPlugin.h:

3:19 PM Changeset in webkit [200341] by Simon Fraser

• 28 edits
  1 copy
  1 add in trunk/Source/WebCore

Add to the Animations log channel output about which properties are being blended
​https://bugs.webkit.org/show_bug.cgi?id=157271

Reviewed by Dean Jackson.

Make the Animations log channel dump information as CSS properties are being blended.
Sample output:

blending left from 0px to 400px at 0.57 -> 227.76px
blending transform from translate(0px, 0px, 0px) to translate(400px, 0px, 0px) at 0.74 -> translate(294.97px, 0px, 0px)

This makes it easier to see, for example, transitions to or from "auto" values.

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:
• page/animation/CSSPropertyAnimation.cpp:

(WebCore::PropertyWrapperGetter::value):
(WebCore::PropertyWrapperMaybeInvalidColor::value):
(WebCore::CSSPropertyAnimationWrapperMap::wrapperForProperty):
(WebCore::CSSPropertyAnimation::blendProperties):

• platform/Length.cpp:

(WebCore::operator<<):

• platform/LengthBox.h:
• platform/graphics/transforms/IdentityTransformOperation.h:
• platform/graphics/transforms/Matrix3DTransformOperation.cpp:

(WebCore::Matrix3DTransformOperation::dump):

• platform/graphics/transforms/Matrix3DTransformOperation.h:
• platform/graphics/transforms/MatrixTransformOperation.cpp:

(WebCore::MatrixTransformOperation::dump):

• platform/graphics/transforms/MatrixTransformOperation.h:
• platform/graphics/transforms/PerspectiveTransformOperation.cpp:

(WebCore::PerspectiveTransformOperation::dump):

• platform/graphics/transforms/PerspectiveTransformOperation.h:
• platform/graphics/transforms/RotateTransformOperation.cpp:

(WebCore::RotateTransformOperation::dump):

• platform/graphics/transforms/RotateTransformOperation.h:
• platform/graphics/transforms/ScaleTransformOperation.cpp:

(WebCore::ScaleTransformOperation::dump):

• platform/graphics/transforms/ScaleTransformOperation.h:
• platform/graphics/transforms/SkewTransformOperation.cpp:

(WebCore::SkewTransformOperation::dump):

• platform/graphics/transforms/SkewTransformOperation.h:
• platform/graphics/transforms/TransformOperation.h:
• platform/graphics/transforms/TransformOperations.cpp:

(WebCore::operator<<):

• platform/graphics/transforms/TransformOperations.h:
• platform/graphics/transforms/TranslateTransformOperation.cpp:

(WebCore::TranslateTransformOperation::dump):

• platform/graphics/transforms/TranslateTransformOperation.h:
• rendering/style/NinePieceImage.cpp:

(WebCore::operator<<):

• rendering/style/NinePieceImage.h:
• svg/SVGLength.cpp:

(WebCore::operator<<):

• svg/SVGLength.h:

3:18 PM Changeset in webkit [200340] by Chris Dumez

• 9 edits in trunk/Source/WebCore

Modernize HTMLConstructionSite
​https://bugs.webkit.org/show_bug.cgi?id=157279

Reviewed by Alex Christensen.

Modernize HTMLConstructionSite: Use less raw pointers, more auto, more
range loops and more nullptr.

• dom/ScriptElement.h:
• html/parser/HTMLConstructionSite.cpp:

(WebCore::setAttributes):
(WebCore::shouldUseLengthLimit):
(WebCore::executeReparentTask):
(WebCore::HTMLConstructionSite::attachLater):
(WebCore::HTMLConstructionSite::executeQueuedTasks):
(WebCore::HTMLConstructionSite::HTMLConstructionSite):
(WebCore::HTMLConstructionSite::takeForm):
(WebCore::HTMLConstructionSite::dispatchDocumentElementAvailableIfNeeded):
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagBeforeHTML):
(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):
(WebCore::HTMLConstructionSite::insertHTMLHtmlStartTagInBody):
(WebCore::HTMLConstructionSite::insertHTMLBodyStartTagInBody):
(WebCore::HTMLConstructionSite::setDefaultCompatibilityMode):
(WebCore::HTMLConstructionSite::setCompatibilityMode):
(WebCore::HTMLConstructionSite::finishedParsing):
(WebCore::HTMLConstructionSite::insertDoctype):
(WebCore::HTMLConstructionSite::insertComment):
(WebCore::HTMLConstructionSite::insertCommentOnDocument):
(WebCore::HTMLConstructionSite::insertCommentOnHTMLHtmlElement):
(WebCore::HTMLConstructionSite::insertHTMLHeadElement):
(WebCore::HTMLConstructionSite::insertHTMLBodyElement):
(WebCore::HTMLConstructionSite::insertHTMLFormElement):
(WebCore::HTMLConstructionSite::insertHTMLElement):
(WebCore::HTMLConstructionSite::insertHTMLElementOrFindCustomElementInterface):
(WebCore::HTMLConstructionSite::insertCustomElement):
(WebCore::HTMLConstructionSite::insertSelfClosingHTMLElement):
(WebCore::HTMLConstructionSite::insertFormattingElement):
(WebCore::HTMLConstructionSite::insertScriptElement):
(WebCore::HTMLConstructionSite::insertForeignElement):
(WebCore::HTMLConstructionSite::insertTextNode):
(WebCore::HTMLConstructionSite::reparent):
(WebCore::HTMLConstructionSite::insertAlreadyParsedChild):
(WebCore::HTMLConstructionSite::takeAllChildren):
(WebCore::HTMLConstructionSite::createElement):
(WebCore::HTMLConstructionSite::createHTMLElementOrFindCustomElementInterface):
(WebCore::HTMLConstructionSite::createHTMLElement):
(WebCore::HTMLConstructionSite::createElementFromSavedToken):
(WebCore::HTMLConstructionSite::indexOfFirstUnopenFormattingElement):
(WebCore::HTMLConstructionSite::reconstructTheActiveFormattingElements):
(WebCore::HTMLConstructionSite::findFosterSite):
(WebCore::HTMLConstructionSite::shouldFosterParent):
(WebCore::HTMLConstructionSite::fosterParent):
(WebCore::HTMLConstructionSite::~HTMLConstructionSite): Deleted.
(WebCore::HTMLConstructionSite::setForm): Deleted.
(WebCore::HTMLConstructionSite::setCompatibilityModeFromDoctype): Deleted.
(WebCore::HTMLConstructionSite::ownerDocumentForCurrentNode): Deleted.
(WebCore::HTMLConstructionSite::generateImpliedEndTagsWithExclusion): Deleted.

• html/parser/HTMLConstructionSite.h:

(WebCore::HTMLConstructionSite::inQuirksMode):
(WebCore::HTMLConstructionSite::isTelephoneNumberParsingEnabled):
(WebCore::HTMLConstructionSite::RedirectToFosterParentGuard::RedirectToFosterParentGuard):

• html/parser/HTMLElementStack.cpp:

(WebCore::HTMLNames::isRootNode):
(WebCore::HTMLElementStack::ElementRecord::ElementRecord):
(WebCore::HTMLElementStack::ElementRecord::replaceElement):
(WebCore::HTMLElementStack::ElementRecord::isAbove):
(WebCore::HTMLElementStack::popAll):
(WebCore::HTMLElementStack::popUntil):
(WebCore::HTMLElementStack::popUntilPopped):
(WebCore::HTMLElementStack::pushRootNode):
(WebCore::HTMLElementStack::pushHTMLHtmlElement):
(WebCore::HTMLElementStack::pushRootNodeCommon):
(WebCore::HTMLElementStack::pushHTMLHeadElement):
(WebCore::HTMLElementStack::pushHTMLBodyElement):
(WebCore::HTMLElementStack::push):
(WebCore::HTMLElementStack::insertAbove):
(WebCore::HTMLElementStack::removeHTMLHeadElement):
(WebCore::HTMLElementStack::remove):
(WebCore::HTMLElementStack::contains):
(WebCore::inScopeCommon):
(WebCore::HTMLElementStack::hasNumberedHeaderElementInScope):
(WebCore::HTMLElementStack::inScope):
(WebCore::HTMLElementStack::pushCommon):
(WebCore::HTMLElementStack::popCommon):
(WebCore::HTMLElementStack::removeNonTopCommon):
(WebCore::HTMLElementStack::show):
(WebCore::HTMLElementStack::hasOnlyOneElement): Deleted.
(WebCore::HTMLElementStack::secondElementIsHTMLBodyElement): Deleted.
(WebCore::HTMLElementStack::pop): Deleted.
(WebCore::HTMLElementStack::popUntilTableScopeMarker): Deleted.
(WebCore::HTMLElementStack::oneBelowTop): Deleted.

• html/parser/HTMLElementStack.h:

(WebCore::HTMLElementStack::ElementRecord::stackItem):
(WebCore::HTMLElementStack::ElementRecord::setNext): Deleted.
(WebCore::HTMLElementStack::popUntilPopped): Deleted.

• html/parser/HTMLFormattingElementList.cpp:

(WebCore::HTMLFormattingElementList::contains):
(WebCore::HTMLFormattingElementList::swapTo):
(WebCore::HTMLFormattingElementList::append):
(WebCore::HTMLFormattingElementList::remove):
(WebCore::HTMLFormattingElementList::tryToEnsureNoahsArkConditionQuickly):
(WebCore::HTMLFormattingElementList::ensureNoahsArkCondition):

• html/parser/HTMLFormattingElementList.h:

(WebCore::HTMLFormattingElementList::Entry::Entry):
(WebCore::HTMLFormattingElementList::Entry::replaceElement):
(WebCore::HTMLFormattingElementList::Bookmark::Bookmark):
(WebCore::HTMLFormattingElementList::Bookmark::moveToAfter):
(WebCore::HTMLFormattingElementList::Bookmark::mark):
(WebCore::HTMLFormattingElementList::first):
(WebCore::HTMLFormattingElementList::Entry::isMarker): Deleted.
(WebCore::HTMLFormattingElementList::Entry::stackItem): Deleted.
(WebCore::HTMLFormattingElementList::Entry::operator!=): Deleted.

• html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processDoctypeToken):
(WebCore::HTMLTreeBuilder::processCloseWhenNestedTag):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::insertGenericHTMLElement):
(WebCore::HTMLTreeBuilder::processTemplateStartTag):
(WebCore::HTMLTreeBuilder::processStartTagForInTable):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processHtmlStartTagForInBody):
(WebCore::HTMLTreeBuilder::processAnyOtherEndTagForInBody):
(WebCore::HTMLTreeBuilder::callTheAdoptionAgency):
(WebCore::HTMLTreeBuilder::processEndTagForInBody):
(WebCore::HTMLTreeBuilder::processComment):
(WebCore::HTMLTreeBuilder::defaultForBeforeHTML):
(WebCore::HTMLTreeBuilder::processStartTagForInHead):
(WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag):
(WebCore::HTMLTreeBuilder::processGenericRawTextStartTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):
(WebCore::HTMLTreeBuilder::processTokenInForeignContent):

2:42 PM Changeset in webkit [200339] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Add fail-fast option to run-javascriptcore-tests
​https://bugs.webkit.org/show_bug.cgi?id=157270

Patch by Srinivasan Vijayaraghavan <​svijayaraghavan@apple.com> on 2016-05-02
Reviewed by Geoffrey Garen.

• Scripts/run-javascriptcore-tests: Add fail-fast command line option.

Defaults to yes, which is the current behavior.

2:20 PM Changeset in webkit [200338] by peavo@outlook.com

• 13 edits in trunk/Source/JavaScriptCore

[Win] Clean up annoying compiler warnings
​https://bugs.webkit.org/show_bug.cgi?id=149813

Reviewed by Alex Christensen.

• bytecode/PropertyCondition.cpp:

(JSC::PropertyCondition::isWatchableWhenValid):

• dfg/DFGObjectAllocationSinkingPhase.cpp:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

• inspector/InspectorBackendDispatcher.cpp:

(Inspector::BackendDispatcher::sendPendingErrors):

• jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCall):

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseAssignmentExpression):

• runtime/ClonedArguments.cpp:

(JSC::ClonedArguments::createWithInlineFrame):

• runtime/Error.cpp:

(JSC::addErrorInfoAndGetBytecodeOffset):

• runtime/IntlNumberFormat.cpp:

(JSC::IntlNumberFormat::initializeNumberFormat):

• runtime/JSObject.cpp:

(JSC::JSObject::heapSnapshot):
(JSC::callToPrimitiveFunction):

• runtime/RegExpPrototype.cpp:

(JSC::flagsString):

• runtime/SamplingProfiler.cpp:

(JSC::SamplingProfiler::StackFrame::functionStartColumn):

2:01 PM Changeset in webkit [200337] by Nikita Vasilyev

• 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Adding a new console message shouldn't modify DOM when the console log is hidden
​https://bugs.webkit.org/show_bug.cgi?id=155629
<rdar://problem/25235470>

Reviewed by Timothy Hatcher.

Instead of rendering console messages right away, store them (in _pendingMessages)
and render only when the console tab or the split console is visible.
Also, batch rendering operations using requestAnimationFrame.

• UserInterface/Controllers/JavaScriptLogViewController.js:

(WebInspector.JavaScriptLogViewController):
Store console message views in _pendingMessages.

(WebInspector.JavaScriptLogViewController.prototype._appendConsoleMessageView):
(WebInspector.JavaScriptLogViewController.prototype.renderPendingMessages):
Use requestAnimationFrame batching. Run isScrolledToBottom() at most only once
per batch.

(WebInspector.JavaScriptLogViewController.prototype.renderPendingMessagesSoon):
(WebInspector.JavaScriptLogViewController.prototype._didRenderConsoleMessageView):
There is no need to run scrollToBottom again.

• UserInterface/Views/ConsoleCommandView.js:

(WebInspector.ConsoleCommandView):
Move all DOM operations to a new render method.

(WebInspector.ConsoleCommandView.prototype.render):

• UserInterface/Views/ConsoleMessageView.js:

(WebInspector.ConsoleMessageView):
(WebInspector.ConsoleMessageView.prototype.render):
(WebInspector.ConsoleMessageView.prototype.set repeatCount):
(WebInspector.ConsoleMessageView.prototype._renderRepeatCount):

• UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView.prototype.shown):
When the console tab or the split console is opened render all pending messages.

(WebInspector.LogContentView.prototype.didAppendConsoleMessageView):
No need to scrollToBottom once again.

(WebInspector.LogContentView.prototype._messageAdded):
(WebInspector.LogContentView.prototype._previousMessageRepeatCountUpdated):
(WebInspector.LogContentView.prototype._scopeFromMessageLevel): Deleted.
(WebInspector.LogContentView.prototype._markScopeBarItemUnread): Added.
Rename _pulseScopeBarItemBorder. In the very first version the border was pulsing,
but now we use small colored circles instead.

1:32 PM Changeset in webkit [200336] by peavo@outlook.com

• 5 edits in trunk/Source/WebCore

Remove unneeded casts once we upgrade to a version of Visual Studio that is not broken
​https://bugs.webkit.org/show_bug.cgi?id=121235

Reviewed by Darin Adler.

• css/MediaQueryEvaluator.cpp:

(WebCore::createFunctionMap):

• dom/make_names.pl:

(printWrapperFactoryCppFile):

• loader/archive/ArchiveFactory.cpp:

(WebCore::archiveMIMETypes):

• rendering/svg/SVGPathData.cpp:

(WebCore::updatePathFromGraphicsElement):

1:25 PM Changeset in webkit [200335] by achristensen@apple.com

• 2 edits in trunk/Source/WebKit2

Crash if a certificate chain has null certificates
​https://bugs.webkit.org/show_bug.cgi?id=157206

Reviewed by Alexey Proskuryakov.

• NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::certificatesMatch):
SecTrustGetCertificateAtIndex can return null.
If this ever happens, something has gone horribly wrong in the security code and we should crash.
See rdar://problem/21723172

12:59 PM Changeset in webkit [200334] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebInspectorUI

Uncaught Exception: TypeError: null is not an object (evaluating 'sourceCodeLocation.formattedLineNumber')
​https://bugs.webkit.org/show_bug.cgi?id=157239
<rdar://problem/26030791>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-02
Reviewed by Timothy Hatcher.

• UserInterface/Controllers/IssueManager.js:

(WebInspector.IssueManager.issueMatchSourceCode):
Require a sourceCodeLocation for Script errors.

• UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype._addIssue):
Be safe against a missing sourceCodeLocation.

• UserInterface/Views/SourceCodeTextEditor.css:

(.source-code.text-editor > .CodeMirror .issue-widget.inline > .arrow):
(@media (-webkit-min-device-pixel-ratio: 2)):
Adjust the style, on non-Retina the inline message arrow would sometimes
be detached from the warning message.

12:52 PM Changeset in webkit [200333] by andersca@apple.com

• 2 edits in trunk/Source/WebCore

Fix build.

• platform/mac/WebPlaybackControlsManager.h:

12:47 PM Changeset in webkit [200332] by timothy@apple.com

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Zooming of docked Web Inspector affects the webpage, but reset to 0 does not
​https://bugs.webkit.org/show_bug.cgi?id=157234
rdar://problem/26027177

Always prevent default for the zoom keyboard shortcuts to avoid passing the event back to
Safari to handle and add explicit beeps when max/min is hit.

Reviewed by Brian Burg.

• UserInterface/Base/Main.js:

(WebInspector.contentLoaded): Removed setting implicitlyPreventsDefault on zoom keyboard shortcuts.
(WebInspector._increaseZoom): Add explicit beep and remove preventDefault call.
(WebInspector._decreaseZoom): Ditto.

12:33 PM Changeset in webkit [200331] by weinig@apple.com

• 2 edits in trunk/Source/WebCore

DataDetector underline color should be based on the text color
​https://bugs.webkit.org/show_bug.cgi?id=157272

Fixes:

<rdar://problem/25663930> DataDetectors links should use the default text color for their parent nodes
<rdar://problem/25663983> DataDetectors links underline color update

Reviewed by Tim Horton.

• editing/cocoa/DataDetection.mm:

(WebCore::DataDetection::detectContentInRange):
When using light links, use the color of the parent element as the text color, and that same color with
20% alpha as the underline color.

12:08 PM Changeset in webkit [200330] by mmaxfield@apple.com

• 7 edits in trunk/Source/WebKit2

Addressing post-review comments after r200116
​https://bugs.webkit.org/show_bug.cgi?id=157228

Reviewed by Anders Carlsson.

• Shared/WebPreferencesDefinitions.h:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):

• UIProcess/API/Cocoa/WKWebViewConfiguration.h:
• UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration encodeWithCoder:]):
(-[WKWebViewConfiguration initWithCoder:]):
(-[WKWebViewConfiguration copyWithZone:]):

• UIProcess/WebPageProxy.cpp:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

11:59 AM Changeset in webkit [200329] by clopez@igalia.com

• 2 edits in trunk/Tools

[CMake] MiniBrowser fails to build because libsoup link flags are not defined.
​https://bugs.webkit.org/show_bug.cgi?id=157268

Reviewed by Michael Catanzaro.

• MiniBrowser/gtk/CMakeLists.txt:

11:37 AM Changeset in webkit [200328] by peavo@outlook.com

• 6 edits in trunk

[Win] Enable IndexedDB.
​https://bugs.webkit.org/show_bug.cgi?id=157192

Reviewed by Brent Fulgham.

.:

• Source/cmake/OptionsWin.cmake:

Source/WTF:

Fix compile errors when format specifiers like PRIu64 is used, by defining
STDC_FORMAT_MACROS before inttypes.h is included.

• wtf/Platform.h:

LayoutTests:

• platform/win/TestExpectations: Update IndexedDB test expectations.

11:19 AM Changeset in webkit [200327] by rniwa@webkit.org

• 4 edits
  3 adds in trunk

document.currentScript must be null when we're executing a script inside a shadow tree
​https://bugs.webkit.org/show_bug.cgi?id=157245

Reviewed by Darin Adler.

Source/WebCore:

Fix the bug by not setting currentScript as spec'ed in HTML5 specification:
​https://html.spec.whatwg.org/multipage/dom.html#dom-document-currentscript
​https://html.spec.whatwg.org/multipage/scripting.html#execute-the-script-block
as of 3dc763829ca1598427b588cf08830c1e2af5a05c

New behavior matches that of Google Chrome Canary.

Test: fast/shadow-dom/Document-prototype-currentScript.html

• dom/CurrentScriptIncrementer.h:

(WebCore::CurrentScriptIncrementer::CurrentScriptIncrementer):
(WebCore::CurrentScriptIncrementer::~CurrentScriptIncrementer):

• dom/ScriptElement.cpp:

(WebCore::ScriptElement::executeScript):

LayoutTests:

Add a W3C style testharness.js test.

• fast/shadow-dom/Document-prototype-currentScript-expected.txt: Added.
• fast/shadow-dom/Document-prototype-currentScript.html: Added.
• fast/shadow-dom/resources/Document-prototype-currentScript-helper.js: Added.

11:05 AM Changeset in webkit [200326] by achristensen@apple.com

• 4 edits
  2 adds in trunk

Do not reuse cache entries with conditional headers
​https://bugs.webkit.org/show_bug.cgi?id=157205
rdar://problem/25856933

Reviewed by Chris Dumez.

Source/WebCore:

Test: http/tests/xmlhttprequest/if-modified-since-0.html

• loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::canReuse):
CachedResourceLoader::determineRevalidationPolicy asserts that the request is not conditional,
which means that it does not have any headers like If-Modified-Since. They are usually different,
because we put the timestamp in the If-Modified-Since header, so it fails the canReuse test because
time has passed since the last If-Modified-Since header was sent. When a user sets the If-Modified-Since
manually to something that is constant, we reuse cache entries when we should not.

• platform/network/mac/WebCoreResourceHandleAsDelegate.mm:

(-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
Set the source so we can use it in Internals.

LayoutTests:

• http/tests/xmlhttprequest/if-modified-since-0-expected.txt: Added.
• http/tests/xmlhttprequest/if-modified-since-0.html: Added.

10:38 AM Changeset in webkit [200325] by keith_miller@apple.com

• 4 edits
  1 add in trunk/Source/JavaScriptCore

ToThis should be able to be eliminated in Constant Folding
​https://bugs.webkit.org/show_bug.cgi?id=157213

Reviewed by Saam Barati.

This patch enables eliminating the ToThis value when we have abstract interpreter
indicates the node is not needed. Since there are Objects that override their
ToThis behavior we first check if we can eliminate the node by looking at its
speculated type. If the function is in strict mode then we can eliminate ToThis as
long as the speculated type is not SpecObjectOther since that contains objects
that may set OverridesToThis. If the function is not in strict mode then we can
eliminate ToThis as long is the speculated type is an object that is not SpecObjectOther.

If we can't eliminate with type information we can still eliminate the ToThis node with
the proven structure set. When ToThis only sees structures that do not set OverridesToThis
it can be eliminated. Additionally, if the function is in strict mode then we can eliminate
ToThis as long as all only the object structures don't set OverridesToThis.

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::isToThisAnIdentity):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupToThis):

• tests/stress/to-this-global-object.js: Added.

(test):
(test2):
(get for):

9:21 AM Changeset in webkit [200324] by yoav@yoav.ws

• 2 edits in trunk/Source/WebCore

Speculatively fix the cmake build
​https://bugs.webkit.org/show_bug.cgi?id=157262

Reviewed by Darin Adler.

This patch adds WEB_TIMING build flag guards around calls to DOMWindow()->performance(),
in order to make sure builds that have WEB_TIMING disabled (e.g. cmake on Mac) continue
to build.

No new tests as there's no functional change.

• loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::loadDone):

9:15 AM Changeset in webkit [200323] by dbates@webkit.org

• 5 edits in trunk/Source

CSP: Add workaround for XtraMath
​https://bugs.webkit.org/show_bug.cgi?id=157252

Reviewed by Andy Estes.

Source/WebCore:

• platform/RuntimeApplicationChecks.h:
• platform/RuntimeApplicationChecks.mm:

(WebCore::IOSApplication::isXtraMath): Added.

Source/WebKit/mac:

• WebView/WebView.mm:

(shouldAllowContentSecurityPolicySourceStarToMatchAnyProtocol): Allow * to match any protocol for
applicable versions of app XtraMath.

8:57 AM Changeset in webkit [200322] by dbates@webkit.org

• 13 edits in trunk/Source

DatabaseTracker::closeAllDatabases calls Database::close from the wrong thread
​https://bugs.webkit.org/show_bug.cgi?id=147672
<rdar://problem/22357464>

Reviewed by Brady Eidson.

Source/WebCore:

Schedule a DatabaseCloseTask when Database::close() is called from a thread other than the
database thread as the database thread is responsible for interacting with the database.

Currently -[WebDatabaseManager startBackgroundTask] and WebProcess::processWillSuspendImminently()
call DatabaseTracker::closeAllDatabases() indirectly and directly, respectively, from a
thread other than the database thread. In a debug build, this causes an assertion failure
in Database::close(). In a release/production build, this starts a race between the calling
thread and the database thread that can lead to a crash. It is the responsibility of the
database thread to manage the database. We should ensure that calling Database::close()
delegates the responsibility of actually closing the database to the database thread to
avoid interfering with the database thread or the need to synchronize access to data
structures used by the database thread.

• Modules/webdatabase/Database.cpp:

(WebCore::Database::interrupt): Added. Turns around and calls SQLiteDatabase::interrupt().
(WebCore::Database::close): Added. Schedules a DatabaseCloseTask to close the database and
wait for it to complete if we have not already scheduled closing the database.
(WebCore::Database::performClose): Renamed; formerly named close.
(WebCore::Database::markAsDeletedAndClose): Extracted logic to schedule a DatabaseCloseTask
from here to Database::close() and modified this function to call Database::close().

• Modules/webdatabase/Database.h:
• Modules/webdatabase/DatabaseTask.cpp:

(WebCore::DatabaseCloseTask::doPerformTask): Call Database::performClose() instead of Database::close()
as the latter has been repurposed to schedule closing the database.

• Modules/webdatabase/DatabaseThread.cpp:

(WebCore::DatabaseThread::databaseThread): Ditto.

• Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::closeAllDatabases): Added argument currentQueryBehavior (defaults
to CurrentQueryBehavior::RunToCompletion - close every database after completion of the
current database query, if any).

• Modules/webdatabase/DatabaseTracker.h:
• platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::interrupt): Added. This is safe to call regardless of the state
of the database and thread safe by <​https://www.sqlite.org/c3ref/interrupt.html>.

• platform/sql/SQLiteDatabase.h:

Source/WebKit/mac:

Update the background assertion expiration callback to call DatabaseTracker::closeAllDatabases()
with CurrentQueryBehavior::Interrupt so that we abort a long running query and close the database
immediately to avoid holding a locked file when the process is suspended.

• Storage/WebDatabaseManager.mm:

(+[WebDatabaseManager startBackgroundTask]):

Source/WebKit2:

Call DatabaseTracker::closeAllDatabases() with CurrentQueryBehavior::Interrupt so that we abort
a long running query and close the database immediately to avoid holding a locked file when the
process is suspended.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::processWillSuspendImminently):

5:01 AM Changeset in webkit [200321] by gskachkov@gmail.com

• 7 edits
  3 adds in trunk

Class contructor and methods shouldn't have "arguments" and "caller"
​https://bugs.webkit.org/show_bug.cgi?id=144238

Reviewed by Ryosuke Niwa.

Source/JavaScriptCore:

Added TypeError that is raised in case of access to properties 'arguments' or 'caller'
of constructor or method of class.

• runtime/JSFunction.cpp:

(JSC::getThrowTypeErrorGetterSetter):
(JSC::JSFunction::getOwnPropertySlot):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::createThrowTypeErrorArgumentsAndCaller):
(JSC::JSGlobalObject::visitChildren):

• runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::throwTypeErrorArgumentsAndCallerGetterSetter):

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncThrowTypeErrorArgumentsAndCaller):

• runtime/JSGlobalObjectFunctions.h:

LayoutTests:

• js/class-method-and-constructor-properties-expected.txt: Added.
• js/class-method-and-constructor-properties.html: Added.
• js/script-tests/class-method-and-constructor-properties.js: Added.

1:21 AM Changeset in webkit [200320] by yoav@yoav.ws

• 32 edits
  1 copy
  4 adds in trunk

Move ResourceTiming behind a runtime flag
​https://bugs.webkit.org/show_bug.cgi?id=157133

Reviewed by Alex Christensen.

.:

• Source/cmake/WebKitFeatures.cmake: Remove the PERFORMANCE_TIMELINE build flag.

Source/JavaScriptCore:

• runtime/CommonIdentifiers.h: Added PerformanceEntry, PerformanceEntryList and PerformanceResourceTiming as property names.

Source/WebCore:

Move the ResourceTiming API from being behind a build time flag to be behind an
off-by-default runtime flag, that can be turned on using internals.

Tests: fast/dom/Window/window-properties-performance-resource-timing.html

http/tests/performance/performance-resource-timing-entries.html

• DerivedSources.make: Added idl files for PerformanceEntry, PerformanceEntryList and PerformanceResourceTiming.
• WebCore.xcodeproj/project.pbxproj: Added the various Performance* files to the project.
• bindings/generic/RuntimeEnabledFeatures.cpp: Added ResourceTiming as a runtime flag.

(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):

• bindings/generic/RuntimeEnabledFeatures.h: Added ResourceTiming as a runtime flag.

(WebCore::RuntimeEnabledFeatures::setResourceTimingEnabled):
(WebCore::RuntimeEnabledFeatures::resourceTimingEnabled):

• bindings/js/JSPerformanceEntryCustom.cpp: Removed #if for ResourceTiming, and replaced PERFORMANCE_TIMELINE for WEB_TIMING.

Added build flag around UserTiming related h files.
(WebCore::toJS): Deleted.

• dom/EventNames.h: Renamed webkitresourcetimingbufferfull to resourcetimingbufferfull.
• loader/DocumentThreadableLoader.cpp: Replace #if for ResourceTiming with runtime flag.

(WebCore::DocumentThreadableLoader::loadRequest):

• loader/ResourceLoadNotifier.cpp: Replace #if for ResourceTiming with runtime flag.

(WebCore::ResourceLoadNotifier::dispatchWillSendRequest):

• loader/cache/CachedResourceLoader.cpp: Replace #if for ResourceTiming with runtime flag.

(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::storeResourceTimingInitiatorInformation):
(WebCore::CachedResourceLoader::loadDone):

• loader/cache/CachedResourceLoader.h: Remove #if for ResourceTiming.
• page/Performance.cpp: Remove #if for ResourceTiming.

(WebCore::Performance::Performance): Removed #if for ResourceTiming related initialization.
(WebCore::Performance::webkitGetEntries): Renamed to getEntries.
(WebCore::Performance::webkitGetEntriesByType): Renamed to getEntriesByType.
(WebCore::Performance::webkitGetEntriesByName): Renamed to getEntriesByName.

• page/Performance.h: Remove #if for ResourceTiming.
• page/Performance.idl: Replace #if for ResourceTiming with runtime flag.
• page/PerformanceEntry.cpp: Remove the PERFORMANCE_TIMELINE build flag.
• page/PerformanceEntry.h: Remove the PERFORMANCE_TIMELINE build flag.
• page/PerformanceEntry.idl: Replace the PERFORMANCE_TIMELINE build flag with runtime flag.
• page/PerformanceEntryList.cpp: Remove the PERFORMANCE_TIMELINE build flag.
• page/PerformanceEntryList.h: Remove the PERFORMANCE_TIMELINE build flag.
• page/PerformanceEntryList.idl: Replace the PERFORMANCE_TIMELINE build flag with runtime flag.
• page/PerformanceResourceTiming.cpp: Remove the RESOURCE_TIMING build flag.
• page/PerformanceResourceTiming.h: Remove the RESOURCE_TIMING build flag.
• page/PerformanceResourceTiming.idl: Replace the RESOURCE_TIMING build flag with runtime flag.
• testing/Internals.cpp: Add a method that enables ResourceTiming.

(WebCore::Internals::setResourceTimingSupport):

• testing/Internals.h: Add a method that enables ResourceTiming.
• testing/Internals.idl: Add a method that enables ResourceTiming.

LayoutTests:

Added tests that make sure ResourceTiming APIs are exposed and that resources
show up as entries in the performance timeline.

• fast/dom/Window/window-properties-performance-resource-timing-expected.txt: Added.
• fast/dom/Window/window-properties-performance-resource-timing.html: Added.
• fast/dom/Window/window-properties-performance.html: Removed ";".
• http/tests/performance/performance-resource-timing-entries-expected.txt: Added.
• http/tests/performance/performance-resource-timing-entries.html: Added.

1:09 AM Changeset in webkit [200319] by Yusuke Suzuki

• 2 edits
  1 add in trunk/Source/JavaScriptCore

Assertion failure for bound function with custom prototype and Reflect.construct
​https://bugs.webkit.org/show_bug.cgi?id=157081

Reviewed by Saam Barati.

We ensured newTarget != exec->callee(). However, it does not mean newTarget.get("prototype") != exec->callee()->get("prototype").
When the given prototype is the same to baseStructure->sotredPrototype(), it is unnecessary to create a new structure from this
baseStructure.

• bytecode/InternalFunctionAllocationProfile.h:

(JSC::InternalFunctionAllocationProfile::createAllocationStructureFromBase):

• tests/stress/custom-prototype-may-be-same-to-original-one.js: Added.

(shouldBe):
(boundFunction):

May 1, 2016:

11:14 PM Changeset in webkit [200318] by n_wang@apple.com

• 5 edits in trunk

AX: Crash at WebCore::AccessibilityObject::getAttribute const + 9
​https://bugs.webkit.org/show_bug.cgi?id=157256

Reviewed by Chris Fleizach.

Source/WebCore:

When the <label> for the input element has no renderer, it will cause
crash when we ask for the title element text. Fixed it by getting the
aria-label attribute directly from the <label> element instead of its
accessibility object.

Test case covered in accessibility/mac/aria-label-on-label-element.html.

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::titleElementText):

LayoutTests:

• accessibility/mac/aria-label-on-label-element-expected.txt:
• accessibility/mac/aria-label-on-label-element.html:

11:05 PM Changeset in webkit [200317] by Darin Adler

• 26 edits in trunk/Source/WebCore

Stop using string-based enumerations in TextTrack, and eliminate support for string-based enumerations
​https://bugs.webkit.org/show_bug.cgi?id=157253

Reviewed by Chris Dumez.

This was the most difficult case to convert from the old style of enumeration to enum class.
Afterward there is a bit of messy duplication, but it still seems like an improvement overall.

After this patch, I plan to change the rule for the name of the enumeration; instead of
living at the top level of the WebCore namespace, we will look for them inside the class for the
first interface defined in the same file along with the enumeration, and remove the name prefix,
if the interfaces's name is a prefix of the enumerations's name.

Once that's done, next step is to do something in the bindings for dictionaries. And adopt both the
enumeration and dictionary mechanisms more widely, and remove the old use of "dictionary" as a type name.

• Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::removeSourceBuffer): Use enum values instead of keywords.

• Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::textTrackModeChanged): Ditto.

• bindings/js/JSTextTrackCustom.cpp:

(WebCore::JSTextTrack::setKind): Deleted.

• bindings/scripts/CodeGenerator.pm:

(IsStringBasedEnumType): Deleted.

• bindings/scripts/CodeGeneratorJS.pm:

(GetEnumerationImplementationContent): Removed IsStringBasedEnumType check.
(GenerateParametersCheck): Ditto.
(GenerateImplementation): Ditto.
(GetNativeType): Ditto.
(JSValueToNative): Ditto.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadInternal): Use enum values instead of keywords.
(WebCore::HTMLMediaElement::textTrackModeChanged): Ditto.
(WebCore::HTMLMediaElement::textTrackKindChanged): Ditto.
(WebCore::HTMLMediaElement::textTrackAddCues): Ditto.
(WebCore::HTMLMediaElement::textTrackAddCue): Ditto.
(WebCore::HTMLMediaElement::addTextTrack): Ditto.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Ditto.
(WebCore::HTMLMediaElement::setSelectedTextTrack): Ditto.
(WebCore::HTMLMediaElement::configureTextTracks): Ditto.
(WebCore::HTMLMediaElement::hasClosedCaptions): Ditto.
(WebCore::HTMLMediaElement::configureTextTrackDisplay): Ditto.
(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): Ditto.
(WebCore::toPlatform): Added helpers for the outOfBandTrackSources function.
(WebCore::HTMLMediaElement::outOfBandTrackSources): Removed unneeded fastHasAttribute
check since getNonEmptyURLAttribute already returns an empty URL when the attribute is
not present. Changed to use enum values instead of keywords.

• html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::parseAttribute): Use new setKindKeywordIgnoringASCIICase
function rather than calling setKind and convertToASCIILowercase. Also use ensureTrack
instead of track since the latter is a cover that calls it and dumbs down the return type.
(WebCore::HTMLTrackElement::kind): Changed return type to const AtomicString& since
that's what we will have for kind keywords and because it matches what we normally have
for attribute getting fuctions. Also use ensureTrack.
(WebCore::HTMLTrackElement::setKind): Changed argument to AtomicString so we don't waste
time making a string and then destroying it before turning it into an AtomicString so it
can be an attribute value.
(WebCore::HTMLTrackElement::srclang): Changed return type to const AtomicString& as is
customary and efficient for attribute value convenience functions. Also use fastGetAttribute.
(WebCore::HTMLTrackElement::setSrclang): Deleted.
(WebCore::HTMLTrackElement::label): Ditto.
(WebCore::HTMLTrackElement::setLabel): Deleted.
(WebCore::HTMLTrackElement::setIsDefault): Deleted.
(WebCore::HTMLTrackElement::scheduleLoad): Use enum values instead of keywords.

• html/HTMLTrackElement.h: Use pragma once. Update for changes mentioned above.

Also mark things final instead of override as per our recent style discussion.

• html/HTMLTrackElement.idl: Use [Reflect] for srclang and label.

• html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay): Use enum value
instead of keyword.
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Ditto.

• html/track/AudioTrack.cpp:

(WebCore::AudioTrack::AudioTrack): Use new base class MediaTrackBase.

• html/track/AudioTrack.h: Use pragma once. Make base class be MediaTrackBase instead

of TrackBase.

• html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::setMode): Change argument type to enum instead of string.
(WebCore::toPrivate): Added. Helper for setModeInternal.
(WebCore::InbandTextTrack::setModeInternal): Change argument type to enum instead of string.
(WebCore::InbandTextTrack::updateKindFromPrivate): Use enum instead of string to call setKind.

• html/track/InbandTextTrack.h: Use pragma once. Use TextTrackMode for argument types.

• html/track/TextTrack.cpp:

(WebCore::captionsKeyword): Converted this to a non-member function since it is now
private to this file.
(WebCore::descriptionsKeyword): Ditto.
(WebCore::chaptersKeyword): Ditto.
(WebCore::metadataKeyword): Ditto.
(WebCore::forcedKeyword): Ditto.
(WebCore::TextTrack::disabledKeyword): Deleted.
(WebCore::TextTrack::hiddenKeyword): Deleted.
(WebCore::TextTrack::showingKeyword): Deleted.
(WebCore::TextTrack::TextTrack): Moved some initialization to be done in the header where
the data members are defined. Put the code that is the equivalent to setKindInternal here,
because it turns out it's not needed anywhere else. Over time we might change the types
involved and there's no need to have that be across multiple functions.
(WebCore::TextTrack::~TextTrack): Removed unneeded call to clearClient, right when the
object is about to be destroyed. Perhaps there was an illusion that the old call might
be a virtual function call that invokes the clearClient from a derived class, but that
doesn't work in a destructor, so this code was only clearing out the data member and
that does not need to be done.
(WebCore::TextTrack::isValidKind): Deleted.
(WebCore::TextTrack::enabled): Use enum value instead of keyword.
(WebCore::TextTrack::kindKeyword): Added. Function for callers who need a string, not the
enum value.
(WebCore::TextTrack::setKind): Take enum value instead of keyword. Also changed since
we store the kind in a data member in this class, not inherited.
(WebCore::TextTrack::setKindKeywordIgnoringASCIICase): Added. For HTMLTrackElement to use
when setting the kind attribute.
(WebCore::TextTrack::setMode): Take enum value instread of keyword. Also removed assertion
since the enum already makes it intrinsically clear what values are valid, unlike a string.
(WebCore::TextTrack::cues): Use enum value instead of keyword.
(WebCore::TextTrack::activeCues): Ditto.
(WebCore::TextTrack::addCue): Ditto.
(WebCore::TextTrack::ensureVTTRegionList): Changed return type to reference.
(WebCore::TextTrack::regions): Use enum value instead of keyword.
(WebCore::TextTrack::addRegion): Use reference.
(WebCore::TextTrack::cueDidChange): Ditto.
(WebCore::TextTrack::isRendered): Use enum values instead of keywords. Also write to be
a boolean expression instead of a couple different if statements.
(WebCore::TextTrack::ensureTextTrackCueList): Changed return type to reference.
(WebCore::TextTrack::isMainProgramContent): Use enum value instead of keyword.
(WebCore::TextTrack::containsOnlyForcedSubtitles): Ditto.

• html/track/TextTrack.h: Use pragma once. Removed unneeded include. Added enums for

TextTrackKind and TextTrackMode. Updated for changes to functions listed above.
Added m_mode and m_kind and initialized those data members and some others.

• html/track/TextTrack.idl: Tweaked formatting. Used ImplementedAs for the kind

attribute rather than using a CustomSetter. This preserves the strange behavior
where setting kind does nothing when !ENABLE(MEDIA_SOURCE). If we discover we don't
need that, then we won't need ImplementedAs any more either.

• html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::dispatchEvent): Use enum instad of keyword.
(WebCore::TextTrackCue::isActive): Ditto.

• html/track/TrackBase.cpp:

(WebCore::TrackBase::TrackBase): Removed unneeded initialization that is handled in
the data member definition in the header now.
(WebCore::MediaTrackBase::MediaTrackBase): Added. Calls through to TrackBase.
(WebCore::MediaTrackBase::setKind): Moved to MediaTrackBase from TrackBase, because
this isn't needed for text tracks.
(WebCore::MediaTrackBase::setKindInternal): Ditto.

• html/track/TrackBase.h: Use pragma once. Move kind, setKind, isValidKind, defaultKindKeyword,

setKindInternal, and m_kind all to a derived class, MediaTrackBase, since TextTrack doesn't need
any of those any more. Later we might adopt enumerations more and it's possible the need for
MediaTrackBase will go away.

• html/track/VideoTrack.cpp:

(WebCore::VideoTrack::VideoTrack): Updated to use MediaTrackBase.
(WebCore::VideoTrack::setLanguage): Ditto.

• html/track/VideoTrack.h: Use pragma once. Removed unneeded header include.

Derive from MediaTrackBase instead of TrackBase.

• page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::sortedTrackListForMenu): Use enum values instead
of keywords.
(WebCore::CaptionUserPreferences::textTrackSelectionScore): Ditto.

• page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::textTrackSelectionScore): Ditto.
(WebCore::CaptionUserPreferencesMediaAF::sortedTrackListForMenu): Ditto. Also used
kindKeyword since we want a string for logging.

• platform/cocoa/WebPlaybackSessionModelMediaElement.mm:

(WebPlaybackSessionModelMediaElement::updateLegibleOptions): Ditto.

9:21 PM Changeset in webkit [200316] by Chris Dumez

• 30 edits in trunk/Source/WebCore

Pass reference instead of pointer to IDL attribute setters if not nullable
​https://bugs.webkit.org/show_bug.cgi?id=157250

Reviewed by Darin Adler.

Update the bindings generator so that we pass wrapper types by reference
to attribute setters instead of by raw pointer when the attribute is not
marked as nullable in the IDL.

There is no intended Web-exposed behavior change.

• Modules/speech/SpeechSynthesisUtterance.idl:
• Modules/webaudio/ConvolverNode.idl:
• bindings/js/JSDataCueCustom.cpp:

(WebCore::constructJSDataCue):

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

• bindings/scripts/CodeGeneratorObjC.pm:

(GenerateImplementation):

• bindings/scripts/test/JS/JSTestInterface.cpp:
• bindings/scripts/test/JS/JSTestObj.cpp:
• bindings/scripts/test/ObjC/DOMTestInterface.mm:
• bindings/scripts/test/ObjC/DOMTestObj.mm:

Rebaseline bindings tests.

• dom/Document.cpp:

(WebCore::Document::moveNodeIteratorsToNewDocument):

• dom/NodeIterator.cpp:

(WebCore::NodeIterator::NodePointer::NodePointer):
(WebCore::NodeIterator::NodePointer::moveToNext):
(WebCore::NodeIterator::NodePointer::moveToPrevious):
(WebCore::NodeIterator::NodeIterator):
(WebCore::NodeIterator::~NodeIterator):
(WebCore::NodeIterator::updateForNodeRemoval):
(WebCore::NodeIterator::NodePointer::clear): Deleted.
(WebCore::NodeIterator::nextNode): Deleted.

• dom/NodeIterator.h:
• dom/Traversal.cpp:

(WebCore::NodeIteratorBase::NodeIteratorBase):

• dom/Traversal.h:

(WebCore::NodeIteratorBase::root):

• dom/TreeWalker.cpp:

(WebCore::TreeWalker::setCurrentNode):
(WebCore::TreeWalker::setCurrent):
(WebCore::TreeWalker::parentNode):
(WebCore::TreeWalker::firstChild):
(WebCore::TreeWalker::lastChild):
(WebCore::TreeWalker::traverseSiblings):
(WebCore::TreeWalker::previousNode):
(WebCore::TreeWalker::nextNode):

• dom/TreeWalker.h:

(WebCore::TreeWalker::currentNode):

• dom/TreeWalker.idl:
• html/HTMLAttachmentElement.idl:
• html/HTMLInputElement.idl:
• html/HTMLTableElement.idl:
• html/track/DataCue.cpp:

(WebCore::DataCue::DataCue):
(WebCore::DataCue::setData):
(WebCore::toDataCue): Deleted.

• html/track/DataCue.h:
• html/track/DataCue.idl:

5:32 PM Changeset in webkit [200315] by commit-queue@webkit.org

• 12 edits
  2 deletes in trunk

Unreviewed, rolling out r200264 and r200266.
​https://bugs.webkit.org/show_bug.cgi?id=157251

This change caused existing LayoutTest media/media-source
/media-source-stalled-holds-sleep-assertion.html to time out
on Mac on every run. (Requested by ryanhaddad on #webkit).

Reverted changesets:

"[Mac] AirPlay fails if target is set before AVPlayer has been
created"
​https://bugs.webkit.org/show_bug.cgi?id=157147
​http://trac.webkit.org/changeset/200264

"[Mac] AirPlay fails if target is set before AVPlayer has been
created"
​https://bugs.webkit.org/show_bug.cgi?id=157147
​http://trac.webkit.org/changeset/200266

5:21 PM Changeset in webkit [200314] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Drop CanUseWTFOptionalForParameter() from bindings generator
​https://bugs.webkit.org/show_bug.cgi?id=157247

Reviewed by Darin Adler.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):
(CanUseWTFOptionalForParameter): Deleted.

5:17 PM Changeset in webkit [200313] by Darin Adler

• 13 edits in trunk/Source

Update Fetch to use enum class instead of string for enumerations
​https://bugs.webkit.org/show_bug.cgi?id=157241

Reviewed by Chris Dumez.

Source/WebCore:

• Modules/fetch/FetchOptions.h: Changed this class into a struct,

getting rid of all the getter and setter functions. Moved all the
enumeration types out of this class to the WebCore namespace level
and gave them all the names and values that match the ones from the
IDL file.

• Modules/fetch/FetchRequest.cpp:

(WebCore::setReferrerPolicy): Updated for the changes to FetchOptions.
The string matching here will likely go away when we change dictionary
so it sets up a structure, which will parse the enumeration values, but
that won't be for a while, so this stays for now.
(WebCore::setMode): Ditto.
(WebCore::setCredentials): Ditto.
(WebCore::setCache): Ditto.
(WebCore::setRedirect): Ditto.
(WebCore::buildOptions): Updated for changes to FetchOptions.
(WebCore::buildHeaders): Ditto.
(WebCore::FetchRequest::create): Ditto.
(WebCore::FetchRequest::type): Moved this to the header and changed its
return type to the enum; it's not just a single return statement.
(WebCore::FetchRequest::destination): Ditto.
(WebCore::FetchRequest::referrerPolicy): Ditto.
(WebCore::FetchRequest::mode): Ditto.
(WebCore::FetchRequest::credentials): Ditto.
(WebCore::FetchRequest::cache): Ditto.
(WebCore::FetchRequest::redirect): Ditto.

• Modules/fetch/FetchRequest.h: Changed all the getters that return

enumerations to return the enum class values instead of strings.
Put all the inline versions here in the header.

• bindings/scripts/CodeGenerator.pm: Removed the seven enum types that

are in FetchRequest.idl from the list of "string-based" enums.

• dom/Document.cpp:

(WebCore::Document::Document): Updated for the change where I
renamed ReferrerPolicy to ReferrerHeaderPolicy, at least for now.
(WebCore::Document::processReferrerPolicy): Ditto.
(WebCore::Document::applyContentDispositionAttachmentSandbox): Ditto.

• dom/Document.h: Ditto.
• loader/FrameNetworkingContext.h: Ditto.
• page/SecurityPolicy.cpp:

(WebCore::SecurityPolicy::generateReferrerHeader): Ditto.

• page/SecurityPolicy.h: Ditto.

• platform/ReferrerPolicy.h: Renamed this enum from ReferrerPolicy to

ReferrerHeaderPolicy, since the one specified in the Fetch API has the
name ReferrerPolicy. I think the best way to resolve this longer term is
to merge them since they really do represent the same concept, although
the one from the Fetch API has a few more features.

Source/WebKit2:

• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::loadResource): Updated for the change where I
renamed ReferrerPolicy to ReferrerHeaderPolicy, at least for now.
(WebKit::WebLoaderStrategy::schedulePluginStreamLoad): Ditto.

2:30 PM Changeset in webkit [200312] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Unreviewed attempt to fix Windows build after r200288.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):

2:08 PM Changeset in webkit [200311] by Konstantin Tokarev

• 2 edits in trunk/Source/WebKit2

Fixed build with !ENABLED(DATABASE_PROCESS).

Unreviewed build fix.

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::grantSandboxExtensionsToDatabaseProcessForBlobs):

1:58 PM Changeset in webkit [200310] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Unreviewed attempt to fix Windows build after r200288.

• bindings/scripts/CodeGeneratorJS.pm:

(GetEnumerationImplementationContent):

1:00 PM Changeset in webkit [200309] by youenn.fablet@crf.canon.fr

• 165 edits
  82 adds in trunk/LayoutTests

Sync web-platform-tests up to revision 4af8373
​https://bugs.webkit.org/show_bug.cgi?id=157170

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Rebasing expectations.

• resources/ImportExpectations: Skipping new test suites.

Skipping IndexedDB until we decide whether to continue having these tests here.

• resources/TestRepositories: Updating revision to 4af8373.
• resources/web-platform-tests-modules.json:
• web-platform-tests/IndexedDB/idbindex-multientry-big-expected.txt:
• web-platform-tests/IndexedDB/idbindex_get7-expected.txt:
• web-platform-tests/IndexedDB/idbindex_getKey7-expected.txt:
• web-platform-tests/IndexedDB/idbindex_openCursor2-expected.txt:
• web-platform-tests/IndexedDB/idbindex_openKeyCursor3-expected.txt:
• web-platform-tests/README.md:
• web-platform-tests/XMLHttpRequest/OWNERS:
• web-platform-tests/XMLHttpRequest/XMLHttpRequest-withCredentials-expected.txt:
• web-platform-tests/XMLHttpRequest/XMLHttpRequest-withCredentials.js:

(test_withCredentials.): Deleted.

• web-platform-tests/XMLHttpRequest/abort-during-open.htm:
• web-platform-tests/XMLHttpRequest/abort-during-open.js: Added.

(test.async_test.test.step.client.onreadystatechange):
(test.async_test.test.step):

• web-platform-tests/XMLHttpRequest/abort-during-open.worker.js: Added.
• web-platform-tests/XMLHttpRequest/data-uri-expected.txt:
• web-platform-tests/XMLHttpRequest/data-uri.htm:
• web-platform-tests/XMLHttpRequest/formdata-set-expected.txt:
• web-platform-tests/XMLHttpRequest/formdata-set.htm:
• web-platform-tests/XMLHttpRequest/interfaces-expected.txt:
• web-platform-tests/XMLHttpRequest/resources/auth7/corsenabled.py: Added.

(main):

• web-platform-tests/XMLHttpRequest/resources/auth7/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/dom/lists/w3c-import.log.
• web-platform-tests/XMLHttpRequest/resources/auth8/corsenabled-no-authorize.py: Added.

(main):

• web-platform-tests/XMLHttpRequest/resources/auth8/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/dom/lists/w3c-import.log.
• web-platform-tests/XMLHttpRequest/resources/auth9/auth.py: Added.

(main):

• web-platform-tests/XMLHttpRequest/resources/auth9/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/dom/lists/w3c-import.log.
• web-platform-tests/XMLHttpRequest/responseurl-expected.txt: Added.
• web-platform-tests/XMLHttpRequest/responseurl.html: Added.
• web-platform-tests/XMLHttpRequest/send-authentication-basic-setrequestheader-and-arguments-expected.txt: Added.
• web-platform-tests/XMLHttpRequest/send-authentication-basic-setrequestheader-and-arguments.htm: Added.
• web-platform-tests/XMLHttpRequest/send-authentication-cors-setrequestheader-no-cred-expected.txt: Added.
• web-platform-tests/XMLHttpRequest/send-authentication-cors-setrequestheader-no-cred.htm: Added.
• web-platform-tests/XMLHttpRequest/send-entity-body-document-expected.txt:
• web-platform-tests/XMLHttpRequest/send-send.htm:
• web-platform-tests/XMLHttpRequest/send-send.js: Added.

(test):

• web-platform-tests/XMLHttpRequest/send-send.worker.js: Added.
• web-platform-tests/XMLHttpRequest/setrequestheader-bogus-name-expected.txt:
• web-platform-tests/XMLHttpRequest/setrequestheader-bogus-name.htm:
• web-platform-tests/XMLHttpRequest/setrequestheader-bogus-value-expected.txt:
• web-platform-tests/XMLHttpRequest/setrequestheader-bogus-value.htm:
• web-platform-tests/XMLHttpRequest/w3c-import.log:
• web-platform-tests/common/OWNERS:
• web-platform-tests/dom/collections/HTMLCollection-as-proto-length-get-throws-expected.txt: Added.
• web-platform-tests/dom/collections/HTMLCollection-as-proto-length-get-throws.html: Added.
• web-platform-tests/dom/collections/HTMLCollection-supported-property-indices-expected.txt: Added.
• web-platform-tests/dom/collections/HTMLCollection-supported-property-indices.html: Added.
• web-platform-tests/dom/collections/w3c-import.log:
• web-platform-tests/dom/events/Event-constructors-expected.txt:
• web-platform-tests/dom/events/Event-constructors.html:
• web-platform-tests/dom/events/Event-defaultPrevented-after-dispatch-expected.txt: Added.
• web-platform-tests/dom/events/Event-defaultPrevented-after-dispatch.html: Added.
• web-platform-tests/dom/events/Event-dispatch-bubbles-false-expected.txt:
• web-platform-tests/dom/events/Event-dispatch-bubbles-false.html:
• web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt:
• web-platform-tests/dom/events/ProgressEvent-expected.txt:
• web-platform-tests/dom/events/ProgressEvent.html:
• web-platform-tests/dom/events/w3c-import.log:
• web-platform-tests/dom/interfaces-expected.txt:
• web-platform-tests/dom/interfaces.html:
• web-platform-tests/dom/lists/DOMTokenList-value-expected.txt: Added.
• web-platform-tests/dom/lists/DOMTokenList-value.html: Added.
• web-platform-tests/dom/lists/w3c-import.log:
• web-platform-tests/dom/nodes/CharacterData-appendChild-expected.txt: Added.
• web-platform-tests/dom/nodes/CharacterData-appendChild.html: Added.
• web-platform-tests/dom/nodes/DOMImplementation-createDocument-expected.txt:
• web-platform-tests/dom/nodes/DOMImplementation-createDocument.html:
• web-platform-tests/dom/nodes/Document-Element-getElementsByTagName.js:

(test_getElementsByTagName):

• web-platform-tests/dom/nodes/Document-characterSet-normalization-expected.txt:
• web-platform-tests/dom/nodes/Document-characterSet-normalization.html:
• web-platform-tests/dom/nodes/Document-createElement-namespace-expected.txt:
• web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.html: Added.
• web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.svg: Added.
• web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xhtml: Added.
• web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xml: Added.
• web-platform-tests/dom/nodes/Document-createElement-namespace.html:
• web-platform-tests/dom/nodes/Document-createEvent-expected.txt:
• web-platform-tests/dom/nodes/Document-createEvent.html:
• web-platform-tests/dom/nodes/Document-createEvent.js:
• web-platform-tests/dom/nodes/Document-getElementsByTagName-expected.txt:
• web-platform-tests/dom/nodes/Document-getElementsByTagName-xhtml-expected.txt:
• web-platform-tests/dom/nodes/Document-getElementsByTagName-xhtml.xhtml:
• web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt:
• web-platform-tests/dom/nodes/Element-hasAttributes-expected.txt: Added.
• web-platform-tests/dom/nodes/Element-hasAttributes.html: Added.
• web-platform-tests/dom/nodes/Element-insertAdjacentElement-expected.txt: Added.
• web-platform-tests/dom/nodes/Element-insertAdjacentElement.html: Added.
• web-platform-tests/dom/nodes/Element-insertAdjacentText-expected.txt: Added.
• web-platform-tests/dom/nodes/Element-insertAdjacentText.html: Added.
• web-platform-tests/dom/nodes/Node-contains-xml-expected.txt: Added.
• web-platform-tests/dom/nodes/Node-contains-xml.xml: Added.
• web-platform-tests/dom/nodes/Node-isSameNode-expected.txt: Added.
• web-platform-tests/dom/nodes/Node-isSameNode.html: Added.
• web-platform-tests/dom/nodes/Node-parentElement.html:
• web-platform-tests/dom/nodes/Node-replaceChild-expected.txt:
• web-platform-tests/dom/nodes/Node-replaceChild.html:
• web-platform-tests/dom/nodes/attributes-expected.txt:
• web-platform-tests/dom/nodes/attributes.html:
• web-platform-tests/dom/nodes/attributes.js:

(attr_is):

• web-platform-tests/dom/nodes/case-expected.txt:
• web-platform-tests/dom/nodes/case.js:

(get_qualified_name):
(test_get_elements_tag_name):

• web-platform-tests/dom/nodes/insert-adjacent-expected.txt: Added.
• web-platform-tests/dom/nodes/insert-adjacent.html: Added.
• web-platform-tests/dom/nodes/remove-unscopable-expected.txt: Added.
• web-platform-tests/dom/nodes/remove-unscopable.html: Added.
• web-platform-tests/dom/nodes/rootNode-expected.txt: Added.
• web-platform-tests/dom/nodes/rootNode.html: Added.
• web-platform-tests/dom/nodes/w3c-import.log:
• web-platform-tests/dom/ranges/Range-stringifier-expected.txt: Added.
• web-platform-tests/dom/ranges/Range-stringifier.html: Added.
• web-platform-tests/dom/ranges/w3c-import.log:
• web-platform-tests/dom/traversal/TreeWalker-acceptNode-filter.html:
• web-platform-tests/dom/traversal/TreeWalker-basic.html:
• web-platform-tests/dom/traversal/TreeWalker-currentNode.html:
• web-platform-tests/dom/traversal/TreeWalker-previousNodeLastChildReject.html:
• web-platform-tests/dom/traversal/TreeWalker-previousSiblingLastChildSkip.html:
• web-platform-tests/dom/traversal/TreeWalker-traversal-reject.html:
• web-platform-tests/dom/traversal/TreeWalker-traversal-skip-most.html:
• web-platform-tests/dom/traversal/TreeWalker-traversal-skip.html:
• web-platform-tests/dom/traversal/TreeWalker-walking-outside-a-tree.html:
• web-platform-tests/fetch/api/cors/cors-preflight.js:
• web-platform-tests/fetch/api/credentials/cookies.js:

(cookies):

• web-platform-tests/fetch/api/policies/referrer-origin-expected.txt:
• web-platform-tests/fetch/api/policies/referrer-origin.js:

(promise_test):

• web-platform-tests/fetch/api/request/request-consume.html:
• web-platform-tests/fetch/api/request/resources/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/dom/lists/w3c-import.log.
• web-platform-tests/fetch/api/request/w3c-import.log:
• web-platform-tests/fetch/api/resources/utils.js:

(validateStreamFromString):

• web-platform-tests/fetch/api/response/response-cancel-stream-expected.txt:
• web-platform-tests/fetch/api/response/response-consume-stream-expected.txt:
• web-platform-tests/fetch/api/response/w3c-import.log:
• web-platform-tests/html/OWNERS:
• web-platform-tests/html/dom/documents/dom-tree-accessors/Document.getElementsByClassName-null-undef.html:
• web-platform-tests/html/dom/documents/dom-tree-accessors/Element.getElementsByClassName-null-undef.html:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByClassName-same.html:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-case-xhtml.xhtml:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-case.html:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-id-xhtml.xhtml:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-id.html:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-namespace-xhtml.xhtml:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-namespace.html:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-xhtml.xhtml:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements.html:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-param-xhtml.xhtml:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-param.html:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-same.html:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.head-01.html:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.head-02.html:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-01.html:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-02.xhtml:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-03.html:
• web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-04.xhtml:
• web-platform-tests/html/dom/elements/global-attributes/id-name-specialcase.html:
• web-platform-tests/html/dom/elements/global-attributes/id-name.html:
• web-platform-tests/html/dom/interfaces-expected.txt:
• web-platform-tests/html/dom/interfaces.html:
• web-platform-tests/html/resources/common.js:

(isVoidElement): Deleted.

• web-platform-tests/html/semantics/document-metadata/the-link-element/resources/stylesheet.css: Added.

(body):

• web-platform-tests/html/semantics/document-metadata/the-link-element/resources/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/dom/lists/w3c-import.log.
• web-platform-tests/html/semantics/document-metadata/the-link-element/stylesheet-with-base-expected.html: Added.
• web-platform-tests/html/semantics/document-metadata/the-link-element/stylesheet-with-base.html: Added.
• web-platform-tests/html/semantics/document-metadata/the-link-element/stylesheet.css: Added.

(body):

• web-platform-tests/html/semantics/document-metadata/the-link-element/w3c-import.log:
• web-platform-tests/html/semantics/embedded-content/the-canvas-element/2d.scaled.png: Added.
• web-platform-tests/html/semantics/embedded-content/the-canvas-element/w3c-import.log:
• web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-ignored-in-media-element-expected.txt: Added.
• web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-ignored-in-media-element.html: Added.
• web-platform-tests/html/semantics/embedded-content/the-embed-element/w3c-import.log:
• web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-with-base-expected.html: Added.
• web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-with-base.html: Added.
• web-platform-tests/html/semantics/embedded-content/the-iframe-element/w3c-import.log:
• web-platform-tests/html/semantics/embedded-content/the-img-element/document-base-url-expected.html: Added.
• web-platform-tests/html/semantics/embedded-content/the-img-element/document-base-url.html: Added.
• web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/viewport-change-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-img-element/resources/cat.jpg: Added.
• web-platform-tests/html/semantics/embedded-content/the-img-element/resources/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/dom/lists/w3c-import.log.
• web-platform-tests/html/semantics/embedded-content/the-img-element/w3c-import.log:
• web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt:
• web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput.html:
• web-platform-tests/html/semantics/forms/form-submission-0/getactionurl-expected.txt: Added.
• web-platform-tests/html/semantics/forms/form-submission-0/getactionurl.html: Added.
• web-platform-tests/html/semantics/forms/form-submission-0/w3c-import.log:
• web-platform-tests/html/semantics/forms/textfieldselection/selection-after-content-change-expected.txt: Added.
• web-platform-tests/html/semantics/forms/textfieldselection/selection-after-content-change.html: Added.
• web-platform-tests/html/semantics/forms/textfieldselection/w3c-import.log:
• web-platform-tests/html/semantics/forms/the-form-element/form-autocomplete-expected.txt:
• web-platform-tests/html/semantics/forms/the-form-element/form-autocomplete.html:
• web-platform-tests/html/semantics/forms/the-input-element/checkbox.html:
• web-platform-tests/html/semantics/forms/the-input-element/selection-expected.txt: Added.
• web-platform-tests/html/semantics/forms/the-input-element/selection.html: Added.
• web-platform-tests/html/semantics/forms/the-input-element/w3c-import.log:
• web-platform-tests/html/semantics/forms/the-legend-element/legend-form-expected.txt:
• web-platform-tests/html/semantics/forms/the-legend-element/legend-form.html:
• web-platform-tests/html/semantics/grouping-content/the-ol-element/ol.start-reflection-1.html:
• web-platform-tests/html/semantics/grouping-content/the-ol-element/ol.start-reflection-2.html:
• web-platform-tests/html/semantics/links/linktypes/alternate-css-expected.html: Added.
• web-platform-tests/html/semantics/links/linktypes/alternate-css.html: Added.
• web-platform-tests/html/semantics/links/linktypes/alternate.css: Added.

(div):

• web-platform-tests/html/semantics/links/linktypes/preferred.css: Added.

(div):

• web-platform-tests/html/semantics/links/linktypes/w3c-import.log:
• web-platform-tests/html/semantics/selectors/pseudo-classes/default-expected.txt:
• web-platform-tests/html/semantics/selectors/pseudo-classes/default.html:
• web-platform-tests/html/semantics/selectors/pseudo-classes/focus-autofocus-expected.txt: Added.
• web-platform-tests/html/semantics/selectors/pseudo-classes/focus-autofocus.html: Added.
• web-platform-tests/html/semantics/selectors/pseudo-classes/focus-expected.txt:
• web-platform-tests/html/semantics/selectors/pseudo-classes/focus.html:
• web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange-expected.txt:
• web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange.html:
• web-platform-tests/html/semantics/selectors/pseudo-classes/link-expected.txt:
• web-platform-tests/html/semantics/selectors/pseudo-classes/link.html:
• web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly-expected.txt:
• web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly.html:
• web-platform-tests/html/semantics/selectors/pseudo-classes/w3c-import.log:
• web-platform-tests/html/semantics/tabular-data/the-table-element/insertRow-method-03-expected.txt: Added.
• web-platform-tests/html/semantics/tabular-data/the-table-element/insertRow-method-03.html: Added.
• web-platform-tests/html/semantics/tabular-data/the-table-element/tFoot-expected.txt: Added.
• web-platform-tests/html/semantics/tabular-data/the-table-element/tFoot.html: Added.
• web-platform-tests/html/semantics/tabular-data/the-table-element/tHead-expected.txt: Added.
• web-platform-tests/html/semantics/tabular-data/the-table-element/tHead.html: Added.
• web-platform-tests/html/semantics/tabular-data/the-table-element/w3c-import.log:
• web-platform-tests/lint.whitelist:
• web-platform-tests/media/OWNERS:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-add.https.html:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-delete.https.html:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https.html:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-matchAll.https.html:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-put.https.html:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-keys.https.html:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-match.https.html:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage.https.html:
• web-platform-tests/service-workers/cache-storage/serviceworker/credentials.html:
• web-platform-tests/streams/byte-length-queuing-strategy.js:

(test):

• web-platform-tests/streams/count-queuing-strategy.js:

(test):

• web-platform-tests/streams/readable-streams/bad-strategies.js:

(get string_appeared_here):
(promise_test):

• web-platform-tests/streams/readable-streams/bad-underlying-sources.https-expected.txt:
• web-platform-tests/streams/readable-streams/bad-underlying-sources.js:

(promise_test):
(promise_test.t.const.closed.new.ReadableStream.start):

• web-platform-tests/streams/readable-streams/cancel.js:

(promise_test): Deleted.

• web-platform-tests/streams/readable-streams/general.https-expected.txt:
• web-platform-tests/streams/readable-streams/general.js:

(test):
(promise_test):
(promise_test.t.const.rs.new.ReadableStream.pull):
(promise_test.t.const.rs.new.ReadableStream.start): Deleted.

• web-platform-tests/streams/readable-streams/readable-stream-reader.js:

(test):

• web-platform-tests/streams/readable-streams/templated.https-expected.txt:
• web-platform-tests/streams/resources/rs-test-templates.js:

(self.templatedRSEmpty):

LayoutTests:

• platform/ios-simulator/TestExpectations: Marking some tests as failing.
• platform/wk2/imported/w3c/web-platform-tests/html/semantics/document-metadata/styling/LinkStyle-expected.txt:

12:22 PM Changeset in webkit [200308] by bshafiei@apple.com

• 5 edits in tags/Safari-602.1.30.2/Source

Versioning.

12:19 PM Changeset in webkit [200307] by bshafiei@apple.com

• 1 copy in tags/Safari-602.1.30.2

New tag.

11:56 AM Changeset in webkit [200306] by mitz@apple.com

• 1 edit
  1 delete in trunk/Source/WebInspectorUI

WebInspectorUI.framework/Versions/A/Resources/Images/Legacy is empty
​https://bugs.webkit.org/show_bug.cgi?id=157248

Reviewed by Timothy Hatcher.

• UserInterface/Images/Legacy: Removed.

10:52 AM Changeset in webkit [200305] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Unreviewed, rebaseline bindings tests after r200300.

• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsStringWithCache):

9:37 AM Changeset in webkit [200304] by Darin Adler

• 5 edits in trunk/Source/WebCore

Use enum class instead of string-based enums in RTC code
​https://bugs.webkit.org/show_bug.cgi?id=157242

Reviewed by Alex Christensen.

• Modules/mediastream/RTCConfiguration.cpp:

(WebCore::RTCConfiguration::RTCConfiguration): Don't initialize members here,
do it in the header instead.
(WebCore::RTCConfiguration::initialize): Initialize data members to enum values,
not strings.

• Modules/mediastream/RTCConfiguration.h: Tried to keep this class compiling.

Added the new enum class, and changed to use that instead of strings. But note,
this should not even be a class. Needs to become a dictionary.

• Modules/mediastream/RTCConfiguration.idl: Updated the names and values of the

enums to match the current RTC specification. Again, as I said, this should be
a dictionary, not an interface.

• bindings/scripts/CodeGenerator.pm: Removed the RTC enumerations from the list

of string-based enums.

7:09 AM Changeset in webkit [200303] by youenn.fablet@crf.canon.fr

• 3 edits
  4 adds in trunk/LayoutTests/imported/w3c

Fix 157169

Update W3C importer files related to csswg-test files after r200234
​https://bugs.webkit.org/show_bug.cgi?id=157169

Reviewed by Ryosuke Niwa.

Updating ImportExpectations to import css-scoping-1 test suite only from css wg test repository.
Updating TestRepositories to set the current csswg-test revision to b2daa426addd5ccb8e9ce1c5d800f9d82603f1ec.
Rerun test importer to add some additional files (document, license...).

• csswg-test/CONTRIBUTING.md: Added.
• csswg-test/LICENSE: Added.
• csswg-test/README.md: Added.
• csswg-test/w3c-import.log: Added.
• resources/ImportExpectations:
• resources/TestRepositories: