Context Navigation

← Previous Period
Next Period →

Timeline

May 7, 2016:

11:39 PM Changeset in webkit [200552] by Darin Adler

12 edits in trunk

Change MutationObserver::observe to take an IDL dictionary, rather than WebCore::Dictionary
https://bugs.webkit.org/show_bug.cgi?id=157456

Reviewed by Chris Dumez.

Source/WebCore:

bindings/js/JSDOMConvert.h:

(WebCore::convertOptional): Use a specific Optional null rather than Nullopt so we
can compile the ternary operator.
(WebCore::convert<bool>): Added.
(WebCore::convert<Vector<String>>): Added. Later we probably need to change convert to use
a member function of a class template rather than a function template so we can make partial
specialization work and do this just once for all Vector<T>.

bindings/js/JSMutationObserverCustom.cpp:

(WebCore::JSMutationObserverOwner::isReachableFromOpaqueRoots): Streamlined code and removed
some local variables. Changed to call the new observedNodes rather than getObservedNodes.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateDictionaryImplementationContent): Fixed bug where we tried to call the version of
the convert function with a default value even when there was none.

bindings/scripts/test/TestObj.idl: Added a test case basically identical to what's needed

in MutationObserver.idl.

bindings/scripts/test/JS/JSTestObj.cpp: Regenerated.

dom/MutationObserver.cpp:

(WebCore::MutationObserver::observe): Chagned function to take a MutationObserver::Init
instead of a Dictionary.
(WebCore::MutationObserver::observationStarted): Changed argument type to a reference.
(WebCore::MutationObserver::observationEnded): Ditto.
(WebCore::MutationObserverMicrotask): Removed unneeded explicit constructor and destructor.
(WebCore::queueMutationObserverCompoundMicrotask): Got rid of unnneeded local variable.
(WebCore::MutationObserver::observedNodes): Renamed to remove the "get" prefix.

dom/MutationObserver.h: Reduced includes. Added MutationObserver::Init struct and

used it for the type of the argument to the observe function. Changed a few argument
types and removed unused forward declarations.

dom/MutationObserver.idl: Added MutationObserverInit and used it instead of Dictionary.

dom/MutationObserverRegistration.cpp:

(WebCore::MutationObserverRegistration::MutationObserverRegistration): Pass a reference.
(WebCore::MutationObserverRegistration::~MutationObserverRegistration): Ditto.

LayoutTests:

fast/dom/MutationObserver/observe-exceptions-expected.txt: Updated to expect

the specific TypeError generated by the bindings code rather than the generic
TypeError we got before generated inside the C++ DOM.

9:57 PM Changeset in webkit [200551] by rniwa@webkit.org

2 edits in trunk/Websites/perf.webkit.org

Add horizontal between categories of tests
https://bugs.webkit.org/show_bug.cgi?id=157386

Reviewed by Darin Adler.

Wrap tests in each category by tbody and add a horizontal bar between each category.

public/v3/pages/summary-page.js:

(SummaryPage.prototype._constructTable):
(SummaryPage.cssTemplate):

9:39 PM Changeset in webkit [200550] by Chris Dumez

29 edits
1 add in trunk/Source/WebCore

Reduce special handling of XPathNSResolver type in the bindings
https://bugs.webkit.org/show_bug.cgi?id=157454

Reviewed by Darin Adler.

Reduce special handling of XPathNSResolver type in the bindings.

CMakeLists.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSBindingsAllInOne.cpp:

Add new JSXPathNSResolverCustom.cpp file.

bindings/js/JSDOMStringListCustom.cpp:

(WebCore::JSDOMStringList::toWrapped):
Take the ExecState by reference instead of pointer.

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::toWrapped):
Update to take an ExecState& parameter. The bindings now pass
an ExecState to all custom toWrapped() methods for consistency
and flexibility.

bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):
Pass an ExecState now that those toWrapped() methods expect
it.

bindings/js/JSEventTargetCustom.cpp:

(WebCore::JSEventTarget::toWrapped):
Update to take an ExecState& parameter.

bindings/js/JSIDBDatabaseCustom.cpp:

(WebCore::JSIDBDatabase::transaction):
Pass ExecState by reference instead of pointer.

bindings/js/JSMessageEventCustom.cpp:

(WebCore::handleInitMessageEvent):
Pass ExecState to JSDOMWindow::toWrapped().

bindings/js/JSXPathNSResolverCustom.cpp: Added.

(WebCore::JSXPathNSResolver::toWrapped):
Provide a custom implementation of JSXPathNSResolver::toWrapped()
instead of having the custom code in the bindings generator.

bindings/scripts/CodeGeneratorJS.pm:

(AddIncludesForType):
Drop special includes for XPathNSResolver as they are no longer needed.

(GenerateHeader):
Drop special casing of certain types for generating the toWrapped()
declaration by:

Relying on GetNativeType() for the return value as certain types return a RefPtr instead of a raw pointer.
Adding an extra ExecState parameter when a custom implementation of toWrapped() is provided, given that some of them need it.

(GenerateParametersCheck):
Drop custom code for XPathNSResolver and use the normal code path for
this type now. The custom code now resides in the custom implementation
of JSXPathNSResolver::toWrapped(), in custom bindings.

(JSValueToNative):

Drop NodeFilter from the nativeType hash map as it was updated to be a callback interface a while back.
Add XPathNSResolver to nativeType hash map so that we now to use a RefPtr<> instead of a raw pointer in the bindings. We should probably add an IDL extended attribute for this at some point.
Drop special casing for DOMStringList which was outdated since there is no toDOMStringList() function. DOMStringList has a custom toWrapped() function instead nowadays so we now call this one instead. We apparently do not have any DOMStringList parameters outside our bindings tests at the moment, which is why no one noticed.
Pass an ExecState to toWrapped() if the interface has the JSCustomToNativeObject IDL extended attribute.

bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
bindings/scripts/test/GObject/WebKitDOMTestObj.h:
bindings/scripts/test/JS/JSTestObj.cpp:
bindings/scripts/test/ObjC/DOMTestObj.h:
bindings/scripts/test/ObjC/DOMTestObj.mm:
bindings/scripts/test/TestObj.idl:

Add bindings test coverage for having an operation with an
XPathNSResolver parameter.

dom/Document.idl:
xml/XPathEvaluator.idl:

Drop some unnecessary default parameter values.

xml/XPathNSResolver.idl:

Add JSCustomToNativeObject IDL extended attribute so that we can
provide our own custom implementation of JSXPathNSResolver::toWrapped(),
instead of having the custom code in the bindings generator.

dom/Document.cpp:

(WebCore::Document::createExpression):
(WebCore::Document::evaluate):

dom/Document.h:
inspector/InspectorNodeFinder.cpp:
xml/XPathEvaluator.cpp:

(WebCore::XPathEvaluator::createExpression):
(WebCore::XPathEvaluator::evaluate):

xml/XPathEvaluator.h:
xml/XPathExpression.cpp:

(WebCore::XPathExpression::createExpression):

xml/XPathExpression.h:
xml/XPathParser.cpp:

(WebCore::XPath::Parser::Parser):
(WebCore::XPath::Parser::parseStatement):

xml/XPathParser.h:

Take XPathNSResolver parameter as a Ref<XPathNSResolver>&& as this is
what the generated bindings now provide us, given that this sometimes
have to create a wrapper around a JSObject.

3:29 PM Changeset in webkit [200549] by Darin Adler

2 edits in trunk/Source/WebCore

Fix crash introduced by the last patch.

Fix suggested by Chris Dumez.

css/FontFace.cpp:

(WebCore::FontFace::FontFace): Roll out incorrect change. Things were getting
initialized in the wrong order in a change I had made to the FontFace constructor
that takes a CSSFontSelector.

2:36 PM Changeset in webkit [200548] by Chris Dumez

2 edits in trunk/Source/WebCore

Unreviewed, rebaseline bindings tests after r200547.

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::convert<TestObj::FontFaceDescriptors>):

2:14 PM Changeset in webkit [200547] by Darin Adler

18 edits
1 move in trunk

Next step on dictionary bindings, along with other bindings refinements
https://bugs.webkit.org/show_bug.cgi?id=157451

Reviewed by Chris Dumez.

Source/WebCore:

Converted one dictionary, the one passed to the constructor in FontFace.

WebCore.xcodeproj/project.pbxproj: Updated for name change of JSDOMBuild.h to

JSDOMConvert.h and also let Xcode update a file type.

bindings/js/JSDOMBinding.cpp:

(WebCore::propertyValue): Added.

bindings/js/JSDOMBinding.h: Use pragma once. Remove unnecessary forward declaration.

Move all declarations to the top of the file, separating them from definitions. This
is a small step toward better overview of what's in this file and paves the way for
future simplifications and improvements we can make after we observe patterns.
Also removed a couple unused functions.

bindings/js/JSDOMConvert.h: Renamed from JSDOMBuild.h.

Renamed function templates from build to convert. Added convertOptional.

bindings/js/ReadableStreamController.cpp:

(WebCore::callFunction): Use auto and remove some unneeded namespacing.
(WebCore::ReadableStreamController::invoke): Ditto. Also remove use of helper function
getPropertyFromObject, since this was the only call site and it was not very helpful.
(WebCore::ReadableStreamController::isControlledReadableStreamLocked): Ditto.
(WebCore::createReadableStream): Ditto.
(WebCore::getReadableStreamReader): Ditto.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateEnumerationImplementationContent): Updated for name change from build to
convert and JSDOMBuild.h to JSDOMConvert.h.
(GenerateDictionaryImplementationContent): Ditto. Also added code to handle optional
and added explicit exception checking, using local variables. Not clear longer term
if the local variable approach is OK since this will unnecessarily change types like
const String& to String.
(GenerateParametersCheck): Removed local variable $optional and use $parameter->isOptional
directly consistently. This is slightly clearer because the old code used a mix of the
two, and also is a better pattern for when we refactor this into smaller functions.
Note that this function name is not good any more--this is a lot more then parameter checks.
(GetNativeType): Return appropriate name for dictionary types.
(JSValueToNative): Updated for name change from build to convert and JSDOMBuild.h to
JSDOMConvert.h.

bindings/scripts/test/JS/JSTestObj.cpp:
bindings/scripts/test/JS/JSTestTypedefs.cpp:

Regenerated results.

bindings/scripts/test/TestObj.idl: Added another dictionary test case, just a copy

of the current state of the one in FontFace.idl.

css/CSSFontFace.cpp:

(WebCore::CSSFontFace::setUnicodeRange): Update for simplified UnicodeRange struct.
(WebCore::CSSFontFace::setFeatureSettings): Fix to correctly handle being called
with "normal". Also fix so it doesn't call fontPropertyChanged if nothing changed.
Also got rid of return value, which had no real value: it was returning false for
some bad inputs, but others would just lead to assertions, and the real reason this
was OK is that this function is only passed known-valid values.

css/CSSFontFace.h: Used prama once. Tweaked formatting. Removed return value from

the setFeatureSettings function. Changed UnicodeRange to be struct with public data
members instead a struct with a constructor and getter functions.

css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule): Updated since setFeatureSettings no
longer has a boolean return value.

css/CSSSegmentedFontFace.cpp:

(WebCore::appendFontWithInvalidUnicodeRangeIfLoading): Updated for simplified
UnicodeRange struct.

css/FontFace.cpp:

(WebCore::valueFromDictionary): Deleted.
(WebCore::FontFace::create): Updated to take the descriptors as a struct instead of
a WebCore::Dictionary. Also made that argument optional as specified in the current
specification draft.
(WebCore::FontFace::setFeatureSettings): Updated since setFeatureSettings no longer
has a boolean return value.
(WebCore::FontFace::unicodeRange): Updated for simplified UnicodeRange struct.

css/FontFace.h: Used pragma once. Removed unneeded includes and forward declarations.

Derived privately from CSSFontFace::Client. Added a FontFace::Descriptors struct and
used it as an argument to the create function as described above.

css/FontFace.idl: Added FontFaceDescriptors and changed the argument to the

constructor to be an optional FontFaceDescriptors instead of a Dictionary.

Tools:

Scripts/do-webcore-rename: Use this to rename JSDOMBuild.h to JSDOMConvert.h.

Also skip test expectations in a directory that this was modifying unnecessarily.

1:04 PM Changeset in webkit [200546] by youenn.fablet@crf.canon.fr

15 edits in trunk/Source/WebCore

Rework FontFace promise attribute handling
https://bugs.webkit.org/show_bug.cgi?id=157310

Reviewed by Myles C. Maxfield.

Making promise attributes cached attributes, so that they are created only once.
They are created in the custom binding code and passed to DOM class as needed.

Removed usage of ExecState& from DOM iterators.

No change should be visible from user scripts.

Modules/fetch/FetchHeaders.cpp:

(WebCore::FetchHeaders::Iterator::next): Removing ExecState parameter.

Modules/fetch/FetchHeaders.h:
bindings/js/JSDOMIterator.h:

(WebCore::keyValueIteratorForEach):
(WebCore::JSDOMIterator<JSWrapper>::next): Ditto.

bindings/js/JSDOMPromise.cpp:

(WebCore::DeferredWrapper::promise): Removed deferred() and added access to promise directly.

bindings/js/JSDOMPromise.h:
bindings/js/JSFontFaceCustom.cpp:

(WebCore::JSFontFace::loaded): Using cached attribute to call FontFace::loaded only once.

bindings/js/JSFontFaceSetCustom.cpp:

(WebCore::JSFontFaceSet::ready): Using cached attribute to call FontFaceSet::ready only once.

css/CSSFontFace.cpp:

(WebCore::CSSFontFace::wrapper): Removing ExecState parameter.

css/CSSFontFace.h:
css/FontFace.cpp:

(WebCore::FontFace::create): Ditto.
(WebCore::FontFace::FontFace): Ditto.
(WebCore::FontFace::fontStateChanged): Updating promise handling.
(WebCore::FontFace::registerLoaded): Resolving/rejecting promise if backing CSSFontFace loading is ended.
(WebCore::FontFace::load): Calling backing load.

css/FontFace.h:
css/FontFaceSet.cpp:

(WebCore::FontFaceSet::Iterator::next): Removing ExecState parameter.
(WebCore::FontFaceSet::load): Removing ExecState and ExceptionCode parameter.
(WebCore::FontFaceSet::registerReady): Resolving promise if ready otherwise storing it for resolving it later.
(WebCore::FontFaceSet::completedLoading): Resolving promise if any is stored.
(WebCore::FontFaceSet::create): Deleted.

css/FontFaceSet.h:
css/FontFaceSet.idl:

1:02 PM Changeset in webkit [200545] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Fix an incorrect usage of OS(DARWIN) with PLATFORM(COCOA)
https://bugs.webkit.org/show_bug.cgi?id=157167

Patch by Jeremy Huddleston Sequoia <jeremyhu@apple.com> on 2016-05-07
Reviewed by Myles C. Maxfield.

platform/graphics/FontPlatformData.h:

(WebCore::FontPlatformData::hash):

9:51 AM Changeset in webkit [200544] by timothy@apple.com

7 edits
3 adds in trunk/PerformanceTests

Update Animometer design
https://bugs.webkit.org/show_bug.cgi?id=157449

Reviewed by Darin Adler.

Animometer/developer.html: Stop including runner/animometer.css.
Animometer/index.html: Udpated elements to fit new styles.

Animometer/resources/debug-runner/animometer.css:

Copy the old runner/animometer.css to here so the debug runner is unaffected.

Animometer/resources/runner/animometer.css:

New styles for the design. Drop flex box for broad browser support.

Animometer/resources/runner/animometer.js:

(ResultsTable.clear): Use textContent.
(window.sectionsManager.showSection): Add class to the body.
(window.sectionsManager.setSectionScore): Use textContent, not innerHTML.

Animometer/resources/runner/crystal.svg: Added.
Animometer/resources/runner/lines.svg: Added.
Animometer/resources/runner/logo.svg: Added.

Animometer/resources/runner/tests.js: Shorten test name and title case them.

9:20 AM Changeset in webkit [200543] by mark.lam@apple.com

6 edits
2 moves in trunk/Source/JavaScriptCore

Add JSC options bytecodeRangeToJITCompile and jitWhitelist.
https://bugs.webkit.org/show_bug.cgi?id=157428

Reviewed by Michael Saboff.

Added Options::bytecodeRangeToJITCompile and Options::jitWhitelist options.

Moved DFGFunctionWhitelist* to FunctionWhitelist* and made it generic so that it can be used for more than one whitelist instance. In this case, we now have two: the dfgWhitelist and the jitWhitelist.

Added "can compile" checks in LLInt::shouldJIT() to check Options::bytecodeRangeToJITCompile and Options::jitWhitelist.

CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
dfg/DFGDriver.cpp:

(JSC::DFG::getNumCompilations):
(JSC::DFG::ensureGlobalDFGWhitelist):
(JSC::DFG::compileImpl):

dfg/DFGFunctionWhitelist.cpp: Removed.
dfg/DFGFunctionWhitelist.h: Removed.

llint/LLIntSlowPaths.cpp:

(JSC::LLInt::ensureGlobalJITWhitelist):
(JSC::LLInt::shouldJIT):

runtime/Options.h:

tools/FunctionWhitelist.cpp: Copied from Source/JavaScriptCore/dfg/DFGFunctionWhitelist.cpp.

(JSC::FunctionWhitelist::FunctionWhitelist):
(JSC::FunctionWhitelist::contains):
(JSC::DFG::FunctionWhitelist::ensureGlobalWhitelist): Deleted.
(JSC::DFG::FunctionWhitelist::FunctionWhitelist): Deleted.
(JSC::DFG::FunctionWhitelist::parseFunctionNamesInFile): Deleted.
(JSC::DFG::FunctionWhitelist::contains): Deleted.

tools/FunctionWhitelist.h: Copied from Source/JavaScriptCore/dfg/DFGFunctionWhitelist.h.

6:03 AM Changeset in webkit [200542] by jdiggs@igalia.com

6 edits in trunk

REGRESSION(r196222): [AX][GTK] accessibility/gtk/caret-offsets.html failing
https://bugs.webkit.org/show_bug.cgi?id=153956

Reviewed by Chris Fleizach.

Source/WebCore:

The reason the test began failing is that it was checking the new caret offset
synchronously. For most of the test cases, this was not a problem. But when the
caret was moved out of a focused link, the focus change (and associated repainting)
delayed the caret-moved event long enough to cause the associated test case to fail.
The test now uses shouldBecomeEqualToString() instead of shouldBeEqualToString().

The test also had a supposedly-correct expectation which was wrong: When moving the
caret to a valid accessible offset, the caret-moved event should be for that offset.
This was not the case for the list item test case because emitTextSelectionChange()
was not adjusting the offset for the RenderListMarker, the text of which is exposed
as part of the ATK_ROLE_LIST_ITEM object. This bug was also fixed and the test case
updated accordingly.

No new tests are needed. The previously-failing test is now passing.

editing/atk/FrameSelectionAtk.cpp:

(WebCore::emitTextSelectionChange):

LayoutTests:

Change the test to run asynchronously and update the expectations.

accessibility/gtk/caret-offsets-expected.txt: Updated.
accessibility/gtk/caret-offsets.html: Updated.
platform/gtk/TestExpectations: Unskipped the previously-failing test.

1:19 AM Changeset in webkit [200541] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

[JSC][32bit] stress/tagged-templates-template-object.js fails in debug
https://bugs.webkit.org/show_bug.cgi?id=157436

Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-05-07
Reviewed by Filip Pizlo.

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):
The node OverridesHasInstance had a speculation after a jump.

May 6, 2016:

11:03 PM Changeset in webkit [200540] by Joseph Pecoraro

22 edits in trunk/Source

Rename HitTestRequest DisallowShadowContent to DisallowUserAgentShadowContent
https://bugs.webkit.org/show_bug.cgi?id=157447

Reviewed by Ryosuke Niwa.

Source/WebCore:

HitTesting is intended to reach nodes inside shadow content. This property
on the HitTestRequest is intended to avoid hit testing in UserAgent shadow
content. Rename the enum value, and cascading methods for clarity.

html/MediaElementSession.cpp:

(WebCore::isMainContent):

page/EventHandler.cpp:

(WebCore::EventHandler::eventMayStartDrag):
(WebCore::EventHandler::updateSelectionForMouseDrag):
(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::mouseMoved):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::EventHandler::handleMouseForceEvent):
(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::isInsideScrollbar):
(WebCore::EventHandler::sendContextMenuEvent):
(WebCore::EventHandler::sendContextMenuEventForKey):
(WebCore::EventHandler::hoverTimerFired):
(WebCore::EventHandler::dragSourceEndedAt):
(WebCore::EventHandler::handleDrag):
(WebCore::EventHandler::dispatchSyntheticTouchEventIfEnabled):

page/EventHandler.h:
page/FocusController.cpp:

(WebCore::updateFocusCandidateIfNeeded):

rendering/HitTestRequest.h:

(WebCore::HitTestRequest::HitTestRequest):
(WebCore::HitTestRequest::disallowsUserAgentShadowContent):
(WebCore::HitTestRequest::disallowsShadowContent): Deleted.

rendering/HitTestResult.cpp:

(WebCore::HitTestResult::setToNonUserAgentShadowAncestor):
(WebCore::HitTestResult::addNodeToRectBasedTestResult):
(WebCore::HitTestResult::setToNonShadowAncestor): Deleted.

rendering/HitTestResult.h:
rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::isReplacementObscured):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::hitTestClipContent):

testing/Internals.cpp:

(WebCore::Internals::nodesFromRect):

Source/WebKit/mac:

WebView/WebFrame.mm:

(-[WebFrame elementAtPoint:]):

WebView/WebHTMLView.mm:

(-[WebHTMLView elementAtPoint:allowShadowContent:]):

Source/WebKit/win:

WebView.cpp:

(WebView::gestureNotify):

Source/WebKit2:

WebProcess/WebPage/CoordinatedGraphics/WebPageCoordinatedGraphics.cpp:

(WebKit::WebPage::findZoomableAreaForPoint):

WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::hitTest):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::determinePrimarySnapshottedPlugIn):

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::rangeForWebSelectionAtPosition):
(WebKit::WebPage::rangeForBlockAtPoint):
(WebKit::WebPage::getPositionInformation):

10:52 PM Changeset in webkit [200539] by Joseph Pecoraro

6 edits in trunk/Source

Web Inspector: Inspect Element and Element Selection searching should work with Shadow DOM Nodes
https://bugs.webkit.org/show_bug.cgi?id=157446
<rdar://problem/24688447>

Reviewed by Ryosuke Niwa.

Source/WebCore:

inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::innerParentNode):
The Inspector backend was informing the frontend that all ShadowRoots
were floating and had no parent. Get the host element for ShadowRoots.

rendering/HitTestResult.cpp:

(WebCore::moveOutOfUserAgentShadowTree):
(WebCore::HitTestResult::setToNonShadowAncestor):
EventHandler::mouseMoved is calling setToNonShadowAncestor before
notifying Page::chrome / Inspector about the moused over element.
This should be the deepest non-user-agent-shadow node.

Source/WebInspectorUI:

UserInterface/Models/DOMNode.js:

(WebInspector.DOMNode):
Shadow DOM nodes did not have a parent, and so when attempting
to create DOM Tree elements up the chain, we were failing at
shadow boundaries. Create the parent relationship, the parent
already treats it as a child.

UserInterface/Views/DOMTreeOutline.js:

(WebInspector.DOMTreeOutline.prototype._revealAndSelectNode):
Whenever we try to reveal and select an element in a shadow tree
but the setting to show shadow DOM is disabled, walk up until
we are out of the shadow tree.

10:44 PM Changeset in webkit [200538] by Joseph Pecoraro

4 edits in trunk/Source

Web Inspector: Misc CommandLineAPI cleanup
https://bugs.webkit.org/show_bug.cgi?id=157450

Reviewed by Ryosuke Niwa.

Source/JavaScriptCore:

inspector/InjectedScriptSource.js:

(BasicCommandLineAPI):
Fix mistake in r200533, and modernize related code.

Source/WebCore:

inspector/CommandLineAPIModuleSource.js:

(bind):

9:25 PM Changeset in webkit [200537] by peavo@outlook.com

3 edits in trunk/LayoutTests

[Win] Skip failing INTL test.
https://bugs.webkit.org/show_bug.cgi?id=157418

Reviewed by Alex Christensen.

Temporarily skip string-localeCompare.js, because AppleWin currently does not have INTL enabled.

js/script-tests/string-localeCompare.js:
platform/win/TestExpectations:

8:51 PM Changeset in webkit [200536] by rniwa@webkit.org

1 edit
2 adds in trunk/LayoutTests

MouseEvent's offsetX and offsetY should be based on relative target
https://bugs.webkit.org/show_bug.cgi?id=157444
<rdar://problem/24396408>

Reviewed by Darin Adler.

Add a W3C style testharness.js test for adjusting offsetX and offsetY to the adjusted target
since our existing behavior matches the spec as well as Chrome's behavior:
http://w3c.github.io/webcomponents/spec/shadow/#event-dispatch

fast/shadow-dom/MouseEvent-prototype-offsetX-offsetY-expected.txt: Added.
fast/shadow-dom/MouseEvent-prototype-offsetX-offsetY.html: Added.

8:08 PM Changeset in webkit [200535] by commit-queue@webkit.org

5 edits
2 adds in trunk

Web Inspector: Improve console.count()
https://bugs.webkit.org/show_bug.cgi?id=157439
<rdar://problem/26152654>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-06
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

make console.count() increment an unnamed global counter.
make console.count(label) increment a counter with that label name.

inspector/agents/InspectorConsoleAgent.cpp:

(Inspector::InspectorConsoleAgent::count):

LayoutTests:

inspector/console/console-api-expected.txt:
inspector/console/console-count-expected.txt: Added.
inspector/console/console-count.html: Added.
inspector/console/console-time.html:

5:38 PM WebKitGTK/2.10.x edited by jdiggs@igalia.com

(diff)

5:25 PM WebKitGTK/2.12.x edited by jdiggs@igalia.com

(diff)

5:05 PM Changeset in webkit [200534] by Simon Fraser

43 edits
1 copy
2 moves
6 adds in trunk

Enable IOS_TEXT_AUTOSIZING on Mac and make it testable
https://bugs.webkit.org/show_bug.cgi?id=157432
rdar://problem/16406720

Reviewed by Dean Jackson.

Source/JavaScriptCore:

Enable IOS_TEXT_AUTOSIZING on Mac so it can be tested.

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Enable IOS_TEXT_AUTOSIZING on Mac so it can be tested.

Make the setTextAutosizingEnabled() Setting work, and plumb it through WK1 and WK2
preferences for WTR and DRT. Make textAutosizingWindowSizeOverride() work, for layout tests.
These two settings are shared with TEXT_AUTOSIZING.

Add a TextAutosizing log channel, which is useful for generated -expected.html results.

Move adjustComputedFontSizesOnBlocks() and related code from RenderObject to RenderElement
without changes.

An implication of this set of changes is that the way clients enable text autosizing
has changed. Previously, they set the "MinimumZoomFontSize" preference to 0.
Settings::defaultMinimumZoomFontSize() used to do this in order to enable text autosizing
on iPhone only, not iPad.

Now the preferred technique is to leave minimumZoomFontSize alone, and to use textAutosizingEnabled()
instead. Settings::defaultTextAutosizingEnabled() now does the check for iPhone.

UIWebView calls WebKitGetMinimumZoomFontSize() to setup the default minimum font zoom size,
which will now always return 15, but had no other code that toggled this. So it's safe to just rely
on Settings::defaultTextAutosizingEnabled() doing the right thing for iPhone/iPad.

Test: fast/text-autosizing/ios/autosize-width.html

Configurations/FeatureDefines.xcconfig:
dom/Document.cpp:

(WebCore::Document::addAutoSizingNode):

page/FrameView.cpp:

(WebCore::FrameView::layout):

page/Settings.cpp:

(WebCore::Settings::Settings): Deleted.
(WebCore::Settings::setTextAutosizingEnabled): Deleted.
(WebCore::Settings::setTextAutosizingWindowSizeOverride): Deleted.

page/Settings.h:

(WebCore::Settings::textAutosizingEnabled): Deleted.
(WebCore::Settings::textAutosizingWindowSizeOverride): Deleted.

page/Settings.in:
page/cocoa/SettingsCocoa.mm:

(WebCore::Settings::defaultMinimumZoomFontSize):
(WebCore::Settings::defaultTextAutosizingEnabled):

platform/Logging.h:
rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::adjustComputedFontSizes):

rendering/RenderElement.cpp:

(WebCore::includeNonFixedHeight):
(WebCore::RenderElement::adjustComputedFontSizesOnBlocks):
(WebCore::RenderElement::resetTextAutosizing):

rendering/RenderElement.h:
rendering/RenderObject.cpp:

(WebCore::includeNonFixedHeight): Deleted.
(WebCore::RenderObject::adjustComputedFontSizesOnBlocks): Deleted.
(WebCore::RenderObject::resetTextAutosizing): Deleted.

rendering/RenderObject.h:
rendering/TextAutoSizing.cpp:

(WebCore::TextAutoSizingValue::adjustNodeSizes):

testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setTextAutosizingEnabled):
(WebCore::InternalSettings::setTextAutosizingWindowSizeOverride):

testing/InternalSettings.h:

Source/WebKit/ios:

Enable IOS_TEXT_AUTOSIZING on Mac so it can be tested.

Add a TextAutosizing log channel, which is useful for generated -expected.html results.

Move adjustComputedFontSizesOnBlocks() and related code from RenderObject to RenderElement
without changes.

Now the preferred technique is to leave minimumZoomFontSize alone, and to use textAutosizingEnabled()
instead. Settings::defaultTextAutosizingEnabled() now does the check for iPhone.

Misc/WebUIKitSupport.mm:

(WebKitGetMinimumZoomFontSize):

Source/WebKit/mac:

Enable IOS_TEXT_AUTOSIZING on Mac so it can be tested.

Add a TextAutosizing log channel, which is useful for generated -expected.html results.

Move adjustComputedFontSizesOnBlocks() and related code from RenderObject to RenderElement
without changes.

Now the preferred technique is to leave minimumZoomFontSize alone, and to use textAutosizingEnabled()
instead. Settings::defaultTextAutosizingEnabled() now does the check for iPhone.

Configurations/FeatureDefines.xcconfig:
WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences _setTextAutosizingEnabled:]):
(-[WebPreferences _textAutosizingEnabled]):

WebView/WebPreferencesPrivate.h:

Source/WebKit2:

Enable IOS_TEXT_AUTOSIZING on Mac so it can be tested.

Add a TextAutosizing log channel, which is useful for generated -expected.html results.

Move adjustComputedFontSizesOnBlocks() and related code from RenderObject to RenderElement
without changes.

Now the preferred technique is to leave minimumZoomFontSize alone, and to use textAutosizingEnabled()
instead. Settings::defaultTextAutosizingEnabled() now does the check for iPhone.

Configurations/FeatureDefines.xcconfig:
Shared/WebPreferencesDefinitions.h:
UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _textAutosizingEnabled]):
(-[WKPreferences _setTextAutosizingEnabled:]):

UIProcess/API/Cocoa/WKPreferencesPrivate.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

Enable IOS_TEXT_AUTOSIZING on Mac so it can be tested.

Add a TextAutosizing log channel, which is useful for generated -expected.html results.

Move adjustComputedFontSizesOnBlocks() and related code from RenderObject to RenderElement
without changes.

Now the preferred technique is to leave minimumZoomFontSize alone, and to use textAutosizingEnabled()
instead. Settings::defaultTextAutosizingEnabled() now does the check for iPhone.

DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::setTextAutosizingEnabled):

TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::platformResetPreferencesToConsistentValues):

LayoutTests:

Enable fast/text-autosizing/ios/ on Mac and iOS

fast/text-autosizing/ios/autosize-width-expected.html: Added.
fast/text-autosizing/ios/autosize-width.html: Added.
platform/ios-simulator/TestExpectations:
platform/mac-wk2/TestExpectations:
platform/mac/TestExpectations:

4:32 PM Changeset in webkit [200533] by commit-queue@webkit.org

19 edits
2 adds in trunk

Web Inspector: Console: Variables defined with let/const aren't accessible outside of console's scope
https://bugs.webkit.org/show_bug.cgi?id=150752
<rdar://problem/23343385>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-06
Reviewed by Mark Lam.

Source/JavaScriptCore:

This approach allows Web Inspector to hang a "Scope Extension", a
WithObjectScope, off the GlobalObject. When resolving identifiers
in fails to resolve anything in the normal scope chain, consult
the scope extension.

This allows us to eliminate the with (commandLineAPI) { ... }
block in global console evaluations, and instead makes it a full
program evaluation, with the commandLineAPI available and safely
shadowed by actual variables as expected.

inspector/InjectedScriptSource.js:

(InjectedScript.prototype._evaluateOn):
Use the new evaluateWithScopeExtension and provide the CommandLineAPI
object as the scope extension object.

(BasicCommandLineAPI):
(BasicCommandLineAPI.inScopeVariables): Deleted.
Simplify now that we don't need to check for variable shadowing ourselves.

inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::evaluateWithScopeExtension):

inspector/JSInjectedScriptHost.h:
inspector/JSInjectedScriptHostPrototype.cpp:

(Inspector::JSInjectedScriptHostPrototype::finishCreation):
(Inspector::jsInjectedScriptHostPrototypeFunctionEvaluateWithScopeExtension):
Provide a new InjectedScriptHost method to evaluate a program
with a scope extension.

runtime/Completion.cpp:

(JSC::evaluateWithScopeExtension):

runtime/Completion.h:

General JSC::evaluate function to evaluate a program with a scope extension.

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::setGlobalScopeExtension):
(JSC::JSGlobalObject::clearGlobalScopeExtension):
(JSC::JSGlobalObject::visitChildren):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::globalScopeExtension):
Hang a scope extension off the global object.

runtime/JSScope.cpp:

(JSC::JSScope::resolve):
Consult the scope extension when resolve fails to find anything normally.

Source/WebCore:

Test: inspector/runtime/evaluate-CommandLineAPI.html

inspector/CommandLineAPIModuleSource.js:

(bind):
(this.member.toString):
(CommandLineAPI):
(CommandLineAPIImpl.prototype):
(slice): Deleted.
(bound): Deleted.
(bound.toString): Deleted.
(inScopeVariables): Deleted.
(customToStringMethod): Deleted.
Simplify now that we don't need to do our own variable shadow checking.

LayoutTests:

inspector/runtime/evaluate-CommandLineAPI-expected.txt: Added.
inspector/runtime/evaluate-CommandLineAPI.html: Added.

New test covering the different cases of global evaluation with the
CommandLineAPI as a scope extension.

http/tests/inspector/console/cross-domain-inspected-node-access-expected.txt:
inspector/console/command-line-api-expected.txt:
inspector/debugger/js-stacktrace-expected.txt:
inspector/debugger/js-stacktrace.html:
inspector/model/stack-trace-expected.txt:
platform/mac/inspector/model/remote-object-expected.txt:

Update expectations now that global evaluations are treated as
program's [global code] and not evals [eval code]. Also some
line number changes.

4:21 PM Changeset in webkit [200532] by beidson@apple.com

3 edits in trunk/LayoutTests

Unreviewed IDB test gardening.

TestExpectations:
storage/indexeddb/pending-activity-workers-expected.txt: Updated expectations.

3:57 PM Changeset in webkit [200531] by mark.lam@apple.com

7 edits in trunk/Source/JavaScriptCore

Add JSC options reportBaselineCompileTimes and reportDFGCompileTimes.
https://bugs.webkit.org/show_bug.cgi?id=157427

Reviewed by Filip Pizlo and Keith Miller.

The compile times reporting options are now:

reportCompileTimes -> report compile times in all tiers.
reportBaselineCompileTimes -> report compile times in baseline JIT.
reportDFGCompileTimes -> report compile times in DFG and FTL.
reportFTLCompileTimes -> report compile times in FTL.

Also updated reportTotalCompileTimes() to collect stats that include the baseline
JIT. compileTimeStats() is now moved into JIT.cpp (from DFGPlan.cpp).

dfg/DFGPlan.cpp:

(JSC::DFG::Plan::reportCompileTimes):
(JSC::DFG::Plan::compileInThread):
(JSC::DFG::Plan::compileInThreadImpl):
(JSC::DFG::Plan::cancel):
(JSC::DFG::Plan::compileTimeStats): Deleted.

dfg/DFGPlan.h:

(JSC::DFG::Plan::compileTimeStats): Deleted.

jit/JIT.cpp:

(JSC::ctiPatchCallByReturnAddress):
(JSC::JIT::privateCompile):
(JSC::JIT::stackPointerOffsetFor):
(JSC::JIT::reportCompileTimes):
(JSC::JIT::computeCompileTimes):
(JSC::JIT::compileTimeStats):

jit/JIT.h:

(JSC::JIT::shouldEmitProfiling):

jsc.cpp:

(runJSC):

runtime/Options.h:

3:47 PM Changeset in webkit [200530] by timothy_horton@apple.com

8 edits
2 adds in trunk

<attachment> element should understand UTIs
https://bugs.webkit.org/show_bug.cgi?id=157425
<rdar://problem/25585401>

Reviewed by Anders Carlsson.

UTIs are often much more specific than MIME types, so we should allow
clients of <attachment> to use them to get more accurate icons.

Test: fast/attachment/attachment-uti.html

platform/graphics/Icon.h:
platform/graphics/mac/IconMac.mm:

(WebCore::Icon::createIconForMIMEType): Deleted.
Remove the now-unused createIconForMIMEType.

platform/network/mac/UTIUtilities.h:
platform/network/mac/UTIUtilities.mm:

(WebCore::isDeclaredUTI):
Expose UTTypeIsDeclared as isDeclaredUTI.

rendering/RenderThemeIOS.mm:

(WebCore::iconForAttachment):

rendering/RenderThemeMac.mm:

(WebCore::iconForAttachment):
If the attachment's type is a UTI, request the icon for it directly.
If it's a MIME type, convert to a UTI before requesting.

fast/attachment/attachment-uti-expected.html: Added.
fast/attachment/attachment-uti.html: Added.

Add a test that UTIs render the same as their corresponding MIME types.

3:39 PM Changeset in webkit [200529] by Nikita Vasilyev

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Unexpected white border at the bottom of Debugger filter bar
https://bugs.webkit.org/show_bug.cgi?id=157430
<rdar://problem/26146602>

Reviewed by Timothy Hatcher.

Remove the semi-transparent white borders.

UserInterface/Views/NavigationBar.css:

(.navigation-bar): Deleted.

UserInterface/Views/SearchSidebarPanel.css:

(.sidebar > .panel.navigation.search > .search-bar): Deleted.

3:23 PM Changeset in webkit [200528] by Chris Dumez

19 edits in trunk

Clean up converting from JSValue to float / double in the bindings generator
https://bugs.webkit.org/show_bug.cgi?id=157407

Reviewed by Darin Adler.

Source/WebCore:

Clean up converting from JSValue to float / double in the bindings generator:

Handle all aspects of converting to float / double inside JSValueToNative() instead of relying partly on the call sites.
Add a build<>() template function to JSDOMBuild.h that is now called from the bindings to convert to float / double and deal with non-finite values.
Provide a better message with the TypeError that is thrown for non-finite values.

No new tests, rebaselined existing tests.

bindings/js/JSDOMBinding.cpp:

(WebCore::throwSequenceTypeError):
(WebCore::throwNonFiniteTypeError):

bindings/js/JSDOMBinding.h:
bindings/js/JSDOMBuild.h:

(WebCore::build):

bindings/scripts/CodeGenerator.pm:

(IsFloatingPointType):

bindings/scripts/CodeGeneratorJS.pm:

(JSValueToNative):
(GenerateImplementation): Deleted.
(GenerateParametersCheck): Deleted.
(GenerateReturnParameters): Deleted.

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjStrictFloat):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalDoubleIsNaN):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalFloatIsNaN):
(WebCore::jsTestObjPrototypeFunctionStrictFunction):
(WebCore::jsTestObjPrototypeFunctionVariadicDoubleMethod):
(WebCore::jsTestObjPrototypeFunctionAny):
(WebCore::jsTestObjPrototypeFunctionTestPromiseFunctionWithFloatArgumentPromise):
(WebCore::jsTestObjPrototypeFunctionTestPromiseOverloadedFunction1Promise):

bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::jsTestTypedefsPrototypeFunctionSetShadow):

LayoutTests:

Rebaseline the tests now that we provide a more useful exception message.

fast/canvas/canvas-2d-imageData-create-nonfinite-expected.txt:
fast/canvas/canvas-getImageData-invalid-expected.txt:
fast/canvas/canvas-putImageData-expected.txt:
fast/canvas/canvas-putImageData.js:
fast/canvas/linearGradient-infinite-values-expected.txt:
fast/canvas/radialGradient-infinite-values-expected.txt:
fast/canvas/resources/canvas-2d-imageData-create-nonfinite.js:
fast/canvas/script-tests/canvas-getImageData-invalid.js:
fast/canvas/script-tests/linearGradient-infinite-values.js:
fast/canvas/script-tests/radialGradient-infinite-values.js:

3:06 PM Changeset in webkit [200527] by beidson@apple.com

4 edits in trunk/LayoutTests

Unreviewed IDB test gardening.

Fix a failing test, and add better classification/comments to a different failing test.

TestExpectations:
storage/indexeddb/dont-commit-on-blocked-expected.txt:
storage/indexeddb/dont-commit-on-blocked.html:

2:38 PM Changeset in webkit [200526] by beidson@apple.com

3 edits in trunk/LayoutTests

Unreviewed IDB test gardening.

Update the workers variant of "deletedatabase-delayed-by-open-and-versionchange" to the modern expected results.

TestExpectations:
storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-workers-expected.txt:

2:22 PM Changeset in webkit [200525] by beidson@apple.com

2 edits in trunk/LayoutTests

Unreviewed IDB test gardening.

Finish removing unsupported lines from the "unprefix" test.

storage/indexeddb/unprefix-private-expected.txt:

2:21 PM Changeset in webkit [200524] by dino@apple.com

31 edits
4 deletes in trunk

Regions, Shapes and Tracks don't need runtime features
https://bugs.webkit.org/show_bug.cgi?id=157426
<rdar://problem/26146262>

Reviewed by Simon Fraser.

Source/WebCore:

The following RuntimeEnabledFeatures can be removed since
we have no need to disable them (they are stable and have
shipped for a while):

CSS Regions
CSS Shapes
Media tracks

bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures): Deleted.

bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setCSSShapesEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::cssShapesEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setCSSRegionsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::cssRegionsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setCSSCompositingEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::cssCompositingEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webkitVideoTrackEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setWebkitVideoTrackEnabled): Deleted.

css/CSSParser.cpp:

(WebCore::isSimpleLengthPropertyID):
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::createRegionRule):
(WebCore::CSSParserContext::CSSParserContext): Deleted.
(WebCore::operator==): Deleted.
(WebCore::CSSParser::parseShapeProperty): Deleted.
(WebCore::CSSParser::cssRegionsEnabled): Deleted.
(WebCore::CSSParser::cssCompositingEnabled): Deleted.
(WebCore::CSSParser::parseFlowThread): Deleted.
(WebCore::CSSParser::parseRegionThread): Deleted.

css/CSSParser.h:
css/CSSParserMode.h:
dom/Document.cpp:

(WebCore::Document::webkitGetNamedFlows):
(WebCore::Document::cssRegionsEnabled): Deleted.
(WebCore::Document::cssCompositingEnabled): Deleted.

dom/Document.h:
dom/Element.cpp:

(WebCore::Element::unregisterNamedFlowContentElement):
(WebCore::Element::webkitRegionOverset):
(WebCore::Element::webkitGetRegionFlowRanges): Deleted.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::scheduleDelayedAction):
(WebCore::HTMLMediaElement::pendingActionTimerFired):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::loadInternal):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::playbackProgressTimerFired):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::userCancelledLoad):
(WebCore::HTMLMediaElement::setVideoFullscreenLayer):
(WebCore::HTMLMediaElement::hasClosedCaptions):
(WebCore::HTMLMediaElement::setClosedCaptionsVisible):
(WebCore::HTMLMediaElement::configureTextTrackDisplay):
(WebCore::HTMLMediaElement::finishParsingChildren): Deleted.
(WebCore::HTMLMediaElement::audioTrackEnabledChanged): Deleted.
(WebCore::HTMLMediaElement::videoTrackSelectedChanged): Deleted.
(WebCore::HTMLMediaElement::mediaPlayerDidAddAudioTrack): Deleted.
(WebCore::HTMLMediaElement::mediaPlayerDidAddTextTrack): Deleted.
(WebCore::HTMLMediaElement::mediaPlayerDidAddVideoTrack): Deleted.
(WebCore::HTMLMediaElement::addAudioTrack): Deleted.
(WebCore::HTMLMediaElement::addTextTrack): Deleted.
(WebCore::HTMLMediaElement::addVideoTrack): Deleted.
(WebCore::HTMLMediaElement::removeAudioTrack): Deleted.
(WebCore::HTMLMediaElement::removeTextTrack): Deleted.
(WebCore::HTMLMediaElement::removeVideoTrack): Deleted.
(WebCore::HTMLMediaElement::audioTracks): Deleted.
(WebCore::HTMLMediaElement::textTracks): Deleted.
(WebCore::HTMLMediaElement::videoTracks): Deleted.
(WebCore::HTMLMediaElement::didAddTextTrack): Deleted.
(WebCore::HTMLMediaElement::didRemoveTextTrack): Deleted.

html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::parseAttribute):
(WebCore::HTMLTrackElement::scheduleLoad): Deleted.
(WebCore::HTMLTrackElement::canLoadURL): Deleted.

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::createRenderNamedFlowFragmentIfNeeded):

testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo): Deleted.
(WebCore::InternalSettings::setCSSShapesEnabled): Deleted.

testing/InternalSettings.h:
testing/InternalSettings.idl:

Source/WebKit/mac:

The following RuntimeEnabledFeatures can be removed since
we have no need to disable them (they are stable and have
shipped for a while):

CSS Regions
CSS Shapes
Media tracks

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]): Deleted.
(-[WebPreferences cssRegionsEnabled]): Deleted.
(-[WebPreferences setCSSRegionsEnabled:]): Deleted.
(-[WebPreferences cssCompositingEnabled]): Deleted.
(-[WebPreferences setCSSCompositingEnabled:]): Deleted.

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]): Deleted.

Source/WebKit2:

The following RuntimeEnabledFeatures can be removed since
we have no need to disable them (they are stable and have
shipped for a while):

CSS Regions
CSS Shapes
Media tracks

Shared/WebPreferencesDefinitions.h:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetCSSRegionsEnabled): Deleted.
(WKPreferencesGetCSSRegionsEnabled): Deleted.

UIProcess/API/C/WKPreferencesRefPrivate.h:
WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): Deleted.
(WebKit::InjectedBundle::setCSSRegionsEnabled): Deleted.
(WebKit::InjectedBundle::setCSSCompositingEnabled): Deleted.

WebProcess/InjectedBundle/InjectedBundle.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Deleted.

Tools:

The following RuntimeEnabledFeatures can be removed since
we have no need to disable them (they are stable and have
shipped for a while):

CSS Regions
CSS Shapes
Media tracks

DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues): Deleted.

LayoutTests:

Remove these tests since their runtime flags no longer exist.

fast/regions/css-regions-disabled-expected.txt: Removed.
fast/regions/css-regions-disabled.html: Removed.
fast/shapes/css-shapes-disabled-expected.txt: Removed.
fast/shapes/css-shapes-disabled.html: Removed.

2:16 PM Changeset in webkit [200523] by beidson@apple.com

5 edits in trunk/LayoutTests

Unreviewed IDB test gardening.

Remove unsupported lines from the "unprefix" test.

TestExpectations:
storage/indexeddb/resources/unprefix.js:
storage/indexeddb/unprefix-expected.txt:
storage/indexeddb/unprefix-workers-expected.txt:

2:11 PM Changeset in webkit [200522] by beidson@apple.com

2 edits
2 deletes in trunk/LayoutTests

Unreviewed IDB test gardening.

Remove the Workers variant of a test that had been removed for being irrelevant.

TestExpectations:
storage/indexeddb/factory-basics-workers-expected.txt: Removed.
storage/indexeddb/factory-basics-workers.html: Removed.

2:04 PM Changeset in webkit [200521] by beidson@apple.com

43 edits in trunk

Modern IDB (Workers): Start running a lot of the workers tests.
https://bugs.webkit.org/show_bug.cgi?id=157424

Reviewed by Sam Weinig.

Source/WebCore:

No new tests (Covered by enabling a whole bunch of existing tests).

Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::stop): Call removeAllEventListeners() to clean up the Worker VM

before it shuts down.

Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::stop): Call removeAllEventListeners()

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::IDBTransaction): Initialize with the correct VM.
(WebCore::IDBTransaction::stop): Call removeAllEventListeners()
(WebCore::IDBTransaction::operationDidComplete):

Modules/indexeddb/client/IDBConnectionProxy.cpp:

(WebCore::IDBClient::IDBConnectionProxy::takeIDBOpenDBRequest):
(WebCore::IDBClient::IDBConnectionProxy::completeOpenDBRequest): Don't take the request from

the map, but rather let the request take itself from its appropriate thread.

Modules/indexeddb/client/IDBConnectionProxy.h:

Modules/indexeddb/client/TransactionOperation.h:

(WebCore::IDBClient::TransactionOperation::completed): Rework clearing out the completion

handler, as the handler itself might hold the last reference to this.

page/SecurityOrigin.h:

(WebCore::SecurityOrigin::hasUniversalAccess):

workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::WorkerGlobalScope): If the parent context's SecurityOrigin had

universal access, grant it to this one.

LayoutTests:

Many tests that obviously pass need updated expectations for the details of error messages.

Others just work right out of the box.

TestExpectations: Enable some tests, and categorize remaining failures.

http/tests/security/cross-origin-worker-indexeddb-allowed-expected.txt:
http/tests/security/cross-origin-worker-indexeddb-allowed.html:
http/tests/security/cross-origin-worker-indexeddb-expected.txt:
http/tests/security/cross-origin-worker-indexeddb.html:
http/tests/security/resources/cross-origin-iframe-for-worker-indexeddb.html:
http/tests/security/resources/document-for-cross-origin-worker-indexeddb.html:
http/tests/security/resources/worker-for-indexeddb.js:
storage/indexeddb/basics-workers.html:
storage/indexeddb/cursor-advance-workers-expected.txt:
storage/indexeddb/cursor-advance-workers.html:
storage/indexeddb/deletedatabase-delayed-by-open-and-versionchange-workers.html:
storage/indexeddb/dont-commit-on-blocked-private.html:
storage/indexeddb/dont-commit-on-blocked.html:
storage/indexeddb/factory-basics-workers.html:
storage/indexeddb/index-basics-workers-expected.txt:
storage/indexeddb/index-basics-workers.html:
storage/indexeddb/modern/workers-disabled.html:
storage/indexeddb/objectstore-basics-workers-expected.txt:
storage/indexeddb/objectstore-basics-workers.html:
storage/indexeddb/open-twice-workers.html:
storage/indexeddb/pending-activity-workers.html:
storage/indexeddb/pending-version-change-on-exit-private.html:
storage/indexeddb/pending-version-change-on-exit.html:
storage/indexeddb/pending-version-change-stuck-private.html:
storage/indexeddb/pending-version-change-stuck-works-with-terminate-private.html:
storage/indexeddb/pending-version-change-stuck-works-with-terminate.html:
storage/indexeddb/pending-version-change-stuck.html:
storage/indexeddb/transaction-complete-workers-expected.txt:
storage/indexeddb/transaction-complete-workers-private-expected.txt:
storage/indexeddb/transaction-complete-workers-private.html:
storage/indexeddb/transaction-complete-workers.html:
storage/indexeddb/unprefix-workers.html:

2:01 PM Changeset in webkit [200520] by rniwa@webkit.org

4 edits
2 adds in trunk

FKA: No way to get focus from DOM to shadow DOM components (Was: HTML5 media controls not keyboard accessible)
https://bugs.webkit.org/show_bug.cgi?id=117857

Reviewed by Jer Noble.

Source/WebCore:

The bug was caused by hasCustomFocusLogic returning true on media elements.

Fix the bug by removing this function so that FocusController will walk into the shadow tree of media elements
to look for focusable elements. This will allow AT such as Voice Over to iterate through controls.

We don't seem to draw focus rings inside the media elements but that could be tweaked in a separate patch.

Test: media/tab-focus-inside-media-elements.html

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::hasCustomFocusLogic): Deleted.

html/HTMLMediaElement.h:

LayoutTests:

Added a regression test for moving focus into media elements by pressing tab key.

media/tab-focus-inside-media-elements-expected.txt: Added.
media/tab-focus-inside-media-elements.html: Added.

1:38 PM Changeset in webkit [200519] by andersca@apple.com

10 edits
1 delete in trunk/Source/WebCore

Tidy up the LinkRelAttribute code
https://bugs.webkit.org/show_bug.cgi?id=157429

Reviewed by Sam Weinig.

Get rid of IconURL.h and move the IconType enumeration inside LinkRelAttribute.
Remove the InvalidIcon enum declaration and use WTF::Optional instead.

WebCore.xcodeproj/project.pbxproj:
dom/IconURL.h: Removed.
html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::iconType):
(WebCore::HTMLLinkElement::addSubresourceAttributeURLs):

html/HTMLLinkElement.h:
html/LinkRelAttribute.cpp:

(WebCore::LinkRelAttribute::LinkRelAttribute):

html/LinkRelAttribute.h:
html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::relAttributeIsStyleSheet):

loader/FrameLoader.h:
loader/FrameLoaderClient.h:
loader/icon/IconController.cpp:

(WebCore::iconFromLinkElements):

1:37 PM Changeset in webkit [200518] by fpizlo@apple.com

1 edit
2 adds in trunk/LayoutTests

JS Function removed after parsing
https://bugs.webkit.org/show_bug.cgi?id=149175

Reviewed by Mark Lam.

This bug doesn't happen anymore, but the test case is still useful. This test will fail 1/5 of
the time if we regress.

js/dom/function-removed-after-parsing-expected.txt: Added.
js/dom/function-removed-after-parsing.html: Added.

12:54 PM Changeset in webkit [200517] by commit-queue@webkit.org

5 edits
2 deletes in trunk/Source/WebInspectorUI

Web Inspector: Remove HeapSnapshot Summary View
https://bugs.webkit.org/show_bug.cgi?id=157385

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-06
Reviewed by Timothy Hatcher.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Main.html:
UserInterface/Views/HeapSnapshotClusterContentView.js:

(WebInspector.HeapSnapshotClusterContentView):
(WebInspector.HeapSnapshotClusterContentView.prototype.get summaryContentView): Deleted.
(WebInspector.HeapSnapshotClusterContentView.prototype.showSummary): Deleted.
(WebInspector.HeapSnapshotClusterContentView.prototype._pathComponentForContentView):
(WebInspector.HeapSnapshotClusterContentView.prototype._identifierForContentView):
(WebInspector.HeapSnapshotClusterContentView.prototype._showContentViewForIdentifier):

UserInterface/Views/HeapSnapshotSummaryContentView.css: Removed.
UserInterface/Views/HeapSnapshotSummaryContentView.js: Removed.
UserInterface/Views/Variables.css:

(:root):

12:54 PM Changeset in webkit [200516] by jer.noble@apple.com

4 edits
2 adds in trunk

Muted media elements should be allowed to autoplay, even if RequireUserGestureForAudioRateChange is set.
https://bugs.webkit.org/show_bug.cgi?id=157404
<rdar://problem/26016802>

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/audio-playback-restriction-play-muted.html

Add element.muted() as a critera of whether playback is permitted when
RequireUserGestureForAudioRateChange is set. Also, make sure to re-evaluate whether the
element should be playing when muted is changed without a user gesture.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setMuted):

html/MediaElementSession.cpp:

(WebCore::MediaElementSession::playbackPermitted):

LayoutTests:

media/audio-playback-restriction-play-muted-expected.txt: Added.
media/audio-playback-restriction-play-muted.html: Added.

12:25 PM Changeset in webkit [200515] by Ryan Haddad

2 edits in trunk/Tools

Increase delay when launching multiple ios-simulators in parallel
https://bugs.webkit.org/show_bug.cgi?id=157422

Reviewed by Alexey Proskuryakov.

Tests are intermittently failing when launching multiple simulators in parallel due to "You are opening
this application for the first time" confirmation dialogs. Increasing the delay to alleviate this issue.

Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort.setup_test_run):

11:17 AM Changeset in webkit [200514] by adachan@apple.com

6 edits in trunk/Source/WebKit2

Create a fence in WebVideoFullscreenManagerProxy::setVideoLayerFrame() to pass to the web process
https://bugs.webkit.org/show_bug.cgi?id=157409

Reviewed by Tim Horton.

UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm:

(WebKit::WebVideoFullscreenManagerProxy::setVideoLayerFrame):
Create a fence by calling DrawingAreaProxy::createFence() and pass it when sending the
WebVideoFullscreenManager::SetVideoLayerFrameFenced message.

UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::createFence):
Stub implementation. Assert not to be reached here since it's only implemented on Mac so far.

UIProcess/DrawingAreaProxy.h:

UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::createFence):
Renamed from createFenceForGeometryUpdate() since we are using it for more than just updating geometry.
(WebKit::TiledCoreAnimationDrawingAreaProxy::sendUpdateGeometry):
Update due to method rename.

9:57 AM Changeset in webkit [200513] by dbates@webkit.org

2 edits in trunk/Source/WebKit/mac

Remove workaround for Apple Internal bots
<rdar://problem/25989808>

Reverts the workaround added in r200211 as it is no longer needed.

WebView/WebPDFView.h:

9:18 AM Changeset in webkit [200512] by peavo@outlook.com

2 edits in trunk/Tools

[Win] Remove WinXP support.
https://bugs.webkit.org/show_bug.cgi?id=157416

Reviewed by Brent Fulgham.

win/DLLLauncher/DLLLauncherMain.cpp:

(enableTerminationOnHeapCorruption):

8:53 AM Changeset in webkit [200511] by Brent Fulgham

4 edits in trunk/Source/WebCore

Don't use invalidated ResourceLoadStatistics iterators
https://bugs.webkit.org/show_bug.cgi?id=157412
<rdar://problem/26133153>

Reviewed by Chris Dumez.

ResourceLoadObserver::logFrameNavigation was using references bound to the 'value'
member of iterators from the ResourceLoadStatistics HashMap. When new entries were
added, these iterators were invalidated causing the references to refer to invalid
memory.

Renamed 'resourceStatisticsForPrimaryDomain' to 'ensureResourceStatisticsForPrimaryDomain'
to clarify that it may mutate the underlying HashMap, thereby invalidating any
existing iterators.

loader/ResourceLoadObserver.cpp:

(WebCore::ResourceLoadObserver::logFrameNavigation): Protect against HashMap
elements being copied/moved when new intries are added.

loader/ResourceLoadStatisticsStore.cpp:

(WebCore::ResourceLoadStatisticsStore::setResourceStatisticsForPrimaryDomain): Added.

loader/ResourceLoadStatisticsStore.h:

1:17 AM Changeset in webkit [200510] by Manuel Rego Casasnovas

329 edits in trunk

[css-grid] Unprefix CSS Grid Layout properties
https://bugs.webkit.org/show_bug.cgi?id=157137

Reviewed by Simon Fraser.

Remove "-webkit" prefix from all the grid layout properties,
including the display value.
Update the source code to remove the prefix where it was used too.

ManualTests/css-grid-layout-item-with-huge-span-crash.html:

PerformanceTests:

Layout/auto-grid-lots-of-data.html:
Layout/fixed-grid-lots-of-data.html:
Layout/fixed-grid-lots-of-stretched-data.html:

Source/WebCore:

css/CSSComputedStyleDeclaration.cpp:

(WebCore::isLayoutDependent):
(WebCore::ComputedStyleExtractor::propertyValue):

css/CSSParser.cpp:

(WebCore::isSimpleLengthPropertyID):
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridGapShorthand):
(WebCore::CSSParser::parseGridTemplateRowsAndAreasAndColumns):
(WebCore::CSSParser::parseGridTemplateShorthand):
(WebCore::CSSParser::parseGridShorthand):
(WebCore::CSSParser::parseGridAreaShorthand):

css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

css/CSSPropertyNames.in:
css/CSSValueKeywords.in:
css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyInitialGridTemplateAreas):
(WebCore::StyleBuilderCustom::applyInheritGridTemplateAreas):
(WebCore::StyleBuilderCustom::applyValueGridTemplateAreas):
(WebCore::StyleBuilderCustom::applyInitialGridTemplateColumns):
(WebCore::StyleBuilderCustom::applyInheritGridTemplateColumns):
(WebCore::StyleBuilderCustom::applyValueGridTemplateColumns):
(WebCore::StyleBuilderCustom::applyInitialGridTemplateRows):
(WebCore::StyleBuilderCustom::applyInheritGridTemplateRows):
(WebCore::StyleBuilderCustom::applyValueGridTemplateRows):

css/StyleProperties.cpp:

(WebCore::StyleProperties::getPropertyValue):

Source/WebInspectorUI:

UserInterface/Models/CSSKeywordCompletions.js:

Tools:

TestWebKitAPI/Tests/WebCore/CSSParser.cpp:

(TestWebKitAPI::TEST):

LayoutTests:

css3/parse-align-content.html:
css3/parse-align-items.html:
css3/parse-align-self.html:
css3/parse-justify-content.html:
fast/css-grid-layout/absolute-positioning-definite-sizes.html:
fast/css-grid-layout/absolute-positioning-grid-container-containing-block.html:
fast/css-grid-layout/absolute-positioning-grid-container-parent.html:
fast/css-grid-layout/anonymous-grid-items-expected.html:
fast/css-grid-layout/anonymous-grid-items.html:
fast/css-grid-layout/auto-content-resolution-columns.html:
fast/css-grid-layout/auto-content-resolution-rows.html:
fast/css-grid-layout/breadth-size-resolution-grid.html:
fast/css-grid-layout/calc-resolution-grid-item.html:
fast/css-grid-layout/compute-intrinsic-widths-scrollbar.html:
fast/css-grid-layout/display-grid-set-get-expected.txt:
fast/css-grid-layout/explicit-grid-size.html:
fast/css-grid-layout/flex-and-content-sized-resolution-columns-expected.txt:
fast/css-grid-layout/flex-and-content-sized-resolution-columns.html:
fast/css-grid-layout/flex-and-intrinsic-sizes.html:
fast/css-grid-layout/flex-and-minmax-content-resolution-columns.html:
fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html:
fast/css-grid-layout/flex-content-distribution.html:
fast/css-grid-layout/flex-content-resolution-columns.html:
fast/css-grid-layout/flex-content-resolution-rows.html:
fast/css-grid-layout/flex-content-sized-column-use-available-width.html:
fast/css-grid-layout/flex-content-sized-columns-resize.html:
fast/css-grid-layout/flex-factor-sum-less-than-1.html:
fast/css-grid-layout/float-not-protruding-into-next-grid-item.html:
fast/css-grid-layout/floating-empty-grids.html:
fast/css-grid-layout/grid-align-content-distribution-vertical-lr.html:
fast/css-grid-layout/grid-align-content-distribution-vertical-rl.html:
fast/css-grid-layout/grid-align-content-distribution.html:
fast/css-grid-layout/grid-align-content-vertical-lr.html:
fast/css-grid-layout/grid-align-content-vertical-rl.html:
fast/css-grid-layout/grid-align-content.html:
fast/css-grid-layout/grid-align-justify-margin-border-padding-vertical-lr.html:
fast/css-grid-layout/grid-align-justify-margin-border-padding-vertical-rl.html:
fast/css-grid-layout/grid-align-justify-margin-border-padding.html:
fast/css-grid-layout/grid-align-justify-overflow.html:
fast/css-grid-layout/grid-align-justify-stretch.html:
fast/css-grid-layout/grid-align-stretching-replaced-items.html:
fast/css-grid-layout/grid-align.html:
fast/css-grid-layout/grid-auto-columns-rows-auto-flow-resolution.html:
fast/css-grid-layout/grid-auto-columns-rows-get-set-expected.txt:
fast/css-grid-layout/grid-auto-columns-rows-get-set.html:
fast/css-grid-layout/grid-auto-columns-rows-resolution.html:
fast/css-grid-layout/grid-auto-columns-rows-update.html:
fast/css-grid-layout/grid-auto-flow-get-set-expected.txt:
fast/css-grid-layout/grid-auto-flow-get-set.html:
fast/css-grid-layout/grid-auto-flow-resolution.html:
fast/css-grid-layout/grid-auto-flow-sparse.html:
fast/css-grid-layout/grid-auto-flow-update.html:
fast/css-grid-layout/grid-automatic-minimum-for-auto-columns-expected.txt:
fast/css-grid-layout/grid-automatic-minimum-for-auto-columns.html:
fast/css-grid-layout/grid-automatic-minimum-for-auto-rows-expected.txt:
fast/css-grid-layout/grid-automatic-minimum-for-auto-rows.html:
fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
fast/css-grid-layout/grid-columns-rows-get-set.html:
fast/css-grid-layout/grid-container-change-named-grid-lines-recompute-child.html:
fast/css-grid-layout/grid-container-ignore-first-letter.html:
fast/css-grid-layout/grid-content-alignment-and-self-alignment-spanning.html:
fast/css-grid-layout/grid-content-alignment-and-self-alignment.html:
fast/css-grid-layout/grid-content-alignment-overflow.html:
fast/css-grid-layout/grid-content-alignment-stretch-only-valid-for-auto-sized-tracks.html:
fast/css-grid-layout/grid-content-alignment-stretch-with-different-sized-tracks.html:
fast/css-grid-layout/grid-content-alignment-with-span-vertical-lr.html:
fast/css-grid-layout/grid-content-alignment-with-span-vertical-rl.html:
fast/css-grid-layout/grid-content-alignment-with-span.html:
fast/css-grid-layout/grid-content-sized-columns-resolution-expected.txt:
fast/css-grid-layout/grid-content-sized-columns-resolution.html:
fast/css-grid-layout/grid-disable.html:
fast/css-grid-layout/grid-dynamic-updates-relayout.html:
fast/css-grid-layout/grid-element-auto-repeat-get-set-expected.txt:
fast/css-grid-layout/grid-element-auto-repeat-get-set.html:
fast/css-grid-layout/grid-element-border-grid-item.html:
fast/css-grid-layout/grid-element-border-padding-grid-item.html:
fast/css-grid-layout/grid-element-change-columns-repaint.html:
fast/css-grid-layout/grid-element-change-rows-repaint.html:
fast/css-grid-layout/grid-element-empty-row-column.html:
fast/css-grid-layout/grid-element-min-max-height.html:
fast/css-grid-layout/grid-element-min-max-width.html:
fast/css-grid-layout/grid-element-padding-grid-item.html:
fast/css-grid-layout/grid-element-padding-margin.html:
fast/css-grid-layout/grid-element-repeat-get-set-expected.txt:
fast/css-grid-layout/grid-element-repeat-get-set.html:
fast/css-grid-layout/grid-element-shrink-to-fit.html:
fast/css-grid-layout/grid-grow-tracks-to-their-max-expected.txt:
fast/css-grid-layout/grid-grow-tracks-to-their-max.html:
fast/css-grid-layout/grid-gutters-and-alignment.html:
fast/css-grid-layout/grid-gutters-and-flex-content.html:
fast/css-grid-layout/grid-gutters-and-tracks.html:
fast/css-grid-layout/grid-gutters-get-set-expected.txt:
fast/css-grid-layout/grid-gutters-get-set.html:
fast/css-grid-layout/grid-indefinite-calculated-height-crash-expected.txt:
fast/css-grid-layout/grid-indefinite-calculated-height-crash.html:
fast/css-grid-layout/grid-initialize-span-one-items-expected.txt:
fast/css-grid-layout/grid-initialize-span-one-items.html:
fast/css-grid-layout/grid-item-addition-auto-placement-update.html:
fast/css-grid-layout/grid-item-addition-track-breadth-update.html:
fast/css-grid-layout/grid-item-area-get-set-expected.txt:
fast/css-grid-layout/grid-item-area-get-set.html:
fast/css-grid-layout/grid-item-auto-margins-alignment-vertical-lr.html:
fast/css-grid-layout/grid-item-auto-margins-alignment-vertical-rl.html:
fast/css-grid-layout/grid-item-auto-margins-alignment.html:
fast/css-grid-layout/grid-item-auto-margins-and-stretch.html:
fast/css-grid-layout/grid-item-auto-margins-must-respect-specified-margins.html:
fast/css-grid-layout/grid-item-auto-placement-automatic-span.html:
fast/css-grid-layout/grid-item-auto-placement-definite-span.html:
fast/css-grid-layout/grid-item-auto-placement-fixed-row-column.html:
fast/css-grid-layout/grid-item-auto-sized-align-justify-margin-border-padding.html:
fast/css-grid-layout/grid-item-bad-named-area-auto-placement.html:
fast/css-grid-layout/grid-item-bad-resolution-double-span.html:
fast/css-grid-layout/grid-item-change-column-repaint.html:
fast/css-grid-layout/grid-item-change-row-repaint.html:
fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
fast/css-grid-layout/grid-item-column-row-get-set.html:
fast/css-grid-layout/grid-item-display.html:
fast/css-grid-layout/grid-item-end-after-get-set-expected.txt:
fast/css-grid-layout/grid-item-end-after-get-set.html:
fast/css-grid-layout/grid-item-margin-auto-columns-rows-horizontal-ltr.html:
fast/css-grid-layout/grid-item-margin-auto-columns-rows-horizontal-rtl.html:
fast/css-grid-layout/grid-item-margin-auto-columns-rows-vertical-ltr.html:
fast/css-grid-layout/grid-item-margin-auto-columns-rows-vertical-rtl.html:
fast/css-grid-layout/grid-item-margin-resolution.html:
fast/css-grid-layout/grid-item-margins-not-collapse.html:
fast/css-grid-layout/grid-item-multiple-minmax-content-resolution.html:
fast/css-grid-layout/grid-item-named-grid-area-resolution.html:
fast/css-grid-layout/grid-item-named-grid-line-resolution.html:
fast/css-grid-layout/grid-item-negative-indexes.html:
fast/css-grid-layout/grid-item-negative-integer-explicit-grid-resolution.html:
fast/css-grid-layout/grid-item-negative-position-resolution.html:
fast/css-grid-layout/grid-item-order-auto-flow-resolution.html:
fast/css-grid-layout/grid-item-order-in-content-sized-columns-resolution.html:
fast/css-grid-layout/grid-item-order-paint-order.html:
fast/css-grid-layout/grid-item-position-changed-dynamic.html:
fast/css-grid-layout/grid-item-removal-auto-placement-update.html:
fast/css-grid-layout/grid-item-removal-track-breadth-update.html:
fast/css-grid-layout/grid-item-spanning-resolution.html:
fast/css-grid-layout/grid-item-start-before-get-set-expected.txt:
fast/css-grid-layout/grid-item-start-before-get-set.html:
fast/css-grid-layout/grid-item-stretch-with-margins-borders-padding-vertical-lr.html:
fast/css-grid-layout/grid-item-stretch-with-margins-borders-padding-vertical-rl.html:
fast/css-grid-layout/grid-item-stretch-with-margins-borders-padding.html:
fast/css-grid-layout/grid-item-text-background-not-interleaved.html:
fast/css-grid-layout/grid-item-unknown-named-grid-line-resolution.html:
fast/css-grid-layout/grid-item-with-border-in-fr.html:
fast/css-grid-layout/grid-item-with-border-in-intrinsic.html:
fast/css-grid-layout/grid-item-with-percent-height-in-auto-height-grid-resolution.html:
fast/css-grid-layout/grid-item-with-percent-min-max-height-dynamic.html:
fast/css-grid-layout/grid-item-z-index-change-repaint-expected.html:
fast/css-grid-layout/grid-item-z-index-change-repaint.html:
fast/css-grid-layout/grid-item-z-index-stacking-context-expected.html:
fast/css-grid-layout/grid-item-z-index-stacking-context.html:
fast/css-grid-layout/grid-item-z-index-support.html:
fast/css-grid-layout/grid-items-should-not-be-stretched-when-height-or-width-or-margin-change.html:
fast/css-grid-layout/grid-justify-content-distribution-vertical-lr.html:
fast/css-grid-layout/grid-justify-content-distribution-vertical-rl.html:
fast/css-grid-layout/grid-justify-content-distribution.html:
fast/css-grid-layout/grid-justify-content-vertical-lr.html:
fast/css-grid-layout/grid-justify-content-vertical-rl.html:
fast/css-grid-layout/grid-justify-content.html:
fast/css-grid-layout/grid-percent-track-margin-border-padding.html:
fast/css-grid-layout/grid-percent-track-scrollbar.html:
fast/css-grid-layout/grid-positioned-children-writing-modes.html:
fast/css-grid-layout/grid-positioned-items-background-rtl.html:
fast/css-grid-layout/grid-positioned-items-background.html:
fast/css-grid-layout/grid-positioned-items-content-alignment-rtl.html:
fast/css-grid-layout/grid-positioned-items-content-alignment.html:
fast/css-grid-layout/grid-positioned-items-gaps-rtl.html:
fast/css-grid-layout/grid-positioned-items-gaps.html:
fast/css-grid-layout/grid-positioned-items-implicit-grid-line.html:
fast/css-grid-layout/grid-positioned-items-implicit-grid.html:
fast/css-grid-layout/grid-positioned-items-padding.html:
fast/css-grid-layout/grid-positioned-items-unknown-named-grid-line.html:
fast/css-grid-layout/grid-positioned-items-within-grid-implicit-track.html:
fast/css-grid-layout/grid-preferred-logical-widths.html:
fast/css-grid-layout/grid-repeat-calc-expected.txt:
fast/css-grid-layout/grid-repeat-calc.html:
fast/css-grid-layout/grid-shorthand-computed-style-crash.html:
fast/css-grid-layout/grid-shorthand-get-set-expected.txt:
fast/css-grid-layout/grid-shorthand-get-set.html:
fast/css-grid-layout/grid-sizing-positioned-items.html:
fast/css-grid-layout/grid-strict-ordering-crash.html:
fast/css-grid-layout/grid-template-areas-empty-string-crash.html:
fast/css-grid-layout/grid-template-areas-get-set-expected.txt:
fast/css-grid-layout/grid-template-areas-get-set.html:
fast/css-grid-layout/grid-template-areas-infinite-loop.html:
fast/css-grid-layout/grid-template-columns-rows-computed-style-gaps-content-alignment-expected.txt:
fast/css-grid-layout/grid-template-columns-rows-computed-style-gaps-content-alignment.html:
fast/css-grid-layout/grid-template-shorthand-computed-style-crash.html:
fast/css-grid-layout/grid-template-shorthand-get-set-expected.txt:
fast/css-grid-layout/grid-template-shorthand-get-set.html:
fast/css-grid-layout/grid-update-sizes-after-distributing-all-expected.txt:
fast/css-grid-layout/grid-update-sizes-after-distributing-all.html:
fast/css-grid-layout/grid-was-populated-assert.html:
fast/css-grid-layout/grid-with-relative-font-length-crash.html:
fast/css-grid-layout/implicit-columns-auto-resolution.html:
fast/css-grid-layout/implicit-position-dynamic-change-expected.txt:
fast/css-grid-layout/implicit-position-dynamic-change.html:
fast/css-grid-layout/implicit-rows-auto-resolution.html:
fast/css-grid-layout/implicit-tracks-before-explicit.html:
fast/css-grid-layout/justify-self-cell.html:
fast/css-grid-layout/mark-as-infinitely-growable-expected.txt:
fast/css-grid-layout/mark-as-infinitely-growable.html:
fast/css-grid-layout/maximize-tracks-definite-indefinite-height.html:
fast/css-grid-layout/min-content-row-must-shrink-when-column-grows.html:
fast/css-grid-layout/min-height-border-box.html:
fast/css-grid-layout/min-width-height-auto-and-margins.html:
fast/css-grid-layout/min-width-height-auto-overflow.html:
fast/css-grid-layout/min-width-height-auto.html:
fast/css-grid-layout/min-width-margin-box.html:
fast/css-grid-layout/minmax-fixed-logical-height-only.html:
fast/css-grid-layout/minmax-fixed-logical-width-only.html:
fast/css-grid-layout/minmax-max-content-resolution-columns.html:
fast/css-grid-layout/minmax-max-content-resolution-rows.html:
fast/css-grid-layout/minmax-min-content-column-resolution-columns.html:
fast/css-grid-layout/minmax-min-content-column-resolution-rows.html:
fast/css-grid-layout/minmax-spanning-resolution-columns.html:
fast/css-grid-layout/minmax-spanning-resolution-rows.html:
fast/css-grid-layout/named-grid-line-get-set-expected.txt:
fast/css-grid-layout/named-grid-line-get-set.html:
fast/css-grid-layout/named-grid-lines-computed-style-implicit-tracks-expected.txt:
fast/css-grid-layout/named-grid-lines-computed-style-implicit-tracks.html:
fast/css-grid-layout/named-grid-lines-with-named-grid-areas-dynamic-get-set.html:
fast/css-grid-layout/named-grid-lines-with-named-grid-areas-get-set-expected.txt:
fast/css-grid-layout/named-grid-lines-with-named-grid-areas-get-set.html:
fast/css-grid-layout/named-grid-lines-with-named-grid-areas-resolution.html:
fast/css-grid-layout/non-grid-columns-rows-get-set-expected.txt:
fast/css-grid-layout/non-grid-columns-rows-get-set-multiple-expected.txt:
fast/css-grid-layout/non-grid-columns-rows-get-set-multiple.html:
fast/css-grid-layout/non-grid-columns-rows-get-set.html:
fast/css-grid-layout/non-grid-element-repeat-get-set-expected.txt:
fast/css-grid-layout/non-grid-element-repeat-get-set.html:
fast/css-grid-layout/non-named-grid-line-get-set-expected.txt:
fast/css-grid-layout/non-named-grid-line-get-set.html:
fast/css-grid-layout/percent-grid-item-in-percent-grid-track-in-percent-grid.html:
fast/css-grid-layout/percent-grid-item-in-percent-grid-track-update.html:
fast/css-grid-layout/percent-grid-item-in-percent-grid-track.html:
fast/css-grid-layout/percent-intrinsic-track-breadth.html:
fast/css-grid-layout/percent-of-indefinite-track-size-in-auto.html:
fast/css-grid-layout/percent-of-indefinite-track-size-in-minmax-crash.html:
fast/css-grid-layout/percent-of-indefinite-track-size.html:
fast/css-grid-layout/percent-padding-margin-resolution-grid-item-update.html:
fast/css-grid-layout/percent-padding-margin-resolution-grid-item.html:
fast/css-grid-layout/percent-resolution-grid-item.html:
fast/css-grid-layout/percent-track-breadths-regarding-container-size.html:
fast/css-grid-layout/place-cell-by-index.html:
fast/css-grid-layout/positioned-grid-items-should-not-create-implicit-tracks.html:
fast/css-grid-layout/positioned-grid-items-should-not-take-up-space.html:
fast/css-grid-layout/relayout-align-items-changed.html:
fast/css-grid-layout/relayout-align-self-changed.html:
fast/css-grid-layout/relayout-indefinite-heights.html:
fast/css-grid-layout/relayout-justify-items-changed.html:
fast/css-grid-layout/relayout-justify-self-changed.html:
fast/css-grid-layout/resources/display-grid-set-get.js:
fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:

(testInherit):
(testInitial):

fast/css-grid-layout/resources/grid-columns-rows-get-set.js:

(testInherit):
(testInitial):

fast/css-grid-layout/resources/grid-definitions-parsing-utils.js:

(testGridTemplatesValues):
(checkGridTemplatesSetJSValues):
(testGridTemplatesSetBadJSValues):
(checkGridAutoFlowSetCSSValue):
(checkGridAutoFlowSetJSValue):
(testGridAutoDefinitionsValues):
(testGridGapDefinitionsValues):

fast/css-grid-layout/resources/grid-item-column-row-parsing-utils.js:

(checkColumnRowValues):
(window.testColumnRowJSParsing):
(window.testColumnRowInvalidJSParsing):
(window.testColumnStartRowStartJSParsing):
(window.testColumnEndRowEndJSParsing):
(setupInheritTest):
(setupInitialTest):
(window.testColumnRowInheritJSParsing):
(window.testStartBeforeInheritJSParsing):
(window.testEndAfterInheritJSParsing):
(window.testColumnRowInitialJSParsing):
(window.testStartBeforeInitialJSParsing):
(window.testEndAfterInitialJSParsing):

fast/css-grid-layout/resources/grid-shorthand-parsing-utils.js:

(testGridDefinitionsValues):
(checkGridDefinitionsSetJSValues):
(testGridDefinitionsSetBadJSValues):

fast/css-grid-layout/resources/grid-template-shorthand-parsing-utils.js:

(testGridDefinitionsValues):
(checkGridDefinitionsSetJSValues):
(testGridDefinitionsSetBadJSValues):

fast/css-grid-layout/resources/grid.css:

(.grid):
(.inline-grid):
(.firstRowFirstColumn):
(.onlyFirstRowOnlyFirstColumn):
(.firstRowSecondColumn):
(.onlyFirstRowOnlySecondColumn):
(.firstRowThirdColumn):
(.firstRowFourthColumn):
(.secondRowFirstColumn):
(.onlySecondRowOnlyFirstColumn):
(.secondRowSecondColumn):
(.onlySecondRowOnlySecondColumn):
(.endSecondRowEndSecondColumn):
(.secondRowThirdColumn):
(.secondRowFourthColumn):
(.thirdRowFirstColumn):
(.thirdRowSecondColumn):
(.thirdRowThirdColumn):
(.fourthRowFirstColumn):
(.fourthRowSecondColumn):
(.firstAutoRowSecondAutoColumn):
(.autoLastRowAutoLastColumn):
(.autoSecondRowAutoFirstColumn):
(.firstRowBothColumn):
(.secondRowBothColumn):
(.bothRowFirstColumn):
(.bothRowSecondColumn):
(.bothRowBothColumn):
(.autoRowAutoColumn):
(.firstRowAutoColumn):
(.secondRowAutoColumn):
(.thirdRowAutoColumn):
(.autoRowFirstColumn):
(.autoRowSecondColumn):
(.autoRowThirdColumn):
(.autoRowAutoColumnSpanning2):
(.autoRowSpanning2AutoColumn):
(.autoRowSpanning2AutoColumnSpanning3):
(.autoRowSpanning3AutoColumnSpanning2):
(.autoRowFirstColumnSpanning2):
(.autoRowSecondColumnSpanning2):
(.firstRowSpanning2AutoColumn):
(.secondRowSpanning2AutoColumn):
(.gridAutoFlowColumnSparse):
(.gridAutoFlowColumnDense):
(.gridAutoFlowRowSparse):
(.gridAutoFlowRowDense):

fast/css-grid-layout/resources/non-grid-columns-rows-get-set-multiple.js:

(testInherit):
(testInitial):

fast/css-grid-layout/resources/non-grid-columns-rows-get-set.js:

(testInherit):
(testInitial):

fast/css-grid-layout/should-not-collapse-anonymous-blocks.html:
fast/css-grid-layout/swap-lines-if-start-is-further-endward-than-end-line-expected.html:
fast/css-grid-layout/swap-lines-if-start-is-further-endward-than-end-line.html:
fast/css-grid-layout/tracks-number-greatly-exceeding-available-size-crash.html:
fast/css/auto-min-size.html:
fast/css/first-letter-ignores-display-property.html:
fast/css/getComputedStyle/computed-style-expected.txt:
fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
fast/css/getComputedStyle/resources/property-names.js:
fast/css/parse-justify-items.html:
fast/events/key-events-in-editable-gridbox.html:
fast/repaint/align-items-overflow-change.html:
fast/repaint/align-self-change.html:
fast/repaint/align-self-overflow-change.html:
fast/repaint/justify-items-change.html:
fast/repaint/justify-items-legacy-change.html:
fast/repaint/justify-items-overflow-change.html:
fast/repaint/justify-self-change.html:
fast/repaint/justify-self-overflow-change.html:
fast/text-autosizing/cluster-inline-grid-flex-box-expected.html:
fast/text-autosizing/cluster-inline-grid-flex-box.html:
ietestcenter/css3/grid/display-grid-001-expected.htm:
ietestcenter/css3/grid/display-grid-001.htm:
ietestcenter/css3/grid/display-grid-002-expected.htm:
ietestcenter/css3/grid/display-grid-002.htm:
ietestcenter/css3/grid/grid-column-001-expected.htm:
ietestcenter/css3/grid/grid-column-001.htm:
ietestcenter/css3/grid/grid-column-002-expected.htm:
ietestcenter/css3/grid/grid-column-002.htm:
ietestcenter/css3/grid/grid-column-003-expected.htm:
ietestcenter/css3/grid/grid-column-003.htm:
ietestcenter/css3/grid/grid-columns-001-expected.htm:
ietestcenter/css3/grid/grid-columns-001.htm:
ietestcenter/css3/grid/grid-items-001-expected.htm:
ietestcenter/css3/grid/grid-items-001.htm:
ietestcenter/css3/grid/grid-items-002-expected.htm:
ietestcenter/css3/grid/grid-items-002.htm:
ietestcenter/css3/grid/grid-items-003-expected.htm:
ietestcenter/css3/grid/grid-items-003.htm:
ietestcenter/css3/grid/grid-items-004-expected.htm:
ietestcenter/css3/grid/grid-items-004.htm:
ietestcenter/css3/grid/grid-items-005-expected.htm:
ietestcenter/css3/grid/grid-items-005.htm:
svg/css/getComputedStyle-basic-expected.txt:

12:45 AM Changeset in webkit [200509] by n_wang@apple.com

5 edits
2 adds in trunk

AX: <attachment> element should have a replacement character
https://bugs.webkit.org/show_bug.cgi?id=157406

Reviewed by Chris Fleizach.

Source/WebCore:

Make sure attachment element is considered as a replaced node.

Test: accessibility/mac/attachment-element-replacement-character.html

editing/TextIterator.cpp:

(WebCore::isRendererReplacedElement):

LayoutTests:

accessibility/attachment-element-expected.txt:
accessibility/mac/attachment-element-replacement-character-expected.txt: Added.
accessibility/mac/attachment-element-replacement-character.html: Added.
editing/pasteboard/drag-and-drop-attachment-contenteditable-expected.txt:

12:27 AM Changeset in webkit [200508] by n_wang@apple.com

3 edits
2 adds in trunk

AX: String for document range is empty if end visible position anchors to a ignored replaced node
https://bugs.webkit.org/show_bug.cgi?id=157403

Reviewed by Chris Fleizach.

Source/WebCore:

The CharacterOffset that is converted from VisiblePositon is wrong when the VisiblePostion anchors
to an ignored replaced node. Fixed it by adjusting the offset of the CharacterOffset correctly in
such case.

Test: accessibility/mac/text-marker-string-for-document-end-replaced-node.html

accessibility/AXObjectCache.cpp:

(WebCore::characterOffsetsInOrder):
(WebCore::AXObjectCache::characterOffsetFromVisiblePosition):
(WebCore::AXObjectCache::accessibilityObjectForTextMarkerData):

LayoutTests:

accessibility/mac/text-marker-string-for-document-end-replaced-node-expected.txt: Added.
accessibility/mac/text-marker-string-for-document-end-replaced-node.html: Added.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed