Context Navigation

← Previous Period
Next Period →

Timeline

May 20, 2016:

11:15 PM Changeset in webkit [201241] by mitz@apple.com

2 edits in trunk/Source/WebCore

Fixed USE(APPLE_INTERNAL_SDK) builds.

platform/cocoa/ThemeCocoa.mm:

(WebCore::fitContextToBox):

10:22 PM Changeset in webkit [201240] by Joseph Pecoraro

2 edits in trunk/LayoutTests

Unreviewed test gardening after r201237 exposed an issue.

TestExpectations:

10:17 PM Changeset in webkit [201239] by Joseph Pecoraro

48 edits
13 deletes in trunk/Source

Remove LegacyProfiler
https://bugs.webkit.org/show_bug.cgi?id=153565

Reviewed by Mark Lam.

Source/JavaScriptCore:

JavaScriptCore now provides a sampling profiler and it is enabled
by all ports. Web Inspector switched months ago to using the
sampling profiler and displaying its data. Remove the legacy
profiler, as it is no longer being used by anything other then
console.profile and tests. We will update console.profile's
behavior soon to have new behavior and use the sampling data.

API/JSProfilerPrivate.cpp: Removed.
API/JSProfilerPrivate.h: Removed.
CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/BytecodeList.json:
bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset): Deleted.
(JSC::computeDefsForBytecodeOffset): Deleted.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode): Deleted.

bytecode/UnlinkedFunctionExecutable.cpp:

(JSC::generateUnlinkedFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::unlinkedCodeBlockFor):

bytecode/UnlinkedFunctionExecutable.h:
bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitCallVarargsInTailPosition):
(JSC::BytecodeGenerator::emitConstructVarargs):
(JSC::BytecodeGenerator::emitConstruct):

bytecompiler/BytecodeGenerator.h:

(JSC::CallArguments::profileHookRegister): Deleted.
(JSC::BytecodeGenerator::shouldEmitProfileHooks): Deleted.

bytecompiler/NodesCodegen.cpp:

(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
(JSC::CallArguments::CallArguments): Deleted.

dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects): Deleted.

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock): Deleted.

dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel): Deleted.

dfg/DFGClobberize.h:

(JSC::DFG::clobberize): Deleted.

dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC): Deleted.

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode): Deleted.

dfg/DFGNodeType.h:
dfg/DFGPredictionPropagationPhase.cpp:
dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute): Deleted.

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile): Deleted.

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile): Deleted.

inspector/InjectedScriptBase.cpp:

(Inspector::InjectedScriptBase::callFunctionWithEvalEnabled):

interpreter/Interpreter.cpp:

(JSC::UnwindFunctor::operator()): Deleted.
(JSC::Interpreter::execute): Deleted.
(JSC::Interpreter::executeCall): Deleted.
(JSC::Interpreter::executeConstruct): Deleted.

jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass): Deleted.

jit/JIT.h:
jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_profile_will_call): Deleted.
(JSC::JIT::emit_op_profile_did_call): Deleted.

jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_profile_will_call): Deleted.
(JSC::JIT::emit_op_profile_did_call): Deleted.

jit/JITOperations.cpp:
jit/JITOperations.h:
llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL): Deleted.

llint/LLIntSlowPaths.h:
llint/LowLevelInterpreter.asm:
parser/ParserModes.h:
profiler/CallIdentifier.h: Removed.
profiler/LegacyProfiler.cpp: Removed.
profiler/LegacyProfiler.h: Removed.
profiler/Profile.cpp: Removed.
profiler/Profile.h: Removed.
profiler/ProfileGenerator.cpp: Removed.
profiler/ProfileGenerator.h: Removed.
profiler/ProfileNode.cpp: Removed.
profiler/ProfileNode.h: Removed.
profiler/ProfilerJettisonReason.cpp:

(WTF::printInternal): Deleted.

profiler/ProfilerJettisonReason.h:
runtime/CodeCache.cpp:

(JSC::CodeCache::getGlobalCodeBlock):
(JSC::CodeCache::getProgramCodeBlock):
(JSC::CodeCache::getEvalCodeBlock):
(JSC::CodeCache::getModuleProgramCodeBlock):

runtime/CodeCache.h:
runtime/Executable.cpp:

(JSC::ScriptExecutable::newCodeBlockFor):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::createProgramCodeBlock):
(JSC::JSGlobalObject::createEvalCodeBlock):
(JSC::JSGlobalObject::createModuleProgramCodeBlock):
(JSC::JSGlobalObject::~JSGlobalObject): Deleted.
(JSC::JSGlobalObject::hasLegacyProfiler): Deleted.

runtime/JSGlobalObject.h:
runtime/Options.h:
runtime/VM.cpp:

(JSC::VM::VM): Deleted.
(JSC::SetEnabledProfilerFunctor::operator()): Deleted.
(JSC::VM::setEnabledProfiler): Deleted.

runtime/VM.h:

(JSC::VM::enabledProfiler): Deleted.
(JSC::VM::enabledProfilerAddress): Deleted.

Source/WebCore:

ForwardingHeaders/profiler/Profile.h: Removed.
ForwardingHeaders/profiler/ProfileNode.h: Removed.
testing/js/WebCoreTestSupport.cpp:
xml/XSLStyleSheetLibxslt.cpp:
xml/XSLTProcessorLibxslt.cpp:

8:57 PM Changeset in webkit [201238] by rniwa@webkit.org

6 edits in trunk

run-benchmark's results should contain Animometer's debug output
https://bugs.webkit.org/show_bug.cgi?id=157941

Reviewed by Stephanie Lewis.

PerformanceTests:

Made developer.html support the JSON generated by run-benchmark which stores everything under debugOutput.

Animometer/resources/debug-runner/animometer.js:

(Utilities.initialize): Unwrap debugOutput in the case run-benchmark's result JSON is used.

Tools:

Modified the Animometer patch to store debug output and made benchmark_runner extract them together as a single array.
The result can be dragged and dropped into Animometer's developer.html page.

Scripts/webkitpy/benchmark_runner/benchmark_runner.py:

(BenchmarkRunner._run_one_test): Parse JSON here instead of doing it in multiple call sites.
(BenchmarkRunner._run_benchmark): Strip debugOutput from individual test result, and merge them together separately.

Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch:

Modified the patch to store the debug output.

Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:

(ServerControl.render_POST): Fixed a bug that POST to /report results in 500 because getvalue is not defined
when the request body is larger than a certain size on twisted.

7:00 PM Changeset in webkit [201237] by commit-queue@webkit.org

51 edits
8 deletes in trunk

Remove LegacyProfiler
https://bugs.webkit.org/show_bug.cgi?id=153565

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-20
Reviewed by Saam Barati.

ManualTests/inspector/profiler-test-call.html: Removed.
ManualTests/inspector/profiler-test-many-calls-in-the-same-scope.html: Removed.

Source/JavaScriptCore:

inspector/protocol/Timeline.json:
jsc.cpp:
runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::hasLegacyProfiler):

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::supportsLegacyProfiling): Deleted.

Source/WebCore:

CMakeLists.txt:
DerivedSources.cpp:
DerivedSources.make:
ForwardingHeaders/profiler/LegacyProfiler.h: Removed.
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSCustomXPathNSResolver.cpp:
bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::supportsLegacyProfiling): Deleted.
(WebCore::JSDOMWindowBase::supportsRichSourceInfo): Deleted.

bindings/js/JSDOMWindowBase.h:
bindings/js/JSWorkerGlobalScopeBase.cpp:

(WebCore::JSWorkerGlobalScopeBase::supportsLegacyProfiling): Deleted.

bindings/js/JSWorkerGlobalScopeBase.h:
bindings/js/ScriptCachedFrameData.cpp:
bindings/js/ScriptController.cpp:

(WebCore::ScriptController::clearWindowShell): Deleted.

bindings/js/ScriptProfile.h: Removed.
bindings/js/ScriptProfileNode.h: Removed.
bindings/scripts/CodeGeneratorJS.pm:

(AddClassForwardIfNeeded): Deleted.

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence): Deleted.

bindings/scripts/test/TestObj.idl:
css/CSSParser.cpp:
dom/Document.cpp:
inspector/InspectorConsoleInstrumentation.h:

(WebCore::InspectorInstrumentation::stopProfiling):

inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::legacyProfilerEnabled): Deleted.
(WebCore::InspectorController::setLegacyProfilerEnabled): Deleted.

inspector/InspectorController.h:
inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::stopProfilingImpl):

inspector/InspectorInstrumentation.h:
inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::startFromConsole):
(WebCore::InspectorTimelineAgent::stopFromConsole):

inspector/InspectorTimelineAgent.h:
inspector/PageDebuggerAgent.cpp:
inspector/PageRuntimeAgent.cpp:
inspector/ScriptProfile.idl: Removed.
inspector/ScriptProfileNode.idl: Removed.
inspector/TimelineRecordFactory.cpp:

(WebCore::buildAggregateCallInfoInspectorObject): Deleted.
(WebCore::buildInspectorObject): Deleted.
(WebCore::buildProfileInspectorObject): Deleted.
(WebCore::TimelineRecordFactory::appendProfile): Deleted.

inspector/TimelineRecordFactory.h:
page/DOMWindow.cpp:
page/Page.cpp:
page/PageConsoleClient.cpp:

(WebCore::PageConsoleClient::profileEnd):
(WebCore::PageConsoleClient::clearProfiles): Deleted.

page/PageConsoleClient.h:
testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState): Deleted.
(WebCore::Internals::consoleProfiles): Deleted.
(WebCore::Internals::setLegacyJavaScriptProfilingEnabled): Deleted.

testing/Internals.h:
testing/Internals.idl:

Source/WebKit/win:

Interfaces/IWebInspector.idl:
WebCoreStatistics.cpp:
WebInspector.cpp:

(WebInspector::isJavaScriptProfilingEnabled): Deleted.
(WebInspector::setJavaScriptProfilingEnabled): Deleted.

WebInspector.h:
WebView.cpp:

LayoutTests:

fast/profiler/anonymous-event-handler-expected.txt: Removed.
fast/profiler/anonymous-event-handler.html: Removed.
fast/profiler/anonymous-function-called-from-different-contexts-expected.txt: Removed.
fast/profiler/anonymous-function-called-from-different-contexts.html: Removed.
fast/profiler/anonymous-function-calls-built-in-functions-expected.txt: Removed.
fast/profiler/anonymous-function-calls-built-in-functions.html: Removed.
fast/profiler/anonymous-function-calls-eval-expected.txt: Removed.
fast/profiler/anonymous-function-calls-eval.html: Removed.
fast/profiler/anonymous-functions-with-display-names-expected.txt: Removed.
fast/profiler/anonymous-functions-with-display-names.html: Removed.
fast/profiler/apply-expected.txt: Removed.
fast/profiler/apply.html: Removed.
fast/profiler/built-in-function-calls-anonymous-expected.txt: Removed.
fast/profiler/built-in-function-calls-anonymous.html: Removed.
fast/profiler/built-in-function-calls-user-defined-function-expected.txt: Removed.
fast/profiler/built-in-function-calls-user-defined-function.html: Removed.
fast/profiler/call-expected.txt: Removed.
fast/profiler/call-register-leak-expected.txt: Removed.
fast/profiler/call-register-leak.html: Removed.
fast/profiler/call.html: Removed.
fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope-expected.txt: Removed.
fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html: Removed.
fast/profiler/compare-multiple-profiles-expected.txt: Removed.
fast/profiler/compare-multiple-profiles.html: Removed.
fast/profiler/constructor-expected.txt: Removed.
fast/profiler/constructor.html: Removed.
fast/profiler/dead-time-expected.txt: Removed.
fast/profiler/dead-time.html: Removed.
fast/profiler/document-dot-write-expected.txt: Removed.
fast/profiler/document-dot-write.html: Removed.
fast/profiler/event-handler-expected.txt: Removed.
fast/profiler/event-handler.html: Removed.
fast/profiler/execution-context-and-eval-on-same-line-expected.txt: Removed.
fast/profiler/execution-context-and-eval-on-same-line.html: Removed.
fast/profiler/inline-event-handler-expected.txt: Removed.
fast/profiler/inline-event-handler.html: Removed.
fast/profiler/many-calls-in-the-same-scope-expected.txt: Removed.
fast/profiler/many-calls-in-the-same-scope.html: Removed.
fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt: Removed.
fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html: Removed.
fast/profiler/multiple-and-different-scoped-function-calls-expected.txt: Removed.
fast/profiler/multiple-and-different-scoped-function-calls.html: Removed.
fast/profiler/multiple-anonymous-functions-called-from-the-same-function-expected.txt: Removed.
fast/profiler/multiple-anonymous-functions-called-from-the-same-function.html: Removed.
fast/profiler/multiple-frames-expected.txt: Removed.
fast/profiler/multiple-frames.html: Removed.
fast/profiler/named-functions-with-display-names-expected.txt: Removed.
fast/profiler/named-functions-with-display-names.html: Removed.
fast/profiler/nested-anonymous-functon-expected.txt: Removed.
fast/profiler/nested-anonymous-functon.html: Removed.
fast/profiler/nested-start-and-stop-profiler-expected.txt: Removed.
fast/profiler/nested-start-and-stop-profiler.html: Removed.
fast/profiler/no-execution-context-expected.txt: Removed.
fast/profiler/no-execution-context.html: Removed.
fast/profiler/one-execution-context-expected.txt: Removed.
fast/profiler/one-execution-context.html: Removed.
fast/profiler/profile-calls-in-included-file-expected.txt: Removed.
fast/profiler/profile-calls-in-included-file.html: Removed.
fast/profiler/profile-with-no-title-expected.txt: Removed.
fast/profiler/profile-with-no-title.html: Removed.
fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting-expected.txt: Removed.
fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html: Removed.
fast/profiler/profiling-from-a-nested-location-expected.txt: Removed.
fast/profiler/profiling-from-a-nested-location.html: Removed.
fast/profiler/resources/other-frame.html: Removed.
fast/profiler/resources/other-window.html: Removed.
fast/profiler/resources/profiler-test-JS-resources.js: Removed.
fast/profiler/simple-event-call-expected.txt: Removed.
fast/profiler/simple-event-call.html: Removed.
fast/profiler/simple-no-level-change-expected.txt: Removed.
fast/profiler/simple-no-level-change.html: Removed.
fast/profiler/start-and-stop-profiler-multiple-times-expected.txt: Removed.
fast/profiler/start-and-stop-profiler-multiple-times.html: Removed.
fast/profiler/start-and-stop-profiling-in-the-same-function-expected.txt: Removed.
fast/profiler/start-and-stop-profiling-in-the-same-function.html: Removed.
fast/profiler/start-but-dont-stop-profiling-expected.txt: Removed.
fast/profiler/start-but-dont-stop-profiling.html: Removed.
fast/profiler/stop-profiling-after-setTimeout-expected.txt: Removed.
fast/profiler/stop-profiling-after-setTimeout.html: Removed.
fast/profiler/stop-then-function-call-expected.txt: Removed.
fast/profiler/stop-then-function-call.html: Removed.
fast/profiler/throw-exception-from-eval-expected.txt: Removed.
fast/profiler/throw-exception-from-eval.html-disabled: Removed.
fast/profiler/two-execution-contexts-expected.txt: Removed.
fast/profiler/two-execution-contexts.html: Removed.
fast/profiler/user-defined-function-calls-built-in-functions-expected.txt: Removed.
fast/profiler/user-defined-function-calls-built-in-functions.html: Removed.
fast/profiler/window-dot-eval-expected.txt: Removed.
fast/profiler/window-dot-eval.html: Removed.
platform/efl/TestExpectations:
platform/gtk/TestExpectations:
platform/ios-simulator/TestExpectations:

6:17 PM Changeset in webkit [201236] by bshafiei@apple.com

1 copy in tags/Safari-602.1.32.4

New tag.

5:17 PM Changeset in webkit [201235] by sbarati@apple.com

2 edits in trunk/Source/JavaScriptCore

JSScope::abstractAccess doesn't need to copy the SymbolTableEntry, it can use it by reference
https://bugs.webkit.org/show_bug.cgi?id=157956

Reviewed by Geoffrey Garen.

A SymbolTableEntry may be a FatEntry. Copying a FatEntry is slow because we have to
malloc memory for it, then free the malloced memory once the entry goes out of
scope. abstractAccess uses a SymbolTableEntry temporarily when performing scope
accesses during bytecode linking. It copies out the SymbolTableEntry every time
it does a SymbolTable lookup. This is not cheap when the entry happens to be a
FatEntry. We should really just be using a reference to the entry because
there is no need to copy it in such a scenario.

runtime/JSScope.cpp:

(JSC::abstractAccess):

4:56 PM Changeset in webkit [201234] by Alan Bujtas

12 edits
4 adds in trunk

width: 1% on nested table cell causes its table to hog horizontal space
https://bugs.webkit.org/show_bug.cgi?id=144696
<rdar://problem/20839572>

Reviewed by David Hyatt and Tim Horton.

This patch is based on https://chromium.googlesource.com/chromium/src/+/9428cfb16993a2329e87c65da096ca295132ef0f

Source/WebCore:

Tests: fast/table/inner-percent-width-affects-outer-floated-div.html

fast/table/inner-percent-width-doesnt-affect-ancestor-columns.html

rendering/AutoTableLayout.cpp:

(WebCore::shouldScaleColumnsForParent):
(WebCore::shouldScaleColumnsForSelf):
(WebCore::AutoTableLayout::computeIntrinsicLogicalWidths):
(WebCore::shouldScaleColumns): Deleted.

rendering/AutoTableLayout.h:
rendering/RenderTable.cpp:

(WebCore::RenderTable::updateLogicalWidth):

rendering/TableLayout.h:

(WebCore::TableLayout::scaledWidthFromPercentColumns):

LayoutTests:

fast/table/inner-percent-width-affects-outer-floated-div-expected.html: Added.
fast/table/inner-percent-width-affects-outer-floated-div.html: Added.
fast/table/inner-percent-width-doesnt-affect-ancestor-columns-expected.html: Added.
fast/table/inner-percent-width-doesnt-affect-ancestor-columns.html: Added.
platform/mac/fast/table/border-collapsing/cached-change-row-border-width-expected.txt:
platform/mac/fast/table/border-collapsing/cached-change-tbody-border-width-expected.txt:
platform/mac/fast/table/max-width-integer-overflow-expected.txt:

4:46 PM Changeset in webkit [201233] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

Inconsistent state in playback controls
https://bugs.webkit.org/show_bug.cgi?id=157962
<rdar://problem/26397571>

Reviewed by Beth Dakin.

Do not use the playbackSessionManager() as the model, that's what the model is for.

platform/mac/WebPlaybackSessionInterfaceMac.mm:

(WebCore::WebPlaybackSessionInterfaceMac::setClient):

4:15 PM Changeset in webkit [201232] by beidson@apple.com

7 edits
3 adds in trunk

Modern IDB: Properly handle blobs in Workers.
https://bugs.webkit.org/show_bug.cgi?id=157947

Reviewed by Alex Christensen.

Source/WebCore:

Test: storage/indexeddb/modern/blob-simple-workers.html

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::putOrAddOnServer): Use writeBlobsToDiskForIndexedDBSynchronously from

background threads instead of the asynchronous form.

Add ability to set an existing empty IDBValue to be an isolated copy of a different IDBValue:

Modules/indexeddb/IDBValue.cpp:

(WebCore::IDBValue::setAsIsolatedCopy):
(WebCore::IDBValue::isolatedCopy):

Modules/indexeddb/IDBValue.h:

Add a method - only to be called from a non-main thread - that synchronously writes blobs to disk:

bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::writeBlobsToDiskForIndexedDBSynchronously):

bindings/js/SerializedScriptValue.h:

LayoutTests:

storage/indexeddb/modern/blob-simple-workers-expected.txt: Added.
storage/indexeddb/modern/blob-simple-workers.html: Added.
storage/indexeddb/modern/resources/blob-simple-workers.js: Added.

3:53 PM Changeset in webkit [201231] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

REGRESSION(r200740): Web Inspector: TimelineRecordBar class lists not properly cleared, bleeding colors when zooming in and out
https://bugs.webkit.org/show_bug.cgi?id=157959
<rdar://problem/26393067>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-20
Reviewed by Brian Burg.

UserInterface/Views/TimelineRecordBar.js:

(WebInspector.TimelineRecordBar.prototype.set records):
When records are cleared, clear all classes.

3:31 PM Changeset in webkit [201230] by bshafiei@apple.com

7 edits
2 adds in branches/safari-602.1.32-branch

Merge r201227. rdar://problem/24577706

3:28 PM Changeset in webkit [201229] by andersca@apple.com

2 edits in trunk/Source/WebCore

Allow named images on iOS
https://bugs.webkit.org/show_bug.cgi?id=157960
rdar://problem/26396532

Reviewed by Dean Jackson.

USE(NEW_THEME) is false on iOS so force named images to be drawn by checking PLATFORM(IOS) as well.

platform/graphics/NamedImageGeneratedImage.cpp:

(WebCore::NamedImageGeneratedImage::draw):

3:10 PM Changeset in webkit [201228] by mmaxfield@apple.com

4 edits
3 adds in trunk

[Cocoa] REGRESSION(r184899): Ascent adjustments are applied to web fonts
https://bugs.webkit.org/show_bug.cgi?id=157954
<rdar://problem/24204349>

Reviewed by Dean Jackson.

Source/WebCore:

There are a few specific fonts which exist on Windows and Cocoa OSes, and we will adjust
the ascents of these fonts to better match their counterparts on Windows. However, in
r184899, we started applying this adjustment to web fonts too.

Test: fast/text/ascent-adjustment-webfont.html

platform/graphics/cocoa/FontCocoa.mm:

(WebCore::Font::platformInit):

svg/SVGToOTFFontConversion.cpp: We were reporting the length of font names wrong, so

it made the test pass without this patch even when it shouldn't have. Previously, we
were recording the number of characters in the font, not the number of bytes (each
character is 2 bytes).

LayoutTests:

fast/text/ascent-adjustment-webfont-expected-mismatch.html: Added.
fast/text/ascent-adjustment-webfont.html: Added.
fast/text/resources/Helvetica-light.svg: Added.

3:05 PM Changeset in webkit [201227] by enrica@apple.com

7 edits
2 adds in trunk

Drag cannot start if no drag data or custom data is available in the Pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=157911
rdar://problem/24577706

Reviewed by Tim Horton.

Source/WebKit/mac:

We need to make sure there is always one item in common between source and target
of the drag and drop operation.

WebView/WebHTMLView.mm:

(-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]):

Source/WebKit2:

We need to make sure there is always one item in common between source and target
of the drag and drop operation.

UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::dragImageForView):

LayoutTests:

fast/events/draggable-div-customdata-expected.txt: Added.
fast/events/draggable-div-customdata.html: Added.
platform/ios-simulator/TestExpectations
platform/mac-wk2/TestExpectations

2:47 PM Changeset in webkit [201226] by commit-queue@webkit.org

3 edits
1 add in trunk/Source/JavaScriptCore

Web Inspector: retained size for typed arrays does not count native backing store
https://bugs.webkit.org/show_bug.cgi?id=157945
<rdar://problem/26392238>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-20
Reviewed by Geoffrey Garen.

runtime/JSArrayBuffer.h:
runtime/JSArrayBuffer.cpp:

(JSC::JSArrayBuffer::estimatedSize):
Include an estimatedSize implementation for JSArrayBuffer.
ArrayBuffer has a unique path, different from other data
stored in the Heap.

tests/heapProfiler/typed-array-sizes.js: Added.

Test sizes of TypedArray with and without an ArrayBuffer.
When the TypedArray is a view wrapping an ArrayBuffer, the
ArrayBuffer has the size.

2:17 PM Changeset in webkit [201225] by ggaren@apple.com

3 edits in trunk/Source/JavaScriptCore

reifyAllStaticProperties makes two copies of every string
https://bugs.webkit.org/show_bug.cgi?id=157953

Reviewed by Mark Lam.

Let's not do that.

runtime/JSObject.cpp:

(JSC::JSObject::reifyAllStaticProperties): Pass our Identifier to
reifyStaticProperty so it doesn't have to make its own.

runtime/Lookup.h:

(JSC::reifyStaticProperty): No need to null check because callers never
pass null anymore. No need to make an identifier because callers pass
us one.

(JSC::reifyStaticProperties): Honor new interface.

2:17 PM Changeset in webkit [201224] by commit-queue@webkit.org

19 edits in trunk/Source

Remove unnecessary PageOverlay client function pageOverlayDestroyed
https://bugs.webkit.org/show_bug.cgi?id=157388
<rdar://problem/25471523>

Patch by John Wilander <wilander@apple.com> on 2016-05-20
Reviewed by Tim Horton.

Remove dead PageOverlay code. Almost all of these overrides were empty and
never called. In the case of WebPageOverlay it was never called but had a
function body, causing confusion. There was a fear of dangling pointers in
WebPageOverlay's static hash map between PageOverlays and WebPageOverlays.
Only WebPageOverlay's constructor creates its PageOverlay object and adds it
to the hash map. Its client object is kept in a unique pointer member which
is automatically deleted when the WebPageOverlay object itself is deleted.
This explains why PageOverlayClientImpl::pageOverlayDestroyed in
WKBundlePageOverlay can safely be removed. Finally, WebPageOverlay's
destructor clears the hash map entry for its PageOverlay object. Thus, there
is no need to call WebPageOverlay::pageOverlayDestroyed nor a need for
WebPageOverlay's destructor to call pageOverlayDestroyed on its client.

No new tests. I tried to come up with a WebKit API test for this but I
wasn't able to test presence/absence of WebPageOverlay's map entries since
the map is not exposed.

Source/WebCore:

page/DebugPageOverlays.cpp:

(WebCore::RegionOverlay::pageOverlayDestroyed): Deleted.

page/PageOverlay.h:

(WebCore::PageOverlay::Client::pageOverlayDestroyed): Deleted.

page/ResourceUsageOverlay.h:

(WebCore::ResourceUsageOverlay::pageOverlayDestroyed): Deleted.

page/mac/ServicesOverlayController.h:
page/mac/ServicesOverlayController.mm:

(WebCore::ServicesOverlayController::pageOverlayDestroyed): Deleted.

testing/MockPageOverlayClient.cpp:
testing/MockPageOverlayClient.h:

(WebCore::MockPageOverlayClient::pageOverlayDestroyed): Deleted.

Source/WebKit2:

WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:

(WebKit::PageOverlayClientImpl::pageOverlayDestroyed): Deleted.

WebProcess/Plugins/PDF/PDFPlugin.h:
WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::HUD::pageOverlayDestroyed): Deleted.

WebProcess/WebCoreSupport/WebInspectorClient.cpp:
WebProcess/WebCoreSupport/WebInspectorClient.h:

(WebKit::WebInspectorClient::pageOverlayDestroyed): Deleted.

WebProcess/WebPage/FindController.cpp:
WebProcess/WebPage/FindController.h:

(WebKit::FindController::pageOverlayDestroyed): Deleted.

WebProcess/WebPage/WebPageOverlay.cpp:
WebProcess/WebPage/WebPageOverlay.h:

(WebKit::WebPageOverlay::pageOverlayDestroyed): Deleted.

WebProcess/WebPage/ios/FindIndicatorOverlayClientIOS.h:

(WebKit::FindIndicatorOverlayClientIOS::pageOverlayDestroyed): Deleted.

1:43 PM Changeset in webkit [201223] by commit-queue@webkit.org

6 edits
2 adds in trunk

Fix null dereferencing in CSSAnimationTriggerScrollValue::equals
https://bugs.webkit.org/show_bug.cgi?id=157930

Patch by Alex Christensen <achristensen@webkit.org> on 2016-05-20
Reviewed by Dean Jackson.

Source/WebCore:

Test: fast/css/compare-animation-trigger.html

css/CSSAnimationTriggerScrollValue.cpp:

(WebCore::CSSAnimationTriggerScrollValue::equals):

css/CSSAnimationTriggerScrollValue.h:

(WebCore::CSSAnimationTriggerScrollValue::create):
(WebCore::CSSAnimationTriggerScrollValue::startValue):
(WebCore::CSSAnimationTriggerScrollValue::endValue):
(WebCore::CSSAnimationTriggerScrollValue::hasEndValue):
(WebCore::CSSAnimationTriggerScrollValue::operator==):
(WebCore::CSSAnimationTriggerScrollValue::CSSAnimationTriggerScrollValue):

css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapAnimationTrigger):

css/CSSValue.h:

(WebCore::CSSValue::operator==):

LayoutTests:

fast/css/compare-animation-trigger-expected.txt: Added.
fast/css/compare-animation-trigger.html: Added.

12:36 PM Changeset in webkit [201222] by Nikita Vasilyev

5 edits in trunk/Source/WebInspectorUI

Web Inspector: Split Console is auto opening all the time when using Inspect Element context menu
https://bugs.webkit.org/show_bug.cgi?id=157910
<rdar://problem/26374066>

Reviewed by Timothy Hatcher.

Currently, "synthetic" property is only used to decide whether adding a console message should
open the console or not. Replace it with "shouldRevealConsole".

UserInterface/Controllers/DOMTreeManager.js:

(WebInspector.DOMTreeManager.prototype.inspectNodeObject.nodeAvailable):
(WebInspector.DOMTreeManager.prototype.inspectNodeObject):

UserInterface/Controllers/JavaScriptLogViewController.js:

(WebInspector.JavaScriptLogViewController.prototype.appendImmediateExecutionWithResult.saveResultCallback):
(WebInspector.JavaScriptLogViewController.prototype.appendImmediateExecutionWithResult):
(WebInspector.JavaScriptLogViewController.prototype.consolePromptTextCommitted.printResult):
(WebInspector.JavaScriptLogViewController.prototype.consolePromptTextCommitted):
(WebInspector.JavaScriptLogViewController.prototype._appendConsoleMessageView):

UserInterface/Models/ConsoleCommandResultMessage.js:

(WebInspector.ConsoleCommandResultMessage):
(WebInspector.ConsoleCommandResultMessage.prototype.get shouldRevealConsole):
(WebInspector.ConsoleCommandResultMessage.prototype.get synthetic): Deleted.

UserInterface/Views/HeapSnapshotInstanceDataGridNode.js:

(WebInspector.HeapSnapshotInstanceDataGridNode.logHeapSnapshotNode.node.shortestGCRootPath.):
(WebInspector.HeapSnapshotInstanceDataGridNode.logHeapSnapshotNode):

12:13 PM Changeset in webkit [201221] by ggaren@apple.com

2 edits in trunk/Source/JavaScriptCore

JSBench regression: CodeBlock linking always copies the symbol table
https://bugs.webkit.org/show_bug.cgi?id=157951

Reviewed by Saam Barati.

We always put a SymbolTable into the constant pool, even in simple
functions in which it won't be used -- i.e., there's on eval and there
are no captured variables and so on.

This is costly because linking must copy any provided symbol tables.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitProfileType): Only add the symbol table
as a constant if we will use it at runtime.

12:07 PM Changeset in webkit [201220] by bshafiei@apple.com

2 edits in tags/Safari-602.1.33.1/Source/WebCore

Merged r201212. rdar://problem/26385907

12:06 PM Changeset in webkit [201219] by bshafiei@apple.com

5 edits in tags/Safari-602.1.33.1/Source

Versioning.

11:48 AM Changeset in webkit [201218] by hyatt@apple.com

3 edits
2 adds in trunk

Scrolling broken in iTunes connect pages
https://bugs.webkit.org/show_bug.cgi?id=157678

Reviewed by Zalan Bujtas.

Source/WebCore:

Added fast/flexbox/nested-columns-min-intrinsic-disabled.html

Turn off minimum intrinsic size adjustment for flexboxes. This violates the spec,
but until we can produce good results that is what we need to do. Blink has also
turned off nested columns intrinsic sizing as well, so we match them with this
change.

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax):

LayoutTests:

fast/flexbox/nested-column-intrinsic-min-disabled-expected.html: Added.
fast/flexbox/nested-column-intrinsic-min-disabled.html: Added.

11:44 AM Changeset in webkit [201217] by bshafiei@apple.com

1 copy in tags/Safari-602.1.33.1

New tag.

11:34 AM Changeset in webkit [201216] by jdiggs@igalia.com

60 edits
1 move
19 deletes in trunk/LayoutTests

AX: Layout tests related to text alternative computation need to be done differently
https://bugs.webkit.org/show_bug.cgi?id=157187

Create several utility methods to facilitate retrieval of platform-independent
attribute values from platform-specific attributes:

platformValueForW3CName() and platformValueForW3CDescription() to retrieve a specific piece of text alternative information, stripping off the platform attribute name by default. These methods should make it possible to share tests and expectations files because the text alternative calculation defined by the W3C accessibility specifications should be the same for all platforms. (The differences are the result of the unique platform mappings.)

platformTextAlternatives() to dump out all the text alternative attributes and values, preserving the platform-specific attribute name. This, along with the use of the platformValue* methods with attribute name enabled, should make it possible to have shared tests with platform-specific expectations without the need to check the platform in the test itself.

platformRoleForComboBox() and platformRoleForStaticText() to eliminate the need for platform-specific expectations files simply because such an element happens to be included in the test file and verifying that element's role is desired.

Begin using these methods in the tests related to text alternative computation
which had platform-specific checks, update the expectations files when needed,
and remove now-obsolete platform-specific expectations files.

Reviewed by Chris Fleizach.

accessibility/alt-tag-on-image-with-nonimage-role-expected.txt: Updated.
accessibility/alt-tag-on-image-with-nonimage-role.html: Updated.
accessibility/aria-help-expected.txt: Added.
accessibility/aria-help.html: Updated.
accessibility/aria-label-expected.txt: Updated.
accessibility/aria-label.html: Updated.
accessibility/aria-labeled-with-hidden-node-expected.txt: Updated.
accessibility/aria-labeled-with-hidden-node.html: Updated.
accessibility/aria-labelledby-on-input-expected.txt: Updated.
accessibility/aria-labelledby-on-input.html: Updated.
accessibility/aria-labelledby-overrides-aria-labeledby-expected.txt: Updated.
accessibility/aria-labelledby-overrides-aria-labeledby.html: Updated.
accessibility/aria-labelledby-overrides-label-expected.txt: Updated.
accessibility/aria-labelledby-overrides-label.html: Updated.
accessibility/aria-labelledby-stay-within-expected.txt: Updated.
accessibility/aria-labelledby-stay-within.html: Updated.
accessibility/aria-labelledby-with-descendants-expected.txt: Updated.
accessibility/aria-labelledby-with-descendants.html: Updated.
accessibility/aria-namefrom-author-expected.txt: Updated.
accessibility/aria-namefrom-author.html: Updated.
accessibility/aria-text-role-expected.txt: Updated.
accessibility/aria-text-role.html: Updated.
accessibility/canvas-description-and-role-expected.txt: Updated.
accessibility/canvas-description-and-role.html: Updated.
accessibility/canvas-fallback-content.html: Updated.
accessibility/empty-image-with-title-expected.txt: Updated.
accessibility/empty-image-with-title.html: Updated.
accessibility/fieldset-element-expected.txt: Updated.
accessibility/fieldset-element.html: Updated.
accessibility/focusable-div-expected.txt: Updated.
accessibility/focusable-div.html: Updated.
accessibility/help-text.html: Updated.
accessibility/img-alt-tag-only-whitespace-expected.txt: Updated.
accessibility/img-alt-tag-only-whitespace.html: Updated.
accessibility/img-aria-button-alt-tag-expected.txt: Updated.
accessibility/img-aria-button-alt-tag.html: Updated.
accessibility/img-fallsback-to-title.html: Updated.
accessibility/input-image-alt-expected.txt: Updated.
accessibility/input-image-alt.html: Updated.
accessibility/loading-iframe-sends-notification.html: Updated.
accessibility/self-referencing-aria-labelledby-expected.txt: Updated.
accessibility/self-referencing-aria-labelledby.html: Updated.
accessibility/svg-bounds.html: Updated.
accessibility/svg-group-element-with-title-expected.txt: Updated.
accessibility/svg-group-element-with-title.html: Updated.
accessibility/svg-image-expected.txt: Updated.
accessibility/svg-image.html: Updated.
accessibility/svg-labelledby-expected.txt: Updated.
accessibility/svg-labelledby.html: Updated.
accessibility/svg-remote-element.html: Updated.
accessibility/w3c-svg-description-calculation.html: Updated.
accessibility/w3c-svg-name-calculation.html: Updated.
platform/gtk/accessibility/alt-tag-on-image-with-nonimage-role-expected.txt: Removed.
platform/gtk/accessibility/aria-labeled-with-hidden-node-expected.txt: Removed.
platform/gtk/accessibility/aria-labelledby-on-input-expected.txt: Removed.
platform/gtk/accessibility/aria-labelledby-overrides-aria-labeledby-expected.txt: Removed.
platform/gtk/accessibility/aria-labelledby-overrides-label-expected.txt: Updated.
platform/gtk/accessibility/aria-labelledby-with-descendants-expected.txt: Removed.
platform/gtk/accessibility/aria-namefrom-author-expected.txt: Removed.
platform/gtk/accessibility/aria-text-role-expected.txt: Removed.
platform/gtk/accessibility/canvas-description-and-role-expected.txt: Updated.
platform/gtk/accessibility/empty-image-with-title-expected.txt: Updated.
platform/gtk/accessibility/fieldset-element-expected.txt: Removed.
platform/gtk/accessibility/focusable-div-expected.txt: Removed.
platform/gtk/accessibility/img-alt-tag-only-whitespace-expected.txt: Removed.
platform/gtk/accessibility/img-aria-button-alt-tag-expected.txt: Removed.
platform/gtk/accessibility/img-fallsback-to-title-expected.txt: Updated.
platform/gtk/accessibility/input-image-alt-expected.txt: Removed.
platform/gtk/accessibility/self-referencing-aria-labelledby-expected.txt: Removed.
platform/gtk/accessibility/svg-group-element-with-title-expected.txt: Removed.
platform/gtk/accessibility/svg-image-expected.txt: Removed.
platform/gtk/accessibility/svg-labelledby-expected.txt: Removed.
platform/mac/accessibility/aria-help-expected.txt: Removed.
platform/mac/accessibility/aria-labelledby-overrides-label-expected.txt: Removed.
platform/mac/accessibility/canvas-description-and-role-expected.txt: Updated.
platform/mac/accessibility/fieldset-element-expected.txt: Removed.
platform/mac/accessibility/img-fallsback-to-title-expected.txt: Updated.
platform/win/accessibility/canvas-description-and-role-expected.txt: Updated.
resources/accessibility-helper.js:

(platformValueForW3CName): Added.
(platformValueForW3CDescription): Added.
(platformTextAlternatives): Added.
(platformRoleForComboBox): Added.
(platformRoleForStaticText): Added.

10:09 AM Changeset in webkit [201215] by commit-queue@webkit.org

2 edits in trunk/Tools

Use clearer names for JSON output of javascriptcore test results
https://bugs.webkit.org/show_bug.cgi?id=157921

Patch by Srinivasan Vijayaraghavan <svijayaraghavan@apple.com> on 2016-05-20
Reviewed by Alexey Proskuryakov.

"failures" and "apiTestResult" were somewhat ambiguous names.

Scripts/run-javascriptcore-tests:

(runJSCStressTests): "failures" -> "stressFailures", "apiTestResult" -> "allApiTestsPassed".

10:02 AM Changeset in webkit [201214] by Chris Dumez

2 edits in trunk/Tools

Unreviewed, fix API test introduced in r201213.

TestWebKitAPI/Tests/WTF/WeakPtr.cpp:

(TestWebKitAPI::TEST):

7:42 AM Changeset in webkit [201213] by commit-queue@webkit.org

7 edits in trunk

Implement operator== for WeakPtr
https://bugs.webkit.org/show_bug.cgi?id=157883

Patch by Rawinder Singh <rawinder.singh-webkit@cisra.canon.com.au> on 2016-05-20
Reviewed by Chris Dumez.

Implement operator== and operator!= for WeakPtr and update code to use the operators.

Source/WebCore:

page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::updateLastScrollbarUnderMouse):

page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::platformCompleteWheelEvent):

Source/WTF:

wtf/WeakPtr.h:

(WTF::operator==):
(WTF::operator!=):

Tools:

TestWebKitAPI/Tests/WTF/WeakPtr.cpp:

(TestWebKitAPI::TEST):

May 19, 2016:

11:35 PM Changeset in webkit [201212] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

REGRESSION (r200638): -[DOMHTMLVideoElement play] disappeared from ObjC bindings
https://bugs.webkit.org/show_bug.cgi?id=157940
<rdar://problem/26385907>

Reviewed by Dan Bernstein.

html/HTMLMediaElement.idl:

Drop the return value of play from the ObjC bindings, because the bindings
generator doesn't seem to know what to do with a Promise.

11:32 PM Changeset in webkit [201211] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Can't resume Debugger after breaking on exception in Promise
https://bugs.webkit.org/show_bug.cgi?id=157240
<rdar://problem/26030890>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-19
Reviewed by Timothy Hatcher.

If we pause but have no source code to show we paused in purely internal
code. In such cases we were attempting to resume without actually
telling the backend to resume, so the backend and frontend were out of
sync. The frontend thinking it is "paused" without an activeCallFrame
and the backend actually being paused.

This change more gracefully handles this situation. It actually resumes
both the frontend and the backend.

UserInterface/Controllers/DebuggerManager.js:

(WebInspector.DebuggerManager.prototype.debuggerDidPause):
Resume the backend and the frontend.

(WebInspector.DebuggerManager.prototype._didResumeInternal):
Don't look at the active call frame, look at the paused state.
This may issue a Resumed event without actually triggering a
Paused event if this was the only pause, but that is harmless.

11:31 PM Changeset in webkit [201210] by commit-queue@webkit.org

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Main Resource with <scripts> not showing up in debugger sidebar after reload
https://bugs.webkit.org/show_bug.cgi?id=157939
<rdar://problem/26385691>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-19
Reviewed by Timothy Hatcher.

The order of events on a reload are:

MainResourceChanged, add main resource
ScriptsCleared, remove all elements

This change makes it so ScriptsCleared add the main resource (and
potentially other resources). This also avoids the work in
MainResourceChanged on reloads / navigations that would be wasted if
ScriptsCleared were to just remove it. However, this is still needed
for initial load where ScriptsCleared does not happen.

UserInterface/Views/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel.prototype._mainResourceDidChange):
Only add the main resource tree here when we are first loading.

(WebInspector.DebuggerSidebarPanel.prototype._scriptsCleared):
Add the main resource tree after we remove all children in navigations.

UserInterface/Views/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel.prototype._contentTreeOutlineTreeSelectionDidChange):
This was not gracefully handling if there was no selected tree element.

9:13 PM Changeset in webkit [201209] by commit-queue@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Visual Style connectors are not always centered properly
https://bugs.webkit.org/show_bug.cgi?id=157932

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-19
Reviewed by Timothy Hatcher.

UserInterface/Views/VisualStylePropertyEditorLink.css:

(.visual-style-property-editor-link):
Remove the 1px margin on @2x that would cause jitter at different
sidebar widths. It is however needed on @1x.

(.visual-style-property-editor-link:not(.link-all)):
Make the height 20 so these both move closer to the center of the
<select> elements they are next to. They are not perfectly centered
as that would require a half pixel.

(.visual-style-property-editor-link.link-vertical):
Move the top line up a pixel so it is "up 0.5" from center and
the bottom one is already "down 0.5" from the center.

7:44 PM Changeset in webkit [201208] by commit-queue@webkit.org

21 edits in trunk/Source/JavaScriptCore

[JSC] Improve int->float conversion in FTL
https://bugs.webkit.org/show_bug.cgi?id=157936

Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-05-19
Reviewed by Filip Pizlo.

The integer -> floating point lowering was very barebone.

For example, converting a constant integer to double
was doing:

mov #const, %eax
xor %xmm0, %xmm0
cvtsi2sd %eax, %xmm0

Conversion from integer to float was also missing.
We were always converting to double then rounding the double
to float.

This patch adds the basics:
-Constant folding.
-Integer to Float opcode.
-Reducing int->double to int->float when used by DoubleToFloat.

assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::convertInt32ToFloat):

assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::convertInt64ToDouble):
(JSC::MacroAssemblerX86_64::convertInt64ToFloat):

assembler/X86Assembler.h:

(JSC::X86Assembler::cvtsi2ss_rr):
(JSC::X86Assembler::cvtsi2ssq_rr):
(JSC::X86Assembler::cvtsi2sdq_mr):
(JSC::X86Assembler::cvtsi2ssq_mr):
(JSC::X86Assembler::cvtsi2ss_mr):

assembler/MacroAssemblerARM64.h:
b3/B3Const32Value.cpp:

(JSC::B3::Const32Value::iToDConstant):
(JSC::B3::Const32Value::iToFConstant):

b3/B3Const32Value.h:
b3/B3Const64Value.cpp:

(JSC::B3::Const64Value::iToDConstant):
(JSC::B3::Const64Value::iToFConstant):

b3/B3Const64Value.h:
b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::lower):

b3/B3Opcode.cpp:

(WTF::printInternal):

b3/B3Opcode.h:
b3/B3ReduceDoubleToFloat.cpp:
b3/B3ReduceStrength.cpp:
b3/B3Validate.cpp:
b3/B3Value.cpp:

(JSC::B3::Value::iToDConstant):
(JSC::B3::Value::iToFConstant):
(JSC::B3::Value::isRounded):
(JSC::B3::Value::effects):
(JSC::B3::Value::key):
(JSC::B3::Value::typeFor):

b3/B3Value.h:
b3/B3ValueKey.cpp:

(JSC::B3::ValueKey::materialize):

b3/air/AirFixPartialRegisterStalls.cpp:
b3/air/AirOpcode.opcodes:
b3/testb3.cpp:

(JSC::B3::int64Operands):
(JSC::B3::testIToD64Arg):
(JSC::B3::testIToF64Arg):
(JSC::B3::testIToD32Arg):
(JSC::B3::testIToF32Arg):
(JSC::B3::testIToD64Mem):
(JSC::B3::testIToF64Mem):
(JSC::B3::testIToD32Mem):
(JSC::B3::testIToF32Mem):
(JSC::B3::testIToD64Imm):
(JSC::B3::testIToF64Imm):
(JSC::B3::testIToD32Imm):
(JSC::B3::testIToF32Imm):
(JSC::B3::testIToDReducedToIToF64Arg):
(JSC::B3::testIToDReducedToIToF32Arg):
(JSC::B3::run):

7:37 PM Changeset in webkit [201207] by commit-queue@webkit.org

4 edits in trunk/Source/JavaScriptCore

[JSC] FTL can crash on stack overflow
https://bugs.webkit.org/show_bug.cgi?id=157881
rdar://problem/24665964

Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-05-19
Reviewed by Michael Saboff.

The VM's m_largestFTLStackSize was never set anywhere (updateFTLLargestStackSize()
was never called). We forgot to change that when implementing B3.

Even when it is set, we still have a problem on OSR Exit.
If the last frame is a FTL frame and it OSR Exits, the space required for
that frame becomes significantly larger. What happens is we crash in the OSR Exit
instead of the FTL frame (this is what happens in rdar://problem/24665964).

This patch changes the stack boundary checks in FTL to be the same as DFG:
we verify that we have enough space for the current optimized function but
also for the baseline version (including inlining) in case of exit.

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::lower):
(JSC::FTL::DFG::LowerDFGToB3::didOverflowStack): Deleted.

runtime/VM.cpp:

(JSC::VM::VM): Deleted.
(JSC::VM::updateStackLimit): Deleted.
(JSC::VM::updateFTLLargestStackSize): Deleted.

runtime/VM.h:

(JSC::VM::addressOfFTLStackLimit): Deleted.

7:25 PM Changeset in webkit [201206] by commit-queue@webkit.org

2 edits in trunk/Tools

Add JSON results to 32-bit and CLoop JSC tests
https://bugs.webkit.org/show_bug.cgi?id=157929

Patch by Srinivasan Vijayaraghavan <svijayaraghavan@apple.com> on 2016-05-19
Reviewed by Alexey Proskuryakov.

BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunLLINTCLoopTests): Change command-line parameters to run-javascriptcore-tests in order to get JSON output.
(Run32bitJSCTests): Change command-line parameters to run-javascriptcore-tests in order to get JSON output.

6:50 PM Changeset in webkit [201205] by Chris Dumez

58 edits in trunk/Source

Improve compile-time assertions in is<>() / downcast<>()
https://bugs.webkit.org/show_bug.cgi?id=157817

Reviewed by Darin Adler.

Source/WebCore:

Add missing includes and drop unnecessary is<WebVTTElement>() check
in SharingResolver::canShareStyleWithElement() that was identified
by the new assertions. WebVTTElement inherits Element but the check
was done on a StyledElement.

accessibility/AccessibilityRenderObject.cpp:
accessibility/AccessibilitySVGElement.cpp:
css/CSSDefaultStyleSheets.cpp:
css/CSSParser.cpp:
css/CSSStyleSheet.cpp:
css/StyleResolver.cpp:
cssjit/SelectorCompiler.cpp:
dom/Document.cpp:
dom/Element.cpp:
dom/Node.cpp:
dom/Position.cpp:
editing/ApplyStyleCommand.cpp:
editing/FrameSelection.cpp:
editing/ReplaceSelectionCommand.cpp:
editing/TextIterator.cpp:
editing/VisiblePosition.cpp:
editing/VisibleUnits.cpp:
editing/cocoa/HTMLConverter.mm:
editing/htmlediting.cpp:
editing/markup.cpp:
html/GenericCachedHTMLCollection.cpp:
html/HTMLBodyElement.cpp:
html/HTMLFormElement.cpp:
html/HTMLLIElement.cpp:
html/HTMLNameCollection.cpp:
html/HTMLSelectElement.cpp:
html/parser/HTMLTreeBuilder.cpp:
inspector/InspectorDOMAgent.cpp:
inspector/InspectorStyleSheet.cpp:
loader/SubframeLoader.cpp:
loader/archive/cf/LegacyWebArchive.cpp:
mathml/MathMLElement.cpp:
page/EventHandler.cpp:
page/FrameView.cpp:
page/PageSerializer.cpp:
page/SpatialNavigation.cpp:
page/mac/EventHandlerMac.mm:
rendering/HitTestResult.cpp:
rendering/RenderBlockFlow.cpp:
rendering/RenderBox.cpp:
rendering/RenderBoxModelObject.cpp:
rendering/RenderElement.cpp:
rendering/RenderFieldset.cpp:
rendering/RenderLayer.cpp:
rendering/svg/RenderSVGTransformableContainer.cpp:
style/StyleSharingResolver.cpp:

(WebCore::Style::SharingResolver::canShareStyleWithElement):

svg/SVGAnimationElement.cpp:
svg/SVGFELightElement.cpp:
svg/SVGTextPositioningElement.cpp:

Source/WebKit2:

Add missing includes.

WebProcess/WebPage/WebFrame.cpp:
WebProcess/WebPage/WebPage.cpp:

Source/WTF:

wtf/Ref.h:

(WTF::is):
Add is<>() overloads taking a Ref<>() so that is<>() keeps working when
passing a Ref<>(), despite the new static assertions on the input type.
Some call sites were already leveraging this as it was working by
implicitly converting the Ref<T> into a T&.

wtf/TypeCasts.h:

(WTF::is):
(WTF::downcast):
Make static assertions stricter in is<>() / downcast<>() to catch more
cases where those are either unnecessary or incorrect.

6:22 PM Changeset in webkit [201204] by mmaxfield@apple.com

2 edits in trunk/LayoutTests

Test gardening after r201203

Unreviewed.

platform/ios-simulator/TestExpectations:

5:59 PM Changeset in webkit [201203] by mmaxfield@apple.com

2 edits
3 adds in trunk/LayoutTests

Add John Daggett's font variant synthesis test
https://bugs.webkit.org/show_bug.cgi?id=157935
<rdar://problem/24133521>

Reviewed by Dean Jackson.

Make sure that we continue to synthesize correctly.

css3/font-variant-synthesis-jdaggett-expected.html: Added.
css3/font-variant-synthesis-jdaggett.html: Added.
css3/resources/gsubtest-lookup3.otf: Added.
platform/mac/TestExpectations:

5:20 PM Changeset in webkit [201202] by timothy_horton@apple.com

2 edits in trunk/Source/WebKit2

Mail crashes under TiledCoreAnimationDrawingAreaProxy::createFenceForGeometryUpdate() when the Web process crashes
https://bugs.webkit.org/show_bug.cgi?id=157927
<rdar://problem/24793374>

Reviewed by Dean Jackson.

UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::createFence):
With just the right combination of layout mechanisms and Web Content process
crash timing, it is possible to get a frame change underneath WebPageProxy::processDidCrash,
before the DrawingArea has been nulled out but after the Connection has.
This can lead to a null dereference. I had a lot of trouble writing a API
test for this, though I'm certain it's possible.

4:54 PM Changeset in webkit [201201] by Alan Bujtas

6 edits in trunk/Source/WebCore

Cleanup RenderObject::container()
https://bugs.webkit.org/show_bug.cgi?id=157914

Reviewed by David Hyatt.

Now we have a dedicated method for the optional, repaintContainerSkipped branch. The container finding

logic is moved to a static inline function so the compiler can optimize out the repaintContainerSkipped branches, when
container() is called instead of container(repaintContainer, isRepaintContainerSkipped).

Use helper functions like canContainAbsolutelyPositionedObjects()
Remove stale comments.

No behaviour change.

rendering/RenderBox.cpp:

(WebCore::RenderBox::mapLocalToContainer):
(WebCore::RenderBox::pushMappingToContainer):
(WebCore::RenderBox::computeRectForRepaint):

rendering/RenderInline.cpp:

(WebCore::RenderInline::computeRectForRepaint):
(WebCore::RenderInline::mapLocalToContainer):
(WebCore::RenderInline::pushMappingToContainer):

rendering/RenderObject.cpp:

(WebCore::containerForElement):
(WebCore::RenderObject::container):

rendering/RenderObject.h:
rendering/RenderText.h:

4:48 PM Changeset in webkit [201200] by bshafiei@apple.com

19 edits
2 adds in branches/safari-602.1.32-branch

Merge r201187. rdar://problem/25314776

4:32 PM Changeset in webkit [201199] by enrica@apple.com

6 edits in trunk/Source

No candidate punctuation when typing punctuation in WK2 text field.
https://bugs.webkit.org/show_bug.cgi?id=157773
rdar://problem/23084603

Reviewed by Sam Weinig.

Source/WebCore:

We need to keep the inputManagerHint as part of the platform key event
information. Adding a new initializer for the task and a property to retrieve
the stored hint.

platform/ios/WebEvent.h:
platform/ios/WebEvent.mm:

(-[WebEvent initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers:isRepeating:withFlags:keyCode:isTabKey:characterSet:]):
(-[WebEvent initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers:isRepeating:withFlags:withInputManagerHint:keyCode:isTabKey:]):
(-[WebEvent dealloc]):
(-[WebEvent inputManagerHint]):

Source/WebKit2:

We need to adopt the new addInputString:withFlags:withInputManagerHint function
for this to work propertly.

Platform/spi/ios/UIKitSPI.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _interpretKeyEvent:isCharEvent:]):

3:58 PM Changeset in webkit [201198] by bshafiei@apple.com

11 edits
2 adds in branches/safari-602.1.32-branch

Merge r201189. rdar://problem/24577706

3:58 PM Changeset in webkit [201197] by bshafiei@apple.com

3 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI

Merge r201191. rdar://problem/26377366

3:58 PM Changeset in webkit [201196] by bshafiei@apple.com

12 edits
2 adds in branches/safari-602.1.32-branch

Merge r201183. rdar://problem/26375866

3:58 PM Changeset in webkit [201195] by beidson@apple.com

8 edits
3 adds in trunk

Finishing off: Modern IDB: Website data store management.
https://bugs.webkit.org/show_bug.cgi?id=157626

Reviewed by Alex Christensen.

Source/WebCore:

Test: storage/indexeddb/modern/new-database-after-user-delete.html

This patch does two primary things:
1 - Implements the actual "delete files on disk" code for unopened databases,

taken from existing WK2 code.

2 - When a UniqueIBDDatabase is told to close immediately for user delete, it also

queues up a "delete backing store unconditionally" operation in the database task queue.

That way, all of the open databases are deleted before the primary "delete all files"
pass, and they are also deleted before any future openDB requests are handled that might
recreate the files.

Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::getOrCreateUniqueIDBDatabase):
(WebCore::IDBServer::IDBServer::deleteDatabase):
(WebCore::IDBServer::IDBServer::closeUniqueIDBDatabase):
(WebCore::IDBServer::IDBServer::openDBRequestCancelled):
(WebCore::IDBServer::removeAllDatabasesForOriginPath):
(WebCore::IDBServer::IDBServer::performCloseAndDeleteDatabasesModifiedSince):
(WebCore::IDBServer::IDBServer::performCloseAndDeleteDatabasesForOrigins):

Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::performUnconditionalDeleteBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::doneWithHardClose):
(WebCore::IDBServer::UniqueIDBDatabase::immediateCloseForUserDelete):

Modules/indexeddb/server/UniqueIDBDatabase.h:

Source/WebKit2:

DatabaseProcess/DatabaseProcess.cpp:

(WebKit::DatabaseProcess::deleteWebsiteDataForOrigins):
(WebKit::removeAllDatabasesForOriginPath): Deleted.
(WebKit::DatabaseProcess::deleteIndexedDatabaseEntriesForOrigins): Deleted.
(WebKit::DatabaseProcess::deleteIndexedDatabaseEntriesModifiedSince): Deleted.

DatabaseProcess/DatabaseProcess.h:

LayoutTests:

storage/indexeddb/modern/new-database-after-user-delete-expected.txt: Added.
storage/indexeddb/modern/new-database-after-user-delete.html: Added.
storage/indexeddb/modern/resources/new-database-after-user-delete.js: Added.

3:55 PM Changeset in webkit [201194] by Brent Fulgham

3 edits in trunk/Source/WebKit2

[OS X][WK2] Expand sandbox for new mach endpoints
https://bugs.webkit.org/show_bug.cgi?id=157919
<rdar://problem/25238336>

Reviewed by Alexey Proskuryakov.

Grant the WebContent and Networking processes the mach lookup capability for
various Security-related mach endpoints..

Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

3:41 PM Changeset in webkit [201193] by bshafiei@apple.com

4 edits in branches/safari-602.1.32-branch/Source/JavaScriptCore

Merge r201180. rdar://problem/26129156

3:27 PM Changeset in webkit [201192] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

REGRESSION (r189385): Web Inspector: CSS properties modified via JS don't update in the Styles sidebar
https://bugs.webkit.org/show_bug.cgi?id=157918

Reviewed by Timothy Hatcher.

UserInterface/Controllers/DOMTreeManager.js:

(WebInspector.DOMTreeManager):
(WebInspector.DOMTreeManager.prototype._inlineStyleInvalidated):
(WebInspector.DOMTreeManager.prototype._loadNodeAttributes):
Set the initial value of _loadNodeAttributesTimeout to be 0,
as setTimeout always returns a positive integer.

3:25 PM Changeset in webkit [201191] by commit-queue@webkit.org

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Heap Snapshots taken before timeline view has a zero time do not get shown
https://bugs.webkit.org/show_bug.cgi?id=157923
<rdar://problem/26377366>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-19
Reviewed by Timothy Hatcher.

UserInterface/Views/HeapAllocationsTimelineDataGridNode.js:

(WebInspector.HeapAllocationsTimelineDataGridNode):
(WebInspector.HeapAllocationsTimelineDataGridNode.prototype.createCellContent):
(WebInspector.HeapAllocationsTimelineDataGridNode.prototype.updateTimestamp):
Show emDash for the timestamp if we don't yet have a zero time.
Update when we get a zero time.

UserInterface/Views/HeapAllocationsTimelineView.js:

(WebInspector.HeapAllocationsTimelineView):
(WebInspector.HeapAllocationsTimelineView.prototype.layout):
(WebInspector.HeapAllocationsTimelineView.prototype.reset):
Save a list of nodes pre-zero time and update them when we get a zero time.

3:20 PM Changeset in webkit [201190] by BJ Burg

2 edits in trunk/Source/WebKit2

Web Inspector: CRASH when closing a page while element selection mode is enabled via Develop menu
https://bugs.webkit.org/show_bug.cgi?id=157925
<rdar://problem/26259618>

Reviewed by Joseph Pecoraro.

WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::elementSelectionChanged):
Null-check m_page->inspector() since it will return nullptr if the page
is closed but not yet destructed. This is triggered by teardown code
in InspectorDOMAgent::willDestroyFrontendAndBackend.

3:19 PM Changeset in webkit [201189] by enrica@apple.com

11 edits
2 adds in trunk

Drag cannot start if no drag data is available in the Pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=157911
rdar://problem/24577706

Reviewed by Tim Horton.

Source/WebKit/mac:

WebView/WebHTMLView.mm:

(+[WebHTMLView _dummyPasteboardType]):
(-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]):

WebView/WebHTMLViewPrivate.h:
WebView/WebView.mm:

(-[WebView _registerDraggedTypes]):

Source/WebKit2:

Setting dummy data to allow drag to start.

Shared/mac/PasteboardTypes.h:
Shared/mac/PasteboardTypes.mm:
UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::registerDraggedTypes):
(WebKit::WebViewImpl::dragImageForView):

LayoutTests:

fast/events/draggable-div-nodata-expected.txt: Added.
fast/events/draggable-div-nodata.html: Added.
platform/ios-simulator/TestExpectations
platform/mac-wk2/TestExpectations

3:11 PM Changeset in webkit [201188] by beidson@apple.com

2 edits in trunk/Source/WebCore

REGRESSION(201098) GuardMalloc / ASan crashes in WebCore::IDBServer::UniqueIDBDatabase::executeNextDatabaseTaskReply
https://bugs.webkit.org/show_bug.cgi?id=157917

Reviewed by Alex Christensen.

No new tests (Covered by all existing tests in Gmalloc/ASAN configs).

Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::~UniqueIDBDatabase):
(WebCore::IDBServer::UniqueIDBDatabase::executeNextDatabaseTaskReply): Protect this from deletion before executing the task.

2:59 PM Changeset in webkit [201187] by jer.noble@apple.com

19 edits
2 adds in trunk

[IOS] Add setting to allow playback to continue inline after exiting fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=157912

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-fullscreen-return-to-inline.html

Allow playback to continue when exiting fullscreen via settings.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::exitFullscreen):

page/Settings.in:

Source/WebKit/mac:

Add a preference to control whether media should be allowed to continue playing inline when
exiting fullscreen.

WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences allowsInlineMediaPlaybackAfterFullscreen]):
(-[WebPreferences setAllowsInlineMediaPlaybackAfterFullscreen:]):

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

Add a preference and configuration property to control whether media should be allowed to continue
playing inline when exiting fullscreen.

Shared/WebPreferencesDefinitions.h:
UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):

UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]):
(-[WKWebViewConfiguration encodeWithCoder:]):
(-[WKWebViewConfiguration initWithCoder:]):
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _allowsInlineMediaPlaybackAfterFullscreen]):
(-[WKWebViewConfiguration _setAllowsInlineMediaPlaybackAfterFullscreen:]):

UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
UIProcess/mac/WKFullScreenWindowController.mm:

(disableScreenUpdates):
(enableScreenUpdates):
(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):
(-[WKFullScreenWindowController exitFullScreen]):
(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:finalFrame:]):
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
(-[WKFullScreenWindowController completeFinishExitFullScreenAnimationAfterRepaint]):
(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]):
(-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

LayoutTests:

media/media-fullscreen-return-to-inline-expected.txt: Added.
media/media-fullscreen-return-to-inline.html: Added.
media/video-test.js:

(runWithKeyDown.eventName.window.testRunner.eventSender.keyDown.string_appeared_here.string_appeared_here.thunk):
(runWithKeyDown):

2:51 PM Changeset in webkit [201186] by hyatt@apple.com

2 edits in trunk/Source/WebCore

Fix childrenInline() check in markAllDescendantsWithFloatsForLayout()
https://bugs.webkit.org/show_bug.cgi?id=157866

Reviewed by Zalan Bujtas.

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::markAllDescendantsWithFloatsForLayout):

2:46 PM Changeset in webkit [201185] by fpizlo@apple.com

2 edits in trunk/Source/WTF

Unreviewed, fix all of the builds. I failed a second time.

wtf/BackwardsGraph.h:

(WTF::BackwardsGraph::rootName):

2:44 PM Changeset in webkit [201184] by fpizlo@apple.com

2 edits in trunk/Source/WTF

Unreviewed, fix all of the builds. I had made an additional change that I did not mean to
commit. This fixes it.

wtf/BackwardsGraph.h:

(WTF::BackwardsGraph::rootName):
(WTF::BackwardsGraph::Set::dump):
(WTF::BackwardsGraph::dump):

2:30 PM Changeset in webkit [201183] by commit-queue@webkit.org

12 edits
2 adds in trunk

Web Inspector: HeapSnapshot Instances view should remove dead objects
https://bugs.webkit.org/show_bug.cgi?id=157920
<rdar://problem/26375866>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-19
Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

UserInterface/Workers/HeapSnapshot/HeapSnapshotWorker.js:

(HeapSnapshotWorker):
(HeapSnapshotWorker.prototype.clearSnapshots):
(HeapSnapshotWorker.prototype.createSnapshot):
Preserve a list of snapshots for this page's session. When
new snapshots come in we can determine which nodes have died
and update previous snapshots. Emit a CollectionEvent
containing the nodes that were deleted and affected snapshots.

UserInterface/Workers/HeapSnapshot/HeapSnapshot.js:

(HeapSnapshot):
Stash the largest node identifier.
Create a byte-per-node list to mark it as dead or alive.
All snapshots start with all live nodes.

(HeapSnapshot.prototype.updateDeadNodesAndGatherCollectionData):
(HeapSnapshot.prototype._markDeadNodes):
When we get a new snapshot we can mark dead nodes in previous
snapshots. Determine the nodeIdentifiers of dead nodes, and
mark them as dead if they existed in previous snapshots.

(HeapSnapshot.buildCategories):
(HeapSnapshot.prototype.updateCategories):
(HeapSnapshotDiff.prototype.updateCategories):
Include a "deadCount" in category data. And provide a method
to return an updated category list.

(HeapSnapshot.prototype.serializeNode):
Include a "dead" property on nodes when they are first fetched.

UserInterface/Proxies/HeapSnapshotDiffProxy.js:

(WebInspector.HeapSnapshotDiffProxy.prototype.updateForCollectionEvent):
(WebInspector.HeapSnapshotDiffProxy.prototype.updateCategories):

UserInterface/Proxies/HeapSnapshotNodeProxy.js:

(WebInspector.HeapSnapshotNodeProxy):
(WebInspector.HeapSnapshotNodeProxy.deserialize):

UserInterface/Proxies/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotProxy.prototype.updateForCollectionEvent):
(WebInspector.HeapSnapshotProxy.prototype.updateCategories):
Update snapshot proxies from a collection event by updating properties
and dispatching an event from the model object.

UserInterface/Proxies/HeapSnapshotWorkerProxy.js:

(WebInspector.HeapSnapshotWorkerProxy):
(WebInspector.HeapSnapshotWorkerProxy.prototype.clearSnapshots):
(WebInspector.HeapSnapshotWorkerProxy.prototype._mainResourceDidChange):
Clear the session snapshot list when the main resource changes.
However we can't yet clear the HeapSnapshot objects on the worker
because we may still have UI that interact with them.

UserInterface/Views/HeapAllocationsTimelineView.js:

(WebInspector.HeapAllocationsTimelineView):
(WebInspector.HeapAllocationsTimelineView.prototype.closed):
Register and unregister for HeapSnapshot collection events.

(WebInspector.HeapAllocationsTimelineView.prototype._heapSnapshotCollectionEvent.updateHeapSnapshotForEvent):
(WebInspector.HeapAllocationsTimelineView.prototype._heapSnapshotCollectionEvent):
Update all the snapshots we know about when a collection event happens.

UserInterface/Views/HeapSnapshotClassDataGridNode.js:

(WebInspector.HeapSnapshotClassDataGridNode.prototype.removeCollectedNodes):
(WebInspector.HeapSnapshotClassDataGridNode.prototype.updateCount):
(WebInspector.HeapSnapshotClassDataGridNode.prototype._populate):
(WebInspector.HeapSnapshotClassDataGridNode.prototype._fetchBatch):

UserInterface/Views/HeapSnapshotContentView.js:

(WebInspector.HeapSnapshotContentView.prototype._heapSnapshotDataGridTreeDidPopulate):
(WebInspector.HeapSnapshotContentView):

UserInterface/Views/HeapSnapshotDataGridTree.js:

(WebInspector.HeapSnapshotDataGridTree):
(WebInspector.HeapSnapshotDataGridTree.prototype.removeChild):
(WebInspector.HeapSnapshotDataGridTree.prototype.removeCollectedNodes):
(WebInspector.HeapSnapshotDataGridTree.prototype._heapSnapshotCollectedNodes):
(WebInspector.HeapSnapshotInstancesDataGridTree.prototype.populateTopLevel):
(WebInspector.HeapSnapshotInstancesDataGridTree.prototype.removeCollectedNodes):
(WebInspector.HeapSnapshotInstancesDataGridTree):
Update the Instances DataGridTree UI when a collection event happens.
Remove any top level InstanceDataGridNodes that may be showing for collected nodes.
Update the category counts on the ClassDataGridNodes.
Update FetchMoreDataGridNodes to have updated counts (and replace removed nodes).

LayoutTests:

inspector/unit-tests/heap-snapshot-collection-event-expected.txt: Added.
inspector/unit-tests/heap-snapshot-collection-event.html: Added.

2:25 PM Changeset in webkit [201182] by fpizlo@apple.com

28 edits
14 adds in trunk

DFG::LICMPhase shouldn't hoist type checks unless it knows that the check will succeed at the loop pre-header
https://bugs.webkit.org/show_bug.cgi?id=144527

Reviewed by Saam Barati.

Source/JavaScriptCore:

This adds a control flow equivalence analysis (called ControlEquivalenceAnalysis) based on
dominator analysis over the backwards CFG. Two basic blocks are control flow equivalent if
the execution of one implies that the other one must also execute. It means that the two
blocks' forward and backward dominance are reciprocated: (A dom B and B backdom A) or (B dom
A and A backdom B). LICM now uses it to become more conservative about hoisting checks, if
this has caused problems in the past. If we hoist something that may exit from a block that
was not control equivalent to the pre-header then it's possible that the node's speculation
will fail even though it wouldn't have if it wasn't hoisted. So, we flag these nodes'
origins as being "wasHoisted" and we track all of their exits as "HoistingFailed". LICM will
turn off such speculative hoisting if the CodeBlock from which we are hoisting had the
HoistingFailed exit kind.

Note that this deliberately still allows us to hoist things that may exit even if they are
not control equivalent to the pre-header. This is necessary because the profitability of
hoisting is so huge in all of the cases that we're aware of that it's worth giving it a
shot.

This is neutral on macrobenchmarks since none of the benchmarks we track have a hoistable
operation that would exit only if hoisted. I added microbenchmarks to illustrate the problem
and two of them speed up by ~40% while one of them is neutral (Int52 saves us from having
problems on that program even though LICM previously did the wrong thing).

JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/ExitKind.cpp:

(JSC::exitKindToString):

bytecode/ExitKind.h:
dfg/DFGAtTailAbstractState.h:

(JSC::DFG::AtTailAbstractState::operator bool):
(JSC::DFG::AtTailAbstractState::initializeTo):

dfg/DFGBackwardsCFG.h: Added.

(JSC::DFG::BackwardsCFG::BackwardsCFG):

dfg/DFGBackwardsDominators.h: Added.

(JSC::DFG::BackwardsDominators::BackwardsDominators):

dfg/DFGCommon.h:

(JSC::DFG::checkAndSet): Deleted.

dfg/DFGControlEquivalenceAnalysis.h: Added.

(JSC::DFG::ControlEquivalenceAnalysis::ControlEquivalenceAnalysis):
(JSC::DFG::ControlEquivalenceAnalysis::dominatesEquivalently):
(JSC::DFG::ControlEquivalenceAnalysis::areEquivalent):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::dumpBlockHeader):
(JSC::DFG::Graph::invalidateCFG):
(JSC::DFG::Graph::substituteGetLocal):
(JSC::DFG::Graph::handleAssertionFailure):
(JSC::DFG::Graph::ensureDominators):
(JSC::DFG::Graph::ensurePrePostNumbering):
(JSC::DFG::Graph::ensureNaturalLoops):
(JSC::DFG::Graph::ensureBackwardsCFG):
(JSC::DFG::Graph::ensureBackwardsDominators):
(JSC::DFG::Graph::ensureControlEquivalenceAnalysis):
(JSC::DFG::Graph::methodOfGettingAValueProfileFor):

dfg/DFGGraph.h:

(JSC::DFG::Graph::hasDebuggerEnabled):

dfg/DFGInPlaceAbstractState.h:

(JSC::DFG::InPlaceAbstractState::operator bool):
(JSC::DFG::InPlaceAbstractState::createValueForNode):
(JSC::DFG::InPlaceAbstractState::forNode):

dfg/DFGLICMPhase.cpp:

(JSC::DFG::LICMPhase::run):
(JSC::DFG::LICMPhase::attemptHoist):

dfg/DFGMayExit.cpp:

(JSC::DFG::mayExit):

dfg/DFGMayExit.h:
dfg/DFGNode.h:
dfg/DFGNodeOrigin.cpp:

(JSC::DFG::NodeOrigin::dump):

dfg/DFGNodeOrigin.h:

(JSC::DFG::NodeOrigin::takeValidExit):
(JSC::DFG::NodeOrigin::withWasHoisted):
(JSC::DFG::NodeOrigin::forInsertingAfter):

dfg/DFGNullAbstractState.h: Added.

(JSC::DFG::NullAbstractState::NullAbstractState):
(JSC::DFG::NullAbstractState::operator bool):
(JSC::DFG::NullAbstractState::forNode):

dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::OSRExit):

dfg/DFGOSRExitBase.cpp:

(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSiteSlow):

dfg/DFGOSRExitBase.h:

(JSC::DFG::OSRExitBase::OSRExitBase):

dfg/DFGTypeCheckHoistingPhase.cpp:

(JSC::DFG::TypeCheckHoistingPhase::run):

ftl/FTLOSRExit.cpp:

(JSC::FTL::OSRExitDescriptor::prepareOSRExitHandle):
(JSC::FTL::OSRExit::OSRExit):

ftl/FTLOSRExit.h:

Source/WTF:

This adds an adaptor for graphs called BackwardsGraph. The WTF graph framework is based on
passing around a Graph template argument that follows the protocol shared by DFG::CFG,
B3::CFG, and Air::CFG. These graphs always have a single root node but may have many leaf
nodes. This new BackwardsGraph adaptor reverses the graph by creating a synthetic return
node that it uses as the root in the inverted graph. This currently may resort to some
heuristics in programs that have an infinite loop, but other than that, it'll work well in
the general case.

This allows us to say Dominators<BackwardsGraph<some graph type>> as a way of computing
backwards dominators, which then allows us to easily answer control flow equivalence
queries.

CMakeLists.txt:
WTF.xcodeproj/project.pbxproj:
wtf/BackwardsGraph.h: Added.

(WTF::BackwardsGraph::Node::Node):
(WTF::BackwardsGraph::Node::root):
(WTF::BackwardsGraph::Node::operator==):
(WTF::BackwardsGraph::Node::operator!=):
(WTF::BackwardsGraph::Node::operator bool):
(WTF::BackwardsGraph::Node::isRoot):
(WTF::BackwardsGraph::Node::node):
(WTF::BackwardsGraph::Set::Set):
(WTF::BackwardsGraph::Set::add):
(WTF::BackwardsGraph::Set::remove):
(WTF::BackwardsGraph::Set::contains):
(WTF::BackwardsGraph::Set::dump):
(WTF::BackwardsGraph::Map::Map):
(WTF::BackwardsGraph::Map::clear):
(WTF::BackwardsGraph::Map::size):
(WTF::BackwardsGraph::Map::operator[]):
(WTF::BackwardsGraph::BackwardsGraph):
(WTF::BackwardsGraph::root):
(WTF::BackwardsGraph::newMap):
(WTF::BackwardsGraph::successors):
(WTF::BackwardsGraph::predecessors):
(WTF::BackwardsGraph::index):
(WTF::BackwardsGraph::node):
(WTF::BackwardsGraph::numNodes):
(WTF::BackwardsGraph::dump):

wtf/Dominators.h:

(WTF::Dominators::Dominators):
(WTF::Dominators::dump):
(WTF::Dominators::LengauerTarjan::computeDepthFirstPreNumbering):

wtf/GraphNodeWorklist.h:

(WTF::GraphNodeWith::GraphNodeWith):
(WTF::GraphNodeWith::operator bool):

wtf/StdLibExtras.h:

(WTF::callStatelessLambda):
(WTF::checkAndSet):

LayoutTests:

Add tests for LICM hoisting things that would only exit if hoisted.

js/regress/licm-dragons-expected.txt: Added.
js/regress/licm-dragons-out-of-bounds-expected.txt: Added.
js/regress/licm-dragons-out-of-bounds.html: Added.
js/regress/licm-dragons-overflow-expected.txt: Added.
js/regress/licm-dragons-overflow.html: Added.
js/regress/licm-dragons.html: Added.
js/regress/script-tests/licm-dragons-out-of-bounds.js: Added.

(foo):

js/regress/script-tests/licm-dragons-overflow.js: Added.

(foo):

js/regress/script-tests/licm-dragons.js: Added.

(foo):

2:11 PM Changeset in webkit [201181] by BJ Burg

2 edits in trunk/LayoutTests

Web Inspector: use a consistent prefix for injected scripts
https://bugs.webkit.org/show_bug.cgi?id=157715
<rdar://problem/26287188>

Reviewed by Alexey Proskuryakov.

Follow-up fix to an affected test.

inspector/debugger/scriptParsed.html:

Check whether the script is for CommandLineAPIModuleSource before
checking whether it is an InjectedScript. With the new naming scheme,
the latter is a subset of the former, so do the more specific check first.

2:02 PM Changeset in webkit [201180] by mark.lam@apple.com

4 edits in trunk/Source/JavaScriptCore

Code that null checks the VM pointer before any use should ref the VM.
https://bugs.webkit.org/show_bug.cgi?id=157864

Reviewed by Filip Pizlo and Keith Miller.

JSLock::willReleaseLock() and HeapTimer::timerDidFire() need to reference the VM
through a RefPtr. Otherwise, there's no guarantee that the VM won't be deleted
after their null checks.

bytecode/CodeBlock.h:

(JSC::CodeBlock::vm):
(JSC::CodeBlock::setVM): Deleted.

Not used, and suggests that it can be changed during the lifetime of the CodeBlock (which should not be).

heap/HeapTimer.cpp:

(JSC::HeapTimer::timerDidFire):

runtime/JSLock.cpp:

(JSC::JSLock::willReleaseLock):

Store the VM pointer in a RefPtr first, and null check the RefPtr instead of the raw VM pointer. This makes the null check a strong guarantee that the VM pointer is valid while these functions are using it.

1:40 PM Changeset in webkit [201179] by bshafiei@apple.com

5 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI

Merge r201177. rdar://problem/26373969

1:23 PM Changeset in webkit [201178] by timothy@apple.com

2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION: Search magnifying glass shifted in Search tab input field
https://bugs.webkit.org/show_bug.cgi?id=157913
rdar://problem/26374424

Reviewed by Joseph Pecoraro.

UserInterface/Views/SearchSidebarPanel.css:

(.sidebar > .panel.navigation.search > .search-bar > input[type="search"]): Removed padding-left.
(.sidebar > .panel.navigation.search > .search-bar > input[type="search"]::-webkit-search-results-button):
Added. Add margin-right here instead.

1:22 PM Changeset in webkit [201177] by timothy@apple.com

5 edits in trunk/Source/WebInspectorUI

Web Inspector: Timelines "Edit" button should be right-aligned
https://bugs.webkit.org/show_bug.cgi?id=157909
rdar://problem/26373969

Reviewed by Joseph Pecoraro.

UserInterface/Views/ButtonNavigationItem.css:

(.navigation-bar .item.button.text-only): Deleted height: auto. Now inherited.

UserInterface/Views/NavigationBar.css:

(.navigation-bar .item): Change height to auto to support any NavigationBar height.
This is needed since the Timelines tab has a shorter NavigationBar height, and
flexible items were overflowing.

UserInterface/Views/TextNavigationItem.css:

(.navigation-bar .item.text): Deleted height: auto. Now inherited.

UserInterface/Views/TimelineOverview.js:

(WebInspector.TimelineOverview): Add a FlexibleSpaceNavigationItem before the Edit button.

1:09 PM Changeset in webkit [201176] by sbarati@apple.com

3 edits in trunk/Source/JavaScriptCore

arrow function lexical environment should reuse the same environment as the function's lexical environment where possible
https://bugs.webkit.org/show_bug.cgi?id=157908

Reviewed by Filip Pizlo.

We can safely combine these two environment when we have
a simple parameter list (no default parameters, no destructring parameters).

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::initializeDefaultParameterValuesAndSetupFunctionScopeStack):
(JSC::BytecodeGenerator::initializeArrowFunctionContextScopeIfNeeded):

bytecompiler/BytecodeGenerator.h:

12:15 PM Changeset in webkit [201175] by Csaba Osztrogonác

2 edits in trunk/Tools

Typo fix in import-test262-tests
https://bugs.webkit.org/show_bug.cgi?id=157902

Reviewed by Keith Miller.

Scripts/import-test262-tests:

12:09 PM Changeset in webkit [201174] by Chris Dumez

5 edits in trunk/Source/WebCore

Update RenderBlockFlow::adjustComputedFontSizes() to use RenderObjectTraversal
https://bugs.webkit.org/show_bug.cgi?id=157784

Reviewed by Zalan Bujtas.

Update RenderBlockFlow::adjustComputedFontSizes() to use RenderObjectTraversal
instead of having its own Renderer tree traversal API, specifically for iOS
text autosizing.

rendering/RenderBlockFlow.cpp:

(WebCore::isVisibleRenderText):
(WebCore::resizeTextPermitted):
(WebCore::isNonBlocksOrNonFixedHeightListItems):
(WebCore::RenderBlockFlow::adjustComputedFontSizes):

rendering/RenderIterator.h:

(WebCore::RenderObjectTraversal::nextSkippingChildren):

rendering/RenderObject.cpp:

(WebCore::RenderObject::traverseNext): Deleted.
(WebCore::RenderObject::enclosingBox): Deleted.
(WebCore::RenderObject::enclosingBoxModelObject): Deleted.
(WebCore::RenderObject::fixedPositionedWithNamedFlowContainingBlock): Deleted.
(WebCore::hasFixedPosInNamedFlowContainingBlock): Deleted.
(WebCore::RenderObject::firstLineBlock): Deleted.
(WebCore::objectIsRelayoutBoundary): Deleted.

rendering/RenderObject.h:

11:50 AM Changeset in webkit [201173] by Csaba Osztrogonác

3 edits in trunk/Source/WebCore

Fix the build with GCC 4.9 in CSSParser.cpp
https://bugs.webkit.org/show_bug.cgi?id=157887

Reviewed by Chris Dumez.

css/CSSParser.cpp:

(WebCore::CSSParser::createViewportRule):

css/CSSParser.h:

11:39 AM Changeset in webkit [201172] by msaboff@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed build fix.

Skipping this new test as it times out on the bots.

Issue tracked in https://bugs.webkit.org/show_bug.cgi?id=157903

tests/stress/regress-157595.js:

(MyRegExp):

10:58 AM Changeset in webkit [201171] by BJ Burg

11 edits in trunk/Source

Web Inspector: timelines should not update via requestAnimationFrame unless Web Inspector is visible
https://bugs.webkit.org/show_bug.cgi?id=157897
<rdar://problem/26330802>

Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

The timelines overview tries to animate using requestAnimationFrame, even if the
inspector frontend is not really visible. When it does this, requestAnimationFrame
simply stalls out until the inspector becomes visible. If a recording is started
while the inspector is not visible, then when it is shown again, the timeline will
start to animate from 0s instead of the current time. This happens because the
requestAnimationFrame was requested when the current time actually was 0, and it
finally executes some time later, when the current time is no longer accurate.
Since the timelines animate by calculating time elapsed since the previous frame
rather than using event timestamps, there is no way for the timelines to skip forward
in their animations in scenarios where the current time becomes arbitrarily skewed.

To fix this, consider the visibility state of the frontend as reported by the UIProcess.
Fire a global notification when visibility state changes, and start or stop updating
the current time as the frontend becomes visible or not shown.

This does not affect most other uses of requestAnimationFrame, which are used as
timers to call updateLayout at an appropriate time. The timelines case is different
because the current time is fixed prior to requesting an animation frame, and
later animation frames are only triggered by earlier requests, so there's nothing to
coalesce.

UserInterface/Base/Main.js:

(WebInspector.loaded): Initialize WebInspector.visible.

UserInterface/Base/Object.js: Add new event.

UserInterface/Protocol/InspectorFrontendAPI.js:

(InspectorFrontendAPI.setIsVisible): Added.

UserInterface/Test/Test.js:

(WebInspector.updateVisibilityState): Add a stub.

UserInterface/Views/TimelineRecordingContentView.js:

(WebInspector.TimelineRecordingContentView):
(WebInspector.TimelineRecordingContentView.prototype._inspectorVisibilityStateChanged):
If visibility state changes while capturing, then start or stop updating the
current time as appropriate. Otherwise, refresh the timelines with updated
times so that they know about the recording's updated start/current/end time.

(WebInspector.TimelineRecordingContentView.prototype._startUpdatingCurrentTime):
Bail out if the Web Inspector frontend is not visible to the user and won't be
able to service requestAnimationFrames immediately.

Source/WebKit2:

The UIProcess needs to notify the Inspector frontend when it is truly visible.
The frontend can't use document.visibilityState because it doesn't seem to work
if the inspector frontend's WKWebView is created but not attached to a window.

UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::open):
(WebKit::WebInspectorProxy::didClose):
Send visibility updates to the inspector process when the inspector becomes
"visible" or "not visible". It becomes visible if it is attached to the
inspected page's window, or gets its own native window.

WebProcess/WebPage/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::frontendLoaded):
(WebKit::WebInspectorUI::setDockingUnavailable):
(WebKit::WebInspectorUI::setIsVisible):
Call InspectorFrontendAPI.updateVisibilityState to let the frontend know.

WebProcess/WebPage/WebInspectorUI.h:
WebProcess/WebPage/WebInspectorUI.messages.in:

Add new message.

10:27 AM Changeset in webkit [201170] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

JSC: DFG::SpeculativeJIT::compile special case for MIPS for PutByValWithThis
https://bugs.webkit.org/show_bug.cgi?id=157741

Patch by Guillaume Emont <guijemont@igalia.com> on 2016-05-19
Reviewed by Saam Barati.

The PutByValWithThis case needs a special case for MIPS because we
don't have enough registers. The special case needs to be different
from the x86 one because we have a different ABI.

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

10:11 AM Changeset in webkit [201169] by Csaba Osztrogonác

2 edits in trunk/Tools

[EFL] Fix the gst-libav build on ARM Thumb2 after r199649
https://bugs.webkit.org/show_bug.cgi?id=157893

Reviewed by Antonio Gomes.

efl/patches/gst-libav.patch:

9:48 AM Changeset in webkit [201168] by BJ Burg

16 edits in trunk

Web Inspector: use a consistent prefix for injected scripts
https://bugs.webkit.org/show_bug.cgi?id=157715
<rdar://problem/26287188>

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

CMakeLists.txt:
DerivedSources.make:
inspector/InjectedScriptSource.js:

Source/WebCore:

CMakeLists.txt:
DerivedSources.make:
inspector/CommandLineAPIModuleSource.js:

Source/WebKit2:

CMakeLists.txt:
DerivedSources.make:
WebProcess/Automation/WebAutomationSessionProxy.js:

LayoutTests:

Update how inspector tests check sourceURLs for internal scripts.

inspector/debugger/scriptParsed.html:
inspector/debugger/sourceURLs.html:

9:22 AM Changeset in webkit [201167] by jer.noble@apple.com

4 edits in trunk/Source/WebCore

Playback controls should not be active for muted media elements.
https://bugs.webkit.org/show_bug.cgi?id=157876
<rdar://problem/26007525>

Reviewed by Eric Carlson.

Consolidate calls to setUpPlaybackControlsManager() and clearUpPlaybackControlsManager()
into a new method, updatePlaybackControlsManager(), which checks with the MediaElementSession
whether the media element can currently control the playback controls manager, and call
one or the other method conditionally.

That means more logic needs to be moved into MediaElementSession::canControlControlsManager(),
such as whether the element is muted(), has ended(), or whether the element's document has
been suspended.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::setMuted):
(WebCore::HTMLMediaElement::updatePlayState):
(WebCore::HTMLMediaElement::clearMediaPlayer):
(WebCore::HTMLMediaElement::stopWithoutDestroyingMediaPlayer):
(WebCore::HTMLMediaElement::createMediaPlayer):
(WebCore::HTMLMediaElement::updatePlaybackControlsManager):

html/HTMLMediaElement.h:
html/MediaElementSession.cpp:

(WebCore::MediaElementSession::canControlControlsManager):

9:11 AM Changeset in webkit [201166] by Chris Dumez

26 edits in trunk/Source/WebCore

Kill JSDOMBindings' createNewWrapper()
https://bugs.webkit.org/show_bug.cgi?id=157842

Reviewed by Youenn Fablet.

Kill JSDOMBindings' createNewWrapper() as it is identical to createWrapper().

bindings/js/JSDOMBinding.h:

(WebCore::createNewWrapper): Deleted.

bindings/js/JSDocumentFragmentCustom.cpp:

(WebCore::toJSNewlyCreated):

bindings/js/JSNodeListCustom.cpp:

(WebCore::createWrapper):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestGlobalObject.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestNondeterministic.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSattribute.cpp:

(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSreadonly.cpp:

(WebCore::toJSNewlyCreated):

9:07 AM Changeset in webkit [201165] by jer.noble@apple.com

2 edits in trunk/Tools

REGRESSION(r200951): VideoControlsManager API tests time out
https://bugs.webkit.org/show_bug.cgi?id=157896
<rdar://problem/26326293>

Reviewed by Eric Carlson.

Explicitly disable user gesture requirements for playback.

TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:

(TestWebKitAPI::TEST):

9:03 AM Changeset in webkit [201164] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

Playback controls still valid after navigating back after watching YouTube video.
https://bugs.webkit.org/show_bug.cgi?id=157874
<rdar://problem/25993063>

Reviewed by Eric Carlson.

YouTube uses window.onpopstate to "navigate" backwards from a video page to the main page
(or other video page). This causes the playback controls to not be cleared (since no
navigation actually occured). Instead, clear the playback controls when we clear our
MediaPlayer due to load() being called, when the src= attribute is changed, or when a
<source> element is added to the <video>.

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::clearMediaPlayer):
(WebCore::HTMLMediaElement::createMediaPlayer):

7:33 AM Changeset in webkit [201163] by Philippe Normand

4 edits in trunk/Source/WebCore

[GStreamer] unrelated codecs required to play videos
https://bugs.webkit.org/show_bug.cgi?id=135972

Reviewed by Michael Catanzaro.

Instead of hard-coding the list of supported mime-types, check the
decoder and demuxer GStreamer elements available and dynamically
build the list of mime-types accordingly. This patch also removes
support for under-used and exotic mime-types.

Based on a patch by Mario Sanchez Prada.

No new tests, existing media tests cover this change.

platform/graphics/gstreamer/GStreamerUtilities.cpp:

(WebCore::gstRegistryHasElementForMediaType): New function
checking the elements registered in the factories have a sink pad
matching the caps specified as second argument of the function.

platform/graphics/gstreamer/GStreamerUtilities.h:
platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::mimeTypeSet): Hard-coded list of mime-types replaced by
runtime-built list of mime-types that can be supported by the
GStreamer decoders and demuxers available on the host machine.
(WebCore::MediaPlayerPrivateGStreamer::getSupportedTypes):
mimeTypeCache renamed to mimeTypeSet.
(WebCore::MediaPlayerPrivateGStreamer::supportsType): Ditto.

7:19 AM Changeset in webkit [201162] by Csaba Osztrogonác

2 edits in trunk/Source/WebCore

[ARM] Fix Wformat warning in MemoryPressureHandler.cpp
https://bugs.webkit.org/show_bug.cgi?id=157892

Reviewed by Michael Saboff.

platform/MemoryPressureHandler.cpp:

(WebCore::MemoryPressureHandler::ReliefLogger::logMemoryUsageChange):

7:19 AM Changeset in webkit [201161] by Csaba Osztrogonác

3 edits in trunk/Source/JavaScriptCore

[ARM] Remove redefined macro after r200606
https://bugs.webkit.org/show_bug.cgi?id=157890

Reviewed by Michael Saboff.

bytecode/PolymorphicAccess.cpp:
jit/CCallHelpers.h:

7:15 AM Changeset in webkit [201160] by youenn.fablet@crf.canon.fr

2 edits in trunk/Source/WebCore

Remove castDOMMobjectForWrapperCreation(T&)
https://bugs.webkit.org/show_bug.cgi?id=157886

Reviewed by Andreas Kling.

No change of behavior.

bindings/js/JSDOMBinding.h:

(WebCore::castDOMObjectForWrapperCreation): Deleted.

6:22 AM Changeset in webkit [201159] by Antti Koivisto

7 edits in trunk

Style resolution for explicitly inherited properties is inefficient
https://bugs.webkit.org/show_bug.cgi?id=157860

Reviewed by Andreas Kling.

Source/WebCore:

We mark the parent style with hasExplicitlyInheritedProperties bit rather than the style that is actually
affected by inherited properties. This leads to various inefficiencies including unnecessarily wide style recalcs.

css/StyleResolver.cpp:

(WebCore::isCacheableInMatchedPropertiesCache):

Check the style itself rather than the parent. This allows more caching.

(WebCore::StyleResolver::applyProperty):

Mark the style rather than the parent.

style/StyleChange.cpp:

(WebCore::Style::determineChange):

Remove hasExplicitlyInheritedProperties test and just return NoInherit. Having explicitly inherited
properties doesn't make the children inherit them automatically.

This allows smaller style recalcs.

style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolveElement):

This patch exposed a bug with appearance property in meter and progress elements.
They may construct different renderer based on appearance so we need to force
render tree reconstruction when it changes.

(WebCore::Style::TreeResolver::popParentsToDepth):
(WebCore::Style::shouldResolvePseudoElement):

Don't clear the style recalc bits here.

(WebCore::Style::shouldResolveElement):

Add a helper.
If the parent had a NoInherit style change, test if the element has existing style with
hasExplicitlyInheritedProperties bit. If so we need to re-resolve this element.

(WebCore::Style::clearNeedsStyleResolution):

Also clear pseudo elements.

(WebCore::Style::TreeResolver::resolveComposedTree):

LayoutTests:

platform/ios-simulator/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:

This is a progression.

5:03 AM Changeset in webkit [201158] by Csaba Osztrogonác

3 edits in trunk/Tools

Slow JSC stress tests times out in 32 bit debug mode
https://bugs.webkit.org/show_bug.cgi?id=154964

Reviewed by Michael Catanzaro.

Scripts/run-javascriptcore-tests:

(runJSCStressTests): Pass through the --debug option.

Scripts/run-jsc-stress-tests: Increase the timeout for debug builds.

2:36 AM Changeset in webkit [201157] by bshafiei@apple.com

3 edits in branches/safari-602.1.32-branch/Source/WebKit2

Merge r201110. rdar://problem/25730174

2:36 AM Changeset in webkit [201156] by bshafiei@apple.com

2 edits in branches/safari-602.1.32-branch/Source/WebKit2

Merge r201016. rdar://problem/25584201

2:36 AM Changeset in webkit [201155] by bshafiei@apple.com

2 edits in branches/safari-602.1.32-branch/Tools

Merge r200978. rdar://problem/25584201

2:35 AM Changeset in webkit [201154] by bshafiei@apple.com

10 edits in branches/safari-602.1.32-branch

Merge r200951. rdar://problem/25584201

1:41 AM Changeset in webkit [201153] by bshafiei@apple.com

4 edits in branches/safari-602.1.32-branch/Source/WebCore

Merge r201119. rdar://problem/26225793

1:41 AM Changeset in webkit [201152] by bshafiei@apple.com

2 edits in branches/safari-602.1.32-branch/Source/WebCore

Merge r201103. rdar://problem/26339922

1:41 AM Changeset in webkit [201151] by bshafiei@apple.com

3 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI

Merge r201102. rdar://problem/26339922

1:41 AM Changeset in webkit [201150] by bshafiei@apple.com

2 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI

Merge r201092. rdar://problem/26349229

1:41 AM Changeset in webkit [201149] by bshafiei@apple.com

2 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI

Merge r200661.

1:41 AM Changeset in webkit [201148] by bshafiei@apple.com

11 edits
2 adds in branches/safari-602.1.32-branch

Merge r200651. rdar://problem/26188642

1:40 AM Changeset in webkit [201147] by bshafiei@apple.com

14 edits
3 adds in branches/safari-602.1.32-branch

Merge r201090. rdar://problem/26334636

1:40 AM Changeset in webkit [201146] by bshafiei@apple.com

4 edits in branches/safari-602.1.32-branch/Source/WebKit2

Merge r201079. rdar://problem/26334648

1:40 AM Changeset in webkit [201145] by bshafiei@apple.com

12 edits in branches/safari-602.1.32-branch

Merge r201065. rdar://problem/26333137

1:40 AM Changeset in webkit [201144] by bshafiei@apple.com

3 edits in branches/safari-602.1.32-branch/Source/WebCore

Merge r201043. rdar://problem/25835802

1:40 AM Changeset in webkit [201143] by bshafiei@apple.com

2 edits in branches/safari-602.1.32-branch/Source/WebKit2

Merge r200961. rdar://problem/25984480

1:40 AM Changeset in webkit [201142] by bshafiei@apple.com

6 edits in branches/safari-602.1.32-branch/Source/WebKit2

Merge r200959. rdar://problem/26298247

1:40 AM Changeset in webkit [201141] by bshafiei@apple.com

2 edits in branches/safari-602.1.32-branch/Source/WebKit2

Merge r200950. rdar://problem/26287306

1:40 AM Changeset in webkit [201140] by bshafiei@apple.com

2 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI

Merge r200949. rdar://problem/26262219

1:40 AM Changeset in webkit [201139] by bshafiei@apple.com

11 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI

Merge r200947. rdar://problem/26286090

1:40 AM Changeset in webkit [201138] by bshafiei@apple.com

8 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI

Merge r200873. rdar://problem/26228605

1:40 AM Changeset in webkit [201137] by bshafiei@apple.com

2 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI

Merge r200809. rdar://problem/26260709

1:40 AM Changeset in webkit [201136] by bshafiei@apple.com

2 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI

Merge r200805. rdar://problem/26252938

1:40 AM Changeset in webkit [201135] by bshafiei@apple.com

2 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI

Merge r200779. rdar://problem/26239051

1:40 AM Changeset in webkit [201134] by bshafiei@apple.com

7 edits
1 add in branches/safari-602.1.32-branch/Source/WebInspectorUI

Merge r200767. rdar://problem/26231245

1:39 AM Changeset in webkit [201133] by bshafiei@apple.com

3 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI

Merge r200716. rdar://problem/26232856

1:39 AM Changeset in webkit [201132] by bshafiei@apple.com

9 edits in branches/safari-602.1.32-branch/Source/WebKit2

Merge r200702. rdar://problem/26190121

1:39 AM Changeset in webkit [201131] by bshafiei@apple.com

4 edits in branches/safari-602.1.32-branch/Source/WebInspectorUI

Merge r200656. rdar://problem/25898256

1:08 AM Changeset in webkit [201130] by yoav@yoav.ws

4 edits in trunk/LayoutTests

REGRESSION (r200887): LayoutTest http/tests/performance/performance-resource-timing-cached-entries.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=157816

Reviewed by Alexey Proskuryakov.

Mark the test as flaky, and add console logs to try to figure out the cause for flakiness.

TestExpectations: Mark the test as flaky.
http/tests/performance/performance-resource-timing-cached-entries.html: Add prints to better identify the flakiness root cause.

12:32 AM Changeset in webkit [201129] by youenn.fablet@crf.canon.fr

46 edits in trunk/Source/WebCore

Refactor toJS functions to use toJSNewlyCreated
https://bugs.webkit.org/show_bug.cgi?id=157835

Reviewed by Chris Dumez.

Moving checks generated by binding generator from toJS to toJSNewlyCreated.
Changing wrap template function to use toJSNewlyCreated function.
This allows DOMClass toJS() to be equivalent to wrap template function.

Refactored custom binding code to take benefit of this.

Covered by existing tests.

bindings/js/JSAnimationTimelineCustom.cpp:

(WebCore::toJSNewlyCreated):
(WebCore::toJS):

bindings/js/JSBlobCustom.cpp:

(WebCore::toJSNewlyCreated):
(WebCore::toJS):

bindings/js/JSCSSRuleCustom.cpp:

(WebCore::toJSNewlyCreated):
(WebCore::toJS):

bindings/js/JSCSSValueCustom.cpp:

(WebCore::toJSNewlyCreated):
(WebCore::toJS):

bindings/js/JSCanvasRenderingContextCustom.cpp:

(WebCore::toJSNewlyCreated):
(WebCore::toJS):

bindings/js/JSDOMBinding.h:

(WebCore::wrap):
(WebCore::toJS):

bindings/js/JSDocumentCustom.cpp:

(WebCore::toJS):
(WebCore::cachedDocumentWrapper): Deleted.

bindings/js/JSDocumentFragmentCustom.cpp:

(WebCore::toJSNewlyCreated):
(WebCore::toJS):

bindings/js/JSEventCustom.cpp:

(WebCore::toJSNewlyCreated):
(WebCore::toJS):

bindings/js/JSHTMLCollectionCustom.cpp:

(WebCore::toJSNewlyCreated):
(WebCore::toJS):

bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::toJSNewlyCreated):
(WebCore::toJS):

bindings/js/JSHTMLTemplateElementCustom.cpp:

(WebCore::JSHTMLTemplateElement::content):

bindings/js/JSIDBCursorCustom.cpp:

(WebCore::toJSNewlyCreated):
(WebCore::toJS):

bindings/js/JSImageDataCustom.cpp:

(WebCore::toJSNewlyCreated):
(WebCore::toJS):

bindings/js/JSMediaStreamCapabilitiesCustom.cpp:

(WebCore::toJSNewlyCreated):
(WebCore::toJS):

bindings/js/JSNodeListCustom.h:

(WebCore::toJS):

bindings/js/JSPerformanceEntryCustom.cpp:

(WebCore::toJSNewlyCreated):
(WebCore::toJS):

bindings/js/JSSVGPathSegCustom.cpp:

(WebCore::toJSNewlyCreated):
(WebCore::toJS):

bindings/js/JSStyleSheetCustom.cpp:

(WebCore::toJSNewlyCreated):
(WebCore::toJS):

bindings/js/JSTextCustom.cpp:

(WebCore::toJSNewlyCreated):
(WebCore::toJS):

bindings/js/JSTextTrackCueCustom.cpp:

(WebCore::toJSNewlyCreated):
(WebCore::toJS):

bindings/js/JSTrackCustom.cpp:

(WebCore::toJS):

bindings/js/JSXMLDocumentCustom.cpp:

(WebCore::toJSNewlyCreated):
(WebCore::toJS):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
bindings/scripts/test/JS/JSTestEventConstructor.cpp:
bindings/scripts/test/JS/JSTestEventTarget.cpp:
bindings/scripts/test/JS/JSTestException.cpp:
bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
bindings/scripts/test/JS/JSTestGlobalObject.cpp:
bindings/scripts/test/JS/JSTestInterface.cpp:
bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
bindings/scripts/test/JS/JSTestNondeterministic.cpp:
bindings/scripts/test/JS/JSTestObj.cpp:
bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
bindings/scripts/test/JS/JSTestTypedefs.cpp:
bindings/scripts/test/JS/JSattribute.cpp:
bindings/scripts/test/JS/JSreadonly.cpp:

12:14 AM Changeset in webkit [201128] by youenn.fablet@crf.canon.fr

11 edits in trunk/Source/WebCore

Make binding DOM constructor use toJSNewlyCreated instead of toJS
https://bugs.webkit.org/show_bug.cgi?id=157832

Reviewed by Chris Dumez.

Using toJSNewlyCreated in generated constructors instead of toJS.
Enabling generation of toJS and toJSNewlyCreated for constructable DOM objects.
This ensures that toJSNewlyCreated call in constructor will compile properly.

Updating some custom code to implement toJSNewlyCreated.

Covered by existing tests.

bindings/js/JSImageDataCustom.cpp:

(WebCore::toJSNewlyCreated):
(WebCore::toJS):

bindings/js/JSTextTrackCueCustom.cpp:

(WebCore::toJSNewlyCreated):
(WebCore::toJS):

bindings/scripts/CodeGeneratorJS.pm:

(ShouldGenerateToJSDeclaration):
(GenerateConstructorDefinition):

bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::construct):

bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorNamedConstructor::construct):

bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::JSTestNodeConstructor::construct):
(WebCore::toJSNewlyCreated):
(WebCore::toJS):

bindings/scripts/test/JS/JSTestNode.h:

(WebCore::toJS):
(WebCore::toJSNewlyCreated):

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::construct):

bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::constructJSTestOverloadedConstructors1):
(WebCore::constructJSTestOverloadedConstructors2):
(WebCore::constructJSTestOverloadedConstructors3):
(WebCore::constructJSTestOverloadedConstructors4):
(WebCore::constructJSTestOverloadedConstructors5):

Context Navigation

Timeline

May 20, 2016:

May 19, 2016:

Download in other formats: