⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



May 21, 2016:

9:19 PM WebKitGTK/2.12.x edited by Michael Catanzaro
I'm in X, let's copy/paste (diff)
4:52 PM Changeset in webkit [201246] by aestes@apple.com
  • 3 edits in trunk/Source/WebKit2

REGRESSION (r188642): All pages are blank when printing a webpage in iOS Safari
​https://bugs.webkit.org/show_bug.cgi?id=157924
rdar://problem/22524550

Reviewed by Sam Weinig.

When UIPrintInteractionController asks WKWebView to print a webpage, it does so in several phases. First we're
asked to compute the page count, followed later by a series of messages asking us to draw each page into a
provided CGContext.

When asked for the page count, we send a message to the Web process instructing it to compute and
return the page count synchronously and then immediately start drawing the page for printing. If the drawing has
finished by the time we're asked to print the first page, then we can do so without waiting. But if it hasn't
then we block by calling Connection::waitForMessage(), passing std::chromo::milliseconds::max() as the relative
timeout.

Prior to r188642, Connection::waitForMessage() called std::condition_variable::wait_for(), which takes a
relative timeout value. r188642 replaced this with WTF::Condition::waitUntil(), which takes an absolute timeout
instead. To convert from relative to absolute, this line was added to Connection::waitForMessage():

Condition::Clock::time_point absoluteTimeout = Condition::Clock::now() + timeout;

std::chrono will convert both operands to a common duration type before performing the addition. When timeout
equals something very large, like milliseconds::max(), this conversion results in signed integer overflow,
giving absoluteTimeout a value less than Clock::now() and making waitForMessage time out immediately.

To fix this, compute how many milliseconds remain on our clock, and add the smaller of that and the timeout
value to Clock::now() to arrive at an absolute timeout.

  • Platform/IPC/Connection.cpp:

(IPC::Connection::waitForMessage):

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _printedDocument]): Removed an unnecessary nanoseconds-to-milliseconds conversion.

12:21 PM Changeset in webkit [201245] by Matt Baker
  • 14 edits in trunk/Source/WebInspectorUI

Web Inspector: Creating the CSSStyleDetailsSidebarPanel takes about 50ms (20%) of main load
​https://bugs.webkit.org/show_bug.cgi?id=156707
<rdar://problem/25780404>

Reviewed by Timothy Hatcher.

This patch adds new View concepts, initialLayout and widthDidChange,
making it possible for hidden views to postpone the creation of their
UI subtree until they are shown for the first time.

Sidebar panels get this performance improvement by virtue of SidebarPanel
and StyleDetailsPanel, which trigger a layout when shown. This can be
removed once <​https://webkit.org/b/150741> is fixed, and this is done
automatically by View.

  • UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor):
Should subclass View.
(WebInspector.CSSStyleDeclarationTextEditor.prototype.layout):
(WebInspector.CSSStyleDeclarationTextEditor.prototype.get element): Deleted.
Handled in View base class.
(WebInspector.CSSStyleDeclarationTextEditor.prototype.updateLayout): Deleted.
Relocate to layout override, ignore unused parameter force.

  • UserInterface/Views/CSSStyleDetailsSidebarPanel.js:

(WebInspector.CSSStyleDetailsSidebarPanel):
Create the minimum required initial state and UI elements. Relocate
anything that can be lazy loaded to initialLayout.

(WebInspector.CSSStyleDetailsSidebarPanel.prototype.initialLayout):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype.sizeDidChange):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype.widthDidChange): Deleted.

  • UserInterface/Views/ComputedStyleDetailsPanel.js:

(WebInspector.ComputedStyleDetailsPanel):
Relocate anything that can be lazy loaded to initialLayout.
(WebInspector.ComputedStyleDetailsPanel.prototype.initialLayout):
(WebInspector.ComputedStyleDetailsPanel.prototype.shown): Deleted.
(WebInspector.ComputedStyleDetailsPanel.prototype.widthDidChange): Deleted.
Handled in View base class.

  • UserInterface/Views/DataGrid.js:

(WebInspector.DataGrid.prototype.layout):
Resize logic can be safely moved to sizeDidChange, since columns are
always initialized when the width changes.
(WebInspector.DataGrid.prototype.sizeDidChange):
Reposition headers, scrollbars.
(WebInspector.DataGrid.prototype._updateHeaderAndScrollbar):
Broke out header repositioning, which needs to be called whenever
column widths are initialized or the view size changes.

  • UserInterface/Views/NavigationBar.js:

(WebInspector.NavigationBar.prototype.layout):

  • UserInterface/Views/RulesStyleDetailsPanel.js:

(WebInspector.RulesStyleDetailsPanel.prototype.sizeDidChange):
(WebInspector.RulesStyleDetailsPanel.prototype.widthDidChange): Deleted.

  • UserInterface/Views/Sidebar.js:

(WebInspector.Sidebar.prototype._recalculateWidth):
Width changes need to be coordinated by the View base class, since the
initial layout must have occurred before handling a width change.
Force a layout with a resize layout reason.

  • UserInterface/Views/SidebarPanel.js:

(WebInspector.SidebarPanel.prototype.get displayName):
Drive-by style fix: add getter so that CSSStyleDetailsSidebarPanel
doesn't have to read the private property directly.

(WebInspector.SidebarPanel.prototype.shown):
Force a layout whenever the panel is shown.
(WebInspector.SidebarPanel.prototype.sizeDidChange):
(WebInspector.SidebarPanel):
(WebInspector.SidebarPanel.prototype.widthDidChange): Deleted.

  • UserInterface/Views/StyleDetailsPanel.js:

(WebInspector.StyleDetailsPanel.prototype.shown):
Schedule a layout when shown. A forced layout isn't necessary.
Unlike SidebarPanels, the initial state of style panels doesn't depend
on its layout, and can be safely initialized by the next rAF.

(WebInspector.StyleDetailsPanel.prototype.hidden):
Cancel a pending layout if the panel is hidden before the next AF.
(WebInspector.StyleDetailsPanel.prototype.widthDidChange): Deleted.
Not needed, defined in View base class.

  • UserInterface/Views/TimelineOverview.js:

(WebInspector.TimelineOverview.prototype.sizeDidChange):
(WebInspector.TimelineOverview.prototype.layout):
Moved resize logic to sizeDidChange.

  • UserInterface/Views/TimelineRuler.js:

(WebInspector.TimelineRuler.prototype.sizeDidChange):
(WebInspector.TimelineRuler.prototype.layout):
Moved resize logic to sizeDidChange.

  • UserInterface/Views/View.js:

(WebInspector.View):
(WebInspector.View.prototype.updateLayout):
(WebInspector.View.prototype.cancelLayout):
Allow a pending layout to be canceled. Useful when a view with a
pending layout is hidden before the layout occurs.

(WebInspector.View.prototype.get layoutReason):
Protected getter for subclasses that need to check the layout reason
outside sizeDidChange.

(WebInspector.View.prototype.initialLayout):
Subclass hook to create UI subtree the first time a layout occurs.
Called only once during the lifetime of the View.

(WebInspector.View.prototype.layout):
Drive-by comment fix.
(WebInspector.View.prototype.sizeDidChange):
New layout cycle hook for subclasses.
(WebInspector.View.prototype._layoutSubtree):
Do an initial layout the first time layout is called.
Call the sizeDidChange hook so that subclasses can update state
which depends on size/position before doing layout.

  • UserInterface/Views/VisualStyleDetailsPanel.js:

(WebInspector.VisualStyleDetailsPanel):
Create the minimum required initial state and UI elements. Relocate
anything that can be lazy loaded to initialLayout.

(WebInspector.VisualStyleDetailsPanel.prototype.refresh):
No changes, shifting line numbers confused the diff.
(WebInspector.VisualStyleDetailsPanel.prototype.initialLayout):
(WebInspector.VisualStyleDetailsPanel.prototype.sizeDidChange):
(WebInspector.VisualStyleDetailsPanel.prototype.widthDidChange): Deleted.

12:21 PM Changeset in webkit [201244] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

Simulator launch fails intermittently due to failure in checking simulator boot status
​https://bugs.webkit.org/show_bug.cgi?id=157965
rdar://problem/26402404

Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/xcode/simulator.py:

(Simulator.wait_until_device_is_booted): Ignore CalledProcessError exception while checking
whether simulator has finished booting.

11:42 AM Changeset in webkit [201243] by Matt Baker
  • 3 edits in trunk/Source/WebInspectorUI

Assertion Failed: StyleDetailsPanel.markAsNeedsRefresh() called with null domNode
​https://bugs.webkit.org/show_bug.cgi?id=157955
<rdar://problem/26398943>

Reviewed by Timothy Hatcher.

CSSStyleDetailsSidebarPanel visible is true while the panel is being
removed from the details sidebar, even after calling hidden(). This
causes it to refresh its current StyleDetailsPanel with a null DOM node.

Unfortunately, SidebarPanel.visible isn't toggled by calling shown/hidden.
Since SidebarPanel.visible is only true if the panel is selected, we should
deselect panels before removing them.

  • UserInterface/Views/Sidebar.js:

(WebInspector.Sidebar.prototype.removeSidebarPanel):
Deselect the panel being removed before calling visibiltyDidChange.

  • UserInterface/Views/SidebarPanel.js:

(WebInspector.SidebarPanel.prototype.toggle): Deleted.
(WebInspector.SidebarPanel.prototype.willRemove): Deleted.
Drive-by update to remove some unused methods.

10:10 AM Changeset in webkit [201242] by mitz@apple.com
  • 3 edits in trunk/Tools

Silence warnings from svn propget when using newer versions of Subversion.
​https://bugs.webkit.org/show_bug.cgi?id=157879

Reviewed by Daniel Bates.

  • Scripts/prepare-ChangeLog:

(attributeCommand): Redirect svn propget stderr to /dev/null.

  • Scripts/svn-create-patch:

(findMimeType): Ditto.

May 20, 2016:

11:15 PM Changeset in webkit [201241] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Fixed USE(APPLE_INTERNAL_SDK) builds.

  • platform/cocoa/ThemeCocoa.mm:

(WebCore::fitContextToBox):

10:22 PM Changeset in webkit [201240] by Joseph Pecoraro
  • 2 edits in trunk/LayoutTests

Unreviewed test gardening after r201237 exposed an issue.

10:17 PM Changeset in webkit [201239] by Joseph Pecoraro
  • 48 edits
    13 deletes in trunk/Source

Remove LegacyProfiler
​https://bugs.webkit.org/show_bug.cgi?id=153565

Reviewed by Mark Lam.

Source/JavaScriptCore:

JavaScriptCore now provides a sampling profiler and it is enabled
by all ports. Web Inspector switched months ago to using the
sampling profiler and displaying its data. Remove the legacy
profiler, as it is no longer being used by anything other then
console.profile and tests. We will update console.profile's
behavior soon to have new behavior and use the sampling data.

  • API/JSProfilerPrivate.cpp: Removed.
  • API/JSProfilerPrivate.h: Removed.
  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/BytecodeList.json:
  • bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset): Deleted.
(JSC::computeDefsForBytecodeOffset): Deleted.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode): Deleted.

  • bytecode/UnlinkedFunctionExecutable.cpp:

(JSC::generateUnlinkedFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::unlinkedCodeBlockFor):

  • bytecode/UnlinkedFunctionExecutable.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitCallVarargsInTailPosition):
(JSC::BytecodeGenerator::emitConstructVarargs):
(JSC::BytecodeGenerator::emitConstruct):

  • bytecompiler/BytecodeGenerator.h:

(JSC::CallArguments::profileHookRegister): Deleted.
(JSC::BytecodeGenerator::shouldEmitProfileHooks): Deleted.

  • bytecompiler/NodesCodegen.cpp:

(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
(JSC::CallArguments::CallArguments): Deleted.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects): Deleted.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock): Deleted.

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel): Deleted.

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize): Deleted.

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC): Deleted.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode): Deleted.

  • dfg/DFGNodeType.h:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute): Deleted.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile): Deleted.

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile): Deleted.

  • inspector/InjectedScriptBase.cpp:

(Inspector::InjectedScriptBase::callFunctionWithEvalEnabled):

  • interpreter/Interpreter.cpp:

(JSC::UnwindFunctor::operator()): Deleted.
(JSC::Interpreter::execute): Deleted.
(JSC::Interpreter::executeCall): Deleted.
(JSC::Interpreter::executeConstruct): Deleted.

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass): Deleted.

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_profile_will_call): Deleted.
(JSC::JIT::emit_op_profile_did_call): Deleted.

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_profile_will_call): Deleted.
(JSC::JIT::emit_op_profile_did_call): Deleted.

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL): Deleted.

  • llint/LLIntSlowPaths.h:
  • llint/LowLevelInterpreter.asm:
  • parser/ParserModes.h:
  • profiler/CallIdentifier.h: Removed.
  • profiler/LegacyProfiler.cpp: Removed.
  • profiler/LegacyProfiler.h: Removed.
  • profiler/Profile.cpp: Removed.
  • profiler/Profile.h: Removed.
  • profiler/ProfileGenerator.cpp: Removed.
  • profiler/ProfileGenerator.h: Removed.
  • profiler/ProfileNode.cpp: Removed.
  • profiler/ProfileNode.h: Removed.
  • profiler/ProfilerJettisonReason.cpp:

(WTF::printInternal): Deleted.

  • profiler/ProfilerJettisonReason.h:
  • runtime/CodeCache.cpp:

(JSC::CodeCache::getGlobalCodeBlock):
(JSC::CodeCache::getProgramCodeBlock):
(JSC::CodeCache::getEvalCodeBlock):
(JSC::CodeCache::getModuleProgramCodeBlock):

  • runtime/CodeCache.h:
  • runtime/Executable.cpp:

(JSC::ScriptExecutable::newCodeBlockFor):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::createProgramCodeBlock):
(JSC::JSGlobalObject::createEvalCodeBlock):
(JSC::JSGlobalObject::createModuleProgramCodeBlock):
(JSC::JSGlobalObject::~JSGlobalObject): Deleted.
(JSC::JSGlobalObject::hasLegacyProfiler): Deleted.

  • runtime/JSGlobalObject.h:
  • runtime/Options.h:
  • runtime/VM.cpp:

(JSC::VM::VM): Deleted.
(JSC::SetEnabledProfilerFunctor::operator()): Deleted.
(JSC::VM::setEnabledProfiler): Deleted.

  • runtime/VM.h:

(JSC::VM::enabledProfiler): Deleted.
(JSC::VM::enabledProfilerAddress): Deleted.

Source/WebCore:

  • ForwardingHeaders/profiler/Profile.h: Removed.
  • ForwardingHeaders/profiler/ProfileNode.h: Removed.
  • testing/js/WebCoreTestSupport.cpp:
  • xml/XSLStyleSheetLibxslt.cpp:
  • xml/XSLTProcessorLibxslt.cpp:
8:57 PM Changeset in webkit [201238] by rniwa@webkit.org
  • 6 edits in trunk

run-benchmark's results should contain Animometer's debug output
​https://bugs.webkit.org/show_bug.cgi?id=157941

Reviewed by Stephanie Lewis.

PerformanceTests:

Made developer.html support the JSON generated by run-benchmark which stores everything under debugOutput.

  • Animometer/resources/debug-runner/animometer.js:

(Utilities.initialize): Unwrap debugOutput in the case run-benchmark's result JSON is used.

Tools:

Modified the Animometer patch to store debug output and made benchmark_runner extract them together as a single array.
The result can be dragged and dropped into Animometer's developer.html page.

  • Scripts/webkitpy/benchmark_runner/benchmark_runner.py:

(BenchmarkRunner._run_one_test): Parse JSON here instead of doing it in multiple call sites.
(BenchmarkRunner._run_benchmark): Strip debugOutput from individual test result, and merge them together separately.

  • Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch:

Modified the patch to store the debug output.

  • Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:

(ServerControl.render_POST): Fixed a bug that POST to /report results in 500 because getvalue is not defined
when the request body is larger than a certain size on twisted.

7:00 PM Changeset in webkit [201237] by commit-queue@webkit.org
  • 51 edits
    8 deletes in trunk

Remove LegacyProfiler
​https://bugs.webkit.org/show_bug.cgi?id=153565

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-20
Reviewed by Saam Barati.

.:

  • ManualTests/inspector/profiler-test-call.html: Removed.
  • ManualTests/inspector/profiler-test-many-calls-in-the-same-scope.html: Removed.

Source/JavaScriptCore:

  • inspector/protocol/Timeline.json:
  • jsc.cpp:
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::hasLegacyProfiler):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::supportsLegacyProfiling): Deleted.

Source/WebCore:

JavaScriptCore now provides a sampling profiler and it is enabled
by all ports. Web Inspector switched months ago to using the
sampling profiler and displaying its data. Remove the legacy
profiler, as it is no longer being used by anything other then
console.profile and tests. We will update console.profile's
behavior soon to have new behavior and use the sampling data.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • ForwardingHeaders/profiler/LegacyProfiler.h: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCustomXPathNSResolver.cpp:
  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::supportsLegacyProfiling): Deleted.
(WebCore::JSDOMWindowBase::supportsRichSourceInfo): Deleted.

  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/JSWorkerGlobalScopeBase.cpp:

(WebCore::JSWorkerGlobalScopeBase::supportsLegacyProfiling): Deleted.

  • bindings/js/JSWorkerGlobalScopeBase.h:
  • bindings/js/ScriptCachedFrameData.cpp:
  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::clearWindowShell): Deleted.

  • bindings/js/ScriptProfile.h: Removed.
  • bindings/js/ScriptProfileNode.h: Removed.
  • bindings/scripts/CodeGeneratorJS.pm:

(AddClassForwardIfNeeded): Deleted.

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg): Deleted.
(WebCore::jsTestObjPrototypeFunctionMethodReturningSequence): Deleted.

  • bindings/scripts/test/TestObj.idl:
  • css/CSSParser.cpp:
  • dom/Document.cpp:
  • inspector/InspectorConsoleInstrumentation.h:

(WebCore::InspectorInstrumentation::stopProfiling):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::legacyProfilerEnabled): Deleted.
(WebCore::InspectorController::setLegacyProfilerEnabled): Deleted.

  • inspector/InspectorController.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::stopProfilingImpl):

  • inspector/InspectorInstrumentation.h:
  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::startFromConsole):
(WebCore::InspectorTimelineAgent::stopFromConsole):

  • inspector/InspectorTimelineAgent.h:
  • inspector/PageDebuggerAgent.cpp:
  • inspector/PageRuntimeAgent.cpp:
  • inspector/ScriptProfile.idl: Removed.
  • inspector/ScriptProfileNode.idl: Removed.
  • inspector/TimelineRecordFactory.cpp:

(WebCore::buildAggregateCallInfoInspectorObject): Deleted.
(WebCore::buildInspectorObject): Deleted.
(WebCore::buildProfileInspectorObject): Deleted.
(WebCore::TimelineRecordFactory::appendProfile): Deleted.

  • inspector/TimelineRecordFactory.h:
  • page/DOMWindow.cpp:
  • page/Page.cpp:
  • page/PageConsoleClient.cpp:

(WebCore::PageConsoleClient::profileEnd):
(WebCore::PageConsoleClient::clearProfiles): Deleted.

  • page/PageConsoleClient.h:
  • testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState): Deleted.
(WebCore::Internals::consoleProfiles): Deleted.
(WebCore::Internals::setLegacyJavaScriptProfilingEnabled): Deleted.

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit/win:

  • Interfaces/IWebInspector.idl:
  • WebCoreStatistics.cpp:
  • WebInspector.cpp:

(WebInspector::isJavaScriptProfilingEnabled): Deleted.
(WebInspector::setJavaScriptProfilingEnabled): Deleted.

LayoutTests:

  • fast/profiler/anonymous-event-handler-expected.txt: Removed.
  • fast/profiler/anonymous-event-handler.html: Removed.
  • fast/profiler/anonymous-function-called-from-different-contexts-expected.txt: Removed.
  • fast/profiler/anonymous-function-called-from-different-contexts.html: Removed.
  • fast/profiler/anonymous-function-calls-built-in-functions-expected.txt: Removed.
  • fast/profiler/anonymous-function-calls-built-in-functions.html: Removed.
  • fast/profiler/anonymous-function-calls-eval-expected.txt: Removed.
  • fast/profiler/anonymous-function-calls-eval.html: Removed.
  • fast/profiler/anonymous-functions-with-display-names-expected.txt: Removed.
  • fast/profiler/anonymous-functions-with-display-names.html: Removed.
  • fast/profiler/apply-expected.txt: Removed.
  • fast/profiler/apply.html: Removed.
  • fast/profiler/built-in-function-calls-anonymous-expected.txt: Removed.
  • fast/profiler/built-in-function-calls-anonymous.html: Removed.
  • fast/profiler/built-in-function-calls-user-defined-function-expected.txt: Removed.
  • fast/profiler/built-in-function-calls-user-defined-function.html: Removed.
  • fast/profiler/call-expected.txt: Removed.
  • fast/profiler/call-register-leak-expected.txt: Removed.
  • fast/profiler/call-register-leak.html: Removed.
  • fast/profiler/call.html: Removed.
  • fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope-expected.txt: Removed.
  • fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope.html: Removed.
  • fast/profiler/compare-multiple-profiles-expected.txt: Removed.
  • fast/profiler/compare-multiple-profiles.html: Removed.
  • fast/profiler/constructor-expected.txt: Removed.
  • fast/profiler/constructor.html: Removed.
  • fast/profiler/dead-time-expected.txt: Removed.
  • fast/profiler/dead-time.html: Removed.
  • fast/profiler/document-dot-write-expected.txt: Removed.
  • fast/profiler/document-dot-write.html: Removed.
  • fast/profiler/event-handler-expected.txt: Removed.
  • fast/profiler/event-handler.html: Removed.
  • fast/profiler/execution-context-and-eval-on-same-line-expected.txt: Removed.
  • fast/profiler/execution-context-and-eval-on-same-line.html: Removed.
  • fast/profiler/inline-event-handler-expected.txt: Removed.
  • fast/profiler/inline-event-handler.html: Removed.
  • fast/profiler/many-calls-in-the-same-scope-expected.txt: Removed.
  • fast/profiler/many-calls-in-the-same-scope.html: Removed.
  • fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt: Removed.
  • fast/profiler/multiple-and-different-scoped-anonymous-function-calls.html: Removed.
  • fast/profiler/multiple-and-different-scoped-function-calls-expected.txt: Removed.
  • fast/profiler/multiple-and-different-scoped-function-calls.html: Removed.
  • fast/profiler/multiple-anonymous-functions-called-from-the-same-function-expected.txt: Removed.
  • fast/profiler/multiple-anonymous-functions-called-from-the-same-function.html: Removed.
  • fast/profiler/multiple-frames-expected.txt: Removed.
  • fast/profiler/multiple-frames.html: Removed.
  • fast/profiler/named-functions-with-display-names-expected.txt: Removed.
  • fast/profiler/named-functions-with-display-names.html: Removed.
  • fast/profiler/nested-anonymous-functon-expected.txt: Removed.
  • fast/profiler/nested-anonymous-functon.html: Removed.
  • fast/profiler/nested-start-and-stop-profiler-expected.txt: Removed.
  • fast/profiler/nested-start-and-stop-profiler.html: Removed.
  • fast/profiler/no-execution-context-expected.txt: Removed.
  • fast/profiler/no-execution-context.html: Removed.
  • fast/profiler/one-execution-context-expected.txt: Removed.
  • fast/profiler/one-execution-context.html: Removed.
  • fast/profiler/profile-calls-in-included-file-expected.txt: Removed.
  • fast/profiler/profile-calls-in-included-file.html: Removed.
  • fast/profiler/profile-with-no-title-expected.txt: Removed.
  • fast/profiler/profile-with-no-title.html: Removed.
  • fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting-expected.txt: Removed.
  • fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting.html: Removed.
  • fast/profiler/profiling-from-a-nested-location-expected.txt: Removed.
  • fast/profiler/profiling-from-a-nested-location.html: Removed.
  • fast/profiler/resources/other-frame.html: Removed.
  • fast/profiler/resources/other-window.html: Removed.
  • fast/profiler/resources/profiler-test-JS-resources.js: Removed.
  • fast/profiler/simple-event-call-expected.txt: Removed.
  • fast/profiler/simple-event-call.html: Removed.
  • fast/profiler/simple-no-level-change-expected.txt: Removed.
  • fast/profiler/simple-no-level-change.html: Removed.
  • fast/profiler/start-and-stop-profiler-multiple-times-expected.txt: Removed.
  • fast/profiler/start-and-stop-profiler-multiple-times.html: Removed.
  • fast/profiler/start-and-stop-profiling-in-the-same-function-expected.txt: Removed.
  • fast/profiler/start-and-stop-profiling-in-the-same-function.html: Removed.
  • fast/profiler/start-but-dont-stop-profiling-expected.txt: Removed.
  • fast/profiler/start-but-dont-stop-profiling.html: Removed.
  • fast/profiler/stop-profiling-after-setTimeout-expected.txt: Removed.
  • fast/profiler/stop-profiling-after-setTimeout.html: Removed.
  • fast/profiler/stop-then-function-call-expected.txt: Removed.
  • fast/profiler/stop-then-function-call.html: Removed.
  • fast/profiler/throw-exception-from-eval-expected.txt: Removed.
  • fast/profiler/throw-exception-from-eval.html-disabled: Removed.
  • fast/profiler/two-execution-contexts-expected.txt: Removed.
  • fast/profiler/two-execution-contexts.html: Removed.
  • fast/profiler/user-defined-function-calls-built-in-functions-expected.txt: Removed.
  • fast/profiler/user-defined-function-calls-built-in-functions.html: Removed.
  • fast/profiler/window-dot-eval-expected.txt: Removed.
  • fast/profiler/window-dot-eval.html: Removed.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/ios-simulator/TestExpectations:
6:17 PM Changeset in webkit [201236] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.32.4

New tag.

5:17 PM Changeset in webkit [201235] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSScope::abstractAccess doesn't need to copy the SymbolTableEntry, it can use it by reference
​https://bugs.webkit.org/show_bug.cgi?id=157956

Reviewed by Geoffrey Garen.

A SymbolTableEntry may be a FatEntry. Copying a FatEntry is slow because we have to
malloc memory for it, then free the malloced memory once the entry goes out of
scope. abstractAccess uses a SymbolTableEntry temporarily when performing scope
accesses during bytecode linking. It copies out the SymbolTableEntry every time
it does a SymbolTable lookup. This is not cheap when the entry happens to be a
FatEntry. We should really just be using a reference to the entry because
there is no need to copy it in such a scenario.

  • runtime/JSScope.cpp:

(JSC::abstractAccess):

4:56 PM Changeset in webkit [201234] by Alan Bujtas
  • 12 edits
    4 adds in trunk

width: 1% on nested table cell causes its table to hog horizontal space
​https://bugs.webkit.org/show_bug.cgi?id=144696
<rdar://problem/20839572>

Reviewed by David Hyatt and Tim Horton.

This patch is based on ​https://chromium.googlesource.com/chromium/src/+/9428cfb16993a2329e87c65da096ca295132ef0f

Source/WebCore:

Tests: fast/table/inner-percent-width-affects-outer-floated-div.html

fast/table/inner-percent-width-doesnt-affect-ancestor-columns.html

  • rendering/AutoTableLayout.cpp:

(WebCore::shouldScaleColumnsForParent):
(WebCore::shouldScaleColumnsForSelf):
(WebCore::AutoTableLayout::computeIntrinsicLogicalWidths):
(WebCore::shouldScaleColumns): Deleted.

  • rendering/AutoTableLayout.h:
  • rendering/RenderTable.cpp:

(WebCore::RenderTable::updateLogicalWidth):

  • rendering/TableLayout.h:

(WebCore::TableLayout::scaledWidthFromPercentColumns):

LayoutTests:

  • fast/table/inner-percent-width-affects-outer-floated-div-expected.html: Added.
  • fast/table/inner-percent-width-affects-outer-floated-div.html: Added.
  • fast/table/inner-percent-width-doesnt-affect-ancestor-columns-expected.html: Added.
  • fast/table/inner-percent-width-doesnt-affect-ancestor-columns.html: Added.
  • platform/mac/fast/table/border-collapsing/cached-change-row-border-width-expected.txt:
  • platform/mac/fast/table/border-collapsing/cached-change-tbody-border-width-expected.txt:
  • platform/mac/fast/table/max-width-integer-overflow-expected.txt:
4:46 PM Changeset in webkit [201233] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Inconsistent state in playback controls
​https://bugs.webkit.org/show_bug.cgi?id=157962
<rdar://problem/26397571>

Reviewed by Beth Dakin.

Do not use the playbackSessionManager() as the model, that's what the model is for.

  • platform/mac/WebPlaybackSessionInterfaceMac.mm:

(WebCore::WebPlaybackSessionInterfaceMac::setClient):

4:15 PM Changeset in webkit [201232] by beidson@apple.com
  • 7 edits
    3 adds in trunk

Modern IDB: Properly handle blobs in Workers.
​https://bugs.webkit.org/show_bug.cgi?id=157947

Reviewed by Alex Christensen.

Source/WebCore:

Test: storage/indexeddb/modern/blob-simple-workers.html

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::putOrAddOnServer): Use writeBlobsToDiskForIndexedDBSynchronously from

background threads instead of the asynchronous form.

Add ability to set an existing empty IDBValue to be an isolated copy of a different IDBValue:

  • Modules/indexeddb/IDBValue.cpp:

(WebCore::IDBValue::setAsIsolatedCopy):
(WebCore::IDBValue::isolatedCopy):

  • Modules/indexeddb/IDBValue.h:

Add a method - only to be called from a non-main thread - that synchronously writes blobs to disk:

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::writeBlobsToDiskForIndexedDBSynchronously):

  • bindings/js/SerializedScriptValue.h:

LayoutTests:

  • storage/indexeddb/modern/blob-simple-workers-expected.txt: Added.
  • storage/indexeddb/modern/blob-simple-workers.html: Added.
  • storage/indexeddb/modern/resources/blob-simple-workers.js: Added.
3:53 PM Changeset in webkit [201231] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

REGRESSION(r200740): Web Inspector: TimelineRecordBar class lists not properly cleared, bleeding colors when zooming in and out
​https://bugs.webkit.org/show_bug.cgi?id=157959
<rdar://problem/26393067>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-20
Reviewed by Brian Burg.

  • UserInterface/Views/TimelineRecordBar.js:

(WebInspector.TimelineRecordBar.prototype.set records):
When records are cleared, clear all classes.

3:31 PM Changeset in webkit [201230] by bshafiei@apple.com
  • 7 edits
    2 adds in branches/safari-602.1.32-branch

Merge r201227. rdar://problem/24577706

3:28 PM Changeset in webkit [201229] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Allow named images on iOS
​https://bugs.webkit.org/show_bug.cgi?id=157960
rdar://problem/26396532

Reviewed by Dean Jackson.

USE(NEW_THEME) is false on iOS so force named images to be drawn by checking PLATFORM(IOS) as well.

  • platform/graphics/NamedImageGeneratedImage.cpp:

(WebCore::NamedImageGeneratedImage::draw):

3:10 PM Changeset in webkit [201228] by mmaxfield@apple.com
  • 4 edits
    3 adds in trunk

[Cocoa] REGRESSION(r184899): Ascent adjustments are applied to web fonts
​https://bugs.webkit.org/show_bug.cgi?id=157954
<rdar://problem/24204349>

Reviewed by Dean Jackson.

Source/WebCore:

There are a few specific fonts which exist on Windows and Cocoa OSes, and we will adjust
the ascents of these fonts to better match their counterparts on Windows. However, in
r184899, we started applying this adjustment to web fonts too.

Test: fast/text/ascent-adjustment-webfont.html

  • platform/graphics/cocoa/FontCocoa.mm:

(WebCore::Font::platformInit):

  • svg/SVGToOTFFontConversion.cpp: We were reporting the length of font names wrong, so

it made the test pass without this patch even when it shouldn't have. Previously, we
were recording the number of characters in the font, not the number of bytes (each
character is 2 bytes).

LayoutTests:

  • fast/text/ascent-adjustment-webfont-expected-mismatch.html: Added.
  • fast/text/ascent-adjustment-webfont.html: Added.
  • fast/text/resources/Helvetica-light.svg: Added.
3:05 PM Changeset in webkit [201227] by enrica@apple.com
  • 7 edits
    2 adds in trunk

Drag cannot start if no drag data or custom data is available in the Pasteboard.
​https://bugs.webkit.org/show_bug.cgi?id=157911
rdar://problem/24577706

Reviewed by Tim Horton.

Source/WebKit/mac:

We need to make sure there is always one item in common between source and target
of the drag and drop operation.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]):

Source/WebKit2:

We need to make sure there is always one item in common between source and target
of the drag and drop operation.

  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::dragImageForView):

LayoutTests:

  • fast/events/draggable-div-customdata-expected.txt: Added.
  • fast/events/draggable-div-customdata.html: Added.
  • platform/ios-simulator/TestExpectations
  • platform/mac-wk2/TestExpectations
2:47 PM Changeset in webkit [201226] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Source/JavaScriptCore

Web Inspector: retained size for typed arrays does not count native backing store
​https://bugs.webkit.org/show_bug.cgi?id=157945
<rdar://problem/26392238>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-05-20
Reviewed by Geoffrey Garen.

  • runtime/JSArrayBuffer.h:
  • runtime/JSArrayBuffer.cpp:

(JSC::JSArrayBuffer::estimatedSize):
Include an estimatedSize implementation for JSArrayBuffer.
ArrayBuffer has a unique path, different from other data
stored in the Heap.

  • tests/heapProfiler/typed-array-sizes.js: Added.

Test sizes of TypedArray with and without an ArrayBuffer.
When the TypedArray is a view wrapping an ArrayBuffer, the
ArrayBuffer has the size.

2:17 PM Changeset in webkit [201225] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

reifyAllStaticProperties makes two copies of every string
​https://bugs.webkit.org/show_bug.cgi?id=157953

Reviewed by Mark Lam.

Let's not do that.

  • runtime/JSObject.cpp:

(JSC::JSObject::reifyAllStaticProperties): Pass our Identifier to
reifyStaticProperty so it doesn't have to make its own.

  • runtime/Lookup.h:

(JSC::reifyStaticProperty): No need to null check because callers never
pass null anymore. No need to make an identifier because callers pass
us one.

(JSC::reifyStaticProperties): Honor new interface.

2:17 PM Changeset in webkit [201224] by commit-queue@webkit.org
  • 19 edits in trunk/Source

Remove unnecessary PageOverlay client function pageOverlayDestroyed
​https://bugs.webkit.org/show_bug.cgi?id=157388
<rdar://problem/25471523>

Patch by John Wilander <​wilander@apple.com> on 2016-05-20
Reviewed by Tim Horton.

Remove dead PageOverlay code. Almost all of these overrides were empty and
never called. In the case of WebPageOverlay it was never called but had a
function body, causing confusion. There was a fear of dangling pointers in
WebPageOverlay's static hash map between PageOverlays and WebPageOverlays.
Only WebPageOverlay's constructor creates its PageOverlay object and adds it
to the hash map. Its client object is kept in a unique pointer member which
is automatically deleted when the WebPageOverlay object itself is deleted.
This explains why PageOverlayClientImpl::pageOverlayDestroyed in
WKBundlePageOverlay can safely be removed. Finally, WebPageOverlay's
destructor clears the hash map entry for its PageOverlay object. Thus, there
is no need to call WebPageOverlay::pageOverlayDestroyed nor a need for
WebPageOverlay's destructor to call pageOverlayDestroyed on its client.

No new tests. I tried to come up with a WebKit API test for this but I
wasn't able to test presence/absence of WebPageOverlay's map entries since
the map is not exposed.

Source/WebCore:

  • page/DebugPageOverlays.cpp:

(WebCore::RegionOverlay::pageOverlayDestroyed): Deleted.

  • page/PageOverlay.h:

(WebCore::PageOverlay::Client::pageOverlayDestroyed): Deleted.

  • page/ResourceUsageOverlay.h:

(WebCore::ResourceUsageOverlay::pageOverlayDestroyed): Deleted.

  • page/mac/ServicesOverlayController.h:
  • page/mac/ServicesOverlayController.mm:

(WebCore::ServicesOverlayController::pageOverlayDestroyed): Deleted.

  • testing/MockPageOverlayClient.cpp:
  • testing/MockPageOverlayClient.h:

(WebCore::MockPageOverlayClient::pageOverlayDestroyed): Deleted.

Source/WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:

(WebKit::PageOverlayClientImpl::pageOverlayDestroyed): Deleted.

  • WebProcess/Plugins/PDF/PDFPlugin.h:
  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::HUD::pageOverlayDestroyed): Deleted.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:
  • WebProcess/WebCoreSupport/WebInspectorClient.h:

(WebKit::WebInspectorClient::pageOverlayDestroyed): Deleted.

  • WebProcess/WebPage/FindController.cpp:
  • WebProcess/WebPage/FindController.h:

(WebKit::FindController::pageOverlayDestroyed): Deleted.

  • WebProcess/WebPage/WebPageOverlay.cpp:
  • WebProcess/WebPage/WebPageOverlay.h:

(WebKit::WebPageOverlay::pageOverlayDestroyed): Deleted.

  • WebProcess/WebPage/ios/FindIndicatorOverlayClientIOS.h:

(WebKit::FindIndicatorOverlayClientIOS::pageOverlayDestroyed): Deleted.

1:43 PM Changeset in webkit [201223] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Fix null dereferencing in CSSAnimationTriggerScrollValue::equals
​https://bugs.webkit.org/show_bug.cgi?id=157930

Patch by Alex Christensen <​achristensen@webkit.org> on 2016-05-20
Reviewed by Dean Jackson.

Source/WebCore:

Test: fast/css/compare-animation-trigger.html

  • css/CSSAnimationTriggerScrollValue.cpp:

(WebCore::CSSAnimationTriggerScrollValue::equals):

  • css/CSSAnimationTriggerScrollValue.h:

(WebCore::CSSAnimationTriggerScrollValue::create):
(WebCore::CSSAnimationTriggerScrollValue::startValue):
(WebCore::CSSAnimationTriggerScrollValue::endValue):
(WebCore::CSSAnimationTriggerScrollValue::hasEndValue):
(WebCore::CSSAnimationTriggerScrollValue::operator==):
(WebCore::CSSAnimationTriggerScrollValue::CSSAnimationTriggerScrollValue):

  • css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapAnimationTrigger):

  • css/CSSValue.h:

(WebCore::CSSValue::operator==):

LayoutTests:

  • fast/css/compare-animation-trigger-expected.txt: Added.
  • fast/css/compare-animation-trigger.html: Added.
12:36 PM Changeset in webkit [201222] by Nikita Vasilyev
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Split Console is auto opening all the time when using Inspect Element context menu
​https://bugs.webkit.org/show_bug.cgi?id=157910
<rdar://problem/26374066>

Reviewed by Timothy Hatcher.

Currently, "synthetic" property is only used to decide whether adding a console message should
open the console or not. Replace it with "shouldRevealConsole".

  • UserInterface/Controllers/DOMTreeManager.js:

(WebInspector.DOMTreeManager.prototype.inspectNodeObject.nodeAvailable):
(WebInspector.DOMTreeManager.prototype.inspectNodeObject):

  • UserInterface/Controllers/JavaScriptLogViewController.js:

(WebInspector.JavaScriptLogViewController.prototype.appendImmediateExecutionWithResult.saveResultCallback):
(WebInspector.JavaScriptLogViewController.prototype.appendImmediateExecutionWithResult):
(WebInspector.JavaScriptLogViewController.prototype.consolePromptTextCommitted.printResult):
(WebInspector.JavaScriptLogViewController.prototype.consolePromptTextCommitted):
(WebInspector.JavaScriptLogViewController.prototype._appendConsoleMessageView):

  • UserInterface/Models/ConsoleCommandResultMessage.js:

(WebInspector.ConsoleCommandResultMessage):
(WebInspector.ConsoleCommandResultMessage.prototype.get shouldRevealConsole):
(WebInspector.ConsoleCommandResultMessage.prototype.get synthetic): Deleted.

  • UserInterface/Views/HeapSnapshotInstanceDataGridNode.js:

(WebInspector.HeapSnapshotInstanceDataGridNode.logHeapSnapshotNode.node.shortestGCRootPath.):
(WebInspector.HeapSnapshotInstanceDataGridNode.logHeapSnapshotNode):

12:13 PM Changeset in webkit [201221] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

JSBench regression: CodeBlock linking always copies the symbol table
​https://bugs.webkit.org/show_bug.cgi?id=157951

Reviewed by Saam Barati.

We always put a SymbolTable into the constant pool, even in simple
functions in which it won't be used -- i.e., there's on eval and there
are no captured variables and so on.

This is costly because linking must copy any provided symbol tables.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitProfileType): Only add the symbol table
as a constant if we will use it at runtime.

12:07 PM Changeset in webkit [201220] by bshafiei@apple.com
  • 2 edits in tags/Safari-602.1.33.1/Source/WebCore

Merged r201212. rdar://problem/26385907

12:06 PM Changeset in webkit [201219] by bshafiei@apple.com
  • 5 edits in tags/Safari-602.1.33.1/Source

Versioning.

11:48 AM Changeset in webkit [201218] by hyatt@apple.com
  • 3 edits
    2 adds in trunk

Scrolling broken in iTunes connect pages
​https://bugs.webkit.org/show_bug.cgi?id=157678

Reviewed by Zalan Bujtas.

Source/WebCore:

Added fast/flexbox/nested-columns-min-intrinsic-disabled.html

Turn off minimum intrinsic size adjustment for flexboxes. This violates the spec,
but until we can produce good results that is what we need to do. Blink has also
turned off nested columns intrinsic sizing as well, so we match them with this
change.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax):

LayoutTests:

  • fast/flexbox/nested-column-intrinsic-min-disabled-expected.html: Added.
  • fast/flexbox/nested-column-intrinsic-min-disabled.html: Added.
11:44 AM Changeset in webkit [201217] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.33.1

New tag.

11:34 AM Changeset in webkit [201216] by jdiggs@igalia.com
  • 60 edits
    1 move
    19 deletes in trunk/LayoutTests

AX: Layout tests related to text alternative computation need to be done differently
​https://bugs.webkit.org/show_bug.cgi?id=157187

Create several utility methods to facilitate retrieval of platform-independent
attribute values from platform-specific attributes:

  • platformValueForW3CName() and platformValueForW3CDescription() to retrieve a specific piece of text alternative information, stripping off the platform attribute name by default. These methods should make it possible to share tests and expectations files because the text alternative calculation defined by the W3C accessibility specifications should be the same for all platforms. (The differences are the result of the unique platform mappings.)
  • platformTextAlternatives() to dump out all the text alternative attributes and values, preserving the platform-specific attribute name. This, along with the use of the platformValue* methods with attribute name enabled, should make it possible to have shared tests with platform-specific expectations without the need to check the platform in the test itself.
  • platformRoleForComboBox() and platformRoleForStaticText() to eliminate the need for platform-specific expectations files simply because such an element happens to be included in the test file and verifying that element's role is desired.

Begin using these methods in the tests related to text alternative computation
which had platform-specific checks, update the expectations files when needed,
and remove now-obsolete platform-specific expectations files.

Reviewed by Chris Fleizach.

  • accessibility/alt-tag-on-image-with-nonimage-role-expected.txt: Updated.
  • accessibility/alt-tag-on-image-with-nonimage-role.html: Updated.
  • accessibility/aria-help-expected.txt: Added.
  • accessibility/aria-help.html: Updated.
  • accessibility/aria-label-expected.txt: Updated.
  • accessibility/aria-label.html: Updated.
  • accessibility/aria-labeled-with-hidden-node-expected.txt: Updated.
  • accessibility/aria-labeled-with-hidden-node.html: Updated.
  • accessibility/aria-labelledby-on-input-expected.txt: Updated.
  • accessibility/aria-labelledby-on-input.html: Updated.
  • accessibility/aria-labelledby-overrides-aria-labeledby-expected.txt: Updated.
  • accessibility/aria-labelledby-overrides-aria-labeledby.html: Updated.
  • accessibility/aria-labelledby-overrides-label-expected.txt: Updated.
  • accessibility/aria-labelledby-overrides-label.html: Updated.
  • accessibility/aria-labelledby-stay-within-expected.txt: Updated.
  • accessibility/aria-labelledby-stay-within.html: Updated.
  • accessibility/aria-labelledby-with-descendants-expected.txt: Updated.
  • accessibility/aria-labelledby-with-descendants.html: Updated.
  • accessibility/aria-namefrom-author-expected.txt: Updated.
  • accessibility/aria-namefrom-author.html: Updated.
  • accessibility/aria-text-role-expected.txt: Updated.
  • accessibility/aria-text-role.html: Updated.
  • accessibility/canvas-description-and-role-expected.txt: Updated.
  • accessibility/canvas-description-and-role.html: Updated.
  • accessibility/canvas-fallback-content.html: Updated.
  • accessibility/empty-image-with-title-expected.txt: Updated.
  • accessibility/empty-image-with-title.html: Updated.
  • accessibility/fieldset-element-expected.txt: Updated.
  • accessibility/fieldset-element.html: Updated.
  • accessibility/focusable-div-expected.txt: Updated.
  • accessibility/focusable-div.html: Updated.
  • accessibility/help-text.html: Updated.
  • accessibility/img-alt-tag-only-whitespace-expected.txt: Updated.
  • accessibility/img-alt-tag-only-whitespace.html: Updated.
  • accessibility/img-aria-button-alt-tag-expected.txt: Updated.
  • accessibility/img-aria-button-alt-tag.html: Updated.
  • accessibility/img-fallsback-to-title.html: Updated.
  • accessibility/input-image-alt-expected.txt: Updated.
  • accessibility/input-image-alt.html: Updated.
  • accessibility/loading-iframe-sends-notification.html: Updated.
  • accessibility/self-referencing-aria-labelledby-expected.txt: Updated.
  • accessibility/self-referencing-aria-labelledby.html: Updated.
  • accessibility/svg-bounds.html: Updated.
  • accessibility/svg-group-element-with-title-expected.txt: Updated.
  • accessibility/svg-group-element-with-title.html: Updated.
  • accessibility/svg-image-expected.txt: Updated.
  • accessibility/svg-image.html: Updated.
  • accessibility/svg-labelledby-expected.txt: Updated.
  • accessibility/svg-labelledby.html: Updated.
  • accessibility/svg-remote-element.html: Updated.
  • accessibility/w3c-svg-description-calculation.html: Updated.
  • accessibility/w3c-svg-name-calculation.html: Updated.
  • platform/gtk/accessibility/alt-tag-on-image-with-nonimage-role-expected.txt: Removed.
  • platform/gtk/accessibility/aria-labeled-with-hidden-node-expected.txt: Removed.
  • platform/gtk/accessibility/aria-labelledby-on-input-expected.txt: Removed.
  • platform/gtk/accessibility/aria-labelledby-overrides-aria-labeledby-expected.txt: Removed.
  • platform/gtk/accessibility/aria-labelledby-overrides-label-expected.txt: Updated.
  • platform/gtk/accessibility/aria-labelledby-with-descendants-expected.txt: Removed.
  • platform/gtk/accessibility/aria-namefrom-author-expected.txt: Removed.
  • platform/gtk/accessibility/aria-text-role-expected.txt: Removed.
  • platform/gtk/accessibility/canvas-description-and-role-expected.txt: Updated.
  • platform/gtk/accessibility/empty-image-with-title-expected.txt: Updated.
  • platform/gtk/accessibility/fieldset-element-expected.txt: Removed.
  • platform/gtk/accessibility/focusable-div-expected.txt: Removed.
  • platform/gtk/accessibility/img-alt-tag-only-whitespace-expected.txt: Removed.
  • platform/gtk/accessibility/img-aria-button-alt-tag-expected.txt: Removed.
  • platform/gtk/accessibility/img-fallsback-to-title-expected.txt: Updated.
  • platform/gtk/accessibility/input-image-alt-expected.txt: Removed.
  • platform/gtk/accessibility/self-referencing-aria-labelledby-expected.txt: Removed.
  • platform/gtk/accessibility/svg-group-element-with-title-expected.txt: Removed.
  • platform/gtk/accessibility/svg-image-expected.txt: Removed.
  • platform/gtk/accessibility/svg-labelledby-expected.txt: Removed.
  • platform/mac/accessibility/aria-help-expected.txt: Removed.
  • platform/mac/accessibility/aria-labelledby-overrides-label-expected.txt: Removed.
  • platform/mac/accessibility/canvas-description-and-role-expected.txt: Updated.
  • platform/mac/accessibility/fieldset-element-expected.txt: Removed.
  • platform/mac/accessibility/img-fallsback-to-title-expected.txt: Updated.
  • platform/win/accessibility/canvas-description-and-role-expected.txt: Updated.
  • resources/accessibility-helper.js:

(platformValueForW3CName): Added.
(platformValueForW3CDescription): Added.
(platformTextAlternatives): Added.
(platformRoleForComboBox): Added.
(platformRoleForStaticText): Added.

10:09 AM Changeset in webkit [201215] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Use clearer names for JSON output of javascriptcore test results
​https://bugs.webkit.org/show_bug.cgi?id=157921

Patch by Srinivasan Vijayaraghavan <​svijayaraghavan@apple.com> on 2016-05-20
Reviewed by Alexey Proskuryakov.

"failures" and "apiTestResult" were somewhat ambiguous names.

  • Scripts/run-javascriptcore-tests:

(runJSCStressTests): "failures" -> "stressFailures", "apiTestResult" -> "allApiTestsPassed".

10:02 AM Changeset in webkit [201214] by Chris Dumez
  • 2 edits in trunk/Tools

Unreviewed, fix API test introduced in r201213.

  • TestWebKitAPI/Tests/WTF/WeakPtr.cpp:

(TestWebKitAPI::TEST):

7:42 AM Changeset in webkit [201213] by commit-queue@webkit.org
  • 7 edits in trunk

Implement operator== for WeakPtr
​https://bugs.webkit.org/show_bug.cgi?id=157883

Patch by Rawinder Singh <​rawinder.singh-webkit@cisra.canon.com.au> on 2016-05-20
Reviewed by Chris Dumez.

Implement operator== and operator!= for WeakPtr and update code to use the operators.

Source/WebCore:

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::updateLastScrollbarUnderMouse):

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::platformCompleteWheelEvent):

Source/WTF:

  • wtf/WeakPtr.h:

(WTF::operator==):
(WTF::operator!=):

Tools:

  • TestWebKitAPI/Tests/WTF/WeakPtr.cpp:

(TestWebKitAPI::TEST):

Note: See TracTimeline for information about the timeline view.