⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 3, 2016:

8:28 PM Changeset in webkit [201678] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Source/JavaScriptCore

Eager FTL failure for strict comparison of NaN with number check
​https://bugs.webkit.org/show_bug.cgi?id=158368

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-06-03
Reviewed by Darin Adler.

DoupleRep with a RealNumberUse starts by handling double
then falls back to Int32 if the unboxed double is NaN.

Before handling integers, the code is checking if the input
is indeed an int32. The problem was that this check failed
to account for NaN as an original input of the DoubleRep.

The call to isNotInt32() filter the doubles checks because
that was handled by the previous block.
The problem is the previous block handles any double except NaN.
If the original input was NaN, the masking by "~SpecFullDouble"
filter that possibility and isNotInt32() fails to test that case.

This patch fixes the issue by changing the filter to SpecDoubleReal.
The type SpecDoubleReal does not include the NaN types.

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileDoubleRep):

  • tests/stress/double-rep-real-number-use-on-nan.js: Added.

To ensure the isNotInt32() does not test anything, we want
proven numbers as input. The (+value) are there to enforce
a ToNumber() which in turn give us a proven Number type.

7:04 PM Changeset in webkit [201677] by mmaxfield@apple.com
  • 5 edits
    2 adds in trunk

Bopomofo ruby in Dictionary.app is written horizontally (when it should be written vertically)
​https://bugs.webkit.org/show_bug.cgi?id=158245
<rdar://problem/25675318>

Reviewed by Darin Adler.

Source/WebCore:

With orthogonal flows, the inner element gets a logical width that is computed from two values:

  • The containing block's available logical height
  • The FrameView's visibleHeight

In Dictionary.app, the FrameView's height changes, but this element doesn't get relaid out.
This is because of our optimization where normal-flow elements don't get relaid out if their
parent's width doesn't change (which is the case here).

Therefore, this orthogonal writing mode element should be relaid out when the FrameView changes
size. Luckily, we already have machinery for doing this: percentage heights. In quirks mode, a
div with a percentage height may walk arbitrarily far up the DOM tree in order to determine which
element the percentage should be resolved against. Therefore, we have a map of percentage-sizing-
ancestors to percentage-sizing-descendants which speeds up this search. If a percentage-sizing-
ancestor gets relaid out, all the relevant percentage-sizing-descendants get relaid out too.

Therefore, we can simply mark the FrameView as a percentage-sizing-ancestor and the orthogonal
flow element as a percentage-sizing-descendant. The lifetime of this relationship is already
managed correctly - it gets reset when style changes and when the renderer is destroyed, and
is created during layout.

Unfortunately, this same treatment should also be done to the element which dictates the
containing block's logical height (which caused ​https://bugs.webkit.org/show_bug.cgi?id=158286).
Implementing this would require giving RenderBox::availableLogicalHeight() a second result
of the necessary element which dictates the return. In an effort to keep this patch small and
focused, I'll do this secondary (much larger) work in a patch on that bug. This patch,
therefore, is kept small and focused.

Test: fast/text/orthogonal-writing-mode-containing-block-frameView-resize-relayout.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight):

LayoutTests:

Rebaselined fast/table/border-collapsing/004-vertical.html to show a progression.

  • fast/text/orthogonal-writing-mode-containing-block-frameView-resize-relayout-expected.html: Added.
  • fast/text/orthogonal-writing-mode-containing-block-frameView-resize-relayout.html: Added.
  • platform/mac/fast/table/border-collapsing/004-vertical-expected.png: Rebased
  • platform/mac/fast/table/border-collapsing/004-vertical-expected.txt: Rebased
7:00 PM Changeset in webkit [201676] by mmaxfield@apple.com
  • 11 edits
    4 adds in trunk

Text not visible while external font downloading
​https://bugs.webkit.org/show_bug.cgi?id=25207
<rdar://problem/15167413>

Reviewed by Dean Jackson.

Source/WebCore:

I already laid the groundwork for this when implementing the CSS Font Loading API.
We only have to create a timer and correctly respond to it timing out (by setting
state).

This patch also adds a new internal setting which puts us in a mode where font
loads never complete and the timeout occurs immediately. This is so we can test
the fallback behavior.

Test: fast/text/web-font-load-fallback-during-loading.html

  • css/CSSFontFace.cpp:

(WebCore::CSSFontFace::CSSFontFace):
(WebCore::CSSFontFace::fontLoadEventOccurred):
(WebCore::CSSFontFace::timeoutFired):
(WebCore::CSSFontFace::setStatus):
(WebCore::CSSFontFace::fontLoaded):
(WebCore::CSSFontFace::webFontsShouldAlwaysFallBack):
(WebCore::CSSFontFace::pump):
(WebCore::CSSFontFace::font):

  • css/CSSFontFace.h:
  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::fontLoaded):

  • css/FontFace.cpp:

(WebCore::FontFace::fontStateChanged):

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setWebFontsAlwaysFallBack):

  • page/Settings.h:

(WebCore::Settings::webFontsAlwaysFallBack):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setWebFontsAlwaysFallBack):

  • testing/InternalSettings.h:
  • testing/InternalSettings.idl:

LayoutTests:

  • fast/text/web-font-load-fallback-during-loading-no-multiple-expected.txt: Added.
  • fast/text/web-font-load-fallback-during-loading-no-multiple.html: Added.
  • fast/text/web-font-load-fallback-during-loading-expected.html: Added.
  • fast/text/web-font-load-fallback-during-loading.html: Added.
6:31 PM Changeset in webkit [201675] by Chris Dumez
  • 12 edits in trunk/Source

Modernize a few more lambda captures
​https://bugs.webkit.org/show_bug.cgi?id=158370

Reviewed by Brady Eidson.

Source/WebCore:

  • workers/DedicatedWorkerGlobalScope.cpp:

(WebCore::DedicatedWorkerGlobalScope::postMessage):

  • workers/DedicatedWorkerGlobalScope.h:
  • workers/Worker.cpp:

(WebCore::Worker::postMessage):

  • workers/Worker.h:
  • workers/WorkerEventQueue.cpp:

(WebCore::WorkerEventQueue::enqueueEvent):

  • workers/WorkerGlobalScopeProxy.h:
  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::postMessageToWorkerGlobalScope):

  • workers/WorkerMessagingProxy.h:
  • workers/WorkerObjectProxy.h:

Source/WebKit:

  • Storage/StorageTracker.cpp:

(WebCore::StorageTracker::deleteOrigin):

6:08 PM Changeset in webkit [201674] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

JSON.stringify replacer function calls with numeric array indices
​https://bugs.webkit.org/show_bug.cgi?id=158262
Source/JavaScriptCore:

rdar://problem/26613876

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-06-03
Reviewed by Saam Barati.

The spec of SerializeJSONArray is pretty clear that the index
should be transformed into a string before calling SerializeJSONProperty.
See ​http://www.ecma-international.org/ecma-262/6.0/#sec-serializejsonarray

  • runtime/JSONObject.cpp:

(JSC::PropertyNameForFunctionCall::value):

LayoutTests:

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-06-03
Reviewed by Saam Barati.

  • js/JSON-stringify-exposes-array-indices-as-strings-expected.txt: Added.
  • js/JSON-stringify-exposes-array-indices-as-strings.html: Added.
  • js/script-tests/JSON-stringify-exposes-array-indices-as-strings.js: Added.

(replacer):
(testObject.toJSON):
(toJSONArrayHelper):

  • js/resources/JSON-stringify.js:
  • js/dom/JSON-stringify-expected.txt:

Update the test results for the native implementation.

5:56 PM Changeset in webkit [201673] by commit-queue@webkit.org
  • 55 edits
    1 move in trunk/Source

Unreviewed, rolling out r201663.
​https://bugs.webkit.org/show_bug.cgi?id=158374

Broke the Windows build (Requested by andersca on #webkit).

Reverted changeset:

"Rename NoncopyableFunction to Function"
​https://bugs.webkit.org/show_bug.cgi?id=158354
​http://trac.webkit.org/changeset/201663

5:34 PM Changeset in webkit [201672] by sbarati@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Proxy.ownKeys should no longer throw an exception when duplicate keys are returned and the target is non-extensible
​https://bugs.webkit.org/show_bug.cgi?id=158350
<rdar://problem/26626211>

Reviewed by Michael Saboff.

The spec was recently changes in Proxy OwnPropertyKeys
to allow for duplicate property names under certain circumstances.
This patch fixes our implementation to match the spec.
See: ​https://github.com/tc39/ecma262/pull/594

  • runtime/ProxyObject.cpp:

(JSC::ProxyObject::performGetOwnPropertyNames):

  • tests/stress/proxy-own-keys.js:

(i.catch):
(ownKeys):
(assert):

5:04 PM Changeset in webkit [201671] by BJ Burg
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: add a keyboard shortcut to close the current tab bar item
​https://bugs.webkit.org/show_bug.cgi?id=158363
<rdar://problem/22677254>

Reviewed by Timothy Hatcher.

Make Cmd-w close the current tab. This matches Safari's keyboard shortcut.

  • UserInterface/Views/TabBrowser.js:

(WebInspector.TabBrowser):
Don't do anything if the New Tab tab is the only tab bar item besides the
pinned "new tab" button.

4:51 PM Changeset in webkit [201670] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Some shadow chicken code is wrong when run on a big endian CPU
​https://bugs.webkit.org/show_bug.cgi?id=158361

Reviewed by Mark Lam.

This code was wrong on a big endian CPU, and it was
also an anti-pattern in the file. The code was harmless
on a little endian CPU, but it's better to remove it.

  • llint/LowLevelInterpreter64.asm:
4:27 PM Changeset in webkit [201669] by BJ Burg
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: setter for debugging flag InspectorBackend.dumpInspectorTimeStats does not work
​https://bugs.webkit.org/show_bug.cgi?id=158366

Reviewed by Timothy Hatcher.

  • UserInterface/Protocol/InspectorBackend.js:

(InspectorBackendClass.prototype.set dumpInspectorTimeStats):
Actually update the backing member when the setter is called.

4:06 PM Changeset in webkit [201668] by keith_miller@apple.com
  • 26 edits
    1 add in trunk/Source/JavaScriptCore

Add argument_count bytecode for concat
​https://bugs.webkit.org/show_bug.cgi?id=158358

Reviewed by Geoffrey Garen.

This patch adds a new argument count bytecode. Normally, we would
just make sure that the argument.length bytecode was fast enough
that we shouldn't need such an bytecode. However, for the case of
Array.prototype.concat the overhead of the arguments object
allocation in the LLInt was too high and caused regressions.

  • bytecode/BytecodeIntrinsicRegistry.h:
  • bytecode/BytecodeList.json:
  • bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):

  • bytecompiler/NodesCodegen.cpp:

(JSC::BytecodeIntrinsicNode::emit_intrinsic_argumentCount):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getArgumentCount):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_argument_count):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • tests/stress/argument-count-bytecode.js: Added.

(inlineCount):
(inlineCount1):
(inlineCount2):
(inlineCountVarArgs):
(assert):

4:01 PM Changeset in webkit [201667] by rniwa@webkit.org
  • 7 edits
    2 adds in trunk

Crash under VisibleSelection::firstRange()
​https://bugs.webkit.org/show_bug.cgi?id=158241

Reviewed by Enrica Casucci.

Source/WebCore:

The crash was commonly caused by parentAnchoredEquivalent returning null when the anchored node was a shadow root.
Fixed it by returning a shadow root in parentAnchoredEquivalent.

Also guard against other kinds of crashes by adding a null check in VisibleSelection::firstRange() since we've seen
a crash in the same code path outside of a shadow tree.

This patch also fixes other Position methods to stop using nonShadowBoundaryParentNode in place of parentNode as
that would cause a similar crash and/or a bug elsewhere.

Test: fast/shadow-dom/selection-at-shadow-root-crash.html

  • accessibility/AXObjectCache.cpp:

(AXObjectCache::startCharacterOffsetOfParagraph): Fixed a bug uncovered by the assertion fix in Position::Position.
This code was sometimes creating a position inside a BR, which is wrong.
(AXObjectCache::endCharacterOffsetOfParagraph): Ditto.

  • dom/Position.cpp:

(WebCore::Position::Position): Fixed an assertion which was checking that this constructor wasn't being called

with m_anchorNode set to an element editing ignores content of.
ing it with isShadowRoot() made this assertion

useless because it's true whenever m_anchorNode is not a shadow root.
(WebCore::Position::containerNode): Use parentNode() instead of findParent() which calls nonShadowBoundaryParentNode
since Position should
(WebCore::Position::parentAnchoredEquivalent): Fixed the bug by letting this function return a shadow root.
(WebCore::Position::previous): Use parentNode() instead of findParent().
(WebCore::Position::next): Ditto.
(WebCore::Position::atStartOfTree): Ditto.
(WebCore::Position::atEndOfTree): Ditto.
(WebCore::Position::findParent): Deleted.

  • dom/Position.h:
  • editing/VisibleSelection.cpp:

(VisibleSelection::firstRange): Added a null check.

LayoutTests:

Added a regression test.

  • fast/shadow-dom/selection-at-shadow-root-crash-expected.txt: Added.
  • fast/shadow-dom/selection-at-shadow-root-crash.html: Added.
3:47 PM Changeset in webkit [201666] by Alan Bujtas
  • 3 edits
    2 adds in trunk

Incorrect rendering on boostmobile FAQ page
​https://bugs.webkit.org/show_bug.cgi?id=158303
<rdar://problem/26603462>

Reviewed by Chris Dumez.

Initial value for background-color is 'transparent'. see ​https://drafts.csswg.org/css-backgrounds-3/#background-color

Source/WebCore:

Test: fast/selectors/non-visited-link-backround-color.html

  • css/CSSPropertyNames.in:

LayoutTests:

  • fast/selectors/non-visited-link-backround-color-expected.html: Added.
  • fast/selectors/non-visited-link-backround-color.html: Added.
3:31 PM Changeset in webkit [201665] by beidson@apple.com
  • 8 edits in trunk/Source/WebCore

More miscellaneous IDBBindingUtilities cleanup.
​https://bugs.webkit.org/show_bug.cgi?id=158359

Reviewed by Tim Horton.

No new tests (Straight refactor, yo).

Replace more ScriptExecutionContext&s with ExecState&s.
Combine more unnecessarily separate functions.
Remove some cruft.

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::setGetResult):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::setResult):
(WebCore::IDBRequest::setResultToStructuredClone):

  • Modules/indexeddb/server/MemoryObjectStore.cpp:

(WebCore::IDBServer::MemoryObjectStore::updateIndexesForPutRecord):
(WebCore::IDBServer::MemoryObjectStore::populateIndexWithExistingRecords):

  • Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::updateOneIndexForAddRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::updateAllIndexesForAddRecord):

  • Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::performPutOrAdd):

  • bindings/js/IDBBindingUtilities.cpp:

(WebCore::deserializeIDBValueToJSValue):
(WebCore::idbKeyDataToScriptValue):
(WebCore::deserializeIDBValueDataToJSValue): Deleted.

  • bindings/js/IDBBindingUtilities.h:
3:26 PM Changeset in webkit [201664] by Chris Dumez
  • 10 edits in trunk

CanvasRenderingContext2D.createPattern() / putImageData() throw wrong exception type
​https://bugs.webkit.org/show_bug.cgi?id=158322

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline test now that it is passing.

  • canvas/2d.pattern.image.undefined-expected.txt:

Source/WebCore:

CanvasRenderingContext2D.createPattern() / putImageData() were throwing the wrong
exception type when the first parameter was null. It should throw a TypeError
but it was throwing a legacy TYPE_MISMATCH_ERR:

This patch aligns our behavior with the specification.

No new tests, covered by existing tests.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::createPattern):
(WebCore::CanvasRenderingContext2D::putImageData):
(WebCore::CanvasRenderingContext2D::webkitPutImageDataHD):
(WebCore::CanvasRenderingContext2D::didDraw): Deleted.
(WebCore::CanvasRenderingContext2D::drawFocusIfNeeded): Deleted.
(WebCore::CanvasRenderingContext2D::drawFocusIfNeededInternal): Deleted.
(WebCore::CanvasRenderingContext2D::font): Deleted.

  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasRenderingContext2D.idl:

LayoutTests:

Update several outdated layout tests.

  • canvas/philip/tests/2d.imageData.put.null.html:
  • canvas/philip/tests/2d.pattern.image.null.html:
  • canvas/philip/tests/2d.pattern.image.undefined.html:
3:24 PM Changeset in webkit [201663] by andersca@apple.com
  • 55 edits
    1 move in trunk/Source

Rename NoncopyableFunction to Function
​https://bugs.webkit.org/show_bug.cgi?id=158354

Reviewed by Chris Dumez.

Source/WebCore:

  • Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::MediaEndpointPeerConnection::runTask):

  • Modules/mediastream/MediaEndpointPeerConnection.h:
  • Modules/webaudio/AudioDestinationNode.h:

(WebCore::AudioDestinationNode::resume):
(WebCore::AudioDestinationNode::suspend):
(WebCore::AudioDestinationNode::close):

  • Modules/webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::resume):
(WebCore::DefaultAudioDestinationNode::suspend):
(WebCore::DefaultAudioDestinationNode::close):

  • Modules/webaudio/DefaultAudioDestinationNode.h:
  • dom/ActiveDOMCallbackMicrotask.cpp:

(WebCore::ActiveDOMCallbackMicrotask::ActiveDOMCallbackMicrotask):

  • dom/ActiveDOMCallbackMicrotask.h:
  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::Task::Task):

  • fileapi/AsyncFileStream.cpp:

(WebCore::callOnFileThread):
(WebCore::AsyncFileStream::perform):

  • fileapi/AsyncFileStream.h:
  • page/FrameView.cpp:

(WebCore::FrameView::queuePostLayoutCallback):
(WebCore::FrameView::flushPostLayoutTasksQueue):

  • page/FrameView.h:
  • page/scrolling/ScrollingThread.cpp:

(WebCore::ScrollingThread::dispatch):
(WebCore::ScrollingThread::dispatchBarrier):
(WebCore::ScrollingThread::dispatchFunctionsFromScrollingThread):

  • page/scrolling/ScrollingThread.h:
  • platform/GenericTaskQueue.cpp:

(WebCore::TaskDispatcher<Timer>::postTask):

  • platform/GenericTaskQueue.h:

(WebCore::TaskDispatcher::postTask):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::scheduleDeferredTask):

  • platform/mediastream/MediaStreamPrivate.cpp:

(WebCore::MediaStreamPrivate::scheduleDeferredTask):

  • platform/mediastream/MediaStreamPrivate.h:
  • platform/mediastream/mac/AVMediaCaptureSource.h:
  • platform/mediastream/mac/AVMediaCaptureSource.mm:

(WebCore::AVMediaCaptureSource::scheduleDeferredTask):

  • style/StyleTreeResolver.cpp:

(WebCore::Style::postResolutionCallbackQueue):
(WebCore::Style::queuePostResolutionCallback):

  • style/StyleTreeResolver.h:

Source/WebKit:

  • Storage/StorageSyncManager.cpp:

(WebCore::StorageSyncManager::dispatch):

  • Storage/StorageSyncManager.h:
  • Storage/StorageThread.cpp:

(WebCore::StorageThread::dispatch):
(WebCore::StorageThread::terminate):

  • Storage/StorageThread.h:

Source/WebKit2:

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::fetchDiskCacheEntries):
(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::clearDiskCacheEntries):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::traverse):

  • NetworkProcess/cache/NetworkCache.h:
  • NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:

(WebKit::NetworkCache::runTaskInQueue):

  • NetworkProcess/cache/NetworkCacheStorage.h:

Source/WTF:

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CrossThreadTask.h:

(WTF::CrossThreadTask::CrossThreadTask):

  • wtf/Function.h: Renamed from Source/WTF/wtf/NoncopyableFunction.h.
  • wtf/FunctionDispatcher.h:
  • wtf/MainThread.cpp:

(WTF::functionQueue):
(WTF::dispatchFunctionsFromMainThread):
(WTF::callOnMainThread):

  • wtf/MainThread.h:
  • wtf/RunLoop.cpp:

(WTF::RunLoop::performWork):
(WTF::RunLoop::dispatch):

  • wtf/RunLoop.h:
  • wtf/WorkQueue.h:
  • wtf/cocoa/WorkQueueCocoa.cpp:

(WTF::WorkQueue::dispatch):
(WTF::WorkQueue::dispatchAfter):

  • wtf/efl/DispatchQueueWorkItemEfl.h:

(WorkItem::WorkItem):
(TimerWorkItem::create):
(TimerWorkItem::TimerWorkItem):

  • wtf/efl/WorkQueueEfl.cpp:

(WTF::WorkQueue::dispatch):
(WTF::WorkQueue::dispatchAfter):

  • wtf/generic/RunLoopGeneric.cpp:

(WTF::RunLoop::TimerBase::ScheduledTask::create):
(WTF::RunLoop::TimerBase::ScheduledTask::ScheduledTask):
(WTF::RunLoop::dispatchAfter):

  • wtf/generic/WorkQueueGeneric.cpp:

(WorkQueue::dispatch):
(WorkQueue::dispatchAfter):

  • wtf/glib/RunLoopGLib.cpp:

(WTF::DispatchAfterContext::DispatchAfterContext):
(WTF::RunLoop::dispatchAfter):

  • wtf/win/WorkItemWin.cpp:

(WTF::WorkItemWin::WorkItemWin):
(WTF::WorkItemWin::create):
(WTF::HandleWorkItem::HandleWorkItem):
(WTF::HandleWorkItem::createByAdoptingHandle):

  • wtf/win/WorkItemWin.h:

(WTF::WorkItemWin::function):

  • wtf/win/WorkQueueWin.cpp:

(WTF::WorkQueue::dispatch):
(WTF::WorkQueue::dispatchAfter):

3:05 PM Changeset in webkit [201662] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Marking fast/scrolling/scroll-container-horizontally.html as flaky on mac-wk2 and ios-simulator-wk1
​https://bugs.webkit.org/show_bug.cgi?id=158237

Unreviewed test gardening.

  • platform/ios-simulator-wk1/TestExpectations:
  • platform/mac-wk2/TestExpectations:
2:59 PM Changeset in webkit [201661] by adachan@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(r201474): Subtitles are not resizing in other fullscreen modes
​https://bugs.webkit.org/show_bug.cgi?id=158355

Reviewed by Eric Carlson.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::syncTextTrackBounds):
Set the text track representation layer's frame based on the active video layer.

2:42 PM Changeset in webkit [201660] by beidson@apple.com
  • 10 edits in trunk/Source/WebCore

Miscellaneous IDBBindingUtilities cleanup.
​https://bugs.webkit.org/show_bug.cgi?id=158353

Reviewed by Tim Horton.

No new tests (Straight refactor, yo).

Starting with removing a single form of scriptValueToIDBKey(), and making the return value be
Ref<IDBKey> instead of RefPtr<IDBKey>, update a whole bunch of code to understand that the ExecState
is non-null and the resulting key is non-null.

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::continueFunction):

  • Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::cmp):

  • Modules/indexeddb/IDBIndex.cpp:

(WebCore::IDBIndex::count):
(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):

  • Modules/indexeddb/IDBKey.cpp:

(WebCore::IDBKey::compare):
(WebCore::IDBKey::isLessThan):
(WebCore::IDBKey::isEqual):

  • Modules/indexeddb/IDBKey.h:

(WebCore::IDBKey::createMultiEntryArray):

  • Modules/indexeddb/IDBKeyRange.cpp:

(WebCore::IDBKeyRange::only):
(WebCore::IDBKeyRange::lowerBound):
(WebCore::IDBKeyRange::upperBound):
(WebCore::IDBKeyRange::bound):
(WebCore::IDBKeyRange::isOnlyKey):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::modernDelete):
(WebCore::IDBObjectStore::count):

  • bindings/js/IDBBindingUtilities.cpp:

(WebCore::get):
(WebCore::set):
(WebCore::createIDBKeyFromValue):
(WebCore::getNthValueOnKeyPath):
(WebCore::internalCreateIDBKeyFromScriptValueAndKeyPath):
(WebCore::ensureNthValueOnKeyPath):
(WebCore::canInjectNthValueOnKeyPath):
(WebCore::injectIDBKeyIntoScriptValue):
(WebCore::maybeCreateIDBKeyFromScriptValueAndKeyPath):
(WebCore::canInjectIDBKeyIntoScriptValue):
(WebCore::deserializeIDBValueToJSValue):
(WebCore::scriptValueToIDBKey):
(WebCore::createKeyPathArray):

  • bindings/js/IDBBindingUtilities.h:
2:36 PM Changeset in webkit [201659] by benjamin@webkit.org
  • 8 edits
    2 moves in trunk/Source/WebCore

Rename CheckedRadioButtons into RadioButtonGroups
​https://bugs.webkit.org/show_bug.cgi?id=158326

Reviewed by Alex Christensen.

CheckedRadioButtons handles the set of all the Radio Button Groups
for a particular form or document.
The name is wrong and apparently comes from former uses of this class
(see the comment above the class declaration).

This patch renames "CheckedRadioButtons" to "RadioButtonGroups" to reflect that it handles
all the Radio Button Group from a given context (form or document).
Internally it has a set of RadioButtonGroup but that is never explicitely
exposed.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/CheckedRadioButtons.cpp:

(WebCore::RadioButtonGroup::isEmpty): Deleted.
(WebCore::RadioButtonGroup::isRequired): Deleted.
(WebCore::RadioButtonGroup::checkedButton): Deleted.
(WebCore::RadioButtonGroup::RadioButtonGroup): Deleted.
(WebCore::RadioButtonGroup::isValid): Deleted.
(WebCore::RadioButtonGroup::members): Deleted.
(WebCore::RadioButtonGroup::setCheckedButton): Deleted.
(WebCore::RadioButtonGroup::add): Deleted.
(WebCore::RadioButtonGroup::updateCheckedState): Deleted.
(WebCore::RadioButtonGroup::requiredAttributeChanged): Deleted.
(WebCore::RadioButtonGroup::remove): Deleted.
(WebCore::RadioButtonGroup::updateValidityForAllButtons): Deleted.
(WebCore::RadioButtonGroup::contains): Deleted.
(WebCore::CheckedRadioButtons::CheckedRadioButtons): Deleted.
(WebCore::CheckedRadioButtons::~CheckedRadioButtons): Deleted.
(WebCore::CheckedRadioButtons::addButton): Deleted.
(WebCore::CheckedRadioButtons::groupMembers): Deleted.
(WebCore::CheckedRadioButtons::updateCheckedState): Deleted.
(WebCore::CheckedRadioButtons::requiredAttributeChanged): Deleted.
(WebCore::CheckedRadioButtons::checkedButtonForGroup): Deleted.
(WebCore::CheckedRadioButtons::isInRequiredGroup): Deleted.
(WebCore::CheckedRadioButtons::removeButton): Deleted.

  • dom/RadioButtonGroups.cpp: Renamed from Source/WebCore/dom/CheckedRadioButtons.cpp.

(WebCore::RadioButtonGroup::isEmpty):
(WebCore::RadioButtonGroup::isRequired):
(WebCore::RadioButtonGroup::checkedButton):
(WebCore::RadioButtonGroup::RadioButtonGroup):
(WebCore::RadioButtonGroup::isValid):
(WebCore::RadioButtonGroup::members):
(WebCore::RadioButtonGroup::setCheckedButton):
(WebCore::RadioButtonGroup::add):
(WebCore::RadioButtonGroup::updateCheckedState):
(WebCore::RadioButtonGroup::requiredAttributeChanged):
(WebCore::RadioButtonGroup::remove):
(WebCore::RadioButtonGroup::updateValidityForAllButtons):
(WebCore::RadioButtonGroup::contains):
(WebCore::RadioButtonGroups::RadioButtonGroups):
(WebCore::RadioButtonGroups::~RadioButtonGroups):
(WebCore::RadioButtonGroups::addButton):
(WebCore::RadioButtonGroups::groupMembers):
(WebCore::RadioButtonGroups::updateCheckedState):
(WebCore::RadioButtonGroups::requiredAttributeChanged):
(WebCore::RadioButtonGroups::checkedButtonForGroup):
(WebCore::RadioButtonGroups::isInRequiredGroup):
(WebCore::RadioButtonGroups::removeButton):

  • dom/RadioButtonGroups.h: Renamed from Source/WebCore/dom/CheckedRadioButtons.h.
  • html/FormController.h:

(WebCore::FormController::radioButtonGroups):
(WebCore::FormController::checkedRadioButtons): Deleted.

  • html/HTMLFormElement.h:
  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::~HTMLInputElement):
(WebCore::HTMLInputElement::setChecked):
(WebCore::HTMLInputElement::didMoveToNewDocument):
(WebCore::HTMLInputElement::requiredAttributeChanged):
(WebCore::HTMLInputElement::isInRequiredRadioButtonGroup):
(WebCore::HTMLInputElement::radioButtonGroup):
(WebCore::HTMLInputElement::checkedRadioButtonForGroup):
(WebCore::HTMLInputElement::radioButtonGroups):
(WebCore::HTMLInputElement::addToRadioButtonGroup):
(WebCore::HTMLInputElement::removeFromRadioButtonGroup):
(WebCore::HTMLInputElement::checkedRadioButtons): Deleted.

  • html/HTMLInputElement.h:
2:35 PM Changeset in webkit [201658] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove unused WebInspector.CSSCompletions methods
​https://bugs.webkit.org/show_bug.cgi?id=158352

Reviewed by Joseph Pecoraro.

  • UserInterface/Models/CSSCompletions.js:

(WebInspector.CSSCompletions.prototype.firstStartsWith): Deleted.
(WebInspector.CSSCompletions.prototype.isLonghandPropertyName): Deleted.
(WebInspector.CSSCompletions.prototype.longhandsForShorthand): Deleted.

2:26 PM Changeset in webkit [201657] by ggaren@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Clients of PolymorphicAccess::addCases shouldn't have to malloc
​https://bugs.webkit.org/show_bug.cgi?id=158357

Reviewed by Keith Miller.

We only ever have 1 or 2 cases, so we can use inline Vector capacity.

This shows up a little in the JSBench profile.

  • bytecode/PolymorphicAccess.cpp:

(JSC::PolymorphicAccess::addCases):
(JSC::PolymorphicAccess::addCase):

  • bytecode/PolymorphicAccess.h:
  • bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::addAccessCase):

2:13 PM Changeset in webkit [201656] by benjamin@webkit.org
  • 6 edits in trunk/Source/JavaScriptCore

Fix some more INFINITI->INFINITY typos

Unreviewed.

The tests were not covering the edge cases they were supposed to test.

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-06-03

  • tests/stress/math-ceil-basics.js:

(testMathCeilOnConstants):

  • tests/stress/math-clz32-basics.js:

(testMathClz32OnDoubles):
(testMathClz32OnConstants):

  • tests/stress/math-floor-basics.js:

(testMathFloorOnConstants):

  • tests/stress/math-round-basics.js:

(testMathRoundOnConstants):

  • tests/stress/math-trunc-basics.js:

(testMathTruncOnConstants):

1:59 PM Changeset in webkit [201655] by Chris Dumez
  • 14 edits in trunk/Source

Unreviewed, roll out r196633 as it broke PageCache on iOS for WebKit.org
<rdar://problem/26521101>

Source/WebCore:

  • dom/Document.cpp:

(WebCore::Document::setInPageCache): Deleted.

  • history/CachedPage.cpp:

(WebCore::CachedPage::restore):
(WebCore::CachedPage::clear):

  • history/CachedPage.h:

(WebCore::CachedPage::markForVisitedLinkStyleRecalc):
(WebCore::CachedPage::markForFullStyleRecalc):

  • history/PageCache.cpp:

(WebCore::PageCache::markPagesForVisitedLinkStyleRecalc):
(WebCore::PageCache::markPagesForFullStyleRecalc):

  • history/PageCache.h:
  • page/Frame.cpp:

(WebCore::Frame::setPageAndTextZoomFactors):

  • page/Page.cpp:

(WebCore::Page::setViewScaleFactor):
(WebCore::Page::setDeviceScaleFactor):
(WebCore::Page::setPagination):
(WebCore::Page::setPaginationLineGridEnabled):
(WebCore::Page::setVisitedLinkStore):

Source/WebKit/mac:

  • WebCoreSupport/WebVisitedLinkStore.mm:

(WebVisitedLinkStore::removeAllVisitedLinks):
(WebVisitedLinkStore::removeVisitedLink):
(WebVisitedLinkStore::addVisitedLinkHash):

Source/WebKit/win:

  • WebCoreSupport/WebVisitedLinkStore.cpp:

(WebVisitedLinkStore::removeAllVisitedLinks):
(WebVisitedLinkStore::addVisitedLinkHash):

Source/WebKit2:

  • WebProcess/WebPage/VisitedLinkTableController.cpp:

(WebKit::VisitedLinkTableController::setVisitedLinkTable):
(WebKit::VisitedLinkTableController::visitedLinkStateChanged):
(WebKit::VisitedLinkTableController::allVisitedLinkStateChanged):
(WebKit::VisitedLinkTableController::removeAllVisitedLinks):

1:12 PM Changeset in webkit [201654] by barraclough@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

JSGlobalObject::addFunction should call deleteProperty rather than removeDirect
​https://bugs.webkit.org/show_bug.cgi?id=158295

Reviewed by Saam Barati.

When a function in declared in program code, this replaces any previosly existing
property from the global object. JSGlobalObject::addFunction is currently calling
removeDirect rather than deleteProperty to remove the existing property. This fails
to remove any properties from static tables.

We currently get away with this because (a) JSObject & JSGlobalObject don't currently
have any properties in static tables, and (b) the current quirky property precedence
means that the symbol table properties end up taking precedence over JSDOMWindow's
static table, so window object properties end up being shadowed.

As a part of bug #158178 the precedence of static tables will change, requiring this
to be fixed.

The deleteProperty function does what we want (has the ability to remove properties,
including those from the static tables). Normally deleteProperty will not remove
properties that are non-configurable (DontDelete) - we need to do so. The function
does already support this, through a flag on VM named 'isInDefineOwnProperty', which
causes configurability to be ignored. Generalize this mechanism for use outside of
defineOwnProperty, renaming & moving DefineOwnPropertyScope helper class out to VM.

  • runtime/JSFunction.cpp:

(JSC::JSFunction::deleteProperty):

  • isInDefineOwnProperty -> deletePropertyMode.
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::addFunction):

  • removeDirect -> deleteProperty.
  • runtime/JSObject.cpp:

(JSC::JSObject::deleteProperty):

  • isInDefineOwnProperty -> deletePropertyMode.

(JSC::JSObject::defineOwnNonIndexProperty):

  • DefineOwnPropertyScope -> VM::DeletePropertyModeScope.

(JSC::DefineOwnPropertyScope::DefineOwnPropertyScope): Deleted.
(JSC::DefineOwnPropertyScope::~DefineOwnPropertyScope): Deleted.

  • DefineOwnPropertyScope -> VM::DeletePropertyModeScope.
  • runtime/VM.cpp:

(JSC::VM::VM):

  • removed m_inDefineOwnProperty.
  • runtime/VM.h:

(JSC::VM::deletePropertyMode):

  • isInDefineOwnProperty -> deletePropertyMode.

(JSC::VM::DeletePropertyModeScope::DeletePropertyModeScope):
(JSC::VM::DeletePropertyModeScope::~DeletePropertyModeScope):

  • DefineOwnPropertyScope -> VM::DeletePropertyModeScope.

(JSC::VM::setInDefineOwnProperty): Deleted.

  • Replaced with deletePropertyMode, can now only be set via VM::DeletePropertyModeScope.

(JSC::VM::isInDefineOwnProperty): Deleted.

  • isInDefineOwnProperty -> deletePropertyMode.
12:54 PM Changeset in webkit [201653] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

LayoutTest imported/w3c/indexeddb/idbcursor-advance-continue-async.htm is flaky on Yosemite WK2
​https://bugs.webkit.org/show_bug.cgi?id=154606

Reviewed by Alex Christensen.

  • platform/mac-wk2/TestExpectations: Remove expectations. Test has been working great for quite awhile.
12:28 PM Changeset in webkit [201652] by beidson@apple.com
  • 5 edits in trunk/LayoutTests

storage/indexeddb/intversion-open-in-upgradeneeded.html is flaky on mac.
​https://bugs.webkit.org/show_bug.cgi?id=155050

Reviewed by Alex Christensen.

The test no longer crashes/times out, but it does have text failures.
Resolve them by removing a race in the test itself.

  • platform/mac-wk2/TestExpectations:
  • storage/indexeddb/intversion-open-in-upgradeneeded-expected.txt:
  • storage/indexeddb/intversion-open-in-upgradeneeded-private-expected.txt:
  • storage/indexeddb/resources/intversion-open-in-upgradeneeded.js:
11:42 AM Changeset in webkit [201651] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ARMv7 vstm and vldm instructions can only operate on a maximum of 16 registers.
​https://bugs.webkit.org/show_bug.cgi?id=158349

Reviewed by Filip Pizlo.

According to the ARM Assembler Reference, the vstm and vldm instructions can only
operate on a maximum of 16 registers. See
​http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dht0002a/ch01s03s02.html
and ​http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dht0002a/ch01s03s02.html.

The ARMv7 probe code was wrongly using these instructions to store and load all
32 'd' registers. This is now fixed.

  • assembler/MacroAssemblerARMv7.cpp:
11:36 AM Changeset in webkit [201650] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Update NativeFunctionParameters (FontFaceSet, HTMLSlotElement, EventTarget)
​https://bugs.webkit.org/show_bug.cgi?id=158333

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-03
Reviewed by Brian Burg.

  • UserInterface/Models/NativeFunctionParameters.js:

Replace FontLoader with FontFaceSet. Add HTMLSlotElement API.
EventTarget is now actually in the prototype chain, so add it as
a first class citizen and keep mixing it in for legacy backends.

11:22 AM Changeset in webkit [201649] by peavo@outlook.com
  • 2 edits in trunk/Source/WebKit/win

[Win] Implement WebView::removeAllUserContentFromGroup
​https://bugs.webkit.org/show_bug.cgi?id=158343

Reviewed by Brent Fulgham.

  • WebView.cpp:

(WebView::removeAllUserContentFromGroup):

11:13 AM Changeset in webkit [201648] by commit-queue@webkit.org
  • 5 edits
    8 adds in trunk

Reflection of element does not respect backdrop-filter property
​https://bugs.webkit.org/show_bug.cgi?id=158201

Patch by Antoine Quint <Antoine Quint> on 2016-06-03
Reviewed by Dean Jackson.

Source/WebCore:

We weren't cloning the PlatformCALayer for the backdrop so reflections would simply
not show their backdrops. We now follow the same pattern as other PlatformCALayers
owned by a GraphicsLayerCA and keep a list of backdrop layer clones that we add
to the structural layer when cloning to match the layer order of the original
and update the backdrop layer clone properties to match the original when the
backdrop filters or rectangle changes.

Tests: css3/filters/backdrop/backdrop-filter-with-reflection-add-backdrop.html

css3/filters/backdrop/backdrop-filter-with-reflection-remove-backdrop.html
css3/filters/backdrop/backdrop-filter-with-reflection-value-change.html
css3/filters/backdrop/backdrop-filter-with-reflection.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateBackdropFilters):
(WebCore::GraphicsLayerCA::updateBackdropFiltersRect):
Update backdrop layer clones to match new values set when the backdrop filter
configuration changes.

(WebCore::GraphicsLayerCA::ensureCloneLayers):
Create the backdrop layer clones map if needed and clone the existing backdrop layer.

(WebCore::GraphicsLayerCA::clearClones):
Clear the backdrop layer clones map.

(WebCore::GraphicsLayerCA::fetchCloneLayers):
Obtain a clone for the backdrop layer, and if we have a valid clone, add it to the
structural layer clone as its first child to match the operation in updateSublayerList().

  • platform/graphics/ca/GraphicsLayerCA.h:

Modify the signature for ensureCloneLayers() to account for the new backdrop layer clone and
declare the backdrop layer clone map.

  • platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(PlatformCALayerCocoa::clone):
Reflect the backdrop layer type when cloning a PlatformCALayer.

LayoutTests:

  • css3/filters/backdrop/backdrop-filter-with-reflection-add-backdrop-expected.html: Added.
  • css3/filters/backdrop/backdrop-filter-with-reflection-add-backdrop.html: Added.

Covers the case where a reflected element without a backdrop-filter initially has one added later.

  • css3/filters/backdrop/backdrop-filter-with-reflection-expected.html: Added.
  • css3/filters/backdrop/backdrop-filter-with-reflection-remove-backdrop-expected.html: Added.

Covers the case where a reflected element with a backdrop-filter initially has it removed later.

  • css3/filters/backdrop/backdrop-filter-with-reflection-remove-backdrop.html: Added.
  • css3/filters/backdrop/backdrop-filter-with-reflection-value-change-expected.html: Added.

Covers the case where a reflected element with a backdrop-filter has its backdrop-filter property changed later.

  • css3/filters/backdrop/backdrop-filter-with-reflection-value-change.html: Added.
  • css3/filters/backdrop/backdrop-filter-with-reflection.html: Added.

Covers the basic case of a reflected element with a backdrop-filter.

10:09 AM Changeset in webkit [201647] by beidson@apple.com
  • 3 edits in trunk/Source/WebCore

ResourceResponseBase cleanup.
​https://bugs.webkit.org/show_bug.cgi?id=158348

Reviewed by Chris Dumez.

No new tests (Refactor, no behavior change).

CrossThreadData can be noncopyable and WTFMove()'ed around, instead of
being in a unique_ptr.

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::crossThreadData):
(WebCore::ResourceResponseBase::fromCrossThreadData):

  • platform/network/ResourceResponseBase.h:
9:49 AM Changeset in webkit [201646] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Gardening: CLOOP build fix (needs a #include).

Not reviewed.

  • interpreter/StackVisitor.h:
9:43 AM Changeset in webkit [201645] by akling@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Eliminate two large sources of temporary StringImpl objects.
<​https://webkit.org/b/158336>

Reviewed by Anders Carlsson.

We were jumping through some inefficient hoops when creating Identifiers due to the
convenience of our String(const char*) constructor.

This patch avoids just over 1 million temporary StringImpl objects on the PLUM benchmark.

  • runtime/JSObject.h:

(JSC::makeIdentifier): Add an overload for string literals so we can stop creating a temporary
String just for passing to Identifier::fromString().

  • runtime/Lookup.h:

(JSC::reifyStaticProperties): Use the Identifier::fromString() that takes an LChar* and a length
instead of creating a temporary String.

9:32 AM Changeset in webkit [201644] by pvollan@apple.com
  • 2 edits in trunk

[Win] IndexedDB worker tests are failing.
​https://bugs.webkit.org/show_bug.cgi?id=158341

Reviewed by Alex Christensen.

Enable IndexedDB in workers.

  • Source/cmake/OptionsWin.cmake:
9:13 AM Changeset in webkit [201643] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

Fix the !ENABLE(INDEXED_DATABASE) build after r201575
​https://bugs.webkit.org/show_bug.cgi?id=158346

Reviewed by Brady Eidson.

  • DatabaseProcess/DatabaseProcess.cpp:

(WebKit::DatabaseProcess::fetchWebsiteData):
(WebKit::DatabaseProcess::deleteWebsiteData):
(WebKit::DatabaseProcess::deleteWebsiteDataForOrigins):

8:40 AM Changeset in webkit [201642] by youenn.fablet@crf.canon.fr
  • 2 edits in trunk/Tools

[GTK] Update YouCompleteMe script to make all include paths absolute
​https://bugs.webkit.org/show_bug.cgi?id=158301

Reviewed by Michael Catanzaro.

Before this patch, some include paths were not made absolute.
This could make YouCompleteMe plugin to fail extracting information or validating cpp files.

  • gtk/ycm_extra_conf.py:
7:53 AM Changeset in webkit [201641] by mark.lam@apple.com
  • 6 edits
    1 add in trunk/Source

Clean up how StackVisitor dumps its frames.
​https://bugs.webkit.org/show_bug.cgi?id=158316

Reviewed by Keith Miller.

Source/JavaScriptCore:

  1. Updated to do dumping to a PrintStream.
  2. Added support for printing a prefix for each frame. This is currently used by JSDollarVMPrototype to print frame numbers.
  3. Fix the incrementing of the frame index in StackVisitor. It was initialized but never incremented before when iterating the frames.
  • interpreter/StackVisitor.cpp:

(JSC::StackVisitor::gotoNextFrame):
(JSC::StackVisitor::Frame::codeType):
(JSC::StackVisitor::Frame::functionName):
(JSC::StackVisitor::Frame::sourceURL):
(JSC::StackVisitor::Frame::toString):
(JSC::StackVisitor::Frame::createArguments):
(JSC::StackVisitor::Frame::computeLineAndColumn):
(JSC::StackVisitor::Frame::retrieveExpressionInfo):
(JSC::StackVisitor::Frame::setToEnd):
(JSC::StackVisitor::Frame::dump):
(JSC::StackVisitor::Indent::dump):
(JSC::printIndents): Deleted.
(JSC::log): Deleted.
(JSC::logF): Deleted.
(JSC::StackVisitor::Frame::print): Deleted.

  • interpreter/StackVisitor.h:

(JSC::StackVisitor::Indent::Indent):
(JSC::StackVisitor::Indent::operator++):
(JSC::StackVisitor::Indent::operator--):
(JSC::StackVisitor::Frame::isJSFrame):
(JSC::StackVisitor::Frame::isInlinedFrame):
(JSC::StackVisitor::Frame::vmEntryFrame):
(JSC::StackVisitor::Frame::callFrame):
(JSC::StackVisitor::Frame::Frame):
(JSC::StackVisitor::Frame::~Frame):

  • tools/JSDollarVMPrototype.cpp:

(JSC::PrintFrameFunctor::operator()):

Source/WTF:

Added an Indenter class what works with dataLog.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/Indenter.h: Added.

(WTF::Indenter::Indenter):
(WTF::Indenter::dump):
(WTF::Indenter::operator++):
(WTF::Indenter::operator--):

2:03 AM Changeset in webkit [201640] by nael.ouedraogo@crf.canon.fr
  • 2 edits in trunk/Tools

Unreviewed: add myself to the committers list.

  • Scripts/webkitpy/common/config/contributors.json:
12:52 AM Changeset in webkit [201639] by commit-queue@webkit.org
  • 4 edits in trunk

REGRESSION: WebGL doesn't show up in CSS reflections
​https://bugs.webkit.org/show_bug.cgi?id=76489

Patch by Antoine Quint <Antoine Quint> on 2016-06-03
Reviewed by Dean Jackson.

Source/WebCore:

The WebGLLayer needs to notify its owning GraphicsLayer that it was displayed
such that its clones, in GraphicsLayerCA::layerDidDisplay, may have their contents
updated to match that layer's contents. The test at compositing/webgl/webgl-reflection.html
already covers this test and its expectation on Mac has been updated.

  • platform/graphics/mac/WebGLLayer.mm:

(-[WebGLLayer display]):

LayoutTests:

Update the expected rendering to contain the reflected WebGL <canvas>.

  • platform/mac/compositing/webgl/webgl-reflection-expected.png:
12:10 AM Changeset in webkit [201638] by barraclough@apple.com
  • 2 edits in trunk/Source/WebCore

Refactor showModalDialog handling in JSDOMWindowCustom
​https://bugs.webkit.org/show_bug.cgi?id=158294

Reviewed by Ryosuke Niwa.

The showModalDialog property is currently implemented in a way that effectively
results in duplication of the tail of the function, but modified to call
Base::getOwnPropertySlot instead of getStaticPropertySlot. It does so based on the
assumption that Base::getOwnPropertySlot is not going to search the static tables
(containing the property we wish to omit).

However as a part of bug #158178 I plan to change it such that Base::getOwnPropertySlot
does also search the static tables. So, refactoring this code to no longer depend on
using a function that bypasses the static tables. Always perform a lookup that will
check both property storage & static tables. If the object does contain the property,
then check explicitly for the value we're intending to suppress.

Covered by exsiting tests.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertySlot):

  • Check result of getStaticPropertySlot for showModalDialog function.

Jun 2, 2016:

10:40 PM Changeset in webkit [201637] by beidson@apple.com
  • 4 edits in trunk/Source/WebCore

Fix AtomicString regression caused by r201603.
​https://bugs.webkit.org/show_bug.cgi?id=158338

Reviewed by Chris Dumez.

No new tests (Refactor, plus already caught by existing test configs).

  • loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::crossThreadData): Re-introduce the cross thread data concept,

but more modern and clean this time.

(WebCore::ResourceResponseBase::fromCrossThreadData):
(WebCore::ResourceResponseBase::isolatedCopy): Deleted.

  • platform/network/ResourceResponseBase.h:
10:38 PM Changeset in webkit [201636] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Drop BlobRegistryContext class as it is no longer needed
​https://bugs.webkit.org/show_bug.cgi?id=158328

Reviewed by Brady Eidson.

Drop BlobRegistryContext class as it is no longer needed. We can now
call isolatedCopy() as we capture in the lambda.

  • fileapi/ThreadableBlobRegistry.cpp:

(WebCore::ThreadableBlobRegistry::registerFileBlobURL):
(WebCore::ThreadableBlobRegistry::registerBlobURL):
(WebCore::ThreadableBlobRegistry::registerBlobURLForSlice):
(WebCore::ThreadableBlobRegistry::blobSize):
(WebCore::ThreadableBlobRegistry::unregisterBlobURL):
(WebCore::BlobRegistryContext::BlobRegistryContext): Deleted.

10:27 PM Changeset in webkit [201635] by Alan Bujtas
  • 18 edits
    2 adds in trunk

Repaint issue with vertical text in an out of flow container.
​https://bugs.webkit.org/show_bug.cgi?id=102665
<rdar://problem/26605298>

Reviewed by David Hyatt.

Since the renderer’s offset for positioned objects is always physical, we only
need to flip the repaint rect(always logical) for writing root, when we see the first positioned object.
All subsequent writing root changes for positioned objects are okay and they don't need flipping.

Source/WebCore:

Test: fast/repaint/vertical-text-repaint.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeRectForRepaint):

  • rendering/RenderBox.h:

(WebCore::RenderBox::computeRectForRepaint):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::computeRectForRepaint):

  • rendering/RenderInline.h:

(WebCore::RenderInline::computeRectForRepaint):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::computeRectForRepaint):

  • rendering/RenderObject.h:

(WebCore::RenderObject::computeAbsoluteRepaintRect):
(WebCore::RenderObject::computeRectForRepaint):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::computeRectForRepaint):

  • rendering/RenderTableCell.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::computeRectForRepaint):

  • rendering/RenderView.h:
  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::computeRectForRepaint):

  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::computeFloatRectForRepaint):

  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::computeRectForRepaint):

  • rendering/svg/RenderSVGText.h:

LayoutTests:

  • fast/repaint/vertical-text-repaint-expected.txt: Added.
  • fast/repaint/vertical-text-repaint.html: Added.
9:33 PM Changeset in webkit [201634] by peavo@outlook.com
  • 8 edits in trunk

[Win] Fetch API tests are failing.
​https://bugs.webkit.org/show_bug.cgi?id=158296

Reviewed by Alex Christensen.

Source/WebKit/win:

Add preference for enabling Fetch API.

  • Interfaces/IWebPreferencesPrivate.idl:
  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::fetchAPIEnabled):
(WebPreferences::setFetchAPIEnabled):

  • WebPreferences.h:
  • WebView.cpp:

(WebView::notifyPreferencesChanged):

Tools:

Enable Fetch API when running tests.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):

8:32 PM Changeset in webkit [201633] by andersca@apple.com
  • 9 edits
    1 add in trunk/Source/WebCore

Fix build
​https://bugs.webkit.org/show_bug.cgi?id=158337
rdar://problem/26429419

Reviewed by Dan Bernstein.

  • WebCore.xcodeproj/project.pbxproj:

Add QTKitSPI.h header.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
  • platform/graphics/mac/MediaTimeQTKit.h:
  • platform/graphics/mac/MediaTimeQTKit.mm:
  • platform/mac/WebVideoFullscreenController.mm:

Include QTKitSPI.h.

  • platform/spi/cocoa/QuartzCoreSPI.h:
  • platform/spi/mac/AVFoundationSPI.h:

Use MAX_ALLOWED instead of MIN_REQUIRED.

  • platform/spi/mac/QTKitSPI.h:

Add new QTKit header.

7:54 PM Changeset in webkit [201632] by benjamin@webkit.org
  • 3 edits in trunk/LayoutTests

Fix a typo in the clz32() tests

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-06-02
Rubber-stamped by Joseph Pecoraro.

Joe found a bug in math-clz32.js: I typed INFINITI instead of INFINITY.
The tests was effectively checking "undefined" instead of infinity.

  • js/math-clz32-expected.txt:
  • js/script-tests/math-clz32.js:

(objectRecordConversionCalls.valueOf):

6:34 PM Changeset in webkit [201631] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebKit/ios

Fix typo in -[WebDefaultUIKitDelegate deleteFromInputwithFlags:]
<​https://webkit.org/b/158323>
<rdar://problem/26549165>

Reviewed by Andy Estes.

  • DefaultDelegates/WebDefaultUIKitDelegate.m:

(-[WebDefaultUIKitDelegate deleteFromInputwithFlags:]): Rename...
(-[WebDefaultUIKitDelegate deleteFromInputWithFlags:]): ...to this.

6:18 PM Changeset in webkit [201630] by commit-queue@webkit.org
  • 12 edits in trunk/Source/WebInspectorUI

Web Inspector: Modernize Array.prototype.every/some callsites to arrow functions
​https://bugs.webkit.org/show_bug.cgi?id=158330

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-02
Reviewed by Brian Burg.

  • UserInterface/Controllers/DOMTreeManager.js:

(WebInspector.DOMTreeManager.prototype._updateContentFlowFromPayload):

  • UserInterface/Models/ProfileNode.js:

(WebInspector.ProfileNode):

  • UserInterface/Models/ScopeChainNode.js:

(WebInspector.ScopeChainNode):

  • UserInterface/Models/StackTrace.js:

(WebInspector.StackTrace):

  • UserInterface/Models/StructureDescription.js:

(WebInspector.StructureDescription):

  • UserInterface/Models/TypeDescription.js:

(WebInspector.TypeDescription):

  • UserInterface/Protocol/InspectorBackend.js:

(InspectorBackend.Command.prototype.supports):

  • UserInterface/Views/ContentViewContainer.js:

(WebInspector.ContentViewContainer.prototype.showContentView):

  • UserInterface/Views/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel.prototype._checkElementsForPendingViewStateCookie.treeElementMatchesCookie):
(WebInspector.NavigationSidebarPanel.prototype._checkElementsForPendingViewStateCookie):

  • UserInterface/Views/ScopeBar.js:

(WebInspector.ScopeBar.prototype.get selectedItems):
(WebInspector.ScopeBar.prototype.hasNonDefaultItemSelected):

  • UserInterface/Views/TabContentView.js:

(WebInspector.TabContentView):
(WebInspector.TabContentView.console.assert): Deleted.

5:39 PM Changeset in webkit [201629] by commit-queue@webkit.org
  • 15 edits in trunk/Source

[iOS] PDFDocumentImage should not create a cached image larger than 4M pixels
​https://bugs.webkit.org/show_bug.cgi?id=157857

Patch by Said Abou-Hallawa <sabouhallawa@apple,com> on 2016-06-02
Reviewed by Darin Adler.

Source/WebCore:

On iOS, if the scaled size of the PDFDocumentImage cached image will exceed
the 4M pixels limit and the system physical memory is 1GB or less, do not
create it. PDFDocumentImage::draw() falls back peacefully if the cached image
couldn't be created for any reason. The PDF will be drawn directly to the
GraphicsContext without having to go through the cached image. This means
the whole PDF will be drawn multiple times; one time for each tile. I think
this is okay for zooming a large PDFDocumentImage on a low end device.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawTextInternal): Call the static function
ImageBuffer::createCompatibleBuffer() without having to go through the GraphicsContext.

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::drawPattern): Ditto.

  • platform/graphics/FloatSize.h:

(WebCore::FloatSize::area): A helper function similar to IntSize::area().
(WebCore::operator*): Scale a FloatSize by another FloatSize and return the result.

  • platform/graphics/GradientImage.cpp:

(WebCore::GradientImage::drawPattern): Call ImageBuffer::createCompatibleBuffer().

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::scaleFactor):: Return the scaling part of the current CTM.
(WebCore::scalesMatch): Deleted.
(WebCore::GraphicsContext::createCompatibleBuffer): Deleted.
(WebCore::GraphicsContext::isCompatibleWithBuffer): Deleted.

  • platform/graphics/GraphicsContext.h:

Move these image buffer functions to ImageBuffer.

  • platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::createCompatibleBuffer): Make createCompatibleBuffer
a static function of the ImageBuffer. There is no need to go through the
GraphicsContext just to get the GraphicsContext scaleFactor.

(WebCore::ImageBuffer::compatibleBufferSize): Scale the size of the cachedImage
by the scaleFactor of the context.

(WebCore::ImageBuffer::isCompatibleWithContext): Returns true if the drawing
context and the ImageBuffer context have the same scaleFactor.

  • platform/graphics/ImageBuffer.h:
  • platform/graphics/NamedImageGeneratedImage.cpp:

(WebCore::NamedImageGeneratedImage::drawPattern): Call ImageBuffer::createCompatibleBuffer().

  • platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::updateCachedImageIfNeeded): On iOS, if the
physical memory is less than 1GB, do not allocate more than 16MB for the
PDF cachedImage.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended): Call ImageBuffer::createCompatibleBuffer().

  • rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::bufferForeground): Ditto.

Source/WTF:

  • wtf/StdLibExtras.h: Add a constant value for GB (230).
4:52 PM Changeset in webkit [201628] by sbarati@apple.com
  • 2 edits
    1 add in trunk/Source/JavaScriptCore

global lexical environment variables are not accessible through functions created using the function constructor
​https://bugs.webkit.org/show_bug.cgi?id=158319

Reviewed by Filip Pizlo.

When creating a function using the Function constructor, we were
using the global object instead of the global lexical environment
as the function's scope. We should be using the global lexical environment.

  • runtime/FunctionConstructor.cpp:

(JSC::constructFunctionSkippingEvalEnabledCheck):

  • tests/stress/function-constructor-reading-from-global-lexical-environment.js: Added.

(assert):
(test):
(ClassTDZ):

4:45 PM Changeset in webkit [201627] by Chris Dumez
  • 7 edits in trunk

[WebIDL] 'undefined' should be an acceptable value for nullable parameters
​https://bugs.webkit.org/show_bug.cgi?id=158321

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline test. The test is failing because the first parameter to
createPattern is wrongly marked as nullable in our IDL and because our
implementation throws a legacy TYPE_MISMATCH_ERR instead of a standard
TypeError when getting null as first parameter. I will fix this bug
and this test via Bug 158322.

  • canvas/2d.pattern.image.undefined-expected.txt:

Source/WebCore:

'undefined' should be an acceptable value for nullable parameters (and
should be converted to null):

Our bindings got most of the cases right but there was a bug in our
overload resolution code. This patch fixes it.

No new tests, already covered by existing tests.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheckExpression):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethodWithOptionalParameter):

LayoutTests:

Rebaseline existing test that is now passing.

  • canvas/philip/tests/2d.pattern.image.undefined-expected.txt:
4:33 PM Changeset in webkit [201626] by commit-queue@webkit.org
  • 5 edits in trunk/Tools

Really display failing JSC stress tests in buildbot dashboard
​https://bugs.webkit.org/show_bug.cgi?id=158324

Patch by Srinivasan Vijayaraghavan <​svijayaraghavan@apple.com> on 2016-06-02
Reviewed by Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:

(BuildbotCombinedQueueView.prototype.update): Correctly check for string membership in array.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

(BuildbotIteration.prototype._parseData): Correctly check for string membership in array.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:

(BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions): Correctly check for string
membership in array.
(BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions): Ensure that the correct URL is
generated after the first time.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

(BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Correctly check for string membership in array.

4:14 PM Changeset in webkit [201625] by dino@apple.com
  • 2 edits in trunk/Websites/webkit.org

Update the example for wider color gamut images.

  • blog-files/color-gamut/index.html:
4:07 PM Changeset in webkit [201624] by oliver@apple.com
  • 7 edits
    2 adds in trunk

JS parser incorrectly handles invalid utf8 in error messages.
​https://bugs.webkit.org/show_bug.cgi?id=158128

Reviewed by Saam Barati.

Source/JavaScriptCore:

The bug here was caused by us using PrintStream's toString method
to produce the error message for a parse error, even though toString
may produce a null string in the event of invalid utf8 that causes
the error in first case. So when we try to create an error message
containing the invalid character code, we set m_errorMessage to the
null string, as that signals "no error" we don't stop parsing, and
everything goes down hill from there.

Now we use the new toStringWithLatin1Fallback so that we can always
produce an error message, even if it contains invalid unicode. We
also add an additional fallback so that we can guarantee an error
message is set even if we're given a null string. There's a debug
mode assertion to prevent anyone accidentally attempting to clear
the message via setErrorMessage.

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::logError):

  • parser/Parser.h:

(JSC::Parser::setErrorMessage):

Source/WTF:

Add a new toStringWithLatin1Fallback that simply uses
String::fromUTF8WithLatin1Fallback, so we can avoid the
standard String::fromUTF8 null return.

  • wtf/StringPrintStream.cpp:

(WTF::StringPrintStream::toStringWithLatin1Fallback):

  • wtf/StringPrintStream.h:

LayoutTests:

Add a testcase.

  • js/invalid-utf8-in-syntax-error-expected.txt: Added.
  • js/script-tests/invalid-utf8-in-syntax-error.js: Added.
3:43 PM Changeset in webkit [201623] by beidson@apple.com
  • 26 edits in trunk/Source/WebCore

Modernize how many platform/network classes do isolatedCopy().
​https://bugs.webkit.org/show_bug.cgi?id=158313

Reviewed by Alex Christensen.

No new tests (Refactor, no behavior change).

  • loader/WorkerThreadableLoader.h:
  • platform/network/FormData.cpp:

(WebCore::FormData::isolatedCopy):
(WebCore::FormDataElement::isolatedCopy):
(WebCore::FormData::FormData): Deleted.
(WebCore::FormData::deepCopy): Deleted.

  • platform/network/FormData.h:
  • platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::isolatedCopy):
(WebCore::HTTPHeaderMap::copyData): Deleted.
(WebCore::HTTPHeaderMap::adopt): Deleted.

  • platform/network/HTTPHeaderMap.h:
  • platform/network/ResourceErrorBase.cpp:

(WebCore::ResourceErrorBase::asResourceError):
(WebCore::ResourceErrorBase::isolatedCopy):

  • platform/network/ResourceErrorBase.h:

(WebCore::ResourceErrorBase::platformCopy): Deleted.

  • platform/network/ResourceLoadTiming.h:

(WebCore::ResourceLoadTiming::isolatedCopy): Not strictly needed for now, but makes it obvious

that changes will be needed if new members are added later.

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::isolatedCopy):
(WebCore::ResourceRequestBase::setAsIsolatedCopy):
(WebCore::ResourceRequestBase::copyData): Deleted.

  • platform/network/ResourceRequestBase.h:
  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::isolatedCopy):
(WebCore::ResourceResponseBase::copyData): Deleted.

  • platform/network/ResourceResponseBase.h:

(WebCore::CrossThreadResourceResponseDataBase::CrossThreadResourceResponseDataBase): Deleted.

  • platform/network/cf/ResourceError.h:
  • platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::doPlatformIsolatedCopy):
(WebCore::ResourceError::platformCopy): Deleted.

  • platform/network/cf/ResourceRequest.h:
  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doPlatformSetAsIsolatedCopy):
(WebCore::ResourceRequest::doPlatformCopyData): Deleted.
(WebCore::ResourceRequest::doPlatformAdopt): Deleted.

  • platform/network/cf/ResourceResponse.h:

(WebCore::ResourceResponse::doPlatformCopyData): Deleted.
(WebCore::ResourceResponse::doPlatformAdopt): Deleted.

  • platform/network/curl/ResourceError.h:

(WebCore::ResourceError::doPlatformIsolatedCopy):

  • platform/network/curl/ResourceRequest.h:

(WebCore::ResourceRequest::doPlatformSetAsIsolatedCopy):
(WebCore::ResourceRequest::doPlatformCopyData): Deleted.
(WebCore::ResourceRequest::doPlatformAdopt): Deleted.

  • platform/network/curl/ResourceResponse.h:

(WebCore::ResourceResponse::doPlatformCopyData): Deleted.
(WebCore::ResourceResponse::doPlatformAdopt): Deleted.

  • platform/network/mac/ResourceErrorMac.mm:

(WebCore::ResourceError::doPlatformIsolatedCopy):

  • platform/network/soup/ResourceError.h:
  • platform/network/soup/ResourceErrorSoup.cpp:

(WebCore::ResourceError::doPlatformIsolatedCopy):
(WebCore::ResourceError::platformCopy): Deleted.

  • platform/network/soup/ResourceRequest.h:

(WebCore::ResourceRequest::doPlatformSetAsIsolatedCopy):
(WebCore::ResourceRequest::doPlatformCopyData): Deleted.
(WebCore::ResourceRequest::doPlatformAdopt): Deleted.

  • platform/network/soup/ResourceResponse.h:

(WebCore::ResourceResponse::doPlatformCopyData): Deleted.
(WebCore::ResourceResponse::doPlatformAdopt): Deleted.

3:18 PM Changeset in webkit [201622] by sbarati@apple.com
  • 3 edits
    1 add in trunk/Source/JavaScriptCore

Teach bytecode liveness about the debugger
​https://bugs.webkit.org/show_bug.cgi?id=158288

Reviewed by Filip Pizlo.

There was a bug where we wouldn't always keep the scope register
on the stack when the debugger is enabled. The debugger always assumes
it can read from the scope. The bug happened in OSR exit from the FTL.
The FTL uses bytecode liveness for OSR exit. Bytecode liveness proved
that the scope register was dead, so the FTL OSR exit wrote undefined
into the scope's stack slot when OSR exiting to the baseline.

To fix this, I taught bytecode liveness' computeUsesForBytecodeOffset() that the
scope is used by every instruction except op_enter. This causes the
scope to be live-in at every instruction except op_enter.

  • bytecode/BytecodeLivenessAnalysis.cpp:

(JSC::blockContainsBytecodeOffset):
(JSC::addAlwaysLiveLocals):
(JSC::findBasicBlockForBytecodeOffset):
(JSC::stepOverInstruction):
(JSC::computeLocalLivenessForBytecodeOffset):
(JSC::BytecodeLivenessAnalysis::runLivenessFixpoint):

  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):

  • tests/stress/shadow-chicken-reading-from-scope-after-ftl-osr-exit-bytecode-liveness.js: Added.

(foo):
(catch):

3:15 PM Changeset in webkit [201621] by dino@apple.com
  • 1 edit
    10 adds in trunk/Websites/webkit.org

Adding some sample images for a blog post on color.

  • blog-files/color-gamut/Flowers-AdobeRGB.jpg: Added.
  • blog-files/color-gamut/Flowers-ProPhoto.jpg: Added.
  • blog-files/color-gamut/Flowers-oog.jpg: Added.
  • blog-files/color-gamut/Flowers-sRGB.jpg: Added.
  • blog-files/color-gamut/Rose-AdobeRGB.jpg: Added.
  • blog-files/color-gamut/Rose-ProPhoto.jpg: Added.
  • blog-files/color-gamut/Rose-oog.jpg: Added.
  • blog-files/color-gamut/Rose-sRGB.jpg: Added.
  • blog-files/color-gamut/index.html: Added.
3:11 PM Changeset in webkit [201620] by commit-queue@webkit.org
  • 26 edits in trunk/Source/WebInspectorUI

Web Inspector: Modernize some function expressions that bind(this) to arrow functions
​https://bugs.webkit.org/show_bug.cgi?id=158315

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-02
Reviewed by Brian Burg.

Convert a common "function(x) { ... }.bind(this)" pattern to use arrow
functions "(x) => { ... }", which lexically binds this, slightly faster,
and uses less memory.

  • UserInterface/Base/Main.js:

(WebInspector._updateNewTabButtonState):

  • UserInterface/Controllers/BreakpointPopoverController.js:

(WebInspector.BreakpointPopoverController.prototype._createPopoverContent):

  • UserInterface/Controllers/TypeTokenAnnotator.js:

(WebInspector.TypeTokenAnnotator.prototype.insertAnnotations):
(WebInspector.TypeTokenAnnotator.prototype.insertAnnotations.): Deleted.

  • UserInterface/Models/RenderingFrameTimelineRecord.js:

(WebInspector.RenderingFrameTimelineRecord.prototype._calculateDurationRemainder):
(WebInspector.RenderingFrameTimelineRecord):

  • UserInterface/Models/Resource.js:

(WebInspector.Resource.prototype.requestContent):

  • UserInterface/Models/Script.js:

(WebInspector.Script.prototype.requestScriptSyntaxTree):
(WebInspector.Script.prototype.requestScriptSyntaxTree.makeSyntaxTreeAndCallCallback): Deleted.

  • UserInterface/Models/SourceCodeLocation.js:

(WebInspector.SourceCodeLocation.prototype.populateLiveDisplayLocationString):

  • UserInterface/Models/WrappedPromise.js:

(WebInspector.WrappedPromise):

  • UserInterface/Views/BreakpointActionView.js:

(WebInspector.BreakpointActionView.prototype._updateBody):

  • UserInterface/Views/BreakpointTreeElement.js:

(WebInspector.BreakpointTreeElement.prototype._dataUpdated):

  • UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype._updateTextMarkers.update):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._updateTextMarkers):

  • UserInterface/Views/DefaultDashboardView.js:

(WebInspector.DefaultDashboardView.prototype._appendElementForNamedItem.set item):
(WebInspector.DefaultDashboardView.prototype._appendElementForNamedItem):

  • UserInterface/Views/ErrorObjectView.js:

(WebInspector.ErrorObjectView.prototype.update):

  • UserInterface/Views/GeneralTreeElement.js:

(WebInspector.GeneralTreeElement.prototype.onattach):
(WebInspector.GeneralTreeElement.prototype.onattach.this._boundContextMenuEventHandler): Deleted.

  • UserInterface/Views/InlineSwatch.js:

(WebInspector.InlineSwatch.prototype._getNextValidHEXFormat):
(WebInspector.InlineSwatch):

  • UserInterface/Views/LayerTreeDetailsSidebarPanel.js:

(WebInspector.LayerTreeDetailsSidebarPanel.prototype.refresh):
(WebInspector.LayerTreeDetailsSidebarPanel.prototype._showPopoverForSelectedNode):
(WebInspector.LayerTreeDetailsSidebarPanel.prototype._contentForPopover):

  • UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView.prototype._mouseup):

  • UserInterface/Views/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel.prototype._checkElementsForPendingViewStateCookie):

  • UserInterface/Views/ObjectTreeBaseTreeElement.js:

(WebInspector.ObjectTreeBaseTreeElement.prototype.createGetterElement):
(WebInspector.ObjectTreeBaseTreeElement.prototype.createGetterElement.): Deleted.

  • UserInterface/Views/ObjectTreePropertyTreeElement.js:

(WebInspector.ObjectTreePropertyTreeElement.prototype._updateEntries):

  • UserInterface/Views/ObjectTreeView.js:

(WebInspector.ObjectTreeView.prototype._updateEntries):

  • UserInterface/Views/ResourceDetailsSidebarPanel.js:

(WebInspector.ResourceDetailsSidebarPanel.prototype._refreshImageSizeSection):

  • UserInterface/Views/ScopeChainDetailsSidebarPanel.js:

(WebInspector.ScopeChainDetailsSidebarPanel.prototype._addWatchExpressionButtonClicked):
(WebInspector.ScopeChainDetailsSidebarPanel.prototype._objectTreeElementAddContextMenuItems):
(WebInspector.ScopeChainDetailsSidebarPanel.prototype._addWatchExpressionButtonClicked.this._codeMirror.addKeyMap): Deleted.

  • UserInterface/Views/TabBar.js:
  • UserInterface/Views/VisualStylePropertyEditor.js:

(WebInspector.VisualStylePropertyEditor.prototype._checkDependencies):

3:01 PM Changeset in webkit [201619] by msaboff@apple.com
  • 16 edits
    3 adds in trunk

REGRESSION(r200694): %ThrowTypeError% is not unique
​https://bugs.webkit.org/show_bug.cgi?id=158231

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

The ES6 standard in section 9.2.7.1 states that %ThrowTypeError% is unique. This
change reverts the handling of TypeError before r200694 and then rolls in
throwTypeErrorGetterSetter() with the renamed throwTypeErrorArgumentsCalleeAndCallerGetterSetter().

  • runtime/ClonedArguments.cpp:

(JSC::ClonedArguments::getOwnPropertySlot):
(JSC::ClonedArguments::materializeSpecials):

  • runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::finishCreation):
(JSC::JSBoundFunction::visitChildren):

  • runtime/JSFunction.cpp:

(JSC::getThrowTypeErrorGetterSetter):
(JSC::JSFunction::callerGetter):
(JSC::JSFunction::defineOwnProperty):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::regExpProtoSymbolReplaceFunction):
(JSC::JSGlobalObject::regExpProtoGlobalGetter):
(JSC::JSGlobalObject::regExpProtoUnicodeGetter):
(JSC::JSGlobalObject::throwTypeErrorArgumentsCalleeAndCallerGetterSetter):
(JSC::JSGlobalObject::moduleLoader):
(JSC::JSGlobalObject::throwTypeErrorGetterSetter): Deleted.
(JSC::JSGlobalObject::throwTypeErrorCalleeAndCallerGetterSetter): Deleted.
(JSC::JSGlobalObject::throwTypeErrorArgumentsAndCallerInStrictModeGetterSetter): Deleted.
(JSC::JSGlobalObject::throwTypeErrorArgumentsAndCallerInClassContextGetterSetter): Deleted.

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncThrowTypeError):
(JSC::globalFuncThrowTypeErrorArgumentsCalleeAndCaller):
(JSC::globalFuncThrowTypeErrorCalleeAndCaller): Deleted.
(JSC::globalFuncThrowTypeErrorArgumentsAndCallerInStrictMode): Deleted.
(JSC::globalFuncThrowTypeErrorArgumentsAndCallerInClassContext): Deleted.

  • runtime/JSGlobalObjectFunctions.h:
  • tests/stress/reflect-set.js:

LayoutTests:

Rebased tests for the new TypeError messages.
Added a new test, throw-type-error-is-unique.html.

  • inspector/runtime/getProperties-expected.txt:
  • js/basic-strict-mode-expected.txt:
  • js/caller-property-expected.txt:
  • js/class-method-and-constructor-properties-expected.txt:
  • js/script-tests/caller-property.js:

(strictCaller):
(strictTailCaller):

  • js/script-tests/class-method-and-constructor-properties.js:

(F.prototype.getElement):
(F):
(G.prototype.get item):
(G):
(H.prototype.arguments):
(H):

  • js/script-tests/throw-type-error-is-unique.js: Added.

(ThrowTypeErrorSource):
(ThrowTypeErrorSource.prototype.checkTypeErrorFunctions):
(A):
(strictArguments):
(test):

  • js/throw-type-error-is-unique-expected.txt: Added.
  • js/throw-type-error-is-unique.html: Added.
2:53 PM Changeset in webkit [201618] by msaboff@apple.com
  • 5 edits in trunk

[iOS]: Some JSC stress tests fail running out of executable memory when the LLInt is disabled
​https://bugs.webkit.org/show_bug.cgi?id=158317

Reviewed by Saam Barati.

Source/JavaScriptCore:

Updated these test to not run the "no-llint" variant when running on ARM machines.

  • tests/stress/arrowfunction-lexical-bind-superproperty.js: Skip no-llint for ARM

(testCase):

  • tests/stress/proxy-revoke.js: Skipp no-lint for ARM and ARM64

(assert):

Tools:

Added defaultNoNoLLIntRun variant to run the default tests with the exception of the no-llint
variant.

  • Scripts/run-jsc-stress-tests:
2:24 PM Changeset in webkit [201617] by keith_miller@apple.com
  • 20 edits
    3 adds in trunk/Source

Unreviewed, reland r201532. The associated regressions have been fixed
by r201584.

1:48 PM Changeset in webkit [201616] by bshafiei@apple.com
  • 5 edits in branches/safari-602.1.32-branch/Source

Versioning.

1:37 PM Changeset in webkit [201615] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Crash under CachedResource::addClientToSet()
​https://bugs.webkit.org/show_bug.cgi?id=158310
<rdar://problem/23643359>

Reviewed by Eric Carlson.

Only call CachedResource::addClient() on the resource returned
by CachedResourceLoader::requestMedia() if the resource is
non-null. CachedResourceLoader::requestMedia() can return null
in some cases so we need to handle this properly.

No new tests, no known reproduction case.

  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:

(WebCore::WebCoreAVFResourceLoader::startLoading):

1:35 PM Changeset in webkit [201614] by Chris Dumez
  • 6 edits in trunk/Source/WebCore

ScriptExecutionContext::Task constructor should take a NoncopyableFunction<void ()> as parameter
​https://bugs.webkit.org/show_bug.cgi?id=158309

Reviewed by Brady Eidson.

ScriptExecutionContext::Task constructor should take a NoncopyableFunction<void ()>
as parameter for consistency with the other constructor and because this can be
called cross-thread.

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::suspend):
(WebCore::AudioContext::resume):
(WebCore::AudioContext::close):
(WebCore::AudioContext::suspendPlayback):
(WebCore::AudioContext::mayResumePlayback):

  • Modules/webaudio/AudioDestinationNode.h:

(WebCore::AudioDestinationNode::resume):
(WebCore::AudioDestinationNode::suspend):
(WebCore::AudioDestinationNode::close):

  • Modules/webaudio/DefaultAudioDestinationNode.cpp:

(WebCore::DefaultAudioDestinationNode::resume):
(WebCore::DefaultAudioDestinationNode::suspend):
(WebCore::DefaultAudioDestinationNode::close):

  • Modules/webaudio/DefaultAudioDestinationNode.h:
  • dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::Task::Task):

1:05 PM Changeset in webkit [201613] by fpizlo@apple.com
  • 4 edits in trunk/Websites/webkit.org

Fix typos and make some revisions to the B3 docs
​https://bugs.webkit.org/show_bug.cgi?id=158311

Reviewed by Michael Saboff.

I found typos and fixed them. Also, I clarified some things:

  • Is B3 IR platform-agnostic? Sort of. I tried to describe when it is (Values usually behave the same way regardless of CPU) and when it isn't (it lets you speak of registers if that's what you want to do, for example).


  • How does isValidForm really get used? You don't really need to create an Inst to use it.


  • Some other incremental improvements to make the docs clearer.
  • docs/b3/assembly-intermediate-representation.html:
  • docs/b3/index.html:
  • docs/b3/intermediate-representation.html:
12:57 PM Changeset in webkit [201612] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

Crash under WebProcess::registerWithStateDumper()
​https://bugs.webkit.org/show_bug.cgi?id=158304
<rdar://problem/25329276>

Reviewed by Anders Carlsson.

The issue is that the block in registerWithStateDumper() was executed in
a background thread and is iterating over m_pageMap HashMap. The crash
occurs when a page gets removed from the m_pageMap HashMap while the
block is iterating over this same HashMap in another thread.

The solution proposed is to execute the registerWithStateDumper()'s
block in the main thread.

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::registerWithStateDumper):

12:40 PM Changeset in webkit [201611] by fpizlo@apple.com
  • 4 edits in trunk/Source

Use "= delete" for Locker(int)

Rubber stamped by Saam Barati.
Source/JavaScriptCore:

  • runtime/ConcurrentJITLock.h:

(JSC::ConcurrentJITLocker::ConcurrentJITLocker):

Source/WTF:


See discussion: ​https://bugs.webkit.org/show_bug.cgi?id=158306#c8

  • wtf/Locker.h:

(WTF::Locker::Locker):
(WTF::Locker::~Locker):

12:36 PM Changeset in webkit [201610] by keith_miller@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

ObjectPropertyCondition should have a isStillValidAssumingImpurePropertyWatchpoint function
​https://bugs.webkit.org/show_bug.cgi?id=158308

Reviewed by Filip Pizlo.

Recently, structureEnsuresValidityAssumingImpurePropertyWatchpoint was converted to check
what should be isStillValidAssumingImpurePropertyWatchpoint. This patch fixes the API so
it should work as expected. This patch also changes generateConditions in
ObjectPropertyConditionSet to use isStillValidAssumingImpurePropertyWatchpoint.

  • bytecode/ObjectPropertyCondition.cpp:

(JSC::ObjectPropertyCondition::structureEnsuresValidityAssumingImpurePropertyWatchpoint):
(JSC::ObjectPropertyCondition::isStillValidAssumingImpurePropertyWatchpoint):

  • bytecode/ObjectPropertyCondition.h:
  • bytecode/ObjectPropertyConditionSet.cpp:
12:21 PM Changeset in webkit [201609] by fpizlo@apple.com
  • 4 edits in trunk/Source

Make it harder to accidentally pass an integer to a locker.

Rubber stamped by Keith Miller.
Source/JavaScriptCore:

  • runtime/ConcurrentJITLock.h:

(JSC::ConcurrentJITLocker::ConcurrentJITLocker):

Source/WTF:


See here for the discussion: ​https://bugs.webkit.org/show_bug.cgi?id=158306#c3

  • wtf/Locker.h:

(WTF::Locker::Locker):
(WTF::Locker::~Locker):

12:05 PM Changeset in webkit [201608] by dbates@webkit.org
  • 5 edits
    2 adds in trunk

Fix a couple of mistakes in CSSParserValue memory management
​https://bugs.webkit.org/show_bug.cgi?id=158307
<rdar://problem/26127225>

Source/WebCore:

Patch by Darin Adler <Darin Adler> on 2016-06-02
Reviewed by Daniel Bates.

  • css/CSSGrammar.y.in: Added a destructor for calc_func_term. This presumably

fixes some memory leaks in error cases. Removed an assertion about not needing
a call to destroy that was far too limited. Tweaked formatting of the percentage
ase in the key production. Indented calc_func_term to make it consistent with
other productions nearby.

  • css/CSSParserValues.cpp:

(WebCore::CSSParserValueList::~CSSParserValueList): Use a modern for loop.
(WebCore::CSSParserValueList::deleteValueAt): Deleted. Unused function, and also
would have resulted in a memory leak unless the code already extracted the value
from the list.
(WebCore::CSSParserValueList::extend): Properly transfer ownership from one value
list to the other by setting the unit to 0 in the donor.

  • css/CSSParserValues.h: Removed unused deleteValueAt function.

LayoutTests:

Reviewed by Darin Adler.

  • fast/css/calc-with-two-variables-crash-expected.txt: Added.
  • fast/css/calc-with-two-variables-crash.html: Added.
12:04 PM Changeset in webkit [201607] by rniwa@webkit.org
  • 3 edits in trunk/Websites/perf.webkit.org

Build fix after r201564.

  • public/v3/pages/analysis-category-page.js:

(AnalysisCategoryPage.prototype.updateFromSerializedState):

  • public/v3/pages/create-analysis-task-page.js:

(CreateAnalysisTaskPage.prototype.updateFromSerializedState):
(CreateAnalysisTaskPage.prototype.render):

11:42 AM Changeset in webkit [201606] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

LayoutTests time out intermittently due to alert about reopening Simulator after it unexpectedly quit
​https://bugs.webkit.org/show_bug.cgi?id=158305

Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort.clean_up_test_run): Delete simulator's savedState directories during cleanup.

11:41 AM Changeset in webkit [201605] by fpizlo@apple.com
  • 5 edits in trunk/Source

Make it easier to use NoLockingNecessary
​https://bugs.webkit.org/show_bug.cgi?id=158306

Reviewed by Keith Miller.

Source/JavaScriptCore:

Adapt to the new NoLockingNecessary API. More details in the WTF ChangeLog.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::initializeArrowFunctionContextScopeIfNeeded):
(JSC::BytecodeGenerator::instantiateLexicalVariables):
(JSC::BytecodeGenerator::emitPrefillStackTDZVariables):
(JSC::BytecodeGenerator::initializeBlockScopedFunctions):
(JSC::BytecodeGenerator::hoistSloppyModeFunctionIfNecessary):
(JSC::BytecodeGenerator::popLexicalScopeInternal):
(JSC::BytecodeGenerator::prepareLexicalScopeForNextForLoopIteration):
(JSC::BytecodeGenerator::variable):
(JSC::BytecodeGenerator::createVariable):
(JSC::BytecodeGenerator::emitResolveScope):
(JSC::BytecodeGenerator::emitPushFunctionNameScope):

  • runtime/ConcurrentJITLock.h:

(JSC::ConcurrentJITLockerBase::ConcurrentJITLockerBase):
(JSC::ConcurrentJITLocker::ConcurrentJITLocker):

Source/WTF:

An idiom that we borrowed from LLVM is that if a function requires a lock to be held, we
have it take a const Locker& as its first argument. This may not communicate which lock is
to be held, but it does help us to remember that some lock must be held. So far, it's been
relatively easy to then figure out which lock. We've had bugs where we forgot to hold a
lock but I don't remember the last time we had a bug where we grabbed the wrong lock.

But sometimes, we know at the point where we call such a method that we actually don't
need to hold any lock. This usually happens during object construction. If we're
constructing some object then we usually know that we have not escaped it yet, so we don't
need to waste time acquiring its lock. We could solve this by having a separate set of
methods that don't do or require locking. This would be cumbersome, since usually for
every variant that takes const Locker&, there is already one that doesn't, and that one
will grab the lock for you. So this means having a third variant, that also doesn't take a
const Locker&, but does no locking. That's pretty weird.

So, we introduced NoLockingNecessary for situations like this. The idiom went like so:

Locker<Whatever> locker(Locker<Whatever>::NoLockingNecessary)
stuff->foo(locker);


Usually though, there would be some distance between where the locker is defined and where
it's used, so when you just look at stuff->foo(locker) in isolation you don't know if this
is a real locker or a NoLockingNecessary cast. Also, requiring two lines for this just
adds code.

This change makes this easier. Now you can just do:

stuff->foo(NoLockingNecessary).


This is because NoLockingNecessary has been pulled out into the WTF namespace (and is
usinged from the global namespace) and the Locker<> constructor that takes
NoLockingNecessaryTag is now implicit.

The only possible downside of this change is that people might use this idiom more
frequently now that it's easier to use. I don't think that's a bad thing. I'm now
convinced that this is not a bad idiom. When I was fixing an unrelated bug, I almost went
the way of adding more locking to some core JSC data structures, and in the process, I
needed to use NoLockingNecessary. It's clear that this is a general-purpose idiom and we
should not impose artificial constraints on its use.

  • wtf/Locker.h:

(WTF::Locker::Locker):
(WTF::Locker::~Locker):

11:40 AM Changeset in webkit [201604] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

SVG content renders in incorrect vertical position when padding-left is not specified
​https://bugs.webkit.org/show_bug.cgi?id=158234

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2016-06-02
Reviewed by Darin Adler.

Source/WebCore:

Fix the optimization in RenderSVGRoot::buildLocalToBorderBoxTransform().
Use LayoutSize::isZero() instead of LayoutSize::isEmpty() to decide whether
there is borderAndPadding applied or not.

Test: svg/custom/svg-root-padding-individual.html

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::buildLocalToBorderBoxTransform):

LayoutTests:

Make sure the SVG root element is positioned correctly when either the sum
of its (leftPadding + rightPadding) or the sum of its (topPadding + bottomPadding)
is equal to zero.

  • svg/custom/svg-root-padding-individual-expected.html: Added.
  • svg/custom/svg-root-padding-individual.html: Added.
11:17 AM Changeset in webkit [201603] by beidson@apple.com
  • 14 edits in trunk/Source

Overhaul cross-thread use of ResourceRequest, ResourceResponse, and ResourceError.
​https://bugs.webkit.org/show_bug.cgi?id=158293

Reviewed by Darin Adler.

Source/WebCore:

No new tests (Refactor, no behavior change).

  • loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFailAccessControlCheck):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::removeRequestFromSessionCaches):

  • platform/network/ResourceErrorBase.cpp:

(WebCore::ResourceErrorBase::isolatedCopy):
(WebCore::ResourceErrorBase::copy): Deleted.

  • platform/network/ResourceErrorBase.h:
  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::isolatedCopy):
(WebCore::ResourceRequestBase::setAsIsolatedCopy):
(WebCore::ResourceRequestBase::adopt): Deleted.

Made copyData private, and made "adopt" be "isolatedCopy".
Rest of the changes are all re-indenting the file.

  • platform/network/ResourceRequestBase.h:

(WebCore::ResourceRequestBase::responseContentDispositionEncodingFallbackArray):
(WebCore::ResourceRequestBase::reportUploadProgress):
(WebCore::ResourceRequestBase::setReportUploadProgress):
(WebCore::ResourceRequestBase::reportLoadTiming):
(WebCore::ResourceRequestBase::setReportLoadTiming):
(WebCore::ResourceRequestBase::reportRawHeaders):
(WebCore::ResourceRequestBase::setReportRawHeaders):
(WebCore::ResourceRequestBase::hiddenFromInspector):
(WebCore::ResourceRequestBase::setHiddenFromInspector):
(WebCore::ResourceRequestBase::requester):
(WebCore::ResourceRequestBase::setRequester):
(WebCore::ResourceRequestBase::encodingRequiresPlatformData):
(WebCore::ResourceRequestBase::ResourceRequestBase):
(WebCore::ResourceRequestBase::platformCompare):
(WebCore::operator==):
(WebCore::operator!=):

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::isolatedCopy):
(WebCore::ResourceResponseBase::adopt): Deleted.

  • platform/network/ResourceResponseBase.h:
  • platform/network/cf/ResourceError.h:

(WebCore::ResourceError::isolatedCopy): Deleted.

Removed platform-specific isolatedCopy, and re-indented the header:

  • platform/network/cf/ResourceRequest.h:

(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::encodingRequiresPlatformData):
(WebCore::ResourceRequest::cachePartition):
(WebCore::ResourceRequest::setCachePartition):
(WebCore::ResourceRequest::setDomainForCachePartition):
(WebCore::ResourceRequest::resourcePrioritiesEnabled):
(WebCore::ResourceRequest::isolatedCopy): Deleted.

  • platform/network/cf/ResourceResponse.h:

(WebCore::ResourceResponse::isolatedCopy): Deleted.

Source/WebKit2:

  • NetworkProcess/cache/NetworkCacheEntry.cpp:

(WebKit::NetworkCache::Entry::Entry):

10:59 AM Changeset in webkit [201602] by Chris Dumez
  • 12 edits in trunk/Source

Modernize various lambda captures
​https://bugs.webkit.org/show_bug.cgi?id=158292

Reviewed by Brady Eidson.

Modernize various lambda captures, especially the ones unnecessarily
allocating objects on the heap and destroying them in the lambda.

Source/WebCore:

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::didConnect):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryData):
(WebCore::ThreadableWebSocketChannelClientWrapper::didUpdateBufferedAmount):
(WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshake):
(WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageError):
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):
(WebCore::ThreadableWebSocketChannelClientWrapper::resume): Deleted.

  • Modules/websockets/WorkerThreadableWebSocketChannel.cpp:

(WebCore::WorkerThreadableWebSocketChannel::Bridge::disconnect):

  • bindings/js/JSCallbackData.h:

(WebCore::DeleteCallbackDataTask::DeleteCallbackDataTask):

  • loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
(WebCore::WorkerThreadableLoader::MainThreadBridge::destroy):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didSendData):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFailAccessControlCheck):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFailRedirectCheck):
(WebCore::WorkerThreadableLoader::MainThreadBridge::cancel): Deleted.

Source/WebKit2:

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::fetchDiskCacheEntries):
(WebKit::clearDiskCacheEntries):
(WebKit::NetworkProcess::fetchWebsiteData): Deleted.

  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::traverse):

  • NetworkProcess/cache/NetworkCache.h:
  • NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::TraverseOperation::TraverseOperation):

  • NetworkProcess/cache/NetworkCacheStorage.h:
10:50 AM Changeset in webkit [201601] by adam.bergkvist@ericsson.com
  • 10 edits in trunk

WebRTC: Update RTCPeerConnection.addTrack() to create (or reuse) an RTCRtpTransceiver
​https://bugs.webkit.org/show_bug.cgi?id=158191

Reviewed by Eric Carlson.

Source/WebCore:

Update RTCPeerConnection.addTrack to create an RTCRtpTranscevier, or reuse an existing
transceiver that has not been used to send [1].

A new RtpTransceiverSet type is added that wraps a vector of RTCRtpTransceiver objects
and internally maintains two lists for efficient access to RTCRtpSender and RTCRtpReceiver
objects.

[1] ​https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html#dom-rtcpeerconnection-addtrack

Updated existing test: fast/mediastream/RTCPeerConnection-add-removeTrack.html

  • Modules/mediastream/PeerConnectionBackend.h:
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::addTrack):
(WebCore::RTCPeerConnection::removeTrack):
(WebCore::RTCPeerConnection::completeAddTransceiver):
(WebCore::RTCPeerConnection::close):

  • Modules/mediastream/RTCPeerConnection.h:
  • Modules/mediastream/RTCRtpTransceiver.cpp:

(WebCore::RtpTransceiverSet::append):

  • Modules/mediastream/RTCRtpTransceiver.h:

(WebCore::RtpTransceiverSet::list):
(WebCore::RtpTransceiverSet::getSenders):
(WebCore::RtpTransceiverSet::getReceivers):

LayoutTests:

Extend existing test to verify the created RTCRtpTransceiver object.

  • fast/mediastream/RTCPeerConnection-add-removeTrack-expected.txt:
  • fast/mediastream/RTCPeerConnection-add-removeTrack.html:

Add checks for bad argument lists and verify the created RTCRtpTransceiver.

9:40 AM Changeset in webkit [201600] by Chris Dumez
  • 3 edits in trunk/Source/WebKit2

Speculative revalidated request returns 200 instead of 304
​https://bugs.webkit.org/show_bug.cgi?id=158256

Reviewed by Antti Koivisto and Carlos Garcia Campos.

Already conditional requests coming from WebCore should bypass the
SpeculativeLoadManager. This is because the validation is requested
by WebCore (usually the memory cache) and not our network cache. As
a result, we need to pipe the revalidation response (e.g. 304 status
code) back to WebCore instead of resolving it as disk cache level.

This should fix the /webkit2/WebKitWebResource/response unit test.

  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::retrieve):

  • NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:

(WebKit::NetworkCache::requestsHeadersMatch):

5:03 AM Changeset in webkit [201599] by peavo@outlook.com
  • 2 edits in trunk/LayoutTests

Unreviewed test gardening.

Unskip websocket tests passing after r201500.

  • platform/win/TestExpectations:
3:33 AM Changeset in webkit [201598] by peavo@outlook.com
  • 2 edits in trunk/LayoutTests

Unreviewed test gardening.

The test storage/indexeddb/modern/blob-simple.html is passing.

  • platform/win/TestExpectations:
2:48 AM WebKitGTK/Gardening/Calendar edited by jfernandez@igalia.com
(diff)
2:31 AM Changeset in webkit [201597] by jfernandez@igalia.com
  • 5 edits
    1 add in trunk/LayoutTests

Unreviewed GTK+ gardening Additional rebaseline after r201397.

Added reference files for pixel tests.

  • fast/forms/search-input-rtl-expected.txt:
  • platform/gtk/fast/css/text-overflow-input-expected.png:
  • platform/gtk/fast/forms/placeholder-position-expected.png:
  • platform/gtk/fast/forms/search-input-rtl-expected.png: Added.
  • platform/gtk/fast/forms/search-rtl-expected.png:
1:45 AM Changeset in webkit [201596] by youenn.fablet@crf.canon.fr
  • 32 edits in trunk/Source

Source/WebCore:
Use more references in ResourceLoader related code
​https://bugs.webkit.org/show_bug.cgi?id=158222

Reviewed by Darin Adler.

No change of behavior.

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::load):

  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::clearDocument):
(WebCore::CSSFontSelector::beginLoadingFontSoon):
(WebCore::CSSFontSelector::beginLoadTimerFired):

  • css/CSSFontSelector.h:
  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::scheduleArchiveLoad):

  • loader/DocumentLoader.h:
  • loader/LoaderStrategy.h:
  • loader/NetscapePlugInStreamLoader.cpp:

(WebCore::NetscapePlugInStreamLoader::NetscapePlugInStreamLoader):
(WebCore::NetscapePlugInStreamLoader::create):

  • loader/NetscapePlugInStreamLoader.h:
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::ResourceLoader):
(WebCore::ResourceLoader::start):

  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::RequestCountTracker::RequestCountTracker):
(WebCore::SubresourceLoader::SubresourceLoader):
(WebCore::SubresourceLoader::create):
(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::notifyDone):

  • loader/SubresourceLoader.h:
  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::maybeLoadResource):

  • loader/appcache/ApplicationCacheHost.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::incrementRequestCount):
(WebCore::CachedResourceLoader::decrementRequestCount):

  • loader/cache/CachedResourceLoader.h:

Source/WebKit:
Use more references in ResourceLoader related code
​https://bugs.webkit.org/show_bug.cgi?id=158222

Reviewed by Darin Adler.

  • WebCoreSupport/WebResourceLoadScheduler.cpp:

(WebResourceLoadScheduler::loadResource):

  • WebCoreSupport/WebResourceLoadScheduler.h:

Source/WebKit/mac:
Add WebIDL special operation support: serializer
​https://bugs.webkit.org/show_bug.cgi?id=156293

Reviewed by Darin Adler.

  • Plugins/Hosted/HostedNetscapePluginStream.mm:

(WebKit::HostedNetscapePluginStream::start):

  • Plugins/WebNetscapePluginStream.mm:

(WebNetscapePluginStream::start):

Source/WebKit/win:
Use more references in ResourceLoader related code
​https://bugs.webkit.org/show_bug.cgi?id=158222

Reviewed by Darin Adler.

  • Plugins/PluginStream.cpp:

(WebCore::PluginStream::start):

Source/WebKit2:
Use more references in ResourceLoader related code
​https://bugs.webkit.org/show_bug.cgi?id=158222

Reviewed by Darin Adler.

  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::loadResource):
(WebKit::WebLoaderStrategy::schedulePluginStreamLoad):
(WebKit::WebLoaderStrategy::scheduleLoad):
(WebKit::WebLoaderStrategy::scheduleInternallyFailedLoad):
(WebKit::WebLoaderStrategy::startLocalLoad):
(WebKit::WebLoaderStrategy::networkProcessCrashed):

  • WebProcess/Network/WebLoaderStrategy.h:
  • WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::create):
(WebKit::WebResourceLoader::WebResourceLoader):

  • WebProcess/Network/WebResourceLoader.h:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::Stream::start):

12:36 AM Changeset in webkit [201595] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

[Wayland] PlatformDisplayWayland destructor is super crashy
​https://bugs.webkit.org/show_bug.cgi?id=157973

Reviewed by Michael Catanzaro.

EGL registers two at exist callbacks one to finish the display and another one to unload drivers, the one to
finish the display happens first. When our destructor is called the _eglFiniDisplay callback has already been
called, so we have a valid pointer for an already finished display. Then eglTerminate tries to find the display
in the global display list, but fails and for some reason it crashes when trying to return an error.
If atexit is called after the global PlatformDisplay constructor, the atexit handler is called before the
destructor. The atexit callbacks are called in reverse order, so if we register an atexit handler after the
global instace has been created and after EGL has been initialized, we could terminate the EGL display before
the EGL atexit handlers and the global PlatformDisplay destructor.

  • platform/graphics/PlatformDisplay.cpp:

(WebCore::PlatformDisplay::initializeEGLDisplay):

Note: See TracTimeline for information about the timeline view.