Context Navigation

← Previous Period
Next Period →

Timeline

Jun 13, 2016:

11:57 PM Changeset in webkit [202033] by barraclough@apple.com

3 edits in trunk/Source/JavaScriptCore

setUpStaticFunctionSlot does not handle Builtin|Accessor properties
https://bugs.webkit.org/show_bug.cgi?id=158637

Reviewed by Geoff Garen.

setUpStaticFunctionSlot contains a duplicate copy of the body of the function reifyStaticProperty

however it is missing handling for Accessor type under Builtin functions.

Fix the bug by de-duplicating - setUpStaticFunctionSlot should just call reifyStaticProperty.

runtime/Lookup.cpp:

(JSC::setUpStaticFunctionSlot):

should just call reifyStaticProperty.

runtime/Lookup.h:

(JSC::lookupPut):
(JSC::reifyStaticProperty):

changed reifyStaticProperty to take PropertyName.

11:36 PM Changeset in webkit [202032] by barraclough@apple.com

2 edits in trunk/Source/WebCore

Remove hasStaticPropertyTable (part 3: JSLocation::putDelegate)
https://bugs.webkit.org/show_bug.cgi?id=158431

Unreviewed build fix.

bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::putDelegate):

11:18 PM Changeset in webkit [202031] by barraclough@apple.com

3 edits in trunk/Source/WebCore

Remove hasStaticPropertyTable (part 4: JSHTMLDocument & JSStorage)
https://bugs.webkit.org/show_bug.cgi?id=158431

Reviewed by Chris Dumez.

All uses of hasStaticPropertyTable flag generated by bindings are wrong.

JSHTMLDocument & JSStorage contain a number of static_asserts claiming that
various methods do not support static properties. These asserts were likely
correct at the time they were added, as JSObject::getOwnPropertySlot and
JSObject::deleteProperty did not support getting / deleting static value.
This is no longer the case, and these asserts are now incorrect.

bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::getOwnPropertySlot):

bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::deletePropertyByIndex):
(WebCore::JSStorage::putDelegate):

remove incorrect static_asserts.

11:17 PM Changeset in webkit [202030] by barraclough@apple.com

2 edits in trunk/Source/WebCore

Remove hasStaticPropertyTable (part 3: JSLocation::putDelegate)
https://bugs.webkit.org/show_bug.cgi?id=158431

Reviewed by Geoff Garen.

All uses of hasStaticPropertyTable flag generated by bindings are wrong.

JSLocation::putDelegate checks the static property table redundantly.

In the case of same origin access, if the property is not in the static
table the method will call JSObject::put and return true (indicating the
delegate handled the put). If the property is in the static table, the
method will return false (indicating the the delegate did not handle the
access) - in which case the calling function will call JSObject::put.
Checking for the property in the static table is redundant - same origin
access does not require any special handling, and should just always
return false & let the caller handle the put.

In the case of cross origin access, if the property is not in the static
table we return true (indicating the access was handled, and silently
blocking it). If it is a static property, we check the name, and if the
name is not 'href' we also return true, silently blocking. In the case
that the name is 'href' we'll return false, indicating to the caller
that the access was not handled by the delegate, resulting in it taking
place. The additional check of the static table is redundant, since we
only have special behaviour in the case of 'href'. (Moreover it is
unnecesszarily fragile, since if we made a change such that 'href' was no
longer implemented as a static property with would fail.)

for same origin, always return false.
for cross origin, return false for 'href', otherwise return true.

bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::putDelegate):

restructure & remove static table check.

11:09 PM Changeset in webkit [202029] by barraclough@apple.com

2 edits in trunk/Source/WebCore

Remove hasStaticPropertyTable (part 2: JSPluginElement)
https://bugs.webkit.org/show_bug.cgi?id=158431

Reviewed by Chris Dumez.

All uses of hasStaticPropertyTable flag generated by bindings are wrong.

The check in pluginElementCustomGetOwnPropertySlot was somewhat dubious in the
first place (for types with static properties it would give precedence to both
static and also property storage properties; for types without static properties
it would check neither - an odd asymetry in the case of values in the storage
array, and was depending on an implementation detail that could change).

This is all now redundant anyway. None of these types have static properties.
All properties are now corretcly on the prototype (which is handled appropriately
below). This is just dead code.

bindings/js/JSPluginElementFunctions.h:

(WebCore::pluginElementCustomGetOwnPropertySlot):

remove dead code.

11:08 PM Changeset in webkit [202028] by barraclough@apple.com

2 edits in trunk/Source/WebCore

Remove hasStaticPropertyTable (part 1: DOM bindings)
https://bugs.webkit.org/show_bug.cgi?id=158431

Reviewed by Chris Dumez.

All uses of hasStaticPropertyTable flag generated by bindings are wrong.

bindings/js/JSDOMBinding.h:

(WebCore::getStaticValueSlotEntryWithoutCaching): Deleted.
(WebCore::getStaticValueSlotEntryWithoutCaching<JSDOMObject>): Deleted.

this method is not used anywhere.

11:04 PM Changeset in webkit [202027] by barraclough@apple.com

10 edits
2 moves in trunk/Source/JavaScriptCore

JSBoundSlotBaseFunction no longer binds slot base
https://bugs.webkit.org/show_bug.cgi?id=157978

Reviewed by Geoff Garen.

This class is basically currently named after a bug. We should never have
been binding function to slot bases - this was not ever correct behavior.
This was fixed earlier in the year, but there is still some cruft including
the class name to clean up.

renamed JSBoundSlotBaseFunction -> JSCustomGetterSetterFunction
removed m_boundSlotBase - don't retain the original slot base (we were not really using it anyway).
ASSERT customGetterSetter->getter/setter are non-null, rather than checking.
Store the PropertyName such that we can pass this to the getter (we're currently reperforming the String->Identifier conversion every time).
Removed JSFunction::lookUpOrCreateNativeExecutable - this is just overhead, and not used consistently.

CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
runtime/JSBoundSlotBaseFunction.cpp: Removed.
runtime/JSBoundSlotBaseFunction.h: Removed.
- JSBoundSlotBaseFunction -> JSCustomGetterSetterFunction
runtime/JSCustomGetterSetterFunction.cpp: Copied from Source/JavaScriptCore/runtime/JSBoundSlotBaseFunction.cpp.

(JSC::JSCustomGetterSetterFunction::customGetterSetterFunctionCall):

made a static function on JSCustomGetterSetterFunction such that accessor to member properties could be made private. Call variant of callCustomSetter that does not require slotBase, ASSERT getter/setter present, pass stored PropertyName to getter.

(JSC::JSCustomGetterSetterFunction::JSCustomGetterSetterFunction):

renamed, store propertyName.

(JSC::JSCustomGetterSetterFunction::create):

use same function name to Executable as is being passed to Function::finishCreation.

(JSC::JSCustomGetterSetterFunction::visitChildren):
(JSC::JSCustomGetterSetterFunction::finishCreation):

removed m_boundSlotBase.

runtime/JSCustomGetterSetterFunction.h: Copied from Source/JavaScriptCore/runtime/JSBoundSlotBaseFunction.h.

(JSC::JSCustomGetterSetterFunction::customGetterSetter):
(JSC::JSCustomGetterSetterFunction::isSetter):

made private.

(JSC::JSCustomGetterSetterFunction::propertyName):

new accessor.

(JSC::JSBoundSlotBaseFunction::boundSlotBase): Deleted.

removed.

runtime/JSFunction.cpp:

(JSC::JSFunction::create):
(JSC::JSFunction::lookUpOrCreateNativeExecutable): Deleted.

removed lookUpOrCreateNativeExecutable. This inconsistently used wrapper was providing no value, only bloat.

runtime/JSFunction.h:
runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

renamed JSBoundSlotBaseFunction -> JSCustomGetterSetterFunction, etc.

runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::customGetterSetterFunctionStructure):
(JSC::JSGlobalObject::boundSlotBaseFunctionStructure): Deleted.

renamed JSBoundSlotBaseFunction -> JSCustomGetterSetterFunction, etc.

runtime/JSNativeStdFunction.cpp:

(JSC::JSNativeStdFunction::create):

removed lookUpOrCreateNativeExecutable.

runtime/JSObject.cpp:

(JSC::getCustomGetterSetterFunctionForGetterSetter):
(JSC::JSObject::getOwnPropertyDescriptor):
(JSC::getBoundSlotBaseFunctionForGetterSetter): Deleted.

renamed JSBoundSlotBaseFunction -> JSCustomGetterSetterFunction, etc.

runtime/VM.h:
- renamed JSBoundSlotBaseFunction -> JSCustomGetterSetterFunction, etc.

11:04 PM Changeset in webkit [202026] by adam.bergkvist@ericsson.com

15 edits in trunk

WebRTC: Imlement MediaEndpointPeerConnection::replaceTrack()
https://bugs.webkit.org/show_bug.cgi?id=158688

Reviewed by Eric Carlson.

Source/WebCore:

Implement MediaEndpointPeerConnection::replaceTrack() that is the MediaEndpoint implementation
of RTCRtpSender.replaceTrack() [1].

[1] https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html#dom-rtcrtpsender-replacetrack

Updated fast/mediastream/RTCRtpSender-replaceTrack.html

Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::MediaEndpointPeerConnection::replaceTrack):
(WebCore::MediaEndpointPeerConnection::replaceTrackTask):
Implemented.

Modules/mediastream/MediaEndpointPeerConnection.h:
Modules/mediastream/PeerConnectionBackend.h:
Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::replaceTrack):

Modules/mediastream/RTCPeerConnection.h:

Move the MediaStreamTrack instance of sending a reference to it. This change is the main
reason many files are touched by this change.

Modules/mediastream/RTCRtpSender.h:
Modules/mediastream/RTCRtpSender.idl:
platform/mediastream/MediaEndpoint.h:

Use mid instead of mdescIndex to identify the media description in the backend.

platform/mock/MockMediaEndpoint.cpp:

(WebCore::MockMediaEndpoint::replaceSendSource):

platform/mock/MockMediaEndpoint.h:

LayoutTests:

Update existing test for RTCRtpSender.replaceTrack.

fast/mediastream/RTCRtpSender-replaceTrack-expected.txt:
fast/mediastream/RTCRtpSender-replaceTrack.html:

Add test cases where a "not yet negotiated track" is directly replaced. Also check that the
old track id is used in later offers.

fast/mediastream/resources/promise-utils.js:

(promiseShouldResolve):
Added utility method to test promise expressions that are expected to resolve.

9:33 PM Changeset in webkit [202025] by commit-queue@webkit.org

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Show Exception Stack in UncaughtExceptionReporter view
https://bugs.webkit.org/show_bug.cgi?id=158657
<rdar://problem/26754441>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-13
Reviewed by Darin Adler.

UserInterface/Debug/UncaughtExceptionReporter.css:

(.uncaught-exception-sheet li):
Make newlines significant.

UserInterface/Debug/UncaughtExceptionReporter.js:

(unblockEventHandlers):
(handleError):
(handleLinkClick):
(formattedEntry):
Format the exception and a possible stack with a bit of sanitizing.

9:10 PM MathML/Early_2016_Refactoring edited by fred.wang@free.fr

(diff)

9:03 PM Changeset in webkit [202024] by mitz@apple.com

2 edits in trunk/Source/WebKit2

[Mac] Web Content service with a restricted entitlement may load arbitrary dylibs
https://bugs.webkit.org/show_bug.cgi?id=156668
<rdar://problem/26714558>

Reviewed by Anders Carlsson.

Configurations/WebContentService.xcconfig: Enable library validation when the Web Content service is given the XPC domain extension entitlement when targeting macOS Sierra or later.

8:28 PM Changeset in webkit [202023] by commit-queue@webkit.org

81 edits
3 copies
11 adds in trunk

window.onerror should pass the ErrorEvent's 'error' property as the 5th argument to the event handler
https://bugs.webkit.org/show_bug.cgi?id=55092
<rdar://problem/25731279>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-13
Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

This includes the actual Error in window.error / ErrorEvent:
https://html.spec.whatwg.org/multipage/webappapis.html#the-errorevent-interface

This is useful for scripts to be able to get an error stack
from uncaught exceptions, by checking the error itself.

Tests: fast/events/window-onerror17.html

http/tests/security/cross-origin-script-error-event-redirected.html
http/tests/security/cross-origin-script-error-event.html
http/tests/security/script-crossorigin-error-event-information.html
http/tests/security/script-no-crossorigin-error-event-should-be-sanitized.html
userscripts/window-onerror-for-isolated-world-3.html

CMakeLists.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSBindingsAllInOne.cpp:

Add new custom error event file.

bindings/js/JSDOMBinding.cpp:

(WebCore::reportException):
Include the JSC::Exception when reporting exceptions, so the error value is available.

bindings/js/JSErrorEventCustom.cpp:

(WebCore::JSErrorEvent::error):
Sanitized access to the ErrorEvent's error property to prevent leaking objects
across isolated world boundaries. This is like CustomEvent's data property.

bindings/js/JSErrorHandler.cpp:

(WebCore::JSErrorHandler::handleEvent):

bindings/js/JSErrorHandler.h:

Include the error object as the 4th argument to the window.onerror event handler.

dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::sanitizeScriptError):
(WebCore::ScriptExecutionContext::reportException):
(WebCore::ScriptExecutionContext::dispatchErrorEvent):

dom/ScriptExecutionContext.h:

Include the error object in the ErrorEvent constructed when dispatching error events.

dom/ErrorEvent.cpp:

(WebCore::ErrorEvent::ErrorEvent):
(WebCore::ErrorEvent::sanitizedErrorValue):
(WebCore::ErrorEvent::trySerializeError):

dom/ErrorEvent.h:
dom/ErrorEvent.idl:

Include an any "error" property on the ErrorEvent, and allow it in initialization.

bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):

workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):
Within the Worker world, the error is included in the event.
When re-dispatching the error on the world object in the world that spawned the
Worker the event does not include an error object. This matches other browsers
right now, but could be improved to have the same cross world serialization
as isolated worlds have with the error data.

dom/CustomEvent.h:

Remove unimplemented stale method.

LayoutTests:

platform/wk2/TestExpectations:

Skip new userscript test on WebKit2 like others.

fast/events/constructors/error-event-constructor-expected.txt:
fast/events/constructors/error-event-constructor.html:

Test for the new any "error" initialization property.

fast/events/event-leak-objects-expected.txt:
fast/events/event-leak-objects.html:
fast/events/event-properties-gc-expected.txt:
fast/events/event-properties-gc.html:

Like CustomEvent.details, ErrorEvent.error should not leak
objects across isolated worlds.

fast/events/window-onerror-exception-in-attr-expected.txt:
fast/events/window-onerror-exception-in-attr.html:
fast/events/window-onerror-syntax-error-in-attr-expected.txt:
fast/events/window-onerror-syntax-error-in-attr.html:
fast/events/window-onerror1-expected.txt:
fast/events/window-onerror1.html:
fast/events/window-onerror10-expected.txt:
fast/events/window-onerror10.html:
fast/events/window-onerror11-expected.txt:
fast/events/window-onerror11.html:
fast/events/window-onerror12-expected.txt:
fast/events/window-onerror12.html:
fast/events/window-onerror13.html:
fast/events/window-onerror14.html:
fast/events/window-onerror16.html:
fast/events/window-onerror17-expected.txt: Added.
fast/events/window-onerror17.html: Copied from LayoutTests/fast/events/window-onerror12.html.
fast/events/window-onerror2-expected.txt:
fast/events/window-onerror2.html:
fast/events/window-onerror3-expected.txt:
fast/events/window-onerror3.html:
fast/events/window-onerror4-expected.txt:
fast/events/window-onerror4.html:
fast/events/window-onerror5-expected.txt:
fast/events/window-onerror5.html:
fast/events/window-onerror6-expected.txt:
fast/events/window-onerror6.html:
fast/events/window-onerror7-expected.txt:
fast/events/window-onerror7.html:
fast/events/window-onerror8-expected.txt:
fast/events/window-onerror8.html:
fast/events/window-onerror9-expected.txt:
fast/events/window-onerror9.html:

Include output for the column number and error object where possible.

fast/files/resources/setup-for-read-common.js:
fast/files/workers/worker-apply-blob-url-to-xhr.html:
fast/workers/resources/worker-error-in-handling-script-error.js:
fast/workers/resources/worker-script-error-bubbled.js:
fast/workers/resources/worker-script-error-handled.js:
fast/workers/resources/worker-script-error.js:
fast/workers/worker-script-error-expected.txt:

Test "onerror" within Workers, and the "error" event on
the Worker from the spawning context.

http/tests/security/cross-origin-script-error-event-expected.txt: Added.
http/tests/security/cross-origin-script-error-event-redirected-expected.txt: Added.
http/tests/security/cross-origin-script-error-event-redirected.html: Added.
http/tests/security/cross-origin-script-error-event.html: Added.
http/tests/security/cross-origin-script-window-onerror-expected.txt:
http/tests/security/cross-origin-script-window-onerror-redirected-expected.txt:
http/tests/security/cross-origin-script-window-onerror-redirected.html:
http/tests/security/cross-origin-script-window-onerror.html:
http/tests/security/script-crossorigin-error-event-information-expected.txt: Added.
http/tests/security/script-crossorigin-error-event-information.html: Added.
http/tests/security/script-crossorigin-onerror-information-expected.txt:
http/tests/security/script-crossorigin-onerror-information.html:
http/tests/security/script-no-crossorigin-error-event-should-be-sanitized-expected.txt: Added.
http/tests/security/script-no-crossorigin-error-event-should-be-sanitized.html: Copied from LayoutTests/http/tests/security/script-no-crossorigin-onerror-should-be-sanitized.html.
http/tests/security/script-no-crossorigin-onerror-should-be-sanitized-expected.txt:
http/tests/security/script-no-crossorigin-onerror-should-be-sanitized.html:
http/tests/security/window-onerror-exception-in-iframe-expected.txt:
http/tests/security/window-onerror-exception-in-iframe.html:
http/tests/workers/worker-importScriptsOnError-expected.txt:
js/dom/exception-line-number-expected.txt:
js/dom/script-tests/exception-line-number.js:

(window.onerror):

userscripts/window-onerror-for-isolated-world-1-expected.txt:
userscripts/window-onerror-for-isolated-world-1.html:
userscripts/window-onerror-for-isolated-world-2-expected.txt:
userscripts/window-onerror-for-isolated-world-2.html:
userscripts/window-onerror-for-isolated-world-3-expected.txt: Added.
userscripts/window-onerror-for-isolated-world-3.html: Added.

Add an explicit test for error objects crossing isolated world boundaries.
In the Isolated World case, serializable values are cloned, but unserializable
values cause the error object to return to null to avoid leaking across worlds.

8:05 PM Changeset in webkit [202022] by dino@apple.com

3 edits
2 adds in trunk

SVG elements don't blend correctly into HTML
https://bugs.webkit.org/show_bug.cgi?id=158718
<rdar://problem/26782004>

Reviewed by Antoine Quint.

Source/WebCore:

We were not creating any transparency layers for the root SVG nodes.
This is ok if the SVG is the root document, because it is the backdrop.
However, if it is inline SVG, it needs to apply the operation in
order to composite into the document.

Test: svg/css/mix-blend-mode-with-inline-svg.html

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::beginTransparencyLayers):

LayoutTests:

svg/css/mix-blend-mode-with-inline-svg-expected.html: Added.
svg/css/mix-blend-mode-with-inline-svg.html: Added.

7:29 PM Changeset in webkit [202021] by sbarati@apple.com

2 edits in trunk/Source/JavaScriptCore

The sampling profiler should further protect itself against certain forms of sampling bias that arise due to the sampling interval being in sync with some other system process
https://bugs.webkit.org/show_bug.cgi?id=158678

Reviewed by Benjamin Poulain.

I first became aware of this problem when I read this paper:
http://plv.colorado.edu/papers/mytkowicz-pldi10.pdf

To provide background for this change, I'll quote a paragraph
from section 6.2:
"One statically sound method for collecting random samples is to collect a
sample at every t + r milliseconds, where t is the desired sampling interval
and r is a random number between −t and t. One might think that sampling every
t seconds is enough (i.e., drop the r component) but it is not: specifically,
if a profiler samples every t seconds, the sampling rate would be synchronized
with any program or system activity that occurs at regular time intervals [17].
For example, if the thread scheduler switches between threads every 10ms and our
sampling interval was also 10ms, then we may always take samples immediately after
a thread switch. Because performance is often different immediately after a thread
switch than at other points (e.g., due to cache and TLB warm-up effects) we would
get biased data. The random component, r, guards against such situations."

runtime/SamplingProfiler.cpp:

(JSC::SamplingProfiler::timerLoop):

7:27 PM Changeset in webkit [202020] by ddkilzer@apple.com

3 edits in trunk/Tools

False-positive over-release of WebView in destroyWebViewAndOffscreenWindow() in DumpRenderTree.mm
<https://webkit.org/b/158716>

Reviewed by Andy Estes.

DumpRenderTree/mac/DumpRenderTree.mm:

(destroyWebViewAndOffscreenWindow): Change this function to take
a WebView, and assert that it's the same as [mainFrame webView].
(dumpRenderTree): Pass 'webView' into
destroyWebViewAndOffscreenWindow().

DumpRenderTree/mac/DumpRenderTreeMac.h:

(createWebViewAndOffscreenWindow): Add NS_RETURNS_RETAINED since
this function returns a +1 WebView. Declare this method only for
Objective-C[++] source.

5:34 PM Changeset in webkit [202019] by beidson@apple.com

6 edits in trunk

storage/indexeddb/modern/leaks-1.html leaks the database connection handle.
https://bugs.webkit.org/show_bug.cgi?id=158643

Reviewed by Alex Christensen.

Source/WebCore:

Tested by changes to existing test.

Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::hasPendingActivity):

dom/EventTarget.h:

(WebCore::EventTarget::eventTargetData):
(WebCore::EventTarget::hasEventListeners):

LayoutTests:

storage/indexeddb/modern/leak-1-expected.txt:
storage/indexeddb/modern/resources/leak-1.js:

5:17 PM Changeset in webkit [202018] by enrica@apple.com

3 edits in trunk/Source/WebCore

REGRESSION(r201956): Failure to initialize new internal settings produced random test failures in release.
https://bugs.webkit.org/show_bug.cgi?id=158713
rdar://26769957

Reviewed by Simon Fraser.

Failed to initialize the new member variable in both Settings and InternalSettings classes.

page/Settings.cpp:

(WebCore::Settings::Settings):

testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):

5:11 PM Changeset in webkit [202017] by Chris Dumez

4 edits in trunk/Source/WebCore

Drop HipChat hack introduced in r197548
https://bugs.webkit.org/show_bug.cgi?id=158711

Reviewed by Geoffrey Garen.

Drop HipChat hack introduced in r197548. This hack is no longer needed
as the bug was fixed in HipChat since then:
https://support.atlassian.com/servicedesk/customer/portal/32/HCP-7532

I have confirmed locally that the latest version (4.0.12.665) is able
to connect without the hack.

bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::putDelegate): Deleted.

platform/RuntimeApplicationChecks.h:
platform/RuntimeApplicationChecks.mm:

(WebCore::MacApplication::isHipChat): Deleted.

4:52 PM Changeset in webkit [202016] by Jon Davis

2 edits in trunk/Websites/webkit.org

Minor style updates for figcaptions and post forewords.

wp-content/themes/webkit/style.css:

(article .foreword):
(figure.aligncenter figcaption):
(figure.aligncenter figcaption::before):

4:17 PM Changeset in webkit [202015] by oliver@apple.com

3 edits in trunk/Source/JavaScriptCore

DFG Validation fails when performing a concatenation with only a single entry
https://bugs.webkit.org/show_bug.cgi?id=158699

Reviewed by Saam Barati.

Fairly simple short circuiting of a single replacement template string
without any padding to be planted as a simple to string rather than
op_strcat.

bytecompiler/NodesCodegen.cpp:

(JSC::TemplateLiteralNode::emitBytecode):

tests/stress/template-literal.js:

(testSingleNode):

4:05 PM Changeset in webkit [202014] by Chris Fleizach

2 edits in trunk/Source/WebCore

AX: CrashTracer: com.apple.WebKit.WebContent at WebCore::AccessibilityRenderObject::remoteSVGRootElement const + 227
https://bugs.webkit.org/show_bug.cgi?id=158685

Reviewed by David Kilzer.

Crash reports show a null access at a line that tries to dereference a pointer.
I still don't have a way to layout test this, as it seems tied to tear down of the main document.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::remoteSVGRootElement):

3:57 PM Changeset in webkit [202013] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Use two video layer solution only on mac.
https://bugs.webkit.org/show_bug.cgi?id=158705
rdar://problem/26776360

Patch by Jeremy Jones <jeremyj@apple.com> on 2016-06-13
Reviewed by Jer Noble.

Two video layer solution is only useful on the mac to prevent flicker, so don't do it elsewhere.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerLayer):

3:53 PM Changeset in webkit [202012] by Jon Davis

3 edits in trunk/Websites/webkit.org

Adds support for foreword custom meta and display styles on blog posts.
https://bugs.webkit.org/show_bug.cgi?id=158707.

Reviewed by Timothy Hatcher.

wp-content/themes/webkit/functions.php:
wp-content/themes/webkit/style.css:

(article .foreword):

3:44 PM Changeset in webkit [202011] by Matt Baker

4 edits in trunk/Source/WebInspectorUI

Web Inspector: Filter Records not applying to new records
https://bugs.webkit.org/show_bug.cgi?id=158213
<rdar://problem/26543912>

Reviewed by Timothy Hatcher.

This patch makes the following improvements to timeline grid filtering:

Records are filtered as they are added to the grid.
Timeline view no longer triggers a filter refresh while the current time changes while recording.
Filters are refreshed whenever the current timeline view changes.

UserInterface/Views/DataGrid.js:

(WebInspector.DataGrid.prototype.hasFilters):
Helper function to check for custom and text filters.

(WebInspector.DataGrid.prototype._applyFiltersToNodeAndDispatchEvent):
Encapsulate node state change and event dispatch, which was previously
done in multiple places.

(WebInspector.DataGrid.prototype.insertChild):
Filter incoming node if needed.

(WebInspector.DataGrid.prototype._updateFilter.createIteratorForNodesToBeFiltered):
(WebInspector.DataGrid.prototype._updateFilter):
(WebInspector.DataGrid.prototype.yieldableTaskWillProcessItem):
Use new convenience functions.

(WebInspector.DataGrid.prototype.hasCustomFilters): Deleted.
Renamed hasFilters.

UserInterface/Views/TimelineRecordingContentView.js:

(WebInspector.TimelineRecordingContentView.prototype._currentContentViewDidChange):
Refresh grid filters on view change.

UserInterface/Views/TimelineView.js:

(WebInspector.TimelineView.prototype.set startTime):
(WebInspector.TimelineView.prototype.set endTime):
Schedule filter change notification when selection bounds changes.

(WebInspector.TimelineView.prototype._timesDidChange):
(WebInspector.TimelineView.prototype._scheduleFilterDidChange):
(WebInspector.TimelineView):

3:43 PM Changeset in webkit [202010] by sbarati@apple.com

7 edits
2 adds in trunk/Source/WebInspectorUI

Web Inspector: Call Trees view should have a 'Top Functions'-like mode
https://bugs.webkit.org/show_bug.cgi?id=158555
<rdar://problem/26712544>

Reviewed by Timothy Hatcher.

This patch adds a Top Functions view that is similar to Instruments'
Top Functions view. I really wanted to add this view because I've
been doing a lot of performance debugging and I've exclusively
used the Top Functions view and I want the Inspector to also have
this view. I like to think of it as a more sophisticated version of the bottom-up view.

Top Functions works by treating every frame as a root in the tree.
Top functions view then presents a list of "roots". This is the same
as all other views, which also present a list of roots, but in this case,
every frame is a root. Bottom Up is great for nailing in specific performance
problems in exactly one frame. But Bottom Up doesn't give you good context about where
a specific frame is in the call tree and how frames are related by having
a caller or some path of shared callers. For example, consider this call tree:

(program)
/ \

/ \

(many nodes...)

/

/

(parent)
/ \

/ \

(leaf1) (leaf2)

Suppose that 'leaf1' is super hot, and 'leaf2' is moderately hot.
If we look at this through Bottom Up view, we will see 'leaf1'
is super hot, but it will take more scrolling to see that 'leaf2'
is moderately hot. Lets say that 'parent' is also moderately hot,
but that the majority of its time isn't self time. With Bottom Up view,
there is no good way to see that 'leaf1' and 'leaf2' are both nodes under 'parent'.
With Top Down, you can find this information, but it requires a ton of drilling down into
the tree (i.e, you must expand past the 'many nodes...' I drew above). It's inconvenient to
use Top Down here for indentation alone. Bottom up will tell you that 'leaf1' is super hot,
and that 'leaf2' and 'parent' are moderately hot, but it doesn't show how they're related
in the original tree. It's important to see that 'parent's total time is very high
because it itself is moderately hot, and it has a child node that is super hot, and
another child that's moderately 'hot'. For the sake of this example, let's pretend
that 85% of the program's time is spent inside 'parent'. Seeing this information through
'Top Functions' is easy because this information filters to the top of the list. Specifically,
when using 'Top Functions' sorted by Total Time. Because every node is a root, there will be
a top-level entry for every frame in the program. Specifically, there will be a top-level node
for 'parent' in my above example. Because I've sorted this view by Total Time, I will see '(program)'
first. That's because 100% of execution time is under the '(program)' frame. Then, I might see
a few other nodes that also run the entire time because '(program)' calls them, and they eventually
call into other things that never leave the stack. These will also have time ranges near 100%.
But, only a few nodes after that, I'll see 'parent' in the list because it accounts for 85% of
execution time. Immediately, I will see that it has some self time, and that it has two child
nodes that have self time. This is really helpful.

Let's consider another example where it's not easy in Top Down to get the full picture of 'parent':

(program)

/ | \

(... many nodes...)

/ \

(many nodes...) (many nodes...)

/ \

parent parent

| |

leaf1 leaf2

If we viewed this program in Top Down, we don't get a full picture of 'parent'
because it has its time distributed in two different subsections of the tree.
Specifically, lets say it has 70% of time in the leaf1 path, and 30% of the
time in the leaf2 path. We want a way to see these things together. It's impossible
to do this in Top Down or Bottom Up. But, in Top Functions view, we get the view that
we want to see because we treat 'parent' as a root of the tree. Because we do this,
we will create the following sub tree in the Top Functions view:

parent

/ \

leaf1 leaf2

This happens naturally because when 'parent' is a root, we add all its children
to its subtree.

Constructing this tree is really easy. What we do is take any arbitrary stack
trace of length n, and treat is as n separate stack traces. Specifically, we
perform the following operation for any stack trace S.

S = [A, B, C, D]
(A is the entry frame, and D is the top of the stack).
We will transform this into a list of stack traces S' like so:
S' = A, B, C, D], [B, C, D], [C, D], [D

If we then run the normal top down tree algorithm on this set of stack
traces, all nodes get treated as roots, and voila, we get the Top Functions view.

Localizations/en.lproj/localizedStrings.js:
UserInterface/Controllers/TimelineManager.js:
UserInterface/Main.html:
UserInterface/Models/CallingContextTree.js:
UserInterface/Models/TimelineRecording.js:
UserInterface/Views/ScriptProfileTimelineView.js:
UserInterface/Views/TextToggleButtonNavigationItem.css: Added.
UserInterface/Views/TextToggleButtonNavigationItem.js: Added.

3:41 PM Changeset in webkit [202009] by Matt Baker

7 edits in trunk/Source/WebInspectorUI

Web Inspector: Add ability to show/hide DataGird columns
https://bugs.webkit.org/show_bug.cgi?id=158676
<rdar://problem/26761573>

Reviewed by Timothy Hatcher.

Make it possible to show/hide grid columns using the grid header
context menu. This patch enables the new behavior for most of the
timeline grids.

UserInterface/Views/DataGrid.js:

(WebInspector.DataGrid):
(WebInspector.DataGrid.prototype.get identifier):
(WebInspector.DataGrid.prototype.set identifier):
An identifier for the grid instance, for managing per-grid settings.
Setting the id causes settings to be created, and their values to be
applied to the grid.

(WebInspector.DataGrid.prototype.get columnChooserEnabled):
(WebInspector.DataGrid.prototype.set columnChooserEnabled):
Enable showing/hiding columns via the grid header.

(WebInspector.DataGrid.prototype.insertColumn):
(WebInspector.DataGrid.prototype.showColumn):
Set column visibility and hidden column setting, then perform layout.

(WebInspector.DataGrid.prototype._collapseColumnGroupWithCell):
(WebInspector.DataGrid.prototype._contextMenuInHeader):
Create column chooser menu items if necessary.

(WebInspector.DataGrid.prototype._showColumn): Deleted.
(WebInspector.DataGrid.prototype._hideColumn): Deleted.
Replaced by showColumn.

UserInterface/Views/LayoutTimelineView.js:

(WebInspector.LayoutTimelineView):
Always show "type" and "name" columns.

UserInterface/Views/NetworkTimelineView.js:

(WebInspector.NetworkTimelineView):

UserInterface/Views/RenderingFrameTimelineView.js:

(WebInspector.RenderingFrameTimelineView):

UserInterface/Views/ScriptDetailsTimelineView.js:

(WebInspector.ScriptDetailsTimelineView):
Always show "name" column.

UserInterface/Views/TimelineDataGrid.js:

(WebInspector.TimelineDataGrid):
Enable column chooser.

3:25 PM Changeset in webkit [202008] by rniwa@webkit.org

2 edits in trunk/Websites/perf.webkit.org

Build fix. Strip out "use strict" everywhere so that the perf dashboard works on the shipping Safari.

tools/bundle-v3-scripts.py:

(main):

3:17 PM Changeset in webkit [202007] by fpizlo@apple.com

3 edits in trunk/Source/JavaScriptCore

FTL::Output methods should be out-of-line whenever possible
https://bugs.webkit.org/show_bug.cgi?id=158704

Reviewed by Benjamin Poulain.

These methods turn into a non-trivial amount of code because of the template-based B3 API.
Inlining them didn't achieve any performance advantages for the FTL, but it did make the
code larger. This outlines most methods in FTL::Output. It makes FTL::LowerDFGToB3 smaller
and it doesn't change performance.

ftl/FTLOutput.cpp:

(JSC::FTL::Output::appendTo):
(JSC::FTL::Output::framePointer):
(JSC::FTL::Output::lockedStackSlot):
(JSC::FTL::Output::constBool):
(JSC::FTL::Output::constInt32):
(JSC::FTL::Output::constInt64):
(JSC::FTL::Output::constDouble):
(JSC::FTL::Output::phi):
(JSC::FTL::Output::add):
(JSC::FTL::Output::sub):
(JSC::FTL::Output::mul):
(JSC::FTL::Output::div):
(JSC::FTL::Output::chillDiv):
(JSC::FTL::Output::mod):
(JSC::FTL::Output::chillMod):
(JSC::FTL::Output::neg):
(JSC::FTL::Output::doubleAdd):
(JSC::FTL::Output::doubleSub):
(JSC::FTL::Output::doubleMul):
(JSC::FTL::Output::doubleDiv):
(JSC::FTL::Output::doubleMod):
(JSC::FTL::Output::bitAnd):
(JSC::FTL::Output::bitOr):
(JSC::FTL::Output::bitXor):
(JSC::FTL::Output::shl):
(JSC::FTL::Output::aShr):
(JSC::FTL::Output::lShr):
(JSC::FTL::Output::bitNot):
(JSC::FTL::Output::logicalNot):
(JSC::FTL::Output::ctlz32):
(JSC::FTL::Output::doubleAbs):
(JSC::FTL::Output::doubleCeil):
(JSC::FTL::Output::doubleFloor):
(JSC::FTL::Output::doubleTrunc):
(JSC::FTL::Output::doubleSin):
(JSC::FTL::Output::doubleCos):
(JSC::FTL::Output::doublePow):
(JSC::FTL::Output::doublePowi):
(JSC::FTL::Output::doubleSqrt):
(JSC::FTL::Output::doubleLog):
(JSC::FTL::Output::hasSensibleDoubleToInt):
(JSC::FTL::Output::doubleToUInt):
(JSC::FTL::Output::signExt32To64):
(JSC::FTL::Output::zeroExt):
(JSC::FTL::Output::intToDouble):
(JSC::FTL::Output::unsignedToDouble):
(JSC::FTL::Output::castToInt32):
(JSC::FTL::Output::doubleToFloat):
(JSC::FTL::Output::floatToDouble):
(JSC::FTL::Output::load):
(JSC::FTL::Output::load8SignExt32):
(JSC::FTL::Output::baseIndex):
(JSC::FTL::Output::equal):
(JSC::FTL::Output::notEqual):
(JSC::FTL::Output::above):
(JSC::FTL::Output::aboveOrEqual):
(JSC::FTL::Output::below):
(JSC::FTL::Output::belowOrEqual):
(JSC::FTL::Output::greaterThan):
(JSC::FTL::Output::greaterThanOrEqual):
(JSC::FTL::Output::lessThan):
(JSC::FTL::Output::lessThanOrEqual):
(JSC::FTL::Output::doubleEqual):
(JSC::FTL::Output::doubleEqualOrUnordered):
(JSC::FTL::Output::doubleNotEqualOrUnordered):
(JSC::FTL::Output::doubleLessThan):
(JSC::FTL::Output::doubleLessThanOrEqual):
(JSC::FTL::Output::doubleGreaterThan):
(JSC::FTL::Output::doubleGreaterThanOrEqual):
(JSC::FTL::Output::doubleNotEqualAndOrdered):
(JSC::FTL::Output::doubleLessThanOrUnordered):
(JSC::FTL::Output::doubleLessThanOrEqualOrUnordered):
(JSC::FTL::Output::doubleGreaterThanOrUnordered):
(JSC::FTL::Output::doubleGreaterThanOrEqualOrUnordered):
(JSC::FTL::Output::isZero32):
(JSC::FTL::Output::notZero32):
(JSC::FTL::Output::isZero64):
(JSC::FTL::Output::notZero64):
(JSC::FTL::Output::select):
(JSC::FTL::Output::jump):
(JSC::FTL::Output::branch):
(JSC::FTL::Output::check):
(JSC::FTL::Output::ret):
(JSC::FTL::Output::unreachable):
(JSC::FTL::Output::speculate):
(JSC::FTL::Output::speculateAdd):
(JSC::FTL::Output::speculateSub):
(JSC::FTL::Output::speculateMul):
(JSC::FTL::Output::patchpoint):
(JSC::FTL::Output::trap):
(JSC::FTL::Output::anchor):
(JSC::FTL::Output::bitCast):
(JSC::FTL::Output::fround):

ftl/FTLOutput.h:

(JSC::FTL::Output::setOrigin):
(JSC::FTL::Output::origin):
(JSC::FTL::Output::constIntPtr):
(JSC::FTL::Output::doubleNeg):
(JSC::FTL::Output::zeroExtPtr):
(JSC::FTL::Output::load32NonNegative):
(JSC::FTL::Output::isNull):
(JSC::FTL::Output::notNull):
(JSC::FTL::Output::testIsZeroPtr):
(JSC::FTL::Output::testNonZeroPtr):
(JSC::FTL::Output::call):
(JSC::FTL::Output::operation):
(JSC::FTL::Output::branch):
(JSC::FTL::Output::switchInstruction):
(JSC::FTL::Output::addIncomingToPhi):
(JSC::FTL::Output::framePointer): Deleted.
(JSC::FTL::Output::constBool): Deleted.
(JSC::FTL::Output::constInt32): Deleted.
(JSC::FTL::Output::constInt64): Deleted.
(JSC::FTL::Output::constDouble): Deleted.
(JSC::FTL::Output::phi): Deleted.
(JSC::FTL::Output::add): Deleted.
(JSC::FTL::Output::sub): Deleted.
(JSC::FTL::Output::mul): Deleted.
(JSC::FTL::Output::div): Deleted.
(JSC::FTL::Output::chillDiv): Deleted.
(JSC::FTL::Output::mod): Deleted.
(JSC::FTL::Output::chillMod): Deleted.
(JSC::FTL::Output::doubleAdd): Deleted.
(JSC::FTL::Output::doubleSub): Deleted.
(JSC::FTL::Output::doubleMul): Deleted.
(JSC::FTL::Output::doubleDiv): Deleted.
(JSC::FTL::Output::doubleMod): Deleted.
(JSC::FTL::Output::bitAnd): Deleted.
(JSC::FTL::Output::bitOr): Deleted.
(JSC::FTL::Output::bitXor): Deleted.
(JSC::FTL::Output::shl): Deleted.
(JSC::FTL::Output::aShr): Deleted.
(JSC::FTL::Output::lShr): Deleted.
(JSC::FTL::Output::ctlz32): Deleted.
(JSC::FTL::Output::addWithOverflow32): Deleted.
(JSC::FTL::Output::subWithOverflow32): Deleted.
(JSC::FTL::Output::mulWithOverflow32): Deleted.
(JSC::FTL::Output::addWithOverflow64): Deleted.
(JSC::FTL::Output::subWithOverflow64): Deleted.
(JSC::FTL::Output::mulWithOverflow64): Deleted.
(JSC::FTL::Output::doubleAbs): Deleted.
(JSC::FTL::Output::doubleCeil): Deleted.
(JSC::FTL::Output::doubleFloor): Deleted.
(JSC::FTL::Output::doubleSin): Deleted.
(JSC::FTL::Output::doubleCos): Deleted.
(JSC::FTL::Output::doublePow): Deleted.
(JSC::FTL::Output::doubleSqrt): Deleted.
(JSC::FTL::Output::doubleLog): Deleted.
(JSC::FTL::Output::signExt32To64): Deleted.
(JSC::FTL::Output::zeroExt): Deleted.
(JSC::FTL::Output::intToDouble): Deleted.
(JSC::FTL::Output::castToInt32): Deleted.
(JSC::FTL::Output::doubleToFloat): Deleted.
(JSC::FTL::Output::floatToDouble): Deleted.
(JSC::FTL::Output::equal): Deleted.
(JSC::FTL::Output::notEqual): Deleted.
(JSC::FTL::Output::above): Deleted.
(JSC::FTL::Output::aboveOrEqual): Deleted.
(JSC::FTL::Output::below): Deleted.
(JSC::FTL::Output::belowOrEqual): Deleted.
(JSC::FTL::Output::greaterThan): Deleted.
(JSC::FTL::Output::greaterThanOrEqual): Deleted.
(JSC::FTL::Output::lessThan): Deleted.
(JSC::FTL::Output::lessThanOrEqual): Deleted.
(JSC::FTL::Output::doubleEqual): Deleted.
(JSC::FTL::Output::doubleEqualOrUnordered): Deleted.
(JSC::FTL::Output::doubleNotEqualOrUnordered): Deleted.
(JSC::FTL::Output::doubleLessThan): Deleted.
(JSC::FTL::Output::doubleLessThanOrEqual): Deleted.
(JSC::FTL::Output::doubleGreaterThan): Deleted.
(JSC::FTL::Output::doubleGreaterThanOrEqual): Deleted.
(JSC::FTL::Output::doubleNotEqualAndOrdered): Deleted.
(JSC::FTL::Output::doubleLessThanOrUnordered): Deleted.
(JSC::FTL::Output::doubleLessThanOrEqualOrUnordered): Deleted.
(JSC::FTL::Output::doubleGreaterThanOrUnordered): Deleted.
(JSC::FTL::Output::doubleGreaterThanOrEqualOrUnordered): Deleted.
(JSC::FTL::Output::isZero32): Deleted.
(JSC::FTL::Output::notZero32): Deleted.
(JSC::FTL::Output::isZero64): Deleted.
(JSC::FTL::Output::notZero64): Deleted.
(JSC::FTL::Output::select): Deleted.
(JSC::FTL::Output::extractValue): Deleted.
(JSC::FTL::Output::jump): Deleted.
(JSC::FTL::Output::ret): Deleted.
(JSC::FTL::Output::unreachable): Deleted.
(JSC::FTL::Output::speculate): Deleted.
(JSC::FTL::Output::speculateAdd): Deleted.
(JSC::FTL::Output::speculateSub): Deleted.
(JSC::FTL::Output::speculateMul): Deleted.
(JSC::FTL::Output::patchpoint): Deleted.
(JSC::FTL::Output::trap): Deleted.
(JSC::FTL::Output::anchor): Deleted.
(JSC::FTL::Output::bitCast): Deleted.
(JSC::FTL::Output::fround): Deleted.

3:00 PM Changeset in webkit [202006] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Decrease PiP flicker by not removing window prematurely.
https://bugs.webkit.org/show_bug.cgi?id=158436
<rdar://problem/19052639>

Patch by Jeremy Jones <jeremyj@apple.com> on 2016-06-13
Reviewed by Darin Adler.

UIWindow shouldn't be removed until cleanupFullscreen, so the video layer has a chance
to be reparented in the DOM first.

platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::didStopPictureInPicture):

2:58 PM Changeset in webkit [202005] by achristensen@apple.com

44 edits
4 adds in trunk/Source

Add WebSocketProvider stub
https://bugs.webkit.org/show_bug.cgi?id=158702

Reviewed by Brady Eidson.

Source/WebCore:

No new tests. No change in behavior.

WebCore.xcodeproj/project.pbxproj:
dom/DocumentMarkerController.cpp:
dom/ScriptedAnimationController.cpp:
html/HTMLMediaElement.cpp:
html/MediaDocument.cpp:
html/shadow/MediaControlElements.cpp:
html/shadow/MediaControls.cpp:
html/shadow/MediaControls.h:
html/shadow/MediaControlsApple.cpp:
inspector/InspectorInstrumentation.cpp:
inspector/InspectorInstrumentation.h:
inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::overlayPage):

loader/EmptyClients.h:
loader/FrameLoader.cpp:
loader/FrameLoader.h:
loader/appcache/ApplicationCacheHost.cpp:
loader/cache/CachedResource.cpp:
page/FrameView.cpp:
page/Page.cpp:

(WebCore::Page::Page):

page/Page.h:

(WebCore::Page::applicationCacheStorage):
(WebCore::Page::databaseProvider):
(WebCore::Page::socketProvider):
(WebCore::Page::storageNamespaceProvider):

page/PageConfiguration.cpp:

(WebCore::PageConfiguration::PageConfiguration):

page/PageConfiguration.h:
page/ResourceUsageOverlay.cpp:
page/SocketProvider.h: Added.

(WebCore::SocketProvider::~SocketProvider):

page/cocoa/ResourceUsageOverlayCocoa.mm:
rendering/RenderElement.cpp:
rendering/RenderLayerBacking.cpp:
style/StyleResolveForDocument.cpp:
style/StyleTreeResolver.cpp:
svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged):

testing/MockPageOverlayClient.cpp:

Source/WebKit:

WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

Misc/WebSocketProvider.h: Added.
WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):

Source/WebKit/win:

WebSocketProvider.h: Added.
WebView.cpp:

(WebView::initWithFrame):

Source/WebKit2:

WebKit2.xcodeproj/project.pbxproj:
WebProcess/Network/WebSocketProvider.h: Added.
WebProcess/WebPage/WebPage.cpp:

(WebKit::m_shouldDispatchFakeMouseMoveEvents):

Source/WTF:

wtf/UniqueRef.h:

(WTF::UniqueRef::operator->):
(WTF::UniqueRef::operator T&):
(WTF::UniqueRef::operator const T&):
Added operator T& to avoid unneeded .get() calls.

2:55 PM Changeset in webkit [202004] by keith_miller@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed, Cloop build fix.

bytecode/BytecodeList.json:

2:05 PM Changeset in webkit [202003] by keith_miller@apple.com

32 edits
1 add in trunk/Source/JavaScriptCore

Add new builtin opcode tailCallForwardArguments
https://bugs.webkit.org/show_bug.cgi?id=158666

Reviewed by Filip Pizlo.

We should support the ability to have a builtin forward its
arguments to a helper without allocating an arguments object. This
patch adds a new bytecode intrinsic @tailCallForwardArguments that
takes two values. The first is the target of the call and the
second is the new this value. This opcode will tail call to the
passed function without triggering an allocation of an arguments
object for the caller function.

In the LLInt and Baseline this function acts the same way a normal
tail call does. The bytecode will allocate a new stack frame
copying all the arguments of the caller function into the new
frame, along with the new this. Then when the actual call happens
the new frame is copied over the caller frame. While this is not
necessary, it allows the target function to have more arguments
than the caller function via arity fixup.

Once we get to the DFG we reuse existing DFG Nodes for forwarding
arguments, although there were some minor changes. This patch
swaps the meaning of the second and third children for each DFG
varargs node, exchanging the argmuments and this child,
respectively. It also makes the arguments child for each varargs
node, as well as the ForwardVarargs node optional. If the optional
child is missing, then forwarding node assumes that the arguments
for the node's inlineCallFrame should be used instead. Finally,
when inlining the target of an inlined
op_tail_call_forward_arguments we make sure the arguments of the
forwarding function are marked as non-unboxable since this would
normally be done by the caller's create arguments object node,
which does not exist in this case.

bytecode/BytecodeIntrinsicRegistry.h:
bytecode/BytecodeList.json:
bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

bytecode/CallLinkInfo.h:

(JSC::CallLinkInfo::callTypeFor):

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::finishCreation):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCallForwardArgumentsInTailPosition):
(JSC::BytecodeGenerator::emitCallVarargs):

bytecompiler/BytecodeGenerator.h:
bytecompiler/NodesCodegen.cpp:

(JSC::BytecodeIntrinsicNode::emit_intrinsic_tailCallForwardArguments):
(JSC::BytecodeIntrinsicNode::emit_intrinsic_tryGetById):

dfg/DFGArgumentsEliminationPhase.cpp:
dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleVarargsCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGNode.h:

(JSC::DFG::Node::hasArgumentsChild):
(JSC::DFG::Node::argumentsChild):

dfg/DFGPreciseLocalClobberize.h:

(JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):

dfg/DFGPredictionPropagationPhase.cpp:
dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileForwardVarargs):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

dfg/DFGVarargsForwardingPhase.cpp:
ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargs):
(JSC::FTL::DFG::LowerDFGToB3::compileForwardVarargs):

interpreter/Interpreter.cpp:

(JSC::sizeFrameForForwardArguments):
(JSC::setupForwardArgumentsFrame):
(JSC::setupForwardArgumentsFrameAndSetThis):

interpreter/Interpreter.h:
jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

jit/JIT.h:
jit/JITCall.cpp:

(JSC::JIT::compileSetupVarargsFrame):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::emit_op_tail_call_forward_arguments):
(JSC::JIT::emitSlow_op_tail_call_forward_arguments):

jit/JITCall32_64.cpp:

(JSC::JIT::emitSlow_op_tail_call_forward_arguments):
(JSC::JIT::emit_op_tail_call_forward_arguments):
(JSC::JIT::compileSetupVarargsFrame):
(JSC::JIT::compileOpCall):

jit/JITOperations.cpp:
jit/JITOperations.h:
llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::varargsSetup):

llint/LLIntSlowPaths.h:
llint/LowLevelInterpreter.asm:
tests/stress/tailCallForwardArguments.js: Added.

(putFuncToPrivateName.createBuiltin):
(putFuncToPrivateName):
(createTailCallForwardingFuncWith):
(baz):
(baz2):
(baz3):
(let.bodyText):
(baz4):
(baz5):
(arrayEq):

1:06 PM Changeset in webkit [202002] by commit-queue@webkit.org

12 edits in trunk

Make HashMap and HashSet work with Refs
https://bugs.webkit.org/show_bug.cgi?id=158638

Patch by Sam Weinig <sam@webkit.org> on 2016-06-13
Reviewed by Darin Adler.

Source/WTF:

wtf/GetPtr.h:

Move HashTableDeletedValueType and HashTableEmptyValueType here, as they are now shared
by more than one smart pointer. This file should probably be renamed to something else
at some point to indicate that it contains helpers for pointer and ref related functionality.

wtf/HashFunctions.h:

Add a DefaultHash for Refs. Customize the PtrHash to indicate that it is not safe to compare
to empty or deleted Refs.

wtf/HashMap.h:

(WTF::HashMapTranslator::equal):
(WTF::HashMapTranslator::translate):
(WTF::HashMapEnsureTranslator::equal):
(WTF::HashMapEnsureTranslator::translate):

wtf/HashSet.h:

(WTF::IdentityExtractor::extract):
(WTF::HashSetTranslator::hash):
(WTF::HashSetTranslator::equal):
(WTF::HashSetTranslator::translate):

wtf/HashTable.h:

(WTF::IdentityHashTranslator::hash):
(WTF::IdentityHashTranslator::equal):
(WTF::IdentityHashTranslator::translate):
Use the new assignToEmpty trait function to allow uninitialized Ref's to be safely assigned to.

wtf/HashTraits.h:

(WTF::HashTraits<Ref>::emptyValue):
(WTF::HashTraits<Ref>::isEmptyValue):
(WTF::HashTraits<Ref>::assignToEmpty):
(WTF::HashTraits<Ref>::peek):
(WTF::HashTraits<Ref>::customDeleteBucket):
Add custom HashTraits for Ref. Also, introduce a new trait function, assignToEmpty, for use
in translation assignments. This is necessary since the default assignment operator for Ref
will not allow assignment to the empty Ref, which we need to do here.

wtf/Ref.h:

(WTF::Ref::operator=):
(WTF::Ref::Ref):
(WTF::Ref::isHashTableDeletedValue):
(WTF::Ref::hashTableDeletedValue):
(WTF::Ref::isHashTableEmptyValue):
(WTF::Ref::hashTableEmptyValue):
Add explicit constructors/predicates for making deleted/empty Refs.

(WTF::Ref::assignToHashTableEmptyValue):
Add a special function that allows assignment to an empty Ref, which the
assignment operator does not.

(WTF::IsSmartPtr):
Add an IsSmartPtr override to indicate that Ref is a smart pointer.

wtf/RefPtr.h:

Move HashTableDeletedValueType to GetPtr.h.

Tools:

TestWebKitAPI/Tests/WTF/HashMap.cpp:

(TestWebKitAPI::TEST):

TestWebKitAPI/Tests/WTF/HashSet.cpp:

(TestWebKitAPI::TEST):
Add tests for using Refs in HashMaps (both as key and value) and HashSets.

12:47 PM Changeset in webkit [202001] by rniwa@webkit.org

9 edits
3 adds in trunk/Websites/perf.webkit.org

Invalid token error when trying to create an A/B analysis for a range
https://bugs.webkit.org/show_bug.cgi?id=158679

Reviewed by Chris Dumez.

The problem in this particular case was due to another website overriding cookies for our subdomain.
Make PrivilegedAPI robust against its token becoming invalid in general to fix the bug since the cookie
is only available under /privileged-api/ and the v3 UI can't access it for security reasons.

This patch factors out PrivilegedAPI out of remote.js so that it can be tested separately in server tests
as well as unit tests even though RemoteAPI itself is implemented differently in each case.

init-database.sql: Added a forgotten default value "false" to run_marked_outlier.
public/v3/index.html:
public/v3/privileged-api.js: Added. Extracted out of public/v3/remote.js.

(PrivilegedAPI.sendRequest): Fixed the bug. When the initial request fails with "InvalidToken" error,
re-generate the token and re-issue the request.
(PrivilegedAPI.requestCSRFToken):

public/v3/remote.js:

(RemoteAPI.postJSON): Added to match tools/js/remote.js.
(RemoteAPI.postJSONWithStatus): Ditto.
(PrivilegedAPI): Moved to privileged-api.js.

server-tests/api-measurement-set-tests.js: Removed the unused require for crypto.
server-tests/privileged-api-upate-run-status.js: Added tests for /privileged-api/update-run-status.
server-tests/resources/test-server.js:

(TestServer.prototype.inject): Clear the cookies as well as tokens in PrivilegedAPI.

tools/js/remote.js:

(RemoteAPI): Added the support for PrivilegedAPI by making cookie set by the server persist.
(RemoteAPI.prototype.clearCookies): Added for tests.
(RemoteAPI.prototype.postJSON): Make sure sendHttpRequest always sends a valid JSON.
(RemoteAPI.prototype.postJSONWithStatus): Added since this API is used PrivilegedAPI.
(RemoteAPI.prototype.sendHttpRequest): Retain the cookie set by the server and send it back in each request.

tools/js/v3-models.js:
unit-tests/privileged-api-tests.js: Added unit tests for PrivilegedAPI.
unit-tests/resources/mock-remote-api.js:

(MockRemoteAPI.postJSON): Added for unit testing.
(MockRemoteAPI.postJSONWithStatus): Ditto.

12:40 PM Changeset in webkit [202000] by rniwa@webkit.org

3 edits in trunk/Websites/perf.webkit.org

/admin/tests is very slow
https://bugs.webkit.org/show_bug.cgi?id=158682

Reviewed by Chris Dumez.

The slowness came from TestNameResolver::construct, which was fetching the entire table of test_configurations,
which at this point contains more than 32,000 rows. Don't fetch the entire table in the constructor. Instead,
fetch a subset of rows as needed in configurations_for_metric_and_platform. Even though this results in many SQL
queries being issued, that's a lot more efficient in practice because we only fetch a few dozen rows in practice.

Also removed a whole bunch of features from /admin/tests to simplify the page. In particular, the ability to update
the list of triggerables has been removed now that sync-buildbot.js automatically updates that for us. This removed
the last use of test_exists_on_platform, which was also dependent on fetching test_configurations upfront.

public/admin/tests.php:
public/include/test-name-resolver.php:

(TestNameResolver::construct): Don't fetch the entire table of test_configurations.
(TestNameResolver::configurations_for_metric_and_platform): Just issue a SQL query for the specified platform and metric.
(TestNameResolver::test_exists_on_platform): Removed.

12:39 PM Changeset in webkit [201999] by adam.bergkvist@ericsson.com

2 edits
2 adds in trunk/LayoutTests

WebRTC: Add test that verifies that RTCPeerConnection.addTrack can reuse an existing RTCRtpSender
https://bugs.webkit.org/show_bug.cgi?id=158621

Reviewed by Eric Carlson.

Add test to verify that RTCPeerConnection.addTrack reuses an existing RTCRtpSender
under the right circumstances.

fast/mediastream/RTCPeerConnection-addTrack-reuse-sender-expected.txt: Added.
fast/mediastream/RTCPeerConnection-addTrack-reuse-sender.html: Added.
platform/mac/TestExpectations:

The mac port is not building with WEB_RTC yet.

12:38 PM Changeset in webkit [201998] by adam.bergkvist@ericsson.com

2 edits
2 adds in trunk/LayoutTests

WebRTC: Add media setup test with complete offer/answer dialog
https://bugs.webkit.org/show_bug.cgi?id=158620

Reviewed by Eric Carlson.

Test a complete SDP offer/answer dialog between two RTCPeerConnection instances in the same
page. Media is set up in both direction with a single dialog. Check the local- and
remoteDescription attributes and the RTCPeerConnection states.

fast/mediastream/RTCPeerConnection-media-setup-single-dialog-expected.txt: Added.
fast/mediastream/RTCPeerConnection-media-setup-single-dialog.html: Added.
platform/mac/TestExpectations:

The mac port is not building with WEB_RTC yet.

11:56 AM Changeset in webkit [201997] by beidson@apple.com

2 edits in trunk/Source/WebCore

Crashes in WebCore::IDBServer::UniqueIDBDatabase::executeNextDatabaseTask.
<rdar://problem/26768449> and https://bugs.webkit.org/show_bug.cgi?id=158696

Reviewed by David Kilzer.

No new tests (Covered by all existing tests in Gmalloc/ASAN configs).

Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::executeNextDatabaseTask):
(WebCore::IDBServer::UniqueIDBDatabase::executeNextDatabaseTaskReply):

11:08 AM Changeset in webkit [201996] by fpizlo@apple.com

2 edits in trunk/PerformanceTests

Fix round-down goof in Air.js's ShuffleCustom.forEachArg
https://bugs.webkit.org/show_bug.cgi?id=158674

Reviewed by Michael Saboff.

x / 3 * 3 is not how you round down to multiples of 3 in JavaScript. You need to do
Math.floor(x / 3) * 3 instead.

This is a benign change, because having extra arguments to a Shuffle is not something we
actually take advantage of yet. But I think it's best to match the original C++ code's
intent.

Air.js/custom.js:

(const.ShuffleCustom.forEachArg):

10:32 AM Changeset in webkit [201995] by beidson@apple.com

2 edits in trunk/Source/WebCore

Modern IDB: IDBOpenDBRequest objects leak.
https://bugs.webkit.org/show_bug.cgi?id=158694

Reviewed by Alex Christensen.

No new tests (Currently have no testing strategy for guaranteeing lifetime of WebCore DOM objects)

Modules/indexeddb/client/IDBConnectionProxy.cpp:

(WebCore::IDBClient::IDBConnectionProxy::completeOpenDBRequest): At this point we never need the

request again, so remove it from the map.

10:28 AM Changeset in webkit [201994] by Chris Dumez

3 edits in trunk/Source/WebCore

Make sure HTTPHeaderMap gets a move constructor / assignment operator
https://bugs.webkit.org/show_bug.cgi?id=158695
<rdar://problem/26729511>

Reviewed by Alex Christensen.

Make sure HTTPHeaderMap gets a move constructor / assignment operator.
It was not getting an implicit one because of its user-declared
destructor. This patch drops the user-declared destructor so that
HTTPHeaderMap now gets an implicit move constructor / assignment
operator.

Not having a move constructor / assignment operator is an issue because
we rely on HTTPHeaderMap::isolatedCopy() / WTFMove() since r201623 to
pass HTTPHeaderMap across thread.

platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::~HTTPHeaderMap): Deleted.

platform/network/HTTPHeaderMap.h:

9:52 AM Changeset in webkit [201993] by Yusuke Suzuki

2 edits in trunk/Source/JavaScriptCore

Unreviewed, follow up patch for r201964
https://bugs.webkit.org/show_bug.cgi?id=158619

Fix typo in the comment.

runtime/MathCommon.h:

(JSC::toInt32):

9:46 AM Changeset in webkit [201992] by nael.ouedraogo@crf.canon.fr

2 edits in trunk/Source/WebCore

Remove useless parameter from GenerateParametersCheck signature
https://bugs.webkit.org/show_bug.cgi?id=158692

Reviewed by Chris Dumez.

Remove one parameter which is passed to GenerateParametersCheck
but never used in the caller code.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
(GenerateParametersCheck):
(GenerateConstructorDefinition):

9:27 AM Changeset in webkit [201991] by commit-queue@webkit.org

2 edits in trunk/Source/WTF

Stack overflow at RefPtr::release on Windows port since r201782
https://bugs.webkit.org/show_bug.cgi?id=158687

Patch by Fujii Hironori <Fujii Hironori> on 2016-06-13
Reviewed by Chris Dumez.

RefPtr::release calls RefPtr::RefPtr, and RefPtr::RefPtr calls
RefPtr::release.

RefPtr::RefPtr does not need to call RefPtr::release.

wtf/RefPtr.h:

(WTF::RefPtr::RefPtr): Do not call RefPtr::release.

8:53 AM Changeset in webkit [201990] by mark.lam@apple.com

14 edits in trunk

Add a mechanism for collecting LLINT stats.
https://bugs.webkit.org/show_bug.cgi?id=158668

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

This patch will add a mechanism for collecting the stats on LLINT opcode
execution counts. The changes made to enable this are:

Refactored how Options availability work so that we can add a new category: Configurable (in addition to the pre-existing Normal and Restricted availability).

Normal options - always available.
Restricted options - only available on debug builds.
Configurable options - depends on #define flag options.

This change is necessary so that:

we won't have to rebuild the world when we want to enable that #define flag to make that Configurable option available.
when the #define flag is disabled, the option will be invisible to the user.

With this, we add our first configurable option, JSC_reportLLIntStats, which
is dependent on the ENABLE_LLINT_STATS flag. See next.

Added the ENABLE_LLINT_STATS flag in LLIntCommon.h. To enable LLINT stats collection, we'll need to set this flag to a non-zero value, and rebuilding the project. By design, this will only require a minimal set of files to be rebuilt.

ENABLE_LLINT_STATS is 0 (i.e. disabled) by default.

Added a slow path callback to the LLINT's traceExecution() macro, to call _llint_count_opcode(), which in turns counts the opcode. This callback will only be built into the LLINT if ENABLE_LLINT_STATS is non-zero.

Added s_opcodeStatsArray to LLInt::Data. This is where the stats are recorded and stored.

Added calls to LLInt::Data::dumpStats() in jsc.cpp and DumpRenderTree.mm to dump the LLINT stats if enabled. If enabled, the LLINT stats will be sorted and dumped (via dataLog) before the programs terminate.

interpreter/Interpreter.h:
jsc.cpp:

(main):

llint/LLIntCommon.h:
llint/LLIntData.cpp:

(JSC::LLInt::initialize):
(JSC::LLInt::Data::dumpStats):

llint/LLIntData.h:

(JSC::LLInt::Data::opcodeStats):

llint/LLIntOfflineAsmConfig.h:
llint/LLIntSlowPaths.cpp:

(JSC::LLInt::llint_crash):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

llint/LLIntSlowPaths.h:
llint/LowLevelInterpreter.asm:
runtime/Options.cpp:

(JSC::parse):
(JSC::Options::isAvailable):
(JSC::overrideOptionWithHeuristic):
(JSC::scaleJITPolicy):
(JSC::Options::initialize):
(JSC::Options::setOptionWithoutAlias):
(JSC::Options::dumpAllOptions):
(JSC::Options::dumpOption):

runtime/Options.h:

(JSC::Option::Option):
(JSC::Option::operator!=):
(JSC::Option::id):

Tools:

DumpRenderTree/mac/DumpRenderTree.mm:

(DumpRenderTreeMain):

7:10 AM Changeset in webkit [201989] by commit-queue@webkit.org

6 edits in trunk

[GTK] Enabling Shadow DOM by default
https://bugs.webkit.org/show_bug.cgi?id=158686

Patch by Romain Bellessort <romain.bellessort@crf.canon.fr> on 2016-06-13
Reviewed by Carlos Garcia Campos.

Added support for enabling Shadow DOM by default for GTK.

Source/cmake/OptionsGTK.cmake:

Tools:

Added support for enabling Shadow DOM by default for GTK.
Changed GTK test expectations for fast/shadow-dom tests (most tests
pass).

Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Changed GTK test expectations for fast/shadow-dom tests (most tests
pass).

platform/gtk/TestExpectations:

6:40 AM Changeset in webkit [201988] by nael.ouedraogo@crf.canon.fr

9 edits in trunk/Source/WebCore

Improve code generator for functions with variadic parameters
https://bugs.webkit.org/show_bug.cgi?id=158529

Reviewed by Darin Adler.

JS bindings code of functions with variadic parameters is improved.

Functions with variadic parameters are skipped for ObjC and GObject code generators.

bindings/scripts/CodeGeneratorGObject.pm:

(SkipFunction): Skip functions with variadic parameters.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):

bindings/scripts/CodeGeneratorObjC.pm:

(SkipFunction): Skip functions with variadic parameters.

bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_any): Deleted.
(webkit_dom_test_obj_attach_shadow_root): Deleted.
(webkit_dom_test_obj_get_read_only_long_attr): Deleted.
(webkit_dom_test_obj_get_read_only_string_attr): Deleted.

bindings/scripts/test/GObject/WebKitDOMTestObj.h:
bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionOverloadedMethod12):
(WebCore::jsTestObjPrototypeFunctionVariadicStringMethod):
(WebCore::jsTestObjPrototypeFunctionVariadicDoubleMethod):
(WebCore::jsTestObjPrototypeFunctionVariadicNodeMethod):

bindings/scripts/test/ObjC/DOMTestObj.h:
bindings/scripts/test/ObjC/DOMTestObj.mm:

2:06 AM Changeset in webkit [201987] by peavo@outlook.com

2 edits in trunk/LayoutTests

Unreviewed test gardening.

Unskip passing fast/workers tests.

platform/win/TestExpectations:

Jun 12, 2016:

8:57 PM Changeset in webkit [201986] by aakash_jain@apple.com

2 edits in trunk/Tools

run-safari/run-webkit-app fail to quit iOS simulator after Xcode installation
https://bugs.webkit.org/show_bug.cgi?id=158651
rdar://problem/26499824

Reviewed by Daniel Bates.

This change is to make our tools more robust. Sometimes run-safari/run-webkit-app fails
to start the tests as one of the first thing these scripts do is to relaunch iOS Simulators,
and in process call quitIOSSimulator. In case the Simulator is not registered in LaunchServices
for some reason, quitIOSSimulator fails and the script stops. This change will make the scripts
still continue when they fail to quit iOS Simuator, and modify the way Simulator is opened,
so that Simulator is implicitly registered with LaunchServices while opening it.

Scripts/webkitdirs.pm:

(relaunchIOSSimulator):
Launch iOS Simulator using complete path. Partially reverting http://trac.webkit.org/changeset/184202.
(quitIOSSimulator):
Do not die if quitting ios Simulator fails, so that relaunchIOSSimulator can still
attempt to launch the simulator.
(waitUntilIOSSimulatorDeviceIsInState):
Added a FIXME.

1:57 PM Changeset in webkit [201985] by Alan Bujtas

3 edits in trunk/Source/WebCore

Cleanup RenderBlock::removePositionedObjects
https://bugs.webkit.org/show_bug.cgi?id=158670

Reviewed by Simon Fraser.

No change in functionality.

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::insertPositionedObject):
(WebCore::RenderBlock::removePositionedObject):
(WebCore::RenderBlock::removePositionedObjects):

rendering/RenderBlock.h:

1:45 PM Changeset in webkit [201984] by Alan Bujtas

3 edits
2 adds in trunk

Remove positioned descendants when RenderBlock is no longer a containing block.
https://bugs.webkit.org/show_bug.cgi?id=158655
<rdar://problem/26510032>

Reviewed by Simon Fraser.

Normally the RenderView is the containing block for fixed positioned renderers.
However when a renderer acquires some transform related properties, it becomes the containing
block for all the fixed positioned renderers in its descendant tree.
When the last transform related property is removed, the renderer is no longer a containing block
and we need to remove all these positioned renderers from the descendant tracker map (gPositionedDescendantsMap).
They will be inserted back into the tracker map during the next layout (either under the RenderView or
under the next transformed renderer in the ancestor chain).

Source/WebCore:

Test: fast/block/fixed-position-reparent-when-transition-is-removed.html

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::removePositionedObjectsIfNeeded):

LayoutTests:

fast/block/fixed-position-reparent-when-transition-is-removed-expected.txt: Added.
fast/block/fixed-position-reparent-when-transition-is-removed.html: Added.

6:22 AM Changeset in webkit [201983] by ddkilzer@apple.com

3 edits in trunk/Source/bmalloc

Crash in com.apple.WebKit.WebContent at std::1::call_once_proxy<std::__1::tuple<CrashReporterSupportLibrary()::$_0&&> >
<https://webkit.org/b/158660>
<rdar://problem/25652686>

Reviewed by Darin Adler.

bmalloc/Logging.cpp: Switch to use

BSOFT_LINK_PRIVATE_FRAMEWORK() to link
CrashReporterSupport.framework.

bmalloc/darwin/BSoftLinking.h:

(BSOFT_LINK_PRIVATE_FRAMEWORK): Rename from BSOFT_LINK_FRAMEWORK.
Switch to use /System/Library/PrivateFrameworks/.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed