Timeline
Jun 15, 2016:
- 11:01 PM Changeset in webkit [202125] by
-
- 56 edits5 adds in trunk
Add support for Symbol.isConcatSpreadable (round 2)
https://bugs.webkit.org/show_bug.cgi?id=158769
Reviewed by Mark Lam.
Source/JavaScriptCore:
This patch adds support for Symbol.isConcatSpreadable. In order to
do so, it was necessary to move the Array.prototype.concat function
to JS. A number of different optimizations were needed to make
such the move to a builtin performant. First, this patch adds a
new Bytecode intrinsic, isJSArray, that checks if the value is a
JSArray object. Specifically, isJSArray checks that the array
object is a normal instance of JSArray and not a RuntimeArray or
Array.prototype. isJSArray can also be converted into a constant
by the DFG if we are able to prove that the incomming value is
already a JSArray.
In order to further improve the perfomance we also now cover more
indexing types in our fast path memcpy code. Before we would only
memcpy Arrays if they had the same indexing type and did not have
Array storage or were undecided. Now the memcpy code covers the
following additional three cases:
1) One array is undecided and the other does not have array storage
2) One array is Int32 and the other is contiguous (we map this
into a contiguous array).
3) The this value is an array and first argument is a non-array
that does not have Symbol.isConcatSpreadable set.
This patch also adds a new fast path for concat with more than one
array argument by using memcpy to append values onto the result
array. This works roughly the same as the two array fast path
using the same methodology to decide if we can memcpy the other
butterfly into the result butterfly.
- JavaScriptCore.xcodeproj/project.pbxproj:
- builtins/ArrayPrototype.js:
(concatSlowPath):
(concat):
- bytecode/BytecodeIntrinsicRegistry.cpp:
(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):
- bytecode/BytecodeIntrinsicRegistry.h:
- bytecode/BytecodeList.json:
- bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitIsJSArray):
- bytecompiler/NodesCodegen.cpp:
(JSC::BytecodeIntrinsicNode::emit_intrinsic_isJSArray):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNodeType.h:
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPredictionPropagationPhase.cpp:
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::compileIsJSArray):
(JSC::DFG::SpeculativeJIT::compileCallObjectConstructor):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileCallObjectConstructor):
(JSC::FTL::DFG::LowerDFGToB3::compileIsJSArray):
(JSC::FTL::DFG::LowerDFGToB3::isArray):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_is_jsarray):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_is_jsarray):
- jit/JITOperations.h:
- llint/LLIntData.cpp:
(JSC::LLInt::Data::performAssertions):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/ArrayConstructor.h:
(JSC::isArrayConstructor):
- runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::finishCreation):
(JSC::speciesWatchpointsValid):
(JSC::speciesConstructArray):
(JSC::moveElements):
(JSC::concatAppendOne):
(JSC::arrayProtoFuncConcat): Deleted.
- runtime/ArrayPrototype.h:
- runtime/CommonIdentifiers.h:
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/IndexingType.h:
(JSC::indexingTypeForValue):
- runtime/JSArray.cpp:
(JSC::JSArray::appendMemcpy):
(JSC::JSArray::fastConcatWith): Deleted.
- runtime/JSArray.h:
(JSC::JSArray::createStructure):
(JSC::isJSArray):
(JSC::JSArray::fastConcatType): Deleted.
- runtime/JSArrayInlines.h: Added.
(JSC::JSArray::mergeIndexingTypeForCopying):
(JSC::JSArray::canFastCopy):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- runtime/JSObject.cpp:
(JSC::JSObject::convertUndecidedForValue):
- runtime/JSType.h:
- runtime/ObjectConstructor.h:
(JSC::constructObject):
- tests/es6.yaml:
- tests/stress/array-concat-spread-object.js: Added.
(arrayEq):
- tests/stress/array-concat-spread-proxy-exception-check.js: Added.
(arrayEq):
- tests/stress/array-concat-spread-proxy.js: Added.
(arrayEq):
- tests/stress/array-concat-with-slow-indexingtypes.js: Added.
(arrayEq):
- tests/stress/array-species-config-array-constructor.js:
LayoutTests:
Fix tests for Symbol.isConcatSpreadable. Also, add new test that
the array species construction does not use the callees' global
object's Array[Symbol.species] when given an array from another
global object.
- js/Object-getOwnPropertyNames-expected.txt:
- js/array-species-different-globalobjects.html:
- js/dom/array-prototype-properties-expected.txt:
- js/script-tests/Object-getOwnPropertyNames.js:
- 9:41 PM Changeset in webkit [202124] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
Assertion failure when returning incomplete property descriptor from proxy trap.
https://bugs.webkit.org/show_bug.cgi?id=157078
Reviewed by Saam Barati.
If the proxy returns a descriptor that expects a value but does not specify one,
we should use undefined for the value.
- runtime/ProxyObject.cpp:
(JSC::ProxyObject::performInternalMethodGetOwnProperty):
- tests/stress/proxy-returning-incomplete-property-descriptor.js: Added.
(truthiness):
(compare):
(shouldBe):
(test):
(get test):
- 8:30 PM Changeset in webkit [202123] by
-
- 6 edits2 copies2 adds in trunk
Decouple the percent height and positioned descendants maps.
https://bugs.webkit.org/show_bug.cgi?id=158773
Reviewed by David Hyatt and Chris Dumez.
Source/WebCore:
We track renderers with percent height across multiple containers using
HashMap<const RenderBox*, std::unique_ptr<HashSet<const RenderBlock*>>>.
We also use the same data structure to track positioned descendants.
However a positioned renderer can have only one containing block so tracking it
with a 1:many type is defective.
It allows multiple inserts for positioned descendants, which could lead to
inconsistent layout state as the rendering logic expects these type of renderers
with only one containing block.
This patch decouples percent height and positioned tracking by introducing
the PositionedDescendantsMap class. This class is responsible for tracking
the positioned descendants inbetween layouts.
No change in functionality.
Tests: fast/block/positioning/change-containing-block-for-absolute-positioned.html
fast/block/positioning/change-containing-block-for-fixed-positioned.html
- rendering/RenderBlock.cpp:
(WebCore::insertIntoTrackedRendererMaps):
(WebCore::removeFromTrackedRendererMaps):
(WebCore::PositionedDescendantsMap::addDescendant): Add more defensive ASSERT_NOT_REACHED
to the double insert branch when webkit.org/b/158772 gets fixed.
(WebCore::PositionedDescendantsMap::removeDescendant):
(WebCore::PositionedDescendantsMap::removeContainingBlock):
(WebCore::PositionedDescendantsMap::positionedRenderers):
(WebCore::positionedDescendantsMap):
(WebCore::removeBlockFromPercentageDescendantAndContainerMaps):
(WebCore::RenderBlock::~RenderBlock):
(WebCore::RenderBlock::positionedObjects):
(WebCore::RenderBlock::insertPositionedObject):
(WebCore::RenderBlock::removePositionedObject):
(WebCore::RenderBlock::addPercentHeightDescendant):
(WebCore::RenderBlock::removePercentHeightDescendant):
(WebCore::RenderBlock::percentHeightDescendants):
(WebCore::RenderBlock::checkPositionedObjectsNeedLayout):
(WebCore::removeBlockFromDescendantAndContainerMaps): Deleted.
- rendering/RenderBlock.h:
LayoutTests:
Various dynamic containing block changing tests.
- fast/block/fixed-position-reparent-when-transition-is-removed.html:
- fast/block/positioning/change-containing-block-for-absolute-positioned-expected.txt: Added.
- fast/block/positioning/change-containing-block-for-absolute-positioned.html: Added.
- fast/block/positioning/change-containing-block-for-fixed-positioned-expected.txt: Added.
- fast/block/positioning/change-containing-block-for-fixed-positioned.html: Added.
- 8:22 PM Changeset in webkit [202122] by
-
- 3 edits1 move in trunk/Source/WebCore
Move SoftLinking.h to platform/cococa from platform/mac
<https://webkit.org/b/158825>
Reviewed by Andy Estes.
- PlatformMac.cmake: Update for new directory.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- platform/cocoa/SoftLinking.h: Renamed from Source/WebCore/platform/mac/SoftLinking.h.
- 7:59 PM Changeset in webkit [202121] by
-
- 6 edits in trunk/Source
[Cocoa] Clean up / optimize ResourceResponse::platformLazyInit(InitLevel)
https://bugs.webkit.org/show_bug.cgi?id=158809
Reviewed by Darin Adler.
Source/WebCore:
Clean up / optimize ResourceResponse::platformLazyInit(InitLevel).
- platform/network/HTTPParsers.cpp:
(WebCore::extractReasonPhraseFromHTTPStatusLine):
- platform/network/HTTPParsers.h:
Have extractReasonPhraseFromHTTPStatusLine() return an AtomicString as the
Reason is stored as an AtomicString on ResourceResponse. Have the
implementation use StringView::subString()::toAtomicString().
- platform/network/cocoa/ResourceResponseCocoa.mm:
(WebCore::stripLeadingAndTrailingDoubleQuote):
Move the stripLeadingAndTrailingDoubleQuote logic from platformLazyInit()
to its own function. Have it use StringView::subString()::toAtomicString()
to avoid unnecessarily atomizing the textEncodingName that has surrounding
double-quotes.
(WebCore::initializeHTTPHeaders):
Move HTTP headers initialization to its own function for clarity.
(WebCore::extractHTTPStatusText):
Move HTTP status Text extraction to its own function for clarity.
(WebCore::ResourceResponse::platformLazyInit):
- The function is streamlined a bit because most of the logic was moved into separate functions.
- Drop unnecessary (initLevel >= CommonFieldsOnly) check in the first if case and replace with an assertion. This function is always called with CommonFieldsOnly or above (AllFields).
- Drop unnecessary (m_initLevel < AllFields) check in the second if case as this is always true. If not, we would have returned early at the beginning of the function when checking m_initLevel >= initLevel.
- Use AutodrainedPool instead of NSAutoreleasePool for convenience and have only 1 pool instead of 2.
- Drop unnecessary copyNSURLResponseStatusLine() function and call directly CFHTTPMessageCopyResponseStatusLine() since we already have a CFHTTPMessageRef at the call site.
Source/WTF:
Add toAtomicString() method to StringView to avoid having to call toString()
and then atomizing the String at call sites.
- wtf/text/StringView.h:
(WTF::StringView::toAtomicString):
- 7:20 PM Changeset in webkit [202120] by
-
- 5 edits in trunk
Expose _shouldExpandContentToViewHeightForAutoLayout SPI on WKWebView
https://bugs.webkit.org/show_bug.cgi?id=158824
<rdar://problem/23713857>
Reviewed by Simon Fraser.
Test: TestWebKitAPI/WebKit2.AutoLayoutIntegration
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _shouldExpandContentToViewHeightForAutoLayout]):
(-[WKWebView _setShouldExpandContentToViewHeightForAutoLayout:]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
This property exists on WKView; expose it on WKWebView.
- TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
(-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
(-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
(-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:resettingWidth:]):
(TEST):
Add a test for _shouldExpandContentToViewHeightForAutoLayout.
- 6:28 PM Changeset in webkit [202119] by
-
- 3 edits in trunk/Source/WebKit2
Revert part of r196034
https://bugs.webkit.org/show_bug.cgi?id=158805
rdar://problem/26788138
Reviewed by Dan Bernstein.
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::~NetworkLoad):
If the WebResourceLoader was destroyed and received a canAuthenticateAgainstProtectionSpace
but did not send a continueCanAuthenticateAgainstProtectionSpace answer because there's no
core loader, then the NetworkLoad will be destroyed. When this happens, we still need to call
the callback for the challenge.
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::canAuthenticateAgainstProtectionSpace):
If there's no core loader, we can't send IPC.
- 6:22 PM Changeset in webkit [202118] by
-
- 2 edits in trunk/Source/WebKit/mac
+[WebHTMLRepresentation supportedMIMETypes] leaks
https://bugs.webkit.org/show_bug.cgi?id=158683
Reviewed by Darin Adler.
The problem occurred when chaining newArrayByConcatenatingArrays calls.
Also refactored the code to avoid returning NSMutableArrays disguised as NSArrays,
and removed unsafe_unretained modifiers that were added in http://trac.webkit.org/r149453
for no apparent reason.
- WebView/WebHTMLRepresentation.mm:
(newArrayWithStrings):
(+[WebHTMLRepresentation supportedMIMETypes]):
(+[WebHTMLRepresentation supportedMediaMIMETypes]):
(+[WebHTMLRepresentation supportedNonImageMIMETypes]):
(+[WebHTMLRepresentation supportedImageMIMETypes]):
(+[WebHTMLRepresentation unsupportedTextMIMETypes]):
(newArrayByConcatenatingArrays): Deleted.
- 6:14 PM Changeset in webkit [202117] by
-
- 7 edits2 adds in trunk
<attachment> elements jump around a lot around when subtitle text changes slightly
https://bugs.webkit.org/show_bug.cgi?id=158818
<rdar://problem/24450270>
Reviewed by Simon Fraser.
Test: fast/attachment/attachment-subtitle-resize.html
- rendering/RenderAttachment.cpp:
(WebCore::RenderAttachment::layout):
- rendering/RenderAttachment.h:
- rendering/RenderThemeMac.mm:
(WebCore::AttachmentLayout::AttachmentLayout):
(WebCore::RenderThemeMac::paintAttachment):
In order to avoid changes to the centered subtitle text causing the whole
attachment to bounce around a lot, make it so that attachment width can only
increase, never decrease, and round the subtitle's width up to the nearest
increment of 10px when determining its affect on the whole element's width.
Also, center the attachment in its element, instead of left-aligning it,
so that the extra width we may have is evenly distributed between the two sides.
- fast/attachment/attachment-subtitle-resize-expected.txt: Added.
- fast/attachment/attachment-subtitle-resize.html: Added.
- 4:44 PM Changeset in webkit [202116] by
-
- 10 edits2 adds in trunk
[iOS WK2] Make it possible to test the Next/Previous buttons in the keyboard accessory bar
https://bugs.webkit.org/show_bug.cgi?id=158714
Reviewed by Enrica Casucci.
Add UIScriptController.keyboardAccessoryBar{Next,Previous} and hook it up to the WKContentView
method that gets called from UIKit.
Add a test that exercises it.
Source/WebKit2:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView keyboardAssistantBarNext]):
(-[WKWebView keyboardAssistantBarPrevious]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
Tools:
- WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
- WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::keyboardAccessoryBarNext):
(WTR::UIScriptController::keyboardAccessoryBarPrevious):
- WebKitTestRunner/UIScriptContext/UIScriptController.h:
- WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::keyboardAccessoryBarNext):
(WTR::UIScriptController::keyboardAccessoryBarPrevious):
LayoutTests:
- TestExpectations:
- fast/forms/ios/accessory-bar-navigation-expected.txt: Added.
- fast/forms/ios/accessory-bar-navigation.html: Added.
- fast/forms/ios/resources/zooming-test-utils.js: Added.
(testZoomAfterTap):
(tableFromJSON):
- platform/ios-simulator-wk2/TestExpectations:
- 4:34 PM Changeset in webkit [202115] by
-
- 2 edits in trunk/LayoutTests
[mac] LayoutTest transforms/undecomposable.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=158816
Unflakify this test by putting the script in a place that
will execute it before the load event (by which time the animation
may have started).
- transforms/undecomposable.html:
- 4:07 PM Changeset in webkit [202114] by
-
- 2 edits11 adds in trunk/LayoutTests
[iOS WK2] Add tests for zooming to text fields on focus
https://bugs.webkit.org/show_bug.cgi?id=158786
Reviewed by Enrica Casucci.
Add tests that focus form controls, and test the resulting scroll position and zoom level.
- TestExpectations:
- fast/forms/ios/focus-input-via-button-expected.txt: Added.
- fast/forms/ios/focus-input-via-button-no-scaling-expected.txt: Added.
- fast/forms/ios/focus-input-via-button-no-scaling.html: Added.
- fast/forms/ios/focus-input-via-button.html: Added.
- fast/forms/ios/resources/zooming-test-utils.js: Added.
(testZoomAfterTap):
(tableFromJSON):
- fast/forms/ios/zoom-after-input-tap-expected.txt: Added.
- fast/forms/ios/zoom-after-input-tap-wide-input-expected.txt: Added.
- fast/forms/ios/zoom-after-input-tap-wide-input.html: Added.
- fast/forms/ios/zoom-after-input-tap.html: Added.
- platform/ios-simulator-wk2/TestExpectations:
- 3:37 PM Changeset in webkit [202113] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, fix typo in test and move tests to the correct files.
- tests/stress/multi-get-by-offset-proto-or-unset.js:
- tests/stress/multi-get-by-offset-proto-self-or-unset.js:
- 3:14 PM Changeset in webkit [202112] by
-
- 4 edits in trunk/Source
RTL <select> forms are misplaced
https://bugs.webkit.org/show_bug.cgi?id=158810
<rdar://problem/24847541>
Reviewed by Eric Carlson.
AppKit made a change in Sierra that causes popup menus
to snap to a different point when the system language is RTL.
We need to be more explicit about what directionality
we want, and override the location of the popup based
on the text direction.
I also made a small tweak to the fudge offsets we use
in order to make button text and menu text to be
more consistent.
Unfortunately since this is just about the location
of the popup menu, it's unable to be tested in our
current infrastructure.
Source/WebKit/mac:
- WebCoreSupport/PopupMenuMac.mm:
(PopupMenuMac::show):
Source/WebKit2:
- UIProcess/mac/WebPopupMenuProxyMac.mm:
(WebKit::WebPopupMenuProxyMac::showPopupMenu):
- 3:07 PM Changeset in webkit [202111] by
-
- 8 edits in trunk
Improve HashMap and HashSet support for Ref
https://bugs.webkit.org/show_bug.cgi?id=158789
Patch by Sam Weinig <sam@webkit.org> on 2016-06-15
Reviewed by Chris Dumez.
Source/WTF:
Tests: Add more cases to WTF_HashMap.Ref_Key, WTF_HashMap.Ref_Value and WTF_HashSet.Ref
- wtf/HashMap.h:
- wtf/HashSet.h:
Add a MappedTakeType typedef and rework the take functions to use it and HashTraits::take(...).
- wtf/HashTraits.h:
(WTF::GenericHashTraits::assignToEmpty):
Move to GenericHashTraits rather than GenericHashTraitsBase, since it is not different
between integral and non-integral HashTraits.
(WTF::GenericHashTraits::take):
Add a trait function for take that defaults as a forward. This allows us to override take
just like we do with get/peek.
(WTF::HashTraits<Ref<P>>::emptyValue):
Remove unnecessary explicit construction.
(WTF::HashTraits<Ref<P>>::peek):
Fix assertion that could happen if you did a HashMap.get() on an empty Ref value.
(WTF::HashTraits<Ref<P>>::take):
Make the TakeType of a Ref<P> be Optional<Ref<P>>, to avoid having empty
Refs returned from HashMap and HashSet. Implement an explicit take() function to
construct one.
(WTF::HashTraits<Ref<P>>::customDeleteBucket): Deleted.
Remove unnecessary customDeleteBucket implementation. Ref does not assign nullptr to
it's m_ptr in destruction, so there is no dead store to avoid here.
- wtf/Ref.h:
(WTF::Ref::ptrAllowingHashTableEmptyValue):
Add HashTrait helper to allow getting the value of m_ptr even when it is null. This
allows us to avoid a branch in HashTraits<Ref<P>>::peek().
Tools:
- TestWebKitAPI/Tests/WTF/HashMap.cpp:
- TestWebKitAPI/Tests/WTF/HashSet.cpp:
Add more cases to WTF_HashMap.Ref_Key, WTF_HashMap.Ref_Value and WTF_HashSet.Ref
- 2:56 PM Changeset in webkit [202110] by
-
- 2 edits in trunk/Source/WebCore
Reset bindings test results after r202105
Unreviewed test gardening.
- bindings/scripts/test/JS/JSTestObj.cpp:
- 2:27 PM Changeset in webkit [202109] by
-
- 2 edits in trunk/Source/WebCore
WebRTC: (Refactor) Align the structure of RTCPeerConnection.idl with the header file
https://bugs.webkit.org/show_bug.cgi?id=158779
Reviewed by Eric Carlson.
Restructure RTCPeerConnection.idl to make it easer to read and extend in the future.
No change in behavior.
- Modules/mediastream/RTCPeerConnection.idl:
- 2:27 PM Changeset in webkit [202108] by
-
- 2 edits2 adds in trunk/LayoutTests
WebRTC: Add media setup test using the legacy callback APIs
https://bugs.webkit.org/show_bug.cgi?id=158736
Reviewed by Eric Carlson.
Add a test that sets up media using the legacy callback-based createOffer/Answer() and
setLocal/RemoteDescription() methods [1].
[1] https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html#legacy-interface-extensions
- fast/mediastream/RTCPeerConnection-media-setup-callbacks-single-dialog-expected.txt: Added.
- fast/mediastream/RTCPeerConnection-media-setup-callbacks-single-dialog.html: Added.
- platform/mac/TestExpectations:
The mac port is not building with WEB_RTC yet.
- 2:25 PM Changeset in webkit [202107] by
-
- 2 edits in trunk/Tools
Too much log data generated during layout-tests on iOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=158751
Reviewed by Alexey Proskuryakov.
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.developer_dir): memoized the property so that it is not called
repeatedly.
- 2:15 PM Changeset in webkit [202106] by
-
- 2 edits in trunk/Source/WebInspectorUI
Uncaught Exception: TypeError: undefined is not an object (evaluating 'imageElement.classList')
https://bugs.webkit.org/show_bug.cgi?id=158808
<rdar://problem/26821034>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-15
Reviewed by Brian Burg.
- UserInterface/Views/HeapAllocationsTimelineOverviewGraph.js:
(WebInspector.HeapAllocationsTimelineOverviewGraph.prototype._updateSnapshotMarkers):
If the record is out of the layout bounds of the overview graph, the overview graph
may not have created an image element yet, so bail. Later, when the image element
is created, it would get the appropriate style if the record is selected.
- 1:59 PM Changeset in webkit [202105] by
-
- 99 edits in trunk/Source
Drop some unnecessary header includes
https://bugs.webkit.org/show_bug.cgi?id=158788
Reviewed by Alexey Proskuryakov.
Drop some unnecessary header includes in headers to speed up build time.
Source/WebCore:
- Modules/encryptedmedia/MediaKeySession.cpp:
- Modules/gamepad/GamepadManager.cpp:
- Modules/indexeddb/IDBDatabase.cpp:
- Modules/indexeddb/IDBOpenDBRequest.cpp:
- Modules/indexeddb/IDBRequest.cpp:
- Modules/indexeddb/IDBTransaction.cpp:
- Modules/mediasource/MediaSource.cpp:
- Modules/mediasource/SourceBuffer.cpp:
- Modules/mediasource/SourceBufferList.cpp:
- Modules/mediastream/MediaStream.cpp:
- Modules/mediastream/MediaStreamTrack.cpp:
- Modules/speech/SpeechSynthesis.cpp:
- Modules/webaudio/AudioScheduledSourceNode.cpp:
- Modules/webaudio/ScriptProcessorNode.cpp:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
- dom/CharacterData.cpp:
- dom/ContainerNode.cpp:
- dom/DOMNamedFlowCollection.cpp:
- dom/DeviceMotionController.cpp:
- dom/DeviceOrientationController.cpp:
- dom/Document.cpp:
- dom/Document.h:
- dom/DocumentEventQueue.cpp:
- dom/DocumentOrderedMap.h:
- dom/Element.cpp:
- dom/Event.cpp:
- dom/EventDispatcher.cpp:
- dom/EventTarget.cpp:
- dom/EventTarget.h:
- dom/KeyboardEvent.cpp:
- dom/MessageEvent.cpp:
- dom/MessagePort.cpp:
- dom/ScriptElement.cpp:
- dom/ScriptExecutionContext.cpp:
- dom/ScriptExecutionContext.h:
- dom/SecurityContext.h:
- dom/SimulatedClick.cpp:
- dom/TextEvent.cpp:
- dom/WebKitNamedFlow.cpp:
- editing/FrameSelection.cpp:
- fileapi/FileReader.cpp:
- html/HTMLLinkElement.cpp:
- html/HTMLPlugInImageElement.cpp:
- html/HTMLStyleElement.cpp:
- html/HTMLSummaryElement.cpp:
- html/HTMLTrackElement.cpp:
- html/HTMLVideoElement.cpp:
- html/InputType.cpp:
- html/MediaController.cpp:
- html/TextFieldInputType.cpp:
- html/canvas/WebGLRenderingContextBase.cpp:
- html/parser/HTMLScriptRunner.cpp:
- html/shadow/MediaControlElementTypes.cpp:
- html/shadow/MediaControls.cpp:
- html/shadow/MediaControlsApple.cpp:
- html/shadow/SliderThumbElement.cpp:
- html/shadow/mac/ImageControlsButtonElementMac.cpp:
- inspector/InspectorIndexedDBAgent.cpp:
- loader/DocumentLoader.cpp:
- loader/ImageLoader.cpp:
- loader/PolicyChecker.cpp:
- mathml/MathMLSelectElement.cpp:
- page/DOMWindow.h:
- page/EventSource.cpp:
- page/FrameView.cpp:
- page/Performance.cpp:
- page/csp/ContentSecurityPolicy.cpp:
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
- platform/network/HTTPHeaderMap.h:
- platform/network/ResourceHandle.cpp:
- rendering/RenderEmbeddedObject.cpp:
- rendering/RenderSnapshottedPlugIn.cpp:
- svg/SVGSVGElement.cpp:
- svg/SVGUseElement.cpp:
- svg/animation/SVGSMILElement.cpp:
- workers/WorkerGlobalScope.h:
- xml/XMLHttpRequest.cpp:
- xml/XMLHttpRequestProgressEventThrottle.cpp:
- xml/XMLHttpRequestUpload.cpp:
Source/WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.mm:
Source/WebKit/win:
- Plugins/PluginView.cpp:
Source/WebKit2:
- WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm:
- WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:
- WebProcess/Plugins/PDF/PDFPluginPasswordField.mm:
- WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
- WebProcess/Plugins/PluginView.cpp:
- WebProcess/WebPage/WebPage.cpp:
- 1:52 PM Changeset in webkit [202104] by
-
- 7 edits in trunk
GoogleMaps transit schedule explorer comes up blank initially
https://bugs.webkit.org/show_bug.cgi?id=158803
rdar://problem/25818080
Source/WebCore:
Reviewed by Andreas Kling.
In case we had something like
.foo bar { ... }
and later a new stylesheet was added dynamically that contained
.foo baz { ... }
we would fail to add the new rules to the descendant invalidation rule sets for ".foo". This could
cause some style invalidations to be missed.
- css/DocumentRuleSets.cpp:
(WebCore::DocumentRuleSets::collectFeatures):
Reset the ancestorClassRules and ancestorAttributeRulesForHTML rule set caches when new style sheets
are added (==collectFeatures is called).
LayoutTests:
Reviewed by Andreas Kling
Expand the tests to cover this case.
- fast/css/style-invalidation-attribute-change-descendants-expected.txt:
- fast/css/style-invalidation-attribute-change-descendants.html:
- fast/css/style-invalidation-class-change-descendants-expected.txt:
- fast/css/style-invalidation-class-change-descendants.html:
- 1:48 PM Changeset in webkit [202103] by
-
- 3 edits2 adds in trunk
[css-sizing] Item borders are missing with 'min-width:-webkit-fill-available' and zero available width
https://bugs.webkit.org/show_bug.cgi?id=158258
Source/WebCore:
Reviewed by Darin Adler.
The "fill-available" size is defined as the containing block's size less
the box's border and padding size. However, when used for min-width we
should ensure we don't get negative values as result of logical width
computation.
http://www.w3.org/TR/css-sizing-3/#fill-available-sizing
This patch ensure fill-available value computed value will be always
greater than box's boder and padding width.
Test: fast/css-intrinsic-dimensions/fill-available-with-zero-width.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeIntrinsicLogicalWidthUsing):
LayoutTests:
Tests to verify that fill-available size works as expected when contaner's width is zero.
Reviewed by Darin Adler.
- fast/css-intrinsic-dimensions/fill-available-with-zero-width-expected.html: Added.
- fast/css-intrinsic-dimensions/fill-available-with-zero-width.html: Added.
- 12:41 PM Changeset in webkit [202102] by
-
- 3 edits2 adds in trunk
Fix 2d canvas transform after r192900
https://bugs.webkit.org/show_bug.cgi?id=158725
Source/WebCore:
rdar://problem/26774230
Patch by Alex Christensen <achristensen@webkit.org> on 2016-06-15
Reviewed by Dean Jackson.
Test: fast/canvas/canvas-transform-inverse.html
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::transform):
r192900 was intended to have no change in behavior, but I made a typo.
We need to apply the inverse of the original transform to the path to be correct.
This affects transforms applied to the canvas during the creation of a path.
LayoutTests:
Patch by Alex Christensen <achristensen@webkit.org> on 2016-06-15
Reviewed by Dean Jackson.
- fast/canvas/canvas-transform-inverse-expected.html: Added.
- fast/canvas/canvas-transform-inverse.html: Added.
- 12:40 PM Changeset in webkit [202101] by
-
- 3 edits3 adds in trunk/Source/JavaScriptCore
DFGByteCodeParser should be able to infer the value of unset properties in MultiGetByOffset
https://bugs.webkit.org/show_bug.cgi?id=158802
Reviewed by Filip Pizlo.
This patch adds support for unset properties in MultiGetByOffset. Since MultiGetByOffset
already supports constant values this patch just adds a constant case where the fetched
value is undefined. Fortunately (or unfortunately) we don't support object allocation
sinking for constant cases of MultiGetByOffset, which means we don't need to adjust any
in that phase.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::planLoad):
(JSC::DFG::ByteCodeParser::handleGetById):
- dfg/DFGMultiGetByOffsetData.h:
- tests/stress/multi-get-by-offset-proto-or-unset.js: Added.
(foo):
- tests/stress/multi-get-by-offset-proto-self-or-unset.js: Added.
(foo):
- tests/stress/multi-get-by-offset-self-or-unset.js: Added.
(foo):
- 12:32 PM Changeset in webkit [202100] by
-
- 8 edits4 adds in trunk
[iOS] Make HTMLMediaElement.muted mutable
https://bugs.webkit.org/show_bug.cgi?id=158787
<rdar://problem/24452567>
Reviewed by Dean Jackson.
Source/WebCore:
Tests: media/audio-playback-restriction-removed-muted.html
media/audio-playback-restriction-removed-track-enabled.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::audioTrackEnabledChanged): Remove most behavior restrictions if
the track state was changed as a result of a user gesture.
(WebCore::HTMLMediaElement::setMuted): Ditto.
(WebCore::HTMLMediaElement::removeBehaviorsRestrictionsAfterFirstUserGesture): Add mask
parameter so caller can choose which restrictions are removed.
- html/HTMLMediaElement.h:
- html/MediaElementSession.cpp:
(WebCore::restrictionName): Drive-by fix: remove duplicate label.
- html/MediaElementSession.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Set muted on AVPlayer if setMuted
was called before the player was created.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVolume): Drive-by fix: return early if there
is no AVPlayer, not if we won't have metadata yet.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setMuted): New.
LayoutTests:
- media/audio-playback-restriction-removed-muted-expected.txt: Added.
- media/audio-playback-restriction-removed-muted.html: Added.
- media/audio-playback-restriction-removed-track-enabled-expected.txt: Added.
- media/audio-playback-restriction-removed-track-enabled.html: Added.
- 12:30 PM Changeset in webkit [202099] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed GCC build fix after r202098.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::thresholdForJIT):
- 12:20 PM Changeset in webkit [202098] by
-
- 6 edits in trunk/Source/JavaScriptCore
compilation policy should adapt to past behavior
https://bugs.webkit.org/show_bug.cgi?id=158759
Reviewed by Saam Barati.
This looks like a ~9% speedup on JSBench.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::~CodeBlock): Record when a CodeBlock dies without ever
making it to DFG.
(JSC::CodeBlock::thresholdForJIT): CodeBlocks that make it to DFG should
compile sooner; CodeBlocks that don't should compile later. The goal is
to use past behavior, in addition to execution counts, to determine
whether compilation is profitable.
(JSC::CodeBlock::jitAfterWarmUp):
(JSC::CodeBlock::jitSoon): Apply the thresholdForJIT rule.
- bytecode/CodeBlock.h: Moved some code into the .cpp file so I could
change stuff without recompiling.
(JSC::CodeBlock::jitAfterWarmUp): Deleted.
(JSC::CodeBlock::jitSoon): Deleted.
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::didOptimize):
(JSC::UnlinkedCodeBlock::setDidOptimize): Added a piece of data to track
whether we made it to DFG.
- jit/JITOperations.cpp: Record when we make it to DFG.
- 12:17 PM Changeset in webkit [202097] by
-
- 2 edits in trunk/LayoutTests
fast/events/ios tests are marked as flakey, but really just fail in OpenSource and WK1
https://bugs.webkit.org/show_bug.cgi?id=158804
Test gardening.
fast/events/ios is skipped globally. Ideally it would be re-enabled in /ios-simulator-wk2/TestExpectations, but relies on unreleased
software, so leave disabled for now.
- platform/ios-simulator/TestExpectations:
- 12:04 PM Changeset in webkit [202096] by
-
- 4 edits in trunk/Source
Source/JavaScriptCore:
Only Mac port needs ObjC API for JSC.
https://bugs.webkit.org/show_bug.cgi?id=158780
Reviewed by Philippe Normand.
- API/JSBase.h: Removed !defined(BUILDING_GTK)
Source/WTF:
Only Mac port needs ObjC API for JSC
https://bugs.webkit.org/show_bug.cgi?id=158780
Reviewed by Philippe Normand.
- wtf/FeatureDefines.h:
- 11:40 AM WebKit2 edited by
- (diff)
- 10:08 AM Changeset in webkit [202095] by
-
- 3 edits in trunk/Tools
[Win][CMake] Changes in WebKit options are not reflected in incremental builds.
https://bugs.webkit.org/show_bug.cgi?id=158727
Reviewed by Alex Christensen.
Delete CMake cache file if WebKit options have been modified.
- Scripts/build-webkit:
- Scripts/webkitdirs.pm:
(shouldRemoveCMakeCache):
- 9:45 AM Changeset in webkit [202094] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, follow up patch for r202092
https://bugs.webkit.org/show_bug.cgi?id=158661
During checking Windows port on EWS, accidentally introduce the regression.
- wtf/Platform.h:
- 9:39 AM Changeset in webkit [202093] by
-
- 6 edits1 add in trunk/Source/JavaScriptCore
DFGByteCodeParser should be able to infer a property is unset from the Baseline inline cache.
https://bugs.webkit.org/show_bug.cgi?id=158774
Reviewed by Filip Pizlo.
This patch allows the DFGByteCodeParser to speculatively convert a property access into a
constant if that access was always a miss in the Baseline inline cache. This patch does
not add support for MultiGetByOffset and unset properties. That functionality will come
a future patch.
- bytecode/ComplexGetStatus.cpp:
(JSC::ComplexGetStatus::computeFor):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeForStubInfoWithoutExitSiteFeedback):
- bytecode/GetByIdVariant.h:
(JSC::GetByIdVariant::isPropertyUnset):
- bytecode/PutByIdVariant.h:
(JSC::PutByIdVariant::isPropertyUnset):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::load):
(JSC::DFG::ByteCodeParser::handleGetById):
- tests/stress/undefined-access-then-self-change.js: Added.
(foo):
- 9:30 AM Changeset in webkit [202092] by
-
- 6 edits in trunk/Source
[JSC] Move calling convention flags to WTF
https://bugs.webkit.org/show_bug.cgi?id=158661
Reviewed by Keith Miller.
Source/JavaScriptCore:
Due to some calling convention flags and JIT_OPERATION flags, MathCommon.h includes MacroAssemblerCodeRef and JITOperations.h.
But MacroAssembler and JIT part should not be necessary for the MathCommon component.
As with other calling convention flags like JSC_HOST_CALL, these flags should be in WTF.
- assembler/MacroAssemblerCodeRef.h:
- jit/JITOperations.h:
Add wtf/Platform.h inclusion driven by the Windows port build failure.
- runtime/MathCommon.h:
Source/WTF:
- wtf/Platform.h:
- 8:22 AM Changeset in webkit [202091] by
-
- 69 edits in trunk
Enabling Shadow DOM for all platforms
https://bugs.webkit.org/show_bug.cgi?id=158738
Patch by Romain Bellessort <romain.bellessort@crf.canon.fr> on 2016-06-15
Reviewed by Ryosuke Niwa.
.:
Removed Shadow DOM from options (enabled by default)
- Source/cmake/OptionsEfl.cmake:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/OptionsWin.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmake/tools/vsprops/FeatureDefines.props:
- Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
Source/JavaScriptCore:
Removed Shadow DOM from options (enabled by default)
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
No new tests (no new behavior to be tested).
Removed Shadow DOM from options (enabled by default)
(comprises removal of corresponding preprocessor directives)
- Configurations/FeatureDefines.xcconfig:
- DerivedSources.make:
- bindings/generic/RuntimeEnabledFeatures.h:
- bindings/js/JSDocumentFragmentCustom.cpp:
- bindings/js/JSNodeCustom.cpp:
- css/CSSGrammar.y.in:
- css/CSSParser.cpp:
- css/CSSParserValues.cpp:
- css/CSSParserValues.h:
- css/CSSSelector.cpp:
- css/CSSSelector.h:
- css/ElementRuleCollector.cpp:
- css/ElementRuleCollector.h:
- css/RuleSet.cpp:
- css/RuleSet.h:
- css/SelectorChecker.cpp:
- css/SelectorChecker.h:
- css/SelectorPseudoClassAndCompatibilityElementMap.in:
- css/StyleResolver.cpp:
- cssjit/SelectorCompiler.cpp:
- dom/ComposedTreeAncestorIterator.h:
- dom/ComposedTreeIterator.cpp:
- dom/ComposedTreeIterator.h:
- dom/ContainerNode.cpp:
- dom/Document.cpp:
- dom/Document.h:
- dom/Element.cpp:
- dom/Element.h:
- dom/Element.idl:
- dom/Event.idl:
- dom/EventPath.cpp:
- dom/Node.cpp:
- dom/Node.h:
- dom/NonDocumentTypeChildNode.idl:
- dom/ShadowRoot.cpp:
- dom/ShadowRoot.h:
- dom/ShadowRoot.idl:
- dom/SlotAssignment.cpp:
- dom/SlotAssignment.h:
- html/HTMLSlotElement.cpp:
- html/HTMLSlotElement.h:
- html/HTMLSlotElement.idl:
- html/HTMLTagNames.in:
- page/FocusController.cpp:
- style/StyleSharingResolver.cpp:
- style/StyleTreeResolver.cpp:
Source/WebKit/mac:
Removed Shadow DOM from options (enabled by default)
- Configurations/FeatureDefines.xcconfig:
- WebView/WebPreferences.mm:
- WebView/WebView.mm:
Source/WebKit/win:
Removed Shadow DOM from options (enabled by default)
(comprises removal of corresponding preprocessor directives)
- WebView.cpp:
Source/WebKit2:
Removed Shadow DOM from options (enabled by default)
(comprises removal of corresponding preprocessor directives)
- Configurations/FeatureDefines.xcconfig:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
- WebProcess/WebPage/WebPage.cpp:
Tools:
Removed Shadow DOM from options (enabled by default)
- Scripts/webkitperl/FeatureList.pm:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
- 8:13 AM Changeset in webkit [202090] by
-
- 4 edits in trunk/Source/WebCore
[Cocoa] Add two notify listeners for poking the garbage collector.
<https://webkit.org/b/158783>
Reviewed by Antti Koivisto.
Add two new notify listeners:
- com.apple.WebKit.fullGC
Trigger a full garbage collection in the main WebCore VM immediately.
- com.apple.WebKit.deleteAllCode
Throw away all of JSC's linked and unlinked code, and do a full GC.
These will make it easier to diagnose memory growth issues by having a lever that
eliminates many of the large object graphs without going after behavior-changing things
like the memory cache.
- platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::platformInitialize):
- platform/MemoryPressureHandler.h:
- platform/cocoa/MemoryPressureHandlerCocoa.mm:
(WebCore::MemoryPressureHandler::platformInitialize):
- 7:12 AM Changeset in webkit [202089] by
-
- 18 edits in trunk
Vary:Cookie validation doesn't work in private browsing
https://bugs.webkit.org/show_bug.cgi?id=158616
Source/WebCore:
<rdar://problem/26755067>
Reviewed by Andreas Kling.
There wasn't a way to get cookie based on SessionID from WebCore.
- platform/CookiesStrategy.h:
Add a cookie retrival function that takes SessionID instead of NetworkStorageSession.
- platform/network/CacheValidation.cpp:
(WebCore::headerValueForVary):
Use it.
(WebCore::verifyVaryingRequestHeaders):
Source/WebKit/mac:
<rdar://problem/26755067>
Reviewed by Andreas Kling.
- WebCoreSupport/WebFrameNetworkingContext.h:
(WebFrameNetworkingContext::create):
- WebCoreSupport/WebFrameNetworkingContext.mm:
(privateSession):
(WebFrameNetworkingContext::ensurePrivateBrowsingSession):
Expose the private browsing session.
(WebFrameNetworkingContext::destroyPrivateBrowsingSession):
- WebCoreSupport/WebPlatformStrategies.h:
- WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::cookieRequestHeaderFieldValue):
Implement SessionID version of the function.
(WebPlatformStrategies::getRawCookies):
Source/WebKit2:
<rdar://problem/26755067>
Reviewed by Andreas Kling.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue):
Implement SessionID version of the function.
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
LayoutTests:
Reviewed by Darin Adler.
- http/tests/cache/disk-cache/disk-cache-vary-cookie-expected.txt:
- http/tests/cache/disk-cache/disk-cache-vary-cookie.html:
Exapand the existing test to cover memory cache and private browsing.
- 2:55 AM Changeset in webkit [202088] by
-
- 4 edits in trunk
[Win] The test accessibility/selected-text-range-aria-elements.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=158732
Reviewed by Brent Fulgham.
Source/WebCore:
Implement support for getting selected text range.
- accessibility/win/AccessibilityObjectWrapperWin.cpp:
(WebCore::AccessibilityObjectWrapper::accessibilityAttributeValue):
Tools:
Implement selectedTextRange() method.
- DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::selectedTextRange):
- 2:36 AM Changeset in webkit [202087] by
-
- 2 edits in trunk/Tools
[Win] MiniBrowser is not DPI aware.
https://bugs.webkit.org/show_bug.cgi?id=158733
Reviewed by Brent Fulgham.
Call Win32 api function to let Windows know that we will scale the contents ourselves.
- MiniBrowser/win/WinMain.cpp:
(wWinMain):
- 2:26 AM Changeset in webkit [202086] by
-
- 2 edits in trunk/Tools
Unreviewed: add new email address to contributors.json.
- Scripts/webkitpy/common/config/contributors.json:
Jun 14, 2016:
- 11:36 PM Changeset in webkit [202085] by
-
- 2 edits in trunk/Source/WebCore
Addressing post-review comments after r201971
https://bugs.webkit.org/show_bug.cgi?id=158450
Unreviewed.
- css/CSSFontFaceSet.cpp:
(WebCore::CSSFontFaceSet::add):
(WebCore::CSSFontFaceSet::remove):
- 10:04 PM Changeset in webkit [202084] by
-
- 2 edits in trunk/Tools
JSBench should use geometric mean
https://bugs.webkit.org/show_bug.cgi?id=158775
Reviewed by Mark Lam.
For some reason JSBench was using algebraic mean. Since each test
is pretty substantially different it should use geometric mean
instead.
- Scripts/run-jsc-benchmarks:
- 9:44 PM Changeset in webkit [202083] by
-
- 6 edits2 adds in trunk
Honor bidi unicode codepoints
https://bugs.webkit.org/show_bug.cgi?id=149170
<rdar://problem/26527378>
Reviewed by Simon Fraser.
Source/WebCore:
BidiResolver doesn't have any concept of isolate Unicode code points, so produces
unexpected output when they are present. Fix by considering such code points as
whitespace in the bidi algorithm. This is a stop-gap measure until we can support
the codepoints fully in our Bidi algorithm.
Test: fast/text/isolate-ignore.html
- platform/graphics/Font.cpp:
(WebCore::createAndFillGlyphPage):
- platform/text/BidiResolver.h:
(WebCore::Subclass>::createBidiRunsForLine):
Source/WTF:
- wtf/unicode/CharacterNames.h:
LayoutTests:
- fast/text/isolate-ignore-expected.html: Added.
- fast/text/isolate-ignore.html: Added.
- 7:52 PM Changeset in webkit [202082] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Rename DataGrid.showColumn to setColumnVisible
https://bugs.webkit.org/show_bug.cgi?id=158764
<rdar://problem/26801448>
Reviewed by Joseph Pecoraro.
- UserInterface/Views/DataGrid.js:
(WebInspector.DataGrid):
Drive-by update to initialize "this._columnChooserEnabled".
(WebInspector.DataGrid.prototype.set identifier):
(WebInspector.DataGrid.prototype.insertColumn):
(WebInspector.DataGrid.prototype._collapseColumnGroupWithCell):
Use new method name.
(WebInspector.DataGrid.prototype._contextMenuInHeader):
Drive-by style update.
- 7:52 PM Changeset in webkit [202081] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Storage tab should allow hiding columns in the cookies grid
https://bugs.webkit.org/show_bug.cgi?id=158767
<rdar://problem/26803568>
Reviewed by Joseph Pecoraro.
- UserInterface/Views/CookieStorageContentView.js:
(WebInspector.CookieStorageContentView.prototype._rebuildTable):
Enable column chooser, exclude Name and Value columns.
- 7:18 PM Changeset in webkit [202080] by
-
- 3 edits in trunk/Source/WebKit2
Avoid constructing a AuthenticationChallenge unnecessarily in the NetworkLoad constructor
https://bugs.webkit.org/show_bug.cgi?id=158746
Reviewed by Darin Adler.
Avoid constructing a AuthenticationChallenge unnecessarily in the
NetworkLoad constructor by using WTF::Optional<> for this data
member.
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::continueCanAuthenticateAgainstProtectionSpace):
- NetworkProcess/NetworkLoad.h:
- 7:07 PM Changeset in webkit [202079] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Play glyph is pixelated when the page zoom is large
https://bugs.webkit.org/show_bug.cgi?id=158770
<rdar://problem/26092124>
Patch by Antoine Quint <Antoine Quint> on 2016-06-14
Reviewed by Dean Jackson.
Use the same technique that we use to scale the video controls by using a combination
of CSS "zoom" and "transform" properties to have the video play glyph scaled at its
native size regardless of page zoom.
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.set pageScaleFactor):
- 6:45 PM Changeset in webkit [202078] by
-
- 2 edits in trunk/Tools
Debug crash logs are not fully symbolicated on Yosemite
https://bugs.webkit.org/show_bug.cgi?id=158760
Reviewed by Darin Adler.
- BuildSlaveSupport/build.webkit.org-config/master.cfg: Don't enable dSYM generation
for debug builds on Yosemite.
- 6:31 PM Changeset in webkit [202077] by
-
- 2 edits in trunk/Source/WebKit2
Add missing WTFMove() in NetworkResourceLoader::didReceiveResponse()
https://bugs.webkit.org/show_bug.cgi?id=158745
Reviewed by Darin Adler.
Add missing WTFMove() in NetworkResourceLoader::didReceiveResponse()
to avoid copying the ResourceResponse.
- NetworkProcess/NetworkResourceLoader.cpp:
- 6:25 PM Changeset in webkit [202076] by
-
- 5 edits in trunk/Source/WebCore
Regression(r201534): Compile time greatly regressed
https://bugs.webkit.org/show_bug.cgi?id=158765
<rdar://problem/26587342>
Reviewed by Darin Adler.
Compile time greatly regressed by r201534 due to Document.h now including
TextAutoSizing.h. Move the TextAutoSizingTraits back to Document.h to
restore pre-r201534 behavior.
- WebCore.xcodeproj/project.pbxproj:
- dom/Document.cpp:
(WebCore::TextAutoSizingTraits::constructDeletedValue):
(WebCore::TextAutoSizingTraits::isDeletedValue):
- dom/Document.h:
- rendering/TextAutoSizing.h:
(WebCore::TextAutoSizingTraits::constructDeletedValue): Deleted.
(WebCore::TextAutoSizingTraits::isDeletedValue): Deleted.
- 6:03 PM Changeset in webkit [202075] by
-
- 2 edits in trunk/Source/WebCore
Inline media controls cut off PiP and fullscreen buttons on cnn.com
https://bugs.webkit.org/show_bug.cgi?id=158766
<rdar://problem/24175161>
Patch by Antoine Quint <Antoine Quint> on 2016-06-14
Reviewed by Dean Jackson.
The display of the picture-in-picture and fullscreen buttons are dependent on the availability
of video tracks through a call to hasVideo(). We need to ensure that the display properties of
both those buttons are updated when the number of video tracks has changed since the controls
may be populated prior to the availability of video tracks.
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.updateHasVideo):
- 5:45 PM Changeset in webkit [202074] by
-
- 5 edits in trunk
The parser doesn't properly parse "super" when default parameter is an
arrow function.
https://bugs.webkit.org/show_bug.cgi?id=157872.
Patch by Caio Lima <Caio Lima> on 2016-06-14
Reviewed by Saam Barati.
The "super" member or "super()" could not be used when default parameter is an
arrow function, resuling in sytax error. It happened because the
"closestOrdinaryFunctionScope" was not being initialized properly
before "parseFunctionParameters" step and the condition
"functionSuperBinding == SuperBinding::NotNeeded" or
"functionConstructorKind != ConstructorKind::Derived" on
"Parser<LexerType>::parseMemberExpression" step were being true
resulting in SyntaxError.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseFunctionInfo): setting
"functionScope->setExpectedSuperBinding(expectedSuperBinding)" and
"functionScope->setConstructorKind(constructorKind)" before
"parseFunctionParameters" step.
- 5:43 PM Changeset in webkit [202073] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Visual Sidebar: Remove "Text -> Content" subsection
https://bugs.webkit.org/show_bug.cgi?id=158758
<rdar://problem/26799628>
Reviewed by Timothy Hatcher.
"content" CSS property only works with pseudo elements ::before and ::after.
It doesn't do anything for regular (non pseudo) elements. Remove it to
reduce UI clutter.
- UserInterface/Views/VisualStyleDetailsPanel.js:
(WebInspector.VisualStyleDetailsPanel.prototype.initialLayout):
(WebInspector.VisualStyleDetailsPanel.prototype._populateContentSection): Deleted.
- UserInterface/Views/VisualStylePropertyEditor.css:
(.visual-style-property-container > *:first-child:matches(.visual-style-property-value-container)): Deleted.
- 5:42 PM Changeset in webkit [202072] by
-
- 8 edits2 moves in trunk
Web Inspector: Rename Timeline.setAutoCaptureInstruments to Timeline.setInstruments
https://bugs.webkit.org/show_bug.cgi?id=158762
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-14
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
Rename the protocol methods since the backend may use the instruments
for purposes other then auto-capture, such as programmatic capture
via console.profile.
- inspector/protocol/Timeline.json:
Source/WebCore:
Test: inspector/timeline/setInstruments-errors.html
- inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorTimelineAgent::setInstruments):
(WebCore::InspectorTimelineAgent::mainFrameStartedLoading):
(WebCore::InspectorTimelineAgent::setAutoCaptureInstruments): Deleted.
- inspector/InspectorTimelineAgent.h:
Source/WebInspectorUI:
- UserInterface/Controllers/TimelineManager.js:
(WebInspector.TimelineManager.prototype._updateAutoCaptureInstruments):
(WebInspector.TimelineManager):
LayoutTests:
- inspector/timeline/setInstruments-errors-expected.txt: Renamed from LayoutTests/inspector/timeline/setAutoCaptureInstruments-errors-expected.txt.
- inspector/timeline/setInstruments-errors.html: Renamed from LayoutTests/inspector/timeline/setAutoCaptureInstruments-errors.html.
- 4:38 PM Changeset in webkit [202071] by
-
- 3 edits in trunk/Tools
Tests don't work in iOS Simulator when ASan is enabled
https://bugs.webkit.org/show_bug.cgi?id=158726
Reviewed by David Kilzer.
- Scripts/webkitpy/port/driver.py:
(Driver._setup_environ_for_driver): Added a FIXME.
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.setup_environ_for_server): Don't try to insert a dylib built for
simulator into LayoutTestRelay, which is a macOS tool.
- 4:28 PM Changeset in webkit [202070] by
-
- 2 edits in trunk/Tools
Continuous "Reentrancy avoided" error messages in run-webkit-tests if Simulator quits unexpectedly
https://bugs.webkit.org/show_bug.cgi?id=158756
Reviewed by Alexey Proskuryakov.
- Scripts/webkitpy/xcode/simulator.py:
(Simulator.wait_until_device_is_booted): If checking Simulator boot state fails, verify if
the "simulator device" is still in booted state. Since we ensured that simulator device
was in booted state earlier in this method, this indicates that simulator device has shut down
unexpectedly.
- 3:56 PM Changeset in webkit [202069] by
-
- 2 edits in trunk/Source/JavaScriptCore
Document the native format of JSChar type
<http://webkit.org/b/156137>
Reviewed by Darin Adler.
- API/JSStringRef.h:
(typedef JSChar): Update documentation.
- 3:47 PM Changeset in webkit [202068] by
-
- 6 edits2 adds in trunk
decompose4 return value is unchecked, leading to potentially uninitialized data.
https://bugs.webkit.org/show_bug.cgi?id=158761
<rdar://problem/17526268>
Reviewed by Simon Fraser.
Source/WebCore:
WebCore::decompose4 could return early without initializing data.
I now initialize it, but I also started checking the return
value at all the call sites to make sure everything is sensible.
Test: transforms/undecomposable.html
- platform/graphics/transforms/PerspectiveTransformOperation.cpp:
(WebCore::PerspectiveTransformOperation::blend):
- platform/graphics/transforms/RotateTransformOperation.cpp:
(WebCore::RotateTransformOperation::blend):
- platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::decompose4):
(WebCore::TransformationMatrix::blend4):
- platform/graphics/transforms/TransformationMatrix.h:
LayoutTests:
- transforms/undecomposable-expected.txt: Added.
- transforms/undecomposable.html: Added.
- 3:34 PM Changeset in webkit [202067] by
-
- 6 edits4 adds in trunk
The Array species constructor watchpoints should be created the first time they are needed rather than on creation
https://bugs.webkit.org/show_bug.cgi?id=158754
Reviewed by Benjamin Poulain.
Source/JavaScriptCore:
We use adaptive watchpoints for some Array prototype functions to
ensure that the user has not overridden the value of the
Array.prototype.constructor or Array[Symbol.species]. This patch
changes when the Array species constructor watchpoints are
initialized. Before, those watchpoints would be created when the
global object is initialized. This had the advantage that it did
not require validating the constructor and Symbol.species
properties. On the other hand, it also meant that if the user were
to reconfigure properties Array.prototype, which would cause the
structure of the property to become an uncachable dictionary,
prior to running code that the watchpoints would be
invalidated. It turns out that JSBench amazon, for instance, does
reconfigure some of Array.prototype's properties. This patch
initializes the watchpoints the first time they are needed. Since
we only initialize once we also flatten the structure of Array and
Array.prototype.
- runtime/ArrayPrototype.cpp:
(JSC::speciesConstructArray):
(JSC::ArrayPrototype::attemptToInitializeSpeciesWatchpoint):
(JSC::ArrayPrototypeAdaptiveInferredPropertyWatchpoint::handleFire):
(JSC::ArrayPrototype::setConstructor): Deleted.
- runtime/ArrayPrototype.h:
(JSC::ArrayPrototype::speciesWatchpointStatus):
(JSC::ArrayPrototype::didChangeConstructorOrSpeciesProperties): Deleted.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::speciesGetterSetter):
(JSC::JSGlobalObject::arrayConstructor):
- tests/stress/array-symbol-species-lazy-watchpoints.js: Added.
(test):
(arrayEq):
(A):
LayoutTests:
Add new micro-benchmark that tests the impact of lazily
initializing the array species watchpoints.
- js/regress/lazy-array-species-watchpoints-expected.txt: Added.
- js/regress/lazy-array-species-watchpoints.html: Added.
- js/regress/script-tests/lazy-array-species-watchpoints.js: Added.
(test):
- 3:09 PM Changeset in webkit [202066] by
-
- 35 edits2 adds in trunk
Add the unprefixed version of the pseudo element ::placeholder
https://bugs.webkit.org/show_bug.cgi?id=158653
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-06-14
Reviewed by Dean Jackson.
Source/WebCore:
Test: fast/forms/placeholder-pseudo-element-with-webkit-prefix.html
The pseudo element ::-webkit-input-placeholder is stupidly popular
which forces other engines to support this exact name.
The pseudo-element spec provides a new standard name we can adopt
to drop the prefix: https://drafts.csswg.org/css-pseudo-4/#placeholder-pseudo
This patch does just that, make ::placeholder the standard name to select
the placeholder element in the shadow dom of input elements.
Unlike pseudo classes, we did not have any support for prefixes and aliasing.
I want to keep the absurdly efficient matching we currently use for styling
because style updates are more common than stylesheet updates.
With that constraint in mind, the value of CSSSelector has to be the unprefixed
version for both forms of input.
This leaves us with the problem of displaying the CSSSelector for CSSOM.
To differentiate the legacy form from the standard form, I added
a new type of PseudoElement: PseudoElementWebKitCustomLegacyPrefixed.
When parsing, PseudoElementWebKitCustomLegacyPrefixed let us replace
the original value "-webkit-input-placeholder" by the standard value.
When creating the selectorText for CSSOM, PseudoElementWebKitCustomLegacyPrefixed
let us replace the standard for by the legacy form.
- css/CSSParserValues.cpp:
(WebCore::CSSParserSelector::parsePseudoElementSelector):
- css/CSSSelector.cpp:
(WebCore::CSSSelector::pseudoId):
(WebCore::CSSSelector::selectorText):
- css/CSSSelector.h:
(WebCore::CSSSelector::isCustomPseudoElement):
(WebCore::CSSSelector::isWebKitCustomPseudoElement):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchRecursively):
- css/SelectorPseudoElementTypeMap.in:
- css/html.css:
(::placeholder):
(input::placeholder, isindex::placeholder):
(textarea::placeholder):
(::-webkit-input-placeholder): Deleted.
(input::-webkit-input-placeholder, isindex::-webkit-input-placeholder): Deleted.
(textarea::-webkit-input-placeholder): Deleted.
- features.json:
- html/shadow/TextControlInnerElements.cpp:
(WebCore::TextControlPlaceholderElement::TextControlPlaceholderElement):
Source/WebInspectorUI:
- UserInterface/Views/FilterBar.css:
(.filter-bar > input[type="search"]::placeholder):
(.filter-bar > input[type="search"]::-webkit-input-placeholder): Deleted.
- UserInterface/Views/FindBanner.css:
(.find-banner.console-find-banner > input[type="search"]::placeholder):
(.find-banner.console-find-banner > input[type="search"]::-webkit-input-placeholder): Deleted.
- UserInterface/Views/GoToLineDialog.css:
(.go-to-line-dialog > div > input::placeholder):
(.go-to-line-dialog > div > input::-webkit-input-placeholder): Deleted.
- UserInterface/Views/OpenResourceDialog.css:
(.open-resource-dialog > .field > input::placeholder):
(.open-resource-dialog > .field > input::-webkit-input-placeholder): Deleted.
- UserInterface/Views/SearchBar.css:
(.search-bar > input[type="search"]::placeholder):
(.search-bar > input[type="search"]::-webkit-input-placeholder): Deleted.
- UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css:
LayoutTests:
- fast/css/css-selector-text-expected.txt:
- fast/css/css-selector-text.html:
- fast/css/css-set-selector-text-expected.txt:
- fast/css/css-set-selector-text.html:
This covers CSSOM for the prefixed version.
- fast/forms/placeholder-pseudo-element-with-webkit-prefix-expected.html: Added.
- fast/forms/placeholder-pseudo-element-with-webkit-prefix.html: Added.
This verifies both version of the pseudo elements are equivalent.
- fast/css/pseudo-cache-stale-expected.html:
- fast/css/pseudo-cache-stale.html:
- fast/forms/input-placeholder-paint-order-2-expected.html:
- fast/forms/input-placeholder-paint-order-2.html:
- fast/forms/input-placeholder-paint-order.html:
- fast/forms/input-placeholder-text-indent.html:
- fast/forms/input-user-modify.html:
- fast/forms/isindex-placeholder.html:
- fast/forms/placeholder-position.html:
- fast/forms/placeholder-pseudo-style.html:
- fast/forms/textarea-placeholder-pseudo-style.html:
- fast/forms/textarea/textarea-placeholder-paint-order-2-expected.html:
- fast/forms/textarea/textarea-placeholder-paint-order-2.html:
- fast/forms/textarea/textarea-placeholder-paint-order.html:
- 3:02 PM Changeset in webkit [202065] by
-
- 2 edits in trunk/Tools
Follow-up fix #2: REGRESSION (r202020): El Capitan CMake Debug build broken
<https://webkit.org/b/158743>
Unreviewed build fix.
- DumpRenderTree/PlatformMac.cmake: Fix silly typo.
- 2:42 PM Changeset in webkit [202064] by
-
- 13 edits in trunk/Source/WebInspectorUI
Web Inspector: Introduce --navigation-bar-height CSS variable
https://bugs.webkit.org/show_bug.cgi?id=158752
Reviewed by Timothy Hatcher.
Abstract a commonly repeated height value (29px) into a variable.
- UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
(.sidebar > .panel.details.css-style > .content.has-filter-bar):
- UserInterface/Views/DebuggerSidebarPanel.css:
(.sidebar > .panel.navigation.debugger > :matches(.content, .empty-content-placeholder)):
- UserInterface/Views/FilterBar.css:
(.filter-bar):
- UserInterface/Views/NavigationBar.css:
(.navigation-bar):
- UserInterface/Views/NavigationSidebarPanel.css:
(.sidebar > .panel.navigation > .content):
(.sidebar > .panel.navigation > .overflow-shadow.top):
- UserInterface/Views/NetworkSidebarPanel.css:
(.sidebar > .panel.navigation.network > .title-bar):
- UserInterface/Views/ResourceSidebarPanel.css:
(.sidebar > .panel.navigation.resource > :matches(.content, .empty-content-placeholder)):
- UserInterface/Views/SearchSidebarPanel.css:
(.sidebar > .panel.navigation.search > :matches(.content, .empty-content-placeholder)):
(.sidebar > .panel.navigation.search > .search-bar):
- UserInterface/Views/Sidebar.css:
(.sidebar.has-navigation-bar > .panel):
- UserInterface/Views/StorageSidebarPanel.css:
(.sidebar > .panel.navigation.storage > :matches(.content, .empty-content-placeholder)):
- UserInterface/Views/TimelineRecordingContentView.css:
(.content-view.timeline-recording > .content-browser .recording-progress):
- UserInterface/Views/Variables.css:
(:root):
- 2:28 PM Changeset in webkit [202063] by
-
- 13 edits10 adds in trunk
AX: Form label text should be exposed as static text if it contains only static text
https://bugs.webkit.org/show_bug.cgi?id=158634
Reviewed by Chris Fleizach.
Use AccessibilityLabel to represent HTMLLabelElement to assistive technology.
AccessibilityLabel::containsOnlyStaticText() searches label subtree to evaluate
if all children are static text.
AccessibilityLabel::stringValue() consults containsOnlyStaticText() and returns
textUnderElement() if true.
WebAccessibilityObjectWrapperMac consults containsOnlyStaticText() and substitutes
StaticTextRole for LabelRole if true.
Cache containsOnlyStaticText() in the common case when updating children.
Source/WebCore:
Tests: accessibility/mac/label-element-all-text-string-value.html
accessibility/mac/label-element-with-link-string-value.html
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- accessibility/AXObjectCache.cpp:
(WebCore::createFromRenderer):
- accessibility/AccessibilityAllInOne.cpp:
- accessibility/AccessibilityLabel.cpp: Added.
(WebCore::AccessibilityLabel::AccessibilityLabel):
(WebCore::AccessibilityLabel::~AccessibilityLabel):
(WebCore::AccessibilityLabel::create):
(WebCore::AccessibilityLabel::computeAccessibilityIsIgnored):
(WebCore::AccessibilityLabel::stringValue):
(WebCore::childrenContainOnlyStaticText):
(WebCore::AccessibilityLabel::containsOnlyStaticText):
(WebCore::AccessibilityLabel::updateChildrenIfNecessary):
(WebCore::AccessibilityLabel::clearChildren):
(WebCore::AccessibilityLabel::insertChild):
- accessibility/AccessibilityLabel.h: Added.
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isLabel):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper role]):
LayoutTests:
- accessibility/aria-labelledby-overrides-label-expected.txt:
- accessibility/mac/label-element-all-text-string-value-expected.txt: Added.
- accessibility/mac/label-element-all-text-string-value.html: Added.
- accessibility/mac/label-element-with-hidden-control-expected.txt:
- accessibility/mac/label-element-with-hidden-control.html:
- accessibility/mac/label-element-with-link-string-value-expected.txt: Added.
- accessibility/mac/label-element-with-link-string-value.html: Added.
- accessibility/mac/slider-allows-title-ui-element-expected.txt:
- accessibility/mac/slider-allows-title-ui-element.html:
- 2:27 PM Changeset in webkit [202062] by
-
- 2 edits in trunk/Tools
Too much log data generated during layout-tests on iOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=158751
Reviewed by Alexey Proskuryakov.
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort._quit_ios_simulator): Do not use -v flag.
(IOSSimulatorPort.clean_up_test_run): Ditto.
(IOSSimulatorPort._createSimulatorApp): Ditto.
- 1:35 PM Changeset in webkit [202061] by
-
- 2 edits in trunk/LayoutTests
Increase timeouts for userscripts/window-onerror-for-isolated-world-3.html to fix flakiness.
https://bugs.webkit.org/show_bug.cgi?id=158750
Reviewed by Joseph Pecoraro.
- userscripts/window-onerror-for-isolated-world-3.html:
- 1:17 PM Changeset in webkit [202060] by
-
- 2 edits in trunk/Tools
Follow-up fix: REGRESSION (r202020): El Capitan CMake Debug build broken
<https://webkit.org/b/158743>
Unreviewed build fix.
The fix in r202056 clobbered DumpRenderTree_SOURCES and
TestNetscapePlugin_SOURCES from DumpRenderTree/CMakeLists.txt,
so the build failure is now that we're not building the common
sources.
Fix that by saving the common sources (which are all C++ source
files) into *_Cpp_SOURCES lists first, then setting the compiler
flags, then creating the final *_SOURCES lists.
- DumpRenderTree/PlatformMac.cmake: Add
${TestNetscapePlugin_Cpp_SOURCES} to list that needs
"-std=c++14" compiler switch.
(TestNetscapePlugin_Cpp_SOURCES): Add new list for C++ source
files for TestNetscapePlugin. Seeded with
${TestNetscapePlugin_SOURCES} from CMakeLists.txt.
(TestNetscapePlugin_SOURCES): Add
${TestNetscapePlugin_Cpp_SOURCES} to the list of files.
(DumpRenderTree_Cpp_SOURCES): Seed list for C++ source files
with ${DumpRenderTree_SOURCES} from CMakeLists.txt.
(DumpRenderTree_SOURCES): Reformat and sort source lists.
- 1:15 PM Changeset in webkit [202059] by
-
- 6 edits2 deletes in trunk
Unreviewed, rolling out r202057.
https://bugs.webkit.org/show_bug.cgi?id=158749
This change broke the Windows build. (Requested by ryanhaddad
on #webkit).
Reverted changeset:
"Honor bidi unicode codepoints"
https://bugs.webkit.org/show_bug.cgi?id=149170
http://trac.webkit.org/changeset/202057
Patch by Commit Queue <commit-queue@webkit.org> on 2016-06-14
- 12:01 PM Changeset in webkit [202058] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(202002-202014): 845 32-bit JSC Stress Test failures
https://bugs.webkit.org/show_bug.cgi?id=158737
Reviewed by Filip Pizlo.
When the this child and arguments child for the varargs nodes was switched I missed one
case in the 32-bit build.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
- 11:59 AM Changeset in webkit [202057] by
-
- 6 edits2 adds in trunk
Honor bidi unicode codepoints
https://bugs.webkit.org/show_bug.cgi?id=149170
<rdar://problem/26527378>
Reviewed by Simon Fraser.
Source/WebCore:
BidiResolver doesn't have any concept of isolate Unicode code points, so produces
unexpected output when they are present. Fix by considering such code points as
whitespace in the bidi algorithm. This is a stop-gap measure until we can support
the codepoints fully in our Bidi algorithm.
Test: fast/text/isolate-ignore.html
- platform/graphics/Font.cpp:
(WebCore::createAndFillGlyphPage):
- platform/text/BidiResolver.h:
(WebCore::Subclass>::createBidiRunsForLine):
Source/WTF:
- wtf/unicode/CharacterNames.h:
LayoutTests:
- fast/text/isolate-ignore-expected.html: Added.
- fast/text/isolate-ignore.html: Added.
- 11:51 AM Changeset in webkit [202056] by
-
- 2 edits in trunk/Tools
REGRESSION (r202020): El Capitan CMake Debug build broken
<https://webkit.org/b/158743>
Reviewed by Alex Christensen.
The bug was that pure C++ source files (and Objective-C source
files) were being compiled as Objective-C++ source files. This
is obviously incorrect, so the fix was to split out the list of
source files by language, then define compiler switches based on
each file type.
- DumpRenderTree/PlatformMac.cmake: Replace add_definitions()
with separate foreach loops that set compiler flags based on
each source file's type.
(TestNetscapePlugin_ObjCpp_SOURCES): Rename from
TestNetscapePlugin_SOURCES.
(TestNetscapePlugin_SOURCES): Create based on
${TestNetscapePlugin_ObjCpp_SOURCES}.
(DumpRenderTree_ObjC_SOURCES): Split from DumpRenderTree_SOURCES.
(DumpRenderTree_Cpp_SOURCES): Ditto.
(DumpRenderTree_ObjCpp_SOURCES): Ditto.
(DumpRenderTree_SOURCES): Create from above three lists.
- 11:42 AM Changeset in webkit [202055] by
-
- 2 edits in trunk/Source/WebInspectorUI
Follow up to: Web Inspector: Call Trees view should have a 'Top Functions'-like mode
https://bugs.webkit.org/show_bug.cgi?id=158555
<rdar://problem/26712544>
Unreviewed follow up patch.
- Move a long if-else sequence to a switch statement.
- Fix a copy-paste typo in a Symbol(.) enum.
- UserInterface/Models/CallingContextTree.js:
(WebInspector.CallingContextTree.prototype.updateTreeWithStackTrace):
- 11:37 AM Changeset in webkit [202054] by
-
- 8 edits in trunk/Source/WebKit2
Reduce copying of NetworkLoadParameters
https://bugs.webkit.org/show_bug.cgi?id=158744
Reviewed by Alex Christensen.
Reduce copying of NetworkLoadParameters by moving it around instead.
- NetworkProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::startDownload):
- NetworkProcess/Downloads/PendingDownload.cpp:
(WebKit::PendingDownload::PendingDownload):
- NetworkProcess/Downloads/PendingDownload.h:
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::NetworkLoad):
- NetworkProcess/NetworkLoad.h:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::startNetworkLoad):
- NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:
(WebKit::NetworkCache::SpeculativeLoad::SpeculativeLoad):
- 11:09 AM Changeset in webkit [202053] by
-
- 2 edits in trunk/LayoutTests
Removing duplicated TestExpectation and sorting others alphabetically
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 11:03 AM Changeset in webkit [202052] by
-
- 2 edits in trunk/LayoutTests
Marking inspector/debugger/break-in-constructor-before-super.html as flaky on mac debug.
https://bugs.webkit.org/show_bug.cgi?id=158742
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 10:55 AM Changeset in webkit [202051] by
-
- 3 edits in trunk/LayoutTests
Moving flaky expectation for inspector/heap/garbageCollected.html from mac-wk1 to mac
https://bugs.webkit.org/show_bug.cgi?id=153039
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- platform/mac/TestExpectations:
- 9:54 AM Changeset in webkit [202050] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r200455.
https://bugs.webkit.org/show_bug.cgi?id=158740
hangs twitter/facebook (Requested by mcatanzaro on #webkit).
Reverted changeset:
"[GStreamer] Adaptive streaming issues"
https://bugs.webkit.org/show_bug.cgi?id=144040
http://trac.webkit.org/changeset/200455
- 9:46 AM Changeset in webkit [202049] by
-
- 4 edits in trunk
WebRTC: RTCPeerConnection::addTrack() should throw InvalidAccessError instead of InvalidModificationError.
https://bugs.webkit.org/show_bug.cgi?id=158735
Reviewed by Eric Carlson.
Source/WebCore:
Throw InvalidAccessError instead of InvalidModificationError when track already exists in connection's
set of senders as per specification (https://w3c.github.io/webrtc-pc/#dom-rtcpeerconnection-addtrack).
Updated existing test results: fast/mediastream/RTCPeerConnection-add-removeTrack-expected.txt
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::addTrack):
LayoutTests:
Check that an InvalidAccessError exception is thrown when the track already exists in set of senders.
- fast/mediastream/RTCPeerConnection-add-removeTrack-expected.txt:
- 9:41 AM Changeset in webkit [202048] by
-
- 8 edits2 adds in trunk
WebRTC: Imlement MediaEndpointPeerConnection::addIceCandidate()
https://bugs.webkit.org/show_bug.cgi?id=158690
Reviewed by Eric Carlson.
Source/WebCore:
Implement MediaEndpointPeerConnection::addIceCandidate() that is the MediaEndpoint
implementation of RTCPeerConnection.addIceCandidate() [1].
[1] https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html#dom-peerconnection-addicecandidate
Test: fast/mediastream/RTCPeerConnection-addIceCandidate.html
- Modules/mediastream/MediaEndpointPeerConnection.cpp:
(WebCore::MediaEndpointPeerConnection::addIceCandidate):
(WebCore::MediaEndpointPeerConnection::addIceCandidateTask):
Implemented.
- Modules/mediastream/MediaEndpointPeerConnection.h:
- platform/mediastream/MediaEndpoint.h:
Use mid instead of mdescIndex to identify the target media description in the backend.
- platform/mock/MockMediaEndpoint.cpp:
Update mock method signature accordingly.
(WebCore::MockMediaEndpoint::addRemoteCandidate):
- platform/mock/MockMediaEndpoint.h:
LayoutTests:
Add test for RTCPeerConnection.addIceCandidate() that verifies:
- Candidate line parsing
- That a underlying media description can be identified using either sdpMid or sdpMLineIndex
- That sdpMid takes precedence over sdpMLineIndex
- fast/mediastream/RTCPeerConnection-addIceCandidate-expected.txt: Added.
- fast/mediastream/RTCPeerConnection-addIceCandidate.html: Added.
- platform/mac/TestExpectations:
The mac port is not building with WEB_RTC yet.
- 9:40 AM Changeset in webkit [202047] by
-
- 2 edits in trunk/Tools
<rdar://problem/26685782>
Teach the copy-webkitlibraries-to-product-directory script about WebKitSystemInterfaceOSX10.12
Rubber-stamped by Jessie Berlin.
- Scripts/copy-webkitlibraries-to-product-directory:
- 9:32 AM Changeset in webkit [202046] by
-
- 2 edits in trunk/Tools
Activate CMake export compile commands option
https://bugs.webkit.org/show_bug.cgi?id=158734
Reviewed by Alex Christensen.
- Scripts/webkitdirs.pm:
(generateBuildSystemFromCMakeProject): Activating this option for all CMake builds.
This allows using ymcd for WebKit hacking.
- 9:32 AM Changeset in webkit [202045] by
-
- 5 edits1 add in trunk/WebKitLibraries
Update existing WebKitSystemInterface Libraries.
Add macOS Sierra WebKitSystemInterface.
Rubber-stamped by Alexey Proskuryakov.
- libWebKitSystemInterfaceElCapitan.a:
- libWebKitSystemInterfaceIOSDevice9.2.a:
- libWebKitSystemInterfaceIOSSimulator9.2.a:
- libWebKitSystemInterfaceOSX10.12.a: Added.
- libWebKitSystemInterfaceYosemite.a:
- 9:07 AM Changeset in webkit [202044] by
-
- 3 edits in trunk/Source/WebCore
Make RenderBlock::insertInto/RemoveFromTrackedRendererMaps functions static.
https://bugs.webkit.org/show_bug.cgi?id=158722
Reviewed by Simon Fraser.
These functions manipulate static tracker hashmaps. They don't need to be on RenderBlock.
This is also in preparation for decoupling positioned descendant tracking from descendent percentage height handling.
(gPositionedDescendantsMap and gPercentHeightDescendantsMap)
No change in functionality.
- rendering/RenderBlock.cpp:
(WebCore::insertIntoTrackedRendererMaps):
(WebCore::removeFromTrackedRendererMaps):
(WebCore::removeBlockFromDescendantAndContainerMaps):
(WebCore::RenderBlock::insertPositionedObject):
(WebCore::RenderBlock::addPercentHeightDescendant):
(WebCore::RenderBlock::insertIntoTrackedRendererMaps): Deleted.
(WebCore::RenderBlock::removeFromTrackedRendererMaps): Deleted.
- rendering/RenderBlock.h:
- 8:13 AM Changeset in webkit [202043] by
-
- 4 edits2 adds in trunk
WebRTC: Add media setup test where media is set up in one direction at a time
https://bugs.webkit.org/show_bug.cgi?id=158691
Reviewed by Eric Carlson.
Source/WebCore:
Add test for setting up media in one direction at a time. This requires a change in sdp.js
to allow an SDP that doesn't contain a stream id or track id (representing
a track being sent). In this test, the first answer doesn't contain any sending media.
Test: fast/mediastream/RTCPeerConnection-media-setup-two-dialogs.html
- Modules/mediastream/sdp.js:
LayoutTests:
Test setting up media in one direction at a time. This is achieved by first negotiating
media in one direction. In a second step, an updated offer is sent to add bi-directional
media.
- fast/mediastream/RTCPeerConnection-media-setup-two-dialogs-expected.txt: Added.
- fast/mediastream/RTCPeerConnection-media-setup-two-dialogs.html: Added.
- platform/mac/TestExpectations:
The mac port is not building with WEB_RTC yet.
- 7:31 AM Changeset in webkit [202042] by
-
- 2 edits in trunk/Source/WebCore
[Cocoa] Avoid extra copy of headers dictionary in ResourceResponse::platformLazyInit()
https://bugs.webkit.org/show_bug.cgi?id=158717
Reviewed by Alex Christensen.
Avoid extra copy of headers dictionary in ResourceResponse::platformLazyInit() by
calling CFHTTPMessageCopyAllHeaderFields() instead of [NSURLResponse allHeaderFields].
CFHTTPMessageCopyAllHeaderFields() creates only 1 copy while
[NSURLResponse allHeaderFields] creates 2 (see <rdar://problem/26778863>).
- platform/network/cocoa/ResourceResponseCocoa.mm:
(WebCore::addToHTTPHeaderMap):
(WebCore::ResourceResponse::platformLazyInit):
- 6:10 AM Changeset in webkit [202041] by
-
- 3 edits in trunk/Source/WebCore
REGRESSION (r151608): Leak of QTMovieLayer or AVPlayerLayer in -[WebVideoFullscreenController setVideoElement:]
<https://webkit.org/b/158729>
Reviewed by Eric Carlson.
- platform/mac/WebVideoFullscreenController.mm:
(-[WebVideoFullscreenController setVideoElement:]): Use
RetainPtr<> to prevent leaks.
- platform/mac/WebVideoFullscreenHUDWindowController.mm:
Drive-by fix to remove unused <wtf/RetainPtr.h> import.
- 3:00 AM WebKitGTK/2.12.x edited by
- (diff)
- 2:58 AM Changeset in webkit [202040] by
-
- 6 edits in trunk/Source/WebKit2
[ThreadedCompositor] Opening the inspector in a window causes a crash.
https://bugs.webkit.org/show_bug.cgi?id=154444
Reviewed by Žan Doberšek.
The threaded compositor doesn't handle the case of changing or removing the native surface handle. When the web
view is reparented, the current native surface handle is destroyed when the view is removed from the parent, and
a new one is created when added to the new parent. We need to handle this case in the threaded compositor.
- Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:
(WebKit::CompositingRunLoop::stopUpdateTimer): Allow users to stop the update timer.
- Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
(WebKit::ThreadedCompositor::setNativeSurfaceHandleForCompositing): Use performTaskSync because this is called
from a synchronous IPC message and right after it returns, the current native surface is destroyed by the UI
process. So we need to ensure we finish all pending operations for the current native surface in the compositing
thread before it's destroyed. Then we enable or disable the scene depending on whether the native surface has
been created or destroyed and destroy the current context in case the new handle is 0.
(WebKit::ThreadedCompositor::tryEnsureGLContext): Just renamed to make it clear that it can fail.
(WebKit::ThreadedCompositor::glContext):
(WebKit::ThreadedCompositor::renderLayerTree): Return early if scene is not active.
- WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:
(WebKit::ThreadedCoordinatedLayerTreeHost::setNativeSurfaceHandleForCompositing): Schedule a new layer flush
after the native surface handle changed.
- 1:08 AM Changeset in webkit [202039] by
-
- 3 edits in trunk/Source/WebCore
The vector of mediastreams should be passed via a reference to RTCPeerConnection::addTrack()
https://bugs.webkit.org/show_bug.cgi?id=158701
Pass vector of mediastreams by reference.
Reviewed by Youenn Fablet.
- Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::addTrack):
- Modules/mediastream/RTCPeerConnection.h:
- 12:52 AM Changeset in webkit [202038] by
-
- 5 edits in trunk/Source/WebKit2
[Threaded Compositor] Modernize and simplify threaded compositor code
https://bugs.webkit.org/show_bug.cgi?id=158615
Reviewed by Žan Doberšek.
- Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:
(WebKit::CompositingRunLoop::performTask): Use NoncopyableFunction.
(WebKit::CompositingRunLoop::performTaskSync): Ditto.
(WebKit::CompositingRunLoop::startUpdateTimer): Just renamed to start instead of set.
(WebKit::CompositingRunLoop::run): Expose run/stop methods instead of the internal RunLoop object.
(WebKit::CompositingRunLoop::stop): Also stop the update timer instead of relying on the caller to do it.
(WebKit::CompositingRunLoop::setUpdateTimer): Deleted.
(WebKit::CompositingRunLoop::stopUpdateTimer): Deleted.
- Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
(WebKit::ThreadedCompositor::setNativeSurfaceHandleForCompositing): Protects this directly in lambda capture.
(WebKit::ThreadedCompositor::setDeviceScaleFactor): Ditto.
(WebKit::ThreadedCompositor::didChangeViewportSize): Ditto.
(WebKit::ThreadedCompositor::didChangeViewportAttribute): Ditto.
(WebKit::ThreadedCompositor::didChangeContentsSize): Ditto.
(WebKit::ThreadedCompositor::scrollTo): Ditto.
(WebKit::ThreadedCompositor::scrollBy): Ditto.
(WebKit::ThreadedCompositor::updateViewport): Use startUpdateTimer().
(WebKit::ThreadedCompositor::scheduleDisplayImmediately): Ditto.
(WebKit::ThreadedCompositor::didChangeVisibleRect): Improve lambda captures.
(WebKit::ThreadedCompositor::renderLayerTree): Use m_viewportController directly.
(WebKit::ThreadedCompositor::createCompositingThread): Use createThread() version that receives a function.
(WebKit::ThreadedCompositor::runCompositingThread): Use run method and don't stop the update timer when the run
loop finishes.
(WebKit::ThreadedCompositor::terminateCompositingThread): Use stop method.
(WebKit::ThreadedCompositor::ThreadedCompositor): Deleted.
(WebKit::ThreadedCompositor::compositingThreadEntry): Deleted.
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
(WebKit::ThreadedCompositor::viewportController): Deleted.
- 12:48 AM Changeset in webkit [202037] by
-
- 4 edits in trunk/Source/WebKit2
[Threaded Compositor] Flickering and rendering artifacts when resizing the web view
https://bugs.webkit.org/show_bug.cgi?id=154070
Reviewed by Žan Doberšek.
Resizing the web view is expected to be a sync operation, the UI process creates a new backing store state ID,
sends UpdateBackingStoreState message with the flag RespondImmediately to the web process and waits up to 500ms
for the reply (DidUpdateBackingStoreState message). When using the threaded compositor, we schedule a task in
the compositing thread to update the viewport size, and return immediately, so that we reply to the UI process
before the compositing thread has actually updated its size. There's a moment in which sizes are out of sync
causing the flickering and rendering artifacts, the UI process continues rendering at the new size, while the
web process is still rendering at the previous size. We can prevent this from happening just by making the
resize task synchronous in the threaded compositor.
- Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:
(WebKit::CompositingRunLoop::performTaskSync): Add sync version of performTask().
- Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
(WebKit::ThreadedCompositor::didChangeViewportSize): Use performTaskSync().
- 12:43 AM Changeset in webkit [202036] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. Fix Soup downloads after r201943.
This is a follow up of r201943. The DownloadClient used in DownloadSoup was not updated to the new API of the
ResourceHandleClient because it was not using override on the virtual methods, so it was unnoticed. That broke
the downloads soup implementation, because didReceiveResponse is no longer used in the DownloadClient. This
patch updates the DownloadClient to the new ResourceHandleClient API adding also override to all the virtual
methods to prevent this from happening in the future.
- NetworkProcess/Downloads/soup/DownloadSoup.cpp:
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::DownloadClient::DownloadClient):
(WebKit::DownloadClient::downloadFailed):
(WebKit::DownloadClient::didReceiveResponse):
(WebKit::DownloadClient::didReceiveData):
(WebKit::DownloadClient::didFinishLoading):
(WebKit::DownloadClient::didFail):
(WebKit::DownloadClient::wasBlocked): Deleted.
(WebKit::DownloadClient::cannotShowURL): Deleted.
(WebKit::DownloadClient::cancel):
(WebKit::DownloadClient::handleResponse):
- 12:35 AM Changeset in webkit [202035] by
-
- 2 edits in trunk/Source/WebCore
Crash inside firstPositionInNode in checkLoadCompleteForThisFrame
https://bugs.webkit.org/show_bug.cgi?id=158724
Reviewed by Alex Christensen.
Added null checks for document and document element since they could be nullptr here.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
- 12:10 AM Changeset in webkit [202034] by
-
- 2 edits in trunk/Tools
Modernize DumpRenderTreeMac.h
<https://webkit.org/b/158721>
Reviewed by Andy Estes.
- DumpRenderTree/mac/DumpRenderTreeMac.h:
- Update copyright.
- Update license.
- Use #pragma once.
- Use OBJC_CLASS macro.
