Timeline

Jun 23, 2016:

11:07 PM Changeset in webkit [202418] by Simon Fraser

• 3 edits in trunk/Tools

Fix Windows build.

• DumpRenderTree/cg/PixelDumpSupportCG.cpp:
• DumpRenderTree/cg/PixelDumpSupportCG.h:

10:20 PM Changeset in webkit [202417] by pvollan@apple.com

• 2 edits in trunk/Source/WebKit/win

[Win] The test accessibility/aria-labelledby-overrides-label.html is failing.
​https://bugs.webkit.org/show_bug.cgi?id=159057

Reviewed by Brent Fulgham.

The test expects the label to have a static text role, but currently it has a
group role.

• AccessibleBase.cpp:

(MSAARole): Change the role of labels to static text.

9:51 PM Changeset in webkit [202416] by Gyuyoung Kim

• 2 edits in trunk/Tools

[EFL] Change download path of libxslt

Unreviewed EFL build fix.

In Korea current download path can't be accessed. Change it.

• efl/jhbuild.modules:

9:39 PM Changeset in webkit [202415] by commit-queue@webkit.org

• 3 edits
  9 adds in trunk

OOM Assertion failure in Array.prototype.toString
​https://bugs.webkit.org/show_bug.cgi?id=158793

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-06-23
Reviewed by Saam Barati.

Source/JavaScriptCore:

JSString::create() taking a StringImpl was using a signed integer
for the length of the string.
The problem is StringImpl uses an unsigned integer. When a large string
was passed to JSString, the signed integer would be negative and crash
JSString.

• runtime/JSString.h:

(JSC::JSString::create):

LayoutTests:

• js/script-tests/stringimpl-to-jsstring-on-large-strings-1.js: Added.

(string_appeared_here.createStrings):

• js/script-tests/stringimpl-to-jsstring-on-large-strings-2.js: Added.

(string_appeared_here.createRegexp):
(catch):

• js/script-tests/stringimpl-to-jsstring-on-large-strings-3.js: Added.

(string_appeared_here.createStrings):
(catch):

• js/stringimpl-to-jsstring-on-large-strings-1-expected.txt: Added.
• js/stringimpl-to-jsstring-on-large-strings-1.html: Added.
• js/stringimpl-to-jsstring-on-large-strings-2-expected.txt: Added.
• js/stringimpl-to-jsstring-on-large-strings-2.html: Added.
• js/stringimpl-to-jsstring-on-large-strings-3-expected.txt: Added.
• js/stringimpl-to-jsstring-on-large-strings-3.html: Added.

9:08 PM Changeset in webkit [202414] by beidson@apple.com

• 14 edits
  7 adds in trunk

Retrieving Blobs from IndexedDB using cursors fails in WK2 (Sandboxing)
​https://bugs.webkit.org/show_bug.cgi?id=158991

Reviewed by Alex Christensen.

Source/WebCore:

Test: storage/indexeddb/modern/blob-cursor.html

• platform/network/BlobDataFileReference.cpp:

(WebCore::BlobDataFileReference::startTrackingModifications): Deleted.

Source/WebKit2:

• CMakeLists.txt:
• WebKit2.xcodeproj/project.pbxproj:

• DatabaseProcess/DatabaseProcess.cpp:

(WebKit::DatabaseProcess::getSandboxExtensionsForBlobFiles):
(WebKit::DatabaseProcess::didGetSandboxExtensionsForBlobFiles):

• DatabaseProcess/DatabaseProcess.h:

• DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp:

(WebKit::WebIDBConnectionToClient::handleGetResult): Handle creation of sandbox extensions

for any result that might contain blob values.

(WebKit::WebIDBConnectionToClient::didGetRecord):
(WebKit::WebIDBConnectionToClient::didOpenCursor):
(WebKit::WebIDBConnectionToClient::didIterateCursor):

• DatabaseProcess/IndexedDB/WebIDBConnectionToClient.h:

• Shared/Databases/IndexedDB/WebIDBResult.cpp: Added.

(WebKit::WebIDBResult::encode):
(WebKit::WebIDBResult::decode):

• Shared/Databases/IndexedDB/WebIDBResult.h: Added.

(WebKit::WebIDBResult::WebIDBResult):
(WebKit::WebIDBResult::resultData):
(WebKit::WebIDBResult::handles):

• Shared/SandboxExtension.h: Make SandboxExtension handles moveable.

• WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:

(WebKit::preregisterSandboxExtensionsIfNecessary): Register sandbox extensions with the

Networking process for any result that might contain blob values.

(WebKit::WebIDBConnectionToServer::didGetRecord):
(WebKit::WebIDBConnectionToServer::didOpenCursor):
(WebKit::WebIDBConnectionToServer::didIterateCursor):
(WebKit::WebIDBConnectionToServer::didGetRecordWithSandboxExtensions): Deleted.

• WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
• WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.messages.in:

LayoutTests:

• storage/indexeddb/modern/blob-cursor-expected.txt: Added.
• storage/indexeddb/modern/blob-cursor.html: Added.
• storage/indexeddb/modern/resources/blob-cursor.js: Added.
• storage/indexeddb/modern/resources/blob-cursor1.html: Added.
• storage/indexeddb/modern/resources/blob-cursor2.html: Added.

8:41 PM Changeset in webkit [202413] by Yusuke Suzuki

• 44 edits
  1 copy
  47 adds in trunk

[JSC] Implement isFinite / isNaN in JS and make DFG ToNumber accept non number values
​https://bugs.webkit.org/show_bug.cgi?id=154022

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

We aim at optimizing @toInteger operation.
While it still has an unoptimized part[1], this patch should be a first step.

We introduce the @toNumber builtin intrinsic operation.
This converts the given value to the JS number by emitting op_to_number bytecode.
Previously @toInteger called C++ @Number constructor for that purpose.

And in DFG, op_to_number is converted to DFG ToNumber node.
During DFG, we attempt to convert this to edge filtering and Identity, but if we fail,
we just fall back to calling the C++ function.

To utilize ToNumber in user-land side, we add a path attempting to convert Number constructor calls
to ToNumber DFG nodes. This conversion is useful because Number(value) is used to convert a value to a number in JS.

Before this patch, we emit simple edge filtering (NumberUse) instead of emitting DFG node like ToNumber for op_to_number.
But emitting ToNumber is useful, because in the case of Number(value), considering value may not be a number is reasonable.

By leveraging @toNumber operation, we rewrite Number.{isFinite, isNaN}, global.{isFinite, isNaN} and @toInteger.

ToNumber DFG node has a value profiling. This profiling is leveraged to determine the result number type of the ToNumber operation.
This value profiling is provided from either NumberConstructor's call operation or op_to_number.

The results (with the added performance tests) show that, while existing cases are performance neutral, the newly added cases gain the performance benefit.
And ASMBench/n-body.c also shows stable ~2% progression.

[1]: ​https://bugs.webkit.org/show_bug.cgi?id=153738

• CMakeLists.txt:
• DerivedSources.make:
• JavaScriptCore.xcodeproj/project.pbxproj:
• builtins/BuiltinNames.h:
• builtins/GlobalObject.js:

(globalPrivate.isFinite):
(globalPrivate.isNaN):
(globalPrivate.toInteger): Deleted.
(globalPrivate.toLength): Deleted.
(globalPrivate.isDictionary): Deleted.
(globalPrivate.speciesGetter): Deleted.
(globalPrivate.speciesConstructor): Deleted.

• builtins/GlobalOperations.js: Copied from Source/JavaScriptCore/builtins/GlobalObject.js.

(globalPrivate.toInteger):
(globalPrivate.toLength):
(globalPrivate.isDictionary):
(globalPrivate.speciesGetter):
(globalPrivate.speciesConstructor):

• builtins/NumberConstructor.js: Added.

(isFinite):
(isNaN):

• bytecode/BytecodeIntrinsicRegistry.cpp:

(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):

• bytecode/BytecodeIntrinsicRegistry.h:
• bytecode/BytecodeList.json:
• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::finishCreation):

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitUnaryOp):
(JSC::BytecodeGenerator::emitUnaryOpProfiled):

• bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitToNumber):

• bytecompiler/NodesCodegen.cpp:

(JSC::BytecodeIntrinsicNode::emit_intrinsic_toNumber):
(JSC::UnaryPlusNode::emitBytecode):

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::attemptToInlineCall):
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
(JSC::DFG::ByteCodeParser::parseBlock):
We use getPrediction() to retrieve the heap prediction from the to_number bytecode.
According to the benchmark results, choosing getPredictionWithoutOSRExit() causes performance regression (1.5%) in kraken stanford-crypto-aes.

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupToNumber):

• dfg/DFGNode.h:

(JSC::DFG::Node::hasHeapPrediction):

• dfg/DFGNodeType.h:
• dfg/DFGOperations.cpp:
• dfg/DFGOperations.h:
• dfg/DFGPredictionPropagationPhase.cpp:

Alway rely on the heap prediction.

• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):
As of 64bit version, we carefully manage the register reuse. The largest difference between 32bit and 64bit is
branchIfNotNumber() requires the temporary register. We should not use the result registers for that since
it may be reuse the argument registers and it can break the argument registers before using them to call the operation.
Currently, we allocate the additional temporary register for that scratch register.

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):
Reuse the argument register for the result if possible. And manually decrement the use count in the middle of the node.
This is similar technique used in ToPrimitive. Typically, the child of ToNumber is only used by this ToNumber node since
we would like to perform the type conversion onto this child node here. So this careful register reuse effectively removes
the spills to call the operation. The example of the actually emitted code is the following.

76:<!2:loc11> ToNumber(Untyped:@68, JS|MustGen|UseAsOther, DoubleimpurenanTopEmpty, R:World, W:Heap, Exits, ClobbersExit, bc#48) predicting DoubleimpurenanTopEmpty

0x7f986d5fe693: test %rax, %r14
0x7f986d5fe696: jz 0x7f986d5fe6a1
0x7f986d5fe69c: jmp 0x7f986d5fe6d1
0x7f986d5fe6a1: mov %rax, %rsi
0x7f986d5fe6a4: mov %rbp, %rdi
0x7f986d5fe6a7: mov $0x2, 0x24(%rbp)
0x7f986d5fe6ae: mov $0x7f98711ea5f0, %r11
0x7f986d5fe6b8: call *%r11
0x7f986d5fe6bb: mov $0x7f982d3f72d0, %r11
0x7f986d5fe6c5: mov (%r11), %r11
0x7f986d5fe6c8: test %r11, %r11
0x7f986d5fe6cb: jnz 0x7f986d5fe88c

It effectively removes the unnecessary spill to call the operation!

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileToNumber):
(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):

• jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::branchIfNumber):
(JSC::AssemblyHelpers::branchIfNotNumber):

• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_to_number):

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_to_number):

• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:
• parser/Nodes.h:

(JSC::UnaryOpNode::opcodeID):

• runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncIsNaN): Deleted.
(JSC::globalFuncIsFinite): Deleted.

• runtime/JSGlobalObjectFunctions.h:
• runtime/MathCommon.h:

(JSC::maxSafeInteger):
(JSC::minSafeInteger):

• runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::finishCreation):
(JSC::numberConstructorFuncIsFinite): Deleted.
(JSC::numberConstructorFuncIsNaN): Deleted.

• runtime/NumberConstructor.h:
• tests/stress/Number-isNaN-basics.js: Added.

(numberIsNaNOnInteger):
(testNumberIsNaNOnIntegers):
(verifyNumberIsNaNOnIntegerWithOtherTypes):
(numberIsNaNOnDouble):
(testNumberIsNaNOnDoubles):
(verifyNumberIsNaNOnDoublesWithOtherTypes):
(numberIsNaNNoArguments):
(numberIsNaNTooManyArguments):
(testNumberIsNaNOnConstants):
(numberIsNaNStructTransition):
(Number.isNaN):

• tests/stress/global-is-finite.js: Added.

(shouldBe):

• tests/stress/global-is-nan.js: Added.

(shouldBe):

• tests/stress/global-isNaN-basics.js: Added.

(isNaNOnInteger):
(testIsNaNOnIntegers):
(verifyIsNaNOnIntegerWithOtherTypes):
(isNaNOnDouble):
(testIsNaNOnDoubles):
(verifyIsNaNOnDoublesWithOtherTypes):
(verifyIsNaNOnCoercedTypes):
(isNaNNoArguments):
(isNaNTooManyArguments):
(testIsNaNOnConstants):
(isNaNTypeCoercionSideEffects):
(i.value.isNaNTypeCoercionSideEffects.valueOf):
(isNaNStructTransition):
(isNaN):

• tests/stress/number-is-finite.js: Added.

(shouldBe):
(test2):
(test3):

• tests/stress/number-is-nan.js: Added.

(shouldBe):
(test2):
(test3):

• tests/stress/to-number-basics.js: Added.

(shouldBe):

• tests/stress/to-number-convert-identity-without-execution.js: Added.

(shouldBe):
(object.valueOf):
(valueOf):

• tests/stress/to-number-int52.js: Added.

(shouldBe):
(object.valueOf):

• tests/stress/to-number-intrinsic-convert-to-identity-without-execution.js: Added.

(shouldBe):
(object.valueOf):
(valueOf):

• tests/stress/to-number-intrinsic-int52.js: Added.

(shouldBe):
(object.valueOf):

• tests/stress/to-number-intrinsic-object-without-execution.js: Added.

(shouldBe):
(object.valueOf):

• tests/stress/to-number-intrinsic-value-profiling.js: Added.

(shouldBe):
(object.valueOf):

• tests/stress/to-number-object-without-execution.js: Added.

(shouldBe):
(object.valueOf):

• tests/stress/to-number-object.js: Added.

(shouldBe):
(test12):
(object1.valueOf):
(test2):
(test22):
(object2.valueOf):
(test3):
(test32):
(object3.valueOf):

• tests/stress/to-number-value-profiling.js: Added.

(shouldBe):
(object.valueOf):

LayoutTests:

• js/regress/Number-isNaN-expected.txt: Added.
• js/regress/Number-isNaN.html: Added.
• js/regress/global-isNaN-expected.txt: Added.
• js/regress/global-isNaN.html: Added.
• js/regress/script-tests/Number-isNaN.js: Added.
• js/regress/script-tests/global-isNaN.js: Added.
• js/regress/script-tests/many-foreach-calls.js:

(i.4.forEach):
(i.array.forEach): Deleted.

• js/regress/script-tests/to-number-constructor-number-string-number-string.js: Added.

(test):

• js/regress/script-tests/to-number-constructor-only-number.js: Added.

(test):

• js/regress/script-tests/to-number-constructor-only-string.js: Added.

(test):

• js/regress/script-tests/to-number-constructor-string-number-string-number.js: Added.

(test):

• js/regress/script-tests/to-number-number-string-number-string.js: Added.

(test):

• js/regress/script-tests/to-number-only-number.js: Added.

(test):

• js/regress/script-tests/to-number-only-string.js: Added.

(test):

• js/regress/script-tests/to-number-string-number-string-number.js: Added.

(test):

• js/regress/to-number-constructor-number-string-number-string-expected.txt: Added.
• js/regress/to-number-constructor-number-string-number-string.html: Added.
• js/regress/to-number-constructor-only-number-expected.txt: Added.
• js/regress/to-number-constructor-only-number.html: Added.
• js/regress/to-number-constructor-only-string-expected.txt: Added.
• js/regress/to-number-constructor-only-string.html: Added.
• js/regress/to-number-constructor-string-number-string-number-expected.txt: Added.
• js/regress/to-number-constructor-string-number-string-number.html: Added.
• js/regress/to-number-number-string-number-string-expected.txt: Added.
• js/regress/to-number-number-string-number-string.html: Added.
• js/regress/to-number-only-number-expected.txt: Added.
• js/regress/to-number-only-number.html: Added.
• js/regress/to-number-only-string-expected.txt: Added.
• js/regress/to-number-only-string.html: Added.
• js/regress/to-number-string-number-string-number-expected.txt: Added.
• js/regress/to-number-string-number-string-number.html: Added.

8:34 PM Changeset in webkit [202412] by Simon Fraser

• 4 edits in trunk

​https://bugs.webkit.org/show_bug.cgi?id=159077

Tools:

Turn off CARenderServer snapshotting in WTR for now, because it doesn't reliably
snapshot the final state of the test in release builds.

• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dump):

LayoutTests:

Mark fast/harness/snapshot-captures-compositing.html as an image failure.

• platform/ios-simulator-wk2/TestExpectations:

7:50 PM Changeset in webkit [202411] by Simon Fraser

• 3 edits in trunk/Tools

Fix hardware builds, where USE(IOSURFACE) is true by #ifdeffing.

• DumpRenderTree/ios/PixelDumpSupportIOS.mm:

(createBitmapContextFromWebView):

• WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(WTR::PlatformWebView::windowSnapshotImage):

7:47 PM Changeset in webkit [202410] by achristensen@apple.com

• 30 edits in trunk/Source

Remove unused didCancelAuthenticationChallenge
​https://bugs.webkit.org/show_bug.cgi?id=158819

Reviewed by David Kilzer.

Source/WebCore:

No change in behavior. This callback was deprecated in Yosemite. It is never called.

• loader/EmptyClients.h:
• loader/FrameLoaderClient.h:
• loader/ResourceLoadNotifier.cpp:

(WebCore::ResourceLoadNotifier::didCancelAuthenticationChallenge): Deleted.

• loader/ResourceLoadNotifier.h:
• loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::didCancelAuthenticationChallenge): Deleted.

• loader/ResourceLoader.h:
• platform/network/ResourceHandle.h:
• platform/network/ResourceHandleClient.h:

(WebCore::ResourceHandleClient::didCancelAuthenticationChallenge): Deleted.

• platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::didCancelAuthenticationChallenge): Deleted.

• platform/network/mac/WebCoreResourceHandleAsDelegate.mm:

(-[WebCoreResourceHandleAsDelegate connection:didCancelAuthenticationChallenge:]): Deleted.

• platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didCancelAuthenticationChallenge:]): Deleted.

• platform/spi/cocoa/NSURLDownloadSPI.h:

Source/WebKit/ios:

• DefaultDelegates/WebDefaultResourceLoadDelegate.m:

(-[WebDefaultResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
(-[WebDefaultResourceLoadDelegate webView:resource:canAuthenticateAgainstProtectionSpace:forDataSource:]):
(-[WebDefaultResourceLoadDelegate webView:resource:didCancelAuthenticationChallenge:fromDataSource:]): Deleted.

Source/WebKit/mac:

• Misc/WebDownload.mm:

(-[WebDownloadInternal download:didCancelAuthenticationChallenge:]): Deleted.

• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): Deleted.

• WebView/WebDelegateImplementationCaching.h:
• WebView/WebView.mm:

(-[WebView _cacheResourceLoadDelegateImplementations]):

Source/WebKit/win:

• WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): Deleted.

• WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit2:

• NetworkProcess/Downloads/mac/DownloadMac.mm:

(-[WKDownloadAsDelegate download:didCancelAuthenticationChallenge:]): Deleted.

• NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::didCancelAuthenticationChallenge): Deleted.

• NetworkProcess/NetworkLoad.h:
• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge): Deleted.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

7:44 PM Changeset in webkit [202409] by andersca@apple.com

• 2 edits in trunk/Source/WebCore

Add "shippingType" to the list of valid payment request properties
​https://bugs.webkit.org/show_bug.cgi?id=159079
<rdar://problem/26988429>

Reviewed by Dean Jackson.

• Modules/applepay/ApplePaySession.cpp:

(WebCore::isValidPaymentRequestPropertyName):

7:38 PM Changeset in webkit [202408] by benjamin@webkit.org

• 29 edits
  14 adds in trunk

Specialize synchronous event tracking per event type
​https://bugs.webkit.org/show_bug.cgi?id=158826

Reviewed by Simon Fraser.

Source/WebCore:

First, kudos to Rick Byers for all his helps on passive event dispatch.
The specs are pretty damn good and his help reviewing patches is very useful.

This patch change synchronous event dispatch to happen per event
instead of per sequence touchstart->touchend.

The big advantage of this is we can dispatch more events asynchronously.
For example, to handle a tap programmatically, you can limit the active listener
to the touchend event. The touchstart and touchmove are now dispatched asynchronously.

The implementation is a simple extension to EventTrackingRegions.
Instead of a single synchronous region, we have one region per event type.
When processing the events, we only need to send the events synchronously
if that particular event type has a synchronous region.

Note that EventDispatcher's touch event support already supports
mixing synchronous and asynchronous events. The events are always processed
in order even if asynchronous events are pending when a synchronous dispatch
happens.

Tests: fast/events/touch/ios/tap-with-active-listener-inside-document-with-passive-listener.html

fast/events/touch/ios/tap-with-active-listener-inside-window-with-passive-listener.html
fast/events/touch/ios/tap-with-active-touch-end-listener.html
fast/events/touch/ios/tap-with-passive-listener-inside-active-listener.html
fast/events/touch/ios/tap-with-passive-touch-end-listener.html
fast/events/touch/ios/tap-with-passive-touch-start-active-touch-end-listeners-on-elements.html
fast/events/touch/ios/tap-with-passive-touch-start-active-touch-move-listeners-on-elements.html

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:
• dom/EventTarget.cpp:

(WebCore::EventTarget::hasActiveTouchEventListeners): Deleted.

• dom/EventTarget.h:
• page/DebugPageOverlays.cpp:

(WebCore::NonFastScrollableRegionOverlay::updateRegion):

• page/Page.cpp:

(WebCore::Page::nonFastScrollableRects):

• page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::absoluteEventTrackingRegionsForFrame):

• page/scrolling/ScrollingStateFrameScrollingNode.cpp:

(WebCore::ScrollingStateFrameScrollingNode::dumpProperties):

• page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::shouldHandleWheelEventSynchronously):
(WebCore::ScrollingTree::eventTrackingTypeForPoint):

• page/scrolling/ScrollingTree.h:
• platform/EventTrackingRegions.cpp: Added.

(WebCore::EventTrackingRegions::trackingTypeForPoint):
(WebCore::EventTrackingRegions::isEmpty):
(WebCore::EventTrackingRegions::translate):
(WebCore::EventTrackingRegions::uniteSynchronousRegion):
(WebCore::EventTrackingRegions::unite):
(WebCore::operator==):

• platform/EventTrackingRegions.h:

(WebCore::EventTrackingRegions::isEmpty): Deleted.
(WebCore::EventTrackingRegions::trackingTypeForPoint): Deleted.
(WebCore::operator==): Deleted.

Source/WebKit2:

• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<EventTrackingRegions>::encode):
(IPC::ArgumentCoder<EventTrackingRegions>::decode):

• UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::eventTrackingTypeForPoint):

• UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::mergeTrackingTypes):
(WebKit::WebPageProxy::updateTouchEventTracking):
(WebKit::WebPageProxy::touchEventTrackingType):
(WebKit::WebPageProxy::handleTouchEventSynchronously):
(WebKit::WebPageProxy::handleTouchEventAsynchronously):
(WebKit::WebPageProxy::handleTouchEvent):
(WebKit::WebPageProxy::resetState):

• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::TouchEventTracking::isTrackingAnything):
(WebKit::WebPageProxy::TouchEventTracking::reset):

LayoutTests:

• fast/events/touch/ios/tap-with-active-listener-inside-document-with-passive-listener-expected.txt: Added.
• fast/events/touch/ios/tap-with-active-listener-inside-document-with-passive-listener.html: Added.
• fast/events/touch/ios/tap-with-active-listener-inside-window-with-passive-listener-expected.txt: Added.
• fast/events/touch/ios/tap-with-active-listener-inside-window-with-passive-listener.html: Added.
• fast/events/touch/ios/tap-with-active-touch-end-listener-expected.txt: Added.
• fast/events/touch/ios/tap-with-active-touch-end-listener.html: Added.
• fast/events/touch/ios/tap-with-passive-listener-inside-active-listener.html: Added.
• fast/events/touch/ios/tap-with-passive-touch-end-listener-expected.txt: Added.
• fast/events/touch/ios/tap-with-passive-touch-end-listener.html: Added.
• fast/events/touch/ios/tap-with-passive-touch-start-active-touch-end-listeners-on-elements-expected.txt: Added.
• fast/events/touch/ios/tap-with-passive-touch-start-active-touch-end-listeners-on-elements.html: Added.
• fast/events/touch/ios/tap-with-passive-touch-start-active-touch-move-listeners-on-elements-expected.txt: Added.
• fast/events/touch/ios/tap-with-passive-touch-start-active-touch-move-listeners-on-elements.html: Added.

5:59 PM Changeset in webkit [202407] by Simon Fraser

• 2 edits in trunk/Source/WebCore

More attempting to fix external iOS builds.

• platform/spi/cocoa/QuartzCoreSPI.h:

5:25 PM Changeset in webkit [202406] by ap@apple.com

• 2 edits in trunk/LayoutTests

Update TestExpectations for a couple video track tests.

• platform/mac/TestExpectations:

5:12 PM Changeset in webkit [202405] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Try to fix the non-internal builds by defining CARenderServerBufferRef.

• platform/spi/cocoa/QuartzCoreSPI.h:

5:08 PM Changeset in webkit [202404] by Simon Fraser

• 12 edits
  2 adds in trunk

[iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
​https://bugs.webkit.org/show_bug.cgi?id=159077

Reviewed by Tim Horton.

Source/WebCore:

Add CARenderServer SPIs.

Test: fast/harness/snapshot-captures-compositing.html

• platform/spi/cocoa/QuartzCoreSPI.h:

Tools:

Fix both DRT and WTR for iOS to use CARenderServerRenderLayerWithTransform() on the view's layer.
This allows them to capture compositing layers in snapshots, rather than doing a software paint,
thus enabling testing of more things.

• DumpRenderTree/cg/PixelDumpSupportCG.cpp:

(createBitmapContext): Moved to this file to share it.

• DumpRenderTree/cg/PixelDumpSupportCG.h:
• DumpRenderTree/ios/PixelDumpSupportIOS.mm:

(createBitmapContextFromWebView):
(BitmapContext::createFromUIImage): Deleted.
(BitmapContext::pixelData): Deleted.
(BitmapContext::BitmapContext): Deleted.
(computeMD5HashStringForBitmapContext): Deleted.
(dumpBitmap): Deleted.

• DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Don't exclude PixelDumpSupportCG.cpp.
• DumpRenderTree/mac/PixelDumpSupportMac.mm:

(createPagedBitmapContext):
(createBitmapContext): Deleted.

• WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: link with QuartzCore.
• WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dump): Deleted.

• WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(WTR::PlatformWebView::windowSnapshotImage):

LayoutTests:

Test that fails if snapshotting doesn't correctly snapshot 3D transforms.

• fast/harness/snapshot-captures-compositing-expected.html: Added.
• fast/harness/snapshot-captures-compositing.html: Added.

5:00 PM Changeset in webkit [202403] by bshafiei@apple.com

• 5 edits in trunk/Source

Versioning.

4:28 PM Changeset in webkit [202402] by sbarati@apple.com

• 8 edits
  1 add in trunk/Source/JavaScriptCore

DFGSpeculativeJIT's m_slowPathLambdas should restore the current node field and DFG OSR entry functions should use DeferGCForAWhile instead of DeferGC
​https://bugs.webkit.org/show_bug.cgi?id=159064
<rdar://problem/26599119>

Reviewed by Filip Pizlo.

The DFG has a list of m_slowPathLambdas that are code generators it emits
amongst its slow paths. These lambdas, however, did not update the m_currentNode field.
This caused us to use whatever Node happened to be used as the currentNode at the time
we call the slowPathLambda. This means the wrong CallSiteIndex was stored into the call
frame when we made a call. This may lead to a crash if the CallSiteIndex corresponds to
the wrong CodeOrigin. For example, the wrong CodeOrigin could have an InlineCallFrame with
a calleeRecovery that will not be in sync with the current stack state. Trying
to recover that callee will often lead to a crash. The solution is to update
m_currentNode to the DFG::Node* it corresponds to when emitting these slowPathLambdas.

I found this bug because we were inside this bad state when calling an operation
that happened to have a DeferGC. When this DeferGC actually GCed, it would
take a StackTrace, which would lead to a crash because we were updating
ShadowChicken with vm.topCallFrame. It just so happened that the CallSiteIndex
in the call frame in this program corresponded to an InlineCallFrame with a calleeRecover.
However, this CallSiteIndex didn't correspond to the actual state of execution
of the program. I'm adding new options to make reproducing DeferGC related
bugs easier by making DeferGC force a GC according to some probability. To
always have DeferGC force a GC, you can set that probability to 1.

There is a second bug that I discovered after solving the above bug. We were
using DeferGC instead of DeferGCForAWhile in the OSR entry related functions
in the DFG. This would cause us to take a stack trace when the call frame was
in an inconsistent state. For example, the operation would call FTL::prepareOSREntry,
which would replace the DFG CodeBlock in the call frame with the FTL CodeBlock.
However, we wouldn't update the CallSiteIndex to correspond to an FTL CallSiteIndex.
This would lead to a crash when taking a stack trace. The solution is to prevent
stack traces from being taken when the program is in this state by using
DeferGCForAWhie instead of DeferGC.

• dfg/DFGOperations.cpp:
• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::addSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::runSlowPathGenerators):

• dfg/DFGSpeculativeJIT.h:
• heap/Heap.h:
• heap/HeapInlines.h:

(JSC::Heap::collectIfNecessaryOrDefer):
(JSC::Heap::collectAccordingToDeferGCProbability):
(JSC::Heap::decrementDeferralDepthAndGCIfNeeded):
(JSC::Heap::markListSet):

• runtime/Options.cpp:

(JSC::recomputeDependentOptions):
(JSC::Options::initialize):

• runtime/Options.h:
• tests/stress/slow-path-generator-updating-current-node-dfg.js: Added.

(foo):
(bar):

4:22 PM Changeset in webkit [202401] by BJ Burg

• 3 edits in trunk/Source/WebCore

Web Inspector: add assertions to catch dangling frontends that persist between tests
​https://bugs.webkit.org/show_bug.cgi?id=159073

Reviewed by Joseph Pecoraro.

Based on the analysis in ​https://webkit.org/b/159070, we suspect that some test
flakiness might be caused by dangling frontends from previous test cases. Add an
assertion that should catch any frontends that are attached to the inspected page's
backend. There should never be any frontends connected when a test first starts.

• inspector/InspectorController.cpp:

(WebCore::InspectorController::setIsUnderTest):

• inspector/InspectorController.h:

3:52 PM Changeset in webkit [202400] by ddkilzer@apple.com

• 2 edits in trunk/Source/WTF

REGRESSION (r202380): iOS 9.x internal builds are broken

Follow-up fix for: Enable window.open() for existing versions of Secret Society
<​https://webkit.org/b/159049>
<rdar://problem/26528349>

• wtf/spi/darwin/dyldSPI.h: Define DYLD_IOS_VERSION_10_0 when

building on internal SDKs older than iOS 10.

3:46 PM Changeset in webkit [202399] by commit-queue@webkit.org

• 26 edits
  4 adds in trunk

requestFrameAnimation() callback timestamp should be very close to Performance.now()
​https://bugs.webkit.org/show_bug.cgi?id=159038

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2016-06-23
Reviewed by Simon Fraser.

Source/WebCore:

Pass the Performance.now() to requestFrameAnimation() callback. Do not add
the timeUntilOutput which is the difference between outputTime and now since
this addition makes us report a timestamp ahead in the future by almost 33ms.

A new function named "nowTimestamp()" is added to the DOMWindow class. It
calls Performance.now() if WEB_TIMING is enabled, otherwise it calls
monotonicallyIncreasingTime(). The returned timestamp is seconds and it is
relative to the document loading time.

The timestamp passing will be removed all the down till the callers of
ScriptedAnimationController::serviceScriptedAnimations(). The callers will
getting the now timestamp by calling DOMWindow::nowTimestamp().

Tests: animations/animation-callback-timestamp.html

animations/animation-multiple-callbacks-timestamp.html

• dom/Document.cpp:

(WebCore::Document::monotonicTimestamp):
(WebCore::Document::serviceScriptedAnimations):

• dom/Document.h:
• dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
(WebCore::ScriptedAnimationController::animationTimerFired):
(WebCore::ScriptedAnimationController::displayRefreshFired):

• dom/ScriptedAnimationController.h:
• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::getVideoPlaybackQuality):

• loader/DocumentLoadTiming.h:

(WebCore::DocumentLoadTiming::referenceWallTime):

• page/DOMWindow.cpp:

(WebCore::DOMWindow::nowTimestamp):

• page/DOMWindow.h:
• page/FrameView.cpp:

(WebCore::FrameView::serviceScriptedAnimations):

• page/FrameView.h:
• platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::displayDidRefresh):

• platform/graphics/DisplayRefreshMonitor.h:

(WebCore::DisplayRefreshMonitor::setMonotonicAnimationStartTime): Deleted.

• platform/graphics/DisplayRefreshMonitorClient.cpp:

(WebCore::DisplayRefreshMonitorClient::fireDisplayRefreshIfNeeded):

• platform/graphics/DisplayRefreshMonitorClient.h:
• platform/graphics/GraphicsLayerUpdater.cpp:

(WebCore::GraphicsLayerUpdater::displayRefreshFired):

• platform/graphics/GraphicsLayerUpdater.h:
• platform/graphics/ios/DisplayRefreshMonitorIOS.h:
• platform/graphics/ios/DisplayRefreshMonitorIOS.mm:

(-[WebDisplayLinkHandler handleDisplayLink:]):
(WebCore::DisplayRefreshMonitorIOS::displayLinkFired):
(WebCore::mediaTimeToCurrentTime): Deleted.

• platform/graphics/mac/DisplayRefreshMonitorMac.cpp:

(WebCore::displayLinkCallback):
(WebCore::DisplayRefreshMonitorMac::displayLinkFired):

• platform/graphics/mac/DisplayRefreshMonitorMac.h:
• platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:

(WebCore::CompositingCoordinator::syncDisplayState):
(WebCore::CompositingCoordinator::nextAnimationServiceTime):

Source/WebKit2:

• WebProcess/WebPage/Cocoa/RemoteLayerTreeDisplayRefreshMonitor.mm:

(WebKit::RemoteLayerTreeDisplayRefreshMonitor::didUpdateLayers):

LayoutTests:

• animations/animation-callback-timestamp-expected.txt: Added.
• animations/animation-callback-timestamp.html: Added.
• animations/animation-multiple-callbacks-timestamp-expected.txt: Added.
• animations/animation-multiple-callbacks-timestamp.html: Added.

2:28 PM Changeset in webkit [202398] by ddkilzer@apple.com

• 1 edit
  1 delete in trunk/Source/WebCore

Remove unused HarfBuzzFaceCoreText.cpp
<​https://webkit.org/b/159065>

Reviewed by Myles C. Maxfield.

• platform/graphics/harfbuzz/HarfBuzzFaceCoreText.cpp: Removed.

1:55 PM Changeset in webkit [202397] by fpizlo@apple.com

• 7 edits in trunk/Source/JavaScriptCore

Failing baseline JIT compilation of a code block and then trying to compile it from OSR from DFG/FTL will corrupt the CodeBlock
​https://bugs.webkit.org/show_bug.cgi?id=158806

Reviewed by Saam Barati.

If we try to compile a CodeBlock that we already tried compiling in the past then we need
to clean up the data structures that were partly filled in by the failed compile. That
causes some races, since the DFG may be trying to parse those data structures while we are
clearing them. This patch introduces such a clean-up (CodeBlock::resetJITData()) and fixes
the races.

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::getStubInfoMap):
(JSC::CodeBlock::getCallLinkInfoMap):
(JSC::CodeBlock::getByValInfoMap):
(JSC::CodeBlock::getCallLinkInfoForBytecodeIndex):
(JSC::CodeBlock::resetJITData):
(JSC::CodeBlock::visitOSRExitTargets):
(JSC::CodeBlock::setSteppingMode):
(JSC::CodeBlock::addRareCaseProfile):
(JSC::CodeBlock::rareCaseProfileForBytecodeOffset):
(JSC::CodeBlock::rareCaseProfileCountForBytecodeOffset):
(JSC::CodeBlock::resultProfileForBytecodeOffset):
(JSC::CodeBlock::specialFastCaseProfileCountForBytecodeOffset):
(JSC::CodeBlock::couldTakeSpecialFastCase):
(JSC::CodeBlock::ensureResultProfile):

• bytecode/CodeBlock.h:

(JSC::CodeBlock::getFromAllValueProfiles):
(JSC::CodeBlock::numberOfRareCaseProfiles):
(JSC::CodeBlock::numberOfResultProfiles):
(JSC::CodeBlock::numberOfArrayProfiles):
(JSC::CodeBlock::arrayProfiles):
(JSC::CodeBlock::addRareCaseProfile): Deleted.
(JSC::CodeBlock::specialFastCaseProfileCountForBytecodeOffset): Deleted.
(JSC::CodeBlock::couldTakeSpecialFastCase): Deleted.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::makeSafe):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::methodOfGettingAValueProfileFor):

• jit/JIT.cpp:

(JSC::JIT::link):

• jit/JITWorklist.cpp:

(JSC::JITWorklist::compileNow):

1:21 PM Changeset in webkit [202396] by bshafiei@apple.com

• 2 edits in branches/safari-602.1.38-branch/Source/WebKit2

Merged r202393. rdar://problem/17665473

1:16 PM Changeset in webkit [202395] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Land test expectations for rdar://problem/26952627.

Unreviewed test gardening.

• platform/mac/TestExpectations:

1:05 PM Changeset in webkit [202394] by commit-queue@webkit.org

• 21 edits in trunk/Source

Web Inspector: Memory Timeline sometimes shows impossible value for bmalloc size (underflowed)
​https://bugs.webkit.org/show_bug.cgi?id=158110
<rdar://problem/26498584>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-23
Reviewed by Andreas Kling.

Source/JavaScriptCore:

• heap/Heap.cpp:

(JSC::Heap::willStartCollection):
(JSC::Heap::didFinishCollection):

• heap/Heap.h:

(JSC::Heap::externalMemorySize):

• heap/HeapInlines.h:

(JSC::Heap::reportExternalMemoryVisited):
Keep count of external memory we visit.

• heap/SlotVisitor.h:
• heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::reportExternalMemoryVisited):
Report external memory visited like we do extra memory, since
it will be some subset of extra memory that is external.

Source/WebCore:

IOSurface memory backing Canvas element buffers should be classified as "GC Owned",
but should not be considered a part of bmalloc. In fact, the actual memory cost is
external to the Web Content Process. The majority of extra memory reporters tend
to report extra memory that is also allocated in bmalloc. However, some report
non-bmalloc memory, such as the IOSurfaces here.

Continue to report the memory cost without changes to inform the Heap for garbage
collection. However, also keep better accounting of GCOwned memory that is external
to the process for better accounting for the Resource Usage overlay and Web Inspector
Memory timeline.

This is a bit of a game where we want to display the best possible number for
"GCOwned memory" in the tools, but some of that memory shows up in the other
regions (bmalloc, system malloc, etc). Already many sizes are estimates
(ReportExtraMemory, reportExtraMemory ignores small allocations), so we just focus
on getting the largest sources of allocations, such as Canvas IOSurfaces here,
into the right bucket. ResourceUsageThreadCocoa continues to subtract the "extra"
memory from bmalloc. So, we should address other large sources of "extra memory"
not in bmalloc. A likely candidate is HTMLMediaElement which uses the deprecated
reporting right now.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

• bindings/scripts/IDLAttributes.txt:

Add a way to report External memory, dependent on reporting Extra memory.

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::externalMemoryCost):

• html/HTMLCanvasElement.h:
• html/HTMLCanvasElement.idl:

Report external memory cost just like extra memory.

• page/ResourceUsageData.cpp:

(WebCore::ResourceUsageData::ResourceUsageData):

• page/ResourceUsageData.h:

(WebCore::MemoryCategoryInfo::totalSize):

• page/cocoa/ResourceUsageOverlayCocoa.mm:

(WebCore::RingBuffer::at):
(WebCore::appendDataToHistory):
(WebCore::ResourceUsageOverlay::platformDraw):

• page/cocoa/ResourceUsageThreadCocoa.mm:

(WebCore::categoryForVMTag):
(WebCore::ResourceUsageThread::platformThreadBody):
Do not count the GCOwned External memory as dirty memory.
Include External memory output in the overlay.

• inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::collectSample):
When sizing the JavaScript portion, include both the GC Owned
category's dirty and external memory. Ultimately we will
want this everywhere in case things change.

• platform/graphics/ImageBuffer.cpp:

(WebCore::memoryCost):
(WebCore::externalMemoryCost):

• platform/graphics/ImageBuffer.h:
• platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::memoryCost):
(WebCore::ImageBuffer::externalMemoryCost):
Report IOSurface total bytes as extra memory and external memory
so that it can be tracked as GC Owned memory that is separate from
regular (bmalloc/other) in process memory.

12:58 PM Changeset in webkit [202393] by Chris Dumez

• 2 edits in trunk/Source/WebKit2

[iOS] A WebPageProxy in closed state should not be allowed to hold a process assertion
​https://bugs.webkit.org/show_bug.cgi?id=159068
<rdar://problem/17665473>

Reviewed by Tim Horton.

A WebPageProxy in closed state should not be allowed to hold a process assertion. It
currently happens that WebPageProxy::close() gets called but that the WebPageProxy is
kept alive by Safari (e.g. In case of top-hit preloading). In such cases, we fail to
release the foreground process assertion that the WebPageProxy holds.

We should clear the foreground process assertion that the WebPageProxy holds as soon
as WebPageProxy::close() is called.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):

12:24 PM Changeset in webkit [202392] by Konstantin Tokarev

• 3 edits in trunk/Tools

[jhbuild] Added libxslt module.
​https://bugs.webkit.org/show_bug.cgi?id=159034

Unreviewed, followup for r202373.

• efl/install-dependencies: Removed libxslt
• gtk/install-dependencies: Ditto.

12:20 PM Changeset in webkit [202391] by bshafiei@apple.com

• 12 edits in branches/safari-602.1.38-branch/Source

Merge patch for rdar://problem/26831566.

12:17 PM Changeset in webkit [202390] by ap@apple.com

• 4 edits in trunk

Handle (0, 0) ranges from Lookup
​https://bugs.webkit.org/show_bug.cgi?id=159062
rdar://problem/26960385

Reviewed by Tim Horton.

Source/WebCore:

• editing/mac/DictionaryLookup.mm: (WebCore::DictionaryLookup::rangeAtHitTestResult):

Paper over <​https://bugs.webkit.org/show_bug.cgi?id=159063>, which seems too involved
to fix now.

LayoutTests:

• platform/mac/TestExpectations: Unmark the test that was broken due to this.

12:16 PM Changeset in webkit [202389] by Brent Fulgham

• 3 edits in trunk/Source/WebKit2

[OS X][WK2] Expand sandbox for new mach endpoints
​https://bugs.webkit.org/show_bug.cgi?id=159040
<rdar://problem/25238336>

Reviewed by Alexey Proskuryakov.

Grant the WebContent and Networking processes the mach lookup capability for
various Security-related mach endpoints..

• NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
• WebProcess/com.apple.WebProcess.sb.in:

12:12 PM Changeset in webkit [202388] by bshafiei@apple.com

• 5 edits in branches/safari-602.1.38-branch/Source

Versioning.

12:11 PM Changeset in webkit [202387] by bshafiei@apple.com

• 5 edits in branches/safari-602.1.38-branch/Source

Versioning.

12:07 PM Changeset in webkit [202386] by bshafiei@apple.com

• 1 copy in branches/safari-602.1.38-branch

New Branch.

12:07 PM Changeset in webkit [202385] by bshafiei@apple.com

• 1 copy in tags/Safari-602.1.38

New tag.

11:52 AM Changeset in webkit [202384] by Joseph Pecoraro

• 12 edits in trunk/Source

Web Inspector: first heap snapshot taken when a page is reloaded happens before the reload navigation
​https://bugs.webkit.org/show_bug.cgi?id=158995
<rdar://problem/26923778>

Reviewed by Brian Burg.

Source/WebCore:

When the "Heap" instrument is included in the Timeline list
of instruments, defer starting it in an auto-capture scenario
until after the page does its first navigation.

AutoCapture on the backend happens when it is enabled at
the main resource starts loading. In that case it proceeds
through the following phases:

No Auto Capture:

None

Auto Capture:

BeforeLoad -> FirstNavigation -> AfterFirstNavigation

When toggling instruments for backend initiated capture
most instruments do not care and will just start/stop.

• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didCommitLoadImpl):
Inform the TimelineAgent that the main frame navigated.
Do this after informing the HeapAgent (so any potential
snapshot does not get cleared) and PageAgent (so the
frontend knows the page navigated before the agent starts).

• inspector/InspectorTimelineAgent.h:
• inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::internalStop):
(WebCore::InspectorTimelineAgent::mainFrameStartedLoading):
(WebCore::InspectorTimelineAgent::mainFrameNavigated):
Update the auto capture phase transitions.

(WebCore::InspectorTimelineAgent::toggleHeapInstrument):
Only start the heap agent during the None phase (console.profile)
or with the first navigation (auto capture page navigation).

Source/WebInspectorUI:

Let instruments decide to do work or not based on programmatic
(backend initiated) starts and stop.

Programmatic start can happen due to Auto Capture or console.profile.
Programmatic stop can happen due to console.profileEnd.

For example, this allows the frontend to avoid sending agents start/stop
messages when the backend would have already started/stopped the agents.

• UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager):
(WebInspector.TimelineManager.prototype.startCapturing):
(WebInspector.TimelineManager.prototype.capturingStopped):
(WebInspector.TimelineManager.prototype.autoCaptureStarted):
(WebInspector.TimelineManager.prototype.programmaticCaptureStarted):
Call Recording.start/stop with a programmatic flag so the frontend
instruments can perform a more informed start/stop.

• UserInterface/Models/TimelineRecording.js:

(WebInspector.TimelineRecording.prototype.start):
(WebInspector.TimelineRecording.prototype.stop):
Let the instruments decide to do work based on the start/stop
being initiated by the backend or not.

• UserInterface/Models/HeapAllocationsInstrument.js:

(WebInspector.HeapAllocationsInstrument.prototype.startInstrumentation):
(WebInspector.HeapAllocationsInstrument.prototype.stopInstrumentation):

• UserInterface/Models/Instrument.js:

(WebInspector.Instrument.startLegacyTimelineAgent):
(WebInspector.Instrument.prototype.startInstrumentation):
(WebInspector.Instrument.prototype.stopInstrumentation):
(WebInspector.Instrument):

• UserInterface/Models/MemoryInstrument.js:

(WebInspector.MemoryInstrument.prototype.startInstrumentation):
(WebInspector.MemoryInstrument.prototype.stopInstrumentation):
(WebInspector.MemoryInstrument):

• UserInterface/Models/NetworkInstrument.js:
• UserInterface/Models/ScriptInstrument.js:

(WebInspector.ScriptInstrument.prototype.startInstrumentation):
(WebInspector.ScriptInstrument.prototype.stopInstrumentation):
(WebInspector.ScriptInstrument):
Avoid sending start/stop tracking messages when programmatic.
This still allows the instruments to do their own frontend tracking,
such as the Heap agent triggering periodic snapshots.

11:52 AM Changeset in webkit [202383] by Joseph Pecoraro

• 24 edits
  3 copies in trunk/Source

Web Inspector: Snapshots should be cleared at some point
​https://bugs.webkit.org/show_bug.cgi?id=157907
<rdar://problem/26373610>

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

• heap/HeapSnapshotBuilder.h:
• heap/HeapSnapshotBuilder.cpp:

(JSC::HeapSnapshotBuilder::resetNextAvailableObjectIdentifier):
Provide a way to reset the object identifier counter.

• inspector/agents/InspectorHeapAgent.h:
• inspector/agents/InspectorHeapAgent.cpp:

(Inspector::InspectorHeapAgent::clearHeapSnapshots):
Make clearHeapSnapshots protected, so it can be called from a
a PageHeapAgent on page navigations.

Source/WebCore:

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:
• inspector/InspectorAllInOne.cpp:

New specialized agent.

• inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
Construct a specialized HeapAgent.

• inspector/PageHeapAgent.h:
• inspector/PageHeapAgent.cpp:

(WebCore::PageHeapAgent::PageHeapAgent):
(WebCore::PageHeapAgent::enable):
(WebCore::PageHeapAgent::disable):
(WebCore::PageHeapAgent::mainFrameNavigated):
Clear backend snapshots on page navigations.
Set the PageHeapAgent instrumenting agent on enable/disable.

• inspector/InstrumentingAgents.cpp:

(WebCore::InstrumentingAgents::reset):

• inspector/InstrumentingAgents.h:

(WebCore::InstrumentingAgents::pageHeapAgent):
(WebCore::InstrumentingAgents::setPageHeapAgent):
Active PageHeapAgent.

• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didCommitLoadImpl):
Inform the PageHeapAgent when the mainframe navigates.

Source/WebInspectorUI:

Invalidate HeapSnapshotProxy objects when the page navigates.
This allows us to clear our frontend data for the snapshots.
When a snapshot is invalidated, it is disabled in the UI.
This means you cannot select the snapshot or see content
views for the snapshot. If you are in a snapshot when it is
invalidated, you are taken out to the snapshot list.

• UserInterface/Main.html:

New files.

• UserInterface/Proxies/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotProxy):
(WebInspector.HeapSnapshotProxy.invalidateSnapshotProxies):
(WebInspector.HeapSnapshotProxy.prototype.get invalid):
(WebInspector.HeapSnapshotProxy.prototype._invalidate):
Keep track of valid snapshots, and provide a static method to invalidate them.

(WebInspector.HeapSnapshotProxy.prototype.updateForCollectionEvent):
(WebInspector.HeapSnapshotProxy.prototype.allocationBucketCounts):
(WebInspector.HeapSnapshotProxy.prototype.instancesWithClassName):
(WebInspector.HeapSnapshotProxy.prototype.update):
(WebInspector.HeapSnapshotProxy.prototype.nodeWithIdentifier):
UI should only act on valid snapshots.

• UserInterface/Proxies/HeapSnapshotDiffProxy.js:

(WebInspector.HeapSnapshotDiffProxy.prototype.get invalid):
(WebInspector.HeapSnapshotDiffProxy.prototype.updateForCollectionEvent):
(WebInspector.HeapSnapshotDiffProxy.prototype.allocationBucketCounts):
(WebInspector.HeapSnapshotDiffProxy.prototype.instancesWithClassName):
(WebInspector.HeapSnapshotDiffProxy.prototype.update):
(WebInspector.HeapSnapshotDiffProxy.prototype.nodeWithIdentifier):
UI should only act on valid snapshots.

• UserInterface/Proxies/HeapSnapshotWorkerProxy.js:

(WebInspector.HeapSnapshotWorkerProxy.prototype._mainResourceDidChange):
Invalidate and discard snapshots when the main frame navigates.

(WebInspector.HeapSnapshotWorkerProxy.prototype._handleMessage):
(WebInspector.HeapSnapshotWorkerProxy):

• UserInterface/Workers/HeapSnapshot/HeapSnapshotWorker.js:

(HeapSnapshotWorker.prototype.clearSnapshots):
(HeapSnapshotWorker.prototype._handleMessage):
(HeapSnapshotWorker):
A message may come in for a snapshot before it has been cleared.
If that is the case, the object may not exist. Return an error so
that the callback can be deleted on the calling side.

• UserInterface/Views/HeapAllocationsTimelineDataGridNodePathComponent.js:

(WebInspector.HeapAllocationsTimelineDataGridNodePathComponent.prototype.get previousSibling):
(WebInspector.HeapAllocationsTimelineDataGridNodePathComponent.prototype.get nextSibling):
(WebInspector.HeapAllocationsTimelineDataGridNodePathComponent):
Don't show invalid snapshots in page component picker.

• UserInterface/Views/HeapAllocationsTimelineOverviewGraph.css:

(.timeline-overview-graph.heap-allocations > img.snapshot.invalid):

• UserInterface/Views/HeapAllocationsTimelineDataGridNode.js:

(WebInspector.HeapAllocationsTimelineDataGridNode):
(WebInspector.HeapAllocationsTimelineDataGridNode.prototype.createCellContent):
(WebInspector.HeapAllocationsTimelineDataGridNode.prototype.createCells):
(WebInspector.HeapAllocationsTimelineDataGridNode.prototype._heapSnapshotInvalidated):
Give invalid snapshots an invalidated appearance in the snapshot list.

• UserInterface/Views/HeapAllocationsTimelineOverviewGraph.js:

(WebInspector.HeapAllocationsTimelineOverviewGraph.prototype.layout):

• UserInterface/Views/HeapAllocationsTimelineView.css:

(.timeline-view.heap-allocations > .data-grid tr.invalid):
(.timeline-view.heap-allocations > .data-grid:not(:focus, .force-focus) tr.selected.invalid):
Give invalid snapshots an invalidated appearance in the overview graph.

• UserInterface/Views/HeapAllocationsTimelineView.js:

(WebInspector.HeapAllocationsTimelineView):
(WebInspector.HeapAllocationsTimelineView.prototype.get selectionPathComponents):
(WebInspector.HeapAllocationsTimelineView.prototype.closed):
(WebInspector.HeapAllocationsTimelineView.prototype._heapSnapshotCollectionEvent.updateHeapSnapshotForEvent):
(WebInspector.HeapAllocationsTimelineView.prototype._heapSnapshotCollectionEvent):
(WebInspector.HeapAllocationsTimelineView.prototype._heapSnapshotInvalidated):
(WebInspector.HeapAllocationsTimelineView.prototype._updateCompareHeapSnapshotButton):
(WebInspector.HeapAllocationsTimelineView.prototype._dataGridNodeSelected):
Handle interactions when snapshots in the list are invalidated.

11:43 AM Changeset in webkit [202382] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

CSSComputedStyleDeclaration::length should recalculate styles if needed to provide the correct value
​https://bugs.webkit.org/show_bug.cgi?id=159053
<rdar://problem/26638119>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-06-23
Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/css/variables/custom-property-computed-style-length-update.html

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::length):

LayoutTests:

• fast/css/variables/custom-property-computed-style-length-update-expected.txt: Added.
• fast/css/variables/custom-property-computed-style-length-update.html: Added.

9:56 AM Changeset in webkit [202381] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit2

Unreviewed, rolling out r201194.
​https://bugs.webkit.org/show_bug.cgi?id=159059

Not needed for iOS (Requested by bfulgham on #webkit).

Reverted changeset:

"[OS X][WK2] Expand sandbox for new mach endpoints"
​https://bugs.webkit.org/show_bug.cgi?id=157919
​http://trac.webkit.org/changeset/201194

9:35 AM Changeset in webkit [202380] by wilander@apple.com

• 9 edits in trunk/Source

Source/WebCore:
Enable window.open() for existing versions of Secret Society
​https://bugs.webkit.org/show_bug.cgi?id=159049
<rdar://problem/26528349>

Reviewed by Andy Estes.

The Secret Society Hidden Mystery app has a broken version check treating iOS 10
as iOS 1 on iPads. Therefore it believes it can use window.open() in a tap
handler. We should allow the existing versions of the app to do this to not break
them.

No new tests. Tested manually in the app.

• page/DOMWindow.cpp:

(WebCore::DOMWindow::allowPopUp):

Now checks with Settings whether it should allow a popup even though it is
not processing a user gesture.

• page/Settings.in:

Added setting allowWindowOpenWithoutUserGesture.

• platform/RuntimeApplicationChecks.h:
• platform/RuntimeApplicationChecks.mm:

(WebCore::IOSApplication::isTheSecretSocietyHiddenMystery):

Added.

Source/WebKit/mac:
Enable window.open() for existing versions of Secret Society app
​https://bugs.webkit.org/show_bug.cgi?id=159049
<rdar://problem/26528349>

Reviewed by Andy Estes.

The Secret Society Hidden Mystery app has a broken version check treating iOS 10
as iOS 1 on iPads. Therefore it believes it can use window.open() in a tap
handler. We should allow the existing versions of the app to do this to not break
them.

• WebView/WebView.mm:

(shouldAllowWindowOpenWithoutUserGesture):

Added.

(shouldConvertInvalidURLsToBlank):

Changed hex number to constant DYLD_IOS_VERSION_10_0.

Source/WTF:
Enable window.open() for existing versions of Secret Society
​https://bugs.webkit.org/show_bug.cgi?id=159049
<rdar://problem/26528349>

Reviewed by Andy Estes.

The Secret Society Hidden Mystery app has a broken version check treating iOS 10
as iOS 1 on iPads. Therefore it believes it can use window.open() in a tap
handler. We should allow the existing versions of the app to do this to not break
them.

• wtf/spi/darwin/dyldSPI.h:

Added DYLD_IOS_VERSION_10_0.

9:03 AM Changeset in webkit [202379] by Chris Dumez

• 3 edits in trunk/Source/WebCore

Only call sqlite3_initialize() when a SQLite database is actually being opened
​https://bugs.webkit.org/show_bug.cgi?id=159033

Reviewed by Brady Eidson.

Only call sqlite3_initialize() when a SQLite database is actually being opened
instead of doing it unconditionally. sqlite3_initialize() was previously called
in the SQLiteDatabase constructor which gets called on WebContent process
initialization because a DatabaseTracker is constructed on initialization and
DatabaseTracker has a SQLiteDatabase data member.

• platform/sql/SQLiteDatabase.cpp:

(WebCore::initializeSQLiteIfNecessary):
(WebCore::SQLiteDatabase::open):
(WebCore::SQLiteDatabase::SQLiteDatabase): Deleted.

• platform/sql/SQLiteDatabase.h:

8:10 AM Changeset in webkit [202378] by adam.bergkvist@ericsson.com

• 2 edits in trunk/Source/WebCore

WebRTC: Align 'update ICE connection/gathering state' steps with the WebRTC 1.0 specification
​https://bugs.webkit.org/show_bug.cgi?id=159054

Reviewed by Eric Carlson.

Add checks for same state and closed RTCPeerConnection in the 'update ICE connection state'
and 'update ICE gathering state' routines as described in [1].

[1] ​https://w3c.github.io/webrtc-pc/archives/20160513/webrtc.html#update-ice-gathering-state

No change in current behavior.

• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::updateIceGatheringState):
(WebCore::RTCPeerConnection::updateIceConnectionState):

8:05 AM Changeset in webkit [202377] by commit-queue@webkit.org

• 2 edits
  2 adds in trunk/Tools

[EFL] Bump gstreamer version from 1.6.3 to 1.8.0
​https://bugs.webkit.org/show_bug.cgi?id=159050

Patch by Gyuyoung Kim <​gyuyoung.kim@samsung.com> on 2016-06-23
Reviewed by Antonio Gomes.

To be sync with GTK port, this patch bumps gstreamer version for EFL port.

• efl/jhbuild.modules:
• efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
• efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.

6:52 AM Changeset in webkit [202376] by adam.bergkvist@ericsson.com

• 12 edits
  2 adds in trunk

WebRTC: Add support for RTCPeerConnection legacy MediaStream-based API
​https://bugs.webkit.org/show_bug.cgi?id=158940

Reviewed by Eric Carlson.

Source/WebCore:

Implement the legacy MediaStream-based RTCPeerConnection API as JS built-ins. The
getRemoteStreams() function and the 'addstream' event are partly implemented with native
code.

Test: fast/mediastream/RTCPeerConnection-legacy-stream-based-api.html

• Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::MediaEndpointPeerConnection::setRemoteDescriptionTask):
(WebCore::MediaEndpointPeerConnection::getRemoteStreams):
The getRemoteStreams() function and the 'addstream' event is backed up by native code.

• Modules/mediastream/MediaEndpointPeerConnection.h:
• Modules/mediastream/MediaStream.idl:
• Modules/mediastream/PeerConnectionBackend.h:
• Modules/mediastream/RTCPeerConnection.h:
• Modules/mediastream/RTCPeerConnection.idl:
• Modules/mediastream/RTCPeerConnection.js:

(initializeRTCPeerConnection):
(getLocalStreams):
(getRemoteStreams):
(getStreamById):
(addStream):
(removeStream):
Legacy API implemented as JS built-ins.

• bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::addBuiltinGlobals):

• bindings/js/WebCoreBuiltinNames.h:

LayoutTests:

Add test for RTCPeerConnection legacy MediaStream-based API.

• fast/mediastream/RTCPeerConnection-legacy-stream-based-api-expected.txt: Added.
• fast/mediastream/RTCPeerConnection-legacy-stream-based-api.html: Added.
• platform/mac/TestExpectations:

Skip test for mac port (not building with WEB_RTC yet)

3:08 AM Changeset in webkit [202375] by pvollan@apple.com

• 2 edits in trunk/LayoutTests

Unreviewed test gardening.

Update test expectations for passing accessibility tests after r202149,
and fix style issues in test expectations file.

• platform/win/TestExpectations:

3:08 AM Changeset in webkit [202374] by Carlos Garcia Campos

• 1 copy in releases/WebKitGTK/webkit-2.13.2

WebKitGTK+ 2.13.2

2:51 AM Changeset in webkit [202373] by Konstantin Tokarev

• 3 edits in trunk/Tools

[jhbuild] Added libxslt module.
​https://bugs.webkit.org/show_bug.cgi?id=159034

Reviewed by Michael Catanzaro.

• efl/jhbuild.modules:
• gtk/jhbuild.modules:

2:16 AM Changeset in webkit [202372] by Carlos Garcia Campos

• 4 edits in trunk

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.13.2 release.

.:

• Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

• gtk/NEWS: Add release notes for 2.13.2.

1:50 AM Changeset in webkit [202371] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

Unreviewed. Fix the build with CSS Shapes disabled.

• css/StyleBuilderConverter.h:

12:23 AM Changeset in webkit [202370] by Carlos Garcia Campos

• 3 edits in trunk/Source/WebCore

[Soup] Clean up SocketStreamHandle soup implementation
​https://bugs.webkit.org/show_bug.cgi?id=159024

Reviewed by Žan Doberšek.

Stop using a global HashMap to "acivate"/"deactivate" handles, and just take a reference of the handle and
pass the ownership to the callbacks, using a GCancellable to cancel all async operations.

• platform/network/soup/SocketStreamHandle.h:

(WebCore::SocketStreamHandle::create):
(WebCore::SocketStreamHandle::id): Deleted.

• platform/network/soup/SocketStreamHandleSoup.cpp:

(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore::SocketStreamHandle::connected):
(WebCore::SocketStreamHandle::connectedCallback):
(WebCore::SocketStreamHandle::readBytes):
(WebCore::SocketStreamHandle::readReadyCallback):
(WebCore::SocketStreamHandle::didFail):
(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):
(WebCore::SocketStreamHandle::beginWaitingForSocketWritability):
(WebCore::SocketStreamHandle::writeReadyCallback):
(WebCore::getHandleFromId): Deleted.
(WebCore::deactivateHandle): Deleted.
(WebCore::activateHandle): Deleted.
(WebCore::SocketStreamHandle::~SocketStreamHandle): Deleted.
(WebCore::connectedCallback): Deleted.
(WebCore::readReadyCallback): Deleted.
(WebCore::writeReadyCallback): Deleted.

Jun 22, 2016:

11:44 PM Changeset in webkit [202369] by pvollan@apple.com

• 3 edits in trunk/Tools

[Win] Use Windows api function to find top level parent.
​https://bugs.webkit.org/show_bug.cgi?id=159021

Reviewed by Brent Fulgham.

Delete findTopLevelParent function, and use Win32 function GetAncestor instead.

• DumpRenderTree/win/UIDelegate.cpp:

(UIDelegate::runModal):
(findTopLevelParent): Deleted.

• MiniBrowser/win/PrintWebUIDelegate.cpp:

(PrintWebUIDelegate::runModal):
(findTopLevelParent): Deleted.

11:33 PM Changeset in webkit [202368] by pvollan@apple.com

• 6 edits in trunk

[Win] The test storage/indexeddb/modern/handle-user-delete.html is timing out.
​https://bugs.webkit.org/show_bug.cgi?id=158934

Reviewed by Brent Fulgham.

Source/WebKit/win:

Add a method to delete all indexed databases.

• Interfaces/IWebDatabaseManager.idl:
• WebDatabaseManager.cpp:

(WebDatabaseManager::QueryInterface):
(WebDatabaseManager::deleteAllIndexedDatabases):

• WebDatabaseManager.h:

Tools:

DumpRenderTree should also delete indexed databases when clearAllDatabases() is called.

• DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::clearAllDatabases):

11:10 PM Changeset in webkit [202367] by Carlos Garcia Campos

• 3 edits in trunk/Source/WebKit2

REGRESSION(r201880): WebSockets based remote inspector is broken since r201880
​https://bugs.webkit.org/show_bug.cgi?id=158613

Reviewed by Michael Catanzaro.

In r201880 SocketStreamHandleClient was modified to receive references instead of
pointers. WebSocketServerConnection also implements SocketStreamHandleClient but since it's doesn't use
override, it was unnoticed and not updated, so we ended up using the default empty implementation instead of
the WebSocketServerConnection one.

• UIProcess/InspectorServer/WebSocketServerConnection.cpp:

(WebKit::WebSocketServerConnection::WebSocketServerConnection):
(WebKit::WebSocketServerConnection::setSocketHandle):
(WebKit::WebSocketServerConnection::shutdownNow):
(WebKit::WebSocketServerConnection::didCloseSocketStream):
(WebKit::WebSocketServerConnection::didReceiveSocketStreamData):
(WebKit::WebSocketServerConnection::didUpdateBufferedAmount):
(WebKit::WebSocketServerConnection::didFailSocketStream): Deleted.

• UIProcess/InspectorServer/WebSocketServerConnection.h:

10:46 PM Changeset in webkit [202366] by sbarati@apple.com

• 2 edits in trunk/Tools

run-javascriptcore-tests should have some environment variables for commonly used settings
​https://bugs.webkit.org/show_bug.cgi?id=159047

Reviewed by Keith Miller.

This patch adds three environment variables that run-javascriptcore-tests
consults:

• RUN_JAVASCRIPTCORE_TESTS_TESTAPI can be set to 'true' or 'false'. It determines if we should run the api tests or not.
• RUN_JAVASCRIPTCORE_TESTS_BUILD can be set to 'true' or 'false'. It determines if we will perform a build or not before running the tests. to set the default should-build setting.
• RUN_JAVASCRIPTCORE_TESTS_EXTRA_TESTS can be set to a directory or to a yaml file. If set, we will run the extra tests it refers to.

All the values in these environment variables will be overridden if an
option is explicitly passed in. For example, the following will run
the api tests:
RUN_JAVASCRIPTCORE_TESTS_TESTAPI=false run-javascriptcore-tests --testapi

• Scripts/run-javascriptcore-tests:

9:01 PM Changeset in webkit [202365] by Brent Fulgham

• 2 edits in trunk/Source/WebKit2

[iOS][WK2] Expand sandbox to read voice services preferences
​https://bugs.webkit.org/show_bug.cgi?id=159046
<rdar://problem/26926722>

Reviewed by Alexey Proskuryakov.

Expand the sandbox to permit read-only access to voice services preferences.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

8:24 PM Changeset in webkit [202364] by sbarati@apple.com

• 9 edits
  2 adds in trunk

TypeProfiler and TypeProfilerLog don't play nicely with the concurrent JIT
​https://bugs.webkit.org/show_bug.cgi?id=159037
<rdar://problem/26935349>

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

The primary focus of this patch is to make the concurrent
baseline JIT work with the type profiler. We were clearing
the type profiler log on the background baseline compiler
thread which lead to bad things happening. This patch fixes
this by processing the log before we launch the compile on
a background thread.

Secondly, I audited the type profiler code inside the DFG,
and found that we were doing some racy things. I haven't
seen any crashes because of these things, but it is possible
that they exist. We were grabbing a RefPtr to a TypeSet,
even though TypeSet was RefCounted and not ThreadSafeRefCounted.
This patch makes TypeSet ThreadSafeRefCounted. We were
also copying a StructureSet while the execution thread could
be augmenting the StructureSet. This patch puts changes to
TypeSet's StructureSet behind a ConcurrentJITLock.

I've also added two more large running tests that run with the
type profiler enabled. These are here just to catch any major bugs
in the type profiler implementation.

• jit/JIT.cpp:

(JSC::JIT::compileWithoutLinking):
(JSC::JIT::privateCompile):
(JSC::JIT::privateCompileExceptionHandlers):
(JSC::JIT::doMainThreadPreparationBeforeCompile):
(JSC::JIT::frameRegisterCountFor):

• jit/JIT.h:

(JSC::JIT::compile):

• jit/JITWorklist.cpp:

(JSC::JITWorklist::Plan::Plan):
(JSC::JITWorklist::Plan::compileInThread):

• runtime/TypeSet.cpp:

(JSC::TypeSet::addTypeInformation):
(JSC::TypeSet::invalidateCache):

• runtime/TypeSet.h:

(JSC::TypeSet::create):
(JSC::TypeSet::isEmpty):
(JSC::TypeSet::seenTypes):
(JSC::TypeSet::structureSet):

• tests/typeProfiler/deltablue-for-of.js: Added.
• tests/typeProfiler/getter-richards.js: Added.

Tools:

Run typeProfiler.yaml tests under an additional CJIT enabled mode.

• Scripts/run-jsc-stress-tests:

6:39 PM Changeset in webkit [202363] by keith_miller@apple.com

• 20 edits
  1 add in trunk/Source/JavaScriptCore

We should have a DFG intrinsic that checks if a value is a TypedArrayView
​https://bugs.webkit.org/show_bug.cgi?id=159048

Reviewed by Saam Barati.

This patch adds a new DFG Intrinsic that checks if a value is a TypedArrayView.
The intrinsic, IsTypedArrayView, works in the same way that the other Is<insert-type>
DFG nodes work. Additionally, a new builtin function isTypedArrayView has been added.
These changes are needed to fix regressions in %TypedArray%.prototype.subarray.

• builtins/BuiltinNames.h:
• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicCall):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGNodeType.h:
• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileIsTypedArrayView):

• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileIsTypedArrayView):
(JSC::FTL::DFG::LowerDFGToB3::isTypedArrayView):

• runtime/Intrinsic.h:
• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

• runtime/JSTypedArrayViewPrototype.cpp:

(JSC::typedArrayViewPrivateFuncIsTypedArrayView):

• runtime/JSTypedArrayViewPrototype.h:
• tests/stress/istypedarrayview-intrinsic.js: Added.

(makeFn):
(typedArrays.forEach):
(let.test):
(test):

6:13 PM Changeset in webkit [202362] by aakash_jain@apple.com

• 88 edits in trunk/Tools

Fix style issues in webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=159019

Reviewed by Daniel Bates.

Fixed the formatting issues as reported by check-webkit-style in webkitpy.
There is no functionality change.
Only affected file names retained below for brevity.

• Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
• Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
• Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
• Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
• Scripts/webkitpy/benchmark_runner/utils.py:
• Scripts/webkitpy/common/checkout/changelog.py:
• Scripts/webkitpy/common/checkout/changelog_unittest.py:
• Scripts/webkitpy/common/checkout/checkout.py:
• Scripts/webkitpy/common/checkout/checkout_mock.py:
• Scripts/webkitpy/common/checkout/checkout_unittest.py:
• Scripts/webkitpy/common/checkout/commitinfo.py:
• Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
• Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
• Scripts/webkitpy/common/checkout/scm/scm.py:
• Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
• Scripts/webkitpy/common/config/committers_unittest.py:
• Scripts/webkitpy/common/config/irc.py:
• Scripts/webkitpy/common/config/ports.py:
• Scripts/webkitpy/common/config/ports_unittest.py:
• Scripts/webkitpy/common/config/urls.py:
• Scripts/webkitpy/common/host_mock.py:
• Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
• Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
• Scripts/webkitpy/common/net/buildbot/buildbot.py:
• Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
• Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
• Scripts/webkitpy/common/net/credentials_unittest.py:
• Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
• Scripts/webkitpy/common/net/networktransaction_unittest.py:
• Scripts/webkitpy/common/net/statusserver.py:
• Scripts/webkitpy/common/system/autoinstall.py:
• Scripts/webkitpy/common/system/crashlogs_unittest.py:
• Scripts/webkitpy/common/system/executive.py:
• Scripts/webkitpy/common/system/executive_mock.py:
• Scripts/webkitpy/common/system/executive_unittest.py:
• Scripts/webkitpy/common/system/filesystem_mock.py:
• Scripts/webkitpy/common/system/filesystem_unittest.py:
• Scripts/webkitpy/common/system/logutils_unittest.py:
• Scripts/webkitpy/common/system/path.py:
• Scripts/webkitpy/common/system/path_unittest.py:
• Scripts/webkitpy/common/system/platforminfo.py:
• Scripts/webkitpy/common/system/user.py:
• Scripts/webkitpy/common/system/user_unittest.py:
• Scripts/webkitpy/common/system/workspace_unittest.py:
• Scripts/webkitpy/common/thread/threadedmessagequeue.py:
• Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
• Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
• Scripts/webkitpy/layout_tests/controllers/manager.py:
• Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
• Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
• Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
• Scripts/webkitpy/layout_tests/models/test_configuration.py:
• Scripts/webkitpy/layout_tests/models/test_expectations.py:
• Scripts/webkitpy/layout_tests/models/test_failures.py:
• Scripts/webkitpy/layout_tests/models/test_run_results.py:
• Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
• Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
• Scripts/webkitpy/layout_tests/views/printing.py:
• Scripts/webkitpy/performance_tests/perftestsrunner.py:
• Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
• Scripts/webkitpy/port/base_unittest.py:
• Scripts/webkitpy/port/driver.py:
• Scripts/webkitpy/port/driver_unittest.py:
• Scripts/webkitpy/port/factory.py:
• Scripts/webkitpy/port/gtk.py:
• Scripts/webkitpy/port/server_process_unittest.py:
• Scripts/webkitpy/port/test.py:
• Scripts/webkitpy/port/win.py:
• Scripts/webkitpy/style/checker.py:
• Scripts/webkitpy/style/checkers/common_unittest.py:
• Scripts/webkitpy/style/checkers/cpp.py:
• Scripts/webkitpy/style/checkers/cpp_unittest.py:
• Scripts/webkitpy/style/checkers/js.py:
• Scripts/webkitpy/style/checkers/jsonchecker.py:
• Scripts/webkitpy/style/checkers/png.py:
• Scripts/webkitpy/style/checkers/text.py:
• Scripts/webkitpy/style/checkers/text_unittest.py:
• Scripts/webkitpy/style/error_handlers.py:
• Scripts/webkitpy/style/filter.py:
• Scripts/webkitpy/style/filter_unittest.py:
• Scripts/webkitpy/style/optparser.py:
• Scripts/webkitpy/style/optparser_unittest.py:
• Scripts/webkitpy/test/main.py:
• Scripts/webkitpy/w3c/test_converter.py:
• Scripts/webkitpy/w3c/test_converter_unittest.py:
• Scripts/webkitpy/w3c/test_importer_unittest.py:
• Scripts/webkitpy/xcode/simulator.py:

5:19 PM Changeset in webkit [202361] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebKit2

Add SPI to allow creating a WKCertificateInfoRef from a SecTrustRef
​https://bugs.webkit.org/show_bug.cgi?id=159025

Patch by Sam Weinig <​sam@webkit.org> on 2016-06-22
Reviewed by Tim Horton.

• Shared/API/c/mac/WKCertificateInfoMac.h:
• Shared/API/c/mac/WKCertificateInfoMac.mm:

(WKCertificateInfoCreateWithServerTrust):

5:14 PM Changeset in webkit [202360] by ap@apple.com

• 2 edits in trunk/LayoutTests

Test expectations gardening for rdar://problem/26960385

• platform/mac/TestExpectations:

4:46 PM Changeset in webkit [202359] by beidson@apple.com

• 12 edits
  1 add in trunk

DatabaseProcess doesn't handle WebProcesses going away uncleanly.
​https://bugs.webkit.org/show_bug.cgi?id=158894

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (Covered by additions to existing API test).

• Modules/indexeddb/server/IDBConnectionToClient.cpp:

(WebCore::IDBServer::IDBConnectionToClient::registerDatabaseConnection):
(WebCore::IDBServer::IDBConnectionToClient::unregisterDatabaseConnection):
(WebCore::IDBServer::IDBConnectionToClient::connectionToClientClosed):

• Modules/indexeddb/server/IDBConnectionToClient.h:

• Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::unregisterConnection): Call connectionToClientClosed() on

the connection, which cleans up after it in the server.

• Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:

(WebCore::IDBServer::UniqueIDBDatabaseConnection::UniqueIDBDatabaseConnection):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::~UniqueIDBDatabaseConnection):

Source/WebKit2:

• DatabaseProcess/DatabaseToWebProcessConnection.cpp:

(WebKit::DatabaseToWebProcessConnection::didClose):

• DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp:

(WebKit::WebIDBConnectionToClient::disconnectedFromWebProcess): Actually unregister this connection

from the IDBServer so it can clean up.

(WebKit::WebIDBConnectionToClient::~WebIDBConnectionToClient):

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html:
• TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-3.html: Added.
• TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:

4:35 PM Changeset in webkit [202358] by commit-queue@webkit.org

• 21 edits
  12 adds in trunk

AX: Add support for CSS4 :focus-within pseudo
​https://bugs.webkit.org/show_bug.cgi?id=140144

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-06-22
Reviewed by Antti Koivisto.

Source/WebCore:

Tests: fast/css/pseudo-focus-within-basics.html

fast/css/pseudo-focus-within-inside-shadow-dom.html
fast/css/pseudo-focus-within-style-sharing-1.html
fast/css/pseudo-focus-within-style-sharing-2.html
fast/selectors/focus-within-style-update.html

• css/CSSSelector.cpp:

(WebCore::CSSSelector::selectorText):

• css/CSSSelector.h:
• css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

• css/SelectorPseudoClassAndCompatibilityElementMap.in:
• cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementHasFocusWithin):

• dom/ContainerNode.cpp:

(WebCore::destroyRenderTreeIfNeeded):

• dom/Element.cpp:

(WebCore::Element::~Element):
(WebCore::Element::setFocus):
(WebCore::Element::unregisterNamedFlowContentElement):
(WebCore::Element::setIsNamedFlowContentElement):
(WebCore::Element::clearIsNamedFlowContentElement):
(WebCore::Element::setStyleAffectedByFocusWithin):
(WebCore::Element::rareDataStyleAffectedByFocusWithin):
(WebCore::Element::rareDataIsNamedFlowContentElement):

• dom/Element.h:

(WebCore::Element::hasFocusWithin):
(WebCore::Element::styleAffectedByFocusWithin):
(WebCore::Element::isNamedFlowContentElement):
(WebCore::Element::setHasFocusWithin):

• dom/ElementRareData.h:

(WebCore::ElementRareData::styleAffectedByFocusWithin):
(WebCore::ElementRareData::setStyleAffectedByFocusWithin):
(WebCore::ElementRareData::isNamedFlowContentElement):
(WebCore::ElementRareData::setIsNamedFlowContentElement):
(WebCore::ElementRareData::ElementRareData):
(WebCore::ElementRareData::resetComputedStyle):

• dom/Node.h:

(WebCore::Node::flagHasFocusWithin):
(WebCore::Node::isNamedFlowContentNode): Deleted.
(WebCore::Node::setIsNamedFlowContentNode): Deleted.
(WebCore::Node::clearIsNamedFlowContentNode): Deleted.

• rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::clearContentElements):
(WebCore::RenderNamedFlowThread::registerNamedFlowContentElement):
(WebCore::RenderNamedFlowThread::unregisterNamedFlowContentElement):
(WebCore::nextNodeInsideContentElement):

• style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::updateElementRenderer):

• style/StyleRelations.cpp:

(WebCore::Style::commitRelationsToRenderStyle):
(WebCore::Style::commitRelations):

• style/StyleRelations.h:
• style/StyleSharingResolver.cpp:

(WebCore::Style::SharingResolver::canShareStyleWithElement):

LayoutTests:

• fast/css/css-selector-text-expected.txt:
• fast/css/css-selector-text.html:
• fast/css/css-set-selector-text-expected.txt:
• fast/css/css-set-selector-text.html:
• fast/css/pseudo-focus-within-basics-expected.html: Added.
• fast/css/pseudo-focus-within-basics.html: Added.
• fast/css/pseudo-focus-within-inside-shadow-dom-expected.html: Added.
• fast/css/pseudo-focus-within-inside-shadow-dom.html: Added.
• fast/css/pseudo-focus-within-style-sharing-1-expected.html: Added.
• fast/css/pseudo-focus-within-style-sharing-1.html: Added.
• fast/css/pseudo-focus-within-style-sharing-2-expected.html: Added.
• fast/css/pseudo-focus-within-style-sharing-2.html: Added.
• fast/selectors/focus-within-style-update-expected.txt: Added.
• fast/selectors/focus-within-style-update.html: Added.

4:31 PM Changeset in webkit [202357] by Chris Dumez

• 5 edits in trunk/Source/WebKit2

Stop using PassRefPtr in ShareableResource
​https://bugs.webkit.org/show_bug.cgi?id=159043

Reviewed by Alex Christensen.

Stop using PassRefPtr in ShareableResource.

• NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::store):

• NetworkProcess/cache/NetworkCacheEntry.cpp:

(WebKit::NetworkCache::Entry::initializeShareableResourceHandleFromStorageRecord):

• Shared/ShareableResource.cpp:

(WebKit::shareableResourceDeallocate):
(WebKit::ShareableResource::wrapInSharedBuffer):
(WebKit::ShareableResource::Handle::tryWrapInSharedBuffer):
(WebKit::ShareableResource::create):
(WebKit::ShareableResource::map):
(WebKit::ShareableResource::ShareableResource):

• Shared/ShareableResource.h:

4:23 PM Changeset in webkit [202356] by oliver@apple.com

• 3 edits in trunk/Source/WebCore

Integrate WebKit's CFURLConnection with App Transport Security
​https://bugs.webkit.org/show_bug.cgi?id=159039
<rdar://problem/26953685>

Reviewed by Alex Christensen.

Pass additional options to NSURLConnect initialiser to identify that
this connection is for WebKit content loading.

• platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::createNSURLConnection):

3:56 PM Changeset in webkit [202355] by jonlee@apple.com

• 2 edits in trunk/Tools

Update animometer.plan
​https://bugs.webkit.org/show_bug.cgi?id=159012

Reviewed by Ryosuke Niwa.

• Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202318.

3:52 PM Changeset in webkit [202354] by dino@apple.com

• 3 edits
  2 adds in trunk

REGRESSION: Double tap to zoom does not work on yahoo finance
​https://bugs.webkit.org/show_bug.cgi?id=158886
<rdar://problem/24917760>

Reviewed by Simon Fraser.

Source/WebKit2:

We shouldn't enable fast click on pages that have
had to shrink to fit. In other words, we should enable
double-tap-to-zoom if the page has already zoomed.

Test: fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _allowsDoubleTapGestures]):

LayoutTests:

• fast/events/ios/viewport-shrink-to-fit-allows-double-tap-expected.txt: Added.
• fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html: Added.

3:19 PM Changeset in webkit [202353] by BJ Burg

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: don't start auto capturing if the Inspector window is not visible
​https://bugs.webkit.org/show_bug.cgi?id=159014

Reviewed by Joseph Pecoraro.
<rdar://problem/26931269>

Followup, add a missing super.closed() call mentioned in review comments.

• UserInterface/Views/TimelineTabContentView.js:

(WebInspector.TimelineTabContentView.prototype.closed):

3:05 PM Changeset in webkit [202352] by BJ Burg

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: don't start auto capturing if the Inspector window is not visible
​https://bugs.webkit.org/show_bug.cgi?id=159014
<rdar://problem/26931269>

Reviewed by Joseph Pecoraro.

TimelineTabContentView should not tell the timeline manager to enable
auto-capturing unless the Web Inspector UI is visible. If it is preloaded
but not shown to the user, then auto-capturing may inadvertently disable
the debugger, causing it to miss debugger statements and not bring the
inspector to front.

• UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager.prototype.set autoCaptureOnPageLoad):
Bail out if nothing changed. Coerce to a boolean since the backend requires a boolean.

• UserInterface/Views/TimelineTabContentView.js:

(WebInspector.TimelineTabContentView): Listen for UI visibility changes.
(WebInspector.TimelineTabContentView.prototype.shown):
Enable auto-capturing if the UI is visible.

(WebInspector.TimelineTabContentView.prototype.closed): Added.
Remove listeners on global objects so this tab doesn't leak.

(WebInspector.TimelineTabContentView.prototype._inspectorVisibilityChanged):
Update the auto-capturing setting if the UI became visible or not visible.

2:41 PM Changeset in webkit [202351] by BJ Burg

• 4 edits in trunk/Source/WebKit2

Web Automation: Automation.inspectBrowsingContext should have an option to enable timeline auto-capturing
​https://bugs.webkit.org/show_bug.cgi?id=159004
<rdar://problem/26931269>

Reviewed by Joseph Pecoraro.

Automation.inspectBrowsingContext was added to make it easier to hit breakpoints inside of
code evaluated using Automation.evaluateJavaScriptFunction. I recently changed the behavior
of this command to automatically start profiling the page as soon as the inspector attached
so that a full timeline recording could be obtained. However, starting a timeline recording
turns off the debugger, so this command is not so useful for debugging right now.

Add a new option, enableAutoCapturing, to the inspectBrowsingContext command. Don't toggle
profiling automatically unless this optional flag is present and set to true.

• UIProcess/Automation/Automation.json:
• UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::inspectBrowsingContext):
(WebKit::WebAutomationSession::inspectorFrontendLoaded): Deleted.

• UIProcess/Automation/WebAutomationSession.h:

2:17 PM Changeset in webkit [202350] by jeremyj-wk@apple.com

• 8 edits in trunk/Source/WebCore

Adopt commitPriority to get rid of the 2 AVPL solution for PiP
​https://bugs.webkit.org/show_bug.cgi?id=158949
rdar://problem/26867866

Reviewed by Simon Fraser.

No new tests because there is no behavior change. This reverts changes from
​https://bugs.webkit.org/show_bug.cgi?id=158148 and instead uses -[CAContext commitPriority:]
to prevent flicker when moving a layer between contexts.
commitPriority allows the layer to be added to the destination context before it is
removed from the source context.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: remove m_secondaryVideoLayer.
• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: ditto

(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenGravity): ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::syncTextTrackBounds): ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::destroyVideoLayer): ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoLayerGravity): ditto.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm: ditto

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::addDisplayLayer): ditto

• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm: ditto

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::createPreviewLayers):ditto

• platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.h: ditto
• platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.mm: ditto

(WebCore::VideoFullscreenLayerManager::setVideoLayer): ditto
(WebCore::VideoFullscreenLayerManager::setVideoFullscreenLayer): ditto and adopt commitPriority.
(WebCore::VideoFullscreenLayerManager::setVideoFullscreenFrame): ditto
(WebCore::VideoFullscreenLayerManager::setVideoLayers): Deleted.
(WebCore::VideoFullscreenLayerManager::didDestroyVideoLayer): remove m_secondaryVideoLayer.

• platform/spi/cocoa/QuartzCoreSPI.h: Add commitPriority.

2:06 PM Changeset in webkit [202349] by mmaxfield@apple.com

• 68 edits
  20 copies
  22 adds
  1 delete in trunk/LayoutTests

Test gardening for css3/line-break-language-sensitive
​https://bugs.webkit.org/show_bug.cgi?id=159017

Unreviewed.

Some reftests had content which ended up outside of the viewport. This patch
splits that extra content out into separate tests.

In addition, this test migrates these tests to using a web font, so the results
of this test are not sensitive to platform-specific font fallback.

Because of the migration to the web font, css3/line-break-language-sensitive is
no longer needed.

• TestExpectations:
• css3/line-break-language-sensitive/line-break-auto-centered-expected.html: Removed.
• css3/line-break-language-sensitive/line-break-auto-centered.html: Removed.
• css3/line-break-language-sensitive/line-break-auto-half-kana-expected.html: Removed.
• css3/line-break-language-sensitive/line-break-auto-half-kana.html: Removed.
• css3/line-break-language-sensitive/line-break-auto-hyphens.html: Removed.
• css3/line-break-language-sensitive/line-break-auto-inseparables-expected.html: Removed.
• css3/line-break-language-sensitive/line-break-auto-inseparables.html: Removed.
• css3/line-break-language-sensitive/line-break-auto-iteration-marks-expected.html: Removed.
• css3/line-break-language-sensitive/line-break-auto-iteration-marks.html: Removed.
• css3/line-break-language-sensitive/line-break-auto-postfixes.html: Removed.
• css3/line-break-language-sensitive/line-break-auto-prefixes-expected.html: Removed.
• css3/line-break-language-sensitive/line-break-auto-prefixes.html: Removed.
• css3/line-break-language-sensitive/line-break-auto-sound-marks-expected.html: Removed.
• css3/line-break-language-sensitive/line-break-auto-sound-marks.html: Removed.
• css3/line-break-language-sensitive/line-break-loose-centered.html: Removed.
• css3/line-break-language-sensitive/line-break-loose-half-kana-expected.html: Removed.
• css3/line-break-language-sensitive/line-break-loose-half-kana.html: Removed.
• css3/line-break-language-sensitive/line-break-loose-hyphens.html: Removed.
• css3/line-break-language-sensitive/line-break-loose-inseparables-expected.html: Removed.
• css3/line-break-language-sensitive/line-break-loose-inseparables.html: Removed.
• css3/line-break-language-sensitive/line-break-loose-iteration-marks.html: Removed.
• css3/line-break-language-sensitive/line-break-loose-postfixes.html: Removed.
• css3/line-break-language-sensitive/line-break-loose-prefixes-expected.html: Removed.
• css3/line-break-language-sensitive/line-break-loose-prefixes.html: Removed.
• css3/line-break-language-sensitive/line-break-loose-sound-marks-expected.html: Removed.
• css3/line-break-language-sensitive/line-break-loose-sound-marks.html: Removed.
• css3/line-break-language-sensitive/line-break-normal-centered-expected.html: Removed.
• css3/line-break-language-sensitive/line-break-normal-centered.html: Removed.
• css3/line-break-language-sensitive/line-break-normal-half-kana-expected.html: Removed.
• css3/line-break-language-sensitive/line-break-normal-half-kana.html: Removed.
• css3/line-break-language-sensitive/line-break-normal-hyphens-expected.html: Removed.
• css3/line-break-language-sensitive/line-break-normal-hyphens.html: Removed.
• css3/line-break-language-sensitive/line-break-normal-inseparables-expected.html: Removed.
• css3/line-break-language-sensitive/line-break-normal-inseparables.html: Removed.
• css3/line-break-language-sensitive/line-break-normal-iteration-marks.html: Removed.
• css3/line-break-language-sensitive/line-break-normal-postfixes.html: Removed.
• css3/line-break-language-sensitive/line-break-normal-prefixes-expected.html: Removed.
• css3/line-break-language-sensitive/line-break-normal-prefixes.html: Removed.
• css3/line-break-language-sensitive/line-break-normal-sound-marks-expected.html: Removed.
• css3/line-break-language-sensitive/line-break-normal-sound-marks.html: Removed.
• css3/line-break-language-sensitive/line-break-strict-centered-expected.html: Removed.
• css3/line-break-language-sensitive/line-break-strict-centered.html: Removed.
• css3/line-break-language-sensitive/line-break-strict-half-kana-expected.html: Removed.
• css3/line-break-language-sensitive/line-break-strict-half-kana.html: Removed.
• css3/line-break-language-sensitive/line-break-strict-hyphens.html: Removed.
• css3/line-break-language-sensitive/line-break-strict-inseparables-expected.html: Removed.
• css3/line-break-language-sensitive/line-break-strict-inseparables.html: Removed.
• css3/line-break-language-sensitive/line-break-strict-iteration-marks-expected.html: Removed.
• css3/line-break-language-sensitive/line-break-strict-iteration-marks.html: Removed.
• css3/line-break-language-sensitive/line-break-strict-postfixes.html: Removed.
• css3/line-break-language-sensitive/line-break-strict-prefixes-expected.html: Removed.
• css3/line-break-language-sensitive/line-break-strict-prefixes.html: Removed.
• css3/line-break-language-sensitive/line-break-strict-sound-marks-expected.html: Removed.
• css3/line-break-language-sensitive/line-break-strict-sound-marks.html: Removed.
• css3/line-break/line-break-auto-centered-2-expected.html: Renamed from LayoutTests/css3/line-break-language-sensitive/line-break-strict-hyphens-expected.html.
• css3/line-break/line-break-auto-centered-2.html: Added.
• css3/line-break/line-break-auto-centered-expected.html:
• css3/line-break/line-break-auto-centered.html:
• css3/line-break/line-break-auto-half-kana-2-expected.html: Copied from LayoutTests/css3/line-break-language-sensitive/line-break-loose-postfixes-expected.html.
• css3/line-break/line-break-auto-half-kana-2.html: Added.
• css3/line-break/line-break-auto-half-kana-3-expected.html: Copied from LayoutTests/css3/line-break-language-sensitive/line-break-loose-postfixes-expected.html.
• css3/line-break/line-break-auto-half-kana-3.html: Added.
• css3/line-break/line-break-auto-half-kana-4-expected.html: Copied from LayoutTests/css3/line-break-language-sensitive/line-break-strict-postfixes-expected.html.
• css3/line-break/line-break-auto-half-kana-4.html: Added.
• css3/line-break/line-break-auto-half-kana-5-expected.html: Renamed from LayoutTests/css3/line-break-language-sensitive/line-break-auto-postfixes-expected.html.
• css3/line-break/line-break-auto-half-kana-5.html: Added.
• css3/line-break/line-break-auto-half-kana-expected.html:
• css3/line-break/line-break-auto-half-kana.html:
• css3/line-break/line-break-auto-hyphens-expected.html:
• css3/line-break/line-break-auto-hyphens.html:
• css3/line-break/line-break-auto-inseparables-expected.html:
• css3/line-break/line-break-auto-inseparables.html:
• css3/line-break/line-break-auto-iteration-marks-expected.html:
• css3/line-break/line-break-auto-iteration-marks.html:
• css3/line-break/line-break-auto-postfixes-expected.html:
• css3/line-break/line-break-auto-postfixes.html:
• css3/line-break/line-break-auto-prefixes-expected.html:
• css3/line-break/line-break-auto-prefixes.html:
• css3/line-break/line-break-auto-sound-marks-expected.html:
• css3/line-break/line-break-auto-sound-marks.html:
• css3/line-break/line-break-loose-centered-2-expected.html: Renamed from LayoutTests/css3/line-break-language-sensitive/line-break-loose-hyphens-expected.html.
• css3/line-break/line-break-loose-centered-2.html: Added.
• css3/line-break/line-break-loose-centered-expected.html:
• css3/line-break/line-break-loose-centered.html:
• css3/line-break/line-break-loose-half-kana-2-expected.html: Copied from LayoutTests/css3/line-break-language-sensitive/line-break-loose-postfixes-expected.html.
• css3/line-break/line-break-loose-half-kana-2.html: Added.
• css3/line-break/line-break-loose-half-kana-3-expected.html: Copied from LayoutTests/css3/line-break-language-sensitive/line-break-loose-postfixes-expected.html.
• css3/line-break/line-break-loose-half-kana-3.html: Added.
• css3/line-break/line-break-loose-half-kana-4-expected.html: Renamed from LayoutTests/css3/line-break-language-sensitive/line-break-loose-centered-expected.html.
• css3/line-break/line-break-loose-half-kana-4.html: Added.
• css3/line-break/line-break-loose-half-kana-5-expected.html: Renamed from LayoutTests/css3/line-break-language-sensitive/line-break-loose-iteration-marks-expected.html.
• css3/line-break/line-break-loose-half-kana-5.html: Added.
• css3/line-break/line-break-loose-half-kana-expected.html:
• css3/line-break/line-break-loose-half-kana.html:
• css3/line-break/line-break-loose-hyphens-expected.html:
• css3/line-break/line-break-loose-hyphens.html:
• css3/line-break/line-break-loose-inseparables-expected.html:
• css3/line-break/line-break-loose-inseparables.html:
• css3/line-break/line-break-loose-iteration-marks-expected.html:
• css3/line-break/line-break-loose-iteration-marks.html:
• css3/line-break/line-break-loose-postfixes-expected.html:
• css3/line-break/line-break-loose-postfixes.html:
• css3/line-break/line-break-loose-prefixes-expected.html:
• css3/line-break/line-break-loose-prefixes.html:
• css3/line-break/line-break-loose-sound-marks-expected.html:
• css3/line-break/line-break-loose-sound-marks.html:
• css3/line-break/line-break-normal-centered-2-expected.html: Renamed from LayoutTests/css3/line-break-language-sensitive/line-break-normal-iteration-marks-expected.html.
• css3/line-break/line-break-normal-centered-2.html: Added.
• css3/line-break/line-break-normal-centered-expected.html:
• css3/line-break/line-break-normal-centered.html:
• css3/line-break/line-break-normal-half-kana-2-expected.html: Copied from LayoutTests/css3/line-break-language-sensitive/line-break-loose-postfixes-expected.html.
• css3/line-break/line-break-normal-half-kana-2.html: Added.
• css3/line-break/line-break-normal-half-kana-3-expected.html: Copied from LayoutTests/css3/line-break-language-sensitive/line-break-loose-postfixes-expected.html.
• css3/line-break/line-break-normal-half-kana-3.html: Added.
• css3/line-break/line-break-normal-half-kana-4-expected.html: Renamed from LayoutTests/css3/line-break-language-sensitive/line-break-loose-postfixes-expected.html.
• css3/line-break/line-break-normal-half-kana-4.html: Added.
• css3/line-break/line-break-normal-half-kana-5-expected.html: Copied from LayoutTests/css3/line-break/line-break-loose-postfixes-expected.html.
• css3/line-break/line-break-normal-half-kana-5.html: Added.
• css3/line-break/line-break-normal-half-kana-expected.html:
• css3/line-break/line-break-normal-half-kana.html:
• css3/line-break/line-break-normal-hyphens-expected.html:
• css3/line-break/line-break-normal-hyphens.html:
• css3/line-break/line-break-normal-inseparables-expected.html:
• css3/line-break/line-break-normal-inseparables.html:
• css3/line-break/line-break-normal-iteration-marks-expected.html:
• css3/line-break/line-break-normal-iteration-marks.html:
• css3/line-break/line-break-normal-postfixes-expected.html:
• css3/line-break/line-break-normal-postfixes.html:
• css3/line-break/line-break-normal-prefixes-expected.html:
• css3/line-break/line-break-normal-prefixes.html:
• css3/line-break/line-break-normal-sound-marks-expected.html:
• css3/line-break/line-break-normal-sound-marks.html:
• css3/line-break/line-break-strict-centered-2-expected.html: Renamed from LayoutTests/css3/line-break-language-sensitive/line-break-auto-hyphens-expected.html.
• css3/line-break/line-break-strict-centered-2.html: Added.
• css3/line-break/line-break-strict-centered-expected.html:
• css3/line-break/line-break-strict-centered.html:
• css3/line-break/line-break-strict-half-kana-2-expected.html: Copied from LayoutTests/css3/line-break-language-sensitive/line-break-normal-postfixes-expected.html.
• css3/line-break/line-break-strict-half-kana-2.html: Added.
• css3/line-break/line-break-strict-half-kana-3-expected.html: Renamed from LayoutTests/css3/line-break-language-sensitive/line-break-strict-postfixes-expected.html.
• css3/line-break/line-break-strict-half-kana-3.html: Added.
• css3/line-break/line-break-strict-half-kana-4-expected.html: Copied from LayoutTests/css3/line-break-language-sensitive/line-break-normal-postfixes-expected.html.
• css3/line-break/line-break-strict-half-kana-4.html: Added.
• css3/line-break/line-break-strict-half-kana-5-expected.html: Renamed from LayoutTests/css3/line-break-language-sensitive/line-break-normal-postfixes-expected.html.
• css3/line-break/line-break-strict-half-kana-5.html: Added.
• css3/line-break/line-break-strict-half-kana-expected.html:
• css3/line-break/line-break-strict-half-kana.html:
• css3/line-break/line-break-strict-hyphens-expected.html:
• css3/line-break/line-break-strict-hyphens.html:
• css3/line-break/line-break-strict-inseparables-expected.html:
• css3/line-break/line-break-strict-inseparables.html:
• css3/line-break/line-break-strict-iteration-marks-expected.html:
• css3/line-break/line-break-strict-iteration-marks.html:
• css3/line-break/line-break-strict-postfixes-expected.html:
• css3/line-break/line-break-strict-postfixes.html:
• css3/line-break/line-break-strict-prefixes-expected.html:
• css3/line-break/line-break-strict-prefixes.html:
• css3/line-break/line-break-strict-sound-marks-expected.html:
• css3/line-break/line-break-strict-sound-marks.html:
• css3/line-break/resources/AllAhem.svg: Added.
• platform/ios-simulator/TestExpectations:
• platform/mac/TestExpectations:

1:44 PM Changeset in webkit [202348] by Simon Fraser

• 6 edits
  2 adds in trunk

REGRESSION (r201629): Weird button glitching on github.com
​https://bugs.webkit.org/show_bug.cgi?id=159031
rdar://problem/26880332

Reviewed by Tim Horton.

Source/WebCore:

r201629 changed the logic slightly when creating an image buffer for a scaled context;
it set the buffer context's scale to the scale in the source context, but this failed
to take into account the rounding up of the buffer size, which the old code did.

Fix by reverting to the old behavior.

Since buffer sizes can only be integral, changed compatibleBufferSize() to return
an IntSize.

Test: fast/backgrounds/scaled-gradient-background.html

• platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::createCompatibleBuffer):
(WebCore::ImageBuffer::compatibleBufferSize):

• platform/graphics/ImageBuffer.h:
• platform/graphics/IntRect.h:

(WebCore::IntRect::area):

• platform/graphics/IntSize.h:

(WebCore::IntSize::area): Make this return an unsigned.

LayoutTests:

• fast/backgrounds/scaled-gradient-background-expected.html: Added.
• fast/backgrounds/scaled-gradient-background.html: Added.

1:39 PM Changeset in webkit [202347] by timothy_horton@apple.com

• 10 edits in trunk/Source/WebKit2

Mail snapshot has black webview in multitasking switcher
​https://bugs.webkit.org/show_bug.cgi?id=159036
<rdar://problem/25972938>

Reviewed by Simon Fraser.

There is a window of time between an application going into the background
and SpringBoard's snapshotting mechanism completing where it is possible
(though difficult, timing-wise) for RemoteLayerBackingStoreCollection to
make still-needed surfaces volatile (and, even worse, for them to get emptied).

UIKit suggested instead waiting for the window context teardown notification,
which does indeed seem to fire after the snapshotting is complete.
This may have the convenient side effect of making the volatility timer
repeat fewer times in general, because it is now started closer to the
last time that the surfaces will be in-use.

• UIProcess/ApplicationStateTracker.h:
• UIProcess/ApplicationStateTracker.mm:

(WebKit::ApplicationStateTracker::ApplicationStateTracker):
(WebKit::ApplicationStateTracker::~ApplicationStateTracker):
(WebKit::ApplicationStateTracker::applicationDidFinishSnapshottingAfterEnteringBackground):

• UIProcess/WebPageProxy.h:
• UIProcess/ios/WKContentView.mm:

(-[WKContentView didMoveToWindow]):
(-[WKContentView _applicationDidFinishSnapshottingAfterEnteringBackground]):

• UIProcess/ios/WKPDFView.mm:

(-[WKPDFView didMoveToWindow]):
(-[WKPDFView _applicationDidFinishSnapshottingAfterEnteringBackground]):

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::applicationDidFinishSnapshottingAfterEnteringBackground):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:
• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::applicationDidEnterBackground):
(WebKit::WebPage::applicationDidFinishSnapshottingAfterEnteringBackground):

1:38 PM Changeset in webkit [202346] by andersca@apple.com

• 4 edits
  2 adds
  1 delete in trunk/Source/WebKit

Move the WebKitLegacy Apple Pay code to the open source repository
​https://bugs.webkit.org/show_bug.cgi?id=159035

Reviewed by Tim Horton.

Source/WebKit:

• WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

• WebCoreSupport/WebPaymentCoordinatorClient.h: Added.
• WebCoreSupport/WebPaymentCoordinatorClient.mm: Added.

(WebPaymentCoordinatorClient::WebPaymentCoordinatorClient):
(WebPaymentCoordinatorClient::~WebPaymentCoordinatorClient):
(WebPaymentCoordinatorClient::supportsVersion):
(WebPaymentCoordinatorClient::canMakePayments):
(WebPaymentCoordinatorClient::canMakePaymentsWithActiveCard):
(WebPaymentCoordinatorClient::showPaymentUI):
(WebPaymentCoordinatorClient::completeMerchantValidation):
(WebPaymentCoordinatorClient::completeShippingMethodSelection):
(WebPaymentCoordinatorClient::completeShippingContactSelection):
(WebPaymentCoordinatorClient::completePaymentMethodSelection):
(WebPaymentCoordinatorClient::completePaymentSession):
(WebPaymentCoordinatorClient::abortPaymentSession):
(WebPaymentCoordinatorClient::mainFrameDestroyed):

• WebKitAdditions.mm: Removed.
• WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):

1:00 PM Changeset in webkit [202345] by andersca@apple.com

• 7 edits in trunk/Source/WebCore

Inline the last of the Apple Pay WebCore code
​https://bugs.webkit.org/show_bug.cgi?id=159032

Reviewed by Tim Horton.

• loader/EmptyClients.cpp:

(WebCore::fillWithEmptyClients):

• page/MainFrame.cpp:

(WebCore::MainFrame::MainFrame):

• page/MainFrame.h:
• page/PageConfiguration.h:
• platform/cocoa/ThemeCocoa.mm:

(WebCore::passKitBundle):
(WebCore::loadPassKitPDFPage):
(WebCore::applePayButtonLogoBlack):
(WebCore::applePayButtonLogoWhite):
(WebCore::drawApplePayButton):
(WebCore::ThemeCocoa::drawNamedImage):

12:36 PM Changeset in webkit [202344] by ap@apple.com

• 2 edits in trunk/LayoutTests

Test expectation gardening for rdar://problem/26950065

• platform/mac/TestExpectations:

12:25 PM Changeset in webkit [202343] by ap@apple.com

• 2 edits in trunk/LayoutTests

Test expectation gardening.

• platform/mac/TestExpectations:

12:10 PM Changeset in webkit [202342] by andersca@apple.com

• 2 edits in trunk/Source/WebCore

Exception is not thrown when shipping method is an invalid amount
​https://bugs.webkit.org/show_bug.cgi?id=159030
rdar://problem/26700413

Reviewed by Tim Horton.

• Modules/applepay/ApplePaySession.cpp:

(WebCore::createShippingMethods):
Bail if createShippingMethod returns Nullopt.

(WebCore::createPaymentRequest):
Bail if createShippingMethods returns Nullopt.

11:43 AM Changeset in webkit [202341] by andersca@apple.com

• 4 edits in trunk/Source/WebCore

Exception is not thrown when shipping method is an invalid amount
​https://bugs.webkit.org/show_bug.cgi?id=159029
rdar://problem/26700413

Reviewed by Tim Horton.

• Modules/applepay/PaymentRequest.h:

Change ShippingMethod::amount to be a signed 64-bit integer.

• Modules/applepay/PaymentRequestValidator.cpp:

(WebCore::PaymentRequestValidator::validate):
Call validateShippingMethods.

(WebCore::PaymentRequestValidator::validateShippingMethods):
Validate all the shipping methods.

(WebCore::PaymentRequestValidator::validateShippingMethod):
Check that the amount is >= 0.

• Modules/applepay/PaymentRequestValidator.h:

Add new members.

11:20 AM Changeset in webkit [202340] by commit-queue@webkit.org

• 7 edits
  1 add in trunk

W3C test importer should generate files to ignore by WebKit SCM
​https://bugs.webkit.org/show_bug.cgi?id=142743

Patch by Youenn Fablet <​youenn.fablet@crf.canon.fr> on 2016-06-22
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• resources/TestRepositories: Added the option to generate .gitignore and init.py for wpt repo.
• web-platform-tests/.gitignore: Regeneration changes the order of the ignored files and removes the init.py which is now committed to WebKit trunk.
• web-platform-tests/init.py: Added.

Tools:

TestDownloader generates the .gitignore file according submodules git repository information.
TestImporter requests the generation of .gitignore and the main init.py according LayoutTests/imported/w3c/resources/TestRepositories options.

• Scripts/webkitpy/w3c/test_downloader.py:

(TestDownloader.generate_gitignore): Generating .gitignore according submodules description.

• Scripts/webkitpy/w3c/test_importer.py:

(TestImporter.process_test_repositories_import_options): Added the generation of .gitignore/init.py if the repo has the right option.
(TestImporter):
(TestImporter.write_init_py): Writing not empty init.py files.
(TestImporter.import_tests): Using of write_init_py.

• Scripts/webkitpy/w3c/test_importer_unittest.py:

(TestImporterTest.test_git_ignore_generation): Added .gitignore test.
(TestImporterTest):
(TestImporterTest.test_initpy_generation): Added init.py test.

11:15 AM Changeset in webkit [202339] by adam.bergkvist@ericsson.com

• 9 edits
  2 adds in trunk

WebRTC: Add support for the negotiationneeded event in MediaEndpointPeerConnection
​https://bugs.webkit.org/show_bug.cgi?id=158985

Source/WebCore:

Reviewed by Eric Carlson.

Implement MediaEndpointPeerConnection's isNegotiationNeeded, markAsNeedingNegotiation and
clearNegotiationNeededState functions. The calls to these functions are already up-to-date.

Test: fast/mediastream/RTCPeerConnection-more-media-to-negotiate.html

• Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::MediaEndpointPeerConnection::markAsNeedingNegotiation):

• Modules/mediastream/MediaEndpointPeerConnection.h:
• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::scheduleNegotiationNeededEvent):

LayoutTests:

Add tests for the RTCPeerConnection negotiationneeded event.

Reviewed by Eric Carlson.

• fast/mediastream/RTCPeerConnection-more-media-to-negotiate-expected.txt: Added.
• fast/mediastream/RTCPeerConnection-more-media-to-negotiate.html: Added.

Verify that a negotiationneeded event is fired when not all local media can be included in
an answer. (The answerer cannot reply with more m-lines than the offer had to begin with.)

• fast/mediastream/RTCPeerConnection-onnegotiationneeded-expected.txt:
• fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:

Verify that a negotiationneeded event is fired when tracks are added and removed from an
RTCPeerConnection.

• platform/gtk/TestExpectations:

Unskip fast/mediastream/RTCPeerConnection-onnegotiationneeded.html.

• platform/mac/TestExpectations:

The mac port does not build with WEB_RTC enabled yet.

11:14 AM Changeset in webkit [202338] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests/imported/w3c

imported/w3c/web-platform-tests/streams/readable-streams/general.https.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=155760

Patch by Youenn Fablet <​youennf@gmail.com> on 2016-06-22
Reviewed by Alexey Proskuryakov.

Making test more predictable.
Upstreamed to w3c repository as ​https://github.com/w3c/web-platform-tests/pull/3203.

• web-platform-tests/streams/readable-streams/general.js:

(promise_test):

11:12 AM Changeset in webkit [202337] by adam.bergkvist@ericsson.com

• 7 edits
  1 delete in trunk/Source/WebCore

WebRTC: Replace RTCPeerConnection custom constructor with a JS built-in constructor
​https://bugs.webkit.org/show_bug.cgi?id=158832

Reviewed by Eric Carlson and Youenn Fablet.

Use a JS built-in constructor instead of a custom constructor. This makes it easier to
initialize private fields for functions implemented as JS built-ins. The constructor
behavior is in need of updating, but that is left to a follow-up change [1].

[1] ​http://webkit.org/b/158936
No change in behavior.

• CMakeLists.txt:
• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::create):
(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::~RTCPeerConnection):
(WebCore::RTCPeerConnection::initializeWith):

• Modules/mediastream/RTCPeerConnection.h:
• Modules/mediastream/RTCPeerConnection.idl:
• Modules/mediastream/RTCPeerConnection.js:

(initializeRTCPeerConnection):
Add JS built-in constructor function.

• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSRTCPeerConnectionCustom.cpp: Removed.

(WebCore::constructJSRTCPeerConnection): Deleted.

11:11 AM Changeset in webkit [202336] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

CrossOriginPreflightChecker should call DocumentThreadableLoader preflightFailure instead of didFailLoading
​https://bugs.webkit.org/show_bug.cgi?id=158984

Patch by Youenn Fablet <​youenn@apple.com> on 2016-06-22
Reviewed by Darin Adler.

No change of behavior.

Calling DocumentThreadableLoader preflightFailure instead of didFailLoading for any preflight error case.

• loader/CrossOriginPreflightChecker.cpp:

(WebCore::CrossOriginPreflightChecker::notifyFinished): Directly calling preflightFailure callback.
(WebCore::CrossOriginPreflightChecker::doPreflight): Ditto.
(WebCore::CrossOriginPreflightChecker::handleLoadingFailure): Deleted.
(WebCore::CrossOriginPreflightChecker::redirectReceived): Deleted (should have been removed as part of
​https://bugs.webkit.org/show_bug.cgi?id=111008).

• loader/CrossOriginPreflightChecker.h:

11:10 AM Changeset in webkit [202335] by Nikita Vasilyev

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Simplify CSS rule for ContentBrowser navigation bar items
​https://bugs.webkit.org/show_bug.cgi?id=159000

Reviewed by Timothy Hatcher.

• UserInterface/Views/ContentBrowser.css:

(.content-browser > .navigation-bar > .item):
Both these values result in 28px, but 100% is simplier.

10:50 AM Changeset in webkit [202334] by Chris Dumez

• 5 edits in trunk

JSDOMIterator forEach should support second optional parameter
​https://bugs.webkit.org/show_bug.cgi?id=159020

Patch by Youenn Fablet <​youennf@gmail.com> on 2016-06-22
Reviewed by Chris Dumez.

Source/WebCore:

Covered by beefed up test.

• bindings/js/JSDOMIterator.h:

(WebCore::iteratorForEach): Setting callback thisValue to the second argument passed to forEach.

LayoutTests:

• fast/dom/nodeListIterator-expected.txt:
• fast/dom/nodeListIterator.html: Adding 'thisValue' various checks.

10:16 AM Changeset in webkit [202333] by jer.noble@apple.com

• 3 edits in trunk/Source/WebCore

Media controls stop working after exiting PiP
​https://bugs.webkit.org/show_bug.cgi?id=159026
<rdar://problem/26753579>

Reviewed by Eric Carlson.

Do not slave setting WebVideoFullscreenModelVideoElement::setVideoElement() to
WebPlaybackSessionModelVideoElement::setMediaElement(). After all, someone else
(i.e., the media controls) may still be using it.

• platform/cocoa/WebVideoFullscreenModelVideoElement.mm:

(WebVideoFullscreenModelVideoElement::setVideoElement): Deleted.

• platform/ios/WebVideoFullscreenControllerAVKit.mm:

(WebVideoFullscreenControllerContext::didCleanupFullscreen):
(WebVideoFullscreenControllerContext::setUpFullscreen):

10:14 AM Changeset in webkit [202332] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

Update document's isPlayingMedia() state whenever media element's media state changes
​https://bugs.webkit.org/show_bug.cgi?id=159018
<rdar://problem/26586630>

Reviewed by Beth Dakin.

The Document can end up with a stale m_mediaState if its own value isn't updated when
its constituent HTMLMediaElement's m_mediaStates change.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updateMediaState):

10:00 AM Changeset in webkit [202331] by Chris Dumez

• 6 edits in trunk/Source/WebKit2

Add logging related to process assertions to help debug process suspension issues
​https://bugs.webkit.org/show_bug.cgi?id=159001

Reviewed by Antti Koivisto.

Add logging related to process assertions to help debug process suspension issues.

• UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::didChangeIsLoading):

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::fetchWebsiteData):
(WebKit::NetworkProcessProxy::deleteWebsiteData):
(WebKit::NetworkProcessProxy::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcessProxy::setIsHoldingLockedFiles):

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::updateActivityToken):

• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::setIsHoldingLockedFiles):

9:58 AM Changeset in webkit [202330] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Crash under GraphicsLayerCA::recursiveCommitChanges() with deep layer trees
​https://bugs.webkit.org/show_bug.cgi?id=159023
rdar://problem/25377842

Reviewed by Tim Horton.

Having an on-stack DisplayList::Recorder increased the stack frame size significantly,
causing stack exhaustion with deep layer trees, despite the existing depth check.

Make the Recorder heap-allocated to fix this.

Tested by LayoutTests/compositinglayer-creation/deep-tree.html.

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::recursiveCommitChanges):

9:55 AM Changeset in webkit [202329] by weinig@apple.com

• 4 edits
  1 add in trunk

WKWebView with no WKNavigationDelegate does not follow universal links
<rdar://problem/24374110>
​https://bugs.webkit.org/show_bug.cgi?id=158997

Reviewed by Dan Bernstein.

Source/WebKit2:

API Test:

WKWebView.DefaultNavigationDelegate

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):
When initializing the WKWebView, set a default navigation client.

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.

Add a new test that shows that we have a default navigation delegate by swizzling
-[NSWorkspace openURL:]. This will only be called if there is a default client.

1:59 AM Changeset in webkit [202328] by Carlos Garcia Campos

• 4 edits in trunk/Source/WebCore

[GTK] Add support for variadic parameters to GObject DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=158942

Reviewed by Michael Catanzaro.

Generate code for functions having variadic parameters.

• bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunction):
(SkipFunction):

• bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_variadic_string_method):

• bindings/scripts/test/GObject/WebKitDOMTestObj.h:

1:47 AM MathML/Early_2016_Refactoring edited by fred.wang@free.fr

(diff)

1:35 AM Changeset in webkit [202327] by pvollan@apple.com

• 3 edits in trunk/Tools

[Win] Implement modal dialog support in MiniBrowser.
​https://bugs.webkit.org/show_bug.cgi?id=158976

Reviewed by Brent Fulgham.

• MiniBrowser/win/PrintWebUIDelegate.cpp:

(PrintWebUIDelegate::createWebViewWithRequest):
(getHandleFromWebView):
(PrintWebUIDelegate::webViewClose):
(PrintWebUIDelegate::setFrame):
(PrintWebUIDelegate::webViewFrame):
(PrintWebUIDelegate::canRunModal):
(findTopLevelParent):
(PrintWebUIDelegate::runModal):
(PrintWebUIDelegate::createModalDialog):

• MiniBrowser/win/PrintWebUIDelegate.h:

(PrintWebUIDelegate::webViewClose):
(PrintWebUIDelegate::setFrame):
(PrintWebUIDelegate::webViewFrame):
(PrintWebUIDelegate::canRunModal):
(PrintWebUIDelegate::runModal):

12:48 AM Changeset in webkit [202326] by pvollan@apple.com

• 5 edits in trunk

window.showModalDialog doesn't work in DumpRenderTree on Windows
​https://bugs.webkit.org/show_bug.cgi?id=53675

Reviewed by Brent Fulgham.

Tools:

Implement modal dialog support in DumpRenderTree.

• DumpRenderTree/win/UIDelegate.cpp:

(UIDelegate::canRunModal):
(getHandleFromWebView):
(UIDelegate::createModalDialog):
(findTopLevelParent):
(UIDelegate::runModal):
(UIDelegate::webViewClose):

• DumpRenderTree/win/UIDelegate.h:

LayoutTests:

Update test expectations for modal dialog tests.

• platform/win/TestExpectations: