⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 2, 2016:

8:36 PM Changeset in webkit [202785] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: CallFrame console.assert seen in tests (sourceCodeLocation instanceof SourceCodeLocation)
​https://bugs.webkit.org/show_bug.cgi?id=159368

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-07-02
Reviewed by Timothy Hatcher.

  • UserInterface/Test.html:

SourceCodeLocation was already included earlier. This redefines it and
thereby breaks some things.

8:33 PM Changeset in webkit [202784] by commit-queue@webkit.org
  • 8 edits in trunk

inspector/debugger/command-line-api-exception.html flakily times out on mac
​https://bugs.webkit.org/show_bug.cgi?id=152029
<rdar://problem/23813812>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-07-02
Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

  • UserInterface/Base/Object.js:

(WebInspector.Object.addEventListener):
Return the listener, this makes it cleaner to write tests.

LayoutTests:

  • inspector/debugger/command-line-api-exception-expected.txt:
  • inspector/debugger/command-line-api-exception-nested-catch-expected.txt:
  • inspector/debugger/command-line-api-exception-nested-catch.html:
  • inspector/debugger/command-line-api-exception.html:
  • platform/mac/TestExpectations:

Rewrite these tests to use the new test harness.
This also is more careful about Pause/Resume timing differences
between Release and Debug builds.

8:32 PM Changeset in webkit [202783] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Web Inspector: Fix inspector/debugger/pause-reason.html
​https://bugs.webkit.org/show_bug.cgi?id=159325

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-07-02
Reviewed by Timothy Hatcher.

  • platform/mac/TestExpectations:
  • inspector/debugger/pause-reason.html:

This test was pausing on inspector code (evaluateInPage) and
auto-resuming. Instead change the test to pause on the page
doing the setTimeout, so we get the expected pause on next
statement evaluation.

10:52 AM Changeset in webkit [202782] by mitz@apple.com
  • 2 edits in trunk/Source/WTF

Build fix.

  • wtf/Assertions.cpp:
10:47 AM Changeset in webkit [202781] by fpizlo@apple.com
  • 2 edits in trunk/Source/WTF

Unreviewed, roll back unintentional commit in r202778.

  • benchmarks/LockFairnessTest.cpp:

(main):

10:45 AM Changeset in webkit [202780] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd
​https://bugs.webkit.org/show_bug.cgi?id=152486

Patch by Youenn Fablet <​youennf@gmail.com> on 2016-07-02
Reviewed by Daniel Bates.

Add launch of web-platform-tests server by run-webkit-httpd.
Add two options to disable starting httpd and web-platform-tests servers.

  • Scripts/run-webkit-httpd:

(parse_args):
(main):

10:44 AM Changeset in webkit [202779] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Synchronous preflight checker should set loading options to not use credentials
​https://bugs.webkit.org/show_bug.cgi?id=159351

Patch by Youenn Fablet <​youenn@apple.com> on 2016-07-02
Reviewed by Alex Christensen.

Like for asynchronous preflighting, synchronous preflighting loading options should disqble any credentials.

No change of behavior as preflight request is expressly set to not use credentials in
createAccessControlPreflightRequest.

  • loader/CrossOriginPreflightChecker.cpp:

(WebCore::CrossOriginPreflightChecker::doPreflight):

10:43 AM Changeset in webkit [202778] by fpizlo@apple.com
  • 7 edits
    1 add in trunk/Source

Scopes that are not under TDZ should still push their variables onto the TDZ stack so that lifting TDZ doesn't bypass that scope
​https://bugs.webkit.org/show_bug.cgi?id=159332
rdar://problem/27018958

Reviewed by Saam Barati.

This fixes an instacrash in this code:

try{}catch(e){}print(e);let e;


We lift TDZ for "e" in "catch (e){}", but since that scope doesn't push anything onto the
TDZ stack, we lift TDZ from "let e".

The problem is that we weren't tracking the set of variables that do not have TDZ. We need
to track them to "block" the traversal that lifts TDZ. This change fixes this issue by
using a map that tracks all known variables, and tells you if they are under TDZ or not.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::numParameters):

  • bytecode/CodeOrigin.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::Label::setLocation):
(JSC::Variable::dump):
(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::pushLexicalScopeInternal):
(JSC::BytecodeGenerator::popLexicalScope):
(JSC::BytecodeGenerator::popLexicalScopeInternal):
(JSC::BytecodeGenerator::prepareLexicalScopeForNextForLoopIteration):
(JSC::BytecodeGenerator::variable):
(JSC::BytecodeGenerator::needsTDZCheck):
(JSC::BytecodeGenerator::liftTDZCheckIfPossible):
(JSC::BytecodeGenerator::pushTDZVariables):
(JSC::BytecodeGenerator::getVariablesUnderTDZ):
(JSC::BytecodeGenerator::endGenerator):
(WTF::printInternal):

  • bytecompiler/BytecodeGenerator.h:

(JSC::Variable::isConst):
(JSC::Variable::setIsReadOnly):

  • interpreter/CallFrame.h:

(JSC::ExecState::topOfFrame):

  • tests/stress/lift-tdz-bypass-catch.js: Added.

(foo):
(catch):

4:29 AM Changeset in webkit [202777] by fred.wang@free.fr
  • 5 edits in trunk/LayoutTests

Update EFL expectations for some MathML tests.

Unreviewed test gardening.

  • platform/efl/TestExpectations: Mark mathml/presentation/radical-bar-visibility.html as failing.
  • platform/efl/mathml/opentype/horizontal-munderover-expected.txt: Update expectation using latest buildbot results.
  • platform/efl/mathml/presentation/menclose-notation-values-expected.txt: Ditto.
  • platform/efl/mathml/presentation/mspace-children-expected.txt: Ditto.
1:24 AM Changeset in webkit [202776] by fred.wang@free.fr
  • 4 edits
    7 adds
    1 delete in trunk/LayoutTests

Update windows expectations for some MathML tests.

Unreviewed test gardening.

  • platform/win/TestExpectations:
  • platform/win/mathml/opentype/large-operators-expected.txt: Added.
  • platform/win/mathml/opentype/opentype-stretchy-expected.txt: Added.
  • platform/win/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Removed.
  • platform/win/mathml/opentype/vertical-expected.txt: Added.
  • platform/win/mathml/presentation/menclose-notation-default-longdiv-expected.txt:
  • platform/win/mathml/presentation/mo-stretch-expected.txt: Added.
  • platform/win/mathml/presentation/roots-expected.txt: Added.
  • platform/win/mathml/radical-fallback-expected.png: Added.
  • platform/win/mathml/radical-fallback-expected.txt: Added.
  • platform/efl/mathml/radical-fallback-expected.txt:
12:54 AM Changeset in webkit [202775] by fred.wang@free.fr
  • 11 edits
    2 adds
    6 deletes in trunk/LayoutTests

Update EFL expectations for some MathML tests.

Unreviewed test gardening.

  • platform/efl/accessibility/math-mo-fences-and-separators-expected.txt: Added.
  • platform/efl/mathml/opentype/horizontal-expected.txt:
  • platform/efl/mathml/opentype/horizontal-munderover-expected.txt:
  • platform/efl/mathml/opentype/large-operators-expected.png: Removed.
  • platform/efl/mathml/opentype/large-operators-expected.txt:
  • platform/efl/mathml/opentype/opentype-stretchy-expected.png: Removed.
  • platform/efl/mathml/opentype/opentype-stretchy-expected.txt:
  • platform/efl/mathml/opentype/vertical-expected.png: Removed.
  • platform/efl/mathml/opentype/vertical-expected.txt:
  • platform/efl/mathml/presentation/menclose-notation-default-longdiv-expected.png: Removed.
  • platform/efl/mathml/presentation/menclose-notation-default-longdiv-expected.txt:
  • platform/efl/mathml/presentation/menclose-notation-values-expected.txt:
  • platform/efl/mathml/presentation/mo-stretch-expected.png: Removed.
  • platform/efl/mathml/presentation/mo-stretch-expected.txt:
  • platform/efl/mathml/presentation/mspace-children-expected.txt:
  • platform/efl/mathml/presentation/roots-expected.png: Removed.
  • platform/efl/mathml/presentation/roots-expected.txt:
  • platform/efl/mathml/radical-fallback-expected.txt: Added.
12:11 AM Changeset in webkit [202774] by fred.wang@free.fr
  • 4 edits
    1 add in trunk/LayoutTests

Update iOS expectations for some MathML tests.

Unreviewed test gardening.

  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-simulator/TestExpectations:
  • platform/ios-simulator/mathml/mathml-in-dashboard-actual.txt: Added.

Jul 1, 2016:

8:03 PM Changeset in webkit [202773] by Hunseop Jeong
  • 3 edits in trunk/Source/WebKit2

[EFL] Many layout tests are timeout after r202532.
​https://bugs.webkit.org/show_bug.cgi?id=159337

Reviewed by Gyuyoung Kim.

WebPageProxy::forceRepaint() wait for the next commit from the web process
after r202532, but WebPageProxy::callAfterNextPresentationUpdate() is not
implemented in CoordinatedDrawingAreaProxy.

  • UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:

(WebKit::CoordinatedDrawingAreaProxy::contentsRect):
(WebKit::CoordinatedDrawingAreaProxy::dispatchAfterEnsuringDrawing):
(WebKit::CoordinatedDrawingAreaProxy::sizeDidChange):

  • UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h:

(WebKit::CoordinatedDrawingAreaProxy::page):

7:53 PM Changeset in webkit [202772] by mmaxfield@apple.com
  • 12 edits in trunk

REGRESSION(r189668): Notification tests are flakey
​https://bugs.webkit.org/show_bug.cgi?id=159375
<rdar://problem/22760990>

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

Implement WKNotificationManagerGetLocalID(). For more information, see the entry in Tools/ChangeLog.

  • UIProcess/API/C/WKNotificationManager.cpp:

(WKNotificationManagerGetLocalID):

  • UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::notificationLocalIDForTesting):

  • UIProcess/Notifications/WebNotificationManagerProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:

Tools:

Notifications are objects which must exist in both the UI Process and the Web Process. Each process
identifies a notification object by a unique ID. When the Web Process sends a message regarding a
notification to the UI Process, the UI Process's WebNotificationManagerProxy holds a map from
(Page ID, Web Process notification ID) -> UI Process notification ID. This works as intended.

Our tests, however, include an additional method, simulateWebNotificationClick(), which is implemented
by WebKitTestRunner in the Web Process via the Injected Bundle. This method involves sending a message
to the UI process, to handle the simulated click. However, that RPC didn't perform the same local ->
global notification ID mapping, causing the wrong notification to be investigated.

The solution is for WebNotificationProvider, implemented in WebKitTestRunner in the UI Process, to
manually perform this same mapping. Luckily, this object already receives callbacks every time a
notification is created or destroyed. However, because this object is implemented outside WebKit,
it isn't privy to the internal Web Process ID used inside WebNotificationmanagerProxy. Therefore,
this patch adds a private testing function which returns this internal ID. Once given this intenal ID,
WebNotificationProvider can properly map between the different IDs.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::runTestingServerLoop):
(WTR::TestController::simulateWebNotificationClick):

  • WebKitTestRunner/WebNotificationProvider.cpp:

(WTR::WebNotificationProvider::showWebNotification):
(WTR::removeGlobalIDFromIDMap):
(WTR::WebNotificationProvider::closeWebNotification):
(WTR::WebNotificationProvider::removeNotificationManager):
(WTR::WebNotificationProvider::simulateWebNotificationClick):
(WTR::WebNotificationProvider::reset):

  • WebKitTestRunner/WebNotificationProvider.h:

LayoutTests:

  • platform/mac/TestExpectations:
  • platform/mac-wk2/TestExpectations:
7:32 PM Changeset in webkit [202771] by commit-queue@webkit.org
  • 3 edits
    1 delete in trunk

Unreviewed, rolling out r202766.
​https://bugs.webkit.org/show_bug.cgi?id=159382

The new test asserts every time (Requested by ap on #webkit).

Reverted changeset:

"Web Inspector: Sending XHR with UTF8 encoded data shows
garbled data in Resource sidebar"
​https://bugs.webkit.org/show_bug.cgi?id=159358
​http://trac.webkit.org/changeset/202766

7:20 PM Changeset in webkit [202770] by commit-queue@webkit.org
  • 5 edits in trunk

[JSC] RegExp.compile is not returning the regexp when it succeed
​https://bugs.webkit.org/show_bug.cgi?id=159381

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-07-01
Reviewed by Mark Lam.

Source/JavaScriptCore:

Spec:
-​https://tc39.github.io/ecma262/#sec-regexp.prototype.compile
-​https://tc39.github.io/ecma262/#sec-regexpinitialize

  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncCompile):

LayoutTests:

  • js/regexp-compile-expected.txt:
  • js/script-tests/regexp-compile.js:
6:15 PM Changeset in webkit [202769] by Alan Bujtas
  • 5 edits
    3 adds in trunk

prepareForDestruction() always needs to be called before destroying the Document object.
​https://bugs.webkit.org/show_bug.cgi?id=159372
rdar://problem/26788150

Reviewed by Antti Koivisto.

We should never start destroying the Document object without calling prepareForDestruction() first.
It ensures that render tree gets nuked before we start tearing down the node tree.

Source/WebCore:

Test: fast/history/page-cache-destroy-document.html

  • dom/Document.cpp:

(WebCore::Document::removedLastRef):

LayoutTests:

  • fast/history/page-cache-destroy-document-expected.txt: Added.
  • fast/history/page-cache-destroy-document.html: Added.
  • fast/history/resources/page-cache-destroy-helper.html: Added.
5:59 PM Changeset in webkit [202768] by sbarati@apple.com
  • 6 edits
    1 add in trunk

fix "ASSERTION FAILED: currentOffset() >= currentLineStartOffset()"
​https://bugs.webkit.org/show_bug.cgi?id=158572
<rdar://problem/26884092>

Reviewed by Mark Lam.

Source/JavaScriptCore:

There is a bug in our lexer when we notice the pattern:
<return|continue|break|...etc> // some comment here
Our code will say that the token for the comment is a semicolon.
This is the correct semantics, however, it would give the semicolon
a start offset of the comment, but it will give its line start offset
the newline after the comment. This breaks the invariant in the lexer/parser
that the offset for the current line starting point must be less than or equal to
than the start offset of any token on that line. This invariant was broken because
the line start offset was greater than the token start offset. To maintain this
invariant, we claim that the semicolon token is located where the comment starts,
and that its line start offset is the line start offset for the line with the
comment on it. There are other solutions that maintain this invariant, but this
solution provides the best error messages.

  • parser/Lexer.cpp:

(JSC::Lexer<T>::lex):

  • parser/Parser.h:

(JSC::Parser::internalSaveLexerState):

  • tests/stress/obscure-error-message-dont-crash.js: Added.

(try.eval.or.catch):

LayoutTests:

  • js/parser-syntax-check-expected.txt:
  • js/script-tests/parser-syntax-check.js:

(invalid.or.break.catch):
(catch): Deleted.

5:56 PM Changeset in webkit [202767] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Marking fast/history/page-cache-webdatabase-pending-transaction.html as flaky on Mac
​https://bugs.webkit.org/show_bug.cgi?id=159379

Unreviewed test gardening.

  • platform/mac/TestExpectations:
5:55 PM Changeset in webkit [202766] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

Web Inspector: Sending XHR with UTF8 encoded data shows garbled data in Resource sidebar
​https://bugs.webkit.org/show_bug.cgi?id=159358

Patch by Johan K. Jensen <​jj@johanjensen.dk> on 2016-07-01
Reviewed by Joseph Pecoraro.

Source/WebCore:

Test: http/tests/inspector/network/xhr-request-data-encoded-correctly.html

  • inspector/InspectorNetworkAgent.cpp:

(WebCore::buildObjectForResourceRequest):

LayoutTests:

Based on Chromium patch:
<​https://chromium.googlesource.com/chromium/src/+/bcbb663864624ab38b36731eb2edc839a90f9e65%5E%21/#F2>

  • http/tests/inspector/network/xhr-request-data-encoded-correctly-expected.txt:
  • http/tests/inspector/network/xhr-request-data-encoded-correctly.html:
5:22 PM Changeset in webkit [202765] by dino@apple.com
  • 10 edits
    2 adds in trunk

"image-src" support is missing. We only support "-webkit-image-src"
​https://bugs.webkit.org/show_bug.cgi?id=159373
<rdar://problem/27140443>

Patch by Brent Fulgham and Dean Jackson.
Reviewed by Dean Jackson and Brent Fulgham.

Source/WebCore:

Support unprefixed image-set.

Test: fast/css/image-set-unprefixed.html

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::customCSSText):

  • css/CSSParser.cpp:

(WebCore::isImageSetFunctionValue): New helper function
that checks prefixed and unprefixed form.
(WebCore::CSSParser::parseValue): Use the helper.
(WebCore::CSSParser::parseContent):
(WebCore::CSSParser::parseFillImage):
(WebCore::CSSParser::parseBorderImage):

LayoutTests:

Convert some existing tests to use the unprefixed form,
and add a test that checks we are compatible with
the prefixed form.

  • cssom/cssvalue-comparison-expected.txt:
  • cssom/cssvalue-comparison.html:
  • fast/css/cursor-parsing-image-set-expected.txt:
  • fast/css/cursor-parsing-image-set.html:
  • fast/css/image-set-setting-expected.txt:
  • fast/css/image-set-unprefixed-expected.txt: Added.
  • fast/css/image-set-unprefixed.html: Added.
  • fast/css/script-tests/image-set-setting.js:

(testImageSetRule):

4:58 PM Changeset in webkit [202764] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Land test expectations for rdar://problem/27141291.

  • platform/mac/TestExpectations:
4:41 PM Changeset in webkit [202763] by jer.noble@apple.com
  • 7 edits in trunk/Source/WebKit2

REGRESSION(r201405): Fullscreen video no longer enters low-power mode
​https://bugs.webkit.org/show_bug.cgi?id=159220
<rdar://problem/26701056>

Reviewed by Beth Dakin.

In r201405, we removed the call to setTopContentInset(0) to avoid a flash
during repainting where the WebProcess still thought it had an inset and
the UIProcess did not, but the >0 inset breaks low power video playback
in fullscreen. So, instead, fix the repaint issue by setting a CALayer
fence which makes sure both the UIProcess and WebProcess paint simultaneously
after resizing and changing the top content inset.

This requires a new message from WebPageProxy -> WebPage: setTopContentInsetFenced().

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setTopContentInset):

  • UIProcess/mac/WKFullScreenWindowController.h:
  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setTopContentInsetFenced):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
4:25 PM Changeset in webkit [202762] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Possible null Range dereference under AXObjectCache::visiblePositionFromCharacterOffset()
​https://bugs.webkit.org/show_bug.cgi?id=159330
<rdar://problem/27123752>

Reviewed by Benjamin Poulain.

rangeForUnorderedCharacterOffsets() can return a null Range but we failed
to do a null check before dereferencing it.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::visiblePositionFromCharacterOffset):

4:22 PM Changeset in webkit [202761] by Chris Dumez
  • 16 edits
    2 adds in trunk

Regression(r199087): window.focus() / window.close() can no longer be called by a Window's opener
​https://bugs.webkit.org/show_bug.cgi?id=159364
<rdar://problem/27117169>

Reviewed by Gavin Barraclough.

Source/WebCore:

window.focus() / window.close() could no longer be called by a Window's opener
after r199087, which would break focusing of open iWork documents on icloud.com.

Before r199087, we would construct a new function in the caller's context every
time window.focus and window.close was accessed. r199087 fixed the issue so that
we always call the same function. However, those functions are using
[CallWith=Document] and they are were no longer passed the *caller*'s document
as a result. This broke focus / close permission checking as the code needed the
caller's document to do the check.

This patch introduces [CallWith=CallerDocument] and [CallWith=CallerWindow] so
that the implementation can now pass the caller's Document / Window to the
implementation. The bindings rely on JSDOMWindow's callerDOMWindow() to get the
caller DOMWindow / document. This new functionality is now used for window.close
and window.focus to unbreak their permission checking.

Test: fast/dom/Window/child-window-focus.html

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallWith):

  • bindings/scripts/IDLAttributes.txt:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::focus):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:

LayoutTests:

Add layout test coverage.

  • fast/dom/Window/child-window-focus-expected.txt: Added.
  • fast/dom/Window/child-window-focus.html: Added.
4:15 PM Changeset in webkit [202760] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Test gardening for Sierra WK1

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
2:50 PM Changeset in webkit [202759] by fred.wang@free.fr
  • 2 edits in trunk/LayoutTests

Remove failure expectation for mathml/presentation/bug97990.html on ios-simulator

Unreviewed test gardening.

Patch by Frederic Wang <​fwang@igalia.com> on 2016-07-01

  • platform/ios-simulator-wk2/TestExpectations:
2:43 PM Changeset in webkit [202758] by mitz@apple.com
  • 22 edits in trunk/Source/WebKit2

[Mac] Get rid of support for old SDKs
​https://bugs.webkit.org/show_bug.cgi?id=159369

Reviewed by Anders Carlsson.

  • Shared/API/Cocoa/WKFoundation.h: Removed the WK_ARRAY, WK_DICTIONARY, and WK_SET macros, which were only needed for pre-10.11 SDKs.
  • Shared/mac/WebEventFactory.mm:

(WebKit::mouseButtonForEvent): Removed checking for pre-10.10.3 SDKs.
(WebKit::globalPointForEvent): Ditto.
(WebKit::pointForEvent): Ditto.
(WebKit::WebEventFactory::createWebMouseEvent): Ditto.

  • UIProcess/API/Cocoa/WKBackForwardList.h: Replaced WK_ARRAY(...) with NSArray<...>.
  • UIProcess/API/Cocoa/WKPreferences.mm: Ditto.

(-[WKPreferences _setFixedPitchFontFamily:]):
(+[WKPreferences _experimentalFeatures]):

  • UIProcess/API/Cocoa/WKPreferencesPrivate.h: Ditto.
  • UIProcess/API/Cocoa/WKUIDelegate.h: Ditto.
  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h: Ditto.
  • UIProcess/API/Cocoa/WKUserContentController.h: Ditto.
  • UIProcess/API/Cocoa/WKUserContentControllerPrivate.h: Ditto.
  • UIProcess/API/Cocoa/WKUserScriptPrivate.h: Ditto.
  • UIProcess/API/Cocoa/WKWebsiteDataRecord.h: Replaced WK_SET(...) with NSSet<...>.
  • UIProcess/API/Cocoa/WKWebsiteDataStore.h: Ditto.
  • UIProcess/API/Cocoa/WKWebsiteDataStore.mm: Ditto.

(-[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:]):
(-[WKWebsiteDataStore _fetchDataRecordsOfTypes:withOptions:completionHandler:]):

  • UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h: Ditto.
  • UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h: Replaced WK_ARRAY(...) with NSArray<...>.
  • UIProcess/API/Cocoa/_WKUserStyleSheet.h: Ditto.
  • UIProcess/API/Cocoa/_WKUserStyleSheet.mm: Ditto.

(-[_WKUserStyleSheet initWithSource:forMainFrameOnly:]):
(-[_WKUserStyleSheet initWithSource:forMainFrameOnly:legacyWhitelist:legacyBlacklist:userContentWorld:]):
(-[_WKUserStyleSheet initWithSource:forMainFrameOnly:legacyWhitelist:legacyBlacklist:baseURL:userContentWorld:]):

  • UIProcess/API/Cocoa/_WKWebsiteDataSize.h: Replaced WK_SET(...) with NSSet<...>.
  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::pressureChangeWithEvent): Removed checking for pre-10.10.3 SDKs.

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFrame.h: Replaced WK_ARRAY(...) with NSArray<...>.
  • mac/postprocess-framework-headers.sh: Removed sed rules for WK_ARRAY, WK_DICTIONARY and WK_SET.
1:59 PM Changeset in webkit [202757] by Chris Dumez
  • 5 edits in trunk/Source

[iOS] Possible null Range dereference under computeAutocorrectionContext()
​https://bugs.webkit.org/show_bug.cgi?id=159328
<rdar://problem/26766720>

Reviewed by Benjamin Poulain.

Source/WebCore:

  • editing/Editor.cpp:

(WebCore::Editor::compositionRange):

  • editing/Editor.h:

Update to return a RefPtr instead of a PassRefPtr and use nullptr
instead of 0 in the implementation.

Source/WebKit2:

The code in computeAutocorrectionContext() was checking Editor::hasComposition()
before dereferencing Editor::compositionRange(). However, compositionRange()
can also return null in other cases (e.g. compositionStart == compositionEnd).

Drop the check for hasComposition() and do a null check on the value returned
by compositionRange() instead.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::computeAutocorrectionContext):

1:58 PM Changeset in webkit [202756] by Jon Davis
  • 3 edits in trunk/Websites/webkit.org

Added a colorful new image and fixed the Open Graph attribute.
​https://bugs.webkit.org/show_bug.cgi?id=159359

Reviewed by Timothy Hatcher.

The Open Graph image tag should use the property attribute not
the itemprop attribute.

  • wp-content/plugins/social-meta.php:
  • wp-content/themes/webkit/images/ogimage.png:
1:55 PM Changeset in webkit [202755] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

defineGetter/defineSetter should throw exceptions
​https://bugs.webkit.org/show_bug.cgi?id=142934

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-07-01
Reviewed by Mark Lam.

Source/JavaScriptCore:

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):

LayoutTests:

  • js/dom/dom-properties-are-configurable-expected.txt: Added.
  • js/dom/dom-properties-are-configurable.html: Added.
  • js/object-literal-duplicate-properties-expected.txt:
  • js/property-getters-and-setters-expected.txt:
  • js/script-tests/object-literal-duplicate-properties.js:
  • js/script-tests/property-getters-and-setters.js:
1:52 PM Changeset in webkit [202754] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit2

Prevent crash when attempting to copy an image
​https://bugs.webkit.org/show_bug.cgi?id=159288
<rdar://problem/23507828>

Reviewed by Brady Eidson.

WebKit could crash if the HTMLImageElement had a null cachedImage member.
A little investigation showed that the URL we retrieve from the cachedImage
is never used, so rather than adding a null check, let's just pass a
default argument. The actual URL gets read from elsewhere in the pasteboard
processing code.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::performActionOnElement): Don't bother passing the
unused URL argument to the pasteboard method.

1:51 PM Changeset in webkit [202753] by Jon Davis
  • 4 edits in trunk/Source

Source/JavaScriptCore:
Moved Web Animations and Resource Timing feature entries to WebCore.
​https://bugs.webkit.org/show_bug.cgi?id=159356

Reviewed by Timothy Hatcher.

  • features.json:

Source/WebCore:
Updated Picture element and WOFF 2 status
​https://bugs.webkit.org/show_bug.cgi?id=159356

Reviewed by Timothy Hatcher.

Status updates and clean-up to move Web Animations and Resource Timing entries from JSC to WebCore.

  • features.json:
1:49 PM Changeset in webkit [202752] by commit-queue@webkit.org
  • 5 edits
    3 adds in trunk

[JSC] Date.toGMTString should be the Date.toUTCString function
​https://bugs.webkit.org/show_bug.cgi?id=159318

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-07-01
Reviewed by Mark Lam.

Source/JavaScriptCore:

See ​https://tc39.github.io/ecma262/#sec-date.prototype.togmtstring

  • runtime/DatePrototype.cpp:

(JSC::DatePrototype::finishCreation):
(JSC::dateProtoFuncToGMTString): Deleted.

LayoutTests:

  • js/date-prototype-expected.txt: Added.
  • js/date-prototype.html: Added.
  • js/script-tests/date-prototype.js: Added.
1:46 PM Changeset in webkit [202751] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Add early return when processing content extensions if there aren't any.
<​https://webkit.org/b/159363>

Reviewed by Antti Koivisto.

Short-circuit outta there if there aren't any extensions to query.

  • contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::processContentExtensionRulesForLoad):

1:44 PM Changeset in webkit [202750] by fred.wang@free.fr
  • 1 edit
    1 add
    2 deletes in trunk/LayoutTests

Rebaseline some MathML tests.

Unreviewed test gardening.

Patch by Frederic Wang <​fwang@igalia.com> on 2016-07-01

  • platform/gtk/mathml/opentype/munderover-window-resize-expected.txt: Removed.
  • platform/ios-simulator/mathml/presentation/roots-expected.png: Added.
  • platform/mac/mathml/opentype/munderover-window-resize-expected.png: Removed.
1:31 PM Changeset in webkit [202749] by eric.carlson@apple.com
  • 4 edits in trunk/Source/WebCore

HTMLMediaElement::resume() may cause JavaScript execution
​https://bugs.webkit.org/show_bug.cgi?id=159327
<rdar://problem/27131641>

Reviewed by Jer Noble.

HTMLMediaElement::updatePlayState can cause an element to begin playing and enter fullscreen,
which can result in a call to the media controls and JavaScript execution. Javascript is not
allowed allowed to run when a page resumes, so make the call to updatePlayState asynchronous.

No new tests, I wasn't able to create a test that triggers the crash.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::scheduleDelayedAction): Support UpdatePlayState.
(WebCore::HTMLMediaElement::pendingActionTimerFired): Ditto.
(WebCore::HTMLMediaElement::setReadyState): UpdateMediaState -> UpdateState.
(WebCore::HTMLMediaElement::playInternal): Don't call updateMediaController, it is called

by updatePlayState.

(WebCore::HTMLMediaElement::setMuted): UpdateMediaState -> UpdateState.
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged): Ditto.
(WebCore::HTMLMediaElement::mediaEngineWasUpdated): Update media state asynchronously.
(WebCore::HTMLMediaElement::updatePlayState): Add parameter to allow update to happen

asynchronously.

(WebCore::HTMLMediaElement::setPlaying): UpdateMediaState -> UpdateState.
(WebCore::HTMLMediaElement::setPausedInternal): Update media state asynchronously.
(WebCore::HTMLMediaElement::mediaPlayerCurrentPlaybackTargetIsWirelessChanged):

UpdateMediaState -> UpdateState.

(WebCore::HTMLMediaElement::removeEventListener): Ditto.
(WebCore::HTMLMediaElement::enqueuePlaybackTargetAvailabilityChangedEvent): Ditto.
(WebCore::HTMLMediaElement::updateMediaState): UpdateMediaState -> UpdateState

  • html/HTMLMediaElement.h:
  • html/HTMLMediaElementEnums.h: Add UpdatePlayState.
12:41 PM Changeset in webkit [202748] by fred.wang@free.fr
  • 26 edits
    8 adds
    9 deletes in trunk/LayoutTests

Update OS X and iOS expectations for some MathML pixel tests.
​https://bugs.webkit.org/show_bug.cgi?id=159339

Unreviewed test gardening.

Patch by Frederic Wang <​fwang@igalia.com> on 2016-07-01

  • mathml/opentype/fraction-line.html: Add a comment about font requirements.
  • mathml/opentype/horizontal-munderover.html: Ditto.
  • mathml/opentype/horizontal.html: Ditto.
  • mathml/opentype/large-operators-italic-correction.html: Ditto.
  • mathml/opentype/large-operators.html: Ditto.
  • mathml/opentype/vertical.html: Ditto.
  • mathml/presentation/attributes-mathvariant.html: Ditto.
  • mathml/presentation/fractions-linethickness.html: Ditto.
  • mathml/presentation/tokenElements-mathvariant.html: Ditto.
  • mathml/radical-fallback.html: Ditto.
  • platform/ios-simulator-wk1/TestExpectations: Update expectations.
  • platform/ios-simulator-wk2/TestExpectations: Ditto.
  • platform/ios-simulator-wk2/mathml/opentype/large-operators-expected.png: Removed.
  • platform/ios-simulator-wk2/mathml/opentype/vertical-expected.png: Removed.
  • platform/ios-simulator-wk2/mathml/presentation/mo-stretch-expected.png: Removed.
  • platform/ios-simulator/TestExpectations:
  • platform/ios-simulator/mathml/opentype/horizontal-expected.txt: Removed.
  • platform/ios-simulator/mathml/opentype/horizontal-munderover-expected.txt: Removed.
  • platform/ios-simulator/mathml/opentype/large-operators-expected.txt: Removed.
  • platform/ios-simulator/mathml/opentype/opentype-stretchy-expected.png: Added.
  • platform/ios-simulator/mathml/opentype/opentype-stretchy-horizontal-expected.png: Added.
  • platform/ios-simulator/mathml/opentype/opentype-stretchy-horizontal-expected.txt:
  • platform/ios-simulator/mathml/opentype/vertical-expected.txt: Removed.
  • platform/ios-simulator/mathml/presentation/menclose-notation-default-longdiv-expected.png: Added.
  • platform/ios-simulator/mathml/presentation/menclose-notation-values-expected.png: Added.
  • platform/ios-simulator/mathml/presentation/mo-stretch-expected.png: Added.
  • platform/ios-simulator/mathml/presentation/mo-stretch-expected.txt:
  • platform/ios-simulator/mathml/presentation/mspace-children-expected.png: Added.
  • platform/ios-simulator/mathml/radical-fallback-expected.png:
  • platform/mac/TestExpectations: Update expectations.
  • platform/mac/mathml/opentype/horizontal-expected.txt: Removed.
  • platform/mac/mathml/opentype/horizontal-munderover-expected.txt: Removed.
  • platform/mac/mathml/opentype/large-operators-expected.txt: Removed.
  • platform/mac/mathml/opentype/opentype-stretchy-expected.png: Added.
  • platform/mac/mathml/opentype/vertical-expected.txt: Removed.
  • platform/mac/mathml/presentation/menclose-notation-values-expected.png:
  • platform/mac/mathml/presentation/menclose-notation-values-expected.txt:
  • platform/mac/mathml/presentation/mo-stretch-expected.png:
  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
  • platform/mac/mathml/presentation/mspace-children-expected.png: Added.
  • platform/mac/mathml/presentation/roots-expected.png:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/radical-fallback-expected.png:
  • platform/mac/mathml/radical-fallback-expected.txt:
12:10 PM Changeset in webkit [202747] by beidson@apple.com
  • 16 edits
    5 adds in trunk

Blob content type not preserved when retrieving blobs from IndexedDB.
<rdar://problem/27057357> and ​https://bugs.webkit.org/show_bug.cgi?id=159360

Reviewed by Alex Christensen.

Source/WebCore:

Test: storage/indexeddb/modern/blob-svg-image.html

  • fileapi/Blob.cpp:

(WebCore::Blob::Blob):

  • fileapi/ThreadableBlobRegistry.cpp:

(WebCore::postToMainThread):
(WebCore::ThreadableBlobRegistry::registerBlobURLOptionallyFileBacked): Pass along the content type

to the blob registry so that if the file-backed blob takes over, it has the content type.

(WebCore::threadableQueue): Deleted.

  • fileapi/ThreadableBlobRegistry.h:
  • platform/network/BlobRegistry.h:
  • platform/network/BlobRegistryImpl.cpp:

(WebCore::BlobRegistryImpl::registerBlobURL):
(WebCore::BlobRegistryImpl::registerBlobURLOptionallyFileBacked):

  • platform/network/BlobRegistryImpl.h:

Source/WebKit2:

  • NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:

(WebKit::NetworkBlobRegistry::registerBlobURLOptionallyFileBacked):

  • NetworkProcess/FileAPI/NetworkBlobRegistry.h:
  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::registerBlobURLOptionallyFileBacked):

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:
  • WebProcess/FileAPI/BlobRegistryProxy.cpp:

(WebKit::BlobRegistryProxy::registerBlobURLOptionallyFileBacked):

  • WebProcess/FileAPI/BlobRegistryProxy.h:

LayoutTests:

  • storage/indexeddb/modern/blob-svg-image-expected.txt: Added.
  • storage/indexeddb/modern/blob-svg-image.html: Added.
  • storage/indexeddb/modern/resources/blob-svg-image.js: Added.
  • storage/indexeddb/modern/resources/blob-svg-image1.html: Added.
  • storage/indexeddb/modern/resources/blob-svg-image2.html: Added.
12:07 PM Changeset in webkit [202746] by mitz@apple.com
  • 6 edits in trunk/Source/WebKit2

[Cocoa] Get rid of WK_NULLABLE_SPECIFIER now that all supported compilers understand _Nullable
​https://bugs.webkit.org/show_bug.cgi?id=159361

Reviewed by Anders Carlsson.

  • Shared/API/Cocoa/WKFoundation.h:
  • UIProcess/API/Cocoa/WKNavigationDelegate.h:
  • UIProcess/API/Cocoa/WKUIDelegate.h:
  • UIProcess/API/Cocoa/WKWebView.h:
  • mac/postprocess-framework-headers.sh:
11:36 AM Changeset in webkit [202745] by bshafiei@apple.com
  • 1 delete in tags/Safari-602.1.38.2.100

Delete tag.

11:08 AM Changeset in webkit [202744] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit/win

ASSERTION FAILED: info.bmBitsPixel == 32
​https://bugs.webkit.org/show_bug.cgi?id=17737

Reviewed by Brent Fulgham.

The ::SelectObject call will fail if m_backingStoreBitmap is already selected into a device context.
This happens when this method is called indirectly from WebView::updateBackingStore during normal
painting. There is no point continuing, since we would just be scrolling a 1x1 bitmap which is
selected into the device context by default. We can just scroll by repainting the scroll rectangle.

  • WebView.cpp:

(WebView::scrollBackingStore): Invalidate the scroll rectangle if the ::SelectObject call fails.

10:08 AM Changeset in webkit [202743] by ap@apple.com
  • 9 edits in trunk/Tools

Simplify LayoutTestRelay
​https://bugs.webkit.org/show_bug.cgi?id=159353

Reviewed by Daniel Bates.

  1. Use UDID to pass the device from webkitpy to LayoutTestRelay, searching for it

by name and runtime makes no sense.

  1. Removed code to create devices, webkitpy always does this in advance.
  2. Don't create copies of testing apps - we can install the same one into

each simulator, now that we don't run multiple tester processes in a single simulator.

  1. Pass information on how to find I/O pipes via environment, not via Info.plist.
  2. Removed code that kept testing apps alive in the background.
  3. Slightly updated coding style in functions that I touched.
  • LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:

Updated for what we acually use at this point.

  • LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
  • LayoutTestRelay/LayoutTestRelay/LTRelayController.m:

(-[LTRelayController initWithDevice:productDir:appPath:deviceUDID:dumpToolArguments:]):
(-[LTRelayController ipcIdentifier]):
(-[LTRelayController processName]):
(-[LTRelayController didReceiveStdoutData:]):
(-[LTRelayController didCrashWithMessage:]):
(-[LTRelayController installApp]):
(-[LTRelayController _environmentVariables]):
(-[LTRelayController launchApp]):
(-[LTRelayController start]):
(-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]): Deleted.
(-[LTRelayController uniqueAppPath]): Deleted.
(-[LTRelayController uniqueAppURL]): Deleted.
(-[LTRelayController uniqueAppIdentifier]): Deleted.
(-[LTRelayController createUniqueApp]): Deleted.

  • LayoutTestRelay/LayoutTestRelay/main.m:

(usage):
(getRequiredStringArgument):
(main):
(getTestingSimDevice): Deleted.

  • Scripts/webkitpy/port/driver.py:

(IOSSimulatorDriver.cmd_line):

  • WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::platformInitialize):

  • WebKitTestRunner/ios/mainIOS.mm:

(-[WebKitTestRunnerApp applicationDidEnterBackground:]):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(dumpRenderTree):
(-[DumpRenderTree applicationDidEnterBackground:]):

10:06 AM Changeset in webkit [202742] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Make enabling protocol logging in inspector tests easy to remember
​https://bugs.webkit.org/show_bug.cgi?id=159323

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-07-01
Reviewed by Brian Burg.

Now you just need to type InspectorTest.debug() or
ProtocolTest.debug() and it will include stderr logging.

  • UserInterface/Test/FrontendTestHarness.js:

(FrontendTestHarness.prototype.debug):

  • UserInterface/Test/ProtocolTestHarness.js:

(ProtocolTestHarness.prototype.debug):
(ProtocolTestHarness):

  • UserInterface/Test/TestHarness.js:

(TestHarness.prototype.debug):

10:03 AM Changeset in webkit [202741] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Make ResourceLoaderOptions derive from FetchOptions
​https://bugs.webkit.org/show_bug.cgi?id=159345

Patch by Youenn Fablet <​youenn@apple.com> on 2016-07-01
Reviewed by Alex Christensen.

No change of behavior.

  • Modules/fetch/FetchLoader.cpp:

(WebCore::FetchLoader::start):

  • loader/CrossOriginPreflightChecker.cpp:

(WebCore::CrossOriginPreflightChecker::startPreflight):

  • loader/ResourceLoaderOptions.h:

(WebCore::ResourceLoaderOptions::fetchOptions): Deleted.
(WebCore::ResourceLoaderOptions::setFetchOptions): Deleted.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequestInternal):

10:00 AM Changeset in webkit [202740] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Web Inspector: Cleanup inspector/console/console-message.html
​https://bugs.webkit.org/show_bug.cgi?id=159324

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-07-01
Reviewed by Brian Burg.

  • inspector/console/console-message.html:
9:43 AM Changeset in webkit [202739] by Konstantin Tokarev
  • 2 edits in trunk/Tools

[cmake] Build TestNetscapePlugin only if NPAPI is enabled.
​https://bugs.webkit.org/show_bug.cgi?id=159344

Reviewed by Alex Christensen.

  • DumpRenderTree/CMakeLists.txt:
9:39 AM Changeset in webkit [202738] by pvollan@apple.com
  • 2 edits in trunk/Source/WebCore

[Win] Animations tests are crashing in debug mode.
​https://bugs.webkit.org/show_bug.cgi?id=159335

Reviewed by Alex Christensen.

A MSVC runtime check fails because an uninitialized variable is being used.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::keyframeStylesForAnimation):

9:38 AM Changeset in webkit [202737] by mark.lam@apple.com
  • 7 edits
    3 adds in trunk/Source/JavaScriptCore

Update JSC_functionOverrides to handle the new SourceCode strings that have params.
​https://bugs.webkit.org/show_bug.cgi?id=159321

Reviewed by Geoffrey Garen.

And add tests so that this won't fail silently and bit rot anymore.

  • API/tests/FunctionOverridesTest.cpp: Added.

(testFunctionOverrides):

  • API/tests/FunctionOverridesTest.h: Added.
  • API/tests/testapi-function-overrides.js: Added.
  • API/tests/testapi.c:

(main):

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/UnlinkedFunctionExecutable.cpp:

(JSC::UnlinkedFunctionExecutable::link):

  • shell/PlatformWin.cmake:
  • tools/FunctionOverrides.cpp:

(JSC::FunctionOverrides::FunctionOverrides):
(JSC::FunctionOverrides::reinstallOverrides):
(JSC::initializeOverrideInfo):
(JSC::FunctionOverrides::initializeOverrideFor):

  • tools/FunctionOverrides.h:

(JSC::FunctionOverrides::clear):

8:40 AM Changeset in webkit [202736] by jer.noble@apple.com
  • 2 edits in trunk/Source/WTF

Deadlock inside -[WebCoreNSURLSession dealloc]
​https://bugs.webkit.org/show_bug.cgi?id=159331
<rdar://problem/27122716>

Reviewed by Alex Christensen.

A Function<> object can wrap any callable type, including a C++ lambda.

dispatchFunctionsFromMainThread() holds a lock while iterating over the functions in
functionQueue(), and during ths iteration, the previous callable object is destroyed by
assigning the result of functionQueue().takeFirst(). Because lambdas (and other callables,
like functors) can own objects, destroying this callable can have side effects, and if one
of those side effects is to call callOnMainThread(), this can deadlock.

Move this side-effect-having call outside the locked block by clearing the function object
immediately after calling it.

  • wtf/MainThread.cpp:

(WTF::dispatchFunctionsFromMainThread):

8:29 AM Changeset in webkit [202735] by Konstantin Tokarev
  • 2 edits in trunk

[cmake] Make LEGACY_WEB_AUDIO depend on WEB_AUDIO.
​https://bugs.webkit.org/show_bug.cgi?id=159338

Reviewed by Michael Catanzaro.

Enabling LEGACY_WEB_AUDIO makes no sense when WEB_AUDIO is
disabled.

  • Source/cmake/WebKitFeatures.cmake:
8:25 AM Changeset in webkit [202734] by commit-queue@webkit.org
  • 4 edits
    4 adds in trunk/Source/JavaScriptCore

ES6: Implement HasRestrictedGlobalProperty when checking for global lexical tier conflicts
​https://bugs.webkit.org/show_bug.cgi?id=148763

Patch by Caio Lima <Caio Lima> on 2016-07-01
Reviewed by Saam Barati

I've implemented the ES6 spec 8.1.1.4.14
(​http://www.ecma-international.org/ecma-262/6.0/index.html#sec-hasrestrictedglobalproperty)
that defines when a global property can be shadowed.

Added some test cases into global-lexical-redeclare-variable.js

  • runtime/Executable.cpp:

(JSC::ProgramExecutable::initializeGlobalProperties):

  • tests/stress/global-lexical-redeclare-variable.js:

(catch):

  • tests/stress/multiple-files-tests/global-lexical-redeclare-variable/eighth.js: Added.
  • tests/stress/multiple-files-tests/global-lexical-redeclare-variable/nineth.js: Added.
  • tests/stress/multiple-files-tests/global-lexical-redeclare-variable/seventh.js: Added.
  • tests/stress/multiple-files-tests/global-lexical-redeclare-variable/sixth.js:
  • tests/stress/multiple-files-tests/global-lexical-redeclare-variable/tenth.js: Added.
5:46 AM Changeset in webkit [202733] by fred.wang@free.fr
  • 3 edits in trunk/LayoutTests

Rebaseline opentype-stretchy-horizontal.html for EFL.
​https://bugs.webkit.org/show_bug.cgi?id=135561

Unreviewed test gardening.

Patch by Frederic Wang <​fwang@igalia.com> on 2016-07-01

  • platform/efl/TestExpectations:
  • platform/efl/mathml/opentype/opentype-stretchy-horizontal-expected.txt:
5:36 AM Changeset in webkit [202732] by fred.wang@free.fr
  • 2 edits
    1 add in trunk/LayoutTests

Regenerate EFL expectation for foreign-element-in-token.html
​https://bugs.webkit.org/show_bug.cgi?id=133972

Unreviewed test gardening.

Patch by Frederic Wang <​fwang@igalia.com> on 2016-07-01

  • platform/efl/TestExpectations:
  • platform/efl/mathml/presentation/foreign-element-in-token-expected.txt: Added.
5:07 AM Changeset in webkit [202731] by fred.wang@free.fr
  • 4 edits in trunk/LayoutTests

Fix warnings about non existent paths in TestExpectations

Unreviewed test gardening.

Patch by Frederic Wang <​fwang@igalia.com> on 2016-07-01

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/win/TestExpectations:
5:07 AM QtWebKitSecurity edited by Konstantin Tokarev
qtwebkit-announce mailing list does not exist anymore (diff)
5:01 AM QtWebKitReleases edited by Konstantin Tokarev
qtwebkit-announce mailing list does not exist anymore (diff)
4:48 AM Acronyms edited by Konstantin Tokarev
Remove GYP and KURL (diff)
4:47 AM Acronyms edited by Konstantin Tokarev
Added definition for DFG and cross-reference for JSC (diff)
4:16 AM Acronyms edited by Konstantin Tokarev
(diff)
3:53 AM LayoutTestDashboards edited by Konstantin Tokarev
NWRT has superceded old run-webkit-tests (diff)
3:52 AM Writing Reftests edited by Konstantin Tokarev
NWRT has superceded old run-webkit-tests (diff)
3:30 AM Changeset in webkit [202730] by fred.wang@free.fr
  • 2 edits in trunk/LayoutTests

Fix error in r202729

Unreviewed test gardening.

Patch by Frederic Wang <​fwang@igalia.com> on 2016-07-01

  • platform/ios-simulator/TestExpectations: Revert unintentional change of horizontal-munderover.
2:52 AM Changeset in webkit [202729] by fred.wang@free.fr
  • 4 edits in trunk/LayoutTests

Reorganize and improve comments for MathML test expectations on ios and mac.

Unreviewed test gardening.

Patch by Frederic Wang <​fwang@igalia.com> on 2016-07-01

  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-simulator/TestExpectations:
  • platform/mac/TestExpectations:
12:47 AM Changeset in webkit [202728] by commit-queue@webkit.org
  • 35 edits in trunk

Add a runtime flag for DOM iterators
​https://bugs.webkit.org/show_bug.cgi?id=159300

Patch by Youenn Fablet <​youennf@gmail.com> on 2016-07-01
Reviewed by Alex Christensen.

Source/JavaScriptCore:

  • runtime/CommonIdentifiers.h:

Source/WebCore:

  • Modules/fetch/FetchHeaders.idl: Making iterator runtime-enabled.
  • bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setDOMIteratorEnabled):
(WebCore::RuntimeEnabledFeatures::domIteratorEnabled):

  • bindings/scripts/CodeGeneratorJS.pm:

(ToMethodName): Fixing dOM -> dom casing issue.
(GenerateImplementation): Using addIterableProperties new method.
(addIterableProperties): Activating property addition according runtime flag if iterator is rnutime flagged.

  • bindings/scripts/IDLParser.pm:

(parseOptionalIterableInterface): Adding extendedAttributes to iterable.

  • bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::JSTestNodePrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjPrototype::finishCreation):

  • bindings/scripts/test/TestNode.idl: Making iterator runtime-enabled.
  • bindings/scripts/test/TestObj.idl: Ditto.
  • css/FontFaceSet.idl: Ditto.
  • dom/NodeList.idl: Ditto.

Source/WebKit/mac:

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(-[WebPreferences DOMIteratorEnabled]):
(-[WebPreferences setDOMIteratorEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit/win:

  • WebPreferenceKeysPrivate.h:
  • WebPreferences.cpp:

(WebPreferences::domIteratorEnabled):
(WebPreferences::setDOMIteratorEnabled):
(WebView::notifyPreferencesChanged):

  • WebPreferencesreferences.h:
  • WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WebKit2:

  • Shared/WebPreferencesDefinitions.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

  • DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):

  • Scripts/webkitperl/FeatureList.pm:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setDOMIteratorEnabled):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
12:29 AM Changeset in webkit [202727] by fred.wang@free.fr
  • 25 edits in trunk/Source/WebCore

Eliminate trailing whitespace in MathML code
​https://bugs.webkit.org/show_bug.cgi?id=159091

Patch by Frederic Wang <fwang.igalia.com> on 2016-07-01
Reviewed by Alex Christensen.

No new tests, behavior is unchanged.

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::baselinePosition):
(WebCore::RenderMathMLBlock::paint):
(WebCore::parseMathMLNamedSpace):

  • rendering/mathml/RenderMathMLBlock.h:
  • rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::updateFromElement):
(WebCore::RenderMathMLFenced::addChild):

  • rendering/mathml/RenderMathMLFenced.h:
  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::styleDidChange):
(WebCore::RenderMathMLFraction::paint):

  • rendering/mathml/RenderMathMLFraction.h:
  • rendering/mathml/RenderMathMLMath.h:
  • rendering/mathml/RenderMathMLMenclose.h:
  • rendering/mathml/RenderMathMLOperator.cpp:
  • rendering/mathml/RenderMathMLOperator.h:
  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::paint):

  • rendering/mathml/RenderMathMLScripts.cpp:
  • rendering/mathml/RenderMathMLSpace.cpp:
  • rendering/mathml/RenderMathMLSpace.h:
  • rendering/mathml/RenderMathMLToken.h:
  • rendering/mathml/RenderMathMLUnderOver.cpp:
  • rendering/mathml/RenderMathMLUnderOver.h:
12:06 AM Changeset in webkit [202726] by fred.wang@free.fr
  • 2 edits in trunk/Source/WebCore

Small cleanup: Remove unused functions RenderObject::isRenderMathML*Wrapper
​https://bugs.webkit.org/show_bug.cgi?id=159333

Patch by Frederic Wang <​fwang@igalia.com> on 2016-07-01
Reviewed by Alex Christensen.

After the refactoring of RenderMathMLRoot and RenderMathMLScripts, the anonymous flexbox
wrappers used in the old layout implementation have been removed. We thus remove the
corresponding isRender* function from RenderObject.

No new tests, behavior is unchanged.

  • rendering/RenderObject.h:

(WebCore::RenderObject::isRenderMathMLRootWrapper): Deleted.
(WebCore::RenderObject::isRenderMathMLScriptsWrapper): Deleted.

Note: See TracTimeline for information about the timeline view.