Timeline
Jul 13, 2016:
- 11:36 PM Changeset in webkit [203216] by
-
- 4 edits in trunk/Source/WebCore
[GLib] Use a GSource instead of a thread to poll memory pressure eventFD in linux implementation
https://bugs.webkit.org/show_bug.cgi?id=159346
Reviewed by Antonio Gomes.
The eventFD file descriptor is pollable, so it would be much better to use a poll instead of a blocking read in
a secondary thread and then communicate back to the main thread. This is very easy to do with GSource in GLib,
so we could use that when GLib is available and keep the current implementation as a fallback.
- platform/MemoryPressureHandler.cpp:
(WebCore::m_holdOffTimer): Use a RunLoop timer.
- platform/MemoryPressureHandler.h:
- platform/linux/MemoryPressureHandlerLinux.cpp:
(WebCore::MemoryPressureHandler::EventFDPoller::EventFDPoller): Helper class do the eventFD polling.
(WebCore::MemoryPressureHandler::logErrorAndCloseFDs): Check if file descriptors are -1 not 0.
(WebCore::MemoryPressureHandler::install): Return early also if the hold off timer is active. Use EventFDPoller
to do the polling.
(WebCore::MemoryPressureHandler::uninstall): Stop the hold off timer and clear the EventFDPoller.
- 11:34 PM Changeset in webkit [203215] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION(r202273): [GTK] Redirected X window is resized to the previous size on size allocate
https://bugs.webkit.org/show_bug.cgi?id=159551
Reviewed by Michael Catanzaro.
In r202273 I added webkitWebViewBaseResizeRedirectedWindow() helper to remove duplicated code in all places
where we were resizing the redirected window to the current drawing area size. But on size allocate, we were
updating the redirected window first, and then the drawing area, to ensure that when the drawing area notifies
the web process the redirected window is already at the new size. This regression doesn't have any visual
effect, because we are ensure the right size always before rendering, but there's a small extra resize in this case.
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseSizeAllocate): Resize the redirected window before updating the drawing area size.
- 11:17 PM Changeset in webkit [203214] by
-
- 2 edits in trunk/Tools
Test WTF.StringViewIterators is crashing since r203119
https://bugs.webkit.org/show_bug.cgi?id=159710
Reviewed by Darin Adler.
There are two problems in the test case added in r203119. First is that it's testing
StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that
StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a
const reference to the string view member of the deleted CodePoints object.
- TestWebKitAPI/Tests/WTF/StringView.cpp:
(TestWebKitAPI::TEST):
- 10:24 PM Changeset in webkit [203213] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix the magic numbers for ARM traditional in InlineAccess.h
https://bugs.webkit.org/show_bug.cgi?id=159708
Reviewed by Saam Barati.
- bytecode/InlineAccess.h:
(JSC::InlineAccess::sizeForPropertyAccess):
(JSC::InlineAccess::sizeForPropertyReplace):
(JSC::InlineAccess::sizeForLengthAccess):
- 9:55 PM Changeset in webkit [203212] by
-
- 25 edits in trunk/LayoutTests
Rebaseline EFL and Windows MathML tests after r203171
Unreviewed test gardening.
Patch by Frederic Wang <fwang@igalia.com> on 2016-07-13
- platform/efl/mathml/opentype/horizontal-expected.txt:
- platform/efl/mathml/opentype/horizontal-munderover-expected.txt:
- platform/efl/mathml/opentype/large-operators-expected.txt:
- platform/efl/mathml/opentype/opentype-stretchy-expected.txt:
- platform/efl/mathml/opentype/opentype-stretchy-horizontal-expected.txt:
- platform/efl/mathml/opentype/vertical-expected.txt:
- platform/efl/mathml/presentation/menclose-notation-default-longdiv-expected.txt:
- platform/efl/mathml/presentation/menclose-notation-values-expected.txt:
- platform/efl/mathml/presentation/mo-stretch-expected.txt:
- platform/efl/mathml/presentation/mspace-children-expected.txt:
- platform/efl/mathml/presentation/roots-expected.txt:
- platform/efl/mathml/radical-fallback-expected.txt:
- platform/win/mathml/mathml-in-dashboard-expected.txt:
- platform/win/mathml/opentype/horizontal-expected.txt:
- platform/win/mathml/opentype/horizontal-munderover-expected.txt:
- platform/win/mathml/opentype/large-operators-expected.txt:
- platform/win/mathml/opentype/opentype-stretchy-expected.txt:
- platform/win/mathml/opentype/opentype-stretchy-horizontal-expected.txt:
- platform/win/mathml/opentype/vertical-expected.txt:
- platform/win/mathml/presentation/menclose-notation-default-longdiv-expected.txt:
- platform/win/mathml/presentation/mo-stretch-expected.txt:
- platform/win/mathml/presentation/mspace-children-expected.txt:
- platform/win/mathml/presentation/roots-expected.txt:
- platform/win/mathml/radical-fallback-expected.txt:
- 8:45 PM Changeset in webkit [203211] by
-
- 2 edits in trunk/Source/WebCore
[CSS][ARMv7] :nth-child() do not reserve enough registers if it is in backtracking chain
https://bugs.webkit.org/show_bug.cgi?id=159746
rdar://problem/26156169
Reviewed by Andreas Kling.
The generator generateElementIsNthChild() requires 6 registers in style resolution
to mark previous siblings with generateAddStyleRelationIfResolvingStyle() in the loop.
We were only reserving 5, which is a problem is the sixth is taken by the backtracking
register. x86_64 was already requiring 6 for unrelated reasons and ARM64 has so many registers
that you cannot possibly run out of them in CSS JIT.
I generalized the x86_64 path to all architectures.
I did not limit this case to style resolution because the extra register is irrelevant
in most cases. The only difference is one extra push/pop on ARMv7 if you use querySelector
with :nth-child in a backtracking chain.
This problem is covered by the existing test fast/selectors/nth-child-with-backtracking.html
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::minimumRegisterRequirements): Deleted.
- 8:43 PM Changeset in webkit [203210] by
-
- 2 edits in trunk/Source/WebCore
Drop unnecessary check from ContainerNode::removeChild()
https://bugs.webkit.org/show_bug.cgi?id=159747
Reviewed by Andreas Kling.
Drop unnecessary check from ContainerNode::removeChild() to make sure that
the parent of the node being removed is |this|. We already do this check
a few lines above. The only thing that happens in between is the ref'ing
of the node, which does not cause any JS execution.
This check was introduced in r55783 because there used to be a call to
document()->removeFocusedNodeOfSubtree(child.get());
between the two checks. However, this call has been removed since then
and the extra parentNode() check was left in.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::removeChild): Deleted.
- 7:38 PM Changeset in webkit [203209] by
-
- 3 edits in trunk/Tools
[iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it
https://bugs.webkit.org/show_bug.cgi?id=159738
<rdar://problem/27304649>
Reviewed by Dan Bernstein.
The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be
code signed if applicable. We should also copy this bundle into the PlugIns subdirectory
of the WebKitTestRunnerApp.app bundle instead of the top-level bundle directory as the
PlugIns subdirectory is the directory where loadable bundles of an app are expected to live.
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::initializeInjectedBundlePath): Modified code to look for the
bundle WebKitTestRunnerInjectedBundle.bundle in the plugin directory of the main bundle.
- 7:01 PM Changeset in webkit [203208] by
-
- 2 edits in trunk/Source/WTF
Addressing post-review comments after r203119
https://bugs.webkit.org/show_bug.cgi?id=159749
Unreviewed.
- wtf/text/StringView.h:
(WTF::StringView::CodePoints::Iterator::Iterator):
(WTF::StringView::CodePoints::Iterator::operator*):
(WTF::StringView::CodePoints::Iterator::operator==):
- 6:45 PM Changeset in webkit [203207] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, rebaseline tests for ES6 TypedArray behavior.
- js/typed-array-mutated-during-set-expected.txt:
- js/typed-array-mutated-during-set.html:
- 6:20 PM Changeset in webkit [203206] by
-
- 5 edits1 add in trunk/Source/JavaScriptCore
YARR uses mixture of int and unsigned values to index into subject string
https://bugs.webkit.org/show_bug.cgi?id=159744
Reviewed by Benjamin Poulain.
In most cases, we refer to characters in subject strings using a negative index from the number of
"checked" characters in a subject string. The required length is compared against the actual length
and then we use that required length as the checked amount. For example, when matching the string of
4 digits in the RegExp /abc \d{4}/, we know that need 8 characters in the subject string. We refer
to the digits part of the expression from an already checked index of 8 and use negative offsets of
-4 through -1. In many cases we used a signed int for the negative offsets. There are other cases
where we used unsigned values as the amount of negative offset to use when accessing subject characters.
Changed all occurrances of character offsets to unsigned or Checked Arithmetic unsigned values. Note
that the pre-existing Checked class is used in other places to check for under/overflow with arithmetic
operations. Those unsigned offsets are always the number of characters before (negative) from the
current checked character offset. Also added some asserts for cases where arithmetic is not protected
by other checks or with Checked<> wrapped values.
In the case of the JIT, subject characters are accessed using base with scaled index and offset
addressing. The MacroAssembler provides this addressing using the BaseIndex struct. The offset for
this struct is a 32 bit signed quantity. Since we only care about negative offsets, we really only
have 31 bits. Changed the generation of a BaseOffset address to handle the case when the offset and
scaled combination will exceed the 31 bits of negative offset. This is done by moving the base value
into a temp register and biasing the temp base and offset to smaller values so that we can emit
instructions that can reference characters without exceeding the 31 bits of negative offset.
To abstract the character address generation, put the base with scaled index and offset into
one function and used that function everywhere the YARR JIT wants to access subject characters.
Also consilidated a few cases where we were generating inline what readCharacter() does. Usually
this was due to using a different index register.
Added a new regression test.
- tests/stress/regress-159744.js: Added regression test.
(testRegExp):
- yarr/YarrInterpreter.cpp:
(JSC::Yarr::Interpreter::recordParenthesesMatch):
(JSC::Yarr::Interpreter::resetMatches):
(JSC::Yarr::Interpreter::matchParenthesesOnceEnd):
(JSC::Yarr::Interpreter::backtrackParenthesesOnceEnd):
(JSC::Yarr::ByteCompiler::closeBodyAlternative):
(JSC::Yarr::ByteCompiler::atomParenthesesSubpatternEnd):
(JSC::Yarr::ByteCompiler::atomParenthesesOnceEnd):
(JSC::Yarr::ByteCompiler::atomParenthesesTerminalEnd):
(JSC::Yarr::ByteCompiler::emitDisjunction):
- yarr/YarrInterpreter.h:
(JSC::Yarr::ByteTerm::ByteTerm):
(JSC::Yarr::ByteTerm::BOL):
(JSC::Yarr::ByteTerm::UncheckInput):
(JSC::Yarr::ByteTerm::EOL):
(JSC::Yarr::ByteTerm::WordBoundary):
(JSC::Yarr::ByteTerm::BackReference):
- yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::notAtEndOfInput):
(JSC::Yarr::YarrGenerator::negativeOffsetIndexedAddress):
(JSC::Yarr::YarrGenerator::readCharacter):
(JSC::Yarr::YarrGenerator::jumpIfCharNotEquals):
(JSC::Yarr::YarrGenerator::storeToFrame):
(JSC::Yarr::YarrGenerator::generateAssertionBOL):
(JSC::Yarr::YarrGenerator::backtrackAssertionBOL):
(JSC::Yarr::YarrGenerator::generateAssertionEOL):
(JSC::Yarr::YarrGenerator::matchAssertionWordchar):
(JSC::Yarr::YarrGenerator::generateAssertionWordBoundary):
(JSC::Yarr::YarrGenerator::generatePatternCharacterOnce):
(JSC::Yarr::YarrGenerator::generatePatternCharacterFixed):
(JSC::Yarr::YarrGenerator::generatePatternCharacterGreedy):
(JSC::Yarr::YarrGenerator::backtrackPatternCharacterNonGreedy):
(JSC::Yarr::YarrGenerator::generateCharacterClassOnce):
(JSC::Yarr::YarrGenerator::generateCharacterClassFixed):
(JSC::Yarr::YarrGenerator::generateCharacterClassGreedy):
(JSC::Yarr::YarrGenerator::backtrackCharacterClassNonGreedy):
(JSC::Yarr::YarrGenerator::generate):
(JSC::Yarr::YarrGenerator::backtrack):
(JSC::Yarr::YarrGenerator::YarrGenerator):
- yarr/YarrPattern.h:
(JSC::Yarr::PatternTerm::PatternTerm):
- 5:52 PM Changeset in webkit [203205] by
-
- 1 copy in tags/Safari-602.1.40.1.1
New tag.
- 5:15 PM Changeset in webkit [203204] by
-
- 8 edits in trunk/Source/JavaScriptCore
Crashes with detached ArrayBuffers
https://bugs.webkit.org/show_bug.cgi?id=157088
<rdar://problem/27327362>
Reviewed by Filip Pizlo.
TypedArray.prototype.fill was incorrect because it should perform
ToNumber coercion each time it tries to store the
object. Currently, we only perform the coercion once at the
beginning of the loop. If we find that we need to improve the
performance of this function, we can add a faster C++ path back
that only handles the primitive case.
This patch also moves the isNeutered() checks from put and
putByIndex into setIndex. This fixes an issue where setIndex might
store to a no longer valid offset.
- builtins/TypedArrayPrototype.js:
(globalPrivate.typedArrayClampArgumentToStartOrEnd):
(fill):
- runtime/JSGenericTypedArrayView.h:
(JSC::JSGenericTypedArrayView::setIndexQuickly):
(JSC::JSGenericTypedArrayView::setIndex):
(JSC::JSGenericTypedArrayView::setRangeToValue): Deleted.
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::JSGenericTypedArrayView<Adaptor>::put): Deleted.
(JSC::JSGenericTypedArrayView<Adaptor>::putByIndex): Deleted.
- runtime/JSGenericTypedArrayViewPrototypeFunctions.h:
(JSC::genericTypedArrayViewProtoFuncFill): Deleted.
- runtime/JSTypedArrayViewPrototype.cpp:
(JSC::JSTypedArrayViewPrototype::finishCreation):
(JSC::typedArrayViewProtoFuncFill): Deleted.
- tests/stress/typedarray-fill.js:
- tests/stress/typedarray-functions-with-neutered.js:
(defaultForArg):
(test2):
(checkArgumentsForType): Deleted.
(checkArguments): Deleted.
- 5:12 PM Changeset in webkit [203203] by
-
- 2 edits in trunk/Tools
Attempted build fix.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- 5:11 PM Changeset in webkit [203202] by
-
- 3 edits3 adds in trunk
Some bad unicode regex escapes aren't flagged as errors
https://bugs.webkit.org/show_bug.cgi?id=158080
Reviewed by Saam Barati.
Source/JavaScriptCore:
If we have a partial unicode escape, eg /\u{1/u or /\u12|abc/u, we
didn't check for the closing '}' and processed the unicode escape with
the hex value provided.
Added a check that we properly terminated a \u{} unicode escape.
If we fail that check and there isn't a prior error, we record that we
have an invalid unicode escape. The next existing line in the code will
terminate parsing and bubble up the error.
- yarr/YarrParser.h:
(JSC::Yarr::Parser::parseEscape):
LayoutTests:
New tests.
- js/regress-158080.html: Added.
- js/script-tests/regress-158080.js: Added.
- 5:08 PM Changeset in webkit [203201] by
-
- 3 edits118 adds in trunk/LayoutTests
Import W3C WebCryptoAPI tests
https://bugs.webkit.org/show_bug.cgi?id=159636
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- WebCryptoAPI/OWNERS: Added.
- WebCryptoAPI/README.md: Added.
- WebCryptoAPI/WebCryptoAPI.idl: Added.
- WebCryptoAPI/digest/digest.js: Added.
(run_test.):
(run_test.copyBuffer):
(run_test.equalBuffers):
(run_test):
- WebCryptoAPI/digest/digest.worker.js: Added.
- WebCryptoAPI/digest/test_digest-expected.txt: Added.
- WebCryptoAPI/digest/test_digest.html: Added.
- WebCryptoAPI/digest/w3c-import.log: Added.
- WebCryptoAPI/encrypt_decrypt/aes.js: Added.
(run_test.):
(run_test.importVectorKey):
(run_test):
(run_test.equalBuffers):
- WebCryptoAPI/encrypt_decrypt/aes_cbc.worker.js: Added.
- WebCryptoAPI/encrypt_decrypt/aes_cbc_vectors.js: Added.
(getTestVectors):
- WebCryptoAPI/encrypt_decrypt/aes_ctr.worker.js: Added.
- WebCryptoAPI/encrypt_decrypt/aes_ctr_vectors.js: Added.
(getTestVectors):
- WebCryptoAPI/encrypt_decrypt/aes_gcm.worker.js: Added.
- WebCryptoAPI/encrypt_decrypt/aes_gcm_vectors.js: Added.
(getTestVectors):
- WebCryptoAPI/encrypt_decrypt/rsa.js: Added.
(run_test.):
(run_test.else):
(run_test.importVectorKeys):
(run_test.copyBuffer):
(run_test.equalBuffers):
(run_test):
- WebCryptoAPI/encrypt_decrypt/rsa.worker.js: Added.
- WebCryptoAPI/encrypt_decrypt/rsa_vectors.js: Added.
(getTestVectors):
- WebCryptoAPI/encrypt_decrypt/test_aes_cbc-expected.txt: Added.
- WebCryptoAPI/encrypt_decrypt/test_aes_cbc.html: Added.
- WebCryptoAPI/encrypt_decrypt/test_aes_ctr-expected.txt: Added.
- WebCryptoAPI/encrypt_decrypt/test_aes_ctr.html: Added.
- WebCryptoAPI/encrypt_decrypt/test_aes_gcm-expected.txt: Added.
- WebCryptoAPI/encrypt_decrypt/test_aes_gcm.html: Added.
- WebCryptoAPI/encrypt_decrypt/test_rsa_oaep-expected.txt: Added.
- WebCryptoAPI/encrypt_decrypt/test_rsa_oaep.html: Added.
- WebCryptoAPI/encrypt_decrypt/w3c-import.log: Added.
- WebCryptoAPI/generateKey/failures.js: Added.
(run_test.parameterString):
(run_test.testError):
(run_test):
(run_test.invalidUsages):
(run_test.):
- WebCryptoAPI/generateKey/failures.worker.js: Added.
- WebCryptoAPI/generateKey/failures_AES-CBC.worker.js: Added.
- WebCryptoAPI/generateKey/failures_AES-CTR.worker.js: Added.
- WebCryptoAPI/generateKey/failures_AES-GCM.worker.js: Added.
- WebCryptoAPI/generateKey/failures_AES-KW.worker.js: Added.
- WebCryptoAPI/generateKey/failures_ECDH.worker.js: Added.
- WebCryptoAPI/generateKey/failures_ECDSA.worker.js: Added.
- WebCryptoAPI/generateKey/failures_HMAC.worker.js: Added.
- WebCryptoAPI/generateKey/failures_RSA-OAEP.worker.js: Added.
- WebCryptoAPI/generateKey/failures_RSA-PSS.worker.js: Added.
- WebCryptoAPI/generateKey/failures_RSASSA-PKCS1-v1_5.worker.js: Added.
- WebCryptoAPI/generateKey/successes.js: Added.
(run_test.parameterString):
(run_test.):
(run_test.testSuccess):
(run_test):
- WebCryptoAPI/generateKey/successes.worker.js: Added.
- WebCryptoAPI/generateKey/successes_AES-CBC.worker.js: Added.
- WebCryptoAPI/generateKey/successes_AES-CTR.worker.js: Added.
- WebCryptoAPI/generateKey/successes_AES-GCM.worker.js: Added.
- WebCryptoAPI/generateKey/successes_AES-KW.worker.js: Added.
- WebCryptoAPI/generateKey/successes_ECDH.worker.js: Added.
- WebCryptoAPI/generateKey/successes_ECDSA.worker.js: Added.
- WebCryptoAPI/generateKey/successes_HMAC.worker.js: Added.
- WebCryptoAPI/generateKey/successes_RSA-OAEP.worker.js: Added.
- WebCryptoAPI/generateKey/successes_RSA-PSS.worker.js: Added.
- WebCryptoAPI/generateKey/successes_RSASSA-PKCS1-v1_5.worker.js: Added.
- WebCryptoAPI/generateKey/test_aes-cbc-expected.txt: Added.
- WebCryptoAPI/generateKey/test_aes-cbc.html: Added.
- WebCryptoAPI/generateKey/test_aes-ctr-expected.txt: Added.
- WebCryptoAPI/generateKey/test_aes-ctr.html: Added.
- WebCryptoAPI/generateKey/test_failures-expected.txt: Added.
- WebCryptoAPI/generateKey/test_failures.html: Added.
- WebCryptoAPI/generateKey/test_failures_AES-CBC-expected.txt: Added.
- WebCryptoAPI/generateKey/test_failures_AES-CBC.html: Added.
- WebCryptoAPI/generateKey/test_failures_AES-CTR-expected.txt: Added.
- WebCryptoAPI/generateKey/test_failures_AES-CTR.html: Added.
- WebCryptoAPI/generateKey/test_failures_AES-GCM-expected.txt: Added.
- WebCryptoAPI/generateKey/test_failures_AES-GCM.html: Added.
- WebCryptoAPI/generateKey/test_failures_AES-KW-expected.txt: Added.
- WebCryptoAPI/generateKey/test_failures_AES-KW.html: Added.
- WebCryptoAPI/generateKey/test_failures_ECDH-expected.txt: Added.
- WebCryptoAPI/generateKey/test_failures_ECDH.html: Added.
- WebCryptoAPI/generateKey/test_failures_ECDSA-expected.txt: Added.
- WebCryptoAPI/generateKey/test_failures_ECDSA.html: Added.
- WebCryptoAPI/generateKey/test_failures_HMAC-expected.txt: Added.
- WebCryptoAPI/generateKey/test_failures_HMAC.html: Added.
- WebCryptoAPI/generateKey/test_failures_RSA-OAEP-expected.txt: Added.
- WebCryptoAPI/generateKey/test_failures_RSA-OAEP.html: Added.
- WebCryptoAPI/generateKey/test_failures_RSA-PSS-expected.txt: Added.
- WebCryptoAPI/generateKey/test_failures_RSA-PSS.html: Added.
- WebCryptoAPI/generateKey/test_failures_RSASSA-PKCS1-v1_5-expected.txt: Added.
- WebCryptoAPI/generateKey/test_failures_RSASSA-PKCS1-v1_5.html: Added.
- WebCryptoAPI/generateKey/test_successes-expected.txt: Added.
- WebCryptoAPI/generateKey/test_successes.html: Added.
- WebCryptoAPI/generateKey/test_successes_AES-CBC-expected.txt: Added.
- WebCryptoAPI/generateKey/test_successes_AES-CBC.html: Added.
- WebCryptoAPI/generateKey/test_successes_AES-CTR-expected.txt: Added.
- WebCryptoAPI/generateKey/test_successes_AES-CTR.html: Added.
- WebCryptoAPI/generateKey/test_successes_AES-GCM-expected.txt: Added.
- WebCryptoAPI/generateKey/test_successes_AES-GCM.html: Added.
- WebCryptoAPI/generateKey/test_successes_AES-KW-expected.txt: Added.
- WebCryptoAPI/generateKey/test_successes_AES-KW.html: Added.
- WebCryptoAPI/generateKey/test_successes_ECDH-expected.txt: Added.
- WebCryptoAPI/generateKey/test_successes_ECDH.html: Added.
- WebCryptoAPI/generateKey/test_successes_ECDSA-expected.txt: Added.
- WebCryptoAPI/generateKey/test_successes_ECDSA.html: Added.
- WebCryptoAPI/generateKey/test_successes_HMAC-expected.txt: Added.
- WebCryptoAPI/generateKey/test_successes_HMAC.html: Added.
- WebCryptoAPI/generateKey/test_successes_RSA-OAEP-expected.txt: Added.
- WebCryptoAPI/generateKey/test_successes_RSA-OAEP.html: Added.
- WebCryptoAPI/generateKey/test_successes_RSA-PSS-expected.txt: Added.
- WebCryptoAPI/generateKey/test_successes_RSA-PSS.html: Added.
- WebCryptoAPI/generateKey/test_successes_RSASSA-PKCS1-v1_5-expected.txt: Added.
- WebCryptoAPI/generateKey/test_successes_RSASSA-PKCS1-v1_5.html: Added.
- WebCryptoAPI/generateKey/w3c-import.log: Added.
- WebCryptoAPI/getRandomValues.js: Added.
(run_test.):
(run_test):
- WebCryptoAPI/getRandomValues.worker.js: Added.
- WebCryptoAPI/idlharness-expected.txt: Added.
- WebCryptoAPI/idlharness.html: Added.
- WebCryptoAPI/idlharness.worker.js: Added.
(request.onload):
- WebCryptoAPI/test_getRandomValues-expected.txt: Added.
- WebCryptoAPI/test_getRandomValues.html: Added.
- WebCryptoAPI/tools/generate.py: Added.
- WebCryptoAPI/tools/w3c-import.log: Added.
- WebCryptoAPI/util/helpers.js: Added.
(allNonemptySubsetsOf):
(objectToString.):
(objectToString):
(assert_goodCryptoKey):
(allAlgorithmSpecifiersFor):
(allValidUsages):
(allNameVariants):
- WebCryptoAPI/util/w3c-import.log: Added.
- WebCryptoAPI/w3c-import.log: Added.
LayoutTests:
Skip test cases for unimplemented features.
- 4:54 PM Changeset in webkit [203200] by
-
- 8 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r203199.
Broke the build
Reverted changeset:
"Crashes with detached ArrayBuffers"
https://bugs.webkit.org/show_bug.cgi?id=157088
http://trac.webkit.org/changeset/203199
- 4:38 PM Changeset in webkit [203199] by
-
- 8 edits in trunk/Source/JavaScriptCore
Crashes with detached ArrayBuffers
https://bugs.webkit.org/show_bug.cgi?id=157088
<rdar://problem/27327362>
Reviewed by Filip Pizlo.
TypedArray.prototype.fill was incorrect because it should perform
ToNumber coercion each time it tries to store the
object. Currently, we only perform the coercion once at the
beginning of the loop. If we find that we need to improve the
performance of this function, we can add a faster C++ path back
that only handles the primitive case.
This patch also moves the isNeutered() checks from put and
putByIndex into setIndex. This fixes an issue where setIndex might
store to a no longer valid offset.
- builtins/TypedArrayPrototype.js:
(globalPrivate.typedArrayClampArgumentToStartOrEnd):
(fill):
- runtime/JSGenericTypedArrayView.h:
(JSC::JSGenericTypedArrayView::setIndexQuickly):
(JSC::JSGenericTypedArrayView::setIndex):
(JSC::JSGenericTypedArrayView::setRangeToValue): Deleted.
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::JSGenericTypedArrayView<Adaptor>::put): Deleted.
(JSC::JSGenericTypedArrayView<Adaptor>::putByIndex): Deleted.
- runtime/JSGenericTypedArrayViewPrototypeFunctions.h:
(JSC::genericTypedArrayViewProtoFuncFill): Deleted.
- runtime/JSTypedArrayViewPrototype.cpp:
(JSC::JSTypedArrayViewPrototype::finishCreation):
(JSC::typedArrayViewProtoFuncFill): Deleted.
- tests/stress/typedarray-fill.js:
- tests/stress/typedarray-functions-with-neutered.js:
(defaultForArg):
(test2):
(checkArgumentsForType): Deleted.
(checkArguments): Deleted.
- 4:33 PM Changeset in webkit [203198] by
-
- 2 edits in trunk/Source/WebInspectorUI
Uncaught Exception: TypeError: null is not an object (evaluating 'this._contentViewContainer.currentContentView.showsFilterBar')
https://bugs.webkit.org/show_bug.cgi?id=159696
<rdar://problem/27312356>
Reviewed by Joseph Pecoraro.
- UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype._contentViewSelectionPathComponentDidChange):
Early return if content view not visible, since the event is sent during
tab teardown and the current TimelineView may be invalid.
- 3:43 PM Changeset in webkit [203197] by
-
- 1 delete in trunk/Websites/test-results
Remove test-results.
- 3:42 PM Changeset in webkit [203196] by
-
- 20 edits in trunk/Source/WebKit2
[WK2] Use more references for connections
https://bugs.webkit.org/show_bug.cgi?id=159739
Reviewed by Alex Christensen.
Use more references for connections to make it more obvious they cannot
be null.
- DatabaseProcess/DatabaseToWebProcessConnection.cpp:
(WebKit::DatabaseToWebProcessConnection::DatabaseToWebProcessConnection):
- DatabaseProcess/DatabaseToWebProcessConnection.h:
(WebKit::DatabaseToWebProcessConnection::connection):
- DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp:
(WebKit::WebIDBConnectionToClient::messageSenderConnection):
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::NetworkConnectionToWebProcess):
(WebKit::NetworkConnectionToWebProcess::writeBlobsToTemporaryFiles):
- NetworkProcess/NetworkConnectionToWebProcess.h:
(WebKit::NetworkConnectionToWebProcess::connection):
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::messageSenderConnection):
- Shared/mac/CookieStorageShim.mm:
(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL):
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:
(WebKit::WebIDBConnectionToServer::messageSenderConnection):
(WebKit::preregisterSandboxExtensionsIfNecessary):
- WebProcess/Databases/WebToDatabaseProcessConnection.cpp:
(WebKit::WebToDatabaseProcessConnection::WebToDatabaseProcessConnection):
- WebProcess/Databases/WebToDatabaseProcessConnection.h:
(WebKit::WebToDatabaseProcessConnection::connection):
- WebProcess/FileAPI/BlobRegistryProxy.cpp:
(WebKit::BlobRegistryProxy::registerFileBlobURL):
(WebKit::BlobRegistryProxy::registerBlobURL):
(WebKit::BlobRegistryProxy::registerBlobURLOptionallyFileBacked):
(WebKit::BlobRegistryProxy::unregisterBlobURL):
(WebKit::BlobRegistryProxy::registerBlobURLForSlice):
(WebKit::BlobRegistryProxy::blobSize):
(WebKit::BlobRegistryProxy::writeBlobsToTemporaryFiles):
- WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::NetworkProcessConnection):
(WebKit::NetworkProcessConnection::writeBlobsToTemporaryFiles):
- WebProcess/Network/NetworkProcessConnection.h:
(WebKit::NetworkProcessConnection::connection):
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::scheduleLoad):
(WebKit::WebLoaderStrategy::remove):
(WebKit::WebLoaderStrategy::setDefersLoading):
(WebKit::WebLoaderStrategy::loadResourceSynchronously):
(WebKit::WebLoaderStrategy::createPingHandle):
- WebProcess/Network/WebResourceLoader.cpp:
(WebKit::WebResourceLoader::messageSenderConnection):
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::cookiesForDOM):
(WebKit::WebPlatformStrategies::setCookiesFromDOM):
(WebKit::WebPlatformStrategies::cookiesEnabled):
(WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue):
(WebKit::WebPlatformStrategies::getRawCookies):
(WebKit::WebPlatformStrategies::deleteCookie):
(WebKit::WebPlatformStrategies::addCookie):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::startDownload):
(WebKit::WebFrame::convertMainResourceLoadToDownload):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::ensureLegacyPrivateBrowsingSessionInNetworkProcess):
(WebKit::WebProcess::networkConnection):
(WebKit::WebProcess::prefetchDNS):
- WebProcess/WebProcess.h:
- 3:40 PM Changeset in webkit [203195] by
-
- 4 edits in trunk/Source/WebKit2
Move WKPreferencesRef functions to the correct file
https://bugs.webkit.org/show_bug.cgi?id=159741
Reviewed by Sam Weinig.
Also, get rid of WKPreferencesGetPaymentsEnabled and WKPreferencesSetPaymentsEnabled.
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesGetApplePayEnabled):
(WKPreferencesSetApplePayEnabled):
(WKPreferencesGetApplePayCapabilityDisclosureAllowed):
(WKPreferencesSetApplePayCapabilityDisclosureAllowed):
- UIProcess/API/C/WKPreferencesRef.h:
- UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:
(WKPreferencesGetApplePayEnabled): Deleted.
(WKPreferencesSetApplePayEnabled): Deleted.
(WKPreferencesGetApplePayCapabilityDisclosureAllowed): Deleted.
(WKPreferencesSetApplePayCapabilityDisclosureAllowed): Deleted.
(WKPreferencesGetPaymentsEnabled): Deleted.
(WKPreferencesSetPaymentsEnabled): Deleted.
- 3:18 PM Changeset in webkit [203194] by
-
- 2 edits in trunk/LayoutTests
Remove duplicated TestExpectation for perf/rel-list-remove.html on ios-simulator
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- 3:02 PM Changeset in webkit [203193] by
-
- 4 edits in trunk/LayoutTests
Test gardening for fast/text/font-face-javascript.html
https://bugs.webkit.org/show_bug.cgi?id=156631
Unreviewed.
- TestExpectations:
- fast/text/font-face-javascript-expected.txt:
- fast/text/font-face-javascript.html:
- 2:58 PM Changeset in webkit [203192] by
-
- 3 edits in trunk/Source/WebKit2
Add _applePayCapabilityDisclosureAllowed SPI declaration
https://bugs.webkit.org/show_bug.cgi?id=159740
Reviewed by Dan Bernstein.
Also, delete an old method that is no longer used.
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration _paymentsEnabled]): Deleted.
(-[WKWebViewConfiguration _setPaymentsEnabled:]): Deleted.
- 2:56 PM Changeset in webkit [203191] by
-
- 2 edits in tags/Safari-602.1.41/Source/WebCore
Merged r203172. rdar://problem/27306545
- 2:42 PM Changeset in webkit [203190] by
-
- 3 edits in trunk/LayoutTests
Marking imported/blink/storage/indexeddb/blob-valid-after-deletion.html as flaky on Mac and ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=158640
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- 2:33 PM Changeset in webkit [203189] by
-
- 2 edits in trunk/Source/WebKit2
Blank news article on kottke.org
https://bugs.webkit.org/show_bug.cgi?id=159733
<rdar://problem/26743065>
Reviewed by Simon Fraser.
This patch ensures that we update the visible content rect, when Auto Layout moves the WKWebView around.
We normally expect setFrameRect to be called to position WKWebView. However Auto Layout relies on layoutSubviews,
and in order to always have up-to-date visible content rect, we need to override layoutSubviews in WKWebView.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView layoutSubviews]):
- 2:14 PM Changeset in webkit [203188] by
-
- 1 edit4 adds in trunk/LayoutTests
Add test verifying detached iframes cannot set IDB values
https://bugs.webkit.org/show_bug.cgi?id=159736
Patch by Alex Christensen <achristensen@webkit.org> on 2016-07-13
Reviewed by Brady Eidson.
We match Chrome but not Firefox in this case.
- storage/indexeddb/detached-iframe-expected.txt: Added.
- storage/indexeddb/detached-iframe.html: Added.
- storage/indexeddb/resources/detached-iframe.html: Added.
- storage/indexeddb/resources/detached-iframe.js: Added.
(done):
(unexpectedErrorCallback):
(getRequestCallback):
(dbOpenedSecondTime):
(getValueFromIDB):
(makeDetachedFrame):
(prepareDatabase):
- 1:52 PM Changeset in webkit [203187] by
-
- 8 edits3 copies5 adds in trunk
REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker
https://bugs.webkit.org/show_bug.cgi?id=159686
Source/WebCore:
Reviewed by Chris Dumez.
The bug was caused by DOMActivate event not propagating out of the user-agent shadow tree
of a file input, and FileInputType not receiving the event to open the file picker.
Made DOMActivate "composed" event which cross shadow boundaries to fix the bug. The feedback
was given back to W3C on https://github.com/w3c/webcomponents/issues/513#issuecomment-231851617
Test: fast/forms/file/open-file-panel.html
- dom/Event.cpp:
(WebCore::Event::composed):
Tools:
Reviewed by Chris Dumez.
Added a code to print "OPEN FILE PANEL" in the text when runOpenPanel is called in the UI delegate.
- WebKitTestRunner/TestController.cpp:
(WTR::runOpenPanel):
(WTR::TestController::createOtherPage):
(WTR::TestController::createWebViewWithOptions):
LayoutTests:
<rdar://problem/27263589>
Reviewed by Chris Dumez.
Added a regression test for opening a file picker on a type=file input element.
The test currently only works on WebKit2 since the support for logging "OPEN FILE PANEL"
was only added to WebKitTestRunner.
Also added WebKit2 specific expected results for some tests that tries to open file panel.
- fast/forms/file/open-file-panel-expected.txt: Added.
- fast/forms/file/open-file-panel.html: Added.
- platform/ios-simulator-wk1/TestExpectations:
- platform/mac-wk1/TestExpectations:
- platform/win/TestExpectations:
- platform/wk2/accessibility: Added.
- platform/wk2/accessibility/axpress-on-aria-button-expected.txt: Copied from LayoutTests/accessibility/axpress-on-aria-button-expected.txt.
- platform/wk2/accessibility/file-upload-button-with-axpress-expected.txt: Copied from LayoutTests/accessibility/file-upload-button-with-axpress-expected.txt.
- platform/wk2/fast: Added.
- platform/wk2/fast/events: Added.
- platform/wk2/fast/events/domactivate-sets-underlying-click-event-as-handled-expected.txt: Copied from LayoutTests/fast/events/domactivate-sets-underlying-click-event-as-handled-expected.txt.
- 1:51 PM Changeset in webkit [203186] by
-
- 5 edits1 move1 add in trunk
Add more candidate tests
https://bugs.webkit.org/show_bug.cgi?id=159730
Reviewed by Tim Horton.
Source/WebKit/mac:
Move shouldRequestCandidates from WebViewInternal to WebViewPrivate so that
we can use it in tests.
- WebView/WebViewInternal.h:
- WebView/WebViewPrivate.h:
Tools:
This patch re-names ViewWithEditableAreaLeak.mm to CandidateTests.mm and adds
two new tests to that file.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Added.
- TestWebKitAPI/Tests/mac/CandidateTests.mm: Copied from TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm.
(-[CandidateRequestFrameLoadDelegate webView:didFinishLoadForFrame:]):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Removed.
- 1:33 PM Changeset in webkit [203185] by
-
- 2 adds in trunk/Websites/test-results
Update results-safari config.
- 1:32 PM Changeset in webkit [203184] by
-
- 2 edits in branches/safari-602.1.40.1-branch/Source/WebCore
Merged r203172. rdar://problem/27306545
- 1:31 PM Changeset in webkit [203183] by
-
- 5 edits in branches/safari-602.1.40.1-branch/Source
Versioning.
- 1:30 PM Changeset in webkit [203182] by
-
- 1 copy in branches/safari-602.1.40.1-branch
New Branch.
- 1:26 PM Changeset in webkit [203181] by
-
- 4 edits in tags/Safari-602.1.41
Merged r203167. rdar://problem/26358998
- 1:25 PM Changeset in webkit [203180] by
-
- 5 edits in branches/safari-602.1.40-branch/Source
Versioning.
- 1:23 PM Changeset in webkit [203179] by
-
- 5 edits in trunk/Source
Versioning.
- 1:20 PM Changeset in webkit [203178] by
-
- 1 copy in tags/Safari-602.1.41
New tag.
- 1:09 PM Changeset in webkit [203177] by
-
- 8 edits1 delete in trunk/Websites/test-results
Revert 203176.
- 1:04 PM Changeset in webkit [203176] by
-
- 8 edits1 add in trunk/Websites/test-results
Update command for the results maintenance script.
- 1:02 PM Changeset in webkit [203175] by
-
- 1 copy in tags/Safari-602.1.40.7
New tag.
- 1:01 PM Changeset in webkit [203174] by
-
- 2 edits in trunk/Source/WebKit2
WebKit2 shouldn't signal custom protocol clients from the NSURLConnection loader thread.
https://bugs.webkit.org/show_bug.cgi?id=159725
<rdar://problem/27323131>
Reviewed by Andy Estes.
WebKit2 shouldn't signal custom protocol clients from the NSURLConnection
loader thread. Instead, use the RunLoop the WKCustomProtocol was initialized
on.
- NetworkProcess/CustomProtocols/Cocoa/CustomProtocolManagerCocoa.mm:
(-[WKCustomProtocol initWithRequest:cachedResponse:client:]):
(WebKit::dispatchOnInitializationRunLoop):
(WebKit::CustomProtocolManager::didFailWithError):
(WebKit::CustomProtocolManager::didLoadData):
(WebKit::CustomProtocolManager::didReceiveResponse):
(WebKit::CustomProtocolManager::didFinishLoading):
(WebKit::CustomProtocolManager::wasRedirectedToRequest):
(WebKit::dispatchOnResourceLoaderRunLoop): Deleted.
- 1:00 PM Changeset in webkit [203173] by
-
- 4 edits in branches/safari-602.1.40-branch
Merged r203167. rdar://problem/26358998
- 12:17 PM Changeset in webkit [203172] by
-
- 2 edits in trunk/Source/WebCore
v2: WebContent crash due to RELEASE_ASSERT(!m_inLoadPendingImages) in StyleResolver::~StyleResolver()
https://bugs.webkit.org/show_bug.cgi?id=159722
Reviewed by Andreas Kling.
We have crashes where a StyleResolver is deleted underneath pseudoStyleForElement (key parts of the stack):
0 WebCore::StyleResolver::~StyleResolver
3 WebCore::AuthorStyleSheets::updateActiveStyleSheets
4 WebCore::Document::styleResolverChanged
5 WebKit::WebPage::viewportConfigurationChanged()
6 WebKit::WebPage::mainFrameDidLayout()
9 WebCore::FrameLoader::checkCompleted
13 WebCore::ResourceLoader::cancel
19 WebKit::WebLoaderStrategy::loadResource
24 WebCore::Style::loadPendingImage
27 WebCore::StyleResolver::pseudoStyleForElement
29 WebCore::RenderTreeUpdater::updateBeforeOrAfterPseudoElement
33 WebCore::Document::recalcStyle
This appears to be happening when a content blocker blocks a resource load for an image referenced from a stylesheet
and triggers synchronous cancellation of the load. With engine in suitable state this can clear style resolver.
No test, don't know how to make one. This is very timing and engine state dependent.
- dom/AuthorStyleSheets.cpp:
(WebCore::AuthorStyleSheets::updateActiveStyleSheets):
We have an existing check here that prevents destruction of the style resolver when we are in the middle of
a style resolution. However the old inStyleRecalc() bit no longer covers the render tree update phase. Pseudo
elements are resolved during render tree update.
Fix by adding a check for inRenderTreeUpdate() bit too.
This just fixes a regression. A proper fix would be to gather all resources during style resolution
and trigger the loads afterwards.
- 12:14 PM Changeset in webkit [203171] by
-
- 68 edits in trunk
Remove padding and margin around the <math> element
https://bugs.webkit.org/show_bug.cgi?id=157989
Source/WebCore:
Reviewed by Brent Fulgham.
No new tests, already covered by existing tests.
- css/mathml.css:
(math): Remove padding.
(math[display="block"]): Remove margin.
LayoutTests:
Patch by Frederic Wang <fwang@igalia.com> on 2016-07-13
Reviewed by Brent Fulgham.
- imported/mathml-in-html5/mathml/relations/html5-tree/href-click-1.html: Remove spacing hack.
- imported/mathml-in-html5/mathml/relations/html5-tree/href-click-2.html: Ditto.
- mathml/presentation/fractions-box-expected.html: Ditto.
- mathml/presentation/fractions-box.html: Ditto.
- mathml/presentation/href-enter.html: Ditto.
- mathml/presentation/maction-toggle-href.html: Ditto.
- mathml/presentation/mpadded-1-2.html: Ditto.
- mathml/presentation/mpadded-1.html: Ditto.
- mathml/presentation/mpadded-2.html: Ditto.
- mathml/presentation/mpadded-3.html: Ditto.
- mathml/presentation/mpadded-4-expected.html: Ditto.
- mathml/presentation/mpadded-4.html: Ditto.
- mathml/presentation/mspace-prefered-width.html: Ditto.
- mathml/presentation/mspace-units-expected.html: Ditto.
- mathml/presentation/mspace-units.html: Ditto.
- mathml/presentation/mspace.html: Ditto.
- mathml/presentation/scripts-height-expected.html: Ditto.
- mathml/presentation/scripts-subsup-expected.html: Ditto.
- mathml/presentation/scripts-subsup.html: Ditto.
- mathml/presentation/scripts-underover-expected.html: Ditto.
- mathml/presentation/scripts-underover.html: Ditto.
- mathml/presentation/semantics-2.html: Ditto.
- mathml/presentation/semantics-3.html: Ditto.
- mathml/presentation/semantics-4.html: Ditto.
- mathml/presentation/semantics-href.html: Ditto.
- mathml/presentation/style-border-padding-background.html: Ditto.
- platform/gtk/mathml/opentype/horizontal-expected.png: Rebaseline due to spacing change around the math tag.
- platform/gtk/mathml/opentype/horizontal-expected.txt: Ditto.
- platform/gtk/mathml/opentype/horizontal-munderover-expected.png: Ditto.
- platform/gtk/mathml/opentype/horizontal-munderover-expected.txt: Ditto.
- platform/gtk/mathml/opentype/large-operators-expected.txt: Ditto.
- platform/gtk/mathml/opentype/opentype-stretchy-expected.png: Ditto.
- platform/gtk/mathml/opentype/opentype-stretchy-expected.txt: Ditto.
- platform/gtk/mathml/opentype/opentype-stretchy-horizontal-expected.png: Ditto.
- platform/gtk/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Ditto.
- platform/gtk/mathml/opentype/vertical-expected.png: Ditto.
- platform/gtk/mathml/opentype/vertical-expected.txt: Ditto.
- platform/gtk/mathml/presentation/menclose-notation-default-longdiv-expected.png: Ditto.
- platform/gtk/mathml/presentation/menclose-notation-default-longdiv-expected.txt: Ditto.
- platform/gtk/mathml/presentation/menclose-notation-values-expected.png: Ditto.
- platform/gtk/mathml/presentation/menclose-notation-values-expected.txt: Ditto.
- platform/gtk/mathml/presentation/mo-stretch-expected.png: Ditto.
- platform/gtk/mathml/presentation/mo-stretch-expected.txt: Ditto.
- platform/gtk/mathml/presentation/mspace-children-expected.txt: Ditto.
- platform/gtk/mathml/presentation/roots-expected.png: Ditto.
- platform/gtk/mathml/presentation/roots-expected.txt: Ditto.
- platform/gtk/mathml/radical-fallback-expected.png: Ditto.
- platform/gtk/mathml/radical-fallback-expected.txt: Ditto.
- platform/ios-simulator/mathml/opentype/opentype-stretchy-expected.txt: Ditto.
- platform/ios-simulator/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Ditto.
- platform/ios-simulator/mathml/presentation/menclose-notation-default-longdiv-expected.txt: Ditto.
- platform/ios-simulator/mathml/presentation/menclose-notation-values-expected.txt: Ditto.
- platform/ios-simulator/mathml/presentation/mo-stretch-expected.txt: Ditto.
- platform/ios-simulator/mathml/presentation/mspace-children-expected.txt: Ditto.
- platform/ios-simulator/mathml/presentation/roots-expected.txt: Ditto.
- platform/ios-simulator/mathml/radical-fallback-expected.txt: Ditto.
- platform/mac/mathml/opentype/opentype-stretchy-expected.txt: Ditto.
- platform/mac/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Ditto.
- platform/mac/mathml/presentation/menclose-notation-default-longdiv-expected.txt: Ditto.
- platform/mac/mathml/presentation/menclose-notation-values-expected.txt: Ditto.
- platform/mac/mathml/presentation/mo-stretch-expected.txt: Ditto.
- platform/mac/mathml/presentation/mspace-children-expected.txt: Ditto.
- platform/mac/mathml/presentation/roots-expected.txt: Ditto.
- platform/mac/mathml/radical-fallback-expected.txt: Ditto.
- mathml/mathml-in-dashboard-expected.txt: Ditto
- 12:11 PM Changeset in webkit [203170] by
-
- 5 edits in trunk
AX: [ATK] spinbutton-crash.html fails
https://bugs.webkit.org/show_bug.cgi?id=159723
Reviewed by Chris Fleizach.
Tools:
Implement support for AXDecrementButton and AXIncrementButton in
ATK's AccessibilityUIElement::uiElementAttributeValue().
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::uiElementAttributeValue):
LayoutTests:
In ATK, the accessible object for an input element has no children for
the text component. As a result, the spinner is the first and only child.
In AXAPI, the input element has an AXGroup child for the text component.
As a result, the spinner is the second of two children. Therefore, add a
helper method to accessibility-helper.js to retrieve the correct child
for the current platform use it in spinbutton-crash.html.
- accessibility/spinbutton-crash.html: Modified.
- resources/accessibility-helper.js:
(spinnerForTextInput): Added.
- 11:44 AM Changeset in webkit [203169] by
-
- 14 edits in trunk/Source
Update supported platforms in xcconfig files to match the sdk names.
https://bugs.webkit.org/show_bug.cgi?id=159728
Reviewed by Tim Horton.
- Configurations/Base.xcconfig:
- 11:36 AM Changeset in webkit [203168] by
-
- 2 edits in trunk/Source/WebCore
"requiredShippingAddressFields" has been deprecated error thrown when using "requiredBillingAddressFields"
https://bugs.webkit.org/show_bug.cgi?id=159729
rdar://problem/27314974
Reviewed by Tim Horton.
Fix a paste-o.
- Modules/applepay/ApplePaySession.cpp:
(WebCore::createPaymentRequest):
- 10:49 AM Changeset in webkit [203167] by
-
- 4 edits in trunk
[Win] DLLs are missing version information.
https://bugs.webkit.org/show_bug.cgi?id=159349
Reviewed by Alex Christensen.
Avoid using environment variable WEBKIT_LIBRARIES when finding version stamper utility,
in case it is not defined. Instead, use the location of the perl script to find the
utility.
.:
- Source/cmake/tools/scripts/version-stamp.pl:
WebKitLibraries:
- win/tools/scripts/version-stamp.pl:
- 10:40 AM Changeset in webkit [203166] by
-
- 3 edits in trunk/LayoutTests
Marking imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-post-upload.htm as failing on Mac and ios-sim Release WK2
https://bugs.webkit.org/show_bug.cgi?id=159724
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 10:25 AM Changeset in webkit [203165] by
-
- 3 edits3 adds in trunk
[WK1][iOS] Crash when WebSocket attempts to dispatch a mixed content blocker event
https://bugs.webkit.org/show_bug.cgi?id=159680
<rdar://problem/22102028>
Reviewed by Zalan Bujtas.
Source/WebCore:
WK1 on iOS should not use RunLoop::main(). Instead, it should be dispatching events
on the WebThread.
Test: http/tests/ssl/mixedContent/insecure-websocket.html
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect): Do not use RunLoop::main() when we should be using
the WebThread.
LayoutTests:
- http/tests/ssl/mixedContent: Added.
- http/tests/ssl/mixedContent/insecure-websocket-expected.txt: Added.
- http/tests/ssl/mixedContent/insecure-websocket.html: Added.
- 9:30 AM Changeset in webkit [203164] by
-
- 44 edits117 adds in trunk/LayoutTests
Refresh WPT tests up to c875b42
https://bugs.webkit.org/show_bug.cgi?id=159712
Patch by Youenn Fablet <youennf@gmail.com> on 2016-07-13
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- resources/ImportExpectations:
- resources/TestRepositories:
- resources/web-platform-tests-modules.json:
- web-platform-tests/XMLHttpRequest/open-url-multi-window-6-expected.txt: Added.
- web-platform-tests/XMLHttpRequest/open-url-multi-window-6.htm: Added.
- web-platform-tests/XMLHttpRequest/responsexml-basic-expected.txt:
- web-platform-tests/XMLHttpRequest/responsexml-basic.htm:
- web-platform-tests/XMLHttpRequest/responsexml-document-properties-expected.txt:
- web-platform-tests/XMLHttpRequest/send-redirect-post-upload-expected.txt: Added.
- web-platform-tests/XMLHttpRequest/send-redirect-post-upload.htm: Added.
- web-platform-tests/init.py:
- web-platform-tests/dom/events/CustomEvent-expected.txt: Added.
- web-platform-tests/dom/events/CustomEvent.html: Added.
- web-platform-tests/dom/events/Event-dispatch-bubbles-true-expected.txt: Added.
- web-platform-tests/dom/events/Event-dispatch-bubbles-true.html: Added.
- web-platform-tests/dom/events/Event-dispatch-detached-click-expected.txt: Added.
- web-platform-tests/dom/events/Event-dispatch-detached-click.html: Added.
- web-platform-tests/dom/events/Event-dispatch-multiple-stopPropagation-expected.txt: Added.
- web-platform-tests/dom/events/Event-dispatch-multiple-stopPropagation.html: Added.
- web-platform-tests/dom/events/Event-dispatch-order-expected.txt: Added.
- web-platform-tests/dom/events/Event-dispatch-order.html: Added.
- web-platform-tests/dom/events/Event-dispatch-throwing-expected.txt: Added.
- web-platform-tests/dom/events/Event-dispatch-throwing.html: Added.
- web-platform-tests/dom/events/Event-init-while-dispatching-expected.txt: Added.
- web-platform-tests/dom/events/Event-init-while-dispatching.html: Added.
- web-platform-tests/dom/events/Event-subclasses-constructors-expected.txt: Added.
- web-platform-tests/dom/events/Event-subclasses-constructors.html: Added.
- web-platform-tests/dom/events/EventListener-handleEvent-expected.txt: Added.
- web-platform-tests/dom/events/EventListener-handleEvent.html: Added.
- web-platform-tests/dom/events/EventListener-incumbent-global-1.sub-expected.txt: Added.
- web-platform-tests/dom/events/EventListener-incumbent-global-1.sub.html: Added.
- web-platform-tests/dom/events/EventListener-incumbent-global-2.sub-expected.txt: Added.
- web-platform-tests/dom/events/EventListener-incumbent-global-2.sub.html: Added.
- web-platform-tests/dom/events/EventListener-incumbent-global-subframe-1.sub.html: Added.
- web-platform-tests/dom/events/EventListener-incumbent-global-subframe-2.sub.html: Added.
- web-platform-tests/dom/events/EventListener-incumbent-global-subsubframe.sub.html: Added.
- web-platform-tests/dom/lists/DOMTokenList-coverage-for-attributes-expected.txt: Added.
- web-platform-tests/dom/lists/DOMTokenList-coverage-for-attributes.html: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-expected.txt:
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.html: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.svg: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xhtml: Added.
- web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xml: Added.
- web-platform-tests/dom/nodes/ProcessingInstruction-escapes-1-expected.txt: Added.
- web-platform-tests/dom/nodes/ProcessingInstruction-escapes-1.xhtml: Added.
- web-platform-tests/domparsing/DOMParser-parseFromString-html-expected.txt:
- web-platform-tests/domparsing/DOMParser-parseFromString-html.html:
- web-platform-tests/domparsing/createContextualFragment-expected.txt: Added.
- web-platform-tests/domparsing/createContextualFragment.html: Added.
- web-platform-tests/domparsing/innerhtml-01-expected.txt: Added.
- web-platform-tests/domparsing/innerhtml-01.xhtml: Added.
- web-platform-tests/domparsing/innerhtml-03-expected.txt: Added.
- web-platform-tests/domparsing/innerhtml-03.xhtml: Added.
- web-platform-tests/domparsing/innerhtml-04-expected.txt: Added.
- web-platform-tests/domparsing/innerhtml-04.html: Added.
- web-platform-tests/domparsing/innerhtml-05-expected.txt: Added.
- web-platform-tests/domparsing/innerhtml-05.xhtml: Added.
- web-platform-tests/domparsing/innerhtml-06-expected.txt: Added.
- web-platform-tests/domparsing/innerhtml-06.html: Added.
- web-platform-tests/domparsing/innerhtml-07-expected.txt: Added.
- web-platform-tests/domparsing/innerhtml-07.html: Added.
- web-platform-tests/domparsing/insert_adjacent_html-expected.txt: Added.
- web-platform-tests/domparsing/insert_adjacent_html.html: Added.
- web-platform-tests/domparsing/insert_adjacent_html.js: Added.
(testThrowingNoParent):
- web-platform-tests/domparsing/outerhtml-01-expected.txt: Added.
- web-platform-tests/domparsing/outerhtml-01.html: Added.
- web-platform-tests/domparsing/outerhtml-02-expected.txt: Added.
- web-platform-tests/domparsing/outerhtml-02.html: Added.
- web-platform-tests/domparsing/xml-serialization-expected.txt: Added.
- web-platform-tests/domparsing/xml-serialization.xhtml: Added.
- web-platform-tests/fetch/api/basic/request-head-expected.txt: Added.
- web-platform-tests/fetch/api/basic/request-head-worker-expected.txt: Added.
- web-platform-tests/fetch/api/basic/request-head-worker.html: Added.
- web-platform-tests/fetch/api/basic/request-head.html: Added.
- web-platform-tests/fetch/api/basic/request-head.js: Added.
(promise_test):
- web-platform-tests/fetch/api/basic/request-headers-expected.txt:
- web-platform-tests/fetch/api/basic/request-headers-worker-expected.txt:
- web-platform-tests/fetch/api/basic/request-headers.js:
- web-platform-tests/fetch/api/basic/response-url-expected.txt: Added.
- web-platform-tests/fetch/api/basic/response-url-worker-expected.txt: Added.
- web-platform-tests/fetch/api/basic/response-url-worker.html: Added.
- web-platform-tests/fetch/api/basic/response-url.html: Added.
- web-platform-tests/fetch/api/basic/response-url.js: Added.
(checkResponseURL):
- web-platform-tests/fetch/api/basic/w3c-import.log:
- web-platform-tests/fetch/api/cors/cors-basic-worker-expected.txt:
- web-platform-tests/fetch/api/cors/cors-cookies-worker-expected.txt:
- web-platform-tests/fetch/api/cors/cors-preflight-expected.txt:
- web-platform-tests/fetch/api/cors/cors-preflight-worker-expected.txt:
- web-platform-tests/fetch/api/cors/cors-preflight.js:
(corsPreflight):
- web-platform-tests/fetch/api/cors/cors-redirect-credentials-worker-expected.txt:
- web-platform-tests/fetch/api/credentials/authentication-basic-worker-expected.txt:
- web-platform-tests/fetch/api/credentials/cookies-worker-expected.txt:
- web-platform-tests/fetch/api/policies/referrer-origin-worker-expected.txt:
- web-platform-tests/fetch/api/redirect/redirect-location-worker-expected.txt:
- web-platform-tests/fetch/api/redirect/redirect-mode-worker-expected.txt:
- web-platform-tests/fetch/api/request/request-init-002.html:
- web-platform-tests/fetch/api/request/request-init-003.sub-expected.txt:
- web-platform-tests/fetch/api/request/request-init-003.sub.html:
- web-platform-tests/html/dom/interfaces.html:
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/html/semantics/document-metadata/the-base-element/base_about_blank-expected.txt: Added.
- web-platform-tests/html/semantics/document-metadata/the-base-element/base_about_blank.html: Added.
- web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_invalid-expected.txt: Added.
- web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_invalid.html: Added.
- web-platform-tests/html/semantics/document-metadata/the-base-element/base_srcdoc-expected.txt: Added.
- web-platform-tests/html/semantics/document-metadata/the-base-element/base_srcdoc.html: Added.
- web-platform-tests/html/semantics/document-metadata/the-link-element/document-without-browsing-context-expected.txt: Added.
- web-platform-tests/html/semantics/document-metadata/the-link-element/document-without-browsing-context.html: Added.
- web-platform-tests/html/semantics/document-metadata/the-link-element/link-style-error-01-expected.txt:
- web-platform-tests/html/semantics/document-metadata/the-link-element/link-style-error-01.html:
- web-platform-tests/html/semantics/document-metadata/the-link-element/stylesheet.py: Added.
(main):
- web-platform-tests/html/semantics/document-metadata/the-link-element/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/media-elements/video_008-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/media-elements/video_008.htm: Added.
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/historical-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/historical.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-in-object-fallback-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-in-object-fallback-subdocument.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-in-object-fallback.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/change_child.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/change_grandchild.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/change_parentage-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/change_parentage.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/cross_origin_child.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/cross_origin_grandchild.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/cross_origin_parentage-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/cross_origin_parentage.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-allowfullscreen-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-allowfullscreen.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-load-event-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-load-event.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_harness.js: Added.
(get_test_results.):
(get_test_results):
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_helper.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_nonescaping.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/same_origin_child.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/same_origin_grandchild.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/same_origin_parentage-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/same_origin_parentage.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/stash.py: Added.
(main):
- web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/viewport-change-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-img-element/invalid-src-expected.txt: Added.
- web-platform-tests/html/semantics/embedded-content/the-img-element/invalid-src.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-img-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/form-submission-0/submit-entity-body-expected.txt: Added.
- web-platform-tests/html/semantics/forms/form-submission-0/submit-entity-body.html: Added.
- web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setSelectionRange-expected.txt:
- web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setSelectionRange.html:
- web-platform-tests/html/semantics/forms/the-form-element/form-indexed-element-expected.txt: Added.
- web-platform-tests/html/semantics/forms/the-form-element/form-indexed-element.html: Added.
- web-platform-tests/html/semantics/scripting-1/the-script-element/script-not-executed-after-shutdown-child.html: Added.
- web-platform-tests/html/semantics/scripting-1/the-script-element/script-not-executed-after-shutdown-expected.txt: Added.
- web-platform-tests/html/semantics/scripting-1/the-script-element/script-not-executed-after-shutdown.html: Added.
- web-platform-tests/html/semantics/scripting-1/the-script-element/script-not-executed-after-shutdown.js: Added.
- web-platform-tests/html/semantics/scripting-1/the-script-element/scripting-enabled-expected.txt: Added.
- web-platform-tests/html/semantics/scripting-1/the-script-element/scripting-enabled.html: Added.
- web-platform-tests/html/semantics/scripting-1/the-script-element/w3c-import.log:
- web-platform-tests/lint.whitelist:
- web-platform-tests/streams/readable-streams/bad-strategies.https-expected.txt:
- web-platform-tests/streams/readable-streams/bad-strategies.js:
(get string_appeared_here):
(promise_test): Deleted.
LayoutTests:
- TestExpectations: Adding some test expectations and skipping some resource files.
- 9:10 AM Changeset in webkit [203163] by
-
- 3 edits2 adds in trunk
The display property of many MathML elements can not be overriden by page authors
https://bugs.webkit.org/show_bug.cgi?id=139403
Source/WebCore:
The mathml.css user agent stylesheet currently forces most MathML elements to render with
'display: block'. We remove the !important keyword so that users can override the display
property, for example to hide elements with 'display: none'. This is consistent with the
behavior for SVG or HTML elements.
Patch by Frederic Wang <fwang@igalia.com> on 2016-07-13
Reviewed by Brent Fulgham.
Test: imported/mathml-in-html5/mathml/relations/css-styling/display-1.html
- css/mathml.css:
(math):
(math[display="block"]):
(ms, mspace, mtext, mi, mn, mo, mrow, mfenced, mfrac, msub, msup, msubsup, mmultiscripts, mprescripts, none, munder, mover, munderover, msqrt, mroot, merror, mphantom, mstyle, menclose, semantics, mpadded, maction):
(mtd > *):
LayoutTests:
Patch by Frederic Wang <fwang@igalia.com> on 2016-07-13
Reviewed by Brent Fulgham.
- imported/mathml-in-html5/mathml/relations/css-styling/display-1-expected.html: Added.
- imported/mathml-in-html5/mathml/relations/css-styling/display-1.html: Added.
- 9:08 AM Changeset in webkit [203162] by
-
- 11 edits in trunk
[Fetch API] Response should not become disturbed on the ReadableStream creation
https://bugs.webkit.org/show_bug.cgi?id=159714
Patch by Youenn Fablet <youenn@apple.com> on 2016-07-13
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/fetch/api/response/response-stream-disturbed-1-expected.txt:
Source/WebCore:
Covered by rebased test and existing tests.
- Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::stop): Making the response disturbed if cancelled.
- Modules/fetch/FetchResponseSource.cpp:
(WebCore::FetchResponseSource::firstReadCallback): Start enqueueing as soon as first read is made.
(WebCore::FetchResponseSource::doStart): Keep the start promise unresolved so that pull is not called.
FetchResponse is a push source.
- Modules/fetch/FetchResponseSource.h:
- Modules/streams/ReadableStreamInternals.js:
(readFromReadableStreamReader): Calling @firstReadCallback.
- Modules/streams/ReadableStreamSource.h:
(WebCore::ReadableStreamSource::firstReadCallback): Default implementation (does nothing).
- Modules/streams/ReadableStreamSource.idl: Adding firstReadCallback private method.
- bindings/js/WebCoreBuiltinNames.h: Adding @firstReadCallback.
- 7:48 AM Changeset in webkit [203161] by
-
- 2 edits in trunk/LayoutTests
Update Windows expectations for two MathML tests.
Unreviewed test gardening.
Patch by Frederic Wang <fwang@igalia.com> on 2016-07-13
- platform/win/TestExpectations:
- 6:09 AM Changeset in webkit [203160] by
-
- 4 edits in trunk
[EFL] [GTK] Enable back crypto subtle on development builds.
https://bugs.webkit.org/show_bug.cgi?id=159260
Reviewed by Carlos Garcia Campos.
Tools:
- Scripts/webkitperl/FeatureList.pm:
LayoutTests:
- platform/gtk/TestExpectations: Enable back the tests that were
passing on GTK.
- 5:03 AM Changeset in webkit [203159] by
-
- 5 edits in trunk/Source/WebCore
[GStreamer][GL] crash within triggerRepaint
https://bugs.webkit.org/show_bug.cgi?id=159552
Reviewed by Xabier Rodriguez-Calvar.
Revert the un-needed changes introduced in r203056 and use the
MainThreadNotifier without redundant checks.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(WebCore::MediaPlayerPrivateGStreamer::createWeakPtr):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
(WebCore::MediaPlayerPrivateGStreamerBase::createWeakPtr): Deleted.
- 4:37 AM Changeset in webkit [203158] by
-
- 6 edits in trunk/Source/WebCore
Unreviewed. Fix GObject DOM bindings API breaks after r203047-
webkit_dom_document_set_title() and webkit_dom_html_title_element_set_text() now can raise exceptions.
- bindings/gobject/WebKitDOMDeprecated.cpp:
(webkit_dom_document_set_title):
(webkit_dom_html_title_element_set_text):
- bindings/gobject/WebKitDOMDeprecated.h:
- bindings/gobject/WebKitDOMDeprecated.symbols:
- bindings/gobject/webkitdom.symbols:
- bindings/scripts/CodeGeneratorGObject.pm:
(GenerateProperty):
(FunctionUsedToNotRaiseException):
- 4:00 AM Changeset in webkit [203157] by
-
- 8 edits in trunk/Source
[Coordinated Graphics] Remove toCoordinatedGraphicsLayer and use downcast instead
https://bugs.webkit.org/show_bug.cgi?id=159469
Reviewed by Michael Catanzaro.
Source/WebCore:
- page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:
(WebCore::ScrollingCoordinatorCoordinatedGraphics::detachFromStateTree):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::updateViewportConstrainedNode):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::scrollableAreaScrollLayerDidChange):
(WebCore::ScrollingCoordinatorCoordinatedGraphics::willDestroyScrollableArea):
- platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::isCoordinatedGraphicsLayer):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::toCoordinatedLayerID):
(WebCore::CoordinatedGraphicsLayer::setShouldUpdateVisibleRect):
(WebCore::CoordinatedGraphicsLayer::removeFromParent):
(WebCore::CoordinatedGraphicsLayer::setMaskLayer):
(WebCore::CoordinatedGraphicsLayer::flushCompositingState):
(WebCore::CoordinatedGraphicsLayer::syncPendingStateChangesIncludingSubLayers):
(WebCore::CoordinatedGraphicsLayer::findFirstDescendantWithContentsRecursively):
(WebCore::CoordinatedGraphicsLayer::updateContentBuffersIncludingSubLayers):
(WebCore::CoordinatedGraphicsLayer::computeTransformedVisibleRect):
(WebCore::CoordinatedGraphicsLayer::selfOrAncestorHasActiveTransformAnimation):
(WebCore::CoordinatedGraphicsLayer::selfOrAncestorHaveNonAffineTransforms):
(WebCore::toCoordinatedGraphicsLayer): Deleted.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
Source/WebKit2:
- WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:
(WebKit::CompositingCoordinator::flushPendingLayerChanges):
(WebKit::CompositingCoordinator::initializeRootCompositingLayerIfNeeded):
(WebKit::CompositingCoordinator::mainContentsLayer):
- 3:22 AM Changeset in webkit [203156] by
-
- 4 edits in trunk/Source/JavaScriptCore
CLoop buildfix after r203142
https://bugs.webkit.org/show_bug.cgi?id=159706
Unreviewed buildfix.
- interpreter/CLoopStack.cpp:
(JSC::CLoopStack::isSafeToRecurse):
- interpreter/CLoopStack.h:
- interpreter/CLoopStackInlines.h:
(JSC::CLoopStack::isSafeToRecurse): Deleted.
- 1:36 AM Changeset in webkit [203155] by
-
- 9 edits1 copy in trunk/Source
[GTK] WebKitGtk+ uses too many file descriptors
https://bugs.webkit.org/show_bug.cgi?id=152316
Reviewed by Michael Catanzaro.
Source/WebKit2:
The problem is that we are keeping file descriptors open in SharedMemory objects. Those objects can be kept
alive for a long time, for example in case of cached resources sent from the network process as shareable
resources. The thing is that we keep the file descriptor in the SharedMemory object only to be able to create a
Handle, duplicating the file descriptor. However, we are also assuming that we create handles for SharedMemory
objects created by another handle which is wrong. SharedMemory objects are created to map a file or data and
then a handle is created to send it to another process, or to map an existing file or data for a given handle
received from another process. They can also be created to wrap another map, but in that case we don't own the
file descritor nor the mapped data. So, after mapping from a handle, we no longer need the file descriptor, and
it can be closed to release it, while the mapped memory data will still be alive until munmap() is called. This
drastically reduces the amount of file descriptors used by WebKitGTK+.
- Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::readBytesFromSocket): Use setCloseOnExec().
(IPC::Connection::createPlatformConnection): Ditto.
- Platform/SharedMemory.h:
- Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::map): Close the file descriptor right after mmap.
(WebKit::SharedMemory::~SharedMemory): Close the file descriptor only if it hasn't been closed yet.
(WebKit::SharedMemory::createHandle): Add an ASSERT to ensure we only try to create a handle for SharedMemory
objects having a valid file descriptor. Use dupCloseOnExec() to duplicate the handle and set the close on exec flag.
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::launchProcess): Use setCloseOnExec().
Source/WTF:
Add helper functions to duplicate a file descriptor setting close on exec flag, and also to set close on exec
flag to an existing file descriptor.
- wtf/UniStdExtras.h:
- wtf/UniStdExtras.cpp
(WTF::setCloseOnExec):
(WTF::dupCloseOnExec):
- 1:21 AM MathML/Early_2016_Refactoring edited by
- (diff)
- 12:21 AM Changeset in webkit [203154] by
-
- 6 edits in trunk/LayoutTests
Update MathML expectations on EFL and Windows ports.
Unreviewed test gardening.
Patch by Frederic Wang <fwang@igalia.com> on 2016-07-13
- platform/efl/mathml/opentype/horizontal-expected.txt:
- platform/efl/mathml/opentype/horizontal-munderover-expected.txt:
- platform/win/TestExpectations:
- platform/win/mathml/opentype/horizontal-expected.txt:
- platform/win/mathml/opentype/horizontal-munderover-expected.txt:
Jul 12, 2016:
- 11:44 PM Changeset in webkit [203153] by
-
- 5 edits in trunk
[Fetch API] isRedirected should be conveyed in workers
https://bugs.webkit.org/show_bug.cgi?id=159676
Patch by Youenn Fablet <youenn@apple.com> on 2016-07-12
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/fetch/api/redirect/redirect-method-worker-expected.txt:
Source/WebCore:
Passing isRedirected value between threads.
Rebasing corresponding worker test, even though it is currently skipped (due to crashing flakiness).
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::crossThreadData):
(WebCore::ResourceResponseBase::fromCrossThreadData):
- platform/network/ResourceResponseBase.h:
- 10:45 PM Changeset in webkit [203152] by
-
- 1 edit in trunk/Websites/test-results/init-database.sql
Fix SQL: quote hyphenated string.
- 9:50 PM Changeset in webkit [203151] by
-
- 6 edits2 adds in trunk
REGRESSION (r202509): media controls controls enabled AirPlay placeholder is shown
https://bugs.webkit.org/show_bug.cgi?id=159685
<rdar://problem/27198899>
Reviewed by Dean Jackson.
Source/WebCore:
Test: media/controls/airplay-controls.html
- Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.shouldShowControls): Split some of the logic out of shouldHaveControls.
(Controller.prototype.shouldHaveControls): Having controls != showing controls.
(Controller.prototype.updateControls): Call shouldShowControls, not shouldHaveControls.
(Controller.prototype.updateWirelessPlaybackStatus): Add 'appletv' to the class when active.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::getCurrentMediaControlsStatus): Call ensureMediaControlsShadowRoot
in case the controls haven't been created yet.
LayoutTests:
- media/controls/airplay-controls-expected.txt: Added.
- media/controls/airplay-controls.html: Added.
- media/controls/controls-test-helpers.js:
(ControlsTest.prototype.get currentState): Put a try block around the call to get the current
status in case it fails.
- platform/mac/TestExpectations: Skip the new test on Yosemite where AirPlay doesn't work.
- 9:47 PM Changeset in webkit [203150] by
-
- 8 edits1 copy1 add in trunk/Source/WebCore
Move parsing of mpadded attributes to a MathMLPaddedElement class
https://bugs.webkit.org/show_bug.cgi?id=159620
Patch by Frederic Wang <fwang@igalia.com> on 2016-07-12
Reviewed by Brent Fulgham.
No new tests, behavior is unchanged.
- CMakeLists.txt: Add MathMLPaddedElement files.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- mathml/MathMLAllInOne.cpp: Ditto.
- mathml/MathMLInlineContainerElement.cpp: Remove handling of mpadded.
- mathml/MathMLPaddedElement.cpp: Added.
(WebCore::MathMLPaddedElement::MathMLPaddedElement):
(WebCore::MathMLPaddedElement::create):
(WebCore::MathMLPaddedElement::width): Expose width attribute as a MathMLLength until mpadded
pseudo-units are supported.
(WebCore::MathMLPaddedElement::height): Ditto.
(WebCore::MathMLPaddedElement::depth): Ditto
(WebCore::MathMLPaddedElement::lspace): Ditto.
(WebCore::MathMLPaddedElement::voffset): Ditto.
(WebCore::MathMLPaddedElement::parseAttribute): Make length attribute dirty.
(WebCore::MathMLPaddedElement::createElementRenderer): Moved code from MathMLInlineContainerElement.
- mathml/MathMLPaddedElement.h: Added.
- mathml/mathtags.in: Map mapdded to MathMLPaddedElement.
- rendering/mathml/RenderMathMLPadded.cpp:
(WebCore::RenderMathMLPadded::resolveWidth): Helper function to resolve width.
(WebCore::RenderMathMLPadded::resolveAttributes): Helper function to resolve all attributes.
(WebCore::RenderMathMLPadded::computePreferredLogicalWidths): Use resolveWidth.
(WebCore::RenderMathMLPadded::layoutBlock): Use resolveAttributes.
- rendering/mathml/RenderMathMLPadded.h: Add new helper functions to access attributes from
the MathMLPaddedElement class.
- 9:05 PM Changeset in webkit [203149] by
-
- 3 edits in trunk/Source/WebCore
[Cocoa] Simulated memory warning doesn't trigger libcache purge.
<https://webkit.org/b/159688>
Reviewed by Chris Dumez.
Since simulated memory warnings will have the "is under memory pressure" flag set,
we were skipping the libcache purge call.
Add a separate flag that tracks whether we're under simulated pressure, and always
prod libcache in that case.
- platform/MemoryPressureHandler.h:
- platform/cocoa/MemoryPressureHandlerCocoa.mm:
(WebCore::MemoryPressureHandler::platformReleaseMemory):
(WebCore::MemoryPressureHandler::install):
- 8:30 PM Changeset in webkit [203148] by
-
- 2 edits2 adds in trunk/Websites/test-results
<rdar://problem/22524456> Mitigate performance degradation of the flakiness dashboard
Rubber-stamped by Dean Johnson.
- init-database.sql:
Rewrite the init-database.sql file to allow for table partitioning, based on insert date.
Some important things to note:
The main results table is unchanged, but will no longer contain any rows.
Partitioned tables will be generated on demand, and will inherit from 'results'
It is possible to query the 'results' table directly, and that will get data from all child tables.
This should keep us from requiring any client side code changes.
- public_partition_maintenance: Added.
Maintenance script which will be called on a nightly schedule to purge expired data.
This data will be exported and compressed to a sub-folder, then dropped from the database.
I'm not sure how big it will be, so we'll likely need to keep an eye on it.
- test-database.sql: Added.
Simple helper function to test that results partitions are created/deleted correctly.
- 6:25 PM Changeset in webkit [203147] by
-
- 9 edits3 adds6 deletes in trunk
[JSC] Array.prototype.join() fails some conformance tests
https://bugs.webkit.org/show_bug.cgi?id=159657
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-07-12
Reviewed by Saam Barati.
Source/JavaScriptCore:
There were a couple of failures:
-separator.toString() was called *before* we get the length
and process ToLength() on it.
-We were using toUInt32() on length instead of ToLength(),
failing on big integers and various negative numbers.
Additionally, I replaced the "fast" ArrayStorage path
by a fully generic implementation that does not depends on StringJoiner.
The reason is StringJoiner was doing poorly on sparse objects
in certain cases.
If you have a sparse object with a length > INT_MAX but very few
indices defined, and you join on the empty string, it should be possible
to join the array (albeit very slowly). With StringJoiner, we fail
because we try to allocate > INT_MAX empty strings in a contiguous vector.
- runtime/ArrayPrototype.cpp:
(JSC::slowJoin):
(JSC::canUseFastJoin):
(JSC::fastJoin):
(JSC::arrayProtoFuncJoin):
(JSC::join): Deleted.
- runtime/JSArray.h:
(JSC::toLength):
Source/WTF:
- wtf/text/AtomicString.cpp:
(WTF::AtomicString::number):
- wtf/text/AtomicString.h:
LayoutTests:
I removed 3 sputnik tests that are incorrect in the latest spec.
In ES5, Array.prototype.join() was using ToUint32 on the argument:
In ES6, the function uses ToLength:
The test use Infinity and very large integer as the length.
They are guaranteed to time out or run out of memory.
Even if we waited the hours it takes to run this, the results would be different
from what the tests expect.
- js/array-join-expected.txt: Added.
- js/array-join.html: Added.
- js/script-tests/array-join.js: Added.
- 6:24 PM Changeset in webkit [203146] by
-
- 18 edits in trunk/Source/WebCore
Purge PassRefPtr in Modules/webdatabase
https://bugs.webkit.org/show_bug.cgi?id=159255
Reviewed by Benjamin Poulain.
As a step to remove PassRefPtr use, this patch cleans it up in Modules/webdatabase.
Additionally unnecessary spaces and tabs are removed too.
- Modules/webdatabase/ChangeVersionWrapper.cpp:
- Modules/webdatabase/DOMWindowWebDatabase.h:
- Modules/webdatabase/Database.cpp:
(WebCore::Database::Database):
(WebCore::Database::~Database):
(WebCore::Database::scheduleTransaction):
(WebCore::Database::runTransaction):
- Modules/webdatabase/Database.h:
- Modules/webdatabase/DatabaseAuthorizer.cpp:
(WebCore::DatabaseAuthorizer::allowRead):
- Modules/webdatabase/DatabaseManager.cpp:
(WebCore::DatabaseManager::openDatabase):
(WebCore::DatabaseManager::fullPathForDatabase):
(WebCore::DatabaseManager::detailsForNameAndOrigin):
- Modules/webdatabase/DatabaseManager.h:
- Modules/webdatabase/DatabaseTask.cpp:
(WebCore::DatabaseTransactionTask::DatabaseTransactionTask):
- Modules/webdatabase/DatabaseTask.h:
- Modules/webdatabase/SQLCallbackWrapper.h:
(WebCore::SQLCallbackWrapper::SQLCallbackWrapper):
- Modules/webdatabase/SQLResultSetRowList.h:
- Modules/webdatabase/SQLStatement.cpp:
(WebCore::SQLStatement::SQLStatement):
(WebCore::SQLStatement::sqlError):
(WebCore::SQLStatement::sqlResultSet):
- Modules/webdatabase/SQLStatement.h:
- Modules/webdatabase/SQLTransaction.h:
- Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::create):
(WebCore::SQLTransactionBackend::SQLTransactionBackend):
(WebCore::SQLTransactionBackend::transactionError):
- Modules/webdatabase/SQLTransactionBackend.h:
- 5:55 PM Changeset in webkit [203145] by
-
- 2 edits in trunk/Source/WebKit2
[iOS WK2] After zooming and when under memory pressure, page tiles sometimes don't redraw while panning
https://bugs.webkit.org/show_bug.cgi?id=159697
rdar://problem/26314075
Reviewed by Benjamin Poulain.
When under memory pressure, and after pinching back to minimum scale, WebPage::updateVisibleContentRects()
would sometimes always bail under the "boundedScale != currentScale..." condition.
This happened because the visibleContentRectUpdateInfo.scale() is a double, but m_page->pageScaleFactor()
is a float, and the constraining between min and max scale (which are doubles) caused boundedScale
to be always different from currentScale.
Fix by using floats throughout.
No test because there's no way to simulate memory pressure for testing.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::updateVisibleContentRects):
- 5:45 PM Changeset in webkit [203144] by
-
- 2 edits in trunk/Source/JavaScriptCore
Gardening: C Loop build fix after r203142.
Not reviewed.
- interpreter/CLoopStackInlines.h:
(JSC::CLoopStack::isSafeToRecurse):
- 5:20 PM Changeset in webkit [203143] by
-
- 8 edits2 copies4 adds3 deletes in trunk
Unreviewed, rolling out r203131.
https://bugs.webkit.org/show_bug.cgi?id=159698
This change caused an existing LayoutTest to time out on debug
testers (Requested by ryanhaddad on #webkit).
Reverted changeset:
"[JSC] Array.prototype.join() fails some conformance tests"
https://bugs.webkit.org/show_bug.cgi?id=159657
http://trac.webkit.org/changeset/203131
Patch by Commit Queue <commit-queue@webkit.org> on 2016-07-12
- 5:19 PM Changeset in webkit [203142] by
-
- 23 edits1 add in trunk
We should use different stack limits for stack checks from JS and host code.
https://bugs.webkit.org/show_bug.cgi?id=159442
<rdar://problem/26889188>
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
We have 2 stack reservedZoneSizes:
- Options::softReservedZoneSize()
- Options::reservedZoneSize()
Respectively, there are used to define 2 stack limits based on these reserved
zone sizes:
- VM::m_softStackLimit
- VM::m_stackLimit
Options::reservedZoneSize() is the amount of the stack space that JSC guarantees
to the VM and client host code for it's use. Host code that has well known
stack usage characteristics (i.e. doesn't call arbitrary code) may do stack
checks against the VM::m_stackLimit limit (which is computed using
Options::reservedZoneSize()).
Options::softReservedZoneSize() is a more conservative amount of reserved stack
space. This is used to compute the VM::m_softStackLimit limit. Any code that
is difficult to have its stack usage characterized (i.e. may call arbitrary code)
may need more stack space for its work. Hence, these should do stack checks
against the VM::m_softStackLimit limit.
JS code and host code that may call into JS code falls into the category of code
that may call arbitrary code. Hence, they should do stack checks against the
VM::m_softStackLimit limit.
Accordingly, the VM now provides 2 recursion check functions:
- VM::isSafeToRecurseSoft() will do a stack check against VM::m_softStackLimit. In addition, for C Loop builds, VM::isSafeToRecurseSoft() will also check the CLoopStack against VM::m_cloopStackLimit.
- VM::isSafeToRecurse() will do a stack check against VM::m_stackLimit.
Also added a promise-infinite-recursion-should-not-crash.js test.
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitNodeInTailPosition):
(JSC::BytecodeGenerator::emitNodeInConditionContext):
- interpreter/CLoopStack.cpp:
(JSC::CLoopStack::grow):
- interpreter/CLoopStack.h:
(JSC::CLoopStack::size):
- interpreter/CLoopStackInlines.h:
(JSC::CLoopStack::ensureCapacityFor):
(JSC::CLoopStack::isSafeToRecurse):
(JSC::CLoopStack::topOfFrameFor):
- interpreter/CachedCall.h:
(JSC::CachedCall::CachedCall):
- interpreter/Interpreter.cpp:
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- parser/Parser.cpp:
- runtime/Options.h:
- runtime/ProxyObject.cpp:
(JSC::performProxyGet):
(JSC::ProxyObject::performInternalMethodGetOwnProperty):
(JSC::ProxyObject::performHasProperty):
(JSC::ProxyObject::getOwnPropertySlotCommon):
(JSC::ProxyObject::performPut):
(JSC::performProxyCall):
(JSC::performProxyConstruct):
(JSC::ProxyObject::performDelete):
(JSC::ProxyObject::performPreventExtensions):
(JSC::ProxyObject::performIsExtensible):
(JSC::ProxyObject::performDefineOwnProperty):
(JSC::ProxyObject::performGetOwnPropertyNames):
(JSC::ProxyObject::performSetPrototype):
(JSC::ProxyObject::performGetPrototype):
- runtime/RegExp.cpp:
(JSC::RegExp::finishCreation):
(JSC::RegExp::compile):
(JSC::RegExp::compileMatchOnly):
- runtime/StringRecursionChecker.h:
(JSC::StringRecursionChecker::performCheck):
- runtime/VM.cpp:
(JSC::VM::setStackPointerAtVMEntry):
(JSC::VM::updateSoftReservedZoneSize):
(JSC::preCommitStackMemory):
(JSC::VM::updateStackLimits):
(JSC::VM::updateStackLimit): Deleted.
- runtime/VM.h:
(JSC::VM::stackLimit):
(JSC::VM::softStackLimit):
(JSC::VM::addressOfSoftStackLimit):
(JSC::VM::setCLoopStackLimit):
(JSC::VM::isSafeToRecurse):
(JSC::VM::lastStackTop):
(JSC::VM::setException):
- runtime/VMInlines.h:
(JSC::VM::ensureStackCapacityFor):
(JSC::VM::isSafeToRecurseSoft):
(JSC::VM::shouldTriggerTermination):
- tests/stress/promise-infinite-recursion-should-not-crash.js: Added.
(testPromise):
(promiseFunc):
- yarr/YarrPattern.cpp:
Tools:
In http://trac.webkit.org/r203067, we limited the amount of stack that tests will
run with to keep stack overflow tests sane. Turns out, we also need to teach the
LayoutTestRelay to pass env vars over to the iOS simulator. This is needed in
order to keep the js/regress-139548.html test happy with this patch.
Also fixed up run_webkit_tests.py to explicitly pass an int size value for the
JSC_maxPerThreadStackUsage option. Otherwise, it will pass a float value.
- LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
(-[LTRelayController _environmentVariables]):
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(main):
LayoutTests:
- js/regress-141098-expected.txt:
- js/script-tests/regress-141098.js:
(testEval):
(probeAndRecurse):
- Gave all the test constants names.
- Tweaked the constants to allow the test to run in the least amount of time, and also to behave consistently across all test configurations.
- Re-enable eager tests now that the test should finish quickly.
- 5:05 PM Changeset in webkit [203141] by
-
- 4 edits in trunk
platformUserPreferredLanguages on Mac should not try to put the region into the language
https://bugs.webkit.org/show_bug.cgi?id=159693
Rubber stamped by Alexey Proskuryakov.
Source/WTF:
Currently, navigator.language is the thing that we use as the BCP-47 tag in our Intl code
when certain APIs are called without a locale argument. That mostly makes sense, and is
deeply wired into our engine.
In r200105, we made Intl aware of the region as a separate thing from the language by having
platformUserPreferredLanguages() return something like a BCP-47 tag that was
<language>-<region>. For example, if I told System Preferences that I want to speak English
but live in Poland then we'd get "en-pl". This had the effect of making Intl APIs format
dates using Polish formatting, for example.
But this is an odd change, since that same function also feeds into navigator.language.
"en-pl" isn't what we want there, since my System Preferences settings aren't supposed to
mean that I want to speak Polish-style English. There's no such thing.
It may be worthwhile to wire the region settings more elegantly into Intl, but if we do that,
it should be via a mechanism that is separate from navigator.language. So, this change simply
reverts r200105.
- wtf/PlatformUserPreferredLanguagesMac.mm:
(WTF::httpStyleLanguageCode):
(WTF::platformUserPreferredLanguages):
(WTF::isValidICUCountryCode): Deleted.
Tools:
Revert the test change in r200105.
- TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
(TestWebKitAPI::languageForSystemLanguage):
- 5:02 PM Changeset in webkit [203140] by
-
- 5 edits in branches/safari-602.1.40-branch/Source
Versioning.
- 4:57 PM Changeset in webkit [203139] by
-
- 1 copy in tags/Safari-602.1.40.6
New tag.
- 4:57 PM Changeset in webkit [203138] by
-
- 6 edits in branches/safari-602.1.40-branch/Source
Merged r203134. rdar://problem/27312176
- 4:49 PM Changeset in webkit [203137] by
-
- 3 edits in trunk/LayoutTests
REGRESSION (202694): Audio and Video playback controls: Cannot find a position slider to adjust playback position using VO.
https://bugs.webkit.org/show_bug.cgi?id=159661
<rdar://problem/27285135>
Unreviewed. Slight tweak to test to hopefully avoid flakiness.
- media/controls/default-size-should-show-scrubber-expected.txt:
- media/controls/default-size-should-show-scrubber.html:
- 4:20 PM Changeset in webkit [203136] by
-
- 2 edits in trunk/LayoutTests
Marking fast/css/ancestor-of-hovered-element-detached.html as flaky on Mac
https://bugs.webkit.org/show_bug.cgi?id=159173
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 4:16 PM Changeset in webkit [203135] by
-
- 3 edits in trunk/Source/WebInspectorUI
REGRESSION(r192789): Web Inspector: Log Value context menu appears twice
https://bugs.webkit.org/show_bug.cgi?id=159681
<rdar://problem/27304804>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-07-12
Reviewed by Brian Burg.
In r192789 contextmenu events may bubble up so that multiple handlers
may append ContextMenuItems. In nested ObjectTrees / ObjectPreviews
this could result in duplicate items. Add a flag on the bubbling event
so that we only include Object Tree context menu items for the deepest
part of the Object Tree, but still allow bubbling up to the root.
- UserInterface/Views/ObjectPreviewView.js:
(WebInspector.ObjectPreviewView.prototype._contextMenuHandler):
(WebInspector.ObjectPreviewView):
- UserInterface/Views/ObjectTreeBaseTreeElement.js:
(WebInspector.ObjectTreeBaseTreeElement.prototype._contextMenuHandler):
- 4:14 PM Changeset in webkit [203134] by
-
- 6 edits in trunk/Source
[Win] Fix for build error when trying to version stamp dll.
https://bugs.webkit.org/show_bug.cgi?id=159692
Reviewed by Brent Fulgham.
Use correct path to version stamp script.
Source/JavaScriptCore:
- CMakeLists.txt:
Source/WebKit:
- CMakeLists.txt:
Source/WTF:
- wtf/CMakeLists.txt:
- 3:43 PM Changeset in webkit [203133] by
-
- 8 edits in trunk/Source/WebKit2
[WK2][NetworkSession] Fix unsafe RunLoop::dispatch() in NetworkLoad constructor
https://bugs.webkit.org/show_bug.cgi?id=159691
Reviewed by Brady Eidson.
Remove unsafe RunLoop::dispatch() in NetworkLoad constructor. It captured |this| but there
was no guarantee the NetworkLoad would still be alive by the time the lambda gets executed.
Instead, the constructor now takes a NetworkSession& parameter so that the call sites
have to retrieve the NetworkSession for a given SessionID and deal with the fact that
there may be no such NetworkSession before constructing the NetworkLoad.
- NetworkProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::startDownload):
- NetworkProcess/Downloads/PendingDownload.cpp:
(WebKit::PendingDownload::PendingDownload):
- NetworkProcess/Downloads/PendingDownload.h:
- NetworkProcess/NetworkLoad.cpp:
(WebKit::NetworkLoad::NetworkLoad):
- NetworkProcess/NetworkLoad.h:
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::startNetworkLoad):
- NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:
(WebKit::NetworkCache::SpeculativeLoad::SpeculativeLoad):
- 3:21 PM Changeset in webkit [203132] by
-
- 5 edits2 adds in trunk
Web Inspector: ER: Copy as cURL
https://bugs.webkit.org/show_bug.cgi?id=159380
Patch by Johan K. Jensen <johan_jensen@apple.com> on 2016-07-12
Reviewed by Joseph Pecoraro.
Source/WebInspectorUI:
This "Copy as cURL" feature only approximates the original request as only some parts of
that request is known to the frontend.
- UserInterface/Models/Resource.js:
(WebInspector.Resource.prototype.generateCURLCommand.escapeStringPosix.escapeCharacter):
(WebInspector.Resource.prototype.generateCURLCommand.escapeStringPosix):
(WebInspector.Resource.prototype.generateCURLCommand):
(WebInspector.Resource):
- UserInterface/Views/ResourceTimelineDataGridNode.js:
(WebInspector.ResourceTimelineDataGridNode.prototype.appendContextMenuItems):
LayoutTests:
- http/tests/inspector/network/copy-as-curl-expected.txt: Added.
- http/tests/inspector/network/copy-as-curl.html: Added.
- 3:08 PM Changeset in webkit [203131] by
-
- 8 edits3 adds6 deletes in trunk
[JSC] Array.prototype.join() fails some conformance tests
https://bugs.webkit.org/show_bug.cgi?id=159657
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-07-12
Reviewed by Saam Barati.
Source/JavaScriptCore:
There were a couple of failures:
-separator.toString() was called *before* we get the length
and process ToLength() on it.
-We were using toUInt32() on length instead of ToLength(),
failing on big integers and various negative numbers.
Additionally, I replaced the "fast" ArrayStorage path
by a fully generic implementation that does not depends on StringJoiner.
The reason is StringJoiner was doing poorly on sparse objects
in certain cases.
If you have a sparse object with a length > INT_MAX but very few
indices defined, and you join on the empty string, it should be possible
to join the array (albeit very slowly). With StringJoiner, we fail
because we try to allocate > INT_MAX empty strings in a contiguous vector.
- runtime/ArrayPrototype.cpp:
(JSC::slowJoin):
(JSC::canUseFastJoin):
(JSC::fastJoin):
(JSC::arrayProtoFuncJoin):
(JSC::join): Deleted.
- runtime/JSArray.h:
(JSC::toLength):
Source/WTF:
- wtf/text/AtomicString.cpp:
(WTF::AtomicString::number):
- wtf/text/AtomicString.h:
LayoutTests:
I removed 3 sputnik tests that are incorrect in the latest spec.
In ES5, Array.prototype.join() was using ToUint32 on the argument:
In ES6, the function uses ToLength:
The test use Infinity and very large integer as the length.
They are guaranteed to time out or run out of memory.
Even if we waited the hours it takes to run this, the results would be different
from what the tests expect.
- js/array-join-expected.txt: Added.
- js/array-join.html: Added.
- js/script-tests/array-join.js: Added.
- 3:06 PM Changeset in webkit [203130] by
-
- 21 edits in trunk/Source/JavaScriptCore
More stack limit and reserved zone renaming.
https://bugs.webkit.org/show_bug.cgi?id=159690
Rubber-stamped by Geoffrey Garen.
We should rename the following:
osStackLimitWithReserve => softStackLimit
reservedZoneSize => softReservedZoneSize
errorModeReservedZoneSize => reservedZoneSize
- API/tests/PingPongStackOverflowTest.cpp:
(testPingPongStackOverflow):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::lower):
- interpreter/CLoopStack.cpp:
(JSC::CLoopStack::CLoopStack):
(JSC::CLoopStack::grow):
(JSC::CLoopStack::releaseExcessCapacity):
(JSC::CLoopStack::addToCommittedByteCount):
(JSC::CLoopStack::setSoftReservedZoneSize):
(JSC::CLoopStack::setReservedZoneSize): Deleted.
- interpreter/CLoopStack.h:
(JSC::CLoopStack::size):
- interpreter/CLoopStackInlines.h:
(JSC::CLoopStack::shrink):
- jit/JIT.cpp:
(JSC::JIT::compileWithoutLinking):
- jit/SetupVarargsFrame.cpp:
(JSC::emitSetupVarargsFrameFastCase):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/ErrorHandlingScope.cpp:
(JSC::ErrorHandlingScope::ErrorHandlingScope):
(JSC::ErrorHandlingScope::~ErrorHandlingScope):
- runtime/ErrorHandlingScope.h:
- runtime/Options.h:
- runtime/RegExp.cpp:
(JSC::RegExp::finishCreation):
(JSC::RegExp::compile):
(JSC::RegExp::compileMatchOnly):
- runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::setStackPointerAtVMEntry):
(JSC::VM::updateSoftReservedZoneSize):
(JSC::VM::updateStackLimit):
(JSC::VM::updateReservedZoneSize): Deleted.
- runtime/VM.h:
(JSC::VM::stackPointerAtVMEntry):
(JSC::VM::softReservedZoneSize):
(JSC::VM::softStackLimit):
(JSC::VM::addressOfSoftStackLimit):
(JSC::VM::cloopStackLimit):
(JSC::VM::setCLoopStackLimit):
(JSC::VM::isSafeToRecurse):
(JSC::VM::reservedZoneSize): Deleted.
(JSC::VM::osStackLimitWithReserve): Deleted.
(JSC::VM::addressOfOSStackLimitWithReserve): Deleted.
- runtime/VMInlines.h:
(JSC::VM::ensureStackCapacityFor):
- wasm/WASMFunctionCompiler.h:
(JSC::WASMFunctionCompiler::startFunction):
- 2:51 PM Changeset in webkit [203129] by
-
- 4 edits4 adds in trunk
[WK2] Protect against bad database data in LocalStorageDatabase::importItems()
https://bugs.webkit.org/show_bug.cgi?id=159663
<rdar://problem/18995873>
Reviewed by Benjamin Poulain.
Source/WebKit2:
Protect against bad database data in LocalStorageDatabase::importItems(). We
crash if the database contains a null key or a null value so protect against
it given that we have evidence it can happen.
With this change, I can no longer reproduce the UIProcess crash on evernote.com
that is documented at <rdar://problem/18995873>.
- UIProcess/Storage/LocalStorageDatabase.cpp:
(WebKit::LocalStorageDatabase::importItems):
Tools:
Add API test coverage.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Added.
- TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Added.
- TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Added.
- TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Added.
(-[LocalStorageNullEntriesMessageHandler userContentController:didReceiveScriptMessage:]):
(TEST):
- 2:09 PM Changeset in webkit [203128] by
-
- 2 edits in trunk/LayoutTests
Marking storage/indexeddb/database-close-private.html as flaky on Mac
https://bugs.webkit.org/show_bug.cgi?id=158500
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 1:48 PM Changeset in webkit [203127] by
-
- 2 edits in trunk/LayoutTests
Marking storage/indexeddb/modern/handle-user-delete.html as flaky on Yosemite Release
https://bugs.webkit.org/show_bug.cgi?id=158741
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 1:31 PM Changeset in webkit [203126] by
-
- 5 edits in branches/safari-602.1.40-branch/Source
Versioning.
- 1:25 PM Changeset in webkit [203125] by
-
- 1 copy in tags/Safari-602.1.40.5
New tag.
- 1:24 PM Changeset in webkit [203124] by
-
- 10 edits in branches/safari-602.1.40-branch
Merged r203111. rdar://problem/26358998
- 12:40 PM Changeset in webkit [203123] by
-
- 2 edits in trunk/LayoutTests
Marking inspector/indexeddb/deleteDatabaseNamesWithSpace.html as a flaky timeout on Mac debug.
https://bugs.webkit.org/show_bug.cgi?id=159684
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 12:40 PM Changeset in webkit [203122] by
-
- 2 edits in trunk/LayoutTests
Update test expectations for rdar://problem/26590623 after r203117.
- platform/mac/TestExpectations:
- 12:12 PM Changeset in webkit [203121] by
-
- 3 edits in trunk/LayoutTests
Marking imported/w3c/web-platform-tests/fetch/api/request/request-cache.html as flaky on Mac and ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=159683
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- 11:50 AM Changeset in webkit [203120] by
-
- 3 edits2 adds in trunk
REGRESSION (202694): Audio and Video playback controls: Cannot find a position slider to adjust playback position using VO.
https://bugs.webkit.org/show_bug.cgi?id=159661
<rdar://problem/27285135>
Reviewed by Eric Carlson.
Source/WebCore:
The change in r202694 caused MediaDocuments to not always
show their scrubber. The fix is to reduce the minimum amount
of size needed to show the scrubber.
Test: media/controls/default-size-should-show-scrubber.html
- Modules/mediacontrols/mediaControlsApple.js: 80 pixels is enough
to show the scrubber.
LayoutTests:
Add a test that checks the scrubber is visible on a default media element.
Unfortunately this isn't quite an accurate test, since we really want to
examine a Media Document, but it's close enough.
- media/controls/default-size-should-show-scrubber-expected.txt: Added.
- media/controls/default-size-should-show-scrubber.html: Added.
- 11:48 AM Changeset in webkit [203119] by
-
- 4 edits in trunk
Relax ordering requirements on StringView::CodePoints iterator
https://bugs.webkit.org/show_bug.cgi?id=159609
Reviewed by Darin Adler.
Source/WTF:
Previously, there was a requirement where if you use a CodePoints
iterator, you couldn't dereference twice in a row or increment
twice in a row. This restriction is unnecessary.
- wtf/text/StringView.h:
(WTF::StringView::CodePoints::Iterator::Iterator):
(WTF::StringView::CodePoints::Iterator::advanceCurrentCodePoint):
(WTF::StringView::CodePoints::Iterator::operator*):
(WTF::StringView::CodePoints::Iterator::operator==):
Tools:
- TestWebKitAPI/Tests/WTF/StringView.cpp:
(TestWebKitAPI::TEST):
- 10:43 AM Changeset in webkit [203118] by
-
- 2 edits in trunk/Tools
Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975
https://bugs.webkit.org/show_bug.cgi?id=159564
Patch by Youenn Fablet <youenn@apple.com> on 2016-07-12
Reviewed by Brian Burg.
- Scripts/webkitpy/codegen/main.py:
(BuiltinsGeneratorTests.generate_from_js_builtins): Changing --with-wrapper-files option to --wrappers.
- 10:17 AM Changeset in webkit [203117] by
-
- 2 edits in trunk/LayoutTests
Marking http/tests/preload/single_download_preload_runner.html as a timeout
https://bugs.webkit.org/show_bug.cgi?id=159678
Unreviewed test gardening.
- 9:43 AM Changeset in webkit [203116] by
-
- 4 edits2 moves in trunk/Source/WebCore
Move MathMLOperatorDictionary from rendering to DOM
https://bugs.webkit.org/show_bug.cgi?id=159619
Patch by Frederic Wang <fwang@igalia.com> on 2016-07-12
Reviewed by Brent Fulgham.
No new tests, behavior is unchanged.
- CMakeLists.txt: Use the new location of MathMLOperatorDictionary files.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- mathml/MathMLAllInOne.cpp: Add MathMLOperatorDictionary.cpp
- mathml/MathMLOperatorDictionary.cpp: Renamed from Source/WebCore/rendering/mathml/MathMLOperatorDictionary.cpp.
- mathml/MathMLOperatorDictionary.h: Renamed from Source/WebCore/rendering/mathml/MathMLOperatorDictionary.h.
- 7:36 AM Changeset in webkit [203115] by
-
- 14 edits in trunk
Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
https://bugs.webkit.org/show_bug.cgi?id=159671
Reviewed by Csaba Osztrogonác.
ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
https://bugs.webkit.org/show_bug.cgi?id=89235
So this guard can be removed in build scripts.
.:
- Source/cmake/OptionsMac.cmake:
- Source/cmake/WebKitFeatures.cmake:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
- 6:05 AM Changeset in webkit [203114] by
-
- 4 edits2 adds in trunk/Source/WebInspectorUI
Web Inspector: Use separate files for TreeOutline/TreeElement and DataGrid/DataGridNode
https://bugs.webkit.org/show_bug.cgi?id=159659
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-07-12
Reviewed by Timothy Hatcher.
- UserInterface/Main.html:
- UserInterface/Views/DataGrid.js:
- UserInterface/Views/DataGridNode.js: Added.
- UserInterface/Views/TreeElement.js: Added.
- UserInterface/Views/TreeOutline.js:
Extra the component classes to their own file.
- 6:04 AM Changeset in webkit [203113] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r203059.
https://bugs.webkit.org/show_bug.cgi?id=159673
B and R channels now swapped on desktop GL builds (Requested
by philn on #webkit).
Reverted changeset:
"Red and blue colors are swapped in video rendered through
WebGL when GSTREAMER_GL is enabled"
https://bugs.webkit.org/show_bug.cgi?id=159621
http://trac.webkit.org/changeset/203059
- 4:29 AM Changeset in webkit [203112] by
-
- 2 edits2 adds in trunk/Source/WTF
JSCOnly bulidfix after r203078
https://bugs.webkit.org/show_bug.cgi?id=159669
Reviewed by Yusuke Suzuki.
- wtf/PlatformJSCOnly.cmake:
- wtf/text/jsconly/TextBreakIteratorInternalICUJSCOnly.cpp: Added.
(WTF::currentSearchLocaleID):
(WTF::currentTextBreakLocaleID):
- 4:14 AM Changeset in webkit [203111] by
-
- 10 edits in trunk
[Win] DLLs are missing version information.
https://bugs.webkit.org/show_bug.cgi?id=159349
Reviewed by Brent Fulgham.
.:
The version stamping will fail if the target path has forward slashes.
- Source/cmake/tools/scripts/version-stamp.pl: Replace forward slashes with backslashes.
Source/JavaScriptCore:
Generate autoversion.h and run perl version stamp utility.
- CMakeLists.txt:
Source/WebKit:
Run perl version stamp utility.
- CMakeLists.txt:
Source/WTF:
Generate autoversion.h and run perl version stamp utility.
- wtf/CMakeLists.txt:
WebKitLibraries:
The version stamping will fail if the target path has forward slashes.
- win/tools/scripts/version-stamp.pl: Replace forward slashes with backslashes.
- 2:04 AM Changeset in webkit [203110] by
-
- 4 edits in trunk/Source/WebCore
js/dom/global-constructors-attributes.html is flaky: ResourceTiming runtime feature leaks between tests
https://bugs.webkit.org/show_bug.cgi?id=158902
Reviewed by Benjamin Poulain.
Adds a new reset() mechanism to RuntimeEnabledFeatures so that they could be brought back to the initial state.
This reset() is then called from DumpRenderTree and WebKitTestRunner.
No new tests but hopefully current tests will be less flaky.
- bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::reset):
- bindings/generic/RuntimeEnabledFeatures.h:
- testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState): reset RuntimeEnabledFeatures.