Timeline
Jul 15, 2016:
- 9:51 PM Changeset in webkit [203322] by
-
- 49 edits in trunk/Source
Use emptyString() / nullAtom when possible
https://bugs.webkit.org/show_bug.cgi?id=159850
Reviewed by Ryosuke Niwa.
Use emptyString() / nullAtom when possible, for performance.
Source/WebCore:
- Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::channelCountMode):
(WebCore::AudioNode::channelInterpretation):
- Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::tracker):
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::WebSocket):
(WebCore::WebSocket::didConnect):
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::subprotocol):
(WebCore::WebSocketChannel::extensions):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::supportsPressAction):
- accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postTextStateChangePlatformNotification):
- css/CSSPropertySourceData.cpp:
(WebCore::CSSPropertySourceData::CSSPropertySourceData):
- css/PageRuleCollector.cpp:
(WebCore::PageRuleCollector::pageName):
- css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):
- dom/DocumentMarkerController.cpp:
(WebCore::DocumentMarkerController::addDictationPhraseWithAlternativesMarker):
- dom/Element.cpp:
(WebCore::Element::setPrefix):
- editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::respondToMarkerAtEndOfWord):
(WebCore::AlternativeTextController::markerDescriptionForAppliedAlternativeText):
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::removeNodeAttribute):
(WebCore::CompositeEditCommand::moveParagraphs):
- editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::positionInsideTextNode):
- editing/TextCheckingHelper.cpp:
(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):
- editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteSelection):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
(WebCore::TypingCommand::insertLineBreak):
(WebCore::TypingCommand::insertParagraphSeparator):
- editing/cocoa/EditorCocoa.mm:
(WebCore::Editor::styleForSelectionStart):
- editing/mac/EditorMac.mm:
(WebCore::Editor::stringSelectionForPasteboard):
(WebCore::Editor::stringSelectionForPasteboardWithImageAltText):
- fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::FileReaderLoader):
- html/FileInputType.cpp:
(WebCore::FileInputType::appendFormData):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::getCurrentMediaControlsStatus):
- html/HTMLOutputElement.cpp:
(WebCore::HTMLOutputElement::HTMLOutputElement):
- html/SearchInputType.cpp:
(WebCore::SearchInputType::handleKeydownEvent):
- html/TextFieldInputType.cpp:
(WebCore::autoFillButtonTypeToAccessibilityLabel):
- html/canvas/WebGLDebugShaders.cpp:
(WebCore::WebGLDebugShaders::getTranslatedShaderSource):
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::dispatchContextLostEvent):
(WebCore::WebGLRenderingContextBase::maybeRestoreContext):
- html/canvas/WebGLShader.cpp:
(WebCore::WebGLShader::WebGLShader):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlStatusDisplayElement::update):
- html/track/TextTrack.cpp:
(WebCore::TextTrack::captionMenuOffItem):
(WebCore::TextTrack::captionMenuAutomaticItem):
- html/track/VTTRegion.cpp:
(WebCore::VTTRegion::scroll):
- html/track/VTTRegion.h:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::toErrorString):
(WebCore::InspectorDOMAgent::resolveNode):
(WebCore::InspectorDOMAgent::documentURLString):
(WebCore::documentBaseURLString):
- inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::domTypeName):
- inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::localizedStringsURL):
- inspector/InspectorHistory.cpp:
(WebCore::InspectorHistory::Action::mergeId):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::reload):
(WebCore::InspectorPageAgent::frameId):
(WebCore::InspectorPageAgent::loaderId):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::ruleSelector):
- loader/EmptyClients.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::referrer):
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::clearFailedLoadURL):
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::didReceiveResponse):
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
- page/FrameTree.cpp:
(WebCore::FrameTree::setName):
(WebCore::FrameTree::clearName):
- page/Location.cpp:
(WebCore::Location::port):
- platform/network/ProtectionSpaceBase.cpp:
(WebCore::ProtectionSpaceBase::ProtectionSpaceBase):
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::handleElementAttributes):
Source/WTF:
- wtf/text/AtomicString.cpp:
(WTF::AtomicString::convertASCIICase):
- 9:17 PM Changeset in webkit [203321] by
-
- 4 edits2 deletes in trunk/LayoutTests
[mac] LayoutTest fast/css/ancestor-of-hovered-element-detached.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=159173
Reviewed by Alexey Proskuryakov.
The test ancestor-of-hovered-element-detached.html is not reliably
covering r202324.
In the case of that test, the first style update is done with
the flag TeardownType::KeepHoverAndActive. This keeps the ":hover" state
set despite the subtree losing their renderer.
This looks like a serious issue that should be tested separately.
- fast/css/ancestor-of-hovered-element-removed.html:
The :hover update timer is actually a zero timer.
It is reasonable to expect a full update after one frame update.
- fast/css/ancestor-of-hovered-element-detached-expected.txt: Removed.
- fast/css/ancestor-of-hovered-element-detached.html: Removed.
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- 9:16 PM Changeset in webkit [203320] by
-
- 7 edits in trunk/Source/JavaScriptCore
[JSC] Convert the remaining createOutOfMemoryError()+throwException() into throwOutOfMemoryError()
https://bugs.webkit.org/show_bug.cgi?id=159665
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-07-15
Reviewed by Saam Barati.
- API/JSTypedArray.cpp:
(createTypedArray):
- runtime/Error.cpp:
(JSC::createOutOfMemoryError):
- runtime/Error.h:
- runtime/ExceptionHelpers.cpp:
(JSC::throwOutOfMemoryError):
- runtime/JSArrayBufferConstructor.cpp:
(JSC::constructArrayBuffer):
- runtime/JSArrayBufferPrototype.cpp:
(JSC::arrayBufferProtoFuncSlice):
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::JSGenericTypedArrayView<Adaptor>::create):
(JSC::JSGenericTypedArrayView<Adaptor>::createUninitialized):
- 7:50 PM Changeset in webkit [203319] by
-
- 2 edits in trunk/LayoutTests
Test gardening after r203314
https://bugs.webkit.org/show_bug.cgi?id=159842
Unreviewed.
- 7:12 PM Changeset in webkit [203318] by
-
- 5 edits in trunk
[JSC] Change some parameters based on a random search
https://bugs.webkit.org/show_bug.cgi?id=158514
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-07-15
Reviewed by Saam Barati.
Source/JavaScriptCore:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::optimizationThresholdScalingFactor):
- runtime/Options.h:
Tools:
- Scripts/run-jsc-stress-tests:
- 6:43 PM Changeset in webkit [203317] by
-
- 2 edits in trunk/Source/WebCore
Repaints rects drawn incorrectly when inspecting a WebView on a Retina display
https://bugs.webkit.org/show_bug.cgi?id=159824
rdar://problem/27376305
Reviewed by Brian Burg.
InspectorOverlayPage.js set up the canvases with a deviceScaleFactor passed into
reset(), which comes from the overlay's m_page.deviceScaleFactor(). However, updatePaintRects()
used window.devicePixelRatio which was always 1.
Fix by setting the deviceScaleFactor on the m_overlayPage.
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::overlayPage):
- 6:19 PM Changeset in webkit [203316] by
-
- 3 edits in trunk/Source/WebKit2
Web Automation: Fix element and event coord space issues
https://bugs.webkit.org/show_bug.cgi?id=159851
rdar://problem/27375780
Reviewed by Brian Burg.
- UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::performMouseInteraction): Subtract topContentInset() before
it goes back out to WebDriver.
- WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::WebAutomationSessionProxy::computeElementLayout): When using useViewportCoordinates,
subtract topContentInset() so it matches expectations.
- 6:14 PM Changeset in webkit [203315] by
-
- 2 edits5 adds in trunk/Source/JavaScriptCore
Assertion failures and crashes with missing TDZ checks for catch-node bindings.
https://bugs.webkit.org/show_bug.cgi?id=158797
Reviewed by Saam Barati.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitPushCatchScope):
(JSC::BytecodeGenerator::emitPopCatchScope):
- tests/stress/catch-clause-should-be-under-tdz1.js: Added.
- tests/stress/catch-clause-should-be-under-tdz2.js: Added.
- tests/stress/catch-clause-should-be-under-tdz3.js: Added.
- tests/stress/catch-clause-should-be-under-tdz4.js: Added.
- tests/stress/catch-clause-should-be-under-tdz5.js: Added.
- 5:55 PM Changeset in webkit [203314] by
-
- 5 edits in trunk
[macOS] Work around crash in [NSAttributedString nextWordFromIndex:forward:]
https://bugs.webkit.org/show_bug.cgi?id=159842
Reviewed by Jon Lee.
Source/WebCore:
<rdar://problem/27380532> describes a crash inside [NSAttributedString nextWordFromIndex:forward:].
This must be worked around for https://bugs.webkit.org/show_bug.cgi?id=159755 and
<rdar://problem/27325521>.
- platform/text/mac/TextBoundaries.mm:
(WebCore::findNextWordFromIndex):
LayoutTests:
- editing/deleting/delete-emoji-expected.txt:
- editing/deleting/delete-emoji.html:
- 5:46 PM Changeset in webkit [203313] by
-
- 9 edits in trunk
Update XPathException to use the description in toString().
https://bugs.webkit.org/show_bug.cgi?id=159848
Reviewed by Alex Christensen.
Source/WebCore:
No new tests (Covered by changes to existing tests).
- bindings/js/JSDOMBinding.cpp:
(WebCore::createDOMException):
- xml/XPathException.h:
(WebCore::XPathException::XPathException):
LayoutTests:
- fast/dom/DOMException/XPathException-expected.txt:
- fast/dom/DOMException/resources/XPathException.js:
- fast/xpath/4XPath/Core/test_parser-expected.txt:
- fast/xpath/invalid-functions-expected.txt:
- fast/xpath/py-dom-xpath/expressions-expected.txt:
- 5:39 PM Changeset in webkit [203312] by
-
- 15 edits in trunk/Source/WebKit2
Mac UI process needs to know about element focus and blur, much like iOS
https://bugs.webkit.org/show_bug.cgi?id=159843
-and corresponding-
rdar://problem/27229504
Reviewed by Tim Horton.
This patch makes the existing iOS machinery to handle focus and blurring of
elements cross-platform. Instead of using the existing iOS messages for
startAssistingNode/stopAssistingNode, this patch adds a new message that
require only a boolean parameter: setEditableElementIsFocused.
Now that more of this code is shared, this patch teases
m_hasFocusedDueToUserInteraction out into two variables. I realized that it
was being used to mean two slightly different things on Mac and iOS, which
was very confusing. Now we have m_isAssistingNodeDueToUserInteraction to
represent the way iOS was using the variable, and we have
m_hasEverFocusedElementDueToUserInteractionSincePageTransition to represent
how Mac was using the variable. There should not be any behavior changes with
this re-name, just added clarity.
WebViewImpl has a new member variable m_editableElementIsFocused.
- UIProcess/Cocoa/WebViewImpl.h:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::setEditableElementIsFocused):
Pipe the new setEditableElementIsFocused message to WebViewImpl.
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setEditableElementIsFocused):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setEditableElementIsFocused):
elementDidFocus() and elementDidBlur() are now PLATFORM(COCOA) instead of
PLATFORM(IOS)
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::elementDidFocus):
(WebKit::WebChromeClient::elementDidBlur):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:
(WebKit::WebChromeClient::elementDidFocus): Deleted.
(WebKit::WebChromeClient::elementDidBlur): Deleted.
m_hasPendingBlurNotification is no longer iOS-only.
- WebProcess/WebPage/WebPage.cpp:
Use our two new bools m_isAssistingNodeDueToUserInteraction and
m_hasEverFocusedElementDueToUserInteractionSincePageTransition
(WebKit::WebPage::didStartPageTransition):
(WebKit::WebPage::didChangeSelection):
These functions are all newly cross-platform. The Messages they send are
still platform-specific, but otherwise the logic is the same. We
dispatch_async the blur messages so that the UI process features won’t be
flashy when the user is tapping, tabbing, or clicking through form fields.
(WebKit::WebPage::resetAssistedNodeForFrame):
(WebKit::WebPage::elementDidFocus):
(WebKit::WebPage::elementDidBlur):
resetAssistedNodeForFrame() is no longer iOS-only.
(WebKit::WebPage::didCommitLoad):
Move variables and functions around so that they are defined for the right
platform, and declare the two new bools in place of the old one.
- WebProcess/WebPage/WebPage.h:
These functions are now defined in WebPage.cpp
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::resetAssistedNodeForFrame): Deleted.
(WebKit::WebPage::elementDidFocus): Deleted.
(WebKit::WebPage::elementDidBlur): Deleted.
- 5:09 PM Changeset in webkit [203311] by
-
- 2 edits in trunk
Revert double ChangeLog entries
- 5:06 PM Changeset in webkit [203310] by
-
- 2 edits in trunk
Change toString() behavior for exceptions constructed with "createWithDescriptionAsMessage".
https://bugs.webkit.org/show_bug.cgi?id=159839
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- IndexedDB-private-browsing/idbindex_get7-expected.txt:
- IndexedDB-private-browsing/idbindex_getKey7-expected.txt:
- IndexedDB-private-browsing/idbindex_openCursor2-expected.txt:
- IndexedDB-private-browsing/idbindex_openKeyCursor3-expected.txt:
- web-platform-tests/IndexedDB/idbindex_get7-expected.txt:
- web-platform-tests/IndexedDB/idbindex_getKey7-expected.txt:
- web-platform-tests/IndexedDB/idbindex_openCursor2-expected.txt:
- web-platform-tests/IndexedDB/idbindex_openKeyCursor3-expected.txt:
Source/WebCore:
No new tests (Covered by changes to existing tests).
This is the first step towards extended exception messages for all exception types.
- dom/ExceptionBase.cpp:
(WebCore::ExceptionBase::ExceptionBase):
(WebCore::ExceptionBase::toString):
- dom/ExceptionBase.h:
LayoutTests:
- storage/indexeddb/modern/createobjectstore-failures-expected.txt:
- storage/indexeddb/modern/createobjectstore-failures-private-expected.txt:
- storage/indexeddb/modern/double-abort-expected.txt:
- storage/indexeddb/modern/double-abort-private-expected.txt:
- storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures-expected.txt:
- storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures-private-expected.txt:
- storage/indexeddb/modern/idbdatabase-transaction-failures-expected.txt:
- storage/indexeddb/modern/idbdatabase-transaction-failures-private-expected.txt:
- 5:04 PM Changeset in webkit [203309] by
-
- 21 edits in trunk
Change toString() behavior for exceptions constructed with "createWithDescriptionAsMessage".
https://bugs.webkit.org/show_bug.cgi?id=159839
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- IndexedDB-private-browsing/idbindex_get7-expected.txt:
- IndexedDB-private-browsing/idbindex_getKey7-expected.txt:
- IndexedDB-private-browsing/idbindex_openCursor2-expected.txt:
- IndexedDB-private-browsing/idbindex_openKeyCursor3-expected.txt:
- web-platform-tests/IndexedDB/idbindex_get7-expected.txt:
- web-platform-tests/IndexedDB/idbindex_getKey7-expected.txt:
- web-platform-tests/IndexedDB/idbindex_openCursor2-expected.txt:
- web-platform-tests/IndexedDB/idbindex_openKeyCursor3-expected.txt:
Source/WebCore:
No new tests (Covered by changes to existing tests).
This is the first step towards extended exception messages for all exception types.
- dom/ExceptionBase.cpp:
(WebCore::ExceptionBase::ExceptionBase):
(WebCore::ExceptionBase::toString):
- dom/ExceptionBase.h:
LayoutTests:
- storage/indexeddb/modern/createobjectstore-failures-expected.txt:
- storage/indexeddb/modern/createobjectstore-failures-private-expected.txt:
- storage/indexeddb/modern/double-abort-expected.txt:
- storage/indexeddb/modern/double-abort-private-expected.txt:
- storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures-expected.txt:
- storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures-private-expected.txt:
- storage/indexeddb/modern/idbdatabase-transaction-failures-expected.txt:
- storage/indexeddb/modern/idbdatabase-transaction-failures-private-expected.txt:
- 4:50 PM Changeset in webkit [203308] by
-
- 1 edit5 adds in trunk/LayoutTests
Merge background parser Blink test case
https://bugs.webkit.org/show_bug.cgi?id=116503
Test case is from the Blink change (patch by <apavlov@chromium.org>):
<https://chromium.googlesource.com/chromium/blink/+/3044d8c22b6ab5653fe572aad656ae1325725dc9>
- fast/css/background-parser-crash-expected.txt: Added.
- fast/css/background-parser-crash.html: Added.
- inspector/styles: Added.
- inspector/styles/background-parsing-crash-expected.txt: Added.
- inspector/styles/background-parsing-crash.html: Added.
- 4:25 PM Changeset in webkit [203307] by
-
- 1 edit2 adds in trunk/LayoutTests
Merge First-letter Blink test case
https://bugs.webkit.org/show_bug.cgi?id=123961
Test case is from the Blink change (patch by <leviw@chromium.org>):
<https://chromium.googlesource.com/chromium/blink/+/c8ff8df9fc2ad81580526d53304c281df5d93e97%5E%21/#F1>
- fast/css-generated-content/empty-first-letter-with-columns-crash-expected.txt: Added.
- fast/css-generated-content/empty-first-letter-with-columns-crash.html: Added.
- 3:38 PM Changeset in webkit [203306] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, rolling out r203304.
This is wrong because of Node* entries in the internal HashMap
Reverted changeset:
"Add move constructor / assignment operator to ListHashSet"
https://bugs.webkit.org/show_bug.cgi?id=159837
http://trac.webkit.org/changeset/203304
- 3:27 PM Changeset in webkit [203305] by
-
- 2 edits in trunk/LayoutTests
Marking http/tests/cache/disk-cache/disk-cache-request-max-stale.html as a flaky timeout on ios-simulator WK2 Release
https://bugs.webkit.org/show_bug.cgi?id=159840
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- 3:25 PM Changeset in webkit [203304] by
-
- 2 edits in trunk/Source/WTF
Add move constructor / assignment operator to ListHashSet
https://bugs.webkit.org/show_bug.cgi?id=159837
Reviewed by Alex Christensen.
Add move constructor / assignment operator to ListHashSet.
- wtf/ListHashSet.h:
- 2:51 PM Changeset in webkit [203303] by
-
- 38 edits in trunk/Source
Added a makeRef<T> helper
https://bugs.webkit.org/show_bug.cgi?id=159835
Reviewed by Andreas Kling.
Anders told me to!
Source/JavaScriptCore:
- inspector/InjectedScriptHost.cpp:
(Inspector::InjectedScriptHost::wrapper):
Source/WebCore:
- Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::putOrAddOnServer):
- Modules/indexeddb/shared/InProcessIDBServer.cpp:
(WebCore::InProcessIDBServer::deleteDatabase):
(WebCore::InProcessIDBServer::didDeleteDatabase):
(WebCore::InProcessIDBServer::openDatabase):
(WebCore::InProcessIDBServer::didOpenDatabase):
(WebCore::InProcessIDBServer::didAbortTransaction):
(WebCore::InProcessIDBServer::didCommitTransaction):
(WebCore::InProcessIDBServer::didCreateObjectStore):
(WebCore::InProcessIDBServer::didDeleteObjectStore):
(WebCore::InProcessIDBServer::didClearObjectStore):
(WebCore::InProcessIDBServer::didCreateIndex):
(WebCore::InProcessIDBServer::didDeleteIndex):
(WebCore::InProcessIDBServer::didPutOrAdd):
(WebCore::InProcessIDBServer::didGetRecord):
(WebCore::InProcessIDBServer::didGetCount):
(WebCore::InProcessIDBServer::didDeleteRecord):
(WebCore::InProcessIDBServer::didOpenCursor):
(WebCore::InProcessIDBServer::didIterateCursor):
(WebCore::InProcessIDBServer::abortTransaction):
(WebCore::InProcessIDBServer::commitTransaction):
(WebCore::InProcessIDBServer::didFinishHandlingVersionChangeTransaction):
(WebCore::InProcessIDBServer::createObjectStore):
(WebCore::InProcessIDBServer::deleteObjectStore):
(WebCore::InProcessIDBServer::clearObjectStore):
(WebCore::InProcessIDBServer::createIndex):
(WebCore::InProcessIDBServer::deleteIndex):
(WebCore::InProcessIDBServer::putOrAdd):
(WebCore::InProcessIDBServer::getRecord):
(WebCore::InProcessIDBServer::getCount):
(WebCore::InProcessIDBServer::deleteRecord):
(WebCore::InProcessIDBServer::openCursor):
(WebCore::InProcessIDBServer::iterateCursor):
(WebCore::InProcessIDBServer::establishTransaction):
(WebCore::InProcessIDBServer::fireVersionChangeEvent):
(WebCore::InProcessIDBServer::didStartTransaction):
(WebCore::InProcessIDBServer::didCloseFromServer):
(WebCore::InProcessIDBServer::notifyOpenDBRequestBlocked):
(WebCore::InProcessIDBServer::databaseConnectionClosed):
(WebCore::InProcessIDBServer::abortOpenAndUpgradeNeeded):
(WebCore::InProcessIDBServer::didFireVersionChangeEvent):
(WebCore::InProcessIDBServer::openDBRequestCancelled):
(WebCore::InProcessIDBServer::confirmDidCloseFromServer):
(WebCore::InProcessIDBServer::getAllDatabaseNames):
(WebCore::InProcessIDBServer::didGetAllDatabaseNames):
- Modules/mediastream/MediaDevicesRequest.cpp:
(WebCore::MediaDevicesRequest::didCompleteTrackSourceInfoRequest):
- Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::constraintsValidated):
(WebCore::UserMediaRequest::userMediaAccessGranted):
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::scheduleNodeDeletion):
(WebCore::AudioContext::isPlayingAudioDidChange):
(WebCore::AudioContext::suspend):
(WebCore::AudioContext::resume):
(WebCore::AudioContext::close):
(WebCore::AudioContext::suspendPlayback):
(WebCore::AudioContext::mayResumePlayback):
- Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:
(WebCore::ThreadableWebSocketChannelClientWrapper::didConnect):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryData):
(WebCore::ThreadableWebSocketChannelClientWrapper::didUpdateBufferedAmount):
(WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshake):
(WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageError):
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
- bindings/js/JSEventListener.h:
(WebCore::JSEventListener::jsFunction):
- dom/Node.cpp:
(WebCore::Node::setTextContent):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::layoutSizeChanged):
- inspector/CommandLineAPIHost.cpp:
(WebCore::CommandLineAPIHost::wrapper):
- platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
(WebCore::AudioSourceProviderAVFObjC::prepare):
- platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp:
(WebCore::WebCoreAVCFResourceLoader::invalidate):
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::WebCoreAVFResourceLoader::invalidate):
- platform/ios/WebVideoFullscreenControllerAVKit.mm:
(WebVideoFullscreenControllerContext::setExternalPlayback):
- platform/network/BlobResourceHandle.cpp:
(WebCore::BlobResourceHandle::start):
(WebCore::BlobResourceHandle::notifyFinish):
- platform/network/SocketStreamHandleBase.cpp:
(WebCore::SocketStreamHandleBase::disconnect):
- platform/network/curl/CurlDownload.cpp:
(WebCore::CurlDownload::didReceiveHeader):
Source/WebKit2:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::writeBlobsToTemporaryFiles):
- NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::tryStoreAsCacheEntry):
- Platform/IPC/Connection.cpp:
(IPC::Connection::addWorkQueueMessageReceiver):
(IPC::Connection::removeWorkQueueMessageReceiver):
(IPC::Connection::invalidate):
(IPC::Connection::sendMessage):
(IPC::Connection::processIncomingMessage):
(IPC::Connection::postConnectionDidCloseOnConnectionWorkQueue):
(IPC::Connection::connectionDidClose):
(IPC::Connection::enqueueIncomingMessage):
- Platform/IPC/mac/ConnectionMac.mm:
(IPC::Connection::receiveSourceEventHandler):
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
(WebKit::ThreadedCompositor::setNativeSurfaceHandleForCompositing):
(WebKit::ThreadedCompositor::setDeviceScaleFactor):
(WebKit::ThreadedCompositor::didChangeViewportSize):
(WebKit::ThreadedCompositor::didChangeViewportAttribute):
(WebKit::ThreadedCompositor::didChangeContentsSize):
(WebKit::ThreadedCompositor::scrollTo):
(WebKit::ThreadedCompositor::scrollBy):
(WebKit::ThreadedCompositor::didChangeVisibleRect):
- UIProcess/API/APIUserContentExtensionStore.cpp:
(API::UserContentExtensionStore::lookupContentExtension):
(API::UserContentExtensionStore::compileContentExtension):
(API::UserContentExtensionStore::removeContentExtension):
- UIProcess/Launcher/ProcessLauncher.cpp:
(WebKit::ProcessLauncher::ProcessLauncher):
- UIProcess/Storage/LocalStorageDatabaseTracker.cpp:
(WebKit::LocalStorageDatabaseTracker::LocalStorageDatabaseTracker):
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::createSessionStorageNamespace):
(WebKit::StorageManager::destroySessionStorageNamespace):
(WebKit::StorageManager::setAllowedSessionStorageNamespaceConnection):
(WebKit::StorageManager::cloneSessionStorageNamespace):
(WebKit::StorageManager::processDidCloseConnection):
(WebKit::StorageManager::getSessionStorageOrigins):
(WebKit::StorageManager::deleteSessionStorageOrigins):
(WebKit::StorageManager::deleteSessionStorageEntriesForOrigins):
(WebKit::StorageManager::getLocalStorageOrigins):
(WebKit::StorageManager::getLocalStorageOriginDetails):
(WebKit::StorageManager::deleteLocalStorageEntriesForOrigin):
(WebKit::StorageManager::deleteLocalStorageOriginsModifiedSince):
(WebKit::StorageManager::deleteLocalStorageEntriesForOrigins):
- UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::readDataFromDiskIfNeeded):
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchData):
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::pluginThreadAsyncCall):
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::wheelEvent):
(WebKit::EventDispatcher::gestureEvent):
(WebKit::EventDispatcher::touchEvent):
- WebProcess/WebPage/ViewUpdateDispatcher.cpp:
(WebKit::ViewUpdateDispatcher::visibleContentRectUpdate):
Source/WTF:
- wtf/Ref.h:
(WTF::makeRef): Helper function to do type inference for you.
- 2:35 PM Changeset in webkit [203302] by
-
- 66 edits in trunk/Source
Use fastGetAttribute() / setAttributeWithoutSynchronization() when possible
https://bugs.webkit.org/show_bug.cgi?id=159793
Reviewed by Ryosuke Niwa.
Use fastGetAttribute() / setAttributeWithoutSynchronization() when possible, for performance.
Source/WebCore:
- Modules/plugins/YouTubePluginReplacement.cpp:
(WebCore::YouTubePluginReplacement::installReplacement):
- dom/Element.h:
(WebCore::Element::setIdAttribute):
- editing/ApplyStyleCommand.cpp:
(WebCore::hasNoAttributeOrOnlyStyleAttribute):
(WebCore::createFontElement):
(WebCore::ApplyStyleCommand::applyInlineStyleChange):
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::elementIsStyledSpanOrHTMLEquivalent):
- editing/Editor.cpp:
(WebCore::Editor::setBaseWritingDirection):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::isMailPasteAsQuotationNode):
(WebCore::isInlineNodeWithStyle):
- editing/cocoa/DataDetection.mm:
(WebCore::DataDetection::detectContentInRange):
- editing/htmlediting.cpp:
(WebCore::createTabSpanElement):
- editing/ios/EditorIOS.mm:
(WebCore::Editor::setTextAlignmentForChangedBaseWritingDirection):
(WebCore::Editor::WebContentReader::readURL):
- editing/mac/EditorMac.mm:
(WebCore::Editor::WebContentReader::readURL):
- editing/markup.cpp:
(WebCore::createFragmentFromText):
- html/BaseButtonInputType.cpp:
(WebCore::BaseButtonInputType::setValue):
- html/BaseCheckableInputType.cpp:
(WebCore::BaseCheckableInputType::setValue):
- html/FTPDirectoryDocument.cpp:
(WebCore::FTPDirectoryDocumentParser::appendEntry):
(WebCore::FTPDirectoryDocumentParser::createTDForFilename):
(WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
(WebCore::FTPDirectoryDocumentParser::createBasicDocument):
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::href):
(WebCore::HTMLAnchorElement::setHref):
(WebCore::HTMLAnchorElement::target):
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::target):
- html/HTMLBaseElement.cpp:
(WebCore::HTMLBaseElement::setHref):
- html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::setType):
- html/HTMLDetailsElement.cpp:
(WebCore::HTMLDetailsElement::didAddUserAgentShadowRoot):
(WebCore::HTMLDetailsElement::toggleOpen):
- html/HTMLDocument.cpp:
(WebCore::HTMLDocument::setBgColor):
(WebCore::HTMLDocument::setFgColor):
(WebCore::HTMLDocument::setAlinkColor):
(WebCore::HTMLDocument::setLinkColor):
(WebCore::HTMLDocument::setVlinkColor):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::setDir):
(WebCore::HTMLElement::setContentEditable):
(WebCore::HTMLElement::setDraggable):
(WebCore::HTMLElement::setSpellcheck):
(WebCore::HTMLElement::setTranslate):
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::setFormEnctype):
(WebCore::HTMLFormControlElement::setFormMethod):
(WebCore::HTMLFormControlElement::setAutocorrect):
(WebCore::HTMLFormControlElement::setAutocapitalize):
(WebCore::HTMLFormControlElement::setAutocomplete):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::setAutocorrect):
(WebCore::HTMLFormElement::setAutocapitalize):
(WebCore::HTMLFormElement::setAction):
(WebCore::HTMLFormElement::setEnctype):
(WebCore::HTMLFormElement::setMethod):
(WebCore::HTMLFormElement::target):
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::width):
(WebCore::HTMLImageElement::height):
(WebCore::HTMLImageElement::setSrc):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setType):
(WebCore::HTMLInputElement::updateType):
(WebCore::HTMLInputElement::altText):
(WebCore::HTMLInputElement::setDefaultValue):
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::href):
(WebCore::HTMLLinkElement::target):
(WebCore::HTMLLinkElement::type):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setSrc):
(WebCore::HTMLMediaElement::setPreload):
- html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::min):
(WebCore::HTMLMeterElement::setMin):
(WebCore::HTMLMeterElement::max):
(WebCore::HTMLMeterElement::setMax):
(WebCore::HTMLMeterElement::value):
(WebCore::HTMLMeterElement::setValue):
(WebCore::HTMLMeterElement::low):
(WebCore::HTMLMeterElement::setLow):
(WebCore::HTMLMeterElement::high):
(WebCore::HTMLMeterElement::setHigh):
(WebCore::HTMLMeterElement::optimum):
(WebCore::HTMLMeterElement::setOptimum):
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::containsJavaApplet):
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::createForJSConstructor):
(WebCore::HTMLOptionElement::setValue):
(WebCore::HTMLOptionElement::setLabel):
- html/HTMLProgressElement.cpp:
(WebCore::HTMLProgressElement::setValue):
(WebCore::HTMLProgressElement::setMax):
- html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::typeAttributeValue):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::setMultiple):
- html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::setSrc):
(WebCore::HTMLSourceElement::media):
(WebCore::HTMLSourceElement::setMedia):
(WebCore::HTMLSourceElement::type):
(WebCore::HTMLSourceElement::setType):
- html/HTMLTableSectionElement.cpp:
(WebCore::HTMLTableSectionElement::setAlign):
(WebCore::HTMLTableSectionElement::setCh):
(WebCore::HTMLTableSectionElement::chOff):
(WebCore::HTMLTableSectionElement::setChOff):
(WebCore::HTMLTableSectionElement::setVAlign):
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::updateInnerTextElementEditability):
- html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::imageSourceURL):
- html/HiddenInputType.cpp:
(WebCore::HiddenInputType::restoreFormControlState):
(WebCore::HiddenInputType::setValue):
- html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure):
(WebCore::MediaDocument::replaceMediaElementTimerFired):
- html/PluginDocument.cpp:
(WebCore::PluginDocumentParser::createDocumentStructure):
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createAutoFillButton):
(WebCore::TextFieldInputType::updateAutoFillButton):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody):
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlClosedCaptionsContainerElement::create):
(WebCore::MediaControlTimelineElement::create):
(WebCore::MediaControlPanelVolumeSliderElement::create):
(WebCore::MediaControlFullscreenVolumeSliderElement::create):
- html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement):
- html/shadow/mac/ImageControlsButtonElementMac.cpp:
(WebCore::ImageControlsButtonElementMac::tryCreate):
- html/shadow/mac/ImageControlsRootElementMac.cpp:
(WebCore::ImageControlsRootElement::tryCreate):
- html/track/WebVTTElement.cpp:
(WebCore::WebVTTElement::createEquivalentHTMLElement):
- html/track/WebVTTParser.cpp:
(WebCore::WebVTTTreeBuilder::constructTreeFromToken):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::createInspectorStyleSheetForDocument):
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::buildObjectForFrame):
- mathml/MathMLSelectElement.cpp:
(WebCore::MathMLSelectElement::toggle):
- page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeFrame):
- rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::isOpen):
- rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::updateFromElement):
- svg/SVGElement.cpp:
(WebCore::SVGElement::setXmlbase):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::setContentScriptType):
(WebCore::SVGSVGElement::setContentStyleType):
- svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::setMedia):
(WebCore::SVGStyleElement::setTitle):
Source/WebKit/mac:
- WebView/WebHTMLRepresentation.mm:
(matchLabelsAgainstElement):
Source/WebKit/win:
- DOMHTMLClasses.cpp:
(DOMHTMLElement::idName):
Source/WebKit2:
- WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm:
(WebKit::PDFPlugin::PDFPlugin):
- WebProcess/Plugins/PDF/PDFPlugin.mm:
(WebKit::PDFPlugin::createPasswordEntryForm):
- WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:
(WebKit::PDFPluginAnnotation::attach):
- WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:
(WebKit::PDFPluginChoiceAnnotation::createAnnotationElement):
- 2:34 PM Changeset in webkit [203301] by
-
- 9 edits in trunk/Source/WebCore
Modernize StaticNodeList / StaticElementList
https://bugs.webkit.org/show_bug.cgi?id=159831
Reviewed by Ryosuke Niwa.
Modernize StaticNodeList / StaticElementList. Pass vector to adopt
as an rvalue reference instead of a non-const reference.
- bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::namedItems):
- dom/ChildListMutationScope.cpp:
(WebCore::ChildListMutationAccumulator::enqueueMutationRecord):
- dom/MutationRecord.cpp:
- dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::queryAll):
- dom/StaticNodeList.h:
- dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::getRegionsByContent):
(WebCore::WebKitNamedFlow::getRegions):
(WebCore::WebKitNamedFlow::getContent):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::collectIntersectionOrEnclosureList):
- testing/Internals.cpp:
(WebCore::Internals::nodesFromRect):
- 2:18 PM Changeset in webkit [203300] by
-
- 3 edits3 adds in trunk
Block insecure script running in a data: frame when the top-level page is HTTPS
https://bugs.webkit.org/show_bug.cgi?id=125806
<rdar://problem/27331825>
Reviewed by Brady Eidson.
Fix based on a Blink change (patch by <tsepez@chromium.org>):
<https://chromium.googlesource.com/chromium/blink/+/33e553bd96e040151c1472289a0d80803bfca3a5>
Source/WebCore:
Test: http/tests/security/mixedContent/insecure-script-in-data-iframe-in-main-frame-blocked.html
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::checkInsecureContent): Check the top-level frame's security state
before allowing insecure scripts to be used.
LayoutTests:
- http/tests/security/mixedContent/insecure-script-in-data-iframe-in-main-frame-blocked-expected.txt: Added.
- http/tests/security/mixedContent/insecure-script-in-data-iframe-in-main-frame-blocked.html: Added.
- http/tests/security/mixedContent/resources/frame-with-data-url-frame-with-script.html: Added.
- 2:17 PM Changeset in webkit [203299] by
-
- 2 edits in trunk/Source/JavaScriptCore
FunctionOverride's parseClause() needs to keep the CString instance in scope while its data is being used.
https://bugs.webkit.org/show_bug.cgi?id=159828
Reviewed by Saam Barati.
Otherwise, we'll have a use after free. This issue was caught when running an
ASan debug build of testapi.
- tools/FunctionOverrides.cpp:
(JSC::parseClause):
- 2:01 PM Changeset in webkit [203298] by
-
- 2 edits in trunk/Source/WebCore
Let the compiler generate QualifiedName copy constructor and assignment operator
https://bugs.webkit.org/show_bug.cgi?id=159826
Reviewed by Alex Christensen.
Let the compiler generate QualifiedName copy constructor and assignment operator
as our custom implementation does nothing special. This also makes QualifiedName
movable as the compiler is now able to generate the move constructor / assignment
operator as well.
- dom/QualifiedName.h:
(WebCore::QualifiedName::QualifiedName): Deleted.
(WebCore::QualifiedName::operator=): Deleted.
- 1:58 PM Changeset in webkit [203297] by
-
- 9 edits1 add in trunk/Source/JavaScriptCore
%TypedArray%.prototype.indexOf is coercing non-integers or non-floats to numbers wrongly
https://bugs.webkit.org/show_bug.cgi?id=159400
Reviewed by Geoffrey Garen.
This patch fixes coercion of non-numbers in indexOf/lastIndexOf.
Additionally, this patch fixes an issue with includes where it
would not check that the buffer remained non-neutered after
calling the toInteger() function. Lastly, some extra release
asserts have been added in some places to inform us of any issues
in the future.
Additionally, this patch changes bool toNativeFromDouble to
Optional<Type> toNativeFromDoubleWithoutCoercion. This makes it a
little clearer what the function does and also removes the return
argument. The only behavior change is that the function no longer
coerces non-numbers into numbers. That behavior was unused (maybe
unintended), however.
- runtime/JSGenericTypedArrayView.h:
(JSC::JSGenericTypedArrayView::toAdaptorNativeFromValueWithoutCoercion):
(JSC::JSGenericTypedArrayView::sort):
(JSC::JSGenericTypedArrayView::toAdaptorNativeFromValue): Deleted.
- runtime/JSGenericTypedArrayViewPrototypeFunctions.h:
(JSC::genericTypedArrayViewProtoFuncCopyWithin):
(JSC::genericTypedArrayViewProtoFuncIncludes):
(JSC::genericTypedArrayViewProtoFuncIndexOf):
(JSC::genericTypedArrayViewProtoFuncLastIndexOf):
- runtime/ToNativeFromValue.h:
(JSC::toNativeFromValueWithoutCoercion):
(JSC::toNativeFromValue): Deleted.
- runtime/TypedArrayAdaptors.h:
(JSC::IntegralTypedArrayAdaptor::toNativeFromInt32WithoutCoercion):
(JSC::IntegralTypedArrayAdaptor::toNativeFromUint32WithoutCoercion):
(JSC::IntegralTypedArrayAdaptor::toNativeFromDoubleWithoutCoercion):
(JSC::FloatTypedArrayAdaptor::toNativeFromInt32WithoutCoercion):
(JSC::FloatTypedArrayAdaptor::toNativeFromDoubleWithoutCoercion):
(JSC::Uint8ClampedAdaptor::toNativeFromInt32WithoutCoercion):
(JSC::Uint8ClampedAdaptor::toNativeFromDoubleWithoutCoercion):
(JSC::IntegralTypedArrayAdaptor::toNativeFromInt32): Deleted.
(JSC::IntegralTypedArrayAdaptor::toNativeFromUint32): Deleted.
(JSC::IntegralTypedArrayAdaptor::toNativeFromDouble): Deleted.
(JSC::FloatTypedArrayAdaptor::toNativeFromInt32): Deleted.
(JSC::FloatTypedArrayAdaptor::toNativeFromDouble): Deleted.
(JSC::Uint8ClampedAdaptor::toNativeFromInt32): Deleted.
(JSC::Uint8ClampedAdaptor::toNativeFromDouble): Deleted.
- tests/stress/resources/typedarray-test-helper-functions.js:
- tests/stress/typedarray-functions-with-neutered.js:
(callWithArgs):
- tests/stress/typedarray-includes.js: Added.
- tests/stress/typedarray-indexOf.js:
- tests/stress/typedarray-lastIndexOf.js:
- 1:56 PM Changeset in webkit [203296] by
-
- 2 edits in trunk/Source/WebKit2
Disable custom elements in Safari Tech Preview
https://bugs.webkit.org/show_bug.cgi?id=159829
Reviewed by Chris Dumez.
Disable custom elements API in Safari Technology Preview. Our implementation is so out of sync
with the latest spec that it's actively harmful to have this feature enabled.
- Shared/WebPreferencesDefinitions.h:
- 1:42 PM Changeset in webkit [203295] by
-
- 3 edits in trunk/Source/WebKit2
Full screen ePub embedded video is playing on 1/4 screen, cut off
https://bugs.webkit.org/show_bug.cgi?id=159737
<rdar://problem/26259404>
Patch by Jer Noble <jer.noble@apple.com> on 2016-07-15
Reviewed by Tim Horton.
Set the fixedLayoutSize to CGSizeZero when disabling fixed layout due to the
WebView not supporting arbitrary layout modes, and reset to the saved value
when the view does begin supporting arbitrary layout modes.
- UIProcess/Cocoa/WebViewImpl.h:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::setFixedLayoutSize):
(WebKit::WebViewImpl::updateSupportsArbitraryLayoutModes):
- 1:19 PM Changeset in webkit [203294] by
-
- 3 edits in trunk/Source/WebCore
ScrollView::setHasHorizontalScrollbar / setHasVerticalScrollbar duplicate their logic
https://bugs.webkit.org/show_bug.cgi?id=159825
Patch introduces a (private) method to ScrollView
to share the code/logic of setHas{Horizontal,Vertical}Scrollbar.
Patch by Antonio Gomes <tonikitoo@igalia.com> on 2016-07-15
Reviewed by Simon Fraser.
No new tests needed.
- platform/ScrollView.cpp:
(WebCore::ScrollView::setHasScrollbarInternal):
(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):
- platform/ScrollView.h:
- 1:03 PM Changeset in webkit [203293] by
-
- 3 edits in trunk/Source/JavaScriptCore
Add new functions to ARMAssembler after r202214
https://bugs.webkit.org/show_bug.cgi?id=159713
Reviewed by Saam Barati.
- assembler/ARMAssembler.h:
(JSC::ARMAssembler::fillNops):
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::patchableBranch32):
(JSC::MacroAssemblerARM::internalCompare32):
- 12:38 PM Changeset in webkit [203292] by
-
- 2 edits in trunk/LayoutTests
Skipping test from r203288 on ios-simulator due to reliance upon mouse events.
https://bugs.webkit.org/show_bug.cgi?id=159818
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 12:27 PM Changeset in webkit [203291] by
-
- 2 edits in trunk/Websites/webkit.org
Fixed content overflow and missing build information behavior.
https://bugs.webkit.org/show_bug.cgi?id=159820
Reviewed by Timothy Hatcher.
- wp-content/themes/webkit/nightly-start.php:
- 12:01 PM Changeset in webkit [203290] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Make Open Quickly and Goto Line dialogs match Xcode 8
https://bugs.webkit.org/show_bug.cgi?id=159823
rdar://problem/27376501
Reviewed by Brian Burg.
- UserInterface/Views/GoToLineDialog.css:
(.go-to-line-dialog):
(.go-to-line-dialog > div > input):
(.go-to-line-dialog > div > input::placeholder):
(.go-to-line-dialog > div > img):
(.go-to-line-dialog > div): Deleted.
- UserInterface/Views/OpenResourceDialog.css:
(.open-resource-dialog):
(.open-resource-dialog > .field):
(.open-resource-dialog > .field > input):
(.open-resource-dialog > .field > input::placeholder):
(.open-resource-dialog > .field > img):
(.open-resource-dialog > .tree-outline .item): Deleted.
(.open-resource-dialog > .tree-outline .item:first-child): Deleted.
- 11:47 AM Changeset in webkit [203289] by
-
- 17 edits in trunk
MathOperator: Improve alignment for vertical size variant
https://bugs.webkit.org/show_bug.cgi?id=158866
Patch by Frederic Wang <fwang@igalia.com> on 2016-07-15
Reviewed by Brent Fulgham.
Source/WebCore:
The MathOperator class may stretch operators with either a large glyph or a glyph assembly.
In the latter case, the assembly is adjusted to match the stretch ascent and descent
requested by the callers. But in the former case the glyph ascent and descent are used
instead. We solve this by making MathOperator::stretchTo only take a targetSize and let
callers do the vertical alignment they want. This improves the rendering of fences with some
math fonts (e.g. XITS) and allows to pass the two cases of mo-axis-height-1.html.
Test: imported/mathml-in-html5/mathml/presentation-markup/operators/mo-axis-height-1.html
- rendering/mathml/MathOperator.cpp:
(WebCore::MathOperator::stretchTo): Merge vertical and horizontal stretching into the same
function with only the targetSize as a parameter.
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::stretchTo): Updated to use the new signature.
(WebCore::RenderMathMLOperator::verticalStretchedOperatorShift): Helper function to calculate
the shift necessary to align the baseline of the MathOperator instance with the one of the
RenderMathMLOperator.
(WebCore::RenderMathMLOperator::firstLineBaseline): Adjust the baseline.
- rendering/mathml/RenderMathMLOperator.h: Declare verticalStretchedOperatorShift.
- rendering/mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::layoutBlock): Use the new signature. This function aligns the top
of the radical with the overbar so we do not need to adjust baseline alignment here.
LayoutTests:
We import the latest version of mo-axis-height-1.html and update the expectation now that we
pass the two cases (size variant and glyph assembly). We also rebaseline some pixel tests.
- imported/mathml-in-html5/fonts/math/axisheight5000-verticalarrow14000.woff: Updated.
- imported/mathml-in-html5/mathml/presentation-markup/operators/mo-axis-height-1-expected.txt: Updated to expect PASS.
- imported/mathml-in-html5/mathml/presentation-markup/operators/mo-axis-height-1.html: Updated to include the two tests.
- platform/gtk/mathml/opentype/vertical-expected.png: Rebaseline to take into account better alignment of size variant.
- platform/gtk/mathml/opentype/vertical-expected.txt: Ditto.
- platform/gtk/mathml/presentation/mo-stretch-expected.png: Ditto.
- platform/gtk/mathml/presentation/mo-stretch-expected.txt: Ditto.
- platform/ios-simulator/mathml/opentype/opentype-stretchy-expected.txt: Ditto.
- platform/ios-simulator/mathml/presentation/mo-stretch-expected.txt: Ditto.
- platform/mac/mathml/opentype/opentype-stretchy-expected.txt: Ditto.
- platform/mac/mathml/presentation/mo-stretch-expected.txt: Ditto.
- 11:39 AM Changeset in webkit [203288] by
-
- 3 edits2 adds in trunk
WebKit should prevent push/replace state with username in URL.
<rdar://problem/27361737> and https://bugs.webkit.org/show_bug.cgi?id=159818
Reviewed by Brent Fulgham.
Source/WebCore:
Test: http/tests/security/history-username-password.html
- page/History.cpp:
(WebCore::History::stateObjectAdded): Don't allow URLs with usernames/passwords.
LayoutTests:
- http/tests/security/history-username-password-expected.txt: Added.
- http/tests/security/history-username-password.html: Added.
- 11:33 AM Changeset in webkit [203287] by
-
- 10 edits52 deletes in trunk
Unreviewed, rolling out r203266.
This change caused editing/deleting/delete-emoji.html to time
out on El Capitan, crash under GuardMalloc
Reverted changeset:
"Support new emoji group candidates"
https://bugs.webkit.org/show_bug.cgi?id=159755
http://trac.webkit.org/changeset/203266
- 11:31 AM Changeset in webkit [203286] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
Stack overflow error for deeply nested classes.
https://bugs.webkit.org/show_bug.cgi?id=157086
Reviewed by Geoffrey Garen.
Changed the StructureStubClearingWatchpoint destructor to iteratively destruct
its chain of next StructureStubClearingWatchpoints instead of recursively doing
so.
The added deep-StructureStubClearingWatchpoint-destructor-recursion.js test
produces a crash before the fix is applied, but takes about 14 minutes to run.
Hence, it is skipped.
- bytecode/StructureStubClearingWatchpoint.cpp:
(JSC::StructureStubClearingWatchpoint::~StructureStubClearingWatchpoint):
- tests/stress/deep-StructureStubClearingWatchpoint-destructor-recursion.js: Added.
- 11:30 AM MathML/Early_2016_Refactoring edited by
- (diff)
- 11:24 AM Changeset in webkit [203285] by
-
- 11 edits2 adds in trunk
Source/WebCore:
Move parsing of mfrac attributes into a MathMLFractionElement class
https://bugs.webkit.org/show_bug.cgi?id=159624
Patch by Frederic Wang <fwang@igalia.com> on 2016-07-15
Reviewed by Brent Fulgham.
We move the parsing of mfrac attributes to a MathMLFractionElement class. This allows to
minimize the updates in RenderMathMLFraction and to remove the alignment members. Many of
the members in updateLayoutParameters are actually only used in layoutBlock and could be
removed in a follow-up patch. We also improve the resolution of negative line thickness value
since the MathML recommendation says it should be rounded up to the nearest valid
value (which is zero) instead of ignoring the attribute and using the line thickness.
No new tests, already covered by existing tests.
- CMakeLists.txt: Add MathMLFractionElement.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- mathml/MathMLAllInOne.cpp: Ditto.
- mathml/MathMLFractionElement.cpp: Added.
(WebCore::MathMLFractionElement::MathMLFractionElement):
(WebCore::MathMLFractionElement::create):
(WebCore::MathMLFractionElement::lineThickness): Return the cached linethickness length,
parsing it again if it is dirty. This handles the special values "thin", "medium" and "thick"
or fallback to the general parseMathMLLength for MathML lengths.
(WebCore::MathMLFractionElement::cachedFractionAlignment): Return the cached alignment value,
parsing it again if it is dirty.
(WebCore::MathMLFractionElement::numeratorAlignment): Return the cached alignment.
(WebCore::MathMLFractionElement::denominatorAlignment): Ditto.
(WebCore::MathMLFractionElement::parseAttribute): Make attributes dirty.
(WebCore::MathMLFractionElement::createElementRenderer): Create a RenderMathMLFraction.
- mathml/MathMLFractionElement.h: Added.
- mathml/MathMLInlineContainerElement.cpp: We no longer need to handle fraction here.
(WebCore::MathMLInlineContainerElement::createElementRenderer):
- mathml/mathtags.in: Use MathMLFractionElement for mfrac.
- rendering/mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::updateLayoutParameters): New helper function to set the
layout parameters, replacing updateFromElement. We no longer parse and store the alignment
values here. We also change the resolution of negative values.
(WebCore::RenderMathMLFraction::horizontalOffset): Use the enum from MathMLFractionElement.
(WebCore::RenderMathMLFraction::layoutBlock): We call updateLayoutParameters instead of
updateFromElement. The numerator and denominator alignments are resolved here.
(WebCore::RenderMathMLFraction::parseAlignmentAttribute): Deleted. Parsing of alignment
attribute is now handled in MathMLFractionElement.
(WebCore::RenderMathMLFraction::updateFromElement): Deleted. Attribute changes are now
handled in MathMLFractionElement.
(WebCore::RenderMathMLFraction::styleDidChange): Deleted. Font changes are properly handled.
- rendering/mathml/RenderMathMLFraction.h: Update declarations.
LayoutTests:
Move parsing of mfrac attributes into a MathMLFractionElementClass
https://bugs.webkit.org/show_bug.cgi?id=159624
Patch by Frederic Wang <fwang@igalia.com> on 2016-07-15
Reviewed by Brent Fulgham.
We update the expectation for negative linethickness. As indicated in the MathML
recommendation, it should be rounded up to the nearest valid value, which is 0.
- mathml/presentation/mfrac-linethickness2.html: Update the comment to reflect the new behavior.
- mathml/presentation/mfrac-linethickness2-expected.html: Use 0px as the reference for negative values.
- 11:06 AM Changeset in webkit [203284] by
-
- 2 edits in trunk/Tools
Changed the start page URL for WebKit Nightly builds.
https://bugs.webkit.org/show_bug.cgi?id=159816
Reviewed by Timothy Hatcher.
- WebKitLauncher/start.html:
- 10:41 AM Changeset in webkit [203283] by
-
- 1 edit2 adds in trunk/LayoutTests
Merge InlineBidiResolver end-of-line Blink test case
https://bugs.webkit.org/show_bug.cgi?id=126201
<rdar://problem/27331789>
Test case is from the Blink change (patch by <igor.o@chromium.org>):
<https://chromium.googlesource.com/chromium/blink/+/d34ca9bbbdf71905d61aa45def30063311508a64>
- fast/text/international/bidi-crash-reached-end-of-line-expected.txt: Added.
- fast/text/international/bidi-crash-reached-end-of-line.html: Added.
- 10:35 AM Changeset in webkit [203282] by
-
- 1 edit2 adds in trunk/LayoutTests
Merge Blink test case
https://bugs.webkit.org/show_bug.cgi?id=123870
Patch is from the Blink change (patch by <morritaw@chromium.org>):
<https://chromium.googlesource.com/chromium/blink/+/2abd63ccea97b1fcf25b337c76f12e6ad1bfc025>
- fast/dom/mutation-details-focus-expected.txt: Added.
- fast/dom/mutation-details-focus.html: Added.
- 10:30 AM Changeset in webkit [203281] by
-
- 2 edits in trunk/LayoutTests
Updating TestExpectations after r203267
https://bugs.webkit.org/show_bug.cgi?id=159817
Unreviewed test gardening.
- 10:03 AM Changeset in webkit [203280] by
-
- 4 edits in trunk/Source/WebCore
Check whether font is nonnull for GlyphData instead of calling GlyphData::isValid()
https://bugs.webkit.org/show_bug.cgi?id=159783
Patch by Frederic Wang <fwang@igalia.com> on 2016-07-15
Reviewed by Brent Fulgham.
GlyphData::isValid() returns true for GlyphData with null 'font' pointer when the 'glyph'
index is nonzero. This behavior is not expected by the MathML code and we have had crashes
in our test suite in the past on Windows (e.g. bug 140653). We thus replace the call to
GlyphData::isValid() with a stronger verification: Whether the 'font' pointer is nonzero.
No new tests, this only makes null pointer checks stronger.
- rendering/mathml/MathOperator.cpp:
(WebCore::boundsForGlyph):
(WebCore::advanceWidthForGlyph):
(WebCore::MathOperator::getBaseGlyph):
(WebCore::MathOperator::setSizeVariant):
(WebCore::MathOperator::fillWithVerticalExtensionGlyph):
(WebCore::MathOperator::fillWithHorizontalExtensionGlyph):
(WebCore::MathOperator::paintVerticalGlyphAssembly):
(WebCore::MathOperator::paintHorizontalGlyphAssembly):
(WebCore::MathOperator::paint):
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths):
- rendering/mathml/RenderMathMLToken.cpp:
(WebCore::RenderMathMLToken::computePreferredLogicalWidths):
(WebCore::RenderMathMLToken::firstLineBaseline):
(WebCore::RenderMathMLToken::layoutBlock):
(WebCore::RenderMathMLToken::paint):
(WebCore::RenderMathMLToken::paintChildren):
- 9:51 AM Changeset in webkit [203279] by
-
- 2 edits in trunk/Source/WebCore
Add DejaVu Math TeX Gyre to the list of math fonts.
https://bugs.webkit.org/show_bug.cgi?id=159805
Patch by Frederic Wang <fwang@igalia.com> on 2016-07-15
Reviewed by Brent Fulgham.
DejaVu 2.36 has a new math font that can be used for MathML rendering. Because this font is
likely to be installed on many systems (Linux, LibreOffice, etc) we include it in the default
list of font-families in mathml.css in order to increase the chance to find a math font.
No new tests, it only affects rendering when DejaVu Math TeX Gyre is installed on the system.
- css/mathml.css:
(math):
- 9:48 AM Changeset in webkit [203278] by
-
- 3 edits41 adds in trunk/LayoutTests
Import more tests from the MathML in HTML5 test suite
https://bugs.webkit.org/show_bug.cgi?id=159715
Patch by Frederic Wang <fwang@igalia.com> on 2016-07-15
Reviewed by Brent Fulgham.
- imported/mathml-in-html5/fonts/math/lineheight5000-typolineheight2300.woff: Added.
- imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-5-expected.txt: Added.
- imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-5.html: Added.
- imported/mathml-in-html5/mathml/presentation-markup/spaces/space-1-expected.txt: Added.
- imported/mathml-in-html5/mathml/presentation-markup/spaces/space-1.html: Added.
- imported/mathml-in-html5/mathml/presentation-markup/spaces/space-2-expected.html: Added.
- imported/mathml-in-html5/mathml/presentation-markup/spaces/space-2.html: Added.
- imported/mathml-in-html5/mathml/relations/css-styling/color-1-expected.html: Added.
- imported/mathml-in-html5/mathml/relations/css-styling/color-1.html: Added.
- imported/mathml-in-html5/mathml/relations/css-styling/visibility-1-expected.html: Added.
- imported/mathml-in-html5/mathml/relations/css-styling/visibility-1.html: Added.
- imported/mathml-in-html5/mathml/relations/html5-tree/class-1-expected.html: Added.
- imported/mathml-in-html5/mathml/relations/html5-tree/class-1.html: Added.
- imported/mathml-in-html5/mathml/relations/html5-tree/class-2-expected.txt: Added.
- imported/mathml-in-html5/mathml/relations/html5-tree/class-2.html: Added.
- imported/mathml-in-html5/mathml/relations/html5-tree/color-attributes-1-expected.html: Added.
- imported/mathml-in-html5/mathml/relations/html5-tree/color-attributes-1.html: Added.
- imported/mathml-in-html5/mathml/relations/html5-tree/display-1-expected.txt: Added.
- imported/mathml-in-html5/mathml/relations/html5-tree/display-1.html: Added.
- imported/mathml-in-html5/mathml/relations/html5-tree/dynamic-1-expected.html: Added.
- imported/mathml-in-html5/mathml/relations/html5-tree/dynamic-1.html: Added.
- imported/mathml-in-html5/mathml/relations/html5-tree/integration-point-1-expected.html: Added.
- imported/mathml-in-html5/mathml/relations/html5-tree/integration-point-1.html: Added.
- imported/mathml-in-html5/mathml/relations/html5-tree/integration-point-2-expected.html: Added.
- imported/mathml-in-html5/mathml/relations/html5-tree/integration-point-2.html: Added.
- imported/mathml-in-html5/mathml/relations/html5-tree/integration-point-3-expected.html: Added.
- imported/mathml-in-html5/mathml/relations/html5-tree/integration-point-3.html: Added.
- imported/mathml-in-html5/mathml/relations/html5-tree/namespace-1-expected.txt: Added.
- imported/mathml-in-html5/mathml/relations/html5-tree/namespace-1.html: Added.
- imported/mathml-in-html5/mathml/relations/html5-tree/required-extensions-1-expected.txt: Added.
- imported/mathml-in-html5/mathml/relations/html5-tree/required-extensions-1.html: Added.
- imported/mathml-in-html5/mathml/relations/html5-tree/required-extensions-2-expected.html: Added.
- imported/mathml-in-html5/mathml/relations/html5-tree/required-extensions-2.html: Added.
- imported/mathml-in-html5/mathml/relations/html5-tree/unique-identifier-2-expected.txt: Added.
- imported/mathml-in-html5/mathml/relations/html5-tree/unique-identifier-2.html: Added.
- imported/mathml-in-html5/mathml/relations/html5-tree/unique-identifier-3-expected.html: Added.
- imported/mathml-in-html5/mathml/relations/html5-tree/unique-identifier-3.html: Added.
- imported/mathml-in-html5/mathml/relations/text-and-math/use-typo-metrics-1-expected.html: Added.
- imported/mathml-in-html5/mathml/relations/text-and-math/use-typo-metrics-1.html: Added.
- platform/ios-simulator/TestExpectations: Mark use-typo-metrics-1.html as failing.
- platform/mac/TestExpectations: Ditto.
- 9:42 AM Changeset in webkit [203277] by
-
- 5 edits in trunk
[MSE] Increase the SourceBuffer "fudge factor"
https://bugs.webkit.org/show_bug.cgi?id=159813
<rdar://problem/27372033>
Reviewed by Jon Lee.
Source/WebCore:
Some media encoding/conversion pipelines are sloppy when doing sample time/timescale
math, and the error accumulation results in small gaps in the media timeline. r202641
increased the maximum allowable gap from 0.01 second to one 24fps frame, but it turns
out that at least one large provider has a significant amount of content encoded with
up to two 24fps frames.
No new tests, updated media/media-source/media-source-small-gap.html.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::currentTimeFudgeFactor): Increase maximum gap to 2002 / 24000 frames.
LayoutTests:
- media/media-source/media-source-small-gap-expected.txt:
- media/media-source/media-source-small-gap.html:
- 9:11 AM MathML edited by
- (diff)
- 9:06 AM MathML/Fonts edited by
- Add DejaVu font (diff)
- 7:52 AM Changeset in webkit [203276] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix expectations in test262.yaml
https://bugs.webkit.org/show_bug.cgi?id=159810
Reviewed by Keith Miller.
- tests/test262.yaml:
- 5:46 AM Changeset in webkit [203275] by
-
- 53 edits in trunk/Source/WebCore
Add final keyword to WebCore/svg classes
https://bugs.webkit.org/show_bug.cgi?id=159802
Patch by Rawinder Singh <rawinder.singh-webkit@cisra.canon.com.au> on 2016-07-15
Reviewed by Youenn Fablet.
Updated classes in the WebCore/svg directory to be marked as final where appropriate.
- svg/SVGException.h:
- svg/SVGLengthList.h:
- svg/SVGMatrix.h:
- svg/SVGNumberList.h:
- svg/SVGPaint.h:
- svg/SVGPathBuilder.h:
- svg/SVGPathByteStreamBuilder.h:
- svg/SVGPathByteStreamSource.h:
- svg/SVGPathSegArcAbs.h:
- svg/SVGPathSegArcRel.h:
- svg/SVGPathSegClosePath.h:
- svg/SVGPathSegCurvetoCubicAbs.h:
- svg/SVGPathSegCurvetoCubicRel.h:
- svg/SVGPathSegCurvetoCubicSmoothAbs.h:
- svg/SVGPathSegCurvetoCubicSmoothRel.h:
- svg/SVGPathSegCurvetoQuadraticAbs.h:
- svg/SVGPathSegCurvetoQuadraticRel.h:
- svg/SVGPathSegCurvetoQuadraticSmoothAbs.h:
- svg/SVGPathSegCurvetoQuadraticSmoothRel.h:
- svg/SVGPathSegLinetoAbs.h:
- svg/SVGPathSegLinetoHorizontalAbs.h:
- svg/SVGPathSegLinetoHorizontalRel.h:
- svg/SVGPathSegLinetoRel.h:
- svg/SVGPathSegLinetoVerticalAbs.h:
- svg/SVGPathSegLinetoVerticalRel.h:
- svg/SVGPathSegListBuilder.h:
- svg/SVGPathSegListSource.h:
- svg/SVGPathSegMovetoAbs.h:
- svg/SVGPathSegMovetoRel.h:
- svg/SVGPathStringSource.h:
- svg/SVGPathTraversalStateBuilder.h:
- svg/SVGPointList.h:
- svg/SVGRenderingIntent.h:
- svg/SVGStringList.h:
- svg/SVGTRefElement.cpp:
- svg/SVGToOTFFontConversion.cpp:
- svg/SVGTransformList.h:
- svg/SVGUnitTypes.h:
- svg/SVGViewSpec.h:
- svg/SVGZoomEvent.h:
- svg/animation/SMILTimeContainer.h:
- svg/animation/SVGSMILElement.cpp:
- svg/graphics/filters/SVGFEImage.h:
- svg/graphics/filters/SVGFilter.h:
- svg/properties/SVGAnimatedPathSegListPropertyTearOff.h:
- svg/properties/SVGAnimatedPropertyTearOff.h:
- svg/properties/SVGAnimatedTransformListPropertyTearOff.h:
- svg/properties/SVGMatrixTearOff.h:
- svg/properties/SVGPathSegListPropertyTearOff.h:
- svg/properties/SVGStaticListPropertyTearOff.h:
- svg/properties/SVGStaticPropertyTearOff.h:
- svg/properties/SVGTransformListPropertyTearOff.h:
- 5:38 AM Changeset in webkit [203274] by
-
- 5 edits1 add in trunk
Uninitialized variable in DIBPixelData can cause a dangerous memory write
https://bugs.webkit.org/show_bug.cgi?id=159414
Reviewed by Brent Fulgham.
Source/WebCore:
Initialize local BITMAP variable, in case the ::GetObject function that should initialize it
fails to do so, because the bitmap handle is invalid.
Tests: Tools/TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp
- platform/graphics/win/DIBPixelData.cpp:
(WebCore::DIBPixelData::initialize): Initialize local variable.
(WebCore::DIBPixelData::setRGBABitmapAlpha): Return early if we have no bitmap.
- platform/graphics/win/DIBPixelData.h: Link fix.
Tools:
Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
when the HDC parameter is invalid.
- TestWebKitAPI/PlatformWin.cmake:
- TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
(TestWebKitAPI::TEST):
- 3:21 AM Changeset in webkit [203273] by
-
- 2 edits in trunk/Source/WTF
Revert r202560 to fix the ARMv7 build with ARM instruction set
https://bugs.webkit.org/show_bug.cgi?id=159707
Reviewed by Carlos Garcia Campos.
- wtf/Platform.h: Revert r202560.
- 2:43 AM Changeset in webkit [203272] by
-
- 2 edits in trunk/Source/JavaScriptCore
[ARM] Disable Inline Caching on ARMv7 traditional until proper fix
https://bugs.webkit.org/show_bug.cgi?id=159759
Reviewed by Saam Barati.
- jit/Repatch.cpp:
(JSC::forceICFailure):
- 2:25 AM Changeset in webkit [203271] by
-
- 5 edits1 copy1 add in trunk/Tools
[GTK] Add basic tabs support to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=159803
Reviewed by Sergio Villar Senin.
It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.
- MiniBrowser/gtk/BrowserTab.c: Added.
(titleChanged):
(isLoadingChanged):
(decidePolicy):
(removeChildIfInfoBar):
(loadChanged):
(createInfoBarQuestionMessage):
(tlsErrorsDialogResponse):
(loadFailedWithTLSerrors):
(permissionRequestDialogResponse):
(decidePermissionRequest):
(colorChooserRGBAChanged):
(popoverColorClosed):
(colorChooserRequestFinished):
(runColorChooserCallback):
(inspectorOpenedInWindow):
(inspectorClosed):
(browserTabSetProperty):
(browserTabFinalize):
(browser_tab_init):
(browserTabConstructed):
(browser_tab_class_init):
(getInternalURI):
(browser_tab_new):
(browser_tab_get_web_view):
(browser_tab_load_uri):
(browser_tab_get_title_widget):
(browser_tab_set_status_text):
(browser_tab_toggle_inspector):
(browser_tab_start_search):
(browser_tab_stop_search):
(browser_tab_add_accelerators):
(fullScreenMessageTimeoutCallback):
(browser_tab_enter_fullscreen):
(browser_tab_leave_fullscreen):
- MiniBrowser/gtk/BrowserTab.h: Added.
- MiniBrowser/gtk/BrowserWindow.c:
(getExternalURI):
(browserWindowSetStatusText):
(reloadOrStopCallback):
(goBackCallback):
(goForwardCallback):
(settingsCallback):
(webViewURIChanged):
(browserWindowHistoryItemActivated):
(browserWindowUpdateNavigationActions):
(webViewCreate):
(webViewEnterFullScreen):
(webViewLeaveFullScreen):
(webViewDecidePolicy):
(browserWindowCanZoomIn):
(browserWindowCanZoomOut):
(browserWindowZoomIn):
(browserWindowZoomOut):
(scrollEventCallback):
(faviconChanged):
(webViewIsLoadingChanged):
(defaultZoomCallback):
(searchCallback):
(newTabCallback):
(toggleWebInspector):
(reloadPage):
(reloadPageIgnoringCache):
(stopPageLoad):
(loadHomePage):
(editingCommandCallback):
(insertImageCommandCallback):
(insertLinkCommandCallback):
(browserWindowSetupEditorToolbar):
(browserWindowSwitchTab):
(browserWindowTabAddedOrRemoved):
(browser_window_init):
(browserWindowConstructed):
(browserWindowSaveSession):
(browserWindowDeleteEvent):
(browser_window_new):
(browser_window_append_view):
(browser_window_load_uri):
(browser_window_load_session):
(browser_window_set_background_color):
(resetStatusText): Deleted.
(activateUriEntryCallback): Deleted.
(webViewTitleChanged): Deleted.
(resetEntryProgress): Deleted.
(browserWindowCreateBackForwardMenu): Deleted.
(webViewReadyToShow): Deleted.
(webViewLoadFailed): Deleted.
(webViewMouseTargetChanged): Deleted.
(browserWindowUpdateZoomActions): Deleted.
(webViewZoomLevelChanged): Deleted.
(updateUriEntryIcon): Deleted.
(zoomInCallback): Deleted.
(zoomOutCallback): Deleted.
(toggleFullScreen): Deleted.
(browserWindowEditingCommandToggleButtonSetActive): Deleted.
(browserWindowFinalize): Deleted.
(browser_window_class_init): Deleted.
- MiniBrowser/gtk/BrowserWindow.h:
- MiniBrowser/gtk/CMakeLists.txt:
- MiniBrowser/gtk/main.c:
(createBrowserTab):
(aboutURISchemeRequestCallback):
(main):
(parseBackgroundColor): Deleted.
Jul 14, 2016:
- 11:03 PM Changeset in webkit [203270] by
-
- 1 edit24089 adds in trunk/Source/JavaScriptCore
Add Test262 test files and yaml
Rubber Stamped by Benjamin Poulain.
This patch adds all the test262 test files and the yaml that drives
run-jsc-stress-tests.
- tests/test262.yaml: Added. Yaml file to drive the test262 test suite with our driver.
- tests/test262/LICENSE: Added. License for the test262 test suite.
- tests/test262/harness/: Added. Harness directory for the test262 tests.
- tests/test262/test/: Added. Directory with all the actual test files.
- 10:49 PM Changeset in webkit [203269] by
-
- 7 edits in trunk
Change CSSParser::sourceSize returning Optional<CSSParser::SourceSize>
https://bugs.webkit.org/show_bug.cgi?id=159666
Reviewed by Michael Catanzaro.
Source/WebCore:
Tests:
fast/dom/HTMLImageElement/sizes/image-sizes-invalids.html
- css/CSSGrammar.y.in: Avoid adding SourceSize to source_size_list when the value is a Nullopt.
- css/CSSParser.cpp:
(WebCore::CSSParser::sourceSize): Return a Nullopt when an invalid value is encountered.
- css/CSSParser.h:
LayoutTests:
Added a test to make sure that an invalid source-size value is skipped, but the next one is properly picked.
- fast/dom/HTMLImageElement/sizes/image-sizes-invalids-expected.txt:
- fast/dom/HTMLImageElement/sizes/image-sizes-invalids.html:
- 9:59 PM Changeset in webkit [203268] by
-
- 2 edits in trunk/Source/JavaScriptCore
Return the correct value from Heap::externalMemorySize
https://bugs.webkit.org/show_bug.cgi?id=159797
<rdar://problem/27362446>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-07-14
Reviewed by Timothy Hatcher.
- heap/Heap.h:
(JSC::Heap::externalMemorySize):
We should have been returning m_externalMemorySize which is a subset
of m_extraMemorySize. In practice the difference can be small. A major
difference in "extra memory size" may be from deprecated memory size
and array buffer sizes.
- 8:56 PM Changeset in webkit [203267] by
-
- 8 edits6 adds in trunk
[RTL Scrollbars] Frame scrollbars don't move to the right when text direction changes to RTL
https://bugs.webkit.org/show_bug.cgi?id=158252
Patch by Antonio Gomes <tonikitoo@igalia.com> on 2016-07-14
Reviewed by Myles C. Maxfield.
Source/WebCore:
When the 'dir' attribute changes either on body or on the document
element level, the associated FrameView does not trigger an update on
the frame level vertical scrollbar.
Patch adds a 'hook' so that RenderBox::styleDidChange can call in
order to get the document level scrollbar placed properly in the next
layout.
Test: fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement.html
fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2.html
fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement.html
- page/FrameView.cpp:
(WebCore::FrameView::topContentDirectionDidChange):
- page/FrameView.h:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
LayoutTests:
- fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement.html: Added.
- fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-expected.txt: Added.
- fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2.html: Added.
- fast/scrolling/rtl-scrollbars-alternate-body-dir-attr-does-not-update-scrollbar-placement-2-expected.html: Added.
- fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement.html: Added.
- fast/scrolling/rtl-scrollbars-alternate-iframe-body-dir-attr-does-not-update-scrollbar-placement-expected.txt: Added.
- 8:11 PM Changeset in webkit [203266] by
-
- 10 edits52 adds in trunk
Support new emoji group candidates
https://bugs.webkit.org/show_bug.cgi?id=159755
<rdar://problem/27325521>
Reviewed by Dean Jackson.
Source/WebCore:
There are a few code points which should be able to be joined (with ZWJ) to
either U+2640 or U+2642 to change the gender of the emoji. These patterns
should also work with an additional 0xFE0F variation selector. This patch
adds these new patterns to our existing emoji group candidate infrastructure.
Tests: fast/text/emoji-gender-2-3.html
fast/text/emoji-gender-2-4.html
fast/text/emoji-gender-2-5.html
fast/text/emoji-gender-2-6.html
fast/text/emoji-gender-2-7.html
fast/text/emoji-gender-2-8.html
fast/text/emoji-gender-2-9.html
fast/text/emoji-gender-2.html
fast/text/emoji-gender-3.html
fast/text/emoji-gender-4.html
fast/text/emoji-gender-5.html
fast/text/emoji-gender-6.html
fast/text/emoji-gender-7.html
fast/text/emoji-gender-8.html
fast/text/emoji-gender-9.html
fast/text/emoji-gender-fe0f-3.html
fast/text/emoji-gender-fe0f-4.html
fast/text/emoji-gender-fe0f-5.html
fast/text/emoji-gender-fe0f-6.html
fast/text/emoji-gender-fe0f-7.html
fast/text/emoji-gender-fe0f-8.html
fast/text/emoji-gender-fe0f-9.html
fast/text/emoji-gender.html
fast/text/emoji-num-glyphs.html
fast/text/emoji-single-parent-family-2.html
fast/text/emoji-single-parent-family.html
- platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Removed incorrect ASSERT()s.
- platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::characterRangeCodePath):
- platform/text/CharacterProperties.h:
(WebCore::isEmojiGroupCandidate):
Source/WTF:
This patch doesn't update the rules for our cursor movement iterator, because
I don't know the language used for implementing these rules. These rules will
be updated in the near future. When they do,
editing/deleting/delete-emoji-expected.txt will need to be updated.
- wtf/text/TextBreakIterator.cpp:
(WTF::cursorMovementIterator):
LayoutTests:
Because this patch doesn't update the rules for our cursor movement
iterator, the new expected result for editing/deleting/delete-emoji.html
expects incorrect results. In the patch where we update these rules,
the expected result should also be updated.
Because these new emoji require system support, TestExpectations has
been updated to mark the tests as failing until the system support has
been added.
- TestExpectations:
- editing/deleting/delete-emoji-expected.txt:
- editing/deleting/delete-emoji.html:
- fast/text/emoji-gender-2-3-expected.html: Added.
- fast/text/emoji-gender-2-3.html: Added.
- fast/text/emoji-gender-2-4-expected.html: Added.
- fast/text/emoji-gender-2-4.html: Added.
- fast/text/emoji-gender-2-5-expected.html: Added.
- fast/text/emoji-gender-2-5.html: Added.
- fast/text/emoji-gender-2-6-expected.html: Added.
- fast/text/emoji-gender-2-6.html: Added.
- fast/text/emoji-gender-2-7-expected.html: Added.
- fast/text/emoji-gender-2-7.html: Added.
- fast/text/emoji-gender-2-8-expected.html: Added.
- fast/text/emoji-gender-2-8.html: Added.
- fast/text/emoji-gender-2-9-expected.html: Added.
- fast/text/emoji-gender-2-9.html: Added.
- fast/text/emoji-gender-2-expected-mismatch.html: Added.
- fast/text/emoji-gender-2.html: Added.
- fast/text/emoji-gender-3-expected.html: Added.
- fast/text/emoji-gender-3.html: Added.
- fast/text/emoji-gender-4-expected.html: Added.
- fast/text/emoji-gender-4.html: Added.
- fast/text/emoji-gender-5-expected.html: Added.
- fast/text/emoji-gender-5.html: Added.
- fast/text/emoji-gender-6-expected.html: Added.
- fast/text/emoji-gender-6.html: Added.
- fast/text/emoji-gender-7-expected.html: Added.
- fast/text/emoji-gender-7.html: Added.
- fast/text/emoji-gender-8-expected.html: Added.
- fast/text/emoji-gender-8.html: Added.
- fast/text/emoji-gender-9-expected.html: Added.
- fast/text/emoji-gender-9.html: Added.
- fast/text/emoji-gender-expected-mismatch.html: Added.
- fast/text/emoji-gender-fe0f-3-expected.html: Added.
- fast/text/emoji-gender-fe0f-3.html: Added.
- fast/text/emoji-gender-fe0f-4-expected.html: Added.
- fast/text/emoji-gender-fe0f-4.html: Added.
- fast/text/emoji-gender-fe0f-5-expected.html: Added.
- fast/text/emoji-gender-fe0f-5.html: Added.
- fast/text/emoji-gender-fe0f-6-expected.html: Added.
- fast/text/emoji-gender-fe0f-6.html: Added.
- fast/text/emoji-gender-fe0f-7-expected.html: Added.
- fast/text/emoji-gender-fe0f-7.html: Added.
- fast/text/emoji-gender-fe0f-8-expected.html: Added.
- fast/text/emoji-gender-fe0f-8.html: Added.
- fast/text/emoji-gender-fe0f-9-expected.html: Added.
- fast/text/emoji-gender-fe0f-9.html: Added.
- fast/text/emoji-gender.html: Added.
- fast/text/emoji-num-glyphs-expected.txt: Added.
- fast/text/emoji-num-glyphs.html: Added.
- fast/text/emoji-single-parent-family-2-expected-mismatch.html: Added.
- fast/text/emoji-single-parent-family-2.html: Added.
- fast/text/emoji-single-parent-family-expected-mismatch.html: Added.
- fast/text/emoji-single-parent-family.html: Added.
- 7:31 PM Changeset in webkit [203265] by
-
- 2 edits in trunk/Source/WebCore
CrashTracer: com.apple.WebKit.WebContent at WebCore: WebCore::MediaQueryEvaluator::evaluate const
https://bugs.webkit.org/show_bug.cgi?id=159799
<rdar://problem/27346959>
Reviewed by Myles Maxfield.
Speculative fix for this crash, which seems to happen when asking for the Node's
renderer(). From the incoming crash logs, it is triggered by mutations on
a <picture> or <img> element, which would require choosing a new source,
and causing some media queries to evaluate.
The only place in MediaQueryEvaluator that has anything to do with
renderers is when gathering up some style information to pass to the
actual evaluation function. I put a guard against a missing documentElement
in there.
- css/MediaQueryEvaluator.cpp:
(WebCore::MediaQueryEvaluator::evaluate): Make sure documentElement is not
null.
- 7:17 PM Changeset in webkit [203264] by
-
- 55 edits in trunk/Source/WebCore
Update HTML*Element class override methods in final classes
https://bugs.webkit.org/show_bug.cgi?id=159456
Patch by Rawinder Singh <rawinder.singh-webkit@cisra.canon.com.au> on 2016-07-14
Reviewed by Youenn Fablet.
Update HTML*Element classes so that overriden methods in final classes are marked final.
Also marked HTMLDivElement overriden methods as final since they are not overridden by derived classes.
- html/HTMLAppletElement.h:
- html/HTMLAreaElement.h:
- html/HTMLAttachmentElement.h:
- html/HTMLAudioElement.h:
- html/HTMLBRElement.h:
- html/HTMLBaseElement.h:
- html/HTMLBodyElement.h:
- html/HTMLButtonElement.h:
- html/HTMLCanvasElement.h:
- html/HTMLDataElement.h:
- html/HTMLDetailsElement.h:
- html/HTMLDivElement.h:
- html/HTMLEmbedElement.h:
- html/HTMLFieldSetElement.h:
- html/HTMLFontElement.h:
- html/HTMLFormElement.h:
- html/HTMLFrameSetElement.h:
- html/HTMLHRElement.h:
- html/HTMLHtmlElement.h:
- html/HTMLKeygenElement.h:
- html/HTMLLIElement.h:
- html/HTMLLabelElement.h:
- html/HTMLLegendElement.h:
- html/HTMLLinkElement.h:
- html/HTMLMapElement.h:
- html/HTMLMarqueeElement.h:
- html/HTMLMetaElement.h:
- html/HTMLMeterElement.h:
- html/HTMLModElement.h:
- html/HTMLOListElement.h:
- html/HTMLObjectElement.h:
- html/HTMLOptGroupElement.h:
- html/HTMLOptionElement.h:
- html/HTMLOutputElement.h:
- html/HTMLParagraphElement.h:
- html/HTMLParamElement.h:
- html/HTMLPreElement.h:
- html/HTMLProgressElement.h:
- html/HTMLQuoteElement.h:
- html/HTMLScriptElement.h:
- html/HTMLSourceElement.h:
- html/HTMLStyleElement.h:
- html/HTMLSummaryElement.h:
- html/HTMLTableCaptionElement.h:
- html/HTMLTableColElement.h:
- html/HTMLTableElement.h:
- html/HTMLTableSectionElement.h:
- html/HTMLTemplateElement.h:
- html/HTMLTextAreaElement.h:
- html/HTMLTitleElement.h:
- html/HTMLUListElement.h:
- html/HTMLUnknownElement.h:
- html/HTMLVideoElement.h:
- html/HTMLWBRElement.h:
- 7:11 PM Changeset in webkit [203263] by
-
- 8 edits in trunk
It should be a syntax error to have a 'use strict' directive inside a function that has a non-simple parameter list
https://bugs.webkit.org/show_bug.cgi?id=159790
<rdar://problem/27171636>
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Is is a syntax error for a function's parameter list to be non-simple
and for the function to also contain a 'use strict' directive.
See section 14.2.1 of the spec:
https://tc39.github.io/ecma262/#sec-arrow-function-definitions-static-semantics-early-errors
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseSourceElements):
(JSC::Parser<LexerType>::parseFormalParameters):
- parser/Parser.h:
(JSC::Scope::Scope):
(JSC::Scope::strictMode):
(JSC::Scope::isValidStrictMode):
(JSC::Scope::shadowsArguments):
(JSC::Scope::setHasNonSimpleParameterList):
(JSC::Scope::hasNonSimpleParameterList):
(JSC::Scope::copyCapturedVariablesToVector):
LayoutTests:
- js/parser-syntax-check-expected.txt:
- js/script-tests/parser-syntax-check.js:
- 7:07 PM Changeset in webkit [203262] by
-
- 2 edits in trunk/Source/WebCore
Modernize GlyphMetricsMap
https://bugs.webkit.org/show_bug.cgi?id=159788
Reviewed by Darin Adler.
Modernize GlyphMetricsMap a bit.
- platform/graphics/GlyphMetricsMap.h:
- Drop WTF_MAKE_NONCOPYABLE as the class is already non-copyable due to having to having a std::unique_ptr data member.
- Drop GlyphMetricsMap default constructor and let the compiler generate it instead. This required using inline initialization for m_filledPrimaryPage.
(WebCore::GlyphMetricsMap::GlyphMetricsPage::GlyphMetricsPage):
- Make m_metrics data member private as it does not need to be public.
- Make setMetricsForIndex(unsigned index, const T& metrics) setter private as it does not need to be public.
- Make GlyphMetricsPage(const T& initialValue) constructor explicit as it takes only 1 parameter.
(WebCore::GlyphMetricsMap<T>::locatePageSlowCase):
- Use HashMap::ensure() to make the code a bit nicer.
- 6:46 PM Changeset in webkit [203261] by
-
- 5 edits5 adds in trunk
[iOS WK2] When scrolling apple.com/music on iPad Pro in landscape, left-hand tiles appear first
https://bugs.webkit.org/show_bug.cgi?id=159798
rdar://problem/27362717
Reviewed by Tim Horton.
Source/WebCore:
In out-of-visible tiled layers, we always allocated the top-left tile, wasting
memory and causing ugliness when scrolling that layer into view. This happened
because getTileIndexRangeForRect() had no way to express the fact that no tiles
should be created.
Fix getTileIndexRangeForRect() to return a bool, and fix callers to respect the
return value.
Test: compositing/tiling/offscreen-tiled-layer.html
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::dumpAdditionalProperties):
- platform/graphics/ca/TileGrid.cpp:
(WebCore::TileGrid::setNeedsDisplayInRect):
(WebCore::TileGrid::tilesWouldChangeForCoverageRect):
(WebCore::TileGrid::getTileIndexRangeForRect):
(WebCore::TileGrid::revalidateTiles):
(WebCore::TileGrid::ensureTilesForRect):
(WebCore::TileGrid::extent):
- platform/graphics/ca/TileGrid.h:
LayoutTests:
Test with an offscreen tiled layer.
- compositing/tiling/offscreen-tiled-layer-expected.txt: Added.
- compositing/tiling/offscreen-tiled-layer.html: Added.
- platform/ios-simulator-wk1/compositing/tiling/offscreen-tiled-layer-expected.txt: Added.
- platform/ios-simulator-wk2/compositing/tiling/offscreen-tiled-layer-expected.txt: Added.
- platform/mac-wk1/compositing/tiling/offscreen-tiled-layer-expected.txt: Added.
- 5:52 PM Changeset in webkit [203260] by
-
- 2 edits in trunk/LayoutTests
Skipping editing/spelling/copy-paste-crash.html on ios-simulator.
https://bugs.webkit.org/show_bug.cgi?id=142969
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 5:39 PM Changeset in webkit [203259] by
-
- 1 edit4 adds in trunk/LayoutTests
Merge Blink test case
https://bugs.webkit.org/show_bug.cgi?id=117422
Patch is from a set of Blink changes (patches by <leviw@chromium.org>):
<https://chromium.googlesource.com/chromium/blink/+/507e1576555bd2ce6688206f28339c25761893b1>
<https://chromium.googlesource.com/chromium/blink/+/4c95872f52340cf0cf9a2a7078bb63a94f38d302>
- fast/list/list-style-position-inside-expected.txt: Added.
- fast/list/list-style-position-inside.html: Added.
- fast/sub-pixel/float-list-inside-expected.txt: Added.
- fast/sub-pixel/float-list-inside.html: Added.
- 5:10 PM Changeset in webkit [203258] by
-
- 3 edits2 adds in trunk
Remove credentials in URL when accessed through location.href
https://bugs.webkit.org/show_bug.cgi?id=139562
<rdar://problem/27331164>
Reviewed by Brent Fulgham.
Source/WebCore:
Test: http/tests/security/location-href-clears-username-password.html
The reason for this change is to not allow scripts on the page to
exfiltrate username and password from the URL.
- page/Location.cpp:
(WebCore::Location::href):
Now checks if there is a username or password in the URL. If so,
it copies the URL and removes the username and password.
LayoutTests:
The reason for this change is to not allow scripts on the page to
exfiltrate username and password from the URL.
- http/tests/security/location-href-clears-username-password-expected.txt: Added.
- http/tests/security/location-href-clears-username-password.html: Added.
Test case adapted from https://src.chromium.org/viewvc/blink?revision=189367&view=revision.
- 5:00 PM Changeset in webkit [203257] by
-
- 4 edits in trunk
Allow RefPtrs of const RefCounted types
https://bugs.webkit.org/show_bug.cgi?id=158269
Patch by Alex Christensen <achristensen@webkit.org> on 2016-07-14
Reviewed by Anders Carlsson.
Source/WTF:
- wtf/RefCounted.h:
(WTF::RefCountedBase::ref):
(WTF::RefCountedBase::~RefCountedBase):
(WTF::RefCountedBase::derefBase):
(WTF::RefCounted::deref):
Creating references to a const object does not really modify the object,
so everything in RefCounted is now mutable, and ref and deref are const.
Tools:
- TestWebKitAPI/Tests/WTF/RefPtr.cpp:
(TestWebKitAPI::TEST):
(TestWebKitAPI::ConstRefCounted::create):
(TestWebKitAPI::returnConstRefCountedRef):
(TestWebKitAPI::returnRefCountedRef):
- 4:46 PM Changeset in webkit [203256] by
-
- 4 edits in trunk/Websites/webkit.org
Improved WebKit Nightly start page design.
https://bugs.webkit.org/show_bug.cgi?id=159780
Reviewed by Timothy Hatcher.
Added better 404 handling, improved presentation of the
start page and new Apache rewrites for the P1 bug list.
- .htaccess:
- wp-content/themes/webkit/functions.php:
- wp-content/themes/webkit/nightly-start.php:
- 4:45 PM Changeset in webkit [203255] by
-
- 1 edit2 adds in trunk/LayoutTests
Merge Blink test case
https://bugs.webkit.org/show_bug.cgi?id=116507
Patch is from a Blink change (patch by <ojan@chromium.org>):
<https://chromium.googlesource.com/chromium/blink/+/6598fc75a7260643ecfc42856ef24bcf96380443>
- compositing/iframes/crash-mouse-event-expected.txt: Added.
- compositing/iframes/crash-mouse-event.html: Added.
- 4:38 PM Changeset in webkit [203254] by
-
- 7 edits1 copy in trunk/Source/WebInspectorUI
Web Inspector: Rename CCTNode to CallingContextTreeNode
https://bugs.webkit.org/show_bug.cgi?id=159782
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-07-14
Reviewed by Timothy Hatcher.
- UserInterface/Models/CallingContextTree.js:
- UserInterface/Models/CallingContextTreeNode.js:
Extra to its own file and rename.
- UserInterface/Main.html:
- UserInterface/Test.html:
- UserInterface/TestStub.html:
Include the new file.
- UserInterface/Views/ProfileDataGridNode.js:
(WebInspector.ProfileDataGridNode):
- UserInterface/Views/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridTree.prototype._updateCurrentFocusDetails):
Rename shorthand "cctnode".
- 4:37 PM Changeset in webkit [203253] by
-
- 9 edits in trunk/Source/WebInspectorUI
Web Inspector: SidebarPanel classes should use View.layout instead of "refresh"
https://bugs.webkit.org/show_bug.cgi?id=159745
<rdar://problem/27335252>
Reviewed by Timothy Hatcher.
- UserInterface/Views/ApplicationCacheDetailsSidebarPanel.js:
(WebInspector.ApplicationCacheDetailsSidebarPanel.prototype.set applicationCacheFrame):
Use needsLayout.
- UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
(WebInspector.CSSStyleDetailsSidebarPanel.prototype.layout):
Move refresh logic to layout.
(WebInspector.CSSStyleDetailsSidebarPanel.prototype.initialLayout):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype._styleSheetAddedOrRemoved):
Defer layout to coalesce updates.
(WebInspector.CSSStyleDetailsSidebarPanel):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype.refresh): Deleted.
- UserInterface/Views/DOMDetailsSidebarPanel.js:
(WebInspector.DOMDetailsSidebarPanel.prototype.set domNode):
Use needsLayout.
- UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
Move refresh logic to layout.
- UserInterface/Views/DetailsSidebarPanel.js:
(WebInspector.DetailsSidebarPanel.prototype.shown): Deleted.
Base class already forces a layout when shown.
(WebInspector.DetailsSidebarPanel.prototype.needsRefresh): Deleted.
No longer needed.
(WebInspector.DetailsSidebarPanel.prototype.refresh): Deleted.
Renamed layout.
(WebInspector.DetailsSidebarPanel): Deleted.
- UserInterface/Views/LayerTreeDetailsSidebarPanel.js:
(WebInspector.LayerTreeDetailsSidebarPanel.prototype.supportsDOMNode):
(WebInspector.LayerTreeDetailsSidebarPanel.prototype._layerTreeDidChange):
Use needsLayout.
(WebInspector.LayerTreeDetailsSidebarPanel.prototype.shown):
Base class already forces a layout when shown.
- UserInterface/Views/ResourceDetailsSidebarPanel.js:
(WebInspector.ResourceDetailsSidebarPanel.prototype.set resource):
Use needsLayout.
- UserInterface/Views/ScopeChainDetailsSidebarPanel.js:
(WebInspector.ScopeChainDetailsSidebarPanel):
(WebInspector.ScopeChainDetailsSidebarPanel.prototype.set callFrame):
(WebInspector.ScopeChainDetailsSidebarPanel.prototype._addWatchExpression):
(WebInspector.ScopeChainDetailsSidebarPanel.prototype._removeWatchExpression):
(WebInspector.ScopeChainDetailsSidebarPanel.prototype._clearAllWatchExpressions):
(WebInspector.ScopeChainDetailsSidebarPanel.prototype._refreshAllWatchExpressionsButtonClicked):
(WebInspector.ScopeChainDetailsSidebarPanel.prototype._didEvaluateExpression):
(WebInspector.ScopeChainDetailsSidebarPanel.prototype._mainResourceDidChange):
Use needsLayout.
- 4:33 PM Changeset in webkit [203252] by
-
- 4 edits in trunk/Source/WebCore
[css-grid] Handle min-content/max-content with orthogonal flows
https://bugs.webkit.org/show_bug.cgi?id=159294
Reviewed by Darin Adler.
Currently there is no support for orthogonal flows in many aspects of the
Grid Layout logic.
The Grid sizing algorithm should be adapted to this scenario, hence this
patch focus on the min-content and max-content functions, used to resolve
content based track sizes.
There are still issues related to alignment and sizes using percentages,
but they will be addressed in different patches.
Tests: fast/css-grid-layout/grid-item-positioning-with-orthogonal-flows.html
fast/css-grid-layout/grid-item-sizing-with-orthogonal-flows.html
fast/css-grid-layout/grid-item-spanning-and-orthogonal-flows.html
fast/css-grid-layout/grid-track-sizing-with-orthogonal-flows.html
fast/css-grid-layout/grid-track-sizing-with-percentages-and-orthogonal-flows.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthInRegion):
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::GridSizingData::advanceNextState):
(WebCore::RenderGrid::GridSizingData::isValidTransitionForDirection):
(WebCore::RenderGrid::computeTrackSizesForDirection):
(WebCore::RenderGrid::repeatTracksSizingIfNeeded): Added.
(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
(WebCore::RenderGrid::computeIntrinsicLogicalHeight):
(WebCore::hasOverrideContainingBlockContentSizeForChild):
(WebCore::overrideContainingBlockContentSizeForChild):
(WebCore::setOverrideContainingBlockContentSizeForChild):
(WebCore::shouldClearOverrideContainingBlockContentSizeForChild):
(WebCore::RenderGrid::gridTrackSize):
(WebCore::RenderGrid::isOrthogonalChild): Added.
(WebCore::RenderGrid::logicalHeightForChild):
(WebCore::RenderGrid::flowAwareDirectionForChild): Added.
(WebCore::RenderGrid::minSizeForChild):
(WebCore::RenderGrid::updateOverrideContainingBlockContentSizeForChild):
(WebCore::RenderGrid::minContentForChild):
(WebCore::RenderGrid::maxContentForChild):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::layoutPositionedObject):
(WebCore::RenderGrid::offsetAndBreadthForPositionedChild):
(WebCore::RenderGrid::assumedRowsSizeForOrthogonalChild): Added.
(WebCore::RenderGrid::gridAreaBreadthForChild):
(WebCore::RenderGrid::columnAxisPositionForChild):
(WebCore::RenderGrid::rowAxisPositionForChild):
(WebCore::RenderGrid::findChildLogicalPosition):
- rendering/RenderGrid.h:
(WebCore::RenderGrid::SizingOperation): This enum has been moved to the header file.
(WebCore::RenderGrid::m_hasAnyOrthogonalChild): New class attribute to know if there are any orthogonal grid items.
(WebCore::RenderGrid::updateOverrideContainingBlockContentSizeForChild):
(WebCore::RenderGrid::logicalHeightForChild):
(WebCore::RenderGrid::gridAreaBreadthForChild):
(WebCore::RenderGrid::assumedRowsSizeForOrthogonalChild):
- 4:21 PM Changeset in webkit [203251] by
-
- 14 edits in trunk/Source/WebKit2
Unreviewed, rolling out r203248.
This change causes LayoutTests to crash and exit early
Reverted changeset:
"Use more Refs with WorkQueues"
https://bugs.webkit.org/show_bug.cgi?id=159792
http://trac.webkit.org/changeset/203248
- 4:17 PM Changeset in webkit [203250] by
-
- 25 edits in trunk/Source
Use emptyString() instead of "" when possible
https://bugs.webkit.org/show_bug.cgi?id=159789
Reviewed by Alex Christensen.
Use emptyString() instead of "" when possible to reduce String allocations.
Source/WebCore:
- Modules/webdatabase/Database.cpp:
(WebCore::Database::performOpenAndVerify):
- css/CSSSelector.h:
- css/StyleProperties.cpp:
(WebCore::MutableStyleProperties::removeProperty):
(WebCore::MutableStyleProperties::removeCustomProperty):
- editing/TextCheckingHelper.cpp:
(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):
(WebCore::TextCheckingHelper::findFirstBadGrammar):
- editing/TypingCommand.h:
(WebCore::TypingCommand::create):
- fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::cleanup):
- inspector/InspectorStyleSheet.cpp:
(WebCore::fillMediaListChain):
- page/UserContentURLPattern.cpp:
(WebCore::UserContentURLPattern::parse):
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::load):
- platform/gtk/DataObjectGtk.h:
(WebCore::DataObjectGtk::clearURIList):
- platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
- platform/network/curl/ResourceHandleManager.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::layerTreeAsText):
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::updateContent):
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::noneDashboardRegions):
- rendering/svg/SVGTextMetrics.cpp:
(WebCore::SVGTextMetrics::SVGTextMetrics):
- xml/XPathParser.cpp:
(WebCore::XPath::Parser::lexString):
Source/WebKit/cf:
- WebCoreSupport/WebInspectorClientCF.cpp:
(populateSetting):
Source/WebKit/win:
- Plugins/PluginView.cpp:
(WebCore::parseRFC822HeaderFields):
Source/WebKit2:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::pasteboardChangedOwner):
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::parseRFC822HeaderFields):
(WebKit::NPN_Status):
- 4:15 PM Changeset in webkit [203249] by
-
- 4 edits2 adds in trunk
editing/spelling/spellcheck-async.html sometimes crashes with GuardMalloc
https://bugs.webkit.org/show_bug.cgi?id=142969
<rdar://problem/27331095>
Reviewed by Alex Christensen.
Fix based on a Blink change (patch by <rouslan@chromium.org>):
<https://chromium.googlesource.com/chromium/blink/+/c713736b122c2224804b2db72f1f711cb47ee260%5E%21/#F1>
Source/WebCore:
Test: editing/spelling/copy-paste-crash.html
editing/spelling/spellcheck-async.html
- editing/SpellChecker.cpp:
(WebCore::SpellCheckRequest::didSucceed):
(WebCore::SpellCheckRequest::didCancel):
LayoutTests:
- editing/spelling/copy-paste-crash-expected.txt: Added.
- editing/spelling/copy-paste-crash.html: Added.
- platform/platform/mac-wk2/TestExpectations: Skip test on mac-wk2 since all Spelling tests are
currently broken (see <https://webkit.org/b/105616>).
- 4:04 PM Changeset in webkit [203248] by
-
- 14 edits in trunk/Source/WebKit2
Use more Refs with WorkQueues
https://bugs.webkit.org/show_bug.cgi?id=159792
Reviewed by Brady Eidson.
- NetworkProcess/CustomProtocols/CustomProtocolManager.h:
- Platform/IPC/Connection.cpp:
(IPC::Connection::setShouldExitOnSyncMessageSendFailure):
(IPC::Connection::addWorkQueueMessageReceiver):
- Platform/IPC/Connection.h:
- Shared/mac/SecItemShim.cpp:
(WebKit::SecItemShim::initializeConnection):
- UIProcess/Storage/LocalStorageDatabaseTracker.cpp:
(WebKit::LocalStorageDatabaseTracker::create):
(WebKit::LocalStorageDatabaseTracker::LocalStorageDatabaseTracker):
- UIProcess/Storage/LocalStorageDatabaseTracker.h:
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::StorageArea::openDatabaseAndImportItemsIfNeeded):
(WebKit::StorageManager::StorageManager):
- UIProcess/Storage/StorageManager.h:
- UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::processWillOpenConnection):
(WebKit::WebResourceLoadStatisticsStore::processDidCloseConnection):
- UIProcess/mac/SecItemShimProxy.cpp:
(WebKit::SecItemShimProxy::initializeConnection):
(WebKit::SecItemShimProxy::secItemRequest):
- WebProcess/Plugins/PluginProcessConnectionManager.cpp:
(WebKit::PluginProcessConnectionManager::initializeConnection):
(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::initializeConnection):
(WebKit::EventDispatcher::wheelEvent):
- WebProcess/WebPage/ViewUpdateDispatcher.cpp:
(WebKit::ViewUpdateDispatcher::initializeConnection):
(WebKit::ViewUpdateDispatcher::visibleContentRectUpdate):
- 3:14 PM Changeset in webkit [203247] by
-
- 2 edits in trunk/LayoutTests
Remove duplicate TestExpectations entry.
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 3:05 PM Changeset in webkit [203246] by
-
- 2 edits in trunk/Source/WebCore
ImageBuffer's succes flag should be set to false at the very beginning of the c'tor.
https://bugs.webkit.org/show_bug.cgi?id=159784
Reviewed by Simon Fraser.
No change in functionality.
- platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::ImageBuffer):
- 2:52 PM Changeset in webkit [203245] by
-
- 6 edits in trunk/Source/WebKit2
Web Automation: FrameNotFound errors happen a lot for the main frame
https://bugs.webkit.org/show_bug.cgi?id=159777
rdar://problem/27224628
Send both pageID and frameID, and have the WebProcess side resolve the
mainFrame from 0 based on the known pageID. This avoids a race waiting
for the DidCreateMainFrame message.
Reviewed by Brian Burg.
- UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::webFrameIDForHandle):
(WebKit::WebAutomationSession::switchToBrowsingContext):
(WebKit::WebAutomationSession::evaluateJavaScriptFunction):
(WebKit::WebAutomationSession::resolveChildFrameHandle):
(WebKit::WebAutomationSession::resolveParentFrameHandle):
(WebKit::WebAutomationSession::computeElementLayout):
(WebKit::WebAutomationSession::getAllCookies):
(WebKit::WebAutomationSession::deleteSingleCookie):
(WebKit::WebAutomationSession::webFrameProxyForHandle): Deleted.
(WebKit::WebAutomationSession::webFrameIDForHandle): Added.
- UIProcess/Automation/WebAutomationSession.h:
- WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::WebAutomationSessionProxy::evaluateJavaScriptFunction):
(WebKit::WebAutomationSessionProxy::resolveChildFrameWithOrdinal):
(WebKit::WebAutomationSessionProxy::resolveChildFrameWithNodeHandle):
(WebKit::WebAutomationSessionProxy::resolveChildFrameWithName):
(WebKit::WebAutomationSessionProxy::resolveParentFrame):
(WebKit::WebAutomationSessionProxy::focusFrame):
(WebKit::WebAutomationSessionProxy::computeElementLayout):
(WebKit::WebAutomationSessionProxy::takeScreenshot):
(WebKit::WebAutomationSessionProxy::getCookiesForFrame):
(WebKit::WebAutomationSessionProxy::deleteCookie):
- WebProcess/Automation/WebAutomationSessionProxy.h:
- WebProcess/Automation/WebAutomationSessionProxy.messages.in:
- 2:43 PM Changeset in webkit [203244] by
-
- 26 edits2 adds4 deletes in trunk/Source
Use SocketProvider to create SocketStreamHandles
https://bugs.webkit.org/show_bug.cgi?id=159774
Source/WebCore:
Reviewed by Brady Eidson.
No new tests. No change in behaviour.
In r202930 I introduced the SocketProvider, but I used it to make a WebSocketChannel
instead of a SocketStreamHandle, which is the class I want to make into an interface
and proxy the web traffic over to the NetworkProcess.
- CMakeLists.txt:
- Modules/websockets/ThreadableWebSocketChannel.cpp: Added.
(WebCore::ThreadableWebSocketChannel::create):
I removed this in 202930, so this is restoring it from that patch, hence the old copyright.
- Modules/websockets/ThreadableWebSocketChannel.h:
(WebCore::ThreadableWebSocketChannel::ThreadableWebSocketChannel):
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::WebSocketChannel):
(WebCore::WebSocketChannel::connect):
- Modules/websockets/WebSocketChannel.h:
(WebCore::WebSocketChannel::create):
- Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
(WebCore::WorkerThreadableWebSocketChannel::WorkerThreadableWebSocketChannel):
(WebCore::WorkerThreadableWebSocketChannel::resume):
(WebCore::WorkerThreadableWebSocketChannel::Peer::Peer):
(WebCore::WorkerThreadableWebSocketChannel::Peer::didReceiveMessageError):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::Bridge):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::~Bridge):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::mainThreadInitialize):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::initialize):
- Modules/websockets/WorkerThreadableWebSocketChannel.h:
(WebCore::WorkerThreadableWebSocketChannel::create):
(WebCore::WorkerThreadableWebSocketChannel::Bridge::create):
- WebCore.xcodeproj/project.pbxproj:
- inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::overlayPage):
- loader/EmptyClients.cpp:
(WebCore::EmptyEditorClient::registerRedoStep):
(WebCore::EmptySocketProvider::createWebSocketChannel): Deleted.
- loader/EmptyClients.h:
- page/SocketProvider.cpp: Added.
(WebCore::SocketProvider::createSocketStreamHandle):
- page/SocketProvider.h:
(WebCore::SocketProvider::~SocketProvider): Deleted.
- platform/network/cf/SocketStreamHandle.h:
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):
Source/WebKit:
Reviewed by Alex Christensen.
- PlatformMac.cmake:
- PlatformWin.cmake:
- WebKit.xcodeproj/project.pbxproj:
Source/WebKit/mac:
Reviewed by Brady Eidson.
- Misc/WebSocketProvider.h: Removed.
- Misc/WebSocketProvider.mm: Removed.
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
Source/WebKit/win:
Reviewed by Brady Eidson.
- WebSocketProvider.cpp: Removed.
- WebSocketProvider.h: Removed.
- WebView.cpp: Replaced WebSocketProvider with SocketProvider as we did in WebCore.
Source/WebKit2:
Reviewed by Brady Eidson.
- WebProcess/Network/WebSocketProvider.cpp:
(WebKit::WebSocketProvider::createSocketStreamHandle):
(WebKit::WebSocketProvider::createWebSocketChannel): Deleted.
- WebProcess/Network/WebSocketProvider.h:
- 2:42 PM Changeset in webkit [203243] by
-
- 4 edits in trunk/Source/WebInspectorUI
Web Inspector: Maintain selected function when switching between different profile representations
https://bugs.webkit.org/show_bug.cgi?id=159778
<rdar://problem/27355913>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-07-14
Reviewed by Timothy Hatcher.
- UserInterface/Models/CallingContextTree.js:
(WebInspector.CCTNode):
(WebInspector.CCTNode.prototype.get hash):
(WebInspector.CCTNode.prototype.findOrMakeChild):
(WebInspector.CCTNode.prototype.equals):
Expose the hash so two nodes can be compared cheaply.
- UserInterface/Views/ProfileView.js:
(WebInspector.ProfileView.prototype._repopulateDataGridFromTree):
(WebInspector.ProfileView.prototype._restoreSharedState):
(WebInspector.ProfileView.prototype._dataGridNodeSelected):
Share data between multiple ProfileViews. Currently just remembering
and restoring the selected function.
- UserInterface/Views/ScriptProfileTimelineView.js:
(WebInspector.ScriptProfileTimelineView):
(WebInspector.ScriptProfileTimelineView.prototype._showProfileViewForOrientation):
Include the shared data when constructing new ProfileViews.
- 2:39 PM Changeset in webkit [203242] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][iOS] Potential null dereference under ViewGestureController::beginSwipeGesture()
https://bugs.webkit.org/show_bug.cgi?id=159776
<rdar://problem/22467100>
Reviewed by Tim Horton.
Potential null dereference under ViewGestureController::beginSwipeGesture() of:
m_webPageProxy.backForwardList().currentItem()
The client side is expected to call ViewGestureController::canSwipeInDirection() but
this only guarantees that the m_alternateBackForwardListSourceView's currentItem is
non-null when m_alternateBackForwardListSourceView is non-null. It does not guarantee
that m_webPageProxy's currentItem is non-null.
- UIProcess/ios/ViewGestureControllerIOS.mm:
(WebKit::ViewGestureController::beginSwipeGesture):
- 2:15 PM Changeset in webkit [203241] by
-
- 4 edits in trunk/Source/WebCore
"User delete" tests are flakey timeouts (and/or DatabaseProcess crashes).
https://bugs.webkit.org/show_bug.cgi?id=158741
Reviewed by Alex Christensen.
No new tests (Covered by existing tests in some configurations)
- Check if a database hard delete is complete in more places.
- Asynchronously clear out the hard close protector instead of synchronously.
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::~UniqueIDBDatabase):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformUnconditionalDeleteBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::didFinishHandlingVersionChange):
(WebCore::IDBServer::UniqueIDBDatabase::connectionClosedFromClient):
(WebCore::IDBServer::UniqueIDBDatabase::transactionCompleted):
(WebCore::IDBServer::UniqueIDBDatabase::executeNextDatabaseTaskReply):
(WebCore::IDBServer::UniqueIDBDatabase::maybeFinishHardClose):
(WebCore::IDBServer::UniqueIDBDatabase::isDoneWithHardClose):
(WebCore::IDBServer::UniqueIDBDatabase::doneWithHardClose): Deleted.
- Modules/indexeddb/server/UniqueIDBDatabase.h:
(WebCore::IDBServer::UniqueIDBDatabase::hardClosedForUserDelete):
- Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:
(WebCore::IDBServer::UniqueIDBDatabaseConnection::didAbortTransaction):
- 2:01 PM Changeset in webkit [203240] by
-
- 4 edits in trunk/Source/WebCore
CSSStyleSheet members should clear their owner node when destroyed
https://bugs.webkit.org/show_bug.cgi?id=117470
Reviewed by Chris Dumez.
Make sure that CSSStyleSheet members are detached from their owner node when
the owning object is destroyed.
I audited other CSSStyleSheet uses, and found one other place where the owner node was not
being cleared during destruction. The Inspector also uses CSSStyleSheet, but seems to
handle the node ownership properly.
Fix based on a Blink change (patch by <haraken@chromium.org>):
<https://chromium.googlesource.com/chromium/blink/+/c4949bfdeb2a613701afa1410bdae70531b8f6bf>
Also includes a follow-up fix (patch by <haraken@chromium.org>):
<https://chromium.googlesource.com/chromium/blink/+/9c3932dc80b33429db3a5873cb266b726c8a19bf>
No test case. Was found by the Chromium team through review of their crash traces under minor DOM GC.
- contentextensions/ContentExtensionStyleSheet.cpp:
(WebCore::ContentExtensions::ContentExtensionStyleSheet::~ContentExtensionStyleSheet):
- contentextensions/ContentExtensionStyleSheet.h:
- dom/InlineStyleSheetOwner.cpp:
(WebCore::InlineStyleSheetOwner::~InlineStyleSheetOwner):
(WebCore::authorStyleSheetsForElement):
- 1:54 PM Changeset in webkit [203239] by
-
- 2 edits2 adds in trunk/Source/JavaScriptCore
ASSERTION FAILED: : this != replacement()
https://bugs.webkit.org/show_bug.cgi?id=159779
Reviewed by Michael Saboff.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::jettison): If we jettison during GC, and our owner
is dead, we choose not to replace ourselves. (See
https://bugs.webkit.org/show_bug.cgi?id=159588.) So, it's possible to
invalidate and still be our owner's CodeBlock. Relax our ASSERT to allow
for this.
- 1:14 PM Changeset in webkit [203238] by
-
- 12 edits in trunk/Source
Fix the !ENABLE(WEB_SOCKETS) build after r202930
https://bugs.webkit.org/show_bug.cgi?id=159768
Reviewed by Alex Christensen.
Source/WebCore:
- loader/EmptyClients.cpp:
- loader/EmptyClients.h:
- page/SocketProvider.h:
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::WorkerGlobalScope):
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::WorkerThread):
Source/WebKit/mac:
- Misc/WebSocketProvider.h:
Source/WebKit/win:
- WebSocketProvider.h:
Source/WebKit2:
- WebProcess/Network/WebSocketProvider.h:
- 12:46 PM Changeset in webkit [203237] by
-
- 1 edit2 adds in trunk/LayoutTests
Add test to confirm we do not crash in media destruction
https://bugs.webkit.org/show_bug.cgi?id=122816
Test based on a Blink change (patch by <igor.o@sisa.samsung.com>):
<https://chromium.googlesource.com/chromium/blink/+/7a2b2dcefbc013003487d5055eeda7a57daafa93%5E%21/#F0>
We do not seem to have the bug that prompted the Chromium source change. Adding
test case to ensure we do not introduce this problem in the future.
- editing/undo/audio-in-undo-stack-crash-expected.txt: Added.
- editing/undo/audio-in-undo-stack-crash.html: Added.
- 12:45 PM Changeset in webkit [203236] by
-
- 3 edits in trunk/Source/WTF
Avoid an extra heap allocation when dispatching Functions to WorkQueue
https://bugs.webkit.org/show_bug.cgi?id=158367
Reviewed by Anders Carlsson.
Avoid an extra heap allocation when dispatching Functions to WorkQueue
by adding leakCallable() / adoptCallable() functions to Function.
- wtf/Function.h:
- wtf/cocoa/WorkQueueCocoa.cpp:
(WTF::WorkQueue::dispatch):
(WTF::WorkQueue::dispatchAfter):
- 12:32 PM Changeset in webkit [203235] by
-
- 4 edits1 add in trunk
DOMIterators should be assigned a correct prototype
https://bugs.webkit.org/show_bug.cgi?id=159115
Patch by Youenn Fablet <youenn@apple.com> on 2016-07-14
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/fetch/api/headers/headers-basic.html: Updating test (changes to be upstreamed to w3c wpt repo)
Source/WebCore:
Default iterator object internal prototype property is the Iterator prototype as defined in
http://heycam.github.io/webidl/#dfn-iterator-prototype-object.
Linking DOMIterator prototype to IteratorPrototype.
This allows adding @@iterator property to the result of entries, keys and values methods.
This in turns allow doing for-of loops on them.
Covered by updated test.
- ForwardingHeaders/runtime/IteratorPrototype.h: Added.
- bindings/js/JSDOMIterator.h: Setting correct prototype and marking next prototype property as enumerable.
- 12:30 PM Changeset in webkit [203234] by
-
- 5 edits in trunk
Remove support for value iterators from JSDOMIterator
https://bugs.webkit.org/show_bug.cgi?id=159293
Patch by Youenn Fablet <youenn@apple.com> on 2016-07-14
Reviewed by Chris Dumez.
Source/WebCore:
Value iterators are now handled without using DOMIterator.
Since FontFaceSet is using DOMIterator as an intermediate step towards supporting set-like,
entries and forEach implementation should be made compliant with set-like.
This means that item value should be passed instead of an index in entries iterator and forEach callback.
Covered by updated test.
- bindings/js/JSDOMIterator.h:
(WebCore::JSDOMIterator<JSWrapper>::asJS): Pass set item as entries value field.
(WebCore::appendForEachArguments): Pass set item as second parameter.
(WebCore::iteratorForEach): Remove index handling.
LayoutTests:
- fast/text/font-face-set-javascript-expected.txt:
- fast/text/font-face-set-javascript.html:
- 12:29 PM Changeset in webkit [203233] by
-
- 2 edits in trunk/Source/WebCore
Fix the !ENABLE(MATHML) build after r201739
https://bugs.webkit.org/show_bug.cgi?id=159767
Reviewed by Alex Christensen.
- dom/Document.cpp:
(WebCore::Document::validateCustomElementName):
- 12:28 PM Changeset in webkit [203232] by
-
- 2 edits in trunk/Source/WebCore
Fix the !ENABLE(CSS_IMAGE_SET) build
https://bugs.webkit.org/show_bug.cgi?id=159766
Reviewed by Alex Christensen.
- css/CSSParser.cpp:
- 12:09 PM Changeset in webkit [203231] by
-
- 2 edits in trunk/LayoutTests
Land test expectations for rdar://problem/27353750.
- platform/mac/TestExpectations:
- 11:33 AM Changeset in webkit [203230] by
-
- 2 edits in trunk/Source/WebKit2
Possible crash under NavigationState::NavigationClient::processDidCrash()
https://bugs.webkit.org/show_bug.cgi?id=159773
<rdar://problem/19814215>
Reviewed by Anders Carlsson.
Add a m_navigationState.m_navigationDelegateMethods.webViewWebProcessDidCrash before
trying to call it to avoid crashing if the client does not implement it.
At the beginning of the method, we abort early only if both webViewWebContentProcessDidTerminate
and webViewWebProcessDidCrash are implemented. However, if webViewWebContentProcessDidTerminate
implemented but not webViewWebProcessDidCrash we can end up crashing as we fail to check later
on before trying to call it.
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::NavigationClient::processDidCrash):
- 11:18 AM Changeset in webkit [203229] by
-
- 5 edits1 add in trunk
JSONObject Walker::walk must save array length before processing array elements.
https://bugs.webkit.org/show_bug.cgi?id=153485
Reviewed by Darin Adler and Michael Saboff.
Source/JavaScriptCore:
According to https://tc39.github.io/ecma262/#sec-internalizejsonproperty,
JSON.parse() should cache the length of an array and use the cached length when
iterating array elements (see section 24.3.1.1 2.b.iii).
- runtime/JSONObject.cpp:
(JSC::Walker::walk):
- tests/stress/JSON-parse-should-cache-array-lengths.js: Added.
(toString):
(shouldBe):
(test):
(test2):
LayoutTests:
- js/JSON-parse-reviver-expected.txt:
- js/script-tests/JSON-parse-reviver.js:
- Fixed a bug in arrayReviver() where it was setting the array length to 3, but was immediately returning a value from the reviver for index 3. This effectively forces array.length to 4. As a result, case 4 always failed silently, and case 5 never executed.
- Added tracking of cases visited by the revivers so that they can be verified.
- 10:59 AM Changeset in webkit [203228] by
-
- 26 edits in trunk/Source/WebCore
Cleanup of MathML headers
https://bugs.webkit.org/show_bug.cgi?id=159336
Reviewed by Alex Christensen.
We do some cleanup in MathML headers:
- Use #pragma once
- Use final for class that are not extended.
- Use final instead of override for virtual members that are not overridden by derived classes.
- Try and reduce the visibility of function members to private or protected as appropriate.
- Remove useless #include
- Remove useless class or friendship declaration
- Remove unused functions
No new tests, behavior is unchanged.
- mathml/MathMLElement.h:
- mathml/MathMLInlineContainerElement.h:
- mathml/MathMLMathElement.h:
- mathml/MathMLMencloseElement.h:
- mathml/MathMLOperatorDictionary.h:
- mathml/MathMLPaddedElement.h:
- mathml/MathMLSelectElement.h:
- mathml/MathMLSpaceElement.h:
- mathml/MathMLTextElement.h:
- rendering/mathml/MathOperator.h:
- rendering/mathml/RenderMathMLBlock.h:
- rendering/mathml/RenderMathMLFenced.h:
- rendering/mathml/RenderMathMLFraction.h:
- rendering/mathml/RenderMathMLMath.h:
- rendering/mathml/RenderMathMLMenclose.h:
- rendering/mathml/RenderMathMLOperator.h:
- rendering/mathml/RenderMathMLRoot.h:
- rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::RenderMathMLRow): Deleted. We no longer create anonymous row.
- rendering/mathml/RenderMathMLRow.h:
- rendering/mathml/RenderMathMLScripts.h:
- rendering/mathml/RenderMathMLSpace.h:
- rendering/mathml/RenderMathMLToken.h:
- rendering/mathml/RenderMathMLUnderOver.h:
- 10:50 AM Changeset in webkit [203227] by
-
- 2 edits in trunk/Source/WebKit2
Fix the DatabaseProcess build with disabled IDB
https://bugs.webkit.org/show_bug.cgi?id=159769
Reviewed by Alex Christensen.
- WebProcess/Databases/WebToDatabaseProcessConnection.cpp:
(WebKit::WebToDatabaseProcessConnection::didClose):
- 10:38 AM Changeset in webkit [203226] by
-
- 2 edits in trunk/Source/JavaScriptCore
[mips] Handle properly unaligned halfword load
https://bugs.webkit.org/show_bug.cgi?id=153226
Patch by Julien Brianceau <jbriance@cisco.com> on 2016-07-14
Reviewed by Michael Catanzaro.
Waiting for the kernel to silently fix-up unaligned accesses is
not efficient, so let's provide an implementation of load16Unaligned
in mips macro assembler.
Performance improvement seen with SunSpider's regexp-dna test.
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::load16Unaligned):
(JSC::MacroAssemblerMIPS::load32WithUnalignedHalfWords):
- 10:26 AM Changeset in webkit [203225] by
-
- 6 edits in trunk/Source/WebCore
Pass SessionID to WebSocketHandle constructor
https://bugs.webkit.org/show_bug.cgi?id=159772
Reviewed by Brady Eidson.
No new tests. No change in behavior.
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::connect):
- platform/network/cf/SocketStreamHandle.h:
(WebCore::SocketStreamHandle::create):
- platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle):
- platform/network/curl/SocketStreamHandle.h:
(WebCore::SocketStreamHandle::create):
- platform/network/soup/SocketStreamHandle.h:
- 8:48 AM Changeset in webkit [203224] by
-
- 2 edits in trunk/Source/WebCore
[GLib] Use a GSource instead of a thread to poll memory pressure eventFD in linux implementation
https://bugs.webkit.org/show_bug.cgi?id=159346
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2016-07-14
Reviewed by Antonio Gomes.
This is a follow up of r203216 to fix wrong use of Optional values.
- platform/linux/MemoryPressureHandlerLinux.cpp:
- 5:33 AM Changeset in webkit [203223] by
-
- 2 edits in trunk/Source/WebKit2
[ThreadedCompositor] Build fails in debug mode after r202040
https://bugs.webkit.org/show_bug.cgi?id=159757
Patch by Hyunjun Ko <Hyunjun Ko> on 2016-07-14
Reviewed by Michael Catanzaro.
Debug mode build failed due to call getter method, which is
removed, in ASSERT().
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
(WebKit::ThreadedCompositor::glContext): Deleted.
(WebKit::ThreadedCompositor::didChangeVisibleRect): Deleted.
(WebKit::ThreadedCompositor::renderLayerTree): Deleted.
- 4:16 AM Changeset in webkit [203222] by
-
- 13 edits15 adds in trunk
DOM value iterable interfaces should use Array prototype methods
https://bugs.webkit.org/show_bug.cgi?id=159296
Patch by Youenn Fablet <youenn@apple.com> on 2016-07-14
Reviewed by Chris Dumez and Mark Lam.
Source/JavaScriptCore:
- JavaScriptCore.xcodeproj/project.pbxproj: Marking some header files as private so that they can be included in
WebCore.
- runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::finishCreation): copying iterable methods (entries, forEach, keys and values) to private slots.
Source/WebCore:
Test: fast/dom/NodeList/nodelist-iterable.html
Also covered by updated layout test and binding tests.
For value iterators, copy the iterator methods from Array prototype: as per https://heycam.github.io/webidl/#es-iterable,
[re: entries] If the interface has a value iterator, then the Function object is the initial value of the "entries" data property of %ArrayPrototype% ([ECMA-262], section 6.1.7.4).
[re: keys] If the interface has a value iterator, then the Function object is the initial value of the "keys" data property of %ArrayPrototype% ([ECMA-262], section 6.1.7.4).
[re: forEach] If the interface defines an indexed property getter, then the Function object is the initial value of the "forEach" data property of %ArrayPrototype% ([ECMA-262], section 6.1.7.4).
[re: Symbol.iterator] If the interface defines an indexed property getter, then the Function object is %ArrayProto_values% ([ECMA-262], section 6.1.7.4).
[re: values] If the interface has a value iterator, then the Function object is the value of the @@iterator property.
This change applies only to NodeList at the moment.
Copy of Array prototype iterator methods is disabled if the interface has no indexed getter.
- CMakeLists.txt:
- ForwardingHeaders/builtins/BuiltinNames.h: Added.
- ForwardingHeaders/builtins/JSCBuiltins.h: Added.
- ForwardingHeaders/runtime/CommonIdentifiers.h: Added.
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMIterator.cpp: Added.
(WebCore::addValueIterableMethods): Copy iterator methods from array prototype.
- bindings/js/JSDOMIterator.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GeneratePropertiesHashTable):
(GenerateImplementation):
(IsValueIterableInterface): Introduced to only copy iterator methods if the interface has an indexed getter.
(IsKeyValueIterableInterface): Introduced to detect whether generating iterator methods.
(GenerateImplementationIterableFunctions):
- bindings/scripts/test/GObject/WebKitDOMTestIterable.cpp: Added.
- bindings/scripts/test/GObject/WebKitDOMTestIterable.h: Added.
- bindings/scripts/test/GObject/WebKitDOMTestIterablePrivate.h: Added.
- bindings/scripts/test/JS/JSTestIterable.cpp: Added.
- bindings/scripts/test/JS/JSTestIterable.h: Added.
- bindings/scripts/test/JS/JSTestObj.cpp: Updated as TestObj defines both iterable<> and indexed getter.
- bindings/scripts/test/ObjC/DOMTestIterable.h: Added.
- bindings/scripts/test/ObjC/DOMTestIterable.mm: Added.
- bindings/scripts/test/ObjC/DOMTestIterableInternal.h: Added.
- bindings/scripts/test/TestIterable.idl: Added to handle the case of value iterator without indexed getter defined.
Array prototype methods should not be copied.
- bindings/scripts/test/TestObj.idl: Changing to be a value iterator (with indexed getter already defined).
Array prototype methods should be copied.
LayoutTests:
- fast/dom/nodeListIterator-expected.txt:
- fast/dom/nodeListIterator.html:
- fast/dom/NodeList/nodelist-iterable-expected.txt: Added.
- fast/dom/NodeList/nodelist-iterable.html: Added.
- 3:14 AM Changeset in webkit [203221] by
-
- 11 edits3 adds in trunk
[Fetch API] Request and Response url getter should use URL serialization
https://bugs.webkit.org/show_bug.cgi?id=159705
Patch by Youenn Fablet <youenn@apple.com> on 2016-07-14
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/fetch/api/basic/response-url-expected.txt: Added.
- web-platform-tests/fetch/api/basic/response-url-worker-expected.txt: Added.
- web-platform-tests/fetch/api/basic/response-url-worker.html: Added.
- web-platform-tests/fetch/api/basic/response-url.html: Added.
- web-platform-tests/fetch/api/basic/response-url.js: Added.
(checkResponseURL):
- web-platform-tests/fetch/api/request/request-init-003.sub-expected.txt:
- web-platform-tests/fetch/api/request/request-init-003.sub.html:
Source/WebCore:
Tests: fetch/fetch-url-serialization.html
imported/w3c/web-platform-tests/fetch/api/basic/response-url-worker.html
imported/w3c/web-platform-tests/fetch/api/basic/response-url.html
Implementing https://url.spec.whatwg.org/#concept-url-serializer and applying it to Request and Response getter.
Adding a temporary routine to compute url cannot-be-a-base-url flag. The parsing routine should store that
information in the URL itself.
Added tests to cover serialization routine. Failing tests are mostly due to limitations of the URL parser.
Tests do not check for URLs with username and password as Request constructor throws with such URLs.
- Modules/fetch/FetchRequest.cpp:
(WebCore::FetchRequest::url): Adding request url serialization, fragment included.
- Modules/fetch/FetchRequest.h:
- Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::url): Adding response url serialization, fragment excluded.
- Modules/fetch/FetchResponse.h:
- platform/URL.cpp:
(WebCore::cannotBeABaseURL): Temporary helper function to have a coarse evaluation of url cannot-be-a-base-url flag.
(WebCore::URL::serialize): Implementation of https://url.spec.whatwg.org/#concept-url-serializer.
- platform/URL.h:
(WebCore::URL::hasUser): Helper getter.
(WebCore::URL::hasPassword): Ditto.
(WebCore::URL::hasQuery): Ditto.
(WebCore::URL::hasFragment): Ditto.
LayoutTests:
- fetch/fetch-url-serialization-expected.txt: Added.
- fetch/fetch-url-serialization.html: Added.
- fetch/fetch-urls.json: Added.
- 1:36 AM Changeset in webkit [203220] by
-
- 3 edits in trunk/Source/WebCore
[css-grid] Const-ify track sizing algorithm
https://bugs.webkit.org/show_bug.cgi?id=159716
Reviewed by Carlos Garcia Campos.
All the methods used to run the track sizing algorithm should not
modify the state of LayoutGrid. We can safely const-ify all of them
and remove the ugly const_cast in computeIntrinsicLogicalWidths().
No new tests needed as there is no change in behavior.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::logicalHeightForChild):
(WebCore::RenderGrid::minSizeForChild):
(WebCore::RenderGrid::updateOverrideContainingBlockContentLogicalWidthForChild):
(WebCore::RenderGrid::minContentForChild):
(WebCore::RenderGrid::maxContentForChild):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForNonSpanningItems):
(WebCore::RenderGrid::currentItemSizeForTrackSizeComputationPhase):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
(WebCore::RenderGrid::distributeSpaceToTracks):
- rendering/RenderGrid.h:
- 12:54 AM Changeset in webkit [203219] by
-
- 4 edits in trunk
REGRESSION (r202918): LayoutTest media/video-main-content-allow-then-deny.html is flaky, failing almost every time on El Capitan
https://bugs.webkit.org/show_bug.cgi?id=159533
Reviewed by Eric Carlson.
Source/WebCore:
Move the contents of mainContentCheckTimerFired() into updateIsMainContent() so that the
results of changing the m_isMainContent ivar are acted upon no matter why m_isMainContent
changes.
- html/MediaElementSession.cpp:
(WebCore::MediaElementSession::mainContentCheckTimerFired):
(WebCore::MediaElementSession::updateIsMainContent):
LayoutTests:
- platform/mac/TestExpectations:
- 12:29 AM Changeset in webkit [203218] by
-
- 2 edits in trunk/LayoutTests
Rebaseline test after r203204 and r203207.
- js/typed-array-mutated-during-set-expected.txt:
- 12:05 AM Changeset in webkit [203217] by
-
- 14 edits in trunk/Source
Modernize WebSocket handle
https://bugs.webkit.org/show_bug.cgi?id=159750
Reviewed by Brady Eidson.
Source/WebCore:
No new tests. No change in behavior.
This patch just removes ThreadableWebSocketChannel::InvalidMessage which is never used
and makes our use of SocketStreamHandleClient a reference instead of a pointer.
- Modules/websockets/ThreadableWebSocketChannel.h:
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::send):
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::connect):
- platform/network/SocketStreamHandleBase.cpp:
(WebCore::SocketStreamHandleBase::SocketStreamHandleBase):
(WebCore::SocketStreamHandleBase::send):
(WebCore::SocketStreamHandleBase::disconnect):
(WebCore::SocketStreamHandleBase::sendPendingData):
(WebCore::SocketStreamHandleBase::setClient): Deleted.
- platform/network/SocketStreamHandleBase.h:
(WebCore::SocketStreamHandleBase::~SocketStreamHandleBase):
(WebCore::SocketStreamHandleBase::bufferedAmount):
(WebCore::SocketStreamHandleBase::client):
- platform/network/cf/SocketStreamHandle.h:
(WebCore::SocketStreamHandle::create):
- platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore::SocketStreamHandle::addCONNECTCredentials):
(WebCore::SocketStreamHandle::copyCFStreamDescription):
(WebCore::SocketStreamHandle::readStreamCallback):
(WebCore::SocketStreamHandle::writeStreamCallback):
(WebCore::SocketStreamHandle::reportErrorToClient):
(WebCore::SocketStreamHandle::~SocketStreamHandle):
(WebCore::SocketStreamHandle::platformClose):
(WebCore::SocketStreamHandle::port):
- platform/network/curl/SocketStreamHandle.h:
(WebCore::SocketStreamHandle::create):
- platform/network/curl/SocketStreamHandleCurl.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore::SocketStreamHandle::platformClose):
(WebCore::SocketStreamHandle::readData):
(WebCore::SocketStreamHandle::didReceiveData):
(WebCore::SocketStreamHandle::didOpenSocket):
(WebCore::SocketStreamHandle::createCopy):
- platform/network/soup/SocketStreamHandle.h:
- platform/network/soup/SocketStreamHandleSoup.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore::SocketStreamHandle::~SocketStreamHandle):
(WebCore::SocketStreamHandle::connected):
(WebCore::SocketStreamHandle::connectedCallback):
(WebCore::SocketStreamHandle::readBytes):
(WebCore::SocketStreamHandle::didFail):
(WebCore::SocketStreamHandle::writeReady):
(WebCore::SocketStreamHandle::platformClose):
(WebCore::SocketStreamHandle::beginWaitingForSocketWritability):
Source/WebKit2:
- UIProcess/InspectorServer/soup/WebSocketServerSoup.cpp:
(WebKit::connectionCallback):
