Timeline

Jul 16, 2016:

5:19 PM Changeset in webkit [203329] by Chris Dumez

• 5 edits in trunk

Unreviewed, rolling out r203318.

Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
SunSpider)

Reverted changeset:

"[JSC] Change some parameters based on a random search"
​https://bugs.webkit.org/show_bug.cgi?id=158514
​http://trac.webkit.org/changeset/203318

2:33 PM Changeset in webkit [203328] by beidson@apple.com

• 36 edits in trunk

Update SVGException to use the description in toString().
​https://bugs.webkit.org/show_bug.cgi?id=159847

Reviewed by Darin Adler.

Source/WebCore:

No new tests (Covered by changes to existing tests).

• bindings/js/JSDOMBinding.cpp:

(WebCore::reportException): use consoleErrorMessage for now.

• dom/ExceptionBase.cpp:

(WebCore::ExceptionBase::consoleErrorMessage):

• dom/ExceptionBase.h:

• svg/SVGException.h:

LayoutTests:

• svg/animations/animate-marker-orient-from-angle-to-autostartreverse-expected.txt:
• svg/custom/SVGException-expected.txt:
• svg/custom/polyline-points-crash-expected.txt:
• svg/custom/script-tests/SVGException.js:
• svg/dom/SVGAnimatedEnumeration-SVGClipPathElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-SVGComponentTransferFunctionElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-SVGFEBlendElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-SVGFEColorMatrixElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-SVGFECompositeElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-SVGFEConvolveMatrixElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-SVGFEDisplacementMapElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-SVGFEMorphologyElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-SVGFETurbulenceElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-SVGFilterElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-SVGGradientElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-SVGMarkerElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-SVGMaskElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-SVGPatternElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-SVGTextContentElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-SVGTextPathElement-expected.txt:
• svg/dom/SVGAnimatedEnumeration-expected.txt:
• svg/dom/SVGLengthList-basics-expected.txt:
• svg/dom/SVGMatrix-interface-expected.txt:
• svg/dom/SVGNumberList-basics-expected.txt:
• svg/dom/SVGPointList-basics-expected.txt:
• svg/dom/SVGTransformList-basics-expected.txt:
• svg/dom/svglist-exception-on-out-bounds-error-expected.txt:
• svg/filters/feBlend-invalid-mode-expected.txt:
• svg/filters/feComponentTransfer-style-crash-expected.txt:
• svg/filters/feDisplacementMap-crash-test-expected.txt:

11:31 AM Changeset in webkit [203327] by ddkilzer@apple.com

• 2 edits in trunk/Websites/bugs.webkit.org

Use secure (https) links on enter_bug.cgi
<​https://webkit.org/b/159853>

Reviewed by Alexey Proskuryakov.

• template/en/default/global/choose-product.html.tmpl:

Use https instead of http for links to webkit.org.

10:21 AM Changeset in webkit [203326] by Chris Dumez

• 7 edits in trunk/Source/WebCore

Use fastHasAttribute() when possible
​https://bugs.webkit.org/show_bug.cgi?id=159838

Reviewed by Ryosuke Niwa.

Use fastHasAttribute() when possible, for performance.

• editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::makeStylingElementsDirectChildrenOfEditableRootToPreventStyleLoss):

• editing/markup.cpp:

(WebCore::createMarkupInternal):

• html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::draggable):

• html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::parseAttribute):

• mathml/MathMLSelectElement.cpp:

(WebCore::MathMLSelectElement::getSelectedSemanticsChild):

• rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::adjustMenuListButtonStyle):

9:33 AM Changeset in webkit [203325] by Chris Dumez

• 4 edits in trunk

Add move constructor / assignment operator to ListHashSet
​https://bugs.webkit.org/show_bug.cgi?id=159837

Reviewed by Darin Adler.

Source/WTF:

Add move constructor / assignment operator to ListHashSet.

• wtf/ListHashSet.h:

(WTF::ListHashSetConstIterator::operator++):
(WTF::U>::ListHashSet):
(WTF::=):
(WTF::U>::clear):
(WTF::U>::appendNode):
(WTF::U>::prependNode):
(WTF::U>::deleteAllNodes):
(WTF::ListHashSetNode::ListHashSetNode): Deleted.

Tools:

Add API tests.

• TestWebKitAPI/Tests/WTF/ListHashSet.cpp:

(TestWebKitAPI::TEST):

8:21 AM Changeset in webkit [203324] by rniwa@webkit.org

• 133 edits in trunk/Source

Rename fastGetAttribute to attributeWithoutSynchronization
​https://bugs.webkit.org/show_bug.cgi?id=159852

Reviewed by Darin Adler.

Source/WebCore:

Renamed fastGetAttribute to attributeWithoutSynchronization for clarity.

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::findAriaModalNodes):
(WebCore::nodeHasRole):
(WebCore::AXObjectCache::handleLiveRegionCreated):
(WebCore::AXObjectCache::handleMenuItemSelected):
(WebCore::AXObjectCache::handleAriaModalChange):
(WebCore::isNodeAriaVisible):

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::siblingWithAriaRole):
(WebCore::AccessibilityNodeObject::titleElementText):
(WebCore::AccessibilityNodeObject::alternativeTextForWebArea):
(WebCore::AccessibilityNodeObject::hierarchicalLevel):
(WebCore::AccessibilityNodeObject::stringValue):
(WebCore::accessibleNameForNode):

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::contentEditableAttributeIsEnabled):
(WebCore::AccessibilityObject::getAttribute):

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::stringValue):
(WebCore::AccessibilityRenderObject::exposesTitleUIElement):

• accessibility/AccessibilitySVGElement.cpp:

(WebCore::AccessibilitySVGElement::childElementWithMatchingLanguage):
(WebCore::AccessibilitySVGElement::accessibilityDescription):

• bindings/objc/DOM.mm:

(-[DOMHTMLLinkElement _mediaQueryMatches]):

• bindings/scripts/CodeGenerator.pm:

(GetterExpression):

• bindings/scripts/CodeGeneratorObjC.pm:

(GenerateImplementation):

• bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjReflectedStringAttr):

• dom/AuthorStyleSheets.cpp:

(WebCore::AuthorStyleSheets::collectActiveStyleSheets):

• dom/Document.cpp:

(WebCore::Document::buildAccessKeyMap):
(WebCore::Document::processBaseElement):

• dom/DocumentOrderedMap.cpp:

(WebCore::DocumentOrderedMap::getElementByLabelForAttribute):

• dom/Element.cpp:

(WebCore::Element::imageSourceURL):
(WebCore::Element::rendererIsNeeded):
(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
(WebCore::Element::pseudo):
(WebCore::Element::setPseudo):
(WebCore::Element::spellcheckAttributeState):
(WebCore::Element::canContainRangeEndPoint):
(WebCore::Element::completeURLsInAttributeValue):

• dom/Element.h:

(WebCore::Element::fastHasAttribute):
(WebCore::Element::attributeWithoutSynchronization):
(WebCore::Element::fastGetAttribute): Deleted.

• dom/InlineStyleSheetOwner.cpp:

(WebCore::InlineStyleSheetOwner::createSheet):

• dom/ScriptElement.cpp:

(WebCore::ScriptElement::requestScript):
(WebCore::ScriptElement::executeScript):

• dom/SlotAssignment.cpp:

(WebCore::slotNameFromSlotAttribute):
(WebCore::SlotAssignment::SlotAssignment):
(WebCore::recursivelyFireSlotChangeEvent):
(WebCore::SlotAssignment::didChangeSlot):
(WebCore::SlotAssignment::hostChildElementDidChange):
(WebCore::SlotAssignment::assignedNodesForSlot):
(WebCore::SlotAssignment::resolveAllSlotElements):

• dom/TreeScope.cpp:

(WebCore::TreeScope::labelElementForId):

• dom/VisitedLinkState.cpp:

(WebCore::linkAttribute):

• editing/ApplyStyleCommand.cpp:

(WebCore::isLegacyAppleStyleSpan):
(WebCore::hasNoAttributeOrOnlyStyleAttribute):

• editing/EditingStyle.cpp:

(WebCore::EditingStyle::elementIsStyledSpanOrHTMLEquivalent):

• editing/ReplaceSelectionCommand.cpp:

(WebCore::isInterchangeNewlineNode):
(WebCore::isInterchangeConvertedSpaceSpan):
(WebCore::positionAvoidingPrecedingNodes):
(WebCore::isMailPasteAsQuotationNode):
(WebCore::isHeaderElement):
(WebCore::isInlineNodeWithStyle):

• editing/TextIterator.cpp:

(WebCore::isRendererReplacedElement):

• editing/cocoa/DataDetection.mm:

(WebCore::DataDetection::isDataDetectorLink):
(WebCore::DataDetection::requiresExtendedContext):
(WebCore::DataDetection::dataDetectorIdentifier):
(WebCore::DataDetection::shouldCancelDefaultAction):
(WebCore::removeResultLinksFromAnchor):
(WebCore::searchForLinkRemovingExistingDDLinks):

• editing/gtk/EditorGtk.cpp:

(WebCore::elementURL):

• editing/htmlediting.cpp:

(WebCore::isTabSpanNode):
(WebCore::isTabSpanTextNode):
(WebCore::isMailBlockquote):
(WebCore::caretMinOffset):

• editing/markup.cpp:

(WebCore::createFragmentFromMarkup):

• html/Autofill.cpp:

(WebCore::AutofillData::createFromHTMLFormControlElement):

• html/BaseTextInputType.cpp:

(WebCore::BaseTextInputType::patternMismatch):

• html/DateInputType.cpp:

(WebCore::DateInputType::createStepRange):

• html/DateTimeInputType.cpp:

(WebCore::DateTimeInputType::createStepRange):

• html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::createStepRange):

• html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::findAssociatedForm):
(WebCore::FormAssociatedElement::resetFormAttributeTargetObserver):
(WebCore::FormAssociatedElement::formAttributeTargetChanged):

• html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::draggable):
(WebCore::HTMLAnchorElement::href):
(WebCore::HTMLAnchorElement::setHref):
(WebCore::HTMLAnchorElement::target):
(WebCore::HTMLAnchorElement::origin):
(WebCore::HTMLAnchorElement::sendPings):
(WebCore::HTMLAnchorElement::handleClick):

• html/HTMLAnchorElement.h:

(WebCore::HTMLAnchorElement::visitedLinkHash):

• html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::updateWidget):

• html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::target):

• html/HTMLAttachmentElement.cpp:

(WebCore::HTMLAttachmentElement::attachmentTitle):
(WebCore::HTMLAttachmentElement::attachmentType):

• html/HTMLBaseElement.cpp:

(WebCore::HTMLBaseElement::target):
(WebCore::HTMLBaseElement::href):

• html/HTMLBodyElement.cpp:

(WebCore::HTMLBodyElement::addSubresourceAttributeURLs):

• html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::value):
(WebCore::HTMLButtonElement::computeWillValidate):

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::reset):

• html/HTMLDocument.cpp:

(WebCore::HTMLDocument::bgColor):
(WebCore::HTMLDocument::setBgColor):
(WebCore::HTMLDocument::fgColor):
(WebCore::HTMLDocument::setFgColor):
(WebCore::HTMLDocument::alinkColor):
(WebCore::HTMLDocument::setAlinkColor):
(WebCore::HTMLDocument::linkColor):
(WebCore::HTMLDocument::setLinkColor):
(WebCore::HTMLDocument::vlinkColor):
(WebCore::HTMLDocument::setVlinkColor):

• html/HTMLElement.cpp:

(WebCore::contentEditableType):
(WebCore::HTMLElement::collectStyleForPresentationAttribute):
(WebCore::HTMLElement::dir):
(WebCore::HTMLElement::setDir):
(WebCore::HTMLElement::draggable):
(WebCore::HTMLElement::setDraggable):
(WebCore::HTMLElement::title):
(WebCore::HTMLElement::tabIndex):
(WebCore::HTMLElement::translateAttributeMode):
(WebCore::HTMLElement::hasDirectionAuto):
(WebCore::HTMLElement::directionality):

• html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::imageSourceURL):
(WebCore::HTMLEmbedElement::addSubresourceAttributeURLs):

• html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::formEnctype):
(WebCore::HTMLFormControlElement::formMethod):
(WebCore::HTMLFormControlElement::formAction):
(WebCore::HTMLFormControlElement::autocorrect):
(WebCore::HTMLFormControlElement::autocapitalizeType):

• html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::autocorrect):
(WebCore::HTMLFormElement::autocapitalizeType):
(WebCore::HTMLFormElement::autocapitalize):
(WebCore::HTMLFormElement::action):
(WebCore::HTMLFormElement::setAction):
(WebCore::HTMLFormElement::target):
(WebCore::HTMLFormElement::wasUserSubmitted):
(WebCore::HTMLFormElement::shouldAutocomplete):
(WebCore::HTMLFormElement::finishParsingChildren):
(WebCore::HTMLFormElement::autocomplete):

• html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::location):
(WebCore::HTMLFrameElementBase::setLocation):

• html/HTMLHtmlElement.cpp:

(WebCore::HTMLHtmlElement::insertedByParser):

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::imageSourceURL):
(WebCore::HTMLImageElement::setBestFitURLAndDPRFromImageCandidate):
(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):
(WebCore::HTMLImageElement::selectImageSource):
(WebCore::HTMLImageElement::altText):
(WebCore::HTMLImageElement::createElementRenderer):
(WebCore::HTMLImageElement::width):
(WebCore::HTMLImageElement::height):
(WebCore::HTMLImageElement::alt):
(WebCore::HTMLImageElement::draggable):
(WebCore::HTMLImageElement::setHeight):
(WebCore::HTMLImageElement::src):
(WebCore::HTMLImageElement::setSrc):
(WebCore::HTMLImageElement::addSubresourceAttributeURLs):
(WebCore::HTMLImageElement::didMoveToNewDocument):
(WebCore::HTMLImageElement::isServerMap):
(WebCore::HTMLImageElement::crossOrigin):

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::updateType):
(WebCore::HTMLInputElement::initializeInputType):
(WebCore::HTMLInputElement::altText):
(WebCore::HTMLInputElement::value):
(WebCore::HTMLInputElement::defaultValue):
(WebCore::HTMLInputElement::setDefaultValue):
(WebCore::HTMLInputElement::acceptMIMETypes):
(WebCore::HTMLInputElement::acceptFileExtensions):
(WebCore::HTMLInputElement::accept):
(WebCore::HTMLInputElement::alt):
(WebCore::HTMLInputElement::effectiveMaxLength):
(WebCore::HTMLInputElement::src):
(WebCore::HTMLInputElement::setAutoFilled):
(WebCore::HTMLInputElement::dataList):
(WebCore::HTMLInputElement::resetListAttributeTargetObserver):

• html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::isKeytypeRSA):
(WebCore::HTMLKeygenElement::appendFormData):

• html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::didAttachRenderers):
(WebCore::HTMLLIElement::parseValue):

• html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::control):

• html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::crossOrigin):
(WebCore::HTMLLinkElement::process):
(WebCore::HTMLLinkElement::href):
(WebCore::HTMLLinkElement::rel):
(WebCore::HTMLLinkElement::target):
(WebCore::HTMLLinkElement::type):
(WebCore::HTMLLinkElement::iconType):

• html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::scrollAmount):
(WebCore::HTMLMarqueeElement::setScrollAmount):
(WebCore::HTMLMarqueeElement::scrollDelay):
(WebCore::HTMLMarqueeElement::setScrollDelay):
(WebCore::HTMLMarqueeElement::loop):

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::insertedInto):
(WebCore::HTMLMediaElement::crossOrigin):
(WebCore::HTMLMediaElement::networkState):
(WebCore::HTMLMediaElement::mediaSessionTitle):
(WebCore::HTMLMediaElement::doesHaveAttribute):

• html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::process):
(WebCore::HTMLMetaElement::content):
(WebCore::HTMLMetaElement::httpEquiv):
(WebCore::HTMLMetaElement::name):

• html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::min):
(WebCore::HTMLMeterElement::setMin):
(WebCore::HTMLMeterElement::max):
(WebCore::HTMLMeterElement::setMax):
(WebCore::HTMLMeterElement::value):
(WebCore::HTMLMeterElement::low):
(WebCore::HTMLMeterElement::high):
(WebCore::HTMLMeterElement::optimum):

• html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::shouldAllowQuickTimeClassIdQuirk):
(WebCore::HTMLObjectElement::hasValidClassId):
(WebCore::HTMLObjectElement::imageSourceURL):
(WebCore::HTMLObjectElement::renderFallbackContent):
(WebCore::HTMLObjectElement::containsJavaApplet):
(WebCore::HTMLObjectElement::addSubresourceAttributeURLs):

• html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::groupLabelText):

• html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::value):
(WebCore::HTMLOptionElement::label):

• html/HTMLParamElement.cpp:

(WebCore::HTMLParamElement::value):
(WebCore::HTMLParamElement::isURLParameter):

• html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::value):
(WebCore::HTMLProgressElement::max):

• html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::crossOrigin):
(WebCore::HTMLScriptElement::src):
(WebCore::HTMLScriptElement::sourceAttributeValue):
(WebCore::HTMLScriptElement::charsetAttributeValue):
(WebCore::HTMLScriptElement::typeAttributeValue):
(WebCore::HTMLScriptElement::languageAttributeValue):
(WebCore::HTMLScriptElement::forAttributeValue):
(WebCore::HTMLScriptElement::eventAttributeValue):
(WebCore::HTMLScriptElement::asyncAttributeValue):

• html/HTMLSlotElement.cpp:

(WebCore::HTMLSlotElement::insertedInto):
(WebCore::HTMLSlotElement::removedFrom):

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::media):
(WebCore::HTMLSourceElement::setMedia):
(WebCore::HTMLSourceElement::type):
(WebCore::HTMLSourceElement::setType):

• html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::colSpanForBindings):
(WebCore::HTMLTableCellElement::rowSpan):
(WebCore::HTMLTableCellElement::rowSpanForBindings):
(WebCore::HTMLTableCellElement::cellIndex):
(WebCore::HTMLTableCellElement::abbr):
(WebCore::HTMLTableCellElement::axis):
(WebCore::HTMLTableCellElement::setColSpanForBindings):
(WebCore::HTMLTableCellElement::headers):
(WebCore::HTMLTableCellElement::setRowSpanForBindings):
(WebCore::HTMLTableCellElement::scope):
(WebCore::HTMLTableCellElement::addSubresourceAttributeURLs):
(WebCore::HTMLTableCellElement::cellAbove):

• html/HTMLTableColElement.cpp:

(WebCore::HTMLTableColElement::width):

• html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::rules):
(WebCore::HTMLTableElement::summary):
(WebCore::HTMLTableElement::addSubresourceAttributeURLs):

• html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::align):
(WebCore::HTMLTableSectionElement::setAlign):
(WebCore::HTMLTableSectionElement::ch):
(WebCore::HTMLTableSectionElement::setCh):
(WebCore::HTMLTableSectionElement::chOff):
(WebCore::HTMLTableSectionElement::setChOff):
(WebCore::HTMLTableSectionElement::vAlign):
(WebCore::HTMLTableSectionElement::setVAlign):

• html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::appendFormData):

• html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::strippedPlaceholder):
(WebCore::HTMLTextFormControlElement::isPlaceholderEmpty):
(WebCore::HTMLTextFormControlElement::directionForFormData):

• html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::srclang):
(WebCore::HTMLTrackElement::label):
(WebCore::HTMLTrackElement::isDefault):
(WebCore::HTMLTrackElement::ensureTrack):
(WebCore::HTMLTrackElement::mediaElementCrossOriginAttribute):

• html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::parseAttribute):
(WebCore::HTMLVideoElement::imageSourceURL):

• html/ImageInputType.cpp:

(WebCore::ImageInputType::height):
(WebCore::ImageInputType::width):

• html/InputType.cpp:

(WebCore::InputType::applyStep):

• html/MediaElementSession.cpp:

(WebCore::MediaElementSession::wirelessVideoPlaybackDisabled):

• html/MonthInputType.cpp:

(WebCore::MonthInputType::createStepRange):

• html/NumberInputType.cpp:

(WebCore::NumberInputType::createStepRange):
(WebCore::NumberInputType::sizeShouldIncludeDecoration):

• html/RangeInputType.cpp:

(WebCore::RangeInputType::createStepRange):
(WebCore::RangeInputType::handleKeydownEvent):

• html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::appendFormData):
(WebCore::TextFieldInputType::updateAutoFillButton):

• html/TimeInputType.cpp:

(WebCore::TimeInputType::createStepRange):

• html/ValidationMessage.cpp:

(WebCore::ValidationMessage::updateValidationMessage):

• html/WeekInputType.cpp:

(WebCore::WeekInputType::createStepRange):

• html/track/WebVTTElement.cpp:

(WebCore::WebVTTElement::createEquivalentHTMLElement):

• inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::buildObjectForFrame):

• loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::defaultSubstituteDataForURL):

• loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

• loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::isPluginContentAllowedByContentSecurityPolicy):

• mathml/MathMLElement.cpp:

(WebCore::MathMLElement::colSpan):
(WebCore::MathMLElement::rowSpan):
(WebCore::MathMLElement::childShouldCreateRenderer):
(WebCore::MathMLElement::defaultEventHandler):
(WebCore::MathMLElement::cachedMathMLLength):

• mathml/MathMLFractionElement.cpp:

(WebCore::MathMLFractionElement::lineThickness):
(WebCore::MathMLFractionElement::cachedFractionAlignment):

• mathml/MathMLSelectElement.cpp:

(WebCore::MathMLSelectElement::getSelectedActionChildAndIndex):
(WebCore::MathMLSelectElement::getSelectedActionChild):
(WebCore::MathMLSelectElement::getSelectedSemanticsChild):
(WebCore::MathMLSelectElement::defaultEventHandler):
(WebCore::MathMLSelectElement::willRespondToMouseClickEvents):
(WebCore::MathMLSelectElement::toggle):

• page/EventHandler.cpp:

(WebCore::findDropZone):

• page/Frame.cpp:

(WebCore::Frame::matchLabelsAgainstElement):

• page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):

• platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::writeImageToDataObject):

• rendering/HitTestResult.cpp:

(WebCore::HitTestResult::altDisplayString):

• rendering/RenderDetailsMarker.cpp:

(WebCore::RenderDetailsMarker::isOpen):

• rendering/RenderImage.cpp:

(WebCore::RenderImage::imageMap):
(WebCore::RenderImage::nodeAtPoint):

• rendering/RenderMenuList.cpp:

(RenderMenuList::itemAccessibilityText):
(RenderMenuList::itemToolTip):

• rendering/RenderSearchField.cpp:

(WebCore::RenderSearchField::autosaveName):

• rendering/RenderThemeIOS.mm:

(WebCore::getAttachmentProgress):
(WebCore::AttachmentInfo::AttachmentInfo):

• rendering/RenderThemeMac.mm:

(WebCore::AttachmentLayout::layOutSubtitle):
(WebCore::RenderThemeMac::paintAttachment):

• rendering/mathml/MathMLStyle.cpp:

(WebCore::MathMLStyle::resolveMathMLStyle):

• rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::updateFromElement):

• rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::setOperatorFlagFromAttribute):
(WebCore::RenderMathMLOperator::setOperatorFlagFromAttributeValue):
(WebCore::RenderMathMLOperator::setOperatorProperties):

• rendering/mathml/RenderMathMLScripts.cpp:

(WebCore::RenderMathMLScripts::getScriptMetricsAndLayoutIfNeeded):

• rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::hasAccent):

• style/StyleSharingResolver.cpp:

(WebCore::Style::SharingResolver::canShareStyleWithElement):
(WebCore::Style::SharingResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):

• svg/SVGAElement.cpp:

(WebCore::SVGAElement::title):
(WebCore::SVGAElement::defaultEventHandler):

• svg/SVGAltGlyphElement.cpp:

(WebCore::SVGAltGlyphElement::glyphRef):
(WebCore::SVGAltGlyphElement::setFormat):
(WebCore::SVGAltGlyphElement::format):
(WebCore::SVGAltGlyphElement::childShouldCreateRenderer):

• svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::toValue):
(WebCore::SVGAnimationElement::byValue):
(WebCore::SVGAnimationElement::fromValue):
(WebCore::SVGAnimationElement::isAdditive):
(WebCore::SVGAnimationElement::isAccumulated):

• svg/SVGElement.cpp:

(WebCore::SVGElement::xmlbase):
(WebCore::SVGElement::setXmlbase):

• svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::unitsPerEm):
(WebCore::SVGFontFaceElement::xHeight):
(WebCore::SVGFontFaceElement::capHeight):
(WebCore::SVGFontFaceElement::horizontalOriginX):
(WebCore::SVGFontFaceElement::horizontalOriginY):
(WebCore::SVGFontFaceElement::horizontalAdvanceX):
(WebCore::SVGFontFaceElement::verticalOriginX):
(WebCore::SVGFontFaceElement::verticalOriginY):
(WebCore::SVGFontFaceElement::verticalAdvanceY):
(WebCore::SVGFontFaceElement::ascent):
(WebCore::SVGFontFaceElement::descent):

• svg/SVGFontFaceNameElement.cpp:

(WebCore::SVGFontFaceNameElement::srcValue):

• svg/SVGFontFaceUriElement.cpp:

(WebCore::SVGFontFaceUriElement::srcValue):

• svg/SVGGlyphRefElement.cpp:

(WebCore::SVGGlyphRefElement::glyphRef):
(WebCore::SVGGlyphRefElement::setGlyphRef):

• svg/SVGHKernElement.cpp:

(WebCore::SVGHKernElement::buildHorizontalKerningPair):

• svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::contentScriptType):
(WebCore::SVGSVGElement::contentStyleType):

• svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::media):
(WebCore::SVGStyleElement::title):
(WebCore::SVGStyleElement::setTitle):

• svg/SVGToOTFFontConversion.cpp:

(WebCore::SVGToOTFFontConverter::appendOS2Table):
(WebCore::SVGToOTFFontConverter::appendCFFTable):
(WebCore::SVGToOTFFontConverter::appendArabicReplacementSubtable):
(WebCore::SVGToOTFFontConverter::appendVORGTable):
(WebCore::SVGToOTFFontConverter::transcodeGlyphPaths):
(WebCore::SVGToOTFFontConverter::processGlyphElement):
(WebCore::SVGToOTFFontConverter::compareCodepointsLexicographically):
(WebCore::SVGToOTFFontConverter::SVGToOTFFontConverter):

• svg/SVGVKernElement.cpp:

(WebCore::SVGVKernElement::buildVerticalKerningPair):

• svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::insertedInto):
(WebCore::SVGSMILElement::parseAttribute):
(WebCore::SVGSMILElement::svgAttributeChanged):
(WebCore::SVGSMILElement::restart):
(WebCore::SVGSMILElement::fill):
(WebCore::SVGSMILElement::dur):
(WebCore::SVGSMILElement::repeatDur):
(WebCore::SVGSMILElement::repeatCount):
(WebCore::SVGSMILElement::maxValue):
(WebCore::SVGSMILElement::minValue):

Source/WebKit/mac:

• WebView/WebHTMLRepresentation.mm:

(matchLabelsAgainstElement):

Source/WebKit/win:

• DOMHTMLClasses.cpp:

(DOMHTMLElement::idName):

Source/WebKit2:

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getPositionInformation):
(WebKit::WebPage::performActionOnElement):
(WebKit::WebPage::getAssistedNodeInformation):

4:33 AM Changeset in webkit [203323] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

ASSERTION FAILED: isMainThread() in ~UniqueIDBDatabase() since r201997
​https://bugs.webkit.org/show_bug.cgi?id=159809

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2016-07-16
Reviewed by Brady Eidson.

In r201997 the UniqueIDBDatabase was protected in executeNextDatabaseTask() because the last reference could be
removed while the task is performed. However UniqueIDBDatabase is expected to be deleted in the main thread, and
the destructor asserts when not called in the main thread, but executeNextDatabaseTask() is always called on a
secondary thread. So, if the protector contains the last reference, the object is deleted in the secondary thread.

• Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::executeNextDatabaseTask): Use callOnMainThread to ensure the object is
deleted in the main thread in case the protector contains the last reference.

Jul 15, 2016:

9:51 PM Changeset in webkit [203322] by Chris Dumez

• 49 edits in trunk/Source

Use emptyString() / nullAtom when possible
​https://bugs.webkit.org/show_bug.cgi?id=159850

Reviewed by Ryosuke Niwa.

Use emptyString() / nullAtom when possible, for performance.

Source/WebCore:

• Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::channelCountMode):
(WebCore::AudioNode::channelInterpretation):

• Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::tracker):

• Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::WebSocket):
(WebCore::WebSocket::didConnect):

• Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::subprotocol):
(WebCore::WebSocketChannel::extensions):

• accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::supportsPressAction):

• accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postTextStateChangePlatformNotification):

• css/CSSPropertySourceData.cpp:

(WebCore::CSSPropertySourceData::CSSPropertySourceData):

• css/PageRuleCollector.cpp:

(WebCore::PageRuleCollector::pageName):

• css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):

• dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::addDictationPhraseWithAlternativesMarker):

• dom/Element.cpp:

(WebCore::Element::setPrefix):

• editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::respondToMarkerAtEndOfWord):
(WebCore::AlternativeTextController::markerDescriptionForAppliedAlternativeText):

• editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::removeNodeAttribute):
(WebCore::CompositeEditCommand::moveParagraphs):

• editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::positionInsideTextNode):

• editing/TextCheckingHelper.cpp:

(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):

• editing/TypingCommand.cpp:

(WebCore::TypingCommand::deleteSelection):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
(WebCore::TypingCommand::insertLineBreak):
(WebCore::TypingCommand::insertParagraphSeparator):

• editing/cocoa/EditorCocoa.mm:

(WebCore::Editor::styleForSelectionStart):

• editing/mac/EditorMac.mm:

(WebCore::Editor::stringSelectionForPasteboard):
(WebCore::Editor::stringSelectionForPasteboardWithImageAltText):

• fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::FileReaderLoader):

• html/FileInputType.cpp:

(WebCore::FileInputType::appendFormData):

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::getCurrentMediaControlsStatus):

• html/HTMLOutputElement.cpp:

(WebCore::HTMLOutputElement::HTMLOutputElement):

• html/SearchInputType.cpp:

(WebCore::SearchInputType::handleKeydownEvent):

• html/TextFieldInputType.cpp:

(WebCore::autoFillButtonTypeToAccessibilityLabel):

• html/canvas/WebGLDebugShaders.cpp:

(WebCore::WebGLDebugShaders::getTranslatedShaderSource):

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::dispatchContextLostEvent):
(WebCore::WebGLRenderingContextBase::maybeRestoreContext):

• html/canvas/WebGLShader.cpp:

(WebCore::WebGLShader::WebGLShader):

• html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlStatusDisplayElement::update):

• html/track/TextTrack.cpp:

(WebCore::TextTrack::captionMenuOffItem):
(WebCore::TextTrack::captionMenuAutomaticItem):

• html/track/VTTRegion.cpp:

(WebCore::VTTRegion::scroll):

• html/track/VTTRegion.h:
• inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::toErrorString):
(WebCore::InspectorDOMAgent::resolveNode):
(WebCore::InspectorDOMAgent::documentURLString):
(WebCore::documentBaseURLString):

• inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::domTypeName):

• inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::localizedStringsURL):

• inspector/InspectorHistory.cpp:

(WebCore::InspectorHistory::Action::mergeId):

• inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::reload):
(WebCore::InspectorPageAgent::frameId):
(WebCore::InspectorPageAgent::loaderId):

• inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::ruleSelector):

• loader/EmptyClients.h:
• loader/FrameLoader.cpp:

(WebCore::FrameLoader::referrer):

• loader/ImageLoader.cpp:

(WebCore::ImageLoader::clearFailedLoadURL):

• loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::didReceiveResponse):

• page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected):

• page/FrameTree.cpp:

(WebCore::FrameTree::setName):
(WebCore::FrameTree::clearName):

• page/Location.cpp:

(WebCore::Location::port):

• platform/network/ProtectionSpaceBase.cpp:

(WebCore::ProtectionSpaceBase::ProtectionSpaceBase):

• xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::handleElementAttributes):

Source/WTF:

• wtf/text/AtomicString.cpp:

(WTF::AtomicString::convertASCIICase):

9:17 PM Changeset in webkit [203321] by benjamin@webkit.org

• 4 edits
  2 deletes in trunk/LayoutTests

[mac] LayoutTest fast/css/ancestor-of-hovered-element-detached.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=159173

Reviewed by Alexey Proskuryakov.

The test ancestor-of-hovered-element-detached.html is not reliably
covering r202324.

In the case of that test, the first style update is done with
the flag TeardownType::KeepHoverAndActive. This keeps the ":hover" state
set despite the subtree losing their renderer.
This looks like a serious issue that should be tested separately.

• fast/css/ancestor-of-hovered-element-removed.html:

The :hover update timer is actually a zero timer.
It is reasonable to expect a full update after one frame update.

• fast/css/ancestor-of-hovered-element-detached-expected.txt: Removed.
• fast/css/ancestor-of-hovered-element-detached.html: Removed.
• platform/ios-simulator/TestExpectations:
• platform/mac/TestExpectations:

9:16 PM Changeset in webkit [203320] by commit-queue@webkit.org

• 7 edits in trunk/Source/JavaScriptCore

[JSC] Convert the remaining createOutOfMemoryError()+throwException() into throwOutOfMemoryError()
​https://bugs.webkit.org/show_bug.cgi?id=159665

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-07-15
Reviewed by Saam Barati.

• API/JSTypedArray.cpp:

(createTypedArray):

• runtime/Error.cpp:

(JSC::createOutOfMemoryError):

• runtime/Error.h:
• runtime/ExceptionHelpers.cpp:

(JSC::throwOutOfMemoryError):

• runtime/JSArrayBufferConstructor.cpp:

(JSC::constructArrayBuffer):

• runtime/JSArrayBufferPrototype.cpp:

(JSC::arrayBufferProtoFuncSlice):

• runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::create):
(JSC::JSGenericTypedArrayView<Adaptor>::createUninitialized):

7:50 PM Changeset in webkit [203319] by mmaxfield@apple.com

• 2 edits in trunk/LayoutTests

Test gardening after r203314
​https://bugs.webkit.org/show_bug.cgi?id=159842

Unreviewed.

• TestExpectations:

7:12 PM Changeset in webkit [203318] by commit-queue@webkit.org

• 5 edits in trunk

[JSC] Change some parameters based on a random search
​https://bugs.webkit.org/show_bug.cgi?id=158514

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-07-15
Reviewed by Saam Barati.

Source/JavaScriptCore:

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::optimizationThresholdScalingFactor):

• runtime/Options.h:

Tools:

• Scripts/run-jsc-stress-tests:

6:43 PM Changeset in webkit [203317] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Repaints rects drawn incorrectly when inspecting a WebView on a Retina display
​https://bugs.webkit.org/show_bug.cgi?id=159824
rdar://problem/27376305

Reviewed by Brian Burg.

InspectorOverlayPage.js set up the canvases with a deviceScaleFactor passed into
reset(), which comes from the overlay's m_page.deviceScaleFactor(). However, updatePaintRects()
used window.devicePixelRatio which was always 1.

Fix by setting the deviceScaleFactor on the m_overlayPage.

• inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::overlayPage):

6:19 PM Changeset in webkit [203316] by timothy@apple.com

• 3 edits in trunk/Source/WebKit2

Web Automation: Fix element and event coord space issues
​https://bugs.webkit.org/show_bug.cgi?id=159851
rdar://problem/27375780

Reviewed by Brian Burg.

• UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::performMouseInteraction): Subtract topContentInset() before
it goes back out to WebDriver.

• WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::WebAutomationSessionProxy::computeElementLayout): When using useViewportCoordinates,
subtract topContentInset() so it matches expectations.

6:14 PM Changeset in webkit [203315] by mark.lam@apple.com

• 2 edits
  5 adds in trunk/Source/JavaScriptCore

Assertion failures and crashes with missing TDZ checks for catch-node bindings.
​https://bugs.webkit.org/show_bug.cgi?id=158797

Reviewed by Saam Barati.

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitPushCatchScope):
(JSC::BytecodeGenerator::emitPopCatchScope):

• tests/stress/catch-clause-should-be-under-tdz1.js: Added.
• tests/stress/catch-clause-should-be-under-tdz2.js: Added.
• tests/stress/catch-clause-should-be-under-tdz3.js: Added.
• tests/stress/catch-clause-should-be-under-tdz4.js: Added.
• tests/stress/catch-clause-should-be-under-tdz5.js: Added.

5:55 PM Changeset in webkit [203314] by mmaxfield@apple.com

• 5 edits in trunk

[macOS] Work around crash in [NSAttributedString nextWordFromIndex:forward:]
​https://bugs.webkit.org/show_bug.cgi?id=159842

Reviewed by Jon Lee.

Source/WebCore:

<rdar://problem/27380532> describes a crash inside [NSAttributedString nextWordFromIndex:forward:].
This must be worked around for ​https://bugs.webkit.org/show_bug.cgi?id=159755 and
<rdar://problem/27325521>.

• platform/text/mac/TextBoundaries.mm:

(WebCore::findNextWordFromIndex):

LayoutTests:

• editing/deleting/delete-emoji-expected.txt:
• editing/deleting/delete-emoji.html:

5:46 PM Changeset in webkit [203313] by beidson@apple.com

• 9 edits in trunk

Update XPathException to use the description in toString().
​https://bugs.webkit.org/show_bug.cgi?id=159848

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (Covered by changes to existing tests).

• bindings/js/JSDOMBinding.cpp:

(WebCore::createDOMException):

• xml/XPathException.h:

(WebCore::XPathException::XPathException):

LayoutTests:

• fast/dom/DOMException/XPathException-expected.txt:
• fast/dom/DOMException/resources/XPathException.js:
• fast/xpath/4XPath/Core/test_parser-expected.txt:
• fast/xpath/invalid-functions-expected.txt:
• fast/xpath/py-dom-xpath/expressions-expected.txt:

5:39 PM Changeset in webkit [203312] by Beth Dakin

• 15 edits in trunk/Source/WebKit2

Mac UI process needs to know about element focus and blur, much like iOS
​https://bugs.webkit.org/show_bug.cgi?id=159843
-and corresponding-
rdar://problem/27229504

Reviewed by Tim Horton.

This patch makes the existing iOS machinery to handle focus and blurring of
elements cross-platform. Instead of using the existing iOS messages for
startAssistingNode/stopAssistingNode, this patch adds a new message that
require only a boolean parameter: setEditableElementIsFocused.

Now that more of this code is shared, this patch teases
m_hasFocusedDueToUserInteraction out into two variables. I realized that it
was being used to mean two slightly different things on Mac and iOS, which
was very confusing. Now we have m_isAssistingNodeDueToUserInteraction to
represent the way iOS was using the variable, and we have
m_hasEverFocusedElementDueToUserInteractionSincePageTransition to represent
how Mac was using the variable. There should not be any behavior changes with
this re-name, just added clarity.

WebViewImpl has a new member variable m_editableElementIsFocused.

• UIProcess/Cocoa/WebViewImpl.h:
• UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::setEditableElementIsFocused):

Pipe the new setEditableElementIsFocused message to WebViewImpl.

• UIProcess/PageClient.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setEditableElementIsFocused):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• UIProcess/mac/PageClientImpl.h:
• UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setEditableElementIsFocused):

elementDidFocus() and elementDidBlur() are now PLATFORM(COCOA) instead of
PLATFORM(IOS)

• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::elementDidFocus):
(WebKit::WebChromeClient::elementDidBlur):

• WebProcess/WebCoreSupport/WebChromeClient.h:
• WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:

(WebKit::WebChromeClient::elementDidFocus): Deleted.
(WebKit::WebChromeClient::elementDidBlur): Deleted.

m_hasPendingBlurNotification is no longer iOS-only.

• WebProcess/WebPage/WebPage.cpp:

Use our two new bools m_isAssistingNodeDueToUserInteraction and
m_hasEverFocusedElementDueToUserInteractionSincePageTransition
(WebKit::WebPage::didStartPageTransition):
(WebKit::WebPage::didChangeSelection):

These functions are all newly cross-platform. The Messages they send are
still platform-specific, but otherwise the logic is the same. We
dispatch_async the blur messages so that the UI process features won’t be
flashy when the user is tapping, tabbing, or clicking through form fields.
(WebKit::WebPage::resetAssistedNodeForFrame):
(WebKit::WebPage::elementDidFocus):
(WebKit::WebPage::elementDidBlur):

resetAssistedNodeForFrame() is no longer iOS-only.
(WebKit::WebPage::didCommitLoad):

Move variables and functions around so that they are defined for the right
platform, and declare the two new bools in place of the old one.

• WebProcess/WebPage/WebPage.h:

These functions are now defined in WebPage.cpp

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::resetAssistedNodeForFrame): Deleted.
(WebKit::WebPage::elementDidFocus): Deleted.
(WebKit::WebPage::elementDidBlur): Deleted.

5:09 PM Changeset in webkit [203311] by beidson@apple.com

• 2 edits in trunk

Revert double ChangeLog entries

5:06 PM Changeset in webkit [203310] by beidson@apple.com

• 2 edits in trunk

Change toString() behavior for exceptions constructed with "createWithDescriptionAsMessage".
​https://bugs.webkit.org/show_bug.cgi?id=159839

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• IndexedDB-private-browsing/idbindex_get7-expected.txt:
• IndexedDB-private-browsing/idbindex_getKey7-expected.txt:
• IndexedDB-private-browsing/idbindex_openCursor2-expected.txt:
• IndexedDB-private-browsing/idbindex_openKeyCursor3-expected.txt:
• web-platform-tests/IndexedDB/idbindex_get7-expected.txt:
• web-platform-tests/IndexedDB/idbindex_getKey7-expected.txt:
• web-platform-tests/IndexedDB/idbindex_openCursor2-expected.txt:
• web-platform-tests/IndexedDB/idbindex_openKeyCursor3-expected.txt:

Source/WebCore:

No new tests (Covered by changes to existing tests).

This is the first step towards extended exception messages for all exception types.

• dom/ExceptionBase.cpp:

(WebCore::ExceptionBase::ExceptionBase):
(WebCore::ExceptionBase::toString):

• dom/ExceptionBase.h:

LayoutTests:

• storage/indexeddb/modern/createobjectstore-failures-expected.txt:
• storage/indexeddb/modern/createobjectstore-failures-private-expected.txt:
• storage/indexeddb/modern/double-abort-expected.txt:
• storage/indexeddb/modern/double-abort-private-expected.txt:
• storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures-expected.txt:
• storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures-private-expected.txt:
• storage/indexeddb/modern/idbdatabase-transaction-failures-expected.txt:
• storage/indexeddb/modern/idbdatabase-transaction-failures-private-expected.txt:

5:04 PM Changeset in webkit [203309] by beidson@apple.com

• 21 edits in trunk

Change toString() behavior for exceptions constructed with "createWithDescriptionAsMessage".
​https://bugs.webkit.org/show_bug.cgi?id=159839

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• IndexedDB-private-browsing/idbindex_get7-expected.txt:
• IndexedDB-private-browsing/idbindex_getKey7-expected.txt:
• IndexedDB-private-browsing/idbindex_openCursor2-expected.txt:
• IndexedDB-private-browsing/idbindex_openKeyCursor3-expected.txt:
• web-platform-tests/IndexedDB/idbindex_get7-expected.txt:
• web-platform-tests/IndexedDB/idbindex_getKey7-expected.txt:
• web-platform-tests/IndexedDB/idbindex_openCursor2-expected.txt:
• web-platform-tests/IndexedDB/idbindex_openKeyCursor3-expected.txt:

Source/WebCore:

No new tests (Covered by changes to existing tests).

This is the first step towards extended exception messages for all exception types.

• dom/ExceptionBase.cpp:

(WebCore::ExceptionBase::ExceptionBase):
(WebCore::ExceptionBase::toString):

• dom/ExceptionBase.h:

LayoutTests:

• storage/indexeddb/modern/createobjectstore-failures-expected.txt:
• storage/indexeddb/modern/createobjectstore-failures-private-expected.txt:
• storage/indexeddb/modern/double-abort-expected.txt:
• storage/indexeddb/modern/double-abort-private-expected.txt:
• storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures-expected.txt:
• storage/indexeddb/modern/idbdatabase-deleteobjectstore-failures-private-expected.txt:
• storage/indexeddb/modern/idbdatabase-transaction-failures-expected.txt:
• storage/indexeddb/modern/idbdatabase-transaction-failures-private-expected.txt:

4:50 PM Changeset in webkit [203308] by Brent Fulgham

• 1 edit
  5 adds in trunk/LayoutTests

Merge background parser Blink test case
​https://bugs.webkit.org/show_bug.cgi?id=116503

Test case is from the Blink change (patch by <​apavlov@chromium.org>):
<​https://chromium.googlesource.com/chromium/blink/+/3044d8c22b6ab5653fe572aad656ae1325725dc9>

• fast/css/background-parser-crash-expected.txt: Added.
• fast/css/background-parser-crash.html: Added.
• inspector/styles: Added.
• inspector/styles/background-parsing-crash-expected.txt: Added.
• inspector/styles/background-parsing-crash.html: Added.

4:25 PM Changeset in webkit [203307] by Brent Fulgham

• 1 edit
  2 adds in trunk/LayoutTests

Merge First-letter Blink test case
​https://bugs.webkit.org/show_bug.cgi?id=123961

Test case is from the Blink change (patch by <​leviw@chromium.org>):
<​https://chromium.googlesource.com/chromium/blink/+/c8ff8df9fc2ad81580526d53304c281df5d93e97%5E%21/#F1>

• fast/css-generated-content/empty-first-letter-with-columns-crash-expected.txt: Added.
• fast/css-generated-content/empty-first-letter-with-columns-crash.html: Added.

3:38 PM Changeset in webkit [203306] by Chris Dumez

• 2 edits in trunk/Source/WTF

Unreviewed, rolling out r203304.

This is wrong because of Node* entries in the internal HashMap

Reverted changeset:

"Add move constructor / assignment operator to ListHashSet"
​https://bugs.webkit.org/show_bug.cgi?id=159837
​http://trac.webkit.org/changeset/203304

3:27 PM Changeset in webkit [203305] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Marking http/tests/cache/disk-cache/disk-cache-request-max-stale.html as a flaky timeout on ios-simulator WK2 Release
​https://bugs.webkit.org/show_bug.cgi?id=159840

Unreviewed test gardening.

• platform/ios-simulator-wk2/TestExpectations:

3:25 PM Changeset in webkit [203304] by Chris Dumez

• 2 edits in trunk/Source/WTF

Add move constructor / assignment operator to ListHashSet
​https://bugs.webkit.org/show_bug.cgi?id=159837

Reviewed by Alex Christensen.

Add move constructor / assignment operator to ListHashSet.

• wtf/ListHashSet.h:

2:51 PM Changeset in webkit [203303] by ggaren@apple.com

• 38 edits in trunk/Source

Added a makeRef<T> helper
​https://bugs.webkit.org/show_bug.cgi?id=159835

Reviewed by Andreas Kling.

Anders told me to!

Source/JavaScriptCore:

• inspector/InjectedScriptHost.cpp:

(Inspector::InjectedScriptHost::wrapper):

Source/WebCore:

• Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::putOrAddOnServer):

• Modules/indexeddb/shared/InProcessIDBServer.cpp:

(WebCore::InProcessIDBServer::deleteDatabase):
(WebCore::InProcessIDBServer::didDeleteDatabase):
(WebCore::InProcessIDBServer::openDatabase):
(WebCore::InProcessIDBServer::didOpenDatabase):
(WebCore::InProcessIDBServer::didAbortTransaction):
(WebCore::InProcessIDBServer::didCommitTransaction):
(WebCore::InProcessIDBServer::didCreateObjectStore):
(WebCore::InProcessIDBServer::didDeleteObjectStore):
(WebCore::InProcessIDBServer::didClearObjectStore):
(WebCore::InProcessIDBServer::didCreateIndex):
(WebCore::InProcessIDBServer::didDeleteIndex):
(WebCore::InProcessIDBServer::didPutOrAdd):
(WebCore::InProcessIDBServer::didGetRecord):
(WebCore::InProcessIDBServer::didGetCount):
(WebCore::InProcessIDBServer::didDeleteRecord):
(WebCore::InProcessIDBServer::didOpenCursor):
(WebCore::InProcessIDBServer::didIterateCursor):
(WebCore::InProcessIDBServer::abortTransaction):
(WebCore::InProcessIDBServer::commitTransaction):
(WebCore::InProcessIDBServer::didFinishHandlingVersionChangeTransaction):
(WebCore::InProcessIDBServer::createObjectStore):
(WebCore::InProcessIDBServer::deleteObjectStore):
(WebCore::InProcessIDBServer::clearObjectStore):
(WebCore::InProcessIDBServer::createIndex):
(WebCore::InProcessIDBServer::deleteIndex):
(WebCore::InProcessIDBServer::putOrAdd):
(WebCore::InProcessIDBServer::getRecord):
(WebCore::InProcessIDBServer::getCount):
(WebCore::InProcessIDBServer::deleteRecord):
(WebCore::InProcessIDBServer::openCursor):
(WebCore::InProcessIDBServer::iterateCursor):
(WebCore::InProcessIDBServer::establishTransaction):
(WebCore::InProcessIDBServer::fireVersionChangeEvent):
(WebCore::InProcessIDBServer::didStartTransaction):
(WebCore::InProcessIDBServer::didCloseFromServer):
(WebCore::InProcessIDBServer::notifyOpenDBRequestBlocked):
(WebCore::InProcessIDBServer::databaseConnectionClosed):
(WebCore::InProcessIDBServer::abortOpenAndUpgradeNeeded):
(WebCore::InProcessIDBServer::didFireVersionChangeEvent):
(WebCore::InProcessIDBServer::openDBRequestCancelled):
(WebCore::InProcessIDBServer::confirmDidCloseFromServer):
(WebCore::InProcessIDBServer::getAllDatabaseNames):
(WebCore::InProcessIDBServer::didGetAllDatabaseNames):

• Modules/mediastream/MediaDevicesRequest.cpp:

(WebCore::MediaDevicesRequest::didCompleteTrackSourceInfoRequest):

• Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::constraintsValidated):
(WebCore::UserMediaRequest::userMediaAccessGranted):

• Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::scheduleNodeDeletion):
(WebCore::AudioContext::isPlayingAudioDidChange):
(WebCore::AudioContext::suspend):
(WebCore::AudioContext::resume):
(WebCore::AudioContext::close):
(WebCore::AudioContext::suspendPlayback):
(WebCore::AudioContext::mayResumePlayback):

• Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::didConnect):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessage):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveBinaryData):
(WebCore::ThreadableWebSocketChannelClientWrapper::didUpdateBufferedAmount):
(WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshake):
(WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
(WebCore::ThreadableWebSocketChannelClientWrapper::didReceiveMessageError):
(WebCore::ThreadableWebSocketChannelClientWrapper::processPendingTasks):

• Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):

• bindings/js/JSEventListener.h:

(WebCore::JSEventListener::jsFunction):

• dom/Node.cpp:

(WebCore::Node::setTextContent):

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::layoutSizeChanged):

• inspector/CommandLineAPIHost.cpp:

(WebCore::CommandLineAPIHost::wrapper):

• platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:

(WebCore::AudioSourceProviderAVFObjC::prepare):

• platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp:

(WebCore::WebCoreAVCFResourceLoader::invalidate):

• platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:

(WebCore::WebCoreAVFResourceLoader::invalidate):

• platform/ios/WebVideoFullscreenControllerAVKit.mm:

(WebVideoFullscreenControllerContext::setExternalPlayback):

• platform/network/BlobResourceHandle.cpp:

(WebCore::BlobResourceHandle::start):
(WebCore::BlobResourceHandle::notifyFinish):

• platform/network/SocketStreamHandleBase.cpp:

(WebCore::SocketStreamHandleBase::disconnect):

• platform/network/curl/CurlDownload.cpp:

(WebCore::CurlDownload::didReceiveHeader):

Source/WebKit2:

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::writeBlobsToTemporaryFiles):

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::tryStoreAsCacheEntry):

• Platform/IPC/Connection.cpp:

(IPC::Connection::addWorkQueueMessageReceiver):
(IPC::Connection::removeWorkQueueMessageReceiver):
(IPC::Connection::invalidate):
(IPC::Connection::sendMessage):
(IPC::Connection::processIncomingMessage):
(IPC::Connection::postConnectionDidCloseOnConnectionWorkQueue):
(IPC::Connection::connectionDidClose):
(IPC::Connection::enqueueIncomingMessage):

• Platform/IPC/mac/ConnectionMac.mm:

(IPC::Connection::receiveSourceEventHandler):

• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::ThreadedCompositor::setNativeSurfaceHandleForCompositing):
(WebKit::ThreadedCompositor::setDeviceScaleFactor):
(WebKit::ThreadedCompositor::didChangeViewportSize):
(WebKit::ThreadedCompositor::didChangeViewportAttribute):
(WebKit::ThreadedCompositor::didChangeContentsSize):
(WebKit::ThreadedCompositor::scrollTo):
(WebKit::ThreadedCompositor::scrollBy):
(WebKit::ThreadedCompositor::didChangeVisibleRect):

• UIProcess/API/APIUserContentExtensionStore.cpp:

(API::UserContentExtensionStore::lookupContentExtension):
(API::UserContentExtensionStore::compileContentExtension):
(API::UserContentExtensionStore::removeContentExtension):

• UIProcess/Launcher/ProcessLauncher.cpp:

(WebKit::ProcessLauncher::ProcessLauncher):

• UIProcess/Storage/LocalStorageDatabaseTracker.cpp:

(WebKit::LocalStorageDatabaseTracker::LocalStorageDatabaseTracker):

• UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::createSessionStorageNamespace):
(WebKit::StorageManager::destroySessionStorageNamespace):
(WebKit::StorageManager::setAllowedSessionStorageNamespaceConnection):
(WebKit::StorageManager::cloneSessionStorageNamespace):
(WebKit::StorageManager::processDidCloseConnection):
(WebKit::StorageManager::getSessionStorageOrigins):
(WebKit::StorageManager::deleteSessionStorageOrigins):
(WebKit::StorageManager::deleteSessionStorageEntriesForOrigins):
(WebKit::StorageManager::getLocalStorageOrigins):
(WebKit::StorageManager::getLocalStorageOriginDetails):
(WebKit::StorageManager::deleteLocalStorageEntriesForOrigin):
(WebKit::StorageManager::deleteLocalStorageOriginsModifiedSince):
(WebKit::StorageManager::deleteLocalStorageEntriesForOrigins):

• UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::readDataFromDiskIfNeeded):

• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::fetchData):

• WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::pluginThreadAsyncCall):

• WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::wheelEvent):
(WebKit::EventDispatcher::gestureEvent):
(WebKit::EventDispatcher::touchEvent):

• WebProcess/WebPage/ViewUpdateDispatcher.cpp:

(WebKit::ViewUpdateDispatcher::visibleContentRectUpdate):

Source/WTF:

• wtf/Ref.h:

(WTF::makeRef): Helper function to do type inference for you.

2:35 PM Changeset in webkit [203302] by Chris Dumez

• 66 edits in trunk/Source

Use fastGetAttribute() / setAttributeWithoutSynchronization() when possible
​https://bugs.webkit.org/show_bug.cgi?id=159793

Reviewed by Ryosuke Niwa.

Use fastGetAttribute() / setAttributeWithoutSynchronization() when possible, for performance.

Source/WebCore:

• Modules/plugins/YouTubePluginReplacement.cpp:

(WebCore::YouTubePluginReplacement::installReplacement):

• dom/Element.h:

(WebCore::Element::setIdAttribute):

• editing/ApplyStyleCommand.cpp:

(WebCore::hasNoAttributeOrOnlyStyleAttribute):
(WebCore::createFontElement):
(WebCore::ApplyStyleCommand::applyInlineStyleChange):

• editing/EditingStyle.cpp:

(WebCore::EditingStyle::elementIsStyledSpanOrHTMLEquivalent):

• editing/Editor.cpp:

(WebCore::Editor::setBaseWritingDirection):

• editing/ReplaceSelectionCommand.cpp:

(WebCore::isMailPasteAsQuotationNode):
(WebCore::isInlineNodeWithStyle):

• editing/cocoa/DataDetection.mm:

(WebCore::DataDetection::detectContentInRange):

• editing/htmlediting.cpp:

(WebCore::createTabSpanElement):

• editing/ios/EditorIOS.mm:

(WebCore::Editor::setTextAlignmentForChangedBaseWritingDirection):
(WebCore::Editor::WebContentReader::readURL):

• editing/mac/EditorMac.mm:

(WebCore::Editor::WebContentReader::readURL):

• editing/markup.cpp:

(WebCore::createFragmentFromText):

• html/BaseButtonInputType.cpp:

(WebCore::BaseButtonInputType::setValue):

• html/BaseCheckableInputType.cpp:

(WebCore::BaseCheckableInputType::setValue):

• html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocumentParser::appendEntry):
(WebCore::FTPDirectoryDocumentParser::createTDForFilename):
(WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
(WebCore::FTPDirectoryDocumentParser::createBasicDocument):

• html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::href):
(WebCore::HTMLAnchorElement::setHref):
(WebCore::HTMLAnchorElement::target):

• html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::target):

• html/HTMLBaseElement.cpp:

(WebCore::HTMLBaseElement::setHref):

• html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::setType):

• html/HTMLDetailsElement.cpp:

(WebCore::HTMLDetailsElement::didAddUserAgentShadowRoot):
(WebCore::HTMLDetailsElement::toggleOpen):

• html/HTMLDocument.cpp:

(WebCore::HTMLDocument::setBgColor):
(WebCore::HTMLDocument::setFgColor):
(WebCore::HTMLDocument::setAlinkColor):
(WebCore::HTMLDocument::setLinkColor):
(WebCore::HTMLDocument::setVlinkColor):

• html/HTMLElement.cpp:

(WebCore::HTMLElement::setDir):
(WebCore::HTMLElement::setContentEditable):
(WebCore::HTMLElement::setDraggable):
(WebCore::HTMLElement::setSpellcheck):
(WebCore::HTMLElement::setTranslate):

• html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::setFormEnctype):
(WebCore::HTMLFormControlElement::setFormMethod):
(WebCore::HTMLFormControlElement::setAutocorrect):
(WebCore::HTMLFormControlElement::setAutocapitalize):
(WebCore::HTMLFormControlElement::setAutocomplete):

• html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::setAutocorrect):
(WebCore::HTMLFormElement::setAutocapitalize):
(WebCore::HTMLFormElement::setAction):
(WebCore::HTMLFormElement::setEnctype):
(WebCore::HTMLFormElement::setMethod):
(WebCore::HTMLFormElement::target):

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::width):
(WebCore::HTMLImageElement::height):
(WebCore::HTMLImageElement::setSrc):

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::setType):
(WebCore::HTMLInputElement::updateType):
(WebCore::HTMLInputElement::altText):
(WebCore::HTMLInputElement::setDefaultValue):

• html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::href):
(WebCore::HTMLLinkElement::target):
(WebCore::HTMLLinkElement::type):

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setSrc):
(WebCore::HTMLMediaElement::setPreload):

• html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::min):
(WebCore::HTMLMeterElement::setMin):
(WebCore::HTMLMeterElement::max):
(WebCore::HTMLMeterElement::setMax):
(WebCore::HTMLMeterElement::value):
(WebCore::HTMLMeterElement::setValue):
(WebCore::HTMLMeterElement::low):
(WebCore::HTMLMeterElement::setLow):
(WebCore::HTMLMeterElement::high):
(WebCore::HTMLMeterElement::setHigh):
(WebCore::HTMLMeterElement::optimum):
(WebCore::HTMLMeterElement::setOptimum):

• html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::containsJavaApplet):

• html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::createForJSConstructor):
(WebCore::HTMLOptionElement::setValue):
(WebCore::HTMLOptionElement::setLabel):

• html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::setValue):
(WebCore::HTMLProgressElement::setMax):

• html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::typeAttributeValue):

• html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::setMultiple):

• html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::setSrc):
(WebCore::HTMLSourceElement::media):
(WebCore::HTMLSourceElement::setMedia):
(WebCore::HTMLSourceElement::type):
(WebCore::HTMLSourceElement::setType):

• html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::setAlign):
(WebCore::HTMLTableSectionElement::setCh):
(WebCore::HTMLTableSectionElement::chOff):
(WebCore::HTMLTableSectionElement::setChOff):
(WebCore::HTMLTableSectionElement::setVAlign):

• html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::updateInnerTextElementEditability):

• html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::imageSourceURL):

• html/HiddenInputType.cpp:

(WebCore::HiddenInputType::restoreFormControlState):
(WebCore::HiddenInputType::setValue):

• html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):
(WebCore::MediaDocument::replaceMediaElementTimerFired):

• html/PluginDocument.cpp:

(WebCore::PluginDocumentParser::createDocumentStructure):

• html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::createAutoFillButton):
(WebCore::TextFieldInputType::updateAutoFillButton):

• html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processIsindexStartTagForInBody):

• html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlClosedCaptionsContainerElement::create):
(WebCore::MediaControlTimelineElement::create):
(WebCore::MediaControlPanelVolumeSliderElement::create):
(WebCore::MediaControlFullscreenVolumeSliderElement::create):

• html/shadow/TextControlInnerElements.cpp:

(WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement):

• html/shadow/mac/ImageControlsButtonElementMac.cpp:

(WebCore::ImageControlsButtonElementMac::tryCreate):

• html/shadow/mac/ImageControlsRootElementMac.cpp:

(WebCore::ImageControlsRootElement::tryCreate):

• html/track/WebVTTElement.cpp:

(WebCore::WebVTTElement::createEquivalentHTMLElement):

• html/track/WebVTTParser.cpp:

(WebCore::WebVTTTreeBuilder::constructTreeFromToken):

• inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::createInspectorStyleSheetForDocument):

• inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::buildObjectForFrame):

• mathml/MathMLSelectElement.cpp:

(WebCore::MathMLSelectElement::toggle):

• page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):

• rendering/RenderDetailsMarker.cpp:

(WebCore::RenderDetailsMarker::isOpen):

• rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::updateFromElement):

• svg/SVGElement.cpp:

(WebCore::SVGElement::setXmlbase):

• svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::setContentScriptType):
(WebCore::SVGSVGElement::setContentStyleType):

• svg/SVGStyleElement.cpp:

(WebCore::SVGStyleElement::setMedia):
(WebCore::SVGStyleElement::setTitle):

Source/WebKit/mac:

• WebView/WebHTMLRepresentation.mm:

(matchLabelsAgainstElement):

Source/WebKit/win:

• DOMHTMLClasses.cpp:

(DOMHTMLElement::idName):

Source/WebKit2:

• WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm:

(WebKit::PDFPlugin::PDFPlugin):

• WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::createPasswordEntryForm):

• WebProcess/Plugins/PDF/PDFPluginAnnotation.mm:

(WebKit::PDFPluginAnnotation::attach):

• WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:

(WebKit::PDFPluginChoiceAnnotation::createAnnotationElement):

2:34 PM Changeset in webkit [203301] by Chris Dumez

• 9 edits in trunk/Source/WebCore

Modernize StaticNodeList / StaticElementList
​https://bugs.webkit.org/show_bug.cgi?id=159831

Reviewed by Ryosuke Niwa.

Modernize StaticNodeList / StaticElementList. Pass vector to adopt
as an rvalue reference instead of a non-const reference.

• bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::namedItems):

• dom/ChildListMutationScope.cpp:

(WebCore::ChildListMutationAccumulator::enqueueMutationRecord):

• dom/MutationRecord.cpp:
• dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::queryAll):

• dom/StaticNodeList.h:
• dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::getRegionsByContent):
(WebCore::WebKitNamedFlow::getRegions):
(WebCore::WebKitNamedFlow::getContent):

• svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::collectIntersectionOrEnclosureList):

• testing/Internals.cpp:

(WebCore::Internals::nodesFromRect):

2:18 PM Changeset in webkit [203300] by Brent Fulgham

• 3 edits
  3 adds in trunk

Block insecure script running in a data: frame when the top-level page is HTTPS
​https://bugs.webkit.org/show_bug.cgi?id=125806
<rdar://problem/27331825>

Reviewed by Brady Eidson.

Fix based on a Blink change (patch by <​tsepez@chromium.org>):
<​https://chromium.googlesource.com/chromium/blink/+/33e553bd96e040151c1472289a0d80803bfca3a5>

Source/WebCore:

Test: http/tests/security/mixedContent/insecure-script-in-data-iframe-in-main-frame-blocked.html

• loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::checkInsecureContent): Check the top-level frame's security state
before allowing insecure scripts to be used.

LayoutTests:

• http/tests/security/mixedContent/insecure-script-in-data-iframe-in-main-frame-blocked-expected.txt: Added.
• http/tests/security/mixedContent/insecure-script-in-data-iframe-in-main-frame-blocked.html: Added.
• http/tests/security/mixedContent/resources/frame-with-data-url-frame-with-script.html: Added.

2:17 PM Changeset in webkit [203299] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

FunctionOverride's parseClause() needs to keep the CString instance in scope while its data is being used.
​https://bugs.webkit.org/show_bug.cgi?id=159828

Reviewed by Saam Barati.

Otherwise, we'll have a use after free. This issue was caught when running an
ASan debug build of testapi.

• tools/FunctionOverrides.cpp:

(JSC::parseClause):

2:01 PM Changeset in webkit [203298] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Let the compiler generate QualifiedName copy constructor and assignment operator
​https://bugs.webkit.org/show_bug.cgi?id=159826

Reviewed by Alex Christensen.

Let the compiler generate QualifiedName copy constructor and assignment operator
as our custom implementation does nothing special. This also makes QualifiedName
movable as the compiler is now able to generate the move constructor / assignment
operator as well.

• dom/QualifiedName.h:

(WebCore::QualifiedName::QualifiedName): Deleted.
(WebCore::QualifiedName::operator=): Deleted.

1:58 PM Changeset in webkit [203297] by keith_miller@apple.com

• 9 edits
  1 add in trunk/Source/JavaScriptCore

%TypedArray%.prototype.indexOf is coercing non-integers or non-floats to numbers wrongly
​https://bugs.webkit.org/show_bug.cgi?id=159400

Reviewed by Geoffrey Garen.

This patch fixes coercion of non-numbers in indexOf/lastIndexOf.
Additionally, this patch fixes an issue with includes where it
would not check that the buffer remained non-neutered after
calling the toInteger() function. Lastly, some extra release
asserts have been added in some places to inform us of any issues
in the future.

Additionally, this patch changes bool toNativeFromDouble to
Optional<Type> toNativeFromDoubleWithoutCoercion. This makes it a
little clearer what the function does and also removes the return
argument. The only behavior change is that the function no longer
coerces non-numbers into numbers. That behavior was unused (maybe
unintended), however.

• runtime/JSGenericTypedArrayView.h:

(JSC::JSGenericTypedArrayView::toAdaptorNativeFromValueWithoutCoercion):
(JSC::JSGenericTypedArrayView::sort):
(JSC::JSGenericTypedArrayView::toAdaptorNativeFromValue): Deleted.

• runtime/JSGenericTypedArrayViewPrototypeFunctions.h:

(JSC::genericTypedArrayViewProtoFuncCopyWithin):
(JSC::genericTypedArrayViewProtoFuncIncludes):
(JSC::genericTypedArrayViewProtoFuncIndexOf):
(JSC::genericTypedArrayViewProtoFuncLastIndexOf):

• runtime/ToNativeFromValue.h:

(JSC::toNativeFromValueWithoutCoercion):
(JSC::toNativeFromValue): Deleted.

• runtime/TypedArrayAdaptors.h:

(JSC::IntegralTypedArrayAdaptor::toNativeFromInt32WithoutCoercion):
(JSC::IntegralTypedArrayAdaptor::toNativeFromUint32WithoutCoercion):
(JSC::IntegralTypedArrayAdaptor::toNativeFromDoubleWithoutCoercion):
(JSC::FloatTypedArrayAdaptor::toNativeFromInt32WithoutCoercion):
(JSC::FloatTypedArrayAdaptor::toNativeFromDoubleWithoutCoercion):
(JSC::Uint8ClampedAdaptor::toNativeFromInt32WithoutCoercion):
(JSC::Uint8ClampedAdaptor::toNativeFromDoubleWithoutCoercion):
(JSC::IntegralTypedArrayAdaptor::toNativeFromInt32): Deleted.
(JSC::IntegralTypedArrayAdaptor::toNativeFromUint32): Deleted.
(JSC::IntegralTypedArrayAdaptor::toNativeFromDouble): Deleted.
(JSC::FloatTypedArrayAdaptor::toNativeFromInt32): Deleted.
(JSC::FloatTypedArrayAdaptor::toNativeFromDouble): Deleted.
(JSC::Uint8ClampedAdaptor::toNativeFromInt32): Deleted.
(JSC::Uint8ClampedAdaptor::toNativeFromDouble): Deleted.

• tests/stress/resources/typedarray-test-helper-functions.js:
• tests/stress/typedarray-functions-with-neutered.js:

(callWithArgs):

• tests/stress/typedarray-includes.js: Added.
• tests/stress/typedarray-indexOf.js:
• tests/stress/typedarray-lastIndexOf.js:

1:56 PM Changeset in webkit [203296] by rniwa@webkit.org

• 2 edits in trunk/Source/WebKit2

Disable custom elements in Safari Tech Preview
​https://bugs.webkit.org/show_bug.cgi?id=159829

Reviewed by Chris Dumez.

Disable custom elements API in Safari Technology Preview. Our implementation is so out of sync
with the latest spec that it's actively harmful to have this feature enabled.

• Shared/WebPreferencesDefinitions.h:

1:42 PM Changeset in webkit [203295] by dino@apple.com

• 3 edits in trunk/Source/WebKit2

Full screen ePub embedded video is playing on 1/4 screen, cut off
​https://bugs.webkit.org/show_bug.cgi?id=159737
<rdar://problem/26259404>

Patch by Jer Noble <​jer.noble@apple.com> on 2016-07-15
Reviewed by Tim Horton.

Set the fixedLayoutSize to CGSizeZero when disabling fixed layout due to the
WebView not supporting arbitrary layout modes, and reset to the saved value
when the view does begin supporting arbitrary layout modes.

• UIProcess/Cocoa/WebViewImpl.h:
• UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::setFixedLayoutSize):
(WebKit::WebViewImpl::updateSupportsArbitraryLayoutModes):

1:19 PM Changeset in webkit [203294] by tonikitoo@webkit.org

• 3 edits in trunk/Source/WebCore

ScrollView::setHasHorizontalScrollbar / setHasVerticalScrollbar duplicate their logic
​https://bugs.webkit.org/show_bug.cgi?id=159825

Patch introduces a (private) method to ScrollView
to share the code/logic of setHas{Horizontal,Vertical}Scrollbar.

Patch by Antonio Gomes <​tonikitoo@igalia.com> on 2016-07-15
Reviewed by Simon Fraser.

No new tests needed.

• platform/ScrollView.cpp:

(WebCore::ScrollView::setHasScrollbarInternal):
(WebCore::ScrollView::setHasHorizontalScrollbar):
(WebCore::ScrollView::setHasVerticalScrollbar):

• platform/ScrollView.h:

1:03 PM Changeset in webkit [203293] by Csaba Osztrogonác

• 3 edits in trunk/Source/JavaScriptCore

Add new functions to ARMAssembler after r202214
​https://bugs.webkit.org/show_bug.cgi?id=159713

Reviewed by Saam Barati.

• assembler/ARMAssembler.h:

(JSC::ARMAssembler::fillNops):

• assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::patchableBranch32):
(JSC::MacroAssemblerARM::internalCompare32):

12:38 PM Changeset in webkit [203292] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Skipping test from r203288 on ios-simulator due to reliance upon mouse events.
​https://bugs.webkit.org/show_bug.cgi?id=159818

Unreviewed test gardening.

• platform/ios-simulator/TestExpectations:

12:27 PM Changeset in webkit [203291] by Jon Davis

• 2 edits in trunk/Websites/webkit.org

Fixed content overflow and missing build information behavior.
​https://bugs.webkit.org/show_bug.cgi?id=159820

Reviewed by Timothy Hatcher.

• wp-content/themes/webkit/nightly-start.php:

12:01 PM Changeset in webkit [203290] by timothy@apple.com

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Make Open Quickly and Goto Line dialogs match Xcode 8
​https://bugs.webkit.org/show_bug.cgi?id=159823
rdar://problem/27376501

Reviewed by Brian Burg.

• UserInterface/Views/GoToLineDialog.css:

(.go-to-line-dialog):
(.go-to-line-dialog > div > input):
(.go-to-line-dialog > div > input::placeholder):
(.go-to-line-dialog > div > img):
(.go-to-line-dialog > div): Deleted.

• UserInterface/Views/OpenResourceDialog.css:

(.open-resource-dialog):
(.open-resource-dialog > .field):
(.open-resource-dialog > .field > input):
(.open-resource-dialog > .field > input::placeholder):
(.open-resource-dialog > .field > img):
(.open-resource-dialog > .tree-outline .item): Deleted.
(.open-resource-dialog > .tree-outline .item:first-child): Deleted.

11:47 AM Changeset in webkit [203289] by fred.wang@free.fr

• 17 edits in trunk

MathOperator: Improve alignment for vertical size variant
​https://bugs.webkit.org/show_bug.cgi?id=158866

Patch by Frederic Wang <​fwang@igalia.com> on 2016-07-15
Reviewed by Brent Fulgham.

Source/WebCore:

The MathOperator class may stretch operators with either a large glyph or a glyph assembly.
In the latter case, the assembly is adjusted to match the stretch ascent and descent
requested by the callers. But in the former case the glyph ascent and descent are used
instead. We solve this by making MathOperator::stretchTo only take a targetSize and let
callers do the vertical alignment they want. This improves the rendering of fences with some
math fonts (e.g. XITS) and allows to pass the two cases of mo-axis-height-1.html.

Test: imported/mathml-in-html5/mathml/presentation-markup/operators/mo-axis-height-1.html

• rendering/mathml/MathOperator.cpp:

(WebCore::MathOperator::stretchTo): Merge vertical and horizontal stretching into the same
function with only the targetSize as a parameter.

• rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::stretchTo): Updated to use the new signature.
(WebCore::RenderMathMLOperator::verticalStretchedOperatorShift): Helper function to calculate
the shift necessary to align the baseline of the MathOperator instance with the one of the
RenderMathMLOperator.
(WebCore::RenderMathMLOperator::firstLineBaseline): Adjust the baseline.

• rendering/mathml/RenderMathMLOperator.h: Declare verticalStretchedOperatorShift.
• rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::layoutBlock): Use the new signature. This function aligns the top
of the radical with the overbar so we do not need to adjust baseline alignment here.

LayoutTests:

We import the latest version of mo-axis-height-1.html and update the expectation now that we
pass the two cases (size variant and glyph assembly). We also rebaseline some pixel tests.

• imported/mathml-in-html5/fonts/math/axisheight5000-verticalarrow14000.woff: Updated.
• imported/mathml-in-html5/mathml/presentation-markup/operators/mo-axis-height-1-expected.txt: Updated to expect PASS.
• imported/mathml-in-html5/mathml/presentation-markup/operators/mo-axis-height-1.html: Updated to include the two tests.
• platform/gtk/mathml/opentype/vertical-expected.png: Rebaseline to take into account better alignment of size variant.
• platform/gtk/mathml/opentype/vertical-expected.txt: Ditto.
• platform/gtk/mathml/presentation/mo-stretch-expected.png: Ditto.
• platform/gtk/mathml/presentation/mo-stretch-expected.txt: Ditto.
• platform/ios-simulator/mathml/opentype/opentype-stretchy-expected.txt: Ditto.
• platform/ios-simulator/mathml/presentation/mo-stretch-expected.txt: Ditto.
• platform/mac/mathml/opentype/opentype-stretchy-expected.txt: Ditto.
• platform/mac/mathml/presentation/mo-stretch-expected.txt: Ditto.

11:39 AM Changeset in webkit [203288] by beidson@apple.com

• 3 edits
  2 adds in trunk

WebKit should prevent push/replace state with username in URL.
<rdar://problem/27361737> and ​https://bugs.webkit.org/show_bug.cgi?id=159818

Reviewed by Brent Fulgham.

Source/WebCore:

Test: http/tests/security/history-username-password.html

• page/History.cpp:

(WebCore::History::stateObjectAdded): Don't allow URLs with usernames/passwords.

LayoutTests:

• http/tests/security/history-username-password-expected.txt: Added.
• http/tests/security/history-username-password.html: Added.

11:33 AM Changeset in webkit [203287] by Ryan Haddad

• 10 edits
  52 deletes in trunk

Unreviewed, rolling out r203266.

This change caused editing/deleting/delete-emoji.html to time
out on El Capitan, crash under GuardMalloc

Reverted changeset:

"Support new emoji group candidates"
​https://bugs.webkit.org/show_bug.cgi?id=159755
​http://trac.webkit.org/changeset/203266

11:31 AM Changeset in webkit [203286] by mark.lam@apple.com

• 2 edits
  1 add in trunk/Source/JavaScriptCore

Stack overflow error for deeply nested classes.
​https://bugs.webkit.org/show_bug.cgi?id=157086

Reviewed by Geoffrey Garen.

Changed the StructureStubClearingWatchpoint destructor to iteratively destruct
its chain of next StructureStubClearingWatchpoints instead of recursively doing
so.

The added deep-StructureStubClearingWatchpoint-destructor-recursion.js test
produces a crash before the fix is applied, but takes about 14 minutes to run.
Hence, it is skipped.

• bytecode/StructureStubClearingWatchpoint.cpp:

(JSC::StructureStubClearingWatchpoint::~StructureStubClearingWatchpoint):

• tests/stress/deep-StructureStubClearingWatchpoint-destructor-recursion.js: Added.

11:30 AM MathML/Early_2016_Refactoring edited by fred.wang@free.fr

(diff)

11:24 AM Changeset in webkit [203285] by fred.wang@free.fr

• 11 edits
  2 adds in trunk

Source/WebCore:
Move parsing of mfrac attributes into a MathMLFractionElement class
​https://bugs.webkit.org/show_bug.cgi?id=159624

Patch by Frederic Wang <​fwang@igalia.com> on 2016-07-15
Reviewed by Brent Fulgham.

We move the parsing of mfrac attributes to a MathMLFractionElement class. This allows to
minimize the updates in RenderMathMLFraction and to remove the alignment members. Many of
the members in updateLayoutParameters are actually only used in layoutBlock and could be
removed in a follow-up patch. We also improve the resolution of negative line thickness value
since the MathML recommendation says it should be rounded up to the nearest valid
value (which is zero) instead of ignoring the attribute and using the line thickness.

No new tests, already covered by existing tests.

• CMakeLists.txt: Add MathMLFractionElement.
• WebCore.xcodeproj/project.pbxproj: Ditto.
• mathml/MathMLAllInOne.cpp: Ditto.
• mathml/MathMLFractionElement.cpp: Added.

(WebCore::MathMLFractionElement::MathMLFractionElement):
(WebCore::MathMLFractionElement::create):
(WebCore::MathMLFractionElement::lineThickness): Return the cached linethickness length,
parsing it again if it is dirty. This handles the special values "thin", "medium" and "thick"
or fallback to the general parseMathMLLength for MathML lengths.
(WebCore::MathMLFractionElement::cachedFractionAlignment): Return the cached alignment value,
parsing it again if it is dirty.
(WebCore::MathMLFractionElement::numeratorAlignment): Return the cached alignment.
(WebCore::MathMLFractionElement::denominatorAlignment): Ditto.
(WebCore::MathMLFractionElement::parseAttribute): Make attributes dirty.
(WebCore::MathMLFractionElement::createElementRenderer): Create a RenderMathMLFraction.

• mathml/MathMLFractionElement.h: Added.
• mathml/MathMLInlineContainerElement.cpp: We no longer need to handle fraction here.

(WebCore::MathMLInlineContainerElement::createElementRenderer):

• mathml/mathtags.in: Use MathMLFractionElement for mfrac.
• rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::updateLayoutParameters): New helper function to set the
layout parameters, replacing updateFromElement. We no longer parse and store the alignment
values here. We also change the resolution of negative values.
(WebCore::RenderMathMLFraction::horizontalOffset): Use the enum from MathMLFractionElement.
(WebCore::RenderMathMLFraction::layoutBlock): We call updateLayoutParameters instead of
updateFromElement. The numerator and denominator alignments are resolved here.
(WebCore::RenderMathMLFraction::parseAlignmentAttribute): Deleted. Parsing of alignment
attribute is now handled in MathMLFractionElement.
(WebCore::RenderMathMLFraction::updateFromElement): Deleted. Attribute changes are now
handled in MathMLFractionElement.
(WebCore::RenderMathMLFraction::styleDidChange): Deleted. Font changes are properly handled.

• rendering/mathml/RenderMathMLFraction.h: Update declarations.

LayoutTests:
Move parsing of mfrac attributes into a MathMLFractionElementClass
​https://bugs.webkit.org/show_bug.cgi?id=159624

Patch by Frederic Wang <​fwang@igalia.com> on 2016-07-15
Reviewed by Brent Fulgham.

We update the expectation for negative linethickness. As indicated in the MathML
recommendation, it should be rounded up to the nearest valid value, which is 0.

• mathml/presentation/mfrac-linethickness2.html: Update the comment to reflect the new behavior.
• mathml/presentation/mfrac-linethickness2-expected.html: Use 0px as the reference for negative values.

11:06 AM Changeset in webkit [203284] by Jon Davis

• 2 edits in trunk/Tools

Changed the start page URL for WebKit Nightly builds.
​https://bugs.webkit.org/show_bug.cgi?id=159816

Reviewed by Timothy Hatcher.

• WebKitLauncher/start.html:

10:41 AM Changeset in webkit [203283] by Brent Fulgham

• 1 edit
  2 adds in trunk/LayoutTests

Merge InlineBidiResolver end-of-line Blink test case
​https://bugs.webkit.org/show_bug.cgi?id=126201
<rdar://problem/27331789>

Test case is from the Blink change (patch by <​igor.o@chromium.org>):
<​https://chromium.googlesource.com/chromium/blink/+/d34ca9bbbdf71905d61aa45def30063311508a64>

• fast/text/international/bidi-crash-reached-end-of-line-expected.txt: Added.
• fast/text/international/bidi-crash-reached-end-of-line.html: Added.

10:35 AM Changeset in webkit [203282] by Brent Fulgham

• 1 edit
  2 adds in trunk/LayoutTests

Merge Blink test case
​https://bugs.webkit.org/show_bug.cgi?id=123870

Patch is from the Blink change (patch by <​morritaw@chromium.org>):
<​https://chromium.googlesource.com/chromium/blink/+/2abd63ccea97b1fcf25b337c76f12e6ad1bfc025>

• fast/dom/mutation-details-focus-expected.txt: Added.
• fast/dom/mutation-details-focus.html: Added.

10:30 AM Changeset in webkit [203281] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Updating TestExpectations after r203267
​https://bugs.webkit.org/show_bug.cgi?id=159817

Unreviewed test gardening.

• TestExpectations:

10:03 AM Changeset in webkit [203280] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebCore

Check whether font is nonnull for GlyphData instead of calling GlyphData::isValid()
​https://bugs.webkit.org/show_bug.cgi?id=159783

Patch by Frederic Wang <​fwang@igalia.com> on 2016-07-15
Reviewed by Brent Fulgham.

GlyphData::isValid() returns true for GlyphData with null 'font' pointer when the 'glyph'
index is nonzero. This behavior is not expected by the MathML code and we have had crashes
in our test suite in the past on Windows (e.g. bug 140653). We thus replace the call to
GlyphData::isValid() with a stronger verification: Whether the 'font' pointer is nonzero.

No new tests, this only makes null pointer checks stronger.

• rendering/mathml/MathOperator.cpp:

(WebCore::boundsForGlyph):
(WebCore::advanceWidthForGlyph):
(WebCore::MathOperator::getBaseGlyph):
(WebCore::MathOperator::setSizeVariant):
(WebCore::MathOperator::fillWithVerticalExtensionGlyph):
(WebCore::MathOperator::fillWithHorizontalExtensionGlyph):
(WebCore::MathOperator::paintVerticalGlyphAssembly):
(WebCore::MathOperator::paintHorizontalGlyphAssembly):
(WebCore::MathOperator::paint):

• rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::computePreferredLogicalWidths):

• rendering/mathml/RenderMathMLToken.cpp:

(WebCore::RenderMathMLToken::computePreferredLogicalWidths):
(WebCore::RenderMathMLToken::firstLineBaseline):
(WebCore::RenderMathMLToken::layoutBlock):
(WebCore::RenderMathMLToken::paint):
(WebCore::RenderMathMLToken::paintChildren):

9:51 AM Changeset in webkit [203279] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Add DejaVu Math TeX Gyre to the list of math fonts.
​https://bugs.webkit.org/show_bug.cgi?id=159805

Patch by Frederic Wang <​fwang@igalia.com> on 2016-07-15
Reviewed by Brent Fulgham.

DejaVu 2.36 has a new math font that can be used for MathML rendering. Because this font is
likely to be installed on many systems (Linux, LibreOffice, etc) we include it in the default
list of font-families in mathml.css in order to increase the chance to find a math font.

No new tests, it only affects rendering when DejaVu Math TeX Gyre is installed on the system.

• css/mathml.css:

(math):

9:48 AM Changeset in webkit [203278] by commit-queue@webkit.org

• 3 edits
  41 adds in trunk/LayoutTests

Import more tests from the MathML in HTML5 test suite
​https://bugs.webkit.org/show_bug.cgi?id=159715

Patch by Frederic Wang <​fwang@igalia.com> on 2016-07-15
Reviewed by Brent Fulgham.

• imported/mathml-in-html5/fonts/math/lineheight5000-typolineheight2300.woff: Added.
• imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-5-expected.txt: Added.
• imported/mathml-in-html5/mathml/presentation-markup/scripts/subsup-5.html: Added.
• imported/mathml-in-html5/mathml/presentation-markup/spaces/space-1-expected.txt: Added.
• imported/mathml-in-html5/mathml/presentation-markup/spaces/space-1.html: Added.
• imported/mathml-in-html5/mathml/presentation-markup/spaces/space-2-expected.html: Added.
• imported/mathml-in-html5/mathml/presentation-markup/spaces/space-2.html: Added.
• imported/mathml-in-html5/mathml/relations/css-styling/color-1-expected.html: Added.
• imported/mathml-in-html5/mathml/relations/css-styling/color-1.html: Added.
• imported/mathml-in-html5/mathml/relations/css-styling/visibility-1-expected.html: Added.
• imported/mathml-in-html5/mathml/relations/css-styling/visibility-1.html: Added.
• imported/mathml-in-html5/mathml/relations/html5-tree/class-1-expected.html: Added.
• imported/mathml-in-html5/mathml/relations/html5-tree/class-1.html: Added.
• imported/mathml-in-html5/mathml/relations/html5-tree/class-2-expected.txt: Added.
• imported/mathml-in-html5/mathml/relations/html5-tree/class-2.html: Added.
• imported/mathml-in-html5/mathml/relations/html5-tree/color-attributes-1-expected.html: Added.
• imported/mathml-in-html5/mathml/relations/html5-tree/color-attributes-1.html: Added.
• imported/mathml-in-html5/mathml/relations/html5-tree/display-1-expected.txt: Added.
• imported/mathml-in-html5/mathml/relations/html5-tree/display-1.html: Added.
• imported/mathml-in-html5/mathml/relations/html5-tree/dynamic-1-expected.html: Added.
• imported/mathml-in-html5/mathml/relations/html5-tree/dynamic-1.html: Added.
• imported/mathml-in-html5/mathml/relations/html5-tree/integration-point-1-expected.html: Added.
• imported/mathml-in-html5/mathml/relations/html5-tree/integration-point-1.html: Added.
• imported/mathml-in-html5/mathml/relations/html5-tree/integration-point-2-expected.html: Added.
• imported/mathml-in-html5/mathml/relations/html5-tree/integration-point-2.html: Added.
• imported/mathml-in-html5/mathml/relations/html5-tree/integration-point-3-expected.html: Added.
• imported/mathml-in-html5/mathml/relations/html5-tree/integration-point-3.html: Added.
• imported/mathml-in-html5/mathml/relations/html5-tree/namespace-1-expected.txt: Added.
• imported/mathml-in-html5/mathml/relations/html5-tree/namespace-1.html: Added.
• imported/mathml-in-html5/mathml/relations/html5-tree/required-extensions-1-expected.txt: Added.
• imported/mathml-in-html5/mathml/relations/html5-tree/required-extensions-1.html: Added.
• imported/mathml-in-html5/mathml/relations/html5-tree/required-extensions-2-expected.html: Added.
• imported/mathml-in-html5/mathml/relations/html5-tree/required-extensions-2.html: Added.
• imported/mathml-in-html5/mathml/relations/html5-tree/unique-identifier-2-expected.txt: Added.
• imported/mathml-in-html5/mathml/relations/html5-tree/unique-identifier-2.html: Added.
• imported/mathml-in-html5/mathml/relations/html5-tree/unique-identifier-3-expected.html: Added.
• imported/mathml-in-html5/mathml/relations/html5-tree/unique-identifier-3.html: Added.
• imported/mathml-in-html5/mathml/relations/text-and-math/use-typo-metrics-1-expected.html: Added.
• imported/mathml-in-html5/mathml/relations/text-and-math/use-typo-metrics-1.html: Added.
• platform/ios-simulator/TestExpectations: Mark use-typo-metrics-1.html as failing.
• platform/mac/TestExpectations: Ditto.

9:42 AM Changeset in webkit [203277] by eric.carlson@apple.com

• 5 edits in trunk

[MSE] Increase the SourceBuffer "fudge factor"
​https://bugs.webkit.org/show_bug.cgi?id=159813
<rdar://problem/27372033>

Reviewed by Jon Lee.
Source/WebCore:

Some media encoding/conversion pipelines are sloppy when doing sample time/timescale
math, and the error accumulation results in small gaps in the media timeline. r202641
increased the maximum allowable gap from 0.01 second to one 24fps frame, but it turns
out that at least one large provider has a significant amount of content encoded with
up to two 24fps frames.

No new tests, updated media/media-source/media-source-small-gap.html.

• Modules/mediasource/SourceBuffer.cpp:

(WebCore::currentTimeFudgeFactor): Increase maximum gap to 2002 / 24000 frames.

LayoutTests:

• media/media-source/media-source-small-gap-expected.txt:
• media/media-source/media-source-small-gap.html:

9:11 AM MathML edited by fred.wang@free.fr

(diff)

9:06 AM MathML/Fonts edited by fred.wang@free.fr

Add DejaVu font (diff)

7:52 AM Changeset in webkit [203276] by Csaba Osztrogonác

• 2 edits in trunk/Source/JavaScriptCore

Fix expectations in test262.yaml
​https://bugs.webkit.org/show_bug.cgi?id=159810

Reviewed by Keith Miller.

• tests/test262.yaml:

5:46 AM Changeset in webkit [203275] by commit-queue@webkit.org

• 53 edits in trunk/Source/WebCore

Add final keyword to WebCore/svg classes
​https://bugs.webkit.org/show_bug.cgi?id=159802

Patch by Rawinder Singh <​rawinder.singh-webkit@cisra.canon.com.au> on 2016-07-15
Reviewed by Youenn Fablet.

Updated classes in the WebCore/svg directory to be marked as final where appropriate.

• svg/SVGException.h:
• svg/SVGLengthList.h:
• svg/SVGMatrix.h:
• svg/SVGNumberList.h:
• svg/SVGPaint.h:
• svg/SVGPathBuilder.h:
• svg/SVGPathByteStreamBuilder.h:
• svg/SVGPathByteStreamSource.h:
• svg/SVGPathSegArcAbs.h:
• svg/SVGPathSegArcRel.h:
• svg/SVGPathSegClosePath.h:
• svg/SVGPathSegCurvetoCubicAbs.h:
• svg/SVGPathSegCurvetoCubicRel.h:
• svg/SVGPathSegCurvetoCubicSmoothAbs.h:
• svg/SVGPathSegCurvetoCubicSmoothRel.h:
• svg/SVGPathSegCurvetoQuadraticAbs.h:
• svg/SVGPathSegCurvetoQuadraticRel.h:
• svg/SVGPathSegCurvetoQuadraticSmoothAbs.h:
• svg/SVGPathSegCurvetoQuadraticSmoothRel.h:
• svg/SVGPathSegLinetoAbs.h:
• svg/SVGPathSegLinetoHorizontalAbs.h:
• svg/SVGPathSegLinetoHorizontalRel.h:
• svg/SVGPathSegLinetoRel.h:
• svg/SVGPathSegLinetoVerticalAbs.h:
• svg/SVGPathSegLinetoVerticalRel.h:
• svg/SVGPathSegListBuilder.h:
• svg/SVGPathSegListSource.h:
• svg/SVGPathSegMovetoAbs.h:
• svg/SVGPathSegMovetoRel.h:
• svg/SVGPathStringSource.h:
• svg/SVGPathTraversalStateBuilder.h:
• svg/SVGPointList.h:
• svg/SVGRenderingIntent.h:
• svg/SVGStringList.h:
• svg/SVGTRefElement.cpp:
• svg/SVGToOTFFontConversion.cpp:
• svg/SVGTransformList.h:
• svg/SVGUnitTypes.h:
• svg/SVGViewSpec.h:
• svg/SVGZoomEvent.h:
• svg/animation/SMILTimeContainer.h:
• svg/animation/SVGSMILElement.cpp:
• svg/graphics/filters/SVGFEImage.h:
• svg/graphics/filters/SVGFilter.h:
• svg/properties/SVGAnimatedPathSegListPropertyTearOff.h:
• svg/properties/SVGAnimatedPropertyTearOff.h:
• svg/properties/SVGAnimatedTransformListPropertyTearOff.h:
• svg/properties/SVGMatrixTearOff.h:
• svg/properties/SVGPathSegListPropertyTearOff.h:
• svg/properties/SVGStaticListPropertyTearOff.h:
• svg/properties/SVGStaticPropertyTearOff.h:
• svg/properties/SVGTransformListPropertyTearOff.h:

5:38 AM Changeset in webkit [203274] by pvollan@apple.com

• 5 edits
  1 add in trunk

Uninitialized variable in DIBPixelData can cause a dangerous memory write
​https://bugs.webkit.org/show_bug.cgi?id=159414

Reviewed by Brent Fulgham.

Source/WebCore:

Initialize local BITMAP variable, in case the ::GetObject function that should initialize it
fails to do so, because the bitmap handle is invalid.

Tests: Tools/TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp

• platform/graphics/win/DIBPixelData.cpp:

(WebCore::DIBPixelData::initialize): Initialize local variable.
(WebCore::DIBPixelData::setRGBABitmapAlpha): Return early if we have no bitmap.

• platform/graphics/win/DIBPixelData.h: Link fix.

Tools:

Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
when the HDC parameter is invalid.

• TestWebKitAPI/PlatformWin.cmake:
• TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.

(TestWebKitAPI::TEST):

3:21 AM Changeset in webkit [203273] by Csaba Osztrogonác

• 2 edits in trunk/Source/WTF

Revert r202560 to fix the ARMv7 build with ARM instruction set
​https://bugs.webkit.org/show_bug.cgi?id=159707

Reviewed by Carlos Garcia Campos.

• wtf/Platform.h: Revert r202560.

2:43 AM Changeset in webkit [203272] by Csaba Osztrogonác

• 2 edits in trunk/Source/JavaScriptCore

[ARM] Disable Inline Caching on ARMv7 traditional until proper fix
​https://bugs.webkit.org/show_bug.cgi?id=159759

Reviewed by Saam Barati.

• jit/Repatch.cpp:

(JSC::forceICFailure):

2:25 AM Changeset in webkit [203271] by Carlos Garcia Campos

• 5 edits
  1 copy
  1 add in trunk/Tools

[GTK] Add basic tabs support to MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=159803

Reviewed by Sergio Villar Senin.

It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.

• MiniBrowser/gtk/BrowserTab.c: Added.

(titleChanged):
(isLoadingChanged):
(decidePolicy):
(removeChildIfInfoBar):
(loadChanged):
(createInfoBarQuestionMessage):
(tlsErrorsDialogResponse):
(loadFailedWithTLSerrors):
(permissionRequestDialogResponse):
(decidePermissionRequest):
(colorChooserRGBAChanged):
(popoverColorClosed):
(colorChooserRequestFinished):
(runColorChooserCallback):
(inspectorOpenedInWindow):
(inspectorClosed):
(browserTabSetProperty):
(browserTabFinalize):
(browser_tab_init):
(browserTabConstructed):
(browser_tab_class_init):
(getInternalURI):
(browser_tab_new):
(browser_tab_get_web_view):
(browser_tab_load_uri):
(browser_tab_get_title_widget):
(browser_tab_set_status_text):
(browser_tab_toggle_inspector):
(browser_tab_start_search):
(browser_tab_stop_search):
(browser_tab_add_accelerators):
(fullScreenMessageTimeoutCallback):
(browser_tab_enter_fullscreen):
(browser_tab_leave_fullscreen):

• MiniBrowser/gtk/BrowserTab.h: Added.
• MiniBrowser/gtk/BrowserWindow.c:

(getExternalURI):
(browserWindowSetStatusText):
(reloadOrStopCallback):
(goBackCallback):
(goForwardCallback):
(settingsCallback):
(webViewURIChanged):
(browserWindowHistoryItemActivated):
(browserWindowUpdateNavigationActions):
(webViewCreate):
(webViewEnterFullScreen):
(webViewLeaveFullScreen):
(webViewDecidePolicy):
(browserWindowCanZoomIn):
(browserWindowCanZoomOut):
(browserWindowZoomIn):
(browserWindowZoomOut):
(scrollEventCallback):
(faviconChanged):
(webViewIsLoadingChanged):
(defaultZoomCallback):
(searchCallback):
(newTabCallback):
(toggleWebInspector):
(reloadPage):
(reloadPageIgnoringCache):
(stopPageLoad):
(loadHomePage):
(editingCommandCallback):
(insertImageCommandCallback):
(insertLinkCommandCallback):
(browserWindowSetupEditorToolbar):
(browserWindowSwitchTab):
(browserWindowTabAddedOrRemoved):
(browser_window_init):
(browserWindowConstructed):
(browserWindowSaveSession):
(browserWindowDeleteEvent):
(browser_window_new):
(browser_window_append_view):
(browser_window_load_uri):
(browser_window_load_session):
(browser_window_set_background_color):
(resetStatusText): Deleted.
(activateUriEntryCallback): Deleted.
(webViewTitleChanged): Deleted.
(resetEntryProgress): Deleted.
(browserWindowCreateBackForwardMenu): Deleted.
(webViewReadyToShow): Deleted.
(webViewLoadFailed): Deleted.
(webViewMouseTargetChanged): Deleted.
(browserWindowUpdateZoomActions): Deleted.
(webViewZoomLevelChanged): Deleted.
(updateUriEntryIcon): Deleted.
(zoomInCallback): Deleted.
(zoomOutCallback): Deleted.
(toggleFullScreen): Deleted.
(browserWindowEditingCommandToggleButtonSetActive): Deleted.
(browserWindowFinalize): Deleted.
(browser_window_class_init): Deleted.

• MiniBrowser/gtk/BrowserWindow.h:
• MiniBrowser/gtk/CMakeLists.txt:
• MiniBrowser/gtk/main.c:

(createBrowserTab):
(aboutURISchemeRequestCallback):
(main):
(parseBackgroundColor): Deleted.