⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 3, 2016:

11:53 PM Changeset in webkit [204116] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

LayoutTest imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-post-upload.htm failing
https://bugs.webkit.org/show_bug.cgi?id=159724

Unreviewed..

Patch by Youenn Fablet <youenn@apple.com> on 2016-08-04

  • TestExpectations: Removing Crash expectation since it is only occuring on Debug Mac bots.
  • platform/mac/TestExpectations: Skipping test in Debug for Mac bots.
10:26 PM Changeset in webkit [204115] by Chris Dumez
  • 6 edits in trunk

Object.getOwnPropertyNames() on NamedNodeMap fails to return named properties
https://bugs.webkit.org/show_bug.cgi?id=160517

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline several W3C tests now that more checks are passing.

  • web-platform-tests/dom/collections/namednodemap-supported-property-names-expected.txt:
  • web-platform-tests/dom/nodes/attributes-expected.txt:

Source/WebCore:

Object.getOwnPropertyNames() on NamedNodeMap should return named
properties' names as per:

No new tests, rebaselined existing tests.

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::supportedPropertyNames):

  • dom/NamedNodeMap.h:
10:11 PM Changeset in webkit [204114] by Chris Dumez
  • 15 edits in trunk

Drop DocumentType.internalSubset attribute
https://bugs.webkit.org/show_bug.cgi?id=160530

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline W3C test now that one more check is passing.

  • web-platform-tests/dom/historical-expected.txt:

Source/JavaScriptCore:

Drop DocumentType.internalSubset attribute.

  • inspector/protocol/DOM.json:

Source/WebCore:

Drop DocumentType.internalSubset attribute.

It is no longer in the DOM specification:

Other browsers have already dropped it. In WebKit, it was always null
anyway.

No new tests, rebaselined existing test.

  • bindings/objc/DOMDocumentType.mm:

(-[DOMDocumentType internalSubset]):

  • dom/DocumentType.h:
  • dom/DocumentType.idl:
  • dom/Node.cpp:

(WebCore::Node::isEqualNode): Deleted.

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendDocumentType): Deleted.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForNode): Deleted.

Source/WebInspectorUI:

Drop DocumentType.internalSubset attribute.

  • UserInterface/Models/DOMNode.js:

(WebInspector.DOMNode): Deleted.

  • UserInterface/Models/DOMSearchMatchObject.js:

(WebInspector.DOMSearchMatchObject.titleForDOMNode): Deleted.

  • UserInterface/Views/DOMTreeElement.js:

(WebInspector.DOMTreeElement.prototype._nodeTitleInfo): Deleted.

10:09 PM Changeset in webkit [204113] by Chris Dumez
  • 10 edits
    2 deletes in trunk

Drop legacy Document.defaultCharset attribute
https://bugs.webkit.org/show_bug.cgi?id=160536

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline W3C test now that one more check is passing.

  • web-platform-tests/dom/historical-expected.txt:

Source/WebCore:

Drop legacy Document.defaultCharset attribute.

It is no longer in the specification:

Firefox and Chrome have already dropped it.

No new tests, rebaselined existing test.

  • bindings/objc/DOMDocument.mm:

(-[DOMDocument defaultCharset]):

  • dom/Document.cpp:

(WebCore::Document::defaultCharsetForBindings):

  • dom/Document.h:
  • dom/Document.idl:

LayoutTests:

  • fast/dom/Document/document-charset-expected.txt:
  • fast/dom/Document/document-charset.html:

Drop defaultCharset checks.

  • fast/frames/detached-frame-document-defaultCharset-expected.txt: Removed.
  • fast/frames/detached-frame-document-defaultCharset.html: Removed.

Drop test that is no longer useful now that we dropped defaultCharset.

8:43 PM Changeset in webkit [204112] by commit-queue@webkit.org
  • 8 edits in trunk/Source/JavaScriptCore

[JSC] Improve the memory locality of DFG Node's AbstractValues
https://bugs.webkit.org/show_bug.cgi?id=160443

Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-08-03
Reviewed by Mark Lam.

The AbstractInterpreter spends a lot of time on memory operations
for AbstractValues. This patch attempts to improve the situation
by putting the values closer together in memory.

First, AbstractValue is moved out of DFG::Node and it kept in
a vector addressed by node indices.

I initially moved them to InPlaceAbstractState but I quickly discovered
initializing the values in the vector was costly.
I moved the vector to Graph as a cache shared by every instantiation of
InPlaceAbstractState. It is mainly there to avoid constructors and destructors
of AbstractValue. The patch of https://bugs.webkit.org/show_bug.cgi?id=160370
should also help eventually.

I instrumented CFA to find how packed is SparseCollection.
The answer is it can be very sparse, which is bad for CFA.
I added packIndices() to repack the collection before running
liveness since that's where we start using the memory intensively.
This is a measurable improvement but it implies we can no longer
keep indices on a side channel between phases since they may change.

  • b3/B3SparseCollection.h:

(JSC::B3::SparseCollection::packIndices):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::packNodeIndices):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::abstractValuesCache):

  • dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::InPlaceAbstractState):

  • dfg/DFGInPlaceAbstractState.h:

(JSC::DFG::InPlaceAbstractState::forNode):

  • dfg/DFGLivenessAnalysisPhase.cpp:

(JSC::DFG::performLivenessAnalysis):

  • dfg/DFGNode.h:
7:36 PM Changeset in webkit [204111] by caitp@igalia.com
  • 7 edits in trunk

Clarify SyntaxErrors around yield and unskip tests
https://bugs.webkit.org/show_bug.cgi?id=158460

Reviewed by Saam Barati.

Fix and unskip tests which erroneously asserted that yield is not a
valid BindingIdentifier, and improve error message for YieldExpressions
occuring in Arrow formal parameters.

JSTests:

  • stress/generator-syntax.js:
  • stress/yield-out-of-generator.js:

Source/JavaScriptCore:

  • parser/Parser.cpp:

(JSC::Scope::MaybeParseAsGeneratorForScope::MaybeParseAsGeneratorForScope):
(JSC::Parser<LexerType>::parseFunctionInfo):
(JSC::Parser<LexerType>::parseYieldExpression):

  • parser/Parser.h:
6:38 PM Changeset in webkit [204110] by bshafiei@apple.com
  • 5 edits in branches/safari-602-branch/Source

Versioning.

6:27 PM Changeset in webkit [204109] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Marking media/track/track-in-band-cues-added-once.html as flaky on ios-simulator.
https://bugs.webkit.org/show_bug.cgi?id=142152

Unreviewed test gardening.

  • platform/ios-simulator-wk2/TestExpectations:
5:00 PM Changeset in webkit [204108] by andersca@apple.com
  • 21 edits
    2 deletes in trunk/Source/WebCore

Remove some unneeded #ifs now that the Objective-C bindings are frozen
https://bugs.webkit.org/show_bug.cgi?id=160532

Reviewed by Tim Horton.

  • DerivedSources.make:
  • Modules/mediasession/HTMLMediaElementMediaSession.idl:
  • Modules/mediastream/HTMLMediaElementMediaStream.idl:
  • WebCore.xcodeproj/project.pbxproj:
  • animation/DocumentAnimation.idl:
  • dom/ChildNode.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Event.idl:
  • dom/ParentNode.idl:
  • fileapi/Blob.idl:
  • fileapi/FileError.idl:
  • html/DOMSettableTokenList.h: Removed.
  • html/DOMSettableTokenList.idl: Removed.
  • html/HTMLCanvasElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLVideoElement.idl:
4:50 PM Changeset in webkit [204107] by mmaxfield@apple.com
  • 5 edits
    1 add in trunk

[iOS] SF-Heavy is not accessible from web content
https://bugs.webkit.org/show_bug.cgi?id=160522
<rdar://problem/27685273>

Reviewed by Simon Fraser.

Source/WebCore:

The mappings we were using from CSS font-weight to CoreText font weight were inaccurate.
Instead, these new mappings should be used.

Test: fast/text/system-font-weight.html

  • platform/graphics/ios/FontCacheIOS.mm:

(WebCore::systemFontModificationAttributes):

LayoutTests:

  • platform/ios-simulator/fast/text/system-font-weight-expected.txt: iOS 9 is not

expected to pass this test, but there is no way to specify that currently using
TestExpectations. Instead, we can create an iOS 9 specific result.

  • fast/text/system-font-weight-expected.txt:
  • fast/text/system-font-weight.html:
4:44 PM LayoutTestDashboards edited by aakash_jain@apple.com
(diff)
4:41 PM Changeset in webkit [204106] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.47

New tag.

4:25 PM Changeset in webkit [204105] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

Document instructions for increasing process and file limits
https://bugs.webkit.org/show_bug.cgi?id=160528
rdar://problem/24777576

Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort.default_child_processes):

3:53 PM Changeset in webkit [204104] by andersca@apple.com
  • 5 edits
    3 deletes in trunk

Remove the Objective-C bindings generator
https://bugs.webkit.org/show_bug.cgi?id=160526

Reviewed by Sam Weinig.

Source/WebCore:

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/PublicDOMInterfaces.h: Removed.
  • bindings/scripts/CodeGeneratorObjC.pm: Removed.
  • bindings/scripts/test/ObjC/DOMFloat64Array.h: Removed.
  • bindings/scripts/test/ObjC/DOMFloat64Array.mm: Removed.
  • bindings/scripts/test/ObjC/DOMFloat64ArrayInternal.h: Removed.
  • bindings/scripts/test/ObjC/DOMInterfaceName.h: Removed.
  • bindings/scripts/test/ObjC/DOMInterfaceName.mm: Removed.
  • bindings/scripts/test/ObjC/DOMInterfaceNameInternal.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestActiveDOMObject.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestActiveDOMObject.mm: Removed.
  • bindings/scripts/test/ObjC/DOMTestActiveDOMObjectInternal.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestCallback.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestCallback.mm: Removed.
  • bindings/scripts/test/ObjC/DOMTestCallbackFunction.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestCallbackFunction.mm: Removed.
  • bindings/scripts/test/ObjC/DOMTestCallbackFunctionInternal.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestCallbackInternal.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestClassWithJSBuiltinConstructor.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestClassWithJSBuiltinConstructor.mm: Removed.
  • bindings/scripts/test/ObjC/DOMTestClassWithJSBuiltinConstructorInternal.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestCustomConstructorWithNoInterfaceObject.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestCustomConstructorWithNoInterfaceObject.mm: Removed.
  • bindings/scripts/test/ObjC/DOMTestCustomConstructorWithNoInterfaceObjectInternal.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestCustomNamedGetter.mm: Removed.
  • bindings/scripts/test/ObjC/DOMTestCustomNamedGetterInternal.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestEventConstructor.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestEventConstructor.mm: Removed.
  • bindings/scripts/test/ObjC/DOMTestEventConstructorInternal.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestEventTarget.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestEventTarget.mm: Removed.
  • bindings/scripts/test/ObjC/DOMTestEventTargetInternal.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestException.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestException.mm: Removed.
  • bindings/scripts/test/ObjC/DOMTestExceptionInternal.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestGenerateIsReachable.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestGenerateIsReachable.mm: Removed.
  • bindings/scripts/test/ObjC/DOMTestGenerateIsReachableInternal.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestGlobalObject.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestGlobalObject.mm: Removed.
  • bindings/scripts/test/ObjC/DOMTestGlobalObjectInternal.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestImplements.cpp: Removed.
  • bindings/scripts/test/ObjC/DOMTestImplements.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestInterface.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestInterface.mm: Removed.
  • bindings/scripts/test/ObjC/DOMTestInterfaceInternal.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestIterable.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestIterable.mm: Removed.
  • bindings/scripts/test/ObjC/DOMTestIterableInternal.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestJSBuiltinConstructor.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestJSBuiltinConstructor.mm: Removed.
  • bindings/scripts/test/ObjC/DOMTestJSBuiltinConstructorInternal.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestMediaQueryListListener.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestMediaQueryListListener.mm: Removed.
  • bindings/scripts/test/ObjC/DOMTestMediaQueryListListenerInternal.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestNamedConstructor.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestNamedConstructor.mm: Removed.
  • bindings/scripts/test/ObjC/DOMTestNamedConstructorInternal.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestNode.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestNode.mm: Removed.
  • bindings/scripts/test/ObjC/DOMTestNodeInternal.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestNondeterministic.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestNondeterministic.mm: Removed.
  • bindings/scripts/test/ObjC/DOMTestNondeterministicInternal.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestObj.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestObj.mm: Removed.
  • bindings/scripts/test/ObjC/DOMTestObjInternal.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestOverloadedConstructors.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestOverloadedConstructors.mm: Removed.
  • bindings/scripts/test/ObjC/DOMTestOverloadedConstructorsInternal.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestOverrideBuiltins.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestOverrideBuiltins.mm: Removed.
  • bindings/scripts/test/ObjC/DOMTestOverrideBuiltinsInternal.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm: Removed.
  • bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterfaceInternal.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestSupplemental.cpp: Removed.
  • bindings/scripts/test/ObjC/DOMTestSupplemental.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestTypedefs.h: Removed.
  • bindings/scripts/test/ObjC/DOMTestTypedefs.mm: Removed.
  • bindings/scripts/test/ObjC/DOMTestTypedefsInternal.h: Removed.
  • bindings/scripts/test/ObjC/DOMattribute.h: Removed.
  • bindings/scripts/test/ObjC/DOMattribute.mm: Removed.
  • bindings/scripts/test/ObjC/DOMattributeInternal.h: Removed.
  • bindings/scripts/test/ObjC/DOMreadonly.h: Removed.
  • bindings/scripts/test/ObjC/DOMreadonly.mm: Removed.
  • bindings/scripts/test/ObjC/DOMreadonlyInternal.h: Removed.
  • bindings/scripts/test/ObjC/ObjCTestSupplemental.cpp: Removed.
  • bindings/scripts/test/ObjC/ObjCTestSupplemental.h: Removed.

Tools:

  • Scripts/run-bindings-tests:

Update test.

3:46 PM IncreasingKernelLimits edited by aakash_jain@apple.com
(diff)
2:59 PM limit.maxproc.plist attached to IncreasingKernelLimits by aakash_jain@apple.com
2:59 PM limit.maxfiles.plist attached to IncreasingKernelLimits by aakash_jain@apple.com
2:55 PM IncreasingKernelLimits created by aakash_jain@apple.com
2:31 PM Changeset in webkit [204103] by andersca@apple.com
  • 136 edits
    58 deletes in trunk/Source/WebCore

Remove dead bindings code
https://bugs.webkit.org/show_bug.cgi?id=160521

Reviewed by Tim Horton.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMBlob.mm:

(core): Deleted.

  • bindings/objc/DOMBlobInternal.h:
  • bindings/objc/DOMCDATASection.mm:

(core): Deleted.

  • bindings/objc/DOMCDATASectionInternal.h:
  • bindings/objc/DOMCSSCharsetRule.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMCSSCharsetRuleInternal.h: Removed.
  • bindings/objc/DOMCSSFontFaceRule.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMCSSFontFaceRuleInternal.h: Removed.
  • bindings/objc/DOMCSSImportRule.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMCSSImportRuleInternal.h: Removed.
  • bindings/objc/DOMCSSMediaRule.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMCSSMediaRuleInternal.h: Removed.
  • bindings/objc/DOMCSSPageRule.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMCSSPageRuleInternal.h: Removed.
  • bindings/objc/DOMCSSPrimitiveValue.mm:

(core): Deleted.

  • bindings/objc/DOMCSSPrimitiveValueInternal.h:
  • bindings/objc/DOMCSSRule.mm:

(core): Deleted.

  • bindings/objc/DOMCSSRuleInternal.h:
  • bindings/objc/DOMCSSRuleList.mm:

(core): Deleted.

  • bindings/objc/DOMCSSRuleListInternal.h:
  • bindings/objc/DOMCSSStyleRule.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMCSSStyleRuleInternal.h: Removed.
  • bindings/objc/DOMCSSStyleSheet.mm:

(core): Deleted.

  • bindings/objc/DOMCSSStyleSheetInternal.h:
  • bindings/objc/DOMCSSUnknownRule.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMCSSUnknownRuleInternal.h: Removed.
  • bindings/objc/DOMCSSValue.mm:

(core): Deleted.

  • bindings/objc/DOMCSSValueInternal.h:
  • bindings/objc/DOMCSSValueList.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMCSSValueListInternal.h: Removed.
  • bindings/objc/DOMCharacterData.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMCharacterDataInternal.h: Removed.
  • bindings/objc/DOMComment.mm:

(core): Deleted.

  • bindings/objc/DOMCommentInternal.h:
  • bindings/objc/DOMCounter.mm:

(core): Deleted.

  • bindings/objc/DOMCounterInternal.h:
  • bindings/objc/DOMDOMImplementation.mm:

(core): Deleted.

  • bindings/objc/DOMDOMImplementationInternal.h:
  • bindings/objc/DOMDOMTokenList.mm:

(core): Deleted.

  • bindings/objc/DOMDOMTokenListInternal.h:
  • bindings/objc/DOMEntity.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMEntityInternal.h: Removed.
  • bindings/objc/DOMEntityReference.mm:

(core): Deleted.

  • bindings/objc/DOMEntityReferenceInternal.h:
  • bindings/objc/DOMFile.mm:

(core): Deleted.

  • bindings/objc/DOMFileInternal.h:
  • bindings/objc/DOMHTMLAnchorElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLAnchorElementInternal.h: Removed.
  • bindings/objc/DOMHTMLAppletElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLAppletElementInternal.h: Removed.
  • bindings/objc/DOMHTMLAreaElement.mm:

(kit): Deleted.

  • bindings/objc/DOMHTMLAreaElementInternal.h:
  • bindings/objc/DOMHTMLBRElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLBRElementInternal.h: Removed.
  • bindings/objc/DOMHTMLBaseElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLBaseElementInternal.h: Removed.
  • bindings/objc/DOMHTMLBaseFontElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLBaseFontElementInternal.h: Removed.
  • bindings/objc/DOMHTMLBodyElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLBodyElementInternal.h: Removed.
  • bindings/objc/DOMHTMLButtonElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLButtonElementInternal.h: Removed.
  • bindings/objc/DOMHTMLCanvasElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLCanvasElementInternal.h: Removed.
  • bindings/objc/DOMHTMLCollection.mm:

(core): Deleted.

  • bindings/objc/DOMHTMLCollectionInternal.h:
  • bindings/objc/DOMHTMLDListElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLDListElementInternal.h: Removed.
  • bindings/objc/DOMHTMLDirectoryElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLDirectoryElementInternal.h: Removed.
  • bindings/objc/DOMHTMLDivElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLDivElementInternal.h: Removed.
  • bindings/objc/DOMHTMLEmbedElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLEmbedElementInternal.h: Removed.
  • bindings/objc/DOMHTMLFieldSetElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLFieldSetElementInternal.h: Removed.
  • bindings/objc/DOMHTMLFontElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLFontElementInternal.h: Removed.
  • bindings/objc/DOMHTMLFormElement.mm:

(core): Deleted.

  • bindings/objc/DOMHTMLFormElementInternal.h:
  • bindings/objc/DOMHTMLFrameElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLFrameElementInternal.h: Removed.
  • bindings/objc/DOMHTMLFrameSetElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLFrameSetElementInternal.h: Removed.
  • bindings/objc/DOMHTMLHRElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLHRElementInternal.h: Removed.
  • bindings/objc/DOMHTMLHeadElement.mm:

(core): Deleted.

  • bindings/objc/DOMHTMLHeadElementInternal.h:
  • bindings/objc/DOMHTMLHeadingElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLHeadingElementInternal.h: Removed.
  • bindings/objc/DOMHTMLHtmlElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLHtmlElementInternal.h: Removed.
  • bindings/objc/DOMHTMLIFrameElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLIFrameElementInternal.h: Removed.
  • bindings/objc/DOMHTMLImageElement.mm:

(kit): Deleted.

  • bindings/objc/DOMHTMLImageElementInternal.h:
  • bindings/objc/DOMHTMLLIElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLLIElementInternal.h: Removed.
  • bindings/objc/DOMHTMLLabelElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLLabelElementInternal.h: Removed.
  • bindings/objc/DOMHTMLLegendElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLLegendElementInternal.h: Removed.
  • bindings/objc/DOMHTMLLinkElement.mm:

(kit): Deleted.

  • bindings/objc/DOMHTMLLinkElementInternal.h:
  • bindings/objc/DOMHTMLMapElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLMapElementInternal.h: Removed.
  • bindings/objc/DOMHTMLMarqueeElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLMarqueeElementInternal.h: Removed.
  • bindings/objc/DOMHTMLMediaElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLMediaElementInternal.h: Removed.
  • bindings/objc/DOMHTMLMenuElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLMenuElementInternal.h: Removed.
  • bindings/objc/DOMHTMLMetaElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLMetaElementInternal.h: Removed.
  • bindings/objc/DOMHTMLModElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLModElementInternal.h: Removed.
  • bindings/objc/DOMHTMLOListElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLOListElementInternal.h: Removed.
  • bindings/objc/DOMHTMLObjectElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLObjectElementInternal.h: Removed.
  • bindings/objc/DOMHTMLOptGroupElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLOptGroupElementInternal.h: Removed.
  • bindings/objc/DOMHTMLOptionsCollection.mm:

(core): Deleted.

  • bindings/objc/DOMHTMLOptionsCollectionInternal.h:
  • bindings/objc/DOMHTMLParagraphElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLParagraphElementInternal.h: Removed.
  • bindings/objc/DOMHTMLParamElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLParamElementInternal.h: Removed.
  • bindings/objc/DOMHTMLPreElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLPreElementInternal.h: Removed.
  • bindings/objc/DOMHTMLQuoteElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLQuoteElementInternal.h: Removed.
  • bindings/objc/DOMHTMLScriptElement.mm:

(core): Deleted.

  • bindings/objc/DOMHTMLScriptElementInternal.h:
  • bindings/objc/DOMHTMLSelectElement.mm:

(kit): Deleted.

  • bindings/objc/DOMHTMLSelectElementInternal.h:
  • bindings/objc/DOMHTMLStyleElement.mm:

(kit): Deleted.

  • bindings/objc/DOMHTMLStyleElementInternal.h:
  • bindings/objc/DOMHTMLTableColElement.mm:

(kit): Deleted.

  • bindings/objc/DOMHTMLTableColElementInternal.h:
  • bindings/objc/DOMHTMLTableElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLTableElementInternal.h: Removed.
  • bindings/objc/DOMHTMLTableRowElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLTableRowElementInternal.h: Removed.
  • bindings/objc/DOMHTMLTitleElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLTitleElementInternal.h: Removed.
  • bindings/objc/DOMHTMLUListElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLUListElementInternal.h: Removed.
  • bindings/objc/DOMHTMLVideoElement.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMHTMLVideoElementInternal.h: Removed.
  • bindings/objc/DOMKeyboardEvent.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMKeyboardEventInternal.h: Removed.
  • bindings/objc/DOMMediaError.mm:

(core): Deleted.

  • bindings/objc/DOMMediaErrorInternal.h:
  • bindings/objc/DOMMediaList.mm:

(core): Deleted.

  • bindings/objc/DOMMediaListInternal.h:
  • bindings/objc/DOMMouseEvent.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMMouseEventInternal.h: Removed.
  • bindings/objc/DOMMutationEvent.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMMutationEventInternal.h: Removed.
  • bindings/objc/DOMNamedNodeMap.mm:

(core): Deleted.

  • bindings/objc/DOMNamedNodeMapInternal.h:
  • bindings/objc/DOMNodeIterator.mm:

(core): Deleted.

  • bindings/objc/DOMNodeIteratorInternal.h:
  • bindings/objc/DOMNodeList.mm:

(core): Deleted.

  • bindings/objc/DOMNodeListInternal.h:
  • bindings/objc/DOMOverflowEvent.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMOverflowEventInternal.h: Removed.
  • bindings/objc/DOMProgressEvent.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMProgressEventInternal.h: Removed.
  • bindings/objc/DOMRGBColor.mm:

(core): Deleted.

  • bindings/objc/DOMRGBColorInternal.h:
  • bindings/objc/DOMRect.mm:

(core): Deleted.

  • bindings/objc/DOMRectInternal.h:
  • bindings/objc/DOMStyleSheet.mm:

(core): Deleted.

  • bindings/objc/DOMStyleSheetInternal.h:
  • bindings/objc/DOMStyleSheetList.mm:

(core): Deleted.

  • bindings/objc/DOMStyleSheetListInternal.h:
  • bindings/objc/DOMText.mm:

(core): Deleted.

  • bindings/objc/DOMTextEvent.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMTextEventInternal.h: Removed.
  • bindings/objc/DOMTextInternal.h:
  • bindings/objc/DOMTimeRanges.mm:

(core): Deleted.

  • bindings/objc/DOMTimeRangesInternal.h:
  • bindings/objc/DOMTreeWalker.mm:

(core): Deleted.

  • bindings/objc/DOMTreeWalkerInternal.h:
  • bindings/objc/DOMUIEvent.mm:

(core): Deleted.
(kit): Deleted.

  • bindings/objc/DOMUIEventInternal.h: Removed.
  • bindings/objc/DOMWheelEvent.mm:

(kit): Deleted.

  • bindings/objc/DOMWheelEventInternal.h:
  • bindings/objc/DOMXPathExpression.mm:

(core): Deleted.

  • bindings/objc/DOMXPathExpressionInternal.h:
2:08 PM Changeset in webkit [204102] by bshafiei@apple.com
  • 19 edits
    2 deletes in branches/safari-602-branch

Roll out r203982 via r204068. rdar://problem/27547583

2:08 PM Changeset in webkit [204101] by bshafiei@apple.com
  • 2 edits in branches/safari-602-branch/Source/WebCore

Roll out r204082 via r204086. rdar://problem/27547583

1:57 PM Changeset in webkit [204100] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] Work around AVPlayer setMuted bug
https://bugs.webkit.org/show_bug.cgi?id=160519
<rdar://problem/27310475>

Reviewed by Dean Jackson.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h: Only override

supportsMuting on iOS.

1:49 PM Changeset in webkit [204099] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Cmd-L shortcut for Jump to Line conflicts with selecting URL of inspected page
https://bugs.webkit.org/show_bug.cgi?id=158028
<rdar://problem/26516663>

Reviewed by Timothy Hatcher.

Remove Command-L shortcut for opening the Line Number dialog, since
we already support Control-G.

  • UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor): Deleted.

1:23 PM Changeset in webkit [204098] by mitz@apple.com
  • 8 copies
    1 add in releases/Apple/Safari Technology Preview 10

Added a tag for Safari Technology Preview release 10.

1:06 PM Changeset in webkit [204097] by Michael Catanzaro
  • 4 edits in trunk/Source/WebKit2

[SOUP] Deduplicate WebProcessPool::setIgnoreTLSErrors
https://bugs.webkit.org/show_bug.cgi?id=160489

Reviewed by Alex Christensen.

WebProcessPool::setIgnoreTLSErrors has identical implementation in WebProcessPoolEfl.cpp
and WebProcessPoolGtk.cpp. We have WebProcessPoolSoup.cpp and this function is specific to
the soup network backend, so move it there.

  • UIProcess/efl/WebProcessPoolEfl.cpp:

(WebKit::WebProcessPool::setIgnoreTLSErrors): Deleted.

  • UIProcess/gtk/WebProcessPoolGtk.cpp:

(WebKit::WebProcessPool::setIgnoreTLSErrors): Deleted.

  • UIProcess/soup/WebProcessPoolSoup.cpp:

(WebKit::WebProcessPool::setIgnoreTLSErrors):

12:40 PM Changeset in webkit [204096] by Ryan Haddad
  • 11 edits
    1 copy
    1 delete in trunk/LayoutTests

Unreviewed test gardening.

  • platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt:
  • platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt:
  • platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-checkValidity-expected.txt:
  • platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt:
  • platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt:
  • platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt:
  • platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-stepMismatch-expected.txt:
  • platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt:
  • platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt:
  • platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt: Renamed from LayoutTests/platform/ios-simulator-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt.
  • platform/ios-simulator/imported/w3c/web-platform-tests/html/semantics/forms/form-control-infrastructure/form-expected.txt:
12:10 PM Changeset in webkit [204095] by bshafiei@apple.com
  • 4 edits
    2 adds in branches/safari-602-branch

Merge r204074. rdar://problem/25856238

12:10 PM Changeset in webkit [204094] by bshafiei@apple.com
  • 3 edits in branches/safari-602-branch/Source/WebCore

Merge r204089. rdar://problem/27313234

11:50 AM Changeset in webkit [204093] by fpizlo@apple.com
  • 4 edits
    1 add in trunk

REGRESSION(r203368): broke some test262 tests
https://bugs.webkit.org/show_bug.cgi?id=160479

Reviewed by Mark Lam.

JSTests:

Added a stress test for this case, since we don't always run test262.

  • stress/freeze-setter.js: Added.

(let.o.set foo):

Source/JavaScriptCore:

The optimization in r203368 overlooked a subtle detail: freezing should not set ReadOnly on
Accessor properties.

  • runtime/Structure.cpp:

(JSC::Structure::nonPropertyTransition):

  • runtime/StructureTransitionTable.h:

(JSC::setsDontDeleteOnAllProperties):
(JSC::setsReadOnlyOnNonAccessorProperties):
(JSC::setsReadOnlyOnAllProperties): Deleted.

11:44 AM Changeset in webkit [204092] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

Revise a TestWebKitAPI comment to mention the actual underlying problem

  • TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:

Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516

11:43 AM Changeset in webkit [204091] by ggaren@apple.com
  • 4 edits in trunk/Source/bmalloc

[bmalloc] Merging of XLargeRanges can leak the upper range
https://bugs.webkit.org/show_bug.cgi?id=160403

Reviewed by Michael Saboff.

  • bmalloc/Heap.cpp:

(bmalloc::Heap::scavengeLargeObjects): Don't use removePhysical().
Recorded physical size is a performance optimization. It is not the
truth. So it might be zero even if a range contains physical pages.

Instead, iterate each range in the map unconditionally.

The map can shrink when we release the lock, so we must clamp our
iterator each time through the loop.

The map can grow when we release the lock, but we don't care because
growth restarts the scavenger from the beginning.

  • bmalloc/XLargeMap.cpp:

(bmalloc::XLargeMap::removePhysical): Deleted. Not used anymore.

  • bmalloc/XLargeMap.h:

(bmalloc::XLargeMap::ranges): Added direct access for the sake of
scavengeLargeObjects. (This violates our naming conventions -- I'll do
a rename in a follow-up patch.)

11:35 AM Changeset in webkit [204090] by Chris Dumez
  • 230 edits in trunk/LayoutTests

Fix logging in W3C tests
https://bugs.webkit.org/show_bug.cgi?id=160513

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline W3C tests.

  • web-platform-tests/XMLHttpRequest/open-url-about-blank-window-expected.txt:
  • web-platform-tests/XMLHttpRequest/open-url-javascript-window-2-expected.txt:
  • web-platform-tests/XMLHttpRequest/open-url-javascript-window-expected.txt:
  • web-platform-tests/XMLHttpRequest/open-url-multi-window-4-expected.txt:
  • web-platform-tests/XMLHttpRequest/open-url-multi-window-5-expected.txt:
  • web-platform-tests/XMLHttpRequest/open-url-multi-window-expected.txt:
  • web-platform-tests/XMLHttpRequest/send-content-type-string-expected.txt:
  • web-platform-tests/dom/collections/domstringmap-supported-property-names-expected.txt:
  • web-platform-tests/dom/collections/namednodemap-supported-property-names-expected.txt:
  • web-platform-tests/dom/nodes/Comment-constructor-expected.txt:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_bmp-expected.txt:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_css-expected.txt:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_01-expected.txt:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_02-expected.txt:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_gif-expected.txt:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_html-expected.txt:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_javascripturi-expected.txt:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_jpg-expected.txt:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_mimeheader_01-expected.txt:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_mimeheader_02-expected.txt:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_png-expected.txt:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_txt-expected.txt:
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_xml-expected.txt:
  • web-platform-tests/dom/nodes/Document-createElement-namespace-expected.txt:
  • web-platform-tests/dom/nodes/Element-childElement-null-expected.txt:
  • web-platform-tests/dom/nodes/Element-childElement-null-xhtml-expected.txt:
  • web-platform-tests/dom/nodes/Element-childElementCount-dynamic-add-expected.txt:
  • web-platform-tests/dom/nodes/Element-childElementCount-dynamic-add-xhtml-expected.txt:
  • web-platform-tests/dom/nodes/Element-childElementCount-dynamic-remove-expected.txt:
  • web-platform-tests/dom/nodes/Element-childElementCount-dynamic-remove-xhtml-expected.txt:
  • web-platform-tests/dom/nodes/Element-childElementCount-expected.txt:
  • web-platform-tests/dom/nodes/Element-childElementCount-nochild-expected.txt:
  • web-platform-tests/dom/nodes/Element-childElementCount-nochild-xhtml-expected.txt:
  • web-platform-tests/dom/nodes/Element-childElementCount-xhtml-expected.txt:
  • web-platform-tests/dom/nodes/Element-children-expected.txt:
  • web-platform-tests/dom/nodes/Element-firstElementChild-entity-xhtml-expected.txt:
  • web-platform-tests/dom/nodes/Element-firstElementChild-expected.txt:
  • web-platform-tests/dom/nodes/Element-firstElementChild-namespace-expected.txt:
  • web-platform-tests/dom/nodes/Element-firstElementChild-namespace-xhtml-expected.txt:
  • web-platform-tests/dom/nodes/Element-firstElementChild-xhtml-expected.txt:
  • web-platform-tests/dom/nodes/Element-insertAdjacentElement-expected.txt:
  • web-platform-tests/dom/nodes/Element-insertAdjacentText-expected.txt:
  • web-platform-tests/dom/nodes/Element-lastElementChild-expected.txt:
  • web-platform-tests/dom/nodes/Element-lastElementChild-xhtml-expected.txt:
  • web-platform-tests/dom/nodes/Element-nextElementSibling-expected.txt:
  • web-platform-tests/dom/nodes/Element-nextElementSibling-xhtml-expected.txt:
  • web-platform-tests/dom/nodes/Element-previousElementSibling-expected.txt:
  • web-platform-tests/dom/nodes/Element-previousElementSibling-xhtml-expected.txt:
  • web-platform-tests/dom/nodes/Element-siblingElement-null-expected.txt:
  • web-platform-tests/dom/nodes/Element-siblingElement-null-xhtml-expected.txt:
  • web-platform-tests/dom/nodes/Node-appendChild-expected.txt:
  • web-platform-tests/dom/nodes/Node-contains-xml-expected.txt:
  • web-platform-tests/dom/nodes/Node-isEqualNode-xhtml-expected.txt:
  • web-platform-tests/dom/nodes/Node-removeChild-expected.txt:
  • web-platform-tests/dom/nodes/Text-constructor-expected.txt:
  • web-platform-tests/dom/nodes/getElementsByClassName-19-expected.txt:
  • web-platform-tests/dom/nodes/getElementsByClassName-20-expected.txt:
  • web-platform-tests/dom/nodes/getElementsByClassName-21-expected.txt:
  • web-platform-tests/dom/nodes/getElementsByClassName-22-expected.txt:
  • web-platform-tests/dom/nodes/getElementsByClassName-23-expected.txt:
  • web-platform-tests/dom/nodes/getElementsByClassName-24-expected.txt:
  • web-platform-tests/dom/nodes/getElementsByClassName-25-expected.txt:
  • web-platform-tests/dom/nodes/getElementsByClassName-26-expected.txt:
  • web-platform-tests/dom/nodes/getElementsByClassName-27-expected.txt:
  • web-platform-tests/dom/nodes/getElementsByClassName-28-expected.txt:
  • web-platform-tests/dom/nodes/getElementsByClassName-29-expected.txt:
  • web-platform-tests/dom/nodes/getElementsByClassName-30-expected.txt:
  • web-platform-tests/dom/nodes/getElementsByClassName-31-expected.txt:
  • web-platform-tests/dom/traversal/TreeWalker-acceptNode-filter-expected.txt:
  • web-platform-tests/dom/traversal/TreeWalker-basic-expected.txt:
  • web-platform-tests/dom/traversal/TreeWalker-currentNode-expected.txt:
  • web-platform-tests/dom/traversal/TreeWalker-previousNodeLastChildReject-expected.txt:
  • web-platform-tests/dom/traversal/TreeWalker-previousSiblingLastChildSkip-expected.txt:
  • web-platform-tests/dom/traversal/TreeWalker-traversal-reject-expected.txt:
  • web-platform-tests/dom/traversal/TreeWalker-traversal-skip-expected.txt:
  • web-platform-tests/dom/traversal/TreeWalker-traversal-skip-most-expected.txt:
  • web-platform-tests/dom/traversal/TreeWalker-walking-outside-a-tree-expected.txt:
  • web-platform-tests/domparsing/innerhtml-05-expected.txt:
  • web-platform-tests/fetch/nosniff/image-expected.txt:
  • web-platform-tests/html/dom/documents/dom-tree-accessors/document.forms-expected.txt:
  • web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-namespace-expected.txt:
  • web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-namespace-xhtml-expected.txt:
  • web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-expected.txt:
  • web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-xhtml-expected.txt:
  • web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-param-expected.txt:
  • web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-param-xhtml-expected.txt:
  • web-platform-tests/html/dom/documents/dom-tree-accessors/document.images-expected.txt:
  • web-platform-tests/html/dom/documents/dom-tree-accessors/nameditem-01-expected.txt:
  • web-platform-tests/html/dom/documents/dom-tree-accessors/nameditem-02-expected.txt:
  • web-platform-tests/html/dom/documents/dom-tree-accessors/nameditem-06-expected.txt:
  • web-platform-tests/html/dom/dynamic-markup-insertion/document-write/049-expected.txt:
  • web-platform-tests/html/dom/dynamic-markup-insertion/document-write/050-expected.txt:
  • web-platform-tests/html/dom/dynamic-markup-insertion/document-write/051-expected.txt:
  • web-platform-tests/html/dom/dynamic-markup-insertion/document-write/document.write-02-expected.txt:
  • web-platform-tests/html/dom/dynamic-markup-insertion/document-writeln/document.writeln-02-expected.txt:
  • web-platform-tests/html/dom/dynamic-markup-insertion/document-writeln/document.writeln-03-expected.txt:
  • web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/001-expected.txt:
  • web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/004-expected.txt:
  • web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/005-expected.txt:
  • web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/006-expected.txt:
  • web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/007-expected.txt:
  • web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/008-expected.txt:
  • web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/009-expected.txt:
  • web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/011-expected.txt:
  • web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/012-expected.txt:
  • web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/013-expected.txt:
  • web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/014-expected.txt:
  • web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/015-expected.txt:
  • web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/016-expected.txt:
  • web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/document.open-03-expected.txt:
  • web-platform-tests/html/dom/reflection-embedded-expected.txt:
  • web-platform-tests/html/dom/reflection-forms-expected.txt:
  • web-platform-tests/html/dom/reflection-grouping-expected.txt:
  • web-platform-tests/html/dom/reflection-metadata-expected.txt:
  • web-platform-tests/html/dom/reflection-misc-expected.txt:
  • web-platform-tests/html/dom/reflection-obsolete-expected.txt:
  • web-platform-tests/html/dom/reflection-sections-expected.txt:
  • web-platform-tests/html/dom/reflection-tabular-expected.txt:
  • web-platform-tests/html/dom/reflection-text-expected.txt:
  • web-platform-tests/html/semantics/disabled-elements/disabledElement-expected.txt:
  • web-platform-tests/html/semantics/document-metadata/the-base-element/base_multiple-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrack/activeCues-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrack/addCue-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrack/removeCue-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackCue/endTime-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackCue/id-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackCue/pauseOnExit-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackCue/startTime-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackCue/track-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackCueList/getCueById-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackCueList/getter-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrackCueList/length-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/media-elements/video_008-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/media-elements/video_volume_check-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-embed-element/embed-dimension-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-allowfullscreen-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_javascript_url_01-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/current-pixel-density/basic-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/current-pixel-density/error-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/viewport-change-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/srcset/parse-a-srcset-attribute-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/srcset/select-an-image-source-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/update-media-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-object-element/object-attributes-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-object-element/object-handler-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-video-element/video-tabindex-expected.txt:
  • web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/dirname-ltr-expected.txt:
  • web-platform-tests/html/semantics/forms/constraints/form-validation-checkValidity-expected.txt:
  • web-platform-tests/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt:
  • web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt:
  • web-platform-tests/html/semantics/forms/constraints/form-validation-validity-customError-expected.txt:
  • web-platform-tests/html/semantics/forms/constraints/form-validation-validity-patternMismatch-expected.txt:
  • web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt:
  • web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt:
  • web-platform-tests/html/semantics/forms/constraints/form-validation-validity-stepMismatch-expected.txt:
  • web-platform-tests/html/semantics/forms/constraints/form-validation-validity-tooLong-expected.txt:
  • web-platform-tests/html/semantics/forms/constraints/form-validation-validity-tooShort-expected.txt:
  • web-platform-tests/html/semantics/forms/constraints/form-validation-validity-typeMismatch-expected.txt:
  • web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt:
  • web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt:
  • web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt:
  • web-platform-tests/html/semantics/forms/form-control-infrastructure/form-expected.txt:
  • web-platform-tests/html/semantics/forms/textfieldselection/selection-expected.txt:
  • web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setSelectionRange-expected.txt:
  • web-platform-tests/html/semantics/forms/the-button-element/button-validation-expected.txt:
  • web-platform-tests/html/semantics/forms/the-datalist-element/datalistoptions-expected.txt:
  • web-platform-tests/html/semantics/forms/the-fieldset-element/disabled-001-expected.txt:
  • web-platform-tests/html/semantics/forms/the-fieldset-element/disabled-002-expected.txt:
  • web-platform-tests/html/semantics/forms/the-form-element/form-autocomplete-expected.txt:
  • web-platform-tests/html/semantics/forms/the-form-element/form-elements-matches-expected.txt:
  • web-platform-tests/html/semantics/forms/the-form-element/form-elements-nameditem-01-expected.txt:
  • web-platform-tests/html/semantics/forms/the-form-element/form-elements-nameditem-02-expected.txt:
  • web-platform-tests/html/semantics/forms/the-form-element/form-elements-sameobject-expected.txt:
  • web-platform-tests/html/semantics/forms/the-form-element/form-indexed-element-expected.txt:
  • web-platform-tests/html/semantics/forms/the-form-element/form-nameditem-expected.txt:
  • web-platform-tests/html/semantics/forms/the-input-element/button-expected.txt:
  • web-platform-tests/html/semantics/forms/the-input-element/checkbox-expected.txt:
  • web-platform-tests/html/semantics/forms/the-input-element/radio-expected.txt:
  • web-platform-tests/html/semantics/forms/the-input-element/radio-groupname-case-expected.txt:
  • web-platform-tests/html/semantics/forms/the-input-element/reset-expected.txt:
  • web-platform-tests/html/semantics/forms/the-option-element/option-text-backslash-expected.txt:
  • web-platform-tests/html/semantics/forms/the-output-element/output-expected.txt:
  • web-platform-tests/html/semantics/forms/the-progress-element/progress-expected.txt:
  • web-platform-tests/html/semantics/forms/the-select-element/common-HTMLOptionsCollection-expected.txt:
  • web-platform-tests/html/semantics/forms/the-select-element/common-HTMLOptionsCollection-namedItem-expected.txt:
  • web-platform-tests/html/semantics/forms/the-select-element/select-named-getter-expected.txt:
  • web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-expected.txt:
  • web-platform-tests/html/semantics/grouping-content/the-ol-element/grouping-ol-expected.txt:
  • web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-close-expected.txt:
  • web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-showModal-expected.txt:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/async_003-expected.txt:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/async_004-expected.txt:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/async_005-expected.txt:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/async_006-expected.txt:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/async_007-expected.txt:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/async_008-expected.txt:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/async_010-expected.txt:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/script-noembed-noframes-iframe-expected.txt:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/checked-expected.txt:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/default-expected.txt:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/dir-expected.txt:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/dir01-expected.txt:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/disabled-expected.txt:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/enabled-expected.txt:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/focus-expected.txt:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/indeterminate-expected.txt:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/inrange-outofrange-expected.txt:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/readwrite-readonly-expected.txt:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/required-optional-expected.txt:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/valid-invalid-expected.txt:
  • web-platform-tests/html/semantics/tabular-data/the-table-element/caption-methods-expected.txt:
  • web-platform-tests/html/semantics/tabular-data/the-table-element/tBodies-expected.txt:
  • web-platform-tests/html/semantics/tabular-data/the-tbody-element/insertRow-expected.txt:
  • web-platform-tests/html/semantics/tabular-data/the-tr-element/cells-expected.txt:
  • web-platform-tests/html/semantics/text-level-semantics/the-a-element/a.text-getter-01-expected.txt:
  • web-platform-tests/html/semantics/text-level-semantics/the-a-element/a.text-setter-01-expected.txt:

LayoutTests:

Fix logging in W3C tests. Some W3C tests have no visible output or
output in the wrong order because we fail to use the test's "log"
<div> and always append the log lines to the body.

  • resources/testharnessreport.js:

(self.testRunner.add_completion_callback):

11:17 AM Changeset in webkit [204089] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

Cleanup HTMLMediaElement track lists.
https://bugs.webkit.org/show_bug.cgi?id=160470

Reviewed by Brent Fulgham.

  • html/track/AudioTrack.cpp:

(WebCore::AudioTrack::willRemove): Remove unnecessary ASSERT and NULL check.

  • html/track/TextTrackList.cpp:

(TextTrackList::~TextTrackList): Call clearElement so media element and client pointers are
cleared.

11:11 AM Changeset in webkit [204088] by adachan@apple.com
  • 11 edits in trunk

[Mac] media/pip-video-going-into-fullscreen.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=160469

Reviewed by Eric Carlson.

Source/WebCore:

When going from picture-in-picture directly to fullscreen, fix the issue where the
presentation mode unexpectedly changes back to inline after changing to fullscreen.

On Mac, standard fullscreen is not handled by WebVideoFullscreenManager.
When going from picture-in-picture directly to fullscreen, we call
WebVideoFullscreenInterfaceMac::exitFullscreenWithoutAnimationToMode().
We should update m_mode to VideoFullscreenModeStandard there to keep it in sync
with the fullscreen mode in HTMLMediaElement. Otherwise, we'll inadvertently
update the mode to inline when we clear the VideoFullscreenModePictureInPicture mode
in -[WebVideoFullscreenInterfaceMacObjC pipDidClose:].

Since standard fullscreen on Mac doesn't make use of the video fullscreen layer,
we need to make sure we return the video layer back to inline when the presentation
mode changes to "fullscreen". We only do this on Mac because iOS does use
the video fullscreen layer for standard fullscreen.

  • Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::setPreparedToReturnVideoLayerToInline):
Renamed from MediaControlsHost::setPreparedForInline to make it clear this is about
whether the video layer should be inline.
(WebCore::MediaControlsHost::setPreparedForInline): Deleted.

  • Modules/mediacontrols/MediaControlsHost.h:
  • Modules/mediacontrols/MediaControlsHost.idl:
  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.shouldReturnVideoLayerToInline):
On Mac, the video layer is inline when the presentation mode is "inline" or "fullscreen".
(Controller.prototype.handlePresentationModeChange):
Call shouldReturnVideoLayerToInline() to determine whether the video layer should be inline.

  • Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.shouldReturnVideoLayerToInline):
Override this method since on iOS, the video layer is only inline when the presentation
mode is "inline".

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::stopWithoutDestroyingMediaPlayer):
(WebCore::HTMLMediaElement::setPreparedToReturnVideoLayerToInline):
(WebCore::HTMLMediaElement::setPreparedForInline): Deleted.

  • html/HTMLMediaElement.h:
  • platform/mac/WebVideoFullscreenInterfaceMac.mm:

(WebCore::WebVideoFullscreenInterfaceMac::enterFullscreen):
Remove the assertion that the mode must be "picture-in-picture". I've run into this
assertion in layout tests. Since the EnterFullscreen message is sent in a dispatch_async
block in WebVideoFullscreenManager::didSetupFullscreen(), there's a chance that the
fullscreen mode tracked in WebVideoFullscreenInterfaceMac has already changed to
something else when WebVideoFullscreenInterfaceMac::enterFullscreen() is called.
(WebCore::WebVideoFullscreenInterfaceMac::exitFullscreenWithoutAnimationToMode):
If exiting to standard fullscreen, update m_mode to VideoFullscreenModeStandard.

LayoutTests:

Re-enable media/pip-video-going-into-fullscreen.html on Sierra.

  • platform/mac-wk2/TestExpectations:
11:05 AM Changeset in webkit [204087] by clopez@igalia.com
  • 2 edits
    1 add in trunk/Tools

Benchmark test content-animation timeouts always
https://bugs.webkit.org/show_bug.cgi?id=160057

Reviewed by Simon Fraser.

  • Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
  • Scripts/webkitpy/benchmark_runner/run_benchmark.py:

(start):

10:22 AM Changeset in webkit [204086] by bshafiei@apple.com
  • 2 edits in branches/safari-602-branch/Source/WebCore

Merge r204082. rdar://problem/27547583

10:15 AM Changeset in webkit [204085] by commit-queue@webkit.org
  • 4 edits in trunk

http/tests/fetch/fetch-in-worker-crash.html is sometimes crashing
https://bugs.webkit.org/show_bug.cgi?id=160498

Patch by Youenn Fablet <youenn@apple.com> on 2016-08-03
Reviewed by Chris Dumez.

Source/WebCore:

Covered by http/tests/fetch/fetch-in-worker-crash.html.

  • loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::MainThreadBridge::cancel): Taking a reference of the client wrapper to ensure it can be cleaned-up successfully.

LayoutTests:

  • http/tests/fetch/fetch-in-worker.js:

(onmessage): Reducing flakiness risk by making fetch http load being delayed.

10:12 AM Changeset in webkit [204084] by Csaba Osztrogonác
  • 6 edits
    2 adds in trunk

Lacking support on a arm-traditional disassembler.
https://bugs.webkit.org/show_bug.cgi?id=123717

Reviewed by Mark Lam.

.:

  • Source/cmake/FindLLVM.cmake: Added back the r196749 state.
  • Source/cmake/OptionsCommon.cmake: Added back the r196749 state.

Source/JavaScriptCore:

  • CMakeLists.txt:
  • disassembler/ARMLLVMDisassembler.cpp: Added, based on pre r196729 LLVMDisassembler, but it is ARM traditional only now.

(JSC::tryToDisassemble):

Source/WTF:

  • wtf/Platform.h:
9:53 AM Changeset in webkit [204083] by andersca@apple.com
  • 4 edits
    40 copies
    11 adds in trunk/Source/WebCore

Freeze the last of the Objective-C bindings
https://bugs.webkit.org/show_bug.cgi?id=160482

Reviewed by Darin Adler.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMAttr.h: Added.
  • bindings/objc/DOMAttr.mm: Added.
  • bindings/objc/DOMAttrInternal.h: Added.
  • bindings/objc/DOMCDATASection.h: Added.
  • bindings/objc/DOMCDATASection.mm: Added.
  • bindings/objc/DOMCDATASectionInternal.h: Added.
  • bindings/objc/DOMCharacterData.h
  • bindings/objc/DOMCharacterData.mm: Added.
  • bindings/objc/DOMCharacterDataInternal.h: Added.
  • bindings/objc/DOMComment.h: Added.
  • bindings/objc/DOMComment.mm: Added.
  • bindings/objc/DOMCommentInternal.h: Added.
  • bindings/objc/DOMDOMImplementation.h: Added.
  • bindings/objc/DOMDOMImplementation.mm: Added.
  • bindings/objc/DOMDOMImplementationInternal.h: Added.
  • bindings/objc/DOMDocument.h: Added.
  • bindings/objc/DOMDocument.mm: Added.
  • bindings/objc/DOMDocumentFragment.h: Added.
  • bindings/objc/DOMDocumentFragment.mm: Added.
  • bindings/objc/DOMDocumentFragmentInternal.h: Added.
  • bindings/objc/DOMDocumentFragmentPrivate.h: Added.
  • bindings/objc/DOMDocumentInternal.h: Added.
  • bindings/objc/DOMDocumentPrivate.h: Added.
  • bindings/objc/DOMDocumentType.h: Added.
  • bindings/objc/DOMDocumentType.mm: Added.
  • bindings/objc/DOMDocumentTypeInternal.h: Added.
  • bindings/objc/DOMElement.h: Added.
  • bindings/objc/DOMElement.mm: Added.
  • bindings/objc/DOMElementInternal.h: Added.
  • bindings/objc/DOMEntity.h: Added.
  • bindings/objc/DOMEntity.mm: Added.
  • bindings/objc/DOMEntityInternal.h: Added.
  • bindings/objc/DOMEntityReference.h: Added.
  • bindings/objc/DOMEntityReference.mm: Added.
  • bindings/objc/DOMEntityReferenceInternal.h: Added.
  • bindings/objc/DOMNamedNodeMap.h: Added.
  • bindings/objc/DOMNamedNodeMap.mm: Added.
  • bindings/objc/DOMNamedNodeMapInternal.h: Added.
  • bindings/objc/DOMNode.h: Added.
  • bindings/objc/DOMNode.mm: Added.
  • bindings/objc/DOMNodeInternal.h: Added.
  • bindings/objc/DOMNodeList.h: Added.
  • bindings/objc/DOMNodeList.mm: Added.
  • bindings/objc/DOMNodeListInternal.h: Added.
  • bindings/objc/DOMNodePrivate.h: Added.
  • bindings/objc/DOMProcessingInstruction.h: Added.
  • bindings/objc/DOMProcessingInstruction.mm: Added.
  • bindings/objc/DOMProcessingInstructionInternal.h: Added.
  • bindings/objc/DOMText.h: Added.
  • bindings/objc/DOMText.mm: Added.
  • bindings/objc/DOMTextEvent.mm:
  • bindings/objc/DOMTextEventInternal.h:
  • bindings/objc/DOMTextInternal.h: Added.
9:33 AM Changeset in webkit [204082] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac][iOS] Adopt MediaRemote "seek to playback position"
https://bugs.webkit.org/show_bug.cgi?id=160405
<rdar://problem/27547583>

Reviewed by Dean Jackson.

  • platform/ios/RemoteCommandListenerIOS.mm:

(WebCore::RemoteCommandListenerIOS::RemoteCommandListenerIOS): Fix a typo.

9:12 AM Changeset in webkit [204081] by Chris Dumez
  • 1 edit
    2 moves in trunk/LayoutTests

Unreviewed, move LayoutTest out of platform/ios-simulator/ios.

  • fast/events/touch/ios/Touch-attributes-prototype-expected.txt: Renamed from LayoutTests/platform/ios-simulator/ios/touch/Touch-attributes-prototype-expected.txt.
  • fast/events/touch/ios/Touch-attributes-prototype.html: Renamed from LayoutTests/platform/ios-simulator/ios/touch/Touch-attributes-prototype.html.
7:35 AM Changeset in webkit [204080] by Michael Catanzaro
  • 2 edits in trunk/Source/WebKit2

[GTK] Document how to initialize WebKitFaviconDatabase
https://bugs.webkit.org/show_bug.cgi?id=160391

Reviewed by Carlos Garcia Campos.

  • UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
3:41 AM Changeset in webkit [204079] by commit-queue@webkit.org
  • 61 edits
    2 copies
    22 adds
    4 deletes in trunk/LayoutTests/imported/w3c

Refresh wpt tests up to d686014
https://bugs.webkit.org/show_bug.cgi?id=160446

Patch by Youenn Fablet <youenn@apple.com> on 2016-08-03
Reviewed by Alex Christensen.

  • resources/ImportExpectations:
  • resources/TestRepositories:
  • resources/web-platform-tests-modules.json:
  • web-platform-tests/XMLHttpRequest/FormData-append.html:
  • web-platform-tests/XMLHttpRequest/XMLHttpRequest-withCredentials.any.js: Added.

(test):
(string_appeared_here.test):
(string_appeared_here.async_test):

  • web-platform-tests/XMLHttpRequest/XMLHttpRequest-withCredentials.html: Removed.
  • web-platform-tests/XMLHttpRequest/XMLHttpRequest-withCredentials.js: Removed.
  • web-platform-tests/XMLHttpRequest/XMLHttpRequest-withCredentials.worker.js: Removed.
  • web-platform-tests/XMLHttpRequest/headers-normalize-response-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/headers-normalize-response.htm: Added.
  • web-platform-tests/XMLHttpRequest/open-url-multi-window.htm:
  • web-platform-tests/XMLHttpRequest/resources/last-modified.py:

(main):

  • web-platform-tests/XMLHttpRequest/resources/parse-headers.py: Added.

(main):

  • web-platform-tests/XMLHttpRequest/resources/w3c-import.log:
  • web-platform-tests/XMLHttpRequest/responsexml-document-properties-expected.txt:
  • web-platform-tests/XMLHttpRequest/responsexml-document-properties.htm:
  • web-platform-tests/XMLHttpRequest/send-entity-body-document-expected.txt:
  • web-platform-tests/XMLHttpRequest/send-entity-body-empty-expected.txt:
  • web-platform-tests/XMLHttpRequest/send-entity-body-empty.htm:
  • web-platform-tests/XMLHttpRequest/send-entity-body-get-head-async-expected.txt:
  • web-platform-tests/XMLHttpRequest/send-entity-body-get-head-async.htm:
  • web-platform-tests/XMLHttpRequest/send-entity-body-get-head-expected.txt:
  • web-platform-tests/XMLHttpRequest/send-entity-body-get-head.htm:
  • web-platform-tests/XMLHttpRequest/send-entity-body-none-expected.txt:
  • web-platform-tests/XMLHttpRequest/send-entity-body-none.htm:
  • web-platform-tests/XMLHttpRequest/setrequestheader-content-type-expected.txt:
  • web-platform-tests/XMLHttpRequest/setrequestheader-content-type.htm:
  • web-platform-tests/XMLHttpRequest/w3c-import.log:
  • web-platform-tests/dom/events/AddEventListenerOptions-once-expected.txt: Added.
  • web-platform-tests/dom/events/AddEventListenerOptions-once.html: Added.
  • web-platform-tests/dom/events/w3c-import.log:
  • web-platform-tests/dom/lists/DOMTokenList-iteration-expected.txt: Added.
  • web-platform-tests/dom/lists/DOMTokenList-iteration.html: Added.
  • web-platform-tests/dom/lists/w3c-import.log:
  • web-platform-tests/dom/nodes/Node-childNodes-expected.txt:
  • web-platform-tests/dom/nodes/Node-childNodes.html:
  • web-platform-tests/domparsing/insert_adjacent_html-expected.txt:
  • web-platform-tests/fetch/api/basic/request-headers-expected.txt:
  • web-platform-tests/fetch/api/basic/request-headers-worker-expected.txt:
  • web-platform-tests/fetch/api/basic/request-headers.js:
  • web-platform-tests/fetch/api/basic/request-referrer-expected.txt: Added.
  • web-platform-tests/fetch/api/basic/request-referrer.html: Added.
  • web-platform-tests/fetch/api/basic/request-referrer.js: Added.

(testReferrer):

  • web-platform-tests/fetch/api/basic/w3c-import.log:
  • web-platform-tests/fetch/api/cors/cors-cookies-worker-expected.txt:
  • web-platform-tests/fetch/api/policies/referrer-no-referrer-expected.txt:
  • web-platform-tests/fetch/api/policies/referrer-no-referrer-worker-expected.txt:
  • web-platform-tests/fetch/api/policies/referrer-no-referrer.html.headers:
  • web-platform-tests/fetch/api/policies/referrer-no-referrer.js.headers:
  • web-platform-tests/fetch/api/policies/referrer-origin-expected.txt:
  • web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/fetch/api/policies/referrer-origin-expected.txt.
  • web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-worker-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/fetch/api/policies/referrer-origin-expected.txt.
  • web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-worker.html: Added.
  • web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin.html: Added.
  • web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin.html.headers: Added.
  • web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin.js: Added.

(promise_test):

  • web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin.js.headers: Added.
  • web-platform-tests/fetch/api/policies/referrer-origin-worker-expected.txt:
  • web-platform-tests/fetch/api/policies/referrer-origin.html.headers:
  • web-platform-tests/fetch/api/policies/referrer-origin.js.headers:
  • web-platform-tests/fetch/api/policies/referrer-unsafe-url-expected.txt:
  • web-platform-tests/fetch/api/policies/referrer-unsafe-url-worker-expected.txt:
  • web-platform-tests/fetch/api/policies/referrer-unsafe-url.html.headers:
  • web-platform-tests/fetch/api/policies/referrer-unsafe-url.js.headers:
  • web-platform-tests/fetch/api/policies/w3c-import.log:
  • web-platform-tests/fetch/api/request/request-cache-expected.txt:
  • web-platform-tests/fetch/api/request/resources/get-host-info.sub.js: Removed.
  • web-platform-tests/fetch/nosniff/resources/image.py:

(main):

  • web-platform-tests/fetch/nosniff/stylesheet-expected.txt:
  • web-platform-tests/fetch/nosniff/stylesheet.html:
  • web-platform-tests/html/dom/interfaces-expected.txt:
  • web-platform-tests/html/dom/interfaces.html:
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-allowfullscreen-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe-allowfullscreen.html:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/viewport-change-expected.txt:
  • web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-expected.txt:
  • web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li.html:
  • web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-open-expected.txt: Added.
  • web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-open.html: Added.
  • web-platform-tests/html/semantics/interactive-elements/the-dialog-element/w3c-import.log:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/script-charset-03-expected.txt: Added.
  • web-platform-tests/html/semantics/scripting-1/the-script-element/script-charset-03.html: Added.
  • web-platform-tests/html/semantics/scripting-1/the-script-element/w3c-import.log:
  • web-platform-tests/html/semantics/tabular-data/the-table-element/caption-methods-expected.txt:
  • web-platform-tests/html/semantics/tabular-data/the-table-element/caption-methods.html:
  • web-platform-tests/html/semantics/tabular-data/the-table-element/remove-row-expected.txt: Added.
  • web-platform-tests/html/semantics/tabular-data/the-table-element/remove-row.html: Added.
  • web-platform-tests/html/semantics/tabular-data/the-table-element/w3c-import.log:
  • web-platform-tests/lint.whitelist:
  • web-platform-tests/service-workers/tools/blink-import.py:

(main):

12:50 AM Changeset in webkit [204078] by sbarati@apple.com
  • 13 edits
    2 adds in trunk

Implement nested rest destructuring w.r.t the ES7 spec
https://bugs.webkit.org/show_bug.cgi?id=160423

Reviewed by Filip Pizlo.

JSTests:

  • stress/destructuring-rest-element.js: Added.

(assert):
(test):
(arr):
(eq):
(gen):
(fakeGen.return.Symbol.iterator):
(fakeGen):

  • stress/rest-elements.js:

(testSyntaxError.String.raw):

  • stress/rest-parameter-is-destructuring.js: Added.

(assert):
(test):
(foo):
(bar):

  • test262.yaml:

Source/JavaScriptCore:

The spec has updated the BindingRestElement grammar production to be:
BindingRestElement:

BindingIdentifier
BindingingPattern.

It used to only allow BindingIdentifier in the grammar production.
I've updated our engine to account for this. The semantics are exactly
what you'd expect. For example:
let [a, ...[b, ...c]] = expr();
means that we create an array for the first rest element ...[b, ...c]
and then perform the binding of [b, ...c] to that array. And so on,
applied recursively through the pattern.

  • bytecompiler/NodesCodegen.cpp:

(JSC::RestParameterNode::collectBoundIdentifiers):
(JSC::RestParameterNode::toString):
(JSC::RestParameterNode::bindValue):
(JSC::RestParameterNode::emit):

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createBindingLocation):
(JSC::ASTBuilder::createRestParameter):
(JSC::ASTBuilder::createAssignmentElement):

  • parser/NodeConstructors.h:

(JSC::AssignmentElementNode::AssignmentElementNode):
(JSC::RestParameterNode::RestParameterNode):
(JSC::DestructuringAssignmentNode::DestructuringAssignmentNode):

  • parser/Nodes.h:

(JSC::RestParameterNode::name): Deleted.

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseDestructuringPattern):
(JSC::Parser<LexerType>::parseFormalParameters):

  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::operatorStackPop):

LayoutTests:

  • js/parser-syntax-check-expected.txt:
  • js/script-tests/parser-syntax-check.js:
12:38 AM Changeset in webkit [204077] by benjamin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] Fix Windows build after r204065

  • dfg/DFGAbstractValue.cpp:

(JSC::DFG::AbstractValue::observeTransitions):
AbstractValue is bigger on Windows for an unknown reason.

12:07 AM MathML/Early_2016_Refactoring edited by fred.wang@free.fr
(diff)
12:06 AM Changeset in webkit [204076] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Activate directory index generation for Apache test server
https://bugs.webkit.org/show_bug.cgi?id=160451

Patch by Youenn Fablet <youenn@apple.com> on 2016-08-03
Reviewed by Alexey Proskuryakov.

  • http/conf/apache2.4-httpd.conf:
12:00 AM Changeset in webkit [204075] by fred.wang@free.fr
  • 10 edits in trunk/Source/WebCore

Move determination of operator direction into DOM class and reduce relayout
https://bugs.webkit.org/show_bug.cgi?id=160339

Patch by Frederic Wang <fwang@igalia.com> on 2016-08-02
Reviewed by Darin Adler.

We move the determination of operator direction into MathMLOperatorElement. We also simplify
a bit RenderMathMLFencedOperator so that the update of operator properties are done
immediately in updateOperatorContent and the resolution of to LayoutUnit is implemented
in leadingSpace, trailingSpace, minSize and maxSize. After that, setOperatorProperties is no
longer necessary and we can remove many calls that used to update operator properties and
force relayout.

No new tests, already covered by existing tests.

  • mathml/MathMLInlineContainerElement.cpp:

(WebCore::MathMLInlineContainerElement::childrenChanged): No need to call updateOperatorProperties.

  • mathml/MathMLOperatorElement.cpp: Change names from "text" to "char".

(WebCore::MathMLOperatorElement::parseOperatorChar): Parse character and isVertical in this function.
(WebCore::MathMLOperatorElement::operatorChar):
(WebCore::MathMLOperatorElement::childrenChanged):
(WebCore::MathMLOperatorElement::computeDictionaryProperty): Call operatorChar().character.
(WebCore::MathMLOperatorElement::parseOperatorText): Deleted.
(WebCore::MathMLOperatorElement::operatorText): Deleted.

  • mathml/MathMLOperatorElement.h: Use a new structure to hold both the character and direction

and change names from "text" to "char".

  • rendering/mathml/RenderMathMLFencedOperator.cpp:

(WebCore::RenderMathMLFencedOperator::updateOperatorContent): Update both the character and
direction using MathMLOperatorElement::parseOperatorChar. Then set the boolean properties
and leading/trailing space using the operator dictionary. minsize and maxsize are constant
so we do not need to set them any more.
(WebCore::RenderMathMLFencedOperator::leadingSpace): Resolve the spacing read from the
dictionary to LayoutUnit. Note that it can never be negative.
(WebCore::RenderMathMLFencedOperator::trailingSpace): Ditto.
(WebCore::RenderMathMLFencedOperator::RenderMathMLFencedOperator): Deleted.
(WebCore::RenderMathMLFencedOperator::setOperatorProperties): Deleted.

  • rendering/mathml/RenderMathMLFencedOperator.h: We use the new OperatorChar structure for

accessors and members. We make minSize and maxSize just return the default values and delete
the corresponding members. Finally, leading and trailing space are now stored as unsigned
short in MathUnit.

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::textContent): Use the new OperatorChar structure.
(WebCore::RenderMathMLOperator::isVertical): Helper function forwarding to MathMLOperatorElement.
(WebCore::RenderMathMLOperator::stretchTo): Use isVertical() and remove setOperatorProperties().
(WebCore::RenderMathMLOperator::resetStretchSize): Ditto.
(WebCore::RenderMathMLOperator::updateMathOperator): Rename rebuildTokenContent as this is
now really only used to update MathOperator and hence replace the condition on
useMathOperator() with an ASSERT.
(WebCore::RenderMathMLOperator::updateTokenContent): Call updateMathOperator instead of
rebuildTokenContent.
(WebCore::RenderMathMLOperator::verticalStretchedOperatorShift): We use isVertical().
(WebCore::RenderMathMLOperator::paint): Ditto.
(WebCore::RenderMathMLOperator::setOperatorProperties): Deleted. This is no longer needed.
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths): Deleted.
(WebCore::RenderMathMLOperator::rebuildTokenContent): Deleted. Renamed updateMathOperator.
(WebCore::RenderMathMLOperator::styleDidChange): No need to call updateOperatorProperties.
(WebCore::RenderMathMLOperator::updateOperatorProperties): Ditto..

  • rendering/mathml/RenderMathMLOperator.h: Update some declaration and remove m_isVertical.

(WebCore::RenderMathMLOperator::isVertical): Deleted.

  • rendering/mathml/RenderMathMLRow.cpp:

(WebCore::RenderMathMLRow::updateOperatorProperties): Deleted. This is no longer needed.

  • rendering/mathml/RenderMathMLRow.h: Ditto.

Aug 2, 2016:

11:35 PM Changeset in webkit [204074] by mmaxfield@apple.com
  • 4 edits
    2 adds in trunk

Update breaking rules to match ICU 57
https://bugs.webkit.org/show_bug.cgi?id=160488
<rdar://problem/25856238>

Reviewed by Darin Adler.

Source/WTF:

This patch fixes a typo in the uax14AssignmentsAfter rules which
was causing flag emoji to have line breaking opportunities in their
middles. It also fixes significant language issues for languages
such as Hebrew, and adds correct breaking opportunities around
hyphens.

  • wtf/text/TextBreakIterator.cpp:

(WTF::cursorMovementIterator):
(WTF::uax14AssignmentsAfter):
(WTF::uax14Forward):
(WTF::uax14Reverse):

LayoutTests:

  • fast/text/flag-emoji-line-break-expected.html: Added.
  • fast/text/flag-emoji-line-break.html: Added.
  • platform/mac/TestExpectations: Mark the test as failing on Yosemite.
11:16 PM Changeset in webkit [204073] by bshafiei@apple.com
  • 8 edits
    2 adds in branches/safari-602-branch

Merge r204050. rdar://problem/27313234

11:16 PM Changeset in webkit [204072] by bshafiei@apple.com
  • 8 edits
    2 moves in branches/safari-602-branch

Merge r204062. rdar://problem/27592936

11:16 PM Changeset in webkit [204071] by bshafiei@apple.com
  • 9 edits
    2 adds in branches/safari-602-branch

Merge r203955. rdar://problem/27629346

11:15 PM Changeset in webkit [204070] by bshafiei@apple.com
  • 3 edits in branches/safari-602-branch/Source/WebKit2

Merge r204057. rdar://problem/27534205

11:15 PM Changeset in webkit [204069] by bshafiei@apple.com
  • 2 edits in branches/safari-602-branch/Source/WebCore

Merge r203984. rdar://problem/27409854

11:15 PM Changeset in webkit [204068] by bshafiei@apple.com
  • 19 edits
    2 adds in branches/safari-602-branch

Merge r203982. rdar://problem/27547583

10:38 PM Changeset in webkit [204067] by bshafiei@apple.com
  • 5 edits in branches/safari-602-branch/Source

Versioning.

10:33 PM Changeset in webkit [204066] by benjamin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] Fix 32bits jsc after r204065

Default constructed JSValue() are not equal to zero in 32bits.

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::AbstractValue):

8:45 PM Changeset in webkit [204065] by benjamin@webkit.org
  • 7 edits in trunk/Source

[JSC] Simplify the initialization of AbstractValue in the AbstractInterpreter
https://bugs.webkit.org/show_bug.cgi?id=160370

Reviewed by Saam Barati.

Source/JavaScriptCore:

We use a ton of AbstractValue to run the Abstract Interpreter.

When we set up the initial values, the compiler sets
a zero on a first word, a one on a second word, and a zero
again on a third word.
Since no vector or double-store can deal with 3 words, unrolling
is done by repeating those instructions.

The reason for the one was TinyPtrSet. It needed a flag for
empty value to identify the set as thin. I flipped the flag to "fat"
to make sure TinyPtrSet is initialized to zero.

With that done, I just had to clean some places to make
the initialization shorter.
It makes the binary easier to follow but this does not help with
the bigger problem: the time spent per block on Abstract Interpreter.

  • bytecode/Operands.h:

The traits were useless, no client code defines it.

(JSC::Operands::Operands):
(JSC::Operands::ensureLocals):
Because of the size of the function, llvm is not inlining it.
We were literally loading 3 registers from memory and storing
them in the vector.
Now that AbstractValue has a VectorTraits, we should just rely
on the memset of Vector when possible.

(JSC::Operands::getLocal):
(JSC::Operands::setArgumentFirstTime):
(JSC::Operands::setLocalFirstTime):
(JSC::Operands::clear):
(JSC::OperandValueTraits::defaultValue): Deleted.
(JSC::OperandValueTraits::isEmptyForDump): Deleted.

  • bytecode/OperandsInlines.h:

(JSC::Operands<T>::dumpInContext):
(JSC::Operands<T>::dump):
(JSC::Traits>::dumpInContext): Deleted.
(JSC::Traits>::dump): Deleted.

  • dfg/DFGAbstractValue.cpp:
  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::AbstractValue):

Source/WTF:

  • wtf/TinyPtrSet.h:

(WTF::TinyPtrSet::isThin):
(WTF::TinyPtrSet::set):

7:56 PM Changeset in webkit [204064] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Drop custom bindings code for HTMLSelectElement.remove()
https://bugs.webkit.org/show_bug.cgi?id=160477

Reviewed by Darin Adler.

Drop custom bindings code for HTMLSelectElement.remove() and use
overloading instead.

  • bindings/js/JSHTMLSelectElementCustom.cpp:

(WebCore::JSHTMLSelectElement::remove): Deleted.

  • html/HTMLSelectElement.idl:
7:56 PM Changeset in webkit [204063] by Chris Dumez
  • 10 edits in trunk

Drop custom bindings code for HTMLOptionsCollection.remove()
https://bugs.webkit.org/show_bug.cgi?id=160475

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline W3C test now that more checks are passing.

  • web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

Drop custom bindings code for HTMLOptionsCollection.remove() and use
overloading instead. The overload that take an HTMLOptionElement is
WebKit-specific and should probably be dropped at some point:

This patch also fixes several bugs:

  • The parameter is now mandatory. This is consistent with the specification, Firefox and Chrome.
  • HTMLOptionsCollection.prototype.remove.length is now 1 instead of 0.

No new tests, rebaselined existing tests.

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::JSHTMLOptionsCollection::remove): Deleted.

  • html/HTMLOptionsCollection.idl:

LayoutTests:

Update existing tests to reflect behavior change.

  • fast/dom/non-numeric-values-numeric-parameters-expected.txt:
  • fast/dom/script-tests/non-numeric-values-numeric-parameters.js:
  • js/dom/select-options-remove-expected.txt:
  • js/resources/select-options-remove.js:
7:38 PM Changeset in webkit [204062] by n_wang@apple.com
  • 8 edits
    2 moves in trunk

AX: Simulated touch events are not working on iOS
https://bugs.webkit.org/show_bug.cgi?id=160395
<rdar://problem/27633597>

Reviewed by Chris Fleizach.

Source/WebCore:

We should mark the simulated touch as a potential tap otherwise it won't
be handled on iOS. Also, we need to dispatch both touch start and touch end
to mimic the real touch events. Last, added a has event listeners check,
because iOS is dispatching mouse click events for elements without touch event
listeners.

Test: accessibility/ios-simulator/press-fires-touch-events.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::press):
(WebCore::AccessibilityObject::dispatchTouchEvent):

  • page/ios/EventHandlerIOS.mm:

(WebCore::EventHandler::dispatchSimulatedTouchEvent):

  • platform/ios/PlatformEventFactoryIOS.mm:

(WebCore::PlatformTouchEventBuilder::PlatformTouchEventBuilder):

Tools:

  • WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:

(WTR::AccessibilityUIElement::press):
(WTR::AccessibilityUIElement::setSelectedChild):

LayoutTests:

  • accessibility/ios-simulator/press-fires-touch-events-expected.txt: Added.
  • accessibility/ios-simulator/press-fires-touch-events.html: Added.
  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-simulator/ios/accessibility/press-fires-touch-events-expected.txt: Removed.
  • platform/ios-simulator/ios/accessibility/press-fires-touch-events.html: Removed.
7:20 PM Changeset in webkit [204061] by commit-queue@webkit.org
  • 9 edits in trunk/Source

Clean up some useless AtomicString atoms
https://bugs.webkit.org/show_bug.cgi?id=160471

Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-08-02
Reviewed by Geoffrey Garen.

Source/WebCore:

The only uses of "commentAtom" and "textAtom" where for their
respective overload of Node::nodeName().
Those methods return a string, we should not keep them in the atomic
string table just to hold a small String alive. They were also the only
two nodes to behave that way.

The atom xlinkAtom was only used by createForeignAttributesMap(), which
is itself only invoked once. There is no need for the symbol xlinkAtom.

  • dom/CDATASection.cpp:

(WebCore::CDATASection::nodeName):

  • dom/Comment.cpp:

(WebCore::Comment::nodeName):

  • dom/Document.cpp:

(WebCore::Document::nodeName):

  • dom/Text.cpp:

(WebCore::Text::nodeName):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::createForeignAttributesMap):

Source/WTF:

  • wtf/text/AtomicString.h:
  • wtf/text/StringStatics.cpp:

(WTF::AtomicString::init): Deleted.

6:57 PM Changeset in webkit [204060] by fpizlo@apple.com
  • 2 edits in trunk/Tools

run-javascriptcore-tests should accept multiple --extra-tests
https://bugs.webkit.org/show_bug.cgi?id=160486

Reviewed by Saam Barati.

We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
test suites. This does it by using GetOpt::Long's array support.

  • Scripts/run-javascriptcore-tests:

(runJSCStressTests):

6:46 PM Changeset in webkit [204059] by sbarati@apple.com
  • 1 add
    1 delete in trunk/JSTests

Rename Changelog to ChangeLog

Rubber stamped by Keith Miller.

  • Changelog: Removed.
6:28 PM Changeset in webkit [204058] by sbarati@apple.com
  • 15 edits
    1 add in trunk

update a class extending null w.r.t the ES7 spec
https://bugs.webkit.org/show_bug.cgi?id=160417

Reviewed by Keith Miller.

Source/JavaScriptCore:

When a class extends null, it should not be marked as a derived class.
This was changed in the ES2016 spec, and this patch makes the needed
changes in JSC to follow the spec. This allows classes to extend
null and have their default constructor invoked without throwing an exception.
This also prevents |this| from being under TDZ at the start of the constructor.
Because ES6 allows arbitrary expressions in the class <ident> extends <expr>
syntax, we don't know statically if a constructor is extending null or not.
Therefore, we don't always know statically if it's a base or derived constructor.
I solved this by putting a boolean on the constructor function under a private
symbol named isDerivedConstructor when doing class construction. We only need
to put this boolean on constructors that may extend null. Constructors that are
declared in a class with no extends syntax can tell statically that they are a base constructor.

I've also renamed the ConstructorKind::Derived enum value to be
ConstructorKind::Extends to better indicate that we can't answer
the "am I a derived constructor?" question statically.

  • builtins/BuiltinExecutables.cpp:

(JSC::BuiltinExecutables::createDefaultConstructor):

  • builtins/BuiltinNames.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::initializeArrowFunctionContextScopeIfNeeded):
(JSC::BytecodeGenerator::emitReturn):
(JSC::BytecodeGenerator::emitLoadArrowFunctionLexicalEnvironment):
(JSC::BytecodeGenerator::ensureThis):
(JSC::BytecodeGenerator::emitPutDerivedConstructorToArrowFunctionContextScope):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::makeFunction):

  • bytecompiler/NodesCodegen.cpp:

(JSC::EvalFunctionCallNode::emitBytecode):
(JSC::FunctionCallValueNode::emitBytecode):
(JSC::FunctionNode::emitBytecode):
(JSC::ClassExprNode::emitBytecode):

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::Parser):
(JSC::Parser<LexerType>::parseFunctionInfo):
(JSC::Parser<LexerType>::parseClass):
(JSC::Parser<LexerType>::parseMemberExpression):

  • parser/ParserModes.h:

LayoutTests:

  • js/class-syntax-extends-expected.txt:
  • js/class-syntax-super-expected.txt:
  • js/script-tests/class-syntax-extends.js:
  • js/script-tests/class-syntax-super.js:
6:22 PM Changeset in webkit [204057] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

REGRESSION (r203385): Frequent RELEASE_ASSERT in WebKit::RemoteLayerTreeDrawingArea::flushLayers()
https://bugs.webkit.org/show_bug.cgi?id=160481
<rdar://problem/27534205>

Reviewed by Simon Fraser.

  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):
(WebKit::RemoteLayerTreeDrawingAreaProxy::didRefreshDisplay):
(WebKit::RemoteLayerTreeDrawingAreaProxy::waitForDidUpdateViewState):
If the UI process sends a didUpdate message while the Web process is in
the middle of flushing on a background thread, the drawing area will
allow another commit to start on the main thread, which then (rightfully)
causes the RELEASE_ASSERT.

This is normally not a problem, because didRefreshDisplay (which sends the didUpdate)
bails if m_didUpdateMessageState is anything other than NotSent, and m_didUpdateMessageState
is only NotSent if the Web process has sent a commit (and thus will not commit again until
it gets a didUpdate). This is the fundamental mechanism that avoids multiple commits being
in flight at once.

In r203385, I added a path where didRefreshDisplay could be called
before the first commit arrived (by way of
_applicationWillEnterForeground -> viewStateDidChange -> waitForDidUpdateViewState).

This caused trouble because m_didUpdateMessageState is initialized to NotSent,
which means that we could end up sending a didUpdate immediately, before the first
commit arrives - even worse, while the first commit is being flushed on a background thread,
leading the aforementioned RELEASE_ASSERT to fire.

Instead, initialize it to Sent (which I've renamed to DoesNotNeedDidUpdate), so that
we won't send a didUpdate until after the first commit arrives (at which point
the two processes are in agreement about the order of things).

It's not currently possible to API test this for multiple reasons, though it is fairly
easy to write a test app that reproduces reliably (by simulating suspend/resume notifications
inside the didFinishNavigation: callback).

6:14 PM Changeset in webkit [204056] by Ryan Haddad
  • 2 edits
    1 copy
    1 add in branches/safari-602-branch/LayoutTests

Merge r203992. rdar://problem/27611932

5:43 PM Changeset in webkit [204055] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skip media/track/track-remove-crash.html on ios-simulator-wk2
https://bugs.webkit.org/show_bug.cgi?id=160367

Unreviewed test gardening.

  • platform/ios-simulator-wk2/TestExpectations:
5:31 PM Changeset in webkit [204054] by andersca@apple.com
  • 3 edits
    80 adds in trunk/Source/WebCore

Freeze the Objective-C DOM Event and CSS bindings
https://bugs.webkit.org/show_bug.cgi?id=160476

Reviewed by Tim Horton.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMCSSCharsetRule.h: Added.
  • bindings/objc/DOMCSSCharsetRule.mm: Added.
  • bindings/objc/DOMCSSCharsetRuleInternal.h: Added.
  • bindings/objc/DOMCSSFontFaceRule.h: Added.
  • bindings/objc/DOMCSSFontFaceRule.mm: Added.
  • bindings/objc/DOMCSSFontFaceRuleInternal.h: Added.
  • bindings/objc/DOMCSSImportRule.h: Added.
  • bindings/objc/DOMCSSImportRule.mm: Added.
  • bindings/objc/DOMCSSImportRuleInternal.h: Added.
  • bindings/objc/DOMCSSMediaRule.h: Added.
  • bindings/objc/DOMCSSMediaRule.mm: Added.
  • bindings/objc/DOMCSSMediaRuleInternal.h: Added.
  • bindings/objc/DOMCSSPageRule.h: Added.
  • bindings/objc/DOMCSSPageRule.mm: Added.
  • bindings/objc/DOMCSSPageRuleInternal.h: Added.
  • bindings/objc/DOMCSSPrimitiveValue.h: Added.
  • bindings/objc/DOMCSSPrimitiveValue.mm: Added.
  • bindings/objc/DOMCSSPrimitiveValueInternal.h: Added.
  • bindings/objc/DOMCSSRule.h: Added.
  • bindings/objc/DOMCSSRule.mm: Added.
  • bindings/objc/DOMCSSRuleInternal.h: Added.
  • bindings/objc/DOMCSSRuleList.h: Added.
  • bindings/objc/DOMCSSRuleList.mm: Added.
  • bindings/objc/DOMCSSRuleListInternal.h: Added.
  • bindings/objc/DOMCSSStyleDeclaration.h: Added.
  • bindings/objc/DOMCSSStyleDeclaration.mm: Added.
  • bindings/objc/DOMCSSStyleDeclarationInternal.h: Added.
  • bindings/objc/DOMCSSStyleRule.h: Added.
  • bindings/objc/DOMCSSStyleRule.mm: Added.
  • bindings/objc/DOMCSSStyleRuleInternal.h: Added.
  • bindings/objc/DOMCSSStyleSheet.h: Added.
  • bindings/objc/DOMCSSStyleSheet.mm: Added.
  • bindings/objc/DOMCSSStyleSheetInternal.h: Added.
  • bindings/objc/DOMCSSUnknownRule.h: Added.
  • bindings/objc/DOMCSSUnknownRule.mm: Added.
  • bindings/objc/DOMCSSUnknownRuleInternal.h: Added.
  • bindings/objc/DOMCSSValue.h: Added.
  • bindings/objc/DOMCSSValue.mm: Added.
  • bindings/objc/DOMCSSValueInternal.h: Added.
  • bindings/objc/DOMCSSValueList.h: Added.
  • bindings/objc/DOMCSSValueList.mm: Added.
  • bindings/objc/DOMCSSValueListInternal.h: Added.
  • bindings/objc/DOMCounter.h: Added.
  • bindings/objc/DOMCounter.mm: Added.
  • bindings/objc/DOMCounterInternal.h: Added.
  • bindings/objc/DOMEvent.h: Added.
  • bindings/objc/DOMEvent.mm: Added.
  • bindings/objc/DOMEventInternal.h: Added.
  • bindings/objc/DOMEventListener.h: Added.
  • bindings/objc/DOMEventTarget.h: Added.
  • bindings/objc/DOMKeyboardEvent.h: Added.
  • bindings/objc/DOMKeyboardEvent.mm: Added.
  • bindings/objc/DOMKeyboardEventInternal.h: Added.
  • bindings/objc/DOMMouseEvent.h: Added.
  • bindings/objc/DOMMouseEvent.mm: Added.
  • bindings/objc/DOMMouseEventInternal.h: Added.
  • bindings/objc/DOMMutationEvent.h: Added.
  • bindings/objc/DOMMutationEvent.mm: Added.
  • bindings/objc/DOMMutationEventInternal.h: Added.
  • bindings/objc/DOMOverflowEvent.h: Added.
  • bindings/objc/DOMOverflowEvent.mm: Added.
  • bindings/objc/DOMOverflowEventInternal.h: Added.
  • bindings/objc/DOMProgressEvent.h: Added.
  • bindings/objc/DOMProgressEvent.mm: Added.
  • bindings/objc/DOMProgressEventInternal.h: Added.
  • bindings/objc/DOMRGBColor.h: Added.
  • bindings/objc/DOMRGBColor.mm: Added.
  • bindings/objc/DOMRGBColorInternal.h: Added.
  • bindings/objc/DOMRect.h: Added.
  • bindings/objc/DOMRect.mm: Added.
  • bindings/objc/DOMRectInternal.h: Added.
  • bindings/objc/DOMTextEvent.h: Added.
  • bindings/objc/DOMTextEvent.mm: Added.

(-[DOMTextEvent data]):
(-[DOMTextEvent initTextEvent:canBubbleArg:cancelableArg:viewArg:dataArg:]):

  • bindings/objc/DOMTextEventInternal.h: Added.
  • bindings/objc/DOMUIEvent.h: Added.
  • bindings/objc/DOMUIEvent.mm: Added.
  • bindings/objc/DOMUIEventInternal.h: Added.
  • bindings/objc/DOMWheelEvent.h: Added.
  • bindings/objc/DOMWheelEvent.mm: Added.
  • bindings/objc/DOMWheelEventInternal.h: Added.
5:00 PM Changeset in webkit [204053] by enrica@apple.com
  • 20 edits in trunk

Allow building with content filtering disabled.
https://bugs.webkit.org/show_bug.cgi?id=160454

Reviewed by Simon Fraser.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • platform/PlatformContentFilter.h:

(WebCore::PlatformContentFilter::unblockRequestDeniedScript):

  • platform/cocoa/NetworkExtensionContentFilter.h:
  • platform/cocoa/NetworkExtensionContentFilter.mm:

(WebCore::NetworkExtensionContentFilter::unblockHandler):

  • platform/cocoa/ParentalControlsContentFilter.h:
  • testing/MockContentFilter.h:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::blockedByContentFilterError):

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
  • Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::ArgumentCoder<KeypressCommand>::decode):
(IPC::ArgumentCoder<ContentFilterUnblockHandler>::encode):
(IPC::ArgumentCoder<ContentFilterUnblockHandler>::decode):

  • WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:

(WebKit::blockedByContentFilterError):

Tools:

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4:43 PM Changeset in webkit [204052] by dino@apple.com
  • 15 edits in trunk

Reapply fixes for webkit.org/b/159450 and webkit.org/b/157569
https://bugs.webkit.org/show_bug.cgi?id=160474
<rdar://problem/27668170>

Reviewed by Simon Fraser.

The fixes are behaviour we want. They just caused a regression
on medium.com (reverted in http://trac.webkit.org/r203380).

Now that we've branched, revert the reversion (which itself
was a reversion), so we can fix the actual bug:
https://bugs.webkit.org/show_bug.cgi?id=160478

Source/WebCore:

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseAnimationShorthand):
(WebCore::CSSParser::addPropertyWithPrefixingVariant):
(WebCore::CSSParser::parseTransitionShorthand):

  • css/CSSPropertyNames.in:
  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValueInternal):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValueInternal):

  • css/StyleProperties.cpp:

(WebCore::MutableStyleProperties::removeShorthandProperty):
(WebCore::StyleProperties::asText):
(WebCore::MutableStyleProperties::removeProperty): Deleted.
(WebCore::MutableStyleProperties::removePrefixedOrUnprefixedProperty): Deleted.
(WebCore::MutableStyleProperties::setProperty): Deleted.
(WebCore::getIndexInShorthandVectorForPrefixingVariant): Deleted.
(WebCore::MutableStyleProperties::appendPrefixingVariantProperty): Deleted.
(WebCore::MutableStyleProperties::setPrefixingVariantProperty): Deleted.

  • css/StyleProperties.h:

LayoutTests:

  • animations/fill-mode-forwards-zero-duration.html:
  • animations/play-state-start-paused.html:
  • animations/script-tests/spring-parsing.js:

(testSpring):

  • animations/spring-parsing-expected.txt:
  • animations/unprefixed-properties-expected.txt:
  • animations/unprefixed-properties.html:
  • fast/css/prefixed-unprefixed-variant-style-declaration-expected.txt:
  • fast/css/shorthand-omitted-initial-value-overrides-shorthand-expected.txt:
4:29 PM Changeset in webkit [204051] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.46

New tag.

4:03 PM Changeset in webkit [204050] by eric.carlson@apple.com
  • 8 edits
    2 adds in trunk

Cleanup HTMLMediaElement track lists.
https://bugs.webkit.org/show_bug.cgi?id=160470

Reviewed by David Kilzer.

Source/WebCore:

Test: media/range-extract-contents-crash.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement):

  • html/track/AudioTrack.cpp:

(WebCore::AudioTrack::willRemove): ASSERT if media element is NULL.

  • html/track/TextTrackList.cpp:

(TextTrackList::clearElement): Clear track media element pointers and client.

  • html/track/TextTrackList.h:
  • html/track/TrackListBase.cpp:

(TrackListBase::~TrackListBase): Call clearElement.
(TrackListBase::clearElement): Clear track media element pointers and client.

  • html/track/TrackListBase.h:

LayoutTests:

  • media/range-extract-contents-crash-expected.txt: Added.
  • media/range-extract-contents-crash.html: Added.
3:59 PM Changeset in webkit [204049] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Remove more Objective-C bindings that are not used
https://bugs.webkit.org/show_bug.cgi?id=160473

Reviewed by Sam Weinig.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMCSS.mm:

(kitClass):

  • dom/Document.idl:
3:55 PM Changeset in webkit [204048] by Chris Dumez
  • 10 edits in trunk

Drop custom bindings for FormData.append()
https://bugs.webkit.org/show_bug.cgi?id=160466

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

  • web-platform-tests/XMLHttpRequest/interfaces-expected.txt:

Source/WebCore:

Drop custom bindings for FormData.append(). We no longer need them now
that we have proper support for overloads after r204028.

This patch also fixes the fact that FormData.prototype.append.length
was 0 instead of 2.

No new tests, rebaselined existing test.

  • bindings/js/JSDOMFormDataCustom.cpp:

(WebCore::JSDOMFormData::append): Deleted.

  • html/DOMFormData.cpp:

(WebCore::DOMFormData::append):

  • html/DOMFormData.h:
  • html/DOMFormData.idl:
  • html/FileInputType.cpp:

(WebCore::FileInputType::appendFormData):

  • html/FormDataList.cpp:

(WebCore::FormDataList::appendBlob):

  • html/FormDataList.h:

(WebCore::FormDataList::Item::Item):
(WebCore::FormDataList::appendBlob):

3:42 PM Changeset in webkit [204047] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r203799.
https://bugs.webkit.org/show_bug.cgi?id=160467

Decided on a different solution (Requested by jonlee_ on
#webkit).

Reverted changeset:

"Captions do not render in PiP window when element is hidden"
https://bugs.webkit.org/show_bug.cgi?id=160265
http://trac.webkit.org/changeset/203799

3:23 PM Changeset in webkit [204046] by achristensen@apple.com
  • 4 edits in trunk/Source/WebCore

Remove unused functions in URL
https://bugs.webkit.org/show_bug.cgi?id=160468

Reviewed by Geoffrey Garen.

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::extractInnerURL):

  • platform/URL.cpp:

(WebCore::mimeTypeFromURL):
(WebCore::URL::stringCenterEllipsizedToLength):
(WebCore::URL::isSafeToSendToAnotherThread): Deleted.

  • platform/URL.h:

(WebCore::URL::operator NSString*):
(WebCore::URL::innerURL): Deleted.

3:23 PM Changeset in webkit [204045] by Chris Dumez
  • 14 edits in trunk

Named / Indexed properties should be configurable
https://bugs.webkit.org/show_bug.cgi?id=160457

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline several W3C tests now that more checks are passing.

  • web-platform-tests/dom/nodes/Document-getElementsByTagName-expected.txt:
  • web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt:

Source/WebCore:

Report Named / Indexed properties as being configurable to comply with
the Web IDL specification:

Firefox and Chrome also report them as being configurable.

No new tests, rebaselined existing tests.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateGetOwnPropertySlotBody):

LayoutTests:

Update / rebaseline existing tests to reflect behavior change.

  • fast/dom/NodeList/nodelist-name-getter-properties-expected.txt:
  • fast/dom/NodeList/nodelist-name-getter-properties.html:
  • js/dom/getOwnPropertyDescriptor-expected.txt:
  • js/resources/getOwnPropertyDescriptor.js:
3:16 PM Changeset in webkit [204044] by andersca@apple.com
  • 13 edits in trunk

Remove more unused/uninstalled Objective-C DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=160464

Reviewed by Darin Adler.

Source/WebCore:

  • Configurations/WebCore.xcconfig:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMCSS.mm:

(kitClass):

  • bindings/objc/DOMEvents.h:
  • bindings/objc/DOMEvents.mm:

(kitClass): Deleted.

  • dom/Document.idl:

Source/WebKit/mac:

Stop installing unused headers.

  • MigrateHeaders.make:

LayoutTests:

Update test results.

  • platform/mac/fast/dom/wrapper-classes-objc-expected.txt:
  • platform/mac/fast/dom/wrapper-classes-objc.html:
2:44 PM Changeset in webkit [204043] by Chris Dumez
  • 9 edits in trunk

[WebIDL] Extend new overload resolution algorithm support to constructors
https://bugs.webkit.org/show_bug.cgi?id=160455

Reviewed by Ryosuke Niwa.

Source/WebCore:

Extend new overload resolution algorithm support (added in r204028) to
constructors as well. It was only used for operations. Remove code that
is now dead from the bindings generator.

We now share the same code of generating the overload resolution code
for operations and constructors.

No new tests, rebaselined existing tests.

  • bindings/scripts/CodeGenerator.pm:

(LinkOverloadedFunctions):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateOverloadedFunctionOrConstructor):
(GenerateImplementation):
(GenerateConstructorDefinitions):
(GenerateConstructorDefinition):
(GetFunctionLength): Deleted.
(LengthOfLongestFunctionParameterList): Deleted.
(GetNativeTypeForConversions): Deleted.
(GetGnuVTableNameForInterface): Deleted.
(GetGnuMangledNameForInterface): Deleted.
(GetGnuVTableOffsetForType): Deleted.
(GenerateConstructorHelperMethods): Deleted.

  • bindings/scripts/IDLParser.pm:

(applyExtendedAttributeList): Deleted.

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::JSTestOverloadedConstructorsConstructor::construct):

  • bindings/scripts/test/TestOverloadedConstructors.idl:

LayoutTests:

Update / rebaseline existing test as we now provide slightly different
exception messages when given bad overloaded constructor parameters.

  • fast/canvas/canvas-imageData-expected.txt:
  • fast/canvas/script-tests/canvas-imageData.js:
2:33 PM Changeset in webkit [204042] by Ryan Haddad
  • 2 edits in branches/safari-602-branch/LayoutTests

Merge r203917. rdar://problem/27430381

2:28 PM Changeset in webkit [204041] by beidson@apple.com
  • 5 edits in trunk

Removing IndexedDB WebsiteData can fail for some users.
https://bugs.webkit.org/show_bug.cgi?id=160463

Reviewed by Alex Christensen.

Source/WebCore:

Covered by changes to API test IndexedDB.StoreBlobThenDelete.

For a few months in trunk WebKit, deleting an IndexedDB using WebsiteDataStore API would only
delete the "IndexedDB.sqlite3" file, but would leave the "-wal" and "-shm" files behind.

We'd then fail to delete the directory itself, tricking API clients to think there are still
databases in the given origin.

Furthermore, the code to delete a database first checks for the existence of "IndexedDB.sqlite3"
then refuses to do any further cleanup if it doesn't exist.

We should just always run the entire delete procedure even if IndexedDB.sqlite does not exist.

  • Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::removeAllDatabasesForOriginPath):

  • platform/sql/SQLiteFileSystem.cpp:

(WebCore::SQLiteFileSystem::deleteDatabaseFile):

Tools:

  • TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
2:17 PM Changeset in webkit [204040] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Fix Mac CMake build.

  • PlatformMac.cmake:

Some ObjC bindings have been frozen.

2:15 PM Changeset in webkit [204039] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Marking two media tests as flaky crashes on ios-simulator-wk2
https://bugs.webkit.org/show_bug.cgi?id=160367

Unreviewed test gardening.

  • platform/ios-simulator-wk2/TestExpectations:
1:26 PM Changeset in webkit [204038] by fred.wang@free.fr
  • 6 edits in trunk/Source/WebCore

More cleanup of MathML operator parsing
https://bugs.webkit.org/show_bug.cgi?id=160336

Patch by Frederic Wang <fwang@igalia.com> on 2016-08-02
Reviewed by Darin Adler.

No new tests, behavior is unchanged.

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::parseMathMLLength): Deleted. This function is no longer used.

  • rendering/mathml/RenderMathMLBlock.h: Ditto.
  • rendering/mathml/RenderMathMLFencedOperator.h: Move some length members from

RenderMathMLOperator and override the accessors. Also override useMathOperator() since it is
always true for anonymous mfenced operators.

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::textContent): No need to ASSERT !isAnonymous since this
function is overriden by RenderMathMLFencedOperator.
(WebCore::RenderMathMLOperator::isInvisibleOperator): Use a temporary variable to call
textContent only once.
(WebCore::RenderMathMLOperator::leadingSpace): Helper function to determine the leading space.
(WebCore::RenderMathMLOperator::trailingSpace): Helper function to determine the trailing space.
(WebCore::RenderMathMLOperator::minSize): Helper function to determine the min space.
(WebCore::RenderMathMLOperator::maxSize): Helper function to determine the max space.
(WebCore::RenderMathMLOperator::setOperatorProperties): This is now only used to set m_isVertical.
(WebCore::RenderMathMLOperator::stretchTo): Call maxSize and minSize when necessary.
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths): Call leadingSpace and trailingSpace.
(WebCore::RenderMathMLOperator::layoutBlock): Ditto.
(WebCore::RenderMathMLOperator::useMathOperator): Remove the case for anonymous operators as
this is now handled in the derived class.
(WebCore::RenderMathMLOperator::paint): Call leadingSpace.

  • rendering/mathml/RenderMathMLOperator.h: Remove length members and declare helper functions

to get these lengths from MathMLOperatorElement.
(WebCore::RenderMathMLOperator::setLeadingSpace): Deleted. This is no longer used.
(WebCore::RenderMathMLOperator::setTrailingSpace): Deleted. This is no longer used.

12:53 PM Changeset in webkit [204037] by fred.wang@free.fr
  • 9 edits in trunk

Move parsing of operator length attributes to MathMLOperatorElement
https://bugs.webkit.org/show_bug.cgi?id=160301

Patch by Frederic Wang <fwang@igalia.com> on 2016-08-02
Reviewed by Darin Adler.

Source/WebCore:

We move parsing of operator attributes lspace, rspace minsize, maxsize into the class
MathMLOperatorElement. We rely on the existing MathMLElement::Length structure and expand
it to handle the "infinity" case of maxsize that we always resolve as intMaxForLayoutUnit.
We also improve the resolution of a negative value for minsize and maxsize since the MathML
recommendation says it should be rounded up to the nearest valid value (which is zero)
instead of ignoring the attribute and using the default value. This is similar to r203285
for mfrac@linethickness. We also update the existing test for minsize/maxsize to take into
account that change.

No new tests, already covered by existing tests.

  • mathml/MathMLElement.h: Add an "Infinity" type for MathML Length.
  • mathml/MathMLOperatorElement.cpp:

(WebCore::MathMLOperatorElement::leadingSpace): Helper function to retrieve the cached value
for the lspace attribute, parse it if necessary.
(WebCore::MathMLOperatorElement::trailingSpace): Ditto for rspace.
(WebCore::MathMLOperatorElement::minSize): Ditto for minsize.
(WebCore::MathMLOperatorElement::maxSize): Ditto for maxsize. This attribute also accepts the
"infinity" value.
(WebCore::MathMLOperatorElement::parseAttribute): Mark attributes dirty.

  • mathml/MathMLOperatorElement.h: Declare Length members and accessors.
  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::toUserUnits): Resolve Infinity as intMaxForLayoutUnit.

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::setOperatorProperties): We use toUserUnits to resolve the
lengths. Negative maxsize and minsize values now fallback to 0 instead of their default
values. We also remove the !isAnonymous() check since setOperatorProperties is overriden
in the RenderMathMLFencedOperator class.

LayoutTests:

  • mathml/presentation/stretchy-minsize-maxsize-expected.html: Update the test for negative

minsize and maxsize to align on the behavior suggested in the MathML recommendation.

  • mathml/presentation/stretchy-minsize-maxsize.html: Ditto.
12:23 PM Changeset in webkit [204036] by fred.wang@free.fr
  • 2 edits in trunk/Source/WebCore

Unreviewed build error fix.

  • mathml/MathMLOperatorElement.cpp:

(WebCore::propertyFlagToAttributeName): Return a nullQName to avoid warnings on some platforms.

12:16 PM Changeset in webkit [204035] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Stop building Objective-C bindings that aren't exposed anywhere
https://bugs.webkit.org/show_bug.cgi?id=160458

Reviewed by Darin Adler.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
12:13 PM Changeset in webkit [204034] by Chris Dumez
  • 5 edits in trunk

HTMLCollection's named getter should only do 'name' attribute matching for HTMLElements
https://bugs.webkit.org/show_bug.cgi?id=160456

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

  • web-platform-tests/dom/nodes/Document-getElementsByTagName-expected.txt:

Rebaseline. We are still failing but on the next check.

  • web-platform-tests/dom/nodes/Element-children-expected.txt:

Rebaseline now that one more check is passing.

Source/WebCore:

HTMLCollection's named getter should only do 'name' attribute matching for HTMLElements:

Our slow path which relies on HTMLCollection::updateNamedElementCache() does the right
thing. However, we have a fast path in
CachedHTMLCollection<HTMLCollectionClass, traversalType>::namedItem() that was missing a
check.

Firefox and Chrome both behave correctly here.

No new tests, rebaselined existing tests.

  • html/CachedHTMLCollection.h:

(WebCore::traversalType>::namedItem):

12:12 PM WebKitIDL edited by Chris Dumez
StrictTypeChecking no longer exists as of r204033 (diff)
12:11 PM Changeset in webkit [204033] by Chris Dumez
  • 6 edits in trunk/Source/WebCore

Kill [StrictTypeChecking] IDL extended attribute
https://bugs.webkit.org/show_bug.cgi?id=160382

Reviewed by Darin Adler.

Kill [StrictTypeChecking] IDL extended attribute. Its only remaining
use was on DOMString parameters for a few CanvasRenderingContext2D
operations in order to work around a bug in our overload resolution.

However, as of r204028, we implement the Web IDL overload resolution
algorithm and [StrictTypeChecking] is now a no-op and is no longer
needed.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheckExpression):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/TestTypedefs.idl:
  • html/canvas/CanvasRenderingContext2D.idl:
11:47 AM Changeset in webkit [204032] by fred.wang@free.fr
  • 8 edits in trunk/Source/WebCore

Move parsing of boolean operator properties into MathMLOperatorElement
https://bugs.webkit.org/show_bug.cgi?id=160190

Patch by Frederic Wang <fwang@igalia.com> on 2016-08-02
Reviewed by Darin Adler.

No new tests, already covered by existing tests.

  • mathml/MathMLOperatorDictionary.h: Add a bit mask with all the property flags set.
  • mathml/MathMLOperatorElement.cpp:

(WebCore::attributeNameToPropertyFlag): helper function to map from attribute name to flag.
(WebCore::MathMLOperatorElement::computeOperatorFlag): Helper function to update one
bit of m_properties.flags from the corresponding boolean attribute. The default value is
taken from the operator dictionary data stored in m_dictionaryProperty.flags.
(WebCore::MathMLOperatorElement::hasProperty): Returns whether the operator has a property,
parsing it again if the corresponding attribute is dirty.
(WebCore::MathMLOperatorElement::childrenChanged): Make all properties dirty.
(WebCore::propertyFlagToAttributeName): helper function to map from flag to attribute name.
(WebCore::MathMLOperatorElement::parseAttribute): Make all properties dirty if the form
attribute changed. Make each property dirty when the corresponding attribute changed.
(WebCore::MathMLOperatorElement::flags): Deleted. Replaced with the finer hasProperty function.

  • mathml/MathMLOperatorElement.h: Define new structure, member and functions to handle

operator properties.

  • rendering/mathml/RenderMathMLFencedOperator.cpp:

(WebCore::RenderMathMLFencedOperator::RenderMathMLFencedOperator): Move m_operatorFlags from
the base class to the derived class.

  • rendering/mathml/RenderMathMLFencedOperator.h: Ditto.
  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::RenderMathMLOperator): Ditto.
(WebCore::RenderMathMLOperator::hasOperatorFlag): Just call hasOperatorFlag from the
MathMLOperatorElement class.
(WebCore::RenderMathMLOperator::setOperatorProperties): We do not initialize m_operatorFlags
since it has been removed from the base class. We also do not parse attributes since this
has been moved to the MathMLOperatorElement class.
(WebCore::RenderMathMLOperator::setOperatorFlagFromAttribute): Deleted.
(WebCore::RenderMathMLOperator::setOperatorFlagFromAttributeValue): Deleted.

  • rendering/mathml/RenderMathMLOperator.h: Move m_operatorFlags from the base class to the

derived class, remove some parsing helper functions and update hasOperatorFlag to make it
overridable.

10:42 AM Changeset in webkit [204031] by andersca@apple.com
  • 4 edits
    28 adds in trunk/Source/WebCore

Freeze another bunch of Objective-C binding files
https://bugs.webkit.org/show_bug.cgi?id=160435

Reviewed by Alex Christensen.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMAbstractView.h: Added.
  • bindings/objc/DOMAbstractView.mm:
  • bindings/objc/DOMAbstractViewInternal.h: Added.
  • bindings/objc/DOMMediaList.h: Added.
  • bindings/objc/DOMMediaList.mm: Added.
  • bindings/objc/DOMMediaListInternal.h: Added.
  • bindings/objc/DOMNodeFilter.h: Added.
  • bindings/objc/DOMNodeIterator.h: Added.
  • bindings/objc/DOMNodeIterator.mm: Added.
  • bindings/objc/DOMNodeIteratorInternal.h: Added.
  • bindings/objc/DOMRange.h: Added.
  • bindings/objc/DOMRange.mm: Added.
  • bindings/objc/DOMRangeInternal.h: Added.
  • bindings/objc/DOMStyleSheet.h: Added.
  • bindings/objc/DOMStyleSheet.mm: Added.
  • bindings/objc/DOMStyleSheetInternal.h: Added.
  • bindings/objc/DOMStyleSheetList.h: Added.
  • bindings/objc/DOMStyleSheetList.mm: Added.
  • bindings/objc/DOMStyleSheetListInternal.h: Added.
  • bindings/objc/DOMTreeWalker.h: Added.
  • bindings/objc/DOMTreeWalker.mm: Added.
  • bindings/objc/DOMTreeWalkerInternal.h: Added.
  • bindings/objc/DOMXPathExpression.h: Added.
  • bindings/objc/DOMXPathExpression.mm: Added.
  • bindings/objc/DOMXPathExpressionInternal.h: Added.
  • bindings/objc/DOMXPathNSResolver.h: Added.
  • bindings/objc/DOMXPathResult.h: Added.
  • bindings/objc/DOMXPathResult.mm: Added.
  • bindings/objc/DOMXPathResultInternal.h: Added.
10:27 AM Changeset in webkit [204030] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[MathML] Use more auto for local variables
https://bugs.webkit.org/show_bug.cgi?id=160453

Patch by Frederic Wang <fwang@igalia.com> on 2016-08-02
Reviewed by Darin Adler.

No new tests, behavior is unchanged.

  • mathml/MathMLElement.cpp:

(WebCore::MathMLElement::colSpan):
(WebCore::MathMLElement::rowSpan):
(WebCore::MathMLElement::childShouldCreateRenderer):
(WebCore::MathMLElement::defaultEventHandler):

  • mathml/MathMLSelectElement.cpp:

(WebCore::MathMLSelectElement::getSelectedActionChild):
(WebCore::MathMLSelectElement::getSelectedSemanticsChild):

  • rendering/mathml/RenderMathMLFenced.cpp:

(WebCore::RenderMathMLFenced::updateFromElement):

10:03 AM Changeset in webkit [204029] by Ryan Haddad
  • 2 edits in trunk/Source/WebCore

Attempt to fix build after r204014.

Unreviewed build fix.

  • loader/mac/ResourceLoaderMac.mm:

(WebCore::ResourceLoader::willCacheResponse):

10:02 AM Changeset in webkit [204028] by Chris Dumez
  • 32 edits in trunk

[WebIDL] Implement overload resolution algorithm
https://bugs.webkit.org/show_bug.cgi?id=160394

Reviewed by Darin Adler.

Source/WebCore:

Implement overload resolution algorithm:

This means that our support for operation overloading in our IDL is
now a lot more extensive than it used to be and is now compliant with
the Web IDL specification.

In particular, overloading should now work for a lot more parameter
types which means that:

  • We should be able to drop some custom bindings code in a follow-up patch.
  • We will be able to drop the [StrictTypeChecking] attribute which was a hack used to make overloading work for parameters of type DOMString.

Also, the order of the overloads in the IDL no longer impacts the
generated bindings code. It used to be that you needed to put the
overloads with the more specific parameter types first in order for the
generated bindings code to be somewhat correct.

No new tests, rebaselined bindings tests.

  • bindings/scripts/CodeGenerator.pm:

(IsStringOrEnumType):

  • bindings/scripts/CodeGeneratorJS.pm:

(IsNullableType):
(StripNullable):
(ComputeEffectiveOverloadSet):
(AreTypesDistinguishableForOverloadResolution):
(GetDistinguishingArgumentIndex):
(GetOverloadThatMatches):
(GenerateOverloadedFunction):

  • bindings/scripts/test/JS/JSTestGlobalObject.cpp:

(WebCore::jsTestGlobalObjectInstanceFunctionEnabledAtRuntimeOperation):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionEnabledAtRuntimeOperation):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethodWithOptionalParameter1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethodWithOptionalParameter):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionTestPromiseOverloadedFunction):
(WebCore::jsTestObjConstructorFunctionOverloadedMethod12): Deleted.
(WebCore::jsTestObjPrototypeFunctionTestPromiseOverloadedFunction2Promise): Deleted.

  • bindings/scripts/test/TestObj.idl:
  • dom/EventTarget.h:
  • dom/EventTarget.idl:
  • html/HTMLOptionsCollection.h:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLSelectElement.h:

(WebCore::HTMLSelectElement::add):

  • html/HTMLSelectElement.idl:

LayoutTests:

Update / Rebaseline existing test. There is no major behavior change.
We sometimes get a different exception message than we used to.

  • fast/canvas/canvas-clip-path-expected.txt:
  • fast/canvas/canvas-fill-path-expected.txt:
  • fast/canvas/canvas-path-addPath-expected.txt:
  • fast/canvas/canvas-path-isPointInPath-expected.txt:
  • fast/canvas/canvas-path-isPointInStroke-expected.txt:
  • fast/canvas/canvas-putImageData-expected.txt:
  • fast/canvas/canvas-putImageData.js:
  • fast/canvas/canvas-stroke-path-expected.txt:
  • fast/canvas/webgl/script-tests/texImageTest.js:
  • fast/canvas/webgl/texImageTest-expected.txt:
  • fast/dom/HTMLSelectElement/add-expected.txt:
  • fast/dom/HTMLSelectElement/add.html:
  • fast/dom/HTMLSelectElement/options-collection-add-expected.txt:
  • fast/dom/HTMLSelectElement/options-collection-add.html:
  • fast/dom/incompatible-operations-expected.txt:
  • js/dom/select-options-add-expected.txt:
  • webaudio/audiobuffer-expected.txt:
  • webaudio/audiobuffer.html:
  • webgl/1.0.2/resources/webgl_test_files/conformance/textures/tex-image-with-invalid-data.html:
9:57 AM Changeset in webkit [204027] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

[macOS] Guard workaround in r203314 for only OSes which need it
https://bugs.webkit.org/show_bug.cgi?id=160440

Reviewed by Simon Fraser.

The workarond introduced in r203314 only needs to be applied on
certain OSes.

No new tests because there is no behavior change.

  • platform/text/mac/TextBoundaries.mm:

(WebCore::findNextWordFromIndex):

8:46 AM Changeset in webkit [204026] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove CachedResourceRequest initiatingDocumentLoader
https://bugs.webkit.org/show_bug.cgi?id=160449

Patch by Youenn Fablet <youenn@apple.com> on 2016-08-02
Reviewed by Alex Christensen.

No change of behavior.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::startLoadingMainResource): Removing call to setInitiator.

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::setInitiator): Deleted.

  • loader/cache/CachedResourceRequest.h:

(WebCore::CachedResourceRequest::initiatingDocumentLoader): Deleted.

8:37 AM Changeset in webkit [204025] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

[ARM] Disable Inline Caching on ARMv7 traditional until proper fix
https://bugs.webkit.org/show_bug.cgi?id=159759

Reviewed by Saam Barati.

  • jit/JITMathIC.h:

(JSC::JITMathIC::generateInline):

8:15 AM EnvironmentVariables edited by clopez@igalia.com
(diff)
6:22 AM Changeset in webkit [204024] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed test gardening.

Update test expectations on Windows for many failing tests. These failures are tracked in
https://bugs.webkit.org/show_bug.cgi?id=160447.

  • platform/win/TestExpectations:
5:45 AM Changeset in webkit [204023] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

Skip fetch API worker tests in Debug mode
https://bugs.webkit.org/show_bug.cgi?id=160448

Unreviewed.

Patch by Youenn Fablet <youenn@apple.com> on 2016-08-02

LayoutTests/imported/w3c:

  • web-platform-tests/fetch/api/cors/cors-cookies-worker-expected.txt: Rebasing

LayoutTests:

4:28 AM MathML/Early_2016_Refactoring edited by fred.wang@free.fr
(diff)
4:27 AM Changeset in webkit [204022] by fred.wang@free.fr
  • 10 edits in trunk/Source/WebCore

Move parsing of the form attribute to MathMLOperatorElement
https://bugs.webkit.org/show_bug.cgi?id=160239

Patch by Frederic Wang <fwang@igalia.com> on 2016-07-28
Reviewed by Darin Adler.

We move the parsing of the mo@form attribute to the MathMLOperatorElement class. Note that
when the attribute is not explicit, the form may also be guessed by searching into the
operator dictionary. Hence we also start moving the determination of the default dictionary
properties. Moving the actual parsing of the corresponding attributes will be done in
follow-up commits.

No new tests, already covered by existing tests.

  • mathml/MathMLInlineContainerElement.cpp:

(WebCore::MathMLInlineContainerElement::childrenChanged): Make the form of operators dirty
if its siblings have changed.

  • mathml/MathMLOperatorDictionary.cpp:

(WebCore::MathMLOperatorDictionary::search): Merge old getEntry functions into one helper
function that returns an Optional<Entry>.
(WebCore::MathMLOperatorDictionary::getEntry): Deleted

  • mathml/MathMLOperatorDictionary.h: Declare MathMLOperatorDictionary::find.
  • mathml/MathMLOperatorElement.cpp:

(WebCore::MathMLOperatorElement::dictionaryProperty): We determine the operator form by
parsing the corresponding attribute or by using heuristics if that attribute is not
specified. We also read dictionary the corresponding dictionary properties.
(WebCore::MathMLOperatorElement::flags): Return the flags read from the dictionary.
(WebCore::MathMLOperatorElement::defaultLeadingSpace): Return the space read from the dictionary.
(WebCore::MathMLOperatorElement::defaultTrailingSpace): Return the space read from the dictionary.
(WebCore::MathMLOperatorElement::childrenChanged): Make the dictionary properties dirty.
(WebCore::MathMLOperatorElement::parseAttribute): Make the dictionary properties dirty when
the form changes.

  • mathml/MathMLOperatorElement.h: New member to store dictionary properties and expose them.
  • rendering/mathml/RenderMathMLFencedOperator.cpp:

(WebCore::RenderMathMLFencedOperator::setOperatorProperties): We implement the case specific
to anonymous mfenced operators here.

  • rendering/mathml/RenderMathMLFencedOperator.h: Move the m_operatorForm member here and

declare the overriden function setOperatorProperties.

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::setOperatorProperties): Simplify this code since the logic
has been moved to the element classes.
(WebCore::RenderMathMLOperator::setOperatorPropertiesFromOpDictEntry): Deleted.

  • rendering/mathml/RenderMathMLOperator.h: Remove setOperatorPropertiesFromOpDictEntry, make

members accessible to RenderMathMLFencedOperator and remove m_operatorForm.

2:43 AM Changeset in webkit [204021] by fred.wang@free.fr
  • 17 edits in trunk/Source/WebCore

Use Optional members to store parsed MathML attributes.
https://bugs.webkit.org/show_bug.cgi?id=160400

Patch by Frederic Wang <fwang.igalia.com> on 2016-08-02
Reviewed by Darin Adler.

Parsed MathML attributes are stored on the element classes using the memoize pattern to
minimize the number of parsing updates. Currently, a dirty flag for each member
indicate when it must be parsed again. We change this to wrap these members into an
Optional<T> container instead, where a null value indicates that the member is dirty.

No new tests, behavior is unchanged.

  • mathml/MathMLElement.cpp:

(WebCore::MathMLElement::cachedMathMLLength):
(WebCore::MathMLElement::cachedBooleanAttribute):
(WebCore::MathMLElement::parseMathVariantAttribute):
(WebCore::MathMLElement::specifiedDisplayStyle):
(WebCore::MathMLElement::specifiedMathVariant):

  • mathml/MathMLElement.h:
  • mathml/MathMLFractionElement.cpp:

(WebCore::MathMLFractionElement::lineThickness):
(WebCore::MathMLFractionElement::cachedFractionAlignment):
(WebCore::MathMLFractionElement::parseAttribute):

  • mathml/MathMLFractionElement.h:
  • mathml/MathMLInlineContainerElement.cpp:

(WebCore::MathMLInlineContainerElement::parseAttribute):

  • mathml/MathMLMathElement.cpp:

(WebCore::MathMLMathElement::specifiedDisplayStyle):
(WebCore::MathMLMathElement::parseAttribute):

  • mathml/MathMLOperatorElement.cpp:

(WebCore::MathMLOperatorElement::operatorText):

  • mathml/MathMLPaddedElement.cpp:

(WebCore::MathMLPaddedElement::parseAttribute):

  • mathml/MathMLPaddedElement.h:
  • mathml/MathMLScriptsElement.cpp:

(WebCore::MathMLScriptsElement::parseAttribute):

  • mathml/MathMLScriptsElement.h:
  • mathml/MathMLSpaceElement.cpp:

(WebCore::MathMLSpaceElement::parseAttribute):

  • mathml/MathMLSpaceElement.h:
  • mathml/MathMLTextElement.cpp:

(WebCore::MathMLTextElement::parseAttribute):

  • mathml/MathMLUnderOverElement.cpp:

(WebCore::MathMLUnderOverElement::parseAttribute):

  • mathml/MathMLUnderOverElement.h:
  • rendering/mathml/MathMLStyle.cpp:

(WebCore::MathMLStyle::resolveMathMLStyle):

  • rendering/mathml/MathMLStyle.h:
  • rendering/mathml/RenderMathMLToken.cpp:

(WebCore::mathVariant):
(WebCore::RenderMathMLToken::updateMathVariantGlyph):

1:07 AM Changeset in webkit [204020] by commit-queue@webkit.org
  • 8 edits
    5 adds in trunk

[Fetch API] Fetch promises should not reject or resolve when ActiveDOMObjects are being stopped
https://bugs.webkit.org/show_bug.cgi?id=160420

Patch by Youenn Fablet <youenn@apple.com> on 2016-08-02
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

  • web-platform-tests/fetch/api/cors/cors-preflight-redirect-worker-expected.txt: Added.
  • web-platform-tests/fetch/nosniff/worker-expected.txt: Added.

Source/WebCore:

Test: http/tests/fetch/fetch-in-worker-crash.html

Promises should not be rejected when FetchResponse/FetchRequest are stopped as ActiveDOMObject.

  • Modules/fetch/FetchBody.h:

(WebCore::FetchBody::cleanConsumePromise): Allowing to nullify the promise used to consume body.

  • Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::stop): Nullifying the body consume promise if any.

  • Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::BodyLoader::stop): Nullifying the fetch promise if any.

LayoutTests:

  • TestExpectations:
  • http/tests/fetch/fetch-in-worker-crash-expected.txt: Added.
  • http/tests/fetch/fetch-in-worker-crash.html: Added.
  • http/tests/fetch/fetch-in-worker.js: Added.

(onmessage):

  • platform/ios-simulator-wk2/imported/w3c/web-platform-tests/fetch/api/cors/cors-basic-worker-expected.txt:
12:20 AM Changeset in webkit [204019] by commit-queue@webkit.org
  • 23 edits
    5 adds in trunk

[Fetch API] Add support to ReferrerPolicy
https://bugs.webkit.org/show_bug.cgi?id=160404

Patch by Youenn Fablet <youenn@apple.com> on 2016-08-02
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

  • web-platform-tests/fetch/api/basic/referrer-expected.txt: Added.
  • web-platform-tests/fetch/api/basic/referrer-worker-expected.txt: Added.
  • web-platform-tests/fetch/api/basic/referrer-worker.html: Added.
  • web-platform-tests/fetch/api/basic/referrer.html: Added.
  • web-platform-tests/fetch/api/basic/referrer.js: Added.

(runTest):

  • web-platform-tests/fetch/api/cors/cors-preflight-referrer-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-preflight-referrer-worker-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-preflight-referrer.js:

(corsPreflightReferrer): fix infrastructure bug in test and fix expected referrer policy in default case.

  • web-platform-tests/fetch/api/cors/cors-preflight-worker-expected.txt:

Source/WebCore:

Tests: imported/w3c/web-platform-tests/fetch/api/basic/referrer-worker.html

imported/w3c/web-platform-tests/fetch/api/basic/referrer.html

Refactored ThreadableLoader API to take more references.

Updated loading code in CachedResource to take into account referrer policy, that can be set by fetch API.
To enable correct handling of OriginWhenCrossOrigin policy, the computation of the cross-origin status of a request is
moved from ResourceLoader to CachedResource.

Referrer is passed to the loading code through HTTP headers.
This was triggering preflighting for Workers request as WorkerThreadableLoader was setting the referrer.
It is now done in DocumentThreadableLoader::loadRequest so that preflighting is done before setting the referrer.
Note that this referrer setting is only a way to pass a specific referrer value to the loading code.
CachedResource code will compute the actual referer value based on the referrer policy.
It might be good in the future to have a different way of conveying this information to CachedResource, maybe
through CachedResourceRequest.

  • Modules/fetch/FetchLoader.cpp:

(WebCore::FetchLoader::start): Refactoring of ThreadableLoader API.

  • Modules/fetch/FetchRequest.cpp:

(WebCore::FetchRequest::internalRequest): Setting referrer if it has a specific value.

  • fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::start): Ractoring of ThreadableLoader API.

  • loader/CrossOriginPreflightChecker.cpp:

(WebCore::CrossOriginPreflightChecker::startPreflight): Set referrer in the preflight request if any.
(WebCore::CrossOriginPreflightChecker::doPreflight): Ditto.

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadResourceSynchronously): Refactoring of ThreadableLoader API.
(WebCore::DocumentThreadableLoader::create): Ditto.
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Ditto.
(WebCore::DocumentThreadableLoader::loadRequest): Ditto.

  • loader/DocumentThreadableLoader.h:

(WebCore::DocumentThreadableLoader::referrer): Storing referrer in case one is defined.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::init): Removing of cross origin computation since it is done earlier in CachedResource.

  • loader/ThreadableLoader.cpp:

(WebCore::ThreadableLoader::create): Refactoring of ThreadableLoader API.
(WebCore::ThreadableLoader::loadResourceSynchronously): Ditto.

  • loader/ThreadableLoader.h:
  • loader/ThreadableLoaderClientWrapper.h:

(WebCore::ThreadableLoaderClientWrapper::create): Ditto.
(WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper): Ditto.

  • loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::WorkerThreadableLoader): Ditto.
(WebCore::WorkerThreadableLoader::loadResourceSynchronously): Removing setting of referrer in header and passing
it as a parameter.
(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): Ditto.

  • loader/WorkerThreadableLoader.h:

(WebCore::WorkerThreadableLoader::create): Refactoring of ThreadableLoader API.

  • loader/cache/CachedResource.cpp:

(WebCore::addAdditionalRequestHeadersToRequest): Computation of referrer based on referrer policy.
(WebCore::CachedResource::addAdditionalRequestHeaders): Ditto.
(WebCore::CachedResource::load): Computation of cross origin status.
(WebCore::CachedResource::varyHeaderValuesMatch):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::options):

  • page/EventSource.cpp:

(WebCore::EventSource::connect): Refactoring of ThreadableLoader API.

  • workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::loadSynchronously): Ditto.
(WebCore::WorkerScriptLoader::loadAsynchronously): Ditto.

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createRequest): Ditto.

12:19 AM Changeset in webkit [204018] by beidson@apple.com
  • 25 edits
    2 adds in trunk/Source

Refactor data passed along for a "GetRecord" request.
https://bugs.webkit.org/show_bug.cgi?id=160352

Reviewed by Tim Horton.

Source/WebCore:

No new tests (No behavior change).

Adding this new object lets us easily add new data passed along for GetRecord
requests going forward.

  • WebCore.xcodeproj/project.pbxproj:
  • CMakeLists.txt:
  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::get):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::requestGetRecord):
(WebCore::IDBTransaction::requestIndexRecord):
(WebCore::IDBTransaction::getRecordOnServer):

  • Modules/indexeddb/IDBTransaction.h:
  • Modules/indexeddb/client/IDBConnectionProxy.cpp:

(WebCore::IDBClient::IDBConnectionProxy::getRecord):

  • Modules/indexeddb/client/IDBConnectionProxy.h:
  • Modules/indexeddb/client/IDBConnectionToServer.cpp:

(WebCore::IDBClient::IDBConnectionToServer::getRecord):

  • Modules/indexeddb/client/IDBConnectionToServer.h:
  • Modules/indexeddb/client/IDBConnectionToServerDelegate.h:
  • Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::getRecord):

  • Modules/indexeddb/server/IDBServer.h:
  • Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::getRecord):

  • Modules/indexeddb/server/UniqueIDBDatabase.h:
  • Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:

(WebCore::IDBServer::UniqueIDBDatabaseTransaction::getRecord):

  • Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h:
  • Modules/indexeddb/shared/IDBGetRecordData.cpp: Added.

(WebCore::IDBGetRecordData::isolatedCopy):

  • Modules/indexeddb/shared/IDBGetRecordData.h: Added.

(WebCore::IDBGetRecordData::encode):
(WebCore::IDBGetRecordData::decode):

  • Modules/indexeddb/shared/InProcessIDBServer.cpp:

(WebCore::InProcessIDBServer::getRecord):

  • Modules/indexeddb/shared/InProcessIDBServer.h:

Source/WebKit2:

  • DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp:

(WebKit::WebIDBConnectionToClient::getRecord):

  • DatabaseProcess/IndexedDB/WebIDBConnectionToClient.h:
  • DatabaseProcess/IndexedDB/WebIDBConnectionToClient.messages.in:
  • WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:

(WebKit::WebIDBConnectionToServer::getRecord):

  • WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
Note: See TracTimeline for information about the timeline view.