⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 12, 2016:

11:11 PM Changeset in webkit [204444] by Gyuyoung Kim
  • 3 edits in trunk/Tools

Skip to check directories existence in build-webkit
​https://bugs.webkit.org/show_bug.cgi?id=160691

Reviewed by Alex Christensen.

CMake checks if directories are there itself. So CMake ports
don't need to check it in the build-webkit script.

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:

(determineSourceDir):
(isCMakeBuild):

10:05 PM Changeset in webkit [204443] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.50.0.3

New tag.

10:01 PM Changeset in webkit [204442] by bshafiei@apple.com
  • 5 edits in branches/safari-602.1.50.0-branch/Source

Versioning.

9:20 PM Changeset in webkit [204441] by Chris Dumez
  • 21 edits
    1 add in trunk

getElementsByTagName() should take a qualifiedName in parameter
​https://bugs.webkit.org/show_bug.cgi?id=160682

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

  • web-platform-tests/dom/nodes/Document-getElementsByTagName-expected.txt:
  • web-platform-tests/dom/nodes/Document-getElementsByTagName-xhtml-expected.txt:
  • web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt:
  • web-platform-tests/dom/nodes/case-expected.txt:

Rebaseline several W3C tests now that more checks are passing.

  • web-platform-tests/dom/nodes/Document-getElementsByTagName-xhtml.xhtml:

Re-sync this test from upstream as it was outdated after:

Source/WebCore:

getElementsByTagName() should take a qualifiedName in parameter, not a
localName, according to the latest DOM specification:

The new behavior matches Firefox and Edge. There is a slight
compatiblity risk but we should give it a try.

No new tests, rebaselined existing tests.

  • WebCore.xcodeproj/project.pbxproj:
  • dom/AllDescendantsCollection.h: Added.
  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::getElementsByTagName):
(WebCore::ContainerNode::getElementsByTagNameNS):

  • dom/Node.cpp:

(WebCore::NodeListsNodeData::invalidateCaches):

  • dom/NodeRareData.h:

(WebCore::NodeListsNodeData::addCachedTagCollectionNS):
(WebCore::NodeListsNodeData::removeCachedTagCollectionNS):
(WebCore::NodeListsNodeData::adoptDocument):
(WebCore::NodeListsNodeData::deleteThisAndUpdateNodeRareDataIfAboutToRemoveLastList):

  • dom/TagCollection.cpp:

(WebCore::makeQualifiedName):
(WebCore::splitQualifiedName):
(WebCore::TagCollectionNS::TagCollectionNS):
(WebCore::TagCollectionNS::~TagCollectionNS):
(WebCore::TagCollection::TagCollection):
(WebCore::TagCollection::~TagCollection):
(WebCore::HTMLTagCollection::HTMLTagCollection):
(WebCore::HTMLTagCollection::~HTMLTagCollection):

  • dom/TagCollection.h:

(WebCore::TagCollection::elementMatches):
(WebCore::TagCollectionNS::elementMatches):
(WebCore::HTMLTagCollection::elementMatches):

  • html/CollectionType.h:
  • html/GenericCachedHTMLCollection.cpp:

(WebCore::GenericCachedHTMLCollection<traversalType>::elementMatches):

  • html/HTMLCollection.cpp:

(WebCore::invalidationTypeExcludingIdAndNameAttributes):

LayoutTests:

Update existing tests to reflect behavior change.

  • fast/dom/getElementsByClassName/010.xml:
  • fast/dom/getElementsByClassName/011.xml:
8:05 PM Changeset in webkit [204440] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Remove always true JSC::Debugger::needPauseHandling virtual method
​https://bugs.webkit.org/show_bug.cgi?id=160822

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-12
Reviewed by Mark Lam.

Source/JavaScriptCore:

All subclasses return true for this method. Just remove the method.

  • debugger/Debugger.cpp:

(JSC::Debugger::pauseIfNeeded):

  • inspector/ScriptDebugServer.h:

Source/WebKit/mac:

  • WebView/WebScriptDebugger.h:
7:14 PM Changeset in webkit [204439] by sbarati@apple.com
  • 35 edits
    6 adds in trunk

Inline store loop for CopyRest in DFG and FTL for certain array modes
​https://bugs.webkit.org/show_bug.cgi?id=159612

Reviewed by Filip Pizlo.

JSTests:

  • stress/rest-parameter-having-a-bad-time.js: Added.
  • stress/rest-parameter-many-arguments.js: Added.
  • stress/rest-parameter-various-types.js: Added.

Source/JavaScriptCore:

This patch changes the old copy_rest bytecode to actually allocate the rest array itself.
The bytecode is now called create_rest with an analogous CreateRest node in the DFG/FTL.
This allows the bytecode to be in control of what type of indexingType the array is allocated
with. We always allocate using ArrayWithContiguous storage unless we're havingABadTime().
This also makes allocating and writing into the array fast. On the fast path, the DFG/FTL
JIT will fast allocate the array and its storage, and we will do a memmove from the rest
region of arguments into the array's storage.

I'm seeing a 1-2% speedup on ES6SampleBench, and about a 2x speedup
on micro benchmarks that just test rest creation speed.

  • bytecode/BytecodeList.json:
  • bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitRestParameter):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCallArrayAllocatorSlowPathGenerator.h:

(JSC::DFG::CallArrayAllocatorWithVariableSizeSlowPathGenerator::CallArrayAllocatorWithVariableSizeSlowPathGenerator):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::uses):
(JSC::DFG::Graph::isWatchingHavingABadTimeWatchpoint):
(JSC::DFG::Graph::compilation):

  • dfg/DFGNode.h:

(JSC::DFG::Node::numberOfArgumentsToSkip):

  • dfg/DFGNodeType.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCreateClonedArguments):
(JSC::DFG::SpeculativeJIT::compileCreateRest):
(JSC::DFG::SpeculativeJIT::compileGetRestLength):
(JSC::DFG::SpeculativeJIT::compileCopyRest): Deleted.

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileArithRandom):
(JSC::DFG::SpeculativeJIT::compileAllocateNewArrayWithSize):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileArithRandom):
(JSC::DFG::SpeculativeJIT::compileAllocateNewArrayWithSize):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateClonedArguments):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateRest):
(JSC::FTL::DFG::LowerDFGToB3::compileGetRestLength):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayBuffer):
(JSC::FTL::DFG::LowerDFGToB3::compileAllocateArrayWithSize):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayWithSize):
(JSC::FTL::DFG::LowerDFGToB3::compileCopyRest): Deleted.

  • interpreter/CallFrame.h:

(JSC::ExecState::addressOfArgumentsStart):
(JSC::ExecState::argument):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_argument_count):
(JSC::JIT::emit_op_create_rest):
(JSC::JIT::emit_op_copy_rest): Deleted.

  • jit/JITOperations.h:
  • llint/LowLevelInterpreter.asm:
  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/CommonSlowPaths.h:

LayoutTests:

  • js/regress/rest-parameter-construction-performance-expected.txt: Added.
  • js/regress/rest-parameter-construction-performance.html: Added.
  • js/regress/script-tests/rest-parameter-construction-performance.js: Added.

(foo):
(test1):
(test2.foo):
(test2):

7:02 PM Changeset in webkit [204438] by rniwa@webkit.org
  • 7 edits in trunk/Source/JavaScriptCore

Add a helper class for enumerating elements in an iterable object
​https://bugs.webkit.org/show_bug.cgi?id=160800

Reviewed by Benjamin Poulain.

Added iteratorForIterable which provides an abstraction for iterating over an iterable object,
and deployed it in the constructors of Set, WeakSet, Map, and WeakMap.

Also added a helper function iteratorForIterable, which retrieves the iterator out of an iterable object.

  • runtime/IteratorOperations.cpp:

(JSC::iteratorForIterable): Added.

  • runtime/IteratorOperations.h:

(JSC::forEachInIterable): Added.

  • runtime/MapConstructor.cpp:

(JSC::constructMap):

  • runtime/SetConstructor.cpp:

(JSC::constructSet):

  • runtime/WeakMapConstructor.cpp:

(JSC::constructWeakMap):

  • runtime/WeakSetConstructor.cpp:

(JSC::constructWeakSet):

5:56 PM Changeset in webkit [204437] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Add application/vnd.api+json as a valid JSON MIME-type
​https://bugs.webkit.org/show_bug.cgi?id=160834
rdar://problem/27608536

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/CodeMirrorAdditions.js: Add Add application/vnd.api+json to extraJSONTypes.
5:11 PM Changeset in webkit [204436] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.50.0.2

New tag.

5:08 PM Changeset in webkit [204435] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.50.1.2

New tag.

4:54 PM Changeset in webkit [204434] by keith_miller@apple.com
  • 8 edits
    27545 adds
    1 delete in branches/safari-602-branch

Merge r203972.

2016-08-01 Keith Miller <​keith_miller@apple.com>

We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
​https://bugs.webkit.org/show_bug.cgi?id=160372

Rubber stamped by Geoffrey Garen.

This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
a new top level directory, JSTests. Having the tests in the Source directory
was both confusing and inconvenient for people that just want to checkout the
source code of WebKit. Since there is no other obvious place to put all the
JavaScript tests a new top level directory seemed the most sensible.

  • JSTests/: Copied from Source/JavaScriptCore/tests.
  • Source/JavaScriptCore/tests/: Deleted.
  • Scripts/import-test262-tests:
  • Scripts/run-javascriptcore-tests:
  • Scripts/update-javascriptcore-test-res:
4:35 PM Changeset in webkit [204433] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WTF

Make variant only available when compiling for C++14 or greater
​https://bugs.webkit.org/show_bug.cgi?id=160813

Patch by Sam Weinig <​sam@webkit.org> on 2016-08-12
Reviewed by Anders Carlsson.

  • wtf/Compiler.h:
  • wtf/StdLibExtras.h:
  • wtf/Variant.h:
4:34 PM Changeset in webkit [204432] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

[Cocoa] Instances of WKObject subclasses don’t work correctly with CFGetTypeID()
​https://bugs.webkit.org/show_bug.cgi?id=160820
<rdar://problem/27825875>

Reviewed by Anders Carlsson.

  • Shared/Cocoa/WKObject.mm:

(-[WKObject _cfTypeID]): Override this internal method and forward to the target object.

4:12 PM Changeset in webkit [204431] by achristensen@apple.com
  • 5 edits in trunk

Make URLParser work with URLs missing URL parts
​https://bugs.webkit.org/show_bug.cgi?id=160824

Reviewed by Brady Eidson.

Source/WebCore:

My initial implementation of URLParser didn't work correctly with URLs missing parts,
like a URL with no fragment, or a URL with no query. This fixes and tests parsing such URLS.
Covered by new API tests.

  • platform/URLParser.cpp:

(WebCore::URLParser::parse):
(WebCore::URLParser::allValuesEqual):

  • platform/URLParser.h:

(WebCore::URLParser::parse):

Tools:

  • TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::s):
(TestWebKitAPI::checkURL):
(TestWebKitAPI::TEST_F):
(TestWebKitAPI::eq): Deleted.

4:08 PM Changeset in webkit [204430] by wilander@apple.com
  • 2 edits in trunk/Tools

Add HashCountedSet API tests to TestWTFLibrary target
​https://bugs.webkit.org/show_bug.cgi?id=160815

Reviewed by Alex Christensen.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Added HashCountedSet.cpp and sorted the file reference section
according to UNIX sort.

3:55 PM WebKitIDL edited by jiewen_tan@apple.com
(diff)
3:53 PM Changeset in webkit [204429] by commit-queue@webkit.org
  • 27 edits
    4 moves in trunk/Source

Rename DocumentLoadTiming and ResourceLoadTiming
​https://bugs.webkit.org/show_bug.cgi?id=160821

Patch by Johan K. Jensen <​johan_jensen@apple.com> on 2016-08-12
Reviewed by Alex Christensen.

Source/WebCore:

Renames ResourceLoadTiming to NetworkLoadTiming.
Renames DocumentLoadTiming to LoadTiming as well as
navigationStart() to startTime(), so it's generic for
both the main resource and subresources.

  • CMakeLists.txt:
  • Modules/gamepad/NavigatorGamepad.cpp:

(WebCore::NavigatorGamepad::from):

  • PlatformMac.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorNetworkAgent.cpp:

(WebCore::buildObjectForTiming):
(WebCore::buildObjectForResourceResponse):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::startLoadingMainResource):

  • loader/DocumentLoader.h:

(WebCore::DocumentLoader::timing):
(WebCore::DocumentLoader::resetTiming):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::dispatchUnloadEvents):
(WebCore::FrameLoader::loadProvisionalItemFromCachedPage):

  • loader/LoadTiming.cpp: Renamed from Source/WebCore/loader/DocumentLoadTiming.cpp.

(WebCore::LoadTiming::LoadTiming):
(WebCore::LoadTiming::monotonicTimeToZeroBasedDocumentTime):
(WebCore::LoadTiming::monotonicTimeToPseudoWallTime):
(WebCore::LoadTiming::markStartTime):
(WebCore::LoadTiming::addRedirect):

  • loader/LoadTiming.h: Renamed from Source/WebCore/loader/DocumentLoadTiming.h.

(WebCore::LoadTiming::markUnloadEventStart):
(WebCore::LoadTiming::markUnloadEventEnd):
(WebCore::LoadTiming::markRedirectStart):
(WebCore::LoadTiming::markRedirectEnd):
(WebCore::LoadTiming::markFetchStart):
(WebCore::LoadTiming::setResponseEnd):
(WebCore::LoadTiming::markLoadEventStart):
(WebCore::LoadTiming::markLoadEventEnd):
(WebCore::LoadTiming::setHasSameOriginAsPreviousDocument):
(WebCore::LoadTiming::startTime):
(WebCore::LoadTiming::unloadEventStart):
(WebCore::LoadTiming::unloadEventEnd):
(WebCore::LoadTiming::redirectStart):
(WebCore::LoadTiming::redirectEnd):
(WebCore::LoadTiming::redirectCount):
(WebCore::LoadTiming::fetchStart):
(WebCore::LoadTiming::responseEnd):
(WebCore::LoadTiming::loadEventStart):
(WebCore::LoadTiming::loadEventEnd):
(WebCore::LoadTiming::hasCrossOriginRedirect):
(WebCore::LoadTiming::hasSameOriginAsPreviousDocument):
(WebCore::LoadTiming::referenceMonotonicTime):
(WebCore::LoadTiming::referenceWallTime):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchLoadEvent):

  • page/PerformanceNavigation.cpp:

(WebCore::PerformanceNavigation::redirectCount):

  • page/PerformanceResourceTiming.cpp:

(WebCore::PerformanceResourceTiming::PerformanceResourceTiming):
(WebCore::PerformanceResourceTiming::resourceTimeToDocumentMilliseconds):

  • page/PerformanceResourceTiming.h:
  • page/PerformanceTiming.cpp:

(WebCore::PerformanceTiming::navigationStart):
(WebCore::PerformanceTiming::unloadEventStart):
(WebCore::PerformanceTiming::unloadEventEnd):
(WebCore::PerformanceTiming::redirectStart):
(WebCore::PerformanceTiming::redirectEnd):
(WebCore::PerformanceTiming::fetchStart):
(WebCore::PerformanceTiming::domainLookupStart):
(WebCore::PerformanceTiming::domainLookupEnd):
(WebCore::PerformanceTiming::connectStart):
(WebCore::PerformanceTiming::connectEnd):
(WebCore::PerformanceTiming::secureConnectionStart):
(WebCore::PerformanceTiming::requestStart):
(WebCore::PerformanceTiming::responseStart):
(WebCore::PerformanceTiming::responseEnd):
(WebCore::PerformanceTiming::loadEventStart):
(WebCore::PerformanceTiming::loadEventEnd):
(WebCore::PerformanceTiming::loadTiming):
(WebCore::PerformanceTiming::monotonicTimeToIntegerMilliseconds):

  • page/PerformanceTiming.h:
  • platform/network/NetworkLoadTiming.h: Renamed from Source/WebCore/platform/network/ResourceLoadTiming.h.

(WebCore::NetworkLoadTiming::NetworkLoadTiming):
(WebCore::NetworkLoadTiming::operator=):
(WebCore::NetworkLoadTiming::isolatedCopy):
(WebCore::NetworkLoadTiming::operator==):
(WebCore::NetworkLoadTiming::operator!=):
(WebCore::NetworkLoadTiming::encode):
(WebCore::NetworkLoadTiming::decode):

  • platform/network/ResourceHandle.h:
  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::crossThreadData):
(WebCore::ResourceResponseBase::fromCrossThreadData):
(WebCore::ResourceResponseBase::compare):

  • platform/network/ResourceResponseBase.h:

(WebCore::ResourceResponseBase::networkLoadTiming):
(WebCore::ResourceResponseBase::encode):
(WebCore::ResourceResponseBase::decode):

  • platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:

(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveResponse):

  • platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp:

(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveResponse):

  • platform/network/cocoa/NetworkLoadTiming.mm: Renamed from Source/WebCore/platform/network/cocoa/ResourceLoadTiming.mm.

(WebCore::timingValue):
(WebCore::copyTimingData):
(WebCore::setCollectsTimingData):

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::calculateWebTimingInformations):

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::getConnectionTimingData):

  • platform/network/mac/WebCoreResourceHandleAsDelegate.mm:

(-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):

  • platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::sendRequestCallback):
(WebCore::ResourceHandle::didStartRequest):
(WebCore::networkEventCallback):

Source/WebKit2:

Rename ResourceLoadTiming to NetworkLoadTiming.

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):

3:32 PM Changeset in webkit [204428] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Command-Shift-O causes infinite loop if web page has frames
​https://bugs.webkit.org/show_bug.cgi?id=160810

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/OpenResourceDialog.js:

(WebInspector.OpenResourceDialog.prototype._addResourcesForFrame):
"frame" doesn't change inside the loop.

3:02 PM Changeset in webkit [204427] by bshafiei@apple.com
  • 8 edits in branches/safari-602-branch/Source/WebKit2

Merge r204414. rdar://problem/27624095

2:56 PM Changeset in webkit [204426] by bshafiei@apple.com
  • 8 edits in branches/safari-602.1.50.1-branch/Source/WebKit2

Merge r204414. rdar://problem/27624095

2:53 PM Changeset in webkit [204425] by bshafiei@apple.com
  • 8 edits in branches/safari-602.1.50.0-branch/Source/WebKit2

Merge r204414. rdar://problem/27624095

2:46 PM Changeset in webkit [204424] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Remove unused includes of RefCountedLeakCounter.h
​https://bugs.webkit.org/show_bug.cgi?id=160817

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-12
Reviewed by Mark Lam.

Source/JavaScriptCore:

  • parser/Nodes.cpp:
  • runtime/Structure.cpp:

Source/WebCore:

  • bindings/js/JSEventListener.cpp:
  • rendering/RenderBlockLineLayout.cpp:
2:38 PM Changeset in webkit [204423] by Ryan Haddad
  • 1 edit
    1 add in trunk/LayoutTests

Add mac-wk1 baseline for js/dom/global-constructors-attributes.html after r204396.

Unreviewed test gardening.

  • platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt: Added.
2:38 PM Changeset in webkit [204422] by Brent Fulgham
  • 3 edits
    3 adds in trunk

ASSERTION FAILED: : line >= firstLine in BytecodeGenerator::emitExpressionInfo.
​https://bugs.webkit.org/show_bug.cgi?id=160535
<rdar://problem/27328151>
Source/JavaScriptCore:


Patch by Pranjal Jumde <​pjumde@apple.com> on 2016-08-12
Reviewed by Saam Barati.

lineNumber from the savePoint was not being restored before calling next() causing discrepancy in the offset and line for the token

  • parser/Parser.h:

(JSC::Parser::restoreLexerState):

LayoutTests:

Patch by Pranjal Jumde <​pjumde@apple.com> on 2016-08-12
Reviewed by Saam Barati.

lineNumber from the savePoint was not being restored before calling next() causing discrepancy in the offset and line for the token

  • js/multiline-function-crash-expected.txt: Added.
  • js/multiline-function-crash.html: Added.
  • js/script-tests/multiline-function-crash.js: Added.
2:24 PM Changeset in webkit [204421] by rniwa@webkit.org
  • 3 edits in trunk/Tools

run-benchmark should run JetStream 1.1 instead of 1.0.1
​https://bugs.webkit.org/show_bug.cgi?id=160816

Reviewed by Filip Pizlo.

Use the latest JetStream 1.1 in run-benchmark.

  • Scripts/webkitpy/benchmark_runner/benchmark_builder.py:

(BenchmarkBuilder.exit):

  • Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
  • Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last

change to JetStream directory.

2:09 PM Changeset in webkit [204420] by Ryan Haddad
  • 1 edit
    3 deletes in trunk/LayoutTests

Unreviewed, rolling out r204416.

This test fails with a debug assertion

Reverted changeset:

"ASSERTION FAILED: : line >= firstLine in
BytecodeGenerator::emitExpressionInfo."
​https://bugs.webkit.org/show_bug.cgi?id=160535
​http://trac.webkit.org/changeset/204416

1:46 PM Changeset in webkit [204419] by gskachkov@gmail.com
  • 8 edits
    1 add in trunk

[ES2016] Implement Object.entries
​https://bugs.webkit.org/show_bug.cgi?id=160412

Reviewed by Saam Barati.

This patch adds entries function to Object that returns list of
key+values pairs. Patch did according to the point of
spec ​https://tc39.github.io/ecma262/#sec-object.entries

Source/JavaScriptCore:

  • builtins/ObjectConstructor.js:

(globalPrivate.enumerableOwnProperties):
(entries):

  • runtime/ObjectConstructor.cpp:

JSTests:

  • stress/object-entries.js:

(compare):
(string_appeared_here.forEach):
(const.getInvokedFunctions.):
(const.getInvokedFunctions):
(Array.prototype.push):

  • stress/object-values.js:
1:34 PM Changeset in webkit [204418] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Support for :lineNumber syntax in Open Resource Dialog
​https://bugs.webkit.org/show_bug.cgi?id=159732
<rdar://problem/27684491>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-12
Reviewed by Matt Baker.

Allow the Open Resource Dialog to support line/column syntax.
Other tools allow "<name>:<line>:<column>" syntax, where the
location data at the end is optional. If the <name> portion
is missing, the location can be used for the active content
view, assuming it has text data and has lines.

  • UserInterface/Base/Main.js:

(WebInspector.focusedOrVisibleContentView):
Expose a function to access the current focused / visible content view.

(WebInspector.dialogWasDismissed):
Include passing on cookie data when showing a represented object.

  • UserInterface/Views/Dialog.js:

(WebInspector.Dialog):
(WebInspector.Dialog.prototype.get visible):
(WebInspector.Dialog.prototype.get delegate):
(WebInspector.Dialog.prototype.get representedObject):
(WebInspector.Dialog.prototype.get cookie):
(WebInspector.Dialog.prototype.dismiss):

  • UserInterface/Models/ResourceQueryResult.js:

(WebInspector.ResourceQueryResult):
(WebInspector.ResourceQueryResult.prototype.get cookie):
Include cookie data along with the represented object in matches
and dialog results.

  • UserInterface/Controllers/ResourceQueryController.js:

(WebInspector.ResourceQueryController.prototype.executeQuery):
Cut off location data from a query, and stash it on the query result.
A query can be "<name>:<line>:<column>", and the line/column data
becomes cookie data for the resource.

  • UserInterface/Views/OpenResourceDialog.js:

(WebInspector.OpenResourceDialog.prototype._populateResourceTreeOutline):
If the query is just ":<line>:<column>" have it jump to a location
in the current content view if applicable.

(WebInspector.OpenResourceDialog.prototype._handleKeydownEvent):
(WebInspector.OpenResourceDialog.prototype._treeSelectionDidChange):
When dismissing, include cookie data.

1:03 PM Changeset in webkit [204417] by achristensen@apple.com
  • 4 edits in trunk

Initial URLParser implementation
​https://bugs.webkit.org/show_bug.cgi?id=160811

Reviewed by Brady Eidson.

Source/WebCore:

There are a lot of missing parts, but it works in one case, so I test that one case.

  • platform/URLParser.cpp:

(WebCore::isC0Control):
(WebCore::isC0ControlOrSpace):
(WebCore::isTabOrNewline):
(WebCore::isASCIIDigit):
(WebCore::isASCIIAlpha):
(WebCore::isASCIIAlphanumeric):
(WebCore::isSpecialScheme):
(WebCore::URLParser::parse):

Tools:

  • TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::eq):
(TestWebKitAPI::checkURL):
(TestWebKitAPI::TEST_F):

11:53 AM Changeset in webkit [204416] by Brent Fulgham
  • 1 edit
    3 adds in trunk/LayoutTests

ASSERTION FAILED: : line >= firstLine in BytecodeGenerator::emitExpressionInfo.
​https://bugs.webkit.org/show_bug.cgi?id=160535
<rdar://problem/27328151>

Patch by Pranjal Jumde <​pjumde@apple.com> on 2016-08-12
Reviewed by Saam Barati.

lineNumber from the savePoint was not being restored before calling next() causing discrepancy in the offset and line for the token

  • js/multiline-function-crash-expected.txt: Added.
  • js/multiline-function-crash.html: Added.
  • js/script-tests/multiline-function-crash.js: Added.
11:51 AM Changeset in webkit [204415] by Brent Fulgham
  • 1 edit
    2 adds in trunk/LayoutTests

Add test for fixed nullptr deref error
​https://bugs.webkit.org/show_bug.cgi?id=160807
<rdar://problem/15576693>

Unreviewed test gardening.

  • mathml/row-clone-crash-expected.txt: Added.
  • mathml/row-clone-crash.html: Added.
11:50 AM Changeset in webkit [204414] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

message loading never finishes in Mail
​https://bugs.webkit.org/show_bug.cgi?id=160806
rdar://problem/27624095

Reviewed by Dan Bernstein.

Add more checks for when a process goes away before we've established a proper connection to it.

  • Platform/IPC/mac/ConnectionMac.mm:

(IPC::Connection::receiveSourceEventHandler):
Handle the MACH_NOTIFY_NO_SENDERS and MACH_NOTIFY_SEND_ONCE messages here. Also, once we receive a send
right from the other side, stop listening for the MACH_NOTIFY_NO_SENDERS notification.

  • UIProcess/ChildProcessProxy.cpp:

(WebKit::ChildProcessProxy::didFinishLaunching):
Null check the connection identifier.

  • UIProcess/Launcher/ProcessLauncher.cpp:

(WebKit::ProcessLauncher::ProcessLauncher):
(WebKit::processLauncherWorkQueue): Deleted.
Get rid of the process launcher queue - we're not doing any blocking work here.

  • UIProcess/Launcher/ProcessLauncher.h:

Add a weak factory.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::systemDirectoryPath):
Move this before launchProcess().

(WebKit::ProcessLauncher::launchProcess):
Merge createService and connectToService into launchProcess. Also make the following changes:

  • Use mach_port_request_notification to get a notification for when our receive right loses all its senders.

This lets us listen for the other process going away before we have a send right for it.

  • Use xpc_connection_set_event_handler to listen for errors, so we can detect the process going away before

we've sent a message to it.

(WebKit::connectToService): Deleted.
(WebKit::createService): Deleted.

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didFinishLaunching):
If we failed to launch, call networkProcessCrashedOrFailedToLaunch so we'll unblock any waiting web processes.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didFinishLaunching):
Null check the connection and XPC connection before trying to get its pid.

9:54 AM Changeset in webkit [204413] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Rebaseline js/dom/global-constructors-attributes.html after r204396.

Unreviewed test gardening.

  • platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
9:51 AM Changeset in webkit [204412] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r204404.
​https://bugs.webkit.org/show_bug.cgi?id=160805

"Broke the build for some Apple Internal projects" (Requested
by bradee-oh on #webkit).

Reverted changeset:

"Support WebIDL unions (Part 1)"
​https://bugs.webkit.org/show_bug.cgi?id=160769
​http://trac.webkit.org/changeset/204404

8:55 AM Changeset in webkit [204411] by beidson@apple.com
  • 3 edits in trunk/Tools

Fix the 32-bit Mac build after:
Add WK2 ExperimentalFeature support to MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=160788

Reviewed by NOBODY (OOPS!).

Sprinkle "#if WK_API_ENABLED"s liberally.

  • MiniBrowser/mac/AppDelegate.m:

(defaultConfiguration):

  • MiniBrowser/mac/SettingsController.m:

(-[SettingsController _populateMenu]):
(-[SettingsController validateMenuItem:]):

3:38 AM Changeset in webkit [204410] by Philippe Normand
  • 3 edits in trunk/Source/WebCore

[GStreamer] Performance problems with bigger video resolution in the webrtc media player
​https://bugs.webkit.org/show_bug.cgi?id=153826

Reviewed by Alejandro G. Castro.

Keep the OpenWebRTC video renderer size synchronized with the Media element size.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:

(WebCore::MediaPlayerPrivateGStreamerOwr::setSize):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.h:
3:35 AM Changeset in webkit [204409] by Philippe Normand
  • 6 edits in trunk

[GStreamer][OWR] Video rendering fixes
​https://bugs.webkit.org/show_bug.cgi?id=160764

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

The video renderer of OpenWebRTC now uses OpenGL so we have two
options to correctly handle this in WebKit:

  • if USE_GSTREAMER_GL is enabled then we simply pass our GL appsink to the renderer and there is no need to create glupload and glcolorconvert element on WebKit side because those elements are already created on OpenWebRTC side.
  • if USE_GSTREAMER_GL is disabled then we need our sink to download frames from the GPU so that rendering can be done with the WebKit video sink in main memory.
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::createGLAppSink): Split out GL appsink management
to a separate method that can be used by sub-classes.
(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSinkGL): Use new createGLAppSink method.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:

(WebCore::MediaPlayerPrivateGStreamerOwr::createVideoSink): handle GStreamer-GL configurations
and pass a different element to the renderer depending on the configuration.

Tools:

  • gtk/jhbuild.modules: Bump to current OpenWebRTC master.
2:11 AM Changeset in webkit [204408] by pvollan@apple.com
  • 2 edits in trunk/Tools

Add missing return statement in convertFast function added in r204376.

Unreviewed.

  • Scripts/webkitpy/common/system/path.py:

(_CygPath.convertFast):

Aug 11, 2016:

10:52 PM Changeset in webkit [204407] by bshafiei@apple.com
  • 5 edits in branches/safari-602-branch/Source

Versioning.

9:55 PM Changeset in webkit [204406] by bshafiei@apple.com
  • 1 copy in tags/Safari-603.1.2

New tag.

9:55 PM Changeset in webkit [204405] by bshafiei@apple.com
  • 1 delete in tags/Safari-603.1.2

Delete tag.

9:34 PM Changeset in webkit [204404] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Support WebIDL unions (Part 1)
​https://bugs.webkit.org/show_bug.cgi?id=160769

Reviewed by Chris Dumez.

This is the first part of an effort to add support for union types
in our code generators. This change:

  • Adds a domType struct to hold the parsed type information. For now, we only use it temporarily while parsing, and don't expose it to the code generators, but that will change in a later patch.
  • Remove support for scoped identifiers for types. They are not supported by WebIDL.
  • Make debugging the parser easier by providing backtraces when asserting.

There should be no observable changes.

  • bindings/scripts/IDLParser.pm:
8:38 PM Changeset in webkit [204403] by mark.lam@apple.com
  • 3 edits
    1 add in trunk

OverridesHasInstance should not branch across register allocations.
​https://bugs.webkit.org/show_bug.cgi?id=160792
<rdar://problem/27361778>

Reviewed by Benjamin Poulain.

JSTests:

  • stress/OverrideHasInstance-should-not-branch-across-register-allocations.js: Added.

Source/JavaScriptCore:

The OverrideHasInstance node has a branch test that is emitted conditionally.
It also has a bug where it allocated a register after this branch, which is not
allowed and would fail an assertion introduced in ​https://trac.webkit.org/r145931.
From the ChangeLog for r145931:

"This [assertion that register allocations are not branched around] protects
against the case where an allocation could have spilled register contents to free
up a register and that spill only occurs on one path of many through the code.
A subsequent fill of the spilled register may load garbage."

Because the branch isn't always emitted, this bug has gone unnoticed until now.
This patch fixes this issue by pre-allocating the registers before emitting the
branch in OverrideHasInstance.

Note: this issue is only present in DFGSpeculativeJIT64.cpp. The 32-bit version
is doing it right.

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

6:33 PM Changeset in webkit [204402] by commit-queue@webkit.org
  • 8 edits in trunk/Source/JavaScriptCore

[JSC] Make B3 Return opcode work without arguments
​https://bugs.webkit.org/show_bug.cgi?id=160787

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-08-11
Reviewed by Keith Miller.

We need a way to create functions that do not return values.

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::retVoid):

  • b3/B3BasicBlock.cpp:

(JSC::B3::BasicBlock::appendNewControlValue):

  • b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::lower):

  • b3/B3Validate.cpp:
  • b3/B3Value.h:
  • b3/air/AirOpcode.opcodes:
  • b3/testb3.cpp:

(JSC::B3::testReturnVoid):
(JSC::B3::run):

6:29 PM Changeset in webkit [204401] by beidson@apple.com
  • 4 edits in trunk/Source/WebKit2

[WK2] Don't monitor gamepads at all unless an interested WebPageProxy is in the active window.
​https://bugs.webkit.org/show_bug.cgi?id=160760

Reviewed by Tim Horton.

This patch makes it such that the UIProcess will only listen to the platform gamepad mechanism
if a WebPageProxy that is interested in gamepads is in the active window.

  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::windowDidBecomeKey):
(WebKit::WebViewImpl::windowDidResignKey):

  • UIProcess/Gamepad/UIGamepadProvider.cpp:

(WebKit::UIGamepadProvider::UIGamepadProvider):
(WebKit::UIGamepadProvider::gamepadSyncTimerFired):
(WebKit::UIGamepadProvider::scheduleGamepadStateSync):
(WebKit::UIGamepadProvider::platformGamepadConnected):
(WebKit::UIGamepadProvider::platformGamepadDisconnected):
(WebKit::UIGamepadProvider::platformGamepadInputActivity):
(WebKit::UIGamepadProvider::processPoolStartedUsingGamepads):
(WebKit::UIGamepadProvider::processPoolStoppedUsingGamepads):
(WebKit::UIGamepadProvider::viewBecameActive):
(WebKit::UIGamepadProvider::viewBecameInactive):
(WebKit::UIGamepadProvider::scheduleDisableGamepadMonitoring):
(WebKit::UIGamepadProvider::disableMonitoringTimerFired):
(WebKit::UIGamepadProvider::startMonitoringGamepads):
(WebKit::UIGamepadProvider::stopMonitoringGamepads):
(WebKit::UIGamepadProvider::updateTimerFired): Deleted.
(WebKit::UIGamepadProvider::startOrStopSynchingGamepadState): Deleted.

  • UIProcess/Gamepad/UIGamepadProvider.h:
6:22 PM Changeset in webkit [204400] by mmaxfield@apple.com
  • 52 edits in trunk/Source/WebCore

Migrate from ints to unsigneds when referring to indices into strings
​https://bugs.webkit.org/show_bug.cgi?id=160735

Reviewed by Simon Fraser.

There are a few cases where we use ints to refer to indices into strings:

  • A simple historical accident. These were migrated to unsigneds directly.
  • Where we use -1 as a sentinal value. These were migrated to Optional<unsigned>.

This patch only modifies rendering code (rather than DOM code). There are a few
places in DOM code (such as Position and Node::maxCharacterOffset()) which also
erroneously use ints; however, I didn't want this change to be observable from
script and I wanted to keep this patch to a reasonable size.

No new tests because there is no behavior change.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::updateAppearance):
(WebCore::FrameSelection::setCaretVisibility):

  • platform/DragImage.cpp:

(WebCore::createDragImageForRange):

  • platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::glyphBufferForTextRun):
(WebCore::FontCascade::drawText):
(WebCore::FontCascade::drawEmphasisMarks):
(WebCore::FontCascade::adjustSelectionRectForText):
(WebCore::computeUnderlineType):
(WebCore::FontCascade::getGlyphsAndAdvancesForSimpleText):
(WebCore::FontCascade::drawEmphasisMarksForSimpleText):
(WebCore::FontCascade::drawGlyphBuffer):
(WebCore::offsetToMiddleOfGlyphAtIndex):
(WebCore::FontCascade::adjustSelectionRectForSimpleText):

  • platform/graphics/FontCascade.h:
  • platform/graphics/GlyphBuffer.h:

(WebCore::GlyphBuffer::size):
(WebCore::GlyphBuffer::glyphs):
(WebCore::GlyphBuffer::advances):
(WebCore::GlyphBuffer::fontAt):
(WebCore::GlyphBuffer::glyphAt):
(WebCore::GlyphBuffer::advanceAt):
(WebCore::GlyphBuffer::offsetAt):
(WebCore::GlyphBuffer::reverse):
(WebCore::GlyphBuffer::offsetInString):
(WebCore::GlyphBuffer::shrink):
(WebCore::GlyphBuffer::swap):

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawText):
(WebCore::GraphicsContext::drawGlyphs):
(WebCore::GraphicsContext::drawEmphasisMarks):

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/Latin1TextIterator.h:

(WebCore::Latin1TextIterator::Latin1TextIterator):
(WebCore::Latin1TextIterator::currentCharacter):

  • platform/graphics/SurrogatePairAwareTextIterator.cpp:

(WebCore::SurrogatePairAwareTextIterator::SurrogatePairAwareTextIterator):

  • platform/graphics/SurrogatePairAwareTextIterator.h:

(WebCore::SurrogatePairAwareTextIterator::currentCharacter):

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::applyFontTransforms):
(WebCore::WidthIterator::advanceInternal):
(WebCore::WidthIterator::advance):
(WebCore::WidthIterator::advanceOneCharacter):

  • platform/graphics/WidthIterator.h:
  • platform/graphics/cairo/FontCairo.cpp:

(WebCore::drawGlyphsToContext):
(WebCore::drawGlyphsShadow):
(WebCore::FontCascade::drawGlyphs):

  • platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:

(WebCore::FontCascade::getGlyphsAndAdvancesForComplexText):
(WebCore::FontCascade::drawEmphasisMarksForComplexText):
(WebCore::FontCascade::adjustSelectionRectForComplexText):

  • platform/graphics/cocoa/FontCascadeCocoa.mm:

(WebCore::fillVectorWithHorizontalGlyphPositions):
(WebCore::showLetterpressedGlyphsWithAdvances):
(WebCore::showGlyphsWithAdvances):
(WebCore::FontCascade::drawGlyphs):
(WebCore::FontCascade::dashesForIntersectionsWithRect):
(WebCore::FontCascade::adjustSelectionRectForComplexText):
(WebCore::FontCascade::getGlyphsAndAdvancesForComplexText):
(WebCore::FontCascade::drawEmphasisMarksForComplexText):

  • platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::drawGlyphs):

  • platform/graphics/displaylists/DisplayListRecorder.h:
  • platform/graphics/harfbuzz/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::selectionRect):

  • platform/graphics/harfbuzz/HarfBuzzShaper.h:
  • platform/graphics/mac/ComplexTextController.h:
  • platform/graphics/win/FontCGWin.cpp:

(WebCore::FontCascade::drawGlyphs):

  • platform/graphics/win/FontWin.cpp:

(WebCore::FontCascade::adjustSelectionRectForComplexText):
(WebCore::FontCascade::getGlyphsAndAdvancesForComplexText):
(WebCore::FontCascade::drawEmphasisMarksForComplexText):

  • rendering/EllipsisBox.cpp:

(WebCore::EllipsisBox::paintSelection):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::isSelected):
(WebCore::InlineTextBox::selectionState):
(WebCore::InlineTextBox::localSelectionRect):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::clampedOffset):
(WebCore::InlineTextBox::selectionStartEnd):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintDocumentMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::positionForOffset):

  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::offsetRun):
(WebCore::InlineTextBox::InlineTextBox): Deleted.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::localCaretRect):

  • rendering/RenderBlock.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::localCaretRect):

  • rendering/RenderBox.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::localCaretRect):

  • rendering/RenderInline.h:
  • rendering/RenderLineBreak.cpp:

(WebCore::RenderLineBreak::localCaretRect):

  • rendering/RenderLineBreak.h:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::selectionStartEnd):
(WebCore::RenderObject::localCaretRect):

  • rendering/RenderObject.h:
  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::isSelected):

  • rendering/RenderText.cpp:

(WebCore::RenderText::localCaretRect):
(WebCore::RenderText::collectSelectionRectsForLineBoxes):

  • rendering/RenderText.h:
  • rendering/RenderTextLineBoxes.cpp:

(WebCore::RenderTextLineBoxes::setSelectionState):

  • rendering/RenderView.cpp:

(WebCore::RenderView::subtreeSelectionBounds):
(WebCore::RenderView::repaintSubtreeSelection):
(WebCore::RenderView::setSelection):
(WebCore::RenderView::splitSelectionBetweenSubtrees):
(WebCore::RenderView::clearSubtreeSelection):
(WebCore::RenderView::applySubtreeSelection):
(WebCore::RenderView::getSelection):
(WebCore::RenderView::clearSelection):
(WebCore::RenderView::RenderView): Deleted.

  • rendering/RenderView.h:
  • rendering/SelectionSubtreeRoot.cpp:

(WebCore::SelectionSubtreeRoot::adjustForVisibleSelection):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeRoot): Deleted.

  • rendering/SelectionSubtreeRoot.h:

(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::SelectionSubtreeData):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionStartPos):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionEndPos):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionClear):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionStartEndPositions):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::setSelectionStartPos):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::setSelectionEndPos):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::clearSelection):
(WebCore::SelectionSubtreeRoot::OldSelectionData::OldSelectionData): Deleted.

  • rendering/TextPainter.cpp:

(WebCore::TextPainter::drawTextOrEmphasisMarks):
(WebCore::TextPainter::paintTextWithShadows):
(WebCore::TextPainter::paintTextAndEmphasisMarksIfNeeded):
(WebCore::TextPainter::paintText):

  • rendering/TextPainter.h:

(WebCore::TextPainter::addEmphasis):

  • rendering/svg/RenderSVGInlineText.cpp:

(WebCore::RenderSVGInlineText::localCaretRect):

  • rendering/svg/RenderSVGInlineText.h:
  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::positionForOffset):
(WebCore::SVGInlineTextBox::selectionRectForTextFragment):
(WebCore::SVGInlineTextBox::localSelectionRect):
(WebCore::SVGInlineTextBox::paintSelectionBackground):
(WebCore::SVGInlineTextBox::mapStartEndPositionsIntoFragmentCoordinates):
(WebCore::SVGInlineTextBox::paintTextWithShadows):
(WebCore::SVGInlineTextBox::paintText):

  • rendering/svg/SVGInlineTextBox.h:
  • rendering/svg/SVGTextQuery.cpp:

(WebCore::SVGTextQuery::mapStartEndPositionsIntoFragmentCoordinates):
(WebCore::SVGTextQuery::modifyStartEndPositionsRespectingLigatures):
(WebCore::SVGTextQuery::subStringLengthCallback):
(WebCore::SVGTextQuery::startPositionOfCharacterCallback):
(WebCore::SVGTextQuery::endPositionOfCharacterCallback):
(WebCore::SVGTextQuery::rotationOfCharacterCallback):
(WebCore::calculateGlyphBoundaries):
(WebCore::SVGTextQuery::extentOfCharacterCallback):
(WebCore::SVGTextQuery::characterNumberAtPositionCallback):

  • rendering/svg/SVGTextQuery.h:
6:12 PM Changeset in webkit [204399] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.2.1

New tag.

6:02 PM Changeset in webkit [204398] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Gardening: fix gcc builds after r204387.

Not reviewed.

Apparently, gcc is not sophisticated enough to realize that the end of the
function is unreachable, and is wrongly complaining about "control reaches end of
non-void function". I'm restoring the RELEASE_ASSERT_NOT_REACHED() and return
statement at the end of MarkedBlock::sweepHelper() to appease gcc.

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::sweepHelper):

5:35 PM Changeset in webkit [204397] by beidson@apple.com
  • 4 edits in trunk/Tools

Add WK2 ExperimentalFeature support to MiniBrowser.
​https://bugs.webkit.org/show_bug.cgi?id=160788

Reviewed by Alex Christensen.

  • MiniBrowser/mac/AppDelegate.h:
  • MiniBrowser/mac/AppDelegate.m:

(defaultConfiguration):
(defaultPreferences):

  • MiniBrowser/mac/SettingsController.m:

(-[SettingsController _populateMenu]):
(-[SettingsController validateMenuItem:]):
(-[SettingsController toggleExperimentalFeature:]):

5:35 PM Changeset in webkit [204396] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Make Gamepads be a WK2 ExperimentalFeature.
​https://bugs.webkit.org/show_bug.cgi?id=160788

Reviewed by Alex Christensen.

  • Shared/WebPreferencesDefinitions.h:
5:34 PM Changeset in webkit [204395] by commit-queue@webkit.org
  • 12 edits in trunk/Source

Don't use a NetworkingContext when creating SocketStreamHandles
​https://bugs.webkit.org/show_bug.cgi?id=160732

Patch by Alex Christensen <​achristensen@webkit.org> on 2016-08-11
Reviewed by Brady Eidson.

Source/WebCore:

No change in behavior. After r204327 a SessionID is all we need to get the NetworkStorageSession,
and we pass the SessionID to the SocketStreamHandle constructor, so use that instead.
SessionIDs can be serialized and sent over IPC. NetworkingContexts can't.

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::connect):

  • page/SocketProvider.cpp:

(WebCore::SocketProvider::createSocketStreamHandle):

  • page/SocketProvider.h:
  • platform/network/cf/SocketStreamHandle.h:

(WebCore::SocketStreamHandle::create):

  • platform/network/cf/SocketStreamHandleCFNet.cpp:

(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore::SocketStreamHandle::getStoredCONNECTProxyCredentials):

  • platform/network/curl/SocketStreamHandle.h:

(WebCore::SocketStreamHandle::create):

  • platform/network/soup/SocketStreamHandle.h:
  • platform/network/soup/SocketStreamHandleSoup.cpp:

(WebCore::SocketStreamHandle::create):

Source/WebKit2:

  • WebProcess/Network/WebSocketProvider.cpp:

(WebKit::WebSocketProvider::createSocketStreamHandle):

  • WebProcess/Network/WebSocketProvider.h:
5:33 PM Changeset in webkit [204394] by commit-queue@webkit.org
  • 21 edits in trunk/Source

Use StringBuilder::appendLiteral when possible don't append result of makeString
​https://bugs.webkit.org/show_bug.cgi?id=160772

Patch by Alex Christensen <​achristensen@webkit.org> on 2016-08-11
Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • API/tests/ExecutionTimeLimitTest.cpp:

(testExecutionTimeLimit):

  • API/tests/PingPongStackOverflowTest.cpp:

(PingPongStackOverflowObject_hasInstance):

  • bytecompiler/NodesCodegen.cpp:

(JSC::ArrayPatternNode::toString):
(JSC::RestParameterNode::toString):

  • runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::sanitizedToString):

  • runtime/Options.cpp:

(JSC::Options::dumpOption):

Source/WebCore:

StringBuilder::append does an unnecessary strlen call.
append(makeString(...)) always does unnecessary allocations and copies.
It's currently only used in debug logging, but we shouldn't have this pattern in WebKit.

  • Modules/indexeddb/server/IndexValueStore.cpp:

(WebCore::IDBServer::IndexValueStore::loggingString):

  • Modules/indexeddb/shared/IDBDatabaseInfo.cpp:

(WebCore::IDBDatabaseInfo::loggingString):

  • Modules/indexeddb/shared/IDBObjectStoreInfo.cpp:

(WebCore::IDBObjectStoreInfo::loggingString):

  • contentextensions/CombinedURLFilters.cpp:

(WebCore::ContentExtensions::prefixTreeVertexToString):
(WebCore::ContentExtensions::recursivePrint):

  • html/HTMLMediaElement.cpp:

(WebCore::actionName):

  • html/MediaElementSession.cpp:

(WebCore::restrictionName):

  • loader/ResourceLoadStatistics.cpp:

(WebCore::appendBoolean):
(WebCore::appendHashCountedSet):
(WebCore::ResourceLoadStatistics::toString):

  • platform/PODInterval.h:

(WebCore::PODInterval::toString):

  • platform/URL.cpp:

(WebCore::URL::setHost):
(WebCore::URL::setHostAndPort):
(WebCore::URL::serialize):

  • testing/Internals.cpp:

(WebCore::appendOffsets):
(WebCore::Internals::scrollSnapOffsets):

Source/WebKit2:

  • Shared/Gamepad/GamepadData.cpp:

(WebKit::GamepadData::isNull):
(WebKit::GamepadData::loggingString):

  • Shared/Gamepad/GamepadData.h:
  • UIProcess/WebProcessPool.h:
5:22 PM Changeset in webkit [204393] by commit-queue@webkit.org
  • 13 edits
    4 adds in trunk/Source/JavaScriptCore

[JSC] Revert most of r203808
​https://bugs.webkit.org/show_bug.cgi?id=160784

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-08-11
Reviewed by Geoffrey Garen.

Switching to fastMalloc() caused regressions on Jetstream and Octane
on MacBook Air. I was able to get back some of it in the following
patches but the tests that never go to FTL are still regressed.

This patch revert r203808 except of the node index.
Nodes are allocated with the custom allocator like before but they are
now also kept in a table, addressed by the node index.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • b3/B3SparseCollection.h:

(JSC::B3::SparseCollection::packIndices): Deleted.

  • dfg/DFGAllocator.h: Added.

(JSC::DFG::Allocator::Region::size):
(JSC::DFG::Allocator::Region::headerSize):
(JSC::DFG::Allocator::Region::numberOfThingsPerRegion):
(JSC::DFG::Allocator::Region::data):
(JSC::DFG::Allocator::Region::isInThisRegion):
(JSC::DFG::Allocator::Region::regionFor):
(JSC::DFG::Allocator<T>::Allocator):
(JSC::DFG::Allocator<T>::~Allocator):
(JSC::DFG::Allocator<T>::allocate):
(JSC::DFG::Allocator<T>::free):
(JSC::DFG::Allocator<T>::freeAll):
(JSC::DFG::Allocator<T>::reset):
(JSC::DFG::Allocator<T>::indexOf):
(JSC::DFG::Allocator<T>::allocatorOf):
(JSC::DFG::Allocator<T>::bumpAllocate):
(JSC::DFG::Allocator<T>::freeListAllocate):
(JSC::DFG::Allocator<T>::allocateSlow):
(JSC::DFG::Allocator<T>::freeRegionsStartingAt):
(JSC::DFG::Allocator<T>::startBumpingIn):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compileImpl):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::~Graph):
(JSC::DFG::Graph::addNodeToMapByIndex):
(JSC::DFG::Graph::deleteNode):
(JSC::DFG::Graph::packNodeIndices):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::addNode):
(JSC::DFG::Graph::maxNodeCount):
(JSC::DFG::Graph::nodeAt):

  • dfg/DFGLongLivedState.cpp: Added.

(JSC::DFG::LongLivedState::LongLivedState):
(JSC::DFG::LongLivedState::~LongLivedState):
(JSC::DFG::LongLivedState::shrinkToFit):

  • dfg/DFGLongLivedState.h: Added.
  • dfg/DFGNode.h:
  • dfg/DFGNodeAllocator.h: Added.

(operator new ):

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThread):
(JSC::DFG::Plan::compileInThreadImpl):

  • dfg/DFGPlan.h:
  • dfg/DFGWorklist.cpp:

(JSC::DFG::Worklist::runThread):

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:
5:08 PM Changeset in webkit [204392] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Marking transitions/clip-path-transitions.html and transitions/clip-path-path-transitions.html as flaky on ios-simulator.
​https://bugs.webkit.org/show_bug.cgi?id=153809

Unreviewed test gardening.

  • platform/ios-simulator-wk2/TestExpectations:
5:05 PM Changeset in webkit [204391] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

REGRESSION (r204264): Web Inspector: Uncaught Exception in Network tab when reloading a web page
​https://bugs.webkit.org/show_bug.cgi?id=160781
<rdar://problem/27810452>

Reviewed by Matt Baker.

WebInspector.TimelineDataGrid.prototype.closed was removed in r204264.
Define a stub method on DataGrid so it's available to all its subclasses.

  • UserInterface/Views/DataGrid.js:

this._dataGrid.closed()

3:27 PM Changeset in webkit [204390] by Chris Dumez
  • 6 edits
    1 add
    5 deletes in trunk

Align Range.surroundContents() with the latest DOM specification
​https://bugs.webkit.org/show_bug.cgi?id=160777

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline W3C test now that all checks are passing.

  • web-platform-tests/dom/ranges/Range-surroundContents-expected.txt:

Source/WebCore:

Align Range.surroundContents() with the latest DOM specification:

In particular, the following changes were made:

  1. Drop early check to see if startContainer() accepts children like newParent. This check is not in the specification. Let the later call to Range.insertNode() take care of doing the check and throwing.
  2. Drop early check to see if newParent contains the range's start node, for the same reasons as above.
  3. Move extractContents() call *before* removing newParent's children to match the order in the specification (steps 3 & 4).

This makes our behavior much closer to Firefox's as well.

No new tests, rebaselined existing W3C test.

  • dom/Range.cpp:

(WebCore::Range::surroundContents):

LayoutTests:

Rebaseline existing due to behavior change.

  • fast/dom/Range/surroundContents-1-expected.txt:
  • fast/dom/Range/surroundContents-1.html:
2:25 PM Changeset in webkit [204389] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

Keep EWS logs for longer
​https://bugs.webkit.org/show_bug.cgi?id=160776

Reviewed by Daniel Bates.

  • EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
2:21 PM Changeset in webkit [204388] by mark.lam@apple.com
  • 4 edits in trunk

The jsc shell's Element host constructor should throw if it fails to construct an object.
​https://bugs.webkit.org/show_bug.cgi?id=160773
<rdar://problem/27328608>

Reviewed by Saam Barati.

JSTests:

  • stress/generational-opaque-roots.js:

Source/JavaScriptCore:

The Element object is a test object provided in the jsc shell for testing use only.
JavaScriptCore expects host constructors to either throw an error or return a
constructed object. Element has a host constructor that did not obey this contract.
As a result, the following statement will fail a RELEASE_ASSERT:

new (Element.bind())

This is now fixed.

  • jsc.cpp:

(functionCreateElement):

2:18 PM Changeset in webkit [204387] by mark.lam@apple.com
  • 7 edits
    1 add in trunk

Disallow synchronous sweeping for eden GCs.
​https://bugs.webkit.org/show_bug.cgi?id=160716

Reviewed by Geoffrey Garen.

JSTests:

  • stress/eden-gc-with-retired-blocks.js: Added.
  • This test is just in case we add back support for eden GCs with synchronous sweeping in the future.

Source/JavaScriptCore:

  • heap/Heap.cpp:

(JSC::Heap::collectAllGarbage):
(JSC::Heap::collectAndSweep): Deleted.

  • heap/Heap.h:

(JSC::Heap::collectAllGarbage): Deleted.

  • No need for a separate collectAndSweep() anymore since we only call it for FullCollections.
  • Since we've already swept all the blocks, I cleared m_blockSnapshot so that the IncrementalSweeper can bail earlier when it runs later.
  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::sweepHelper):

  • Removed the unreachable return statement.
  • heap/MarkedBlock.h:
  • Document what "Retired" means.
  • tools/JSDollarVMPrototype.cpp:

(JSC::JSDollarVMPrototype::edenGC):

2:17 PM Changeset in webkit [204386] by Simon Fraser
  • 5 edits
    2 deletes in trunk/Tools

iOS DRT/WTR project cleanup
​https://bugs.webkit.org/show_bug.cgi?id=160778

Reviewed by Tim Horton.

Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.

Remove AppDelegate.* which were unused.

Exclude ios/Launch.storyboard on more platforms.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
  • WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
  • WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.

(-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.

1:49 PM Changeset in webkit [204385] by Ryan Haddad
  • 12 edits in trunk/LayoutTests

Rebaseline more iOS tests after r204363.

Unreviewed test gardening.

  • fast/events/ios/keyboard-scrolling-distance-expected.txt:
  • fast/events/ios/keyboard-should-not-trigger-resize-expected.txt:
  • fast/forms/ios/accessory-bar-navigation-expected.txt:
  • fast/forms/ios/focus-input-in-fixed-expected.txt:
  • fast/forms/ios/focus-input-in-iframe-expected.txt:
  • fast/forms/ios/focus-input-via-button-expected.txt:
  • fast/forms/ios/focus-input-via-button-ipad-expected.txt:
  • fast/forms/ios/focus-input-via-button-no-scaling-expected.txt:
  • fast/forms/ios/focus-long-textarea-expected.txt:
  • fast/forms/ios/zoom-after-input-tap-expected.txt:
  • fast/forms/ios/zoom-after-input-tap-wide-input-expected.txt:
1:21 PM Changeset in webkit [204384] by achristensen@apple.com
  • 2 edits in trunk/Tools

Fix Yosemite bots' cookie accept policies after r204365.
​https://bugs.webkit.org/show_bug.cgi?id=160758

  • TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:

(TEST):
This makes the test fully clean up after itself.

1:20 PM Changeset in webkit [204383] by achristensen@apple.com
  • 2 edits in trunk/Tools

Fix Yosemite bots' cookie accept policies after r204365.
​https://bugs.webkit.org/show_bug.cgi?id=160758

  • TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:

(TEST):
I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
causing any problems because there are no other API tests that do anything with cookies.
My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
to reset any bots that have run tests since r204365. I will commit a followup that sets it to originalCookieAcceptPolicy.

12:45 PM Changeset in webkit [204382] by aakash_jain@apple.com
  • 7 edits in trunk/Tools

EWS should check if the patch is still valid before executing every major step
​https://bugs.webkit.org/show_bug.cgi?id=160739
rdar://problem/27768813

Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/tool/bot/commitqueuetask.py:

(CommitQueueTask.run): validate method is now executed in base class.

  • Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:

(EarlyWarningSystemTask.run): validate method is now executed in base class.

  • Scripts/webkitpy/tool/bot/stylequeuetask.py:

(StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.

  • Scripts/webkitpy/tool/bot/patchanalysistask.py:

(PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).

  • Scripts/webkitpy/tool/commands/perfalizer.py:

(PerfalizerTask.validate): Added.

  • Scripts/webkitpy/tool/commands/queues_unittest.py:

(test_manual_reject_during_processing): Updated test case.

12:22 PM Changeset in webkit [204381] by Chris Dumez
  • 2 edits in trunk/Source/WebKit/mac

Regression(r204268): Mail crashes when trying to compose an email
​https://bugs.webkit.org/show_bug.cgi?id=160775

Reviewed by Anders Carlsson.

Properly initialize PageConfiguration.pluginInfoProvider in
[WebView initSimpleHTMLDocumentWithStyle] to avoid a null
dereference in Mail when trying to compose an email.

  • WebView/WebView.mm:

(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):

12:09 PM Changeset in webkit [204380] by achristensen@apple.com
  • 8 edits
    3 adds in trunk

Add URLParser stub
​https://bugs.webkit.org/show_bug.cgi?id=160770

Reviewed by Sam Weinig.

Source/WebCore:

Added API test stub.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/URL.h:
  • platform/URLParser.cpp: Added.

(WebCore::URLParser::parse):

  • platform/URLParser.h: Added.

(WebCore::URLParser::parse):

Tools:

  • TestWebKitAPI/PlatformGTK.cmake:
  • TestWebKitAPI/PlatformWin.cmake:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.

(TestWebKitAPI::TEST_F):

11:39 AM Changeset in webkit [204379] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Add NSButtonType to AppKitCompatibilityDeclarations.h.
​https://bugs.webkit.org/show_bug.cgi?id=160767.

Patch by Maureen Daum <​mdaum@apple.com> on 2016-08-11
Reviewed by Dan Bernstein.

Add NSButtonType to AppKitCompatibilityDeclarations.h so that we can use the new
names but still build successfully on older OS versions.

  • wtf/mac/AppKitCompatibilityDeclarations.h:
11:14 AM Changeset in webkit [204378] by Simon Fraser
  • 7 edits
    1 add
    1 delete in trunk/Tools

[iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
​https://bugs.webkit.org/show_bug.cgi?id=160761

Reviewed by Tim Horton.

Give iOS DRT a Launch storyboard.

Have it use a UIViewController so future forms testing works correctly.

Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
can run in iPad mode.

Remove empty InfoPlist.strings files.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • DumpRenderTree/ios/Info.plist:
  • DumpRenderTree/ios/Launch.storyboard: Added.
  • DumpRenderTree/mac/DumpRenderTree.mm:

(createWebViewAndOffscreenWindow):

  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
  • WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.

10:48 AM Changeset in webkit [204377] by Chris Dumez
  • 8 edits in trunk

Move dataset attribute from Element to HTMLElement / SVGElement
​https://bugs.webkit.org/show_bug.cgi?id=160766

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline W3C test now that one more check is passing.

  • web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

Move dataset attribute from Element to HTMLElement / SVGElement as per
the specifications:

Firefox and Chrome seem to have dataset on HTMLElement but not on
SVGElement (yet).

No new tests, rebaselined existing test.

  • dom/Element.idl:
  • html/HTMLElement.idl:
  • svg/SVGElement.idl:

LayoutTests:

Rebaseline existing tests now that properties are in different order
when iterating.

  • js/dom/dom-static-property-for-in-iteration-expected.txt:
10:42 AM Changeset in webkit [204376] by pvollan@apple.com
  • 2 edits in trunk/Tools

[Win] Unable to reliably run tests in parallel
​https://bugs.webkit.org/show_bug.cgi?id=140914

Reviewed by Brent Fulgham.

The cygpath utility function can fail badly when running with multiple DumpRenderTree
processes. We can use string replacement to convert the Cygwin path to a Windows path
instead.

  • Scripts/webkitpy/common/system/path.py:

(cygpathFast):

  • Scripts/webkitpy/port/driver.py:

(Driver._command_from_driver_input):

9:34 AM Changeset in webkit [204375] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, update MediaRemoteSPI.h after r204082.

  • platform/spi/mac/MediaRemoteSPI.h:
6:55 AM Changeset in webkit [204374] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unskip 2d.gradient.interpolate.colouralpha on macOS Sierra
​https://bugs.webkit.org/show_bug.cgi?id=160765
<rdar://problem/24025664>

Patch by Antoine Quint <Antoine Quint> on 2016-08-11
Reviewed by Eric Carlson.

We fixed the tests in ​https://bugs.webkit.org/show_bug.cgi?id=160689 but forgot to unskip them.

  • platform/mac/TestExpectations:
5:02 AM Changeset in webkit [204373] by pvollan@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[Win] Warning fix.
​https://bugs.webkit.org/show_bug.cgi?id=160734

Reviewed by Sam Weinig.

Add static cast from int to uint32_t.

  • bytecode/ArithProfile.h:
4:26 AM Changeset in webkit [204372] by clopez@igalia.com
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[GTK] German translation update
​https://bugs.webkit.org/show_bug.cgi?id=152228

Rubber-Stamped by Michael Catanzaro.

Patch by Bernd Homuth <​dev@hmt.im> on 2016-08-11

  • de.po: Update to reviewed translation from 2016-08-05.
3:22 AM Changeset in webkit [204371] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

Test 2d.gradient.interpolate.colouralpha.html is broken on macOS Sierra
​https://bugs.webkit.org/show_bug.cgi?id=160689
<rdar://problem/24025664>

Patch by Antoine Quint <Antoine Quint> on 2016-08-11
Reviewed by Dean Jackson.

When the test samples 25th pixel it expect the value to be exactly 25% interpolation of the color values.
However, the sampling location is the center of the pixel, i.e. it should correspond to 25.5% interpolation,
which would expect the color of (189.975, 189.75, 65.25, 65.25). The new values are a rounded values of
interpolation “by hand” at steps of 25.5%, 50.5% and 75.5%.

LayoutTests/imported/w3c:

  • canvas/2d.gradient.interpolate.colouralpha.html:

LayoutTests:

  • canvas/philip/tests/2d.gradient.interpolate.colouralpha.html:
Note: See TracTimeline for information about the timeline view.