⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 13, 2016:

6:29 PM Changeset in webkit [204452] by mitz@apple.com
  • 2 edits in trunk/Source/WTF

Build fix follow-up to r204433.

  • wtf/StdLibExtras.h:

(WTF::makeVisitor): Don’t use an auto return type.

5:10 PM Changeset in webkit [204451] by Chris Dumez
  • 3 edits
    2 adds in trunk

'compatMode' property should be on Document, not HTMLDocument
​https://bugs.webkit.org/show_bug.cgi?id=160819

Reviewed by Sam Weinig.

Source/WebCore:

'compatMode' property should be on Document, not HTMLDocument:

WebKit had it on both. Firefox and Chrome have it on Document only.

Test: fast/dom/Document/compatMode-location.html

  • html/HTMLDocument.idl:

LayoutTests:

Add layout test coverage.

  • fast/dom/Document/compatMode-location-expected.txt: Added.
  • fast/dom/Document/compatMode-location.html: Added.
3:37 PM Changeset in webkit [204450] by Chris Dumez
  • 5 edits in trunk

Move 'embeds' / 'plugins'/ 'scripts' attributes from HTMLDocument to Document
​https://bugs.webkit.org/show_bug.cgi?id=160829

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline W3C test now that more checks are passing.

  • web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

Move 'embeds' / 'plugins'/ 'scripts' attributes from HTMLDocument to Document
to match the latest specification:

This also matches Chrome.

No new tests, rebaselined existing test.

  • dom/Document.idl:
  • html/HTMLDocument.idl:
3:36 PM Changeset in webkit [204449] by Chris Dumez
  • 9 edits in trunk

Move designMode attribute from HTMLDocument to Document
​https://bugs.webkit.org/show_bug.cgi?id=160838

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline W3C test now that more checks are passing.

  • web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

Move designMode attribute from HTMLDocument to Document to match the
latest HTML specification:

This also matches Chrome.

No new tests, rebaselined existing test.

  • dom/Document.cpp:

(WebCore::Document::designMode):
(WebCore::Document::setDesignMode):

  • dom/Document.h:
  • dom/Document.idl:
  • html/HTMLDocument.cpp:

(WebCore::HTMLDocument::bgColor): Deleted.
(WebCore::HTMLDocument::setBgColor): Deleted.
(WebCore::HTMLDocument::fgColor): Deleted.

  • html/HTMLDocument.h:
  • html/HTMLDocument.idl:
1:30 PM Changeset in webkit [204448] by clopez@igalia.com
  • 2 edits in trunk/Tools

[GTK] Install script lacks gstreamer related dependencies
​https://bugs.webkit.org/show_bug.cgi?id=160814

Reviewed by Carlos Garcia Campos.

  • gtk/install-dependencies: Fedora case had already listed this dependencies,

but both Arch and Debian/Ubuntu were missing them.

11:59 AM Changeset in webkit [204447] by Konstantin Tokarev
  • 2 edits in trunk/Tools

make-dist.py should not allow unknown rules in manifest
​https://bugs.webkit.org/show_bug.cgi?id=160841

Reviewed by Carlos Garcia Campos.

  • gtk/make-dist.py:

(Manifest.process_line):

10:17 AM Changeset in webkit [204446] by pvollan@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

[Win] Warning fixes.
​https://bugs.webkit.org/show_bug.cgi?id=160803

Reviewed by Brent Fulgham.

Initialize local variables.

  • jit/JIT.cpp:

(JSC::JIT::compileWithoutLinking):

  • runtime/Error.cpp:

(JSC::addErrorInfoAndGetBytecodeOffset):

8:32 AM Changeset in webkit [204445] by clopez@igalia.com
  • 3 edits in trunk/Tools

[EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
​https://bugs.webkit.org/show_bug.cgi?id=160809

Reviewed by Carlos Garcia Campos.

  • efl/install-dependencies: Factorize the previous logic for handling the php5/7

case, and use it also for the new package names of libpng and libgeoclue.

  • gtk/install-dependencies: Ditto.

Aug 12, 2016:

11:11 PM Changeset in webkit [204444] by Gyuyoung Kim
  • 3 edits in trunk/Tools

Skip to check directories existence in build-webkit
​https://bugs.webkit.org/show_bug.cgi?id=160691

Reviewed by Alex Christensen.

CMake checks if directories are there itself. So CMake ports
don't need to check it in the build-webkit script.

  • Scripts/build-webkit:
  • Scripts/webkitdirs.pm:

(determineSourceDir):
(isCMakeBuild):

10:05 PM Changeset in webkit [204443] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.50.0.3

New tag.

10:01 PM Changeset in webkit [204442] by bshafiei@apple.com
  • 5 edits in branches/safari-602.1.50.0-branch/Source

Versioning.

9:20 PM Changeset in webkit [204441] by Chris Dumez
  • 21 edits
    1 add in trunk

getElementsByTagName() should take a qualifiedName in parameter
​https://bugs.webkit.org/show_bug.cgi?id=160682

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

  • web-platform-tests/dom/nodes/Document-getElementsByTagName-expected.txt:
  • web-platform-tests/dom/nodes/Document-getElementsByTagName-xhtml-expected.txt:
  • web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt:
  • web-platform-tests/dom/nodes/case-expected.txt:

Rebaseline several W3C tests now that more checks are passing.

  • web-platform-tests/dom/nodes/Document-getElementsByTagName-xhtml.xhtml:

Re-sync this test from upstream as it was outdated after:

Source/WebCore:

getElementsByTagName() should take a qualifiedName in parameter, not a
localName, according to the latest DOM specification:

The new behavior matches Firefox and Edge. There is a slight
compatiblity risk but we should give it a try.

No new tests, rebaselined existing tests.

  • WebCore.xcodeproj/project.pbxproj:
  • dom/AllDescendantsCollection.h: Added.
  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::getElementsByTagName):
(WebCore::ContainerNode::getElementsByTagNameNS):

  • dom/Node.cpp:

(WebCore::NodeListsNodeData::invalidateCaches):

  • dom/NodeRareData.h:

(WebCore::NodeListsNodeData::addCachedTagCollectionNS):
(WebCore::NodeListsNodeData::removeCachedTagCollectionNS):
(WebCore::NodeListsNodeData::adoptDocument):
(WebCore::NodeListsNodeData::deleteThisAndUpdateNodeRareDataIfAboutToRemoveLastList):

  • dom/TagCollection.cpp:

(WebCore::makeQualifiedName):
(WebCore::splitQualifiedName):
(WebCore::TagCollectionNS::TagCollectionNS):
(WebCore::TagCollectionNS::~TagCollectionNS):
(WebCore::TagCollection::TagCollection):
(WebCore::TagCollection::~TagCollection):
(WebCore::HTMLTagCollection::HTMLTagCollection):
(WebCore::HTMLTagCollection::~HTMLTagCollection):

  • dom/TagCollection.h:

(WebCore::TagCollection::elementMatches):
(WebCore::TagCollectionNS::elementMatches):
(WebCore::HTMLTagCollection::elementMatches):

  • html/CollectionType.h:
  • html/GenericCachedHTMLCollection.cpp:

(WebCore::GenericCachedHTMLCollection<traversalType>::elementMatches):

  • html/HTMLCollection.cpp:

(WebCore::invalidationTypeExcludingIdAndNameAttributes):

LayoutTests:

Update existing tests to reflect behavior change.

  • fast/dom/getElementsByClassName/010.xml:
  • fast/dom/getElementsByClassName/011.xml:
8:05 PM Changeset in webkit [204440] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Remove always true JSC::Debugger::needPauseHandling virtual method
​https://bugs.webkit.org/show_bug.cgi?id=160822

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-12
Reviewed by Mark Lam.

Source/JavaScriptCore:

All subclasses return true for this method. Just remove the method.

  • debugger/Debugger.cpp:

(JSC::Debugger::pauseIfNeeded):

  • inspector/ScriptDebugServer.h:

Source/WebKit/mac:

  • WebView/WebScriptDebugger.h:
7:14 PM Changeset in webkit [204439] by sbarati@apple.com
  • 35 edits
    6 adds in trunk

Inline store loop for CopyRest in DFG and FTL for certain array modes
​https://bugs.webkit.org/show_bug.cgi?id=159612

Reviewed by Filip Pizlo.

JSTests:

  • stress/rest-parameter-having-a-bad-time.js: Added.
  • stress/rest-parameter-many-arguments.js: Added.
  • stress/rest-parameter-various-types.js: Added.

Source/JavaScriptCore:

This patch changes the old copy_rest bytecode to actually allocate the rest array itself.
The bytecode is now called create_rest with an analogous CreateRest node in the DFG/FTL.
This allows the bytecode to be in control of what type of indexingType the array is allocated
with. We always allocate using ArrayWithContiguous storage unless we're havingABadTime().
This also makes allocating and writing into the array fast. On the fast path, the DFG/FTL
JIT will fast allocate the array and its storage, and we will do a memmove from the rest
region of arguments into the array's storage.

I'm seeing a 1-2% speedup on ES6SampleBench, and about a 2x speedup
on micro benchmarks that just test rest creation speed.

  • bytecode/BytecodeList.json:
  • bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitRestParameter):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCallArrayAllocatorSlowPathGenerator.h:

(JSC::DFG::CallArrayAllocatorWithVariableSizeSlowPathGenerator::CallArrayAllocatorWithVariableSizeSlowPathGenerator):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::uses):
(JSC::DFG::Graph::isWatchingHavingABadTimeWatchpoint):
(JSC::DFG::Graph::compilation):

  • dfg/DFGNode.h:

(JSC::DFG::Node::numberOfArgumentsToSkip):

  • dfg/DFGNodeType.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCreateClonedArguments):
(JSC::DFG::SpeculativeJIT::compileCreateRest):
(JSC::DFG::SpeculativeJIT::compileGetRestLength):
(JSC::DFG::SpeculativeJIT::compileCopyRest): Deleted.

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileArithRandom):
(JSC::DFG::SpeculativeJIT::compileAllocateNewArrayWithSize):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileArithRandom):
(JSC::DFG::SpeculativeJIT::compileAllocateNewArrayWithSize):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateClonedArguments):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateRest):
(JSC::FTL::DFG::LowerDFGToB3::compileGetRestLength):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayBuffer):
(JSC::FTL::DFG::LowerDFGToB3::compileAllocateArrayWithSize):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayWithSize):
(JSC::FTL::DFG::LowerDFGToB3::compileCopyRest): Deleted.

  • interpreter/CallFrame.h:

(JSC::ExecState::addressOfArgumentsStart):
(JSC::ExecState::argument):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_argument_count):
(JSC::JIT::emit_op_create_rest):
(JSC::JIT::emit_op_copy_rest): Deleted.

  • jit/JITOperations.h:
  • llint/LowLevelInterpreter.asm:
  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/CommonSlowPaths.h:

LayoutTests:

  • js/regress/rest-parameter-construction-performance-expected.txt: Added.
  • js/regress/rest-parameter-construction-performance.html: Added.
  • js/regress/script-tests/rest-parameter-construction-performance.js: Added.

(foo):
(test1):
(test2.foo):
(test2):

7:02 PM Changeset in webkit [204438] by rniwa@webkit.org
  • 7 edits in trunk/Source/JavaScriptCore

Add a helper class for enumerating elements in an iterable object
​https://bugs.webkit.org/show_bug.cgi?id=160800

Reviewed by Benjamin Poulain.

Added iteratorForIterable which provides an abstraction for iterating over an iterable object,
and deployed it in the constructors of Set, WeakSet, Map, and WeakMap.

Also added a helper function iteratorForIterable, which retrieves the iterator out of an iterable object.

  • runtime/IteratorOperations.cpp:

(JSC::iteratorForIterable): Added.

  • runtime/IteratorOperations.h:

(JSC::forEachInIterable): Added.

  • runtime/MapConstructor.cpp:

(JSC::constructMap):

  • runtime/SetConstructor.cpp:

(JSC::constructSet):

  • runtime/WeakMapConstructor.cpp:

(JSC::constructWeakMap):

  • runtime/WeakSetConstructor.cpp:

(JSC::constructWeakSet):

5:56 PM Changeset in webkit [204437] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Add application/vnd.api+json as a valid JSON MIME-type
​https://bugs.webkit.org/show_bug.cgi?id=160834
rdar://problem/27608536

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/CodeMirrorAdditions.js: Add Add application/vnd.api+json to extraJSONTypes.
5:11 PM Changeset in webkit [204436] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.50.0.2

New tag.

5:08 PM Changeset in webkit [204435] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.50.1.2

New tag.

4:54 PM Changeset in webkit [204434] by keith_miller@apple.com
  • 8 edits
    27545 adds
    1 delete in branches/safari-602-branch

Merge r203972.

2016-08-01 Keith Miller <​keith_miller@apple.com>

We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
​https://bugs.webkit.org/show_bug.cgi?id=160372

Rubber stamped by Geoffrey Garen.

This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
a new top level directory, JSTests. Having the tests in the Source directory
was both confusing and inconvenient for people that just want to checkout the
source code of WebKit. Since there is no other obvious place to put all the
JavaScript tests a new top level directory seemed the most sensible.

  • JSTests/: Copied from Source/JavaScriptCore/tests.
  • Source/JavaScriptCore/tests/: Deleted.
  • Scripts/import-test262-tests:
  • Scripts/run-javascriptcore-tests:
  • Scripts/update-javascriptcore-test-res:
4:35 PM Changeset in webkit [204433] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WTF

Make variant only available when compiling for C++14 or greater
​https://bugs.webkit.org/show_bug.cgi?id=160813

Patch by Sam Weinig <​sam@webkit.org> on 2016-08-12
Reviewed by Anders Carlsson.

  • wtf/Compiler.h:
  • wtf/StdLibExtras.h:
  • wtf/Variant.h:
4:34 PM Changeset in webkit [204432] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

[Cocoa] Instances of WKObject subclasses don’t work correctly with CFGetTypeID()
​https://bugs.webkit.org/show_bug.cgi?id=160820
<rdar://problem/27825875>

Reviewed by Anders Carlsson.

  • Shared/Cocoa/WKObject.mm:

(-[WKObject _cfTypeID]): Override this internal method and forward to the target object.

4:12 PM Changeset in webkit [204431] by achristensen@apple.com
  • 5 edits in trunk

Make URLParser work with URLs missing URL parts
​https://bugs.webkit.org/show_bug.cgi?id=160824

Reviewed by Brady Eidson.

Source/WebCore:

My initial implementation of URLParser didn't work correctly with URLs missing parts,
like a URL with no fragment, or a URL with no query. This fixes and tests parsing such URLS.
Covered by new API tests.

  • platform/URLParser.cpp:

(WebCore::URLParser::parse):
(WebCore::URLParser::allValuesEqual):

  • platform/URLParser.h:

(WebCore::URLParser::parse):

Tools:

  • TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::s):
(TestWebKitAPI::checkURL):
(TestWebKitAPI::TEST_F):
(TestWebKitAPI::eq): Deleted.

4:08 PM Changeset in webkit [204430] by wilander@apple.com
  • 2 edits in trunk/Tools

Add HashCountedSet API tests to TestWTFLibrary target
​https://bugs.webkit.org/show_bug.cgi?id=160815

Reviewed by Alex Christensen.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Added HashCountedSet.cpp and sorted the file reference section
according to UNIX sort.

3:55 PM WebKitIDL edited by jiewen_tan@apple.com
(diff)
3:53 PM Changeset in webkit [204429] by commit-queue@webkit.org
  • 27 edits
    4 moves in trunk/Source

Rename DocumentLoadTiming and ResourceLoadTiming
​https://bugs.webkit.org/show_bug.cgi?id=160821

Patch by Johan K. Jensen <​johan_jensen@apple.com> on 2016-08-12
Reviewed by Alex Christensen.

Source/WebCore:

Renames ResourceLoadTiming to NetworkLoadTiming.
Renames DocumentLoadTiming to LoadTiming as well as
navigationStart() to startTime(), so it's generic for
both the main resource and subresources.

  • CMakeLists.txt:
  • Modules/gamepad/NavigatorGamepad.cpp:

(WebCore::NavigatorGamepad::from):

  • PlatformMac.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorNetworkAgent.cpp:

(WebCore::buildObjectForTiming):
(WebCore::buildObjectForResourceResponse):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::startLoadingMainResource):

  • loader/DocumentLoader.h:

(WebCore::DocumentLoader::timing):
(WebCore::DocumentLoader::resetTiming):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::dispatchUnloadEvents):
(WebCore::FrameLoader::loadProvisionalItemFromCachedPage):

  • loader/LoadTiming.cpp: Renamed from Source/WebCore/loader/DocumentLoadTiming.cpp.

(WebCore::LoadTiming::LoadTiming):
(WebCore::LoadTiming::monotonicTimeToZeroBasedDocumentTime):
(WebCore::LoadTiming::monotonicTimeToPseudoWallTime):
(WebCore::LoadTiming::markStartTime):
(WebCore::LoadTiming::addRedirect):

  • loader/LoadTiming.h: Renamed from Source/WebCore/loader/DocumentLoadTiming.h.

(WebCore::LoadTiming::markUnloadEventStart):
(WebCore::LoadTiming::markUnloadEventEnd):
(WebCore::LoadTiming::markRedirectStart):
(WebCore::LoadTiming::markRedirectEnd):
(WebCore::LoadTiming::markFetchStart):
(WebCore::LoadTiming::setResponseEnd):
(WebCore::LoadTiming::markLoadEventStart):
(WebCore::LoadTiming::markLoadEventEnd):
(WebCore::LoadTiming::setHasSameOriginAsPreviousDocument):
(WebCore::LoadTiming::startTime):
(WebCore::LoadTiming::unloadEventStart):
(WebCore::LoadTiming::unloadEventEnd):
(WebCore::LoadTiming::redirectStart):
(WebCore::LoadTiming::redirectEnd):
(WebCore::LoadTiming::redirectCount):
(WebCore::LoadTiming::fetchStart):
(WebCore::LoadTiming::responseEnd):
(WebCore::LoadTiming::loadEventStart):
(WebCore::LoadTiming::loadEventEnd):
(WebCore::LoadTiming::hasCrossOriginRedirect):
(WebCore::LoadTiming::hasSameOriginAsPreviousDocument):
(WebCore::LoadTiming::referenceMonotonicTime):
(WebCore::LoadTiming::referenceWallTime):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchLoadEvent):

  • page/PerformanceNavigation.cpp:

(WebCore::PerformanceNavigation::redirectCount):

  • page/PerformanceResourceTiming.cpp:

(WebCore::PerformanceResourceTiming::PerformanceResourceTiming):
(WebCore::PerformanceResourceTiming::resourceTimeToDocumentMilliseconds):

  • page/PerformanceResourceTiming.h:
  • page/PerformanceTiming.cpp:

(WebCore::PerformanceTiming::navigationStart):
(WebCore::PerformanceTiming::unloadEventStart):
(WebCore::PerformanceTiming::unloadEventEnd):
(WebCore::PerformanceTiming::redirectStart):
(WebCore::PerformanceTiming::redirectEnd):
(WebCore::PerformanceTiming::fetchStart):
(WebCore::PerformanceTiming::domainLookupStart):
(WebCore::PerformanceTiming::domainLookupEnd):
(WebCore::PerformanceTiming::connectStart):
(WebCore::PerformanceTiming::connectEnd):
(WebCore::PerformanceTiming::secureConnectionStart):
(WebCore::PerformanceTiming::requestStart):
(WebCore::PerformanceTiming::responseStart):
(WebCore::PerformanceTiming::responseEnd):
(WebCore::PerformanceTiming::loadEventStart):
(WebCore::PerformanceTiming::loadEventEnd):
(WebCore::PerformanceTiming::loadTiming):
(WebCore::PerformanceTiming::monotonicTimeToIntegerMilliseconds):

  • page/PerformanceTiming.h:
  • platform/network/NetworkLoadTiming.h: Renamed from Source/WebCore/platform/network/ResourceLoadTiming.h.

(WebCore::NetworkLoadTiming::NetworkLoadTiming):
(WebCore::NetworkLoadTiming::operator=):
(WebCore::NetworkLoadTiming::isolatedCopy):
(WebCore::NetworkLoadTiming::operator==):
(WebCore::NetworkLoadTiming::operator!=):
(WebCore::NetworkLoadTiming::encode):
(WebCore::NetworkLoadTiming::decode):

  • platform/network/ResourceHandle.h:
  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::crossThreadData):
(WebCore::ResourceResponseBase::fromCrossThreadData):
(WebCore::ResourceResponseBase::compare):

  • platform/network/ResourceResponseBase.h:

(WebCore::ResourceResponseBase::networkLoadTiming):
(WebCore::ResourceResponseBase::encode):
(WebCore::ResourceResponseBase::decode):

  • platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:

(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveResponse):

  • platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp:

(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveResponse):

  • platform/network/cocoa/NetworkLoadTiming.mm: Renamed from Source/WebCore/platform/network/cocoa/ResourceLoadTiming.mm.

(WebCore::timingValue):
(WebCore::copyTimingData):
(WebCore::setCollectsTimingData):

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::calculateWebTimingInformations):

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::getConnectionTimingData):

  • platform/network/mac/WebCoreResourceHandleAsDelegate.mm:

(-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):

  • platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::sendRequestCallback):
(WebCore::ResourceHandle::didStartRequest):
(WebCore::networkEventCallback):

Source/WebKit2:

Rename ResourceLoadTiming to NetworkLoadTiming.

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):

3:32 PM Changeset in webkit [204428] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Command-Shift-O causes infinite loop if web page has frames
​https://bugs.webkit.org/show_bug.cgi?id=160810

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/OpenResourceDialog.js:

(WebInspector.OpenResourceDialog.prototype._addResourcesForFrame):
"frame" doesn't change inside the loop.

3:02 PM Changeset in webkit [204427] by bshafiei@apple.com
  • 8 edits in branches/safari-602-branch/Source/WebKit2

Merge r204414. rdar://problem/27624095

2:56 PM Changeset in webkit [204426] by bshafiei@apple.com
  • 8 edits in branches/safari-602.1.50.1-branch/Source/WebKit2

Merge r204414. rdar://problem/27624095

2:53 PM Changeset in webkit [204425] by bshafiei@apple.com
  • 8 edits in branches/safari-602.1.50.0-branch/Source/WebKit2

Merge r204414. rdar://problem/27624095

2:46 PM Changeset in webkit [204424] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Remove unused includes of RefCountedLeakCounter.h
​https://bugs.webkit.org/show_bug.cgi?id=160817

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-12
Reviewed by Mark Lam.

Source/JavaScriptCore:

  • parser/Nodes.cpp:
  • runtime/Structure.cpp:

Source/WebCore:

  • bindings/js/JSEventListener.cpp:
  • rendering/RenderBlockLineLayout.cpp:
2:38 PM Changeset in webkit [204423] by Ryan Haddad
  • 1 edit
    1 add in trunk/LayoutTests

Add mac-wk1 baseline for js/dom/global-constructors-attributes.html after r204396.

Unreviewed test gardening.

  • platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt: Added.
2:38 PM Changeset in webkit [204422] by Brent Fulgham
  • 3 edits
    3 adds in trunk

ASSERTION FAILED: : line >= firstLine in BytecodeGenerator::emitExpressionInfo.
​https://bugs.webkit.org/show_bug.cgi?id=160535
<rdar://problem/27328151>
Source/JavaScriptCore:


Patch by Pranjal Jumde <​pjumde@apple.com> on 2016-08-12
Reviewed by Saam Barati.

lineNumber from the savePoint was not being restored before calling next() causing discrepancy in the offset and line for the token

  • parser/Parser.h:

(JSC::Parser::restoreLexerState):

LayoutTests:

Patch by Pranjal Jumde <​pjumde@apple.com> on 2016-08-12
Reviewed by Saam Barati.

lineNumber from the savePoint was not being restored before calling next() causing discrepancy in the offset and line for the token

  • js/multiline-function-crash-expected.txt: Added.
  • js/multiline-function-crash.html: Added.
  • js/script-tests/multiline-function-crash.js: Added.
2:24 PM Changeset in webkit [204421] by rniwa@webkit.org
  • 3 edits in trunk/Tools

run-benchmark should run JetStream 1.1 instead of 1.0.1
​https://bugs.webkit.org/show_bug.cgi?id=160816

Reviewed by Filip Pizlo.

Use the latest JetStream 1.1 in run-benchmark.

  • Scripts/webkitpy/benchmark_runner/benchmark_builder.py:

(BenchmarkBuilder.exit):

  • Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
  • Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last

change to JetStream directory.

2:09 PM Changeset in webkit [204420] by Ryan Haddad
  • 1 edit
    3 deletes in trunk/LayoutTests

Unreviewed, rolling out r204416.

This test fails with a debug assertion

Reverted changeset:

"ASSERTION FAILED: : line >= firstLine in
BytecodeGenerator::emitExpressionInfo."
​https://bugs.webkit.org/show_bug.cgi?id=160535
​http://trac.webkit.org/changeset/204416

1:46 PM Changeset in webkit [204419] by gskachkov@gmail.com
  • 8 edits
    1 add in trunk

[ES2016] Implement Object.entries
​https://bugs.webkit.org/show_bug.cgi?id=160412

Reviewed by Saam Barati.

This patch adds entries function to Object that returns list of
key+values pairs. Patch did according to the point of
spec ​https://tc39.github.io/ecma262/#sec-object.entries

Source/JavaScriptCore:

  • builtins/ObjectConstructor.js:

(globalPrivate.enumerableOwnProperties):
(entries):

  • runtime/ObjectConstructor.cpp:

JSTests:

  • stress/object-entries.js:

(compare):
(string_appeared_here.forEach):
(const.getInvokedFunctions.):
(const.getInvokedFunctions):
(Array.prototype.push):

  • stress/object-values.js:
1:34 PM Changeset in webkit [204418] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Support for :lineNumber syntax in Open Resource Dialog
​https://bugs.webkit.org/show_bug.cgi?id=159732
<rdar://problem/27684491>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-12
Reviewed by Matt Baker.

Allow the Open Resource Dialog to support line/column syntax.
Other tools allow "<name>:<line>:<column>" syntax, where the
location data at the end is optional. If the <name> portion
is missing, the location can be used for the active content
view, assuming it has text data and has lines.

  • UserInterface/Base/Main.js:

(WebInspector.focusedOrVisibleContentView):
Expose a function to access the current focused / visible content view.

(WebInspector.dialogWasDismissed):
Include passing on cookie data when showing a represented object.

  • UserInterface/Views/Dialog.js:

(WebInspector.Dialog):
(WebInspector.Dialog.prototype.get visible):
(WebInspector.Dialog.prototype.get delegate):
(WebInspector.Dialog.prototype.get representedObject):
(WebInspector.Dialog.prototype.get cookie):
(WebInspector.Dialog.prototype.dismiss):

  • UserInterface/Models/ResourceQueryResult.js:

(WebInspector.ResourceQueryResult):
(WebInspector.ResourceQueryResult.prototype.get cookie):
Include cookie data along with the represented object in matches
and dialog results.

  • UserInterface/Controllers/ResourceQueryController.js:

(WebInspector.ResourceQueryController.prototype.executeQuery):
Cut off location data from a query, and stash it on the query result.
A query can be "<name>:<line>:<column>", and the line/column data
becomes cookie data for the resource.

  • UserInterface/Views/OpenResourceDialog.js:

(WebInspector.OpenResourceDialog.prototype._populateResourceTreeOutline):
If the query is just ":<line>:<column>" have it jump to a location
in the current content view if applicable.

(WebInspector.OpenResourceDialog.prototype._handleKeydownEvent):
(WebInspector.OpenResourceDialog.prototype._treeSelectionDidChange):
When dismissing, include cookie data.

1:03 PM Changeset in webkit [204417] by achristensen@apple.com
  • 4 edits in trunk

Initial URLParser implementation
​https://bugs.webkit.org/show_bug.cgi?id=160811

Reviewed by Brady Eidson.

Source/WebCore:

There are a lot of missing parts, but it works in one case, so I test that one case.

  • platform/URLParser.cpp:

(WebCore::isC0Control):
(WebCore::isC0ControlOrSpace):
(WebCore::isTabOrNewline):
(WebCore::isASCIIDigit):
(WebCore::isASCIIAlpha):
(WebCore::isASCIIAlphanumeric):
(WebCore::isSpecialScheme):
(WebCore::URLParser::parse):

Tools:

  • TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::eq):
(TestWebKitAPI::checkURL):
(TestWebKitAPI::TEST_F):

11:53 AM Changeset in webkit [204416] by Brent Fulgham
  • 1 edit
    3 adds in trunk/LayoutTests

ASSERTION FAILED: : line >= firstLine in BytecodeGenerator::emitExpressionInfo.
​https://bugs.webkit.org/show_bug.cgi?id=160535
<rdar://problem/27328151>

Patch by Pranjal Jumde <​pjumde@apple.com> on 2016-08-12
Reviewed by Saam Barati.

lineNumber from the savePoint was not being restored before calling next() causing discrepancy in the offset and line for the token

  • js/multiline-function-crash-expected.txt: Added.
  • js/multiline-function-crash.html: Added.
  • js/script-tests/multiline-function-crash.js: Added.
11:51 AM Changeset in webkit [204415] by Brent Fulgham
  • 1 edit
    2 adds in trunk/LayoutTests

Add test for fixed nullptr deref error
​https://bugs.webkit.org/show_bug.cgi?id=160807
<rdar://problem/15576693>

Unreviewed test gardening.

  • mathml/row-clone-crash-expected.txt: Added.
  • mathml/row-clone-crash.html: Added.
11:50 AM Changeset in webkit [204414] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

message loading never finishes in Mail
​https://bugs.webkit.org/show_bug.cgi?id=160806
rdar://problem/27624095

Reviewed by Dan Bernstein.

Add more checks for when a process goes away before we've established a proper connection to it.

  • Platform/IPC/mac/ConnectionMac.mm:

(IPC::Connection::receiveSourceEventHandler):
Handle the MACH_NOTIFY_NO_SENDERS and MACH_NOTIFY_SEND_ONCE messages here. Also, once we receive a send
right from the other side, stop listening for the MACH_NOTIFY_NO_SENDERS notification.

  • UIProcess/ChildProcessProxy.cpp:

(WebKit::ChildProcessProxy::didFinishLaunching):
Null check the connection identifier.

  • UIProcess/Launcher/ProcessLauncher.cpp:

(WebKit::ProcessLauncher::ProcessLauncher):
(WebKit::processLauncherWorkQueue): Deleted.
Get rid of the process launcher queue - we're not doing any blocking work here.

  • UIProcess/Launcher/ProcessLauncher.h:

Add a weak factory.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::systemDirectoryPath):
Move this before launchProcess().

(WebKit::ProcessLauncher::launchProcess):
Merge createService and connectToService into launchProcess. Also make the following changes:

  • Use mach_port_request_notification to get a notification for when our receive right loses all its senders.

This lets us listen for the other process going away before we have a send right for it.

  • Use xpc_connection_set_event_handler to listen for errors, so we can detect the process going away before

we've sent a message to it.

(WebKit::connectToService): Deleted.
(WebKit::createService): Deleted.

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::didFinishLaunching):
If we failed to launch, call networkProcessCrashedOrFailedToLaunch so we'll unblock any waiting web processes.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didFinishLaunching):
Null check the connection and XPC connection before trying to get its pid.

9:54 AM Changeset in webkit [204413] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Rebaseline js/dom/global-constructors-attributes.html after r204396.

Unreviewed test gardening.

  • platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
9:51 AM Changeset in webkit [204412] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r204404.
​https://bugs.webkit.org/show_bug.cgi?id=160805

"Broke the build for some Apple Internal projects" (Requested
by bradee-oh on #webkit).

Reverted changeset:

"Support WebIDL unions (Part 1)"
​https://bugs.webkit.org/show_bug.cgi?id=160769
​http://trac.webkit.org/changeset/204404

8:55 AM Changeset in webkit [204411] by beidson@apple.com
  • 3 edits in trunk/Tools

Fix the 32-bit Mac build after:
Add WK2 ExperimentalFeature support to MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=160788

Reviewed by NOBODY (OOPS!).

Sprinkle "#if WK_API_ENABLED"s liberally.

  • MiniBrowser/mac/AppDelegate.m:

(defaultConfiguration):

  • MiniBrowser/mac/SettingsController.m:

(-[SettingsController _populateMenu]):
(-[SettingsController validateMenuItem:]):

3:38 AM Changeset in webkit [204410] by Philippe Normand
  • 3 edits in trunk/Source/WebCore

[GStreamer] Performance problems with bigger video resolution in the webrtc media player
​https://bugs.webkit.org/show_bug.cgi?id=153826

Reviewed by Alejandro G. Castro.

Keep the OpenWebRTC video renderer size synchronized with the Media element size.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:

(WebCore::MediaPlayerPrivateGStreamerOwr::setSize):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.h:
3:35 AM Changeset in webkit [204409] by Philippe Normand
  • 6 edits in trunk

[GStreamer][OWR] Video rendering fixes
​https://bugs.webkit.org/show_bug.cgi?id=160764

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

The video renderer of OpenWebRTC now uses OpenGL so we have two
options to correctly handle this in WebKit:

  • if USE_GSTREAMER_GL is enabled then we simply pass our GL appsink to the renderer and there is no need to create glupload and glcolorconvert element on WebKit side because those elements are already created on OpenWebRTC side.
  • if USE_GSTREAMER_GL is disabled then we need our sink to download frames from the GPU so that rendering can be done with the WebKit video sink in main memory.
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::createGLAppSink): Split out GL appsink management
to a separate method that can be used by sub-classes.
(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSinkGL): Use new createGLAppSink method.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:

(WebCore::MediaPlayerPrivateGStreamerOwr::createVideoSink): handle GStreamer-GL configurations
and pass a different element to the renderer depending on the configuration.

Tools:

  • gtk/jhbuild.modules: Bump to current OpenWebRTC master.
2:11 AM Changeset in webkit [204408] by pvollan@apple.com
  • 2 edits in trunk/Tools

Add missing return statement in convertFast function added in r204376.

Unreviewed.

  • Scripts/webkitpy/common/system/path.py:

(_CygPath.convertFast):

Note: See TracTimeline for information about the timeline view.