⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 15, 2016:

11:50 PM Changeset in webkit [204500] by rniwa@webkit.org
  • 19 edits
    8 adds in trunk

Conversion to sequence<T> is broken for iterable objects
https://bugs.webkit.org/show_bug.cgi?id=160801

Reviewed by Darin Adler.

Source/JavaScriptCore:

Export functions used to iterate over iterable objects.

  • runtime/IteratorOperations.h:

(JSC::forEachInIterable):

Source/WebCore:

Added the proper iterator support for sequence<T> with one caveat that we don't check for RegExp object
per https://github.com/heycam/webidl/issues/145.

See http://heycam.github.io/webidl/#es-sequence and http://heycam.github.io/webidl/#es-overloads

Tests: bindings/scripts/test/TestOverloadedConstructorsWithSequence.idl

  • bindings/js/JSDOMBinding.cpp:

(WebCore::hasIteratorMethod): Added. A helper function for checking whether a JSValue is iterable or not.

  • bindings/js/JSDOMBinding.h:

(WebCore::NativeValueTraits<unsigned>::nativeValue): Removed the check for isNumber to match the spec'ed
behavior at http://heycam.github.io/webidl/#es-unsigned-long which calls ToNumber first without checking
whether the value is a number or not.
(WebCore::toRefPtrNativeArray): Replaced isJSArray check by isObject check and throw a TypeError. Deployed
forEachInIterable to support non-JSArray iterable objects. Also removed the function pointer from the third
argument since we were always calling JSCT::toWrapped.
(WebCore::toNativeArray): Ditto.

  • bindings/js/JSDOMConvert.h:

(WebCore::Converter<Vector<T>>::convert): Removed the comment about toNativeArray not throwing when value
is not an object.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateOverloadedFunctionOrConstructor): Removed the check for isJSArray for sequence<T> as an iterable
object is not necessary a JSArray.
(WillConvertUndefinedToDefaultParameterValue): Don't return 1 for all sequences since toNativeArray and
toRefPtrNativeArray now throws on undefined due to isObject check.
(JSValueToNative): Removed the third argument from toRefPtrNativeArray.

  • bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructorsWithSequence.cpp: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructorsWithSequence.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestOverloadedConstructorsWithSequencePrivate.h: Added.
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalSequenceIsEmpty):

  • bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp: Added.
  • bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.h: Added.
  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::jsTestTypedefsPrototypeFunctionFunc):

  • bindings/scripts/test/TestOverloadedConstructorsWithSequence.idl: Added.

LayoutTests:

Added test cases for converting non-JSArray objects to sequence<T> for MutationObserver, FontFaceSet, and WebSocket.

  • fast/dom/MutationObserver/observe-exceptions-expected.txt:
  • fast/dom/MutationObserver/observe-exceptions.html:
  • fast/text/font-face-set-javascript-expected.txt:
  • fast/text/font-face-set-javascript.html:
  • http/tests/dom/window-open-about-webkit-org-and-access-document-expected.txt: Rebaselined due to js-test-pre.js change.
  • http/tests/resources/js-test-pre.js: Merged ToT from resources/js-test-pre.js.
  • http/tests/security/xssAuditor/block-does-not-leak-location-expected.txt: Rebaselined due to js-test-pre.js change.
  • http/tests/security/xssAuditor/block-does-not-leak-referrer-expected.txt: Ditto.
  • http/tests/websocket/tests/hybi/websocket-constructor-protocols-expected.txt: Added.
  • http/tests/websocket/tests/hybi/websocket-constructor-protocols.html: Added.
11:48 PM Changeset in webkit [204499] by Chris Dumez
  • 6 edits in trunk/Source/WebCore

Rename RegisteredEventListener::listener() to callback() for clarity
https://bugs.webkit.org/show_bug.cgi?id=160873

Reviewed by Darin Adler.

Rename RegisteredEventListener::listener() to callback() for clarity
and to match the specification:

Always calling listener->listener() seems wrong.

  • bindings/js/JSCommandLineAPIHostCustom.cpp:

(WebCore::getJSListenerFunctions):

  • dom/EventListenerMap.cpp:

(WebCore::findListener):
(WebCore::removeFirstListenerCreatedFromMarkup):
(WebCore::copyListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerIterator::nextListener):

  • dom/EventTarget.cpp:

(WebCore::EventTarget::getAttributeEventListener):
(WebCore::EventTarget::fireEventListeners):

  • dom/RegisteredEventListener.h:

(WebCore::RegisteredEventListener::callback):
(WebCore::RegisteredEventListener::RegisteredEventListener):
(WebCore::RegisteredEventListener::listener): Deleted.

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getEventListeners):
(WebCore::InspectorDOMAgent::buildObjectForEventListener):

11:41 PM Changeset in webkit [204498] by Simon Fraser
  • 2 edits in trunk/Tools

webkitpy error in TestRunResults.merge()
https://bugs.webkit.org/show_bug.cgi?id=160882

Reviewed by Daniel Bates.

The argument to TestRunResults.merge() can be None if there are no device-specifc
initial results or retry results in Manager.run(), so just return early in that case.

  • Scripts/webkitpy/layout_tests/models/test_run_results.py:

(TestRunResults.merge):

11:24 PM Changeset in webkit [204497] by Chris Dumez
  • 9 edits in trunk/Source/WebCore

Add support for dictionary members of non nullable wrapper types
https://bugs.webkit.org/show_bug.cgi?id=160876

Reviewed by Darin Adler.

Add support for dictionary members of non nullable wrapper types. We
only supported nullable wrapper types as dictionary members so far.

No new tests, updated bindings tests.

  • bindings/js/JSDOMConvert.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateDictionaryImplementationContent):
(GenerateParametersCheck):
(JSValueToNative):
(GenerateConstructorDefinition):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::construct):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorNamedConstructor::construct):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::convertDictionary<TestObj::Dictionary>):
(WebCore::convertDictionary<TestObj::DictionaryThatShouldNotTolerateNull>):
(WebCore::convertDictionary<TestObj::DictionaryThatShouldTolerateNull>):
(WebCore::jsTestObjPrototypeFunctionAttachShadowRoot):

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::constructJSTestOverloadedConstructors4):
(WebCore::constructJSTestOverloadedConstructors5):

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefsConstructor::construct):

  • bindings/scripts/test/TestObj.idl:
10:14 PM Changeset in webkit [204496] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Large class lists are not easily discoverable with "Classes" quick-toggle
https://bugs.webkit.org/show_bug.cgi?id=160856

Patch by Devin Rousso <Devin Rousso> on 2016-08-15
Reviewed by Joseph Pecoraro.

  • UserInterface/Base/DOMUtilities.js:

(WebInspector.linkifyNodeReference):
Add option to truncate the text of the linkified node.

  • UserInterface/Views/CSSStyleDetailsSidebarPanel.css:

(.sidebar > .panel.details.css-style > .content ~ .class-list-container):
Increase the max-height to partially show additional classes if many are set.

  • UserInterface/Views/RulesStyleDetailsPanel.js:

(WebInspector.RulesStyleDetailsPanel.prototype.refresh.insertMediaOrInheritanceLabel):
Trucate the name of inherited nodes so they don't take up as much space in the sidebar.

  • UserInterface/Views/VisualStyleSelectorSection.css:

(.details-section.visual-style-selector-section > .header > .current-selector): Deleted.
(.details-section.visual-style-selector-section > .content > .selectors > .selector-list > .section-divider > .titles): Deleted.
Removed since they are already inherited.

9:17 PM Changeset in webkit [204495] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Regression 204203-204210] 32-bit ASSERTION FAILED: !m_data[index].name.isValid()
https://bugs.webkit.org/show_bug.cgi?id=160881

Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-08-15
Reviewed by Mark Lam.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):
We were trying to set the result of the Identity node to the same
value as the source of the Identity.
That is pretty messed up.

8:32 PM Changeset in webkit [204494] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

Drop unused EventTarget::hasActiveEventListeners()
https://bugs.webkit.org/show_bug.cgi?id=160869

Reviewed by Alex Christensen.

  • dom/EventListenerMap.cpp:

(WebCore::EventListenerMap::containsActive): Deleted.

  • dom/EventListenerMap.h:
  • dom/EventTarget.cpp:

(WebCore::EventTarget::hasActiveEventListeners): Deleted.

  • dom/EventTarget.h:
7:27 PM Changeset in webkit [204493] by commit-queue@webkit.org
  • 12 edits in trunk

Speed up compile times by not including wtf/Variant.h so much
https://bugs.webkit.org/show_bug.cgi?id=160847

Patch by Sam Weinig <sam@webkit.org> on 2016-08-15
Reviewed by Alex Christensen and Saam Barati.

Source/WebCore:

"using std::experimental::variant" caused internal compiler errors in MSVC2015,
so we are just writing std::experimental where we use it for now.
We should move variant into the std::experimental namespace.

  • bindings/js/JSNodeOrString.cpp:

(WebCore::toNodeOrStringVector):

  • bindings/js/JSNodeOrString.h:
  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::childElementCount):
(WebCore::ContainerNode::append):
(WebCore::ContainerNode::prepend):

  • dom/ContainerNode.h:
  • dom/Node.cpp:

(WebCore::Node::appendChild):
(WebCore::nodeSetPreTransformedFromNodeOrStringVector):
(WebCore::firstFollowingSiblingNotInNodeSet):
(WebCore::Node::convertNodesOrStringsIntoNode):
(WebCore::Node::before):
(WebCore::Node::after):
(WebCore::Node::replaceWith):

  • dom/Node.h:

(WebCore::Node::setStyleChange):
(WebCore::Node::customPseudoId):

Source/WTF:

  • wtf/Forward.h:

Add forward declaration of std::variant.

  • wtf/StdLibExtras.h:

Remove references to std::variant. Move them to wtf/Variant.h

Tools:

  • TestWebKitAPI/Tests/WTF/Variant.cpp:

(TestWebKitAPI::TEST):
Explicitly use std::experimental::variant.

7:06 PM Changeset in webkit [204492] by dbates@webkit.org
  • 5 edits
    5 adds in trunk

ASSERTION FAILURE: [[videoLayer delegate] isKindOfClass:getUIViewClass()] in WebAVPlayerLayerView_videoView()
https://bugs.webkit.org/show_bug.cgi?id=160433

Reviewed by Eric Carlson.

Source/WebCore:

Early return from WebAVPlayerLayerView_videoView() if the PiP layer does not have a non-nil delegate view.

Test: media/controls/close-page-with-picture-in-picture-video-assertion-failure.html

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebAVPlayerLayerView_videoView):

LayoutTests:

Add a layout test to ensure that we do not cause an assertion failure when exiting PiP by closing the tab.

  • TestExpectations: Skip media/control/ipad tests on all ports. We will re-enable these tests for iOS.
  • media/controls/close-page-with-picture-in-picture-video-assertion-failure-expected.txt: Added.
  • media/controls/close-page-with-picture-in-picture-video-assertion-failure.html: Added.
  • media/controls/resources/picture-in-picture.html: Added.
  • platform/ios-simulator/TestExpectations: Mark tests media/control/ipad as Pass so that we run them

in the iPad simulator.

6:43 PM Changeset in webkit [204491] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Close button on selected item in Network tab is misaligned
https://bugs.webkit.org/show_bug.cgi?id=160884

Patch by Devin Rousso <Devin Rousso> on 2016-08-15
Reviewed by Matt Baker.

  • UserInterface/Views/NetworkSidebarPanel.css:

(.sidebar > .panel.navigation.network .status .close.status-button):

6:34 PM Changeset in webkit [204490] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Error/Warning icons are misplaced in the Visual sidebar
https://bugs.webkit.org/show_bug.cgi?id=160875

Patch by Devin Rousso <Devin Rousso> on 2016-08-15
Reviewed by Matt Baker.

  • UserInterface/Views/VisualStyleCommaSeparatedKeywordEditor.css:

(.visual-style-property-container.comma-separated-keyword-editor > .visual-style-property-value-container > .visual-style-special-property-placeholder): Deleted.
Reworked to apply more generally to editors without titles.

  • UserInterface/Views/VisualStylePropertyEditor.css:

(.visual-style-property-container.missing-dependency > .visual-style-property-editor-warning):
(.visual-style-property-container.invalid-value > .visual-style-property-editor-warning):
(.visual-style-property-container:matches(.missing-dependency, .invalid-value) > *:first-child:matches(.visual-style-property-value-container)):
(.visual-style-property-container > *:first-child:matches(.visual-style-property-value-container) > .visual-style-special-property-placeholder):
(.visual-style-property-container > .visual-style-property-editor-warning.missing-dependency): Deleted.
(.visual-style-property-container > .visual-style-property-editor-warning.invalid-value): Deleted.
Reworked class names to be on the element container instead of the icon.

  • UserInterface/Views/VisualStylePropertyEditor.js:

(WebInspector.VisualStylePropertyEditor.prototype.update):
(WebInspector.VisualStylePropertyEditor.prototype.updateEditorValues):
(WebInspector.VisualStylePropertyEditor.prototype._valueDidChange):
(WebInspector.VisualStylePropertyEditor.prototype._checkDependencies):

4:32 PM Changeset in webkit [204489] by sbarati@apple.com
  • 7 edits in trunk/Source

Web Inspector: Introduce a method to enable code coverage profiler without enabling type profiler
https://bugs.webkit.org/show_bug.cgi?id=160750
<rdar://problem/27793469>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

  • inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::disableTypeProfiler):
(Inspector::InspectorRuntimeAgent::enableControlFlowProfiler):
(Inspector::InspectorRuntimeAgent::disableControlFlowProfiler):
(Inspector::InspectorRuntimeAgent::setTypeProfilerEnabledState):
(Inspector::InspectorRuntimeAgent::setControlFlowProfilerEnabledState):

  • inspector/agents/InspectorRuntimeAgent.h:
  • inspector/protocol/Runtime.json:

Source/WebInspectorUI:

  • UserInterface/Base/Main.js:

(WebInspector.loaded):

  • UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype._setTypeTokenAnnotatorEnabledState):

4:31 PM Changeset in webkit [204488] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Array.prototype.map builtin should go on the fast path when constructor===@Array
https://bugs.webkit.org/show_bug.cgi?id=160836

Reviewed by Keith Miller.

In the FTL, we were not compiling the result array in Array.prototype.map
efficiently when the result array should use the Array constructor
(which is the common case). We used to compile it as:
x: JSConstant(Array)
y: Construct(@x, ...)
instead of
y: NewArrayWithSize(...)

This patch changes the builtin to go down the fast path when certain
conditions are met. Often, the check to go down the fast path will
be constant folded because we always create a normal array from the
Array constructor.

This is around a 5% speedup on ES6 Sample Bench.

I also made similar changes for Array.prototype.filter
and Array.prototype.concat on its slow path.

  • builtins/ArrayPrototype.js:
3:43 PM Changeset in webkit [204487] by Ryan Haddad
  • 2 edits
    1 add in branches/safari-602-branch/LayoutTests

Test gardening for rdar://problem/27595142.

3:42 PM Changeset in webkit [204486] by keith_miller@apple.com
  • 8 edits
    27545 adds
    1 delete in branches/safari-602.1.50.1-branch

Merge r203972.

2016-08-01 Keith Miller <keith_miller@apple.com>

We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
https://bugs.webkit.org/show_bug.cgi?id=160372

Rubber stamped by Geoffrey Garen.

This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
a new top level directory, JSTests. Having the tests in the Source directory
was both confusing and inconvenient for people that just want to checkout the
source code of WebKit. Since there is no other obvious place to put all the
JavaScript tests a new top level directory seemed the most sensible.

  • JSTests/: Copied from Source/JavaScriptCore/tests.
  • Source/JavaScriptCore/tests/: Deleted.
  • Scripts/import-test262-tests:
  • Scripts/run-javascriptcore-tests:
  • Scripts/update-javascriptcore-test-res:
2:52 PM Changeset in webkit [204485] by mark.lam@apple.com
  • 7 edits
    1 add in trunk/Source/JavaScriptCore

Make JSValue::strictEqual() handle failures to resolve JSRopeStrings.
https://bugs.webkit.org/show_bug.cgi?id=160832
<rdar://problem/27577556>

Reviewed by Geoffrey Garen.

Currently, JSValue::strictEqualSlowCaseInline() (and peers) will blindly try to
access the StringImpl of a JSRopeString that fails to resolve its rope. As a
result, we'll crash with null pointer dereferences.

We can fix this by introducing a JSString::equal() method that will do the
equality comparison, but is aware of the potential failures to resolve ropes.
JSValue::strictEqualSlowCaseInline() (and peers) will now call JSString::equal()
instead of accessing the underlying StringImpl directly.

Also added some exception checks.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • jit/JITOperations.cpp:
  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncIndexOf):
(JSC::arrayProtoFuncLastIndexOf):

  • runtime/JSCJSValueInlines.h:

(JSC::JSValue::equalSlowCaseInline):
(JSC::JSValue::strictEqualSlowCaseInline):

  • runtime/JSString.cpp:

(JSC::JSString::equalSlowCase):

  • runtime/JSString.h:
  • runtime/JSStringInlines.h: Added.

(JSC::JSString::equal):

2:35 PM Changeset in webkit [204484] by keith_miller@apple.com
  • 8 edits
    7 copies
    4 adds in trunk/Source

Implement WASM Parser and B3 IR generator
https://bugs.webkit.org/show_bug.cgi?id=160681

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

This patch adds the skeleton for a WebAssembly pipeline. The
pipeline is designed in order to make it easy to have as much of
the compilation process threaded as possible. The flow of the
pipeline roughly goes as follows:

1) Create a WASMPlan with the VM and a Vector of the
assembly. Currently the plan will process all the work
synchronously, however, in the future this can be offloaded to
other threads.

2) The plan will run the WASMModuleParser, which collates all the
information needed to compile each module function
independently. Since, we are still in the early phases, the only
information is the starting and ending byte of the function's
body. The module parser, however, still scans both and
semi-validates the type and the function sections.

3) Each function is decoded and compiled. In the future this
should also include a opcode validation phase. The
WASMFunctionParser is templatized so that a validator should be
able to use most of the same code the B3 IR generator does.

4) When the plan has finished it will fill a Vector of
B3::Compilation objects that correspond to the respective function
in the WASM module.

The current testing plan for the modules is to inline the the
binary generated by the spec's OCaml prototype. The inlined binary
is passed to a WASMPlan then invoked to check the result of the
function. In the future we should add a more robust testing
infrastructure.

(printUsageStatement):
(CommandLine::parseArguments):
(invoke):
(runWASMTests):
(main):

  • wasm/JSWASMModule.h:

(JSC::JSWASMModule::globalVariableTypes):

  • wasm/WASMB3IRGenerator.cpp: Added.

(JSC::WASM::B3IRGenerator::B3IRGenerator):
(JSC::WASM::B3IRGenerator::addLocal):
(JSC::WASM::B3IRGenerator::binaryOp):
(JSC::WASM::B3IRGenerator::addConstant):
(JSC::WASM::B3IRGenerator::addBlock):
(JSC::WASM::B3IRGenerator::endBlock):
(JSC::WASM::B3IRGenerator::addReturn):
(JSC::WASM::B3IRGenerator::unify):
(JSC::WASM::B3IRGenerator::initializeIncommingTypes):
(JSC::WASM::B3IRGenerator::unifyValuesWithLevel):
(JSC::WASM::B3IRGenerator::stackForControlLevel):
(JSC::WASM::B3IRGenerator::blockForControlLevel):
(JSC::WASM::parseAndCompile):

  • wasm/WASMB3IRGenerator.h: Copied from Source/WTF/wtf/DataLog.h.
  • wasm/WASMFormat.h:
  • wasm/WASMFunctionParser.h: Added.

(JSC::WASM::WASMFunctionParser<Context>::WASMFunctionParser):
(JSC::WASM::WASMFunctionParser<Context>::parse):
(JSC::WASM::WASMFunctionParser<Context>::parseBlock):
(JSC::WASM::WASMFunctionParser<Context>::parseExpression):

  • wasm/WASMModuleParser.cpp: Added.

(JSC::WASM::WASMModuleParser::parse):
(JSC::WASM::WASMModuleParser::parseFunctionTypes):
(JSC::WASM::WASMModuleParser::parseFunctionSignatures):
(JSC::WASM::WASMModuleParser::parseFunctionDefinitions):

  • wasm/WASMModuleParser.h: Copied from Source/WTF/wtf/DataLog.h.

(JSC::WASM::WASMModuleParser::WASMModuleParser):
(JSC::WASM::WASMModuleParser::functionInformation):

  • wasm/WASMOps.h: Copied from Source/WTF/wtf/DataLog.h.
  • wasm/WASMParser.h: Added.

(JSC::WASM::WASMParser::parseVarUInt32):
(JSC::WASM::WASMParser::WASMParser):
(JSC::WASM::WASMParser::consumeCharacter):
(JSC::WASM::WASMParser::consumeString):
(JSC::WASM::WASMParser::parseUInt32):
(JSC::WASM::WASMParser::parseUInt7):
(JSC::WASM::WASMParser::parseVarUInt1):
(JSC::WASM::WASMParser::parseValueType):

  • wasm/WASMPlan.cpp: Copied from Source/WTF/wtf/DataLog.h.

(JSC::WASM::Plan::Plan):

  • wasm/WASMPlan.h: Copied from Source/WTF/wtf/DataLog.h.
  • wasm/WASMSections.cpp: Copied from Source/WTF/wtf/DataLog.h.

(JSC::WASM::WASMSections::lookup):

  • wasm/WASMSections.h: Copied from Source/WTF/wtf/DataLog.h.

(JSC::WASM::WASMSections::validateOrder):

Source/WTF:

  • wtf/DataLog.h:

(WTF::dataLogLn): Add a new dataLog function, dataLogLn that
automagically includes a new line at the end of the print.

  • wtf/LEBDecoder.h:

(decodeUInt32):
(decodeInt32): Change the LEBDecoder to take a pointer and length
rather than a Vector.

2:23 PM Changeset in webkit [204483] by achristensen@apple.com
  • 12 edits
    8 moves in trunk/Source

Rename SocketStreamHandleBase to SocketStreamHandle and SocketStreamHandle to SocketStreamHandleImpl
https://bugs.webkit.org/show_bug.cgi?id=160858

Reviewed by Brady Eidson.

Source/WebCore:

No new tests. No change in behavior, except GTK's SocketStreamHandleImpl is now safely ThreadSafeRefCounted.
This is preparation for making a new kind of SocketStreamHandle which is a proxy that communicates with the NetworkProcess in WebKit2.

  • CMakeLists.txt:
  • PlatformAppleWin.cmake:
  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • PlatformMac.cmake:
  • PlatformWinCairo.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • page/SocketProvider.cpp:

(WebCore::SocketProvider::createSocketStreamHandle):

  • platform/network/SocketStreamHandle.cpp: Copied from Source/WebCore/platform/network/SocketStreamHandleBase.cpp.

(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore::SocketStreamHandle::state):
(WebCore::SocketStreamHandle::send):
(WebCore::SocketStreamHandle::close):
(WebCore::SocketStreamHandle::disconnect):
(WebCore::SocketStreamHandle::sendPendingData):
(WebCore::SocketStreamHandleBase::SocketStreamHandleBase): Deleted.
(WebCore::SocketStreamHandleBase::state): Deleted.
(WebCore::SocketStreamHandleBase::send): Deleted.
(WebCore::SocketStreamHandleBase::close): Deleted.
(WebCore::SocketStreamHandleBase::disconnect): Deleted.
(WebCore::SocketStreamHandleBase::sendPendingData): Deleted.

  • platform/network/SocketStreamHandle.h: Copied from Source/WebCore/platform/network/SocketStreamHandleBase.h.

(WebCore::SocketStreamHandle::~SocketStreamHandle):
(WebCore::SocketStreamHandle::client):
(WebCore::SocketStreamHandleBase::~SocketStreamHandleBase): Deleted.
(WebCore::SocketStreamHandleBase::client): Deleted.

  • platform/network/SocketStreamHandleBase.cpp: Removed.
  • platform/network/SocketStreamHandleBase.h: Removed.
  • platform/network/cf/SocketStreamHandle.h: Removed.
  • platform/network/cf/SocketStreamHandleCFNet.cpp: Removed.
  • platform/network/cf/SocketStreamHandleImpl.h: Copied from Source/WebCore/platform/network/cf/SocketStreamHandle.h.

(WebCore::SocketStreamHandleImpl::create):
(WebCore::SocketStreamHandle::create): Deleted.

  • platform/network/cf/SocketStreamHandleImplCFNet.cpp: Copied from Source/WebCore/platform/network/cf/SocketStreamHandleCFNet.cpp.

(WebCore::SocketStreamHandleImpl::SocketStreamHandleImpl):
(WebCore::SocketStreamHandleImpl::scheduleStreams):
(WebCore::SocketStreamHandleImpl::retainSocketStreamHandle):
(WebCore::SocketStreamHandleImpl::releaseSocketStreamHandle):
(WebCore::SocketStreamHandleImpl::copyPACExecutionDescription):
(WebCore::SocketStreamHandleImpl::pacExecutionCallback):
(WebCore::SocketStreamHandleImpl::executePACFileURL):
(WebCore::SocketStreamHandleImpl::removePACRunLoopSource):
(WebCore::SocketStreamHandleImpl::chooseProxy):
(WebCore::SocketStreamHandleImpl::chooseProxyFromArray):
(WebCore::SocketStreamHandleImpl::createStreams):
(WebCore::SocketStreamHandleImpl::getStoredCONNECTProxyCredentials):
(WebCore::authenticationSchemeFromAuthenticationMethod):
(WebCore::SocketStreamHandleImpl::addCONNECTCredentials):
(WebCore::SocketStreamHandleImpl::copyCFStreamDescription):
(WebCore::SocketStreamHandleImpl::readStreamCallback):
(WebCore::SocketStreamHandleImpl::writeStreamCallback):
(WebCore::SocketStreamHandleImpl::reportErrorToClient):
(WebCore::SocketStreamHandleImpl::~SocketStreamHandleImpl):
(WebCore::SocketStreamHandleImpl::platformSend):
(WebCore::SocketStreamHandleImpl::platformClose):
(WebCore::SocketStreamHandleImpl::port):
(WebCore::SocketStreamHandle::SocketStreamHandle): Deleted.
(WebCore::SocketStreamHandle::scheduleStreams): Deleted.
(WebCore::SocketStreamHandle::retainSocketStreamHandle): Deleted.
(WebCore::SocketStreamHandle::releaseSocketStreamHandle): Deleted.
(WebCore::SocketStreamHandle::copyPACExecutionDescription): Deleted.
(WebCore::SocketStreamHandle::pacExecutionCallback): Deleted.
(WebCore::SocketStreamHandle::executePACFileURL): Deleted.
(WebCore::SocketStreamHandle::removePACRunLoopSource): Deleted.
(WebCore::SocketStreamHandle::chooseProxy): Deleted.
(WebCore::SocketStreamHandle::chooseProxyFromArray): Deleted.
(WebCore::SocketStreamHandle::createStreams): Deleted.
(WebCore::SocketStreamHandle::getStoredCONNECTProxyCredentials): Deleted.
(WebCore::SocketStreamHandle::addCONNECTCredentials): Deleted.
(WebCore::SocketStreamHandle::copyCFStreamDescription): Deleted.
(WebCore::SocketStreamHandle::readStreamCallback): Deleted.
(WebCore::SocketStreamHandle::writeStreamCallback): Deleted.
(WebCore::SocketStreamHandle::reportErrorToClient): Deleted.
(WebCore::SocketStreamHandle::~SocketStreamHandle): Deleted.
(WebCore::SocketStreamHandle::platformSend): Deleted.
(WebCore::SocketStreamHandle::platformClose): Deleted.
(WebCore::SocketStreamHandle::port): Deleted.

  • platform/network/curl/SocketStreamHandle.h: Removed.
  • platform/network/curl/SocketStreamHandleCurl.cpp: Removed.
  • platform/network/curl/SocketStreamHandleImpl.h: Copied from Source/WebCore/platform/network/curl/SocketStreamHandle.h.

(WebCore::SocketStreamHandleImpl::create):
(WebCore::SocketStreamHandle::create): Deleted.

  • platform/network/curl/SocketStreamHandleImplCurl.cpp: Copied from Source/WebCore/platform/network/curl/SocketStreamHandleCurl.cpp.

(WebCore::SocketStreamHandleImpl::SocketStreamHandleImpl):
(WebCore::SocketStreamHandleImpl::~SocketStreamHandleImpl):
(WebCore::SocketStreamHandleImpl::platformSend):
(WebCore::SocketStreamHandleImpl::platformClose):
(WebCore::SocketStreamHandleImpl::readData):
(WebCore::SocketStreamHandleImpl::sendData):
(WebCore::SocketStreamHandleImpl::waitForAvailableData):
(WebCore::SocketStreamHandleImpl::startThread):
(WebCore::SocketStreamHandleImpl::stopThread):
(WebCore::SocketStreamHandleImpl::didReceiveData):
(WebCore::SocketStreamHandleImpl::didOpenSocket):
(WebCore::SocketStreamHandleImpl::createCopy):
(WebCore::SocketStreamHandle::SocketStreamHandle): Deleted.
(WebCore::SocketStreamHandle::~SocketStreamHandle): Deleted.
(WebCore::SocketStreamHandle::platformSend): Deleted.
(WebCore::SocketStreamHandle::platformClose): Deleted.
(WebCore::SocketStreamHandle::readData): Deleted.
(WebCore::SocketStreamHandle::sendData): Deleted.
(WebCore::SocketStreamHandle::waitForAvailableData): Deleted.
(WebCore::SocketStreamHandle::startThread): Deleted.
(WebCore::SocketStreamHandle::stopThread): Deleted.
(WebCore::SocketStreamHandle::didReceiveData): Deleted.
(WebCore::SocketStreamHandle::didOpenSocket): Deleted.
(WebCore::SocketStreamHandle::createCopy): Deleted.

  • platform/network/soup/SocketStreamHandle.h: Removed.
  • platform/network/soup/SocketStreamHandleImpl.h: Copied from Source/WebCore/platform/network/soup/SocketStreamHandle.h.
  • platform/network/soup/SocketStreamHandleImplSoup.cpp: Copied from Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp.

(WebCore::SocketStreamHandleImpl::create):
(WebCore::SocketStreamHandleImpl::SocketStreamHandleImpl):
(WebCore::SocketStreamHandleImpl::~SocketStreamHandleImpl):
(WebCore::SocketStreamHandleImpl::connected):
(WebCore::SocketStreamHandleImpl::connectedCallback):
(WebCore::SocketStreamHandleImpl::readBytes):
(WebCore::SocketStreamHandleImpl::readReadyCallback):
(WebCore::SocketStreamHandleImpl::didFail):
(WebCore::SocketStreamHandleImpl::writeReady):
(WebCore::SocketStreamHandleImpl::platformSend):
(WebCore::SocketStreamHandleImpl::platformClose):
(WebCore::SocketStreamHandleImpl::beginWaitingForSocketWritability):
(WebCore::SocketStreamHandleImpl::stopWaitingForSocketWritability):
(WebCore::SocketStreamHandleImpl::writeReadyCallback):
(WebCore::SocketStreamHandle::create): Deleted.
(WebCore::SocketStreamHandle::SocketStreamHandle): Deleted.
(WebCore::SocketStreamHandle::~SocketStreamHandle): Deleted.
(WebCore::SocketStreamHandle::connected): Deleted.
(WebCore::SocketStreamHandle::connectedCallback): Deleted.
(WebCore::SocketStreamHandle::readBytes): Deleted.
(WebCore::SocketStreamHandle::readReadyCallback): Deleted.
(WebCore::SocketStreamHandle::didFail): Deleted.
(WebCore::SocketStreamHandle::writeReady): Deleted.
(WebCore::SocketStreamHandle::platformSend): Deleted.
(WebCore::SocketStreamHandle::platformClose): Deleted.
(WebCore::SocketStreamHandle::beginWaitingForSocketWritability): Deleted.
(WebCore::SocketStreamHandle::stopWaitingForSocketWritability): Deleted.
(WebCore::SocketStreamHandle::writeReadyCallback): Deleted.

  • platform/network/soup/SocketStreamHandleSoup.cpp: Removed.

Source/WebKit2:

  • WebProcess/Network/WebSocketProvider.cpp:

(WebKit::WebSocketProvider::createSocketStreamHandle):

2:11 PM Changeset in webkit [204482] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Another build fix.

  • WebKit.exp:
2:08 PM Changeset in webkit [204481] by jiewen_tan@apple.com
  • 22 edits
    2 copies
    17 adds in trunk

Expose crypto.getRandomValues to Web Workers
https://bugs.webkit.org/show_bug.cgi?id=104851
<rdar://problem/27285714>

Reviewed by Darin Adler.

Source/WebCore:

Tests: crypto/webkitSubtle/disallowed-in-worker.html

crypto/workers/crypto-gc-worker.html
crypto/workers/crypto-random-values-limits-worker.html
crypto/workers/crypto-random-values-types-worker.html
crypto/workers/crypto-random-values-worker.html

Expose both crypto and crypto.getRandomValues to Web Workers. However, webkitSubtle is
disabled in Web Workers. This change also refactors a bit on IDLs related to Crypto
interface.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:

Introduce GlobalCrypto Interface which is used to repalace the partial IDL in both
DOMWindow and WorkerGlobalScope with sub-implememtations.

  • bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::visitAdditionalChildren):

  • bindings/js/JSWorkerGlobalScopeCustom.cpp:

(WebCore::JSWorkerGlobalScope::visitAdditionalChildren):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:
  • dom/Document.idl:

Add support of GenerateIsReachable=ImplScriptExecutionContext, which allow registered
JS Objects to live as long as ScriptExecutionContext lives, i.e. Document and
WorkerGlobalScope.

  • page/Crypto.cpp:

(WebCore::Crypto::Crypto):
(WebCore::Crypto::webkitSubtle):
(WebCore::Crypto::document): Deleted.

  • page/Crypto.h:

(WebCore::Crypto::create):

  • page/Crypto.idl:

Change the opaque root of Crypto to ScriptExecutionContext such that it perserves
the same live time in both Window and Web Worker. And disable WebKitSubtle in Web
Workers.

  • page/DOMWindow.idl:
  • page/GlobalCrypto.idl: Added.

Replace partial IDL to sub-implementation of crypto attribute.

  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::crypto):

  • workers/WorkerGlobalScope.h:
  • workers/WorkerGlobalScope.idl:

Introduce crypto attribute to Web Workers.

LayoutTests:

  • crypto/crypto-random-values-limits.html:
  • crypto/crypto-random-values-types.html:
  • crypto/crypto-random-values.html:
  • crypto/webkitSubtle/disallowed-in-worker-expected.txt: Added.
  • crypto/webkitSubtle/disallowed-in-worker.html: Added.
  • crypto/webkitSubtle/resources/disallowed-in-worker.js: Added.
  • crypto/workers/crypto-gc-worker-expected.txt: Added.
  • crypto/workers/crypto-gc-worker.html: Added.
  • crypto/workers/crypto-random-values-limits-worker-expected.txt: Added.
  • crypto/workers/crypto-random-values-limits-worker.html: Added.
  • crypto/workers/crypto-random-values-types-worker-expected.txt: Added.
  • crypto/workers/crypto-random-values-types-worker.html: Added.
  • crypto/workers/crypto-random-values-worker-expected.txt: Added.
  • crypto/workers/crypto-random-values-worker.html: Added.
  • crypto/workers/resources/crypto-gc-worker.js: Added.

(startTest):
(continueTest):
(finishTest):

  • crypto/workers/resources/crypto-random-limits-worker.js: Added.

(catch):

  • crypto/workers/resources/crypto-random-values-types-worker.js: Copied from LayoutTests/crypto/crypto-random-values-types.html.

(checkIntegerTypes):
(checkNonIntegerTypes):

  • crypto/workers/resources/crypto-random-values-worker.js: Copied from LayoutTests/crypto/crypto-random-values.html.

(catch):

  • js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
2:04 PM Changeset in webkit [204480] by commit-queue@webkit.org
  • 6 edits in trunk/Source/JavaScriptCore

[JSC] B3 Neg opcode should support float
https://bugs.webkit.org/show_bug.cgi?id=160795

Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-08-15
Reviewed by Geoffrey Garen.

This is required to implement WASM f32.neg opcode.

  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::negateFloat):

  • b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::lower):

  • b3/B3ReduceDoubleToFloat.cpp:
  • b3/air/AirOpcode.opcodes:
  • b3/testb3.cpp:

(JSC::B3::testNegDouble):
(JSC::B3::testNegFloat):
(JSC::B3::testNegFloatWithUselessDoubleConversion):
(JSC::B3::run):

1:55 PM Changeset in webkit [204479] by commit-queue@webkit.org
  • 96 edits in trunk/Source

Use #pragma once in inspector headers
https://bugs.webkit.org/show_bug.cgi?id=160861

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-15
Reviewed by Mark Lam.

  • inspector/*.h:
1:51 PM Changeset in webkit [204478] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Fix build.

  • Configurations/WebKitLegacy.xcconfig:
  • WebKit.mac.exp:
1:50 PM Changeset in webkit [204477] by Simon Fraser
  • 13 edits in trunk/Tools

Allow a port to run tests with a custom device setup
https://bugs.webkit.org/show_bug.cgi?id=160833

Reviewed by Daniel Bates.

These changes allow the IOSSimulator port to run tests in iPad mode.

This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
in this case 'ipad'. When specified, any test in a directory with a suffix that matches
a custom device will be collected into a set, and run in that device's environment after
the other tests have run.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._custom_device_for_test): If the test contains a directory matching a
custom device suffix, return that custom device.
(Manager._set_up_run): Push the custom device class, if any, into options so
that the Worker can get to it.
(Manager.run): Go through the list of tests, and break it down into device-generic
tests, and tests for each device class. _run_test_subset is then called for
each collection of tests, and the results merged.
(Manager._run_test_subset): Some lines unwrapped.
(Manager._end_test_run):
(Manager._run_tests):

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner.init): Unwrapped a line.

  • Scripts/webkitpy/layout_tests/models/test_run_results.py:

(TestRunResults.merge): Add this function to merge TestRunResults

  • Scripts/webkitpy/layout_tests/views/printing.py:

(Printer.print_workers_and_shards): Print the custom device, if any.

  • Scripts/webkitpy/port/base.py:

(Port): Base port has empty array of custom devices.
(Port.setup_test_run): Add device_class argument.

  • Scripts/webkitpy/port/driver.py:

(DriverInput.repr):
(Driver.check_driver.implementation):

  • Scripts/webkitpy/port/efl.py:

(EflPort.setup_test_run):

  • Scripts/webkitpy/port/gtk.py:

(GtkPort.setup_test_run):

  • Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
(IOSSimulatorPort.init):
(IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
based on the custom device class.
(IOSSimulatorPort._set_device_class):
(IOSSimulatorPort._create_simulators): Factor some code into this function.
(IOSSimulatorPort.setup_test_run):
(IOSSimulatorPort.testing_device):
(IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
seemed wrong for this function. That was moved to setup_test_run().
(IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
but this happened too early, before we knew which kind of devices to create. Devices
are now created in setup_test_run().

  • Scripts/webkitpy/port/win.py:

(WinPort.setup_test_run):

1:45 PM Changeset in webkit [204476] by andersca@apple.com
  • 3 edits
    1 delete in trunk/Source/WebKit

Remove OldWebAssertions.c
https://bugs.webkit.org/show_bug.cgi?id=160862

Reviewed by Dan Bernstein.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

These functions were used by an old version of iWeb. The latest version of iWeb no longer uses them.

  • Misc/OldWebAssertions.c: Removed.

(WebReportAssertionFailure): Deleted.
(WebReportError): Deleted.

1:40 PM Changeset in webkit [204475] by keith_miller@apple.com
  • 8 edits
    27545 adds
    1 delete in branches/safari-602.1.50.0-branch

Merge r203972.

2016-08-01 Keith Miller <keith_miller@apple.com>

We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
https://bugs.webkit.org/show_bug.cgi?id=160372

Rubber stamped by Geoffrey Garen.

This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
a new top level directory, JSTests. Having the tests in the Source directory
was both confusing and inconvenient for people that just want to checkout the
source code of WebKit. Since there is no other obvious place to put all the
JavaScript tests a new top level directory seemed the most sensible.

  • JSTests/: Copied from Source/JavaScriptCore/tests.
  • Source/JavaScriptCore/tests/: Deleted.
  • Scripts/import-test262-tests:
  • Scripts/run-javascriptcore-tests:
  • Scripts/update-javascriptcore-test-res:
12:16 PM Changeset in webkit [204474] by andersca@apple.com
  • 4 edits
    2 deletes in trunk/Source/WebKit

Remove WebKeyGenerator
https://bugs.webkit.org/show_bug.cgi?id=160854

Reviewed by Dan Bernstein.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

This SPI class is no longer used by Safari.

  • WebCoreSupport/WebKeyGenerator.h: Removed.
  • WebCoreSupport/WebKeyGenerator.mm: Removed.

(+[WebKeyGenerator sharedGenerator]): Deleted.
(toWebCertificateParseResult): Deleted.
(-[WebKeyGenerator addCertificatesToKeychainFromData:]): Deleted.

  • WebView/WebFrameView.mm:
12:11 PM Changeset in webkit [204473] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix iOS build.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::webGLPolicyForURL):
(WebKit::WebPage::resolveWebGLPolicyForURL):

11:59 AM Changeset in webkit [204472] by Keith Rollin
  • 23 edits in trunk/Source

Rename LOG_ALWAYS
https://bugs.webkit.org/show_bug.cgi?id=160768

Rename LOG_ALWAYS and friends, given that the first parameter to it is
a boolean expression that determines whether or not logging should be
performed.

Reviewed by Chris Dumez.

Source/WebCore:

No new tests. No new functionality is added. Only some macro names
have been changed.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::prepareForLoadStart):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):

  • platform/MemoryPressureHandler.cpp:

(WebCore::MemoryPressureHandler::ReliefLogger::logMemoryUsageChange):

  • platform/graphics/cocoa/IOSurface.mm:

(WebCore::IOSurface::IOSurface):

Source/WebKit2:

  • NetworkProcess/Downloads/Download.cpp:

(WebKit::Download::didReceiveResponse):
(WebKit::Download::didReceiveData):
(WebKit::Download::didFinish):
(WebKit::Download::didFail):
(WebKit::Download::didCancel):

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::prepareToSuspend):
(WebKit::NetworkProcess::cancelPrepareToSuspend):
(WebKit::NetworkProcess::processDidResume):

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::startNetworkLoad):
(WebKit::NetworkResourceLoader::didFinishLoading):
(WebKit::NetworkResourceLoader::didFailLoading):
(WebKit::NetworkResourceLoader::continueWillSendRequest):

  • Platform/IPC/Connection.cpp:

(IPC::Connection::waitForSyncReply):

  • Shared/ChildProcess.cpp:

(WebKit::didCloseOnConnectionWorkQueue):

  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::didChangeIsLoading):

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::fetchWebsiteData):
(WebKit::NetworkProcessProxy::deleteWebsiteData):
(WebKit::NetworkProcessProxy::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcessProxy::setIsHoldingLockedFiles):

  • UIProcess/ProcessThrottler.cpp:

(WebKit::ProcessThrottler::updateAssertionNow):
(WebKit::ProcessThrottler::updateAssertion):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::updateActivityToken):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::fetchWebsiteData):
(WebKit::WebProcessProxy::deleteWebsiteData):
(WebKit::WebProcessProxy::deleteWebsiteDataForOrigins):
(WebKit::WebProcessProxy::didSetAssertionState):
(WebKit::WebProcessProxy::setIsHoldingLockedFiles):

  • UIProcess/ios/ProcessAssertionIOS.mm:

(-[WKProcessAssertionBackgroundTaskManager _updateBackgroundTask]):
(WebKit::ProcessAssertion::ProcessAssertion):

  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoad):

  • WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::willSendRequest):
(WebKit::WebResourceLoader::didReceiveResponse):
(WebKit::WebResourceLoader::didReceiveData):
(WebKit::WebResourceLoader::didFinishResourceLoad):
(WebKit::WebResourceLoader::didFailResourceLoad):
(WebKit::WebResourceLoader::didReceiveResource):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::layerVolatilityTimerFired):
(WebKit::WebPage::markLayersVolatile):
(WebKit::WebPage::cancelMarkLayersVolatile):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::actualPrepareToSuspend):
(WebKit::WebProcess::processWillSuspendImminently):
(WebKit::WebProcess::prepareToSuspend):
(WebKit::WebProcess::cancelPrepareToSuspend):
(WebKit::WebProcess::markAllLayersVolatile):
(WebKit::WebProcess::processDidResume):

Source/WTF:

  • wtf/Assertions.h:
11:57 AM Changeset in webkit [204471] by dbates@webkit.org
  • 12 edits
    24 adds in trunk

Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
private frameworks and libraries
https://bugs.webkit.org/show_bug.cgi?id=155931
<rdar://problem/25807989>

Reviewed by Dan Bernstein.

Source/JavaScriptCore:

Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
where X is the major version of the active iOS SDK.

  • Configurations/Base.xcconfig:

Source/WebCore:

Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
where X is the major version of the active iOS SDK.

  • Configurations/WebCore.xcconfig:

Source/WebKit/mac:

Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
where X is the major version of the active iOS SDK.

  • Configurations/WebKitLegacy.xcconfig:

Source/WebKit2:

Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
where X is the major version of the active iOS SDK.

  • Configurations/BaseTarget.xcconfig:

Tools:

Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
where X is the major version of the active iOS SDK.

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/Base.xcconfig:

WebKitLibraries:

Add text-based stubs for private frameworks in iOS 9 and iOS 10 beta.

  • WebKitPrivateFrameworkStubs: Added.
  • WebKitPrivateFrameworkStubs/iOS: Added.
  • WebKitPrivateFrameworkStubs/iOS/10: Added.
  • WebKitPrivateFrameworkStubs/iOS/10/AppSupport.framework: Added.
  • WebKitPrivateFrameworkStubs/iOS/10/AppSupport.framework/AppSupport.tbd: Added.
  • WebKitPrivateFrameworkStubs/iOS/10/AssertionServices.framework: Added.
  • WebKitPrivateFrameworkStubs/iOS/10/AssertionServices.framework/AssertionServices.tbd: Added.
  • WebKitPrivateFrameworkStubs/iOS/10/CorePDF.framework: Added.
  • WebKitPrivateFrameworkStubs/iOS/10/CorePDF.framework/CorePDF.tbd: Added.
  • WebKitPrivateFrameworkStubs/iOS/10/GraphicsServices.framework: Added.
  • WebKitPrivateFrameworkStubs/iOS/10/GraphicsServices.framework/GraphicsServices.tbd: Added.
  • WebKitPrivateFrameworkStubs/iOS/10/IOSurface.framework: Added.
  • WebKitPrivateFrameworkStubs/iOS/10/IOSurface.framework/IOSurface.tbd: Added.
  • WebKitPrivateFrameworkStubs/iOS/9: Added.
  • WebKitPrivateFrameworkStubs/iOS/9/AppSupport.framework: Added.
  • WebKitPrivateFrameworkStubs/iOS/9/AppSupport.framework/AppSupport.tbd: Added.
  • WebKitPrivateFrameworkStubs/iOS/9/AssertionServices.framework: Added.
  • WebKitPrivateFrameworkStubs/iOS/9/AssertionServices.framework/AssertionServices.tbd: Added.
  • WebKitPrivateFrameworkStubs/iOS/9/CorePDF.framework: Added.
  • WebKitPrivateFrameworkStubs/iOS/9/CorePDF.framework/CorePDF.tbd: Added.
  • WebKitPrivateFrameworkStubs/iOS/9/GraphicsServices.framework: Added.
  • WebKitPrivateFrameworkStubs/iOS/9/GraphicsServices.framework/GraphicsServices.tbd: Added.
  • WebKitPrivateFrameworkStubs/iOS/9/IOSurface.framework: Added.
  • WebKitPrivateFrameworkStubs/iOS/9/IOSurface.framework/IOSurface.tbd: Added.
11:48 AM Changeset in webkit [204470] by Joseph Pecoraro
  • 27 edits in trunk/Source/JavaScriptCore

Reduce includes of Debugger.h
https://bugs.webkit.org/show_bug.cgi?id=160827

Reviewed by Mark Lam.

  • API/JSTypedArray.cpp:
  • bytecode/UnlinkedCodeBlock.h:
  • bytecode/UnlinkedFunctionExecutable.cpp:
  • bytecode/UnlinkedFunctionExecutable.h:
  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:
  • dfg/DFGPlan.cpp:
  • dfg/DFGSpeculativeJIT32_64.cpp:
  • dfg/DFGSpeculativeJIT64.cpp:
  • ftl/FTLJITCode.h:
  • inspector/ScriptCallStackFactory.cpp:
  • inspector/agents/InspectorDebuggerAgent.h:
  • jit/JITOpcodes.cpp:
  • jit/JITOpcodes32_64.cpp:
  • jit/JITOperations.cpp:
  • llint/LLIntOffsetsExtractor.cpp:
  • parser/Nodes.cpp:
  • parser/Parser.cpp:
  • parser/Parser.h:
  • runtime/Completion.cpp:
  • runtime/Executable.cpp:
  • runtime/Executable.h:
  • runtime/FunctionConstructor.cpp:
  • runtime/SamplingProfiler.cpp:
  • runtime/SamplingProfiler.h:
  • runtime/VMEntryScope.cpp:
11:16 AM Changeset in webkit [204469] by Simon Fraser
  • 17 edits in trunk

Add a setting and preferences to enable visual viewport mode
https://bugs.webkit.org/show_bug.cgi?id=160843

Reviewed by Sam Weinig.
Source/WebCore:

Add a visualViewportEnabled setting, in the start of a group at the bottom
of the file which is intended as the future home for all runtime-enabled
settings.

  • page/Settings.in:

Source/WebKit/mac:

Hook up the visualViewportEnabled setting for WebKit1.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences visualViewportEnabled]):
(-[WebPreferences setVisualViewportEnabled:]):

  • WebView/WebPreferencesPrivate.h:

Source/WebKit2:

Hook up the visualViewportEnabled setting for WebKit2.

  • Shared/WebPreferencesDefinitions.h:
  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _visualViewportEnabled]):
(-[WKPreferences _setVisualViewportEnabled:]):

  • UIProcess/API/Cocoa/WKPreferencesPrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.

  • MiniBrowser/mac/SettingsController.h:
  • MiniBrowser/mac/SettingsController.m:

(-[SettingsController _populateMenu]):
(-[SettingsController validateMenuItem:]):
(-[SettingsController visualViewportEnabled]):
(-[SettingsController toggleVisualViewportEnabled:]):

  • MiniBrowser/mac/WK1BrowserWindowController.m:

(-[WK1BrowserWindowController didChangeSettings]):

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController didChangeSettings]):

10:53 AM Changeset in webkit [204468] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Fix WinCairo build after r204466.

  • platform/network/curl/SocketStreamHandleCurl.cpp:
10:37 AM Changeset in webkit [204467] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Fix GTK build after r204466.

  • platform/gtk/DataObjectGtk.h:
10:21 AM Changeset in webkit [204466] by achristensen@apple.com
  • 519 edits in trunk/Source

Remove unused includes of wtf headers
https://bugs.webkit.org/show_bug.cgi?id=160839

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-15
Reviewed by Alex Christensen.

Source/JavaScriptCore:

  • Lots of files.

Source/WebCore:

  • Lots of files.

Source/WebKit:

  • Storage/StorageSyncManager.h:
  • Storage/StorageThread.cpp:
  • Storage/StorageThread.h:
  • Storage/WebDatabaseProvider.cpp:

Source/WebKit/cf:

  • WebCoreSupport/WebInspectorClientCF.cpp:

Source/WebKit/ios:

  • Misc/WebGeolocationCoreLocationProvider.h:
  • WebView/WebPDFViewIOS.mm:
  • WebView/WebPlainWhiteView.mm:

Source/WebKit/mac:

  • History/BinaryPropertyList.cpp:
  • History/WebBackForwardList.mm:
  • History/WebHistoryItemInternal.h:
  • Misc/WebNSFileManagerExtras.mm:
  • Plugins/Hosted/NetscapePluginHostProxy.h:
  • WebCoreSupport/WebPlatformStrategies.mm:
  • WebCoreSupport/WebSelectionServiceController.mm:
  • WebCoreSupport/WebUserMediaClient.h:

Source/WebKit/win:

  • WebFrame.h:

Source/WebKit2:

  • Lots of files.

Source/WTF:

  • wtf/BackwardsGraph.h:
  • wtf/DataLog.cpp:
  • wtf/WorkQueue.cpp:
  • wtf/text/StringImpl.cpp:
  • wtf/unicode/icu/CollatorICU.cpp:
10:15 AM Changeset in webkit [204465] by achristensen@apple.com
  • 4 edits in trunk/Source/WebCore

Remove unused WebSocketChannel::willOpenSocketStream
https://bugs.webkit.org/show_bug.cgi?id=160851

Reviewed by Daniel Bates.

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::willOpenSocketStream): Deleted.

  • Modules/websockets/WebSocketChannel.h:
  • platform/network/SocketStreamHandleClient.h:

(WebCore::SocketStreamHandleClient::willOpenSocketStream): Deleted.

10:14 AM Changeset in webkit [204464] by Ryan Haddad
  • 2 edits in trunk/JSTests

Skip failing test mozilla/ecma/LexicalConventions/7.7.3.js
https://bugs.webkit.org/show_bug.cgi?id=160662

Unreviewed test gardening.

  • mozilla/ecma/LexicalConventions/7.7.3.js:
9:53 AM Changeset in webkit [204463] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Rebaseline js/dom/global-constructors-attributes.html for mac-wk1, mark as failing on Yosemite.

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
  • platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
9:43 AM Changeset in webkit [204462] by andersca@apple.com
  • 9 edits
    3 copies
    4 adds in trunk/Source

Move the plug-in and WebGL blacklist code to WebCore
https://bugs.webkit.org/show_bug.cgi?id=160831

Reviewed by Sam Weinig.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • platform/mac/BlacklistUpdater.h: Added.

(WebCore::BlacklistUpdater::queue):
(WebCore::BlacklistUpdater::pluginBlacklist):
(WebCore::BlacklistUpdater::webGLBlacklist):

  • platform/mac/BlacklistUpdater.mm: Added.

(WebCore::BlacklistUpdater::readBlacklistData):
(WebCore::BlacklistUpdater::reloadIfNecessary):
(WebCore::BlacklistUpdater::initializeQueue):

  • platform/mac/PluginBlacklist.h: Added.
  • platform/mac/PluginBlacklist.mm: Added.

(WebCore::PluginBlacklist::loadPolicyForPluginVersion):
(WebCore::PluginBlacklist::isPluginUpdateAvailable):
(WebCore::PluginBlacklist::create):
(WebCore::PluginBlacklist::~PluginBlacklist):
(WebCore::PluginBlacklist::splitOSVersion):
(WebCore::PluginBlacklist::loadPolicyForPlugin):
(WebCore::PluginBlacklist::isUpdateAvailable):
(WebCore::PluginBlacklist::PluginBlacklist):

  • platform/mac/WebGLBlacklist.h: Added.
  • platform/mac/WebGLBlacklist.mm: Added.

(WebCore::OSBuildInfo::OSBuildInfo):
(WebCore::OSBuildInfo::operator==):
(WebCore::OSBuildInfo::operator>):
(WebCore::OSBuildInfo::operator<=):
(WebCore::OSBuildInfo::operator<):
(WebCore::buildInfoFromOSBuildString):
(WebCore::WebGLBlacklist::shouldBlockWebGL):
(WebCore::WebGLBlacklist::shouldSuggestBlockingWebGL):
(WebCore::matchesGPU):
(WebCore::gpuMaskFromString):
(WebCore::matchesBuildInfo):
(WebCore::WebGLBlacklist::create):
(WebCore::WebGLBlacklist::shouldBlock):
(WebCore::WebGLBlacklist::shouldSuggestBlocking):
(WebCore::WebGLBlacklist::WebGLBlacklist):
(WebCore::WebGLBlacklist::~WebGLBlacklist):

  • platform/spi/cf/CFUtilitiesSPI.h: Added.

Source/WebKit/mac:

Adopt the plug-in and WebGL blacklist code from WebCore instead of using the code from WebKitSystemInterface.

  • WebCoreSupport/WebFrameLoaderClient.mm:

(shouldBlockPlugin):
(WebFrameLoaderClient::createPlugin):
(WebFrameLoaderClient::createJavaAppletWidget):
(shouldBlockWebGL):
(WebFrameLoaderClient::webGLPolicyForURL):
(WebFrameLoaderClient::resolveWebGLPolicyForURL):

Source/WebKit2:

Adopt the plug-in and WebGL blacklist code from WebCore instead of using the code from WebKitSystemInterface.

  • Shared/Plugins/Netscape/mac/PluginInformationMac.mm:

(WebKit::getPlatformPluginModuleInformation):

  • Shared/Plugins/PluginModuleInfo.h:
  • UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKContextIsPlugInUpdateAvailable):
(WKContextShouldBlockWebGL):
(WKContextShouldSuggestBlockWebGL):

  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::shouldBlockPlugin):
(WebKit::PluginInfoStore::defaultLoadPolicyForPlugin):
(WebKit::WKPlugInModuleLoadPolicyToPluginModuleLoadPolicy): Deleted.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::findPlugin):

9:10 AM Changeset in webkit [204461] by Brent Fulgham
  • 2 edits
    1 add in trunk/Source/WebKit2

Add Sandbox profile for Enterprise support version of Flash Player
https://bugs.webkit.org/show_bug.cgi?id=160753
<rdar://problem/17614483>

Reviewed by Andy Estes.

  • Resources/PlugInSandboxProfiles/com.macromedia.Flash Player ESR.plugin.sb: Added.
  • WebKit2.xcodeproj/project.pbxproj: Add reference to new sandbox profile.
2:56 AM Changeset in webkit [204460] by Konstantin Tokarev
  • 2 edits in trunk/Tools

Allow using make-dist with non-GTK ports
https://bugs.webkit.org/show_bug.cgi?id=160842

Reviewed by Michael Catanzaro.

This patch adds support for setting base name of tarball and argument
passed to cmake's -DPORT= via command line arguments.

  • gtk/make-dist.py:

(Distcheck.configure):
(Distcheck.check):
(get_tarball_root_and_output_filename_from_arguments):

Aug 14, 2016:

5:48 PM Changeset in webkit [204459] by Chris Dumez
  • 13 edits
    1 delete in trunk/Source/WebCore

Align the event listener firing code with the latest DOM Specification and simplify it
https://bugs.webkit.org/show_bug.cgi?id=160828

Reviewed by Darin Adler.

Align the event listener firing code with the latest DOM specification:

The following changes were made:

  1. RegisteredEventListener (equivalent to "event listener" in the spec) is now RefCounted
  2. RegisteredEventListener now has a wasRemoved flag as in specification.
  3. fireEventListeners() is now iterating over a copy of the event listeners, as in the specification. We rely on the wasRemoved removed flag to avoid executing event listeners that were removed while we iterate.

Previously, the code was modifying the event listeners vector we were
iterating on. Doing so safely lead to complicated and error prone code.
The new code is much simpler and easier to reason about.

This change seems to be perf-neutral on Speedometer.

No new tests, no web-exposed behavior change.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCommandLineAPIHostCustom.cpp:

(WebCore::getJSListenerFunctions):

  • dom/DOMAllInOne.cpp:
  • dom/EventListenerMap.cpp:

(WebCore::EventListenerMap::assertNoActiveIterators):
(WebCore::EventListenerMap::containsCapturing):
(WebCore::EventListenerMap::containsActive):
(WebCore::findListener):
(WebCore::EventListenerMap::add):
(WebCore::removeListenerFromVector):
(WebCore::EventListenerMap::remove):
(WebCore::EventListenerMap::find):
(WebCore::removeFirstListenerCreatedFromMarkup):
(WebCore::copyListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerMap::copyEventListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerIterator::nextListener):
(WebCore::EventListenerMap::clear): Deleted.

  • dom/EventListenerMap.h:

(WebCore::EventListenerMap::contains):
(WebCore::EventListenerMap::assertNoActiveIterators):

  • dom/EventTarget.cpp:

(WebCore::EventTarget::removeEventListener):
(WebCore::EventTarget::getAttributeEventListener):
(WebCore::FiringEventListenersScope::FiringEventListenersScope):
(WebCore::FiringEventListenersScope::~FiringEventListenersScope):
(WebCore::EventTarget::fireEventListeners):
(WebCore::EventTarget::setAttributeEventListener): Deleted.
(WebCore::EventTarget::hasActiveEventListeners): Deleted.
(WebCore::EventTarget::dispatchEventForBindings): Deleted.
(WebCore::EventTarget::getEventListeners): Deleted.

  • dom/EventTarget.h:

(WebCore::EventTarget::isFiringEventListeners):

  • dom/RegisteredEventListener.cpp: Removed.
  • dom/RegisteredEventListener.h:

(WebCore::RegisteredEventListener::Options::Options):
(WebCore::RegisteredEventListener::create):
(WebCore::RegisteredEventListener::listener):
(WebCore::RegisteredEventListener::useCapture):
(WebCore::RegisteredEventListener::isPassive):
(WebCore::RegisteredEventListener::isOnce):
(WebCore::RegisteredEventListener::wasRemoved):
(WebCore::RegisteredEventListener::markAsRemoved):
(WebCore::RegisteredEventListener::RegisteredEventListener):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::getEventListenersForNode):
(WebCore::InspectorDOMAgent::getEventListeners):
(WebCore::InspectorDOMAgent::buildObjectForEventListener):

  • inspector/InspectorDOMAgent.h:

(WebCore::EventListenerInfo::EventListenerInfo):

  • svg/SVGElement.cpp:

(WebCore::hasLoadListener):

5:02 PM Changeset in webkit [204458] by mitz@apple.com
  • 6 edits
    1 delete in trunk/Source/WebKit2

[Cocoa] Remove deprecated _WKFormDelegate
https://bugs.webkit.org/show_bug.cgi?id=160848

Reviewed by Anders Carlsson.

  • Shared/API/Cocoa/WebKitPrivate.h: Removed #import.
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _formDelegate]): Moved into WKBinaryCompatibilityIOS10 cateogry implementation,

chaged type to id <_WKInputDelegate>.

(-[WKWebView _setFormDelegate:]): Ditto.

  • UIProcess/API/Cocoa/WKWebViewPrivate.h: Removed property declaration.
  • UIProcess/API/Cocoa/_WKFormDelegate.h: Removed.
  • WebKit2.xcodeproj/project.pbxproj: Removed reference to header.
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInFormDelegatePrivate.h: Fixed comment.
4:04 PM Changeset in webkit [204457] by gskachkov@gmail.com
  • 4 edits in trunk/JSTests

[2016] Set correct status for test262 after implementation of Object.values&Object.entries
https://bugs.webkit.org/show_bug.cgi?id=160844

Reviewed by Saam Barati.

Patch contains fix statuses of specs in the test262 test collection after implementation of
Object.values and Object.entries functions. Also patch contains small fixes in tests of the
tests for Object.values/entries functions.

  • stress/object-entries.js:

(Object.getOwnPropertyDescriptor):

  • stress/object-values.js:

(Object.getOwnPropertyDescriptor):

  • test262.yaml:
3:42 PM Changeset in webkit [204456] by dbates@webkit.org
  • 12 edits in trunk/Source

Fix compiler errors when building iOS WebKit using the iOS 10 beta SDK
https://bugs.webkit.org/show_bug.cgi?id=160725

Reviewed by Sam Weinig.

Source/WebCore:

  • platform/cocoa/ThemeCocoa.mm: Unconditionally include header dlfcn.h as it

exists in both the public iOS 9.3 SDK and iOS 10 beta SDK.

  • platform/spi/cocoa/CoreTextSPI.h: Add SPI declarations for constants that were

used in r204107.

  • platform/spi/cocoa/PassKitSPI.h: Remove unnecessary #import statements when

building with the Apple Internal SDK. Include header PassKit/PassKit.h when
building for iOS.

  • platform/spi/cocoa/QuartzCoreSPI.h: No need to define CLayer.contentsFormat

when building with the iOS 10 beta SDK as it is now part of the public API.

Source/WebKit/mac:

OSAtomicCompareAndSwap32() has been deprecated as of the iOS 10 beta SDK. For now,
silence the complier warning.

  • WebView/WebView.mm:

(-[WebView _dispatchTileDidDraw:]):

Source/WebKit2:

  • Platform/spi/ios/UIKitSPI.h: Add SPI for UITextInputSuggestionDelegate.
  • UIProcess/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm: Remove unnecessary include of PKPaymentMerchantSession.h.

Source/WTF:

For now, disable OS_LOG when building with the iOS 10 beta SDK until
we have the fix for <rdar://problem/27758343>.

  • wtf/Platform.h:
3:38 PM Changeset in webkit [204455] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Dereferenced NULL pointer in StyleResolver
https://bugs.webkit.org/show_bug.cgi?id=160823

Patch by Jonathan Bedard <Jonathan Bedard> on 2016-08-14
Reviewed by Darin Adler.

No behavior changed, new tests unneeded.

This change was initiated by a NULL pointer dereference to provide this unused argument.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::CascadedProperties::addStyleProperties): Removed unused function argument.
(WebCore::StyleResolver::CascadedProperties::addMatch): Ditto.

  • css/StyleResolver.h: Ditto.
2:45 PM Changeset in webkit [204454] by mitz@apple.com
  • 5 edits
    1 delete in trunk/Source/WebKit2

[Cocoa] Remove deprecated _WKVisitedLinkProvider declarations that aren’t needed
https://bugs.webkit.org/show_bug.cgi?id=160846

Reviewed by Darin Adler.

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration _visitedLinkProvider]): Moved into WKBinaryCompatibilityIOS10

cateogry implementation, changed type to _WKVisitedLinkStore.

(-[WKWebViewConfiguration _setVisitedLinkProvider:]): Ditto.

  • UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h: Removed property declaration.
  • UIProcess/API/Cocoa/_WKVisitedLinkProvider.h: Removed.
  • UIProcess/API/Cocoa/_WKVisitedLinkProvider.mm: Moved declaration in here.
  • WebKit2.xcodeproj/project.pbxproj: Updated for header removal.
11:29 AM Changeset in webkit [204453] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Fix GTK Debug bots after r204400
https://bugs.webkit.org/show_bug.cgi?id=160818

Reviewed by Carlos Garcia Campos.

Because the GTK EWS bot doesn't run tests, I missed this.

No new tests because there is no behavior change.

  • platform/graphics/harfbuzz/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::selectionRect):

Note: See TracTimeline for information about the timeline view.