⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 21, 2016:

11:02 PM Changeset in webkit [204702] by commit-queue@webkit.org
  • 17 edits in trunk/Source

Use Document& instead of Document* when getting cookies
​https://bugs.webkit.org/show_bug.cgi?id=161011

Patch by Alex Christensen <​achristensen@webkit.org> on 2016-08-21
Reviewed by Darin Adler.

Source/WebCore:

No change in behavior.

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::processBuffer):

  • Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::clientHandshakeMessage):
(WebCore::WebSocketHandshake::clientHandshakeRequest):

  • dom/Document.cpp:

(WebCore::Document::cookie):
(WebCore::Document::setCookie):
(WebCore::Document::referrer):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::getCookies):
(WebCore::InspectorPageAgent::deleteCookie):
(WebCore::InspectorPageAgent::getResourceTree):

  • loader/CookieJar.cpp:

(WebCore::networkingContext):
(WebCore::storageSession):
(WebCore::cookies):
(WebCore::setCookies):
(WebCore::cookiesEnabled):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::addCookie):

  • loader/CookieJar.h:
  • page/Navigator.cpp:

(WebCore::Navigator::cookieEnabled):
(WebCore::Navigator::javaEnabled):

Source/WebKit/mac:

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::getCookies):
(WebKit::NetscapePluginInstanceProxy::setCookies):

  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView getVariable:forURL:value:length:]):
(-[WebNetscapePluginView setVariable:forURL:value:length:]):

Source/WebKit/win:

  • Plugins/PluginView.cpp:

(WebCore::PluginView::getValueForURL):

Source/WebKit2:

  • WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::WebAutomationSessionProxy::getCookiesForFrame):
(WebKit::WebAutomationSessionProxy::deleteCookie):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::cookiesForURL):
(WebKit::PluginView::setCookiesForURL):
(WebKit::PluginView::getAuthenticationInfo):

10:42 PM Changeset in webkit [204701] by commit-queue@webkit.org
  • 4 edits in trunk

URLParser should parse IPv4 addresses
​https://bugs.webkit.org/show_bug.cgi?id=161023

Patch by Alex Christensen <​achristensen@webkit.org> on 2016-08-21
Reviewed by Darin Adler.

Source/WebCore:

Covered by new API tests because URLParser isn't used anywhere in WebCore yet.

  • platform/URLParser.cpp:

(WebCore::URLParser::authorityEndReached):
(WebCore::serializeIPv4):
(WebCore::parseIPv4Number):
(WebCore::pow256):
(WebCore::parseIPv4Host):
(WebCore::parseIPv6Host):
(WebCore::URLParser::hostEndReached):

Tools:

  • TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::TEST_F):
(TestWebKitAPI::checkURLDifferences):
We are already getting differences between the old URL::parse and the new URLParser.
(TestWebKitAPI::shouldFail):

9:04 PM Changeset in webkit [204700] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Remove a few custom bindings
​https://bugs.webkit.org/show_bug.cgi?id=161039

Patch by Sam Weinig <​sam@webkit.org> on 2016-08-21
Reviewed by Darin Adler.

Remove custom bindings for CanvasRenderingContext2D's webkitLineDash attribute and commit function.

  • WebCore.xcodeproj/project.pbxproj:

Sort files.

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:

(WebCore::JSCanvasRenderingContext2D::commit): Deleted.
(WebCore::JSCanvasRenderingContext2D::webkitLineDash): Deleted.
(WebCore::JSCanvasRenderingContext2D::setWebkitLineDash): Deleted.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::webkitLineDashOffset): Deleted.
(WebCore::CanvasRenderingContext2D::setWebkitLineDashOffset): Deleted.

  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasRenderingContext2D.idl:
8:47 PM Changeset in webkit [204699] by Yusuke Suzuki
  • 3 edits
    1 add in trunk

[DFG] Should not fixup AnyIntUse in 32_64
​https://bugs.webkit.org/show_bug.cgi?id=161029

Reviewed by Saam Barati.

JSTests:

  • typeProfiler/int52-dfg.js: Added.

(test):

Source/JavaScriptCore:

DFG fixup phase uses AnyIntUse even in 32bit DFG. This patch removes this incorrect filtering.
If the 32bit DFG see the TypeAnyInt, it should fallback to the NumberUse case.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

1:36 PM Changeset in webkit [204698] by Yusuke Suzuki
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r204697
​https://bugs.webkit.org/show_bug.cgi?id=161029

JSTests:

  • typeProfiler/int52-dfg.js: Removed.

(test): Deleted.

  • typeProfiler/number-filter-dfg.js: Removed.

(test): Deleted.

Source/JavaScriptCore:

32bit is OK. DFGSpeculativeJIT64.cpp shortcut also need some cares.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

12:45 PM Changeset in webkit [204697] by Yusuke Suzuki
  • 3 edits
    2 adds in trunk

[DFG] Should not fixup AnyIntUse in 32_64
​https://bugs.webkit.org/show_bug.cgi?id=161029

Reviewed by Saam Barati.

JSTests:

  • typeProfiler/int52-dfg.js: Added.

(test):

  • typeProfiler/number-filter-dfg.js: Added.

(test):

Source/JavaScriptCore:

DFG fixup phase uses AnyIntUse even in 32bit DFG. This patch removes this incorrect filtering.
If the 32bit DFG see the TypeAnyInt, it should fallback to the NumberUse case.

And this patch also fixes the case that the type set only contains TypeNumber. Previously,
we used NumberUse edge filtering. But it misses AnyInt logging: While the NumberUse filter
passes both TypeAnyInt and TypeNumber, the type set only logged TypeNumber.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

11:13 AM Changeset in webkit [204696] by dbates@webkit.org
  • 1 edit in trunk/Tools/ChangeLog

Fix up title in ChangeLog entry for r204695.

11:08 AM Changeset in webkit [204695] by dbates@webkit.org
  • 3 edits
    1 add in trunk/Tools

prepare-ChangeLog lists modified methods as having been deleted
​https://bugs.webkit.org/show_bug.cgi?id=148437

Reviewed by Dan Bernstein.

  • Scripts/prepare-ChangeLog:

(diffCommand): When using a Subversion checkout, generate a unified diff without any context lines.
This matches our behavior when using a Git checkout. The function overlap logic in generateFunctionListsByRanges()
assumes that its line ranges were from a unified diff without any context lines.
(extractLineRangeAfterChange): A deleted line should be represented with a ("begin line number", "end line number") = ("new starting line number", "new starting line number").
(extractLineRangeBeforeChange): An added line should be represented with a ("begin line number", "end line number") = ("original starting line number", "original starting line number").

  • Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Update expected results

based on changes to extractLineRangeAfterChange() and extractLineRangeBeforeChange().

  • Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added.

(discardOutput): Convenience function invokes the specified function redirecting standard output and standard error
to /dev/null for the duration of the function call.

8:41 AM Changeset in webkit [204694] by commit-queue@webkit.org
  • 2 edits
    11 adds in trunk/LayoutTests

[Mac] Rebase some failing XMLHttpRequest tests
​https://bugs.webkit.org/show_bug.cgi?id=161036

Unreviewed.

Patch by Youenn Fablet <​youenn@apple.com> on 2016-08-21

  • TestExpectations: Unmarking rebased tests as failing.
  • platform/ios-simulator/imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-empty-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-empty-expected.txt.
  • platform/ios-simulator/imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-none-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-none-expected.txt.
  • platform/ios-simulator/imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type-expected.txt.
  • platform/mac/imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-empty-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-empty-expected.txt.
  • platform/mac/imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-none-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-none-expected.txt.
  • platform/mac/imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type-expected.txt.
6:36 AM Changeset in webkit [204693] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

cross-origin requests redirected fail or drop author requested headers
​https://bugs.webkit.org/show_bug.cgi?id=112471

Patch by Youenn Fablet <​youenn@apple.com> on 2016-08-21
Reviewed by Alex Christensen.

Source/WebCore:

Test: http/tests/xmlhttprequest/redirections-and-user-headers.html

Storing original headers in DocumentThreadableLoader.
In case of cross-origin redirection in CORS mode, set the new request headers to the original headers.
Add a special handling to Authorization header that should not be used when it is already removed by the network layer.

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::redirectReceived):
(WebCore::DocumentThreadableLoader::loadRequest):

  • loader/DocumentThreadableLoader.h:

LayoutTests:

  • http/tests/xmlhttprequest/redirections-and-user-headers-expected.txt: Added.
  • http/tests/xmlhttprequest/redirections-and-user-headers.html: Added.
  • http/tests/xmlhttprequest/resources/access-control-preflight-redirect.php: Added.
5:18 AM Changeset in webkit [204692] by commit-queue@webkit.org
  • 10 edits
    1 copy
    1 add in trunk/Source/WebCore

Introduce a MathMLAnnotationElement class for the annotation/annotation-xml elements
​https://bugs.webkit.org/show_bug.cgi?id=160540

Patch by Frederic Wang <​fwang@igalia.com> on 2016-08-21
Reviewed by Darin Adler.

The <annotation> element can only contain text whereas the <annotation-xml> element can
contain some elements as described in the HTML5 RelaxNG schema. For this reason, they have
been implemented in the separate MathMLTextElement and MathMLInlineContainerElement
respectively. However, they are actually closer to each other than to token elements or
presentation containers. In particular they support very different attributes and are
considered by the <semantics> tag. Hence we move their implementations in a new
MathMLAnnotation class.

No new tests, already covered by existing tests.

  • CMakeLists.txt: Add MathMLAnnotationElement.
  • mathml/MathMLAllInOne.cpp: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • mathml/MathMLAnnotationElement.cpp: Added.

(WebCore::MathMLAnnotationElement::MathMLAnnotationElement): ASSERT that this class is only
for annotation and annotation-xml.
(WebCore::MathMLAnnotationElement::create):
(WebCore::MathMLAnnotationElement::createElementRenderer): Move implementation from
MathMLTextElement and MathMLInlineContainerElement.
(WebCore::MathMLAnnotationElement::childShouldCreateRenderer): Move implementation from
MathMLTextElement and MathMLElement.
(WebCore::MathMLAnnotationElement::attributeChanged): Move implementation from MathMLElement.

  • mathml/MathMLAnnotationElement.h: Override isSemanticAnnotation and isPresentationMathML

to return true.

  • mathml/MathMLElement.cpp:

(WebCore::MathMLElement::childShouldCreateRenderer): Move the annotation-xml case into
MathMLAnnotationElement.
(WebCore::MathMLElement::attributeChanged): Deleted. This was only used for semantic
annotations and so the code is moved into MathMLAnnotationElement.

  • mathml/MathMLElement.h:

(WebCore::MathMLElement::isMathMLToken): Return false and let derived class override this.
(WebCore::MathMLElement::isSemanticAnnotation): Ditto.
(WebCore::MathMLElement::updateSelectedChild): Make this public so that is can be used
by MathMLAnnotationElement::attributeChanged.

  • mathml/MathMLInlineContainerElement.cpp:

(WebCore::MathMLInlineContainerElement::createElementRenderer): The annotation-xml case is
now handled in MathMLAnnotationElement.

  • mathml/MathMLTextElement.cpp:

(WebCore::MathMLTextElement::createElementRenderer): The annotation case is handled is now
handled in MathMLAnnotationElement.
(WebCore::MathMLTextElement::childShouldCreateRenderer): Ditto.

  • mathml/MathMLTextElement.h: Override isToken to return true.
  • mathml/mathtags.in: Map annotation and annotation-xml to MathMLAnnotationElement.
3:55 AM Changeset in webkit [204691] by Michael Catanzaro
  • 2 edits
    1 delete in trunk/Source/WebCore

[GTK] Clean up CursorGtk.cpp
​https://bugs.webkit.org/show_bug.cgi?id=157794

Reviewed by Darin Adler.

We use GdkCursorType extensively in CursorGtk.cpp, but GTK+ does not support this anymore
and they're only sure to work under X11. Instead, use supported CSS cursor names. This
follows the grand tradition of replacing constants with hardcoded string values, but such
is the new best practice in GTK+ world.

Also, we have a bunch of custom cursors copied from Firefox. Each of these cursors is
nowadays guaranteed to be provided by GTK+, so we don't need any of these anymore.

  • platform/gtk/CursorGtk.cpp:

(WebCore::createNamedCursor):
(WebCore::Cursor::ensurePlatformCursor):

  • platform/gtk/CursorGtk.h: Removed.

Aug 20, 2016:

10:21 PM Changeset in webkit [204690] by Gyuyoung Kim
  • 8 edits in trunk/Source/WebKit2

Unreviewed EFL build fix since r204668

r204668 changed MessageDecoder with Decoder though, MessageDecoder remained
in EFL specific files.

  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
  • UIProcess/WebVibrationProxy.h:
  • WebProcess/Battery/WebBatteryManager.h:
  • WebProcess/WebPage/AcceleratedDrawingArea.cpp:

(WebKit::AcceleratedDrawingArea::didReceiveCoordinatedLayerTreeHostMessage):

  • WebProcess/WebPage/AcceleratedDrawingArea.h:
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
  • WebProcess/WebPage/LayerTreeHost.h:
8:26 PM Changeset in webkit [204689] by commit-queue@webkit.org
  • 1 edit
    1 delete in trunk/Tools

[EFL] Remove unnecessary a patch to mute ecore warnings
​https://bugs.webkit.org/show_bug.cgi?id=160997

Patch by Gyuyoung Kim <​gyuyoung.kim@navercorp.com> on 2016-08-20
Reviewed by Darin Adler.

There is no warning messages during the layout test and perf test
after bumping efl version from 1.17 to 1.18. Remove it.

  • efl/patches/ecore_remove_warnings.patch: Removed.
8:06 PM Changeset in webkit [204688] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the build.

  • dom/UIEvent.h:
7:21 PM Changeset in webkit [204687] by Darin Adler
  • 74 edits in trunk/Source/WebCore

Removed Objective-C specific attributes from IDL, made conditionals more consistent
​https://bugs.webkit.org/show_bug.cgi?id=160900

Reviewed by Sam Weinig.

Removed all Objective-C-specific attributes from all the various IDL files where
they were used. Except, oops, Sam already did that, and so everything just merged!
Now that Objective-C is gone, made all the conditionals be based on LANGUAGE_GOBJECT
specifically. Later we should cut these down because many were not actually needed
for the GObject bindings, actually only for Objective-C. Also made the style of
conditional consistent. Also re-sorted attributes in alphabetical order in many cases
and made formatting more consistent without fancy indentation. Also removed old comments
that tried to document where various operations and attributes were defined; it's not
helpful to track "this was part of DOM level 2" at this point. Also fixed a variety of
types to explicitly state the values are nullable in cases where the generated code
is currently not affected by that; mostly read-only attribute types.

  • Modules/mediasession/HTMLMediaElementMediaSession.idl:
  • Modules/mediastream/HTMLMediaElementMediaStream.idl:
  • animation/AnimationTimeline.idl:
  • animation/DocumentAnimation.idl:
  • bindings/scripts/IDLAttributes.txt:
  • css/CSSMediaRule.idl:
  • css/CSSPrimitiveValue.idl:
  • css/CSSRule.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleSheet.idl:
  • css/CSSValue.idl:
  • css/RGBColor.idl:
  • css/StyleSheet.idl:
  • dom/CharacterData.idl:
  • dom/DOMCoreException.idl:
  • dom/DOMImplementation.idl:
  • dom/Document.idl:
  • dom/DocumentType.idl:
  • dom/Element.idl:
  • dom/Event.idl:
  • dom/EventListener.idl:
  • dom/EventTarget.idl:
  • dom/KeyboardEvent.idl:
  • dom/MessageEvent.idl:
  • dom/MessagePort.idl:
  • dom/MouseEvent.idl:
  • dom/MutationEvent.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/NodeFilter.idl:
  • dom/NonElementParentNode.idl:
  • dom/Range.idl:
  • dom/Slotable.idl:
  • dom/UIEvent.idl:
  • dom/WheelEvent.idl:
  • fileapi/FileException.idl:
  • html/DOMTokenList.idl:
  • html/HTMLAnchorElement.idl:
  • html/HTMLAppletElement.idl:
  • html/HTMLCollection.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLOptionElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLTableColElement.idl:
  • html/HTMLVideoElement.idl:
  • html/ImageData.idl:
  • html/URLUtils.idl:
  • html/track/TextTrack.idl:
  • page/AbstractView.idl:
  • page/DOMSelection.idl:
  • page/DOMWindow.idl:
  • page/Location.idl:
  • svg/SVGDocument.idl:
  • svg/SVGElement.idl:
  • svg/SVGException.idl:
  • svg/SVGExternalResourcesRequired.idl:
  • svg/SVGFilterPrimitiveStandardAttributes.idl:
  • svg/SVGFitToViewBox.idl:
  • svg/SVGPathSeg.idl:
  • svg/SVGTests.idl:
  • svg/SVGURIReference.idl:
  • svg/SVGZoomAndPan.idl:
  • workers/DedicatedWorkerGlobalScope.idl:
  • workers/Worker.idl:
  • workers/WorkerGlobalScope.idl:
  • xml/XPathException.idl:
  • xml/XPathExpression.idl:
  • xml/XPathNSResolver.idl:

See above for summary of changes.

6:43 PM Changeset in webkit [204686] by BJ Burg
  • 2 edits in trunk/Source/JavaScriptCore

Remote Inspector: some methods don't need to be marked virtual anymore
​https://bugs.webkit.org/show_bug.cgi?id=161033

Reviewed by Darin Adler.

This probably happened when this code was last refactored and moved around.

  • inspector/remote/RemoteConnectionToTarget.h:
6:09 PM Changeset in webkit [204685] by weinig@apple.com
  • 35 edits in trunk/Source/WebCore

Remove Objective-C specific extended attributes from the bindings
​https://bugs.webkit.org/show_bug.cgi?id=161034

Reviewed by Dan Bernstein.

  • Removes ObjCPolymorphic, ObjCProtocol, ObjCLegacyUnnamedParameters and ObjCExplicitAtomicString extended attributes.
  • animation/AnimationTimeline.idl:
  • css/CSSMediaRule.idl:
  • css/CSSPrimitiveValue.idl:
  • css/CSSRule.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleSheet.idl:
  • css/CSSValue.idl:
  • css/StyleSheet.idl:
  • dom/CharacterData.idl:
  • dom/DOMImplementation.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Event.idl:
  • dom/EventListener.idl:
  • dom/EventTarget.idl:
  • dom/MouseEvent.idl:
  • dom/MutationEvent.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/NodeFilter.idl:
  • dom/NonElementParentNode.idl:
  • dom/Range.idl:
  • dom/UIEvent.idl:
  • html/HTMLCollection.idl:
  • html/HTMLSelectElement.idl:
  • svg/SVGExternalResourcesRequired.idl:
  • svg/SVGFilterPrimitiveStandardAttributes.idl:
  • svg/SVGFitToViewBox.idl:
  • svg/SVGPathSeg.idl:
  • svg/SVGTests.idl:
  • svg/SVGURIReference.idl:
  • svg/SVGZoomAndPan.idl:
  • xml/XPathExpression.idl:
  • xml/XPathNSResolver.idl:
5:54 PM Changeset in webkit [204684] by weinig@apple.com
  • 37 edits in trunk/Source/WebCore

Roll out r204683.

4:43 PM Changeset in webkit [204683] by weinig@apple.com
  • 37 edits in trunk/Source/WebCore

Remove Objective-C specific extended attributes / features from the bindings
​https://bugs.webkit.org/show_bug.cgi?id=161034

Reviewed by Dan Bernstein.

  • Removes ObjCPolymorphic, ObjCProtocol, ObjCLegacyUnnamedParameters and ObjCExplicitAtomicString extended attributes.
  • Remove support for multiple inheritance from the IDLParser.
  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/IDLParser.pm:
  • animation/AnimationTimeline.idl:
  • css/CSSMediaRule.idl:
  • css/CSSPrimitiveValue.idl:
  • css/CSSRule.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleSheet.idl:
  • css/CSSValue.idl:
  • css/StyleSheet.idl:
  • dom/CharacterData.idl:
  • dom/DOMImplementation.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Event.idl:
  • dom/EventListener.idl:
  • dom/EventTarget.idl:
  • dom/MouseEvent.idl:
  • dom/MutationEvent.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/NodeFilter.idl:
  • dom/NonElementParentNode.idl:
  • dom/Range.idl:
  • dom/UIEvent.idl:
  • html/HTMLCollection.idl:
  • html/HTMLSelectElement.idl:
  • svg/SVGExternalResourcesRequired.idl:
  • svg/SVGFilterPrimitiveStandardAttributes.idl:
  • svg/SVGFitToViewBox.idl:
  • svg/SVGPathSeg.idl:
  • svg/SVGTests.idl:
  • svg/SVGURIReference.idl:
  • svg/SVGZoomAndPan.idl:
  • xml/XPathExpression.idl:
  • xml/XPathNSResolver.idl:
3:00 PM Changeset in webkit [204682] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

[Mac] Web Content service with a restricted entitlement may load arbitrary dylibs
​https://bugs.webkit.org/show_bug.cgi?id=156668
<rdar://problem/25429784>

Reviewed by Sam Weinig.

  • Configurations/WebContentService.xcconfig: Enable library validation when the Web Content service is given the XPC domain extension entitlement.
2:40 PM Changeset in webkit [204681] by weinig@apple.com
  • 28 edits
    1 delete in trunk/Source/WebCore

Stop pretending that AbstractView is a thing, it's not
​https://bugs.webkit.org/show_bug.cgi?id=161032

Reviewed by Dan Bernstein.

Remove AbstractView.idl, the AbstractView typedef of DOMWindow, and
all special casing of the name AbstractView in the JS code generator.

No change in behavior.

  • DerivedSources.make:
  • Modules/indieui/UIRequestEvent.cpp:

(WebCore::UIRequestEvent::createForBindings):
(WebCore::UIRequestEvent::create):
(WebCore::UIRequestEvent::UIRequestEvent):

  • Modules/indieui/UIRequestEvent.h:

(WebCore::UIRequestEvent::receiver):

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/CodeGeneratorGObject.pm:
  • bindings/scripts/CodeGeneratorJS.pm:

(ShouldGenerateToJSDeclaration):
(GetImplClassName):

  • dom/CompositionEvent.cpp:

(WebCore::CompositionEvent::CompositionEvent):
(WebCore::CompositionEvent::~CompositionEvent):
(WebCore::CompositionEvent::initCompositionEvent):

  • dom/CompositionEvent.h:
  • dom/FocusEvent.cpp:

(WebCore::FocusEvent::isFocusEvent):
(WebCore::FocusEvent::FocusEvent):

  • dom/FocusEvent.h:
  • dom/KeyboardEvent.cpp:

(WebCore::KeyboardEvent::KeyboardEvent):
(WebCore::KeyboardEvent::~KeyboardEvent):
(WebCore::KeyboardEvent::initKeyboardEvent):

  • dom/KeyboardEvent.h:
  • dom/MouseEvent.cpp:

(WebCore::MouseEvent::createForBindings):
(WebCore::MouseEvent::create):
(WebCore::MouseEvent::MouseEvent):
(WebCore::MouseEvent::~MouseEvent):
(WebCore::MouseEvent::initMouseEvent):

  • dom/MouseEvent.h:
  • dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::MouseRelatedEvent):
(WebCore::contentsScrollOffset):

  • dom/MouseRelatedEvent.h:
  • dom/SimulatedClick.cpp:
  • dom/TextEvent.cpp:

(WebCore::TextEvent::createForBindings):
(WebCore::TextEvent::create):
(WebCore::TextEvent::createForPlainTextPaste):
(WebCore::TextEvent::createForFragmentPaste):
(WebCore::TextEvent::createForDrop):
(WebCore::TextEvent::createForDictation):
(WebCore::TextEvent::TextEvent):
(WebCore::TextEvent::~TextEvent):
(WebCore::TextEvent::initTextEvent):

  • dom/TextEvent.h:
  • dom/TouchEvent.h:
  • dom/UIEvent.cpp:

(WebCore::UIEvent::UIEvent):
(WebCore::UIEvent::~UIEvent):
(WebCore::UIEvent::initUIEvent):

  • dom/UIEvent.h:

(WebCore::UIEvent::create):
(WebCore::UIEvent::createForBindings):
(WebCore::UIEvent::view):
(WebCore::UIEvent::detail):

  • dom/UIEventWithKeyState.h:

(WebCore::UIEventWithKeyState::UIEventWithKeyState):

  • dom/WheelEvent.cpp:

(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):
(WebCore::WheelEvent::initWebKitWheelEvent):

  • dom/WheelEvent.h:
  • page/AbstractView.idl: Removed.
10:29 AM Changeset in webkit [204680] by Simon Fraser
  • 7 edits in trunk/Tools

REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
​https://bugs.webkit.org/show_bug.cgi?id=160985

Re-land r204672, but don't check the result of 'xcrun simctl shutdown', because
device shutdown seems to happen as result of killing Simulator.apps, and we're racing
with that.

  • Scripts/webkitpy/layout_tests/views/printing.py:

(Printer.print_config):

  • Scripts/webkitpy/port/base.py:

(Port.driver_cmd_line_for_logging):
(Port.driver_cmd_line): Deleted.

  • Scripts/webkitpy/port/driver.py:

(IOSSimulatorDriver.cmd_line):

  • Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort.init):
(IOSSimulatorPort.driver_cmd_line_for_logging):
(IOSSimulatorPort._create_simulators):
(IOSSimulatorPort.setup_test_run):
(IOSSimulatorPort._quit_ios_simulator):
(IOSSimulatorPort.clean_up_test_run):
(IOSSimulatorPort._create_device):
(IOSSimulatorPort):
(IOSSimulatorPort._remove_device):
(IOSSimulatorPort._testing_device):
(IOSSimulatorPort.device_id_for_worker_number):
(IOSSimulatorPort._set_device_class): Deleted.
(IOSSimulatorPort.testing_device): Deleted.

  • Scripts/webkitpy/port/port_testcase.py:

(PortTestCase.test_driver_cmd_line):

  • Scripts/webkitpy/xcode/simulator.py:

(Device.shutdown):
(Device):
(Device.delete):
(Device.reset):
(Simulator):
(Simulator.create_device):
(Simulator.remove_device):
(Simulator.device_number):
(Simulator.device_state_description):
(Simulator.wait_until_device_is_in_state):

7:44 AM Changeset in webkit [204679] by weinig@apple.com
  • 32 edits
    1 delete in trunk

Location.ancestorOrigins should return a FrozenArray<USVString>
​https://bugs.webkit.org/show_bug.cgi?id=161018

Reviewed by Ryosuke Niwa and Chris Dumez.

Source/JavaScriptCore:

  • runtime/ObjectConstructor.h:

(JSC::objectConstructorFreeze):
Export objectConstructorFreeze so it can be used to freeze DOM FrozenArrays.

Source/WebCore:

Updated tests: fast/dom/Window/Location/ancestor-origins.html

fast/dom/indexed-getters-returning-string.html

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::transaction):
(WebCore::IDBDatabase::deleteObjectStore):

  • Modules/indexeddb/IDBDatabase.h:

Remove unused ScriptExecutionContext parameter.

  • Modules/indexeddb/IDBDatabase.idl:

There is no need for a custom implementation anymore.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:

Remove JSDOMStringListCustom.cpp, which is no longer needed.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::jsArray): Deleted.
Remove overload of jsArray that took a DOMStringList.

  • bindings/js/JSDOMBinding.h:

(WebCore::jsFrozenArray):
Add jsFrozenArray which returns an JSArray which has had the moral
equivalent of Object.freeze() called on it. This follows
​http://heycam.github.io/webidl/#es-frozen-array.

  • bindings/js/JSDOMStringListCustom.cpp:

Removed.

  • bindings/js/JSIDBDatabaseCustom.cpp:

(WebCore::JSIDBDatabase::transaction): Deleted.
Remove no longer necessary custom implementation of transaction.

  • bindings/scripts/CodeGenerator.pm:

(IsRefPtrType):
(IsSVGAnimatedType):
(IsSequenceType):
(GetSequenceType):
(IsFrozenArrayType):
(GetFrozenArrayInnerType):

  • bindings/scripts/CodeGeneratorJS.pm:

(AreTypesDistinguishableForOverloadResolution):
(GenerateOverloadedFunctionOrConstructor):
(GetNativeType):
(GetNativeVectorInnerType):
(GetNativeTypeForCallbacks):
(JSValueToNative):
(NativeToJSValue):

  • bindings/scripts/IDLParser.pm:

(parseNonAnyType):
Add support for FrozenArray, closely matching the sequence code.

  • bindings/scripts/test/JS/JSTestCallback.cpp:
  • bindings/scripts/test/JS/JSTestCallback.h:
  • bindings/scripts/test/JS/JSTestCallbackFunction.cpp:
  • bindings/scripts/test/JS/JSTestCallbackFunction.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

Updated bindings test results.

  • dom/DOMStringList.idl:

Remove JSCustomToNativeObject, which is no longer needed.

  • inspector/InspectorIndexedDBAgent.cpp:

Update calls to IDBDatabase::transaction.

  • page/Location.cpp:

(WebCore::Location::ancestorOrigins):

  • page/Location.h:

Change ancestorOrigins to return a Vector<String> rather than
a DOMStringList.

  • page/Location.idl:

Change ancestorOrigins to return a FrozenArray<USVString>, matching
the HTML5 spec.

LayoutTests:

Update existing tests to account for the change in type of Location.ancestorOrigins.

  • fast/dom/Window/Location/ancestor-origins-expected.txt:
  • fast/dom/Window/Location/ancestor-origins.html:
  • fast/dom/indexed-getters-returning-string-expected.txt:
  • fast/dom/indexed-getters-returning-string.html:
4:39 AM WebKitGTK/Gardening/Calendar edited by jfernandez@igalia.com
(diff)
2:38 AM Changeset in webkit [204678] by jfernandez@igalia.com
  • 20 edits in trunk/Source/WebKit2

[GTK] Unreviewed GTK build fix since r204665 and 204668
​https://bugs.webkit.org/show_bug.cgi?id=161020

  • CMakeLists.txt:
  • Platform/IPC/MessageRecorder.cpp:

(IPC::MessageRecorder::recordOutgoingMessage):

  • Platform/IPC/unix/ConnectionUnix.cpp:

(IPC::Connection::processMessage):
(IPC::Connection::sendOutgoingMessage):

  • Platform/unix/SharedMemoryUnix.cpp:

(WebKit::SharedMemory::Handle::encode):
(WebKit::SharedMemory::Handle::decode):

  • PlatformGTK.cmake:
  • Scripts/webkit/LegacyMessageReceiver-expected.cpp:

(Messages::WebPage::GetPluginProcessConnection::DelayedReply::DelayedReply):
(Messages::WebPage::TestMultipleAttributes::DelayedReply::DelayedReply):
(WebKit::WebPage::didReceiveWebPageMessage):
(WebKit::WebPage::didReceiveSyncWebPageMessage):

  • Scripts/webkit/LegacyMessages-expected.h:
  • Scripts/webkit/MessageReceiver-expected.cpp:

(Messages::WebPage::GetPluginProcessConnection::DelayedReply::DelayedReply):
(Messages::WebPage::TestMultipleAttributes::DelayedReply::DelayedReply):
(WebKit::WebPage::didReceiveMessage):
(WebKit::WebPage::didReceiveSyncMessage):

  • Scripts/webkit/Messages-expected.h:
  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(IPC::ArgumentCoder<WebCore::FilterOperations>::encode):
(IPC::ArgumentCoder<WebCore::FilterOperations>::decode):
(IPC::ArgumentCoder<TransformOperations>::encode):
(IPC::ArgumentCoder<TransformOperations>::decode):
(IPC::encodeTimingFunction):
(IPC::decodeTimingFunction):
(IPC::ArgumentCoder<TextureMapperAnimation>::encode):
(IPC::ArgumentCoder<TextureMapperAnimation>::decode):
(IPC::ArgumentCoder<TextureMapperAnimations>::encode):
(IPC::ArgumentCoder<TextureMapperAnimations>::decode):
(IPC::ArgumentCoder<WebCore::GraphicsSurfaceToken>::encode):
(IPC::ArgumentCoder<WebCore::GraphicsSurfaceToken>::decode):
(IPC::ArgumentCoder<SurfaceUpdateInfo>::encode):
(IPC::ArgumentCoder<SurfaceUpdateInfo>::decode):
(IPC::ArgumentCoder<CoordinatedGraphicsLayerState>::encode):
(IPC::ArgumentCoder<CoordinatedGraphicsLayerState>::decode):
(IPC::ArgumentCoder<TileUpdateInfo>::encode):
(IPC::ArgumentCoder<TileUpdateInfo>::decode):
(IPC::ArgumentCoder<TileCreationInfo>::encode):
(IPC::ArgumentCoder<TileCreationInfo>::decode):
(IPC::encodeCoordinatedSurface):
(IPC::decodeCoordinatedSurface):
(IPC::ArgumentCoder<CoordinatedGraphicsState>::encode):
(IPC::ArgumentCoder<CoordinatedGraphicsState>::decode):

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
  • Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:

(WebKit::WebCoordinatedSurface::Handle::encode):
(WebKit::WebCoordinatedSurface::Handle::decode):

  • Shared/CoordinatedGraphics/WebCoordinatedSurface.h:
  • Shared/WebBatteryStatus.cpp:

(WebKit::WebBatteryStatus::Data::encode):
(WebKit::WebBatteryStatus::Data::decode):

  • Shared/WebBatteryStatus.h:
  • Shared/gtk/ArgumentCodersGtk.cpp:

(IPC::encodeImage):
(IPC::decodeImage):
(IPC::encodeDataObject):
(IPC::decodeDataObject):
(IPC::ArgumentCoder<DragData>::encode):
(IPC::ArgumentCoder<DragData>::decode):
(IPC::encodeGKeyFile):
(IPC::decodeGKeyFile):
(IPC::encode):
(IPC::decode):

  • Shared/gtk/ArgumentCodersGtk.h:
  • Shared/soup/WebCoreArgumentCodersSoup.cpp:

(IPC::ArgumentCoder<ResourceRequest>::encodePlatformData):
(IPC::ArgumentCoder<ResourceRequest>::decodePlatformData):
(IPC::ArgumentCoder<CertificateInfo>::encode):
(IPC::ArgumentCoder<CertificateInfo>::decode):
(IPC::ArgumentCoder<ResourceError>::encodePlatformData):
(IPC::ArgumentCoder<ResourceError>::decodePlatformData):
(IPC::ArgumentCoder<ProtectionSpace>::encodePlatformData):
(IPC::ArgumentCoder<ProtectionSpace>::decodePlatformData):
(IPC::ArgumentCoder<Credential>::encodePlatformData):
(IPC::ArgumentCoder<Credential>::decodePlatformData):

  • UIProcess/LegacySessionStateCodingNone.cpp:

(WebKit::encodeLegacySessionState):
(WebKit::decodeLegacySessionState):

  • UIProcess/WebBatteryManagerProxy.h:
1:04 AM Changeset in webkit [204677] by Yusuke Suzuki
  • 2 edits in trunk/Source/WebKit2

Unreviewed, build fix attempt after r204665 and r204668.

  • PlatformGTK.cmake:
Note: See TracTimeline for information about the timeline view.