⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 26, 2016:

10:47 PM Changeset in webkit [205074] by mitz@apple.com
  • 2 edits in trunk/Tools

Keep trying to fix the build after r205057.

  • MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
10:44 PM Changeset in webkit [205073] by mitz@apple.com
  • 6 edits in trunk/Tools

Keep trying to fix the build after r205057.

  • MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Don’t try to import nonexistent config.h. This file is only meant to be built with Xcode anyway.
  • MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Make this compile with Xcode 7.3 and deploy to iOS 9.0.
  • MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Ditto.
  • MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Don’t try to import config.h.
  • MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Ditto.
9:39 PM Changeset in webkit [205072] by mitz@apple.com
  • 2 edits in trunk/Tools

Start trying to fix the build after r205057.

  • MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
9:38 PM Changeset in webkit [205071] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.50.0.8

New tag.

8:48 PM Changeset in webkit [205070] by ap@apple.com
  • 2 edits in trunk/Tools

Remove Yosemite Leaks from the flakiness dashboard
​https://bugs.webkit.org/show_bug.cgi?id=161253

Reviewed by Anders Carlsson.

  • TestResultServer/static-dashboards/builders.jsonp:
8:04 PM Changeset in webkit [205069] by achristensen@apple.com
  • 3 edits in trunk/Source/WebCore

Fix Windows build after r205065.

  • Modules/webaudio/BiquadFilterNode.idl:
  • Modules/webaudio/PannerNode.idl:

There's no WEB_AUDIO on Windows.

7:53 PM Changeset in webkit [205068] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

REGRESSION (r203535): Web Inspector: Inspector overlay node info has disappeared
​https://bugs.webkit.org/show_bug.cgi?id=161264

Patch by Devin Rousso <Devin Rousso> on 2016-08-26
Reviewed by Joseph Pecoraro.

No new tests. Fixing JavaScript error in Inspector overlay.

  • inspector/InspectorOverlay.cpp:

(evaluateCommandInOverlay):
(WebCore::InspectorOverlay::evaluateInOverlay):
Add ASSERT to ensure that errors in the Inspector overlay will cause tests to crash.

  • inspector/InspectorOverlayPage.js:

(DOMBuilder.prototype.appendTextNode):
Move textContent value to parameter of document.createTextNode.

7:51 PM Changeset in webkit [205067] by Joseph Pecoraro
  • 2 edits in trunk/LayoutTests

Web Inspector: inspector/indexeddb/deleteDatabaseNamesWithSpace.html is flakey
​https://bugs.webkit.org/show_bug.cgi?id=161283

Reviewed by Alex Christensen.

  • inspector/indexeddb/deleteDatabaseNamesWithSpace.html:

Add a short timeout between deleting a database and requesting database names
to reduce flakey results.

7:39 PM Changeset in webkit [205066] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WTF

bitwise_cast uses inactive member of union
​https://bugs.webkit.org/show_bug.cgi?id=161244

Patch by JF Bastien <​jfbastien@apple.com> on 2016-08-26
Reviewed by Benjamin Poulain.

  • wtf/Compiler.h:

Add COMPILER_HAS_CLANG_FEATURE

  • wtf/StdLibExtras.h:

(WTF::bitwise_cast):
Fix C++ UB, add trivially-copyable check.

bitwise_cast stores into a union with one type and reads with
another, which is technically C++ undefined behavior because it's
accessing the wrong active member of the union. The better way to
do this is through memcpy, which compilers optimize as well
because it's known-size in known-not-to-escape storage (for small
types they'll inline and then convert stack memory access to SSA
values which may be in-register if that makes sense, which would
be a move between int/FP registers at worst).

The C++ Standard's section [basic.types] explicitly blesses memcpy:

For any trivially copyable type T, if two pointers to T point to
distinct T objects obj1 and obj2, where neither obj1 nor obj2 is a
base-class subobject, if the underlying bytes (1.7) making up obj1
are copied into obj2, 42 obj2 shall subsequently hold the same
value as obj1.

[Example:

T* t1p;
T* t2p;
provided that t2p points to an initialized object ...
std::memcpy(t1p, t2p, sizeof(T));
 at this point, every subobject of trivially copyable type in *t1p contains
the same value as the corresponding subobject in *t2p

— end example ]

Whereas section [class.union] says:

In a union, at most one of the non-static data members can be
active at any time, that is, the value of at most one of the
non-static data members can be stored in a union at any time.

While we're at it, checking that sizeof(To) == sizeof(From) is
good, but we should also check that both types are trivially
copyable (can have a ctor, no dtor, and copy is defaulted as if by
memcpy for type and all subtypes). Unfortunately that trait isn't
implemented consistently in all recent compiler+stdlib
implementations, but recent clang has an equivalent builtin
(other compilers simply won't do the check, and will break on bots
with the right compilers which is better than the current silent
breakage). This builtin hack also avoids #include <type_traits>
which really doesn't save much.

7:01 PM Changeset in webkit [205065] by weinig@apple.com
  • 108 edits
    7 deletes in trunk

Remove support for ENABLE_LEGACY_WEB_AUDIO
​https://bugs.webkit.org/show_bug.cgi?id=161262

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Remove ENABLE_LEGACY_WEB_AUDIO

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Remove ENABLE_LEGACY_WEB_AUDIO.

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::noteGrainOn): Deleted.

  • Modules/webaudio/AudioBufferSourceNode.h:
  • Modules/webaudio/AudioBufferSourceNode.idl:

(WebCore::AudioScheduledSourceNode::noteOn): Deleted.
(WebCore::AudioScheduledSourceNode::noteOff): Deleted.

  • Modules/webaudio/AudioScheduledSourceNode.h:
  • Modules/webaudio/AudioScheduledSourceNode.cpp:

Remove the looping attribute, as well as the noteOn, noteOff, and noteGrainOn functions.

  • Modules/webaudio/AudioContext.idl:

Remove the createGainNode, createDelayNode and createJavaScriptNode functions.

  • Modules/webaudio/AudioParam.idl:

Remove the setTargetValueAtTime function.

  • Modules/webaudio/BiquadDSPKernel.cpp:

(WebCore::BiquadDSPKernel::updateCoefficientsIfNecessary):

  • Modules/webaudio/BiquadFilterNode.cpp:

(WebCore::BiquadFilterNode::type):
(WebCore::BiquadFilterNode::setType):
(WebCore::BiquadFilterNode::getFrequencyResponse):

  • Modules/webaudio/BiquadFilterNode.h:
  • Modules/webaudio/BiquadFilterNode.idl:
  • Modules/webaudio/BiquadProcessor.cpp:

(WebCore::BiquadProcessor::BiquadProcessor):
(WebCore::BiquadProcessor::setType):
(WebCore::BiquadProcessor::getFrequencyResponse):

  • Modules/webaudio/BiquadProcessor.h:

(WebCore::BiquadProcessor::type):

  • bindings/js/JSBiquadFilterNodeCustom.cpp: Removed.

Rename BiquadProcessor::FilterType to BiquadFilterType and use it
directly from the IDL. Remove legacy filter constants from the IDL
and the need for a custom binding for the type attribute.

  • Modules/webaudio/OscillatorNode.cpp:

(WebCore::OscillatorNode::OscillatorNode):
(WebCore::OscillatorNode::setType):
(WebCore::OscillatorNode::setPeriodicWave):
(WebCore::OscillatorNode::type): Deleted.

  • Modules/webaudio/OscillatorNode.h:

(WebCore::OscillatorNode::type):

  • Modules/webaudio/OscillatorNode.idl:
  • Modules/webaudio/PeriodicWave.cpp:

(WebCore::PeriodicWave::createSine):
(WebCore::PeriodicWave::createSquare):
(WebCore::PeriodicWave::createSawtooth):
(WebCore::PeriodicWave::createTriangle):
(WebCore::PeriodicWave::generateBasicWaveform):

  • Modules/webaudio/PeriodicWave.h:
  • bindings/js/JSOscillatorNodeCustom.cpp: Removed.

Remove noteOn and noteOff functions and the type integer constants.
Remove the need for a custom binding for the type attribute by renaming
the type enum OscillatorNode::Type and putting the enum in the IDL.

  • Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::PannerNode):
(WebCore::PannerNode::process):
(WebCore::PannerNode::setPanningModel):
(WebCore::PannerNode::distanceModel):
(WebCore::PannerNode::setDistanceModel):
(WebCore::PannerNode::panningModel): Deleted.

  • Modules/webaudio/PannerNode.h:

(WebCore::PannerNode::panningModel):

  • Modules/webaudio/PannerNode.idl:
  • bindings/js/JSPannerNodeCustom.cpp: Removed.
  • platform/audio/Distance.cpp:

(WebCore::DistanceEffect::DistanceEffect):
(WebCore::DistanceEffect::gain):

  • platform/audio/Distance.h:

(WebCore::DistanceEffect::model):
(WebCore::DistanceEffect::setModel):

  • platform/audio/EqualPowerPanner.cpp:

(WebCore::EqualPowerPanner::EqualPowerPanner):

  • platform/audio/HRTFPanner.cpp:

(WebCore::HRTFPanner::HRTFPanner):

  • platform/audio/Panner.cpp:

(WebCore::Panner::create):

  • platform/audio/Panner.h:

(WebCore::Panner::panningModel):
(WebCore::Panner::Panner):
Replace the panning model and distance model integer constants
with IDL enum support, removing the need for a custom binding.
Rename the supporting C++ enums to work with the bindings.

  • bindings/js/JSAudioContextCustom.cpp:

(WebCore::constructJSAudioContext):
Remove deprecated way of creating an offline context.

  • WebCore.xcodeproj/project.pbxproj:

Update files.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Remove ENABLE_LEGACY_WEB_AUDIO

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Remove ENABLE_LEGACY_WEB_AUDIO.

Tools:

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

  • webaudio/audiobuffersource-loop-points.html:
  • webaudio/audiobuffersource-multi-channels.html:
  • webaudio/audiobuffersource-playbackState-expected.txt:
  • webaudio/audiobuffersource-playbackState.html:
  • webaudio/audiobuffersource-playbackrate.html:
  • webaudio/audiochannelmerger-stereo.html:
  • webaudio/audiochannelsplitter.html:
  • webaudio/audionode-connect-order.html:
  • webaudio/audionode-expected.txt:
  • webaudio/audionode.html:
  • webaudio/audioparam-connect-audioratesignal.html:
  • webaudio/audioparam-summingjunction.html:
  • webaudio/audioprocessingevent.html:
  • webaudio/automatic-pull-node.html:
  • webaudio/biquad-allpass.html:
  • webaudio/biquad-bandpass.html:
  • webaudio/biquad-getFrequencyResponse.html:
  • webaudio/biquad-highpass.html:
  • webaudio/biquad-highshelf.html:
  • webaudio/biquad-lowpass.html:
  • webaudio/biquad-lowshelf.html:
  • webaudio/biquad-notch.html:
  • webaudio/biquad-peaking.html:
  • webaudio/biquadfilternode-basic-expected.txt:
  • webaudio/biquadfilternode-basic.html:
  • webaudio/convolution-mono-mono.html:
  • webaudio/delaynode-max-default-delay.html:
  • webaudio/delaynode-max-nondefault-delay.html:
  • webaudio/delaynode-maxdelay.html:
  • webaudio/delaynode-scheduling.html:
  • webaudio/delaynode.html:
  • webaudio/distance-exponential-expected.txt:
  • webaudio/distance-exponential.html:
  • webaudio/distance-inverse-expected.txt:
  • webaudio/distance-inverse.html:
  • webaudio/distance-linear-expected.txt:
  • webaudio/distance-linear.html:
  • webaudio/gain-basic.html:
  • webaudio/gain.html:
  • webaudio/javascriptaudionode-zero-input-channels.html:
  • webaudio/javascriptaudionode.html:
  • webaudio/mixing.html:
  • webaudio/note-grain-on-play-expected.txt: Removed.
  • webaudio/note-grain-on-play.html: Removed.
  • webaudio/note-grain-on-timing-expected.txt: Removed.
  • webaudio/note-grain-on-timing.html: Removed.
  • webaudio/oscillator-basic-expected.txt:
  • webaudio/oscillator-basic.html:
  • webaudio/oscillator-custom.html:
  • webaudio/oscillator-sawtooth.html:
  • webaudio/oscillator-sine.html:
  • webaudio/oscillator-square.html:
  • webaudio/oscillator-triangle.html:
  • webaudio/pannernode-basic-expected.txt:
  • webaudio/pannernode-basic.html:
  • webaudio/resources/audio-testing.js:
  • webaudio/resources/audioparam-testing.js:
  • webaudio/resources/biquad-testing.js:
  • webaudio/resources/distance-model-testing.js:
  • webaudio/resources/javascriptaudionode-testing.js:
  • webaudio/resources/oscillator-testing.js:
  • webaudio/resources/panner-model-testing.js:
  • webaudio/sample-accurate-scheduling.html:
  • webaudio/stereo2mono-down-mixing.html:
  • webaudio/up-mixing-mono-51.html:
  • webaudio/up-mixing-mono-stereo.html:
  • webaudio/up-mixing-stereo-51.html:
  • webaudio/waveshaper.html:

Update tests for removal of ENABLE_LEGACY_WEB_AUDIO.

5:36 PM Changeset in webkit [205064] by benjamin@webkit.org
  • 4 edits
    1 add in trunk

[JSC] Implement CompareStrictEq(String, Untyped) in FTL
​https://bugs.webkit.org/show_bug.cgi?id=161229

Reviewed by Geoffrey Garen.

JSTests:

  • stress/compare-strict-eq-on-various-types.js: Added.

Source/JavaScriptCore:

Add (String, Untyped) uses to FTL CompareStrictEq.
This was the last use type not implemented, the node is fully
supported by FTL after this patch.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
(JSC::FTL::DFG::LowerDFGToB3::compileStringToUntypedStrictEquality):

(JSC::FTL::DFG::LowerDFGToB3::nonSpeculativeCompare):
Remove the type checks when possible.

5:33 PM Changeset in webkit [205063] by bshafiei@apple.com
  • 5 edits in branches/safari-602.1.50.0-branch/Source

Versioning.

5:30 PM Changeset in webkit [205062] by commit-queue@webkit.org
  • 8 edits in trunk/Source

Web Inspector: Frontend should have access to Resource Timing information
​https://bugs.webkit.org/show_bug.cgi?id=160095

Patch by Johan K. Jensen <​johan_jensen@apple.com> on 2016-08-26
Reviewed by Alex Christensen.

Source/JavaScriptCore:

Rename ResourceTiming property.

  • inspector/protocol/Network.json:

Rename navigationStart to startTime so it's applicable
for all resources and not just the main resource.

Source/WebCore:

Show correct information with Resource Timing information
from ResourceLoader rather than DocumentLoader.

No new tests, frontend doesn't use the timing data yet.

  • inspector/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::buildObjectForTiming):
(WebCore::InspectorNetworkAgent::buildObjectForResourceResponse):
(WebCore::InspectorNetworkAgent::buildObjectForCachedResource):
(WebCore::InspectorNetworkAgent::willSendRequest):
(WebCore::InspectorNetworkAgent::didReceiveResponse):
(WebCore::InspectorNetworkAgent::didLoadResourceFromMemoryCache):
(WebCore::buildObjectForTiming): Deleted.
(WebCore::buildObjectForResourceResponse): Deleted.
(WebCore::buildObjectForCachedResource): Deleted.
Use ResourceLoader instead of DocumentLoader to get Resource Timing information.
Move functions to member functions to access the executionStopWatch.

(WebCore::InspectorNetworkAgent::didFinishLoading):
Use the load timing finishTime and convert to elapsed time for frontend.

  • inspector/InspectorNetworkAgent.h:
  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didFinishLoading):
Pass the web process load timing on to the inspector.

Source/WTF:

Add method to get elapsed time for any monotonic time.
Used by InspectorNetworkAgent.

  • wtf/Stopwatch.h:

(WTF::Stopwatch::elapsedTimeSinceMonotonicTime):

5:13 PM Changeset in webkit [205061] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Unreviewed, fix Windows build after r205048.

  • bindings/scripts/CodeGeneratorJS.pm:

(getConditionalForFunctionConsideringOverloads):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionSingleConditionalOverload1):
(WebCore::jsTestObjPrototypeFunctionSingleConditionalOverload2):
(WebCore::jsTestObjPrototypeFunctionSingleConditionalOverload):

  • bindings/scripts/test/TestObj.idl:
5:04 PM Changeset in webkit [205060] by rniwa@webkit.org
  • 15 edits
    3 adds in trunk

Adopted custom element's callbacks should continue to work
​https://bugs.webkit.org/show_bug.cgi?id=161065

Reviewed by Andreas Kling.

Source/WebCore:

When a custom element is adopted into another document, its reaction callbacks need to continue to work.
Because a different document may have its own global object, each custom element needs to remember its
original global object or JSCustomElementInterface. This patch adds the latter to the element rare data.

Tests: fast/custom-elements/connected-callbacks.html

fast/custom-elements/disconnected-callbacks.html

  • bindings/js/JSCustomElementInterface.cpp:

(WebCore::JSCustomElementInterface::constructElement):
(WebCore::JSCustomElementInterface::upgradeElement):

  • dom/CustomElementReactionQueue.cpp:

(WebCore::findInterfaceForCustomElement): Deleted.
(WebCore::CustomElementReactionQueue::enqueueConnectedCallbackIfNeeded):
(WebCore::CustomElementReactionQueue::enqueueDisconnectedCallbackIfNeeded):
(WebCore::CustomElementReactionQueue::enqueueAttributeChangedCallbackIfNeeded):

  • dom/Element.cpp:

(WebCore::Element::insertedInto): Invoke callbacks even when the current document is not a HTML document.
(WebCore::Element::removedFrom): Ditto.
(WebCore::Element::setCustomElementIsResolved): Moved from Node. Add the element interface to the rare data.
(WebCore::Element::customElementInterface): Added.

  • dom/Element.h:
  • dom/ElementRareData.cpp:
  • dom/ElementRareData.h:

(WebCore::ElementRareData::customElementInterface): Added.
(WebCore::ElementRareData::setCustomElementInterface): Added.

  • dom/Node.h:

((WebCore::Node::setCustomElementIsResolved): Deleted.

LayoutTests:

Added test cases for adopting custom elements into various kinds of documents.

  • fast/custom-elements/connected-callbacks-expected.txt:
  • fast/custom-elements/connected-callbacks.html:
  • fast/custom-elements/defined-pseudo-class-expected.txt:
  • fast/custom-elements/defined-pseudo-class.html:
  • fast/custom-elements/disconnected-callbacks-expected.txt:
  • fast/custom-elements/disconnected-callbacks.html:
  • fast/custom-elements/resources/document-types.js: Added.
  • fast/custom-elements/resources/empty-html-document.html: Added.
4:47 PM Changeset in webkit [205059] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Marking webgl/max-active-contexts-webglcontextlost-prevent-default.html as flaky on mac-wk1.
​https://bugs.webkit.org/show_bug.cgi?id=161205

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
4:43 PM Changeset in webkit [205058] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Marking http/tests/media/hls/hls-accessiblity-describes-video-menu.html as flaky on mac-wk1.
​https://bugs.webkit.org/show_bug.cgi?id=161144

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
4:28 PM Changeset in webkit [205057] by jer.noble@apple.com
  • 4 edits
    26 adds in trunk

Add a test harness for running UI tests on the iOS Simulator
​https://bugs.webkit.org/show_bug.cgi?id=161265

.:

Add the new MobileMiniBrowser project to the WebKit workspace.

Reviewed by Simon Fraser.

  • WebKit.xcworkspace/contents.xcworkspacedata:

Tools:

Reviewed by Simon Fraser.

Add a new iOS Simulator application which uses WKWebView to implement a basic browser, and which
can serve as a test harness for WebKit UI tests.

Also add a basic media playback test which verifies that a <video> element will begin playing in
fullscreen on an iPhone device, but will play inline on an iPad device.

  • Makefile: Add MobileMiniBrowser as a Module for iOS builds.
  • MobileMiniBrowser/Configurations/Base.xcconfig: Added.
  • MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Added.
  • MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig: Added.
  • MobileMiniBrowser/Makefile: Added.
  • MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Added.
  • MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h: Added.
  • MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Added.

(-[AppDelegate application:didFinishLaunchingWithOptions:]):
(-[AppDelegate applicationWillResignActive:]):
(-[AppDelegate applicationDidEnterBackground:]):
(-[AppDelegate applicationWillEnterForeground:]):
(-[AppDelegate applicationDidBecomeActive:]):
(-[AppDelegate applicationWillTerminate:]):

  • MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json: Added.
  • MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Added.
  • MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Added.
  • MobileMiniBrowser/MobileMiniBrowser/Info.plist: Added.
  • MobileMiniBrowser/MobileMiniBrowser/TabViewController.h: Added.
  • MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Added.

(-[TabViewController dealloc]):
(-[TabViewController viewDidLoad]):
(-[TabViewController observeValueForKeyPath:ofObject:change:context:]):
(-[TabViewController tableView:cellForRowAtIndexPath:]):
(-[TabViewController tableView:numberOfRowsInSection:]):
(-[TabViewController numberOfSectionsInTableView:]):
(-[TabViewController tableView:canEditRowAtIndexPath:]):
(-[TabViewController tableView:canMoveRowAtIndexPath:]):
(-[TabViewController tableView:commitEditingStyle:forRowAtIndexPath:]):
(-[TabViewController tableView:didSelectRowAtIndexPath:]):

  • MobileMiniBrowser/MobileMiniBrowser/WebViewController.h: Added.
  • MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Added.

(-[WebViewController viewDidLoad]):
(-[WebViewController didReceiveMemoryWarning]):
(-[WebViewController reload:]):
(-[WebViewController goBack:]):
(-[WebViewController goForward:]):
(-[WebViewController urlFieldEditingBegan:]):
(-[WebViewController navigateTo:]):
(-[WebViewController showTabs:]):
(-[WebViewController selectWebViewAtIndex:]):
(-[WebViewController removeWebViewAtIndex:]):
(-[WebViewController addWebView]):
(-[WebViewController createWebView]):
(-[WebViewController removeWebView:]):
(-[WebViewController setCurrentWebView:]):
(-[WebViewController webView:didFailNavigation:withError:]):
(-[WebViewController observeValueForKeyPath:ofObject:change:context:]):

  • MobileMiniBrowser/MobileMiniBrowser/main.m: Added.

(main):

  • MobileMiniBrowser/MobileMiniBrowserUITests/Info.plist: Added.
  • MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m: Added.

(-[MobileMiniBrowserUITests setUp]):
(-[MobileMiniBrowserUITests tearDown]):
(-[MobileMiniBrowserUITests testBasicVideoPlayback]):

4:25 PM Changeset in webkit [205056] by Alan Bujtas
  • 3 edits
    2 adds in trunk

ASSERT_NOT_REACHED() is touched in WebCore::minimumValueForLength
​https://bugs.webkit.org/show_bug.cgi?id=125781
<rdar://problem/27684457>

Reviewed by Simon Fraser.

Source/WebCore:

RenderTableSection::calcRowLogicalHeight misused minimumValueForLength to fallback to 0 for non-fixed values.
While this patch fixes the assertion, the table section code needs works to support calc values. See webkit.org/b/161273.

Test: fast/table/assert-on-min-max-content-values.html

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):

LayoutTests:

  • fast/table/assert-on-min-max-content-values-expected.txt: Added.
  • fast/table/assert-on-min-max-content-values.html: Added.
4:10 PM Changeset in webkit [205055] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Rebaseline fast/dom/focus-contenteditable.html for ios-simulator after r205044.

Unreviewed test gardening.

  • platform/ios-simulator-wk2/fast/dom/focus-contenteditable-expected.txt:
3:52 PM Changeset in webkit [205054] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

webkit-queues queue-status page should should list more recent statuses
​https://bugs.webkit.org/show_bug.cgi?id=161220

Reviewed by Daniel Bates.

  • QueueStatusServer/handlers/queuestatus.py:

(QueueStatus._fetch_statuses): Increase the number of recent statuses from 15 to 50.

3:41 PM Changeset in webkit [205053] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r204987): fast/canvas-composite-* tests are now flaky assertion failures
<​https://webkit.org/b/161259>

Reviewed by Joseph Pecoraro.

Fix a blunder where HTMLCanvasElement::memoryCost() wasn't forwarding the inquiry
to ImageBuffer but HTMLCanvasElement::externalMemoryCost() was.

This fixes flaky "externalMemorySize() <= extraMemorySize()" assertions on debug bots.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::memoryCost):

3:16 PM Changeset in webkit [205052] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Get rid of NetworkResourceLoader::sendAbortingOnFailure
​https://bugs.webkit.org/show_bug.cgi?id=161267

Reviewed by Dan Bernstein.

NetworkResourceLoader::sendAbortingOnFailure sends an IPC message, and if IPC::Connection::send returns false,
it will abort the network resource load.

IPC::Connection::send will only return false if the connection is invalid, and when it becomes invalidated the
connection client member function "didClose" is invoked. For the network process, this will call abort on all outstanding
network loads.

Auditing all the sendAbortingOnFailure call sites, shows that none of them can be called with an invalid connection,
so replace sendAbortingOnFailure with send.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveResponse):
This is a NetworkLoadClient function which won't be called if the load has been aborted.

(WebKit::NetworkResourceLoader::didReceiveBuffer):
Ditto.

(WebKit::NetworkResourceLoader::didFinishLoading):
Ditto. Also, update a call to sendBufferMaybeAborting to sendBuffer.

(WebKit::NetworkResourceLoader::willSendRedirectedRequest):
This is another NetworkLoadClient function.

(WebKit::NetworkResourceLoader::bufferingTimerFired):
The buffering timer is stopped when abort() is called.

(WebKit::NetworkResourceLoader::sendBuffer):
Rename this from sendBufferMaybeAborting. It has three call sites:

  • didReceiveBuffer and didFinishLoading are both NetworkLoadClient functions.
  • didRetrieveCacheEntry is called from didFinishLoading (a NetworkLoadClient function) and from the completion function of retrieveCacheEntry, which has an early return for when the loader has been aborted.

(WebKit::NetworkResourceLoader::didRetrieveCacheEntry):
This is called from the retrieveCacheEntry completion function, which has an early return for when the loader has been aborted.

(WebKit::NetworkResourceLoader::dispatchWillSendRequestForCacheEntry):
Ditto.

(WebKit::NetworkResourceLoader::sendAbortingOnFailure): Deleted.

  • NetworkProcess/NetworkResourceLoader.h:
3:07 PM Changeset in webkit [205051] by jiewen_tan@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed, update expectations of tests that can either crash or timeout on iOS simulator WK1

  • platform/ios-simulator-wk1/TestExpectations:
2:46 PM Changeset in webkit [205050] by akling@apple.com
  • 9 edits in trunk

The :enabled/:disabled selectors should only match elements that can be disabled.
<​https://webkit.org/b/161255>

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/html/semantics/selectors/pseudo-classes/disabled-expected.txt:

Source/WebCore:

Per the HTML spec, only the following elements can be actually disabled:

button, input, select, textarea, optgroup, option, menuitem, fieldset

Since HTMLOutputElement inherits from HTMLFormControlElement, it had some
misguided ideas about being disableable. This was causing it to get matched
by :enabled and :disabled selectors.

Test: imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/disabled.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):

  • css/SelectorCheckerTestFunctions.h:

(WebCore::matchesDisabledPseudoClass):
(WebCore::matchesEnabledPseudoClass): Renamed from isEnabled/isDisabled. Now only allows
:enabled and :disabled selectors to match elements that are actually disableable.

  • html/HTMLElement.h:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::canBeActuallyDisabled):
(WebCore::HTMLElement::isActuallyDisabled): Added supporting functions for the aforementioned selectors.

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::parseAttribute): Don't care about disabled state
changes in elements that are not disableable in the first place.

2:41 PM Changeset in webkit [205049] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skipping imported/w3c/web-platform-tests/html/dom/interfaces.html on Mac.
​https://bugs.webkit.org/show_bug.cgi?id=161142

Unreviewed test gardening.

  • platform/mac/TestExpectations:
2:34 PM Changeset in webkit [205048] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

REGRESSION(r204028): Fix unused-but-set-variable warning in generated JSNavigator.cpp
​https://bugs.webkit.org/show_bug.cgi?id=161252

Reviewed by Ryosuke Niwa.

Improve support for [Conditional] with overloaded operations in the IDL.

No new tests, updated bindings tests.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GeneratePropertiesHashTable):
(getConditionalForFunctionConsideringOverloads):
(GenerateOverloadedFunctionOrConstructor):
(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestGlobalObject.cpp:

(WebCore::jsTestGlobalObjectInstanceFunctionEnabledAtRuntimeOperation): Deleted.

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionConditionalOverload1):
(WebCore::jsTestObjPrototypeFunctionConditionalOverload2):
(WebCore::jsTestObjPrototypeFunctionConditionalOverload):
(WebCore::jsTestObjPrototypeFunctionEnabledAtRuntimeOperation): Deleted.
(WebCore::jsTestObjConstructorFunctionOverloadedMethod1): Deleted.

  • bindings/scripts/test/TestObj.idl:
2:23 PM Changeset in webkit [205047] by jiewen_tan@apple.com
  • 5 edits
    3 adds in trunk/LayoutTests

Unreviewed, rebase iOS simulator WK1 tables tests

  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator-wk1/tables/mozilla/bugs/bug30559-expected.txt:
  • platform/ios-simulator-wk1/tables/mozilla_expected_failures/bugs/bug128876-expected.txt:
  • platform/ios-simulator-wk1/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.
  • platform/ios-simulator-wk1/tables/mozilla_expected_failures/bugs/bug8499-expected.txt:
  • platform/ios-simulator-wk1/transitions/default-timing-function-expected.txt: Added.
2:20 PM Changeset in webkit [205046] by Joseph Pecoraro
  • 6 edits
    1 copy
    2 adds in trunk/Source/WebInspectorUI

Web Inspector: Add protocol version for iOS 10
​https://bugs.webkit.org/show_bug.cgi?id=161266
<rdar://problem/28036594>

Rubber-stamped by Brian Burg.

  • Localizations/en.lproj/localizedStrings.js:

Update missing localized strings.

  • Versions/Inspector-iOS-10.0.json: Added.

Protocol for iOS 10.

  • UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js:
  • UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
  • UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
  • UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
  • UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js:

Re-generate the legacy backend commands files.

2:14 PM Changeset in webkit [205045] by ggaren@apple.com
  • 2 edits in trunk/Source/bmalloc

2016-08-26 Geoffrey Garen <​ggaren@apple.com>

Unreviewed build fix.

Fix the CMake build.

  • CMakeLists.txt:
2:11 PM Changeset in webkit [205044] by Beth Dakin
  • 4 edits
    2 adds in trunk

charactersAroundPosition can be wrong because it crosses editing boundaries
​https://bugs.webkit.org/show_bug.cgi?id=161215
-and corresponding-
rdar://problem/27933564

Reviewed by Ryosuke Niwa.

Source/WebCore:

charactersAroundPosition() should not cross editing boundaries. This patch fixes
that by making nextCharacterBoundaryInDirection() take an
EditingBoundaryCrossingRule parameter to pass onto VisiblePosition::next() and
VisiblePosition::previous().

  • editing/VisibleUnits.cpp:

(WebCore::nextCharacterBoundaryInDirection):
(WebCore::positionOfNextBoundaryOfGranularity):
(WebCore::charactersAroundPosition):

LayoutTests:

New test.

  • editing/mac/spelling/accept-candidate-without-crossing-editing-boundary-expected.txt: Added.
  • editing/mac/spelling/accept-candidate-without-crossing-editing-boundary.html: Added.

This test is going back to its pre-https://trac.webkit.org/changeset/195078 state.
That change caused this test to have a different layout because it caused more
layouts to happen. Now that we don’t allow the call to charactersAroundPosition()
to cross editing boundaries, those layouts don’t happen, and we have the old
behavior back.

  • platform/mac/fast/dom/focus-contenteditable-expected.txt:
1:59 PM Changeset in webkit [205043] by Joseph Pecoraro
  • 5 edits
    1 add in trunk/Source/WebInspectorUI

Web Inspector: Show IndexedDB Database/ObjectStore/Index data in a details sidebar
​https://bugs.webkit.org/show_bug.cgi?id=161180
<rdar://problem/28003417>

Reviewed by Brian Burg.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Main.html:

New strings and file.

  • UserInterface/Base/Main.js:

(WebInspector.contentLoaded):
Instantiate the global details sidebar.

  • UserInterface/Views/StorageTabContentView.js:

(WebInspector.StorageTabContentView):
Include the new details sidebar in the Storage tab.

  • UserInterface/Controllers/StorageManager.js:

(WebInspector.StorageManager.prototype._addIndexedDBDatabasesIfNeeded.processKeyPath):
Use the protocol generated types.

  • UserInterface/Views/IndexedDatabaseDetailsSidebarPanel.js: Added.

(WebInspector.IndexedDatabaseDetailsSidebarPanel):
(WebInspector.IndexedDatabaseDetailsSidebarPanel.prototype.inspect):
(WebInspector.IndexedDatabaseDetailsSidebarPanel.prototype.layout):
(WebInspector.IndexedDatabaseDetailsSidebarPanel.prototype._keyPathString):
Show the sidebar for an IndexedDatabase, ObjectStore, or Index.
Show each section if we can based on the objects we have.

1:59 PM Changeset in webkit [205042] by Joseph Pecoraro
  • 3 edits
    2 adds in trunk

Web Inspector: Test and address issues in IndexedDB.requestData
​https://bugs.webkit.org/show_bug.cgi?id=161178
<rdar://problem/28002467>

Reviewed by Brian Burg.

Source/WebCore:

Test: inspector/indexeddb/requestData.html

  • inspector/InspectorIndexedDBAgent.cpp:

(idbKeyRangeFromKeyRange):
Parsing was too strict. "lower" and "upper" keys are optional.

(WebCore::DataLoader::execute):
Ensure the skip count is passed forward.

LayoutTests:

  • inspector/indexeddb/requestData-expected.txt: Added.
  • inspector/indexeddb/requestData.html: Added.
1:59 PM Changeset in webkit [205041] by Joseph Pecoraro
  • 9 edits
    2 adds in trunk

Web Inspector: Provide a way to clear an IndexedDB object store
​https://bugs.webkit.org/show_bug.cgi?id=161167
<rdar://problem/27996932>

Reviewed by Brian Burg.

Source/JavaScriptCore:

  • inspector/protocol/IndexedDB.json:

Cleanup the protocol file.

Source/WebCore:

Test: inspector/indexeddb/clearObjectStore.html

  • inspector/InspectorIndexedDBAgent.cpp:

Make the transaction for clearing an object store readwrite
instead of readonly, and activate it.

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js:

"Clear object store".

  • UserInterface/Controllers/StorageManager.js:

(WebInspector.StorageManager.prototype.clearObjectStore):
Provide a wrapper for clearing an object store.

  • UserInterface/Views/IndexedDatabaseObjectStoreContentView.js:

(WebInspector.IndexedDatabaseObjectStoreContentView):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype.get navigationItems):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype._clearButtonClicked):
Add a navigation button on ObjectStore content views to clear the object store.

LayoutTests:

  • inspector/indexeddb/clearObjectStore-expected.txt: Added.
  • inspector/indexeddb/clearObjectStore.html: Added.
1:59 PM Changeset in webkit [205040] by Joseph Pecoraro
  • 3 edits
    4 adds in trunk/LayoutTests

Web Inspector: Test IndexedDB.requestDatabase
​https://bugs.webkit.org/show_bug.cgi?id=161122

Reviewed by Brian Burg.

  • inspector/indexeddb/requestDatabase-expected.txt: Added.
  • inspector/indexeddb/requestDatabase.html: Added.

New tests.

  • inspector/indexeddb/deleteDatabaseNamesWithSpace.html:
  • inspector/indexeddb/requestDatabaseNames.html:

Share code.

  • inspector/indexeddb/resources/utilities.js: Added.

(deleteDatabaseNames):
(createEmptyDatabase):
(createDatabaseWithStores):
Helpers that can be used by each test.

1:59 PM Changeset in webkit [205039] by Joseph Pecoraro
  • 5 edits in trunk/LayoutTests

Web Inspector: Modernize inspector/indexeddb tests
​https://bugs.webkit.org/show_bug.cgi?id=161113

Reviewed by Brian Burg.

  • inspector/indexeddb/deleteDatabaseNamesWithSpace-expected.txt:
  • inspector/indexeddb/deleteDatabaseNamesWithSpace.html:
  • inspector/indexeddb/requestDatabaseNames-expected.txt:
  • inspector/indexeddb/requestDatabaseNames.html:
1:54 PM Changeset in webkit [205038] by jiewen_tan@apple.com
  • 5 edits
    21 adds in trunk/LayoutTests

Unreviewed, rebase iOS simulator WK1 http tests

  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator-wk1/animations/trigger-container-scroll-simple-expected.txt: Added.
  • platform/ios-simulator-wk1/css2.1/t040302-c61-ex-len-00-b-a-expected.txt:
  • platform/ios-simulator-wk1/http/tests/dom/window-open-about-blank-and-access-document-expected.txt: Added.
  • platform/ios-simulator-wk1/http/tests/dom/window-open-about-uppercase-blank-and-access-document-expected.txt: Added.
  • platform/ios-simulator-wk1/http/tests/dom/window-open-about-webkit-org-and-access-document-expected.txt: Added.
  • platform/ios-simulator-wk1/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/proper-open-window-upgrades-expected.txt: Added.
  • platform/ios-simulator-wk1/http/tests/security/cross-origin-modal-dialog-base-expected.txt: Added.
  • platform/ios-simulator-wk1/http/tests/security/insecure-geolocation-expected.txt: Added.
  • platform/ios-simulator-wk1/http/tests/security/mixedContent/insecure-form-in-main-frame-expected.txt: Added.
  • platform/ios-simulator-wk1/http/tests/security/mixedContent/insecure-script-in-data-iframe-in-main-frame-blocked-expected.txt: Added.
  • platform/ios-simulator-wk1/http/tests/security/mixedContent/insecure-xhr-sync-in-main-frame-expected.txt: Added.
  • platform/ios-simulator-wk1/http/tests/security/mixedcontent-geolocation-block-insecure-content-expected.txt: Added.
  • platform/ios-simulator-wk1/http/tests/security/mixedcontent-geolocation-expected.txt: Added.
  • platform/ios-simulator-wk1/http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox-expected.txt: Added.
  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-simulator/TestExpectations:
1:35 PM Changeset in webkit [205037] by Chris Dumez
  • 7 edits in trunk

Calling crossOriginWindow.toString() should not be allowed
​https://bugs.webkit.org/show_bug.cgi?id=161225

Reviewed by Andreas Kling.

Source/WebCore:

Calling crossOriginWindow.toString() should not be allowed:

In WebKit, we were printing a security error in the console but
returning "[object Window]" anyway.

In Firefox and Chrome, it throws an exception.

No new tests, updated existing test.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess):

LayoutTests:

Update existing tests to reflect the behavior change.

  • http/tests/security/cross-frame-access-custom-expected.txt:
  • http/tests/security/cross-frame-access-custom.html:
  • http/tests/security/cross-frame-access-object-setPrototypeOf-expected.txt:
  • http/tests/security/cross-frame-access-object-setPrototypeOf.html:
1:33 PM Changeset in webkit [205036] by mitz@apple.com
  • 4 edits in trunk

[Cocoa] Infinite recursion calling -charValue on a WKNSNumber
​https://bugs.webkit.org/show_bug.cgi?id=161258

Reviewed by Anders Carlsson.

Source/WebKit2:

  • Shared/Cocoa/WKNSNumber.mm:

(-[WKNSNumber charValue]): Override this…
(-[WKNSNumber boolValue]): …not this.

Tools:

  • TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm:

(TestWebKitAPI::TEST):

1:29 PM Changeset in webkit [205035] by commit-queue@webkit.org
  • 19 edits in trunk

Web Inspector: Some CSS selectors in the UI aren't escaped
​https://bugs.webkit.org/show_bug.cgi?id=151378

Patch by Devin Rousso <Devin Rousso> on 2016-08-26
Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

Change ElementData from sending a className string to using an array of
classes, allowing for proper escaping of each class value.

  • inspector/protocol/OverlayTypes.json:

Source/WebCore:

No new tests, but logic and results of existing tests updated:

  • inspector/dom/content-node-region-info.html:
  • inspector/dom/content-node-region-info-expected.txt:
  • inspector/dom/highlightNode-expected.txt:
  • inspector/dom/highlightSelector.html:
  • inspector/dom/highlightSelector-expected.txt:
  • inspector/InspectorOverlay.cpp:

(WebCore::buildObjectForElementData):

  • inspector/InspectorOverlayPage.css:

(.pseudo-type):
(.tag-name): Deleted.

  • inspector/InspectorOverlayPage.js:

(_createElementTitle):

Source/WebInspectorUI:

  • UserInterface/Base/DOMUtilities.js:

(WebInspector.displayNameForNode): Deleted.
(WebInspector.linkifyNodeReference):
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.

  • UserInterface/Models/DOMNode.js:

(WebInspector.DOMNode.prototype.get escapedIdSelector):
(WebInspector.DOMNode.prototype.get escapedClassSelector):
(WebInspector.DOMNode.prototype.get displayName):
(WebInspector.DOMNode.prototype.appropriateSelectorFor):
Rework escaping of ids and class names into separate public functions using CSS.escape.

  • UserInterface/Views/CSSStyleDeclarationSection.js:

(WebInspector.CSSStyleDeclarationSection.prototype.refresh):
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.

  • UserInterface/Views/DOMTreeDataGridNode.js:

(WebInspector.DOMTreeDataGridNode.prototype._createNameCellDocumentFragment):
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.

  • UserInterface/Views/DOMTreeElementPathComponent.js:

(WebInspector.DOMTreeElementPathComponent):
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.

  • UserInterface/Views/LayerTreeDataGridNode.js:

(WebInspector.LayerTreeDataGridNode.prototype.set layer):
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.

  • UserInterface/Views/VisualStyleSelectorSection.js:

(WebInspector.VisualStyleSelectorSection.prototype.update):
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.

LayoutTests:

  • inspector/dom/content-node-region-info.html:
  • inspector/dom/content-node-region-info-expected.txt:

Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.

  • inspector/dom/highlightNode-expected.txt:
  • inspector/dom/highlightSelector.html:
  • inspector/dom/highlightSelector-expected.txt:

Changed result to replace className with new classes array.

1:22 PM Changeset in webkit [205034] by Joseph Pecoraro
  • 5 edits in trunk/Source/JavaScriptCore

Web Inspector: ScriptProfilerAgent and HeapAgent should do less work when frontend disconnects
​https://bugs.webkit.org/show_bug.cgi?id=161213
<rdar://problem/28017986>

Reviewed by Brian Burg.

  • inspector/agents/InspectorHeapAgent.cpp:

(Inspector::InspectorHeapAgent::willDestroyFrontendAndBackend):
Don't take a final snapshot when disconnecting.

  • inspector/agents/InspectorScriptProfilerAgent.cpp:

(Inspector::InspectorScriptProfilerAgent::willDestroyFrontendAndBackend):
(Inspector::InspectorScriptProfilerAgent::stopSamplingWhenDisconnecting):

  • inspector/agents/InspectorScriptProfilerAgent.h:
  • runtime/SamplingProfiler.h:

Don't process samples when disconnecting.

1:22 PM Changeset in webkit [205033] by Joseph Pecoraro
  • 3 edits in trunk/Source/JavaScriptCore

Web Inspector: HeapProfiler/ScriptProfiler do not destruct safely when JSContext is destroyed
​https://bugs.webkit.org/show_bug.cgi?id=161027
<rdar://problem/27871349>

Reviewed by Mark Lam.

For JSContext inspection, when a frontend connects keep the target alive.
This means ref'ing the JSGlobalObject / VM when the first frontend
connects and deref'ing when the last frontend disconnects.

  • inspector/JSGlobalObjectInspectorController.h:
  • inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::globalObjectDestroyed):
(Inspector::JSGlobalObjectInspectorController::disconnectAllFrontends): Deleted.
Now that frontends keep the global object alive, when the global object
is destroyed that must mean that no frontends exist. Remove the now
stale code path.

(Inspector::JSGlobalObjectInspectorController::connectFrontend):
(Inspector::JSGlobalObjectInspectorController::disconnectFrontend):
Ref the target when the first frontend connects, deref when the last disconnects.

1:18 PM Changeset in webkit [205032] by ggaren@apple.com
  • 8 edits
    3 moves in trunk

Renamed XLarge* => Large*
​https://bugs.webkit.org/show_bug.cgi?id=161261

Reviewed by Andreas Kling.

XLarge is not a thing anymore: We just have Small and Large.

  • bmalloc.xcodeproj/project.pbxproj:
  • bmalloc/Heap.cpp:

(bmalloc::Heap::splitAndAllocate):
(bmalloc::Heap::tryAllocateLarge):
(bmalloc::Heap::shrinkLarge):
(bmalloc::Heap::deallocateLarge):

  • bmalloc/Heap.h:
  • bmalloc/LargeMap.cpp: Copied from Source/bmalloc/bmalloc/XLargeMap.cpp.

(bmalloc::LargeMap::remove):
(bmalloc::LargeMap::add):
(bmalloc::XLargeMap::remove): Deleted.
(bmalloc::XLargeMap::add): Deleted.

  • bmalloc/LargeMap.h: Copied from Source/bmalloc/bmalloc/XLargeMap.h.

(bmalloc::LargeMap::ranges):
(bmalloc::XLargeMap::ranges): Deleted.

  • bmalloc/LargeRange.h: Copied from Source/bmalloc/bmalloc/XLargeRange.h.

(bmalloc::LargeRange::LargeRange):
(bmalloc::LargeRange::operator<):
(bmalloc::canMerge):
(bmalloc::merge):
(bmalloc::LargeRange::split):
(bmalloc::XLargeRange::XLargeRange): Deleted.
(bmalloc::XLargeRange::operator<): Deleted.
(bmalloc::XLargeRange::split): Deleted.

  • bmalloc/VMHeap.cpp:

(bmalloc::VMHeap::tryAllocateLargeChunk):

  • bmalloc/VMHeap.h:
  • bmalloc/XLargeMap.cpp: Removed.
  • bmalloc/XLargeMap.h: Removed.
  • bmalloc/XLargeRange.h: Removed.
11:12 AM Changeset in webkit [205031] by Brent Fulgham
  • 3 edits in trunk/Source/WebCore

Crash when getting font bounding rect
​https://bugs.webkit.org/show_bug.cgi?id=161202
<rdar://problem/27986981>

Reviewed by Myles C. Maxfield.

We should never store GlyphData objects for later use, because they contain raw pointers to Font elements
contained in caches, and those font caches get periodically purged.

Instead, we should hold onto the ‘key’ representing the GlyphData, and simply ask the system for the
GlyphData the next time it is needed.

Tested by existing MathML tests under ASAN and GuardMalloc.

  • rendering/mathml/RenderMathMLToken.cpp:

(WebCore::RenderMathMLToken::RenderMathMLToken): Clean up constructors.
(WebCore::RenderMathMLToken::computePreferredLogicalWidths): Use keys to get correct GlyphData when needed.
(WebCore::RenderMathMLToken::updateMathVariantGlyph): Ditto.
(WebCore::RenderMathMLToken::firstLineBaseline): Ditto.
(WebCore::RenderMathMLToken::layoutBlock): Ditto.
(WebCore::RenderMathMLToken::paint): Ditto.
(WebCore::RenderMathMLToken::paintChildren): Ditto.

  • rendering/mathml/RenderMathMLToken.h:
11:09 AM Changeset in webkit [205030] by Chris Dumez
  • 9 edits in trunk

HTMLAreaElement's coords attributes parsing does not comply with the HTML specification
​https://bugs.webkit.org/show_bug.cgi?id=161216

Reviewed by Andreas Kling.

LayoutTests/imported/w3c:

Rebaseline W3C test now that all checks are passing. Chrome is also passing all the checks.

  • web-platform-tests/html/semantics/embedded-content/the-area-element/area-coords-expected.txt:

Source/WebCore:

HTMLAreaElement's coords attributes parsing does not comply with the HTML specification:

This patch aligns our parsing of this attribute with the specification and Chrome.

No new tests, rebaselined existing test.

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::HTMLAreaElement):
(WebCore::HTMLAreaElement::parseAttribute):
(WebCore::HTMLAreaElement::getRegion):

  • html/HTMLAreaElement.h:
  • html/parser/HTMLParserIdioms.cpp:

(WebCore::isHTMLSpaceOrDelimiter):
(WebCore::isNumberStart):
(WebCore::parseHTMLListOfOfFloatingPointNumberValuesInternal):
(WebCore::parseHTMLListOfOfFloatingPointNumberValues):
(WebCore::parseHTMLNonNegativeInteger): Deleted.

  • html/parser/HTMLParserIdioms.h:

LayoutTests:

Unskip web-platform-tests/html/semantics/embedded-content/the-area-element/area-coords.html
as it is now passing and not longer crashing in debug builds.

11:00 AM Changeset in webkit [205029] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Fix the !ENABLE(WEB_SOCKETS) build
​https://bugs.webkit.org/show_bug.cgi?id=161251

Reviewed by Alex Christensen.

  • page/SocketProvider.h:
10:58 AM Changeset in webkit [205028] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebCore

Fix the !ENABLE(WEB_TIMING) build
​https://bugs.webkit.org/show_bug.cgi?id=161250

Reviewed by Alex Christensen.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didFinishLoading):

  • loader/cache/CachedResourceLoader.h:

(WebCore::CachedResourceLoader::resourceTimingInformation):

10:37 AM Changeset in webkit [205027] by Yusuke Suzuki
  • 3 edits
    1 add in trunk

[ES6] newPromiseCapabilities should check the given argument is constructor
​https://bugs.webkit.org/show_bug.cgi?id=161226

Reviewed by Mark Lam.

JSTests:

The arrow function should not be a constructor. So the error should be raised.

  • stress/new-promise-capabilities-requires-constructor.js: Added.

(shouldThrow):

Source/JavaScriptCore:

Use @isConstructor.

  • builtins/PromiseOperations.js:
10:36 AM Changeset in webkit [205026] by Chris Dumez
  • 40 edits in trunk

Trying to access cross-origin Location properties should throw a SecurityError
​https://bugs.webkit.org/show_bug.cgi?id=161248

Reviewed by Alex Christensen.

Source/WebCore:

Trying to access cross-origin Location properties should throw a SecurityError:

Firefox and Chrome already throw. However, WebKit was logging an error message
and returning undefined.

No new tests, updated existing tests.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::throwSecurityError):

  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::getOwnPropertySlotDelegate):

LayoutTests:

Update existing tests to reflect behavior change.

  • http/tests/plugins/cross-frame-object-access-expected.txt:
  • http/tests/plugins/resources/cross-frame-object-access.html:
  • http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny.html:
  • http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-parent-same-origin-deny.html:
  • http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny.html:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html:
  • http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt:
  • http/tests/security/cross-frame-access-child-explicit-domain-expected.txt:
  • http/tests/security/cross-frame-access-custom-expected.txt:
  • http/tests/security/cross-frame-access-getOwnPropertyDescriptor-expected.txt:
  • http/tests/security/cross-frame-access-history-get-expected.txt:
  • http/tests/security/cross-frame-access-history-get-override-expected.txt:
  • http/tests/security/cross-frame-access-location-get-expected.txt:
  • http/tests/security/cross-frame-access-location-get-override-expected.txt:
  • http/tests/security/cross-frame-access-parent-explicit-domain-expected.txt:
  • http/tests/security/cross-frame-access-port-expected.txt:
  • http/tests/security/cross-frame-access-protocol-expected.txt:
  • http/tests/security/cross-frame-access-protocol-explicit-domain-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
  • http/tests/security/location-cross-origin-expected.txt:
  • http/tests/security/location-cross-origin.html:
  • http/tests/security/resources/cross-frame-access.js:

(canGet):
(canGetDescriptor):
(canCall):
(toString):

  • http/tests/security/sandboxed-iframe-blocks-access-from-parent-expected.txt:
  • http/tests/security/xss-DENIED-defineProperty-expected.txt:
  • http/tests/security/xss-DENIED-defineProperty.html:
  • http/tests/security/xssAuditor/block-does-not-leak-location-expected.txt:
  • http/tests/security/xssAuditor/block-does-not-leak-location.html:
  • http/tests/security/xssAuditor/full-block-script-tag-cross-domain-expected.txt:
  • http/tests/security/xssAuditor/full-block-script-tag-cross-domain.html:
  • http/tests/security/xssAuditor/resources/utilities.js:

(checkIfFrameLocationMatchesSrcAndCallDone):

10:36 AM Changeset in webkit [205025] by pvollan@apple.com
  • 3 edits in trunk/Source/WebCore

[Win] Warning fixes.
​https://bugs.webkit.org/show_bug.cgi?id=161241

Reviewed by Brent Fulgham.

MSVC warns about potential use of uninitialized variables.

  • accessibility/AXObjectCache.cpp:
  • css/parser/CSSParserValues.cpp:
10:13 AM Changeset in webkit [205024] by eric.carlson@apple.com
  • 13 edits
    4 adds in trunk

[MediaStream] Add support for OverConstrainedErrorEvent
​https://bugs.webkit.org/show_bug.cgi?id=161199
<rdar://problem/28011819>

Reviewed by Jer Noble.

Source/WebCore:

Test: fast/events/constructors/overconstrained-error-event-constructor.html

  • CMakeLists.txt:
  • DerivedSources.make:
  • Modules/mediastream/OverconstrainedErrorEvent.h: Added.

(WebCore::OverconstrainedErrorEvent::~OverconstrainedErrorEvent):
(WebCore::OverconstrainedErrorEvent::create):
(WebCore::OverconstrainedErrorEvent::createForBindings):
(WebCore::OverconstrainedErrorEvent::error):
(WebCore::OverconstrainedErrorEvent::eventInterface):
(WebCore::OverconstrainedErrorEvent::OverconstrainedErrorEvent):

  • Modules/mediastream/OverconstrainedErrorEvent.idl: Added.
  • WebCore.xcodeproj/project.pbxproj: Add new files.
  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue): Add OverconstrainedErrorEvent converter.

  • bindings/js/JSDictionary.h:
  • dom/EventNames.in: Add OverconstrainedErrorEvent.

LayoutTests:

  • fast/events/constructors/overconstrained-error-event-constructor-expected.txt: Added.
  • fast/events/constructors/overconstrained-error-event-constructor.html: Added.
  • js/dom/global-constructors-attributes-expected.txt: Updated.
  • platform/gtk/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
10:05 AM Changeset in webkit [205023] by keith_miller@apple.com
  • 10 edits in trunk

toString called on proxies returns incorrect tag
​https://bugs.webkit.org/show_bug.cgi?id=161111

Reviewed by Benjamin Poulain.

This patch adds a new Method table function toStringName. This function
is used by Object.prototype.toString to create the string tag that it
inserts. Right now it only changes the stringification of proxy objects.
In future patches I plan to make it work for other classes of objects as
well.

  • runtime/ClassInfo.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::toStringName):

  • runtime/JSCell.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::toStringName):

  • runtime/JSObject.h:
  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncToString):

  • runtime/ProxyObject.cpp:

(JSC::ProxyObject::toStringName):

  • runtime/ProxyObject.h:
10:02 AM Changeset in webkit [205022] by barraclough@apple.com
  • 4 edits
    2 deletes in trunk/Source/bmalloc

bmalloc: speed up the lock slow path
​https://bugs.webkit.org/show_bug.cgi?id=161058

Unreviewed rollout - this caused regressions <rdar://problem/28026089>.

  • bmalloc.xcodeproj/project.pbxproj:
  • bmalloc/ScopeExit.h: Removed.
  • bmalloc/StaticMutex.cpp:

(bmalloc::StaticMutex::lockSlowCase):

  • bmalloc/StaticMutex.h:

(bmalloc::StaticMutex::init):

  • bmalloc/ThreadSwitch.h: Removed.
9:54 AM Changeset in webkit [205021] by Csaba Osztrogonác
  • 19 edits in trunk

Fix the ENABLE(WEBASSEMBLY) build on Linux
​https://bugs.webkit.org/show_bug.cgi?id=161197

Reviewed by Mark Lam.

Source/JavaScriptCore:

  • CMakeLists.txt:
  • b3/B3Common.cpp:

(JSC::B3::shouldDumpIR):

  • shell/CMakeLists.txt:
  • wasm/JSWASMModule.h:
  • wasm/WASMB3IRGenerator.cpp:

(JSC::WASM::toB3Op):

  • wasm/WASMB3IRGenerator.h:
  • wasm/WASMFormat.h:
  • wasm/WASMFunctionParser.h:
  • wasm/WASMModuleParser.cpp:

(JSC::WASM::WASMModuleParser::parseFunctionTypes):

  • wasm/WASMModuleParser.h:
  • wasm/WASMParser.h:
  • wasm/WASMPlan.cpp:
  • wasm/WASMPlan.h:
  • wasm/WASMSections.cpp:

Source/WTF:

  • wtf/Platform.h:

Tools:

  • Scripts/build-jsc:
9:50 AM Changeset in webkit [205020] by pvollan@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[Win] Compile fix.
​https://bugs.webkit.org/show_bug.cgi?id=161235

Reviewed by Brent Fulgham.

YarrPattern::errorMessage has inconsistent dll linkage.

  • yarr/YarrPattern.h:
9:50 AM Changeset in webkit [205019] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.50.0.7

New tag.

9:41 AM Changeset in webkit [205018] by commit-queue@webkit.org
  • 7 edits in trunk

The annotation-xml element does not need to be behave as an mrow
​https://bugs.webkit.org/show_bug.cgi?id=161230

Patch by Frederic Wang <​fwang@igalia.com> on 2016-08-26
Reviewed by Manuel Rego Casasnovas.

Source/WebCore:

In r204779, MathMLAnnotationElement was made a MathMLRowElement just because the
annotation-xml element is generating a RenderMathMLRow. This later point is actually not
needed since annotation-xml is just a wrapper for foreign elements and so does not need to
handle special MathML features like operator spacing or stretching. We can thus move back
MathMLAnnotationElement to a generic MathMLPresentationElement and instead make the
annotation-xml element generate a generic RenderMathMLBlock renderer.

No new tests, semantics annotations already covered by existing tests.

  • mathml/MathMLAnnotationElement.cpp: Replace RenderMathMLRow.h with RenderMathMLBlock.h

(WebCore::MathMLAnnotationElement::MathMLAnnotationElement): Inherit from
MathMLPresentationElement instead of MathMLRowElement.
(WebCore::MathMLAnnotationElement::createElementRenderer): Make annotation-xml create a
RenderMathMLBlock instead of a RenderMathMLRow.
(WebCore::MathMLAnnotationElement::attributeChanged): Inherit from MathMLPresentationElement
instead of MathMLRowElement.

  • mathml/MathMLAnnotationElement.h: Ditto.

LayoutTests:

  • platform/efl/accessibility/math-foreign-content-expected.txt: Remove the AXGroup from the

test expectation, which that was used for annotation-xml.

  • platform/gtk/accessibility/math-foreign-content-expected.txt: Ditto.
  • platform/mac/accessibility/math-foreign-content-expected.txt: Ditto.
9:36 AM Changeset in webkit [205017] by clopez@igalia.com
  • 2 edits in trunk/Tools

[GTK] run-gtk-tests should use the driver environment for checking the accessibility bus
​https://bugs.webkit.org/show_bug.cgi?id=161149

Reviewed by Carlos Garcia Campos.

Add a new function for waiting for the accesibility bus. It sets
the test environment variables before starting the GLib mainloop.
And restores the previous environment after it has finished.
It also adds a timeout (5 seconds) to abort in case it has not
been able to detect the accesibility bus before the timeout expires.

  • Scripts/run-gtk-tests:

(TestRunner):
(TestRunner._wait_for_accessibility_bus):
(TestRunner._wait_for_accessibility_bus.timeout_accessibility_bus):
(TestRunner._start_accessibility_daemons):
(TestRunner._get_tests_from_google_test_suite): Run this command also with the driver test environment.

9:35 AM Changeset in webkit [205016] by pvollan@apple.com
  • 2 edits in trunk/Tools

[Win] Warning fix.
​https://bugs.webkit.org/show_bug.cgi?id=161236

Reviewed by Brent Fulgham.

The & operator in the Test struct has no body.

  • TestWebKitAPI/Tests/WTF/Vector.cpp:

(TestWebKitAPI::TEST):

9:33 AM Changeset in webkit [205015] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Typo fix after r56209
​https://bugs.webkit.org/show_bug.cgi?id=161246

Reviewed by Gyuyoung Kim.

  • page/FrameView.cpp:

(WebCore::FrameView::adjustMediaTypeForPrinting):

9:32 AM Changeset in webkit [205014] by clopez@igalia.com
  • 8 edits in trunk/Tools

[GTK] run-gtk-tests should use webkitpy.port.gtk and webkitpy.port.xvfbdriver
​https://bugs.webkit.org/show_bug.cgi?id=160736

Reviewed by Carlos Garcia Campos.

This plugs run-gtk-tests into the webkitpy testing infrastructure.
As a benefit of this, run-gtk-tests now can be executed over any of
the existing supported gtk test display servers (xvfb, weston-over-xvfb,
or native xorg). A new command line switch --wayland is added for
run-gtk-tests.

  • Scripts/run-gtk-tests:

(TestRunner.init): Remove the --display command line switch, its not longer useful.
Add a --wayland command line switch.
(TestRunner._start_accessibility_daemons):
(TestRunner):
(TestRunner.init):
(TestRunner._run_xvfb): Deleted.
(TestRunner._create_driver):
(TestRunner._setup_testing_environment): Delete the environment variable definitions that
are now done by driver._setup_environ_for_test().
(TestRunner._tear_down_testing_environment):

  • Scripts/webkitpy/port/driver.py:

(Driver.init): Define self._server_name in the constructor of the base class.
It is used by several functions, so it makes sense to store once the value here.
(Driver._setup_environ_for_test): Factorize setting the environment for a given test.
(Driver._start): Get the environment from self._setup_environ_for_test()

  • Scripts/webkitpy/port/driver_unittest.py:

(DriverTest):
(DriverTest.test_setup_environ_for_test): Add unittest for driver._setup_environ_for_test()

  • Scripts/webkitpy/port/gtk.py: Move the inspection of the env var USE_NATIVE_XDISPLAY to the constructor.

(GtkPort.init):
(GtkPort._driver_class):

  • Scripts/webkitpy/port/westondriver.py: Define and use self._setup_environ_for_test()

(WestonDriver._setup_environ_for_test):
(WestonDriver._start):

  • Scripts/webkitpy/port/xorgdriver.py: Define and use self._setup_environ_for_test()

(XorgDriver._setup_environ_for_test):
(XorgDriver._start):

  • Scripts/webkitpy/port/xvfbdriver.py: Define and use self._setup_environ_for_test()

(XvfbDriver._setup_environ_for_test):
(XvfbDriver._start):

9:04 AM Changeset in webkit [205013] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Reinstate flakiness expectations for viewport tests, as they are still flaky.
​https://bugs.webkit.org/show_bug.cgi?id=153110

  • platform/ios-simulator-wk2/TestExpectations:
7:04 AM Changeset in webkit [205012] by Csaba Osztrogonác
  • 5 edits in trunk

[EFL][GTK] REGRESSION(204877): Fix the clean build
​https://bugs.webkit.org/show_bug.cgi?id=161240

Reviewed by Carlos Garcia Campos.

Source/WebKit2:

  • Scripts/generate-forwarding-headers.pl: Added back multiple include-path support. (removed by r183389)

Tools:

  • WebKitTestRunner/PlatformEfl.cmake:
  • WebKitTestRunner/PlatformGTK.cmake:
6:29 AM Changeset in webkit [205011] by pvollan@apple.com
  • 15 edits in trunk/Source/WebCore

[Win] Warning fixes.
​https://bugs.webkit.org/show_bug.cgi?id=161077

Reviewed by Brent Fulgham.

  • css/CSSGrammar.y.includes:
  • css/RuleFeature.cpp:

(WebCore::makeAttributeSelectorKey):

  • editing/TextIterator.cpp:

(WebCore::SearchBuffer::SearchBuffer):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::textToFragment):

  • html/MediaElementSession.h:
  • platform/URL.cpp:
  • platform/graphics/ca/GraphicsLayerCA.cpp:
  • platform/network/HTTPParsers.cpp:

(WebCore::parseHTTPHeader):

  • rendering/InlineIterator.h:

(WebCore::InlineIterator::clear):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::FlexBoxIterator::reset):

  • rendering/RenderText.cpp:

(WebCore::RenderText::secureText):

  • rendering/mathml/RenderMathMLToken.cpp:

(WebCore::mathVariant):

  • style/InlineTextBoxStyle.cpp:

(WebCore::visualOverflowForDecorations):

  • xml/XPathGrammar.y:
3:54 AM Changeset in webkit [205010] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

EWS should indicate which bot processed the patch
​https://bugs.webkit.org/show_bug.cgi?id=161222

Reviewed by Daniel Bates.

  • QueueStatusServer/handlers/statusbubble.py:

(StatusBubble._build_bubble): Display the bot id in status bubble. Also removed "Started processing" message since
after bug fix of 161223, bots send the "Started processing patch" message and it would be displayed in Recent messages.
Also added "Started processing patch" message to progress_statuses.
I might consider displaying bot id in other statuses as well later on.

1:46 AM Changeset in webkit [205009] by Gyuyoung Kim
  • 2 edits in trunk/Source/WebKit2

Unreviewed EFL build fix since r204996.

Patch by Gyuyoung Kim <​gyuyoung.kim@navercorp.com> on 2016-08-26

  • UIProcess/efl/WebPageProxyEfl.cpp:

(WebKit::WebPageProxy::editorStateChanged):
(WebKit::WebPageProxy::setThemePath):
(WebKit::WebPageProxy::confirmComposition):
(WebKit::WebPageProxy::setComposition):
(WebKit::WebPageProxy::cancelComposition):

1:04 AM Changeset in webkit [205008] by nael.ouedraogo@crf.canon.fr
  • 27 edits in trunk

Make custom constructors consistent with generated bindings code
​https://bugs.webkit.org/show_bug.cgi?id=159550

Reviewed by Youenn Fablet.

Add assertion to check DOMConstructorObject* passed in ExecState is not null.
Rename throwConstructorDocumentUnavailableError to throwConstructorScriptExecutionContextUnavailableError since
ScriptExecutionContext is not necessarily a Document.
Modify error message in case of argument error to be consistent with generated binding code: replace calls to
throwVMError with calls to throwConstructorScriptExecutionContextUnavailableError and throwArgumentTypeError.

No new test required. Modify tests and tests expectations to align with new error messages.

Source/WebCore:

  • bindings/js/JSAudioContextCustom.cpp:

(WebCore::constructJSAudioContext):

  • bindings/js/JSBlobCustom.cpp:

(WebCore::constructJSBlob):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::throwConstructorScriptExecutionContextUnavailableError):

  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMConstructor.h:

(WebCore::JSBuiltinConstructor<JSClass>::callConstructor):

  • bindings/js/JSDOMFormDataCustom.cpp:

(WebCore::constructJSDOMFormData):

  • bindings/js/JSDataCueCustom.cpp:

(WebCore::constructJSDataCue):

  • bindings/js/JSFileCustom.cpp:

(WebCore::constructJSFile):

  • bindings/js/JSHTMLElementCustom.cpp:

(WebCore::constructJSHTMLElement):

  • bindings/js/JSMediaSessionCustom.cpp:

(WebCore::constructJSMediaSession):

  • bindings/js/JSMutationObserverCustom.cpp:

(WebCore::constructJSMutationObserver):

  • bindings/js/JSReadableStreamPrivateConstructors.cpp:

(WebCore::constructJSReadableStreamDefaultReader):

  • bindings/js/JSWorkerCustom.cpp:

(WebCore::constructJSWorker):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallbackImplementation):
(NativeToJSValue):
(GenerateHashTableValueArray):
(GenerateConstructorDefinition):

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructorConstructor::construct):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::construct):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorNamedConstructor::construct):

  • bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::JSTestNodeConstructor::construct):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::construct):

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::constructJSTestOverloadedConstructors1):
(WebCore::constructJSTestOverloadedConstructors2):
(WebCore::constructJSTestOverloadedConstructors3):
(WebCore::constructJSTestOverloadedConstructors4):
(WebCore::constructJSTestOverloadedConstructors5):

  • bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:

(WebCore::constructJSTestOverloadedConstructorsWithSequence1):
(WebCore::constructJSTestOverloadedConstructorsWithSequence2):

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefsConstructor::construct):

LayoutTests:

  • fast/dom/MutationObserver/mutation-observer-constructor-expected.txt:
  • fast/files/file-constructor-expected.txt:
  • fast/files/file-constructor.html:
12:36 AM Changeset in webkit [205007] by Gyuyoung Kim
  • 2 edits in trunk/Tools

[EFL] Change homepage url to www.ewebkit.org on MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=161184

Reviewed by Carlos Garcia Campos.

  • MiniBrowser/efl/main.c: Set www.ewebkit.org.
12:34 AM Changeset in webkit [205006] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.7.7.1/Source

Versioning.

12:32 AM Changeset in webkit [205005] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.7.7.1

New tag.

Aug 25, 2016:

11:55 PM Changeset in webkit [205004] by Carlos Garcia Campos
  • 5 edits in trunk/Source

Unreviewed. Fix GTK+ build after r204986 and r204996.

Source/WebCore:

  • page/DOMWindow.idl:

Source/WebKit2:

  • Platform/IPC/unix/ConnectionUnix.cpp:

(IPC::Connection::willSendSyncMessage):
(IPC::Connection::didReceiveSyncReply):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::drawPagesForPrinting):

10:33 PM Changeset in webkit [205003] by aakash_jain@apple.com
  • 4 edits in trunk/Tools

ews queues should update status server when they start processing patch
​https://bugs.webkit.org/show_bug.cgi?id=161223

Reviewed by Daniel Bates.

  • Scripts/webkitpy/tool/commands/queues.py:

(AbstractReviewQueue.process_work_item): Update status server that the bot started processing the patch.

  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

(EarlyWarningSystemTest._default_expected_logs): Updated the unit test accordingly.

  • Scripts/webkitpy/tool/commands/queues_unittest.py:

(StyleQueueTest.test_style_queue_with_style_exception): Same.
(test_style_queue_with_watch_list_exception): Same.
(test_non_valid_patch): Same.

7:16 PM Changeset in webkit [205002] by jiewen_tan@apple.com
  • 2 edits
    15 adds in trunk/LayoutTests

Unreviewed, rebase iOS simulator WK1 imported/w3c tests

  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator-wk1/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-cross-origin-expected.txt: Added.
  • platform/ios-simulator-wk1/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-navigation-samedoc-expected.txt: Added.
  • platform/ios-simulator-wk1/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/scroll-frag-percent-encoded-expected.txt: Added.
  • platform/ios-simulator-wk1/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/unloading-documents/001-expected.txt: Added.
  • platform/ios-simulator-wk1/imported/w3c/web-platform-tests/html/browsers/windows/noreferrer-window-name-expected.txt: Added.
6:53 PM Changeset in webkit [205001] by commit-queue@webkit.org
  • 2 edits
    407 adds in trunk/LayoutTests

[iOS Simulator] Rebaseline many tests under LayoutTests/svg/ for ios-simulator and enable them for testing
​https://bugs.webkit.org/show_bug.cgi?id=161166

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2016-08-25
Reviewed by Simon Fraser.

  • platform/ios-simulator/TestExpectations:
  • platform/ios-simulator/svg/W3C-I18N: Added.
  • platform/ios-simulator/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-direction-ltr-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/painting-marker-05-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/painting-marker-06-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-52-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/color-prof-01-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/color-prop-02-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/color-prop-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/coords-coord-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/coords-coord-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/coords-units-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/interact-events-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/interact-order-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/interact-order-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/interact-order-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/linking-a-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/linking-a-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/linking-a-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/linking-a-04-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/linking-a-05-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/linking-a-07-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/masking-path-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/masking-path-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/masking-path-05-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/painting-fill-05-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/painting-stroke-07-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-10-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-13-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-14-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-15-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/render-elems-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/render-elems-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/render-elems-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/script-handle-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/script-handle-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/script-handle-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/script-handle-04-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-cond-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-frag-04-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-group-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-group-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-image-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-image-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-image-04-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-image-05-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-image-06-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-image-07-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-image-08-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-image-09-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-image-10-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/styling-css-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/styling-css-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/styling-css-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/styling-css-05-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/styling-css-06-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-align-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-align-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-align-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-align-04-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-align-05-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-align-06-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-align-08-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-deco-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-path-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-text-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-text-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-text-04-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-text-06-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-text-07-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-text-08-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-tref-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-ws-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-ws-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/batik: Added.
  • platform/ios-simulator/svg/batik/text: Added.
  • platform/ios-simulator/svg/batik/text/longTextOnPath-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/smallFonts-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textAnchor-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textAnchor2-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textAnchor3-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textDecoration-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textDecoration2-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textEffect-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textEffect2-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textEffect3-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textFeatures-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textGlyphOrientationHorizontal-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textLayout-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textLayout2-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textLength-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textOnPath-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textOnPath2-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textOnPath3-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textOnPathSpaces-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textPCDATA-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textPosition-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textPosition2-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textProperties-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textProperties2-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textStyles-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/verticalText-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/verticalTextOnPath-expected.txt: Added.
  • platform/ios-simulator/svg/text/selection-background-color-expected.txt: Added.
  • platform/ios-simulator/svg/text/small-fonts-2-expected.txt: Added.
  • platform/ios-simulator/svg/text/small-fonts-3-expected.txt: Added.
  • platform/ios-simulator/svg/text/small-fonts-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-align-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-align-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-align-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-align-04-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-align-05-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-align-06-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-altglyph-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-deco-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-fill-opacity-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-fonts-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-fonts-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-gradient-positioning-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-hkern-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-intro-05-t-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-midpoint-split-bug-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-path-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-path-middle-align-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-spacing-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-text-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-text-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-text-04-t-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-text-05-t-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-text-06-t-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-text-07-t-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-text-08-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-tref-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-tselect-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-tselect-02-f-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-tspan-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-viewbox-rescale-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-vkern-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-ws-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-ws-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/text/tspan-dynamic-positioning-expected.txt: Added.
5:57 PM Changeset in webkit [205000] by Simon Fraser
  • 2 edits in trunk/LayoutTests

js/regress/polymorphic-put-by-id.html does not exist.

  • platform/ios-simulator-wk2/TestExpectations:
5:49 PM Changeset in webkit [204999] by jiewen_tan@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed, rebase iOS simulator WK1 imported/mozilla tests

  • platform/ios-simulator-wk1/TestExpectations:
5:28 PM Changeset in webkit [204998] by achristensen@apple.com
  • 5 edits
    1 add in trunk

CMake build fix.

Source/JavaScriptCore:

  • ForwardingHeaders/JavaScriptCore/JSObjectRefPrivate.h: Added.

This is needed for the internal Windows build.

Source/WebKit:

  • PlatformMac.cmake:

Availability was spelled wrong, resulting in a missing header.

Tools:

  • DumpRenderTree/PlatformMac.cmake:
5:14 PM Changeset in webkit [204997] by jiewen_tan@apple.com
  • 2 edits
    3 adds in trunk/LayoutTests

Unreviewed, rebase iOS simulator WK1 imported/blink tests

  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator-wk1/imported/blink/fast/shapes/shape-outside-floats/shape-outside-negative-height-crash-width-expected.txt: Added.
4:09 PM Changeset in webkit [204996] by andersca@apple.com
  • 25 edits in trunk/Source/WebKit2

Replace all IPC message send flags with OptionSet
​https://bugs.webkit.org/show_bug.cgi?id=161211

Reviewed by Tim Horton.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didFailLoading):
(WebKit::NetworkResourceLoader::sendAbortingOnFailure):

  • NetworkProcess/NetworkResourceLoader.h:
  • Platform/IPC/Connection.cpp:

(IPC::WaitForMessageState::WaitForMessageState):
(IPC::Connection::sendMessage):
(IPC::Connection::sendSyncReply):
(IPC::Connection::waitForMessage):
(IPC::Connection::sendSyncMessage):
(IPC::Connection::sendSyncMessageFromSecondaryThread):
(IPC::Connection::waitForSyncReply):
(IPC::Connection::processIncomingMessage):

  • Platform/IPC/Connection.h:

(IPC::Connection::send):
(IPC::Connection::sendSync):
(IPC::Connection::waitForAndDispatchImmediately):

  • Platform/IPC/MessageSender.cpp:

(IPC::MessageSender::sendMessage):

  • Platform/IPC/MessageSender.h:

(IPC::MessageSender::send):
(IPC::MessageSender::sendSync):

  • Platform/IPC/mac/ConnectionMac.mm:

(IPC::Connection::open):
(IPC::Connection::willSendSyncMessage):
(IPC::Connection::didReceiveSyncReply):

  • PluginProcess/mac/PluginControllerProxyMac.mm:

(WebKit::PluginControllerProxy::setComplexTextInputState):

  • UIProcess/ChildProcessProxy.cpp:

(WebKit::ChildProcessProxy::sendMessage):
(WebKit::ChildProcessProxy::didFinishLaunching):

  • UIProcess/ChildProcessProxy.h:

(WebKit::ChildProcessProxy::send):
(WebKit::ChildProcessProxy::sendSync):

  • UIProcess/Databases/DatabaseProcessProxy.cpp:

(WebKit::DatabaseProcessProxy::getDatabaseProcessConnection):

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::getNetworkProcessConnection):

  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::getPluginProcessConnection):

  • UIProcess/WebEditCommandProxy.cpp:

(WebKit::WebEditCommandProxy::unapply):
(WebKit::WebEditCommandProxy::reapply):

  • UIProcess/WebPageProxy.cpp:

(WebKit::printingSendOptions):
(WebKit::WebPageProxy::preferencesDidChange):
(WebKit::WebPageProxy::sendMessage):
(WebKit::WebPageProxy::beginPrinting):
(WebKit::WebPageProxy::endPrinting):
(WebKit::WebPageProxy::computePagesForPrinting):
(WebKit::WebPageProxy::drawRectToImage):
(WebKit::WebPageProxy::drawPagesToPDF):
(WebKit::WebPageProxy::drawPagesForPrinting):
(WebKit::WebPageProxy::setMinimumLayoutSize): Deleted.
(WebKit::WebPageProxy::setAutoSizingShouldExpandToViewHeight): Deleted.
(WebKit::WebPageProxy::handleAlternativeTextUIResult): Deleted.

  • UIProcess/WebPageProxy.h:
  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::waitForDidUpdateViewState):

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::waitForDidUpdateViewState):

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::geometryDidChange):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::runBeforeUnloadConfirmPanel):
(WebKit::WebChromeClient::runJavaScriptAlert):
(WebKit::WebChromeClient::runJavaScriptConfirm):
(WebKit::WebChromeClient::runJavaScriptPrompt):
(WebKit::WebChromeClient::print):
(WebKit::WebChromeClient::exceededDatabaseQuota):
(WebKit::WebChromeClient::reachedApplicationCacheOriginQuota):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::createWithCoreMainFrame):
(WebKit::WebFrame::createSubframe):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::sendPostLayoutEditorStateIfNeeded):
(WebKit::WebPage::postSynchronousMessageForTesting):

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::flush):

4:02 PM Changeset in webkit [204995] by commit-queue@webkit.org
  • 11 edits in trunk

[JSC] Clean up the abstract interpreter for cos/sin/sqrt/fround/log
​https://bugs.webkit.org/show_bug.cgi?id=161181

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2016-08-25
Reviewed by Geoffrey Garen.

JSTests:

Extend the tests to constants.
Add no-argument cases where needed.

  • stress/arith-cos-on-various-types.js:
  • stress/arith-fround-on-various-types.js:
  • stress/arith-log-on-various-types.js:
  • stress/arith-sin-on-various-types.js:
  • stress/arith-sqrt-on-various-types.js:

Source/JavaScriptCore:

All the nodes are doing the exact same thing with a single
difference: how to process constants. I made that into a separate
function called from each node.

I also generalized the constant-to-number code of DoubleRep
to make it available for all those nodes.

  • dfg/DFGAbstractInterpreter.h:
  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeDoubleUnaryOpEffects):

  • runtime/JSCJSValue.cpp:

(JSC::JSValue::toNumberFromPrimitive):

  • runtime/JSCJSValue.h:
3:55 PM Changeset in webkit [204994] by Yusuke Suzuki
  • 40 edits
    2 copies
    12 adds
    2 deletes in trunk

[DFG][FTL] Implement ES6 Generators in DFG / FTL
​https://bugs.webkit.org/show_bug.cgi?id=152723

Reviewed by Filip Pizlo.

JSTests:

  • stress/generator-fib-ftl-and-array.js: Added.

(fib):

  • stress/generator-fib-ftl-and-object.js: Added.

(fib):

  • stress/generator-fib-ftl-and-string.js: Added.

(fib):

  • stress/generator-fib-ftl.js: Added.

(fib):

  • stress/generator-frame-empty.js: Added.

(shouldThrow):
(shouldThrow.fib):

  • stress/generator-reduced-save-point-put-to-scope.js: Added.

(shouldBe):
(gen):

  • stress/generator-transfer-register-beyond-mutiple-yields.js: Added.

(shouldBe):
(gen):

Source/JavaScriptCore:

This patch introduces DFG and FTL support for ES6 generators.
ES6 generator is compiled by the BytecodeGenerator. But at the last phase, BytecodeGenerator performs "generatorification" onto the unlinked code.
In BytecodeGenerator phase, we just emit op_yield for each yield point. And we don't emit any generator related switch, save, and resume sequences
here. Those are emitted by the generatorification phase.

So the graph is super simple! Before the generatorification, the graph looks like this.

op_enter -> ...... -> op_yield -> ..... -> op_yield -> ...

Roughly speaking, in the generatorification phase, we turn out which variables should be saved and resumed at each op_yield.
This is done by liveness analysis. After that, we convert op_yield to the sequence of "op_put_to_scope", "op_ret", and "op_get_from_scope".
op_put_to_scope and op_get_from_scope sequences are corresponding to the save and resume sequences. We set up the scope for the generator frame and
perform op_put_to_scope and op_get_from_scope onto it. The live registers are saved and resumed over the generator's next() calls by using this
special generator frame scope. And we also set up the global switch for the generator.

In the generatorification phase,

  1. We construct the BytecodeGraph from the unlinked instructions. This constructs the basic blocks, and it is used in the subsequent analysis.
  2. We perform the analysis onto the unlinked code. We extract the live variables at each op_yield.
  3. We insert the get_from_scope and put_to_scope at each op_yield. Which registers should be saved and resumed is offered by (2). Then, clip the op_yield themselves. And we also insert the switch_imm. The jump targets of this switch are just after this op_switch_imm and each op_yield point.

One interesting point is the try-range. We split the try-range at the op_yield point in BytecodeGenerator phase.
This drops the hacky thing that is introduced in [1].
If the try-range covers the resume sequences, the exception handler's use-registers are incorrectly transferred to the entry block.
For example,

handler uses r2

try-range

label:(entry block can jump here)

r1 = get_from_scope # resume sequence starts | use r2 is transferred to the entry block!
r2 = get_from_scope |
starts usual sequences |
... |

Handler's r2 use should be considered at the r1 = get_from_scope point.
Previously, we handle this edge case by treating op_resume specially in the liveness analysis[1].
To drop this workaround, we split the try-range not to cover this resume sequence.

handler uses r2

try-range

label:(entry block can jump here)

r1 = get_from_scope # resume sequence starts
r2 = get_from_scope
starts usual sequences try-range should start from here.
... |

OK. Let's show the detailed example.

  1. First, there is the normal bytecode sequence. Here, | represents the offsets, and [] represents the bytecodes.

bytecodes | [ ] | [ ] | [ ] | [ ] | [ ] | [ ] |
try-range <----------------------------------->

  1. When we emit the op_yield in the bytecode generator, we carefully split the try-range.

bytecodes | [ ] | [ ] | [op_yield] | [ ] | [ ] | [ ] |
try-range <-----------> <----------------->

  1. And in the generatorification phase, we insert the switch's jump target and save & resume sequences. And we also drop op_yield.

Insert save seq Insert resume seq
before op_yield. after op_yield's point.

v v

bytecodes | [ ] | [ ] | [op_yield] | [ ] | [ ] | [ ] |
try-range <-----------> <----------------->

|

Jump to here. Drop this op_yield.

  1. The final layout is the following.

bytecodes | [ ] | [ ][save seq][op_ret] | [resume seq] | [ ] | [ ] | [ ] |
try-range <-----------------------------> <---------------->


Jump to here.

The rewriting done by the BytecodeRewriter is executed in a batch manner. Since these modification changes the basic blocks and size of unlinked instructions,
BytecodeRewriter also performs the offset adjustment for UnlinkedCodeBlock. So, this rewriting is performed onto the BytecodeGraph rather than BytecodeBasicBlock.
The reason why we take this design is simple: we don't want to newly create the basic blocks and opcodes for this early phase like DFG. Instead, we perform the
modification and adjustment to the unlinked instructions and UnlinkedCodeBlock in a in-place manner.

Bytecode rewriting functionality is offered by BytecodeRewriter. BytecodeRewriter allows us to insert any bytecodes to any places
in a in-place manner. BytecodeRewriter handles the original bytecode offsets as labels. And you can insert bytecodes before and after
these labels. You can also insert any jumps to any places. When you insert jumps, you need to specify jump target with this labels.
These labels (original bytecode offsets) are automatically converted to the appropriate offsets by BytecodeRewriter.

After that phase, the data flow of the generator-saved-and-resumed-registers are explicitly represented by the get_from_scope and put_to_scope.
And the switch is inserted to represent the actual control flow for the generator. And op_yield is removed. Since we use the existing bytecodes (op_switch_imm, op_put_to_scope
op_ret, and op_get_from_scope), DFG and FTL changes are not necessary. This patch also drops data structures and implementations for the old generator,
op_resume, op_save implementations and GeneratorFrame.

Note that this patch does not leverage the recent multi entrypoints support in B3. After this patch is introduced, we will submit a new patch that leverages the multi
entrypoints for generator's resume and sees the performance gain.

Microbenchmarks related to generators show up to 2.9x improvements.

Baseline Patched

generator-fib 102.0116+-3.2880 34.9670+-0.2221 definitely 2.9174x faster
generator-sunspider-access-nsieve 5.8596+-0.0371 4.9051+-0.0720 definitely 1.1946x faster
generator-with-several-types 332.1478+-4.2425 124.6642+-2.4826 definitely 2.6643x faster

<geometric> 58.2998+-0.7758 27.7425+-0.2577 definitely 2.1015x faster

In ES6SampleBench's Basic, we can observe 41% improvement (Macbook Pro).

Baseline:

Geometric Mean Result: 133.55 ms +- 4.49 ms

Benchmark First Iteration Worst 2% Steady State
Air 54.03 ms +- 7.51 ms 29.06 ms +- 3.13 ms 2276.59 ms +- 61.17 ms
Basic 30.18 ms +- 1.86 ms 18.85 ms +- 0.45 ms 2851.16 ms +- 41.87 ms

Patched:

Geometric Mean Result: 121.78 ms +- 3.96 ms

Benchmark First Iteration Worst 2% Steady State
Air 52.09 ms +- 6.89 ms 29.59 ms +- 3.16 ms 2239.90 ms +- 54.60 ms
Basic 29.28 ms +- 1.46 ms 16.26 ms +- 0.66 ms 2025.15 ms +- 38.56 ms

[1]: ​https://bugs.webkit.org/show_bug.cgi?id=159281

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • builtins/GeneratorPrototype.js:

(globalPrivate.generatorResume):

  • bytecode/BytecodeBasicBlock.cpp:

(JSC::BytecodeBasicBlock::shrinkToFit):
(JSC::BytecodeBasicBlock::computeImpl):
(JSC::BytecodeBasicBlock::compute):
(JSC::isBranch): Deleted.
(JSC::isUnconditionalBranch): Deleted.
(JSC::isTerminal): Deleted.
(JSC::isThrow): Deleted.
(JSC::linkBlocks): Deleted.
(JSC::computeBytecodeBasicBlocks): Deleted.

  • bytecode/BytecodeBasicBlock.h:

(JSC::BytecodeBasicBlock::isEntryBlock):
(JSC::BytecodeBasicBlock::isExitBlock):
(JSC::BytecodeBasicBlock::leaderOffset):
(JSC::BytecodeBasicBlock::totalLength):
(JSC::BytecodeBasicBlock::offsets):
(JSC::BytecodeBasicBlock::successors):
(JSC::BytecodeBasicBlock::index):
(JSC::BytecodeBasicBlock::addSuccessor):
(JSC::BytecodeBasicBlock::BytecodeBasicBlock):
(JSC::BytecodeBasicBlock::addLength):
(JSC::BytecodeBasicBlock::leaderBytecodeOffset): Deleted.
(JSC::BytecodeBasicBlock::totalBytecodeLength): Deleted.
(JSC::BytecodeBasicBlock::bytecodeOffsets): Deleted.
(JSC::BytecodeBasicBlock::addBytecodeLength): Deleted.

  • bytecode/BytecodeGeneratorification.cpp: Added.

(JSC::BytecodeGeneratorification::BytecodeGeneratorification):
(JSC::BytecodeGeneratorification::graph):
(JSC::BytecodeGeneratorification::yields):
(JSC::BytecodeGeneratorification::enterPoint):
(JSC::BytecodeGeneratorification::storageForGeneratorLocal):
(JSC::GeneratorLivenessAnalysis::GeneratorLivenessAnalysis):
(JSC::GeneratorLivenessAnalysis::computeDefsForBytecodeOffset):
(JSC::GeneratorLivenessAnalysis::computeUsesForBytecodeOffset):
(JSC::GeneratorLivenessAnalysis::run):
(JSC::BytecodeGeneratorification::run):
(JSC::performGeneratorification):

  • bytecode/BytecodeGeneratorification.h: Copied from Source/JavaScriptCore/bytecode/BytecodeLivenessAnalysisInlines.h.
  • bytecode/BytecodeGraph.h: Added.

(JSC::BytecodeGraph::codeBlock):
(JSC::BytecodeGraph::instructions):
(JSC::BytecodeGraph::basicBlocksInReverseOrder):
(JSC::BytecodeGraph::blockContainsBytecodeOffset):
(JSC::BytecodeGraph::findBasicBlockForBytecodeOffset):
(JSC::BytecodeGraph::findBasicBlockWithLeaderOffset):
(JSC::BytecodeGraph::size):
(JSC::BytecodeGraph::at):
(JSC::BytecodeGraph::operator[]):
(JSC::BytecodeGraph::begin):
(JSC::BytecodeGraph::end):
(JSC::BytecodeGraph::first):
(JSC::BytecodeGraph::last):
(JSC::BytecodeGraph<Block>::BytecodeGraph):

  • bytecode/BytecodeList.json:
  • bytecode/BytecodeLivenessAnalysis.cpp:

(JSC::BytecodeLivenessAnalysis::BytecodeLivenessAnalysis):
(JSC::BytecodeLivenessAnalysis::computeDefsForBytecodeOffset):
(JSC::BytecodeLivenessAnalysis::computeUsesForBytecodeOffset):
(JSC::BytecodeLivenessAnalysis::getLivenessInfoAtBytecodeOffset):
(JSC::BytecodeLivenessAnalysis::computeFullLiveness):
(JSC::BytecodeLivenessAnalysis::computeKills):
(JSC::BytecodeLivenessAnalysis::dumpResults):
(JSC::BytecodeLivenessAnalysis::compute):
(JSC::isValidRegisterForLiveness): Deleted.
(JSC::getLeaderOffsetForBasicBlock): Deleted.
(JSC::findBasicBlockWithLeaderOffset): Deleted.
(JSC::blockContainsBytecodeOffset): Deleted.
(JSC::findBasicBlockForBytecodeOffset): Deleted.
(JSC::stepOverInstruction): Deleted.
(JSC::computeLocalLivenessForBytecodeOffset): Deleted.
(JSC::computeLocalLivenessForBlock): Deleted.
(JSC::BytecodeLivenessAnalysis::runLivenessFixpoint): Deleted.

  • bytecode/BytecodeLivenessAnalysis.h:
  • bytecode/BytecodeLivenessAnalysisInlines.h:

(JSC::isValidRegisterForLiveness):
(JSC::BytecodeLivenessPropagation<DerivedAnalysis>::stepOverInstruction):
(JSC::BytecodeLivenessPropagation<DerivedAnalysis>::computeLocalLivenessForBytecodeOffset):
(JSC::BytecodeLivenessPropagation<DerivedAnalysis>::computeLocalLivenessForBlock):
(JSC::BytecodeLivenessPropagation<DerivedAnalysis>::getLivenessInfoAtBytecodeOffset):
(JSC::BytecodeLivenessPropagation<DerivedAnalysis>::runLivenessFixpoint):

  • bytecode/BytecodeRewriter.cpp: Added.

(JSC::BytecodeRewriter::applyModification):
(JSC::BytecodeRewriter::execute):
(JSC::BytecodeRewriter::adjustJumpTargetsInFragment):
(JSC::BytecodeRewriter::insertImpl):
(JSC::BytecodeRewriter::adjustJumpTarget):

  • bytecode/BytecodeRewriter.h: Added.

(JSC::BytecodeRewriter::InsertionPoint::InsertionPoint):
(JSC::BytecodeRewriter::InsertionPoint::operator<):
(JSC::BytecodeRewriter::InsertionPoint::operator==):
(JSC::BytecodeRewriter::Insertion::length):
(JSC::BytecodeRewriter::Fragment::Fragment):
(JSC::BytecodeRewriter::Fragment::appendInstruction):
(JSC::BytecodeRewriter::BytecodeRewriter):
(JSC::BytecodeRewriter::insertFragmentBefore):
(JSC::BytecodeRewriter::insertFragmentAfter):
(JSC::BytecodeRewriter::removeBytecode):
(JSC::BytecodeRewriter::graph):
(JSC::BytecodeRewriter::adjustAbsoluteOffset):
(JSC::BytecodeRewriter::adjustJumpTarget):
(JSC::BytecodeRewriter::calculateDifference):

  • bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::handlerForIndex):
(JSC::CodeBlock::shrinkToFit):
(JSC::CodeBlock::valueProfileForBytecodeOffset):
(JSC::CodeBlock::livenessAnalysisSlow):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::isConstantRegisterIndex):
(JSC::CodeBlock::livenessAnalysis):
(JSC::CodeBlock::liveCalleeLocalsAtYield): Deleted.

  • bytecode/HandlerInfo.h:

(JSC::HandlerInfoBase::handlerForIndex):

  • bytecode/Opcode.h:

(JSC::isBranch):
(JSC::isUnconditionalBranch):
(JSC::isTerminal):
(JSC::isThrow):

  • bytecode/PreciseJumpTargets.cpp:

(JSC::getJumpTargetsForBytecodeOffset):
(JSC::computePreciseJumpTargetsInternal):
(JSC::computePreciseJumpTargets):
(JSC::recomputePreciseJumpTargets):
(JSC::findJumpTargetsForBytecodeOffset):

  • bytecode/PreciseJumpTargets.h:
  • bytecode/PreciseJumpTargetsInlines.h: Added.

(JSC::extractStoredJumpTargetsForBytecodeOffset):

  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::handlerForBytecodeOffset):
(JSC::UnlinkedCodeBlock::handlerForIndex):
(JSC::UnlinkedCodeBlock::applyModification):

  • bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedStringJumpTable::offsetForValue):
(JSC::UnlinkedCodeBlock::numCalleeLocals):

  • bytecode/VirtualRegister.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitComplexPopScopes):
(JSC::prepareJumpTableForStringSwitch):
(JSC::BytecodeGenerator::emitYieldPoint):
(JSC::BytecodeGenerator::emitSave): Deleted.
(JSC::BytecodeGenerator::emitResume): Deleted.
(JSC::BytecodeGenerator::emitGeneratorStateLabel): Deleted.
(JSC::BytecodeGenerator::beginGenerator): Deleted.
(JSC::BytecodeGenerator::endGenerator): Deleted.

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::generatorStateRegister):
(JSC::BytecodeGenerator::generatorValueRegister):
(JSC::BytecodeGenerator::generatorResumeModeRegister):
(JSC::BytecodeGenerator::generatorFrameRegister):

  • bytecompiler/NodesCodegen.cpp:

(JSC::FunctionNode::emitBytecode):

  • dfg/DFGOperations.cpp:
  • interpreter/Interpreter.cpp:

(JSC::findExceptionHandler):
(JSC::GetCatchHandlerFunctor::operator()):
(JSC::UnwindFunctor::operator()):

  • interpreter/Interpreter.h:
  • interpreter/InterpreterInlines.h: Copied from Source/JavaScriptCore/bytecode/PreciseJumpTargets.h.

(JSC::Interpreter::getOpcodeID):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_save): Deleted.
(JSC::JIT::emit_op_resume): Deleted.

  • llint/LowLevelInterpreter.asm:
  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseInner):
(JSC::Parser<LexerType>::parseGeneratorFunctionSourceElements):
(JSC::Parser<LexerType>::createGeneratorParameters):

  • parser/Parser.h:
  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL): Deleted.

  • runtime/CommonSlowPaths.h:
  • runtime/GeneratorFrame.cpp: Removed.

(JSC::GeneratorFrame::GeneratorFrame): Deleted.
(JSC::GeneratorFrame::finishCreation): Deleted.
(JSC::GeneratorFrame::createStructure): Deleted.
(JSC::GeneratorFrame::create): Deleted.
(JSC::GeneratorFrame::save): Deleted.
(JSC::GeneratorFrame::resume): Deleted.
(JSC::GeneratorFrame::visitChildren): Deleted.

  • runtime/GeneratorFrame.h: Removed.

(JSC::GeneratorFrame::locals): Deleted.
(JSC::GeneratorFrame::localAt): Deleted.
(JSC::GeneratorFrame::offsetOfLocals): Deleted.
(JSC::GeneratorFrame::allocationSizeForLocals): Deleted.

  • runtime/JSGeneratorFunction.h:
  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:

Source/WTF:

  • wtf/FastBitVector.h:

(WTF::FastBitVector::FastBitVector):

3:27 PM Changeset in webkit [204993] by jiewen_tan@apple.com
  • 5 edits
    13 adds in trunk/LayoutTests

Unreviewed, rebase iOS simulator WK1 fast tests

  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator-wk1/fast/attachment/attachment-select-on-click-expected.txt: Added.
  • platform/ios-simulator-wk1/fast/block/float/overhanging-tall-block-expected.txt: Added.
  • platform/ios-simulator-wk1/fast/clip/014-expected.txt: Added.
  • platform/ios-simulator-wk1/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/ios-simulator-wk1/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/ios-simulator-wk1/fast/events/ghostly-mousemoves-in-subframe-expected.txt: Added.
  • platform/ios-simulator-wk1/fast/forms/form-element-geometry-expected.txt:
  • platform/ios-simulator-wk1/fast/replaced/width100percent-textarea-expected.txt: Added.
  • platform/ios-simulator-wk1/fast/shadow-dom/trusted-event-scoped-flags-expected.txt: Added.
3:11 PM Changeset in webkit [204992] by commit-queue@webkit.org
  • 16 edits
    2 adds in trunk

TryGetById should have a ValueProfile so that it can predict its output type
​https://bugs.webkit.org/show_bug.cgi?id=160921

Patch by JF Bastien <​jfbastien@apple.com> on 2016-08-25
Reviewed by Saam Barati.

JSTests:

  • microbenchmarks/try-get-by-id-basic.js: Added.

(const.check):
(const.bench.f.const.fooPlusBar.createBuiltin):

  • microbenchmarks/try-get-by-id-polymorphic.js: Added.

(const.check):
(fooPlusBar.createBuiltin):
(bench):

Source/JavaScriptCore:

Add a ValueProfile to TryGetById, and make sure DFG picks it up.

A microbenchmark for perfectly predicted computation shows a 20%
runtime reduction with no hit if the prediction goes polymorphic.

  • bytecode/BytecodeList.json:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::finishCreation):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitTryGetById):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasHeapPrediction):

  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_try_get_by_id):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_try_get_by_id):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter.asm:

Source/WTF:

Add WTF_CONCAT to StdLibExtras.h

  • wtf/StdLibExtras.h:
3:11 PM Changeset in webkit [204991] by Simon Fraser
  • 2 edits
    2 adds in trunk/LayoutTests

WK1 Sierra: LayoutTests fast/html/marquee-scroll.html and fast/inline-block/003.html failing
rdar://problem/28017216

This test is sensitive to how WK1 does layouts as a result of updateScrollbars(),
giving different results in WK1 and WK1. Land Sierra results, and mark the test
as failing on earlier OS versions.

  • platform/mac-wk1/TestExpectations:
  • platform/mac-wk1/fast/inline-block/003-expected.txt: Added.
3:02 PM Changeset in webkit [204990] by achristensen@apple.com
  • 2 edits in trunk/Tools

Fix URLParserTest with GuardMalloc
​https://bugs.webkit.org/show_bug.cgi?id=161214
rdar://problem/28014390

Reviewed by Tim Horton.

The CString returned by String::utf8 was going out of scope before we were doing a string comparison on its data.
This just does the comparison of the CStrings instead to keep them in scope during the comparison.

  • TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::eq):
(TestWebKitAPI::checkURL):
(TestWebKitAPI::checkURLDifferences):
(TestWebKitAPI::s): Deleted.

3:01 PM Changeset in webkit [204989] by Wenson Hsieh
  • 6 edits in trunk

Dragging against the end of the inline media scrubber causes the media scrubber to hide
​https://bugs.webkit.org/show_bug.cgi?id=161207

Reviewed by Eric Carlson.

Source/WebCore:

Previously, we would re-enable behavior restrictions when firing an ended event. However, if the ended event is
caused by the user seeking to the end of the video, the media controls would be taken away from under the user.
To prevent this, we don't add the relevant behavior restrictions upon media ended if media was seeking before
firing the event.

Tweaked an existing WebKit API test to cover this change.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::addBehaviorRestrictionsOnEndIfNecessary):

  • html/HTMLMediaElement.h:
  • html/MediaElementSession.cpp:

(WebCore::MediaElementSession::canControlControlsManager):

Tools:

Tweaks an existing WebKit API test covering this behavior change. After some discussion, rather than hide media
controls in this case, we should actually continue showing them. This is because seeking due to user gestures
similar to "scrubbing" are indistinguishable from gestures that immediately seek to the end.

  • TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:

(TestWebKitAPI::TEST):

2:59 PM Changeset in webkit [204988] by bshafiei@apple.com
  • 9 edits in tags/Safari-603.1.3

Merge r204986. rdar://problem/28015060

2:57 PM Changeset in webkit [204987] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

REGRESSION: RELEASE_ASSERT in ResourceUsageThread::platformThreadBody when ASan is enabled
<​https://webkit.org/b/161203>
<rdar://problem/28011251>

Reviewed by Joseph Pecoraro.

  • page/cocoa/ResourceUsageThreadCocoa.mm:

(WebCore::ResourceUsageThread::platformThreadBody): Remove overly optimistic assertions about
"GC owned" memory never being higher than total malloc memory usage. This accounting is not
really exact and pretending otherwise will just lead to crashes.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::externalMemoryCost): Hook up HTMLCanvasElement to the ImageBuffer
helper for reporting external memory cost. This makes accounting slightly more correct.

2:48 PM Changeset in webkit [204986] by Chris Dumez
  • 9 edits in trunk

Regression(r203623): Breaks App Store application
​https://bugs.webkit.org/show_bug.cgi?id=161206
<rdar://problem/28015060>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add quirks for the App Store application so that we log an error message
when passing a Document node to Window.getComputedStyle() instead of
throwing an exception.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::getComputedStyle):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • platform/RuntimeApplicationChecks.h:
  • platform/RuntimeApplicationChecks.mm:

(WebCore::MacApplication::isAppStore):

LayoutTests:

Rebaseline existing test as the exception message is slightly different.

  • fast/dom/Window/getComputedStyle-missing-parameter-expected.txt:
  • fast/dom/Window/getComputedStyle-missing-parameter.html:
1:53 PM Changeset in webkit [204985] by andersca@apple.com
  • 19 edits
    1 delete in trunk/Source/WebKit2

Remove some more MessageRecorder gunk
​https://bugs.webkit.org/show_bug.cgi?id=161209

Reviewed by Tim Horton.

  • DatabaseProcess/DatabaseProcess.h:
  • DatabaseProcess/DatabaseToWebProcessConnection.h:
  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkProcess.h:
  • Platform/IPC/Connection.h:
  • Platform/IPC/ProcessType.h: Removed.
  • PluginProcess/PluginProcess.h:
  • PluginProcess/WebProcessConnection.h:
  • UIProcess/Databases/DatabaseProcessProxy.h:
  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/Plugins/PluginProcessProxy.h:
  • UIProcess/WebProcessProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Databases/WebToDatabaseProcessConnection.h:
  • WebProcess/Network/NetworkProcessConnection.h:
  • WebProcess/Plugins/PluginProcessConnection.h:
  • WebProcess/WebPage/WebInspector.h:
  • WebProcess/WebPage/WebInspectorUI.h:
  • WebProcess/WebProcess.h:
12:20 PM Changeset in webkit [204984] by jiewen_tan@apple.com
  • 2 edits
    3 adds in trunk/LayoutTests

Unreviewed, rebase iOS simulator WK1 fast/css tests

  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator-wk1/fast/css/layerZOrderCrash-expected.txt: Added.
  • platform/ios-simulator-wk1/fast/css/viewport-units-dynamic-expected.txt: Added.
  • platform/ios-simulator-wk1/fast/css/word-space-extra-expected.txt: Added.
12:18 PM Changeset in webkit [204983] by commit-queue@webkit.org
  • 12 edits
    2 adds in trunk

REGRESSION (r203378): [iOS] The PDF image is rendered stretched if a sub image of it is cached first
​https://bugs.webkit.org/show_bug.cgi?id=160617

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2016-08-25
Reviewed by Tim Horton.

Source/WebCore:

When caching only a sub-image of the PDF ensure the source rectangle starts
at the top-left of the cached sub-image rectangle. When drawing the cached
sub-image to the destination context ensure the destination rectangle is the
sub-image rectangle so no stretching or shrinking happens.

Test: fast/images/cached-clipped-pdf.html

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setCachedPDFImageEnabled): Deleted.

  • page/Settings.h:

(WebCore::Settings::isCachedPDFImageEnabled): Deleted.

  • page/Settings.in:

Change the boolean setting CachedPDFImageEnabled to be enum property and
rename it PDFImageCachingPolicy. Allow the "PDFImageCachingBelowMemoryLimit"
option to be available on a;; platforms. The "PDFImageCachingClipBoundsOnly"
option is added for testing purpose. If forces recaching the PDF with each
draw and it sets the cached image rectangle to the clipping rectangle.

  • platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::setPdfImageCachingPolicy): Take an enum instead of boolean.
(WebCore::cachedImageRect):
(WebCore::PDFDocumentImage::decodedSizeChanged): Enable PDFImageCachingBelowMemoryLimit
on all platforms.
(WebCore::PDFDocumentImage::updateCachedImageIfNeeded): Fix the source rectangle
when caching a sub-image of the PDF.
(WebCore::PDFDocumentImage::draw): Fix the destination rectangle when drawing
a sub-image to the destination context.
(WebCore::PDFDocumentImage::setCachedPDFImageEnabled): Deleted.

  • platform/graphics/cg/PDFDocumentImage.h:
  • rendering/RenderImage.cpp:

(WebCore::RenderImage::paintIntoRect):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setPDFImageCachingPolicy):
(WebCore::InternalSettings::setCachedPDFImageEnabled): Deleted.

  • testing/InternalSettings.h:
  • testing/InternalSettings.idl:

Change the internal setting CachedPDFImageEnabled to PDFImageCachingPolicy.

LayoutTests:

  • fast/images/cached-clipped-pdf-expected.html: Added.
  • fast/images/cached-clipped-pdf.html: Added.
  • fast/images/displaced-non-cached-pdf.html:
12:02 PM Changeset in webkit [204982] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Skipping imported/w3c/web-platform-tests/url/url-setters.html because it asserts.
​https://bugs.webkit.org/show_bug.cgi?id=161191

Unreviewed test gardening.

  • platform/ios-simulator-wk1/TestExpectations:
  • platform/mac-wk1/TestExpectations:
11:45 AM Changeset in webkit [204981] by bshafiei@apple.com
  • 3 edits in tags/Safari-603.1.3/Source/WebKit/mac

Merge r204974. rdar://problem/27959937

11:41 AM Changeset in webkit [204980] by Alan Bujtas
  • 3 edits
    2 adds in trunk

Infinite recursion crash in WebCore::RenderBlockFlow::layoutBlock
​https://bugs.webkit.org/show_bug.cgi?id=139474
<rdar://problem/27705190>

Reviewed by David Hyatt.

Source/WebCore:

We should just give up trying to avoid widow when the page is too small to break line.

Test: fast/multicol/assert-on-small-page-height-with-widow.html

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::clearShouldBreakAtLineToAvoidWidowIfNeeded):
(WebCore::RenderBlockFlow::adjustLinePositionForPagination):

  • rendering/RenderBlockFlow.h:

LayoutTests:

  • fast/multicol/assert-on-small-page-height-with-widow-expected.txt: Added.
  • fast/multicol/assert-on-small-page-height-with-widow.html: Added.
11:39 AM Changeset in webkit [204979] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

generate-js-builtins.py should generate platform independent files
​https://bugs.webkit.org/show_bug.cgi?id=161196

Reviewed by Mark Lam.

  • Scripts/generate-js-builtins.py: Files should be processed in fixed order.
11:36 AM Changeset in webkit [204978] by weinig@apple.com
  • 5 edits in trunk/Source/WebCore

Add the ability to override the implementation name of IDL enums and dictionaries
​https://bugs.webkit.org/show_bug.cgi?id=161185

Reviewed by Anders Carlsson.

  • bindings/scripts/CodeGenerator.pm:

(ProcessDocument):
Build a dictionary of IDL name -> implementation name overrides
for enums and dictionaries up front based on ImplementedAs extended
attribute.

(HasEnumImplementationNameOverride):
(GetEnumImplementationNameOverride):
(HasDictionaryImplementationNameOverride):
(GetDictionaryImplementationNameOverride):
Expose predicate and getter for name overrides.

  • bindings/scripts/CodeGeneratorJS.pm:

(GetEnumerationClassName):
(GetDictionaryClassName):
Use the override names as necessary.

  • bindings/scripts/test/TestObj.idl:

Add tests for enums and dictionaries with ImplementedAs extended
attributes.

11:23 AM Changeset in webkit [204977] by achristensen@apple.com
  • 10 edits in trunk/Source

Don't store networkLoadTiming in the disk cache
​https://bugs.webkit.org/show_bug.cgi?id=161161

Patch by Johan K. Jensen <​johan_jensen@apple.com> on 2016-08-25
Reviewed by Antti Koivisto.

Source/WebCore:

No functionality changed. So, no new tests.

  • platform/network/ResourceResponseBase.h:

(WebCore::ResourceResponseBase::encode):
(WebCore::ResourceResponseBase::decode):

Source/WebKit2:

  • NetworkProcess/cache/NetworkCacheStorage.h: Updated version to 10.
  • NetworkProcess/cache/NetworkCacheDecoder.h:
  • NetworkProcess/cache/NetworkCacheEncoder.h:
  • Platform/IPC/Decoder.h:
  • Platform/IPC/Encoder.h:

Added isIPCDecoder/isIPCEncoder static members.

Source/WTF:

  • wtf/Forward.h:

Remove Encode and Decode forward declarations.

11:22 AM Changeset in webkit [204976] by achristensen@apple.com
  • 21 edits
    17 adds in trunk

Update the Resource Timing implementation
​https://bugs.webkit.org/show_bug.cgi?id=161068

Patch by Johan K. Jensen <​johan_jensen@apple.com> on 2016-08-25
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Added W3C Web Platform Tests for Resource Timing.

  • web-platform-tests/resource-timing/OWNERS: Added.
  • web-platform-tests/resource-timing/SyntheticResponse.py: Added.

(main):

  • web-platform-tests/resource-timing/iframe-setdomain.sub.html: Added.
  • web-platform-tests/resource-timing/resource-timing.html: Added.
  • web-platform-tests/resource-timing/resource-timing.js: Added.

(testCases.test):
(test):
(runNextCase):
(assertInvariants):
(assertResourceEntryInvariants):
(canonicalize):
(createUniqueQueryArgument):
(getSyntheticUrl):
(initiateFetch):
(window.onload):

  • web-platform-tests/resource-timing/resources/resource_timing_test0.css: Added.

(div#resource_link_css):

  • web-platform-tests/resource-timing/resources/resource_timing_test0.html: Added.
  • web-platform-tests/resource-timing/resources/resource_timing_test0.js: Added.
  • web-platform-tests/resource-timing/resources/resource_timing_test0.png: Added.
  • web-platform-tests/resource-timing/resources/resource_timing_test0.xml: Added.
  • web-platform-tests/resource-timing/resources/webperftestharness.js: Added.

(wp_test):
(test_namespace):
(test_timing_order):
(test_timing_equals):
(sleep_milliseconds):
(test_true):
(test_equals):
(test_greater_than):
(test_greater_or_equals):

  • web-platform-tests/resource-timing/test_resource_timing.html: Added.
  • web-platform-tests/resource-timing/test_resource_timing.js: Added.

(setup):
(resolve):
(switch.):
(switch.case.string_appeared_here.xmlhttp.onload):
(switch.default.element.onload):
(onload):
(poll_for_stylesheet_load.inner):
(poll_for_stylesheet_load):
(resource_load):

Source/WebCore:

Tests: imported/w3c/web-platform-tests/resource-timing/resource-timing.html

imported/w3c/web-platform-tests/resource-timing/test_resource_timing.html

Update the Resource Timing implementation for better compatibility with the Resource Timing API spec.
Use LoadTiming for general timing information about a resources load timeline.
Mark timestamps for newly loaded resources as well as cached resources.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::startLoadingMainResource):
StartTime and fetchStart should be equal initially.

  • loader/LoadTiming.cpp:

(WebCore::LoadTiming::LoadTiming): Moved member initialization out. Removed constructor.

  • loader/LoadTiming.h:

(WebCore::LoadTiming::markStartTimeAndFetchStart):
Mark startTime and fetchStart simultaneously.

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::init):
Mark the start time of resources.

  • loader/ResourceLoader.h:

(WebCore::ResourceLoader::loadTiming):
Add LoadTiming info to handle a resources load timing.

  • loader/ResourceTimingInformation.cpp:

(WebCore::ResourceTimingInformation::addResourceTiming):

  • loader/ResourceTimingInformation.h:

Only pass in the URL from the ResourceRequest.
Pass LoadTiming instead of timestamps.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequestInternal):
Mark redirects.

(WebCore::SubresourceLoader::didFinishLoading):
Mark the responseEnd timestamp.
Add the ResourceEntry to the timeline before notifyDone is called.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadDone):
Mark timestamps for cached resources and use them instead of a cached LoadTiming.

  • loader/cache/CachedResourceLoader.h:

(WebCore::CachedResourceLoader::resourceTimingInformation):
Add ResourceTimingInformation getter so SubresourceLoader.cpp can add entries before callbacks.

  • page/Performance.cpp:

(WebCore::Performance::addResourceTiming):

  • page/Performance.h:

Update signature: URLs and LoadTiming instead of timestamps.

  • page/PerformanceResourceTiming.cpp:

(WebCore::PerformanceResourceTiming::PerformanceResourceTiming):
(WebCore::PerformanceResourceTiming::redirectStart):
(WebCore::PerformanceResourceTiming::redirectEnd):
(WebCore::PerformanceResourceTiming::fetchStart):
(WebCore::PerformanceResourceTiming::domainLookupStart):
(WebCore::PerformanceResourceTiming::domainLookupEnd):
(WebCore::PerformanceResourceTiming::connectStart):
(WebCore::PerformanceResourceTiming::connectEnd):
(WebCore::PerformanceResourceTiming::requestStart):
(WebCore::PerformanceResourceTiming::responseStart):
(WebCore::PerformanceResourceTiming::responseEnd):
(WebCore::PerformanceResourceTiming::resourceTimeToDocumentMilliseconds):

  • page/PerformanceResourceTiming.h:

Update signatures and properties to use LoadTiming.
Use LoadTiming’s redirectStart/End, fetchStart, responseStart/End.
Make sure dns and connection timestamps are in increasing order, even when cached.

  • page/PerformanceResourceTiming.idl:

Add responseStart.

LayoutTests:

Skip resource outside of resource-folder.
Mark one test as flaky (see bug 161088).

  • resources/testharnessreport.js:

(self.testRunner.add_completion_callback):
Updated completion callback to wait for any other completion callbacks
before finishing, so the Resource Timing tests can cleanup first.
Enabled the ResourceTiming runtime flag.

11:21 AM Changeset in webkit [204975] by jiewen_tan@apple.com
  • 13 edits
    1 add in trunk/LayoutTests

Unreviewed, rebase iOS simulator WK1 fast/multicol tests

  • platform/ios-simulator-wk1/fast/multicol/overflow-unsplittable-expected.txt: Added.
  • platform/ios-simulator-wk1/fast/multicol/pagination/BottomToTop-bt-expected.txt:
  • platform/ios-simulator-wk1/fast/multicol/pagination/BottomToTop-lr-expected.txt:
  • platform/ios-simulator-wk1/fast/multicol/pagination/BottomToTop-rl-expected.txt:
  • platform/ios-simulator-wk1/fast/multicol/pagination/BottomToTop-tb-expected.txt:
  • platform/ios-simulator-wk1/fast/multicol/pagination/RightToLeft-bt-expected.txt:
  • platform/ios-simulator-wk1/fast/multicol/pagination/RightToLeft-lr-expected.txt:
  • platform/ios-simulator-wk1/fast/multicol/pagination/RightToLeft-rl-dynamic-expected.txt:
  • platform/ios-simulator-wk1/fast/multicol/pagination/RightToLeft-rl-expected.txt:
  • platform/ios-simulator-wk1/fast/multicol/pagination/RightToLeft-tb-expected.txt:
  • platform/ios-simulator-wk1/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
  • platform/ios-simulator-wk1/fast/multicol/vertical-rl/column-rules-expected.txt:
  • platform/ios-simulator-wk1/fast/multicol/vertical-rl/float-paginate-complex-expected.txt:
11:12 AM Changeset in webkit [204974] by achristensen@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Re-export DOMException NSStrings after r204717
​https://bugs.webkit.org/show_bug.cgi?id=161200
<rdar://problem/27959937>

Patch by Anders Carlsson <​andersca@apple.com> on 2016-08-25
Reviewed by Alex Christensen.

  • DOM/ExceptionHandlers.mm:

(raiseDOMException):

  • WebKit.exp:
10:50 AM Changeset in webkit [204973] by Simon Fraser
  • 4 edits in trunk/LayoutTests

TestExpectations cleanup

Remove references to non-existant JS tests.

  • platform/ios-simulator/TestExpectations:
  • platform/mac-wk1/TestExpectations:
  • platform/mac/TestExpectations:
10:37 AM Changeset in webkit [204972] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Simplify createMouseEvent in DragController
​https://bugs.webkit.org/show_bug.cgi?id=161168

Reviewed by Dan Bernstein.

  • page/DragController.cpp:

(WebCore::createMouseEvent):

  • platform/DragData.cpp:

(WebCore::DragData::modifierKeyState): Deleted.

  • platform/DragData.h:
10:19 AM Changeset in webkit [204971] by dbates@webkit.org
  • 2 edits in trunk/Tools

Watch more things.

  • Scripts/webkitpy/common/config/watchlist:
10:08 AM Changeset in webkit [204970] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

DOMTokenList.value should be a stringifier attribute
​https://bugs.webkit.org/show_bug.cgi?id=161195

Reviewed by Darin Adler.

DOMTokenList.value should be a stringifier attribute:

No new tests, this change is not observable from the Web.

  • html/DOMTokenList.h:

(WebCore::DOMTokenList::toString): Deleted.

  • html/DOMTokenList.idl:
  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::iconSizes): Deleted.

  • html/HTMLLinkElement.h:
9:54 AM Changeset in webkit [204969] by dbates@webkit.org
  • 2 edits in trunk/Tools

Fix test failure on GTK Linux bots after <​http://trac.webkit.org/changeset/204695>
(​https://bugs.webkit.org/show_bug.cgi?id=148437)

Remove use of module File::Slurp as it is not part of the standard Perl 5 distribution
and is not installed on the GTK Linux bots.

  • Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:

(writeFileWithContent): Added.

9:42 AM Changeset in webkit [204968] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Rebaseline js/dom/global-constructors-attributes.html for mac-wk1 after r204935

Unreviewed test gardening.

  • platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
9:18 AM Changeset in webkit [204967] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skip svg/animations/animate-text-nested-transforms.html on ios-simulator

Unreviewed test gardening.

  • platform/ios-simulator-wk2/TestExpectations:
9:18 AM Changeset in webkit [204966] by pvollan@apple.com
  • 2 edits in trunk/Tools

[Win] run-api-tests is failing.
​https://bugs.webkit.org/show_bug.cgi?id=161140

Reviewed by Brent Fulgham.

Since the move constructor is called 3 more times on Windows, we will have 3 more destructor calls.

  • TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:

(TestWebKitAPI::TEST):

9:00 AM Changeset in webkit [204965] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Marking imported/w3c/web-platform-tests/url/url-setters.html as failing on mac and ios-simulator wk1.
​https://bugs.webkit.org/show_bug.cgi?id=161191

Unreviewed test gardening.

  • platform/ios-simulator-wk1/TestExpectations:
  • platform/mac-wk1/TestExpectations:
8:58 AM Changeset in webkit [204964] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Mac][cmake] Unreviewed speculative buildfix after r204852, just for fun.

  • PlatformMac.cmake:
8:46 AM Changeset in webkit [204963] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Rebaseline js/dom/global-constructors-attributes.html for mac after r204935

Unreviewed test gardening.

  • platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
8:42 AM Changeset in webkit [204962] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Marking gamepad/gamepad-timestamp.html as flaky on mac-wk2.
​https://bugs.webkit.org/show_bug.cgi?id=161148

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
8:39 AM Changeset in webkit [204961] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK][Threaded Compositor] Several flaky tests due to differences in scrollbars
​https://bugs.webkit.org/show_bug.cgi?id=160450

Reviewed by Michael Catanzaro.

The issue is that ThreadedCompositor::didChangeVisibleRect() dispatches the setVisibleContentsRect() call that
ends up in CompositingCoordinator. Since we're compositing the scrollbars as well, this visible contents rect
needs to encompass the complete width of the view, but that's not happening.
In case of non-overlay scrollbars, the scrollbars are clipped from this rect, but that doesn't prevent the
scrollbar overlay layers to be flushed and rendered. What does happen is that during tile creation in the
backing store the tiles that would normally intersect the visible rect of the view (if it were spanning over the
whole actual visible area) are sorted by distance to the visible rect.
The top of the two tiles used for the scrollbar is closer to the visible rect, so that gets created and filled
in first. The second tile is stored as pending for creation, and does get rendered at the point of the next
layer flush.

  • WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:

(WebKit::ThreadedCoordinatedLayerTreeHost::setVisibleContentsRect): Update the visible rect taking into account
the non-overlay scrollbars before passing it to the compositor.

2:53 AM Changeset in webkit [204960] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed test gardening.

Update test expectations on Windows for failing tests. These failures are tracked in
​https://bugs.webkit.org/show_bug.cgi?id=160447.

  • platform/win/TestExpectations:
12:45 AM Changeset in webkit [204959] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed test gardening.

Update test expectations on Windows for failing tests. These failures are tracked in
​https://bugs.webkit.org/show_bug.cgi?id=160447.

  • platform/win/TestExpectations:
12:04 AM Changeset in webkit [204958] by commit-queue@webkit.org
  • 9 edits
    1 add in trunk

NewRegexp should not prevent inlining
​https://bugs.webkit.org/show_bug.cgi?id=154808

Patch by Caio Lima <Caio Lima> on 2016-08-25
Reviewed by Geoffrey Garen.

JSTests:

Added test where functions with NewRegExp can be inlined right now.

  • stress/new-regex-inline.js: Added.

(assert):
(testRegexpInline):
(toInlineGlobal):
(withRegexp):
(inlineRegexpNotGlobal):
(toInlineRecursive):
(regexpContainsRecursive):

Source/JavaScriptCore:

In this patch we are changing the current mechanism used to represent
RegExp in NewRegexp nodes. We are changing the use of a index
pointing to RegExp in
CodeBlock->m_unlinkedCodeBlock->m_rareData->m_regexps as the operand of
NewRegexp node to RegExp address as the operand. To make sure that RegExp* is
pointing to a valid object, we are using m_graph.freezeStrong
mechanism.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasCellOperand):
(JSC::DFG::Node::hasRegexpIndex): Deleted.
(JSC::DFG::Node::regexpIndex): Deleted.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStrengthReductionPhase.cpp:

(JSC::DFG::StrengthReductionPhase::handleNode):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNewRegexp):

Note: See TracTimeline for information about the timeline view.