Timeline

Aug 27, 2016:

10:55 PM Changeset in webkit [205097] by commit-queue@webkit.org

• 8 edits in trunk

URLParser should parse relative URLs
​https://bugs.webkit.org/show_bug.cgi?id=161282

Patch by Alex Christensen <​achristensen@webkit.org> on 2016-08-27
Reviewed by Darin Adler.

Source/WebCore:

Partially covered by new API tests, but once the parser is complete enough we can
use the url web platform tests to more fully test this. It's still a work in
progress only used by tests.

• platform/URLParser.cpp:

(WebCore::URLParser::urlLengthUntilPart):
(WebCore::URLParser::copyURLPartsUntil):
Added some helper functions to reduce redundant code. When parsing relative URLs,
we often want to copy large parts of the base URL, but the stopping point differs.
(WebCore::URLParser::parse):
The parser now returns a URL instead of an Optional<URL> because a URL has a m_isValid which behaves like Optional.

• platform/URLParser.h:

(WebCore::URLParser::parse):

Source/WTF:

• wtf/text/StringView.h:

Use a std::reference_wrapper for the StringView& to make it reassignable so we can add an operator=.

Tools:

• TestWebKitAPI/Tests/WTF/StringView.cpp:

(TestWebKitAPI::TEST):
Added some tests for the new operator=.
Test saving iterators, restoring iterators, and even assigning iterators to new CodePoints objects.
Using the same iterator to iterate multiple objects is bad practice, but it's possible and now tested.

• TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::checkURL):
(TestWebKitAPI::TEST_F):
(TestWebKitAPI::checkRelativeURL):
(TestWebKitAPI::checkURLDifferences):
(TestWebKitAPI::shouldFail):
Add some relative URL tests.

10:29 PM Changeset in webkit [205096] by Chris Dumez

• 15 edits in trunk

Update generated bindings to throw a SecurityError when denying cross-origin access to properties
​https://bugs.webkit.org/show_bug.cgi?id=161270

Reviewed by Darin Adler.

Source/WebCore:

Update generated bindings to throw a SecurityError when denying cross-origin
access to properties, as per the HTML specification:

• ​https://html.spec.whatwg.org/#crossorigingetownpropertyhelper-(-o,-p-)
• ​https://html.spec.whatwg.org/#crossoriginproperties-(-o-)

Firefox and Chrome already throw but Webkit was logging an error message and
returning undefined instead.

No new tests, updated existing tests.

• bindings/js/JSDOMBinding.cpp:

(WebCore::canAccessDocument):
(WebCore::BindingSecurity::shouldAllowAccessToNode):

• bindings/js/JSDOMBinding.h:
• bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

LayoutTests:

Update / rebaseline existing tests to reflect behavior change.

• http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
• http/tests/security/cross-frame-access-call-expected.txt:
• http/tests/security/cross-frame-access-call.html:
• http/tests/security/cross-origin-window-property-access-expected.txt:
• http/tests/security/location-cross-origin-expected.txt:
• http/tests/security/location-cross-origin.html:
• http/tests/security/xss-DENIED-assign-location-href-javascript-expected.txt:
• http/tests/security/xss-DENIED-method-with-iframe-proto-expected.txt:
• http/tests/security/xss-DENIED-method-with-iframe-proto.html:

10:24 PM Changeset in webkit [205095] by Chris Dumez

• 3 edits in trunk/Source/WebCore

Follow-up fixes after r205030.
​https://bugs.webkit.org/show_bug.cgi?id=161216

Reviewed by Darin Adler.

• html/parser/HTMLParserIdioms.cpp:

(WebCore::isHTMLSpaceOrDelimiter):
(WebCore::isNumberStart):
(WebCore::parseHTMLListOfOfFloatingPointNumberValues):

• html/parser/HTMLParserIdioms.h:

6:27 PM Changeset in webkit [205094] by commit-queue@webkit.org

• 13 edits in trunk

WTR needs an implementation of setAutomaticLinkDetectionEnabled
​https://bugs.webkit.org/show_bug.cgi?id=87162

Patch by Jonathan Bedard <Jonathan Bedard> on 2016-08-27
Source/WebKit2:

Reviewed by Darin Adler

• WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetAutomaticLinkDetectionEnabled): Added WKBundleSetAutomaticLinkDetectionEnabled definition.

• WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Added WKBundleSetAutomaticLinkDetectionEnabled declaration.
• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setAutomaticLinkDetectionEnabled): Added setAutomaticLinkDetectionEnabled definition.

• WebProcess/InjectedBundle/InjectedBundle.h: Added setAutomaticLinkDetectionEnabled declaration.
• WebProcess/WebProcess.h: Declared setTextCheckerState public.

Tools:

Reviewed by Darin Adler.

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Added setAutomaticLinkDetectionEnabled binding.
• WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting): Set automatic link detection to false by default.

• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setAutomaticLinkDetectionEnabled): Added setAutomaticLinkDetectionEnabled definition.

• WebKitTestRunner/InjectedBundle/TestRunner.h: Added setAutomaticLinkDetectionEnabled declaration.

LayoutTests:

Reviewed by Darin Adler.

• platform/wk2/TestExpectations: Removed 2 now passing tests.

5:40 PM Changeset in webkit [205093] by commit-queue@webkit.org

• 71 edits in trunk/Source/WebCore

Add final keyword to final classes and overriden methods in WebCore/css
​https://bugs.webkit.org/show_bug.cgi?id=161182

Patch by Rawinder Singh <​rawinder.singh-webkit@cisra.canon.com.au> on 2016-08-27
Reviewed by Darin Adler.

• Mark classes in the WebCore/css directory final as appropriate.
• Update WebCore/css classes so that overriden methods in final classes are marked final.

• css/CSSAnimationTriggerScrollValue.h:
• css/CSSAspectRatioValue.h:
• css/CSSBasicShapes.h:
• css/CSSBorderImageSliceValue.h:
• css/CSSCalculationValue.cpp:

(WebCore::determineCategory):

• css/CSSCalculationValue.h:
• css/CSSCanvasValue.h:
• css/CSSCharsetRule.h:
• css/CSSComputedStyleDeclaration.h:
• css/CSSContentDistributionValue.h:
• css/CSSCrossfadeValue.h:
• css/CSSCursorImageValue.h:
• css/CSSCustomPropertyValue.h:
• css/CSSFilterImageValue.h:
• css/CSSFontFaceLoadEvent.h:
• css/CSSFontFaceSrcValue.h:
• css/CSSFontFeatureValue.h:
• css/CSSFontSelector.h:
• css/CSSFontValue.h:
• css/CSSFunctionValue.h:
• css/CSSGradientValue.h:
• css/CSSGridAutoRepeatValue.h:
• css/CSSGridLineNamesValue.h:
• css/CSSGridTemplateAreasValue.h:
• css/CSSImageSetValue.h:
• css/CSSImageValue.h:
• css/CSSInheritedValue.h:
• css/CSSInitialValue.h:
• css/CSSKeyframeRule.h:
• css/CSSKeyframesRule.h:
• css/CSSLineBoxContainValue.h:
• css/CSSNamedImageValue.h:
• css/CSSPrimitiveValue.h:
• css/CSSReflectValue.h:
• css/CSSRevertValue.h:
• css/CSSRuleList.h:
• css/CSSSegmentedFontFace.h:
• css/CSSShadowValue.h:
• css/CSSStyleSheet.cpp:
• css/CSSStyleSheet.h:
• css/CSSSupportsRule.h:
• css/CSSTimingFunctionValue.h:
• css/CSSUnicodeRangeValue.h:
• css/CSSUnknownRule.h:
• css/CSSUnsetValue.h:
• css/CSSValue.cpp:
• css/CSSVariableDependentValue.h:
• css/CSSVariableValue.h:
• css/Counter.h:
• css/DOMCSSNamespace.h:
• css/DashboardRegion.h:
• css/LengthRepeat.h:
• css/MediaList.h:
• css/MediaQueryList.h:
• css/MediaQueryMatcher.h:
• css/Pair.h:
• css/PropertySetCSSStyleDeclaration.h:
• css/RGBColor.h:
• css/Rect.h:
• css/StyleMedia.h:
• css/StyleProperties.h:
• css/StyleRule.h:
• css/StyleRuleImport.h:
• css/StyleSheetContents.h:
• css/StyleSheetList.h:
• css/ViewportStyleResolver.h:
• css/WebKitCSSFilterValue.h:
• css/WebKitCSSRegionRule.h:
• css/WebKitCSSTransformValue.h:
• css/WebKitCSSViewportRule.h:

5:36 PM Changeset in webkit [205092] by Simon Fraser

• 6 edits in trunk/Source

Add more Editing logging
​https://bugs.webkit.org/show_bug.cgi?id=161287

Reviewed by Darin Adler.

Add logging which tracks how key events get from the UI process to the
web process, and down to form fields.

• editing/Editor.cpp:

(WebCore::Editor::handleTextEvent):
(WebCore::Editor::appliedEditing):

• editing/TypingCommand.cpp:

(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::insertTextAndNotifyAccessibility):

• html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::didEditInnerTextValue):

• page/EventHandler.cpp:

(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::handleTextInputEvent):

5:15 PM Changeset in webkit [205091] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Unused cxxabi.h include in JSGlobalObjectInspectorController.cpp
​https://bugs.webkit.org/show_bug.cgi?id=161120

Patch by Don Olmstead <​don.olmstead@am.sony.com> on 2016-08-27
Reviewed by Darin Adler.

• inspector/JSGlobalObjectInspectorController.cpp:

5:14 PM Changeset in webkit [205090] by pvollan@apple.com

• 2 edits in trunk

[Win] Enable 'warning as error' compiler setting.
​https://bugs.webkit.org/show_bug.cgi?id=161243

Reviewed by Darin Adler.

• Source/cmake/OptionsWin.cmake:

5:13 PM Changeset in webkit [205089] by commit-queue@webkit.org

• 6 edits in trunk

Web Inspector: Make localizedString.js diff and commit friendly (UTF16 -> UTF8)
​https://bugs.webkit.org/show_bug.cgi?id=28685
<rdar://problem/16460975>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-27
Reviewed by Darin Adler.

Source/WebInspectorUI:

• Localizations/en.lproj/localizedStrings.js:
• WebInspectorUI.xcodeproj/project.pbxproj:

Convert the file to UTF-8. Future diffs should display as text.

Tools:

• Scripts/extract-localizable-js-strings:
• Scripts/update-webkit-localizable-strings:

WebInspectorUI localizedStrings.js is now UTF-8. Other clients of
this script still use UTF-16, so keep that the default.

5:12 PM Changeset in webkit [205088] by commit-queue@webkit.org

• 16 edits
  5 deletes in trunk

Remove more custom JavaScript bindings
​https://bugs.webkit.org/show_bug.cgi?id=161293

Patch by Sam Weinig <​sam@webkit.org> on 2016-08-27
Reviewed by Darin Adler.

Source/WebCore:

Remove custom bindings for AudioContext, DOMFormData, MediaSession and WebKitPoint.

• Modules/mediasession/MediaSession.cpp:

(WebCore::MediaSession::MediaSession):

• Modules/mediasession/MediaSession.h:

Change to take Document explicitly, since that is what it
expecting.

• Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):

• Modules/webaudio/AudioContext.h:

Remove unused ExceptionCode parameter.

• Modules/webaudio/AudioContext.idl:
• html/DOMFormData.idl:
• html/HTMLFormElement.idl:
• page/WebKitPoint.idl:

Switch to use the generated constructor.

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSBindingsAllInOne.cpp:

Remove files.

• bindings/js/JSAudioContextCustom.cpp: Removed.
• bindings/js/JSDOMFormDataCustom.cpp: Removed.
• bindings/js/JSMediaSessionCustom.cpp: Removed.
• bindings/js/JSWebKitPointCustom.cpp: Removed.

Remove in favor of generated variants.

• bindings/js/JSHTMLInputElementCustom.h: Removed.

Remove unused header.

• page/WebKitPoint.h:

(WebCore::WebKitPoint::create):
(WebCore::WebKitPoint::WebKitPoint):
Move NaN replacement into the implementation and out of the bindings.

LayoutTests:

• webaudio/audionode-expected.txt:
• webaudio/audionode.html:

Update test for correct behavior of the constructor.

5:11 PM Changeset in webkit [205087] by ap@apple.com

• 2 edits in trunk/Tools

REGRESSION (r204052): Popovers on bot watcher's dashboard are broken
​https://bugs.webkit.org/show_bug.cgi?id=161254

Reviewed by Darin Adler.

Simplify the CSS. My understanding that the CSS was correct, and the root cause
is tracked in bug 160478.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:

5:10 PM Changeset in webkit [205086] by commit-queue@webkit.org

• 9 edits in trunk/LayoutTests

Race between creating/deleting a database in test
​https://bugs.webkit.org/show_bug.cgi?id=161285

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-27
Reviewed by Darin Adler.

Because IndexedDB creation is asynchronous, we were not waiting for the
database to be completely open before sending more commands. These
could race and give unexpected results. Wait for the database to be
successfully created before interacting with it.

• inspector/indexeddb/resources/utilities.js:

(createEmptyDatabase):
(createDatabaseWithStores):
Send a single when the database creation is completed.

• inspector/indexeddb/clearObjectStore-expected.txt:
• inspector/indexeddb/clearObjectStore.html:
• inspector/indexeddb/deleteDatabaseNamesWithSpace.html:
• inspector/indexeddb/requestData-expected.txt:
• inspector/indexeddb/requestDatabase-expected.txt:
• inspector/indexeddb/requestDatabase.html:
• inspector/indexeddb/requestDatabaseNames.html:

Listen for the database created signal before proceeding
with the test.

3:13 PM Changeset in webkit [205085] by rniwa@webkit.org

• 9 edits
  2 adds in trunk

Source/WebCore:
Add adopted callback for custom elements
​https://bugs.webkit.org/show_bug.cgi?id=161284

Reviewed by Antti Koivisto.

Added the support for adoptedCallback: ​https://dom.spec.whatwg.org/#concept-node-adopt
For now, we only support this callback on appendChild.

Test: fast/custom-elements/adopted-callback.html

• bindings/js/JSCustomElementInterface.cpp:

(WebCore::JSCustomElementInterface::invokeCallback): Added JSDOMGlobalObject* as an argument to the callback so that
we can invoke toJS on Document in invokeAdoptedCallback.
(WebCore::JSCustomElementInterface::setAdoptedCallback): Added.
(WebCore::JSCustomElementInterface::invokeAdoptedCallback): Added.
(WebCore::JSCustomElementInterface::setAttributeChangedCallback):

• bindings/js/JSCustomElementInterface.h:

(WebCore::JSCustomElementInterface::hasConnectedCallback): Added.
(WebCore::JSCustomElementInterface::hasDisconnectedCallback): Added.
(WebCore::JSCustomElementInterface::hasAdoptedCallback): Added.

• bindings/js/JSCustomElementRegistryCustom.cpp:

(WebCore::JSCustomElementRegistry::define):

• dom/CustomElementReactionQueue.cpp:

(WebCore::CustomElementReactionQueueItem::CustomElementReactionQueueItem): Added a variant that takes two documents.
(WebCore::CustomElementReactionQueueItem::invoke):
(WebCore::CustomElementReactionQueue::enqueueConnectedCallbackIfNeeded): Fixed a bug that this function was always
enqueuing a callback even when the interface didn't have connectedCallback. Also, there is no need to check
the nullity of the interface since it should never be null.
(WebCore::CustomElementReactionQueue::enqueueDisconnectedCallbackIfNeeded): Ditto.
(WebCore::CustomElementReactionQueue::enqueueAdoptedCallbackIfNeeded): Added.
(WebCore::CustomElementReactionQueue::enqueueAttributeChangedCallbackIfNeeded): Assert that the interface is never
null instead of exiting early.

• dom/CustomElementReactionQueue.h:
• dom/Element.cpp:

(WebCore::Element::didMoveToNewDocument): Added a call to enqueueAdoptedCallbackIfNeeded.

LayoutTests:
adoptcallback

Add adopted callback for custom elements
​https://bugs.webkit.org/show_bug.cgi?id=161284

Reviewed by Antti Koivisto.

• fast/custom-elements/adopted-callback-expected.txt: Added.
• fast/custom-elements/adopted-callback.html: Added.
• fast/custom-elements/resources/document-types.js:

(const.DocumentTypes.create):

2:34 PM Changeset in webkit [205084] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Fix the !PLATFORM(WIN) && USE(CURL) build.
​https://bugs.webkit.org/show_bug.cgi?id=161281

Patch by Yoshiaki Jitsukawa <​Yoshiaki.Jitsukawa@sony.com> on 2016-08-27
Reviewed by Alex Christensen.

• platform/network/curl/ResourceHandleCurl.cpp:

1:55 PM Changeset in webkit [205083] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

html/dom/interfaces.html is flaky due to WebSocket test
​https://bugs.webkit.org/show_bug.cgi?id=161290

Unreviewed.

Patch by Youenn Fablet <​youenn@apple.com> on 2016-08-27

• platform/mac/TestExpectations: Making html/dom/interfaces.html expectation specific to Release.

1:47 PM Changeset in webkit [205082] by commit-queue@webkit.org

• 8 edits in trunk

[Fetch API] Opaque responses should not have any body
​https://bugs.webkit.org/show_bug.cgi?id=161130

Patch by Youenn Fablet <​youenn@apple.com> on 2016-08-27
Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

• web-platform-tests/fetch/api/cors/cors-basic.js:

(cors): Adding response body checking.

Source/WebCore:

Covered by updated test.

Added a new ThreadableLoader option to receive or not opaque response body.
By default, option is set to Receive.
FetchLoader is setting it to DoNotReceive.

• Modules/fetch/FetchLoader.cpp:

(WebCore::FetchLoader::start):

• loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::didReceiveResponse): Calling didFinishLoading just after didReceiveResponse in case of Opaque responses.

• loader/ThreadableLoader.cpp:

(WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions):

• loader/ThreadableLoader.h:
• loader/WorkerThreadableLoader.cpp:

(WebCore::LoaderTaskOptions::LoaderTaskOptions):

11:43 AM Changeset in webkit [205081] by commit-queue@webkit.org

• 6 edits in trunk

[Fetch API] opaqueredirect responses should have their URL set to the original URL
​https://bugs.webkit.org/show_bug.cgi?id=161194

Patch by Youenn Fablet <​youenn@apple.com> on 2016-08-27
Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

• web-platform-tests/fetch/api/redirect/redirect-mode.html:
• web-platform-tests/fetch/api/redirect/redirect-mode.js:

(redirectMode): Updating test to ease the computation of the absolute URL.

Source/WebCore:

Covered by updated tests.

• loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::didReceiveResponse):

• loader/SubresourceLoader.cpp: Removing isNull ASSERT since we now set the response URL.

(WebCore::SubresourceLoader::willSendRequestInternal): Setting opaqueredirect response URL to the original URL.

11:07 AM Changeset in webkit [205080] by Simon Fraser

• 7 edits in trunk

Add run-webkit-tests --print-expectations to show expectations for all or a subset of tests
​https://bugs.webkit.org/show_bug.cgi?id=161217

Reviewed by Ryosuke Niwa.
Tools:

"run-webkit-tests --print-expectations" runs the same logic as running the tests, but
dumps out the lists of tests that would be run and skipped, and, for each, the entry
in TestExpectations that determines the expected outcome of the test.

This is an improved version of webkit-patch print-expectations.

See bug for sample output.

• Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._print_expectations_for_subset): Print out the list of tests and expected
outcome for some subset of tests.
(Manager.print_expectations): Do the same splitting by device class that running tests
does, and for each subset of tests, call _print_expectations_for_subset.

• Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser.expectation_for_skipped_test): Set the flag
expectation_line.not_applicable_to_current_platform
(TestExpectationLine.init): Init not_applicable_to_current_platform to False
(TestExpectationLine.expected_behavior): line.expectation is PASS by default,
even for skipped tests. This function returns a list relevant for display, taking the skipped
modifier into account.
(TestExpectationLine.create_passing_expectation): expectations is normally a list, not a set.
(TestExpectations.readable_filename_and_line_number): Return something printable for
lines with and without filenames

• Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(main): Handle options.print_expectations
(parse_args): Add support for --print-expectations
(_print_expectations):

• Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort.default_child_processes): Make this a debug log.

LayoutTests:

Explicitly skip fast/viewport

• platform/mac/TestExpectations:

10:45 AM Changeset in webkit [205079] by akling@apple.com

• 4 edits in trunk

script.text should behave like script.textContent on setting
<​https://webkit.org/b/148852>

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

• web-platform-tests/html/semantics/scripting-1/the-script-element/script-text-expected.txt:

Source/WebCore:

HTMLScriptElement.text should behave just like .textContent when setting,
so just forward setText() to setTextContent().

Test: import/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/script-text.html

• html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::setText):

8:09 AM Changeset in webkit [205078] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

html/dom/interfaces.html is flaky due to WebSocket test
​https://bugs.webkit.org/show_bug.cgi?id=161290

Unreviewed.

Patch by Youenn Fablet <​youenn@apple.com> on 2016-08-27

• platform/mac/TestExpectations: Marking html/dom/interfaces.html expectation from Skip to Pass|Failure.

7:31 AM Changeset in webkit [205077] by commit-queue@webkit.org

• 94 edits
  1 move
  4 adds
  1 delete in trunk/LayoutTests

Sync web-platform-tests up to revision e827374
​https://bugs.webkit.org/show_bug.cgi?id=161231

Patch by Youenn Fablet <​youenn@apple.com> on 2016-08-27
Reviewed by Sam Weinig.

• resources/ImportExpectations: Skipped some new test suites. Added 'url' test suite as Import.
• resources/TestRepositories: Updated revision to e827374
• resources/web-platform-tests-modules.json:
• web-platform-tests/XMLHttpRequest/abort-during-upload-expected.txt:
• web-platform-tests/XMLHttpRequest/abort-during-upload.htm:
• web-platform-tests/XMLHttpRequest/abort-event-order.htm:
• web-platform-tests/XMLHttpRequest/event-error-expected.txt:
• web-platform-tests/XMLHttpRequest/event-error-order.sub-expected.txt: Added.
• web-platform-tests/XMLHttpRequest/event-error-order.sub.html: Added.
• web-platform-tests/XMLHttpRequest/event-error.html:
• web-platform-tests/XMLHttpRequest/event-error.sub-expected.txt: Added.
• web-platform-tests/XMLHttpRequest/event-error.sub.html: Copied from LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/event-error.html.
• web-platform-tests/XMLHttpRequest/event-progress.htm:
• web-platform-tests/XMLHttpRequest/resources/trickle.py:

(main):

• web-platform-tests/XMLHttpRequest/resources/w3c-import.log:
• web-platform-tests/XMLHttpRequest/resources/xmlhttprequest-event-order.js: Added.

(global.prepare_xhr_for_event_order_test):
(global.assert_xhr_event_order_matches):

• web-platform-tests/XMLHttpRequest/response-data-progress-expected.txt:
• web-platform-tests/XMLHttpRequest/response-data-progress.htm:
• web-platform-tests/XMLHttpRequest/response-method-expected.txt:
• web-platform-tests/XMLHttpRequest/responsexml-document-properties-expected.txt:
• web-platform-tests/XMLHttpRequest/security-consideration.sub.html:
• web-platform-tests/XMLHttpRequest/send-entity-body-document-expected.txt:
• web-platform-tests/XMLHttpRequest/send-no-response-event-order-expected.txt:
• web-platform-tests/XMLHttpRequest/send-no-response-event-order.htm:
• web-platform-tests/XMLHttpRequest/send-sync-response-event-order-expected.txt:
• web-platform-tests/XMLHttpRequest/send-sync-response-event-order.htm:
• web-platform-tests/XMLHttpRequest/w3c-import.log:
• web-platform-tests/common/get-host-info.sub.js: Added.

(get_host_info):

• web-platform-tests/common/w3c-import.log:
• web-platform-tests/dom/interfaces-expected.txt:
• web-platform-tests/dom/interfaces.html:
• web-platform-tests/dom/nodes/attributes-expected.txt:
• web-platform-tests/dom/nodes/attributes.html:
• web-platform-tests/dom/traversal/TreeWalker-acceptNode-filter.html:
• web-platform-tests/dom/traversal/TreeWalker-basic.html:
• web-platform-tests/dom/traversal/TreeWalker-currentNode.html:
• web-platform-tests/dom/traversal/TreeWalker-previousNodeLastChildReject.html:
• web-platform-tests/dom/traversal/TreeWalker-previousSiblingLastChildSkip.html:
• web-platform-tests/dom/traversal/TreeWalker-traversal-reject.html:
• web-platform-tests/dom/traversal/TreeWalker-traversal-skip-most.html:
• web-platform-tests/dom/traversal/TreeWalker-traversal-skip.html:
• web-platform-tests/domparsing/w3c-import.log:
• web-platform-tests/fetch/api/basic/scheme-about-expected.txt:
• web-platform-tests/fetch/api/basic/scheme-about-worker-expected.txt:
• web-platform-tests/fetch/api/basic/scheme-about.js:

(checkFetchResponse):
(checkKoUrl): Deleted.

• web-platform-tests/fetch/api/basic/w3c-import.log:
• web-platform-tests/fetch/api/cors/cors-cookies.js:

(corsCookies):

• web-platform-tests/fetch/api/cors/cors-redirect.js:

(corsRedirect):

• web-platform-tests/fetch/api/headers/headers-basic-expected.txt:
• web-platform-tests/fetch/api/headers/headers-basic.html:
• web-platform-tests/fetch/api/redirect/w3c-import.log:
• web-platform-tests/fetch/api/request/request-cache-expected.txt:
• web-platform-tests/html/browsers/history/the-location-interface/security_location_0.sub.htm:
• web-platform-tests/html/browsers/the-window-object/security-window/window-security.sub.html:
• web-platform-tests/html/browsers/windows/nested-browsing-contexts/frameElement.sub.html:
• web-platform-tests/html/browsers/windows/targeting-cross-origin-nested-browsing-contexts.sub-expected.txt:
• web-platform-tests/html/browsers/windows/targeting-cross-origin-nested-browsing-contexts.sub.html:
• web-platform-tests/html/dom/elements-forms.js:
• web-platform-tests/html/dom/elements-tabular.js:
• web-platform-tests/html/dom/elements/global-attributes/dataset-expected.txt:
• web-platform-tests/html/dom/elements/global-attributes/dataset.html:
• web-platform-tests/html/dom/interfaces-expected.txt:
• web-platform-tests/html/dom/interfaces.html:
• web-platform-tests/html/dom/reflection-forms-expected.txt:
• web-platform-tests/html/dom/reflection-tabular-expected.txt:
• web-platform-tests/html/dom/reflection.js:

(ReflectionTests.typeMap.string_appeared_here.toString):
(ReflectionTests.typeMap.string_appeared_here.valueOf):
(ReflectionTests.typeMap.string_appeared_here.string_appeared_here):

• web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_specified.sub.html:
• web-platform-tests/html/semantics/document-metadata/the-link-element/document-without-browsing-context-expected.txt:
• web-platform-tests/html/semantics/document-metadata/the-link-element/link-load-event.html:
• web-platform-tests/html/semantics/document-metadata/the-link-element/link-style-error-01-expected.txt:
• web-platform-tests/html/semantics/document-metadata/the-link-element/link-style-error-01.html:
• web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.drawImage.canvas.sub-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.drawImage.canvas.sub.html:
• web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.drawImage.image.sub-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.drawImage.image.sub.html:
• web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.canvas.fillStyle.sub-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.canvas.fillStyle.sub.html:
• web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.canvas.strokeStyle.sub-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.canvas.strokeStyle.sub.html:
• web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.canvas.timing.sub-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.canvas.timing.sub.html:
• web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.create.sub-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.create.sub.html:
• web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.cross.sub-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.cross.sub.html:
• web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.image.fillStyle.sub-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.image.fillStyle.sub.html:
• web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.image.strokeStyle.sub-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.image.strokeStyle.sub.html:
• web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.reset.sub-expected.txt:
• web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.reset.sub.html:
• web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/viewport-change-expected.txt:
• web-platform-tests/html/semantics/forms/constraints/form-validation-validity-tooShort.html:
• web-platform-tests/html/semantics/interfaces-expected.txt:
• web-platform-tests/html/semantics/interfaces.html:
• web-platform-tests/html/semantics/interfaces.js:
• web-platform-tests/html/semantics/selectors/pseudo-classes/valid-invalid-expected.txt:
• web-platform-tests/html/semantics/selectors/pseudo-classes/valid-invalid.html:
• web-platform-tests/lint.whitelist:
• web-platform-tests/url/w3c-import.log: Added.

3:40 AM Changeset in webkit [205076] by commit-queue@webkit.org

• 13 edits in trunk

[Fetch API] Blob type should be set from Response/Request contentType header
​https://bugs.webkit.org/show_bug.cgi?id=161228

Patch by Youenn Fablet <​youenn@apple.com> on 2016-08-27
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/fetch/api/request/request-consume.html:
• web-platform-tests/fetch/api/request/request-headers-expected.txt:
• web-platform-tests/fetch/api/request/request-headers.html:
• web-platform-tests/fetch/api/response/response-consume-expected.txt:
• web-platform-tests/fetch/api/response/response-consume.html:
• web-platform-tests/fetch/api/response/response-init-002-expected.txt:
• web-platform-tests/fetch/api/response/response-init-002.html:

Source/WebCore:

Covered by updated tests.

Renaming FetchBody::m_mimeType to m_contentType since that better relates to Content-Type header.
Updated FetchRequest and FetchResponse to set m_contentType according request/response headers.
Handled the case of a Request created from JS, a Response created from JS and a Response created internally to
be used as resolve value in the fetch promise.

In case Content-Type is set but is empty, its empty value should be used for blob type.
Updated contentType checks to use isNull in lieu of isEmpty.

• Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::updateContentType): Routine to synchronize headers with m_contentType.
(WebCore::FetchBody::FetchBody): Renamed m_mimeType to m_contentType.
(WebCore::FetchBody::blob): Ditto.

• Modules/fetch/FetchBody.h: Ditto.

(WebCore::FetchBody::contentType):
(WebCore::FetchBody::setMimeType): Deleted.
(WebCore::FetchBody::mimeType): Deleted.

• Modules/fetch/FetchRequest.cpp:

(WebCore::FetchRequest::setBody): set FetchBody::m_contentType according HTTP headers.

• Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::initializeWith): Ditto.
(WebCore::FetchResponse::BodyLoader::didReceiveResponse): Ditto.

2:18 AM Changeset in webkit [205075] by Carlos Garcia Campos

• 3 edits in trunk/Source/WebKit2

[GTK][Threaded Compositor] Several flaky tests
​https://bugs.webkit.org/show_bug.cgi?id=161242

Reviewed by Michael Catanzaro.

We still have a lot of flaky tests since we switched to the threaded compositor. The UI process might
take the screenshot too early, before everything is actually painted. I can't reproduce the problem, so this is
actually a speculative fix or workaround. Our implementation of DrawingArea::dispatchAfterEnsuringDrawing() is
quite simple, we just dispatch the callback in the next run loop iteration, which doesn't really ensures any
drawing at all. So, we can wait for draw events before dispatching the given callback. Since we don't really
know if draw events were already processed before dispatchAfterEnsuringDrawing() is called, or if there will be
more than one damage event in a short time, this patch waits up to 1 second for draw events, and if a draw
happens it stops if there isn't another draw event in the next 100ms. This should ensure a drawing if it was
really needed.

• UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::DrawingMonitor::DrawingMonitor):
(WebKit::DrawingAreaProxyImpl::DrawingMonitor::~DrawingMonitor):
(WebKit::DrawingAreaProxyImpl::DrawingMonitor::webViewDrawCallback):
(WebKit::DrawingAreaProxyImpl::DrawingMonitor::start):
(WebKit::DrawingAreaProxyImpl::DrawingMonitor::stop):
(WebKit::DrawingAreaProxyImpl::DrawingMonitor::didDraw):
(WebKit::DrawingAreaProxyImpl::dispatchAfterEnsuringDrawing):

• UIProcess/DrawingAreaProxyImpl.h:

Aug 26, 2016:

10:47 PM Changeset in webkit [205074] by mitz@apple.com

• 2 edits in trunk/Tools

Keep trying to fix the build after r205057.

• MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:

10:44 PM Changeset in webkit [205073] by mitz@apple.com

• 6 edits in trunk/Tools

Keep trying to fix the build after r205057.

• MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Don’t try to import nonexistent config.h. This file is only meant to be built with Xcode anyway.
• MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Make this compile with Xcode 7.3 and deploy to iOS 9.0.
• MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Ditto.
• MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Don’t try to import config.h.
• MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Ditto.

9:39 PM Changeset in webkit [205072] by mitz@apple.com

• 2 edits in trunk/Tools

Start trying to fix the build after r205057.

• MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:

9:38 PM Changeset in webkit [205071] by bshafiei@apple.com

• 1 copy in tags/Safari-602.1.50.0.8

New tag.

8:48 PM Changeset in webkit [205070] by ap@apple.com

• 2 edits in trunk/Tools

Remove Yosemite Leaks from the flakiness dashboard
​https://bugs.webkit.org/show_bug.cgi?id=161253

Reviewed by Anders Carlsson.

• TestResultServer/static-dashboards/builders.jsonp:

8:04 PM Changeset in webkit [205069] by achristensen@apple.com

• 3 edits in trunk/Source/WebCore

Fix Windows build after r205065.

• Modules/webaudio/BiquadFilterNode.idl:
• Modules/webaudio/PannerNode.idl:

There's no WEB_AUDIO on Windows.

7:53 PM Changeset in webkit [205068] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

REGRESSION (r203535): Web Inspector: Inspector overlay node info has disappeared
​https://bugs.webkit.org/show_bug.cgi?id=161264

Patch by Devin Rousso <Devin Rousso> on 2016-08-26
Reviewed by Joseph Pecoraro.

No new tests. Fixing JavaScript error in Inspector overlay.

• inspector/InspectorOverlay.cpp:

(evaluateCommandInOverlay):
(WebCore::InspectorOverlay::evaluateInOverlay):
Add ASSERT to ensure that errors in the Inspector overlay will cause tests to crash.

• inspector/InspectorOverlayPage.js:

(DOMBuilder.prototype.appendTextNode):
Move textContent value to parameter of document.createTextNode.

7:51 PM Changeset in webkit [205067] by Joseph Pecoraro

• 2 edits in trunk/LayoutTests

Web Inspector: inspector/indexeddb/deleteDatabaseNamesWithSpace.html is flakey
​https://bugs.webkit.org/show_bug.cgi?id=161283

Reviewed by Alex Christensen.

• inspector/indexeddb/deleteDatabaseNamesWithSpace.html:

Add a short timeout between deleting a database and requesting database names
to reduce flakey results.

7:39 PM Changeset in webkit [205066] by commit-queue@webkit.org

• 3 edits in trunk/Source/WTF

bitwise_cast uses inactive member of union
​https://bugs.webkit.org/show_bug.cgi?id=161244

Patch by JF Bastien <​jfbastien@apple.com> on 2016-08-26
Reviewed by Benjamin Poulain.

• wtf/Compiler.h:

Add COMPILER_HAS_CLANG_FEATURE

• wtf/StdLibExtras.h:

(WTF::bitwise_cast):
Fix C++ UB, add trivially-copyable check.

bitwise_cast stores into a union with one type and reads with
another, which is technically C++ undefined behavior because it's
accessing the wrong active member of the union. The better way to
do this is through memcpy, which compilers optimize as well
because it's known-size in known-not-to-escape storage (for small
types they'll inline and then convert stack memory access to SSA
values which may be in-register if that makes sense, which would
be a move between int/FP registers at worst).

The C++ Standard's section [basic.types] explicitly blesses memcpy:

For any trivially copyable type T, if two pointers to T point to
distinct T objects obj1 and obj2, where neither obj1 nor obj2 is a
base-class subobject, if the underlying bytes (1.7) making up obj1
are copied into obj2, 42 obj2 shall subsequently hold the same
value as obj1.

[Example:

T* t1p;
T* t2p;
provided that t2p points to an initialized object ...
std::memcpy(t1p, t2p, sizeof(T));
at this point, every subobject of trivially copyable type in *t1p contains
the same value as the corresponding subobject in *t2p

— end example ]

Whereas section [class.union] says:

In a union, at most one of the non-static data members can be
active at any time, that is, the value of at most one of the
non-static data members can be stored in a union at any time.

While we're at it, checking that sizeof(To) == sizeof(From) is
good, but we should also check that both types are trivially
copyable (can have a ctor, no dtor, and copy is defaulted as if by
memcpy for type and all subtypes). Unfortunately that trait isn't
implemented consistently in all recent compiler+stdlib
implementations, but recent clang has an equivalent builtin
(other compilers simply won't do the check, and will break on bots
with the right compilers which is better than the current silent
breakage). This builtin hack also avoids #include <type_traits>
which really doesn't save much.

7:01 PM Changeset in webkit [205065] by weinig@apple.com

• 108 edits
  7 deletes in trunk

Remove support for ENABLE_LEGACY_WEB_AUDIO
​https://bugs.webkit.org/show_bug.cgi?id=161262

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Remove ENABLE_LEGACY_WEB_AUDIO

Source/WebCore:

• Configurations/FeatureDefines.xcconfig:

Remove ENABLE_LEGACY_WEB_AUDIO.

• Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::noteGrainOn): Deleted.

• Modules/webaudio/AudioBufferSourceNode.h:
• Modules/webaudio/AudioBufferSourceNode.idl:

(WebCore::AudioScheduledSourceNode::noteOn): Deleted.
(WebCore::AudioScheduledSourceNode::noteOff): Deleted.

• Modules/webaudio/AudioScheduledSourceNode.h:
• Modules/webaudio/AudioScheduledSourceNode.cpp:

Remove the looping attribute, as well as the noteOn, noteOff, and noteGrainOn functions.

• Modules/webaudio/AudioContext.idl:

Remove the createGainNode, createDelayNode and createJavaScriptNode functions.

• Modules/webaudio/AudioParam.idl:

Remove the setTargetValueAtTime function.

• Modules/webaudio/BiquadDSPKernel.cpp:

(WebCore::BiquadDSPKernel::updateCoefficientsIfNecessary):

• Modules/webaudio/BiquadFilterNode.cpp:

(WebCore::BiquadFilterNode::type):
(WebCore::BiquadFilterNode::setType):
(WebCore::BiquadFilterNode::getFrequencyResponse):

• Modules/webaudio/BiquadFilterNode.h:
• Modules/webaudio/BiquadFilterNode.idl:
• Modules/webaudio/BiquadProcessor.cpp:

(WebCore::BiquadProcessor::BiquadProcessor):
(WebCore::BiquadProcessor::setType):
(WebCore::BiquadProcessor::getFrequencyResponse):

• Modules/webaudio/BiquadProcessor.h:

(WebCore::BiquadProcessor::type):

• bindings/js/JSBiquadFilterNodeCustom.cpp: Removed.

Rename BiquadProcessor::FilterType to BiquadFilterType and use it
directly from the IDL. Remove legacy filter constants from the IDL
and the need for a custom binding for the type attribute.

• Modules/webaudio/OscillatorNode.cpp:

(WebCore::OscillatorNode::OscillatorNode):
(WebCore::OscillatorNode::setType):
(WebCore::OscillatorNode::setPeriodicWave):
(WebCore::OscillatorNode::type): Deleted.

• Modules/webaudio/OscillatorNode.h:

(WebCore::OscillatorNode::type):

• Modules/webaudio/OscillatorNode.idl:
• Modules/webaudio/PeriodicWave.cpp:

(WebCore::PeriodicWave::createSine):
(WebCore::PeriodicWave::createSquare):
(WebCore::PeriodicWave::createSawtooth):
(WebCore::PeriodicWave::createTriangle):
(WebCore::PeriodicWave::generateBasicWaveform):

• Modules/webaudio/PeriodicWave.h:
• bindings/js/JSOscillatorNodeCustom.cpp: Removed.

Remove noteOn and noteOff functions and the type integer constants.
Remove the need for a custom binding for the type attribute by renaming
the type enum OscillatorNode::Type and putting the enum in the IDL.

• Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::PannerNode):
(WebCore::PannerNode::process):
(WebCore::PannerNode::setPanningModel):
(WebCore::PannerNode::distanceModel):
(WebCore::PannerNode::setDistanceModel):
(WebCore::PannerNode::panningModel): Deleted.

• Modules/webaudio/PannerNode.h:

(WebCore::PannerNode::panningModel):

• Modules/webaudio/PannerNode.idl:
• bindings/js/JSPannerNodeCustom.cpp: Removed.
• platform/audio/Distance.cpp:

(WebCore::DistanceEffect::DistanceEffect):
(WebCore::DistanceEffect::gain):

• platform/audio/Distance.h:

(WebCore::DistanceEffect::model):
(WebCore::DistanceEffect::setModel):

• platform/audio/EqualPowerPanner.cpp:

(WebCore::EqualPowerPanner::EqualPowerPanner):

• platform/audio/HRTFPanner.cpp:

(WebCore::HRTFPanner::HRTFPanner):

• platform/audio/Panner.cpp:

(WebCore::Panner::create):

• platform/audio/Panner.h:

(WebCore::Panner::panningModel):
(WebCore::Panner::Panner):
Replace the panning model and distance model integer constants
with IDL enum support, removing the need for a custom binding.
Rename the supporting C++ enums to work with the bindings.

• bindings/js/JSAudioContextCustom.cpp:

(WebCore::constructJSAudioContext):
Remove deprecated way of creating an offline context.

• WebCore.xcodeproj/project.pbxproj:

Update files.

Source/WebKit/mac:

• Configurations/FeatureDefines.xcconfig:

Remove ENABLE_LEGACY_WEB_AUDIO

Source/WebKit2:

• Configurations/FeatureDefines.xcconfig:

Remove ENABLE_LEGACY_WEB_AUDIO.

Tools:

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

• webaudio/audiobuffersource-loop-points.html:
• webaudio/audiobuffersource-multi-channels.html:
• webaudio/audiobuffersource-playbackState-expected.txt:
• webaudio/audiobuffersource-playbackState.html:
• webaudio/audiobuffersource-playbackrate.html:
• webaudio/audiochannelmerger-stereo.html:
• webaudio/audiochannelsplitter.html:
• webaudio/audionode-connect-order.html:
• webaudio/audionode-expected.txt:
• webaudio/audionode.html:
• webaudio/audioparam-connect-audioratesignal.html:
• webaudio/audioparam-summingjunction.html:
• webaudio/audioprocessingevent.html:
• webaudio/automatic-pull-node.html:
• webaudio/biquad-allpass.html:
• webaudio/biquad-bandpass.html:
• webaudio/biquad-getFrequencyResponse.html:
• webaudio/biquad-highpass.html:
• webaudio/biquad-highshelf.html:
• webaudio/biquad-lowpass.html:
• webaudio/biquad-lowshelf.html:
• webaudio/biquad-notch.html:
• webaudio/biquad-peaking.html:
• webaudio/biquadfilternode-basic-expected.txt:
• webaudio/biquadfilternode-basic.html:
• webaudio/convolution-mono-mono.html:
• webaudio/delaynode-max-default-delay.html:
• webaudio/delaynode-max-nondefault-delay.html:
• webaudio/delaynode-maxdelay.html:
• webaudio/delaynode-scheduling.html:
• webaudio/delaynode.html:
• webaudio/distance-exponential-expected.txt:
• webaudio/distance-exponential.html:
• webaudio/distance-inverse-expected.txt:
• webaudio/distance-inverse.html:
• webaudio/distance-linear-expected.txt:
• webaudio/distance-linear.html:
• webaudio/gain-basic.html:
• webaudio/gain.html:
• webaudio/javascriptaudionode-zero-input-channels.html:
• webaudio/javascriptaudionode.html:
• webaudio/mixing.html:
• webaudio/note-grain-on-play-expected.txt: Removed.
• webaudio/note-grain-on-play.html: Removed.
• webaudio/note-grain-on-timing-expected.txt: Removed.
• webaudio/note-grain-on-timing.html: Removed.
• webaudio/oscillator-basic-expected.txt:
• webaudio/oscillator-basic.html:
• webaudio/oscillator-custom.html:
• webaudio/oscillator-sawtooth.html:
• webaudio/oscillator-sine.html:
• webaudio/oscillator-square.html:
• webaudio/oscillator-triangle.html:
• webaudio/pannernode-basic-expected.txt:
• webaudio/pannernode-basic.html:
• webaudio/resources/audio-testing.js:
• webaudio/resources/audioparam-testing.js:
• webaudio/resources/biquad-testing.js:
• webaudio/resources/distance-model-testing.js:
• webaudio/resources/javascriptaudionode-testing.js:
• webaudio/resources/oscillator-testing.js:
• webaudio/resources/panner-model-testing.js:
• webaudio/sample-accurate-scheduling.html:
• webaudio/stereo2mono-down-mixing.html:
• webaudio/up-mixing-mono-51.html:
• webaudio/up-mixing-mono-stereo.html:
• webaudio/up-mixing-stereo-51.html:
• webaudio/waveshaper.html:

Update tests for removal of ENABLE_LEGACY_WEB_AUDIO.

5:36 PM Changeset in webkit [205064] by benjamin@webkit.org

• 4 edits
  1 add in trunk

[JSC] Implement CompareStrictEq(String, Untyped) in FTL
​https://bugs.webkit.org/show_bug.cgi?id=161229

Reviewed by Geoffrey Garen.

JSTests:

• stress/compare-strict-eq-on-various-types.js: Added.

Source/JavaScriptCore:

Add (String, Untyped) uses to FTL CompareStrictEq.
This was the last use type not implemented, the node is fully
supported by FTL after this patch.

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
(JSC::FTL::DFG::LowerDFGToB3::compileStringToUntypedStrictEquality):

(JSC::FTL::DFG::LowerDFGToB3::nonSpeculativeCompare):
Remove the type checks when possible.

5:33 PM Changeset in webkit [205063] by bshafiei@apple.com

• 5 edits in branches/safari-602.1.50.0-branch/Source

Versioning.

5:30 PM Changeset in webkit [205062] by commit-queue@webkit.org

• 8 edits in trunk/Source

Web Inspector: Frontend should have access to Resource Timing information
​https://bugs.webkit.org/show_bug.cgi?id=160095

Patch by Johan K. Jensen <​johan_jensen@apple.com> on 2016-08-26
Reviewed by Alex Christensen.

Source/JavaScriptCore:

Rename ResourceTiming property.

• inspector/protocol/Network.json:

Rename navigationStart to startTime so it's applicable
for all resources and not just the main resource.

Source/WebCore:

Show correct information with Resource Timing information
from ResourceLoader rather than DocumentLoader.

No new tests, frontend doesn't use the timing data yet.

• inspector/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::buildObjectForTiming):
(WebCore::InspectorNetworkAgent::buildObjectForResourceResponse):
(WebCore::InspectorNetworkAgent::buildObjectForCachedResource):
(WebCore::InspectorNetworkAgent::willSendRequest):
(WebCore::InspectorNetworkAgent::didReceiveResponse):
(WebCore::InspectorNetworkAgent::didLoadResourceFromMemoryCache):
(WebCore::buildObjectForTiming): Deleted.
(WebCore::buildObjectForResourceResponse): Deleted.
(WebCore::buildObjectForCachedResource): Deleted.
Use ResourceLoader instead of DocumentLoader to get Resource Timing information.
Move functions to member functions to access the executionStopWatch.

(WebCore::InspectorNetworkAgent::didFinishLoading):
Use the load timing finishTime and convert to elapsed time for frontend.

• inspector/InspectorNetworkAgent.h:
• loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didFinishLoading):
Pass the web process load timing on to the inspector.

Source/WTF:

Add method to get elapsed time for any monotonic time.
Used by InspectorNetworkAgent.

• wtf/Stopwatch.h:

(WTF::Stopwatch::elapsedTimeSinceMonotonicTime):

5:13 PM Changeset in webkit [205061] by Chris Dumez

• 4 edits in trunk/Source/WebCore

Unreviewed, fix Windows build after r205048.

• bindings/scripts/CodeGeneratorJS.pm:

(getConditionalForFunctionConsideringOverloads):

• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionSingleConditionalOverload1):
(WebCore::jsTestObjPrototypeFunctionSingleConditionalOverload2):
(WebCore::jsTestObjPrototypeFunctionSingleConditionalOverload):

• bindings/scripts/test/TestObj.idl:

5:04 PM Changeset in webkit [205060] by rniwa@webkit.org

• 15 edits
  3 adds in trunk

Adopted custom element's callbacks should continue to work
​https://bugs.webkit.org/show_bug.cgi?id=161065

Reviewed by Andreas Kling.

Source/WebCore:

When a custom element is adopted into another document, its reaction callbacks need to continue to work.
Because a different document may have its own global object, each custom element needs to remember its
original global object or JSCustomElementInterface. This patch adds the latter to the element rare data.

Tests: fast/custom-elements/connected-callbacks.html

fast/custom-elements/disconnected-callbacks.html

• bindings/js/JSCustomElementInterface.cpp:

(WebCore::JSCustomElementInterface::constructElement):
(WebCore::JSCustomElementInterface::upgradeElement):

• dom/CustomElementReactionQueue.cpp:

(WebCore::findInterfaceForCustomElement): Deleted.
(WebCore::CustomElementReactionQueue::enqueueConnectedCallbackIfNeeded):
(WebCore::CustomElementReactionQueue::enqueueDisconnectedCallbackIfNeeded):
(WebCore::CustomElementReactionQueue::enqueueAttributeChangedCallbackIfNeeded):

• dom/Element.cpp:

(WebCore::Element::insertedInto): Invoke callbacks even when the current document is not a HTML document.
(WebCore::Element::removedFrom): Ditto.
(WebCore::Element::setCustomElementIsResolved): Moved from Node. Add the element interface to the rare data.
(WebCore::Element::customElementInterface): Added.

• dom/Element.h:
• dom/ElementRareData.cpp:
• dom/ElementRareData.h:

(WebCore::ElementRareData::customElementInterface): Added.
(WebCore::ElementRareData::setCustomElementInterface): Added.

• dom/Node.h:

((WebCore::Node::setCustomElementIsResolved): Deleted.

LayoutTests:

Added test cases for adopting custom elements into various kinds of documents.

• fast/custom-elements/connected-callbacks-expected.txt:
• fast/custom-elements/connected-callbacks.html:
• fast/custom-elements/defined-pseudo-class-expected.txt:
• fast/custom-elements/defined-pseudo-class.html:
• fast/custom-elements/disconnected-callbacks-expected.txt:
• fast/custom-elements/disconnected-callbacks.html:
• fast/custom-elements/resources/document-types.js: Added.
• fast/custom-elements/resources/empty-html-document.html: Added.

4:47 PM Changeset in webkit [205059] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Marking webgl/max-active-contexts-webglcontextlost-prevent-default.html as flaky on mac-wk1.
​https://bugs.webkit.org/show_bug.cgi?id=161205

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

4:43 PM Changeset in webkit [205058] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Marking http/tests/media/hls/hls-accessiblity-describes-video-menu.html as flaky on mac-wk1.
​https://bugs.webkit.org/show_bug.cgi?id=161144

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

4:28 PM Changeset in webkit [205057] by jer.noble@apple.com

• 4 edits
  26 adds in trunk

Add a test harness for running UI tests on the iOS Simulator
​https://bugs.webkit.org/show_bug.cgi?id=161265

.:

Add the new MobileMiniBrowser project to the WebKit workspace.

Reviewed by Simon Fraser.

• WebKit.xcworkspace/contents.xcworkspacedata:

Tools:

Reviewed by Simon Fraser.

Add a new iOS Simulator application which uses WKWebView to implement a basic browser, and which
can serve as a test harness for WebKit UI tests.

Also add a basic media playback test which verifies that a <video> element will begin playing in
fullscreen on an iPhone device, but will play inline on an iPad device.

• Makefile: Add MobileMiniBrowser as a Module for iOS builds.
• MobileMiniBrowser/Configurations/Base.xcconfig: Added.
• MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Added.
• MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig: Added.
• MobileMiniBrowser/Makefile: Added.
• MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Added.
• MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h: Added.
• MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Added.

(-[AppDelegate application:didFinishLaunchingWithOptions:]):
(-[AppDelegate applicationWillResignActive:]):
(-[AppDelegate applicationDidEnterBackground:]):
(-[AppDelegate applicationWillEnterForeground:]):
(-[AppDelegate applicationDidBecomeActive:]):
(-[AppDelegate applicationWillTerminate:]):

• MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json: Added.
• MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Added.
• MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Added.
• MobileMiniBrowser/MobileMiniBrowser/Info.plist: Added.
• MobileMiniBrowser/MobileMiniBrowser/TabViewController.h: Added.
• MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Added.

(-[TabViewController dealloc]):
(-[TabViewController viewDidLoad]):
(-[TabViewController observeValueForKeyPath:ofObject:change:context:]):
(-[TabViewController tableView:cellForRowAtIndexPath:]):
(-[TabViewController tableView:numberOfRowsInSection:]):
(-[TabViewController numberOfSectionsInTableView:]):
(-[TabViewController tableView:canEditRowAtIndexPath:]):
(-[TabViewController tableView:canMoveRowAtIndexPath:]):
(-[TabViewController tableView:commitEditingStyle:forRowAtIndexPath:]):
(-[TabViewController tableView:didSelectRowAtIndexPath:]):

• MobileMiniBrowser/MobileMiniBrowser/WebViewController.h: Added.
• MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Added.

(-[WebViewController viewDidLoad]):
(-[WebViewController didReceiveMemoryWarning]):
(-[WebViewController reload:]):
(-[WebViewController goBack:]):
(-[WebViewController goForward:]):
(-[WebViewController urlFieldEditingBegan:]):
(-[WebViewController navigateTo:]):
(-[WebViewController showTabs:]):
(-[WebViewController selectWebViewAtIndex:]):
(-[WebViewController removeWebViewAtIndex:]):
(-[WebViewController addWebView]):
(-[WebViewController createWebView]):
(-[WebViewController removeWebView:]):
(-[WebViewController setCurrentWebView:]):
(-[WebViewController webView:didFailNavigation:withError:]):
(-[WebViewController observeValueForKeyPath:ofObject:change:context:]):

• MobileMiniBrowser/MobileMiniBrowser/main.m: Added.

(main):

• MobileMiniBrowser/MobileMiniBrowserUITests/Info.plist: Added.
• MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m: Added.

(-[MobileMiniBrowserUITests setUp]):
(-[MobileMiniBrowserUITests tearDown]):
(-[MobileMiniBrowserUITests testBasicVideoPlayback]):

4:25 PM Changeset in webkit [205056] by Alan Bujtas

• 3 edits
  2 adds in trunk

ASSERT_NOT_REACHED() is touched in WebCore::minimumValueForLength
​https://bugs.webkit.org/show_bug.cgi?id=125781
<rdar://problem/27684457>

Reviewed by Simon Fraser.

Source/WebCore:

RenderTableSection::calcRowLogicalHeight misused minimumValueForLength to fallback to 0 for non-fixed values.
While this patch fixes the assertion, the table section code needs works to support calc values. See webkit.org/b/161273.

Test: fast/table/assert-on-min-max-content-values.html

• rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):

LayoutTests:

• fast/table/assert-on-min-max-content-values-expected.txt: Added.
• fast/table/assert-on-min-max-content-values.html: Added.

4:10 PM Changeset in webkit [205055] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Rebaseline fast/dom/focus-contenteditable.html for ios-simulator after r205044.

Unreviewed test gardening.

• platform/ios-simulator-wk2/fast/dom/focus-contenteditable-expected.txt:

3:52 PM Changeset in webkit [205054] by aakash_jain@apple.com

• 2 edits in trunk/Tools

webkit-queues queue-status page should should list more recent statuses
​https://bugs.webkit.org/show_bug.cgi?id=161220

Reviewed by Daniel Bates.

• QueueStatusServer/handlers/queuestatus.py:

(QueueStatus._fetch_statuses): Increase the number of recent statuses from 15 to 50.

3:41 PM Changeset in webkit [205053] by akling@apple.com

• 2 edits in trunk/Source/WebCore

REGRESSION (r204987): fast/canvas-composite-* tests are now flaky assertion failures
<​https://webkit.org/b/161259>

Reviewed by Joseph Pecoraro.

Fix a blunder where HTMLCanvasElement::memoryCost() wasn't forwarding the inquiry
to ImageBuffer but HTMLCanvasElement::externalMemoryCost() was.

This fixes flaky "externalMemorySize() <= extraMemorySize()" assertions on debug bots.

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::memoryCost):

3:16 PM Changeset in webkit [205052] by andersca@apple.com

• 3 edits in trunk/Source/WebKit2

Get rid of NetworkResourceLoader::sendAbortingOnFailure
​https://bugs.webkit.org/show_bug.cgi?id=161267

Reviewed by Dan Bernstein.

NetworkResourceLoader::sendAbortingOnFailure sends an IPC message, and if IPC::Connection::send returns false,
it will abort the network resource load.

IPC::Connection::send will only return false if the connection is invalid, and when it becomes invalidated the
connection client member function "didClose" is invoked. For the network process, this will call abort on all outstanding
network loads.

Auditing all the sendAbortingOnFailure call sites, shows that none of them can be called with an invalid connection,
so replace sendAbortingOnFailure with send.

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveResponse):
This is a NetworkLoadClient function which won't be called if the load has been aborted.

(WebKit::NetworkResourceLoader::didReceiveBuffer):
Ditto.

(WebKit::NetworkResourceLoader::didFinishLoading):
Ditto. Also, update a call to sendBufferMaybeAborting to sendBuffer.

(WebKit::NetworkResourceLoader::willSendRedirectedRequest):
This is another NetworkLoadClient function.

(WebKit::NetworkResourceLoader::bufferingTimerFired):
The buffering timer is stopped when abort() is called.

(WebKit::NetworkResourceLoader::sendBuffer):
Rename this from sendBufferMaybeAborting. It has three call sites:

• didReceiveBuffer and didFinishLoading are both NetworkLoadClient functions.
• didRetrieveCacheEntry is called from didFinishLoading (a NetworkLoadClient function) and from the completion function of retrieveCacheEntry, which has an early return for when the loader has been aborted.

(WebKit::NetworkResourceLoader::didRetrieveCacheEntry):
This is called from the retrieveCacheEntry completion function, which has an early return for when the loader has been aborted.

(WebKit::NetworkResourceLoader::dispatchWillSendRequestForCacheEntry):
Ditto.

(WebKit::NetworkResourceLoader::sendAbortingOnFailure): Deleted.

• NetworkProcess/NetworkResourceLoader.h:

3:07 PM Changeset in webkit [205051] by jiewen_tan@apple.com

• 2 edits in trunk/LayoutTests

Unreviewed, update expectations of tests that can either crash or timeout on iOS simulator WK1

• platform/ios-simulator-wk1/TestExpectations:

2:46 PM Changeset in webkit [205050] by akling@apple.com

• 9 edits in trunk

The :enabled/:disabled selectors should only match elements that can be disabled.
<​https://webkit.org/b/161255>

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

• web-platform-tests/html/semantics/selectors/pseudo-classes/disabled-expected.txt:

Source/WebCore:

Per the HTML spec, only the following elements can be actually disabled:

button, input, select, textarea, optgroup, option, menuitem, fieldset

Since HTMLOutputElement inherits from HTMLFormControlElement, it had some
misguided ideas about being disableable. This was causing it to get matched
by :enabled and :disabled selectors.

Test: imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/disabled.html

• css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

• cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):

• css/SelectorCheckerTestFunctions.h:

(WebCore::matchesDisabledPseudoClass):
(WebCore::matchesEnabledPseudoClass): Renamed from isEnabled/isDisabled. Now only allows
:enabled and :disabled selectors to match elements that are actually disableable.

• html/HTMLElement.h:
• html/HTMLElement.cpp:

(WebCore::HTMLElement::canBeActuallyDisabled):
(WebCore::HTMLElement::isActuallyDisabled): Added supporting functions for the aforementioned selectors.

• html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::parseAttribute): Don't care about disabled state
changes in elements that are not disableable in the first place.

2:41 PM Changeset in webkit [205049] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Skipping imported/w3c/web-platform-tests/html/dom/interfaces.html on Mac.
​https://bugs.webkit.org/show_bug.cgi?id=161142

Unreviewed test gardening.

• platform/mac/TestExpectations:

2:34 PM Changeset in webkit [205048] by Chris Dumez

• 5 edits in trunk/Source/WebCore

REGRESSION(r204028): Fix unused-but-set-variable warning in generated JSNavigator.cpp
​https://bugs.webkit.org/show_bug.cgi?id=161252

Reviewed by Ryosuke Niwa.

Improve support for [Conditional] with overloaded operations in the IDL.

No new tests, updated bindings tests.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GeneratePropertiesHashTable):
(getConditionalForFunctionConsideringOverloads):
(GenerateOverloadedFunctionOrConstructor):
(GenerateImplementation):

• bindings/scripts/test/JS/JSTestGlobalObject.cpp:

(WebCore::jsTestGlobalObjectInstanceFunctionEnabledAtRuntimeOperation): Deleted.

• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionConditionalOverload1):
(WebCore::jsTestObjPrototypeFunctionConditionalOverload2):
(WebCore::jsTestObjPrototypeFunctionConditionalOverload):
(WebCore::jsTestObjPrototypeFunctionEnabledAtRuntimeOperation): Deleted.
(WebCore::jsTestObjConstructorFunctionOverloadedMethod1): Deleted.

• bindings/scripts/test/TestObj.idl:

2:23 PM Changeset in webkit [205047] by jiewen_tan@apple.com

• 5 edits
  3 adds in trunk/LayoutTests

Unreviewed, rebase iOS simulator WK1 tables tests

• platform/ios-simulator-wk1/TestExpectations:
• platform/ios-simulator-wk1/tables/mozilla/bugs/bug30559-expected.txt:
• platform/ios-simulator-wk1/tables/mozilla_expected_failures/bugs/bug128876-expected.txt:
• platform/ios-simulator-wk1/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.
• platform/ios-simulator-wk1/tables/mozilla_expected_failures/bugs/bug8499-expected.txt:
• platform/ios-simulator-wk1/transitions/default-timing-function-expected.txt: Added.

2:20 PM Changeset in webkit [205046] by Joseph Pecoraro

• 6 edits
  1 copy
  2 adds in trunk/Source/WebInspectorUI

Web Inspector: Add protocol version for iOS 10
​https://bugs.webkit.org/show_bug.cgi?id=161266
<rdar://problem/28036594>

Rubber-stamped by Brian Burg.

• Localizations/en.lproj/localizedStrings.js:

Update missing localized strings.

• Versions/Inspector-iOS-10.0.json: Added.

Protocol for iOS 10.

• UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
• UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js:

Re-generate the legacy backend commands files.

2:14 PM Changeset in webkit [205045] by ggaren@apple.com

• 2 edits in trunk/Source/bmalloc

2016-08-26 Geoffrey Garen <​ggaren@apple.com>

Unreviewed build fix.

Fix the CMake build.

• CMakeLists.txt:

2:11 PM Changeset in webkit [205044] by Beth Dakin

• 4 edits
  2 adds in trunk

charactersAroundPosition can be wrong because it crosses editing boundaries
​https://bugs.webkit.org/show_bug.cgi?id=161215
-and corresponding-
rdar://problem/27933564

Reviewed by Ryosuke Niwa.

Source/WebCore:

charactersAroundPosition() should not cross editing boundaries. This patch fixes
that by making nextCharacterBoundaryInDirection() take an
EditingBoundaryCrossingRule parameter to pass onto VisiblePosition::next() and
VisiblePosition::previous().

• editing/VisibleUnits.cpp:

(WebCore::nextCharacterBoundaryInDirection):
(WebCore::positionOfNextBoundaryOfGranularity):
(WebCore::charactersAroundPosition):

LayoutTests:

New test.

• editing/mac/spelling/accept-candidate-without-crossing-editing-boundary-expected.txt: Added.
• editing/mac/spelling/accept-candidate-without-crossing-editing-boundary.html: Added.

This test is going back to its pre-https://trac.webkit.org/changeset/195078 state.
That change caused this test to have a different layout because it caused more
layouts to happen. Now that we don’t allow the call to charactersAroundPosition()
to cross editing boundaries, those layouts don’t happen, and we have the old
behavior back.

• platform/mac/fast/dom/focus-contenteditable-expected.txt:

1:59 PM Changeset in webkit [205043] by Joseph Pecoraro

• 5 edits
  1 add in trunk/Source/WebInspectorUI

Web Inspector: Show IndexedDB Database/ObjectStore/Index data in a details sidebar
​https://bugs.webkit.org/show_bug.cgi?id=161180
<rdar://problem/28003417>

Reviewed by Brian Burg.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Main.html:

New strings and file.

• UserInterface/Base/Main.js:

(WebInspector.contentLoaded):
Instantiate the global details sidebar.

• UserInterface/Views/StorageTabContentView.js:

(WebInspector.StorageTabContentView):
Include the new details sidebar in the Storage tab.

• UserInterface/Controllers/StorageManager.js:

(WebInspector.StorageManager.prototype._addIndexedDBDatabasesIfNeeded.processKeyPath):
Use the protocol generated types.

• UserInterface/Views/IndexedDatabaseDetailsSidebarPanel.js: Added.

(WebInspector.IndexedDatabaseDetailsSidebarPanel):
(WebInspector.IndexedDatabaseDetailsSidebarPanel.prototype.inspect):
(WebInspector.IndexedDatabaseDetailsSidebarPanel.prototype.layout):
(WebInspector.IndexedDatabaseDetailsSidebarPanel.prototype._keyPathString):
Show the sidebar for an IndexedDatabase, ObjectStore, or Index.
Show each section if we can based on the objects we have.

1:59 PM Changeset in webkit [205042] by Joseph Pecoraro

• 3 edits
  2 adds in trunk

Web Inspector: Test and address issues in IndexedDB.requestData
​https://bugs.webkit.org/show_bug.cgi?id=161178
<rdar://problem/28002467>

Reviewed by Brian Burg.

Source/WebCore:

Test: inspector/indexeddb/requestData.html

• inspector/InspectorIndexedDBAgent.cpp:

(idbKeyRangeFromKeyRange):
Parsing was too strict. "lower" and "upper" keys are optional.

(WebCore::DataLoader::execute):
Ensure the skip count is passed forward.

LayoutTests:

• inspector/indexeddb/requestData-expected.txt: Added.
• inspector/indexeddb/requestData.html: Added.

1:59 PM Changeset in webkit [205041] by Joseph Pecoraro

• 9 edits
  2 adds in trunk

Web Inspector: Provide a way to clear an IndexedDB object store
​https://bugs.webkit.org/show_bug.cgi?id=161167
<rdar://problem/27996932>

Reviewed by Brian Burg.

Source/JavaScriptCore:

• inspector/protocol/IndexedDB.json:

Cleanup the protocol file.

Source/WebCore:

Test: inspector/indexeddb/clearObjectStore.html

• inspector/InspectorIndexedDBAgent.cpp:

Make the transaction for clearing an object store readwrite
instead of readonly, and activate it.

Source/WebInspectorUI:

• Localizations/en.lproj/localizedStrings.js:

"Clear object store".

• UserInterface/Controllers/StorageManager.js:

(WebInspector.StorageManager.prototype.clearObjectStore):
Provide a wrapper for clearing an object store.

• UserInterface/Views/IndexedDatabaseObjectStoreContentView.js:

(WebInspector.IndexedDatabaseObjectStoreContentView):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype.get navigationItems):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype._clearButtonClicked):
Add a navigation button on ObjectStore content views to clear the object store.

LayoutTests:

• inspector/indexeddb/clearObjectStore-expected.txt: Added.
• inspector/indexeddb/clearObjectStore.html: Added.

1:59 PM Changeset in webkit [205040] by Joseph Pecoraro

• 3 edits
  4 adds in trunk/LayoutTests

Web Inspector: Test IndexedDB.requestDatabase
​https://bugs.webkit.org/show_bug.cgi?id=161122

Reviewed by Brian Burg.

• inspector/indexeddb/requestDatabase-expected.txt: Added.
• inspector/indexeddb/requestDatabase.html: Added.

New tests.

• inspector/indexeddb/deleteDatabaseNamesWithSpace.html:
• inspector/indexeddb/requestDatabaseNames.html:

Share code.

• inspector/indexeddb/resources/utilities.js: Added.

(deleteDatabaseNames):
(createEmptyDatabase):
(createDatabaseWithStores):
Helpers that can be used by each test.

1:59 PM Changeset in webkit [205039] by Joseph Pecoraro

• 5 edits in trunk/LayoutTests

Web Inspector: Modernize inspector/indexeddb tests
​https://bugs.webkit.org/show_bug.cgi?id=161113

Reviewed by Brian Burg.

• inspector/indexeddb/deleteDatabaseNamesWithSpace-expected.txt:
• inspector/indexeddb/deleteDatabaseNamesWithSpace.html:
• inspector/indexeddb/requestDatabaseNames-expected.txt:
• inspector/indexeddb/requestDatabaseNames.html:

1:54 PM Changeset in webkit [205038] by jiewen_tan@apple.com

• 5 edits
  21 adds in trunk/LayoutTests

Unreviewed, rebase iOS simulator WK1 http tests

• platform/ios-simulator-wk1/TestExpectations:
• platform/ios-simulator-wk1/animations/trigger-container-scroll-simple-expected.txt: Added.
• platform/ios-simulator-wk1/css2.1/t040302-c61-ex-len-00-b-a-expected.txt:
• platform/ios-simulator-wk1/http/tests/dom/window-open-about-blank-and-access-document-expected.txt: Added.
• platform/ios-simulator-wk1/http/tests/dom/window-open-about-uppercase-blank-and-access-document-expected.txt: Added.
• platform/ios-simulator-wk1/http/tests/dom/window-open-about-webkit-org-and-access-document-expected.txt: Added.
• platform/ios-simulator-wk1/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/proper-open-window-upgrades-expected.txt: Added.
• platform/ios-simulator-wk1/http/tests/security/cross-origin-modal-dialog-base-expected.txt: Added.
• platform/ios-simulator-wk1/http/tests/security/insecure-geolocation-expected.txt: Added.
• platform/ios-simulator-wk1/http/tests/security/mixedContent/insecure-form-in-main-frame-expected.txt: Added.
• platform/ios-simulator-wk1/http/tests/security/mixedContent/insecure-script-in-data-iframe-in-main-frame-blocked-expected.txt: Added.
• platform/ios-simulator-wk1/http/tests/security/mixedContent/insecure-xhr-sync-in-main-frame-expected.txt: Added.
• platform/ios-simulator-wk1/http/tests/security/mixedcontent-geolocation-block-insecure-content-expected.txt: Added.
• platform/ios-simulator-wk1/http/tests/security/mixedcontent-geolocation-expected.txt: Added.
• platform/ios-simulator-wk1/http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox-expected.txt: Added.
• platform/ios-simulator-wk2/TestExpectations:
• platform/ios-simulator/TestExpectations:

1:35 PM Changeset in webkit [205037] by Chris Dumez

• 7 edits in trunk

Calling crossOriginWindow.toString() should not be allowed
​https://bugs.webkit.org/show_bug.cgi?id=161225

Reviewed by Andreas Kling.

Source/WebCore:

Calling crossOriginWindow.toString() should not be allowed:

• ​https://html.spec.whatwg.org/#crossoriginproperties-(-o-)

In WebKit, we were printing a security error in the console but
returning "[object Window]" anyway.

In Firefox and Chrome, it throws an exception.

No new tests, updated existing test.

• bindings/js/JSDOMWindowCustom.cpp:

(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess):

LayoutTests:

Update existing tests to reflect the behavior change.

• http/tests/security/cross-frame-access-custom-expected.txt:
• http/tests/security/cross-frame-access-custom.html:
• http/tests/security/cross-frame-access-object-setPrototypeOf-expected.txt:
• http/tests/security/cross-frame-access-object-setPrototypeOf.html:

1:33 PM Changeset in webkit [205036] by mitz@apple.com

• 4 edits in trunk

[Cocoa] Infinite recursion calling -charValue on a WKNSNumber
​https://bugs.webkit.org/show_bug.cgi?id=161258

Reviewed by Anders Carlsson.

Source/WebKit2:

• Shared/Cocoa/WKNSNumber.mm:

(-[WKNSNumber charValue]): Override this…
(-[WKNSNumber boolValue]): …not this.

Tools:

• TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm:

(TestWebKitAPI::TEST):

1:29 PM Changeset in webkit [205035] by commit-queue@webkit.org

• 19 edits in trunk

Web Inspector: Some CSS selectors in the UI aren't escaped
​https://bugs.webkit.org/show_bug.cgi?id=151378

Patch by Devin Rousso <Devin Rousso> on 2016-08-26
Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

Change ElementData from sending a className string to using an array of
classes, allowing for proper escaping of each class value.

• inspector/protocol/OverlayTypes.json:

Source/WebCore:

No new tests, but logic and results of existing tests updated:

• inspector/dom/content-node-region-info.html:
• inspector/dom/content-node-region-info-expected.txt:
• inspector/dom/highlightNode-expected.txt:
• inspector/dom/highlightSelector.html:
• inspector/dom/highlightSelector-expected.txt:

• inspector/InspectorOverlay.cpp:

(WebCore::buildObjectForElementData):

• inspector/InspectorOverlayPage.css:

(.pseudo-type):
(.tag-name): Deleted.

• inspector/InspectorOverlayPage.js:

(_createElementTitle):

Source/WebInspectorUI:

• UserInterface/Base/DOMUtilities.js:

(WebInspector.displayNameForNode): Deleted.
(WebInspector.linkifyNodeReference):
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.

• UserInterface/Models/DOMNode.js:

(WebInspector.DOMNode.prototype.get escapedIdSelector):
(WebInspector.DOMNode.prototype.get escapedClassSelector):
(WebInspector.DOMNode.prototype.get displayName):
(WebInspector.DOMNode.prototype.appropriateSelectorFor):
Rework escaping of ids and class names into separate public functions using CSS.escape.

• UserInterface/Views/CSSStyleDeclarationSection.js:

(WebInspector.CSSStyleDeclarationSection.prototype.refresh):
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.

• UserInterface/Views/DOMTreeDataGridNode.js:

(WebInspector.DOMTreeDataGridNode.prototype._createNameCellDocumentFragment):
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.

• UserInterface/Views/DOMTreeElementPathComponent.js:

(WebInspector.DOMTreeElementPathComponent):
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.

• UserInterface/Views/LayerTreeDataGridNode.js:

(WebInspector.LayerTreeDataGridNode.prototype.set layer):
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.

• UserInterface/Views/VisualStyleSelectorSection.js:

(WebInspector.VisualStyleSelectorSection.prototype.update):
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.

LayoutTests:

• inspector/dom/content-node-region-info.html:
• inspector/dom/content-node-region-info-expected.txt:

Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.

• inspector/dom/highlightNode-expected.txt:
• inspector/dom/highlightSelector.html:
• inspector/dom/highlightSelector-expected.txt:

Changed result to replace className with new classes array.

1:22 PM Changeset in webkit [205034] by Joseph Pecoraro

• 5 edits in trunk/Source/JavaScriptCore

Web Inspector: ScriptProfilerAgent and HeapAgent should do less work when frontend disconnects
​https://bugs.webkit.org/show_bug.cgi?id=161213
<rdar://problem/28017986>

Reviewed by Brian Burg.

• inspector/agents/InspectorHeapAgent.cpp:

(Inspector::InspectorHeapAgent::willDestroyFrontendAndBackend):
Don't take a final snapshot when disconnecting.

• inspector/agents/InspectorScriptProfilerAgent.cpp:

(Inspector::InspectorScriptProfilerAgent::willDestroyFrontendAndBackend):
(Inspector::InspectorScriptProfilerAgent::stopSamplingWhenDisconnecting):

• inspector/agents/InspectorScriptProfilerAgent.h:
• runtime/SamplingProfiler.h:

Don't process samples when disconnecting.

1:22 PM Changeset in webkit [205033] by Joseph Pecoraro

• 3 edits in trunk/Source/JavaScriptCore

Web Inspector: HeapProfiler/ScriptProfiler do not destruct safely when JSContext is destroyed
​https://bugs.webkit.org/show_bug.cgi?id=161027
<rdar://problem/27871349>

Reviewed by Mark Lam.

For JSContext inspection, when a frontend connects keep the target alive.
This means ref'ing the JSGlobalObject / VM when the first frontend
connects and deref'ing when the last frontend disconnects.

• inspector/JSGlobalObjectInspectorController.h:
• inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::globalObjectDestroyed):
(Inspector::JSGlobalObjectInspectorController::disconnectAllFrontends): Deleted.
Now that frontends keep the global object alive, when the global object
is destroyed that must mean that no frontends exist. Remove the now
stale code path.

(Inspector::JSGlobalObjectInspectorController::connectFrontend):
(Inspector::JSGlobalObjectInspectorController::disconnectFrontend):
Ref the target when the first frontend connects, deref when the last disconnects.

1:18 PM Changeset in webkit [205032] by ggaren@apple.com

• 8 edits
  3 moves in trunk

Renamed XLarge* => Large*
​https://bugs.webkit.org/show_bug.cgi?id=161261

Reviewed by Andreas Kling.

XLarge is not a thing anymore: We just have Small and Large.

• bmalloc.xcodeproj/project.pbxproj:
• bmalloc/Heap.cpp:

(bmalloc::Heap::splitAndAllocate):
(bmalloc::Heap::tryAllocateLarge):
(bmalloc::Heap::shrinkLarge):
(bmalloc::Heap::deallocateLarge):

• bmalloc/Heap.h:
• bmalloc/LargeMap.cpp: Copied from Source/bmalloc/bmalloc/XLargeMap.cpp.

(bmalloc::LargeMap::remove):
(bmalloc::LargeMap::add):
(bmalloc::XLargeMap::remove): Deleted.
(bmalloc::XLargeMap::add): Deleted.

• bmalloc/LargeMap.h: Copied from Source/bmalloc/bmalloc/XLargeMap.h.

(bmalloc::LargeMap::ranges):
(bmalloc::XLargeMap::ranges): Deleted.

• bmalloc/LargeRange.h: Copied from Source/bmalloc/bmalloc/XLargeRange.h.

(bmalloc::LargeRange::LargeRange):
(bmalloc::LargeRange::operator<):
(bmalloc::canMerge):
(bmalloc::merge):
(bmalloc::LargeRange::split):
(bmalloc::XLargeRange::XLargeRange): Deleted.
(bmalloc::XLargeRange::operator<): Deleted.
(bmalloc::XLargeRange::split): Deleted.

• bmalloc/VMHeap.cpp:

(bmalloc::VMHeap::tryAllocateLargeChunk):

• bmalloc/VMHeap.h:
• bmalloc/XLargeMap.cpp: Removed.
• bmalloc/XLargeMap.h: Removed.
• bmalloc/XLargeRange.h: Removed.

11:12 AM Changeset in webkit [205031] by Brent Fulgham

• 3 edits in trunk/Source/WebCore

Crash when getting font bounding rect
​https://bugs.webkit.org/show_bug.cgi?id=161202
<rdar://problem/27986981>

Reviewed by Myles C. Maxfield.

We should never store GlyphData objects for later use, because they contain raw pointers to Font elements
contained in caches, and those font caches get periodically purged.

Instead, we should hold onto the ‘key’ representing the GlyphData, and simply ask the system for the
GlyphData the next time it is needed.

Tested by existing MathML tests under ASAN and GuardMalloc.

• rendering/mathml/RenderMathMLToken.cpp:

(WebCore::RenderMathMLToken::RenderMathMLToken): Clean up constructors.
(WebCore::RenderMathMLToken::computePreferredLogicalWidths): Use keys to get correct GlyphData when needed.
(WebCore::RenderMathMLToken::updateMathVariantGlyph): Ditto.
(WebCore::RenderMathMLToken::firstLineBaseline): Ditto.
(WebCore::RenderMathMLToken::layoutBlock): Ditto.
(WebCore::RenderMathMLToken::paint): Ditto.
(WebCore::RenderMathMLToken::paintChildren): Ditto.

• rendering/mathml/RenderMathMLToken.h:

11:09 AM Changeset in webkit [205030] by Chris Dumez

• 9 edits in trunk

HTMLAreaElement's coords attributes parsing does not comply with the HTML specification
​https://bugs.webkit.org/show_bug.cgi?id=161216

Reviewed by Andreas Kling.

LayoutTests/imported/w3c:

Rebaseline W3C test now that all checks are passing. Chrome is also passing all the checks.

• web-platform-tests/html/semantics/embedded-content/the-area-element/area-coords-expected.txt:

Source/WebCore:

HTMLAreaElement's coords attributes parsing does not comply with the HTML specification:

• ​https://html.spec.whatwg.org/#attr-area-coords

This patch aligns our parsing of this attribute with the specification and Chrome.

No new tests, rebaselined existing test.

• html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::HTMLAreaElement):
(WebCore::HTMLAreaElement::parseAttribute):
(WebCore::HTMLAreaElement::getRegion):

• html/HTMLAreaElement.h:
• html/parser/HTMLParserIdioms.cpp:

(WebCore::isHTMLSpaceOrDelimiter):
(WebCore::isNumberStart):
(WebCore::parseHTMLListOfOfFloatingPointNumberValuesInternal):
(WebCore::parseHTMLListOfOfFloatingPointNumberValues):
(WebCore::parseHTMLNonNegativeInteger): Deleted.

• html/parser/HTMLParserIdioms.h:

LayoutTests:

Unskip web-platform-tests/html/semantics/embedded-content/the-area-element/area-coords.html
as it is now passing and not longer crashing in debug builds.

• TestExpectations:

11:00 AM Changeset in webkit [205029] by Csaba Osztrogonác

• 2 edits in trunk/Source/WebCore

Fix the !ENABLE(WEB_SOCKETS) build
​https://bugs.webkit.org/show_bug.cgi?id=161251

Reviewed by Alex Christensen.

• page/SocketProvider.h:

10:58 AM Changeset in webkit [205028] by Csaba Osztrogonác

• 3 edits in trunk/Source/WebCore

Fix the !ENABLE(WEB_TIMING) build
​https://bugs.webkit.org/show_bug.cgi?id=161250

Reviewed by Alex Christensen.

• loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didFinishLoading):

• loader/cache/CachedResourceLoader.h:

(WebCore::CachedResourceLoader::resourceTimingInformation):

10:37 AM Changeset in webkit [205027] by Yusuke Suzuki

• 3 edits
  1 add in trunk

[ES6] newPromiseCapabilities should check the given argument is constructor
​https://bugs.webkit.org/show_bug.cgi?id=161226

Reviewed by Mark Lam.

JSTests:

The arrow function should not be a constructor. So the error should be raised.

• stress/new-promise-capabilities-requires-constructor.js: Added.

(shouldThrow):

Source/JavaScriptCore:

Use @isConstructor.

• builtins/PromiseOperations.js:

10:36 AM Changeset in webkit [205026] by Chris Dumez

• 40 edits in trunk

Trying to access cross-origin Location properties should throw a SecurityError
​https://bugs.webkit.org/show_bug.cgi?id=161248

Reviewed by Alex Christensen.

Source/WebCore:

Trying to access cross-origin Location properties should throw a SecurityError:

• ​https://html.spec.whatwg.org/#crossorigingetownpropertyhelper-(-o,-p-)
• ​https://html.spec.whatwg.org/#crossoriginproperties-(-o-)

Firefox and Chrome already throw. However, WebKit was logging an error message
and returning undefined.

No new tests, updated existing tests.

• bindings/js/JSDOMBinding.cpp:

(WebCore::throwSecurityError):

• bindings/js/JSDOMBinding.h:
• bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::getOwnPropertySlotDelegate):

LayoutTests:

Update existing tests to reflect behavior change.

• http/tests/plugins/cross-frame-object-access-expected.txt:
• http/tests/plugins/resources/cross-frame-object-access.html:
• http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
• http/tests/security/XFrameOptions/x-frame-options-deny.html:
• http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-parent-same-origin-deny-expected.txt:
• http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-parent-same-origin-deny.html:
• http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
• http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny.html:
• http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
• http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html:
• http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt:
• http/tests/security/cross-frame-access-child-explicit-domain-expected.txt:
• http/tests/security/cross-frame-access-custom-expected.txt:
• http/tests/security/cross-frame-access-getOwnPropertyDescriptor-expected.txt:
• http/tests/security/cross-frame-access-history-get-expected.txt:
• http/tests/security/cross-frame-access-history-get-override-expected.txt:
• http/tests/security/cross-frame-access-location-get-expected.txt:
• http/tests/security/cross-frame-access-location-get-override-expected.txt:
• http/tests/security/cross-frame-access-parent-explicit-domain-expected.txt:
• http/tests/security/cross-frame-access-port-expected.txt:
• http/tests/security/cross-frame-access-protocol-expected.txt:
• http/tests/security/cross-frame-access-protocol-explicit-domain-expected.txt:
• http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
• http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
• http/tests/security/location-cross-origin-expected.txt:
• http/tests/security/location-cross-origin.html:
• http/tests/security/resources/cross-frame-access.js:

(canGet):
(canGetDescriptor):
(canCall):
(toString):

• http/tests/security/sandboxed-iframe-blocks-access-from-parent-expected.txt:
• http/tests/security/xss-DENIED-defineProperty-expected.txt:
• http/tests/security/xss-DENIED-defineProperty.html:
• http/tests/security/xssAuditor/block-does-not-leak-location-expected.txt:
• http/tests/security/xssAuditor/block-does-not-leak-location.html:
• http/tests/security/xssAuditor/full-block-script-tag-cross-domain-expected.txt:
• http/tests/security/xssAuditor/full-block-script-tag-cross-domain.html:
• http/tests/security/xssAuditor/resources/utilities.js:

(checkIfFrameLocationMatchesSrcAndCallDone):

10:36 AM Changeset in webkit [205025] by pvollan@apple.com

• 3 edits in trunk/Source/WebCore

[Win] Warning fixes.
​https://bugs.webkit.org/show_bug.cgi?id=161241

Reviewed by Brent Fulgham.

MSVC warns about potential use of uninitialized variables.

• accessibility/AXObjectCache.cpp:
• css/parser/CSSParserValues.cpp:

10:13 AM Changeset in webkit [205024] by eric.carlson@apple.com

• 13 edits
  4 adds in trunk

[MediaStream] Add support for OverConstrainedErrorEvent
​https://bugs.webkit.org/show_bug.cgi?id=161199
<rdar://problem/28011819>

Reviewed by Jer Noble.

Source/WebCore:

Test: fast/events/constructors/overconstrained-error-event-constructor.html

• CMakeLists.txt:
• DerivedSources.make:
• Modules/mediastream/OverconstrainedErrorEvent.h: Added.

(WebCore::OverconstrainedErrorEvent::~OverconstrainedErrorEvent):
(WebCore::OverconstrainedErrorEvent::create):
(WebCore::OverconstrainedErrorEvent::createForBindings):
(WebCore::OverconstrainedErrorEvent::error):
(WebCore::OverconstrainedErrorEvent::eventInterface):
(WebCore::OverconstrainedErrorEvent::OverconstrainedErrorEvent):

• Modules/mediastream/OverconstrainedErrorEvent.idl: Added.

• WebCore.xcodeproj/project.pbxproj: Add new files.

• bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue): Add OverconstrainedErrorEvent converter.

• bindings/js/JSDictionary.h:

• dom/EventNames.in: Add OverconstrainedErrorEvent.

LayoutTests:

• fast/events/constructors/overconstrained-error-event-constructor-expected.txt: Added.
• fast/events/constructors/overconstrained-error-event-constructor.html: Added.
• js/dom/global-constructors-attributes-expected.txt: Updated.
• platform/gtk/js/dom/global-constructors-attributes-expected.txt:
• platform/mac/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:

10:05 AM Changeset in webkit [205023] by keith_miller@apple.com

• 10 edits in trunk

toString called on proxies returns incorrect tag
​https://bugs.webkit.org/show_bug.cgi?id=161111

Reviewed by Benjamin Poulain.

This patch adds a new Method table function toStringName. This function
is used by Object.prototype.toString to create the string tag that it
inserts. Right now it only changes the stringification of proxy objects.
In future patches I plan to make it work for other classes of objects as
well.

• runtime/ClassInfo.h:
• runtime/JSCell.cpp:

(JSC::JSCell::toStringName):

• runtime/JSCell.h:
• runtime/JSObject.cpp:

(JSC::JSObject::toStringName):

• runtime/JSObject.h:
• runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncToString):

• runtime/ProxyObject.cpp:

(JSC::ProxyObject::toStringName):

• runtime/ProxyObject.h:

10:02 AM Changeset in webkit [205022] by barraclough@apple.com

• 4 edits
  2 deletes in trunk/Source/bmalloc

bmalloc: speed up the lock slow path
​https://bugs.webkit.org/show_bug.cgi?id=161058

Unreviewed rollout - this caused regressions <rdar://problem/28026089>.

• bmalloc.xcodeproj/project.pbxproj:
• bmalloc/ScopeExit.h: Removed.
• bmalloc/StaticMutex.cpp:

(bmalloc::StaticMutex::lockSlowCase):

• bmalloc/StaticMutex.h:

(bmalloc::StaticMutex::init):

• bmalloc/ThreadSwitch.h: Removed.

9:54 AM Changeset in webkit [205021] by Csaba Osztrogonác

• 19 edits in trunk

Fix the ENABLE(WEBASSEMBLY) build on Linux
​https://bugs.webkit.org/show_bug.cgi?id=161197

Reviewed by Mark Lam.

Source/JavaScriptCore:

• CMakeLists.txt:
• b3/B3Common.cpp:

(JSC::B3::shouldDumpIR):

• shell/CMakeLists.txt:
• wasm/JSWASMModule.h:
• wasm/WASMB3IRGenerator.cpp:

(JSC::WASM::toB3Op):

• wasm/WASMB3IRGenerator.h:
• wasm/WASMFormat.h:
• wasm/WASMFunctionParser.h:
• wasm/WASMModuleParser.cpp:

(JSC::WASM::WASMModuleParser::parseFunctionTypes):

• wasm/WASMModuleParser.h:
• wasm/WASMParser.h:
• wasm/WASMPlan.cpp:
• wasm/WASMPlan.h:
• wasm/WASMSections.cpp:

Source/WTF:

• wtf/Platform.h:

Tools:

• Scripts/build-jsc:

9:50 AM Changeset in webkit [205020] by pvollan@apple.com

• 2 edits in trunk/Source/JavaScriptCore

[Win] Compile fix.
​https://bugs.webkit.org/show_bug.cgi?id=161235

Reviewed by Brent Fulgham.

YarrPattern::errorMessage has inconsistent dll linkage.

• yarr/YarrPattern.h:

9:50 AM Changeset in webkit [205019] by bshafiei@apple.com

• 1 copy in tags/Safari-602.1.50.0.7

New tag.

9:41 AM Changeset in webkit [205018] by commit-queue@webkit.org

• 7 edits in trunk

The annotation-xml element does not need to be behave as an mrow
​https://bugs.webkit.org/show_bug.cgi?id=161230

Patch by Frederic Wang <​fwang@igalia.com> on 2016-08-26
Reviewed by Manuel Rego Casasnovas.

Source/WebCore:

In r204779, MathMLAnnotationElement was made a MathMLRowElement just because the
annotation-xml element is generating a RenderMathMLRow. This later point is actually not
needed since annotation-xml is just a wrapper for foreign elements and so does not need to
handle special MathML features like operator spacing or stretching. We can thus move back
MathMLAnnotationElement to a generic MathMLPresentationElement and instead make the
annotation-xml element generate a generic RenderMathMLBlock renderer.

No new tests, semantics annotations already covered by existing tests.

• mathml/MathMLAnnotationElement.cpp: Replace RenderMathMLRow.h with RenderMathMLBlock.h

(WebCore::MathMLAnnotationElement::MathMLAnnotationElement): Inherit from
MathMLPresentationElement instead of MathMLRowElement.
(WebCore::MathMLAnnotationElement::createElementRenderer): Make annotation-xml create a
RenderMathMLBlock instead of a RenderMathMLRow.
(WebCore::MathMLAnnotationElement::attributeChanged): Inherit from MathMLPresentationElement
instead of MathMLRowElement.

• mathml/MathMLAnnotationElement.h: Ditto.

LayoutTests:

• platform/efl/accessibility/math-foreign-content-expected.txt: Remove the AXGroup from the

test expectation, which that was used for annotation-xml.

• platform/gtk/accessibility/math-foreign-content-expected.txt: Ditto.
• platform/mac/accessibility/math-foreign-content-expected.txt: Ditto.

9:36 AM Changeset in webkit [205017] by clopez@igalia.com

• 2 edits in trunk/Tools

[GTK] run-gtk-tests should use the driver environment for checking the accessibility bus
​https://bugs.webkit.org/show_bug.cgi?id=161149

Reviewed by Carlos Garcia Campos.

Add a new function for waiting for the accesibility bus. It sets
the test environment variables before starting the GLib mainloop.
And restores the previous environment after it has finished.
It also adds a timeout (5 seconds) to abort in case it has not
been able to detect the accesibility bus before the timeout expires.

• Scripts/run-gtk-tests:

(TestRunner):
(TestRunner._wait_for_accessibility_bus):
(TestRunner._wait_for_accessibility_bus.timeout_accessibility_bus):
(TestRunner._start_accessibility_daemons):
(TestRunner._get_tests_from_google_test_suite): Run this command also with the driver test environment.

9:35 AM Changeset in webkit [205016] by pvollan@apple.com

• 2 edits in trunk/Tools

[Win] Warning fix.
​https://bugs.webkit.org/show_bug.cgi?id=161236

Reviewed by Brent Fulgham.

The & operator in the Test struct has no body.

• TestWebKitAPI/Tests/WTF/Vector.cpp:

(TestWebKitAPI::TEST):

9:33 AM Changeset in webkit [205015] by Csaba Osztrogonác

• 2 edits in trunk/Source/WebCore

Typo fix after r56209
​https://bugs.webkit.org/show_bug.cgi?id=161246

Reviewed by Gyuyoung Kim.

• page/FrameView.cpp:

(WebCore::FrameView::adjustMediaTypeForPrinting):

9:32 AM Changeset in webkit [205014] by clopez@igalia.com

• 8 edits in trunk/Tools

[GTK] run-gtk-tests should use webkitpy.port.gtk and webkitpy.port.xvfbdriver
​https://bugs.webkit.org/show_bug.cgi?id=160736

Reviewed by Carlos Garcia Campos.

This plugs run-gtk-tests into the webkitpy testing infrastructure.
As a benefit of this, run-gtk-tests now can be executed over any of
the existing supported gtk test display servers (xvfb, weston-over-xvfb,
or native xorg). A new command line switch --wayland is added for
run-gtk-tests.

• Scripts/run-gtk-tests:

(TestRunner.init): Remove the --display command line switch, its not longer useful.
Add a --wayland command line switch.
(TestRunner._start_accessibility_daemons):
(TestRunner):
(TestRunner.init):
(TestRunner._run_xvfb): Deleted.
(TestRunner._create_driver):
(TestRunner._setup_testing_environment): Delete the environment variable definitions that
are now done by driver._setup_environ_for_test().
(TestRunner._tear_down_testing_environment):

• Scripts/webkitpy/port/driver.py:

(Driver.init): Define self._server_name in the constructor of the base class.
It is used by several functions, so it makes sense to store once the value here.
(Driver._setup_environ_for_test): Factorize setting the environment for a given test.
(Driver._start): Get the environment from self._setup_environ_for_test()

• Scripts/webkitpy/port/driver_unittest.py:

(DriverTest):
(DriverTest.test_setup_environ_for_test): Add unittest for driver._setup_environ_for_test()

• Scripts/webkitpy/port/gtk.py: Move the inspection of the env var USE_NATIVE_XDISPLAY to the constructor.

(GtkPort.init):
(GtkPort._driver_class):

• Scripts/webkitpy/port/westondriver.py: Define and use self._setup_environ_for_test()

(WestonDriver._setup_environ_for_test):
(WestonDriver._start):

• Scripts/webkitpy/port/xorgdriver.py: Define and use self._setup_environ_for_test()

(XorgDriver._setup_environ_for_test):
(XorgDriver._start):

• Scripts/webkitpy/port/xvfbdriver.py: Define and use self._setup_environ_for_test()

(XvfbDriver._setup_environ_for_test):
(XvfbDriver._start):

9:04 AM Changeset in webkit [205013] by ap@apple.com

• 2 edits in trunk/LayoutTests

Reinstate flakiness expectations for viewport tests, as they are still flaky.
​https://bugs.webkit.org/show_bug.cgi?id=153110

• platform/ios-simulator-wk2/TestExpectations:

7:04 AM Changeset in webkit [205012] by Csaba Osztrogonác

• 5 edits in trunk

[EFL][GTK] REGRESSION(204877): Fix the clean build
​https://bugs.webkit.org/show_bug.cgi?id=161240

Reviewed by Carlos Garcia Campos.

Source/WebKit2:

• Scripts/generate-forwarding-headers.pl: Added back multiple include-path support. (removed by r183389)

Tools:

• WebKitTestRunner/PlatformEfl.cmake:
• WebKitTestRunner/PlatformGTK.cmake:

6:29 AM Changeset in webkit [205011] by pvollan@apple.com

• 15 edits in trunk/Source/WebCore

[Win] Warning fixes.
​https://bugs.webkit.org/show_bug.cgi?id=161077

Reviewed by Brent Fulgham.

• css/CSSGrammar.y.includes:
• css/RuleFeature.cpp:

(WebCore::makeAttributeSelectorKey):

• editing/TextIterator.cpp:

(WebCore::SearchBuffer::SearchBuffer):

• html/HTMLElement.cpp:

(WebCore::HTMLElement::textToFragment):

• html/MediaElementSession.h:
• platform/URL.cpp:
• platform/graphics/ca/GraphicsLayerCA.cpp:
• platform/network/HTTPParsers.cpp:

(WebCore::parseHTTPHeader):

• rendering/InlineIterator.h:

(WebCore::InlineIterator::clear):

• rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::FlexBoxIterator::reset):

• rendering/RenderText.cpp:

(WebCore::RenderText::secureText):

• rendering/mathml/RenderMathMLToken.cpp:

(WebCore::mathVariant):

• style/InlineTextBoxStyle.cpp:

(WebCore::visualOverflowForDecorations):

• xml/XPathGrammar.y:

3:54 AM Changeset in webkit [205010] by aakash_jain@apple.com

• 2 edits in trunk/Tools

EWS should indicate which bot processed the patch
​https://bugs.webkit.org/show_bug.cgi?id=161222

Reviewed by Daniel Bates.

• QueueStatusServer/handlers/statusbubble.py:

(StatusBubble._build_bubble): Display the bot id in status bubble. Also removed "Started processing" message since
after bug fix of 161223, bots send the "Started processing patch" message and it would be displayed in Recent messages.
Also added "Started processing patch" message to progress_statuses.
I might consider displaying bot id in other statuses as well later on.

1:46 AM Changeset in webkit [205009] by Gyuyoung Kim

• 2 edits in trunk/Source/WebKit2

Unreviewed EFL build fix since r204996.

Patch by Gyuyoung Kim <​gyuyoung.kim@navercorp.com> on 2016-08-26

• UIProcess/efl/WebPageProxyEfl.cpp:

(WebKit::WebPageProxy::editorStateChanged):
(WebKit::WebPageProxy::setThemePath):
(WebKit::WebPageProxy::confirmComposition):
(WebKit::WebPageProxy::setComposition):
(WebKit::WebPageProxy::cancelComposition):

1:04 AM Changeset in webkit [205008] by nael.ouedraogo@crf.canon.fr

• 27 edits in trunk

Make custom constructors consistent with generated bindings code
​https://bugs.webkit.org/show_bug.cgi?id=159550

Reviewed by Youenn Fablet.

Add assertion to check DOMConstructorObject* passed in ExecState is not null.
Rename throwConstructorDocumentUnavailableError to throwConstructorScriptExecutionContextUnavailableError since
ScriptExecutionContext is not necessarily a Document.
Modify error message in case of argument error to be consistent with generated binding code: replace calls to
throwVMError with calls to throwConstructorScriptExecutionContextUnavailableError and throwArgumentTypeError.

No new test required. Modify tests and tests expectations to align with new error messages.

Source/WebCore:

• bindings/js/JSAudioContextCustom.cpp:

(WebCore::constructJSAudioContext):

• bindings/js/JSBlobCustom.cpp:

(WebCore::constructJSBlob):

• bindings/js/JSDOMBinding.cpp:

(WebCore::throwConstructorScriptExecutionContextUnavailableError):

• bindings/js/JSDOMBinding.h:
• bindings/js/JSDOMConstructor.h:

(WebCore::JSBuiltinConstructor<JSClass>::callConstructor):

• bindings/js/JSDOMFormDataCustom.cpp:

(WebCore::constructJSDOMFormData):

• bindings/js/JSDataCueCustom.cpp:

(WebCore::constructJSDataCue):

• bindings/js/JSFileCustom.cpp:

(WebCore::constructJSFile):

• bindings/js/JSHTMLElementCustom.cpp:

(WebCore::constructJSHTMLElement):

• bindings/js/JSMediaSessionCustom.cpp:

(WebCore::constructJSMediaSession):

• bindings/js/JSMutationObserverCustom.cpp:

(WebCore::constructJSMutationObserver):

• bindings/js/JSReadableStreamPrivateConstructors.cpp:

(WebCore::constructJSReadableStreamDefaultReader):

• bindings/js/JSWorkerCustom.cpp:

(WebCore::constructJSWorker):

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallbackImplementation):
(NativeToJSValue):
(GenerateHashTableValueArray):
(GenerateConstructorDefinition):

• bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructorConstructor::construct):

• bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::construct):

• bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorNamedConstructor::construct):

• bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::JSTestNodeConstructor::construct):

• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::construct):

• bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::constructJSTestOverloadedConstructors1):
(WebCore::constructJSTestOverloadedConstructors2):
(WebCore::constructJSTestOverloadedConstructors3):
(WebCore::constructJSTestOverloadedConstructors4):
(WebCore::constructJSTestOverloadedConstructors5):

• bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:

(WebCore::constructJSTestOverloadedConstructorsWithSequence1):
(WebCore::constructJSTestOverloadedConstructorsWithSequence2):

• bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefsConstructor::construct):

LayoutTests:

• fast/dom/MutationObserver/mutation-observer-constructor-expected.txt:
• fast/files/file-constructor-expected.txt:
• fast/files/file-constructor.html:

12:36 AM Changeset in webkit [205007] by Gyuyoung Kim

• 2 edits in trunk/Tools

[EFL] Change homepage url to www.ewebkit.org on MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=161184

Reviewed by Carlos Garcia Campos.

• MiniBrowser/efl/main.c: Set www.ewebkit.org.

12:34 AM Changeset in webkit [205006] by bshafiei@apple.com

• 5 edits in tags/Safari-601.7.7.1/Source

Versioning.

12:32 AM Changeset in webkit [205005] by bshafiei@apple.com

• 1 copy in tags/Safari-601.7.7.1

New tag.