Timeline
Sep 22, 2016:
- 10:31 PM Changeset in webkit [206293] by
-
- 9 edits in tags/Safari-603.1.6.0.2
Roll out r206165. rdar://problem/28435943
- 10:29 PM Changeset in webkit [206292] by
-
- 5 edits in tags/Safari-603.1.6.0.2/Source
Versioning.
- 10:25 PM Changeset in webkit [206291] by
-
- 1 copy in tags/Safari-603.1.6.0.2
New tag.
- 9:16 PM Changeset in webkit [206290] by
-
- 2 edits in trunk/Tools
[EFL] alert box is not displayed
https://bugs.webkit.org/show_bug.cgi?id=156395
Reviewed by Gyuyoung Kim.
Some popup objects(alert, confirm, prompt, file entry dialog) used the ecore_main_loop_begin() to make
the modal popup but ecore_main_loop_begin() was not executed inside an exisiting main loop. So we have
to use the ecore_main_loop_iterate() instead of the ecore_main_loop_begin().
- MiniBrowser/efl/main.c:
(_ok_clicked_cb):
(_file_entry_dialog_show):
(_javascript_alert_cb):
(_javascript_confirm_cb):
(_javascript_prompt_cb):
(quit_event_loop): Deleted.
- 8:50 PM Changeset in webkit [206289] by
-
- 26 edits1 add in trunk
[JSC] Use an inline cache to generate op_negate
https://bugs.webkit.org/show_bug.cgi?id=162371
Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-09-22
Reviewed by Saam Barati.
JSTests:
- stress/op-negate-inline-cache.js: Added.
Source/JavaScriptCore:
Use an inline cache to reduce the amount of code
required to implement op_negate.
For pure integer negate, the generated asm shrinks
from 147 bytes to 125 bytes (14%).
For double negate, the generated asm shrinks
to 130 bytes (11%).
The average size on Sunspider is 100bytes, this is due
to the op_negates that are never executed and do not
generate much.
- bytecode/ArithProfile.h:
(JSC::ArithProfile::ArithProfile):
(JSC::ArithProfile::observeLHS):
(JSC::ArithProfile::observeLHSAndRHS):
- bytecode/BytecodeList.json:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::addJITNegIC):
- bytecode/CodeBlock.h:
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitUnaryOp):
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp:
(JSC::UnaryOpNode::emitBytecode):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileMathIC):
- dfg/DFGSpeculativeJIT.h:
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileMathIC):
- jit/CCallHelpers.h:
(JSC::CCallHelpers::setupArgumentsWithExecState):
- jit/JIT.h:
- jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_negate):
(JSC::JIT::emitSlow_op_negate):
(JSC::JIT::emitMathICFast):
(JSC::JIT::emitMathICSlow):
- jit/JITInlines.h:
(JSC::JIT::callOperation):
- jit/JITMathIC.h:
(JSC::JITMathIC::generateInline):
(JSC::canGenerateWithBinaryProfile):
(JSC::canGenerateWithUnaryProfile):
- jit/JITMathICForwards.h:
- jit/JITNegGenerator.cpp:
(JSC::JITNegGenerator::generateInline):
(JSC::JITNegGenerator::generateFastPath):
- jit/JITNegGenerator.h:
(JSC::JITNegGenerator::JITNegGenerator):
(JSC::JITNegGenerator::arithProfile):
(JSC::JITNegGenerator::didEmitFastPath): Deleted.
(JSC::JITNegGenerator::endJumpList): Deleted.
(JSC::JITNegGenerator::slowPathJumpList): Deleted.
- jit/JITOperations.cpp:
- jit/JITOperations.h:
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/CommonSlowPaths.cpp:
(JSC::updateArithProfileForUnaryArithOp):
(JSC::SLOW_PATH_DECL):
- 7:10 PM Changeset in webkit [206288] by
-
- 10 edits in branches/safari-602-branch/Source/WebCore
Merge r206193. rdar://problem/28376161
- 7:10 PM Changeset in webkit [206287] by
-
- 2 edits in branches/safari-602-branch/Tools
Merge r206038. rdar://problem/28086237
- 7:10 PM Changeset in webkit [206286] by
-
- 41 edits1 copy3 adds in branches/safari-602-branch
Merge r206033. rdar://problem/28086237
- 6:54 PM Changeset in webkit [206285] by
-
- 10 edits in trunk
[ShadowDOM] Add support for Node.getRootNode(options)
https://bugs.webkit.org/show_bug.cgi?id=162457
Reviewed by Ryosuke Niwa.
LayoutTests/imported/w3c:
Rebaseline existing W3C DOM tests now that more checks are passing.
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/dom/nodes/rootNode-expected.txt:
Source/WebCore:
Add support for Node.getRootNode(options):
No new tests, rebaselined existing tests.
- dom/EventPath.cpp:
(WebCore::RelatedNodeRetargeter::RelatedNodeRetargeter):
(WebCore::RelatedNodeRetargeter::checkConsistency):
- dom/Node.cpp:
(WebCore::Node::rootNode):
(WebCore::Node::shadowIncludingRoot):
(WebCore::Node::getRootNode):
- dom/Node.h:
- dom/Node.idl:
- editing/Editor.cpp:
(WebCore::correctSpellcheckingPreservingTextCheckingParagraph):
- xml/XPathPath.cpp:
(WebCore::XPath::LocationPath::evaluate):
- 6:15 PM Changeset in webkit [206284] by
-
- 4 edits in trunk/Source/JavaScriptCore
Removed unused hasErrorInfo().
https://bugs.webkit.org/show_bug.cgi?id=162473
Reviewed by Saam Barati.
- JavaScriptCore.order:
- runtime/Error.cpp:
(JSC::hasErrorInfo): Deleted.
- runtime/Error.h:
- 6:14 PM Changeset in webkit [206283] by
-
- 2 edits in trunk/Tools
Add an API for getting the branch identifier from a Git or SVN checkout.
https://bugs.webkit.org/show_bug.cgi?id=151570
rdar://problem/17959831
Reviewed by David Kilzer.
This patch adds a function called svnIdentifierForPath. This function returns either "trunk",
the name of the tag, or the name of the branch, as appropriate. This function is necessary for
a VCSUtils client that is not checked in to the WebKit project.
This patch also breaks up pathRelativeToSVNRepositoryRootForPath into four functions:
- pathRelativeToSVNRepositoryRootForPath
- svnInfoForPath
- svnURLForPath
- svnRepositoryRootForPath
This allows us to reuse logic from pathRelativeToSVNRepositoryRootForPath in svnIdentifierForPath and
allows clients of VCSUtils to extract what arbitrary information from thesvn infocommand regardless
of SCM.
- Scripts/VCSUtils.pm:
(svnInfoForPath):
Copied logic that previously lived in pathRelativeToSVNRepositoryRootForPath.
Make code safe to use for a path, and not just for the CWD.
(svnURLForPath):
Calls svnInfoForPath and extracts the URL.
(svnRepositoryRootForPath):
Calls svnInfoForPath and extracts the Repository Root.
(svnIdentifierForPath):
Calls pathRelativeToSVNRepositoryRootForPath and extracts the repository identifier.
(pathRelativeToSVNRepositoryRootForPath):
Now uses svnURLForPath and svnRepositoryRootForPath instead of being responsible for
determining both values.
- 4:53 PM Changeset in webkit [206282] by
-
- 9 edits2 adds in trunk
Add long press selection test
https://bugs.webkit.org/show_bug.cgi?id=162367
Patch by Megan Gardner <Megan Gardner> on 2016-09-22
Reviewed by Simon Fraser.
Tools:
Add support to UIScriptController to synthesize long press events on iOS.
This required adding long-press functionality to HIDEventGenerator.
HIDEventGenerator sends the touchDown, but must then send the touchUp with
a dispatch_after (rather than sleeping, as we do for other events) in order
for the gesture recognizers to correctly detect a long press.
Use the long press synthesis in a test that detects whether a long press
gesture triggers text selection.
Fixed incorrect constants. NSTimeInterval is in seconds, original numbers
were nanoseconds and typedefed to long without regard to the type
differences. Redid constants to be the right value, and converted upon use.
Cleaned up unused enum types.
- DumpRenderTree/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::longPressAtPoint):
(WTR::UIScriptController::forcePressAtPoint):
(WTR::UIScriptController::dragFromPointToPoint): Deleted.
- Scripts/webkitpy/common/config/contributors.json:
- TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
- TestRunnerShared/UIScriptContext/UIScriptController.cpp:
(WTR::UIScriptController::longPressAtPoint):
(WTR::UIScriptController::forcePressAtPoint):
(WTR::UIScriptController::dragFromPointToPoint): Deleted.
- TestRunnerShared/UIScriptContext/UIScriptController.h:
- WebKitTestRunner/ios/HIDEventGenerator.h:
- WebKitTestRunner/ios/HIDEventGenerator.mm:
(-[HIDEventGenerator _createIOHIDEventType:]):
(-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
(-[HIDEventGenerator clearTap:]):
(-[HIDEventGenerator longPressTimerCall:]):
(-[HIDEventGenerator longPressFinish:completionBlock:]):
(-[HIDEventGenerator longPress:completionBlock:]):
(-[HIDEventGenerator forcePress:completionBlock:]):
- WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::longPressAtPoint):
(WTR::UIScriptController::forcePressAtPoint):
(WTR::UIScriptController::dragFromPointToPoint): Deleted.
LayoutTests:
Added test for long press selection.
- fast/events/touch/ios/long-press-to-select-text-expected.txt: Added.
- fast/events/touch/ios/long-press-to-select-text.html: Added.
- 4:41 PM Changeset in webkit [206281] by
-
- 6 edits1 add in trunk
Array.prototype.join should do overflow checks on string joins.
https://bugs.webkit.org/show_bug.cgi?id=162459
Reviewed by Saam Barati.
JSTests:
- stress/array-join-on-strings-need-overflow-checks.js: Added.
(assert):
(catch):
Source/JavaScriptCore:
Change the 2 JSRopeString::create() functions that do joins to be private, and
force all clients of it to go through the jsString() utility functions that do
overflow checks before creating the ropes.
- dfg/DFGOperations.cpp:
- runtime/ArrayPrototype.cpp:
(JSC::slowJoin):
- runtime/JSString.h:
- runtime/Operations.h:
(JSC::jsString):
- 3:34 PM Changeset in webkit [206280] by
-
- 3 edits5 adds in trunk
IDBIndex.openCursor() matches indices on multiple object stores.
<rdar://problem/28434463> and https://bugs.webkit.org/show_bug.cgi?id=158833
Reviewed by Alex Christensen.
Source/WebCore:
Tests: storage/indexeddb/modern/multiple-objectstore-index-cursor-collision-private.html
storage/indexeddb/modern/multiple-objectstore-index-cursor-collision.html
- Modules/indexeddb/server/SQLiteIDBCursor.cpp:
(WebCore::IDBServer::buildIndexStatement): Need to include the object store id in the statement for
index cursors, otherwise there will be collisions amongst multiple object stores that happen to
share primary keys.
(WebCore::IDBServer::SQLiteIDBCursor::bindArguments):
LayoutTests:
- storage/indexeddb/modern/multiple-objectstore-index-cursor-collision-expected.txt: Added.
- storage/indexeddb/modern/multiple-objectstore-index-cursor-collision-private-expected.txt: Added.
- storage/indexeddb/modern/multiple-objectstore-index-cursor-collision-private.html: Added.
- storage/indexeddb/modern/multiple-objectstore-index-cursor-collision.html: Added.
- storage/indexeddb/modern/resources/multiple-objectstore-index-cursor-collision.js: Added.
- 2:56 PM Changeset in webkit [206279] by
-
- 2 edits in trunk/Source/WebCore
ShowRenderTree: Shuffle letters to have better readability.
https://bugs.webkit.org/show_bug.cgi?id=162460
Reviewed by Simon Fraser.
old: (B)lock/(I)nline/I(N)line-block, (R)elative/A(B)solute/Fi(X)ed/Stick(Y) positioned, (O)verflow clipping, (A)nonymous, (G)enerated, (F)loating, has(L)ayer, (C)omposited, (D)irty layout, Dirty (S)tyle.
new: (B)lock/(I)nline/I(N)line-block, (A)bsolute/Fi(X)ed/(R)elative/Stic(K)y, (F)loating, (O)verflow clip, Anon(Y)mous, (G)enerated, has(L)ayer, (C)omposited, (+)Dirty style, (+)Dirty layout.
Not testable.
- rendering/RenderObject.cpp:
(WebCore::showRenderTreeLegend):
(WebCore::RenderObject::showRenderObject):
- 2:39 PM Changeset in webkit [206278] by
-
- 49 edits in trunk
[CSP] Violation report may be sent to wrong domain on frame-ancestors violation
https://bugs.webkit.org/show_bug.cgi?id=162079
<rdar://problem/28321575>
Reviewed by Andy Estes.
Source/WebCore:
Fixes an issue where a CSP violation report may be sent to the wrong domain when the
frame-ancestors directive is violated. In particular, when the frame-ancestors directive
is violated for a page that specifies a report URI that is a relative URL then the
report URI would be resolved with respect to the parent frame's document URL and hence
be sent to the domain of the parent frame's document.
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportViolation): Adjust the report URL with respect
to the blocked URL when we do not have a script execution context.
LayoutTests:
Modified http/tests/security/contentSecurityPolicy/resources/save-report.php to print the HTTP Host header as a means
to validate that the CSP violation report was sent to the appropriate host. Update test expectations.
Note that the presence of "localhost" in the HTTP Host header in the test results for tests
security/contentSecurityPolicy/1.1/frame-ancestors/report-frame-ancestors-cross-origin.html and
security/contentSecurityPolicy/1.1/frame-ancestors/report-frame-ancestors-cross-origin-https.html
verify that we resolve a relative URL CSP report URI with respect to the blocked URL.
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/report-frame-ancestors-cross-origin-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/report-frame-ancestors-cross-origin-https-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/report-frame-ancestors-cross-origin-https.html:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/report-frame-ancestors-cross-origin.html:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/report-frame-ancestors-same-origin-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/report-frame-ancestors-same-origin-https-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/report-frame-ancestors-same-origin-https.html:
- http/tests/security/contentSecurityPolicy/1.1/frame-ancestors/report-frame-ancestors-same-origin.html:
- http/tests/security/contentSecurityPolicy/1.1/report-uri-effective-directive-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/script-blocked-sends-multiple-reports-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/scripthash-allowed-by-enforced-policy-and-blocked-by-report-policy-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/scripthash-allowed-by-enforced-policy-and-blocked-by-report-policy2-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/scripthash-allowed-by-legacy-enforced-policy-and-blocked-by-report-policy-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/scripthash-allowed-by-legacy-enforced-policy-and-blocked-by-report-policy2-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/scripthash-blocked-by-enforced-policy-and-allowed-by-report-policy-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/scripthash-blocked-by-legacy-enforced-policy-and-allowed-by-report-policy-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/scripthash-blocked-by-legacy-enforced-policy-and-blocked-by-report-policy-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/scripthash-blocked-by-legacy-enforced-policy-and-blocked-by-report-policy2-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked-by-enforced-policy-and-allowed-by-report-policy-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked-by-legacy-enforced-policy-and-allowed-by-report-policy-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked-by-legacy-enforced-policy-and-blocked-by-report-policy-expected.txt:
- http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked-by-legacy-enforced-policy-and-blocked-by-report-policy2-expected.txt:
- http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt:
- http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt:
- http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt:
- http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt:
- http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt:
- http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-expected.txt:
- http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-when-private-browsing-enabled-expected.txt:
- http/tests/security/contentSecurityPolicy/report-cross-origin-no-cookies-when-private-browsing-toggled-expected.txt:
- http/tests/security/contentSecurityPolicy/report-only-expected.txt:
- http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt:
- http/tests/security/contentSecurityPolicy/report-only-upgrade-insecure-expected.txt:
- http/tests/security/contentSecurityPolicy/report-same-origin-no-cookies-when-private-browsing-toggled-expected.txt:
- http/tests/security/contentSecurityPolicy/report-same-origin-with-cookies-expected.txt:
- http/tests/security/contentSecurityPolicy/report-same-origin-with-cookies-when-private-browsing-enabled-expected.txt:
- http/tests/security/contentSecurityPolicy/report-status-code-zero-when-using-https-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-from-javascript-expected.txt:
- http/tests/security/contentSecurityPolicy/report-uri-scheme-relative-expected.txt:
- http/tests/security/contentSecurityPolicy/resources/save-report.php:
- http/tests/security/xssAuditor/report-script-tag-expected.txt:
- http/tests/security/xssAuditor/report-script-tag-full-block-expected.txt:
- http/tests/security/xssAuditor/report-script-tag-replace-state-expected.txt:
- 2:34 PM Changeset in webkit [206277] by
-
- 3 edits2 adds in trunk
[XSS Auditor] HTML5 entities can bypass XSS Auditor
https://bugs.webkit.org/show_bug.cgi?id=161939
<rdar://problem/25819815>
Reviewed by David Kilzer.
Source/WebCore:
Merged from Blink:
<https://chromium.googlesource.com/chromium/src/+/04e44060dccee711842d08652bf1c622a0f43179>
Truncate a src-like URL at the first & character as it may mark the start of an HTML entity.
We will evaluate the effectiveness of this approach and adjust it if necessary if we see an
increase in false positives.
HTML5 defines more named character references, including named character references for common
punctuation characters. Characters following some punctuation characters may come from the page
itself. We truncate src-like strings at punctuation characters to avoid considering such page
content when performing a match.
Test: http/tests/security/xssAuditor/script-tag-with-source-data-url5.html
- html/parser/XSSAuditor.cpp:
(WebCore::truncateForSrcLikeAttribute):
LayoutTests:
- http/tests/security/xssAuditor/script-tag-with-source-data-url5-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-source-data-url5.html: Added.
- 2:33 PM Changeset in webkit [206276] by
-
- 4 edits2 adds in trunk
[XSS Auditor] Truncate data URLs at quotes
https://bugs.webkit.org/show_bug.cgi?id=161937
Reviewed by David Kilzer.
Source/WebCore:
Merged from Blink:
<https://chromium.googlesource.com/chromium/src/+/c6d6331190dd43f09459e2341c3111e796f9de12/>
Truncate a data URL at the first single or double quote character to avoid considering
characters that may come from the page content following an injected data URL.
Test: http/tests/security/xssAuditor/script-tag-with-source-data-url4.html
- html/parser/XSSAuditor.cpp:
(WebCore::truncateForSrcLikeAttribute):
LayoutTests:
- http/tests/security/xssAuditor/resources/echo-property.pl:
- http/tests/security/xssAuditor/script-tag-with-source-data-url4-expected.txt: Added.
- http/tests/security/xssAuditor/script-tag-with-source-data-url4.html: Added.
- 2:22 PM Changeset in webkit [206275] by
-
- 9 edits in trunk
Remove more ENABLE(TEXT_AUTOSIZING) code
https://bugs.webkit.org/show_bug.cgi?id=162456
Reviewed by Simon Fraser.
.:
- Source/cmake/tools/vsprops/FeatureDefines.props:
- Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
Source/WebCore:
- page/Settings.in:
- rendering/style/StyleVisualData.h:
(WebCore::StyleVisualData::operator==):
Source/WebKit2:
- UIProcess/API/efl/ewk_settings.cpp:
(ewk_settings_text_autosizing_enabled_set):
(ewk_settings_text_autosizing_enabled_get):
- UIProcess/API/efl/tests/test_ewk2_settings.cpp:
(TEST_F):
- 2:11 PM Changeset in webkit [206274] by
-
- 6 edits in trunk/Source
Fences on x86 should be a lot cheaper
https://bugs.webkit.org/show_bug.cgi?id=162417
Reviewed by Mark Lam and Geoffrey Garen.
Source/JavaScriptCore:
It turns out that:
lock; orl $0, (%rsp)
does everything that we wanted from:
mfence
And it's a lot faster. When I tried mfence for making object visiting concurrent-GC-TSO-
friendly, it was a 9% regression on Octane/splay. But when I tried ortop, it was neutral.
So, we should use ortop from now on.
This part of the change is for the JITs. MacroAssembler::memoryFence() appears to always
mean something like an acqrel fence, so it's safe to make this use ortop. Since B3's Fence
compiles to Air MemoryFence, which is just MacroAssembler::memoryFence(), this also changes
B3 codegen.
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::memoryFence):
- assembler/X86Assembler.h:
(JSC::X86Assembler::lock):
- b3/testb3.cpp:
(JSC::B3::testX86MFence):
(JSC::B3::testX86CompilerFence):
Source/WTF:
It turns out that:
lock; orl $0, (%rsp)
does everything that we wanted from:
mfence
And it's a lot faster. When I tried mfence for making object visiting concurrent-GC-TSO-
friendly, it was a 9% regression on Octane/splay. But when I tried ortop, it was neutral.
So, we should use ortop from now on.
This part of the change just affects our Atomics. I also changed this in the JITs.
- wtf/Atomics.h:
(WTF::x86_ortop):
(WTF::storeLoadFence):
(WTF::x86_mfence): Deleted.
- 2:05 PM Changeset in webkit [206273] by
-
- 5 edits in branches/safari-602-branch/Source
Versioning.
- 1:54 PM Changeset in webkit [206272] by
-
- 2 edits in trunk/Source/WebCore
Fullscreen controls inoperative in WebKitLegacy web views
https://bugs.webkit.org/show_bug.cgi?id=162374
Reviewed by Eric Carlson.
After r205365, the WebPlaybackSessionInterfaceAVKit was now created after the
WebPlaybackSessionModel which fed it data, so it no longer received the burst of data upon
creation. Instead, it should have always asked the model for its cached data as soon as it
was connected to set up its inital state.
- platform/ios/WebPlaybackSessionInterfaceAVKit.mm:
(WebCore::WebPlaybackSessionInterfaceAVKit::WebPlaybackSessionInterfaceAVKit):
- 1:50 PM Changeset in webkit [206271] by
-
- 1 copy in tags/Safari-602.2.12
New tag.
- 1:48 PM Changeset in webkit [206270] by
-
- 2 edits in branches/safari-602-branch/Source/WebCore
Merge r206027. rdar://problem/28366812
- 1:47 PM Changeset in webkit [206269] by
-
- 5 edits in branches/safari-602-branch/Source
Versioning.
- 12:11 PM Changeset in webkit [206268] by
-
- 17 edits in trunk
test262: Function length should be number of parameters before parameters with default values
https://bugs.webkit.org/show_bug.cgi?id=162377
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-09-22
Reviewed by Saam Barati.
JSTests:
- stress/es6-default-parameters.js:
Add our own tests for function lengths with default parameters.
- test262.yaml:
We now pass all dflt-length tests.
Source/JavaScriptCore:
https://tc39.github.io/ecma262/#sec-function-definitions-static-semantics-expectedargumentcount
NOTE: The ExpectedArgumentCount of a FormalParameterList is the number of
FormalParameters to the left of either the rest parameter or the first
FormalParameter with an Initializer. A FormalParameter without an
initializer is allowed after the first parameter with an initializer
but such parameters are considered to be optional with undefined as
their default value.
Alongside the parameterCount value, maintain a separate count,
functionLength, which will be the count before seeing a rest parameter
or parameter with a default value. This will be the function's length.
- bytecode/UnlinkedCodeBlock.h:
- bytecode/UnlinkedFunctionExecutable.cpp:
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
- bytecode/UnlinkedFunctionExecutable.h:
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createFunctionMetadata):
- parser/Nodes.cpp:
(JSC::FunctionMetadataNode::FunctionMetadataNode):
- parser/Nodes.h:
- parser/Parser.cpp:
(JSC::Parser<LexerType>::isArrowFunctionParameters):
(JSC::Parser<LexerType>::parseGeneratorFunctionSourceElements):
(JSC::Parser<LexerType>::parseFormalParameters):
(JSC::Parser<LexerType>::parseFunctionBody):
(JSC::Parser<LexerType>::parseFunctionParameters):
(JSC::Parser<LexerType>::parseFunctionInfo):
- parser/Parser.h:
- parser/ParserFunctionInfo.h:
- parser/SourceProviderCacheItem.h:
(JSC::SourceProviderCacheItem::SourceProviderCacheItem):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createFunctionMetadata):
- runtime/Executable.h:
- runtime/JSFunction.cpp:
(JSC::JSFunction::createBuiltinFunction):
(JSC::JSFunction::reifyLength):
- 11:59 AM Changeset in webkit [206267] by
-
- 53 edits in trunk/Source/JavaScriptCore
Remove a bunch of unnecessary includes
https://bugs.webkit.org/show_bug.cgi?id=162376
Reviewed by Mark Lam.
- 11:47 AM Changeset in webkit [206266] by
-
- 4 edits in trunk
Fix serialization of HTML void elements when they have children
https://bugs.webkit.org/show_bug.cgi?id=162418
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
- web-platform-tests/html/syntax/serializing-html-fragments/serializing-expected.txt:
Source/WebCore:
Fix serialization of HTML void elements when they have children.
Void elements (such as <hr>) cannot have a closing tag. When
encountering them, we would properly not serialize the void
element's children (if it had any). However, we would incorrectly
append an end tag (because the element technically has children).
Relevant specification:
In particular, this part:
""
If current node is an area, base, basefont, bgsound, br, col, embed,
frame, hr, img, input, keygen, link, meta, param, source, track or wbr
element, then continue on to the next child node at this point.
""
Firefox matches the specification.
No new tests, rebaselined existing test.
- editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::serializeNodesWithNamespaces):
- 11:43 AM Changeset in webkit [206265] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Fix build after r206196
Patch by Don Olmstead <don.olmstead@am.sony.com> on 2016-09-22
Reviewed by Alex Christensen.
- platform/text/win/LocaleWin.cpp:
(WebCore::LocaleWin::getLocaleInfoString):
- 11:30 AM Changeset in webkit [206264] by
-
- 2 edits in trunk/LayoutTests
Marking imported/w3c/web-platform-tests/media-source/mediasource-duration.html as flaky on mac.
https://bugs.webkit.org/show_bug.cgi?id=162308
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 11:19 AM Changeset in webkit [206263] by
-
- 4 edits in trunk/LayoutTests
Unreviewed, rolling out r206112.
This change made inspector/network/xhr-json-blob-has-
content.html very flaky.
Reverted changeset:
"Web Inspector: adopt Object.awaitEvent in
LayoutTests/inspector/network"
https://bugs.webkit.org/show_bug.cgi?id=162099
http://trac.webkit.org/changeset/206112
- 10:59 AM Changeset in webkit [206262] by
-
- 2 edits in trunk/LayoutTests
imported/w3c/web-platform-tests/resource-timing/idlharness.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=162414
Unreviewed.
Patch by Youenn Fablet <youenn@apple.com> on 2016-09-22
- 10:39 AM Changeset in webkit [206261] by
-
- 38 edits in trunk
Automatic Text Replacement Testing in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=161919
Reviewed by Ryosuke Niwa.
Source/WebCore:
Fixing existing tests:
editing/inserting/smart-link-when-caret-is-moved-before-URL.html
editing/inserting/typing-space-to-trigger-smart-link.html
Implemented test hooks for text replacement for WebKit2.
Note that spell checking has not been implemented, so most tests which use text replacement still fail.
- testing/Internals.cpp:
(WebCore::Internals::Internals): Reset TextChecker.
(WebCore::Internals::setContinuousSpellCheckingEnabled): Converted exception to an assert.
(WebCore::Internals::setAutomaticQuoteSubstitutionEnabled): Converted exception to an assert.
(WebCore::Internals::setAutomaticLinkDetectionEnabled): Converted exception to an assert.
(WebCore::Internals::setAutomaticDashSubstitutionEnabled): Converted exception to an assert.
(WebCore::Internals::setAutomaticTextReplacementEnabled): Converted exception to an assert.
(WebCore::Internals::setAutomaticSpellingCorrectionEnabled): Converted exception to an assert.
- testing/Internals.h: Removed exception argument for TextChecker setters.
- testing/Internals.idl: Ditto.
Source/WebKit2:
Implemented test hooks for text replacement for WebKit2.
Note that spell checking has not been implemented, so most tests which use text replacement still fail.
- UIProcess/API/C/WKTextChecker.cpp: Added #ifdefs to include file for iOS and Mac.
(WKTextCheckerSetTestingMode): Added.
- UIProcess/API/C/WKTextChecker.h: Added #ifdefs to include file for iOS and Mac.
- UIProcess/TextChecker.h: Added hooks to bypass writing to NSUserDefaults.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::toggleSmartInsertDelete): New message to toggle TextChecker flag.
(WebKit::WebPageProxy::toggleAutomaticQuoteSubstitution): Ditto.
(WebKit::WebPageProxy::toggleAutomaticLinkDetection): Ditto.
(WebKit::WebPageProxy::toggleAutomaticDashSubstitution): Ditto.
(WebKit::WebPageProxy::toggleAutomaticTextReplacement): Ditto.
- UIProcess/WebPageProxy.h: Added messages to toggle TextChecker flags.
- UIProcess/WebPageProxy.messages.in: Ditto.
- UIProcess/efl/TextCheckerEfl.cpp: Implemented new TextChecker hooks for non-Cocoa platforms.
- UIProcess/gtk/TextCheckerGtk.cpp: Ditto.
(WebKit::TextChecker::mutableState): Ditto.
- UIProcess/ios/TextCheckerIOS.mm: Implemented new TextChecker hooks.
(WebKit::TextChecker::mutableState): Allow modification of text checker without writing to NSUserDefaults.
(WebKit::TextChecker::state): Call mutableState.
(WebKit::TextChecker::accessSmartInsertDeleteEnabled): Dummy function.
- UIProcess/mac/TextCheckerMac.mm:
(WebKit::refresh): Reload TextChecker configuration from NSUserDefaults.
(WebKit::TextChecker::mutableState): Allow modification of text checker without writing to NSUserDefaults.
(WebKit::TextChecker::state): Call mutableState().
(WebKit::TextChecker::accessSmartInsertDeleteEnabled): Allow toggling of smartInsertDeleteEnabled without writing to NSUserDefaults.
(WebKit::initializeState): Deleted.
- WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetAutomaticLinkDetectionEnabled): Deleted.
- WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Removed WKBundleSetAutomaticLinkDetectionEnabled.
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setAutomaticLinkDetectionEnabled): Deleted.
- WebKit2.xcodeproj/project.pbxproj: Added WKTextChecker to Mac and iOS.
- WebProcess/InjectedBundle/InjectedBundle.h: Remove setAutomaticLinkDetectionEnabled.
- WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
(WebKit::WebEditorClient::toggleSmartInsertDelete): Send message to UI process to toggle TextChecker.
(WebKit::WebEditorClient::toggleAutomaticQuoteSubstitution): Ditto.
(WebKit::WebEditorClient::toggleAutomaticLinkDetection): Ditto.
(WebKit::WebEditorClient::toggleAutomaticDashSubstitution): Ditto.
(WebKit::WebEditorClient::toggleAutomaticTextReplacement): Ditto.
Tools:
Implemented test hooks for text replacement for WebKit2.
Note that spell checking has not been implemented, so most tests which use text replacement still fail.
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Removed setAutomaticLinkDetectionEnabled from TestRunner, moved to Internals.
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Ditto.
(WTR::InjectedBundle::beginTesting): Ditto.
- WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
- WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::runTest): Place TextChecker into testing mode.
LayoutTests:
Implemented test hooks for text replacement for WebKit2.
Note that spell checking has not been implemented, so most tests which use text replacement still fail.
- editing/inserting/smart-link-when-caret-is-moved-before-URL.html: Use internals instead of TestRunner.
- editing/inserting/typing-space-to-trigger-smart-link.html: Ditto.
- platform/efl/TestExpectations: Added port specific tests.
- platform/gtk/TestExpectations: Added port specific tests.
- platform/ios-simulator/TestExpectations: Added port specific tests.
- platform/ios-simulator-wk1/TestExpectations: Moved skipped tests to ios-simulator.
- platform/ios-simulator-wk2/TestExpectations: Moved skipped tests to ios-simulator.
- platform/mac-wk2/TestExpectations: Removed passing test.
- platform/win/TestExpectations: Added port specific tests.
- platform/wk2/TestExpectations: Added better explanation for failing test.
- 9:20 AM Changeset in webkit [206260] by
-
- 94 edits10 copies54 adds6 deletes in trunk/LayoutTests
Sync web-platform-tests up to revision 3801ab5
https://bugs.webkit.org/show_bug.cgi?id=162375
Patch by Youenn Fablet <youenn@apple.com> on 2016-09-22
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- resources/ImportExpectations:
- resources/TestRepositories:
- resources/resource-files.json:
- resources/web-platform-tests-modules.json:
- web-platform-tests/IndexedDB/idbindex-multientry-big-expected.txt:
- web-platform-tests/XMLHttpRequest/responsexml-document-properties-expected.txt:
- web-platform-tests/XMLHttpRequest/send-entity-body-document-expected.txt:
- web-platform-tests/XMLHttpRequest/setrequestheader-header-allowed.htm:
- web-platform-tests/dom/interfaces-expected.txt:
- web-platform-tests/dom/interfaces.html:
- web-platform-tests/dom/nodes/Document-createEvent-expected.txt:
- web-platform-tests/dom/nodes/Document-createEvent.html:
- web-platform-tests/dom/nodes/NodeList-Iterable.html: Added.
- web-platform-tests/dom/nodes/rootNode.html: Added.
- web-platform-tests/dom/nodes/w3c-import.log:
- web-platform-tests/fetch/api/cors/cors-multiple-origins-expected.txt:
- web-platform-tests/fetch/api/cors/cors-multiple-origins-worker-expected.txt:
- web-platform-tests/fetch/api/cors/cors-preflight-referrer-expected.txt:
- web-platform-tests/fetch/api/cors/cors-preflight-referrer-worker-expected.txt:
- web-platform-tests/fetch/api/cors/cors-preflight-referrer.js:
(corsPreflightReferrer):
- web-platform-tests/fetch/api/redirect/redirect-to-dataurl-expected.txt:
- web-platform-tests/fetch/api/redirect/redirect-to-dataurl-worker-expected.txt:
- web-platform-tests/fetch/api/redirect/redirect-to-dataurl.js:
(redirectDataURL):
- web-platform-tests/fetch/api/response/response-static-redirect.html:
- web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt:
- web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html:
- web-platform-tests/html/browsers/origin/origin-of-data-document.html: Added.
- web-platform-tests/html/browsers/origin/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/tabular-data/w3c-import.log.
- web-platform-tests/html/browsers/windows/nested-browsing-contexts/frameElement.sub-expected.txt:
- web-platform-tests/html/browsers/windows/targeting-cross-origin-nested-browsing-contexts.sub-expected.txt:
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.forms-expected.txt:
- web-platform-tests/html/dom/documents/dom-tree-accessors/document.forms.html:
- web-platform-tests/html/dom/elements-embedded.js:
- web-platform-tests/html/dom/elements-metadata.js:
- web-platform-tests/html/dom/elements-tabular.js:
- web-platform-tests/html/dom/elements-text.js:
- web-platform-tests/html/dom/interfaces-expected.txt:
- web-platform-tests/html/dom/reflection-embedded-expected.txt:
- web-platform-tests/html/dom/reflection-metadata-expected.txt:
- web-platform-tests/html/dom/reflection-tabular-expected.txt:
- web-platform-tests/html/dom/reflection-text-expected.txt:
- web-platform-tests/html/dom/reflection.js:
(ReflectionTests.resolveUrl):
(ReflectionTests.parseNonneg): Deleted.
(ReflectionTests.parseInt): Deleted.
- web-platform-tests/html/semantics/document-metadata/the-link-element/document-without-browsing-context-expected.txt:
- web-platform-tests/html/semantics/document-metadata/the-style-element/historical.html: Added.
- web-platform-tests/html/semantics/document-metadata/the-style-element/style_scoped-expected.txt: Removed.
- web-platform-tests/html/semantics/document-metadata/the-style-element/style_scoped.html: Removed.
- web-platform-tests/html/semantics/document-metadata/the-style-element/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/media-elements/historical-expected.txt:
- web-platform-tests/html/semantics/embedded-content/media-elements/historical.html:
- web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/HTMLElement/HTMLTrackElement/src-expected.txt:
- web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/HTMLElement/HTMLTrackElement/src.html:
- web-platform-tests/html/semantics/embedded-content/the-area-element/area-shape-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-area-element/area-shape.html:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/historical-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-canvas-element/historical.html:
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/historical.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/w3c-import.log:
- web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/viewport-change-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-img-element/nonexistent-image.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-img-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/constraints/form-validation-checkValidity-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-checkValidity.html:
- web-platform-tests/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-reportValidity.html:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow.html:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow.html:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-stepMismatch-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-stepMismatch.html:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid.html:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing.html:
- web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt:
- web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate.html:
- web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-expected.txt:
- web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application.html:
- web-platform-tests/html/semantics/forms/the-input-element/cloning-steps.html: Added.
- web-platform-tests/html/semantics/forms/the-input-element/datetime-2-expected.txt: Removed.
- web-platform-tests/html/semantics/forms/the-input-element/datetime-2.html: Removed.
- web-platform-tests/html/semantics/forms/the-input-element/files-expected.txt:
- web-platform-tests/html/semantics/forms/the-input-element/files.html:
- web-platform-tests/html/semantics/forms/the-input-element/month-expected.txt:
- web-platform-tests/html/semantics/forms/the-input-element/month.html:
- web-platform-tests/html/semantics/forms/the-input-element/type-change-state-expected.txt:
- web-platform-tests/html/semantics/forms/the-input-element/type-change-state.html:
- web-platform-tests/html/semantics/forms/the-input-element/valueMode-expected.txt:
- web-platform-tests/html/semantics/forms/the-input-element/valueMode.html:
- web-platform-tests/html/semantics/forms/the-input-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-option-element/option-form.html: Added.
- web-platform-tests/html/semantics/forms/the-option-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-textarea-element/cloning-steps.html:
- web-platform-tests/html/semantics/forms/the-textarea-element/w3c-import.log:
- web-platform-tests/html/semantics/forms/the-textarea-element/wrap-reflect-1a-expected.html: Added.
- web-platform-tests/html/semantics/forms/the-textarea-element/wrap-reflect-1a.html: Added.
- web-platform-tests/html/semantics/forms/the-textarea-element/wrap-reflect-1b-expected.html: Added.
- web-platform-tests/html/semantics/forms/the-textarea-element/wrap-reflect-1b.html: Added.
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-close-expected.txt:
- web-platform-tests/html/semantics/interactive-elements/the-dialog-element/dialog-close.html:
- web-platform-tests/html/semantics/scripting-1/the-script-element/historical.html: Added.
- web-platform-tests/html/semantics/scripting-1/the-script-element/script-before-after-events-expected.txt: Removed.
- web-platform-tests/html/semantics/scripting-1/the-script-element/script-before-after-events.html: Removed.
- web-platform-tests/html/semantics/scripting-1/the-script-element/w3c-import.log:
- web-platform-tests/html/semantics/tabular-data/historical.html: Added.
- web-platform-tests/html/semantics/tabular-data/w3c-import.log:
- web-platform-tests/html/semantics/text-level-semantics/historical.html: Added.
- web-platform-tests/html/semantics/text-level-semantics/w3c-import.log: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/the-xhtml-syntax/parsing-xhtml-documents/w3c-import.log.
- web-platform-tests/html/syntax/parsing/foreign_content_001.html: Added.
- web-platform-tests/html/syntax/parsing/foreign_content_003.html: Added.
- web-platform-tests/html/syntax/parsing/foreign_content_004.html: Added.
- web-platform-tests/html/syntax/parsing/foreign_content_005.html: Added.
- web-platform-tests/html/syntax/parsing/foreign_content_006.html: Added.
- web-platform-tests/html/syntax/parsing/foreign_content_008.html: Added.
- web-platform-tests/html/syntax/parsing/foreign_content_009.html: Added.
- web-platform-tests/html/syntax/parsing/foreign_content_010.html: Added.
- web-platform-tests/html/syntax/parsing/foreign_content_013.html: Added.
- web-platform-tests/media-source/import_tests.sh:
- web-platform-tests/media-source/mediasource-append-buffer-expected.txt:
- web-platform-tests/media-source/mediasource-is-type-supported-expected.txt:
- web-platform-tests/media-source/mediasource-sourcebuffer-mode-expected.txt:
- web-platform-tests/media-source/mp4/w3c-import.log: Added.
- web-platform-tests/media-source/w3c-import.log: Added.
- web-platform-tests/media-source/webm/w3c-import.log: Added.
- web-platform-tests/resource-timing/idlharness-expected.txt: Added.
- web-platform-tests/resource-timing/idlharness.html: Added.
- web-platform-tests/resource-timing/resource-timing-expected.txt:
- web-platform-tests/resource-timing/resource-timing.js:
(window.onload):
- web-platform-tests/resource-timing/w3c-import.log:
LayoutTests:
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt: Added.
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-checkValidity-expected.txt: Added.
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt: Added.
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt: Added.
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt: Added.
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-stepMismatch-expected.txt: Added.
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt: Added.
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt: Added.
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt: Added.
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/html/semantics/forms/textfieldselection/selection-not-application-expected.txt: Added.
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/month-expected.txt: Added.
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/type-change-state-expected.txt: Added.
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/valueMode-expected.txt: Added.
- platform/ios-simulator-wk2/imported/w3c/web-platform-tests/resource-timing/idlharness-expected.txt: Added.
- platform/wk2/imported/w3c/web-platform-tests/html/semantics/document-metadata/styling/LinkStyle-expected.txt:
- tests-options.json:
- 8:14 AM Changeset in webkit [206259] by
-
- 6 edits in trunk
AX: aria-pressed state not correctly conveyed to VoiceOver iOS on <button> unless role=button added
https://bugs.webkit.org/show_bug.cgi?id=162269
Reviewed by Chris Fleizach.
Source/WebCore:
<button> with aria-pressed attribute has a toggle button role, however, we were looking for explicit
roles in order to convey the aria-press state. Since there's no spec requiring authors explicitly defining
default ARIA semantics in such case, I'm exposing the aria-pressed state for all valid toggle buttons.
Changes are covered in modified test.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isPressed):
LayoutTests:
Added test cases and also fixed a wrong expected output.
- accessibility/ios-simulator/aria-pressed-state-expected.txt:
- accessibility/ios-simulator/aria-pressed-state.html:
- 7:15 AM Changeset in webkit [206258] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix the open source iOS build.
- platform/spi/cocoa/PassKitSPI.h:
- 5:43 AM Changeset in webkit [206257] by
-
- 3 edits in trunk/Source/WebCore
[GStreamer] Support a direct GPU-to-GPU copy of video textures to WebGL
https://bugs.webkit.org/show_bug.cgi?id=159928
Patch by Olivier Blin <Olivier Blin> on 2016-09-22
Reviewed by Carlos Garcia Campos.
Copy of GStreamer video frames to WebGL textures was not accelerated.
WebGLRenderingContextBase::texImage2D(HTMLVideoElement) went
through a slow software paint() wrapping the video frame into
cairo surface (ImageGStreamer), downloading it to draw to the
image cache context, copying it again in software, and uploading
it back to an OpenGL texture.
This patch implements copyVideoTextureToPlatformTexture() for
the GStreamer media player backend, to do GPU-to-GPU copy, by
extracting code from nativeImageForCurrentTime().
Doing this also fixes bug #159621: red and blue colors were
swapped in video rendered through WebGL with GSTREAMER_GL enabled.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::prepareContextForCairoPaint):
(WebCore::MediaPlayerPrivateGStreamerBase::paintToCairoSurface):
(WebCore::MediaPlayerPrivateGStreamerBase::copyVideoTextureToPlatformTexture):
(WebCore::MediaPlayerPrivateGStreamerBase::nativeImageForCurrentTime):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
- 5:14 AM Changeset in webkit [206256] by
-
- 35 edits4 moves in trunk/Source
[GTK] Rename DataObjectGtk as SelectionData
https://bugs.webkit.org/show_bug.cgi?id=162380
Reviewed by Žan Doberšek.
Source/WebCore:
DataObjectGtk represents the data of a selection, like GtkSelectionData, used for clipboard and drag adn drop
operations. Data object is a very generic name, and the Gtk suffix sounds like if this is the GTK implementation
of a generic DataObject class.
- PlatformGTK.cmake:
- editing/gtk/EditorGtk.cpp:
(WebCore::createFragmentFromPasteboardData):
- page/gtk/DragControllerGtk.cpp:
- platform/DragData.h:
- platform/Pasteboard.h:
- platform/PasteboardStrategy.h:
(WebCore::PasteboardStrategy::~PasteboardStrategy): Deleted.
- platform/PlatformPasteboard.h:
- platform/gtk/DragDataGtk.cpp:
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::createPrivate):
(WebCore::Pasteboard::createForDragAndDrop):
(WebCore::Pasteboard::Pasteboard):
(WebCore::Pasteboard::selectionData):
(WebCore::selectionDataTypeFromHTMLClipboardType):
(WebCore::Pasteboard::writeToClipboard):
(WebCore::Pasteboard::readFromClipboard):
(WebCore::Pasteboard::writeString):
(WebCore::Pasteboard::writePlainText):
(WebCore::Pasteboard::write):
(WebCore::Pasteboard::writePasteboard):
(WebCore::Pasteboard::clear):
(WebCore::Pasteboard::canSmartReplace):
(WebCore::Pasteboard::read):
(WebCore::Pasteboard::hasData):
(WebCore::Pasteboard::types):
(WebCore::Pasteboard::readString):
(WebCore::Pasteboard::readFilenames):
- platform/gtk/PasteboardHelper.cpp:
(WebCore::PasteboardHelper::getClipboardContents):
(WebCore::PasteboardHelper::targetListForSelectionData):
(WebCore::PasteboardHelper::fillSelectionData):
(WebCore::ClipboardSetData::ClipboardSetData):
(WebCore::getClipboardContentsCallback):
(WebCore::PasteboardHelper::writeClipboardContents):
(WebCore::clearClipboardContentsCallback): Deleted.
- platform/gtk/PasteboardHelper.h:
- platform/gtk/PlatformPasteboardGtk.cpp:
(WebCore::PlatformPasteboard::writeToClipboard):
(WebCore::PlatformPasteboard::readFromClipboard):
- platform/gtk/SelectionData.cpp: Renamed from Source/WebCore/platform/gtk/DataObjectGtk.cpp.
(WebCore::SelectionData::setText):
(WebCore::SelectionData::setURIList):
(WebCore::SelectionData::setURL):
(WebCore::SelectionData::urlLabel):
(WebCore::SelectionData::clearAllExceptFilenames):
(WebCore::SelectionData::clearAll):
- platform/gtk/SelectionData.h: Renamed from Source/WebCore/platform/gtk/DataObjectGtk.h.
(WebCore::SelectionData::create):
(WebCore::SelectionData::text):
(WebCore::SelectionData::hasText):
(WebCore::SelectionData::clearText):
(WebCore::SelectionData::setMarkup):
(WebCore::SelectionData::markup):
(WebCore::SelectionData::hasMarkup):
(WebCore::SelectionData::clearMarkup):
(WebCore::SelectionData::hasURL):
(WebCore::SelectionData::clearURL):
(WebCore::SelectionData::filenames):
(WebCore::SelectionData::hasURIList):
(WebCore::SelectionData::hasFilenames):
(WebCore::SelectionData::setImage):
(WebCore::SelectionData::image):
(WebCore::SelectionData::hasImage):
(WebCore::SelectionData::unknownTypeData):
(WebCore::SelectionData::unknownTypes):
(WebCore::SelectionData::hasUnknownTypeData):
(WebCore::SelectionData::canSmartReplace):
(WebCore::SelectionData::url): Deleted.
(WebCore::SelectionData::uriList): Deleted.
(WebCore::SelectionData::clearURIList): Deleted.
(WebCore::SelectionData::clearImage): Deleted.
(WebCore::SelectionData::setUnknownTypeData): Deleted.
Source/WebKit2:
- PlatformGTK.cmake:
- Shared/gtk/ArgumentCodersGtk.cpp:
(IPC::ArgumentCoder<SelectionData>::encode):
(IPC::ArgumentCoder<SelectionData>::decode):
- Shared/gtk/ArgumentCodersGtk.h:
- Shared/gtk/WebSelectionData.cpp: Renamed from Source/WebKit2/Shared/gtk/PasteboardContent.cpp.
(WebKit::WebSelectionData::WebSelectionData):
(WebKit::WebSelectionData::encode):
(WebKit::WebSelectionData::decode):
- Shared/gtk/WebSelectionData.h: Renamed from Source/WebKit2/Shared/gtk/PasteboardContent.h.
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::startDrag):
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::performDragControllerAction):
(WebKit::WebPageProxy::startDrag):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebPasteboardProxy.h:
- UIProcess/WebPasteboardProxy.messages.in:
- UIProcess/gtk/DragAndDropHandler.cpp:
(WebKit::DragAndDropHandler::DroppingContext::DroppingContext):
(WebKit::DragAndDropHandler::startDrag):
(WebKit::DragAndDropHandler::fillDragData):
(WebKit::DragAndDropHandler::finishDrag):
(WebKit::DragAndDropHandler::dropDataSelection):
(WebKit::DragAndDropHandler::dragEntered):
(WebKit::DragAndDropHandler::dragDataSelection):
(WebKit::DragAndDropHandler::dragMotion):
(WebKit::DragAndDropHandler::dragLeave):
(WebKit::DragAndDropHandler::drop):
- UIProcess/gtk/DragAndDropHandler.h:
- UIProcess/gtk/WebPasteboardProxyGtk.cpp:
(WebKit::WebPasteboardProxy::writeToClipboard):
(WebKit::WebPasteboardProxy::readFromClipboard):
(WebKit::WebPasteboardProxy::setPrimarySelectionOwner): Deleted.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::writeToClipboard):
(WebKit::WebPlatformStrategies::readFromClipboard):
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:
(WebKit::WebDragClient::startDrag):
- WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performDragControllerAction):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 1:57 AM Changeset in webkit [206255] by
-
- 8 edits1 move1 add1 delete in trunk
CachedResourceRequest should store a SecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=162258
Patch by Youenn Fablet <youenn@apple.com> on 2016-09-22
Reviewed by Sam Weinig.
Source/WebCore:
Test: http/tests/local/script-crossorigin-loads-file-scheme.html
Passing SecurityOrigin from loader clients to CachedResource through CachedResourceRequest.
This ensures that specific origin properties like universal access are well preserved.
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::loadRequest): Set origin to the request.
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource): Setting origin from the request.
Computing CORS state based on that origin.
(WebCore::CachedResource::load): Removing origin computation.
(WebCore::CachedResource::loadFrom): Ditto.
(WebCore::CachedResource::computeOrigin): Deleted.
- loader/cache/CachedResource.h:
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::updateCachedResourceWithCurrentRequest):
(WebCore::CachedResourceLoader::prepareFetch): Introduced to implement step 1 to 7 of https://fetch.spec.whatwg.org/#fetching.
(WebCore::CachedResourceLoader::requestResource):
- loader/cache/CachedResourceLoader.h:
- loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::setAsPotentiallyCrossOrigin): Storing origin.
- loader/cache/CachedResourceRequest.h:
(WebCore::CachedResourceRequest::setOrigin):
(WebCore::CachedResourceRequest::releaseOrigin):
(WebCore::CachedResourceRequest::origin):
LayoutTests:
Updated test to expect load even though CORS checks should fail as the document origin has universal access.
- http/tests/local/script-crossorigin-loads-fail-origin-expected.txt: Removed.
- http/tests/local/script-crossorigin-loads-file-scheme-expected.txt: Added.
- http/tests/local/script-crossorigin-loads-file-scheme.html: Renamed from LayoutTests/http/tests/local/script-crossorigin-loads-fail-origin.html.
- 1:28 AM Changeset in webkit [206254] by
-
- 18 edits in trunk/Source/WebCore
Refactor ContentSecurityPolicy::allow* methods
https://bugs.webkit.org/show_bug.cgi?id=162335
Patch by Youenn Fablet <youenn@apple.com> on 2016-09-22
Reviewed by Darin Adler.
No change of behavior.
Removing the second parameter of ContentSecurityPolicy::allow* methods.
When true, this parameter makes the methods return true.
This patch updates the callers of allow* methods to check for the parameter before making the call.
Made some refactoring to share more code between the various allow* methods.
- Modules/fetch/FetchLoader.cpp:
(WebCore::FetchLoader::start):
- Modules/websockets/WebSocket.cpp:
(WebCore::WebSocket::connect):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::isSafeToLoadURL):
(WebCore::HTMLMediaElement::outOfBandTrackSources):
- html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::allowedToLoadPluginContent):
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::canLoadURL):
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):
(WebCore::DocumentThreadableLoader::redirectReceived):
(WebCore::DocumentThreadableLoader::loadRequest):
(WebCore::DocumentThreadableLoader::isAllowedByContentSecurityPolicy):
- loader/DocumentThreadableLoader.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkIfFormActionAllowedByCSP):
- loader/PolicyChecker.cpp:
(WebCore::isAllowedByContentSecurityPolicy):
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::createJavaAppletWidget):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::allowedByContentSecurityPolicy):
- page/EventSource.cpp:
(WebCore::EventSource::create):
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::allowObjectFromSource):
(WebCore::ContentSecurityPolicy::allowChildFrameFromSource):
(WebCore::ContentSecurityPolicy::allowResourceFromSource):
(WebCore::ContentSecurityPolicy::allowChildContextFromSource):
(WebCore::ContentSecurityPolicy::allowScriptFromSource):
(WebCore::ContentSecurityPolicy::allowImageFromSource):
(WebCore::ContentSecurityPolicy::allowStyleFromSource):
(WebCore::ContentSecurityPolicy::allowFontFromSource):
(WebCore::ContentSecurityPolicy::allowMediaFromSource):
(WebCore::ContentSecurityPolicy::allowConnectToSource):
(WebCore::ContentSecurityPolicy::allowFormAction):
- page/csp/ContentSecurityPolicy.h:
- workers/AbstractWorker.cpp:
(WebCore::AbstractWorker::resolveURL):
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::importScripts):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::initSend):
- 12:57 AM Changeset in webkit [206253] by
-
- 7 edits3 adds in trunk
[css-grid] Remove the x2 computation of row sizes with indefinite heights
https://bugs.webkit.org/show_bug.cgi?id=162150
Reviewed by Darin Adler.
PerformanceTests:
Added a new test case which checks the layout performance of grids inside other grids, i.e,
grids acting both as grid container and grid item.
- Layout/nested-grid.html: Added.
Source/WebCore:
On r192154, among other things, we added a second pass of the track sizing algorithm for
rows in order to properly compute row sizes when the height was indefinite. We did that in
order to have a symmetrical implementation for columns and rows, but unfortunatelly that was
not correct.
Apart from issuing incorrect results in some cases it created a huge performance issue in
the case of having nested grids because we were exponentially increasing the amount of
executions of the track sizing algorithm. The attached performance test shows a 200%
improvement with the patch (26 vs 80 runs/s).
Test: fast/css-grid-layout/nested-grid.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::computeIntrinsicLogicalHeight):
(WebCore::RenderGrid::layoutGridItems):
LayoutTests:
Added a new reftest to check the behavior of grids acting also as grid items and how the
track sizing of rows depend on that. It includes tests for grids which stretch their
children and grids which do not.
Apart from that some expected results were updated so that they no longer fail.
- fast/css-grid-layout/maximize-tracks-definite-indefinite-height.html: Updated expectations.
- fast/css-grid-layout/nested-grid-expected.html: Added.
- fast/css-grid-layout/nested-grid.html: Added.
- fast/css-grid-layout/percent-track-breadths-regarding-container-size.html: Removed FIXME.
- fast/css-grid-layout/percent-track-breadths-regarding-container-size-expected.txt: Fixed 2
failing tests.
- 12:35 AM Changeset in webkit [206252] by
-
- 34 edits in trunk/Source/WebCore
Improve DeferredWrapper code
https://bugs.webkit.org/show_bug.cgi?id=161787
Patch by Youenn Fablet <youenn@apple.com> on 2016-09-22
Reviewed by Darin Adler.
No change of behavior.
Renaming DeferredWrapper to DeferredPromise.
Adding create method that creates the underlying JSC::JSPromiseDeferred in non-worker environments.
Updated create method to take references.
Introducing domWindow helper accessor into JSDOMObject to ease creation of promise in non-worker environments.
Doing some minor clean up (renaming of m_wrapper to m_promiseDeferred, accessor change).
- Modules/applepay/ApplePaySession.cpp:
(WebCore::ApplePaySession::canMakePaymentsWithActiveCard):
- Modules/applepay/ApplePaySession.h:
- Modules/fetch/DOMWindowFetch.cpp:
(WebCore::DOMWindowFetch::fetch):
- Modules/fetch/DOMWindowFetch.h: Updated to take a DeferredPromise to make it consistent with WorkerGlobalScopeFetch.
- Modules/fetch/FetchBody.cpp:
(WebCore::FetchBody::arrayBuffer):
(WebCore::FetchBody::blob):
(WebCore::FetchBody::json):
(WebCore::FetchBody::text):
(WebCore::FetchBody::consume):
(WebCore::FetchBody::consumeArrayBuffer):
(WebCore::FetchBody::consumeArrayBufferView):
(WebCore::FetchBody::consumeText):
(WebCore::FetchBody::consumeBlob):
- Modules/fetch/FetchBody.h:
(WebCore::FetchBody::formData):
- Modules/fetch/FetchBodyConsumer.cpp:
(WebCore::FetchBodyConsumer::resolveWithData):
(WebCore::FetchBodyConsumer::resolve):
- Modules/fetch/FetchBodyConsumer.h:
- Modules/fetch/FetchBodyOwner.cpp:
(WebCore::FetchBodyOwner::arrayBuffer):
(WebCore::FetchBodyOwner::blob):
(WebCore::FetchBodyOwner::formData):
(WebCore::FetchBodyOwner::json):
(WebCore::FetchBodyOwner::text):
- Modules/fetch/FetchBodyOwner.h:
- Modules/fetch/FetchResponse.cpp:
(WebCore::FetchResponse::consume):
(WebCore::FetchResponse::finishConsumingStream):
- Modules/fetch/FetchResponse.h:
- Modules/fetch/WorkerGlobalScopeFetch.cpp:
(WebCore::WorkerGlobalScopeFetch::fetch):
- Modules/fetch/WorkerGlobalScopeFetch.h:
- bindings/js/JSCustomElementRegistryCustom.cpp:
(WebCore::whenDefinedPromise):
(WebCore::JSCustomElementRegistry::whenDefined):
- bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::visitChildren):
- bindings/js/JSDOMGlobalObject.h:
- bindings/js/JSDOMPromise.cpp:
(WebCore::DOMDeferredPromise::DOMDeferredPromise):
(WebCore::DOMDeferredPromise::~DOMDeferredPromise):
(WebCore::DOMDeferredPromise::clear):
(WebCore::DOMDeferredPromise::contextDestroyed):
(WebCore::DOMDeferredPromise::promise):
(WebCore::DOMDeferredPromise::callFunction):
(WebCore::DOMDeferredPromise::reject):
(WebCore::rejectPromiseWithExceptionIfAny):
(WebCore::fulfillPromiseWithJSON):
(WebCore::fulfillPromiseWithArrayBuffer):
(WebCore::DeferredWrapper::DeferredWrapper): Deleted.
(WebCore::DeferredWrapper::~DeferredWrapper): Deleted.
(WebCore::DeferredWrapper::clear): Deleted.
(WebCore::DeferredWrapper::contextDestroyed): Deleted.
(WebCore::DeferredWrapper::promise): Deleted.
(WebCore::DeferredWrapper::callFunction): Deleted.
(WebCore::DeferredWrapper::reject): Deleted.
- bindings/js/JSDOMPromise.h:
(WebCore::DOMDeferredPromise::create):
(WebCore::callPromiseFunction):
(WebCore::DOMPromise::DOMPromise):
(WebCore::DOMPromise::deferredPromise):
(WebCore::DOMDeferredPromise::resolveWithValue):
(WebCore::DOMDeferredPromise::resolveWithNewlyCreated):
(WebCore::DOMDeferredPromise::rejectWithValue):
(WebCore::DOMDeferredPromise::resolve):
(WebCore::DOMDeferredPromise::reject):
(WebCore::DeferredWrapper::create): Deleted.
(WebCore::DOMPromise::deferredWrapper): Deleted.
(WebCore::DeferredWrapper::resolveWithValue): Deleted.
(WebCore::DeferredWrapper::resolveWithNewlyCreated): Deleted.
(WebCore::DeferredWrapper::rejectWithValue): Deleted.
(WebCore::DeferredWrapper::resolve): Deleted.
(WebCore::DeferredWrapper::reject): Deleted.
- bindings/js/JSDOMWrapper.cpp: Introducing domWindow() accessor.
- bindings/js/JSDOMWrapper.h:
- bindings/js/JSFontFaceCustom.cpp:
(WebCore::JSFontFace::loaded):
- bindings/js/JSFontFaceSetCustom.cpp:
(WebCore::JSFontFaceSet::ready):
- bindings/js/JSMediaDevicesCustom.cpp:
(WebCore::JSMediaDevices::getUserMedia):
- bindings/js/JSMediaStreamTrackCustom.cpp:
(WebCore::JSMediaStreamTrack::applyConstraints):
- bindings/js/JSReadableStreamSourceCustom.cpp:
(WebCore::JSReadableStreamSource::start):
- bindings/js/JSWebKitSubtleCryptoCustom.cpp:
(WebCore::JSWebKitSubtleCrypto::encrypt):
(WebCore::JSWebKitSubtleCrypto::decrypt):
(WebCore::JSWebKitSubtleCrypto::sign):
(WebCore::JSWebKitSubtleCrypto::verify):
(WebCore::JSWebKitSubtleCrypto::digest):
(WebCore::JSWebKitSubtleCrypto::generateKey):
(WebCore::JSWebKitSubtleCrypto::importKey):
(WebCore::JSWebKitSubtleCrypto::exportKey):
(WebCore::JSWebKitSubtleCrypto::wrapKey):
(WebCore::JSWebKitSubtleCrypto::unwrapKey):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateImplementation):
(GenerateReturnParameters):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionTestPromiseFunctionPromise):
(WebCore::jsTestObjPrototypeFunctionTestPromiseFunctionWithFloatArgumentPromise):
(WebCore::jsTestObjPrototypeFunctionTestPromiseFunctionWithExceptionPromise):
(WebCore::jsTestObjPrototypeFunctionTestPromiseFunctionWithOptionalIntArgumentPromise):
(WebCore::jsTestObjPrototypeFunctionTestPromiseOverloadedFunction1Promise):
(WebCore::jsTestObjPrototypeFunctionTestPromiseOverloadedFunction2Promise):
(WebCore::jsTestObjConstructorFunctionTestStaticPromiseFunctionPromise):
(WebCore::jsTestObjConstructorFunctionTestStaticPromiseFunctionWithExceptionPromise):
- dom/CustomElementRegistry.h:
(WebCore::CustomElementRegistry::promiseMap):
Sep 21, 2016:
- 11:07 PM Changeset in webkit [206251] by
-
- 5 edits in tags/Safari-603.1.6.0.1/Source
Versioning.
- 11:03 PM Changeset in webkit [206250] by
-
- 1 copy in tags/Safari-603.1.6.0.1
New tag.
- 11:01 PM Changeset in webkit [206249] by
-
- 6 edits in trunk/Source
Rolling out r206244, as it caused flaky crashes on tests.
Was: Correct uses of 'safeCast'
Source/WebCore:
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::adjustSize):
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::destroyMetadataAndNotify):
(WebCore::BitmapImage::cacheFrame):
(WebCore::BitmapImage::didDecodeProperties):
(WebCore::BitmapImage::dataChanged):
(WebCore::BitmapImage::frameImageAtIndex):
- platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::decodedSizeChanged):
(WebCore::PDFDocumentImage::updateCachedImageIfNeeded):
Source/WTF:
- wtf/StdLibExtras.h:
(WTF::safeCast):
- 10:19 PM Changeset in webkit [206248] by
-
- 3 edits in trunk/LayoutTests
Unreviewed, update ios-simulator-wk1 test expectations
- platform/ios-simulator-wk1/TestExpectations:
- platform/ios-simulator/TestExpectations:
- 10:03 PM Changeset in webkit [206247] by
-
- 6 edits in trunk
[macOS] Upon layout, _webView:renderingProgressDidChange: fires before the intrinsic content size is updated
https://bugs.webkit.org/show_bug.cgi?id=162359
<rdar://problem/27776454>
Reviewed by Tim Horton.
Source/WebKit2:
Test: added to TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h: Fixed a bug where m_pendingNewlyReachedLayoutMilestones was never initialized.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h: Added m_pendingNewlyReachedLayoutMilestones member variable to this derived class as well.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::flushLayers): If we have pending milestones, notify
the WebPageProxy now, after any content size changes have been sent.
(WebKit::TiledCoreAnimationDrawingArea::dispatchDidReachLayoutMilestone): New override that
accumulates the milestones into m_pendingNewlyReachedLayoutMilestones and returns true,
so that the caller won’t notify the WebPageProxy immediately.
Tools:
- TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
(TEST):
- 9:36 PM Changeset in webkit [206246] by
-
- 6 edits2 adds in trunk
Fix serialization of bgsound, keygen and track elements
https://bugs.webkit.org/show_bug.cgi?id=162353
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C tests now that more checks are passing.
- web-platform-tests/html/syntax/serializing-html-fragments/outerHTML-expected.txt:
- web-platform-tests/html/syntax/serializing-html-fragments/serializing-expected.txt:
- web-platform-tests/html/syntax/serializing-xml-fragments/outerHTML-expected.txt:
Source/WebCore:
Fix serialization of keygen and track elements to match the specification:
They are not supposed to have an end tag. Firefox and Chrome agree with
the specification.
No new tests, rebaselined existing tests.
- editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::elementCannotHaveEndTag):
- 9:32 PM Changeset in webkit [206245] by
-
- 22 edits in trunk
Fix build for future versions of Clang.
https://bugs.webkit.org/show_bug.cgi?id=162346
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
This fixes issues with the WebCore build where inline
template-class function definitions are marked as exported. This
genereates a weak external symobl that our build does not like.
- runtime/VM.h:
(JSC::VM::setGlobalConstRedeclarationShouldThrow):
Source/WebCore:
This fixes issues with the WebCore build where inline
template-class function definitions are marked as exported. This
genereates a weak external symobl that our build does not like.
- Configurations/WebCore.unexp:
- dom/Exception.h:
- page/Frame.h:
- platform/cocoa/WebPlaybackSessionModelMediaElement.h:
- platform/cocoa/WebVideoFullscreenModelVideoElement.h:
(WebCore::WebVideoFullscreenModelVideoElement::videoElement):
- platform/graphics/Color.h:
- platform/graphics/transforms/TransformationMatrix.h:
(WebCore::TransformationMatrix::rotate):
- platform/mac/WebVideoFullscreenInterfaceMac.h:
- platform/network/ParsedContentRange.h:
(WebCore::ParsedContentRange::ParsedContentRange):
(WebCore::ParsedContentRange::isValid):
- platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::certificateInfo):
- platform/text/TextStream.h:
(WebCore::TextStream::increaseIndent):
(WebCore::TextStream::decreaseIndent):
Source/WTF:
This fixes issues with the WebCore build where inline
template-class function definitions are marked as exported. This
genereates a weak external symobl that our build does not like.
- wtf/text/StringImpl.h:
Tools:
- TestWebKitAPI/Counters.cpp:
- TestWebKitAPI/Counters.h:
(DeleterCounter::deleterCount):
(DeleterCounter::TestingScope::TestingScope):
(DeleterCounter::operator()):
- TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WTF/HashMap.cpp:
(TestWebKitAPI::TEST):
- 6:23 PM Changeset in webkit [206244] by
-
- 6 edits in trunk/Source
Correct uses of 'safeCast'
https://bugs.webkit.org/show_bug.cgi?id=162301
<rdar://problem/28343658>
Reviewed by Antti Koivisto.
Source/WebCore:
A number of integer calculations in BitmapImage and PDFDocumentImage
are not properly checked for overflow. Correct this.
Tested by fast/images/large-size-image-crash.html
- loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::adjustSize): RELEASE_ASSERT on overflow.
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::destroyMetadataAndNotify):
(WebCore::BitmapImage::cacheFrame):
(WebCore::BitmapImage::didDecodeProperties):
(WebCore::BitmapImage::dataChanged):
(WebCore::BitmapImage::ensureFrameAtIndexIsCached):
(WebCore::BitmapImage::frameImageAtIndex):
- platform/graphics/BitmapImage.h:
- platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::decodedSizeChanged):
(WebCore::PDFDocumentImage::updateCachedImageIfNeeded):
Source/WTF:
- wtf/StdLibExtras.h:
(WTF::safeCast): RELEASE_ASSERT on overflow.
- 4:50 PM Changeset in webkit [206243] by
-
- 11 edits in trunk
Setting HTMLMeterElement's attributes to non-finite values throws wrong exception type
https://bugs.webkit.org/show_bug.cgi?id=162364
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Merge meter test changes from https://github.com/w3c/web-platform-tests/pull/3791.
- web-platform-tests/html/semantics/forms/the-meter-element/meter-expected.txt:
- web-platform-tests/html/semantics/forms/the-meter-element/meter.html:
Source/WebCore:
Setting HTMLMeterElement's attributes to non-finite values throws wrong exception type.
It should throw a TypeError because their type is 'double' but we throw a
NOT_SUPPORTED_ERR.
Specification:
Firefox and Chrome agree with the specification.
No new tests, updated existing test.
- html/HTMLMeterElement.cpp:
(WebCore::HTMLMeterElement::setMin):
(WebCore::HTMLMeterElement::setMax):
(WebCore::HTMLMeterElement::setValue):
(WebCore::HTMLMeterElement::setLow):
(WebCore::HTMLMeterElement::setHigh):
(WebCore::HTMLMeterElement::setOptimum):
- html/HTMLMeterElement.h:
- html/HTMLMeterElement.idl:
LayoutTests:
Update existing test to reflect behavior change.
- fast/dom/HTMLMeterElement/script-tests/set-meter-properties.js:
- fast/dom/HTMLMeterElement/set-meter-properties-expected.txt:
- 4:20 PM Changeset in webkit [206242] by
-
- 2 edits in trunk/Source/WebCore
Fix open source build.
- platform/spi/cocoa/PassKitSPI.h:
- 4:08 PM Changeset in webkit [206241] by
-
- 2 edits in trunk/Source/WebCore
Fix spelling errors (that were supposed to be part of my previous commit).
- 3:52 PM Changeset in webkit [206240] by
-
- 7 edits in trunk
Fix serialization of HTML Element attributes
https://bugs.webkit.org/show_bug.cgi?id=162356
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
- web-platform-tests/html/semantics/embedded-content/the-img-element/current-pixel-density/basic-expected.txt:
- web-platform-tests/html/syntax/serializing-html-fragments/serializing-expected.txt:
Source/WebCore:
Fix serialization of HTML Element attributes to align with:
- https://html.spec.whatwg.org/#html-fragment-serialisation-algorithm
- https://html.spec.whatwg.org/#escapingString
In particular, we should not escape '<' and '>'.
Firefox and Chrome both match the specification.
Note that we keep escaping '<' and '>' for Element attributes in the
context of XML serialization, as per:
No new tests, rebaselined existing test.
- editing/MarkupAccumulator.h:
LayoutTests:
Rebaseline test to reflect behavior change.
- editing/pasteboard/paste-noscript-expected.txt:
- 3:52 PM Changeset in webkit [206239] by
-
- 3 edits in trunk/Source/JavaScriptCore
Inline function only used in one place
https://bugs.webkit.org/show_bug.cgi?id=162363
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-09-21
Reviewed by Saam Barati.
- bytecompiler/NodesCodegen.cpp:
(JSC::ForInNode::emitBytecode):
(JSC::ForInNode::emitMultiLoopBytecode):
- parser/Nodes.h:
No need for the extra function, it adds no clarification.
- 3:51 PM Changeset in webkit [206238] by
-
- 20 edits in trunk/Source
Source/WebCore:
support openPaymentSetup API on ApplePaySession object
https://bugs.webkit.org/show_bug.cgi?id=162357
rdar://problem/26776939
Reviewed by Tim Horton.
- Modules/applepay/ApplePaySession.cpp:
(WebCore::ApplePaySession::openPaymentSetup):
Perform security checks and then call into the PaymentCoordiantor. In its completion handler, we resolve the promise.
- Modules/applepay/ApplePaySession.h:
Add new members.
- Modules/applepay/ApplePaySession.idl:
Add openPaymentSetup declaration.
- Modules/applepay/PaymentCoordinator.cpp:
(WebCore::PaymentCoordinator::openPaymentSetup):
Call through to the clients.
- Modules/applepay/PaymentCoordinator.h:
- Modules/applepay/PaymentCoordinatorClient.h:
Add new members.
- loader/EmptyClients.cpp:
Add new stub.
- platform/spi/cocoa/PassKitSPI.h:
Add SPI declaration.
Source/WebKit/mac:
Support openPaymentSetup API on ApplePaySession object
https://bugs.webkit.org/show_bug.cgi?id=162357
rdar://problem/26776939
Reviewed by Tim Horton.
Add openPaymentSetup stub.
- WebCoreSupport/WebPaymentCoordinatorClient.h:
- WebCoreSupport/WebPaymentCoordinatorClient.mm:
(WebPaymentCoordinatorClient::openPaymentSetup):
Source/WebKit2:
support openPaymentSetup API on ApplePaySession object
https://bugs.webkit.org/show_bug.cgi?id=162357
rdar://problem/26776939
Reviewed by Tim Horton.
- UIProcess/ApplePay/WebPaymentCoordinatorProxy.cpp:
(WebKit::WebPaymentCoordinatorProxy::openPaymentSetup):
Call through to platformOpenPaymentSetup, and in the completion handler, send back a OpenPaymentSetupReply message.
- UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:
Add new members.
- UIProcess/ApplePay/WebPaymentCoordinatorProxy.messages.in:
Add OpenPaymentSetup message.
- UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
(WebKit::WebPaymentCoordinatorProxy::platformOpenPaymentSetup):
Allocate a PKPassLibrary and call openPaymentSetupForMerchantIdentifier:domain:completion: on it.
- WebProcess/ApplePay/WebPaymentCoordinator.cpp:
(WebKit::generateOpenPaymentSetupReplyID):
New helper function to generate a reply ID.
(WebKit::WebPaymentCoordinator::openPaymentSetup):
Add the completion handler to m_pendingOpenPaymentSetupCallbacks and send a OpenPaymentSetup message to the UI process.
(WebKit::WebPaymentCoordinator::openPaymentSetupReply):
Grab the callback given its ID and invoke it.
- WebProcess/ApplePay/WebPaymentCoordinator.h:
Add new members.
- WebProcess/ApplePay/WebPaymentCoordinator.messages.in:
Add OpenPaymentSetupReply message.
- 2:40 PM Changeset in webkit [206237] by
-
- 7 edits in trunk
Web Inspector: Improve output of TestHarness.expect* failures
https://bugs.webkit.org/show_bug.cgi?id=162177
<rdar://problem/28367186>
Reviewed by Joseph Pecoraro.
Source/WebInspectorUI:
This patch adds specific expectation functions to TestHarness, to better
express intent when writing tests, and to allow more details to be logged
in the event of a failure.
For functions taking both
actualandexpectedparameters, theactual
parameter comes first. This convention simplifies the implementation of
TestHarness, improves the readability of tests involving inequalities,
and is consistent with XCTest assertions.
- UserInterface/Test/TestHarness.js:
(TestHarness):
(TestHarness.prototype.expectThat):
(TestHarness.prototype.expectFalse):
(TestHarness.prototype.expectNull):
(TestHarness.prototype.expectNotNull):
(TestHarness.prototype.expectEqual):
(TestHarness.prototype.expectNotEqual):
(TestHarness.prototype.expectShallowEqual):
(TestHarness.prototype.expectNotShallowEqual):
(TestHarness.prototype.expectEqualWithAccuracy):
(TestHarness.prototype.expectLessThan):
(TestHarness.prototype.expectLessThanOrEqual):
(TestHarness.prototype.expectGreaterThan):
(TestHarness.prototype.expectGreaterThanOrEqual):
New expectation functions, all of which call _expect under the hood.
(TestHarness.prototype._expect):
Helper method which calls pass or fail. Creates a message when no user
message is provided, and logs expected and actual values in the event
of a failure.
(TestHarness.prototype._expectationValueAsString):
(TestHarness.prototype._expectationMessageFormat):
Get a message format string for the expectation type. Used to create
pass/fail message when no user message is provided.
(TestHarness.prototype._expectedValueFormat):
Get a format string for displaying the expected value. Used to create
the "Expected: " failure message line.
LayoutTests:
Extend coverage to more TestHarness messages by omitting the optional
messageparameter when calling expect* functions.
Other improvements:
- expectEqual/expectNotEqual should test WebInspector object instances, to cover more TestHarness message formatting cases.
- expectEqual/expectNotEqual should test shallow equal arrays, since the test is for strict equality.
- inspector/indexeddb/requestData-expected.txt:
- inspector/unit-tests/number-utilities-expected.txt:
Updated expectations for new TestHarness output.
- inspector/unit-tests/test-harness-expect-functions-expected.txt:
- inspector/unit-tests/test-harness-expect-functions.html:
- 2:22 PM Changeset in webkit [206236] by
-
- 22 edits in trunk
Unreviewed, rolling out r206222 and r206227.
https://bugs.webkit.org/show_bug.cgi?id=162361
"broke the windows build" (Requested by keith_mi_ on #webkit).
Reverted changesets:
"Fix build for future versions of Clang."
https://bugs.webkit.org/show_bug.cgi?id=162346
http://trac.webkit.org/changeset/206222
"Attempt to fix windows build after r206222."
http://trac.webkit.org/changeset/206227
- 2:16 PM Changeset in webkit [206235] by
-
- 4 edits in trunk
URLParser should match URL::parse when parsing data urls with slashes in them
https://bugs.webkit.org/show_bug.cgi?id=162352
Reviewed by Darin Adler.
Source/WebCore:
Covered by new API tests.
- platform/URLParser.cpp:
(WebCore::URLParser::parse):
Tools:
- TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):
- 1:53 PM Changeset in webkit [206234] by
-
- 2 edits in trunk/Source/WebCore
[Win] Null pointer crash under WebCore::CACFLayerTreeHost::create().
https://bugs.webkit.org/show_bug.cgi?id=162266
<rdar://problem/28345073>
Reviewed by Brent Fulgham.
Add null pointer check.
- platform/graphics/ca/win/CACFLayerTreeHost.cpp:
(WebCore::CACFLayerTreeHost::create):
- 1:47 PM Changeset in webkit [206233] by
-
- 5 edits in trunk
Fix enumeration of properties cross origin
https://bugs.webkit.org/show_bug.cgi?id=162328
Reviewed by Darin Adler.
LayoutTests/imported/w3c:
Rebaseline W3C test now that one more check is passing.
- web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt:
Source/WebCore:
All cross origin properties for Window / Location are supposed to be not enumerable:
Therefore, there should be no properties to iterate on for cross origin Window /
Location objects.
No new tests, rebaselined existing test.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertyNames):
- bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::getOwnPropertyNames):
- 1:40 PM Changeset in webkit [206232] by
-
- 2 edits in trunk/LayoutTests
Marking inspector/css/manager-preferredInspectorStyleSheetForFrame.html as flaky on mac.
https://bugs.webkit.org/show_bug.cgi?id=162305
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 1:19 PM Changeset in webkit [206231] by
-
- 4 edits in trunk
URLParser should fail when parsing invalid relative URLs with no schemes
https://bugs.webkit.org/show_bug.cgi?id=162355
Reviewed by Tim Horton.
Source/WebCore:
Covered by new API tests.
- platform/URLParser.cpp:
(WebCore::copyASCIIStringUntil):
When copying from a null String, is8Bit dereferences a null pointer. We don't want to do that.
(WebCore::URLParser::parse):
What the spec calls a "null" URL matches !url.isValid(), not url.isNull().
The former reflects whether the parsing succeeded,
the latter whether the contained String (which could be an invalid URL) is null.
Tools:
- TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):
- 12:59 PM Changeset in webkit [206230] by
-
- 2 edits in trunk/Source/WebCore
Document::styleResolverChanged simplification
https://bugs.webkit.org/show_bug.cgi?id=162347
Reviewed by Anders Carlsson.
- dom/Document.cpp:
(WebCore::Document::implicitClose):
(WebCore::Document::setParsing):
(WebCore::Document::write):
(WebCore::Document::styleResolverChanged):
- Remove unncessary AnimationUpdateBlock, it is created by recalcStyle.
- Remove explicit setNeedsLayoutAndPrefWidthsRecalc/scheduleRelayout calls, style resolution invalidates those as needed.
- Remove evaluateMediaQueryList call, that is done on layout as needed.
- Remove the ancient INSTRUMENT_LAYOUT_SCHEDULING and the related printfs.
- 12:42 PM Changeset in webkit [206229] by
-
- 5 edits in trunk/Source
Versioning.
- 12:38 PM Changeset in webkit [206228] by
-
- 1 copy in tags/Safari-603.1.6
New tag.
- 12:33 PM Changeset in webkit [206227] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix windows build after r206222.
- page/MainFrame.h:
(WebCore::Frame::isMainFrame):
- 12:09 PM Changeset in webkit [206226] by
-
- 17 edits2 adds in trunk
Add a Fence opcode to B3
https://bugs.webkit.org/show_bug.cgi?id=162343
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
This adds the most basic fence support to B3. Currently, this is optimal on x86 and correct
on ARM. It also happens to be sufficient and optimal for what we'll do in the concurrent GC.
The idea of Fence is that it can represent any standalone fence instruction by having two
additional params: a read range and a write range. If the write range is empty, this is
taken to be a store-store fence, which turns into zero code on x86 and a cheaper fence on
ARM.
It turns out that this is powerful enough to express store-load and store-store fences. For
load-store and load-load fences, you wouldn't have wanted to use any code on x86 and you
wouldn't have wanted a standalone barrier on ARM. For those cases, you'd want either a
fenced load (load acquire) or a dependency. See bug 162349 and bug 162350, respectively.
This isn't yet optimized for store-store fences on ARM because we don't have the
MacroAssembler support. Also, the support for "dmb ish" is not really what we want (it seems
to use a heavier fence). I don't think that this is urgent because of how the concurrent GC
will use this facility. I've left that to bug 162342.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- assembler/MacroAssemblerCodeRef.cpp:
(JSC::MacroAssemblerCodeRef::tryToDisassemble):
(JSC::MacroAssemblerCodeRef::disassembly):
- assembler/MacroAssemblerCodeRef.h:
(JSC::MacroAssemblerCodeRef::size): Deleted.
(JSC::MacroAssemblerCodeRef::tryToDisassemble): Deleted.
- b3/B3Compilation.h:
(JSC::B3::Compilation::codeRef):
(JSC::B3::Compilation::disassembly):
(JSC::B3::Compilation::code): Deleted.
- b3/B3Effects.h:
- b3/B3FenceValue.cpp: Added.
(JSC::B3::FenceValue::~FenceValue):
(JSC::B3::FenceValue::cloneImpl):
(JSC::B3::FenceValue::FenceValue):
- b3/B3FenceValue.h: Added.
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::lower):
- b3/B3Opcode.cpp:
(WTF::printInternal):
- b3/B3Opcode.h:
- b3/B3Validate.cpp:
- b3/B3Value.cpp:
(JSC::B3::Value::effects):
- b3/air/AirOpcode.opcodes:
- b3/testb3.cpp:
(JSC::B3::checkUsesInstruction):
(JSC::B3::checkDoesNotUseInstruction):
(JSC::B3::testX86MFence):
(JSC::B3::testX86CompilerFence):
(JSC::B3::run):
Websites/webkit.org:
- docs/b3/intermediate-representation.html:
- 11:42 AM Changeset in webkit [206225] by
-
- 2 edits in releases/WebKitGTK/webkit-2.14/Source/WebKit2
Merge 206216 - Unreviewed, build fix.
- UIProcess/gtk/AcceleratedBackingStoreWayland.cpp:
(WebKit::AcceleratedBackingStoreWayland::paint): fix usage of deviceScaleFactor variable which was
removed.
- 11:41 AM Changeset in webkit [206224] by
-
- 2 edits in trunk/Source/WebCore
New DocumentLoader logging causes crashes
https://bugs.webkit.org/show_bug.cgi?id=162348
<rdar://problem/28404744>
Patch by Keith Rollin <Keith Rollin> on 2016-09-21
Reviewed by Chris Dumez
Check for NULL m_frame before using it.
No new tests -- no tests for logging, though this issue was found by
contentfiltering/block-after-will-send-request-then-allow-unblock.html
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource):
- 11:33 AM Changeset in webkit [206223] by
-
- 2 edits in trunk/Source/WebCore
Optimize URLParser
https://bugs.webkit.org/show_bug.cgi?id=162338
Reviewed by Tim Horton.
No change in behavior. Just a marginal performance improvement.
- platform/URLParser.cpp:
(WebCore::isValidSchemeCharacter):
Added to reduce branches when parsing the scheme of a URL. Now there is a table lookup instead of many range checks.
(WebCore::URLParser::parse):
Use appendVector, which uses memcpy.
(WebCore::URLParser::parseHostAndPort):
If we know that we are parsing the serialized output of a valid URL,
we do not need to convert host characters to lower case.
They are already lower case.
- 11:24 AM Changeset in webkit [206222] by
-
- 21 edits in trunk
Fix build for future versions of Clang.
https://bugs.webkit.org/show_bug.cgi?id=162346
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
This fixes issues with the WebCore build where inline
template-class function definitions are marked as exported. This
genereates a weak external symobl that our build does not like.
- runtime/VM.h:
(JSC::VM::setGlobalConstRedeclarationShouldThrow):
Source/WebCore:
This fixes issues with the WebCore build where inline
template-class function definitions are marked as exported. This
genereates a weak external symobl that our build does not like.
- Configurations/WebCore.unexp:
- dom/Exception.h:
- page/Frame.h:
- platform/cocoa/WebPlaybackSessionModelMediaElement.h:
- platform/cocoa/WebVideoFullscreenModelVideoElement.h:
(WebCore::WebVideoFullscreenModelVideoElement::videoElement):
- platform/graphics/Color.h:
- platform/graphics/transforms/TransformationMatrix.h:
(WebCore::TransformationMatrix::rotate):
- platform/mac/WebVideoFullscreenInterfaceMac.h:
- platform/network/ParsedContentRange.h:
(WebCore::ParsedContentRange::ParsedContentRange):
(WebCore::ParsedContentRange::isValid):
- platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::certificateInfo):
- platform/text/TextStream.h:
(WebCore::TextStream::increaseIndent):
(WebCore::TextStream::decreaseIndent):
Source/WTF:
This fixes issues with the WebCore build where inline
template-class function definitions are marked as exported. This
genereates a weak external symobl that our build does not like.
- wtf/text/StringImpl.h:
Tools:
- TestWebKitAPI/Counters.cpp:
- TestWebKitAPI/Counters.h:
(DeleterCounter::deleterCount):
(DeleterCounter::TestingScope::TestingScope):
(DeleterCounter::operator()):
- TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WTF/HashMap.cpp:
(TestWebKitAPI::TEST):
- 11:23 AM Changeset in webkit [206221] by
-
- 10 edits2 adds in trunk
Object.getOwnPropertyDescriptor() does not work correctly cross origin
https://bugs.webkit.org/show_bug.cgi?id=162311
Reviewed by Gavin Barraclough.
LayoutTests/imported/w3c:
Rebaseline W3C test now that more checks are passing.
- web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt:
Source/JavaScriptCore:
Add a CustomGetterSetter field to PropertySlot that gets populated
by getOwnPropertySlot() and use it in getOwnPropertyDescriptor()
to properly populate the descriptor. We used to rely on reifying
the properties and then call getDirect() in order to get the
CustomGetterSetter. However, this hack was insufficient to support
the cross-origin case because we need to control more precisely
the visibility of the getter and the setter. For example, Location's
href property has both a getter and a setter in the same origin
case but only has a setter in the cross-origin case.
In the future, we can extend the use of PropertySlot's
customGetterSetter field to the same origin case and get rid of the
reification + getDirect() hack in getOwnPropertyDescriptor().
- runtime/JSObject.cpp:
(JSC::JSObject::getOwnPropertyDescriptor):
- runtime/PropertySlot.cpp:
(JSC::PropertySlot::customAccessorGetter):
- runtime/PropertySlot.h:
Source/WebCore:
Object.getOwnPropertyDescriptor() does not work correctly cross origin. In particular:
- We return value descriptors for attributes instead of getter/setter descriptors
- attributes / operations are wrongly marked as non-configurable
Corresponding specification:
- https://html.spec.whatwg.org/#crossoriginproperties-(-o-)
- https://html.spec.whatwg.org/#crossorigingetownpropertyhelper-(-o,-p-)
Test: http/tests/security/cross-origin-descriptors.html
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess):
- bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::getOwnPropertySlotDelegate):
LayoutTests:
Add layout test coverage.
- http/tests/security/cross-origin-descriptors-expected.txt: Added.
- http/tests/security/cross-origin-descriptors.html: Added.
- 11:04 AM Changeset in webkit [206220] by
-
- 2 edits in trunk/Tools
Prepare API tests for enabling URLParser by default
https://bugs.webkit.org/show_bug.cgi?id=162341
Reviewed by Tim Horton.
- TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::checkURL):
(TestWebKitAPI::checkRelativeURL):
(TestWebKitAPI::checkURLDifferences):
(TestWebKitAPI::checkRelativeURLDifferences):
(TestWebKitAPI::shouldFail):
- 11:02 AM Changeset in webkit [206219] by
-
- 4 edits in trunk
URLParser: Correctly parse URLs that are just nonspecialscheme:/
https://bugs.webkit.org/show_bug.cgi?id=162340
Reviewed by Tim Horton.
Source/WebCore:
Covered by new API tests.
- platform/URLParser.cpp:
(WebCore::URLParser::parse):
r206162 wasn't quite right. If a url is just nonspecialscheme:/ then the path should indeed be /
Tools:
- TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):
- 11:00 AM Changeset in webkit [206218] by
-
- 4 edits in trunk
URLParser: correctly parse relative URLs that are just one character
https://bugs.webkit.org/show_bug.cgi?id=162344
Reviewed by Tim Horton.
Source/WebCore:
Covered by new API tests.
- platform/URLParser.cpp:
(WebCore::URLParser::parse):
Tools:
- TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):
- 10:44 AM Changeset in webkit [206217] by
-
- 4 edits11 adds in trunk
REGRESSION (r201090): Setting style.webkitTextSizeAdjust does not change text change on iPad
https://bugs.webkit.org/show_bug.cgi?id=162227
<rdar://problem/27201529>
Reviewed by Simon Fraser.
Source/WebCore:
The CSS property -webkit-text-size-adjust should be respected on all iOS devices. Following
r201090 we respect it only on iPhone and in iPhone-apps run on iPad.
Tests: fast/text-autosizing/ios/ipad/programmatic-text-size-adjust.html
fast/text-autosizing/ios/ipad/text-size-adjust-inline-style.html
fast/text-autosizing/ios/programmatic-text-size-adjust.html
fast/text-autosizing/ios/text-size-adjust-inline-style.html
fast/text-autosizing/text-size-adjust-inline-style.html
- css/parser/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue): Remove unused code to validate -webkit-text-size-adjust.
This code is never used because -webkit-text-size-adjust is a value property (since it accepts a
<percentage> as a value and CSSParserFastPaths::isKeywordPropertyID(CSSPropertyWebkitTextSizeAdjust)
returns false). That is, it is not a keyword property.
(WebCore::CSSParser::parseValue): Always enable the -webkit-text-size-adjust CSS property when
building for iOS regardless of whether Settings:textAutosizingEnabled() is enabled.
LayoutTests:
Add tests to ensure setting the CSS property -webkit-text-size-adjust in a stylesheet or
programmatically is respected on iPhone and iPad. Also added a test to ensure that this
CSS property is ignored on macOS by default.
Note that we have existing tests that ensure that -webkit-text-size-adjust is respected
on macOS when the internal setting Settings::textAutosizingEnabled() is enabled.
- fast/text-autosizing/ios/ipad/programmatic-text-size-adjust-expected.txt: Added.
- fast/text-autosizing/ios/ipad/programmatic-text-size-adjust.html: Added.
- fast/text-autosizing/ios/ipad/text-size-adjust-inline-style-expected.html: Added.
- fast/text-autosizing/ios/ipad/text-size-adjust-inline-style.html: Added.
- fast/text-autosizing/ios/programmatic-text-size-adjust-expected.txt: Added.
- fast/text-autosizing/ios/programmatic-text-size-adjust.html: Added.
- fast/text-autosizing/ios/text-size-adjust-inline-style-expected.html: Added.
- fast/text-autosizing/ios/text-size-adjust-inline-style.html: Added.
- fast/text-autosizing/text-size-adjust-inline-style-expected.html: Added.
- fast/text-autosizing/text-size-adjust-inline-style.html: Added.
- platform/mac/TestExpectations: Skip the iOS and iPad tests on Mac. Otherwise, they will fail
because these tests intentionally do not call window.internal.settings.setTextAutosizingEnabled(true)
so as to test the default port behavior. And on Mac automatic text size adjustment is disabled
by default.
- 10:35 AM Changeset in webkit [206216] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, build fix.
- UIProcess/gtk/AcceleratedBackingStoreWayland.cpp:
(WebKit::AcceleratedBackingStoreWayland::paint): fix usage of deviceScaleFactor variable which was
removed.
- 10:20 AM Changeset in webkit [206215] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening; after r206208, update url-null.html test to reflect current (specced) behavior.
- fast/files/url-null-expected.txt:
- fast/files/url-null.html:
- 10:16 AM Changeset in webkit [206214] by
-
- 2 edits in trunk/LayoutTests/imported/w3c
Unreviewed gardening; add some whitespace to expected results.
- web-platform-tests/media-source/URL-createObjectURL-null-expected.txt:
- 9:28 AM Changeset in webkit [206213] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Build fails with GSTREAMER_GL enabled
https://bugs.webkit.org/show_bug.cgi?id=162337
Patch by Miguel Gomez <magomez@igalia.com> on 2016-09-21
Reviewed by Michael Catanzaro.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::ensureGstGLContext): Remove uneeded const.
- 9:26 AM Changeset in webkit [206212] by
-
- 7 edits in trunk/Source/JavaScriptCore
FTL needs to reserve callee stack space in bytes
https://bugs.webkit.org/show_bug.cgi?id=162324
Reviewed by Geoffrey Garen.
Changed two instances where we call B3::Procedure::requestCallArgAreaSize() with the
number of JSValue sized objects of stack space instead of bytes. The correct units
to use is bytes.
Renamed both the Air and B3 related callArgAreaSize() to callArgAreaSizeInBytes().
No new tests as this doesn't surface as an issue when arguments are passed on the stack.
- b3/B3Procedure.cpp:
(JSC::B3::Procedure::callArgAreaSizeInBytes):
(JSC::B3::Procedure::requestCallArgAreaSizeInBytes):
(JSC::B3::Procedure::callArgAreaSize): Deleted.
(JSC::B3::Procedure::requestCallArgAreaSize): Deleted.
- b3/B3Procedure.h:
- b3/air/AirAllocateStack.cpp:
(JSC::B3::Air::allocateStack):
- b3/air/AirCCallingConvention.cpp:
(JSC::B3::Air::computeCCallingConvention):
- b3/air/AirCode.h:
(JSC::B3::Air::Code::callArgAreaSizeInBytes):
(JSC::B3::Air::Code::requestCallArgAreaSizeInBytes):
(JSC::B3::Air::Code::callArgAreaSize): Deleted.
(JSC::B3::Air::Code::requestCallArgAreaSize): Deleted.
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstruct):
(JSC::FTL::DFG::LowerDFGToB3::compileCallOrConstructVarargs):
(JSC::FTL::DFG::LowerDFGToB3::compileCallEval):
- 9:25 AM Changeset in webkit [206211] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r206127): ASSERTION FAILED: !isClosed() in WebCore::MediaSource::detachFromElement
https://bugs.webkit.org/show_bug.cgi?id=162307
Reviewed by Eric Carlson.
The test is crashing when the ScriptExecutionContext is calling stop() on the media element before
it's attached MediaSource has been open()ed, which is a valid state. Removing this ASSERT().
- Modules/mediasource/MediaSource.cpp:
(WebCore::MediaSource::detachFromElement):
- 9:16 AM Changeset in webkit [206210] by
-
- 3 edits2 adds in trunk/LayoutTests
LayoutTests/imported/w3c:
Unreviewed gardening; added test expectations for new tests.
- web-platform-tests/media-source/mediasource-attach-stops-delaying-load-event-expected.txt: Added.
- web-platform-tests/media-source/mediasource-sourcebuffer-mode-timestamps-expected.txt: Added.
LayoutTests:
Unreviewed gardening; mark imported/w3c/web-platform-tests/media-source/ tests as passing by default
and mark specific tests to skip or fail (rather than vice versa).
- platform/mac/TestExpectations:
- 9:13 AM Changeset in webkit [206209] by
-
- 4 edits in trunk
[media-source] Fix imported/w3c/web-platform-tests/media-source/mediasource-activesourcebuffers.html
https://bugs.webkit.org/show_bug.cgi?id=162257
Reviewed by Eric Carlson.
Source/WebCore:
Some of the conditions in the track changed methods were reversed, and all failed to schedule
a change event.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::SourceBuffer::videoTrackSelectedChanged):
(WebCore::SourceBuffer::audioTrackEnabledChanged):
(WebCore::SourceBuffer::textTrackModeChanged):
LayoutTests:
- platform/mac/TestExpectations:
- 9:12 AM Changeset in webkit [206208] by
-
- 21 edits in trunk
[media-source] Fix imported/w3c/web-platform-tests/media-source/URL-createObjectURL-null.html
https://bugs.webkit.org/show_bug.cgi?id=162299
Reviewed by Eric Carlson.
Source/WebCore:
URL.createObjectURL() should not take an optional parameter (nor return an optional String).
(Ref: https://w3c.github.io/FileAPI/#dfn-createObjectURL)
- Modules/mediasource/DOMURLMediaSource.cpp:
(WebCore::DOMURLMediaSource::createObjectURL):
- Modules/mediasource/DOMURLMediaSource.h:
- Modules/mediasource/DOMURLMediaSource.idl:
- Modules/mediasource/MediaSourceRegistry.cpp:
(WebCore::MediaSourceRegistry::registerURL):
- Modules/mediasource/MediaSourceRegistry.h:
- Modules/mediastream/DOMURLMediaStream.cpp:
(WebCore::DOMURLMediaStream::createObjectURL):
- Modules/mediastream/DOMURLMediaStream.h:
- Modules/mediastream/DOMURLMediaStream.idl:
- Modules/mediastream/MediaStreamRegistry.cpp:
(WebCore::MediaStreamRegistry::registerURL):
- Modules/mediastream/MediaStreamRegistry.h:
- fileapi/Blob.cpp:
(WebCore::BlobURLRegistry::registerURL):
- html/DOMURL.cpp:
(WebCore::DOMURL::createObjectURL):
(WebCore::DOMURL::createPublicURL):
- html/DOMURL.h:
- html/DOMURL.idl:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setSrcObject):
- html/PublicURLManager.cpp:
(WebCore::PublicURLManager::registerURL):
- html/PublicURLManager.h:
- html/URLRegistry.h:
LayoutTests:
- platform/mac/TestExpectations:
- 5:39 AM Changeset in webkit [206207] by
-
- 3 edits in trunk/Source/JavaScriptCore
[ARM] Unreviewed buildfix after r206136.
- assembler/MacroAssembler.h:
- assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::branchPtr): Added.
- 5:16 AM WebKitGTK/Roadmap edited by
- Remove Iulian as primary contact of GAction work, mark as stalled (diff)
- 5:15 AM WebKitGTK/Roadmap edited by
- Use a different bug to track sandboxing, remove my name as primary contact (diff)
- 2:56 AM Changeset in webkit [206206] by
-
- 17 edits in trunk
[Fetch] Align Accept header default values with fetch spec
https://bugs.webkit.org/show_bug.cgi?id=162260
Patch by Youenn Fablet <youenn@apple.com> on 2016-09-21
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Ensuring Accept and Accept-Language user-specific values are going up to the server.
- web-platform-tests/fetch/api/basic/accept-header-expected.txt:
- web-platform-tests/fetch/api/basic/accept-header-worker-expected.txt:
- web-platform-tests/fetch/api/basic/accept-header.js:
(promise_test):
Source/WebCore:
Covered by existing and updated tests.
To start implementing step 1 to 7 of fetch algorithm, this patch updates Accept header handling.
Default values are set according the spec based on resource type.
Some resource types are not defined in the spec and we keep using existing values.
We check if Accept header is already present in the request. If that is the case, no change is done to that header.
If the Accept header is not set, the default value '*/*' is used.
An Accept header is therefore always set at CachedResourceLoader level.
- loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet): Removing accept initialization.
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load): Removing accept header setting.
- loader/cache/CachedResource.h:
(WebCore::CachedResource::accept): Deleted.
(WebCore::CachedResource::setAccept): Deleted.
- loader/cache/CachedResourceLoader.cpp:
(WebCore::acceptHeaderValueFromType): helper routine merging fetch spec and existing WebKit accept values.
(WebCore::CachedResourceLoader::prepareFetch): Should implement step 1 to 7 of https://fetch.spec.whatwg.org/#fetching.
(WebCore::CachedResourceLoader::requestResource): Making use of prepareFetch.
- loader/cache/CachedResourceLoader.h:
- loader/cache/CachedSVGDocument.cpp:
(WebCore::CachedSVGDocument::CachedSVGDocument): Removing accept initialization.
- loader/cache/CachedScript.cpp:
(WebCore::CachedScript::CachedScript): Removing accept initialization.
- loader/cache/CachedXSLStyleSheet.cpp:
(WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet): Removing accept initialization.
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::hasHTTPHeader): Introduced to check for header presence.
- platform/network/ResourceRequestBase.h:
LayoutTests:
- http/tests/misc/resources/image-checks-for-accept.php: Updated according new image Accept header value.
- 2:48 AM Changeset in webkit [206205] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Fix build failure of ScrollbarThemeGtk with libc++
https://bugs.webkit.org/show_bug.cgi?id=162302
Patch by Jeremy Huddleston Sequoia <jeremyhu@apple.com> on 2016-09-21
Reviewed by Carlos Garcia Campos.
- platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::ScrollbarThemeGtk::paint): Add missing #include <cstdlib>
- 2:44 AM Changeset in webkit [206204] by
-
- 3 edits in trunk/Source/WebCore
[OpenWebRTC] Miscellaneous fixes
https://bugs.webkit.org/show_bug.cgi?id=162332
Reviewed by Alejandro G. Castro.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:
(WebCore::MediaPlayerPrivateGStreamerOwr::currentTime): Improved logging.
(WebCore::MediaPlayerPrivateGStreamerOwr::load): Ditto.
(WebCore::MediaPlayerPrivateGStreamerOwr::loadingFailed): Ditto.
(WebCore::MediaPlayerPrivateGStreamerOwr::createGSTAudioSinkBin):
Pre-roll the autoaudiosink, fetch the underlying platform audio
sink and pass it to the OpenWebRTC renderer.
(WebCore::MediaPlayerPrivateGStreamerOwr::maybeHandleChangeMutedState): Improved logging.
(WebCore::MediaPlayerPrivateGStreamerOwr::setSize): Don't configure invalid video renderer.
- platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:
(WebCore::RealtimeMediaSourceCenterOwr::createMediaStream): Fix copy-paste error.
- 2:28 AM WebKitGTK/Roadmap edited by
- (diff)
- 2:25 AM WebKitGTK/Roadmap edited by
- (diff)
- 1:43 AM Changeset in webkit [206203] by
-
- 14 edits in trunk/Source/WebCore
Refactor CachedResourceLoader::canRequest
https://bugs.webkit.org/show_bug.cgi?id=162144
Patch by Youenn Fablet <youenn@apple.com> on 2016-09-21
Reviewed by Darin Adler.
Covered by existing tests.
Simplifying CachedResourceLoader::canRequest by doing:
- CSP checks in another method
- Removing Same-Origin type-specific checks by setting FetchOptions::Mode appropriately in resource loader clients
- Moving script specific check in ScriptElement
Note that the last check may affect the loading behavior in the case scripts are enabled when starting the load
of a script, but gets disabled before receiving a redirection for the script load.
- dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::checkStyleSheet): Setting XSLT stylesheet fetch mode to SameOrigin.
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::requestScriptWithCache): Returning early if scripts are disabled.
- loader/CrossOriginPreflightChecker.cpp:
(WebCore::CrossOriginPreflightChecker::startPreflight): Bypassing CSP checks.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startLoadingMainResource): Bypassing CSP checks as CachedResourceLoader was not
checking them for MainResource.
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::loadRequest): Ditto.
- loader/LinkLoader.cpp:
(WebCore::LinkLoader::preloadIfNeeded): Using new CachedResourceRequest constructor to enable moving the ResourceRequest.
(WebCore::LinkLoader::loadLink): Skipping CSP checks for link prefetch/subresources as CachedResourceLoader was
not checking them for Link Prefetch and Subresource types.
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::allowedByContentSecurityPolicy): Helper routine to check for CSP.
(WebCore::CachedResourceLoader::canRequest): Making use of introduced helper routine.
Simplified same origin check as all requests should have their options set.
- loader/cache/CachedResourceLoader.h:
- loader/cache/CachedResourceRequest.cpp:
(WebCore::CachedResourceRequest::CachedResourceRequest): More efficient constructor.
- loader/cache/CachedResourceRequest.h:
- loader/cache/CachedSVGDocumentReference.cpp:
(WebCore::CachedSVGDocumentReference::load): Setting fetch mode to SameOrigin.
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::updateExternalDocument): Ditto.
- xml/XSLImportRule.cpp:
(WebCore::XSLImportRule::loadSheet): Ditto.
- 12:48 AM Changeset in webkit [206202] by
-
- 3 edits in trunk/Source/WebCore
Build fails with GSTREAMER_GL when both desktop GL and GLES2 are enabled in gst-plugins-bad
https://bugs.webkit.org/show_bug.cgi?id=159562
Patch by Miguel Gomez <magomez@igalia.com> on 2016-09-21
Reviewed by Philippe Normand.
Refactor video orientation code so including TextureMapperGL in MediaPlayerPrivateGStreamerBase.h
is not necessary.
Covered by existent tests.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::texMapFlagFromOrientation):
(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):
(WebCore::MediaPlayerPrivateGStreamerBase::paintToTextureMapper):
(WebCore::MediaPlayerPrivateGStreamerBase::setVideoSourceOrientation):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
- 12:14 AM Changeset in webkit [206201] by
-
- 4 edits193 adds in trunk/LayoutTests
Import html/syntax web platform tests
https://bugs.webkit.org/show_bug.cgi?id=162331
Reviewed by Youenn Fablet.
LayoutTests/imported/w3c:
Import html/syntax web platform tests to improve test coverage.
- web-platform-tests/html/syntax/*: Added.
LayoutTests:
- tests-options.json:
- 12:09 AM Changeset in webkit [206200] by
-
- 3 edits in trunk/Source/WebCore
[GTK] Fix build failure in clipboard support
https://bugs.webkit.org/show_bug.cgi?id=162261
Patch by Jeremy Huddleston Sequoia <jeremyhu@apple.com> on 2016-09-21
Reviewed by Carlos Garcia Campos.
- platform/PlatformPasteboard.h: Add missing #include <functional>
- platform/gtk/PasteboardHelper.h: Add missing #include <functional>
