Timeline

Oct 29, 2016:

11:44 PM Changeset in webkit [208121] by Darin Adler

• 2 edits in trunk/Tools

Fix failing ExtendedColor tests.

• TestWebKitAPI/Tests/WebCore/ExtendedColor.cpp:

Changed the tests in two ways: First, use EXPECT_EQ instead of EXPECT_TRUE
for the string equality comparisons. This required including WTFStringUtilities.h.
Second, change expected results to match what the code is currently generating,
so alpha channels are "0.25" rather than "0.25 / 1". I'll let Dean fix both these
tests and the code if these results are incorrect.

8:53 PM Changeset in webkit [208120] by hyatt@apple.com

• 2 edits in trunk/Source/WebCore

[CSS Parser] Add font-variant-* keyword property support
​https://bugs.webkit.org/show_bug.cgi?id=164195

Reviewed by Zalan Bujtas.

• css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):

8:48 PM Changeset in webkit [208119] by hyatt@apple.com

• 3 edits in trunk/Source/WebCore

[CSS Parser] Fix text-emphasis-position parsing
​https://bugs.webkit.org/show_bug.cgi?id=164197

Reviewed by Zalan Bujtas.

• css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeTextEmphasisPosition):
(WebCore::CSSPropertyParser::parseSingleValue):

7:56 PM Changeset in webkit [208118] by Darin Adler

• 62 edits in trunk/Source

Convert more of DOM from ExceptionCode to Exception
​https://bugs.webkit.org/show_bug.cgi?id=164173

Reviewed by Ryosuke Niwa.

Source/WebCore:

• Modules/mediastream/MediaDevices.cpp:

(WebCore::MediaDevices::getUserMedia): Use ExceptionOr.
(WebCore::MediaDevices::enumerateDevices): Ditto.

• Modules/mediastream/MediaDevices.h: Updated for above.
• Modules/mediastream/MediaDevices.idl: Use non-legacy exceptions.

• Modules/mediastream/MediaEndpointSessionDescription.cpp:

Added now-needed include of ExceptionCode.h.

• Modules/mediastream/RTCConfiguration.cpp:

(WebCore::parseIceServer): Use ExceptionOr.
(WebCore::RTCConfiguration::create): Ditto.
(WebCore::RTCConfiguration::initialize): Ditto.

• Modules/mediastream/RTCConfiguration.h: Updated for above.
• Modules/mediastream/RTCConfiguration.idl: Use non-legacy exceptions.

• Modules/mediastream/RTCDTMFSender.cpp:

(WebCore::RTCDTMFSender::create): Use ExceptionOr.
(WebCore::RTCDTMFSender::insertDTMF): Ditto.

• Modules/mediastream/RTCDTMFSender.h: Updated for above.
• Modules/mediastream/RTCDTMFSender.idl: Use non-legacy exceptions.

• Modules/mediastream/RTCDataChannel.cpp:

(WebCore::RTCDataChannel::create): Use ExceptionOr.
(WebCore::RTCDataChannel::setBinaryType): Ditto.
(WebCore::RTCDataChannel::send): Ditto.
(WebCore::RTCDataChannel::didReceiveRawData): Ditto.

• Modules/mediastream/RTCDataChannel.h: Updated for above.

Also fhcanged resturn values to use const AtomicString& and
unsigned instead of unsigned long. Also made more private.
Also changed BinaryType into an enum class.

• Modules/mediastream/RTCDataChannel.idl: Use non-legacy exceptions.

• Modules/mediastream/RTCIceCandidate.cpp:

(WebCore::RTCIceCandidate::create): Use ExceptionOr.

• Modules/mediastream/RTCIceCandidate.h: Updated for above.
• Modules/mediastream/RTCIceCandidate.idl: Use non-legacy exception.

• Modules/mediastream/RTCOfferAnswerOptions.cpp:

(WebCore::RTCOfferOptions::create): Use ExceptionOr.
(WebCore::RTCAnswerOptions::create): Ditto.

• Modules/mediastream/RTCOfferAnswerOptions.h: Updated for above.

Also removed all virtual functions since nothing here is polymorphic
and initalized data members in the header.

• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::initializeWith): Use ExceptionOr.
(WebCore::RTCPeerConnection::addTrack): Ditto.
(WebCore::RTCPeerConnection::removeTrack): Ditto.
(WebCore::RTCPeerConnection::addTransceiver): Ditto.
(WebCore::RTCPeerConnection::completeAddTransceiver): Ditto.
(WebCore::RTCPeerConnection::queuedCreateOffer): Ditto.
(WebCore::RTCPeerConnection::queuedCreateAnswer): Ditto.
(WebCore::RTCPeerConnection::setConfiguration): Ditto.
(WebCore::RTCPeerConnection::createDataChannel): Ditto.

• Modules/mediastream/RTCPeerConnection.h: Updated for above.
• Modules/mediastream/RTCPeerConnection.idl: Use non-legacy exceptions.

• Modules/mediastream/RTCRtpSender.cpp:

(WebCore::RTCRtpSender::replaceTrack): Use ExceptionOr.

• Modules/mediastream/RTCRtpSender.h: Updated for above.
• Modules/mediastream/RTCRtpSender.idl: Use non-legacy exception.

• Modules/mediastream/RTCSessionDescription.cpp:

(WebCore::RTCSessionDescription::create): Use ExceptoinOr.

• Modules/mediastream/RTCSessionDescription.h: Updated for above.

(WebCore::RTCSessionDescription::~RTCSessionDescription):

• Modules/mediastream/RTCSessionDescription.idl: Use non-legacy exceptions.

• Modules/navigatorcontentutils/NavigatorContentUtils.cpp:

(WebCore::verifyCustomHandlerURL): Just return a boolean, no exception.
(WebCore::verifyProtocolHandlerScheme): Ditto.
(WebCore::NavigatorContentUtils::registerProtocolHandler): Use ExceptionOr.
(WebCore::NavigatorContentUtils::isProtocolHandlerRegistered): Ditto.
(WebCore::NavigatorContentUtils::unregisterProtocolHandler): Ditto.

• Modules/navigatorcontentutils/NavigatorContentUtils.h: Updated for above.
• Modules/navigatorcontentutils/NavigatorContentUtils.idl: Use non-legacy exceptions.

• bindings/js/JSMediaDevicesCustom.cpp:

(WebCore::JSMediaDevicesGetUserMediaPromiseFunction): Use propagateException.

• bindings/scripts/CodeGeneratorJS.pm:

(NeedsExplicitPropagateExceptionCall): Added. Helper function to decide whether
we need to call propagateException explicitly, if return value processing is not
going to propagate the exception for us.
(GenerateParametersCheck): Moved the code from GenerateReturnParameters inline
because it's almost as short as the function call. Use the newly created
NeedsExplicitPropagateExceptionCall function, which properly handles the case
where the return value is a promise.
(GenerateReturnParameters): Deleted.

• dom/CharacterData.cpp:

(WebCore::CharacterData::substringData): Use ExceptionOr.
(WebCore::CharacterData::insertData): Ditto.
(WebCore::CharacterData::deleteData): Ditto.
(WebCore::CharacterData::replaceData): Ditto.

• dom/CharacterData.h: Updated for above.
• dom/CharacterData.idl: Use non-legacy exceptions.

• dom/DataTransferItemList.h: Tried to use ExceptionOr, but this seems

like dead code that doesn't compile.

• dom/DataTransferItemList.idl: Use non-legacy exceptions.

• dom/MessagePort.idl: Use non-legacy exceptions, except this has

already been converted and was a custom binding.

• dom/MutationObserver.cpp:

(WebCore::MutationObserver::observe): Use ExceptionOr.

• dom/MutationObserver.h: Updated for above.
• dom/MutationObserver.idl: Use non-legacy exception.

• dom/Range.cpp:

(WebCore::deleteCharacterData): Updated use of calls that now use
ExceptionOr.
(WebCore::Range::processContentsBetweenOffsets): Ditto.
(WebCore::Range::insertNode): Ditto.

• dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::setInnerHTML): Use ExceptionOr.

• dom/ShadowRoot.h: Updated for above.
• dom/ShadowRoot.idl: Use non-legacy exception.

• dom/Text.cpp:

(WebCore::Text::splitText): Use ExceptionOr.
(WebCore::Text::replaceWholeText): Removed unused ExceptionCode&.

• dom/Text.h: Updated for above.
• dom/Text.idl: Use non-legacy exception.

• editing/ApplyBlockElementCommand.cpp:

(WebCore::isNewLineAtPosition): Rewrote to use data rather than
substringData; more efficient.

• editing/DeleteFromTextNodeCommand.cpp:

(WebCore::DeleteFromTextNodeCommand::doApply): Updated to work with
functions that return ExceptionOr.
(WebCore::DeleteFromTextNodeCommand::doUnapply): Removed IGNORE_EXCEPTION.

• editing/InsertIntoTextNodeCommand.cpp:

(WebCore::InsertIntoTextNodeCommand::InsertIntoTextNodeCommand):
Use WTFMove to avoid a little bit of reference count churn.
(WebCore::InsertIntoTextNodeCommand::doApply): Removed IGNORE_EXCEPTION.
(WebCore::InsertIntoTextNodeCommand::doReapply): Removed ExceptionCode.
(WebCore::InsertIntoTextNodeCommand::doUnapply): Removed IGNORE_EXCEPTION.

• editing/SplitTextNodeCommand.cpp:

(WebCore::SplitTextNodeCommand::doApply): Updated to work with functions
that return ExceptionCode.
(WebCore::SplitTextNodeCommand::doUnapply): Removed ASSERT_NO_EXCEPTION.
(WebCore::SplitTextNodeCommand::insertText1AndTrimText2): Updated to work
with functions that return ExceptionCode.

• html/HTMLTextFormControlElement.cpp:

Added now-needed include of ExceptionCode.h.

• inspector/DOMEditor.cpp: Removed ExceptionCode out argument from calls

to replaceWholeText, which never throws an exception.

Source/WebKit/mac:

• DOM/DOMCharacterData.mm:

(-[DOMCharacterData substringData:length:]): Updated since this
now uses ExceptionOr.
(-[DOMCharacterData insertData:data:]): Ditto.
(-[DOMCharacterData deleteData:length:]): Ditto.
(-[DOMCharacterData replaceData:length:data:]): Ditto.

• DOM/DOMText.mm:

(-[DOMText splitText:]): Ditto.
(-[DOMText replaceWholeText:]): Removed unneeded exception code
handling from function that does not throw an exception.

Source/WebKit2:

• WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMCharacterData.cpp:

(webkit_dom_character_data_substring_data): Updated since this
now uses ExceptionOr.
(webkit_dom_character_data_insert_data): Ditto.
(webkit_dom_character_data_delete_data): Ditto.
(webkit_dom_character_data_replace_data): Ditto.

• WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDeprecated.cpp:

(webkit_dom_text_replace_whole_text): Ditto.

• WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMText.cpp:

(webkit_dom_text_split_text): Ditto.

6:38 PM Changeset in webkit [208117] by sbarati@apple.com

• 29 edits
  4 adds in trunk

We should have a way of profiling when a get_by_id is pure and to emit a PureGetById in the DFG/FTL
​https://bugs.webkit.org/show_bug.cgi?id=163305

Reviewed by Keith Miller.

JSTests:

• microbenchmarks/pure-get-by-id-cse-2.js: Added.

(foo):

• microbenchmarks/pure-get-by-id-cse.js: Added.

(foo):

• stress/pure-get-by-id-cse-correctness.js: Added.

(assert):
(foo):

• stress/pure-get-by-id-on-non-object.js: Added.

(assert):
(foo):

Source/JavaScriptCore:

This creates a new GetById node in the DFG called PureGetById. We emit a
PureGetById when we profile that a get_by_id in the baseline never does
side effects. PureGetById speculates on the fact that it won't do side
effects. If it realizes that it must perform side effects, it will perform
the side effect, but also invalidate the CodeBlock that compiled it,
which will cause us to exit once we return back to the compiled code.
This allows us to have stricter clobberize rules for PureGetById which
model how getOwnPropertySlot(VMInquiry) behaves. This means that PureGetByIds
can be CSEd with each other, and that other things are more likely to
be CSEd around a PureGetById. To profile if a get_by_id does side
effects, I've added an extra bit into StructureStubInfo that we write
to when performing a get_by_id slow path call. If we notice that we
never do effects, inside the ByteCodeParser, we will emit a PureGetById
instead of a GetById.

To justify the performance benefit of this patch, I ran the suite of
benchmarks with useAccessInlining=false. This meant that we don't compile
any (Multi)GetByOffset/(Multi)PutByOffset. This was just to try to see if
this patch is worth anything at all in a world where we emit many
PureGetByIds. Running the benchmarks under this mode showed a 3.5% octane
improvement and a 15% kraken improvement. However, when running benchmarks
with useAccessInlining=true (the default JSC state), this patch is neutral.
I think the main reason for this is that the DFG is good at knowing when to
emit (Multi)GetByOffset, and most benchmarks that would benefit from
PureGetById are already emitting (Multi)GetByOffset. However, PureGetById can be
profitable when we encounter code that is too polymorphic for (Multi)GetByOffset.
It's reasonable to expect that JS code in the wild will fall into this use
case even though it might not be represented in some of the major JS benchmarks.
I wrote some microbenchmarks to demonstrate the benefits of PureGetById CSE,
and they were 30% (eliminating a few PureGetById from an add expression)
to 10x faster (eliminating a PureGetById in a loop).

• bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::StructureStubInfo):
(JSC::StructureStubInfo::reset):

• bytecode/StructureStubInfo.h:
• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGArrayMode.cpp:

(JSC::DFG::canBecomeGetArrayLength):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGNode.h:

(JSC::DFG::Node::convertToGetByOffset):
(JSC::DFG::Node::convertToMultiGetByOffset):
(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::hasHeapPrediction):

• dfg/DFGNodeType.h:
• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileTryGetById):
(JSC::DFG::SpeculativeJIT::compilePureGetById):

• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::compile):

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileGetById):
(JSC::FTL::DFG::LowerDFGToB3::getById):

• jit/JITOperations.cpp:

(JSC::pureGetByIdCommon):

• jit/JITOperations.h:
• jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_try_get_by_id):

• jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_try_get_by_id):

• jit/Repatch.cpp:

(JSC::appropriateOptimizingGetByIdFunction):
(JSC::appropriateGenericGetByIdFunction):
(JSC::tryCacheGetByID):

• jit/Repatch.h:
• profiler/ProfilerJettisonReason.cpp:

(WTF::printInternal):

• profiler/ProfilerJettisonReason.h:

3:34 PM Changeset in webkit [208116] by dino@apple.com

• 11 edits
  5 adds in trunk

Parse color() function
​https://bugs.webkit.org/show_bug.cgi?id=164146
<rdar://problems/29007218>

Reviewed by Darin Adler.

Source/WebCore:

Support the new CSS color() function:
​https://drafts.csswg.org/css-color/#color-function

There are separate code paths for the old and new CSS parser.

Tests: css3/color/color-function-computed-style.html

css3/color/color-function-parsing.html

• css/CSSComputedStyleDeclaration.cpp: Use Color directly, not via rgb().

(WebCore::ComputedStyleExtractor::currentColorOrValidColor):
(WebCore::ComputedStyleExtractor::valueForShadow):
(WebCore::ComputedStyleExtractor::propertyValue):

• css/CSSValueKeywords.in: Note that there is a color function, but the

keyword is already defined. Also add keywords for the color spaces.

• css/SVGCSSValueKeywords.in: sRGB is used outside of SVG now.

• css/parser/CSSParser.cpp: Old CSS parser code to handle color().

(WebCore::isPercent): Helper to tell if a ValueWithCalculation is a percentage or not.
(WebCore::CSSParser::parseColorInt): Renamed.
(WebCore::CSSParser::parseColorDouble): Helper to get a Number/Percentage into a double
(WebCore::CSSParser::parseRGBParameters):
(WebCore::CSSParser::parseColorFunctionParameters):
(WebCore::CSSParser::parseHSLParameters):
(WebCore::CSSParser::parseColorFromValue):
(WebCore::CSSParser::colorIntFromValue): Deleted.

• css/parser/CSSParser.h:

• css/parser/CSSPropertyParserHelpers.cpp: New CSS parser code to handle color().

(WebCore::CSSPropertyParserHelpers::parseColorFunctionParameters):
(WebCore::CSSPropertyParserHelpers::parseColorFunction):

• platform/graphics/Color.h:

(WebCore::Color::isValid): An extended color is valid.
(WebCore::Color::rgb): Move the code to a standalone inline
so that I could add a longer comment.

• platform/graphics/ExtendedColor.cpp:

(WebCore::ExtendedColor::cssText): Alpha output is only needed if != 1.

• platform/graphics/cg/ColorCG.cpp: Handle ExtendedColor -> CGColor.

(WebCore::leakCGColor):
(WebCore::cachedCGColor):

LayoutTests:

Test that exercises the new color() function in CSS. It checks
all valid and invalid input, with the exception of fallback content.

• css3/color/color-function-computed-style-expected.txt: Added.
• css3/color/color-function-computed-style.html: Added.
• css3/color/color-function-parsing-expected.txt: Added.
• css3/color/color-function-parsing.html: Added.

2:42 PM Changeset in webkit [208115] by hyatt@apple.com

• 2 edits in trunk/Source/WebCore

[CSS Parser] Disable -webkit-text-size-adjust when the context says to.
​https://bugs.webkit.org/show_bug.cgi?id=164191

Reviewed by Dean Jackson.

• css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::parseSingleValue):

2:25 PM Changeset in webkit [208114] by hyatt@apple.com

• 2 edits in trunk/Source/WebCore

[CSS Parser] Match old parser's image-rendering values
​https://bugs.webkit.org/show_bug.cgi?id=164190

Reviewed by Dean Jackson.

• css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):

2:18 PM Changeset in webkit [208113] by hyatt@apple.com

• 2 edits in trunk/Source/WebCore

[CSS Parser] Support -webkit-text value for background-clip and -webkit-background-clip
​https://bugs.webkit.org/show_bug.cgi?id=164189

Reviewed by Dean Jackson.

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeBackgroundBox):
(WebCore::consumePrefixedBackgroundBox):

2:12 PM Changeset in webkit [208112] by commit-queue@webkit.org

• 112 edits in trunk/Source/WebCore

Remove some unnecessary includes
​https://bugs.webkit.org/show_bug.cgi?id=164174

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-10-29
Reviewed by Darin Adler.

12:14 PM Changeset in webkit [208111] by hyatt@apple.com

• 2 edits in trunk/Source/WebCore

[CSS Parser] Support -webkit-aspect-ratio
​https://bugs.webkit.org/show_bug.cgi?id=164187

Reviewed by Simon Fraser.

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeWebkitAspectRatio):
(WebCore::CSSPropertyParser::parseSingleValue):

11:59 AM Changeset in webkit [208110] by hyatt@apple.com

• 2 edits in trunk/Source/WebCore

[CSS Parser] Support the caps lock indicator appearance
​https://bugs.webkit.org/show_bug.cgi?id=164186

Reviewed by Simon Fraser.

• css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):

11:54 AM Changeset in webkit [208109] by hyatt@apple.com

• 2 edits in trunk/Source/WebCore

[CSS Parser] Support the alt property
​https://bugs.webkit.org/show_bug.cgi?id=164184

Reviewed by Simon Fraser.

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeAlt):
(WebCore::CSSPropertyParser::parseSingleValue):

11:37 AM Changeset in webkit [208108] by hyatt@apple.com

• 2 edits in trunk/Source/WebCore

[CSS Parser] Add support for -webkit-hyphenate-limit-* properties
​https://bugs.webkit.org/show_bug.cgi?id=164183

Reviewed by Simon Fraser.

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeHyphenateLimit):
(WebCore::CSSPropertyParser::parseSingleValue):

10:46 AM Changeset in webkit [208107] by hyatt@apple.com

• 5 edits in trunk/Source/WebCore

[CSS Parser] Fix transform-origin and perspective-origin to parse as shorthands
​https://bugs.webkit.org/show_bug.cgi?id=164178

Reviewed by Zalan Bujtas.

• css/CSSPropertyNames.in:

Patch the transform-origin-x/y and perspective-origin-x/y properties
to use new converters that can handle keywords.

• css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertPositionComponentX):
(WebCore::StyleBuilderConverter::convertPositionComponentY):
Add the new converters. They just call convertPositionComponent method
that we already use for object-position and background-position.

• css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::consumeTransformOrigin):
(WebCore::CSSPropertyParser::consumePerspectiveOrigin):
Changed to treat the properties as shorthands and add the longhand
properties once parsed.

(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::CSSPropertyParser::parseShorthand):

• css/parser/CSSPropertyParser.h:

Move the parsing into the shorthand method, since we're still treating
these properties as shorthands.

9:32 AM Changeset in webkit [208106] by Wenson Hsieh

• 2 edits in trunk/Tools

UIScriptControllerIOS.mm should not be soft-linking UIKit
​https://bugs.webkit.org/show_bug.cgi?id=164171

Reviewed by Darin Adler.

Follow-up to r208090. Instead of soft-linking, we can simply grab UIKeyboardPredictionView by name instead.

• WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):

9:21 AM Changeset in webkit [208105] by commit-queue@webkit.org

• 38 edits
  3 deletes in trunk/LayoutTests

Remove testharness.js/testharnessreport.js unnecessary copies
​https://bugs.webkit.org/show_bug.cgi?id=164112

Patch by Youenn Fablet <​youenn@apple.com> on 2016-10-29
Reviewed by Darin Adler.

Removing http/tests/w3c directory.
Contained tests are skipped in Mac, EFL and mark as failing in GTK.
These tests have not been modified since more than 3 years and are probably out-of-date compared to W3C wpt.

Updated other http/tests tests using w3c/tests/resources files to use directly /resources/ URLs.
These /resources/ URLs are using an alias to remove the need to have redundant copies.

Removed imported/blink/http/tests/resources testharness and testharnessreport.js since they are not used.
A few test files in imported/blink/http/tests use /resources/... URLs but they will not point to any of the removed files since the tests are run as file based.

• http/tests/media/media-source/mediasource-play-then-seek-back-with-remote-control.html:
• http/tests/media/resources/media-source/generate-config-change-tests.py:
• http/tests/preload/single_download_preload_runner.html:
• http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/form-upgrade.html:
• http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/iframe-upgrade.https.html:
• http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/proper-uir-on-navigation.html:
• http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/resources/insecure-site.html:
• http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/resources/nested-nested-frame.html:
• http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/resources/nested-window.html:
• http/tests/security/cross-origin-css-1.html:
• http/tests/security/cross-origin-css-2.html:
• http/tests/security/cross-origin-css-3.html:
• http/tests/security/cross-origin-css-4.html:
• http/tests/security/cross-origin-css-5.html:
• http/tests/security/cross-origin-css-6.html:
• http/tests/security/cross-origin-css-7.html:
• http/tests/security/cross-origin-css-8.html:
• http/tests/security/cross-origin-css-9.html:
• http/tests/security/cross-origin-css-in-quirks-1.html:
• http/tests/security/cross-origin-css-in-quirks-2.html:
• http/tests/security/cross-origin-css-in-quirks-3.html:
• http/tests/security/cross-origin-css-in-quirks-4.html:
• http/tests/security/cross-origin-css-in-quirks-5.html:
• http/tests/security/cross-origin-css-in-quirks-6.html:
• http/tests/security/cross-origin-css-in-quirks-7.html:
• http/tests/security/cross-origin-css-in-quirks-8.html:
• http/tests/security/mixedContent/insecure-script-in-data-iframe-in-main-frame-blocked.html:
• http/tests/security/resources/post-origin-to-parent.html:
• http/tests/security/same-origin-css-1.html:
• http/tests/security/same-origin-css-2.html:
• http/tests/security/same-origin-css-3.html:
• http/tests/security/same-origin-css-4.html:
• http/tests/security/same-origin-css-5.html:
• http/tests/security/same-origin-css-6.html:
• http/tests/security/same-origin-css-7.html:
• http/tests/security/same-origin-css-8.html:
• http/tests/security/same-origin-css-in-quirks.html:
• http/tests/security/set-domain-remove-subdomain-for-ip-address.html:
• http/tests/w3c/README: Removed.
• http/tests/w3c/resources/WebIDLParser.js: Removed.
• http/tests/w3c/resources/canvas-tests.css: Removed.
• http/tests/w3c/resources/canvas-tests.js: Removed.
• http/tests/w3c/resources/idlharness.js: Removed.
• http/tests/w3c/resources/testharness.css: Removed.
• http/tests/w3c/resources/testharness.js: Removed.
• http/tests/w3c/resources/testharnessreport.js: Removed.
• http/tests/w3c/webperf/approved/HighResolutionTime/basic-expected.txt: Removed.
• http/tests/w3c/webperf/approved/HighResolutionTime/basic.html: Removed.
• http/tests/w3c/webperf/approved/HighResolutionTime/monotonic-clock-expected.txt: Removed.
• http/tests/w3c/webperf/approved/HighResolutionTime/monotonic-clock.html: Removed.
• http/tests/w3c/webperf/approved/HighResolutionTime/resources/now_frame.html: Removed.
• http/tests/w3c/webperf/approved/HighResolutionTime/test_cross_frame_start-expected.txt: Removed.
• http/tests/w3c/webperf/approved/HighResolutionTime/test_cross_frame_start.html: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_document_open-expected.txt: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_document_open.html: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_document_readiness_exist-expected.txt: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_document_readiness_exist.html: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_navigate_within_document-expected.txt: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_navigate_within_document.html: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_attributes_exist-expected.txt: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_attributes_exist.html: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_redirectCount_none-expected.txt: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_redirectCount_none.html: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_type_backforward-expected.txt: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_type_backforward.html: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_type_enums-expected.txt: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_type_enums.html: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_type_reload-expected.txt: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_navigation_type_reload.html: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_no_previous_document-expected.txt: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_no_previous_document.html: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_performance_attributes_exist-expected.txt: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_performance_attributes_exist.html: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_performance_attributes_exist_in_object-expected.txt: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_performance_attributes_exist_in_object.html: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_readwrite-expected.txt: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_readwrite.html: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_attributes_exist-expected.txt: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_attributes_exist.html: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_attributes_order-expected.txt: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_attributes_order.html: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_client_redirect-expected.txt: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_client_redirect.html: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_reload-expected.txt: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_reload.html: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_server_redirect-expected.txt: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_server_redirect.html: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect-expected.txt: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect.html: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_unique_performance_objects-expected.txt: Removed.
• http/tests/w3c/webperf/approved/navigation-timing/html/test_unique_performance_objects.html: Removed.
• http/tests/w3c/webperf/resources/Ahem.ttf: Removed.
• http/tests/w3c/webperf/resources/all_resource_types.htm: Removed.
• http/tests/w3c/webperf/resources/blank_image.png: Removed.
• http/tests/w3c/webperf/resources/blank_page_green.htm: Removed.
• http/tests/w3c/webperf/resources/blank_page_green_with_allow_timing.php: Removed.
• http/tests/w3c/webperf/resources/blank_page_green_with_onunload.htm: Removed.
• http/tests/w3c/webperf/resources/blank_page_meta_redirect.htm: Removed.
• http/tests/w3c/webperf/resources/blank_page_unload.htm: Removed.
• http/tests/w3c/webperf/resources/blank_page_yellow.htm: Removed.
• http/tests/w3c/webperf/resources/blank_page_yellow_with_onunload.htm: Removed.
• http/tests/w3c/webperf/resources/empty_script.js: Removed.
• http/tests/w3c/webperf/resources/generate_resource.php: Removed.
• http/tests/w3c/webperf/resources/gray_bg.css: Removed.
• http/tests/w3c/webperf/resources/green_frame.htm: Removed.
• http/tests/w3c/webperf/resources/inject_resource_test.html: Removed.
• http/tests/w3c/webperf/resources/nested.css: Removed.
• http/tests/w3c/webperf/resources/pagevistestharness.js: Removed.
• http/tests/w3c/webperf/resources/redirect.php: Removed.
• http/tests/w3c/webperf/resources/webperftestharness.js: Removed.
• http/tests/w3c/webperf/resources/webperftestharnessextension.js: Removed.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_attribute_order-expected.txt: Removed.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_attribute_order.html: Removed.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_cached-expected.txt: Removed.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_cached.html: Removed.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_connection_reuse-expected.txt: Removed.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_connection_reuse.html: Removed.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_dynamic_insertion-expected.txt: Removed.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_dynamic_insertion.html: Removed.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_frame_initiator_type-expected.txt: Removed.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_frame_initiator_type.html: Removed.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_iframe_self_navigation-expected.txt: Removed.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_iframe_self_navigation.html: Removed.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_ignore_data_url-expected.txt: Removed.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_ignore_data_url.html: Removed.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_ignore_failures-expected.txt: Removed.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_ignore_failures.html: Removed.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_initiator_types-expected.txt: Removed.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_initiator_types.html: Removed.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_redirects-expected.txt: Removed.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_redirects.html: Removed.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_reparenting-expected.txt: Removed.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_reparenting.html: Removed.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_script_types-expected.txt: Removed.
• http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_script_types.html: Removed.
• http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_buffer_full_when_populate_entries-expected.txt: Removed.
• http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_buffer_full_when_populate_entries.html: Removed.
• http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_buffer_full_when_shrink_buffer_size-expected.txt: Removed.
• http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_buffer_full_when_shrink_buffer_size.html: Removed.
• http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_buffer_size_restriction-expected.txt: Removed.
• http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_buffer_size_restriction.html: Removed.
• http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_clear_resource_timing_functionality-expected.txt: Removed.
• http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_clear_resource_timing_functionality.html: Removed.
• http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_cross_origin_resource_request-expected.txt: Removed.
• http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_cross_origin_resource_request.html: Removed.
• http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_on_shrink_buffer_size-expected.txt: Removed.
• http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_on_shrink_buffer_size.html: Removed.
• http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_store_and_clear_during_callback-expected.txt: Removed.
• http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_store_and_clear_during_callback.html: Removed.
• http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_timing_allow_cross_origin_resource_request-expected.txt: Removed.
• http/tests/w3c/webperf/submission/Intel/resource-timing/test_resource_timing_timing_allow_cross_origin_resource_request.html: Removed.
• http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_clearMarks-expected.txt: Removed.
• http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_clearMarks.html: Removed.
• http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_clearMeasures-expected.txt: Removed.
• http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_clearMeasures.html: Removed.
• http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_entry_type-expected.txt: Removed.
• http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_entry_type.html: Removed.
• http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_mark-expected.txt: Removed.
• http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_mark.html: Removed.
• http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_mark_exception-expected.txt: Removed.
• http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_mark_exception.html: Removed.
• http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure-expected.txt: Removed.
• http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure.html: Removed.
• http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure_associate_with_navigation_timing-expected.txt: Removed.
• http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure_associate_with_navigation_timing.html: Removed.
• http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure_exception-expected.txt: Removed.
• http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_measure_exception.html: Removed.
• http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_method_exist-expected.txt: Removed.
• http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_method_exist.html: Removed.
• http/tests/xmlhttprequest/readystatechange-and-abort.html:
• http/tests/xmlhttprequest/response-json-and-readystate.html:
• http/tests/xmlhttprequest/xmlhttprequest-open-method-allowed.html:
• http/tests/xmlhttprequest/xmlhttprequest-open-method-case-insensitive.html:
• imported/blink/http/tests/resources/testharness.js: Removed.
• imported/blink/http/tests/resources/testharnessreport.js: Removed.
• platform/gtk/TestExpectations:
• platform/ios-simulator/TestExpectations:
• platform/mac/TestExpectations:
• platform/win/TestExpectations:

9:03 AM Changeset in webkit [208104] by commit-queue@webkit.org

• 2 edits in trunk

[CMake][Win] Visual Studio invokes make_settings.pl twice
​https://bugs.webkit.org/show_bug.cgi?id=163774

Patch by Fujii Hironori <Fujii Hironori> on 2016-10-29
Reviewed by Michael Catanzaro.

build-webkit recompiles some files just after finishing
build-webkit in case of using CMake VisualStudio generator because
both WebCoreDerivedSources.vcxproj and WebCoreTestSupport.vcxproj
triggers make_settings.pl.

make_settings.pl generates four files
InternalSettingsGenerated.{h,cpp,idl} and SettingsMacros.h.
WebCoreDerivedSources depends on SettingsMacros.h, and
WebCoreTestSupport depends on InternalSettingsGenerated.cpp.

This problem is described in CMake documentation:
<​https://cmake.org/cmake/help/v3.0/command/add_custom_command.html>

Do not list the output in more than one independent target that may
build in parallel or the two instances of the rule may conflict

To solve this problem, only SettingsMacros.h is specified as
OUTPUT of add_custom_command, and other generated files are marked
as BYPRODUCTS. As the result, only WebCoreDerivedSources target
triggers make_settings.pl. And other targets already have a
dependency to WebCoreDerivedSources target.

To support earlier versions than CMake 3.2, it uses GENERATED
source file property instead of BYPRODUCTS option.

• Source/cmake/WebKitMacros.cmake(GENERATE_SETTINGS_MACROS):

Removed extra output files from OUTPUT of add_custom_command and
added BYPRODUCTS option.

8:22 AM Changeset in webkit [208103] by hyatt@apple.com

• 2 edits in trunk/Source/WebCore

[CSS Parser] Support -webkit-background-composite
​https://bugs.webkit.org/show_bug.cgi?id=164179

Reviewed by Zalan Bujtas.

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeBackgroundComponent):
(WebCore::CSSPropertyParser::parseSingleValue):

6:46 AM Changeset in webkit [208102] by commit-queue@webkit.org

• 6 edits
  2 adds in trunk

REGRESSION (r207754): LayoutTest http/tests/security/svg-image-with-css-cross-domain.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=163922

Patch by Youenn Fablet <​youenn@apple.com> on 2016-10-29
Reviewed by Alex Christensen.

Source/WebCore:

Test: http/tests/security/cached-svg-image-with-css-cross-domain.html

Raw data was not copied in cloned CachedCSSStyleSheet while it is used by some of its clients.
Updated CachedCSSStyleSheet and CachedImage cloning to copy its raw data.

• loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::setBodyDataFrom):

• loader/cache/CachedImage.cpp:

(WebCore::CachedImage::setBodyDataFrom):

• loader/cache/CachedResource.h:

(WebCore::CachedResource::mayTryReplaceEncodedData):

LayoutTests:

• http/tests/security/cached-svg-image-with-css-cross-domain-expected.html: Added.
• http/tests/security/cached-svg-image-with-css-cross-domain.html: Added.
• platform/mac/TestExpectations:

6:44 AM Changeset in webkit [208101] by commit-queue@webkit.org

• 4 edits
  4 adds in trunk

REGRESSION (Safari 10 / r189445): WKWebView and WebView no longer allow async XMLHttpRequest timeout to exceed 60 seconds
​https://bugs.webkit.org/show_bug.cgi?id=163814
<rdar://problem/28917420>

Patch by Youenn Fablet <​youenn@apple.com> on 2016-10-29
Reviewed by Darin Adler.

Source/WebCore:

Tests: http/tests/xmlhttprequest/resetting-timeout-to-zero.html

http/tests/xmlhttprequest/timeout-greater-than-default-network-timeout.html

• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::setTimeout): If the XHR timeout is active, resetting the timeout to zero should lead to using the default network timeout.
Since it is difficult to update the timeout once the request is sent, we mimic the default network timeout with a 60 seconds XHR timeout.
(WebCore::XMLHttpRequest::createRequest): Setting network timeout to infinity if the XHR timeout is active.

LayoutTests:

• http/tests/xmlhttprequest/resetting-timeout-to-zero-expected.txt: Added.
• http/tests/xmlhttprequest/resetting-timeout-to-zero.html: Added.
• http/tests/xmlhttprequest/timeout-greater-than-default-network-timeout-expected.txt: Added.
• http/tests/xmlhttprequest/timeout-greater-than-default-network-timeout.html: Added.
• tests-options.json:

6:43 AM Changeset in webkit [208100] by commit-queue@webkit.org

• 8 edits in trunk/Source/WebCore

MediaEndpoint::generateDtlsInfo is not needed
​https://bugs.webkit.org/show_bug.cgi?id=164130

Patch by Youenn Fablet <​youenn@apple.com> on 2016-10-29
Reviewed by Eric Carlson.

No change of behavior.

Removing MediaEndpoint::generateDtlsInfo as it can be called directly from createMediaEndpointOwr.

• Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::MediaEndpointPeerConnection::MediaEndpointPeerConnection):

• platform/mediastream/MediaEndpoint.cpp:
• platform/mediastream/MediaEndpoint.h:
• platform/mediastream/openwebrtc/MediaEndpointOwr.cpp:

(WebCore::createMediaEndpointOwr):

• platform/mediastream/openwebrtc/MediaEndpointOwr.h:
• platform/mock/MockMediaEndpoint.cpp:

(WebCore::MockMediaEndpoint::MockMediaEndpoint):
(WebCore::MockMediaEndpoint::generateDtlsInfo): Deleted.

• platform/mock/MockMediaEndpoint.h:

Oct 28, 2016:

11:14 PM Changeset in webkit [208099] by Wenson Hsieh

• 2 edits in trunk/Source/WebCore

Unreviewed, add Input Events to the features list.

• features.json:

10:02 PM Changeset in webkit [208098] by Darin Adler

• 2 edits in trunk/Source/WebCore

Fix mismerge that broke a CEReactions test.

• html/HTMLOptionsCollection.idl: Add back CEReactions to the remove function.

8:16 PM Changeset in webkit [208097] by Joseph Pecoraro

• 7 edits
  1 add in trunk

Web Inspector: Breakpoints not working in scripts with unicode characters
​https://bugs.webkit.org/show_bug.cgi?id=164172
<rdar://problem/28895862>

Reviewed by Ryosuke Niwa.

Source/JavaScriptCore:

• parser/Parser.h:

(JSC::parse):
Ensure we pass the debuggerParseData struct to get populated in the
non 8bit string case!

LayoutTests:

• inspector/debugger/breakpoints/resolved-dump-all-pause-locations-expected.txt:
• inspector/debugger/breakpoints/resolved-dump-all-pause-locations.html:
• inspector/debugger/breakpoints/resolved-dump-each-line-expected.txt:
• inspector/debugger/breakpoints/resolved-dump-each-line.html:
• inspector/debugger/breakpoints/resources/dump-unicode.js: Added.

Ensure we can set breakpoints and resolve them in non-8bit source code.

7:32 PM Changeset in webkit [208096] by Darin Adler

• 188 edits in trunk

Move all classes in the HTML directory from ExceptionCode to Exception
​https://bugs.webkit.org/show_bug.cgi?id=163876

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

• web-platform-tests/url/url-setters-expected.txt: Updated for progressions that occurred

because setting the href attribute on a DOMURL object no longer modifies the URL as a side
effect in the cases where it throw an exception.

Source/WebCore:

• bindings/js/JSDOMBinding.cpp:

(WebCore::shouldAllowAccessToNode): Deleted.
(WebCore::BindingSecurity::shouldAllowAccessToFrame): Moved function into the
BindingSecurity namespace. Also changed arguments to references.
(WebCore::BindingSecurity::shouldAllowAccessToDOMWindow): Ditto.
(WebCore::BindingSecurity::shouldAllowAccessToNode): Changed argument type
from pointer to reference.

• bindings/js/JSDOMBinding.h: Removed top level shouldAllowAccessTo functions,

moving all of them into the BindingSecurity namespace. Changed BindingSecurity
from a class into a namespace. Added new checkSecurityForNode functions that
can be used directly to implement CheckSecurityForNode; they turn the node
into a null, which is no change in behavior from what bindings already did.

• bindings/js/JSDOMWindowCustom.cpp:

(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess): Changed argument
type for passed-in string to const String& instead of String&.
(WebCore::JSDOMWindow::getOwnPropertySlot): Updated for BindingSecurity changes.
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex): Ditto.
(WebCore::JSDOMWindow::put): Ditto.

• bindings/js/JSHTMLCanvasElementCustom.cpp:

(WebCore::attributesFor3DContext): Renamed from get3DContextAttributes and
changed to use a return value instead of an out argument.
(WebCore::JSHTMLCanvasElement::getContext): Updated for the above.
(WebCore::JSHTMLCanvasElement::toDataURL): Rewrote to handle ExceptionOr
and also to use Optional<double> instead of const double*.

• bindings/js/JSHTMLFrameElementCustom.cpp:

(WebCore::JSHTMLFrameElement::setLocation): Moved the logic from
allowSettingJavascriptURL in here and updated for BindingSecurity changes.

• bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::JSHTMLOptionsCollection::setLength): Use propagateException.
Also streamlined the code a bit.
(WebCore::JSHTMLOptionsCollection::indexSetter): Updated for new name and
argument types for selectElementIndexSetter.

• bindings/js/JSHTMLSelectElementCustom.cpp:

(WebCore::selectElementIndexSetter): Updated name and argument types and
to use propagateException.
(WebCore::JSHTMLSelectElement::indexSetter): Updated for above.

• bindings/js/JSHTMLSelectElementCustom.h: Ditto.

• bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::getOwnPropertySlotDelegate): Updated for changes to
BindingSecurity.
(WebCore::JSLocation::putDelegate): Ditto. Also rearranged logic a bit.

• bindings/js/ScriptController.cpp:

(WebCore::ScriptController::canAccessFromCurrentOrigin): Updated for
changes to BindingSecurity.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation): Removed old support for CheckSecurityForNode.
(NativeToJSValue): Added new support for CheckSecurityForNode, which uses
the new checkSecurityForNode function, and works properly with ExceptionOr.

• bindings/scripts/test/JS/JSTestObj.cpp: Updated for change below.

• dom/ChildNode.idl: Move the remove function to non-legacy exception.

Needed now because this needs to match the one in HTMLSelectElement.

• dom/Element.cpp:

(WebCore::Element::dispatchMouseForceWillBegin): Refactored a little bit.
(WebCore::Element::mergeWithNextTextNode): Support ExceptionOr for remove.
(WebCore::Element::setOuterHTML): Support ExceptionOr for
createFragmentForInnerOuterHTML.
(WebCore::Element::setInnerHTML): Ditto.
(WebCore::Element::insertAdjacentHTML): Ditto.

• dom/Node.cpp:

(WebCore::Node::remove): Use ExceptionOr.
(WebCore::Node::normalize): Remove use of IGNORE_EXCEPTION.

• dom/Node.h: Use ExceptionOr for remove.

• dom/Range.cpp:

(WebCore::Range::insertNode): Updated for change to remove.
(WebCore::Range::createContextualFragment): Updated for change
to WebCore::createContextualFragment.

• dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::setInnerHTML): Use ExceptionOr for
createFragmentForInnerOuterHTML and replaceChildrenWithFragment.

• editing/AppendNodeCommand.cpp:

(WebCore::AppendNodeCommand::doUnapply): Remove IGNORE_EXCEPTION.

• editing/InsertNodeBeforeCommand.cpp:

(WebCore::InsertNodeBeforeCommand::doUnapply): Ditto.

• editing/MergeIdenticalElementsCommand.cpp:

(WebCore::MergeIdenticalElementsCommand::doApply): Ditto.

• editing/RemoveNodeCommand.cpp:

(WebCore::RemoveNodeCommand::doApply): Ditto.

• editing/SplitElementCommand.cpp:

(WebCore::SplitElementCommand::doUnapply): Ditto.

• editing/SplitTextNodeCommand.cpp:

(WebCore::SplitTextNodeCommand::doUnapply): Ditto.

• editing/WrapContentsInDummySpanCommand.cpp:

(WebCore::WrapContentsInDummySpanCommand::doUnapply): Ditto.

• editing/Editor.cpp:

(WebCore::Editor::insertDictationPhrases): Deleted. Moved this
iOS-specific function to EditorIOS.mm.
(WebCore::Editor::setDictationPhrasesAsChildOfElement): Ditto.
(WebCore::Editor::confirmMarkedText): Ditto.
(WebCore::Editor::setTextAsChildOfElement): Ditto.
(WebCore::Editor::ensureLastEditCommandHasCurrentSelectionIfOpenForMoreTyping): Ditto.

• editing/ios/EditorIOS.mm:

(WebCore::Editor::fontForSelection): Remove ASSERT_NO_EXCEPTION.
(WebCore::Editor::fontAttributesForSelectionStart): Ditto.
(WebCore::Editor::insertDictationPhrases): Moved here from Editor.cpp.
(WebCore::Editor::setDictationPhrasesAsChildOfElement): Ditto. Also
updated code that used remove to not pass an ExceptionCode.
(WebCore::Editor::confirmMarkedText): Ditto.
(WebCore::Editor::setTextAsChildOfElement): Ditto.
(WebCore::Editor::ensureLastEditCommandHasCurrentSelectionIfOpenForMoreTyping): Ditto.

• editing/mac/EditorMac.mm:

(WebCore::Editor::fontForSelection): Remove ASSERT_NO_EXCEPTION.
(WebCore::Editor::fontAttributesForSelectionStart): Ditto.

• editing/markup.cpp:

(WebCore::createFragmentForInnerOuterHTML): Use ExceptionOr.
(WebCore::createContextualFragment): Ditto.
(WebCore::replaceChildrenWithFragment): Ditto.
(WebCore::replaceChildrenWithText): Ditto.

• editing/markup.h: Updated for above changes.

• html/BaseChooserOnlyDateAndTimeInputType.cpp:

(WebCore::BaseChooserOnlyDateAndTimeInputType::updateAppearance):
Removed ASSERT_NO_EXCEPTION.

• html/BaseDateAndTimeInputType.cpp:

(WebCore::BaseDateAndTimeInputType::setValueAsDate): Use ExceptionOr.
(WebCore::BaseDateAndTimeInputType::setValueAsDecimal): Ditto.

• html/BaseDateAndTimeInputType.h: Updated for above changes.

• html/DateTimeLocalInputType.cpp:

(WebCore::DateTimeLocalInputType::setValueAsDate): Use ExceptionOr.

• html/DateTimeLocalInputType.h: Updated for above changes.

• html/DOMTokenList.cpp:

(WebCore::DOMTokenList::validateToken): Use ExceptionOr.
(WebCore::DOMTokenList::validateTokens): Ditto.
(WebCore::DOMTokenList::addInternal): Ditto.
(WebCore::DOMTokenList::add): Ditto.
(WebCore::DOMTokenList::removeInternal): Ditto.
(WebCore::DOMTokenList::remove): Ditto.
(WebCore::DOMTokenList::toggle): Ditto.
(WebCore::DOMTokenList::replace): Ditto.
(WebCore::DOMTokenList::supports): Ditto.

• html/DOMTokenList.h: Updated for above changes.
• html/DOMTokenList.idl: Use non-legacy exceptions.

• html/DOMURL.cpp:

(WebCore::DOMURL::DOMURL): Just take the two URL objects and let
the create functions do all the processing.
(WebCore::DOMURL::create): Use ExceptionOr, and move the processing
of the URLs here out of the constructors.
(WebCore::DOMURL::setHref): Use ExceptionOr.

• html/DOMURL.h: Updated for above changes.
• html/DOMURL.idl: Use non-legacy exceptions.

• html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocumentParser::appendEntry): Remove
IGNORE_EXCEPTION and use releaseReturnValue().

• html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::toDataURL): Use ExceptionOr.

• html/HTMLCanvasElement.h: Updated for above changes.
• html/HTMLCanvasElement.idl: Use non-legacy exception.

• html/HTMLElement.cpp:

(WebCore::HTMLElement::textToFragment): Use ExceptionOr.
(WebCore::HTMLElement::setInnerText): Ditto.
(WebCore::HTMLElement::setOuterText): Ditto.
(WebCore::HTMLElement::setContentEditable): Ditto.
(WebCore::HTMLElement::translateAttributeMode): Deleted.
(WebCore::HTMLElement::translate): Moved the logic from the
translateAttributeMode function in here.

• html/HTMLElement.h: Updated for above changes.
• html/HTMLElement.idl: Use non-legacy exceptions.

• html/HTMLEmbedElement.idl: Use non-legacy exception.
• html/HTMLFrameElement.idl: Ditto.

• html/HTMLFrameOwnerElement.cpp:

(WebCore::HTMLFrameOwnerElement::getSVGDocument): Use ExceptionOr.

• html/HTMLFrameOwnerElement.h: Updated for above.

• html/HTMLIFrameElement.idl: Use non-legacy exception.

• html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::stepUp): Use ExceptionOr.
(WebCore::HTMLInputElement::stepDown): Ditto.
(WebCore::HTMLInputElement::setValue): Ditto.
(WebCore::HTMLInputElement::setValueAsDate): Ditto.
(WebCore::HTMLInputElement::setValueAsNumber): Ditto.
(WebCore::HTMLInputElement::setSize): Ditto.
(WebCore::HTMLInputElement::maxLengthAttributeChanged): Use the
new internalSetMaxLength function; old code relied on a setMaxLength
that was different from the one exposed to bindings.
(WebCore::HTMLInputElement::minLengthAttributeChanged): Ditto.
(WebCore::HTMLInputElement::setRangeText): Use ExceptionOr.

• html/HTMLInputElement.h: Updated for above changes. Also use

data member initialization for InputElementClickState instead of
a constructor.

• html/HTMLInputElement.idl: Use non-legacy exception.

• html/HTMLMarqueeElement.cpp:

(WebCore::HTMLMarqueeElement::setLoop): Use ExceptionOr.
(WebCore::HTMLMarqueeElement::renderMarquee): Tweaked.

• html/HTMLMarqueeElement.h: Updated for above changes.
• html/HTMLMarqueeElement.idl: Ditto.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::TrackGroup::TrackGroup):
Initialize most data members in class definition rather than
the constructor.
(WebCore::HTMLMediaElement::HTMLMediaElement): Ditto.
(WebCore::HTMLMediaElement::~HTMLMediaElement): Updated since
removeMediaElement now takes a reference.
(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Use
a modern for loop to streamline code.
(WebCore::HTMLMediaElement::textTrackModeChanged): Updated since
track now returns a reference.
(WebCore::HTMLMediaElement::setCurrentTimeForBindings): Renamed
to prevent ambiguity with the other version that has slightly
different semantics and overloading and changed to use ExceptionOr.
(WebCore::HTMLMediaElement::playInternal): Updated to use reference.
(WebCore::HTMLMediaElement::setVolume): Use ExceptionOr.
(WebCore::HTMLMediaElement::mediaPlayerDidAddAudioTrack): Take a
reference instead of a PassRefPtr.
(WebCore::HTMLMediaElement::mediaPlayerDidAddTextTrack): Ditto.
(WebCore::HTMLMediaElement::mediaPlayerDidAddVideoTrack): Ditto.
(WebCore::HTMLMediaElement::mediaPlayerDidRemoveAudioTrack): Ditto.
(WebCore::HTMLMediaElement::mediaPlayerDidRemoveTextTrack): Ditto.
(WebCore::HTMLMediaElement::mediaPlayerDidRemoveVideoTrack): Ditto.
(WebCore::HTMLMediaElement::addTextTrack): Use ExceptionOr.
(WebCore::HTMLMediaElement::didAddTextTrack): Use a reference.
(WebCore::HTMLMediaElement::didRemoveTextTrack): Ditto.
(WebCore::HTMLMediaElement::maxBufferedTime): Update to use different
interface to time ranges that does not need to deal with exceptions.
(WebCore::HTMLMediaElement::setController): Pass references.
(WebCore::HTMLMediaElement::outOfBandTrackSources): Use reference.

• html/HTMLMediaElement.h: Updated for above.
• html/HTMLMediaElement.idl: Use non-legacy exceptions.

• html/HTMLObjectElement.idl: Use non-legacy exception.

• html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::createForJSConstructor): Use ExceptionOr.

• html/HTMLOptionElement.h: Updated for above change.
• html/HTMLOptionElement.idl: Use non-legacy exception.

• html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::setLength): Use ExceptionOr.

• html/HTMLOptionsCollection.h: Updated for above change.
• html/HTMLOptionsCollection.idl: Use non-legacy exception.

• html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::setValue): Removed non-finite handling
because that is now handled by the bindings.
(WebCore::HTMLProgressElement::setMax): Ditto.

• html/HTMLProgressElement.h: Updated for above.
• html/HTMLProgressElement.idl: Changed attributes to be double instead

of unrestricted double, and this was able to remove exceptions.

• html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::removeByIndex): Drop IGNORE_EXCEPTION.
(WebCore::HTMLSelectElement::remove): Use ExceptionOr.
(WebCore::HTMLSelectElement::setOption): Ditto.
(WebCore::HTMLSelectElement::setLength): Ditto.

• html/HTMLSelectElement.h: Updated for above changes.
• html/HTMLSelectElement.idl: Use non-legacy exceptions.

• html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::setCaption): Use ExceptionOr.
(WebCore::HTMLTableElement::setTHead): Ditto.
(WebCore::HTMLTableElement::setTFoot): Ditto.
(WebCore::HTMLTableElement::createTHead): Streamline a bit.
(WebCore::HTMLTableElement::deleteTHead): Ditto.
(WebCore::HTMLTableElement::createTFoot): Ditto.
(WebCore::HTMLTableElement::deleteTFoot): Ditto.
(WebCore::HTMLTableElement::createTBody): Ditto.
(WebCore::HTMLTableElement::createCaption): Ditto.
(WebCore::HTMLTableElement::insertRow): Use ExceptionOr.
(WebCore::HTMLTableElement::deleteRow): Ditto.

• html/HTMLTableElement.h: Updated for above changes.
• html/HTMLTableElement.idl: Use non-legacy exceptions.

• html/HTMLTableRowElement.cpp:

(WebCore::findTable): Added.
(WebCore::HTMLTableRowElement::rowIndex): Streamline a bit using the
findTable function above.
(WebCore::findRows): Added.
(WebCore::HTMLTableRowElement::sectionRowIndex): Streamline a bit using
the findRows function above.
(WebCore::HTMLTableRowElement::insertCell): Use ExceptionOr.
(WebCore::HTMLTableRowElement::deleteCell): Ditto.
(WebCore::HTMLTableRowElement::setCells): Deleted.

• html/HTMLTableRowElement.h: Updated for the above. The setCells function

was dead code.

• html/HTMLTableRowElement.idl: Use non-legacy exceptions.

• html/HTMLTableSectionElement.cpp:

(WebCore::HTMLTableSectionElement::additionalPresentationAttributeStyle):
Tweaked a bit to use early return.
(WebCore::HTMLTableSectionElement::insertRow): Use ExceptionOr.
(WebCore::HTMLTableSectionElement::deleteRow): Ditto.
(WebCore::HTMLTableSectionElement::numRows): Use childrenOfType.
(WebCore::HTMLTableSectionElement::align): Deleted.
(WebCore::HTMLTableSectionElement::setAlign): Deleted.
(WebCore::HTMLTableSectionElement::ch): Deleted.
(WebCore::HTMLTableSectionElement::setCh): Deleted.
(WebCore::HTMLTableSectionElement::chOff): Deleted.
(WebCore::HTMLTableSectionElement::setChOff): Deleted.
(WebCore::HTMLTableSectionElement::vAlign): Deleted.
(WebCore::HTMLTableSectionElement::setVAlign): Deleted.

• html/HTMLTableSectionElement.h: Updated for the above.
• html/HTMLTableSectionElement.idl: Use non-legacy exception.

• html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::maxLengthAttributeChanged): Use the new
internalSetMaxLength function; old code relied on a setMaxLength
that was different from the one exposed to bindings.
(WebCore::HTMLTextAreaElement::minLengthAttributeChanged): Ditto.
(WebCore::HTMLTextAreaElement::updatePlaceholderText): Removed
ASSERT_NO_EXCEPTION.

• html/HTMLTextAreaElement.idl: Use non-legacy exceptions.

• html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::setRangeText): Use ExceptionOr.
(WebCore::HTMLTextFormControlElement::setInnerTextValue): Ditto.
(WebCore::HTMLTextFormControlElement::setMaxLength): Ditto.
(WebCore::HTMLTextFormControlElement::setMinLength): Ditto.

• html/HTMLTextFormControlElement.h: Updated for above changes.

Also renamed the setMin/MaxLength function overloads for internal use
to internSetMin/MaxLength and made them protected.

• html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::~HTMLTrackElement): Call clearElement on the
track to break the connection. Before this was done as a side effect of
clearClient, but that is called in other cases where we do not want to
clear the link back to the track element.
(WebCore::HTMLTrackElement::insertedInto): Removed code that uses the
track function for its side effect of creating a track; no longer needed.
Rewrote this so it's more symmetric with removedFrom.
(WebCore::HTMLTrackElement::removedFrom): Pass reference. Also reordered
and removed an unnecessary check for null parent.
(WebCore::HTMLTrackElement::parseAttribute): Use track.
(WebCore::HTMLTrackElement::kind): Ditto.
(WebCore::HTMLTrackElement::track): Renamed ensureTrack to this. Also
removed the redundant code to call setTrackElement; we no longer change
the track element on a track until the track element is destroyed.
(WebCore::HTMLTrackElement::scheduleLoad): Use track.
(WebCore::HTMLTrackElement::loadTimerFired): Ditto.
(WebCore::HTMLTrackElement::setReadyState): Ditto.
(WebCore::HTMLTrackElement::readyState): Ditto.
(WebCore::HTMLTrackElement::mediaElement): Rearranged to use early return.

• html/HTMLTrackElement.h: Updated for above changes.

• html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::webkitEnterFullscreen): Use ExceptionOr.

• html/HTMLVideoElement.h: Removed the functions used just for

capitalization reasons; that's now handled in the bindings.

• html/HTMLVideoElement.idl: Use non-legacy bindings and ImplementedAs.

• html/ImageData.cpp:

(WebCore::ImageData::create): Return ExceptionOr.

• html/ImageData.h: Updated for above changes.
• html/ImageData.idl: Use non-legacy exceptions.

• html/InputType.cpp:

(WebCore::InputType::setValueAsDate): Use ExceptionOr.
(WebCore::InputType::setValueAsDouble): Ditto.
(WebCore::InputType::setValueAsDecimal): Ditto.
(WebCore::InputType::applyStep): Ditto.
(WebCore::InputType::stepUp): Ditto.
(WebCore::InputType::stepUpFromRenderer): Removed IGNORE_EXCEPTION.

• html/InputType.h: Updated for the above.

• html/MediaController.cpp:

(MediaController::addMediaElement): Take a reference instead of a pointer.
(MediaController::removeMediaElement): Ditto.
(MediaController::containsMediaElement): Ditto.
(MediaController::setVolume): Use ExceptionOr.
(MediaController::bringElementUpToSpeed): Take a reference.

• html/MediaController.h: Updated for above changes. Also made lots of

function overrides private.

• html/MediaController.idl: Use non-legacy exception.

• html/MediaControllerInterface.h: Use ExceptionOr for setVolume.

• html/NumberInputType.cpp:

(WebCore::RealNumberRenderSize::max): Use aggregate initialization instead
of a constructor.
(WebCore::calculateRenderSize): Ditto.
(WebCore::NumberInputType::setValueAsDouble): Use ExceptionOr.
(WebCore::NumberInputType::setValueAsDecimal): Ditto.

• html/NumberInputType.h: Updated for above changes.

• html/RangeInputType.cpp:

(WebCore::RangeInputType::RangeInputType): Initialize scalar data member
in class definition instead of here.
(WebCore::RangeInputType::setValueAsDecimal): Use ExceptionOr.
(WebCore::RangeInputType::handleKeydownEvent): Removed IGNORE_EXCEPTION.

• html/RangeInputType.h: Updated for above changes.

• html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::updatePlaceholderText): Removed
ASSERT_NO_EXCEPTION.

• html/TimeRanges.cpp:

(WebCore::TimeRanges::start): Use ExceptionOr.
(WebCore::TimeRanges::end): Ditto.

• html/TimeRanges.h: Updated for the above.
• html/TimeRanges.idl: Use non-legacy exceptions.

• html/URLUtils.idl: Use non-legacy exception.

• html/ValidationMessage.cpp:

(WebCore::ValidationMessage::setMessageDOMAndStartTimer): Removed
ASSERT_NO_EXCEPTION, IGNORE_EXCEPTION, and other exception-ignoring idioms.

• html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTagForInBody): Ditto.

• html/shadow/MediaControlElementTypes.cpp:

(WebCore::MediaControlVolumeSliderElement::defaultEventHandler): Ditto.

• html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::setPosition): Ditto.
(WebCore::MediaControlPanelElement::resetPosition): Ditto.
(WebCore::MediaControlStatusDisplayElement::update): Ditto.
(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay): Ditto.
(WebCore::MediaControlFullscreenVolumeMinButtonElement::defaultEventHandler): Ditto.
(WebCore::MediaControlFullscreenVolumeMaxButtonElement::defaultEventHandler): Ditto.

• html/shadow/MediaControls.cpp:

(WebCore::MediaControls::updateCurrentTimeDisplay): Ditto.

• html/shadow/MediaControlsApple.cpp:

(WebCore::MediaControlsApple::updateCurrentTimeDisplay): Ditto.

• html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::LoadableTextTrack): Take reference.
(WebCore::LoadableTextTrack::~LoadableTextTrack): Deleted.
(WebCore::LoadableTextTrack::clearClient): Deleted override. We no longer
want to clear m_trackElement when clearing the client.
(WebCore::LoadableTextTrack::setTrackElement): Deleted.
(WebCore::LoadableTextTrack::id): Changed to use
attributeWithoutSynchronization for better performance and idAttr instead
of a string constant.

• html/track/LoadableTextTrack.h: Updated for above changes. Added a new

clearElement function. Made the element and isDefault functions private.

• html/track/VTTCue.cpp:

(WebCore::VTTCue::~VTTCue): Removed ASSERT_NO_EXCEPTION, IGNORE_EXCEPTION,
and other exception-ignoring idioms.
(WebCore::VTTCue::removeDisplayTree): Ditto.

• html/track/VTTRegion.cpp:

(WebCore::VTTRegion::displayLastTextTrackCueBox): Ditto.
(WebCore::VTTRegion::willRemoveTextTrackCueBox): Ditto.

• inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::pushNodeByBackendIdToFrontend):
Rewrote to avoid multiplehash table lookups and added a FIXME about
the peculiar code here.
(WebCore::InspectorDOMAgent::resolveNode): Streamlined.
(WebCore::InspectorDOMAgent::nodeAsScriptValue): Use the new
checkSecurityForNode instead of the old shouldAllowAccessToNode.

• platform/graphics/ImageBuffer.h: Take Optional<double> instead of

const double* in toDataURL. Renamed ImageDataToDataURL to just dataURL.

• platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::addAudioTrack): Take a reference instead of PassRefPtr.
(WebCore::MediaPlayer::removeAudioTrack): Ditto.
(WebCore::MediaPlayer::addTextTrack): Ditto.
(WebCore::MediaPlayer::removeTextTrack): Ditto.
(WebCore::MediaPlayer::addVideoTrack): Ditto.
(WebCore::MediaPlayer::removeVideoTrack): Ditto.

• platform/graphics/MediaPlayer.h: Updated for the above.

• platform/graphics/PlatformTimeRanges.h: Exported a couple of functions

that are now used in WebKit.

• platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::clearTextTracks): Use a modern for loop.
(WebCore::MediaPlayerPrivateAVFoundation::processNewAndRemovedTextTracks):
Fixed a bug that would cause this function to fail to process half the tracks.
Also updated for the change from PassRefPtr to references.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::determineChangedTracksFromNewTracksAndOldItems): Pass references.
(WebCore::MediaPlayerPrivateAVFoundationObjC::audioSourceProvider): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::processMetadataTrack): Ditto.
(WebCore::assetMetadataKeyNames): Tweaked formatting.
(WebCore::itemKVOProperties): Ditto.
(WebCore::playerKVOProperties): Ditto.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::updateTracksOfType): Pass references.

• platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::toDataURL): Use Optional<double>

• platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::createBitmapImageAfterScalingIfNeeded): Use auto.
(WebCore::encodeImage): Ditto. Also renamed from CGImageEncodeToData.
(WebCore::dataURL): Ditto. Also renamed from CGImageToDataURL and from
ImageDataToDataURL.
(WebCore::ImageBuffer::toDataURL): Ditto.

• platform/graphics/efl/ImageBufferEfl.cpp:

(WebCore::encodeImageJPEG): Use Optional<double>
(WebCore::ImageBuffer::toDataURL): Ditto.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo): Pass
a reference instead of pointer.
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfText): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::processMpegTsSection): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::processTableOfContents): Ditto.

• platform/graphics/gtk/ImageBufferGtk.cpp:

(WebCore::encodeImage): Use Optional<double>
(WebCore::ImageBuffer::toDataURL): Ditto.

• platform/graphics/win/ImageBufferDirect2D.cpp:

(WebCore::ImageBuffer::toDataURL): Use Optional<double>

• platform/image-encoders/JPEGImageEncoder.cpp:

(WebCore::compressRGBABigEndianToJPEG): Use Optional<double>

• platform/image-encoders/JPEGImageEncoder.h: Ditto.

• platform/ios/WebPlaybackSessionInterfaceAVKit.mm:

(WebCore::WebPlaybackSessionInterfaceAVKit::seekableRangesChanged):
Updated for change to TimeRanges.

• platform/mac/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController setVolume:]): Removed IGNORE_EXCEPTION.

• xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::endElementNs): Ditto.

• rendering/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::paintMediaSliderTrack): Updated for changes to
the TimeRanges class.

Source/WebKit/mac:

• DOM/DOMCharacterData.mm:

(-[DOMCharacterData remove]): Updated exception handling.

• DOM/DOMDOMTokenList.mm:

(-[DOMDOMTokenList toggle:force:]): Ditto.

• DOM/DOMDocumentType.mm:

(-[DOMDocumentType remove]): Ditto.

• DOM/DOMElement.mm:

(-[DOMElement remove]): Ditto.

• DOM/DOMHTML.mm:

(-[DOMHTMLInputElement setValueAsNumberWithChangeEvent:]): Ditto.

• DOM/DOMHTMLCanvasElement.mm:

(-[DOMHTMLCanvasElement toDataURL:]): Ditto.

• DOM/DOMHTMLElement.mm:

(-[DOMHTMLElement setInnerText:]): Ditto.
(-[DOMHTMLElement setOuterText:]): Ditto.
(-[DOMHTMLElement setContentEditable:]): Ditto.

• DOM/DOMHTMLInputElement.mm:

(-[DOMHTMLInputElement setMaxLength:]): Ditto.
(-[DOMHTMLInputElement setValueAsDate:]): Ditto.
(-[DOMHTMLInputElement setValueAsNumber:]): Ditto.
(-[DOMHTMLInputElement stepUp:]): Ditto.
(-[DOMHTMLInputElement stepDown:]): Ditto.
(-[DOMHTMLInputElement setRangeText:]): Ditto.
(-[DOMHTMLInputElement setRangeText:start:end:selectionMode:]): Ditto.

• DOM/DOMHTMLMarqueeElement.mm:

(-[DOMHTMLMarqueeElement setLoop:]): Ditto.

• DOM/DOMHTMLMediaElement.mm:

(-[DOMHTMLMediaElement setCurrentTime:]): Ditto.
(-[DOMHTMLMediaElement setVolume:]): Ditto.

• DOM/DOMHTMLOptionsCollection.mm:

(-[DOMHTMLOptionsCollection setLength:]): Ditto.

• DOM/DOMHTMLTableElement.mm:

(-[DOMHTMLTableElement setCaption:]): Ditto.
(-[DOMHTMLTableElement setTHead:]): Ditto.
(-[DOMHTMLTableElement setTFoot:]): Ditto.
(-[DOMHTMLTableElement insertRow:]): Ditto.
(-[DOMHTMLTableElement deleteRow:]): Ditto.

• DOM/DOMHTMLTableRowElement.mm:

(-[DOMHTMLTableRowElement insertCell:]): Ditto.
(-[DOMHTMLTableRowElement deleteCell:]): Ditto.

• DOM/DOMHTMLTableSectionElement.mm:

(-[DOMHTMLTableSectionElement insertRow:]): Ditto.
(-[DOMHTMLTableSectionElement deleteRow:]): Ditto.

• DOM/DOMHTMLTextAreaElement.mm:

(-[DOMHTMLTextAreaElement setMaxLength:]): Ditto.
(-[DOMHTMLTextAreaElement setRangeText:]): Ditto.
(-[DOMHTMLTextAreaElement setRangeText:start:end:selectionMode:]): Ditto.

• DOM/DOMHTMLVideoElement.mm:

(-[DOMHTMLVideoElement webkitEnterFullscreen]): Ditto.
(-[DOMHTMLVideoElement webkitEnterFullScreen]): Changed to call the other named
version (lowercase S) instead of repeating the logic from that method.
(-[DOMHTMLVideoElement webkitExitFullScreen]): Ditto.

• DOM/DOMTimeRanges.mm:

(-[DOMTimeRanges start:]): Updated exception handling.
(-[DOMTimeRanges end:]): Ditto.

Source/WebKit/win:

• DOMHTMLClasses.cpp:

(DOMHTMLElement::setInnerText): Update exception handling.

• FullscreenVideoController.cpp:

(FullscreenVideoController::setVolume): Ditto.

Source/WebKit2:

• WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDOMTokenList.cpp:

(webkit_dom_dom_token_list_add): Updated exception handling.
(webkit_dom_dom_token_list_remove): Ditto.
(webkit_dom_dom_token_list_toggle): Ditto.
(webkit_dom_dom_token_list_replace): Ditto.

• WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMElement.cpp:

(webkit_dom_element_remove): Ditto.

• WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLElement.cpp:

(webkit_dom_html_element_set_inner_text): Ditto.
(webkit_dom_html_element_set_outer_text): Ditto.
(webkit_dom_html_element_set_content_editable): Ditto.

• WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLInputElement.cpp:

(webkit_dom_html_input_element_set_max_length): Ditto.
(webkit_dom_html_input_element_set_size): Ditto.

• WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLSelectElement.cpp:

(webkit_dom_html_select_element_set_length): Ditto.

• WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLTableElement.cpp:

(webkit_dom_html_table_element_insert_row): Ditto.
(webkit_dom_html_table_element_delete_row): Ditto.
(webkit_dom_html_table_element_set_caption): Ditto.
(webkit_dom_html_table_element_set_t_head): Ditto.
(webkit_dom_html_table_element_set_t_foot): Ditto.

• WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLTableRowElement.cpp:

(webkit_dom_html_table_row_element_insert_cell): Ditto.
(webkit_dom_html_table_row_element_delete_cell): Ditto.

• WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLTableSectionElement.cpp:

(webkit_dom_html_table_section_element_insert_row): Ditto.
(webkit_dom_html_table_section_element_delete_row): Ditto.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState): Removed ASSERT_NO_EXCEPTION.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::setAssistedNodeValueAsNumber): Removed ASSERT_NO_EXCEPTION.

• WebProcess/cocoa/WebPlaybackSessionManager.mm:

(WebKit::WebPlaybackSessionManager::seekableRangesChanged):
Changed the code to use a different interface to TimeRange that does
not involve exceptions.

Tools:

• TestWebKitAPI/Tests/WebCore/TimeRanges.cpp:

(TestWebKitAPI::ToString): Updated for changes to the TimeRanges class.
(TestWebKitAPI::TEST): Ditto.

LayoutTests:

• fast/dom/DOMURL/set-href-attribute-hash-expected.txt:
• fast/dom/DOMURL/set-href-attribute-hash.html:
• fast/dom/DOMURL/set-href-attribute-hostname-expected.txt:
• fast/dom/DOMURL/set-href-attribute-hostname.html:
• fast/dom/DOMURL/set-href-attribute-pathname-expected.txt:
• fast/dom/DOMURL/set-href-attribute-pathname.html:

Updated these tests to expect that if you set href and it raises an exception,
then the URL does not change. The old expected results showed the exception being
raised but the URL being changed to the invalid href.

• fast/dom/HTMLProgressElement/script-tests/set-progress-properties.js:
• fast/dom/HTMLProgressElement/set-progress-properties-expected.txt:

Updated to expect a different exception, TypeError rather than NotSupportedError,
for non-finite values.

7:12 PM Changeset in webkit [208095] by Devin Rousso

• 2 edits in trunk/Tools

Unreviewed, changed Devin Rousso's email and nick.

• Scripts/webkitpy/common/config/contributors.json:

7:07 PM Changeset in webkit [208094] by Wenson Hsieh

• 2 edits in trunk/Tools

Unreviewed, fix the iOS build after r208090.

Use soft-linking as needed in UIScriptControllerIOS.mm.

• WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):

6:42 PM Changeset in webkit [208093] by hyatt@apple.com

• 2 edits in trunk/Source/WebCore

[CSS Parser] Allow @font-face src descriptor's format function to contain identifiers
​https://bugs.webkit.org/show_bug.cgi?id=164169

Reviewed by Simon Fraser.

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeFontFaceSrcURI):

6:18 PM Changeset in webkit [208092] by jer.noble@apple.com

• 3 edits
  2 adds in trunk

WebAudio does not resume when moving from background to foreground tab.
​https://bugs.webkit.org/show_bug.cgi?id=164043

Reviewed by Darin Adler.

Source/WebCore:

Test: webaudio/page-canstartmedia.html

• Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::mediaCanStart):

LayoutTests:

• webaudio/page-canstartmedia-expected.txt: Added.
• webaudio/page-canstartmedia.html: Added.

6:17 PM Changeset in webkit [208091] by commit-queue@webkit.org

• 38 edits
  2 copies
  1 add in trunk/Source/WebInspectorUI

Web Inspector: Preferences for Text Editor behavior
​https://bugs.webkit.org/show_bug.cgi?id=149120

Patch by Devin Rousso <Devin Rousso> on 2016-10-28
Reviewed by Timothy Hatcher.

• Localizations/en.lproj/localizedStrings.js:

• UserInterface/Base/Main.js:

(WebInspector.loaded):
(WebInspector.contentLoaded):
(WebInspector.contentLoaded.setTabSize):
(WebInspector.contentLoaded.setInvalidCharacterClassName):
(WebInspector.contentLoaded.setWhitespaceCharacterClassName):
(WebInspector._tryToRestorePendingTabs):
(WebInspector.indentString):
(WebInspector._updateNewTabButtonState): Deleted.
(WebInspector._newTabItemClicked): Deleted.
Removed calls to the New Tab tab bar item on the Tab Bar instance.
Added listener to the indentUnit setting to change the tab-size value on <body>.
Created helper function to generate the indentString value from settings.

• UserInterface/Base/Test.js:

(WebInspector.indentString):
Assume indent string is " " for tests.

• UserInterface/Base/Setting.js:

Added global WebInspector.settings dictionary for holding settings with UI editors.

• UserInterface/Main.html:

Added GeneralTabBarItem, PinnedTabBarItem, and SettingsTabContentView.

• UserInterface/Models/CSSStyleDeclaration.js:

(WebInspector.CSSStyleDeclaration.prototype.generateCSSRuleString):

• UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype._formattedContentFromEditor):
(WebInspector.CSSStyleDeclarationTextEditor.prototype._resetContent.update):

• UserInterface/Views/VisualStylePropertyEditor.js:

(WebInspector.VisualStylePropertyEditor.generateFormattedTextForNewProperty):

• UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype._showPopoverForFunction.didGetDetails):
Now uses WebInspector.indentUnit for indentation values

• UserInterface/Views/CodeMirrorAdditions.js:

Added "showWhitespaceCharacter" option to CodeMirror. When enabled, it adds an overlay to
the editor that will use pseudo-elements to display whitespace characters (unicode 00B7).

• UserInterface/Views/CodeMirrorOverrides.css:

(.CodeMirror .cm-tab):
(.show-whitespace-characters .CodeMirror .cm-tab::before):
(.show-whitespace-characters .CodeMirror .cm-whitespace::before):
(.show-whitespace-characters .CodeMirror .cm-whitespace-1::before):
(.show-whitespace-characters .CodeMirror .cm-whitespace-2::before):
(.show-whitespace-characters .CodeMirror .cm-whitespace-3::before):
(.show-whitespace-characters .CodeMirror .cm-whitespace-4::before):
(.show-whitespace-characters .CodeMirror .cm-whitespace-5::before):
(.show-whitespace-characters .CodeMirror .cm-whitespace-6::before):
(.show-whitespace-characters .CodeMirror .cm-whitespace-7::before):
(.show-whitespace-characters .CodeMirror .cm-whitespace-8::before):
(.show-whitespace-characters .CodeMirror .cm-whitespace-9::before):
(.show-whitespace-characters .CodeMirror .cm-whitespace-10::before):
(.show-whitespace-characters .CodeMirror .cm-whitespace-11::before):
(.show-whitespace-characters .CodeMirror .cm-whitespace-12::before):
(.show-whitespace-characters .CodeMirror .cm-whitespace-13::before):
(.show-whitespace-characters .CodeMirror .cm-whitespace-14::before):
(.show-whitespace-characters .CodeMirror .cm-whitespace-15::before):
(.show-whitespace-characters .CodeMirror .cm-whitespace-16::before):
(.show-invalid-characters .CodeMirror .cm-invalidchar):
(.CodeMirror .cm-invalidchar): Deleted.
Use unicode character 00B7 (middle dot) to display a space. Also uses a grey border for
visualizing tab characters.

• UserInterface/Views/ApplicationCacheFrameContentView.js:
• UserInterface/Views/CSSStyleDeclarationTextEditor.js:
• UserInterface/Views/ClusterContentView.js:
• UserInterface/Views/DOMTreeContentView.js:
• UserInterface/Views/DatabaseContentView.js:
• UserInterface/Views/IndexedDatabaseObjectStoreContentView.js:
• UserInterface/Views/NetworkGridContentView.js:
• UserInterface/Views/ResourceContentView.js:
• UserInterface/Views/ScriptContentView.js:
• UserInterface/Views/TabContentView.js:
• UserInterface/Views/TimelineRecordingContentView.js:

Add calls to super.shown(), super.hidden(), and super.closed().

• UserInterface/Views/ConsoleTabContentView.js:
• UserInterface/Views/DebuggerTabContentView.js:
• UserInterface/Views/ElementsTabContentView.js:
• UserInterface/Views/NetworkTabContentView.js:
• UserInterface/Views/NewTabContentView.js:
• UserInterface/Views/ResourcesTabContentView.js:
• UserInterface/Views/SearchTabContentView.js:
• UserInterface/Views/StorageTabContentView.js:
• UserInterface/Views/TimelineTabContentView.js:

Now uses WebInspector.GeneralTabBarItem.

• UserInterface/Views/GeneralTabBarItem.js: Added.

(WebInspector.GeneralTabBarItem):
(WebInspector.GeneralTabBarItem.prototype.set title):
(WebInspector.GeneralTabBarItem.prototype._handleContextMenuEvent):
Split from TabBarItem.js to make pinned tab bar items more distinct.

• UserInterface/Views/Main.css:

(body):
Removed tab-size.

• UserInterface/Views/PinnedTabBarItem.js: Added.

(WebInspector.PinnedTabBarItem):
Split from TabBarItem.js to make pinned tab bar items more distinct.

• UserInterface/Views/SettingsTabContentView.css: Added.

(.content-view.settings):
(.content-view.settings > .header):
(.content-view.settings > .setting-container):
(.content-view.settings > .setting-container > .setting-name):
(.content-view.settings > .setting-container > .setting-value-controller):
(.content-view.settings > .setting-container > .setting-value-controller input[type="number"]):

• UserInterface/Views/SettingsTabContentView.js:

(WebInspector.SettingsTabContentView):
(WebInspector.SettingsTabContentView.tabInfo):
(WebInspector.SettingsTabContentView.isEphemeral):
(WebInspector.SettingsTabContentView.shouldSaveTab):
(WebInspector.SettingsTabContentView.prototype.initialLayout):
(WebInspector.SettingsTabContentView.isTabAllowed): Deleted.
(WebInspector.SettingsTabContentView.prototype.get type): Deleted.
Added logic to display an appropriate editor for each item in WebInspector.settings.

• UserInterface/Views/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor.prototype.close):
Add call to super.close().

• UserInterface/Views/TabBar.css:

(.tab-bar:not(.animating) > .item:not(.selected, .disabled):hover):
(.tab-bar > .item:not(.pinned) > .flex-space:last-child):
(.tab-bar > .item.pinned > .icon):
(.tab-bar:not(.animating) > .item:not(.selected, .disabled):hover > .icon):
(.tab-bar:not(.animating) > .item:not(.selected, .disabled):hover,): Deleted.
(.tab-bar > .item > .flex-space:last-child): Deleted.
(.tab-bar > .item.new-tab-button > .icon): Deleted.
(.tab-bar:not(.animating) > .item:not(.selected, .disabled):hover > .icon,): Deleted.
Removed rules specifically targeting .new-tab-button.

• UserInterface/Views/TabBar.js:

(WebInspector.TabBar):
(WebInspector.TabBar.prototype.get newTabTabBarItem):
(WebInspector.TabBar.prototype.updateNewTabTabBarItemState):
(WebInspector.TabBar.prototype.insertTabBarItem):
(WebInspector.TabBar.prototype.removeTabBarItem.animateTabs):
(WebInspector.TabBar.prototype.removeTabBarItem):
(WebInspector.TabBar.prototype.selectPreviousTab):
(WebInspector.TabBar.prototype.selectNextTab):
(WebInspector.TabBar.prototype.set selectedTabBarItem):
(WebInspector.TabBar.prototype.hasNormalTab):
(WebInspector.TabBar.prototype.layout):
(WebInspector.TabBar.prototype._hasMoreThanOneNormalTab):
(WebInspector.TabBar.prototype._handleMouseDown):
(WebInspector.TabBar.prototype._handleMouseMoved):
(WebInspector.TabBar.prototype._handleMouseLeave):
(WebInspector.TabBar.prototype._handleNewTabClick):
(WebInspector.TabBar.prototype._handleNewTabMouseEnter):
(WebInspector.TabBar.prototype.get newTabItem): Deleted.
(WebInspector.TabBar.prototype.set newTabItem): Deleted.
Replaced the newTabItem setter by adding a saved pinned tab bar item (instead of relying
upon a different object to give it the pinned tab bar item) that changes modes depending on
whether a new tab is able to be created.

• UserInterface/Views/TabBarItem.js:

(WebInspector.TabBarItem):
(WebInspector.TabBarItem.prototype.get element):
(WebInspector.TabBarItem.prototype.get representedObject):
(WebInspector.TabBarItem.prototype.set representedObject):
(WebInspector.TabBarItem.prototype.get parentTabBar):
(WebInspector.TabBarItem.prototype.set parentTabBar):
(WebInspector.TabBarItem.prototype.get image):
(WebInspector.TabBarItem.prototype.set image):
(WebInspector.TabBarItem.prototype.get title):
(WebInspector.TabBarItem.prototype.set title):
(WebInspector.TabBarItem.prototype.get pinned): Deleted.
(WebInspector.TabBarItem.prototype._handleContextMenuEvent): Deleted.
Split into GeneralTabBarItem and PinnedTabBarItem to simplify the logic of the DOM and allow
for easier checking of whether a tab bar item is pinned or not.

• UserInterface/Views/TabBrowser.js:

(WebInspector.TabBrowser):
(WebInspector.TabBrowser.prototype.addTabForContentView):
(WebInspector.TabBrowser.prototype.closeTabForContentView):
(WebInspector.TabBrowser.prototype._tabBarItemSelected):
(WebInspector.TabBrowser.prototype._tabBarItemRemoved):
Replaced references to newTabItem with a set number (since each TabBar has a specific number
of pinned tabs).

• UserInterface/Views/TextEditor.js:

(WebInspector.TextEditor):
(WebInspector.TextEditor.prototype.close):.
Remove settings update event listeners to allow garbage collection.

(WebInspector.TextEditor.prototype._startWorkerPrettyPrint):
(WebInspector.TextEditor.prototype._startCodeMirrorPrettyPrint):
Now uses the settings values in WebInspector.setting for settings on the CodeMirror
instance. Also updates the CodeMirror instance if any setting changes.

6:06 PM Changeset in webkit [208090] by Wenson Hsieh

• 17 edits
  4 adds in trunk

iOS autocorrection does not trigger an input event of inputType "insertReplacementText"
​https://bugs.webkit.org/show_bug.cgi?id=164077
<rdar://problem/28987810>

Reviewed by Simon Fraser.

Source/WebCore:

Fixes candidate insertion on iOS, so that it fires input events of type "insertReplacementText" and adds two
iOS unit tests covering this change as well as the test infrastructure needed to support these tests. See
comments below for more details.

Tests: fast/events/ios/before-input-events-prevent-candidate-insertion.html

fast/events/ios/input-events-insert-replacement-text.html

• dom/TextEvent.h:

Adds isAutocompletion() to TextEvent, as well as the TextEventInputAutocompletion text input type. When the
Editor handles this TextEvent, it will use this information when creating or modifying the corresponding typing
command.

• dom/TextEventInputType.h:
• editing/Editor.cpp:

(WebCore::Editor::insertText):
(WebCore::Editor::insertTextWithoutSendingTextEvent):

• editing/Editor.h:
• editing/TypingCommand.cpp:

(WebCore::editActionForTypingCommand):

Now takes whether the command is autocorrection into account. If so, the corresponding edit action should be
EditActionInsertReplacement rather than EditActionTypingInsertText.

(WebCore::TypingCommand::TypingCommand):
(WebCore::TypingCommand::deleteSelection):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::insertLineBreak):
(WebCore::TypingCommand::insertParagraphSeparatorInQuotedContent):
(WebCore::TypingCommand::insertParagraphSeparator):
(WebCore::TypingCommand::inputEventData):
(WebCore::TypingCommand::willAddTypingToOpenCommand):

• editing/TypingCommand.h:

Adds a new TypingCommand option, IsAutocompletion.

Source/WebKit2:

Small tweak to mark text insertion when autocorrecting as such, as opposed to regular keyboard input.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::syncApplyAutocorrection):

Tools:

Adds test support for inserting text candidates on iOS in the form of
UIScriptController.selectTextCandidateAtIndex(index, callback), which selects the text candidate at a given
index (this needs to be a value between 0-2 on iOS) and fires the callback when done.

To implement this, we wait for the text prediction view to have predictions (we determine this by polling at a
given interval) and then tap the center of the text prediction view at the given index.

• DumpRenderTree/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::selectTextCandidateAtIndex):

• TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
• TestRunnerShared/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::selectTextCandidateAtIndex):
(WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):

• TestRunnerShared/UIScriptContext/UIScriptController.h:
• WebKitTestRunner/ios/UIKitSPI.h:
• WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::selectTextCandidateAtIndex):
(WTR::UIScriptController::waitForTextPredictionsViewAndSelectCandidateAtIndex):

LayoutTests:

Adds 2 new unit tests verifying that candidate text insertion can be prevented via beforeinput events, and that
beforeinput and input events of type "insertReplacementText" are fired when inserting candidate text on iOS.

• fast/events/ios/before-input-events-prevent-candidate-insertion-expected.txt: Added.
• fast/events/ios/before-input-events-prevent-candidate-insertion.html: Added.
• fast/events/ios/input-events-insert-replacement-text-expected.txt: Added.
• fast/events/ios/input-events-insert-replacement-text.html: Added.

5:31 PM Changeset in webkit [208089] by achristensen@apple.com

• 9 edits in trunk

Unreviewed, rolling out r207700.
​https://bugs.webkit.org/show_bug.cgi?id=164168

We are ready after r208086 (Requested by alexchristensen on
#webkit).

Reverted changeset:

"Unreviewed, rolling out r207582."
​https://bugs.webkit.org/show_bug.cgi?id=163819
​http://trac.webkit.org/changeset/207700

Patch by Commit Queue <​commit-queue@webkit.org> on 2016-10-28

5:28 PM Changeset in webkit [208088] by hyatt@apple.com

• 2 edits in trunk/Source/WebCore

[CSS Parser] Allow unknown properties in will-change
​https://bugs.webkit.org/show_bug.cgi?id=164165

Reviewed by Simon Fraser.

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeWillChange):

5:20 PM Changeset in webkit [208087] by achristensen@apple.com

• 11 edits in trunk

Partially revert 207805 after resolution in URL spec issue 87
​https://bugs.webkit.org/show_bug.cgi?id=164142

Reviewed by Andy Estes.

LayoutTests/imported/w3c:

• web-platform-tests/url/a-element-expected.txt:
• web-platform-tests/url/a-element-xhtml-expected.txt:
• web-platform-tests/url/url-constructor-expected.txt:

Source/WebCore:

Covered by updated layout tests and API tests.

• platform/URLParser.cpp:

(WebCore::URLParser::isSingleDotPathSegment):
(WebCore::URLParser::isDoubleDotPathSegment):
(WebCore::URLParser::consumeSingleDotPathSegment):
(WebCore::URLParser::consumeDoubleDotPathSegment):
Treat %2e%2e as .. and %2e as . but only if it is entirety of the path segment.
There are tests for URLs like ​http://host/abc%2edef which have not changed because
the %2e is not the entirety of the path segment.

Tools:

• TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::TEST_F):

LayoutTests:

• fast/url/path-expected.txt:
• fetch/fetch-url-serialization-expected.txt:

5:17 PM Changeset in webkit [208086] by achristensen@apple.com

• 4 edits in trunk

URLParser should not try to interpret host of URLs with unrecognized schemes as IPv4 address
​https://bugs.webkit.org/show_bug.cgi?id=164154

Reviewed by Andy Estes.

Source/WebCore:

This is needed to match behavior of all browsers.
This is being discussed in the spec at ​https://github.com/whatwg/url/issues/148

Covered by new API tests.

• platform/URLParser.cpp:

(WebCore::URLParser::parseHostAndPort):
Only try to parse and canonicalize the host as an IPv4 address if the scheme is special (http, wss, etc.)

Tools:

• TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::TEST_F):

5:14 PM Changeset in webkit [208085] by matthew_hanson@apple.com

• 5 edits in branches/safari-602-branch/Source

Versioning.

5:05 PM Changeset in webkit [208084] by matthew_hanson@apple.com

• 1 copy in tags/Safari-602.3.6

New tag.

4:53 PM Changeset in webkit [208083] by Chris Dumez

• 5 edits in trunk

DOMStringMap reports properties as non-enumerable
​https://bugs.webkit.org/show_bug.cgi?id=164114

Reviewed by Sam Weinig.

Source/WebCore:

DOMStringMap's named properties should be configurable, enumerable
and writable as per:

• ​https://heycam.github.io/webidl/#getownproperty-guts (2.7-9)
• ​https://html.spec.whatwg.org/multipage/dom.html#domstringmap

Firefox and Chrome agree with the specification. However, WebKit
was doing the complete opposite.

No new tests, updated existing test.

• bindings/js/JSDOMStringMapCustom.cpp:

(WebCore::JSDOMStringMap::getOwnPropertySlotDelegate):

LayoutTests:

Update existing test to reflect behavior change.

• fast/dom/dataset-name-getter-properties-expected.txt:
• fast/dom/dataset-name-getter-properties.html:

4:49 PM Changeset in webkit [208082] by rniwa@webkit.org

• 24 edits
  1 copy
  25 adds in trunk

Add CEReactions to the remaining HTML DOM APIs
​https://bugs.webkit.org/show_bug.cgi?id=163969

Reviewed by Chris Dumez.

Source/WebCore:

Added CEReactions to the remaining DOM and HTML APIs as needed.

Tests: fast/custom-elements/reactions-for-indieui.html

fast/custom-elements/reactions/Document.html
fast/custom-elements/reactions/HTMLAnchorElement.html
fast/custom-elements/reactions/HTMLOptionElement.html
fast/custom-elements/reactions/HTMLOptionsCollection.html
fast/custom-elements/reactions/HTMLOutputElement.html
fast/custom-elements/reactions/HTMLSelectElement.html
fast/custom-elements/reactions/HTMLTableElement.html
fast/custom-elements/reactions/HTMLTableRowElement.html
fast/custom-elements/reactions/HTMLTableSectionElement.html
fast/custom-elements/reactions/HTMLTitleElement.html
fast/custom-elements/reactions/ShadowRoot.html

• bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::JSHTMLOptionsCollection::setLength):
(WebCore::JSHTMLOptionsCollection::indexSetter):

• bindings/js/JSHTMLSelectElementCustom.cpp:

(WebCore::JSHTMLSelectElement::indexSetter):

• dom/CharacterData.idl:
• dom/Document.idl:
• dom/Element.idl:
• dom/ShadowRoot.idl:
• html/HTMLAnchorElement.idl:
• html/HTMLDocument.idl:
• html/HTMLOptionElement.idl:
• html/HTMLOptionsCollection.idl:
• html/HTMLOutputElement.idl:
• html/HTMLSelectElement.idl:
• html/HTMLTableElement.idl:
• html/HTMLTableRowElement.idl:
• html/HTMLTableSectionElement.idl:
• html/HTMLTitleElement.idl:

LayoutTests:

Added W3C style testharness.js tests for CEReactions to various HTMLElements under fast/custom-elements/reactions.
Also added some WebKit specific tests using the same harness outside that directory.

• fast/custom-elements/reactions-for-indieui-expected.txt: Added.
• fast/custom-elements/reactions-for-indieui.html: Added.
• fast/custom-elements/reactions-for-webkit-extensions-expected.txt:
• fast/custom-elements/reactions-for-webkit-extensions.html:
• fast/custom-elements/reactions/Document-expected.txt: Added.
• fast/custom-elements/reactions/Document.html: Added.
• fast/custom-elements/reactions/HTMLAnchorElement-expected.txt: Added.
• fast/custom-elements/reactions/HTMLAnchorElement.html: Added.
• fast/custom-elements/reactions/HTMLOptionElement-expected.txt: Added.
• fast/custom-elements/reactions/HTMLOptionElement.html: Added.
• fast/custom-elements/reactions/HTMLOptionsCollection-expected.txt: Added.
• fast/custom-elements/reactions/HTMLOptionsCollection.html: Added.
• fast/custom-elements/reactions/HTMLOutputElement-expected.txt: Added.
• fast/custom-elements/reactions/HTMLOutputElement.html: Added.
• fast/custom-elements/reactions/HTMLSelectElement-expected.txt: Added.
• fast/custom-elements/reactions/HTMLSelectElement.html: Added.
• fast/custom-elements/reactions/HTMLTableElement-expected.txt: Added.
• fast/custom-elements/reactions/HTMLTableElement.html: Added.
• fast/custom-elements/reactions/HTMLTableRowElement-expected.txt: Added.
• fast/custom-elements/reactions/HTMLTableRowElement.html: Added.
• fast/custom-elements/reactions/HTMLTableSectionElement-expected.txt: Added.
• fast/custom-elements/reactions/HTMLTableSectionElement.html: Added.
• fast/custom-elements/reactions/HTMLTitleElement-expected.txt: Added.
• fast/custom-elements/reactions/HTMLTitleElement.html: Added.
• fast/custom-elements/reactions/ShadowRoot-expected.txt: Added.
• fast/custom-elements/reactions/ShadowRoot.html: Added.
• fast/custom-elements/resources/additional-helpers.js: Added.
• fast/custom-elements/upgrading-enqueue-reactions-expected.txt:
• fast/custom-elements/upgrading-enqueue-reactions.html:
• platform/efl/TestExpectations:
• platform/gtk/TestExpectations:

4:39 PM Changeset in webkit [208081] by achristensen@apple.com

• 2 edits
  1 move
  1 add in trunk/Source/WebKit2

Rename SharedMemoryMac to SharedMemoryCocoa
​https://bugs.webkit.org/show_bug.cgi?id=164156

Patch by Megan Gardner <Megan Gardner> on 2016-10-28
Reviewed by Alex Christensen.

Renamed SharedMemoryMac to SharedMemoryCocoa, as it runs on all cocoa platforms, not exclusively just mac, and
thus should be named to reflect that reality.

• Platform/cocoa: Added.
• Platform/cocoa/SharedMemoryCocoa.cpp: Copied from Source/WebKit2/Platform/mac/SharedMemoryMac.cpp.
• Platform/mac/SharedMemoryMac.cpp: Removed.
• WebKit2.xcodeproj/project.pbxproj:

4:35 PM Changeset in webkit [208080] by commit-queue@webkit.org

• 27 edits
  5 copies
  5 adds in trunk

[Modern Media Controls] Media Controller: volume control support
​https://bugs.webkit.org/show_bug.cgi?id=163727

Patch by Antoine Quint <Antoine Quint> on 2016-10-28
Reviewed by Dean Jackson.

Source/WebCore:

We introduce the VolumeSupport class which brings support for modifying the media
volume by interacting with the mute volume slider in the media controls and correctly
reflecting the media's volume should it be changed via the media API.

Tests: media/modern-media-controls/volume-support/volume-support-click.html

media/modern-media-controls/volume-support/volume-support-drag.html
media/modern-media-controls/volume-support/volume-support-media-api-mute.html
media/modern-media-controls/volume-support/volume-support-media-api.html

• Modules/modern-media-controls/js-files:
• Modules/modern-media-controls/media/media-controller.js:

(MediaController):

• Modules/modern-media-controls/media/volume-support.js: Added.

(VolumeSupport.prototype.get control):
(VolumeSupport.prototype.get mediaEvents):
(VolumeSupport.prototype.controlValueWillStartChanging):
(VolumeSupport.prototype.controlValueDidChange):
(VolumeSupport.prototype.syncControl):
(VolumeSupport):

• WebCore.xcodeproj/project.pbxproj:

LayoutTests:

Adding new tests for VolumeSupport and adding the new resource to other MediaController tests.

• http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html:
• media/modern-media-controls/elapsed-time-support/elapsed-time-support.html:
• media/modern-media-controls/media-controller/media-controller-constructor.html:
• media/modern-media-controls/media-controller/media-controller-resize.html:
• media/modern-media-controls/mute-support/mute-support-button-click.html:
• media/modern-media-controls/mute-support/mute-support-media-api.html:
• media/modern-media-controls/mute-support/mute-support-muted.html:
• media/modern-media-controls/playback-support/playback-support-autoplay.html:
• media/modern-media-controls/playback-support/playback-support-button-click.html:
• media/modern-media-controls/playback-support/playback-support-media-api.html:
• media/modern-media-controls/remaining-time-support/remaining-time-support.html:
• media/modern-media-controls/scrubber-support/scrubber-support-click.html:
• media/modern-media-controls/scrubber-support/scrubber-support-drag.html:
• media/modern-media-controls/scrubber-support/scrubber-support-media-api.html:
• media/modern-media-controls/start-support/start-support-audio.html:
• media/modern-media-controls/start-support/start-support-autoplay.html:
• media/modern-media-controls/start-support/start-support-click-to-start.html:
• media/modern-media-controls/start-support/start-support-error.html:
• media/modern-media-controls/start-support/start-support-fullscreen.html:
• media/modern-media-controls/start-support/start-support-manual-play.html:
• media/modern-media-controls/start-support/start-support-no-source.html:
• media/modern-media-controls/volume-support/volume-support-click-expected.txt: Added.
• media/modern-media-controls/volume-support/volume-support-click.html: Added.
• media/modern-media-controls/volume-support/volume-support-drag-expected.txt: Added.
• media/modern-media-controls/volume-support/volume-support-drag.html: Added.
• media/modern-media-controls/volume-support/volume-support-media-api-expected.txt: Added.
• media/modern-media-controls/volume-support/volume-support-media-api-mute-expected.txt: Added.
• media/modern-media-controls/volume-support/volume-support-media-api-mute.html: Added.
• media/modern-media-controls/volume-support/volume-support-media-api.html: Added.
• platform/ios-simulator/TestExpectations:

4:28 PM Changeset in webkit [208079] by Joseph Pecoraro

• 2 edits in branches/safari-602-branch/LayoutTests

Fix merge r207229. rdar://problem/29007278

• inspector/console/console-log-proxy.html:

4:19 PM Changeset in webkit [208078] by Yusuke Suzuki

• 4 edits in trunk/Source/JavaScriptCore

[DOMJIT] Include identifier name in CallDOMGetter to dump it
​https://bugs.webkit.org/show_bug.cgi?id=164161

Reviewed by Mark Lam.

This patch adds an identifier number to CallDOMGetterData and use it when dumping the data.
CallDOMGetter did not include identifier. It made CallDOMGetter super hard to debug when dumping DFG graph.

The dump becomes like this.

CallDOMGetter(Cell:@21, JS|MustGen|UseAsOther, Nonboolint32, id0{customGetter}, domJIT = 0x42f8a0, R:World, W:Heap, Exits, ClobbersExit, bc#15) predicting Nonboolint32

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleDOMJITGetter):
(JSC::DFG::ByteCodeParser::handleGetById):

• dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

• dfg/DFGNode.h:

3:57 PM Changeset in webkit [208077] by Yusuke Suzuki

• 26 edits
  1 move in trunk/Source

[DOMJIT] Rename CallDOM to CallDOMGetter
​https://bugs.webkit.org/show_bug.cgi?id=164157

Reviewed by Keith Miller.

Source/JavaScriptCore:

Rename CallDOM to CallDOMGetter to represent that
this is used for DOMJIT getter explicitly.
CallDOM will be used for DOM functions (like element.getAttribute()) later.

• JavaScriptCore.xcodeproj/project.pbxproj:
• bytecode/PolymorphicAccess.cpp:

(JSC::AccessCase::emitDOMJITGetter):

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::blessCallDOMGetter):
(JSC::DFG::ByteCodeParser::handleDOMJITGetter):
(JSC::DFG::blessCallDOM): Deleted.

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGGraph.h:
• dfg/DFGNode.h:

(JSC::DFG::Node::hasHeapPrediction):
(JSC::DFG::Node::hasCallDOMGetterData):
(JSC::DFG::Node::callDOMGetterData):
(JSC::DFG::Node::hasCallDOMData): Deleted.
(JSC::DFG::Node::callDOMData): Deleted.

• dfg/DFGNodeType.h:
• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCallDOMGetter):
(JSC::DFG::SpeculativeJIT::compileCallDOM): Deleted.

• dfg/DFGSpeculativeJIT.h:
• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• domjit/DOMJITCallDOMGetterPatchpoint.h: Renamed from Source/JavaScriptCore/domjit/DOMJITCallDOMPatchpoint.h.

(JSC::DOMJIT::CallDOMGetterPatchpoint::create):

• domjit/DOMJITGetterSetter.h:
• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileCallDOMGetter):
(JSC::FTL::DFG::LowerDFGToB3::compileCallDOM): Deleted.

• jsc.cpp:

Source/WebCore:

No behavior change.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

• bindings/scripts/test/JS/JSTestDOMJIT.h:
• domjit/JSDocumentDOMJIT.cpp:

(WebCore::DocumentDocumentElementDOMJIT::callDOMGetter):
(WebCore::DocumentDocumentElementDOMJIT::callDOM): Deleted.

• domjit/JSNodeDOMJIT.cpp:

(WebCore::createCallDOMGetterForOffsetAccess):
(WebCore::NodeFirstChildDOMJIT::callDOMGetter):
(WebCore::NodeLastChildDOMJIT::callDOMGetter):
(WebCore::NodeNextSiblingDOMJIT::callDOMGetter):
(WebCore::NodePreviousSiblingDOMJIT::callDOMGetter):
(WebCore::NodeParentNodeDOMJIT::callDOMGetter):
(WebCore::NodeNodeTypeDOMJIT::callDOMGetter):
(WebCore::NodeOwnerDocumentDOMJIT::callDOMGetter):
(WebCore::createCallDOMForOffsetAccess): Deleted.
(WebCore::NodeFirstChildDOMJIT::callDOM): Deleted.
(WebCore::NodeLastChildDOMJIT::callDOM): Deleted.
(WebCore::NodeNextSiblingDOMJIT::callDOM): Deleted.
(WebCore::NodePreviousSiblingDOMJIT::callDOM): Deleted.
(WebCore::NodeParentNodeDOMJIT::callDOM): Deleted.
(WebCore::NodeNodeTypeDOMJIT::callDOM): Deleted.
(WebCore::NodeOwnerDocumentDOMJIT::callDOM): Deleted.

3:19 PM Changeset in webkit [208076] by hyatt@apple.com

• 2 edits in trunk/Source/WebCore

[CSS Parser] Fix font-family parsing inside @font-face
​https://bugs.webkit.org/show_bug.cgi?id=164155

Reviewed by Simon Fraser.

• css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::parseFontFaceDescriptor):
Use the full font-family parsing that returns a CSSValueList,
since we can handle multiple families.

3:10 PM Changeset in webkit [208075] by pvollan@apple.com

• 2 edits in trunk/Source/WebCore

[Win][Direct2D] Implement ImageBufferData::putData.
​https://bugs.webkit.org/show_bug.cgi?id=164151

Reviewed by Brent Fulgham.

• platform/graphics/win/ImageBufferDataDirect2D.cpp:

(WebCore::ImageBufferData::getData):
(WebCore::ImageBufferData::putData):

2:57 PM Changeset in webkit [208074] by Yusuke Suzuki

• 4 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix in CLoop builds after r208063.

Include required headers.

• parser/Parser.h:
• runtime/Completion.cpp:
• runtime/JSGlobalObjectFunctions.cpp:

2:52 PM Changeset in webkit [208073] by hyatt@apple.com

• 2 edits in trunk/Source/WebCore

[CSS Parser] Support hanging-punctuation
​https://bugs.webkit.org/show_bug.cgi?id=164153

Reviewed by Simon Fraser.

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeHangingPunctuation):
(WebCore::CSSPropertyParser::parseSingleValue):

2:37 PM Changeset in webkit [208072] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Include parameter strings for native CustomElementRegistry methods in the console
​https://bugs.webkit.org/show_bug.cgi?id=164147

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-10-28
Reviewed by Brian Burg.

• UserInterface/Models/NativeFunctionParameters.js:

2:35 PM Changeset in webkit [208071] by Ryan Haddad

• 14 edits in trunk/Source/JavaScriptCore

Update reference files for builtins generator tests after r208063.

Unreviewed test gardening.

• Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Combined.js-result:
• Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Separate.js-result:
• Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Combined.js-result:
• Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Separate.js-result:
• Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Combined.js-result:
• Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Separate.js-result:
• Scripts/tests/builtins/expected/JavaScriptCore-InternalClashingNames-Combined.js-result:
• Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result:
• Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result:
• Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result:
• Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result:
• Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result:
• Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result:

2:33 PM Changeset in webkit [208070] by Yusuke Suzuki

• 9 edits
  2 copies
  5 adds in trunk

[DOMJIT] Implement Document::documentElement
​https://bugs.webkit.org/show_bug.cgi?id=164113

Reviewed by Sam Weinig.

Source/WebCore:

Test: js/dom/domjit-accessor-document-element.html

This patch implements document.documentElement DOMJIT accessor.
Similar to ownerDocument accessor, the way to access to document.documentElement
from JIT code is already prepared for CSSJIT. DOMJIT just utilizes the existing
functionality: using documentElementMemoryOffset().

document.documentElement is frequently called in jQuery. Especially, every time
we call jQuery.attr(), this is called.

To implement Document accessor, we clean up some code in DOMJITHelpers.
We create the cpp file for DOMJITHelpers and move some helpers to it.
And we also implement DOMJIT::checkDOM<DOMInterface> for convenience.
It returns appropriate CheckDOM patchpoint implementation.

This patch improves Dromaeo jslib-attr-jquery.html 10% (481.64 v.s. 532.54).

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:
• cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsScopeRoot):

• dom/Document.idl:
• domjit/DOMJITAbstractHeapRepository.h:
• domjit/DOMJITCheckDOM.h: Copied from Source/WebCore/domjit/DOMJITAbstractHeapRepository.h.

(WebCore::DOMJIT::TypeChecker<Node>::branchIfFail):
(WebCore::DOMJIT::TypeChecker<Document>::branchIfFail):
(WebCore::DOMJIT::TypeChecker<Event>::branchIfFail):
(WebCore::DOMJIT::TypeChecker<Element>::branchIfFail):
(WebCore::DOMJIT::checkDOM):

• domjit/DOMJITHelpers.cpp: Copied from Source/WebCore/domjit/DOMJITAbstractHeapRepository.h.

(WebCore::DOMJIT::loadDocument):
(WebCore::DOMJIT::loadDocumentElement):

• domjit/DOMJITHelpers.h:

(WebCore::DOMJIT::toWrapperSlow):
(WebCore::DOMJIT::loadDocument): Deleted.

• domjit/JSDocumentDOMJIT.cpp: Added.

(WebCore::DocumentDocumentElementDOMJIT::checkDOM):
(WebCore::DocumentDocumentElementDOMJIT::callDOM):

• domjit/JSNodeDOMJIT.cpp:

(WebCore::createCallDOMForOffsetAccess):
(WebCore::NodeFirstChildDOMJIT::checkDOM):
(WebCore::NodeLastChildDOMJIT::checkDOM):
(WebCore::NodeNextSiblingDOMJIT::checkDOM):
(WebCore::NodePreviousSiblingDOMJIT::checkDOM):
(WebCore::NodeParentNodeDOMJIT::checkDOM):
(WebCore::NodeNodeTypeDOMJIT::checkDOM):
(WebCore::NodeOwnerDocumentDOMJIT::checkDOM):
(WebCore::NodeOwnerDocumentDOMJIT::callDOM):
(WebCore::toWrapperSlow): Deleted.
(WebCore::checkNode): Deleted.

LayoutTests:

• js/dom/domjit-accessor-document-element-changed-expected.txt: Added.
• js/dom/domjit-accessor-document-element-changed.html: Added.
• js/dom/domjit-accessor-document-element-expected.txt: Added.
• js/dom/domjit-accessor-document-element.html: Added.

2:12 PM Changeset in webkit [208069] by hyatt@apple.com

• 2 edits in trunk/Source/WebCore

[CSS Parser] Support initial-letter
​https://bugs.webkit.org/show_bug.cgi?id=164150

Reviewed by Simon Fraser.

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeInitialLetter):
(WebCore::CSSPropertyParser::parseSingleValue):

2:02 PM Changeset in webkit [208068] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Remove some unused code in RenderLayerCompositor::computeExtent()
​https://bugs.webkit.org/show_bug.cgi?id=163934

Reviewed by Zalan Bujtas.

viewportRect was never used.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeExtent):

1:54 PM Changeset in webkit [208067] by Yusuke Suzuki

• 2 edits in trunk/Source/JavaScriptCore

[JSC] Add wasm/js directory to JSC include directories in CMakeLists.txt
​https://bugs.webkit.org/show_bug.cgi?id=164145

Reviewed by Michael Catanzaro.

Attempt to fix CMake ports. We include a file under wasm/js.
But we didn't add it to JSC include directories.

• CMakeLists.txt:

1:53 PM Changeset in webkit [208066] by weinig@apple.com

• 8 edits in trunk

[WebIDL] Update parser and code generators to only access type information through the type property
​https://bugs.webkit.org/show_bug.cgi?id=164141

Reviewed by Anders Carlsson.

Source/WebCore:

Update IDLParser structs:

• domSignature: Rename idlType to type. Specify that type is a domType.
• domInterface: Remove name and parent. Specify that type and parentType are a domTypes.
• domFunction: Specify that signature is a domSignature.
• domAttribute: Remove unused type. Specify that signature is a domSignature.
• domIterable: Remove idlKeyType and valueKeyType. Specify that keyType and valueType are a domTypes
• domConstant: Specify that type is a domType.
• domEnum: Specify that type is a domType.
• domDictionary: Remove name and parent. Specify that type and parentType are a domTypes.
• Typedef: Rename idlType to type and specify that it is a domType.

• bindings/scripts/IDLParser.pm:

Remove redundant properties and specify type info in structs where possible.

• bindings/scripts/CodeGenerator.pm:

(IsSVGTypeNeedingTearOffForType): Renamed to remove ForType suffix.
(IsSVGTypeWithWritablePropertiesNeedingTearOffForType): Renamed to remove ForType suffix.
(GetSVGTypeNeedingTearOffForType): Renamed to remove ForType suffix.
(GetSVGWrappedTypeNeedingTearOffForType): Renamed to remove ForType suffix.

Update to always access type information through type accessors. Remove use of removed
properties.

• bindings/scripts/CodeGeneratorJS.pm:

(IsNullableType): Deleted.
(StripNullable): Deleted.
Remove unused functions.

Update to always access type information through type accessors. Remove use of removed
properties.

• bindings/scripts/generate-bindings.pl:

Update to always access type information through type accessors. Remove use of removed
properties.

Tools:

• DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
• WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:

Update to always access type information through type accessors. Remove use of removed
properties.

1:45 PM Changeset in webkit [208065] by hyatt@apple.com

• 2 edits in trunk/Source/WebCore

[CSS Parser] Support bopomofo Ruby
​https://bugs.webkit.org/show_bug.cgi?id=164148

Reviewed by Simon Fraser.

• css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):

1:41 PM Changeset in webkit [208064] by hyatt@apple.com

• 3 edits in trunk/Source/WebCore

[CSS Parser] Add support for -webkit-canvas images
​https://bugs.webkit.org/show_bug.cgi?id=164144

Reviewed by Simon Fraser.

• css/CSSValueKeywords.in:
• css/parser/CSSParser.cpp:

(WebCore::CSSParserContext::CSSParserContext):

• css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::consumeWebkitCanvas):
(WebCore::CSSPropertyParserHelpers::consumeGeneratedImage):
(WebCore::CSSPropertyParserHelpers::isGeneratedImage):

1:04 PM Changeset in webkit [208063] by ggaren@apple.com

• 40 edits
  14 copies
  3 moves in trunk/Source

One file per class for Executable.h/.cpp
​https://bugs.webkit.org/show_bug.cgi?id=164099

Reviewed by Saam Barati.

Source/JavaScriptCore:

• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• Scripts/builtins/builtins_generate_combined_implementation.py:

(BuiltinsCombinedImplementationGenerator.generate_secondary_header_includes):

• Scripts/builtins/builtins_generate_separate_implementation.py:

(BuiltinsSeparateImplementationGenerator.generate_secondary_header_includes):

• builtins/BuiltinExecutables.cpp:
• bytecode/CallVariant.h:
• bytecode/CodeBlock.cpp:
• bytecode/CodeBlock.h:

(JSC::ScriptExecutable::prepareForExecution):

• bytecode/CodeOrigin.cpp:
• bytecode/EvalCodeCache.h:
• bytecode/InlineCallFrame.cpp:
• bytecode/UnlinkedCodeBlock.cpp:
• bytecode/UnlinkedFunctionExecutable.cpp:
• bytecompiler/StaticPropertyAnalysis.h:
• debugger/DebuggerLocation.cpp:
• dfg/DFGCapabilities.h:
• dfg/DFGOSRExitPreparation.cpp:
• dfg/DFGToFTLDeferredCompilationCallback.cpp:
• dfg/DFGToFTLForOSREntryDeferredCompilationCallback.cpp:
• interpreter/StackVisitor.cpp:
• jit/JITThunks.cpp:
• jit/JITToDFGDeferredCompilationCallback.cpp:
• jit/SpecializedThunkJIT.h:
• llint/LLIntOffsetsExtractor.cpp:
• parser/Parser.h:
• runtime/CallData.cpp:
• runtime/ConstructData.cpp:
• runtime/EvalExecutable.cpp: Copied from Source/JavaScriptCore/runtime/Executable.cpp.

(JSC::ExecutableBase::destroy): Deleted.
(JSC::ExecutableBase::clearCode): Deleted.
(JSC::NativeExecutable::create): Deleted.
(JSC::NativeExecutable::destroy): Deleted.
(JSC::NativeExecutable::createStructure): Deleted.
(JSC::NativeExecutable::finishCreation): Deleted.
(JSC::NativeExecutable::NativeExecutable): Deleted.
(JSC::ScriptExecutable::ScriptExecutable): Deleted.
(JSC::ScriptExecutable::destroy): Deleted.
(JSC::ScriptExecutable::installCode): Deleted.
(JSC::ScriptExecutable::newCodeBlockFor): Deleted.
(JSC::ScriptExecutable::newReplacementCodeBlockFor): Deleted.
(JSC::setupLLInt): Deleted.
(JSC::setupJIT): Deleted.
(JSC::ScriptExecutable::prepareForExecutionImpl): Deleted.
(JSC::ProgramExecutable::ProgramExecutable): Deleted.
(JSC::ProgramExecutable::destroy): Deleted.
(JSC::ModuleProgramExecutable::ModuleProgramExecutable): Deleted.
(JSC::ModuleProgramExecutable::create): Deleted.
(JSC::ModuleProgramExecutable::destroy): Deleted.
(JSC::FunctionExecutable::FunctionExecutable): Deleted.
(JSC::FunctionExecutable::finishCreation): Deleted.
(JSC::FunctionExecutable::destroy): Deleted.
(JSC::samplingDescription): Deleted.
(JSC::ProgramExecutable::checkSyntax): Deleted.
(JSC::ProgramExecutable::initializeGlobalProperties): Deleted.
(JSC::ProgramExecutable::visitChildren): Deleted.
(JSC::ModuleProgramExecutable::visitChildren): Deleted.
(JSC::FunctionExecutable::baselineCodeBlockFor): Deleted.
(JSC::FunctionExecutable::visitChildren): Deleted.
(JSC::FunctionExecutable::fromGlobalCode): Deleted.
(JSC::WebAssemblyExecutable::WebAssemblyExecutable): Deleted.
(JSC::WebAssemblyExecutable::destroy): Deleted.
(JSC::WebAssemblyExecutable::visitChildren): Deleted.
(JSC::ExecutableBase::dump): Deleted.
(JSC::ExecutableBase::hashFor): Deleted.
(JSC::NativeExecutable::hashFor): Deleted.
(JSC::ScriptExecutable::hashFor): Deleted.

• runtime/EvalExecutable.h: Copied from Source/JavaScriptCore/runtime/Executable.h.

(JSC::isCall): Deleted.
(JSC::ExecutableBase::ExecutableBase): Deleted.
(JSC::ExecutableBase::finishCreation): Deleted.
(JSC::ExecutableBase::isEvalExecutable): Deleted.
(JSC::ExecutableBase::isFunctionExecutable): Deleted.
(JSC::ExecutableBase::isProgramExecutable): Deleted.
(JSC::ExecutableBase::isModuleProgramExecutable): Deleted.
(JSC::ExecutableBase::isHostFunction): Deleted.
(JSC::ExecutableBase::isWebAssemblyExecutable): Deleted.
(JSC::ExecutableBase::createStructure): Deleted.
(JSC::ExecutableBase::generatedJITCodeForCall): Deleted.
(JSC::ExecutableBase::generatedJITCodeForConstruct): Deleted.
(JSC::ExecutableBase::generatedJITCodeFor): Deleted.
(JSC::ExecutableBase::entrypointFor): Deleted.
(JSC::ExecutableBase::offsetOfJITCodeWithArityCheckFor): Deleted.
(JSC::ExecutableBase::offsetOfNumParametersFor): Deleted.
(JSC::ExecutableBase::hasJITCodeForCall): Deleted.
(JSC::ExecutableBase::hasJITCodeForConstruct): Deleted.
(JSC::ExecutableBase::hasJITCodeFor): Deleted.
(JSC::ExecutableBase::intrinsic): Deleted.
(JSC::ExecutableBase::intrinsicFor): Deleted.
(JSC::ScriptExecutable::source): Deleted.
(JSC::ScriptExecutable::sourceID): Deleted.
(JSC::ScriptExecutable::sourceURL): Deleted.
(JSC::ScriptExecutable::firstLine): Deleted.
(JSC::ScriptExecutable::setOverrideLineNumber): Deleted.
(JSC::ScriptExecutable::hasOverrideLineNumber): Deleted.
(JSC::ScriptExecutable::overrideLineNumber): Deleted.
(JSC::ScriptExecutable::lastLine): Deleted.
(JSC::ScriptExecutable::startColumn): Deleted.
(JSC::ScriptExecutable::endColumn): Deleted.
(JSC::ScriptExecutable::typeProfilingStartOffset): Deleted.
(JSC::ScriptExecutable::typeProfilingEndOffset): Deleted.
(JSC::ScriptExecutable::usesEval): Deleted.
(JSC::ScriptExecutable::usesArguments): Deleted.
(JSC::ScriptExecutable::isArrowFunctionContext): Deleted.
(JSC::ScriptExecutable::isStrictMode): Deleted.
(JSC::ScriptExecutable::derivedContextType): Deleted.
(JSC::ScriptExecutable::evalContextType): Deleted.
(JSC::ScriptExecutable::ecmaMode): Deleted.
(JSC::ScriptExecutable::setNeverInline): Deleted.
(JSC::ScriptExecutable::setNeverOptimize): Deleted.
(JSC::ScriptExecutable::setNeverFTLOptimize): Deleted.
(JSC::ScriptExecutable::setDidTryToEnterInLoop): Deleted.
(JSC::ScriptExecutable::setCanUseOSRExitFuzzing): Deleted.
(JSC::ScriptExecutable::neverInline): Deleted.
(JSC::ScriptExecutable::neverOptimize): Deleted.
(JSC::ScriptExecutable::neverFTLOptimize): Deleted.
(JSC::ScriptExecutable::didTryToEnterInLoop): Deleted.
(JSC::ScriptExecutable::isInliningCandidate): Deleted.
(JSC::ScriptExecutable::isOkToOptimize): Deleted.
(JSC::ScriptExecutable::canUseOSRExitFuzzing): Deleted.
(JSC::ScriptExecutable::addressOfDidTryToEnterInLoop): Deleted.
(JSC::ScriptExecutable::features): Deleted.
(JSC::ScriptExecutable::recordParse): Deleted.
(JSC::ScriptExecutable::finishCreation): Deleted.
(JSC::ScriptExecutable::prepareForExecution): Deleted.

• runtime/Executable.cpp: Removed.
• runtime/Executable.h: Removed.
• runtime/ExecutableBase.cpp: Copied from Source/JavaScriptCore/runtime/Executable.cpp.

(JSC::NativeExecutable::create): Deleted.
(JSC::NativeExecutable::destroy): Deleted.
(JSC::NativeExecutable::createStructure): Deleted.
(JSC::NativeExecutable::finishCreation): Deleted.
(JSC::NativeExecutable::NativeExecutable): Deleted.
(JSC::ScriptExecutable::ScriptExecutable): Deleted.
(JSC::ScriptExecutable::destroy): Deleted.
(JSC::ScriptExecutable::installCode): Deleted.
(JSC::ScriptExecutable::newCodeBlockFor): Deleted.
(JSC::ScriptExecutable::newReplacementCodeBlockFor): Deleted.
(JSC::setupLLInt): Deleted.
(JSC::setupJIT): Deleted.
(JSC::ScriptExecutable::prepareForExecutionImpl): Deleted.
(JSC::EvalExecutable::create): Deleted.
(JSC::EvalExecutable::EvalExecutable): Deleted.
(JSC::EvalExecutable::destroy): Deleted.
(JSC::ProgramExecutable::ProgramExecutable): Deleted.
(JSC::ProgramExecutable::destroy): Deleted.
(JSC::ModuleProgramExecutable::ModuleProgramExecutable): Deleted.
(JSC::ModuleProgramExecutable::create): Deleted.
(JSC::ModuleProgramExecutable::destroy): Deleted.
(JSC::FunctionExecutable::FunctionExecutable): Deleted.
(JSC::FunctionExecutable::finishCreation): Deleted.
(JSC::FunctionExecutable::destroy): Deleted.
(JSC::samplingDescription): Deleted.
(JSC::EvalExecutable::visitChildren): Deleted.
(JSC::ProgramExecutable::checkSyntax): Deleted.
(JSC::ProgramExecutable::initializeGlobalProperties): Deleted.
(JSC::ProgramExecutable::visitChildren): Deleted.
(JSC::ModuleProgramExecutable::visitChildren): Deleted.
(JSC::FunctionExecutable::baselineCodeBlockFor): Deleted.
(JSC::FunctionExecutable::visitChildren): Deleted.
(JSC::FunctionExecutable::fromGlobalCode): Deleted.
(JSC::WebAssemblyExecutable::WebAssemblyExecutable): Deleted.
(JSC::WebAssemblyExecutable::destroy): Deleted.
(JSC::WebAssemblyExecutable::visitChildren): Deleted.
(JSC::NativeExecutable::hashFor): Deleted.
(JSC::ScriptExecutable::hashFor): Deleted.

• runtime/ExecutableBase.h: Copied from Source/JavaScriptCore/runtime/Executable.h.

(JSC::ScriptExecutable::source): Deleted.
(JSC::ScriptExecutable::sourceID): Deleted.
(JSC::ScriptExecutable::sourceURL): Deleted.
(JSC::ScriptExecutable::firstLine): Deleted.
(JSC::ScriptExecutable::setOverrideLineNumber): Deleted.
(JSC::ScriptExecutable::hasOverrideLineNumber): Deleted.
(JSC::ScriptExecutable::overrideLineNumber): Deleted.
(JSC::ScriptExecutable::lastLine): Deleted.
(JSC::ScriptExecutable::startColumn): Deleted.
(JSC::ScriptExecutable::endColumn): Deleted.
(JSC::ScriptExecutable::typeProfilingStartOffset): Deleted.
(JSC::ScriptExecutable::typeProfilingEndOffset): Deleted.
(JSC::ScriptExecutable::usesEval): Deleted.
(JSC::ScriptExecutable::usesArguments): Deleted.
(JSC::ScriptExecutable::isArrowFunctionContext): Deleted.
(JSC::ScriptExecutable::isStrictMode): Deleted.
(JSC::ScriptExecutable::derivedContextType): Deleted.
(JSC::ScriptExecutable::evalContextType): Deleted.
(JSC::ScriptExecutable::ecmaMode): Deleted.
(JSC::ScriptExecutable::setNeverInline): Deleted.
(JSC::ScriptExecutable::setNeverOptimize): Deleted.
(JSC::ScriptExecutable::setNeverFTLOptimize): Deleted.
(JSC::ScriptExecutable::setDidTryToEnterInLoop): Deleted.
(JSC::ScriptExecutable::setCanUseOSRExitFuzzing): Deleted.
(JSC::ScriptExecutable::neverInline): Deleted.
(JSC::ScriptExecutable::neverOptimize): Deleted.
(JSC::ScriptExecutable::neverFTLOptimize): Deleted.
(JSC::ScriptExecutable::didTryToEnterInLoop): Deleted.
(JSC::ScriptExecutable::isInliningCandidate): Deleted.
(JSC::ScriptExecutable::isOkToOptimize): Deleted.
(JSC::ScriptExecutable::canUseOSRExitFuzzing): Deleted.
(JSC::ScriptExecutable::addressOfDidTryToEnterInLoop): Deleted.
(JSC::ScriptExecutable::features): Deleted.
(JSC::ScriptExecutable::recordParse): Deleted.
(JSC::ScriptExecutable::finishCreation): Deleted.
(JSC::ScriptExecutable::prepareForExecution): Deleted.

• runtime/FunctionExecutable.cpp: Copied from Source/JavaScriptCore/runtime/Executable.cpp.

(JSC::ExecutableBase::destroy): Deleted.
(JSC::ExecutableBase::clearCode): Deleted.
(JSC::NativeExecutable::create): Deleted.
(JSC::NativeExecutable::destroy): Deleted.
(JSC::NativeExecutable::createStructure): Deleted.
(JSC::NativeExecutable::finishCreation): Deleted.
(JSC::NativeExecutable::NativeExecutable): Deleted.
(JSC::ScriptExecutable::ScriptExecutable): Deleted.
(JSC::ScriptExecutable::destroy): Deleted.
(JSC::ScriptExecutable::installCode): Deleted.
(JSC::ScriptExecutable::newCodeBlockFor): Deleted.
(JSC::ScriptExecutable::newReplacementCodeBlockFor): Deleted.
(JSC::setupLLInt): Deleted.
(JSC::setupJIT): Deleted.
(JSC::ScriptExecutable::prepareForExecutionImpl): Deleted.
(JSC::EvalExecutable::create): Deleted.
(JSC::EvalExecutable::EvalExecutable): Deleted.
(JSC::EvalExecutable::destroy): Deleted.
(JSC::ProgramExecutable::ProgramExecutable): Deleted.
(JSC::ProgramExecutable::destroy): Deleted.
(JSC::ModuleProgramExecutable::ModuleProgramExecutable): Deleted.
(JSC::ModuleProgramExecutable::create): Deleted.
(JSC::ModuleProgramExecutable::destroy): Deleted.
(JSC::samplingDescription): Deleted.
(JSC::EvalExecutable::visitChildren): Deleted.
(JSC::ProgramExecutable::checkSyntax): Deleted.
(JSC::ProgramExecutable::initializeGlobalProperties): Deleted.
(JSC::ProgramExecutable::visitChildren): Deleted.
(JSC::ModuleProgramExecutable::visitChildren): Deleted.
(JSC::WebAssemblyExecutable::WebAssemblyExecutable): Deleted.
(JSC::WebAssemblyExecutable::destroy): Deleted.
(JSC::WebAssemblyExecutable::visitChildren): Deleted.
(JSC::ExecutableBase::dump): Deleted.
(JSC::ExecutableBase::hashFor): Deleted.
(JSC::NativeExecutable::hashFor): Deleted.
(JSC::ScriptExecutable::hashFor): Deleted.

• runtime/FunctionExecutable.h: Copied from Source/JavaScriptCore/runtime/Executable.h.

(JSC::isCall): Deleted.
(JSC::ExecutableBase::ExecutableBase): Deleted.
(JSC::ExecutableBase::finishCreation): Deleted.
(JSC::ExecutableBase::isEvalExecutable): Deleted.
(JSC::ExecutableBase::isFunctionExecutable): Deleted.
(JSC::ExecutableBase::isProgramExecutable): Deleted.
(JSC::ExecutableBase::isModuleProgramExecutable): Deleted.
(JSC::ExecutableBase::isHostFunction): Deleted.
(JSC::ExecutableBase::isWebAssemblyExecutable): Deleted.
(JSC::ExecutableBase::createStructure): Deleted.
(JSC::ExecutableBase::generatedJITCodeForCall): Deleted.
(JSC::ExecutableBase::generatedJITCodeForConstruct): Deleted.
(JSC::ExecutableBase::generatedJITCodeFor): Deleted.
(JSC::ExecutableBase::entrypointFor): Deleted.
(JSC::ExecutableBase::offsetOfJITCodeWithArityCheckFor): Deleted.
(JSC::ExecutableBase::offsetOfNumParametersFor): Deleted.
(JSC::ExecutableBase::hasJITCodeForCall): Deleted.
(JSC::ExecutableBase::hasJITCodeForConstruct): Deleted.
(JSC::ExecutableBase::hasJITCodeFor): Deleted.
(JSC::ExecutableBase::intrinsic): Deleted.
(JSC::ExecutableBase::intrinsicFor): Deleted.
(JSC::ScriptExecutable::source): Deleted.
(JSC::ScriptExecutable::sourceID): Deleted.
(JSC::ScriptExecutable::sourceURL): Deleted.
(JSC::ScriptExecutable::firstLine): Deleted.
(JSC::ScriptExecutable::setOverrideLineNumber): Deleted.
(JSC::ScriptExecutable::hasOverrideLineNumber): Deleted.
(JSC::ScriptExecutable::overrideLineNumber): Deleted.
(JSC::ScriptExecutable::lastLine): Deleted.
(JSC::ScriptExecutable::startColumn): Deleted.
(JSC::ScriptExecutable::endColumn): Deleted.
(JSC::ScriptExecutable::typeProfilingStartOffset): Deleted.
(JSC::ScriptExecutable::typeProfilingEndOffset): Deleted.
(JSC::ScriptExecutable::usesEval): Deleted.
(JSC::ScriptExecutable::usesArguments): Deleted.
(JSC::ScriptExecutable::isArrowFunctionContext): Deleted.
(JSC::ScriptExecutable::isStrictMode): Deleted.
(JSC::ScriptExecutable::derivedContextType): Deleted.
(JSC::ScriptExecutable::evalContextType): Deleted.
(JSC::ScriptExecutable::ecmaMode): Deleted.
(JSC::ScriptExecutable::setNeverInline): Deleted.
(JSC::ScriptExecutable::setNeverOptimize): Deleted.
(JSC::ScriptExecutable::setNeverFTLOptimize): Deleted.
(JSC::ScriptExecutable::setDidTryToEnterInLoop): Deleted.
(JSC::ScriptExecutable::setCanUseOSRExitFuzzing): Deleted.
(JSC::ScriptExecutable::neverInline): Deleted.
(JSC::ScriptExecutable::neverOptimize): Deleted.
(JSC::ScriptExecutable::neverFTLOptimize): Deleted.
(JSC::ScriptExecutable::didTryToEnterInLoop): Deleted.
(JSC::ScriptExecutable::isInliningCandidate): Deleted.
(JSC::ScriptExecutable::isOkToOptimize): Deleted.
(JSC::ScriptExecutable::canUseOSRExitFuzzing): Deleted.
(JSC::ScriptExecutable::addressOfDidTryToEnterInLoop): Deleted.
(JSC::ScriptExecutable::features): Deleted.
(JSC::ScriptExecutable::recordParse): Deleted.
(JSC::ScriptExecutable::finishCreation): Deleted.
(JSC::ScriptExecutable::prepareForExecution): Deleted.

• runtime/FunctionExecutableDump.h:
• runtime/JSArray.cpp:
• runtime/JSFunctionInlines.h:
• runtime/JSModuleRecord.cpp:
• runtime/JSObject.cpp:
• runtime/Lookup.cpp:
• runtime/ModuleProgramExecutable.cpp: Copied from Source/JavaScriptCore/runtime/Executable.cpp.

(JSC::ExecutableBase::destroy): Deleted.
(JSC::ExecutableBase::clearCode): Deleted.
(JSC::NativeExecutable::create): Deleted.
(JSC::NativeExecutable::destroy): Deleted.
(JSC::NativeExecutable::createStructure): Deleted.
(JSC::NativeExecutable::finishCreation): Deleted.
(JSC::NativeExecutable::NativeExecutable): Deleted.
(JSC::ScriptExecutable::ScriptExecutable): Deleted.
(JSC::ScriptExecutable::destroy): Deleted.
(JSC::ScriptExecutable::installCode): Deleted.
(JSC::ScriptExecutable::newCodeBlockFor): Deleted.
(JSC::ScriptExecutable::newReplacementCodeBlockFor): Deleted.
(JSC::setupLLInt): Deleted.
(JSC::setupJIT): Deleted.
(JSC::ScriptExecutable::prepareForExecutionImpl): Deleted.
(JSC::EvalExecutable::create): Deleted.
(JSC::EvalExecutable::EvalExecutable): Deleted.
(JSC::EvalExecutable::destroy): Deleted.
(JSC::ProgramExecutable::ProgramExecutable): Deleted.
(JSC::ProgramExecutable::destroy): Deleted.
(JSC::FunctionExecutable::FunctionExecutable): Deleted.
(JSC::FunctionExecutable::finishCreation): Deleted.
(JSC::FunctionExecutable::destroy): Deleted.
(JSC::samplingDescription): Deleted.
(JSC::EvalExecutable::visitChildren): Deleted.
(JSC::ProgramExecutable::checkSyntax): Deleted.
(JSC::ProgramExecutable::initializeGlobalProperties): Deleted.
(JSC::ProgramExecutable::visitChildren): Deleted.
(JSC::FunctionExecutable::baselineCodeBlockFor): Deleted.
(JSC::FunctionExecutable::visitChildren): Deleted.
(JSC::FunctionExecutable::fromGlobalCode): Deleted.
(JSC::WebAssemblyExecutable::WebAssemblyExecutable): Deleted.
(JSC::WebAssemblyExecutable::destroy): Deleted.
(JSC::WebAssemblyExecutable::visitChildren): Deleted.
(JSC::ExecutableBase::dump): Deleted.
(JSC::ExecutableBase::hashFor): Deleted.
(JSC::NativeExecutable::hashFor): Deleted.
(JSC::ScriptExecutable::hashFor): Deleted.

• runtime/ModuleProgramExecutable.h: Copied from Source/JavaScriptCore/runtime/Executable.h.

(JSC::isCall): Deleted.
(JSC::ExecutableBase::ExecutableBase): Deleted.
(JSC::ExecutableBase::finishCreation): Deleted.
(JSC::ExecutableBase::isEvalExecutable): Deleted.
(JSC::ExecutableBase::isFunctionExecutable): Deleted.
(JSC::ExecutableBase::isProgramExecutable): Deleted.
(JSC::ExecutableBase::isModuleProgramExecutable): Deleted.
(JSC::ExecutableBase::isHostFunction): Deleted.
(JSC::ExecutableBase::isWebAssemblyExecutable): Deleted.
(JSC::ExecutableBase::createStructure): Deleted.
(JSC::ExecutableBase::generatedJITCodeForCall): Deleted.
(JSC::ExecutableBase::generatedJITCodeForConstruct): Deleted.
(JSC::ExecutableBase::generatedJITCodeFor): Deleted.
(JSC::ExecutableBase::entrypointFor): Deleted.
(JSC::ExecutableBase::offsetOfJITCodeWithArityCheckFor): Deleted.
(JSC::ExecutableBase::offsetOfNumParametersFor): Deleted.
(JSC::ExecutableBase::hasJITCodeForCall): Deleted.
(JSC::ExecutableBase::hasJITCodeForConstruct): Deleted.
(JSC::ExecutableBase::hasJITCodeFor): Deleted.
(JSC::ExecutableBase::intrinsic): Deleted.
(JSC::ExecutableBase::intrinsicFor): Deleted.
(JSC::ScriptExecutable::source): Deleted.
(JSC::ScriptExecutable::sourceID): Deleted.
(JSC::ScriptExecutable::sourceURL): Deleted.
(JSC::ScriptExecutable::firstLine): Deleted.
(JSC::ScriptExecutable::setOverrideLineNumber): Deleted.
(JSC::ScriptExecutable::hasOverrideLineNumber): Deleted.
(JSC::ScriptExecutable::overrideLineNumber): Deleted.
(JSC::ScriptExecutable::lastLine): Deleted.
(JSC::ScriptExecutable::startColumn): Deleted.
(JSC::ScriptExecutable::endColumn): Deleted.
(JSC::ScriptExecutable::typeProfilingStartOffset): Deleted.
(JSC::ScriptExecutable::typeProfilingEndOffset): Deleted.
(JSC::ScriptExecutable::usesEval): Deleted.
(JSC::ScriptExecutable::usesArguments): Deleted.
(JSC::ScriptExecutable::isArrowFunctionContext): Deleted.
(JSC::ScriptExecutable::isStrictMode): Deleted.
(JSC::ScriptExecutable::derivedContextType): Deleted.
(JSC::ScriptExecutable::evalContextType): Deleted.
(JSC::ScriptExecutable::ecmaMode): Deleted.
(JSC::ScriptExecutable::setNeverInline): Deleted.
(JSC::ScriptExecutable::setNeverOptimize): Deleted.
(JSC::ScriptExecutable::setNeverFTLOptimize): Deleted.
(JSC::ScriptExecutable::setDidTryToEnterInLoop): Deleted.
(JSC::ScriptExecutable::setCanUseOSRExitFuzzing): Deleted.
(JSC::ScriptExecutable::neverInline): Deleted.
(JSC::ScriptExecutable::neverOptimize): Deleted.
(JSC::ScriptExecutable::neverFTLOptimize): Deleted.
(JSC::ScriptExecutable::didTryToEnterInLoop): Deleted.
(JSC::ScriptExecutable::isInliningCandidate): Deleted.
(JSC::ScriptExecutable::isOkToOptimize): Deleted.
(JSC::ScriptExecutable::canUseOSRExitFuzzing): Deleted.
(JSC::ScriptExecutable::addressOfDidTryToEnterInLoop): Deleted.
(JSC::ScriptExecutable::features): Deleted.
(JSC::ScriptExecutable::recordParse): Deleted.
(JSC::ScriptExecutable::finishCreation): Deleted.
(JSC::ScriptExecutable::prepareForExecution): Deleted.

• runtime/NativeExecutable.cpp: Copied from Source/JavaScriptCore/runtime/Executable.cpp.

(JSC::ExecutableBase::destroy): Deleted.
(JSC::ExecutableBase::clearCode): Deleted.
(JSC::ScriptExecutable::ScriptExecutable): Deleted.
(JSC::ScriptExecutable::destroy): Deleted.
(JSC::ScriptExecutable::installCode): Deleted.
(JSC::ScriptExecutable::newCodeBlockFor): Deleted.
(JSC::ScriptExecutable::newReplacementCodeBlockFor): Deleted.
(JSC::setupLLInt): Deleted.
(JSC::setupJIT): Deleted.
(JSC::ScriptExecutable::prepareForExecutionImpl): Deleted.
(JSC::EvalExecutable::create): Deleted.
(JSC::EvalExecutable::EvalExecutable): Deleted.
(JSC::EvalExecutable::destroy): Deleted.
(JSC::ProgramExecutable::ProgramExecutable): Deleted.
(JSC::ProgramExecutable::destroy): Deleted.
(JSC::ModuleProgramExecutable::ModuleProgramExecutable): Deleted.
(JSC::ModuleProgramExecutable::create): Deleted.
(JSC::ModuleProgramExecutable::destroy): Deleted.
(JSC::FunctionExecutable::FunctionExecutable): Deleted.
(JSC::FunctionExecutable::finishCreation): Deleted.
(JSC::FunctionExecutable::destroy): Deleted.
(JSC::samplingDescription): Deleted.
(JSC::EvalExecutable::visitChildren): Deleted.
(JSC::ProgramExecutable::checkSyntax): Deleted.
(JSC::ProgramExecutable::initializeGlobalProperties): Deleted.
(JSC::ProgramExecutable::visitChildren): Deleted.
(JSC::ModuleProgramExecutable::visitChildren): Deleted.
(JSC::FunctionExecutable::baselineCodeBlockFor): Deleted.
(JSC::FunctionExecutable::visitChildren): Deleted.
(JSC::FunctionExecutable::fromGlobalCode): Deleted.
(JSC::WebAssemblyExecutable::WebAssemblyExecutable): Deleted.
(JSC::WebAssemblyExecutable::destroy): Deleted.
(JSC::WebAssemblyExecutable::visitChildren): Deleted.
(JSC::ExecutableBase::dump): Deleted.
(JSC::ExecutableBase::hashFor): Deleted.
(JSC::ScriptExecutable::hashFor): Deleted.

• runtime/NativeExecutable.h: Copied from Source/JavaScriptCore/runtime/Executable.h.

(JSC::isCall): Deleted.
(JSC::ExecutableBase::ExecutableBase): Deleted.
(JSC::ExecutableBase::finishCreation): Deleted.
(JSC::ExecutableBase::isEvalExecutable): Deleted.
(JSC::ExecutableBase::isFunctionExecutable): Deleted.
(JSC::ExecutableBase::isProgramExecutable): Deleted.
(JSC::ExecutableBase::isModuleProgramExecutable): Deleted.
(JSC::ExecutableBase::isHostFunction): Deleted.
(JSC::ExecutableBase::isWebAssemblyExecutable): Deleted.
(JSC::ExecutableBase::createStructure): Deleted.
(JSC::ExecutableBase::generatedJITCodeForCall): Deleted.
(JSC::ExecutableBase::generatedJITCodeForConstruct): Deleted.
(JSC::ExecutableBase::generatedJITCodeFor): Deleted.
(JSC::ExecutableBase::entrypointFor): Deleted.
(JSC::ExecutableBase::offsetOfJITCodeWithArityCheckFor): Deleted.
(JSC::ExecutableBase::offsetOfNumParametersFor): Deleted.
(JSC::ExecutableBase::hasJITCodeForCall): Deleted.
(JSC::ExecutableBase::hasJITCodeForConstruct): Deleted.
(JSC::ExecutableBase::hasJITCodeFor): Deleted.
(JSC::ExecutableBase::intrinsic): Deleted.
(JSC::ExecutableBase::intrinsicFor): Deleted.
(JSC::ScriptExecutable::source): Deleted.
(JSC::ScriptExecutable::sourceID): Deleted.
(JSC::ScriptExecutable::sourceURL): Deleted.
(JSC::ScriptExecutable::firstLine): Deleted.
(JSC::ScriptExecutable::setOverrideLineNumber): Deleted.
(JSC::ScriptExecutable::hasOverrideLineNumber): Deleted.
(JSC::ScriptExecutable::overrideLineNumber): Deleted.
(JSC::ScriptExecutable::lastLine): Deleted.
(JSC::ScriptExecutable::startColumn): Deleted.
(JSC::ScriptExecutable::endColumn): Deleted.
(JSC::ScriptExecutable::typeProfilingStartOffset): Deleted.
(JSC::ScriptExecutable::typeProfilingEndOffset): Deleted.
(JSC::ScriptExecutable::usesEval): Deleted.
(JSC::ScriptExecutable::usesArguments): Deleted.
(JSC::ScriptExecutable::isArrowFunctionContext): Deleted.
(JSC::ScriptExecutable::isStrictMode): Deleted.
(JSC::ScriptExecutable::derivedContextType): Deleted.
(JSC::ScriptExecutable::evalContextType): Deleted.
(JSC::ScriptExecutable::ecmaMode): Deleted.
(JSC::ScriptExecutable::setNeverInline): Deleted.
(JSC::ScriptExecutable::setNeverOptimize): Deleted.
(JSC::ScriptExecutable::setNeverFTLOptimize): Deleted.
(JSC::ScriptExecutable::setDidTryToEnterInLoop): Deleted.
(JSC::ScriptExecutable::setCanUseOSRExitFuzzing): Deleted.
(JSC::ScriptExecutable::neverInline): Deleted.
(JSC::ScriptExecutable::neverOptimize): Deleted.
(JSC::ScriptExecutable::neverFTLOptimize): Deleted.
(JSC::ScriptExecutable::didTryToEnterInLoop): Deleted.
(JSC::ScriptExecutable::isInliningCandidate): Deleted.
(JSC::ScriptExecutable::isOkToOptimize): Deleted.
(JSC::ScriptExecutable::canUseOSRExitFuzzing): Deleted.
(JSC::ScriptExecutable::addressOfDidTryToEnterInLoop): Deleted.
(JSC::ScriptExecutable::features): Deleted.
(JSC::ScriptExecutable::recordParse): Deleted.
(JSC::ScriptExecutable::finishCreation): Deleted.
(JSC::ScriptExecutable::prepareForExecution): Deleted.

• runtime/ProgramExecutable.cpp: Copied from Source/JavaScriptCore/runtime/Executable.cpp.

(JSC::ExecutableBase::destroy): Deleted.
(JSC::ExecutableBase::clearCode): Deleted.
(JSC::NativeExecutable::create): Deleted.
(JSC::NativeExecutable::destroy): Deleted.
(JSC::NativeExecutable::createStructure): Deleted.
(JSC::NativeExecutable::finishCreation): Deleted.
(JSC::NativeExecutable::NativeExecutable): Deleted.
(JSC::ScriptExecutable::ScriptExecutable): Deleted.
(JSC::ScriptExecutable::destroy): Deleted.
(JSC::ScriptExecutable::installCode): Deleted.
(JSC::ScriptExecutable::newCodeBlockFor): Deleted.
(JSC::ScriptExecutable::newReplacementCodeBlockFor): Deleted.
(JSC::setupLLInt): Deleted.
(JSC::setupJIT): Deleted.
(JSC::ScriptExecutable::prepareForExecutionImpl): Deleted.
(JSC::EvalExecutable::create): Deleted.
(JSC::EvalExecutable::EvalExecutable): Deleted.
(JSC::EvalExecutable::destroy): Deleted.
(JSC::ModuleProgramExecutable::ModuleProgramExecutable): Deleted.
(JSC::ModuleProgramExecutable::create): Deleted.
(JSC::ModuleProgramExecutable::destroy): Deleted.
(JSC::FunctionExecutable::FunctionExecutable): Deleted.
(JSC::FunctionExecutable::finishCreation): Deleted.
(JSC::FunctionExecutable::destroy): Deleted.
(JSC::samplingDescription): Deleted.
(JSC::EvalExecutable::visitChildren): Deleted.
(JSC::ModuleProgramExecutable::visitChildren): Deleted.
(JSC::FunctionExecutable::baselineCodeBlockFor): Deleted.
(JSC::FunctionExecutable::visitChildren): Deleted.
(JSC::FunctionExecutable::fromGlobalCode): Deleted.
(JSC::WebAssemblyExecutable::WebAssemblyExecutable): Deleted.
(JSC::WebAssemblyExecutable::destroy): Deleted.
(JSC::WebAssemblyExecutable::visitChildren): Deleted.
(JSC::ExecutableBase::dump): Deleted.
(JSC::ExecutableBase::hashFor): Deleted.
(JSC::NativeExecutable::hashFor): Deleted.
(JSC::ScriptExecutable::hashFor): Deleted.

• runtime/ProgramExecutable.h: Copied from Source/JavaScriptCore/runtime/Executable.h.

(JSC::isCall): Deleted.
(JSC::ExecutableBase::ExecutableBase): Deleted.
(JSC::ExecutableBase::finishCreation): Deleted.
(JSC::ExecutableBase::isEvalExecutable): Deleted.
(JSC::ExecutableBase::isFunctionExecutable): Deleted.
(JSC::ExecutableBase::isProgramExecutable): Deleted.
(JSC::ExecutableBase::isModuleProgramExecutable): Deleted.
(JSC::ExecutableBase::isHostFunction): Deleted.
(JSC::ExecutableBase::isWebAssemblyExecutable): Deleted.
(JSC::ExecutableBase::createStructure): Deleted.
(JSC::ExecutableBase::generatedJITCodeForCall): Deleted.
(JSC::ExecutableBase::generatedJITCodeForConstruct): Deleted.
(JSC::ExecutableBase::generatedJITCodeFor): Deleted.
(JSC::ExecutableBase::entrypointFor): Deleted.
(JSC::ExecutableBase::offsetOfJITCodeWithArityCheckFor): Deleted.
(JSC::ExecutableBase::offsetOfNumParametersFor): Deleted.
(JSC::ExecutableBase::hasJITCodeForCall): Deleted.
(JSC::ExecutableBase::hasJITCodeForConstruct): Deleted.
(JSC::ExecutableBase::hasJITCodeFor): Deleted.
(JSC::ExecutableBase::intrinsic): Deleted.
(JSC::ExecutableBase::intrinsicFor): Deleted.
(JSC::ScriptExecutable::source): Deleted.
(JSC::ScriptExecutable::sourceID): Deleted.
(JSC::ScriptExecutable::sourceURL): Deleted.
(JSC::ScriptExecutable::firstLine): Deleted.
(JSC::ScriptExecutable::setOverrideLineNumber): Deleted.
(JSC::ScriptExecutable::hasOverrideLineNumber): Deleted.
(JSC::ScriptExecutable::overrideLineNumber): Deleted.
(JSC::ScriptExecutable::lastLine): Deleted.
(JSC::ScriptExecutable::startColumn): Deleted.
(JSC::ScriptExecutable::endColumn): Deleted.
(JSC::ScriptExecutable::typeProfilingStartOffset): Deleted.
(JSC::ScriptExecutable::typeProfilingEndOffset): Deleted.
(JSC::ScriptExecutable::usesEval): Deleted.
(JSC::ScriptExecutable::usesArguments): Deleted.
(JSC::ScriptExecutable::isArrowFunctionContext): Deleted.
(JSC::ScriptExecutable::isStrictMode): Deleted.
(JSC::ScriptExecutable::derivedContextType): Deleted.
(JSC::ScriptExecutable::evalContextType): Deleted.
(JSC::ScriptExecutable::ecmaMode): Deleted.
(JSC::ScriptExecutable::setNeverInline): Deleted.
(JSC::ScriptExecutable::setNeverOptimize): Deleted.
(JSC::ScriptExecutable::setNeverFTLOptimize): Deleted.
(JSC::ScriptExecutable::setDidTryToEnterInLoop): Deleted.
(JSC::ScriptExecutable::setCanUseOSRExitFuzzing): Deleted.
(JSC::ScriptExecutable::neverInline): Deleted.
(JSC::ScriptExecutable::neverOptimize): Deleted.
(JSC::ScriptExecutable::neverFTLOptimize): Deleted.
(JSC::ScriptExecutable::didTryToEnterInLoop): Deleted.
(JSC::ScriptExecutable::isInliningCandidate): Deleted.
(JSC::ScriptExecutable::isOkToOptimize): Deleted.
(JSC::ScriptExecutable::canUseOSRExitFuzzing): Deleted.
(JSC::ScriptExecutable::addressOfDidTryToEnterInLoop): Deleted.
(JSC::ScriptExecutable::features): Deleted.
(JSC::ScriptExecutable::recordParse): Deleted.
(JSC::ScriptExecutable::finishCreation): Deleted.
(JSC::ScriptExecutable::prepareForExecution): Deleted.

• runtime/SamplingProfiler.cpp:
• runtime/ScriptExecutable.cpp: Copied from Source/JavaScriptCore/runtime/Executable.cpp.

(JSC::ExecutableBase::destroy): Deleted.
(JSC::ExecutableBase::clearCode): Deleted.
(JSC::NativeExecutable::create): Deleted.
(JSC::NativeExecutable::destroy): Deleted.
(JSC::NativeExecutable::createStructure): Deleted.
(JSC::NativeExecutable::finishCreation): Deleted.
(JSC::NativeExecutable::NativeExecutable): Deleted.
(JSC::EvalExecutable::create): Deleted.
(JSC::EvalExecutable::EvalExecutable): Deleted.
(JSC::EvalExecutable::destroy): Deleted.
(JSC::ProgramExecutable::ProgramExecutable): Deleted.
(JSC::ProgramExecutable::destroy): Deleted.
(JSC::ModuleProgramExecutable::ModuleProgramExecutable): Deleted.
(JSC::ModuleProgramExecutable::create): Deleted.
(JSC::ModuleProgramExecutable::destroy): Deleted.
(JSC::FunctionExecutable::FunctionExecutable): Deleted.
(JSC::FunctionExecutable::finishCreation): Deleted.
(JSC::FunctionExecutable::destroy): Deleted.
(JSC::samplingDescription): Deleted.
(JSC::EvalExecutable::visitChildren): Deleted.
(JSC::ProgramExecutable::checkSyntax): Deleted.
(JSC::ProgramExecutable::initializeGlobalProperties): Deleted.
(JSC::ProgramExecutable::visitChildren): Deleted.
(JSC::ModuleProgramExecutable::visitChildren): Deleted.
(JSC::FunctionExecutable::baselineCodeBlockFor): Deleted.
(JSC::FunctionExecutable::visitChildren): Deleted.
(JSC::FunctionExecutable::fromGlobalCode): Deleted.
(JSC::WebAssemblyExecutable::WebAssemblyExecutable): Deleted.
(JSC::WebAssemblyExecutable::destroy): Deleted.
(JSC::WebAssemblyExecutable::visitChildren): Deleted.
(JSC::ExecutableBase::dump): Deleted.
(JSC::ExecutableBase::hashFor): Deleted.
(JSC::NativeExecutable::hashFor): Deleted.

• runtime/ScriptExecutable.h: Copied from Source/JavaScriptCore/runtime/Executable.h.

(): Deleted.
(JSC::isCall): Deleted.
(JSC::ExecutableBase::ExecutableBase): Deleted.
(JSC::ExecutableBase::finishCreation): Deleted.
(JSC::ExecutableBase::isEvalExecutable): Deleted.
(JSC::ExecutableBase::isFunctionExecutable): Deleted.
(JSC::ExecutableBase::isProgramExecutable): Deleted.
(JSC::ExecutableBase::isModuleProgramExecutable): Deleted.
(JSC::ExecutableBase::isHostFunction): Deleted.
(JSC::ExecutableBase::isWebAssemblyExecutable): Deleted.
(JSC::ExecutableBase::createStructure): Deleted.
(JSC::ExecutableBase::generatedJITCodeForCall): Deleted.
(JSC::ExecutableBase::generatedJITCodeForConstruct): Deleted.
(JSC::ExecutableBase::generatedJITCodeFor): Deleted.
(JSC::ExecutableBase::entrypointFor): Deleted.
(JSC::ExecutableBase::offsetOfJITCodeWithArityCheckFor): Deleted.
(JSC::ExecutableBase::offsetOfNumParametersFor): Deleted.
(JSC::ExecutableBase::hasJITCodeForCall): Deleted.
(JSC::ExecutableBase::hasJITCodeForConstruct): Deleted.
(JSC::ExecutableBase::hasJITCodeFor): Deleted.
(JSC::ExecutableBase::intrinsic): Deleted.
(JSC::ExecutableBase::intrinsicFor): Deleted.
(JSC::ScriptExecutable::prepareForExecution): Deleted.

• runtime/StringConstructor.cpp:
• runtime/StringPrototype.cpp:
• runtime/WebAssemblyExecutable.cpp: Copied from Source/JavaScriptCore/runtime/Executable.cpp.

(JSC::ExecutableBase::destroy): Deleted.
(JSC::ExecutableBase::clearCode): Deleted.
(JSC::NativeExecutable::create): Deleted.
(JSC::NativeExecutable::destroy): Deleted.
(JSC::NativeExecutable::createStructure): Deleted.
(JSC::NativeExecutable::finishCreation): Deleted.
(JSC::NativeExecutable::NativeExecutable): Deleted.
(JSC::ScriptExecutable::ScriptExecutable): Deleted.
(JSC::ScriptExecutable::destroy): Deleted.
(JSC::ScriptExecutable::installCode): Deleted.
(JSC::ScriptExecutable::newCodeBlockFor): Deleted.
(JSC::ScriptExecutable::newReplacementCodeBlockFor): Deleted.
(JSC::setupLLInt): Deleted.
(JSC::setupJIT): Deleted.
(JSC::ScriptExecutable::prepareForExecutionImpl): Deleted.
(JSC::EvalExecutable::create): Deleted.
(JSC::EvalExecutable::EvalExecutable): Deleted.
(JSC::EvalExecutable::destroy): Deleted.
(JSC::ProgramExecutable::ProgramExecutable): Deleted.
(JSC::ProgramExecutable::destroy): Deleted.
(JSC::ModuleProgramExecutable::ModuleProgramExecutable): Deleted.
(JSC::ModuleProgramExecutable::create): Deleted.
(JSC::ModuleProgramExecutable::destroy): Deleted.
(JSC::FunctionExecutable::FunctionExecutable): Deleted.
(JSC::FunctionExecutable::finishCreation): Deleted.
(JSC::FunctionExecutable::destroy): Deleted.
(JSC::samplingDescription): Deleted.
(JSC::EvalExecutable::visitChildren): Deleted.
(JSC::ProgramExecutable::checkSyntax): Deleted.
(JSC::ProgramExecutable::initializeGlobalProperties): Deleted.
(JSC::ProgramExecutable::visitChildren): Deleted.
(JSC::ModuleProgramExecutable::visitChildren): Deleted.
(JSC::FunctionExecutable::baselineCodeBlockFor): Deleted.
(JSC::FunctionExecutable::visitChildren): Deleted.
(JSC::FunctionExecutable::fromGlobalCode): Deleted.
(JSC::ExecutableBase::dump): Deleted.
(JSC::ExecutableBase::hashFor): Deleted.
(JSC::NativeExecutable::hashFor): Deleted.
(JSC::ScriptExecutable::hashFor): Deleted.

• runtime/WebAssemblyExecutable.h: Copied from Source/JavaScriptCore/runtime/Executable.h.

(JSC::isCall): Deleted.
(JSC::ExecutableBase::ExecutableBase): Deleted.
(JSC::ExecutableBase::finishCreation): Deleted.
(JSC::ExecutableBase::isEvalExecutable): Deleted.
(JSC::ExecutableBase::isFunctionExecutable): Deleted.
(JSC::ExecutableBase::isProgramExecutable): Deleted.
(JSC::ExecutableBase::isModuleProgramExecutable): Deleted.
(JSC::ExecutableBase::isHostFunction): Deleted.
(JSC::ExecutableBase::isWebAssemblyExecutable): Deleted.
(JSC::ExecutableBase::createStructure): Deleted.
(JSC::ExecutableBase::generatedJITCodeForCall): Deleted.
(JSC::ExecutableBase::generatedJITCodeForConstruct): Deleted.
(JSC::ExecutableBase::generatedJITCodeFor): Deleted.
(JSC::ExecutableBase::entrypointFor): Deleted.
(JSC::ExecutableBase::offsetOfJITCodeWithArityCheckFor): Deleted.
(JSC::ExecutableBase::offsetOfNumParametersFor): Deleted.
(JSC::ExecutableBase::hasJITCodeForCall): Deleted.
(JSC::ExecutableBase::hasJITCodeForConstruct): Deleted.
(JSC::ExecutableBase::hasJITCodeFor): Deleted.
(JSC::ExecutableBase::intrinsic): Deleted.
(JSC::ExecutableBase::intrinsicFor): Deleted.
(JSC::ScriptExecutable::source): Deleted.
(JSC::ScriptExecutable::sourceID): Deleted.
(JSC::ScriptExecutable::sourceURL): Deleted.
(JSC::ScriptExecutable::firstLine): Deleted.
(JSC::ScriptExecutable::setOverrideLineNumber): Deleted.
(JSC::ScriptExecutable::hasOverrideLineNumber): Deleted.
(JSC::ScriptExecutable::overrideLineNumber): Deleted.
(JSC::ScriptExecutable::lastLine): Deleted.
(JSC::ScriptExecutable::startColumn): Deleted.
(JSC::ScriptExecutable::endColumn): Deleted.
(JSC::ScriptExecutable::typeProfilingStartOffset): Deleted.
(JSC::ScriptExecutable::typeProfilingEndOffset): Deleted.
(JSC::ScriptExecutable::usesEval): Deleted.
(JSC::ScriptExecutable::usesArguments): Deleted.
(JSC::ScriptExecutable::isArrowFunctionContext): Deleted.
(JSC::ScriptExecutable::isStrictMode): Deleted.
(JSC::ScriptExecutable::derivedContextType): Deleted.
(JSC::ScriptExecutable::evalContextType): Deleted.
(JSC::ScriptExecutable::ecmaMode): Deleted.
(JSC::ScriptExecutable::setNeverInline): Deleted.
(JSC::ScriptExecutable::setNeverOptimize): Deleted.
(JSC::ScriptExecutable::setNeverFTLOptimize): Deleted.
(JSC::ScriptExecutable::setDidTryToEnterInLoop): Deleted.
(JSC::ScriptExecutable::setCanUseOSRExitFuzzing): Deleted.
(JSC::ScriptExecutable::neverInline): Deleted.
(JSC::ScriptExecutable::neverOptimize): Deleted.
(JSC::ScriptExecutable::neverFTLOptimize): Deleted.
(JSC::ScriptExecutable::didTryToEnterInLoop): Deleted.
(JSC::ScriptExecutable::isInliningCandidate): Deleted.
(JSC::ScriptExecutable::isOkToOptimize): Deleted.
(JSC::ScriptExecutable::canUseOSRExitFuzzing): Deleted.
(JSC::ScriptExecutable::addressOfDidTryToEnterInLoop): Deleted.
(JSC::ScriptExecutable::features): Deleted.
(JSC::ScriptExecutable::recordParse): Deleted.
(JSC::ScriptExecutable::finishCreation): Deleted.
(JSC::ScriptExecutable::prepareForExecution): Deleted.

Source/WebCore:

• ForwardingHeaders/runtime/Executable.h: Removed.
• ForwardingHeaders/runtime/FunctionExecutable.h: Copied from Source/WebCore/ForwardingHeaders/runtime/Executable.h.
• bindings/js/JSLazyEventListener.cpp:
• bindings/js/JSMainThreadExecStateInstrumentation.h:

12:40 PM Changeset in webkit [208062] by hyatt@apple.com

• 3 edits in trunk/Source/WebCore

[CSS Parser] Clean up gradient parsing
​https://bugs.webkit.org/show_bug.cgi?id=164139

Reviewed by Dean Jackson.

• css/CSSGradientValue.cpp:

(WebCore::positionFromValue):
(WebCore::CSSGradientValue::computeEndPoint):

• css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::consumeDeprecatedGradient):
(WebCore::CSSPropertyParserHelpers::consumeGradientColorStops):
(WebCore::CSSPropertyParserHelpers::consumeDeprecatedRadialGradient):
(WebCore::CSSPropertyParserHelpers::consumeRadialGradient):
(WebCore::CSSPropertyParserHelpers::consumeLinearGradient):

11:58 AM Changeset in webkit [208061] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[GTK] Upgrade HarfBuzz to version 1.3.3
​https://bugs.webkit.org/show_bug.cgi?id=162719

Patch by Frederic Wang <​fwang@igalia.com> on 2016-10-28
Reviewed by Michael Catanzaro.

• gtk/jhbuild.modules:

11:53 AM Changeset in webkit [208060] by dino@apple.com

• 2 edits in trunk/Source/WebCore

New CSS Parser should use Colors not RGBA32s
​https://bugs.webkit.org/show_bug.cgi?id=164124
<rdar://problem/29000373>

Reviewed by Darin Adler.

The old parser has moved from using RGBA32 values to using
Colors directly. This was so we could support ExtendedColors
via the new color() syntax.

Update the new CSS parser to do the same.

• css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::parseRGBParameters):
(WebCore::CSSPropertyParserHelpers::parseHSLParameters):
(WebCore::CSSPropertyParserHelpers::parseHexColor):
(WebCore::CSSPropertyParserHelpers::parseColorFunction):
(WebCore::CSSPropertyParserHelpers::consumeColor):

11:49 AM Changeset in webkit [208059] by dino@apple.com

• 2 edits in trunk/Source/WebCore

Allow new CSS parser to handle insertRule, etc via parseRule
​https://bugs.webkit.org/show_bug.cgi?id=164122
<rdar://problem/29000101>

Reviewed by Darin Adler.

Call the new CSS parser from CSSParser::parseRule if enabled. This
allows style added via the CSSOM insertRule to go through
the parser.

I tested this across our layout tests that use insertRule. It
works fine, but does cause some filter tests to fail. This is
because the new parser does not generate WebKitCSSFilterValues,
but I think the CSSFunctionValue is good enough. I'll remove
WebKitCSSFilterValue separately.

• css/parser/CSSParser.cpp:

(WebCore::CSSParser::parseRule): Call CSSParserImpl::parseRule.

11:34 AM Changeset in webkit [208058] by Simon Fraser

• 3 edits
  4 adds in trunk

Wrong blur radius for filter: drop-shadow()
​https://bugs.webkit.org/show_bug.cgi?id=163667

Reviewed by Darin Adler.

Source/WebCore:

The "stdDev" parameter to <feDropShadow> and <feGaussianBlur> represents the standard
deviation (σ) of the Gaussian blur function. CSS filters drop-shadow() and blur() follow
this with their radius parameter.

However, CSS box-shadow and text-shadow use 2σ to describe the blur radius, since this
is conveniently close to the number of pixels the effect of the blur extends out.

feDropShadow, which is used by non-accelerated filter: drop-shadow(), was using
the wrong blur radius because it passed its stdDev directly to ShadowBlur. ShadowBlur
was written for CSS box-shadow, so expected its input "blur radius" to be twice the
stdDev.

Tests: css3/filters/drop-shadow-blur-radius.html

svg/filters/feDropShadow-blur-radius.html

• platform/graphics/filters/FEDropShadow.cpp:

(WebCore::FEDropShadow::platformApplySoftware):

LayoutTests:

Mismatch tests to detect that the blurry area extends out from under a masking
element on top.

• css3/filters/drop-shadow-blur-radius-expected-mismatch.html: Added.
• css3/filters/drop-shadow-blur-radius.html: Added.
• svg/filters/feDropShadow-blur-radius-expected-mismatch.html: Added.
• svg/filters/feDropShadow-blur-radius.html: Added.

11:09 AM Changeset in webkit [208057] by commit-queue@webkit.org

• 62 edits
  6 adds in trunk

Expose RTCPeerConnection unprefixed
​https://bugs.webkit.org/show_bug.cgi?id=164060

Patch by Youenn Fablet <​youenn@apple.com> on 2016-10-28
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/webrtc/datachannel-emptystring-expected.txt: Added.
• web-platform-tests/webrtc/no-media-call-expected.txt: Added.
• web-platform-tests/webrtc/promises-call-expected.txt: Added.
• web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt: Added.
• web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-idl-expected.txt: Added.
• web-platform-tests/webrtc/simplecall-expected.txt: Added.

Source/WebCore:

Covered by rebased and activated tests.

• Modules/mediastream/RTCPeerConnection.idl:

LayoutTests:

• TestExpectations:
• fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
• fast/mediastream/RTCPeerConnection-add-removeTrack-expected.txt:
• fast/mediastream/RTCPeerConnection-add-removeTrack.html:
• fast/mediastream/RTCPeerConnection-addIceCandidate.html:
• fast/mediastream/RTCPeerConnection-addTrack-reuse-sender.html:
• fast/mediastream/RTCPeerConnection-addTransceiver.html:
• fast/mediastream/RTCPeerConnection-closed-state-expected.txt:
• fast/mediastream/RTCPeerConnection-closed-state.html:
• fast/mediastream/RTCPeerConnection-createAnswer.html:
• fast/mediastream/RTCPeerConnection-createOffer.html:
• fast/mediastream/RTCPeerConnection-datachannel.html:
• fast/mediastream/RTCPeerConnection-dtmf.html:
• fast/mediastream/RTCPeerConnection-events.html:
• fast/mediastream/RTCPeerConnection-expected.txt:
• fast/mediastream/RTCPeerConnection-getConfiguration.html:
• fast/mediastream/RTCPeerConnection-have-local-offer.html:
• fast/mediastream/RTCPeerConnection-have-local-pranswer.html:
• fast/mediastream/RTCPeerConnection-have-remote-offer.html:
• fast/mediastream/RTCPeerConnection-have-remote-pranswer.html:
• fast/mediastream/RTCPeerConnection-ice-expected.txt:
• fast/mediastream/RTCPeerConnection-ice.html:
• fast/mediastream/RTCPeerConnection-icecandidate-event.html:
• fast/mediastream/RTCPeerConnection-iceconnectionstatechange-event.html:
• fast/mediastream/RTCPeerConnection-inspect-answer.html:
• fast/mediastream/RTCPeerConnection-inspect-offer.html:
• fast/mediastream/RTCPeerConnection-js-built-ins-check-this-expected.txt:
• fast/mediastream/RTCPeerConnection-js-built-ins-check-this.html:
• fast/mediastream/RTCPeerConnection-legacy-stream-based-api.html:
• fast/mediastream/RTCPeerConnection-localDescription.html:
• fast/mediastream/RTCPeerConnection-media-setup-callbacks-single-dialog.html:
• fast/mediastream/RTCPeerConnection-media-setup-single-dialog.html:
• fast/mediastream/RTCPeerConnection-media-setup-two-dialogs.html:
• fast/mediastream/RTCPeerConnection-more-media-to-negotiate.html:
• fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
• fast/mediastream/RTCPeerConnection-overloaded-operations-expected.txt:
• fast/mediastream/RTCPeerConnection-overloaded-operations-params-expected.txt:
• fast/mediastream/RTCPeerConnection-overloaded-operations-params.html:
• fast/mediastream/RTCPeerConnection-overloaded-operations.html:
• fast/mediastream/RTCPeerConnection-remoteDescription.html:
• fast/mediastream/RTCPeerConnection-remotely-assigned-transceiver-mid.html:
• fast/mediastream/RTCPeerConnection-setLocalDescription-offer.html:
• fast/mediastream/RTCPeerConnection-setRemoteDescription-offer.html:
• fast/mediastream/RTCPeerConnection-stable.html:
• fast/mediastream/RTCPeerConnection-stats-expected.txt:
• fast/mediastream/RTCPeerConnection-stats.html:
• fast/mediastream/RTCPeerConnection-statsSelector-expected.txt:
• fast/mediastream/RTCPeerConnection-statsSelector.html:
• fast/mediastream/RTCPeerConnection.html:
• fast/mediastream/RTCRtpSender-replaceTrack.html:
• fast/mediastream/RTCTrackEvent-constructor.html:
• platform/efl/TestExpectations:
• platform/efl/js/dom/global-constructors-attributes-expected.txt:
• platform/gtk/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
• platform/mac/js/dom/global-constructors-attributes-expected.txt:
• platform/win/TestExpectations:

10:52 AM Changeset in webkit [208056] by mark.lam@apple.com

• 4 edits in branches/safari-602-branch/Source/JavaScriptCore

Merge r208018. rdar://problem/28962887, rdar://problem/28962912

2016-10-27 Mark Lam <​mark.lam@apple.com>

JSFunction::put() should not allow caching of lazily reified properties.
​https://bugs.webkit.org/show_bug.cgi?id=164081

Reviewed by Geoffrey Garen.

It is incorrect for JSFunction::put() to return PutPropertySlots that indicates
that its lazily reified properties (e.g. .caller, and .arguments) are cacheable.
The reason for this is:

1. Currently, a cacheable put may only consist of the following types of put operations:
   1. putting a new property at an offset in the object storage.
   2. changing the value of an existing property at an offset in the object storage.
   3. invoking the setter for a property at an offset in the object storage.

Returning a PutPropertySlot that indicates the property is cacheable means that
the property put must be one of the above operations.

For lazily reified properties, JSFunction::put() implements complex conditional
behavior that is different than the set of cacheable put operations above.
Hence, it should not claim that the property put is cacheable.

2. Cacheable puts are cached on the original structure of the object before the put operation.

Reifying a lazy property will trigger a structure transition. Even though
subsequent puts to such a property may be cacheable after the structure
transition, it is incorrect to indicate that the property put is cacheable
because the caching is on the original structure, not the new transitioned
structure.

Also fixed some missing exception checks.

• jit/JITOperations.cpp:
• runtime/JSFunction.cpp: (JSC::JSFunction::put): (JSC::JSFunction::reifyLazyPropertyIfNeeded): (JSC::JSFunction::reifyBoundNameIfNeeded):
• runtime/JSFunction.h:

10:42 AM Changeset in webkit [208055] by hyatt@apple.com

• 4 edits in trunk/Source/WebCore

[CSS Parser] Support the marquee properties
​https://bugs.webkit.org/show_bug.cgi?id=164132

Reviewed by Zalan Bujtas.

• css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeWebkitMarqueeIncrement):
(WebCore::consumeWebkitMarqueeRepetition):
(WebCore::consumeWebkitMarqueeSpeed):
(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::CSSPropertyParser::parseShorthand):

10:41 AM Changeset in webkit [208054] by hyatt@apple.com

• 2 edits in trunk/LayoutTests

Fix busted layout test from previous check-in.

• fast/multicol/column-box-alignment-rtl-expected.html:

10:15 AM Changeset in webkit [208053] by Csaba Osztrogonác

• 2 edits in trunk/JSTests

Skip JSTests/microbenchmarks/dense-set.js on memory limited devices
​https://bugs.webkit.org/show_bug.cgi?id=164128

Reviewed by Mark Lam.

• microbenchmarks/dense-set.js:

9:37 AM Changeset in webkit [208052] by caitp@igalia.com

• 29 edits
  16 adds in trunk

[JSC] implement runtime for async functions
​https://bugs.webkit.org/show_bug.cgi?id=163760

Reviewed by Yusuke Suzuki.

JSTests:

• stress/async-await-basic.js: Added.

(shouldBe):
(shouldBeAsync):
(shouldThrow):
(shouldThrowAsync):
(shouldThrowSyntaxError):
(let.AsyncFunction.async):
(async.asyncFunctionForProto):
(Object.getPrototypeOf.async):
(Object.getPrototypeOf.async.method):
(async):
(async.method):
(async.asyncNonConstructorDecl):
(shouldThrow.new.async):
(shouldThrow.new.async.nonConstructor):
(async.asyncDecl):
(async.f):
(MyError):
(async.asyncDeclThrower):
(shouldThrowAsync.async):
(resolveLater):
(rejectLater):
(async.resumeAfterNormal):
(O.async.resumeAfterNormal):
(resumeAfterNormalArrow.async):
(async.resumeAfterThrow):
(O.async.resumeAfterThrow):
(resumeAfterThrowArrow.async):
(catch):

• stress/async-await-module-reserved-word.js: Added.

(shouldThrow):
(SyntaxError.Canstring_appeared_hereawait.checkModuleSyntaxError.String.raw.await):
(checkModuleSyntaxError.String.raw.await):
(checkModuleSyntaxError.String.raw.async.await):
(SyntaxError.Cannot.declare.named):

• stress/async-await-mozilla.js: Added.

(shouldBe):
(shouldBeAsync):
(shouldThrow):
(shouldThrowAsync):
(assert):
(shouldThrowSyntaxError):
(mozSemantics.async.empty):
(mozSemantics.async.simpleReturn):
(mozSemantics.async.simpleAwait):
(mozSemantics.async.simpleAwaitAsync):
(mozSemantics.async.returnOtherAsync):
(mozSemantics.async.simpleThrower):
(mozSemantics.async.delegatedThrower):
(mozSemantics.async.tryCatch):
(mozSemantics.async.tryCatchThrow):
(mozSemantics.async.wellFinally):
(mozSemantics.async.finallyMayFail):
(mozSemantics.async.embedded.async.inner):
(mozSemantics.async.embedded):
(mozSemantics.async.fib):
(mozSemantics.async.isOdd.async.isEven):
(mozSemantics.async.isOdd):
(mozSemantics.hardcoreFib.async.fib2):
(mozSemantics.namedAsyncExpr.async.simple):
(mozSemantics.async.executionOrder.async.first):
(mozSemantics.async.executionOrder.async.second):
(mozSemantics.async.executionOrder.async.third):
(mozSemantics.async.executionOrder):
(mozSemantics.async.miscellaneous):
(mozSemantics.thrower):
(mozSemantics.async.defaultArgs):
(mozSemantics.shouldThrow):
(mozSemantics):
(mozMethods.X):
(mozMethods.X.prototype.async.getValue):
(mozMethods.X.prototype.setValue):
(mozMethods.X.prototype.async.increment):
(mozMethods.X.prototype.async.getBaseClassName):
(mozMethods.X.async.getStaticValue):
(mozMethods.Y.prototype.async.getBaseClassName):
(mozMethods.Y):
(mozFunctionNameInferrence.async.test):
(mozSyntaxErrors):

• stress/async-await-reserved-word.js: Added.

(assert):
(shouldThrowSyntaxError):
(AsyncFunction.async):

• stress/async_arrow_functions_lexical_arguments_binding.js: Added.

(shouldBe):
(shouldBeAsync):
(shouldThrowAsync):
(noArgumentsArrow2.async):

• stress/async_arrow_functions_lexical_new.target_binding.js: Added.

(shouldBe):
(shouldBeAsync):
(shouldThrowAsync):
(C1):
(C2):
(shouldThrowAsync.async):

• stress/async_arrow_functions_lexical_super_binding.js: Added.

(shouldBe):
(shouldBeAsync):
(BaseClass.prototype.baseClassValue):
(BaseClass.prototype.get property):
(BaseClass):
(ChildClass.prototype.asyncSuperProp):
(ChildClass.prototype.asyncSuperProp2):
(ChildClass):
(ChildClass2):

• stress/async_arrow_functions_lexical_this_binding.js: Added.

(shouldBe):
(shouldBeAsync):
(d.y):

Source/JavaScriptCore:

Async functions generate bytecode equivalent to the following, which is
highly dependent on the Generator implementation:

`
Before translation:
async function asyncfn() {}

After translation:
function asyncfn() {

let generator = {

@generatorNext: function(@generator, @generatorState, @generatorValue, @generatorResumeMode, @generatorFrameState) {

Body of async function

},
@generatorState: 0,
@generatorThis: this,
@generatorFrameState: <frame state>,

};
return @asyncFunctionResume(generator, undefined, GeneratorResumeMode::NormalMode);

}
`

Await Expressions are equivalent to non-delegating Yield expressions, and emit identical bytecode.

There are some caveats to be addressed later:

1) the op_to_this is always performed, whether it's used or not, like normal generators. (​https://bugs.webkit.org/show_bug.cgi?id=151586)

2) for async arrow functions, the home object is always stored on the "body" function, regardless of whether it's needed or
not, for the same reason as #1 (and should also be fixed as part of ​https://bugs.webkit.org/show_bug.cgi?id=151586)

• CMakeLists.txt:
• DerivedSources.make:
• JavaScriptCore.xcodeproj/project.pbxproj:
• builtins/AsyncFunctionPrototype.js: Added.

(asyncFunctionResume):

• bytecode/BytecodeList.json:
• bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

• bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):

• bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::isArrowFunction):

• bytecode/UnlinkedFunctionExecutable.h:
• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitNewFunctionExpressionCommon):
(JSC::BytecodeGenerator::emitNewArrowFunctionExpression):
(JSC::BytecodeGenerator::emitNewFunction):

• bytecompiler/NodesCodegen.cpp:

(JSC::FunctionNode::emitBytecode):

• jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

• jit/JIT.h:
• jit/JITOpcodes.cpp:

(JSC::JIT::emitNewFuncCommon):
(JSC::JIT::emit_op_new_async_func):
(JSC::JIT::emitNewFuncExprCommon):
(JSC::JIT::emit_op_new_async_func_exp):

• jit/JITOperations.cpp:
• jit/JITOperations.h:
• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

• llint/LLIntSlowPaths.h:
• llint/LowLevelInterpreter.asm:
• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseInner):
(JSC::Parser<LexerType>::parseAsyncFunctionSourceElements):
(JSC::Parser<LexerType>::parseFunctionInfo):

• parser/Parser.h:

(JSC::Scope::setSourceParseMode):

• parser/ParserModes.h:

(JSC::isGeneratorOrAsyncFunctionBodyParseMode):
(JSC::isGeneratorOrAsyncFunctionWrapperParseMode):

• runtime/AsyncFunctionConstructor.cpp: Added.

(JSC::AsyncFunctionConstructor::AsyncFunctionConstructor):
(JSC::AsyncFunctionConstructor::finishCreation):
(JSC::callAsyncFunctionConstructor):
(JSC::constructAsyncFunctionConstructor):
(JSC::AsyncFunctionConstructor::getCallData):
(JSC::AsyncFunctionConstructor::getConstructData):

• runtime/AsyncFunctionConstructor.h: Added.

(JSC::AsyncFunctionConstructor::create):
(JSC::AsyncFunctionConstructor::createStructure):

• runtime/AsyncFunctionPrototype.cpp: Added.

(JSC::AsyncFunctionPrototype::AsyncFunctionPrototype):
(JSC::AsyncFunctionPrototype::finishCreation):

• runtime/AsyncFunctionPrototype.h: Added.

(JSC::AsyncFunctionPrototype::create):
(JSC::AsyncFunctionPrototype::createStructure):

• runtime/FunctionConstructor.cpp:

(JSC::constructFunctionSkippingEvalEnabledCheck):

• runtime/FunctionConstructor.h:
• runtime/JSAsyncFunction.cpp: Added.

(JSC::JSAsyncFunction::JSAsyncFunction):
(JSC::JSAsyncFunction::createImpl):
(JSC::JSAsyncFunction::create):
(JSC::JSAsyncFunction::createWithInvalidatedReallocationWatchpoint):

• runtime/JSAsyncFunction.h: Added.

(JSC::JSAsyncFunction::allocationSize):
(JSC::JSAsyncFunction::createStructure):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

• runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::lazyAsyncFunctionStructure):
(JSC::JSGlobalObject::asyncFunctionPrototype):
(JSC::JSGlobalObject::asyncFunctionPrototypeConcurrently):
(JSC::JSGlobalObject::asyncFunctionStructure):
(JSC::JSGlobalObject::asyncFunctionStructureConcurrently):

9:23 AM Changeset in webkit [208051] by hyatt@apple.com

• 9 edits in trunk/Source/WebCore

[CSS Parser] Miscellaneous bug fixes
​https://bugs.webkit.org/show_bug.cgi?id=164131

Reviewed by Zalan Bujtas.

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

• css/CSSPropertyNames.in:

The prefix was incorrectly dropped from -webkit-column-progression.
Put it back.

• css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertPositionComponent):
(WebCore::StyleBuilderConverter::convertObjectPosition):
Fix object-position parsing so that the position components can
be ids.

• css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyValueContent):
The new parser doesn't make a list for content:none, since none can't be
a component of a list anyway. Add code to handle this case in the
apply function.

• css/parser/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
Put the prefix back on -webkit-column-progression.

• css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):
Same.

• css/parser/CSSParserImpl.cpp:

(WebCore::CSSParserImpl::parsePageSelector):
Make sure match type is checked, since our code asserts if it isn't.

• css/parser/CSSPropertyParser.cpp:

(WebCore::validWidthOrHeightKeyword):
(WebCore::consumeLineGrid):
(WebCore::CSSPropertyParser::parseSingleValue):
Add support for the line-grid properties and for -webkit-nbsp-mode.

9:14 AM Changeset in webkit [208050] by Matt Baker

• 1 edit
  4 adds in trunk/Source/WebInspectorUI

Unreviewed, worker document images added

• UserInterface/Images/WorkerDocument.png: Added.
• UserInterface/Images/WorkerDocument@2x.png: Added.
• UserInterface/Images/WorkerDocumentLarge.png: Added.
• UserInterface/Images/WorkerDocumentLarge@2x.png: Added.

8:39 AM Changeset in webkit [208049] by Antti Koivisto

• 7 edits in trunk

Always use iOS preload behavior
​https://bugs.webkit.org/show_bug.cgi?id=164127

Reviewed by Andreas Kling.

Source/WebCore:

On non-iOS platforms we were delaying issuing lower priority preload (images mostly) until document has body.
This should be unnecessary as networking layer prioritization should ensure higher priority resources are
loaded earlier. Testing on iOS has showed that more aggressive behavior is a win.

This patch switches to iOS behavior on all platforms (and simplified the logic).

• html/parser/HTMLResourcePreloader.cpp:

(WebCore::HTMLResourcePreloader::preload):

• loader/LinkLoader.cpp:

(WebCore::LinkLoader::preloadIfNeeded):

• loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::performPostLoadActions):
(WebCore::CachedResourceLoader::preload):
(WebCore::CachedResourceLoader::isPreloaded):
(WebCore::CachedResourceLoader::checkForPendingPreloads): Deleted.
(WebCore::CachedResourceLoader::requestPreload): Deleted.
(WebCore::CachedResourceLoader::clearPendingPreloads): Deleted.

• loader/cache/CachedResourceLoader.h:

LayoutTests:

• http/tests/webgl/1.0.2/readPixelsBadArgs-expected.txt:

8:11 AM Changeset in webkit [208048] by Antti Koivisto

• 2 edits in trunk/Source/WebKit2

Enable CFNetwork connection cache fast lane for WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=164129

Reviewed by Andreas Kling.

The idea of this feature is keep a connection free for higher priority requests so low-priority
image loads can't take all the available connections.

We have this enabled on WK1 but not on WK2. See what enabling it does for performance in bots.

• NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::initializeNetworkSettings):

Based on code inspection setting kHTTPMinimumFastLanePriority is not sufficient to enable this feature,
kHTTPNumFastLanes needs also be set to a non-zero value. Use the same constants as WK1.
Also enable this on Mac to unify behavior.

7:21 AM Changeset in webkit [208047] by Csaba Osztrogonác

• 3 edits in trunk/JSTests

Skip 2 JS stress tests on memory limited devices
​https://bugs.webkit.org/show_bug.cgi?id=164125

Unreviewed quick fix to unbreak JSCOnly ARM bots as soon as possible.

• stress/joined-strings-should-not-exceed-max-string-length.js:
• stress/string-prototype-replace-should-throw-out-of-memory-error-when-using-too-much-memory.js:

6:59 AM Changeset in webkit [208046] by commit-queue@webkit.org

• 15 edits
  1 copy
  5 adds in trunk

[Fetch] Ensure redirection count is no more than 20 in case of cross origin requests
​https://bugs.webkit.org/show_bug.cgi?id=164117

Patch by Youenn Fablet <​youenn@apple.com> on 2016-10-28
Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Adding new tests.
Split redirect.py in two different scripts.
redirect.py is to be used when simple redirections are needed.
redirect-count.py is to be used when the number of redirections is tested.

redirect.py no longer needs the count parameter.
This explains rebasing of the existing tests.

• web-platform-tests/fetch/api/basic/mode-same-origin-expected.txt:
• web-platform-tests/fetch/api/basic/mode-same-origin-worker-expected.txt:
• web-platform-tests/fetch/api/cors/cors-redirect-credentials-expected.txt:
• web-platform-tests/fetch/api/cors/cors-redirect-credentials-worker-expected.txt:
• web-platform-tests/fetch/api/redirect/redirect-count-cross-origin-expected.txt: Added.
• web-platform-tests/fetch/api/redirect/redirect-count-cross-origin-worker-expected.txt: Added.
• web-platform-tests/fetch/api/redirect/redirect-count-cross-origin-worker.html: Added.
• web-platform-tests/fetch/api/redirect/redirect-count-cross-origin.html: Added.
• web-platform-tests/fetch/api/redirect/redirect-count-cross-origin.js: Added.

(redirectCount):

• web-platform-tests/fetch/api/redirect/redirect-count-expected.txt:
• web-platform-tests/fetch/api/redirect/redirect-count-worker-expected.txt:
• web-platform-tests/fetch/api/redirect/redirect-count.js:

(redirectCount):

• web-platform-tests/fetch/api/request/request-cache-only-if-cached-expected.txt:
• web-platform-tests/fetch/api/resources/redirect-count.py: Copied from LayoutTests/imported/w3c/web-platform-tests/fetch/api/resources/redirect.py.

(main):

• web-platform-tests/fetch/api/resources/redirect.py:

(main):

Source/WebCore:

Tests: imported/w3c/web-platform-tests/fetch/api/redirect/redirect-count-cross-origin-worker.html

imported/w3c/web-platform-tests/fetch/api/redirect/redirect-count-cross-origin.html

Introducing a ResourceLoaderOptions that defines the maximum redirection count.
By default, it is set to 20 as per fetch specification.

This option is used by SubresourceLoader to cancel load if its redirection count is above that maximum.
DocumentThreadableLoader stopping redirections to make preflight if needed, it now uses the maxRedirectCount loader option to ensure
that the total number of redirections is 20.

• loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::redirectReceived):

• loader/ResourceLoaderOptions.h:
• loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequestInternal):

• loader/SubresourceLoader.h:

5:36 AM Changeset in webkit [208045] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

generate-bindings-all.pl should recompile supplemented IDL if its supplemental IDL are added or removed
​https://bugs.webkit.org/show_bug.cgi?id=164054

Patch by Fujii Hironori <Fujii Hironori> on 2016-10-28
Reviewed by Michael Catanzaro.

generate-bindings-all.pl determines which IDL to recompile by
comparing timestamps of generated files, source IDL and its
dependencies. But this is not enough. If a new supplemental IDL
is added, its supplemented IDL needs to be recompiled even though
the timestamp of the supplemental IDL is older than the
generated files.

• bindings/scripts/generate-bindings-all.pl: Read supplemental

dependency file both before and after invoking preprocess-idls.pl.
Recompile IDL files if its supplemental dependencies are added or
removed.

5:24 AM Changeset in webkit [208044] by commit-queue@webkit.org

• 2 edits in trunk

[CMake] Changing enabled features should trigger recompiling all IDL
​https://bugs.webkit.org/show_bug.cgi?id=164121

Patch by Fujii Hironori <Fujii Hironori> on 2016-10-28
Reviewed by Michael Catanzaro.

Changing enabled features should trigger recompiling all IDL
because some of them use #if. generate-bindings-all.pl was
introduced in <​http://trac.webkit.org/changeset/207617>. Before
this change, updating supplemental_dependency.tmp triggered
recompiling all IDL. Changing enabled features usually involves
adding or removing IDL files. As the result, all IDL would be
recompiled. After the change, adding or removing IDL does not
trigger recompiling all IDL. So, we need to explicitly trigger
recompiling all IDL if enabled features are changed.

• Source/cmake/WebKitMacros.cmake(GENERATE_BINDINGS): Added

cmakeconfig.h to extra dependencies.

4:14 AM Changeset in webkit [208043] by commit-queue@webkit.org

• 9 edits in trunk/Source/WebCore

PeerMediaDescription does not need to be refcounted
​https://bugs.webkit.org/show_bug.cgi?id=164059

Patch by Youenn Fablet <​youenn@apple.com> on 2016-10-28
Reviewed by Darin Adler.

No change of behavior.

• Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::MediaEndpointPeerConnection::createOfferTask):
(WebCore::MediaEndpointPeerConnection::createAnswerTask):
(WebCore::createSourceMap):
(WebCore::MediaEndpointPeerConnection::setLocalDescriptionTask):
(WebCore::MediaEndpointPeerConnection::setRemoteDescriptionTask):
(WebCore::MediaEndpointPeerConnection::addIceCandidateTask):
(WebCore::MediaEndpointPeerConnection::gotIceCandidate):

• Modules/mediastream/MediaEndpointPeerConnection.h:
• Modules/mediastream/SDPProcessor.cpp:

(WebCore::configurationFromJSON):
(WebCore::configurationToJSON):
(WebCore::SDPProcessor::generateCandidateLine):
(WebCore::SDPProcessor::parseCandidateLine):

• platform/mediastream/IceCandidate.h:
• platform/mediastream/MediaEndpointSessionConfiguration.h:

(WebCore::MediaEndpointSessionConfiguration::mediaDescriptions):
(WebCore::MediaEndpointSessionConfiguration::addMediaDescription):
(WebCore::MediaEndpointSessionConfiguration::clone):

• platform/mediastream/PeerMediaDescription.h:

(WebCore::PeerMediaDescription::addPayload):
(WebCore::PeerMediaDescription::addSsrc):
(WebCore::PeerMediaDescription::clearSsrcs):
(WebCore::PeerMediaDescription::addIceCandidate):
(WebCore::PeerMediaDescription::create): Deleted.
(WebCore::PeerMediaDescription::~PeerMediaDescription): Deleted.
(WebCore::PeerMediaDescription::type): Deleted.
(WebCore::PeerMediaDescription::setType): Deleted.
(WebCore::PeerMediaDescription::port): Deleted.
(WebCore::PeerMediaDescription::setPort): Deleted.
(WebCore::PeerMediaDescription::address): Deleted.
(WebCore::PeerMediaDescription::setAddress): Deleted.
(WebCore::PeerMediaDescription::mode): Deleted.
(WebCore::PeerMediaDescription::setMode): Deleted.
(WebCore::PeerMediaDescription::mid): Deleted.
(WebCore::PeerMediaDescription::setMid): Deleted.
(WebCore::PeerMediaDescription::payloads): Deleted.
(WebCore::PeerMediaDescription::setPayloads): Deleted.
(WebCore::PeerMediaDescription::rtcpMux): Deleted.
(WebCore::PeerMediaDescription::setRtcpMux): Deleted.
(WebCore::PeerMediaDescription::rtcpAddress): Deleted.
(WebCore::PeerMediaDescription::setRtcpAddress): Deleted.
(WebCore::PeerMediaDescription::rtcpPort): Deleted.
(WebCore::PeerMediaDescription::setRtcpPort): Deleted.
(WebCore::PeerMediaDescription::mediaStreamId): Deleted.
(WebCore::PeerMediaDescription::setMediaStreamId): Deleted.
(WebCore::PeerMediaDescription::mediaStreamTrackId): Deleted.
(WebCore::PeerMediaDescription::setMediaStreamTrackId): Deleted.
(WebCore::PeerMediaDescription::dtlsSetup): Deleted.
(WebCore::PeerMediaDescription::setDtlsSetup): Deleted.
(WebCore::PeerMediaDescription::dtlsFingerprintHashFunction): Deleted.
(WebCore::PeerMediaDescription::setDtlsFingerprintHashFunction): Deleted.
(WebCore::PeerMediaDescription::dtlsFingerprint): Deleted.
(WebCore::PeerMediaDescription::setDtlsFingerprint): Deleted.
(WebCore::PeerMediaDescription::cname): Deleted.
(WebCore::PeerMediaDescription::setCname): Deleted.
(WebCore::PeerMediaDescription::ssrcs): Deleted.
(WebCore::PeerMediaDescription::iceUfrag): Deleted.
(WebCore::PeerMediaDescription::setIceUfrag): Deleted.
(WebCore::PeerMediaDescription::icePassword): Deleted.
(WebCore::PeerMediaDescription::setIcePassword): Deleted.
(WebCore::PeerMediaDescription::iceCandidates): Deleted.
(WebCore::PeerMediaDescription::clone): Deleted.
(WebCore::PeerMediaDescription::PeerMediaDescription): Deleted.

• platform/mediastream/mac/MediaEndpointMac.cpp:

(WebCore::MediaEndpointMac::addRemoteCandidate):
(WebCore::MediaEndpointMac::OnIceCandidate):

• platform/mediastream/mac/MediaEndpointMac.h:
• platform/mediastream/openwebrtc/MediaEndpointOwr.cpp:

(WebCore::MediaEndpointOwr::updateSendConfiguration):

• platform/mediastream/openwebrtc/MediaEndpointOwr.h:
• platform/mock/MockMediaEndpoint.cpp:

(WebCore::MockMediaEndpoint::updateConfigurationMids):

2:40 AM Changeset in webkit [208042] by commit-queue@webkit.org

• 25 edits
  4 copies
  4 adds in trunk

[Modern Media Controls] Media Controller: scrubbing support
​https://bugs.webkit.org/show_bug.cgi?id=163726
<rdar://problem/27989481>

Patch by Antoine Quint <Antoine Quint> on 2016-10-28
Reviewed by Dean Jackson.

Source/WebCore:

We introduce the ScrubberSupport class which brings support for scrubbing the media
by interacting with the scrubber in the media controls and correctly reflecting
the media's current time as set via the media API.

Tests: media/modern-media-controls/scrubber-support/scrubber-support-click.html

media/modern-media-controls/scrubber-support/scrubber-support-drag.html
media/modern-media-controls/scrubber-support/scrubber-support-media-api.html

• Modules/modern-media-controls/js-files:
• Modules/modern-media-controls/media/media-controller.js:

(MediaController):

• Modules/modern-media-controls/media/scrubbing-support.js: Added.

(ScrubbingSupport.prototype.get control):
(ScrubbingSupport.prototype.get mediaEvents):
(ScrubbingSupport.prototype.controlValueWillStartChanging):
(ScrubbingSupport.prototype.controlValueDidChange):
(ScrubbingSupport.prototype.controlValueDidStopChanging):
(ScrubbingSupport.prototype.syncControl):
(ScrubbingSupport):

• WebCore.xcodeproj/project.pbxproj:

LayoutTests:

Adding new tests for ScrubberSupport that test clicking in the scrubber,
dragging the scrubber and setting the media currentTime via the media API.
Also adding the new resource to other MediaController tests.

• http/tests/media/modern-media-controls/skip-back-support/skip-back-support-button-click.html:
• media/modern-media-controls/elapsed-time-support/elapsed-time-support.html:
• media/modern-media-controls/media-controller/media-controller-constructor.html:
• media/modern-media-controls/media-controller/media-controller-resize.html:
• media/modern-media-controls/mute-support/mute-support-button-click.html:
• media/modern-media-controls/mute-support/mute-support-media-api.html:
• media/modern-media-controls/mute-support/mute-support-muted.html:
• media/modern-media-controls/playback-support/playback-support-autoplay.html:
• media/modern-media-controls/playback-support/playback-support-button-click.html:
• media/modern-media-controls/playback-support/playback-support-media-api.html:
• media/modern-media-controls/remaining-time-support/remaining-time-support.html:
• media/modern-media-controls/scrubber-support/scrubber-support-click-expected.txt: Added.
• media/modern-media-controls/scrubber-support/scrubber-support-click.html: Added.
• media/modern-media-controls/scrubber-support/scrubber-support-drag-expected.txt: Added.
• media/modern-media-controls/scrubber-support/scrubber-support-drag.html: Added.
• media/modern-media-controls/scrubber-support/scrubber-support-media-api-expected.txt: Added.
• media/modern-media-controls/scrubber-support/scrubber-support-media-api.html: Added.
• media/modern-media-controls/start-support/start-support-audio.html:
• media/modern-media-controls/start-support/start-support-autoplay.html:
• media/modern-media-controls/start-support/start-support-click-to-start.html:
• media/modern-media-controls/start-support/start-support-error.html:
• media/modern-media-controls/start-support/start-support-fullscreen.html:
• media/modern-media-controls/start-support/start-support-manual-play.html:
• media/modern-media-controls/start-support/start-support-no-source.html:
• platform/ios-simulator/TestExpectations:
• platform/mac/TestExpectations:

12:17 AM Changeset in webkit [208041] by achristensen@apple.com

• 2 edits in trunk/Source/ThirdParty/ANGLE

Another build fix.

• CMakeLists.txt:

12:08 AM Changeset in webkit [208040] by achristensen@apple.com

• 7 edits in trunk/Source

Source/ThirdParty/ANGLE:
Fix Windows WebGL build after r208036
​https://bugs.webkit.org/show_bug.cgi?id=164101

• CMakeLists.txt:

Source/WebCore:
Fix Windows WebGL build after r208022
​https://bugs.webkit.org/show_bug.cgi?id=164091

• platform/graphics/opengl/Extensions3DOpenGLCommon.h:
• platform/graphics/opengl/Extensions3DOpenGLES.cpp:

(WebCore::Extensions3DOpenGLES::Extensions3DOpenGLES):

• platform/graphics/opengl/Extensions3DOpenGLES.h:
• platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore::GraphicsContext3D::getExtensions):