Timeline

Nov 24, 2016:

12:10 PM Changeset in webkit [208974] by Michael Catanzaro

• 8 edits in trunk

[GTK] Notifications API does not expose or respect the "tag" attribute
​https://bugs.webkit.org/show_bug.cgi?id=164771

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

Expose a tag property on WebKitNotification. Ensure that any previous notification with the
same tag is closed when showing a new notification with that tag.

• UIProcess/API/gtk/WebKitNotification.cpp:

(webkit_notification_class_init):
(webkitNotificationCreate):
(webkit_notification_get_tag):

• UIProcess/API/gtk/WebKitNotification.h:
• UIProcess/API/gtk/WebKitNotificationProvider.cpp:

(WebKitNotificationProvider::withdrawAnyPreviousNotificationMatchingTag):
(WebKitNotificationProvider::show):

• UIProcess/API/gtk/WebKitNotificationProvider.h:
• UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:

Tools:

Verify that showing a notification with the same tag as another notification closes the
previous notification before the new notification is shown.

• TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:

(testWebViewNotification):

7:08 AM Changeset in webkit [208973] by svillar@igalia.com

• 3 edits in trunk/Source/WebCore

[css-grid] Convert grid representation into a class
​https://bugs.webkit.org/show_bug.cgi?id=165042

Reviewed by Manuel Rego Casasnovas.

So far grids are represented as Vectors of Vectors. There are a couple of issues associated
to that decision. First or all, the source code in RenderGrid assumes the existence of that
data structure, meaning that we cannot eventually change it without changing a lot of
code. Apart from the coupling there is another issue, RenderGrid is full of methods to
access and manipulate that data structure.

Instead, it'd be much better to have a Grid class encapsulating both the data structures and
the methods required to access/manipulate it. Note that follow-up patches will move even
more data and procedures into this new class from the RenderGrid code.

No new tests required as this is a refactoring.

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::Grid::ensureGridSize): Moved from RenderGrid.
(WebCore::RenderGrid::Grid::insert): Ditto.
(WebCore::RenderGrid::Grid::clear): Ditto.
(WebCore::RenderGrid::GridIterator::GridIterator):
(WebCore::RenderGrid::gridColumnCount): Use Grid's methods.
(WebCore::RenderGrid::gridRowCount): Ditto.
(WebCore::RenderGrid::placeItemsOnGrid): Use Grid's methods to insert children.
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator): Ditto.
(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid): Ditto.
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid): Ditto.
(WebCore::RenderGrid::numTracks): Use Grid's methods.
(WebCore::RenderGrid::ensureGridSize): Deleted. Moved to Grid class.
(WebCore::RenderGrid::insertItemIntoGrid): Deleted. Moved to Grid class.

• rendering/RenderGrid.h:

5:35 AM Changeset in webkit [208972] by Carlos Garcia Campos

• 2 edits in trunk/Tools

Unreviewed. Fix GTK+ test /webkit2/WebKitWebContext/get-plugins after r208429.

Test plugin library was renamed as libTestNetscapePlugIn.so in r208429.

• TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:

(testWebContextGetPlugins): Update the library name.

4:54 AM Changeset in webkit [208971] by Antti Koivisto

• 12 edits in trunk/Source/WebCore

Remove unused bool return from Element::willRecalcStyle
​https://bugs.webkit.org/show_bug.cgi?id=165059

Reviewed by Andreas Kling.

It is always true.

• dom/Element.cpp:

(WebCore::Element::willRecalcStyle):

• dom/Element.h:
• html/HTMLFrameSetElement.cpp:

(WebCore::HTMLFrameSetElement::willRecalcStyle):

• html/HTMLFrameSetElement.h:
• html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::willRecalcStyle):

• html/HTMLPlugInImageElement.h:
• style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolveComposedTree):

• svg/SVGElement.cpp:

(WebCore::SVGElement::willRecalcStyle):

• svg/SVGElement.h:
• svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::willRecalcStyle):

• svg/SVGUseElement.h:

Nov 23, 2016:

1:37 AM Changeset in webkit [208970] by zandobersek@gmail.com

• 4 edits in trunk

Remove ENABLE_ASSEMBLER_WX_EXCLUSIVE code
​https://bugs.webkit.org/show_bug.cgi?id=165027

Reviewed by Darin Adler.

.:

• Source/cmake/WebKitFeatures.cmake: Remove the ENABLE_ASSEMBLER_WX_EXCLUSIVE option.

Source/JavaScriptCore:

Remove the code guarded with ENABLE(ASSEMBLER_WX_EXCLUSIVE).
No port enables this and the guarded code doesn't build at all,
so it's safe to say it's abandoned.

• jit/ExecutableAllocator.cpp:

(JSC::ExecutableAllocator::initializeAllocator):
(JSC::ExecutableAllocator::ExecutableAllocator):
(JSC::ExecutableAllocator::reprotectRegion): Deleted.