Timeline

Dec 1, 2016:

10:08 PM Changeset in webkit [209232] by BJ Burg

• 9 edits in trunk/Source/JavaScriptCore

Remote Inspector: fix weird typo in generated ObjC protocol type initializer implementations
​https://bugs.webkit.org/show_bug.cgi?id=165295
<rdar://problem/29427778>

Reviewed by Joseph Pecoraro.

Remove a stray semicolon appended after custom initializer signatures.
This is a syntax error when building with less lenient compiler warnings.

• inspector/scripts/codegen/generate_objc_protocol_types_implementation.py:

(ObjCProtocolTypesImplementationGenerator._generate_init_method_for_required_members):

• inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
• inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
• inspector/scripts/tests/expected/events-with-optional-parameters.json-result:
• inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:
• inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result:
• inspector/scripts/tests/expected/type-declaration-object-type.json-result:
• inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:

9:31 PM Changeset in webkit [209231] by Darin Adler

• 6 edits in trunk/Source/WebCore

Stop using WebCore::Dictionary in bindings for Fetch
​https://bugs.webkit.org/show_bug.cgi?id=165241

Reviewed by Chris Dumez.

• Modules/fetch/DOMWindowFetch.idl: Use RequestInit instead of Dictionary.

No effect on code generated since this is a JSBuiltin.

• Modules/fetch/FetchRequest.cpp:

(WebCore::setReferrerPolicy): Deleted. Bindings handle this now.
(WebCore::setMode): Ditto.
(WebCore::setCredentials): Ditto.
(WebCore::setCache): Ditto.
(WebCore::setRedirect): Ditto.
(WebCore::setReferrer): Changed argument from Dictionary to String.
(WebCore::buildOptions): Changed argument from Dictionary to FetchRequest::Init,
and simplified the code accordingly.
(WebCore::FetchRequest::initializeOptions): Ditto.
(WebCore::FetchRequest::initializeWith): Ditto.

• Modules/fetch/FetchRequest.h: Updated for above changes. Also added the Init struct.

• Modules/fetch/FetchRequest.idl: Added missing "only-if-cached" value to RequestCache.

Added RequestInit dictionary and used it instead of Dictionary. Used more-specific string
types for the method and referrer attributes; no effect at runtime, since the code for
getters is the same for ByteString, USVString, and DOMString and these are read-only.

• Modules/fetch/WorkerGlobalScopeFetch.idl: Use RequestInit instead of Dictionary.

No effect on code generated since this is a JSBuiltin.

7:30 PM Changeset in webkit [209230] by jiewen_tan@apple.com

• 19 edits in trunk

Add a runtime flag for SubtleCrypto
​https://bugs.webkit.org/show_bug.cgi?id=164982

Reviewed by Brent Fulgham.

Source/WebCore:

• bindings/generic/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setSubtleCryptoEnabled):
(WebCore::RuntimeEnabledFeatures::subtleCryptoEnabled):

• page/Crypto.idl:

Source/WebKit/mac:

• WebView/WebPreferenceKeysPrivate.h:
• WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences subtleCryptoEnabled]):
(-[WebPreferences setSubtleCryptoEnabled:]):

• WebView/WebPreferencesPrivate.h:
• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

• Shared/WebPreferencesDefinitions.h:
• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetSubtleCryptoEnabled):
(WKPreferencesGetSubtleCryptoEnabled):

• UIProcess/API/C/WKPreferencesRefPrivate.h:
• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

• DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

• WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setSubtleCryptoEnabled):

• WebKitTestRunner/InjectedBundle/TestRunner.h:

6:38 PM Changeset in webkit [209229] by sbarati@apple.com

• 89 edits in trunk/Source

Rename CallFrame::callee() to CallFrame::jsCallee()
​https://bugs.webkit.org/show_bug.cgi?id=165293

Reviewed by Keith Miller.

Source/JavaScriptCore:

Wasm will soon have its own Callee that doesn't derive
from JSObject, but derives from JSCell. I want to introduce
a new function like:
`
CalleeBase* CallFrame::callee()
`

once we have a Wasm callee. It only makes sense to name that
function callee() and rename the current one turn to:
`
JSObject* CallFrame::jsCallee()
`

• API/APICallbackFunction.h:

(JSC::APICallbackFunction::call):
(JSC::APICallbackFunction::construct):

• API/JSCallbackObjectFunctions.h:

(JSC::JSCallbackObject<Parent>::construct):
(JSC::JSCallbackObject<Parent>::call):

• debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::scope):
(JSC::DebuggerCallFrame::type):

• interpreter/CallFrame.cpp:

(JSC::CallFrame::friendlyFunctionName):

• interpreter/CallFrame.h:

(JSC::ExecState::jsCallee):
(JSC::ExecState::callee): Deleted.

• interpreter/Interpreter.cpp:

(JSC::Interpreter::dumpRegisters):
(JSC::notifyDebuggerOfUnwinding):

• interpreter/ShadowChicken.cpp:

(JSC::ShadowChicken::update):

• interpreter/StackVisitor.cpp:

(JSC::StackVisitor::readNonInlinedFrame):

• llint/LLIntSlowPaths.cpp:

(JSC::LLInt::traceFunctionPrologue):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

• runtime/ArrayConstructor.cpp:

(JSC::constructArrayWithSizeQuirk):

• runtime/AsyncFunctionConstructor.cpp:

(JSC::callAsyncFunctionConstructor):
(JSC::constructAsyncFunctionConstructor):

• runtime/BooleanConstructor.cpp:

(JSC::constructWithBooleanConstructor):

• runtime/ClonedArguments.cpp:

(JSC::ClonedArguments::createWithInlineFrame):

• runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::arityCheckFor):

• runtime/DateConstructor.cpp:

(JSC::constructWithDateConstructor):

• runtime/DirectArguments.cpp:

(JSC::DirectArguments::createByCopying):

• runtime/Error.h:

(JSC::StrictModeTypeErrorFunction::constructThrowTypeError):
(JSC::StrictModeTypeErrorFunction::callThrowTypeError):

• runtime/ErrorConstructor.cpp:

(JSC::Interpreter::constructWithErrorConstructor):
(JSC::Interpreter::callErrorConstructor):

• runtime/FunctionConstructor.cpp:

(JSC::constructWithFunctionConstructor):
(JSC::callFunctionConstructor):

• runtime/GeneratorFunctionConstructor.cpp:

(JSC::callGeneratorFunctionConstructor):
(JSC::constructGeneratorFunctionConstructor):

• runtime/InternalFunction.cpp:

(JSC::InternalFunction::createSubclassStructure):

• runtime/IntlCollator.cpp:

(JSC::IntlCollator::initializeCollator):

• runtime/IntlCollatorConstructor.cpp:

(JSC::constructIntlCollator):
(JSC::callIntlCollator):
(JSC::IntlCollatorConstructorFuncSupportedLocalesOf):

• runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::initializeDateTimeFormat):

• runtime/IntlDateTimeFormatConstructor.cpp:

(JSC::constructIntlDateTimeFormat):
(JSC::callIntlDateTimeFormat):
(JSC::IntlDateTimeFormatConstructorFuncSupportedLocalesOf):

• runtime/IntlNumberFormat.cpp:

(JSC::IntlNumberFormat::initializeNumberFormat):

• runtime/IntlNumberFormatConstructor.cpp:

(JSC::constructIntlNumberFormat):
(JSC::callIntlNumberFormat):
(JSC::IntlNumberFormatConstructorFuncSupportedLocalesOf):

• runtime/IntlObject.cpp:

(JSC::canonicalizeLocaleList):
(JSC::defaultLocale):
(JSC::lookupSupportedLocales):
(JSC::intlObjectFuncGetCanonicalLocales):

• runtime/JSArrayBufferConstructor.cpp:

(JSC::constructArrayBuffer):

• runtime/JSArrayBufferPrototype.cpp:

(JSC::arrayBufferProtoFuncSlice):

• runtime/JSBoundFunction.cpp:

(JSC::boundThisNoArgsFunctionCall):
(JSC::boundFunctionCall):
(JSC::boundThisNoArgsFunctionConstruct):
(JSC::boundFunctionConstruct):

• runtime/JSCellInlines.h:

(JSC::ExecState::vm):

• runtime/JSCustomGetterSetterFunction.cpp:

(JSC::JSCustomGetterSetterFunction::customGetterSetterFunctionCall):

• runtime/JSFunction.cpp:

(JSC::callHostFunctionAsConstructor):

• runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::constructGenericTypedArrayView):

• runtime/JSGenericTypedArrayViewPrototypeFunctions.h:

(JSC::genericTypedArrayViewProtoFuncSlice):
(JSC::genericTypedArrayViewPrivateFuncSubarrayCreate):

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):

• runtime/JSInternalPromiseConstructor.cpp:

(JSC::constructPromise):

• runtime/JSMapIterator.cpp:

(JSC::JSMapIterator::createPair):
(JSC::JSMapIterator::clone):

• runtime/JSNativeStdFunction.cpp:

(JSC::runStdFunction):

• runtime/JSPromiseConstructor.cpp:

(JSC::constructPromise):

• runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::clone):

• runtime/JSScope.h:

(JSC::ExecState::lexicalGlobalObject):

• runtime/JSSetIterator.cpp:

(JSC::JSSetIterator::createPair):
(JSC::JSSetIterator::clone):

• runtime/JSStringIterator.cpp:

(JSC::JSStringIterator::clone):

• runtime/MapConstructor.cpp:

(JSC::constructMap):

• runtime/MapPrototype.cpp:

(JSC::mapProtoFuncValues):
(JSC::mapProtoFuncEntries):
(JSC::mapProtoFuncKeys):
(JSC::privateFuncMapIterator):

• runtime/NativeErrorConstructor.cpp:

(JSC::Interpreter::constructWithNativeErrorConstructor):
(JSC::Interpreter::callNativeErrorConstructor):

• runtime/ObjectConstructor.cpp:

(JSC::constructObject):

• runtime/ProxyObject.cpp:

(JSC::performProxyCall):
(JSC::performProxyConstruct):

• runtime/ProxyRevoke.cpp:

(JSC::performProxyRevoke):

• runtime/RegExpConstructor.cpp:

(JSC::constructWithRegExpConstructor):
(JSC::callRegExpConstructor):

• runtime/ScopedArguments.cpp:

(JSC::ScopedArguments::createByCopying):

• runtime/SetConstructor.cpp:

(JSC::constructSet):

• runtime/SetPrototype.cpp:

(JSC::setProtoFuncValues):
(JSC::setProtoFuncEntries):
(JSC::privateFuncSetIterator):

• runtime/StringConstructor.cpp:

(JSC::constructWithStringConstructor):

• runtime/StringPrototype.cpp:

(JSC::stringProtoFuncIterator):

• runtime/WeakMapConstructor.cpp:

(JSC::constructWeakMap):

• runtime/WeakSetConstructor.cpp:

(JSC::constructWeakSet):

• wasm/js/WebAssemblyCompileErrorConstructor.cpp:

(JSC::constructJSWebAssemblyCompileError):

• wasm/js/WebAssemblyFunction.cpp:

(JSC::callWebAssemblyFunction):

• wasm/js/WebAssemblyModuleConstructor.cpp:

(JSC::constructJSWebAssemblyModule):

• wasm/js/WebAssemblyRuntimeErrorConstructor.cpp:

(JSC::constructJSWebAssemblyRuntimeError):

Source/WebCore:

• bindings/js/JSDOMConstructor.h:

(WebCore::JSBuiltinConstructor<JSClass>::construct):

• bindings/js/JSDataCueCustom.cpp:

(WebCore::constructJSDataCue):

• bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::callHTMLAllCollection):

• bindings/js/JSHTMLElementCustom.cpp:

(WebCore::constructJSHTMLElement):

• bindings/js/JSImageConstructor.cpp:

(WebCore::JSImageConstructor::construct):

• bindings/js/JSMutationObserverCustom.cpp:

(WebCore::constructJSMutationObserver):

• bindings/js/JSPluginElementFunctions.cpp:

(WebCore::callPlugin):

• bindings/js/JSWorkerCustom.cpp:

(WebCore::constructJSWorker):

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateConstructorDefinition):

• bindings/scripts/test/JS/JSFloat64Array.cpp:

(WebCore::JSFloat64ArrayConstructor::constructJSFloat64Array):

• bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructorConstructor::construct):

• bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::construct):

• bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorNamedConstructor::construct):

• bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::JSTestNodeConstructor::construct):

• bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::construct):

• bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::constructJSTestOverloadedConstructors1):
(WebCore::constructJSTestOverloadedConstructors2):
(WebCore::constructJSTestOverloadedConstructors3):
(WebCore::constructJSTestOverloadedConstructors4):
(WebCore::constructJSTestOverloadedConstructors5):

• bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:

(WebCore::constructJSTestOverloadedConstructorsWithSequence1):
(WebCore::constructJSTestOverloadedConstructorsWithSequence2):

• bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefsConstructor::construct):

• bridge/objc/objc_runtime.mm:

(JSC::Bindings::callObjCFallbackObject):

• bridge/runtime_method.cpp:

(JSC::callRuntimeMethod):

• bridge/runtime_object.cpp:

(JSC::Bindings::callRuntimeObject):
(JSC::Bindings::callRuntimeConstructor):

Source/WebKit2:

• WebProcess/Plugins/Netscape/JSNPMethod.cpp:

(WebKit::callMethod):

• WebProcess/Plugins/Netscape/JSNPObject.cpp:

(WebKit::callNPJSObject):
(WebKit::constructWithConstructor):

6:11 PM Changeset in webkit [209228] by graouts@webkit.org

• 8 edits
  2 adds in trunk

[Modern Media Controls] Fade controls in when entering and exiting fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=165287

Reviewed by Dean Jackson.

Fade controls in when we enter and leave fullscreen.

Test: media/modern-media-controls/media-controller/media-controller-fade-controls-when-entering-fullscreen.html

• Modules/modern-media-controls/controls/media-controls.css:

(.media-controls.fade-in):
(@keyframes fade-in):
(to):

• Modules/modern-media-controls/controls/media-controls.js:

(MediaControls.prototype.presentInElement):

• Modules/modern-media-controls/media/fullscreen-support.js:

(FullscreenSupport.prototype.buttonWasClicked):

• Modules/modern-media-controls/media/media-controller.js:

(MediaController.prototype._updateControlsIfNeeded):

6:07 PM Changeset in webkit [209227] by graouts@webkit.org

• 7 edits
  5 adds in trunk

[Modern Media Controls] Show and populate the tracks panel
​https://bugs.webkit.org/show_bug.cgi?id=165284

Reviewed by Dean Jackson.

We added a TracksPanel in ​https://bugs.webkit.org/show_bug.cgi?id=165239 which allows to
show a list of media tracks and text tracks to choose from. We now show this panel when
clicking on the tracks button in the controls bar and populate its content with the
list of audio and text tracks for the media element. As an item is picked from the tracks
panel, we toggle the represented track's enabled state and dismiss the panel.

We also pick up the text track container display mostly unchanged from current media controls.

Tests: media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html

media/modern-media-controls/tracks-support/tracks-support-show-and-populate-panel.html

• Modules/modern-media-controls/controls/macos-inline-media-controls.js:

(MacOSInlineMediaControls.prototype.showTracksPanel):

• Modules/modern-media-controls/controls/text-tracks.css: Added.

(video::-webkit-media-text-track-container):
(video::cue):
(video::-webkit-media-text-track-display):
(video::-webkit-media-text-track-display-backdrop):
(video::cue(:future)):
(video::-webkit-media-text-track-container b):
(video::-webkit-media-text-track-container u):
(video::-webkit-media-text-track-container i):
(video::-webkit-media-text-track-container .hidden):

• Modules/modern-media-controls/media/media-controller.js:

(MediaController):

• Modules/modern-media-controls/media/tracks-support.js:

(TracksSupport):
(TracksSupport.prototype.destroy):
(TracksSupport.prototype.buttonWasClicked):
(TracksSupport.prototype.tracksPanelNumberOfSections):
(TracksSupport.prototype.tracksPanelTitleForSection):
(TracksSupport.prototype.tracksPanelNumberOfTracksInSection):
(TracksSupport.prototype.tracksPanelTitleForTrackInSection):
(TracksSupport.prototype.tracksPanelIsTrackInSectionSelected):
(TracksSupport.prototype.tracksPanelSelectionDidChange):
(TracksSupport.prototype.syncControl):
(TracksSupport.prototype._textTracks):
(TracksSupport.prototype._audioTracks):
(TracksSupport.prototype._canPickAudioTracks):
(TracksSupport.prototype._canPickTextTracks):
(TracksSupport.prototype._sortedTrackList):

5:30 PM Changeset in webkit [209226] by Brent Fulgham

• 2 edits in trunk/Source/WebCore

Rare crash when preparing to print
​https://bugs.webkit.org/show_bug.cgi?id=165280
<rdar://problem/28240254>

Reviewed by Dean Jackson.

• page/Frame.cpp:

(WebCore::Frame::setPrinting): Only manipulate the FrameView if it is non-null.
(WebCore::Frame::documentAtPoint): Drive-by fix to change a 0 return to nullptr.

5:24 PM Changeset in webkit [209225] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Removing Release-only flag from flaky test http/tests/cache/disk-cache/disk-cache-request-max-stale.html
​https://bugs.webkit.org/show_bug.cgi?id=159840

Unreviewed test gardening..

• platform/ios-simulator-wk2/TestExpectations:

5:21 PM Changeset in webkit [209224] by Simon Fraser

• 3 edits in trunk/Source/WebCore

Put an obvious debug border on layers with backdrop filters
​https://bugs.webkit.org/show_bug.cgi?id=165291

Reviewed by Tim Horton.

Put a wide magenta border on layers with backdrop filters, to highlight their performance impact.

Change the "contents layer" color (used by WebGL, video etc) to blue.

Make the clipping layer border slightly narrower.

• platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::getDebugBorderInfo):

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setBackdropFilters):

5:01 PM Changeset in webkit [209223] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Marking media/modern-media-controls/tracks-panel/tracks-panel-hide-click-outside.html as a flaky timeout.
​https://bugs.webkit.org/show_bug.cgi?id=165290

Unreviewed test gardening.

• platform/mac/TestExpectations:

4:52 PM Changeset in webkit [209222] by BJ Burg

• 15 edits in trunk/Source/JavaScriptCore

Web Inspector: generated code should use a framework-style import for *ProtocolArrayConversions.h
​https://bugs.webkit.org/show_bug.cgi?id=165281
<rdar://problem/29427778>

Reviewed by Joseph Pecoraro.

• inspector/scripts/codegen/generate_objc_protocol_type_conversions_header.py:

(ObjCProtocolTypeConversionsHeaderGenerator.generate_output):

• inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
• inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
• inspector/scripts/tests/expected/domains-with-varying-command-sizes.json-result:
• inspector/scripts/tests/expected/enum-values.json-result:
• inspector/scripts/tests/expected/events-with-optional-parameters.json-result:
• inspector/scripts/tests/expected/generate-domains-with-feature-guards.json-result:
• inspector/scripts/tests/expected/same-type-id-different-domain.json-result:
• inspector/scripts/tests/expected/shadowed-optional-type-setters.json-result:
• inspector/scripts/tests/expected/type-declaration-aliased-primitive-type.json-result:
• inspector/scripts/tests/expected/type-declaration-array-type.json-result:
• inspector/scripts/tests/expected/type-declaration-enum-type.json-result:
• inspector/scripts/tests/expected/type-declaration-object-type.json-result:
• inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:

4:47 PM Changeset in webkit [209221] by BJ Burg

• 2 edits in trunk/Source/WebCore

Fix the Windows Release build after r209198
​https://bugs.webkit.org/show_bug.cgi?id=165285

Unreviewed build fix.

• Modules/webdriver/NavigatorWebDriver.cpp:

Brute force include all the inlines to work around a JSC issue.

4:24 PM Changeset in webkit [209220] by ggaren@apple.com

• 6 edits
  1 copy
  1 move in trunk/Source/JavaScriptCore

SourceCodeKey should use unlinked source code
​https://bugs.webkit.org/show_bug.cgi?id=165286

Reviewed by Saam Barati.

This patch splits out UnlinkedSourceCode from SourceCode, and deploys
UnlinkedSourceCode in SourceCodeKey.

It's misleading to store SourceCode in SourceCodeKey because SourceCode
has an absolute location whereas unlinked cached code has no location.

I plan to deploy UnlinkedSourceCode in more places, to indicate code
that has no absolute location.

• JavaScriptCore.xcodeproj/project.pbxproj:
• parser/SourceCode.cpp:

(JSC::UnlinkedSourceCode::toUTF8):
(JSC::SourceCode::toUTF8): Deleted.

• parser/SourceCode.h:

(JSC::SourceCode::SourceCode):
(JSC::SourceCode::startColumn):
(JSC::SourceCode::isHashTableDeletedValue): Deleted.
(JSC::SourceCode::hash): Deleted.
(JSC::SourceCode::view): Deleted.
(JSC::SourceCode::providerID): Deleted.
(JSC::SourceCode::isNull): Deleted.
(JSC::SourceCode::provider): Deleted.
(JSC::SourceCode::startOffset): Deleted.
(JSC::SourceCode::endOffset): Deleted.
(JSC::SourceCode::length): Deleted. Move a bunch of stuff in to a new
base class, UnlinkedSourceCode.

• parser/SourceCodeKey.h:

(JSC::SourceCodeKey::SourceCodeKey): Use UnlinkedSourceCode since code
in the cache has no location.

• parser/UnlinkedSourceCode.h: Copied from Source/JavaScriptCore/parser/SourceCode.h.

(JSC::UnlinkedSourceCode::UnlinkedSourceCode):
(JSC::UnlinkedSourceCode::provider):
(JSC::SourceCode::SourceCode): Deleted.
(JSC::SourceCode::isHashTableDeletedValue): Deleted.
(JSC::SourceCode::hash): Deleted.
(JSC::SourceCode::view): Deleted.
(JSC::SourceCode::providerID): Deleted.
(JSC::SourceCode::isNull): Deleted.
(JSC::SourceCode::provider): Deleted.
(JSC::SourceCode::firstLine): Deleted.
(JSC::SourceCode::startColumn): Deleted.
(JSC::SourceCode::startOffset): Deleted.
(JSC::SourceCode::endOffset): Deleted.
(JSC::SourceCode::length): Deleted.
(JSC::makeSource): Deleted.
(JSC::SourceCode::subExpression): Deleted.

• runtime/CodeCache.h: Use UnlinkedSourceCode in the cache.

4:04 PM Changeset in webkit [209219] by Ryan Haddad

• 2 edits in trunk/JSTests

Skip flaky test ChakraCore/test/fieldopts/objtypespec-newobj-invalidation.1.js
​https://bugs.webkit.org/show_bug.cgi?id=162567

Reviewed by Saam Barati.

• ChakraCore.yaml:

2:55 PM Changeset in webkit [209218] by matthew_hanson@apple.com

• 3 edits
  2 adds in branches/safari-602-branch

Merge r209149. rdar://problem/29404230

2:54 PM Changeset in webkit [209217] by hyatt@apple.com

• 2 edits in trunk/Source/WebCore

[CSS Parser] Only allow a single font-family in @font-face
​https://bugs.webkit.org/show_bug.cgi?id=165278

Reviewed by Zalan Bujtas.

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeFontFamilyDescriptor):
(WebCore::CSSPropertyParser::parseFontFaceDescriptor):

2:53 PM Changeset in webkit [209216] by ap@apple.com

• 5 edits in trunk/Tools

Remove webkitpy dependency on Eliza
​https://bugs.webkit.org/show_bug.cgi?id=164979

Reviewed by Daniel Bates.

This module is not on pypi, so installing it is a challenge. The jokes feel pretty old too!

• Scripts/webkitpy/thirdparty/init.py:
• Scripts/webkitpy/thirdparty/init_unittest.py: Changed mock import hook to

test buildbot instead of eliza.

• Scripts/webkitpy/tool/bot/ircbot.py:
• Scripts/webkitpy/tool/bot/ircbot_unittest.py:

2:48 PM Changeset in webkit [209215] by Chris Dumez

• 3 edits
  2 adds in trunk

Source/WebKit2:
[iOS][WK2] Tapping an element generates a 'click' event that has 0 as timeStamp
​https://bugs.webkit.org/show_bug.cgi?id=165270
<rdar://problem/29224355>

Reviewed by Simon Fraser.

Tapping an element generates a 'click' event that has 0 as timeStamp
instead of having a proper timeStamp value. This is breaking some
sites.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::handleSyntheticClick):
(WebKit::WebPage::completeSyntheticClick):

LayoutTests:
[iOS] Tapping an element generates a 'click' event that has 0 as timeStamp
​https://bugs.webkit.org/show_bug.cgi?id=165270
<rdar://problem/29224355>

Reviewed by Simon Fraser.

Add layout test coverage.

• fast/events/ios/click-event-timestamp-expected.txt: Added.
• fast/events/ios/click-event-timestamp.html: Added.

2:36 PM Changeset in webkit [209214] by timothy_horton@apple.com

• 3 edits in trunk/Source/WebKit2

Try to fix the EFL/Gtk build

• UIProcess/efl/WebProcessPoolEfl.cpp:

(WebKit::WebProcessPool::platformResolvePathsForSandboxExtensions):

• UIProcess/gtk/WebProcessPoolGtk.cpp:

(WebKit::WebProcessPool::platformResolvePathsForSandboxExtensions):

2:32 PM Changeset in webkit [209213] by Matt Baker

• 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Show async stack traces for workers
​https://bugs.webkit.org/show_bug.cgi?id=165235
<rdar://problem/29450172>

Reviewed by Joseph Pecoraro.

• UserInterface/Views/CallFrameTreeElement.css:

(.tree-outline > .children > .item.call-frame.async-boundary):
(.tree-outline:not(.single-thread) > .children > .item.call-frame.async-boundary):
(.tree-outline .item.call-frame.async-boundary::before):
(.tree-outline.single-thread .item.call-frame.async-boundary::before):
(.tree-outline .item.call-frame.async-boundary): Deleted.
Style changes for single/multiple-thread call stacks.
Padding changes to account for Thread tree element.
Make selectors more specific where needed.

• UserInterface/Views/DebuggerSidebarPanel.css:

(.sidebar > .panel.navigation.debugger .tree-outline.single-thread > .item.thread):
(.sidebar > .panel.navigation.debugger .tree-outline.single-thread):
Style changes for single/multiple-thread call stacks.

• UserInterface/Views/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel):
Use a single tree outline for showing a single thread or multiple threads.
For single-threaded, hide Thread tree element and un-indent children.

(WebInspector.DebuggerSidebarPanel.prototype._targetAdded):
(WebInspector.DebuggerSidebarPanel.prototype._targetRemoved):
(WebInspector.DebuggerSidebarPanel.prototype._updateCallStackTreeOutline):
Update tree style and whether Thread tree element is selectable.
(WebInspector.DebuggerSidebarPanel.prototype._debuggerActiveCallFrameDidChange):
Remove support for second tree outline.

(WebInspector.DebuggerSidebarPanel.prototype._updateSingleThreadCallStacks): Deleted.
(WebInspector.DebuggerSidebarPanel.prototype._selectActiveCallFrameTreeElement): Deleted.
(WebInspector.DebuggerSidebarPanel.prototype._showSingleThreadCallStacks): Deleted.
(WebInspector.DebuggerSidebarPanel.prototype._showMultipleThreadCallStacks): Deleted.
No longer needed after unifying tree outlines.

• UserInterface/Views/ThreadTreeElement.js:

(WebInspector.ThreadTreeElement.prototype.refresh):
Append call frames from the async stack trace.

2:31 PM Changeset in webkit [209212] by timothy_horton@apple.com

• 6 edits in trunk/Source/WebKit2

Every WKWebView initialization spends a few milliseconds hitting the disk
​https://bugs.webkit.org/show_bug.cgi?id=165268
<rdar://problem/29010113>

Reviewed by Brady Eidson.

Every WKWebView init currently involves doing directory creation and
symlink resolution for a number of paths (to create sandbox extensions
for all of our storage directories), which means touching the disk a
lot during init. All of these paths are immutable per-WebProcessPool,
so, instead, cache them on WebProcessPool and create sandbox extensions
from the already-resolved paths. This is a sizable (~4x) speedup when
initializing subsequent web views.

• Shared/SandboxExtension.h:

(WebKit::SandboxExtension::createHandleWithoutResolvingPath):
Add createHandleWithoutResolvingPath, which makes a sandbox extension
handle without doing symlink resolution.

(WebKit::resolvePathForSandboxExtension):
(WebKit::resolveAndCreateReadWriteDirectoryForSandboxExtension):
Add two functions that do the same resolution that SandboxExtension::createHandle
and ::createHandleForReadWriteDirectory do, but just return the paths,
for later use with createHandleWithoutResolvingPath.

• Shared/mac/SandboxExtensionMac.mm:

(WebKit::resolveAndCreateReadWriteDirectoryForSandboxExtension):
(WebKit::resolvePathForSandboxExtension):
(WebKit::SandboxExtension::createHandleWithoutResolvingPath):
(WebKit::SandboxExtension::createHandle):
(WebKit::SandboxExtension::createHandleForReadWriteDirectory):
Implement the aforementioned functions, and reimplement the existing
createHandle{ForReadWriteDirectory} functions in terms of them.

• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformDefaultIconDatabasePath):
Stop wasting time generating and resolving a platform default icon
database path, since we don't actually use it for anything anymore except
to determine whether the icon database is enabled, and we only want to
enable it if the client has provided a path.

(WebKit::WebProcessPool::platformResolvePathsForSandboxExtensions):
(WebKit::WebProcessPool::platformInitializeWebProcess):

• UIProcess/WebProcessPool.cpp:

(WebKit::m_hiddenPageThrottlingTimer):
(WebKit::WebProcessPool::resolvePathsForSandboxExtensions):
(WebKit::WebProcessPool::createNewWebProcess):

• UIProcess/WebProcessPool.h:

Resolve paths in resolvePathsForSandboxExtensions, and use the resolved
paths along with createHandleWithoutResolvingPath in order to effectively
cache the resolution operation.

2:24 PM Changeset in webkit [209211] by matthew_hanson@apple.com

• 11 edits
  12 adds in branches/safari-602-branch

Merge r209145. rdar://problem/29404231

2:23 PM Changeset in webkit [209210] by matthew_hanson@apple.com

• 6 edits
  2 adds in branches/safari-602-branch

Merge r208745. rdar://problem/29277336

2:23 PM Changeset in webkit [209209] by matthew_hanson@apple.com

• 3 edits
  4 adds in branches/safari-602-branch

Merge r208825. rdar://problem/29277338

2:23 PM Changeset in webkit [209208] by matthew_hanson@apple.com

• 2 edits in branches/safari-602-branch/Source/WebCore

Merge r208629. rdar://problem/29277337

2:23 PM Changeset in webkit [209207] by matthew_hanson@apple.com

• 3 edits
  2 adds in branches/safari-602-branch

Merge r208628. rdar://problem/29277337

2:14 PM Changeset in webkit [209206] by Beth Dakin

• 2 edits in trunk/Source/WebCore

Blacklist Netflix for TouchBar support
​https://bugs.webkit.org/show_bug.cgi?id=165104

Rubber-stamped by Tim Horton.

Meant to not have the www. in the first case because that is covered by the second
case.

• html/HTMLMediaElement.cpp:

(WebCore::needsPlaybackControlsManagerQuirk):

2:07 PM Changeset in webkit [209205] by hyatt@apple.com

• 2 edits in trunk/Source/WebCore

[CSS Parser] Support -webkit-overflow-scrolling: touch
​https://bugs.webkit.org/show_bug.cgi?id=165275

Reviewed by Zalan Bujtas.

• css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):

2:00 PM Changeset in webkit [209204] by keith_miller@apple.com

• 9 edits
  1 add in trunk

Add wasm int to floating point opcodes
​https://bugs.webkit.org/show_bug.cgi?id=165252

Reviewed by Geoffrey Garen.

JSTests:

Add tests for Wasm integral to floating point conversion opcodes.

• wasm/function-tests/int-to-floating-point.js: Added.
• wasm/wasm.json:

Source/JavaScriptCore:

This patch adds support for the Wasm integral type => floating point
type conversion opcodes. Most of these were already supported by B3
however there was no support for uint64 to float/double. Unfortunately,
AFAIK x86_64 does not have a single instruction that performs this
conversion. Since there is a signed conversion instruction on x86 we
use that for all uint64s that don't have the top bit set. If they do have
the top bit set we need to divide by 2 (rounding up) then convert the number
with the signed conversion then double the result.

• assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::convertUInt64ToDouble):
(JSC::MacroAssemblerX86_64::convertUInt64ToFloat):

• jsc.cpp:

(valueWithTypeOfWasmValue):
(box):
(functionTestWasmModuleFunctions):

• wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::addOp<F64ConvertUI64>):
(JSC::Wasm::B3IRGenerator::addOp<OpType::F32ConvertUI64>):

• wasm/WasmFunctionParser.h:

(JSC::Wasm::FunctionParser<Context>::parseExpression):

• wasm/wasm.json:

1:58 PM Changeset in webkit [209203] by ggaren@apple.com

• 1 edit
  1 add in trunk/JSTests

Land a test case for <rdar://problem/27889416>
​https://bugs.webkit.org/show_bug.cgi?id=165272

Reviewed by Saam Barati.

• stress/marked-argument-buffer.js: Added.

(allocate):
(test.o.toString):
(test):

1:57 PM Changeset in webkit [209202] by hyatt@apple.com

• 2 edits in trunk/LayoutTests

[CSS Parser] Fix an invalid shadow DOM test
​https://bugs.webkit.org/show_bug.cgi?id=165273

Reviewed by Zalan Bujtas.

• fast/shadow-dom/css-scoping-slot-with-id.html:

Pseudo-element needs to be rightmost. The rule is illegal, but our old parser
incorrectly allowed it. Fix the test by just flipping the order so that ::slotted(*)
occurs last.

1:47 PM Changeset in webkit [209201] by ggaren@apple.com

• 6 edits
  1 move in trunk/Source/JavaScriptCore

Renamed EvalCodeCache => DirectEvalCodeCache
​https://bugs.webkit.org/show_bug.cgi?id=165271

Reviewed by Saam Barati.

We only use this cache for DirectEval, not IndirectEval.

• JavaScriptCore.xcodeproj/project.pbxproj:
• bytecode/CodeBlock.cpp:

(JSC::DirectEvalCodeCache::visitAggregate):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC::EvalCodeCache::visitAggregate): Deleted.

• bytecode/CodeBlock.h:

(JSC::CodeBlock::directEvalCodeCache):
(JSC::CodeBlock::evalCodeCache): Deleted.

• bytecode/DirectEvalCodeCache.h: Copied from Source/JavaScriptCore/bytecode/EvalCodeCache.h.

(JSC::EvalCodeCache::CacheKey::CacheKey): Deleted.
(JSC::EvalCodeCache::CacheKey::hash): Deleted.
(JSC::EvalCodeCache::CacheKey::isEmptyValue): Deleted.
(JSC::EvalCodeCache::CacheKey::operator==): Deleted.
(JSC::EvalCodeCache::CacheKey::isHashTableDeletedValue): Deleted.
(JSC::EvalCodeCache::CacheKey::Hash::hash): Deleted.
(JSC::EvalCodeCache::CacheKey::Hash::equal): Deleted.
(JSC::EvalCodeCache::tryGet): Deleted.
(JSC::EvalCodeCache::set): Deleted.
(JSC::EvalCodeCache::isEmpty): Deleted.
(JSC::EvalCodeCache::clear): Deleted.

• bytecode/EvalCodeCache.h: Removed.
• interpreter/Interpreter.cpp:

(JSC::eval):

• runtime/DirectEvalExecutable.cpp:

(JSC::DirectEvalExecutable::create):

1:45 PM Changeset in webkit [209200] by jiewen_tan@apple.com

• 12 edits
  21 adds in trunk

Update SubtleCrypto::unwrapKey to match the latest spec
​https://bugs.webkit.org/show_bug.cgi?id=164747
<rdar://problem/29258198>

Reviewed by Brent Fulgham.

LayoutTests/imported/w3c:

• WebCryptoAPI/idlharness-expected.txt:

Source/WebCore:

This patch does following few things:

1. It updates the SubtleCrypto::unwrapKey method to match the latest spec: ​https://www.w3.org/TR/WebCryptoAPI/#SubtleCrypto-method-unwrapKey. It also refers to the latest Editor's Draft to a certain degree: ​https://w3c.github.io/webcrypto/Overview.html#SubtleCrypto-method-unwrapKey.
2. It implements unwrapKey operations of the following algorithms: AES-KW.

Tests: crypto/subtle/aes-cbc-import-key-unwrap-jwk-rsa-key-private.html

crypto/subtle/aes-cbc-import-key-uwrap-jwk-rsa-key-public.html
crypto/subtle/aes-kw-generate-key-wrap-key-unwrap-key.html
crypto/subtle/aes-kw-import-key-unwrap-raw-key.html
crypto/subtle/rsa-oaep-import-key-unwrap-jwk-oct-key.html
crypto/subtle/unwrapKey-malformed-parameters.html
crypto/workers/subtle/aes-cbc-import-key-unwrap-key.html
crypto/workers/subtle/aes-kw-import-key-unwrap-key.html
crypto/workers/subtle/rsa-oaep-import-key-unwrap-key.html

• bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::normalizeCryptoAlgorithmParameters):
(WebCore::jsSubtleCryptoFunctionWrapKeyPromise):
Add some comments.
(WebCore::jsSubtleCryptoFunctionUnwrapKeyPromise):
(WebCore::JSSubtleCrypto::unwrapKey):

• crypto/CryptoAlgorithm.cpp:

(WebCore::CryptoAlgorithm::unwrapKey):

• crypto/CryptoAlgorithm.h:
• crypto/SubtleCrypto.idl:
• crypto/algorithms/CryptoAlgorithmAES_KW.cpp:

(WebCore::CryptoAlgorithmAES_KW::unwrapKey):

• crypto/algorithms/CryptoAlgorithmAES_KW.h:
• crypto/gnutls/CryptoAlgorithmAES_KWGnuTLS.cpp:

(WebCore::CryptoAlgorithmAES_KW::platformUnwrapKey):

• crypto/mac/CryptoAlgorithmAES_KWMac.cpp:

(WebCore::unwrapKeyAES_KW):
(WebCore::CryptoAlgorithmAES_KW::platformUnwrapKey):
(WebCore::CryptoAlgorithmAES_KW::platformDecrypt):

LayoutTests:

• crypto/subtle/aes-cbc-import-key-unwrap-jwk-rsa-key-private-expected.txt: Added.
• crypto/subtle/aes-cbc-import-key-unwrap-jwk-rsa-key-private.html: Added.
• crypto/subtle/aes-cbc-import-key-uwrap-jwk-rsa-key-public-expected.txt: Added.
• crypto/subtle/aes-cbc-import-key-uwrap-jwk-rsa-key-public.html: Added.
• crypto/subtle/aes-kw-generate-key-wrap-key-unwrap-key-expected.txt: Added.
• crypto/subtle/aes-kw-generate-key-wrap-key-unwrap-key.html: Added.
• crypto/subtle/aes-kw-import-key-unwrap-raw-key-expected.txt: Added.
• crypto/subtle/aes-kw-import-key-unwrap-raw-key.html: Added.
• crypto/subtle/rsa-oaep-import-key-unwrap-jwk-oct-key-expected.txt: Added.
• crypto/subtle/rsa-oaep-import-key-unwrap-jwk-oct-key.html: Added.
• crypto/subtle/unwrapKey-malformed-parameters-expected.txt: Added.
• crypto/subtle/unwrapKey-malformed-parameters.html: Added.
• crypto/workers/subtle/aes-cbc-import-key-unwrap-key-expected.txt: Added.
• crypto/workers/subtle/aes-cbc-import-key-unwrap-key.html: Added.
• crypto/workers/subtle/aes-kw-import-key-unwrap-key-expected.txt: Added.
• crypto/workers/subtle/aes-kw-import-key-unwrap-key.html: Added.
• crypto/workers/subtle/resources/aes-cbc-import-key-unwrap-key.js: Added.
• crypto/workers/subtle/resources/aes-kw-import-key-unwrap-key.js: Added.
• crypto/workers/subtle/resources/rsa-oaep-import-key-unwrap-key.js: Added.
• crypto/workers/subtle/rsa-oaep-import-key-unwrap-key-expected.txt: Added.
• crypto/workers/subtle/rsa-oaep-import-key-unwrap-key.html: Added.

1:41 PM Changeset in webkit [209199] by hyatt@apple.com

• 4 edits in trunk

[CSS Parser] Fix font-variant parsing
​https://bugs.webkit.org/show_bug.cgi?id=165266

Reviewed by Dean Jackson.

Source/WebCore:

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeFontVariantEastAsian):
(WebCore::consumeFontVariantAlternates):
(WebCore::consumeFontVariantPosition):
(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::CSSPropertyParser::parseFontFaceDescriptor):
(WebCore::CSSPropertyParser::consumeFontVariantShorthand):
(WebCore::consumeFontVariantList): Deleted.

LayoutTests:

• TestExpectations:

1:39 PM Changeset in webkit [209198] by BJ Burg

• 4 edits
  2 copies
  1 move
  1 add in trunk/Source/WebCore

Web Automation: expose navigator.webdriver if the page is controlled by automation
​https://bugs.webkit.org/show_bug.cgi?id=165245
<rdar://problem/29449874>

Reviewed by Joseph Pecoraro.

Move the implementation into OpenSource. It's in Modules/webdriver/.

• CMakeLists.txt:
• DerivedSources.make:

Add new paths and files.

• Modules/webdriver/NavigatorWebDriver.cpp: Added.

(WebCore::NavigatorWebDriver::NavigatorWebDriver):
(WebCore::NavigatorWebDriver::~NavigatorWebDriver):
(WebCore::NavigatorWebDriver::supplementName):
(WebCore::NavigatorWebDriver::isControlledByAutomation):
(WebCore::NavigatorWebDriver::from):
(WebCore::JSNavigator::webdriver):

• Modules/webdriver/NavigatorWebDriver.h: Added.
• Modules/webdriver/NavigatorWebDriver.idl: Added.
• WebCore.xcodeproj/project.pbxproj:

1:33 PM Changeset in webkit [209197] by beidson@apple.com

• 19 edits
  5 adds in trunk

IndexedDB 2.0: Implement IDBObjectStore.getKey().
​https://bugs.webkit.org/show_bug.cgi?id=165256

Reviewed by Alex Christensen.

Source/WebCore:

Tests: storage/indexeddb/modern/idbobjectstore-getkey-1-private.html

storage/indexeddb/modern/idbobjectstore-getkey-1.html

• Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::getKey):

• Modules/indexeddb/IDBObjectStore.h:
• Modules/indexeddb/IDBObjectStore.idl:

• Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::createObjectStoreGet):
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::requestedObjectStoreRecordType):

• Modules/indexeddb/IDBRequest.h:

• Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::requestGetRecord):
(WebCore::IDBTransaction::requestIndexRecord):
(WebCore::IDBTransaction::didGetRecordOnServer):

• Modules/indexeddb/IndexedDB.h:

• Modules/indexeddb/server/IDBBackingStore.h:

• Modules/indexeddb/server/MemoryIDBBackingStore.cpp:

(WebCore::IDBServer::MemoryIDBBackingStore::getRecord):

• Modules/indexeddb/server/MemoryIDBBackingStore.h:

• Modules/indexeddb/server/MemoryObjectStore.h:

• Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::getRecord):

• Modules/indexeddb/server/SQLiteIDBBackingStore.h:

• Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::getRecord):
(WebCore::IDBServer::UniqueIDBDatabase::performGetRecord):

• Modules/indexeddb/server/UniqueIDBDatabase.h:

• Modules/indexeddb/shared/IDBGetRecordData.cpp:

(WebCore::IDBGetRecordData::isolatedCopy):

• Modules/indexeddb/shared/IDBGetRecordData.h:

(WebCore::IDBGetRecordData::encode):
(WebCore::IDBGetRecordData::decode):

LayoutTests:

• storage/indexeddb/modern/idbobjectstore-getkey-1-expected.txt: Added.
• storage/indexeddb/modern/idbobjectstore-getkey-1-private-expected.txt: Added.
• storage/indexeddb/modern/idbobjectstore-getkey-1-private.html: Added.
• storage/indexeddb/modern/idbobjectstore-getkey-1.html: Added.
• storage/indexeddb/modern/resources/idbobjectstore-getkey-1.js: Added.

1:23 PM Changeset in webkit [209196] by ggaren@apple.com

• 10 edits in trunk/Source/JavaScriptCore

Removed some unnecessary indirection in code generation
​https://bugs.webkit.org/show_bug.cgi?id=165264

Reviewed by Keith Miller.

There's no need to route through JSGlobalObject when producing code --
it just made the code harder to read.

This patch moves functions from JSGlobalObject to their singleton
call sites.

• runtime/CodeCache.cpp:

(JSC::CodeCache::getUnlinkedEvalCodeBlock):
(JSC::CodeCache::getUnlinkedGlobalEvalCodeBlock): Deleted.

• runtime/CodeCache.h:
• runtime/DirectEvalExecutable.cpp:

(JSC::DirectEvalExecutable::create):

• runtime/IndirectEvalExecutable.cpp:

(JSC::IndirectEvalExecutable::create):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::createProgramCodeBlock): Deleted.
(JSC::JSGlobalObject::createLocalEvalCodeBlock): Deleted.
(JSC::JSGlobalObject::createGlobalEvalCodeBlock): Deleted.
(JSC::JSGlobalObject::createModuleProgramCodeBlock): Deleted.

• runtime/JSGlobalObject.h:
• runtime/ModuleProgramExecutable.cpp:

(JSC::ModuleProgramExecutable::create):

• runtime/ProgramExecutable.cpp:

(JSC::ProgramExecutable::initializeGlobalProperties):

• runtime/ProgramExecutable.h:

1:22 PM Changeset in webkit [209195] by commit-queue@webkit.org

• 13 edits in trunk/Source/WebCore

Misc. cleanup in Modules/fetch
​https://bugs.webkit.org/show_bug.cgi?id=165240

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-12-01
Reviewed by Darin Adler.

• Modules/fetch/DOMWindowFetch.h:
• Modules/fetch/FetchBody.cpp:
• Modules/fetch/FetchBody.h:
• Modules/fetch/FetchBodyConsumer.cpp:
• Modules/fetch/FetchBodyOwner.cpp:
• Modules/fetch/FetchBodyOwner.h:
• Modules/fetch/FetchInternals.js:

(consumeStream):

• Modules/fetch/FetchLoader.cpp:
• Modules/fetch/FetchResponse.h:

Remove unnecessary includes and forward declarations.

• Modules/fetch/DOMWindowFetch.js:

(fetch):

• Modules/fetch/FetchResponse.js:

(initializeFetchResponse):

• Modules/fetch/WorkerGlobalScopeFetch.js:

(fetch):
Improve style.

1:10 PM Changeset in webkit [209194] by graouts@webkit.org

• 3 edits
  6 adds in trunk

[Modern Media Controls] Turn off text selection
​https://bugs.webkit.org/show_bug.cgi?id=165261

Reviewed by Dean Jackson.

We turn off text selection and force a non-text cursor for all text in media controls.

Tests: media/modern-media-controls/airplay-placard/airplay-placard-text-section.html

media/modern-media-controls/pip-placard/pip-placard-text-section.html
media/modern-media-controls/status-label/status-label-text-selection.html

• Modules/modern-media-controls/controls/media-controls.css:

(.media-controls):

1:09 PM MathML/Fonts edited by fred.wang@free.fr

(diff)

12:33 PM Changeset in webkit [209193] by Chris Dumez

• 6 edits in trunk

Parameter to DOMStringList.contains() should be mandatory
​https://bugs.webkit.org/show_bug.cgi?id=165257

Reviewed by Alex Christensen.

Source/WebCore:

Parameter to DOMStringList.contains() should be mandatory.
Gecko and Blink have it mandatory but WebKit had it optional and the
string 'undefined" was used by default, which is not helpful.

No new tests, updated existing test.

• dom/DOMStringList.idl:

LayoutTests:

Extend layout test coverage.

• storage/indexeddb/database-basics-expected.txt:
• storage/indexeddb/resources/database-basics.js:

(checkObjectStore):

12:12 PM Changeset in webkit [209192] by Beth Dakin

• 3 edits in trunk/Tools

Force clicking tests fail on some machines
​https://bugs.webkit.org/show_bug.cgi?id=165263

Reviewed by Tim Horton.

Initialize com.apple.trackpad.forceClick to 1 so that we don’t have to depend on
the user account having this feature enabled.

• WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:

(WTR::InjectedBundle::platformInitialize):

• WebKitTestRunner/mac/main.mm:

(setDefaultsToConsistentValuesForTesting):

11:42 AM Changeset in webkit [209191] by jiewen_tan@apple.com

• 6 edits
  2 adds in trunk

SubtleCrypto::deriveBits always return NOT_SUPPORTED_ERR for now
​https://bugs.webkit.org/show_bug.cgi?id=164745
<rdar://problem/29258118>

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• WebCryptoAPI/idlharness-expected.txt:

Source/WebCore:

Since we don't support any cryptography algorithms that has deriveBits operations,
SubtleCrypto::deriveBits will always return NOT_SUPPORTED_ERR for now.

Test: crypto/subtle/deriveBits-malformed-parameters.html

• bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::normalizeCryptoAlgorithmParameters):
(WebCore::jsSubtleCryptoFunctionDeriveBitsPromise):
(WebCore::JSSubtleCrypto::deriveBits):

• crypto/SubtleCrypto.idl:

LayoutTests:

• crypto/subtle/deriveBits-malformed-parameters-expected.txt: Added.
• crypto/subtle/deriveBits-malformed-parameters.html: Added.

11:33 AM Changeset in webkit [209190] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Marking media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-keyboard.html as failing on mac-wk1.
​https://bugs.webkit.org/show_bug.cgi?id=165262

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

11:31 AM Changeset in webkit [209189] by Antti Koivisto

• 12 edits in trunk/Source/WebKit2

Revert r208931
​https://bugs.webkit.org/show_bug.cgi?id=164924

PLT regression.

• NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::makeCacheKey):
(WebKit::NetworkCache::Cache::makeCacheKey): Deleted.

• NetworkProcess/cache/NetworkCache.h:
• NetworkProcess/cache/NetworkCacheBlobStorage.cpp:

(WebKit::NetworkCache::BlobStorage::BlobStorage):
(WebKit::NetworkCache::BlobStorage::add):
(WebKit::NetworkCache::BlobStorage::get):

• NetworkProcess/cache/NetworkCacheBlobStorage.h:
• NetworkProcess/cache/NetworkCacheData.cpp:

(WebKit::NetworkCache::computeSHA1):
(WebKit::NetworkCache::makeSalt): Deleted.
(WebKit::NetworkCache::readOrMakeSalt): Deleted.

• NetworkProcess/cache/NetworkCacheData.h:
• NetworkProcess/cache/NetworkCacheKey.cpp:

(WebKit::NetworkCache::noPartitionString):
(WebKit::NetworkCache::Key::Key):
(WebKit::NetworkCache::Key::hasPartition):
(WebKit::NetworkCache::Key::computeHash):
(WebKit::NetworkCache::Key::hashAsString):
(WebKit::NetworkCache::Key::computePartitionHash): Deleted.

• NetworkProcess/cache/NetworkCacheKey.h:

(WebKit::NetworkCache::Key::hash):
(WebKit::NetworkCache::Key::partitionHash): Deleted.
(WebKit::NetworkCache::Key::hashAsString): Deleted.
(WebKit::NetworkCache::Key::partitionHashAsString): Deleted.

• NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:

(WebKit::NetworkCache::makeSubresourcesKey):
(WebKit::NetworkCache::constructRevalidationRequest):
(WebKit::NetworkCache::SpeculativeLoadManager::PendingFrameLoad::saveToDiskIfReady):
(WebKit::NetworkCache::SpeculativeLoadManager::retrieveSubresourcesEntry):

• NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::open):
(WebKit::NetworkCache::traverseRecordsFiles):
(WebKit::NetworkCache::Storage::Storage):
(WebKit::NetworkCache::Storage::recordDirectoryPathForKey):
(WebKit::NetworkCache::decodeRecordHeader):
(WebKit::NetworkCache::Storage::readRecord):
(WebKit::NetworkCache::Storage::encodeRecord):
(WebKit::NetworkCache::Storage::traverse):
(WebKit::NetworkCache::makeSaltFilePath): Deleted.

• NetworkProcess/cache/NetworkCacheStorage.h:

(WebKit::NetworkCache::Storage::salt): Deleted.

11:27 AM Changeset in webkit [209188] by eric.carlson@apple.com

• 3 edits in trunk/Source/WebCore

[MediaStream][Mac] Video presets sometimes don't work
​https://bugs.webkit.org/show_bug.cgi?id=165214
<rdar://problem/29444533>

Reviewed by Jer Noble.

• platform/mediastream/mac/AVVideoCaptureSource.h:
• platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::setPreset): Set videoSettings width and height.
(WebCore::AVVideoCaptureSource::setupCaptureSession): Store videoSettings object for later use.

Set videoSettings width and height.

(WebCore::AVVideoCaptureSource::bestSessionPresetForVideoDimensions):
(WebCore::AVVideoCaptureSource::sizeForPreset): New.

10:41 AM Changeset in webkit [209187] by graouts@webkit.org

• 7 edits
  2 adds in trunk

[Modern Media Controls] Promote the "on" property from AirPlayButton to IconButton
​https://bugs.webkit.org/show_bug.cgi?id=165260

Reviewed by NOBODY (OOPS!).

With the fix for ​https://bugs.webkit.org/show_bug.cgi?id=165239 we now set the "on"
property for the TracksButton as well, so it makes sense to provide that property
for all IconButton subclasses, not just AirplayButton.

Test: media/modern-media-controls/icon-button/icon-button-on.html

• Modules/modern-media-controls/controls/airplay-button.css:

(button.airplay.on):

• Modules/modern-media-controls/controls/airplay-button.js:

(AirplayButton):
(AirplayButton.prototype.get on): Deleted.
(AirplayButton.prototype.set on): Deleted.

• Modules/modern-media-controls/controls/icon-button.css:

(button.icon:active,):
(button.icon:active): Deleted.

• Modules/modern-media-controls/controls/icon-button.js:

(IconButton.prototype.get on):
(IconButton.prototype.set on):

10:38 AM Changeset in webkit [209186] by graouts@webkit.org

• 3 edits
  2 adds in trunk/LayoutTests

[Modern Media Controls] Fix media/modern-media-controls/status-label/status-label.html
​https://bugs.webkit.org/show_bug.cgi?id=165259

Reviewed by Dean Jackson.

We broke the test at media/modern-media-controls/status-label/status-label.html with the
fix for ​https://bugs.webkit.org/show_bug.cgi?id=165239 since the test would test the
font-family for a StatusLabel which would only inherited to be -apple-system when hosted
in a MediaControls instance. We now remove this assertion and added a dedicated test
for when a StatusLabel is hosted in a MediaControls.

• media/modern-media-controls/status-label/status-label-expected.txt:
• media/modern-media-controls/status-label/status-label-font-expected.txt: Added.
• media/modern-media-controls/status-label/status-label-font.html: Added.
• media/modern-media-controls/status-label/status-label.html:

10:35 AM Changeset in webkit [209185] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Marking media/modern-media-controls/media-controller/media-controller-fullscreen-ltr.html as failing on mac-wk1.
​https://bugs.webkit.org/show_bug.cgi?id=165258

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

10:04 AM Changeset in webkit [209184] by weinig@apple.com

• 39 edits
  2 moves
  4 adds
  1 delete in trunk

[WebIDL] Remove custom bindings for File and Blob constructors
​https://bugs.webkit.org/show_bug.cgi?id=165218

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/fetch/api/basic/request-headers-expected.txt:
• web-platform-tests/fetch/api/basic/request-headers-worker-expected.txt:

Update results (still failing) to account for stricter rules about dictionary default values.

Source/WebCore:

• CMakeLists.txt:
• DerivedSources.make:
• WebCore.xcodeproj/project.pbxproj:

Add/remove new files.

• bindings/js/JSBlobCustom.cpp:

(WebCore::constructJSBlob): Deleted.

• bindings/js/JSFileCustom.cpp: Removed.

Remove custom constructors.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateDefaultValue):
(GenerateDictionaryImplementationContent):
(GenerateParametersCheck):
Add support for optional sequences without default values. Move string default value
optimizations into GenerateDefaultValue.

• fileapi/Blob.cpp:

(WebCore::Blob::Blob):

• fileapi/Blob.h:

(WebCore::Blob::create):

• fileapi/Blob.idl:
• fileapi/File.cpp:

(WebCore::File::File):

• fileapi/File.h:
• fileapi/File.idl:

Add support for the generated constructors.

• fileapi/BlobBuilder.cpp: Copied from Source/WebCore/fileapi/WebKitBlobBuilder.cpp.
• fileapi/BlobBuilder.h: Copied from Source/WebCore/fileapi/WebKitBlobBuilder.h.
• fileapi/WebKitBlobBuilder.cpp: Removed.
• fileapi/WebKitBlobBuilder.h: Removed.

Rename WebKitBlobBuilder to BlobBuilder, and update to work with generated constructor.

• fileapi/BlobPropertyBag.h: Added.
• fileapi/BlobPropertyBag.idl: Added.

Added.

• fileapi/ThreadableBlobRegistry.cpp:

(WebCore::ThreadableBlobRegistry::registerBlobURL):

• fileapi/ThreadableBlobRegistry.h:
• platform/network/BlobRegistry.h:
• platform/network/BlobRegistryImpl.cpp:

(WebCore::BlobRegistryImpl::registerBlobURL):

• platform/network/BlobRegistryImpl.h:

Avoid copies of the BlobPart Vector.

• platform/network/BlobPart.h:

Replace header-guards with #pragma once.

Source/WebKit2:

• NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:

(WebKit::NetworkBlobRegistry::registerBlobURL):

• NetworkProcess/FileAPI/NetworkBlobRegistry.h:
• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::registerBlobURL):

• NetworkProcess/NetworkConnectionToWebProcess.h:
• WebProcess/FileAPI/BlobRegistryProxy.cpp:

(WebKit::BlobRegistryProxy::registerBlobURL):

• WebProcess/FileAPI/BlobRegistryProxy.h:

Avoid copies of the BlobPart Vector.

LayoutTests:

• fast/files/blob-constructor-expected.txt:
• fast/files/file-constructor-expected.txt:
• fast/files/file-constructor.html:
• fast/files/script-tests/blob-constructor.js:

Update for stricter parsing and changed error text. (The error text
is regressed, but consistent with all generated bindings. I will work
on making improvements on this soon.)

• http/tests/fetch/fetch-as-blob.js:

Update to account for stricter rules about dictionary default values.

9:48 AM Changeset in webkit [209183] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Marking media/modern-media-controls/audio/audio-controls-buttons.html as a timeout.
​https://bugs.webkit.org/show_bug.cgi?id=165234

Unreviewed test gardening.

• platform/mac/TestExpectations:

8:16 AM Changeset in webkit [209182] by graouts@webkit.org

• 13 edits
  19 adds in trunk

[Modern Media Controls] Provide a UI object to show a list of tracks
​https://bugs.webkit.org/show_bug.cgi?id=165239

Reviewed by Dean Jackson.

We add a new TracksPanel object which we will be using to display a list of
audio and text tracks. The tracks panel can be shown by calling showTracksPanel()
on a MacOSMediaControls object and will be dismissed by hitting the Escape key
or mousing down outside of the panel's bounds. While the tracks panel is up,
arrows can be used to focus individual tracks which can be activated by either
pressing the Space bar or Enter key.

Activating a track will briefly animate its background to indicate selection and
dismissing the tracks panel is also animated with a quick fade-out animation.

Data for the tracks panel is provided by specifying a dataSource property and
implementing the required methods to provide the number of sections in the panel,
the number of tracks in each section, etc.

Tests: media/modern-media-controls/tracks-panel/tracks-panel-hide-click-outside.html

media/modern-media-controls/tracks-panel/tracks-panel-hide-esc-key.html
media/modern-media-controls/tracks-panel/tracks-panel-hide.html
media/modern-media-controls/tracks-panel/tracks-panel-population.html
media/modern-media-controls/tracks-panel/tracks-panel-right-x.html
media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-keyboard.html
media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-mouse.html
media/modern-media-controls/tracks-panel/tracks-panel.html

• Modules/modern-media-controls/controls/macos-fullscreen-media-controls.css:

(.media-controls.mac.fullscreen):
(.media-controls.mac.fullscreen > .controls-bar):
(.media-controls.mac.fullscreen .tracks-panel):

• Modules/modern-media-controls/controls/macos-inline-media-controls.css:

(.media-controls.mac.inline .tracks-panel):

• Modules/modern-media-controls/controls/macos-media-controls.js:

(MacOSMediaControls.prototype.showTracksPanel):
(MacOSMediaControls.prototype.hideTracksPanel):
(MacOSMediaControls):

• Modules/modern-media-controls/controls/media-controls.css:

(.media-controls):

• Modules/modern-media-controls/controls/placard.css:

(.placard):

• Modules/modern-media-controls/controls/status-label.css:

(.status-label):

• Modules/modern-media-controls/controls/tracks-panel.css: Added.

(.tracks-panel):
(.tracks-panel *):
(.tracks-panel.fade-out):
(.tracks-panel-section):
(.tracks-panel-section:first-of-type):
(.tracks-panel-section > h3):
(.tracks-panel-section > ul):
(.tracks-panel-section > ul > li):
(.tracks-panel-section > ul > li:focus):
(.tracks-panel-section > ul > li.selected:before):
(.tracks-panel-section > ul > li.animated):
(@keyframes tracks-panel-item-selection):
(22.22%):

• Modules/modern-media-controls/controls/tracks-panel.js: Added.

(TracksPanel.prototype.get presented):
(TracksPanel.prototype.presentInParent):
(TracksPanel.prototype.hide):
(TracksPanel.prototype.get rightX):
(TracksPanel.prototype.set rightX):
(TracksPanel.prototype.trackNodeSelectionAnimationDidEnd):
(TracksPanel.prototype.mouseMovedOverTrackNode):
(TracksPanel.prototype.mouseExitedTrackNode):
(TracksPanel.prototype.commitProperty):
(TracksPanel.prototype.handleEvent):
(TracksPanel.prototype._childrenFromDataSource.):
(TracksPanel.prototype._childrenFromDataSource):
(TracksPanel.prototype._handleMousedown):
(TracksPanel.prototype._handleKeydown):
(TracksPanel.prototype._dismiss):
(TracksPanel.prototype._focusTrackNode):
(TracksPanel.prototype._focusPreviousTrackNode):
(TracksPanel.prototype._focusNextTrackNode):
(TracksPanel.prototype._focusFirstTrackNode):
(TracksPanel.prototype._focusLastTrackNode):
(TrackNode):
(TrackNode.prototype.activate):
(TrackNode.prototype.handleEvent):
(TrackNode.prototype._animationDidEnd):

• Modules/modern-media-controls/js-files:
• WebCore.xcodeproj/project.pbxproj:

8:15 AM Changeset in webkit [209181] by akling@apple.com

• 7 edits
  3 adds in trunk/Source/WebCore

Log some basic memory usage stats at interesting points in time
<​https://webkit.org/b/165206>

Reviewed by Antti Koivisto.

This patch adds a mechanism to mark points of interests where we might
want to do performance-related logging:

class PerformanceLogging {

enum PointOfInterest {

MainFrameLoadStarted,
MainFrameLoadCompleted,

}
void didReachPointOfInterest(PointOfInterest)

}

You get to this object via MainFrame::performanceLogging().

We respond to these callbacks by logging some basic data about memory usage
to the PerformanceLogging channel.

More PointOfInterest values will be added soon.

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:
• loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::setState):

• page/MainFrame.cpp:

(WebCore::MainFrame::MainFrame):

• page/MainFrame.h:
• page/PerformanceLogging.cpp: Added.

(WebCore::toString):
(WebCore::getMemoryUsageStatistics):
(WebCore::PerformanceLogging::PerformanceLogging):
(WebCore::writeLog):
(WebCore::PerformanceLogging::didReachPointOfInterest):
(WebCore::PerformanceLogging::getPlatformMemoryUsageStatistics):

• page/PerformanceLogging.h: Added.
• page/cocoa/PerformanceLoggingCocoa.mm: Added.

(WebCore::PerformanceLogging::getPlatformMemoryUsageStatistics):

• platform/Logging.h:

3:05 AM Changeset in webkit [209180] by svillar@igalia.com

• 3 edits in trunk/Source/WebCore

[css-grid] Move more attributes from RenderGrid to the new Grid class
​https://bugs.webkit.org/show_bug.cgi?id=165094

Reviewed by Darin Adler.

Moved more attributes from RenderGrid to Grid as they are not really part of the state of
the RenderGrid object. In particular m_autoRepeat{Columns|Rows},
m_autoRepeatEmpty{Columns|Rows} and m_orderIterator. All of them are now private attributes
of the Grid class so clients should use the getters/setters provided by this patch.

This change allows to definitely remove the grid{Column|Row}Count() methods from
RenderGrid. These two became Grid::numTracks() which returns the number of tracks in the
data structure used to represent the grid (currently a matrix). Contrary to that,
RenderGrid::numTracks() returns the actual size of the grid.

No new tests as this is a refactoring.

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::Grid::numTracks):
(WebCore::RenderGrid::Grid::ensureGridSize):
(WebCore::RenderGrid::Grid::setAutoRepeatTracks):
(WebCore::RenderGrid::Grid::autoRepeatTracks):
(WebCore::RenderGrid::Grid::setAutoRepeatEmptyColumns):
(WebCore::RenderGrid::Grid::setAutoRepeatEmptyRows):
(WebCore::RenderGrid::Grid::hasAutoRepeatEmptyTracks):
(WebCore::RenderGrid::Grid::isEmptyAutoRepeatTrack):
(WebCore::RenderGrid::Grid::autoRepeatEmptyTracks):
(WebCore::RenderGrid::Grid::gridItemSpan):
(WebCore::RenderGrid::Grid::clear):
(WebCore::RenderGrid::RenderGrid):
(WebCore::RenderGrid::computeTrackSizesForDirection):
(WebCore::RenderGrid::guttersSize):
(WebCore::RenderGrid::computeIntrinsicLogicalHeight):
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::RenderGrid::rawGridTrackSize):
(WebCore::RenderGrid::gridTrackSize):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
(WebCore::RenderGrid::computeEmptyTracksForAutoRepeat):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator):
(WebCore::RenderGrid::createEmptyGridAreaAtSpecifiedPositionsOutsideGrid):
(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid):
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
(WebCore::RenderGrid::trackSizesForComputedStyle):
(WebCore::RenderGrid::offsetAndBreadthForPositionedChild):
(WebCore::RenderGrid::assumedRowsSizeForOrthogonalChild):
(WebCore::RenderGrid::gridAreaBreadthForChild):
(WebCore::RenderGrid::gridAreaBreadthForChildIncludingAlignmentOffsets):
(WebCore::RenderGrid::populateGridPositionsForDirection):
(WebCore::RenderGrid::columnAxisOffsetForChild):
(WebCore::RenderGrid::rowAxisOffsetForChild):
(WebCore::RenderGrid::numTracks):
(WebCore::RenderGrid::paintChildren):
(WebCore::RenderGrid::gridColumnCount): Deleted.
(WebCore::RenderGrid::gridRowCount): Deleted.
(WebCore::RenderGrid::hasAutoRepeatEmptyTracks): Deleted.
(WebCore::RenderGrid::isEmptyAutoRepeatTrack): Deleted.
(WebCore::RenderGrid::cachedGridSpan): Deleted.

• rendering/RenderGrid.h:

(WebCore::RenderGrid::autoRepeatCountForDirection): Deleted.

1:24 AM Changeset in webkit [209179] by Yusuke Suzuki

• 7 edits in trunk

Introduce StringImpl::StaticStringImpl with constexpr constructor
​https://bugs.webkit.org/show_bug.cgi?id=165093

Reviewed by Darin Adler.

Source/WTF:

This patch adds new class, StringImpl::StaticStringImpl.
By using this class, we can easily create static StringImpls.
This class has constexpr constructor. You can initialize instances
of this class as global static variables without invoking global
constructors.

We already have similar system, StaticASCIILiteral. But using it
requires some special perl script since we need to calculate
hash value. On the other hand, we can use StaticStringImpl without
any script supports since we implement constexpr hash function.
In the future, we will replace all the use of StaticASCIILiteral
with this StaticStringImpl.

We define empty / null strings as StaticStringImpl. And we make
StringImpl::empty() & StringImpl::null() inline functions.

• wtf/Hasher.h:

(WTF::StringHasher::hashWithTop8BitsMasked):
(WTF::StringHasher::hash):
(WTF::StringHasher::finalize):
(WTF::StringHasher::finalizeAndMaskTop8Bits):
(WTF::StringHasher::computeLiteralHash):
(WTF::StringHasher::computeLiteralHashAndMaskTop8Bits):
(WTF::StringHasher::avalancheBits3):
(WTF::StringHasher::avalancheBits2):
(WTF::StringHasher::avalancheBits1):
(WTF::StringHasher::avalancheBits0):
(WTF::StringHasher::avalancheBits):
(WTF::StringHasher::avoidZero):
(WTF::StringHasher::processPendingCharacter):
(WTF::StringHasher::calculateWithRemainingLastCharacter1):
(WTF::StringHasher::calculateWithRemainingLastCharacter0):
(WTF::StringHasher::calculateWithRemainingLastCharacter):
(WTF::StringHasher::calculate1):
(WTF::StringHasher::calculate0):
(WTF::StringHasher::calculate):
(WTF::StringHasher::computeLiteralHashImpl):

• wtf/text/StringImpl.cpp:
• wtf/text/StringImpl.h:

(WTF::StringImpl::StaticStringImpl::StaticStringImpl):
(WTF::StringImpl::null):
(WTF::StringImpl::empty):

• wtf/text/StringStatics.cpp:

(WTF::StringImpl::null): Deleted.
(WTF::StringImpl::empty): Deleted.

Tools:

• TestWebKitAPI/Tests/WTF/StringImpl.cpp:

(TestWebKitAPI::TEST):

1:22 AM Changeset in webkit [209178] by pvollan@apple.com

• 3 edits in trunk/JSTests

[Win] Skip failing JSC tests.
​https://bugs.webkit.org/show_bug.cgi?id=165140

Reviewed by Mark Lam.

• ChakraCore.yaml:
• microbenchmarks/tan.js:

Nov 30, 2016:

11:51 PM Changeset in webkit [209177] by Carlos Garcia Campos

• 3 edits in trunk/Source/WebKit2

[GTK] UI process crash in WebKit::WaylandCompositor::Surface::prepareTextureForPainting
​https://bugs.webkit.org/show_bug.cgi?id=164911

Reviewed by Michael Catanzaro.

The problem is that m_buffer is nullptr in Surface::prepareTextureForPainting() even though we have already an
image. We only use the buffer to get the image size, so we could save the image size when the image is created,
and then we don't need to care about the buffer anymore.

• UIProcess/gtk/WaylandCompositor.cpp:

(WebKit::WaylandCompositor::Surface::prepareTextureForPainting):
(WebKit::WaylandCompositor::Surface::commit):

• UIProcess/gtk/WaylandCompositor.h:

11:05 PM Changeset in webkit [209176] by beidson@apple.com

• 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r209168.

Caused 2 API tests to fail

Reverted changeset:

"IndexedDB: When doing puts, don't
"updateAllIndexesForAddRecord" if there are no indexes."
​https://bugs.webkit.org/show_bug.cgi?id=165215
​http://trac.webkit.org/changeset/209168

11:04 PM Changeset in webkit [209175] by jfbastien@apple.com

• 22 edits in trunk

WebAssembly: update binary format to 0xD version
​https://bugs.webkit.org/show_bug.cgi?id=164724

Reviewed by Saam Barati.

As described in the following PR: ​https://github.com/WebAssembly/design/pull/836

JSTests:

• wasm/Builder.js:

(const._normalizeFunctionSignature):

• wasm/Builder_WebAssemblyBinary.js:

(const.emitters.Type):
(const.emitters.Code):

• wasm/LowLevelBinary.js:

(export.default.LowLevelBinary.prototype.block_type):
(export.default.LowLevelBinary.prototype.inline_signature_type): Deleted.

• wasm/WASM.js:
• wasm/js-api/test_basic_api.js:
• wasm/self-test/test_BuilderWebAssembly.js:

(EmptyModule):
(CustomSection):

• wasm/self-test/test_WASM.js:
• wasm/wasm.json:

Source/JavaScriptCore:

• wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::B3IRGenerator::zeroForType):
(JSC::Wasm::B3IRGenerator::addConstant):
(JSC::Wasm::createJSWrapper):

• wasm/WasmCallingConvention.h:

(JSC::Wasm::CallingConvention::marshallArgument):

• wasm/WasmFormat.cpp:

(JSC::Wasm::toString): Deleted.

• wasm/WasmFormat.h:

(JSC::Wasm::isValueType):
(JSC::Wasm::toB3Type): Deleted.

• wasm/WasmFunctionParser.h:

(JSC::Wasm::FunctionParser<Context>::parseExpression):

• wasm/WasmModuleParser.cpp:

(JSC::Wasm::ModuleParser::parse):
(JSC::Wasm::ModuleParser::parseType):

• wasm/WasmModuleParser.h:
• wasm/WasmParser.h:

(JSC::Wasm::Parser::parseResultType):

• wasm/generateWasm.py:

(Wasm.init):

• wasm/generateWasmOpsHeader.py:

(cppMacro):
(typeMacroizer):
(opcodeMacroizer):

• wasm/wasm.json:

9:25 PM Changeset in webkit [209174] by Gyuyoung Kim

• 2 edits in trunk/Source/WebCore

Build break when using --minimal
​https://bugs.webkit.org/show_bug.cgi?id=165238

Reviewed by Darin Adler.

• css/parser/CSSSelectorParser.cpp:

(WebCore::CSSSelectorParser::consumePseudo): Use #if ENABLE(VIDEO_TRACK) guard.

8:32 PM Changeset in webkit [209173] by Darin Adler

• 5 edits in trunk/Source

Roll out StringBuilder changes from the previous patch.
They were a slowdown on a Kraken JSON test.

7:56 PM Changeset in webkit [209172] by Yusuke Suzuki

• 3 edits
  2 adds in trunk

[JSC] Specifying same module entry point multiple times cause TypeError
​https://bugs.webkit.org/show_bug.cgi?id=164858

Reviewed by Saam Barati.

Source/JavaScriptCore:

Allow importing the same module multiple times. Previously, when specifying the same
module in the <script type="module" src="here">, it throws TypeError.

• builtins/ModuleLoaderPrototype.js:

(requestFetch):
(requestTranslate):
(requestInstantiate):
(requestSatisfy):

LayoutTests:

• js/dom/modules/module-load-same-module-from-different-entry-point-in-src-expected.txt: Added.
• js/dom/modules/module-load-same-module-from-different-entry-point-in-src.html: Added.

7:54 PM Changeset in webkit [209171] by Yusuke Suzuki

• 11 edits in trunk/Source/JavaScriptCore

WebAssembly JS API: export a module namespace object instead of a module environment
​https://bugs.webkit.org/show_bug.cgi?id=165121

Reviewed by Saam Barati.

This patch setup AbstractModuleRecord further for WebAssemblyModuleRecord.
For exported entries in a wasm instance, we set up exported entries for
AbstractModuleRecord. This allows us to export WASM exported functions in
the module handling code.

Since the exported entries in the abstract module record are correctly
instantiated, the module namespace object for WASM module also starts
working correctly. So we start exposing the module namespace object
as instance.exports instead of the module environment object.

And we move SourceCode, lexicalVariables, and declaredVariables fields to
JSModuleRecord since they are related to JS source code (in the spec words,
they are related to the source text module record).

• runtime/AbstractModuleRecord.cpp:

(JSC::AbstractModuleRecord::AbstractModuleRecord):

• runtime/AbstractModuleRecord.h:

(JSC::AbstractModuleRecord::sourceCode): Deleted.
(JSC::AbstractModuleRecord::declaredVariables): Deleted.
(JSC::AbstractModuleRecord::lexicalVariables): Deleted.

• runtime/JSModuleRecord.cpp:

(JSC::JSModuleRecord::JSModuleRecord):

• runtime/JSModuleRecord.h:

(JSC::JSModuleRecord::sourceCode):
(JSC::JSModuleRecord::declaredVariables):
(JSC::JSModuleRecord::lexicalVariables):

• wasm/WasmFormat.cpp:
• wasm/js/JSWebAssemblyInstance.cpp:

(JSC::JSWebAssemblyInstance::finishCreation):

• wasm/js/WebAssemblyFunction.cpp:
• wasm/js/WebAssemblyInstanceConstructor.cpp:

(JSC::constructJSWebAssemblyInstance):

• wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::create):
(JSC::WebAssemblyModuleRecord::WebAssemblyModuleRecord):
(JSC::WebAssemblyModuleRecord::finishCreation):
WebAssemblyModuleRecord::link should perform linking things.
So allocating exported entries should be done here.
(JSC::WebAssemblyModuleRecord::link):

• wasm/js/WebAssemblyModuleRecord.h:

7:20 PM Changeset in webkit [209170] by commit-queue@webkit.org

• 7 edits
  2 adds in trunk

[Modern Media Controls] Add support for right-to-left layouts
​https://bugs.webkit.org/show_bug.cgi?id=165229

Patch by Antoine Quint <Antoine Quint> on 2016-11-30
Reviewed by Dean Jackson.

Source/WebCore:

We implement the "usesLTRUserInterfaceLayoutDirection" property which is set by HTMLMediaElement
and set a CSS class when the layout is left-to-right, flipping the fullscreen volume slider in the
case that it would not be present (right-to-left).

Test: media/modern-media-controls/media-controller/media-controller-fullscreen-ltr.html

• Modules/modern-media-controls/controls/macos-fullscreen-media-controls.css:

(.media-controls.mac.fullscreen:not(.uses-ltr-user-interface-layout-direction) .volume.slider):

• Modules/modern-media-controls/controls/media-controls.js:

(MediaControls.prototype.get usesLTRUserInterfaceLayoutDirection):
(MediaControls.prototype.set usesLTRUserInterfaceLayoutDirection):

• Modules/modern-media-controls/media/media-controller.js:

(MediaController.prototype.set usesLTRUserInterfaceLayoutDirection):
(MediaController.prototype._updateControlsIfNeeded):

LayoutTests:

Add a test that toggles the layout direction and checks we correctly flip the volume slider.

• media/modern-media-controls/media-controller/media-controller-fullscreen-ltr-expected.txt: Added.
• media/modern-media-controls/media-controller/media-controller-fullscreen-ltr.html: Added.
• platform/ios-simulator/TestExpectations:
• platform/mac/TestExpectations:

7:16 PM Changeset in webkit [209169] by commit-queue@webkit.org

• 6 edits in trunk/Source/WebCore

Web Inspector: Remove unused parameter of InspectorInstrumentation::didFinishXHRLoading
​https://bugs.webkit.org/show_bug.cgi?id=165233

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-11-30
Reviewed by Brian Burg.

• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didFinishXHRLoadingImpl):

• inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didFinishXHRLoading):

• inspector/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::didFinishXHRLoading):

• inspector/InspectorNetworkAgent.h:
• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::didFinishLoading):
Remove unused ThreadableLoaderClient parameter.

6:42 PM Changeset in webkit [209168] by beidson@apple.com

• 2 edits in trunk/Source/WebCore

IndexedDB: When doing puts, don't "updateAllIndexesForAddRecord" if there are no indexes.
​https://bugs.webkit.org/show_bug.cgi?id=165215

Reviewed by Alex Christensen.

No new tests (No observable behavior change).

• Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::addRecord): Don't "updateAllIndexesForAddRecord" if there are no indexes.

Avoiding this saved us some IDBKey serialization and Javascript object manipulation.

6:33 PM Changeset in webkit [209167] by commit-queue@webkit.org

• 14 edits in trunk

[Modern Media Controls] LayoutNode: only mark properties as dirty if different than current value
​https://bugs.webkit.org/show_bug.cgi?id=165236

Patch by Antoine Quint <Antoine Quint> on 2016-11-30
Reviewed by Simon Fraser.

Source/WebCore:

Check that the new value is different than the current value before marking the property as dirty.

• Modules/modern-media-controls/controls/layout-node.js:

(LayoutNode.prototype.set x):
(LayoutNode.prototype.set y):
(LayoutNode.prototype.set width):
(LayoutNode.prototype.set height):
(LayoutNode.prototype.set visible):
(performScheduledLayout):

• Modules/modern-media-controls/controls/scheduler.js:

(const.scheduler.new.prototype.get hasScheduledLayoutCallbacks):

LayoutTests:

Update LayoutNode property tests to check that setting a given property to the
same value doesn't schedule an update.

• media/modern-media-controls/layout-node/height-expected.txt:
• media/modern-media-controls/layout-node/height.html:
• media/modern-media-controls/layout-node/visible-expected.txt:
• media/modern-media-controls/layout-node/visible.html:
• media/modern-media-controls/layout-node/width-expected.txt:
• media/modern-media-controls/layout-node/width.html:
• media/modern-media-controls/layout-node/x-expected.txt:
• media/modern-media-controls/layout-node/x.html:
• media/modern-media-controls/layout-node/y-expected.txt:
• media/modern-media-controls/layout-node/y.html:

5:11 PM Changeset in webkit [209166] by jiewen_tan@apple.com

• 6 edits
  2 adds in trunk

SubtleCrypto::deriveKey always return NOT_SUPPORTED_ERR for now
​https://bugs.webkit.org/show_bug.cgi?id=164744
<rdar://problem/29258083>

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• WebCryptoAPI/idlharness-expected.txt:

Source/WebCore:

Since we don't support any cryptography algorithms that has deriveKey operations,
SubtleCrypto::deriveKey will always return NOT_SUPPORTED_ERR for now.

Test: crypto/subtle/deriveKey-malformed-parameters.html

• bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::normalizeCryptoAlgorithmParameters):
(WebCore::jsSubtleCryptoFunctionDeriveKeyPromise):
(WebCore::JSSubtleCrypto::deriveKey):

• crypto/SubtleCrypto.idl:

LayoutTests:

• crypto/subtle/deriveKey-malformed-parameters-expected.txt: Added.
• crypto/subtle/deriveKey-malformed-parameters.html: Added.

5:03 PM Changeset in webkit [209165] by jfbastien@apple.com

• 25 edits in trunk/JSTests

WebAssembly builder: don't throw when checker not implemented
​https://bugs.webkit.org/show_bug.cgi?id=165219

Reviewed by Mark Lam.

We should perform whichever checks we've implemented, and assume the rest are OK until bug #163421 is fixed.

• wasm/Builder.js:
• wasm/README.md:
• wasm/function-tests/add-12.js:
• wasm/function-tests/br-if-loop-less-than.js:
• wasm/function-tests/brTableAsIf.js:
• wasm/function-tests/brTableManyValues.js:
• wasm/function-tests/brTableWithLoop.js:
• wasm/function-tests/dumb-eq-if-then-else.js:
• wasm/function-tests/dumb-less-than-fallthrough.js:
• wasm/function-tests/dumb-less-than-ite.js:
• wasm/function-tests/eqz.js:
• wasm/function-tests/factorial.js:
• wasm/function-tests/float-sub.js:
• wasm/function-tests/i32-load.js:
• wasm/function-tests/i32-load8-s.js:
• wasm/function-tests/if-then-else-fallthrough.js:
• wasm/function-tests/if-then-fallthrough.js:
• wasm/function-tests/loop-mult.js:
• wasm/function-tests/loop-sum.js:
• wasm/function-tests/max.js:
• wasm/function-tests/min.js:
• wasm/function-tests/ret5.js:
• wasm/function-tests/select.js:
• wasm/self-test/test_BuilderJSON.js:

4:28 PM Changeset in webkit [209164] by jiewen_tan@apple.com

• 19 edits
  27 adds in trunk

Update SubtleCrypto::digest to match the latest spec
​https://bugs.webkit.org/show_bug.cgi?id=164742
<rdar://problem/29258037>

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• WebCryptoAPI/digest/test_digest-expected.txt:
• WebCryptoAPI/idlharness-expected.txt:

Source/WebCore:

This patch updates the SubtleCrypto::digest method to match the latest spec:
​https://www.w3.org/TR/WebCryptoAPI/#SubtleCrypto-method-digest.
It also refers to the latest Editor's Draft to a certain degree:
​https://w3c.github.io/webcrypto/Overview.html#SubtleCrypto-method-digest.
Currently supported digest algorithms are SHA-1, SHA-224, SHA-256, SHA-384,
and SHA-512.

Tests: crypto/subtle/digest-malformed-parameters.html

crypto/subtle/sha1-digest.html
crypto/subtle/sha224-digest.html
crypto/subtle/sha256-digest.html
crypto/subtle/sha384-digest.html
crypto/subtle/sha512-digest.html
crypto/workers/subtle/sha1-digest.html
crypto/workers/subtle/sha224-digest.html
crypto/workers/subtle/sha256-digest.html
crypto/workers/subtle/sha384-digest.html
crypto/workers/subtle/sha512-digest.html

• bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::jsSubtleCryptoFunctionDigestPromise):
(WebCore::JSSubtleCrypto::digest):

• crypto/CryptoAlgorithm.cpp:

(WebCore::CryptoAlgorithm::digest):

• crypto/CryptoAlgorithm.h:
• crypto/SubtleCrypto.idl:
• crypto/algorithms/CryptoAlgorithmSHA1.cpp:

(WebCore::CryptoAlgorithmSHA1::digest):

• crypto/algorithms/CryptoAlgorithmSHA1.h:
• crypto/algorithms/CryptoAlgorithmSHA224.cpp:

(WebCore::CryptoAlgorithmSHA224::digest):

• crypto/algorithms/CryptoAlgorithmSHA224.h:
• crypto/algorithms/CryptoAlgorithmSHA256.cpp:

(WebCore::CryptoAlgorithmSHA256::digest):

• crypto/algorithms/CryptoAlgorithmSHA256.h:
• crypto/algorithms/CryptoAlgorithmSHA384.cpp:

(WebCore::CryptoAlgorithmSHA384::digest):

• crypto/algorithms/CryptoAlgorithmSHA384.h:
• crypto/algorithms/CryptoAlgorithmSHA512.cpp:

(WebCore::CryptoAlgorithmSHA512::digest):

• crypto/algorithms/CryptoAlgorithmSHA512.h:

LayoutTests:

• crypto/subtle/digest-malformed-parameters-expected.txt: Added.
• crypto/subtle/digest-malformed-parameters.html: Added.
• crypto/subtle/sha1-digest-expected.txt: Added.
• crypto/subtle/sha1-digest.html: Added.
• crypto/subtle/sha224-digest-expected.txt: Added.
• crypto/subtle/sha224-digest.html: Added.
• crypto/subtle/sha256-digest-expected.txt: Added.
• crypto/subtle/sha256-digest.html: Added.
• crypto/subtle/sha384-digest-expected.txt: Added.
• crypto/subtle/sha384-digest.html: Added.
• crypto/subtle/sha512-digest-expected.txt: Added.
• crypto/subtle/sha512-digest.html: Added.
• crypto/workers/subtle/resources/sha1-digest.js: Added.
• crypto/workers/subtle/resources/sha224-digest.js: Added.
• crypto/workers/subtle/resources/sha256-digest.js: Added.
• crypto/workers/subtle/resources/sha384-digest.js: Added.
• crypto/workers/subtle/resources/sha512-digest.js: Added.
• crypto/workers/subtle/sha1-digest-expected.txt: Added.
• crypto/workers/subtle/sha1-digest.html: Added.
• crypto/workers/subtle/sha224-digest-expected.txt: Added.
• crypto/workers/subtle/sha224-digest.html: Added.
• crypto/workers/subtle/sha256-digest-expected.txt: Added.
• crypto/workers/subtle/sha256-digest.html: Added.
• crypto/workers/subtle/sha384-digest-expected.txt: Added.
• crypto/workers/subtle/sha384-digest.html: Added.
• crypto/workers/subtle/sha512-digest-expected.txt: Added.
• crypto/workers/subtle/sha512-digest.html: Added.

4:14 PM Changeset in webkit [209163] by graouts@webkit.org

• 5 edits
  5 adds in trunk

[Modern Media Controls] UI Library: <audio> controls
​https://bugs.webkit.org/show_bug.cgi?id=164619
<rdar://problem/29207215>

Reviewed by Dean Jackson.

Add a default size for <audio> elements (200x50).

Tests: media/modern-media-controls/audio/audio-controls-buttons.html

media/modern-media-controls/audio/audio-controls-metrics.html

• Modules/modern-media-controls/controls/media-controls.css:

(:host(audio)):

4:10 PM Changeset in webkit [209162] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

TypeInfo::OutOfLineTypeFlags should be 16 bits in size.
​https://bugs.webkit.org/show_bug.cgi?id=165224

Reviewed by Saam Barati.

There's no reason for OutOfLineTypeFlags to be constraint to 8 bits since the
space is available to us. Making OutOfLineTypeFlags 16 bits brings TypeInfo up
to 32 bits in size from the current 24 bits.

• runtime/JSTypeInfo.h:

(JSC::TypeInfo::TypeInfo):

4:10 PM Changeset in webkit [209161] by graouts@webkit.org

• 12 edits in trunk

[Modern Media Controls] Add an HTML comment flag to turn the feature on
​https://bugs.webkit.org/show_bug.cgi?id=165226

Reviewed by Dean Jackson.

Source/WebKit2:

• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetModernMediaControlsEnabled):
(WKPreferencesGetModernMediaControlsEnabled):

• UIProcess/API/C/WKPreferencesRefPrivate.h:

Tools:

• DumpRenderTree/TestOptions.h:
• DumpRenderTree/TestOptions.mm:

(TestOptions::TestOptions):

• DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

• WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):

• WebKitTestRunner/TestOptions.h:
• WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(WTR::PlatformWebView::viewSupportsOptions):

• WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::viewSupportsOptions):

3:53 PM Changeset in webkit [209160] by beidson@apple.com

• 2 edits in trunk/Source/WebCore

REGRESSION (r209144): API test IndexedDB.DeleteRecovery failing.
​https://bugs.webkit.org/show_bug.cgi?id=165216

Rubberstamped by Tim Horton.

• Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::closeSQLiteDB): Change invalid ASSERT into a null check.

3:48 PM Changeset in webkit [209159] by commit-queue@webkit.org

• 23 edits in trunk

Add separate settings and preferences to enable/disable async decoding for large images and animated images
​https://bugs.webkit.org/show_bug.cgi?id=165177

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2016-11-30
Reviewed by Simon Fraser.
Source/WebCore:

Instead of having the async image decoding be controlled by one setting,
two separate settings are added:

largeImageAsyncDecodingEnabled
animatedImageAsyncDecodingEnabled

And an existing setting is removed:

asyncImageDecodingEnabled

• loader/cache/CachedImage.cpp:

(WebCore::CachedImage::load):

• loader/cache/CachedImage.h:
• page/Settings.in:
• platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::internalStartAnimation):

• platform/graphics/BitmapImage.h:
• platform/graphics/ImageObserver.h:

Source/WebKit/mac:

Hook up the async image decoding settings for WebKit1.

• WebView/WebPreferenceKeysPrivate.h:
• WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences largeImageAsyncDecodingEnabled]):
(-[WebPreferences setLargeImageAsyncDecodingEnabled:]):
(-[WebPreferences animatedImageAsyncDecodingEnabled]):
(-[WebPreferences setAnimatedImageAsyncDecodingEnabled:]):
(-[WebPreferences asyncImageDecodingEnabled]): Deleted.
(-[WebPreferences setAsyncImageDecodingEnabled:]): Deleted.

• WebView/WebPreferencesPrivate.h:
• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

Hook up the async image decoding settings for WebKit2.

• Shared/WebPreferencesDefinitions.h:
• UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _largeImageAsyncDecodingEnabled]):
(-[WKPreferences _setLargeImageAsyncDecodingEnabled:]):
(-[WKPreferences _animatedImageAsyncDecodingEnabled]):
(-[WKPreferences _setAnimatedImageAsyncDecodingEnabled:]):
(-[WKPreferences _asyncImageDecodingEnabled]): Deleted.
(-[WKPreferences _setAsyncImageDecodingEnabled:]): Deleted.

• UIProcess/API/Cocoa/WKPreferencesPrivate.h:
• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

Pref and a menu item to toggle async image decoding settings for WebKits 1 and 2.

• MiniBrowser/mac/SettingsController.h:
• MiniBrowser/mac/SettingsController.m:

(-[SettingsController _populateMenu]):
(-[SettingsController validateMenuItem:]):
(-[SettingsController toggleLargeImageAsyncDecodingEnabled:]):
(-[SettingsController largeImageAsyncDecodingEnabled]):
(-[SettingsController toggleAnimatedImageAsyncDecodingEnabled:]):
(-[SettingsController animatedImageAsyncDecodingEnabled]):
(-[SettingsController toggleAsyncImageDecodingEnabled:]): Deleted.
(-[SettingsController asyncImageDecodingEnabled]): Deleted.

• MiniBrowser/mac/WK1BrowserWindowController.m:

(-[WK1BrowserWindowController didChangeSettings]):

• MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController didChangeSettings]):

3:12 PM Changeset in webkit [209158] by Alan Bujtas

• 3 edits
  2 adds in trunk

ASSERTION FAILED: layoutState->m_renderer == this in WebCore::RenderBlock::offsetFromLogicalTopOfFirstPage
​https://bugs.webkit.org/show_bug.cgi?id=155364
<rdar://problem/27720461>

Reviewed by David Hyatt.

Source/WebCore:

RenderNamedFlowThread is considered to be a root for the current renderer context so
we need to bail out from the containing block traversal here (like we do for the RenderView).

Test: fast/replaced/replaced-element-with-percentage-width-inside-flow-asserts.html

• rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalHeightUsing):

LayoutTests:

• fast/replaced/replaced-element-with-percentage-width-inside-flow-asserts-expected.txt: Added.
• fast/replaced/replaced-element-with-percentage-width-inside-flow-asserts.html: Added.

2:59 PM Changeset in webkit [209157] by beidson@apple.com

• 2 edits in trunk/Source/WebCore

IndexedDB 2.0: Send operations off to the server in batches instead of one at a time.
​https://bugs.webkit.org/show_bug.cgi?id=165221

Reviewed by Myles C. Maxfield.

No new tests (No observable behavior change).

On a profile of "Lots of writes to an IndexedDB", timer scheduling/firing presented as over 10% of the time.

This patch negates much of that.

• Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::pendingOperationTimerFired): Send 100 operations off to the server

before spinning the runloop, instead of only 1.

2:45 PM Changeset in webkit [209156] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[Modern Media Controls] Controls are not visible when returning from picture-in-picture playback
​https://bugs.webkit.org/show_bug.cgi?id=165183

Patch by Antoine Quint <Antoine Quint> on 2016-11-30
Reviewed by Dean Jackson.

We need to call MediaControlsHost::setPreparedToReturnVideoLayerToInline() when we return from
picture-in-picture playback such that the video layer is correctly stacked under the media controls.
We call that function in a rAF call to ensure it's performed in sync with the next scheduled layout
or the media controls would not appear in sync with the video layer.

We also fix an error from a previous commit in ControlsVisibilitySupport.

• Modules/modern-media-controls/media/controls-visibility-support.js:

(ControlsVisibilitySupport.prototype.syncControl):
(ControlsVisibilitySupport):

• Modules/modern-media-controls/media/media-controller.js:

(MediaController):
(MediaController.prototype.handleEvent):
(MediaController.prototype._returnMediaLayerToInlineIfNeeded):

2:26 PM Changeset in webkit [209155] by jiewen_tan@apple.com

• 12 edits
  21 adds in trunk

Update SubtleCrypto::wrapKey to match the latest spec
​https://bugs.webkit.org/show_bug.cgi?id=164746
<rdar://problem/29258160>

Reviewed by Brent Fulgham.

LayoutTests/imported/w3c:

• WebCryptoAPI/idlharness-expected.txt:

Source/WebCore:

This patch does following few things:

1. It updates the SubtleCrypto::wrapKey method to match the latest spec: ​https://www.w3.org/TR/WebCryptoAPI/#SubtleCrypto-method-wrapKey. It also refers to the latest Editor's Draft to a certain degree: ​https://w3c.github.io/webcrypto/Overview.html#SubtleCrypto-method-wrapKey.
2. It implements wrapKey operations of the following algorithms: AES-KW.
3. It also replaces JSSubtleCrypto* with auto in all promise functions.

Tests: crypto/subtle/aes-cbc-import-key-wrap-jwk-rsa-key-private.html

crypto/subtle/aes-cbc-import-key-wrap-jwk-rsa-key-public.html
crypto/subtle/aes-kw-import-key-wrap-raw-key.html
crypto/subtle/aes-kw-wrap-key-malformed-parameters.html
crypto/subtle/rsa-oaep-import-key-wrap-jwk-oct-key.html
crypto/subtle/wrapKey-malformed-parameters.html
crypto/workers/subtle/aes-cbc-import-key-wrap-key.html
crypto/workers/subtle/aes-kw-import-key-wrap-key.html
crypto/workers/subtle/rsa-oaep-import-key-wrap-key.html

• bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::normalizeCryptoAlgorithmParameters):
(WebCore::supportExportKeyThrow):
(WebCore::jsSubtleCryptoFunctionEncryptPromise):
(WebCore::jsSubtleCryptoFunctionDecryptPromise):
(WebCore::jsSubtleCryptoFunctionExportKeyPromise):
(WebCore::jsSubtleCryptoFunctionWrapKeyPromise):
(WebCore::JSSubtleCrypto::wrapKey):

• crypto/CryptoAlgorithm.cpp:

(WebCore::CryptoAlgorithm::wrapKey):

• crypto/CryptoAlgorithm.h:
• crypto/SubtleCrypto.idl:
• crypto/algorithms/CryptoAlgorithmAES_KW.cpp:

(WebCore::CryptoAlgorithmAES_KW::wrapKey):

• crypto/algorithms/CryptoAlgorithmAES_KW.h:
• crypto/gnutls/CryptoAlgorithmAES_KWGnuTLS.cpp:

(WebCore::CryptoAlgorithmAES_KW::platformWrapKey):

• crypto/mac/CryptoAlgorithmAES_KWMac.cpp:

(WebCore::wrapKeyAES_KW):
(WebCore::CryptoAlgorithmAES_KW::platformWrapKey):
(WebCore::CryptoAlgorithmAES_KW::platformEncrypt):

LayoutTests:

• crypto/subtle/aes-cbc-import-key-wrap-jwk-rsa-key-private-expected.txt: Added.
• crypto/subtle/aes-cbc-import-key-wrap-jwk-rsa-key-private.html: Added.
• crypto/subtle/aes-cbc-import-key-wrap-jwk-rsa-key-public-expected.txt: Added.
• crypto/subtle/aes-cbc-import-key-wrap-jwk-rsa-key-public.html: Added.
• crypto/subtle/aes-kw-import-key-wrap-raw-key-expected.txt: Added.
• crypto/subtle/aes-kw-import-key-wrap-raw-key.html: Added.
• crypto/subtle/aes-kw-wrap-key-malformed-parameters-expected.txt: Added.
• crypto/subtle/aes-kw-wrap-key-malformed-parameters.html: Added.
• crypto/subtle/rsa-oaep-import-key-wrap-jwk-oct-key-expected.txt: Added.
• crypto/subtle/rsa-oaep-import-key-wrap-jwk-oct-key.html: Added.
• crypto/subtle/wrapKey-malformed-parameters-expected.txt: Added.
• crypto/subtle/wrapKey-malformed-parameters.html: Added.
• crypto/workers/subtle/aes-cbc-import-key-wrap-key-expected.txt: Added.
• crypto/workers/subtle/aes-cbc-import-key-wrap-key.html: Added.
• crypto/workers/subtle/aes-kw-import-key-wrap-key-expected.txt: Added.
• crypto/workers/subtle/aes-kw-import-key-wrap-key.html: Added.
• crypto/workers/subtle/resources/aes-cbc-import-key-wrap-key.js: Added.
• crypto/workers/subtle/resources/aes-kw-import-key-wrap-key.js: Added.
• crypto/workers/subtle/resources/rsa-oaep-import-key-wrap-key.js: Added.
• crypto/workers/subtle/rsa-oaep-import-key-wrap-key-expected.txt: Added.
• crypto/workers/subtle/rsa-oaep-import-key-wrap-key.html: Added.

2:21 PM Changeset in webkit [209154] by commit-queue@webkit.org

• 4 edits in trunk

REGRESSION: inspector/sampling-profiler/* LayoutTests are flaky timeouts
​https://bugs.webkit.org/show_bug.cgi?id=164388
<rdar://problem/29101555>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-11-30
Reviewed by Saam Barati.

Source/JavaScriptCore:

There was a possibility of a deadlock between the main thread and the GC thread
with the SamplingProfiler lock when Inspector is processing samples to send to
the frontend. The Inspector (main thread) was holding the SamplingProfiler lock
while processing samples, which runs JavaScript that could trigger a GC, and
GC then tries to acquire the SamplingProfiler lock to process unprocessed samples.

A simple solution here is to tighten the bounds of when Inspector holds the
SamplingProfiler lock. It only needs the lock when extracting samples from
the SamplingProfiler. It doesn't need to hold the lock for processing those
samples, which is what can run script and cause a GC.

• inspector/agents/InspectorScriptProfilerAgent.cpp:

(Inspector::InspectorScriptProfilerAgent::trackingComplete):
Tighten bounds of this lock to only where it is needed.

LayoutTests:

• platform/mac/TestExpectations:

Unskip now that tests are no longer flakey.

2:10 PM Changeset in webkit [209153] by weinig@apple.com

• 21 edits in trunk/Source/WebCore

[WebIDL] Add support for more missing / exotic IDLTypes
​https://bugs.webkit.org/show_bug.cgi?id=165156

Reviewed by Alex Christensen.

• Adds JSDOMConvert support for WebIDL's 'callback interface' and 'callback function'.
• Adds JSDOMConvert support for WebIDL extensions for SerializedScriptValue, Dictionary, EventListener and XPathNSResolver (moving much of their special casing out of perl and into JSDOMConvert).

• DerivedSources.make:

Adds $(WebCore)/testing to the list of available IDL directories to keep internals
compiling.

• Modules/webaudio/WaveShaperNode.cpp:
• Modules/webaudio/WaveShaperNode.h:

Update to take curve by reference.

• bindings/generic/IDLTypes.h:

(WebCore::IDLWrapper):
Add helper type, IDLWrapper, which serves as a base type for all IDLTypes that are
RefCounted.

• bindings/js/JSDOMConvert.h:

(WebCore::convert):
(WebCore::Converter<IDLNullable<T>>::convert):
(WebCore::Converter<IDLCallbackFunction<T>>::convert):
(WebCore::JSConverter<IDLCallbackFunction<T>>::convert):
(WebCore::JSConverter<IDLCallbackFunction<T>>::convertNewlyCreated):
(WebCore::Converter<IDLCallbackInterface<T>>::convert):
(WebCore::JSConverter<IDLCallbackInterface<T>>::convert):
(WebCore::JSConverter<IDLCallbackInterface<T>>::convertNewlyCreated):
(WebCore::Converter<IDLSerializedScriptValue<T>>::convert):
(WebCore::JSConverter<IDLSerializedScriptValue<T>>::convert):
(WebCore::Converter<IDLLegacyDictionary<T>>::convert):
(WebCore::Converter<IDLEventListener<T>>::convert):
(WebCore::Converter<IDLXPathNSResolver<T>>::convert):
(WebCore::JSConverter<IDLXPathNSResolver<T>>::convert):
(WebCore::JSConverter<IDLXPathNSResolver<T>>::convertNewlyCreated):
Add converters for the new types. IDLSerializedScriptValue, IDLLegacyDictionary, IDLEventListener and IDLXPathNSResolver
have been templatized to avoid including their implementation classes everywhere. We can improve this in the future by
splitting JSDOMConvert up into to separate files.

• bindings/scripts/CodeGenerator.pm:

(IsBuiltinType):
(IsInterfaceType):
(IsWrapperType):
(ComputeIsCallbackInterface):
(ComputeIsCallbackFunction):
Add new predicates, IsBuiltinType and IsInterfaceType, and re-work IsWrapperType to determine all types that
have a JS wrapper (and consequently a JS{name}.h file).

• bindings/scripts/CodeGeneratorJS.pm:

(AddToIncludesForIDLType):
Update to add include for EventListener.

(GetArgumentExceptionFunction):
(GetArgumentExceptionThrower):
(GetAttributeExceptionFunction):
(GetAttributeExceptionThrower):
Add support for exceptions for callbacks.

(PassArgumentExpression):
Factor out logic on how to pass arguments to C++.

(GenerateHeader):
Make toWrapped and JSDOMWrapperConverterTraits work with XPathNSResolver.

(GenerateImplementation):
Update to use PassArgumentExpression and pass a global object reference to JSValueToNative.

(GenerateParametersCheck):
Remove special casing for callbacks.

(GenerateCallbackHeaderContent):
(GenerateCallbackImplementationContent):
Simplify toJS functions. State and global object are not necessary.

(GetBaseIDLType):
Add support for new types. Add assertion so that unknown types can't get through.

(ShouldPassArgumentByReference):
Rename from ShouldPassWrapperByReference, and merge in CodeGenerator's ShouldPassWrapperByReference.

(JSValueToNativeDOMConvertNeedsThisObject):
Added. Predicate to determine types that need a this object for conversion.

(JSValueToNativeDOMConvertNeedsGlobalObject):
Added. Predicate to determine types that need a global object for conversion.

(JSValueToNative):
Remove special cases for new types.

(NativeToJSValueDOMConvertNeedsState):
Add SerializedScriptValue and XPathNSResolver.

(NativeToJSValueDOMConvertNeedsGlobalObject):
Add SerializedScriptValue and XPathNSResolver.

(NativeToJSValueUsingReferences):
(NativeToJSValueUsingPointers):
(NativeToJSValue):
Remove unused $statePointer and replace $globalObject with $globalObjectReference. Remove
special cases for new types.

(GenerateConstructorDefinition):
Use PassArgumentExpression.

• bindings/scripts/test/JS/JSTestCallbackFunction.cpp:
• bindings/scripts/test/JS/JSTestCallbackFunction.h:
• bindings/scripts/test/JS/JSTestCallbackFunctionWithTypedefs.cpp:
• bindings/scripts/test/JS/JSTestCallbackFunctionWithTypedefs.h:
• bindings/scripts/test/JS/JSTestCallbackInterface.cpp:
• bindings/scripts/test/JS/JSTestCallbackInterface.h:
• bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
• bindings/scripts/test/JS/JSTestObj.cpp:
• bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
• bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
• bindings/scripts/test/JS/JSTestTypedefs.cpp:
• bindings/scripts/test/TestObj.idl:
• bindings/scripts/test/TestSerializedScriptValueInterface.idl:

Update tests. Remove test for a readonly attribute returning a Promise, which is not supported
yet (this was caught by the assertion added to GetBaseIDLType). Add tests for passing and returning
SerializedScriptValues from functions.

1:52 PM EnvironmentVariables edited by clopez@igalia.com

(diff)

1:42 PM Changeset in webkit [209152] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Skipping crashing test js/dom/modules/module-will-fire-beforeload.html.
​https://bugs.webkit.org/show_bug.cgi?id=164883

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

1:42 PM Changeset in webkit [209151] by Chris Dumez

• 2 edits in trunk/Source/WebKit2

[iOS][WK2] Turn on HTML interactive form validation feature
​https://bugs.webkit.org/show_bug.cgi?id=165212
<rdar://problem/29444356>

Reviewed by Simon Fraser.

Turn on HTML interactive form validation feature on iOS WK2
now that we have a native UI.

• Shared/WebPreferencesDefinitions.h:

1:19 PM Changeset in webkit [209150] by jiewen_tan@apple.com

• 25 edits
  32 adds in trunk

Update SubtleCrypto::verify to match the latest spec
​https://bugs.webkit.org/show_bug.cgi?id=164741
<rdar://problem/29257935>

Reviewed by Brent Fulgham.

LayoutTests/imported/w3c:

• WebCryptoAPI/idlharness-expected.txt:

Source/WebCore:

This patch does following few things:

1. It updates the SubtleCrypto::verify method to match the latest spec: ​https://www.w3.org/TR/WebCryptoAPI/#SubtleCrypto-method-verify. It also refers to the latest Editor's Draft to a certain degree: ​https://w3c.github.io/webcrypto/Overview.html#SubtleCrypto-method-verify.
2. It implements verify operations of the following algorithms: HMAC, and RSASSA-PKCS1-V1_5.

Tests: crypto/subtle/hmac-generate-key-sign-verify.html

crypto/subtle/hmac-import-key-verify-sha1.html
crypto/subtle/hmac-import-key-verify-sha224.html
crypto/subtle/hmac-import-key-verify-sha256.html
crypto/subtle/hmac-import-key-verify-sha384.html
crypto/subtle/hmac-import-key-verify-sha512.html
crypto/subtle/rsassa-pkcs1-v1_5-generate-key-sign-verify.html
crypto/subtle/rsassa-pkcs1-v1_5-import-key-verify-sha1.html
crypto/subtle/rsassa-pkcs1-v1_5-import-key-verify-sha224.html
crypto/subtle/rsassa-pkcs1-v1_5-import-key-verify-sha256.html
crypto/subtle/rsassa-pkcs1-v1_5-import-key-verify-sha384.html
crypto/subtle/rsassa-pkcs1-v1_5-import-key-verify-sha512.html
crypto/subtle/verify-malformed-parameters.html
crypto/workers/subtle/hmac-import-key-verify.html
crypto/workers/subtle/rsassa-pkcs1-v1_5-import-key-verify.html

• bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::normalizeCryptoAlgorithmParameters):
(WebCore::jsSubtleCryptoFunctionVerifyPromise):
(WebCore::JSSubtleCrypto::verify):

• crypto/CryptoAlgorithm.cpp:

(WebCore::CryptoAlgorithm::verify):

• crypto/CryptoAlgorithm.h:
• crypto/SubtleCrypto.idl:
• crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::verify):

• crypto/algorithms/CryptoAlgorithmHMAC.h:
• crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):

• crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
• crypto/gcrypt/CryptoAlgorithmHMACGCrypt.cpp:

(WebCore::CryptoAlgorithmHMAC::platformVerify):

• crypto/gnutls/CryptoAlgorithmHMACGnuTLS.cpp:

(WebCore::CryptoAlgorithmHMAC::platformVerify):

• crypto/gnutls/CryptoAlgorithmRSASSA_PKCS1_v1_5GnuTLS.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify):

• crypto/mac/CryptoAlgorithmHMACMac.cpp:

(WebCore::CryptoAlgorithmHMAC::platformVerify):

• crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:

(WebCore::verifyRSASSA_PKCS1_v1_5):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify):

LayoutTests:

Besides adding tests for SubtleCrypto::verify, it also enhances
*generate-key-encrypt-decrypt tests.

• crypto/subtle/aes-cbc-generate-key-encrypt-decrypt-expected.txt:
• crypto/subtle/aes-cbc-generate-key-encrypt-decrypt.html:
• crypto/subtle/hmac-generate-key-sign-verify-expected.txt: Added.
• crypto/subtle/hmac-generate-key-sign-verify.html: Added.
• crypto/subtle/hmac-import-key-verify-sha1-expected.txt: Added.
• crypto/subtle/hmac-import-key-verify-sha1.html: Added.
• crypto/subtle/hmac-import-key-verify-sha224-expected.txt: Added.
• crypto/subtle/hmac-import-key-verify-sha224.html: Added.
• crypto/subtle/hmac-import-key-verify-sha256-expected.txt: Added.
• crypto/subtle/hmac-import-key-verify-sha256.html: Added.
• crypto/subtle/hmac-import-key-verify-sha384-expected.txt: Added.
• crypto/subtle/hmac-import-key-verify-sha384.html: Added.
• crypto/subtle/hmac-import-key-verify-sha512-expected.txt: Added.
• crypto/subtle/hmac-import-key-verify-sha512.html: Added.
• crypto/subtle/rsa-oaep-generate-key-encrypt-decrypt-expected.txt:
• crypto/subtle/rsa-oaep-generate-key-encrypt-decrypt-label-expected.txt:
• crypto/subtle/rsa-oaep-generate-key-encrypt-decrypt-label.html:
• crypto/subtle/rsa-oaep-generate-key-encrypt-decrypt.html:
• crypto/subtle/rsaes-pkcs1-v1_5-generate-key-encrypt-decrypt-expected.txt:
• crypto/subtle/rsaes-pkcs1-v1_5-generate-key-encrypt-decrypt.html:
• crypto/subtle/rsassa-pkcs1-v1_5-generate-key-sign-verify-expected.txt: Added.
• crypto/subtle/rsassa-pkcs1-v1_5-generate-key-sign-verify.html: Added.
• crypto/subtle/rsassa-pkcs1-v1_5-import-key-verify-sha1-expected.txt: Added.
• crypto/subtle/rsassa-pkcs1-v1_5-import-key-verify-sha1.html: Added.
• crypto/subtle/rsassa-pkcs1-v1_5-import-key-verify-sha224-expected.txt: Added.
• crypto/subtle/rsassa-pkcs1-v1_5-import-key-verify-sha224.html: Added.
• crypto/subtle/rsassa-pkcs1-v1_5-import-key-verify-sha256-expected.txt: Added.
• crypto/subtle/rsassa-pkcs1-v1_5-import-key-verify-sha256.html: Added.
• crypto/subtle/rsassa-pkcs1-v1_5-import-key-verify-sha384-expected.txt: Added.
• crypto/subtle/rsassa-pkcs1-v1_5-import-key-verify-sha384.html: Added.
• crypto/subtle/rsassa-pkcs1-v1_5-import-key-verify-sha512-expected.txt: Added.
• crypto/subtle/rsassa-pkcs1-v1_5-import-key-verify-sha512.html: Added.
• crypto/subtle/verify-malformed-parameters-expected.txt: Added.
• crypto/subtle/verify-malformed-parameters.html: Added.
• crypto/workers/subtle/hmac-import-key-verify-expected.txt: Added.
• crypto/workers/subtle/hmac-import-key-verify.html: Added.
• crypto/workers/subtle/resources/hmac-import-key-verify.js: Added.
• crypto/workers/subtle/resources/rsassa-pkcs1-v1_5-import-key-verify.js: Added.
• crypto/workers/subtle/rsassa-pkcs1-v1_5-import-key-verify-expected.txt: Added.
• crypto/workers/subtle/rsassa-pkcs1-v1_5-import-key-verify.html: Added.

1:13 PM Changeset in webkit [209149] by mark.lam@apple.com

• 3 edits
  2 adds in trunk

Proxy is not allowed in the global prototype chain.
​https://bugs.webkit.org/show_bug.cgi?id=165205

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

• runtime/ProgramExecutable.cpp:

(JSC::ProgramExecutable::initializeGlobalProperties):

• We'll now throw a TypeError if we detect a Proxy in the global prototype chain.

LayoutTests:

• js/dom/proxy-is-not-allowed-in-global-prototype-chain-expected.txt: Added.
• js/dom/proxy-is-not-allowed-in-global-prototype-chain.html: Added.

12:38 PM Changeset in webkit [209148] by hyatt@apple.com

• 2 edits in trunk/Source/WebCore

[CSS Parser] Fix columns shorthand parsing
​https://bugs.webkit.org/show_bug.cgi?id=165210

Reviewed by Zalan Bujtas.

• css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::consumeColumns):
(WebCore::consumeColumnWidthOrCount): Deleted.
Bring over the old parser code, since it was actually better at creating implicit values for auto.

12:34 PM Changeset in webkit [209147] by aestes@apple.com

• 5 edits in trunk/Source/WebCore

[Cocoa] Pass the embedding app's bundle ID to new instances of NEFilterSource
​https://bugs.webkit.org/show_bug.cgi?id=165168
<rdar://problem/29003618>

Reviewed by Simon Fraser.

• platform/RuntimeApplicationChecks.h: Declared applicationBundleIdentifier().
• platform/RuntimeApplicationChecks.mm:

(WebCore::applicationBundleIdentifier): Made non-static.

• platform/cocoa/NetworkExtensionContentFilter.mm:

(WebCore::NetworkExtensionContentFilter::initialize): If the new NEFilterSource instance
responds to -setSourceAppBundleID:, call it with applicationBundleIdentifier().

• platform/spi/cocoa/NEFilterSourceSPI.h: Moved NEFilterSourceOptionsRedirectURL into the

!USE(APPLE_INTERNAL_SDK) section and unconditionally declared @property sourceAppBundleID in
a new category on NEFilterSource.

12:30 PM Changeset in webkit [209146] by commit-queue@webkit.org

• 5 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r209112.
​https://bugs.webkit.org/show_bug.cgi?id=165208

"It regressed Octane/Raytrace and JetStream" (Requested by
saamyjoon on #webkit).

Reverted changeset:

"We should support CreateThis in the FTL"
​https://bugs.webkit.org/show_bug.cgi?id=164904
​http://trac.webkit.org/changeset/209112

12:20 PM Changeset in webkit [209145] by Brent Fulgham

• 11 edits
  12 adds in trunk

Use 'childOfType' template when retrieving Shadow DOM elements
​https://bugs.webkit.org/show_bug.cgi?id=165145
<rdar://problem/29331830>

Reviewed by Antti Koivisto.

Source/WebCore:

Tests: fast/shadow-dom/color-input-element-shadow-manipulation.html

fast/shadow-dom/file-input-element-shadow-manipulation.html
fast/shadow-dom/keygen-shadow-manipulation.html
fast/shadow-dom/media-shadow-manipulation.html
fast/shadow-dom/range-input-element-shadow-manipulation.html
fast/shadow-dom/textarea-shadow-manipulation.html

Switch to using 'childOfType' when retrieving Shadow DOM elements, rather
than relying on expected element positions, as these can be changed by
JavaScript.

Drive by fix: Make more use of is<> and downcast<> templates rather than blindly casting.

• dom/Element.h:

(WebCore::Element::isUploadButton): Added.
(WebCore::Element::isSliderContainerElement): Added.

• html/ColorInputType.cpp:

(WebCore::ColorInputType::shadowColorSwatch): Use 'childOfType' rather than assuming
the first child is the one we want.

• html/FileInputType.cpp:

(isType): Added.
(WebCore::FileInputType::disabledAttributeChanged): Use 'childOfType' rather than assuming
the first child is the one we want.
(WebCore::FileInputType::multipleAttributeChanged): Ditto.

• html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::shadowSelect): Ditto.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaControls): Ditto.
(WebCore::HTMLMediaElement::hasMediaControls): Ditto.

• html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::innerTextElement): Ditto.

• html/RangeInputType.cpp:

(WebCore::RangeInputType::sliderTrackElement): Ditto.

• html/shadow/SliderThumbElement.h:

(isType): Added.

• svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::targetClone): Use 'childOfType' rather than assuming
the first child is the one we want.

LayoutTests:

• fast/shadow-dom/color-input-element-shadow-manipulation-expected.txt: Added.
• fast/shadow-dom/color-input-element-shadow-manipulation.html: Added.
• fast/shadow-dom/file-input-element-shadow-manipulation-expected.txt: Added.
• fast/shadow-dom/file-input-element-shadow-manipulation.html: Added.
• fast/shadow-dom/keygen-shadow-manipulation-expected.txt: Added.
• fast/shadow-dom/keygen-shadow-manipulation.html: Added.
• fast/shadow-dom/media-shadow-manipulation-expected.txt: Added.
• fast/shadow-dom/media-shadow-manipulation.html: Added.
• fast/shadow-dom/range-input-element-shadow-manipulation-expected.txt: Added.
• fast/shadow-dom/range-input-element-shadow-manipulation.html: Added.
• fast/shadow-dom/textarea-shadow-manipulation-expected.txt: Added.
• fast/shadow-dom/textarea-shadow-manipulation.html: Added.

11:59 AM Changeset in webkit [209144] by beidson@apple.com

• 3 edits in trunk/Source/WebCore

IndexedDB 2.0: Cache and reuse SQLiteStatements in the SQLite backend.
​https://bugs.webkit.org/show_bug.cgi?id=164974

Reviewed by Alex Christensen.

No new tests (No behavior change other than being faster).

Instead of building new SQLiteStatements from scratch each time they're needed and then
finalizing them after they're used for a single operation, we cache them.

For tests that do puts and/or gets in tight loops, this shows up as a 5%-20% speedup on profiles.

• Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::~SQLiteIDBBackingStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::createAndPopulateInitialDatabaseInfo):
(WebCore::IDBServer::SQLiteIDBBackingStore::getOrEstablishDatabaseInfo):
(WebCore::IDBServer::SQLiteIDBBackingStore::createObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::renameObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::clearObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedHasIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedPutIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::renameIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteUnusedBlobFileRecords):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::updateAllIndexesForAddRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::addRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getBlobRecordsForObjectStoreRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::cachedStatementForGetAllObjectStoreRecords):
(WebCore::IDBServer::SQLiteIDBBackingStore::getAllObjectStoreRecords):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedGetKeyGeneratorValue):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedSetKeyGeneratorValue):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteBackingStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::cachedStatement):
(WebCore::IDBServer::SQLiteIDBBackingStore::closeSQLiteDB):
(WebCore::IDBServer::queryForGetAllObjectStoreRecords): Deleted.

• Modules/indexeddb/server/SQLiteIDBBackingStore.h:

11:48 AM Changeset in webkit [209143] by Joseph Pecoraro

• 5 edits in trunk

Web Inspector: Clicking on link in Web Inspector can cause UIProcess to crash
​https://bugs.webkit.org/show_bug.cgi?id=165157
<rdar://problem/27896562>

Reviewed by Brian Burg.

Source/WebInspectorUI:

By correctly disallowing slashes in the scheme Web Inspector resolves
the correct absolute URL and doesn't end up trying to navigate to an
incorrect file URL.

• UserInterface/Base/URLUtilities.js:

(parseURL):
Disallow "/" characters in the scheme portion. (/​http://example.com)
Allow path to be optional before a fragment portion. (​http://example.com#frag)

LayoutTests:

• inspector/unit-tests/url-utilities-expected.txt:
• inspector/unit-tests/url-utilities.html:

Add some tests for expected valid and invalid parseURL cases.
Note some cases that we don't handle properly and would benefit
by switching to URL constructor which is a much larger change.

11:39 AM Changeset in webkit [209142] by hyatt@apple.com

• 2 edits in trunk/Source/WebCore

[CSS Parser] Make sure -webkit-background-size coalesces identical values.
​https://bugs.webkit.org/show_bug.cgi?id=165207

Reviewed by Dean Jackson.

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeBackgroundSize):

11:20 AM Changeset in webkit [209141] by eric.carlson@apple.com

• 2 edits in trunk/Source/WebCore

[MediaStream] Sync video preview layer and parent layer sizes
​https://bugs.webkit.org/show_bug.cgi?id=165139

Reviewed by Jer Noble.

CALayer auto-resizing doesn't work on iOS, so manually reize the video capture preview layer
whenever the background layer's bounds change.

• platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoSourcePreview::AVVideoSourcePreview): Create layer observer.
(WebCore::AVVideoSourcePreview::backgroundLayerBoundsChanged): Sync preview layer and background

layer sizes.

(WebCore::AVVideoSourcePreview::invalidate): Invalidate and clear observer.
(-[WebCoreAVVideoCaptureSourceObserver initWithParent:]):
(-[WebCoreAVVideoCaptureSourceObserver setParent:]): Add KVO bounds observer.
(-[WebCoreAVVideoCaptureSourceObserver observeValueForKeyPath:ofObject:change:context:]): Call
parent when "bounds" changes.
(-[WebCoreAVVideoCaptureSourceObserver actionForKey:]): Return nil to disable all animations.

11:19 AM Changeset in webkit [209140] by aestes@apple.com

• 11 edits
  12 deletes in trunk

Reverted r209130.

The new test fast/shadow-dom/keygen-shadow-manipulation.html asserts and crashes on Mac debug builds.

10:51 AM Changeset in webkit [209139] by hyatt@apple.com

• 2 edits in trunk/LayoutTests

[CSS Parser] Fix a typo in a layout test for transforms
​https://bugs.webkit.org/show_bug.cgi?id=165203

Reviewed by Dean Jackson.

• transitions/transition-end-event-transform.html:

10:45 AM Changeset in webkit [209138] by Brent Fulgham

• 2 edits in trunk

[Win] Apple build is using incorrect ICU library (if present)
​https://bugs.webkit.org/show_bug.cgi?id=164934
<rdar://problem/29329654>

Reviewed by Alex Christensen.

Move the 'icuuc.lib' and 'icuin.lib' library names to the end of the set of choices when searching for ICU.
so that we preferentially select the 'new' version of these libraries if they are available.

• Source/cmake/FindICU.cmake:

10:42 AM Changeset in webkit [209137] by hyatt@apple.com

• 2 edits in trunk/Source/WebCore

[CSS Parser] Fix crash in -webkit-shape-outside parsing
​https://bugs.webkit.org/show_bug.cgi?id=165202

Reviewed by Dean Jackson.

• css/CSSBasicShapes.cpp:

(WebCore::buildSerializablePositionOffset):
The old parser never passed in a singleton value ID for top/right/bottom/left.
The new parser does, and it exposed a bug in the serialization code for
shapes that didn't properly create the offset primitive value as a percentage
in those cases.

10:30 AM Changeset in webkit [209136] by Jonathan Bedard

• 4 edits in trunk/Tools

Make it possible to use an existing simulator instance for one-off testing
​https://bugs.webkit.org/show_bug.cgi?id=164568
<rdar://problem/29189133>

Reviewed by Daniel Bates.

With this patch, if a simulator is currently running on the machine and
'--dedicated-simulators' is not passed into the application, only one simulator
instance will be used, and this instance will be the existing instance.
If no simulator is running or '--dedicated-simulators' is passed to the script,
previous behavior will be used.

• Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

• Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort.init): Logic for enabling usage of currently running simulator.
(IOSSimulatorPort._create_simulators): Only create simulators when needed, don't reset already running simulators.
(IOSSimulatorPort.setup_test_run): Don't open already running simulators.
(IOSSimulatorPort._quit_ios_simulator): Only quit simulators if we manage them.
(IOSSimulatorPort.clean_up_test_run): Only clean up simulators if we manage them.
(IOSSimulatorPort._using_dedicated_simulators): True if simulators need to be managed, false if using an existing instance.
(IOSSimulatorPort.device_id_for_worker_number): Access currently running simulator if not managing devices.

• Scripts/webkitpy/xcode/simulator.py:

(Simulator.current_device): Get currently running device.

10:03 AM Changeset in webkit [209135] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[GLIB] IndexedDB: Switch to use new encoder for IDBKeyData
​https://bugs.webkit.org/show_bug.cgi?id=165191

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2016-11-30
Reviewed by Sergio Villar Senin.

Instead of using KeyedEncoder.

• Modules/indexeddb/server/IDBSerialization.cpp:

(WebCore::isLegacySerializedIDBKeyData): Helper function to check whether the given data were encoded with
KeyedEncoder or not.
(WebCore::serializedTypeForKeyType): Remove #ifdefs for CF and always use the new encoder.
(WebCore::encodeKey): Ditto.
(WebCore::serializeIDBKeyData): Ditto.
(WebCore::decodeKey): Ditto.
(WebCore::deserializeIDBKeyData): Ditto.

10:01 AM Changeset in webkit [209134] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Web Inspector: Null ResourceResponse Preflight requests cause crash
​https://bugs.webkit.org/show_bug.cgi?id=165120
<rdar://problem/27911350>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-11-30
Reviewed by Brian Burg.

• loader/CrossOriginPreflightChecker.cpp:

(WebCore::CrossOriginPreflightChecker::validatePreflightResponse):
Only inform Web Inspector about successful responses. Informing with a
null response would break the expected Inspector API contract when
notifying about did receive response. Also, when informing Web Inspector
include a didFinishLoading event so the frontend knows this pre-flight
request is complete.

9:53 AM Changeset in webkit [209133] by Brent Fulgham

• 2 edits in trunk/Source/WebKit2

Correct plugin sandbox after r208611
​https://bugs.webkit.org/show_bug.cgi?id=165187
<rdar://problem/29431165>

Reviewed by Alex Christensen.

In r208611 I removed the 'else' clause of a Scheme conditional
that was needed to properly run plugins (such as Flash Player).

This change retains the relevant current sandbox content, while
still stripping out the old code that is no longer needed.

• PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:

9:38 AM Changeset in webkit [209132] by beidson@apple.com

• 2 edits in trunk/Source/WebCore

REGRESSION (209086): IDB tests crash under GuardMalloc.
​https://bugs.webkit.org/show_bug.cgi?id=165201

Reviewed by Chris Dumez.

No new tests (Covered by literally every IDB test when run under GuardMalloc).

• Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::commitOnServer): "Commit on Server" operations are special, in that they

are the last operation a transaction does, and they remove themselves from the protector map right away.
So when we remove them from the protector map we also need to remove their raw-pointer from the
"in-progress" queue.

9:10 AM Changeset in webkit [209131] by commit-queue@webkit.org

• 6 edits
  2 adds in trunk

Some animated image do not animate after reseting their animations
​https://bugs.webkit.org/show_bug.cgi?id=165131

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2016-11-30
Reviewed by Simon Fraser.
Source/WebCore:

Test: fast/images/reset-image-animation.html

The bug happens because the ImageFrameCache does not reset its cached
frames properly when the BitmapImage rests its animation.

-- We need to ignore caching the new NativeImage of an ImageFrame if the
decoding thread is terminated after asynchronously calling
cacheFrameNativeImageAtIndex() on the main thread through callOnMainThread().
Although the decoding thread was terminated this call is still scheduled
to be executed later on the main thread.

-- We need to open the m_frameRequestQueue before starting a new decoding
thread. Opening m_frameRequestQueue clears the enqueued requests from the
previous decoding thread and allows enqueueing requests for the new thread.

-- We need to clear the ImageFrames which were being decoded at the time
the decoding queue was closing and their new NativeImages were not cached.

• platform/graphics/ImageFrameCache.cpp:

(WebCore::ImageFrameCache::cacheFrameNativeImageAtIndex): Assert the NativeImage
is cached for an ImageFrame which is still being decoded.

(WebCore::ImageFrameCache::startAsyncDecodingQueue): Open the m_frameRequestQueue
before starting the decoding thread. Don't cache the NativeImage of an ImageFrame
unless the decoding thread is still alive and it the same as the one that makes
the asynchronous call to cacheFrameNativeImageAtIndex().

(WebCore::ImageFrameCache::requestFrameAsyncDecodingAtIndex): Don't request an
image frame to be be asynchronously decoded if it is already being decoded.

(WebCore::ImageFrameCache::stopAsyncDecodingQueue): Clear the ImageFrames that
were being decoded when the decoding thread terminates.

• testing/Internals.cpp:

(WebCore::Internals::resetImageAnimation):

• testing/Internals.h:
• testing/Internals.idl:

Expose BitmapImage::resetAnimation() through Internals so tests can force it.

LayoutTests:

Ensure the image animation is played in order after the animation is reset.

• fast/images/reset-image-animation-expected.txt: Added.
• fast/images/reset-image-animation.html: Added.

9:03 AM Changeset in webkit [209130] by Brent Fulgham

• 11 edits
  12 adds in trunk

Use 'childOfType' template when retrieving Shadow DOM elements
​https://bugs.webkit.org/show_bug.cgi?id=165145
<rdar://problem/29331830>

Reviewed by Antti Koivisto.

Source/WebCore:

Tests: fast/shadow-dom/color-input-element-shadow-manipulation.html

fast/shadow-dom/file-input-element-shadow-manipulation.html
fast/shadow-dom/keygen-shadow-manipulation.html
fast/shadow-dom/media-shadow-manipulation.html
fast/shadow-dom/range-input-element-shadow-manipulation.html
fast/shadow-dom/textarea-shadow-manipulation.html

Switch to using 'childOfType' when retrieving Shadow DOM elements, rather
than relying on expected element positions, as these can be changed by
JavaScript.

Drive by fix: Make more use of is<> and downcast<> templates rather than blindly casting.

• dom/Element.h:

(WebCore::Element::isUploadButton): Added.
(WebCore::Element::isSliderContainerElement): Added.

• html/ColorInputType.cpp:

(WebCore::ColorInputType::shadowColorSwatch): Use 'childOfType' rather than assuming
the first child is the one we want.

• html/FileInputType.cpp:

(isType): Added.
(WebCore::FileInputType::disabledAttributeChanged): Use 'childOfType' rather than assuming
the first child is the one we want.
(WebCore::FileInputType::multipleAttributeChanged): Ditto.

• html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::shadowSelect): Ditto.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaControls): Ditto.
(WebCore::HTMLMediaElement::hasMediaControls): Ditto.

• html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::innerTextElement): Ditto.

• html/RangeInputType.cpp:

(WebCore::RangeInputType::sliderTrackElement): Ditto.

• html/shadow/SliderThumbElement.h:

(isType): Added.

• svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::targetClone): Use 'childOfType' rather than assuming
the first child is the one we want.

LayoutTests:

• fast/shadow-dom/color-input-element-shadow-manipulation-expected.txt: Added.
• fast/shadow-dom/color-input-element-shadow-manipulation.html: Added.
• fast/shadow-dom/file-input-element-shadow-manipulation-expected.txt: Added.
• fast/shadow-dom/file-input-element-shadow-manipulation.html: Added.
• fast/shadow-dom/keygen-shadow-manipulation-expected.txt: Added.
• fast/shadow-dom/keygen-shadow-manipulation.html: Added.
• fast/shadow-dom/media-shadow-manipulation-expected.txt: Added.
• fast/shadow-dom/media-shadow-manipulation.html: Added.
• fast/shadow-dom/range-input-element-shadow-manipulation-expected.txt: Added.
• fast/shadow-dom/range-input-element-shadow-manipulation.html: Added.
• fast/shadow-dom/textarea-shadow-manipulation-expected.txt: Added.
• fast/shadow-dom/textarea-shadow-manipulation.html: Added.

8:59 AM Changeset in webkit [209129] by Darin Adler

• 40 edits in trunk/Source

Streamline and speed up tokenizer and segmented string classes
​https://bugs.webkit.org/show_bug.cgi?id=165003

Source/JavaScriptCore:

Reviewed by Sam Weinig.

• runtime/JSONObject.cpp:

(JSC::Stringifier::appendStringifiedValue): Use viewWithUnderlyingString when calling
StringBuilder::appendQuotedJSONString, since it now takes a StringView and there is
no benefit in creating a String for that function if one doesn't already exist.

Source/WebCore:

Reviewed by Sam Weinig.

Profiling Speedometer on my iMac showed the tokenizer as one of the
hottest functions. This patch streamlines the segmented string class,
removing various unused features, and also improves some other functions
seen on the Speedometer profile. On my iMac I measured a speedup of
about 3%. Changes include:

• Removed m_pushedChar1, m_pushedChar2, and m_empty data members from the SegmentedString class and all the code that used to handle them.

• Simplified the SegmentedString advance functions so they are small enough to get inlined in the HTML tokenizer.

• Updated callers to call the simpler SegmentedString advance functions that don't handle newlines in as many cases as possible.

• Cut down on allocations of SegmentedString and made code move the segmented string and the strings that are moved into it rather than copying them whenever possible.

• Simplified segmented string functions, removing some branches, mostly from the non-fast paths.

• Removed small unused functions and small functions used in only one or two places, made more functions private and renamed for clarity.

• bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::documentWrite): Moved a little more of the common code in here
from the two functions belwo. Removed obsolete comment saying this was not
following the DOM specification because it is. Removed unneeded special
cases for 1 argument and no arguments. Take a reference instead of a pointer.
(WebCore::JSHTMLDocument::write): Updated for above.
(WebCore::JSHTMLDocument::writeln): Ditto.

• css/parser/CSSTokenizer.cpp: Added now-needed include.
• css/parser/CSSTokenizer.h: Removed unneeded include.

• css/parser/CSSTokenizerInputStream.h: Added definition of kEndOfFileMarker

here; this is now separate from the use in the HTMLParser. In the long run,
unclear to me whether it is really needed in either.

• dom/Document.cpp:

(WebCore::Document::prepareToWrite): Added. Helper function used by the three
different variants of write. Using this may prevent us from having to construct
a SegmentedString just to append one string after future refactoring.
(WebCore::Document::write): Updated to take an rvalue reference and move the
value through.
(WebCore::Document::writeln): Use a single write call instead of two.

• dom/Document.h: Changed write to take an rvalue reference to SegmentedString

rather than a const reference.

• dom/DocumentParser.h: Changed insert to take an rvalue reference to

SegmentedString. In the future, should probably overload to take a single
string since that is the normal case.

• dom/RawDataDocumentParser.h: Updated for change to DocumentParser.

• html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocumentParser::append): Refactored a bit, just enough
so that we don't need an assignment operator for SegmentedString that can
copy a String.

• html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::insert): Updated to take an rvalue reference,
and move the value through.

• html/parser/HTMLDocumentParser.h: Updated for the above.

• html/parser/HTMLEntityParser.cpp:

(WebCore::HTMLEntityParser::consumeNamedEntity): Updated for name changes.
Changed the twao calls to advance here to call advancePastNonNewline; no
change in behavior, but asserts what the code was assuming before, that the
character was not a newline.

• html/parser/HTMLInputStream.h:

(WebCore::HTMLInputStream::appendToEnd): Updated to take an rvalue reference,
and move the value through.
(WebCore::HTMLInputStream::insertAtCurrentInsertionPoint): Ditto.
(WebCore::HTMLInputStream::markEndOfFile): Removed the code to construct a
SegmentedString, overkill since we can just append an individual string.
(WebCore::HTMLInputStream::splitInto): Rewrote the move idiom here to actually
use move, which will reduce reference count churn and other unneeded work.

• html/parser/HTMLMetaCharsetParser.cpp:

(WebCore::HTMLMetaCharsetParser::checkForMetaCharset): Removed unneeded
construction of a SegmentedString, just to append a string.

• html/parser/HTMLSourceTracker.cpp:

(WebCore::HTMLSourceTracker::HTMLSourceTracker): Moved to the class definition.
(WebCore::HTMLSourceTracker::source): Updated for function name change.

• html/parser/HTMLSourceTracker.h: Updated for above.

• html/parser/HTMLTokenizer.cpp: Added now-needed include.

(WebCore::HTMLTokenizer::emitAndResumeInDataState): Use advancePastNonNewline,
since this function is never called in response to a newline character.
(WebCore::HTMLTokenizer::commitToPartialEndTag): Ditto.
(WebCore::HTMLTokenizer::commitToCompleteEndTag): Ditto.
(WebCore::HTMLTokenizer::processToken): Use ADVANCE_PAST_NON_NEWLINE_TO macro
instead of ADVANCE_TO in cases where the character we are advancing past is
known not to be a newline, so we can use the more efficient advance function
that doesn't check for the newline character.

• html/parser/InputStreamPreprocessor.h: Moved kEndOfFileMarker to

SegmentedString.h; not sure that's a good place for it either. In the long run,
unclear to me whether this is really needed.
(WebCore::InputStreamPreprocessor::peek): Added UNLIKELY for the empty check.
Added LIKELY for the not-special character check.
(WebCore::InputStreamPreprocessor::advance): Updated for the new name of the
advanceAndUpdateLineNumber function.
(WebCore::InputStreamPreprocessor::advancePastNonNewline): Added. More
efficient than advance for cases where the last characer is known not to be
a newline character.
(WebCore::InputStreamPreprocessor::skipNextNewLine): Deleted. Was unused.
(WebCore::InputStreamPreprocessor::reset): Deleted. Was unused except in the
constructor; added initial values for the data members to replace.
(WebCore::InputStreamPreprocessor::processNextInputCharacter): Removed long
FIXME comment that didn't really need to be here. Reorganized a bit.
(WebCore::InputStreamPreprocessor::isAtEndOfFile): Renamed and made static.

• html/track/BufferedLineReader.cpp:

(WebCore::BufferedLineReader::nextLine): Updated to not use the poorly named
scanCharacter function to advance past a newline. Also renamed from getLine
and changed to return Optional<String> instead of using a boolean to indicate
failure and an out argument.

• html/track/BufferedLineReader.h:

(WebCore::BufferedLineReader::BufferedLineReader): Use the default, putting
initial values on each data member below.
(WebCore::BufferedLineReader::append): Updated to take an rvalue reference,
and move the value through.
(WebCore::BufferedLineReader::scanCharacter): Deleted. Was poorly named,
and easy to replace with two lines of code at its two call sites.
(WebCore::BufferedLineReader::reset): Rewrote to correctly clear all the
data members of the class, not just the segmented string.

• html/track/InbandGenericTextTrack.cpp:

(WebCore::InbandGenericTextTrack::parseWebVTTFileHeader): Updated to take
an rvalue reference and move the value through.

• html/track/InbandGenericTextTrack.h: Updated for the above.

• html/track/InbandTextTrack.h: Updated since parseWebVTTFileHeader now

takes an rvalue reference.

• html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::parseFileHeader): Updated to take an rvalue reference
and move the value through.
(WebCore::WebVTTParser::parseBytes): Updated to pass ownership of the string
in to the line reader append function.
(WebCore::WebVTTParser::parseCueData): Use auto and WTFMove for WebVTTCueData.
(WebCore::WebVTTParser::flush): More of the same.
(WebCore::WebVTTParser::parse): Changed to use nextLine instead of getLine.

• html/track/WebVTTParser.h: Updated for the above.

• html/track/WebVTTTokenizer.cpp:

(WebCore::advanceAndEmitToken): Use advanceAndUpdateLineNumber by its new
name, just advance. No change in behavior.
(WebCore::WebVTTTokenizer::WebVTTTokenizer): Pass a String, not a
SegmentedString, to add the end of file marker.

• platform/graphics/InbandTextTrackPrivateClient.h: Updated since

parseWebVTTFileHeader takes an rvalue reference.

• platform/text/SegmentedString.cpp:

(WebCore::SegmentedString::Substring::appendTo): Moved here from the header.
The only caller is SegmentedString::toString, inside this file.
(WebCore::SegmentedString::SegmentedString): Deleted the copy constructor.
No longer needed.
(WebCore::SegmentedString::operator=): Defined a move assignment operator
rather than an ordinary assignment operator, since that's what the call
sites really need.
(WebCore::SegmentedString::length): Simplified since we no longer need to
support pushed characters.
(WebCore::SegmentedString::setExcludeLineNumbers): Simplified, since we
can just iterate m_otherSubstrings without an extra check. Also changed to
write directly to the data member of Substring instead of using a function.
(WebCore::SegmentedString::updateAdvanceFunctionPointersForEmptyString):
Added. Used when we run out of characters.
(WebCore::SegmentedString::clear): Removed code to clear now-deleted members.
Updated for changes to other member names.
(WebCore::SegmentedString::appendSubstring): Renamed from just append to
avoid ambiguity with the public append function. Changed to take an rvalue
reference, and move in, and added code to set m_currentCharacter properly,
so the caller doesn't have to deal with that.
(WebCore::SegmentedString::close): Updated to use m_isClosed by its new name.
Also removed unneeded comment about assertion that fires when trying to close
an already closed string.
(WebCore::SegmentedString::append): Added overloads for rvalue references of
both entire SegmentedString objects and of String. Streamlined to just call
appendSubstring and append to the deque.
(WebCore::SegmentedString::pushBack): Tightened up since we don't allow empty
strings and changed to take just a string, not an entire segmented string.
(WebCore::SegmentedString::advanceSubstring): Moved logic into the
advancePastSingleCharacterSubstringWithoutUpdatingLineNumber function.
(WebCore::SegmentedString::toString): Simplified now that we don't need to
support pushed characters.
(WebCore::SegmentedString::advancePastNonNewlines): Deleted.
(WebCore::SegmentedString::advance8): Deleted.
(WebCore::SegmentedString::advanceWithoutUpdatingLineNumber16): Renamed from
advance16. Simplified now that there are no pushed characters. Also changed to
access data members of m_currentSubstring directly instead of calling a function.
(WebCore::SegmentedString::advanceAndUpdateLineNumber8): Deleted.
(WebCore::SegmentedString::advanceAndUpdateLineNumber16): Ditto.
(WebCore::SegmentedString::advancePastSingleCharacterSubstringWithoutUpdatingLineNumber):
Renamed from advanceSlowCase. Removed uneeded logic to handle pushed characters.
Moved code in here from advanceSubstring.
(WebCore::SegmentedString::advancePastSingleCharacterSubstring): Renamed from
advanceAndUpdateLineNumberSlowCase. Simplified by calling the function above.
(WebCore::SegmentedString::advanceEmpty): Broke assertion up into two.
(WebCore::SegmentedString::updateSlowCaseFunctionPointers): Updated for name changes.
(WebCore::SegmentedString::advancePastSlowCase): Changed name and meaning of
boolean argument. Rewrote to use the String class less; it's now used only when
we fail to match after the first character rather than being used for the actual
comparison with the literal.

• platform/text/SegmentedString.h: Moved all non-trivial function bodies out of

the class definition to make things easier to read. Moved the SegmentedSubstring
class inside the SegmentedString class, making it a private struct named Substring.
Removed the m_ prefix from data members of the struct, removed many functions from
the struct and made its union be anonymous instead of naming it m_data. Removed
unneeded StringBuilder.h include.
(WebCore::SegmentedString::isEmpty): Changed to use the length of the substring
instead of a separate boolean. We never create an empty substring, nor leave one
in place as the current substring unless the entire segmented string is empty.
(WebCore::SegmentedString::advancePast): Updated to use the new member function
template instead of a non-template member function. The new member function is
entirely rewritten and does the matching directly rather than allocating a string
just to do prefix matching.
(WebCore::SegmentedString::advancePastLettersIgnoringASCIICase): Renamed to make
it clear that the literal must be all non-letters or lowercase letters as with
the other "letters ignoring ASCII case" functions. The three call sites all fit
the bill. Implement by calling the new function template.
(WebCore::SegmentedString::currentCharacter): Renamed from currentChar.
(WebCore::SegmentedString::Substring::Substring): Use an rvalue reference and
move the string in.
(WebCore::SegmentedString::Substring::currentCharacter): Simplified since this
is never used on an empty substring.
(WebCore::SegmentedString::Substring::incrementAndGetCurrentCharacter): Ditto.
(WebCore::SegmentedString::SegmentedString): Overload to take an rvalue reference.
Simplified since there are now fewer data members.
(WebCore::SegmentedString::advanceWithoutUpdatingLineNumber): Renamed from
advance, since this is only safe to use if there is some reason it is OK to skip
updating the line number.
(WebCore::SegmentedString::advance): Renamed from advanceAndUpdateLineNumber,
since doing that is the normal desired behavior and not worth mentioning in the
public function name.
(WebCore::SegmentedString::advancePastNewline): Renamed from
advancePastNewlineAndUpdateLineNumber.
(WebCore::SegmentedString::numberOfCharactersConsumed): Greatly simplified since
pushed characters are no longer supported.
(WebCore::SegmentedString::characterMismatch): Added. Used by advancePast.

• xml/parser/CharacterReferenceParserInlines.h:

(WebCore::unconsumeCharacters): Use toString rather than toStringPreserveCapacity
because the SegmentedString is going to take ownership of the string.
(WebCore::consumeCharacterReference): Updated to use the pushBack that takes just
a String, not a SegmentedString. Also use advancePastNonNewline.

• xml/parser/MarkupTokenizerInlines.h: Added ADVANCE_PAST_NON_NEWLINE_TO.

• xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::insert): Updated since this takes an rvalue reference.
(WebCore::XMLDocumentParser::append): Removed unnecessary code to create a
SegmentedString.

• xml/parser/XMLDocumentParser.h: Updated for above. Also fixed indentation

and initialized most data members.

• xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::XMLDocumentParser): Moved most data member
initialization into the class definition.
(WebCore::XMLDocumentParser::resumeParsing): Removed code that copied a
segmented string, but converted the whole thing into a string before using it.
Now we convert to a string right away.

Source/WTF:

And do it without re-introducing:

REGRESSION (r209058): API test StringBuilderTest.Equal crashing
​https://bugs.webkit.org/show_bug.cgi?id=165142

Reviewed by Sam Weinig.

• wtf/text/StringBuilder.cpp:

(WTF::StringBuilder::bufferCharacters<LChar>): Moved this here from
the header since it is only used inside the class. Also renamed from
getBufferCharacters.
(WTF::StringBuilder::bufferCharacters<UChar>): Ditto.
(WTF::StringBuilder::appendUninitializedUpconvert): Added. Helper
for the upconvert case in the 16-bit overload of StrinBuilder::append.
(WTF::StringBuilder::append): Changed to use appendUninitializedUpconvert.
(WTF::quotedJSONStringLength): Added. Used in new appendQuotedJSONString
implementation below that now correctly determines the size of what will
be appended by walking thorugh the string twice.
(WTF::appendQuotedJSONStringInternal): Moved the code that writes the
quote marks in here. Also made a few coding style tweaks.
(WTF::StringBuilder::appendQuotedJSONString): Rewrote to use a much
simpler algorithm that grows the string the same way the append function
does. The old code would use reserveCapacity in a way that was costly when
doing a lot of appends on the same string, and also allocated far too much
memory for normal use cases where characters did not need to be turned
into escape sequences.

• wtf/text/StringBuilder.h:

(WTF::StringBuilder::append): Tweaked style a bit, fixed a bug where the
m_is8Bit field wasn't set correctly in one case, optimized the function that
adds substrings for the case where this is the first append and the substring
happens to cover the entire string. Also clarified the assertions and removed
an unneeded check from that substring overload.
(WTF::equal): Reimplemented, using equalCommon. Added an overload of the equal
function just for the case where the arguments are StringBuilder, String.
This is needed because of the peculiar behavior of is8Bit in String, different
from any of our other string classes. I think we should consider changing
String::is8Bit to return true for null strings. We could then remove this
overload and probably remove other checks for null and zero length elsewhere
that are also needed only to avoid calling is8Bit on a null String.

8:56 AM Changeset in webkit [209128] by hyatt@apple.com

• 2 edits in trunk/LayoutTests

[CSS Parser] Mark a bunch of tests as able to fail
​https://bugs.webkit.org/show_bug.cgi?id=165199

Reviewed by Zalan Bujtas.

• TestExpectations:

8:17 AM Changeset in webkit [209127] by Wenson Hsieh

• 2 edits in trunk/LayoutTests

Unreviewed, mark tiled-drawing/scrolling/scroll-snap/scroll-snap-iframe.html as flaky

It seems there are additional causes of test failures when scrolling in iframes. webkit.org/b/165196 will be
used to track this.

• platform/mac-wk2/TestExpectations:

1:41 AM Changeset in webkit [209126] by Csaba Osztrogonác

• 2 edits in trunk/Source/WebCore

Unreviewed speculative cmake buildfix after r209070.

• PlatformMac.cmake: New sources added.

12:36 AM Changeset in webkit [209125] by Philippe Normand

• 2 edits in trunk/Source/WebCore

[WebRTC][OpenWebRTC] Temporary device selection support
​https://bugs.webkit.org/show_bug.cgi?id=165141

Reviewed by Alejandro G. Castro.

Make sure the player handles only one audio and video track at
most for now. The device choice can be influenced with the
WEBKIT_VIDEO_DEVICE and WEBKIT_AUDIO_DEVICE environment variables.
Each variable optionally holds the name of the device to use.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:

(WebCore::MediaPlayerPrivateGStreamerOwr::play):
(WebCore::MediaPlayerPrivateGStreamerOwr::load):

12:30 AM Changeset in webkit [209124] by Claudio Saavedra

• 2 edits in trunk/Source/WebCore

Build fix with !HAVE(ACCESSIBILITY)

• accessibility/AXObjectCache.h:

(WebCore::AccessibilityReplacedText::AccessibilityReplacedText):
(WebCore::AccessibilityReplacedText::postTextStateChangeNotification):

Add dummy implementations.