Timeline
Jan 6, 2017:
- 11:53 PM Changeset in webkit [210476] by
-
- 23 edits4 adds in trunk
Add a slice intrinsic to the DFG/FTL
https://bugs.webkit.org/show_bug.cgi?id=166707
Reviewed by Filip Pizlo.
JSTests:
- stress/array-slice-intrinsic.js: Added.
(assert):
(shallowEq):
(runTest1):
(runTest2):
- stress/array-slice-jettison-on-constructor-change.js: Added.
(assert):
(runTest1):
(runTest2):
(addRandomProperties):
(runTests):
- stress/array-slice-osr-exit-2.js: Added.
(assert):
(Foo):
(shallowEq):
(runTest1):
(runTest2):
(addRandomProperties):
(runTests):
- stress/array-slice-osr-exit.js: Added.
(assert):
(Foo):
(shallowEq):
(runTest1):
(runTest2):
(addRandomProperties):
(runTests):
Source/JavaScriptCore:
The gist of this patch is to inline Array.prototype.slice
into the DFG/FTL. The implementation in the DFG-backend
and FTLLowerDFGToB3 is just a straight forward implementation
of what the C function is doing. The more interesting bits
of this patch are setting up the proper watchpoints and conditions
in the executing code to prove that its safe to skip all of the
observable JS actions that Array.prototype.slice normally does.
We perform the following proofs:
- Array.prototype.constructor has not changed (via a watchpoint).
- That Array.prototype.constructor[Symbol.species] has not changed (via a watchpoint).
- The global object is not having a bad time.
- The array that is being sliced has an original array structure.
- Array.prototype/Object.prototype have not transitioned.
Conditions 1, 2, and 3 are strictly required.
4 is ensuring a couple things:
- That a "constructor" property hasn't been added to the array
we're slicing since we're supposed to perform a Get(array, "constructor").
- That we're not slicing an instance of a subclass of Array.
We could relax 4.1 in the future if we find other ways to test if
the incoming array hasn't changed the "constructor" property.
I'm seeing a 5% speedup on crypto-pbkdf2 and often a 1% speedup on
the total benchmark (the results are sometimes noisy).
- bytecode/ExitKind.cpp:
(JSC::exitKindToString):
- bytecode/ExitKind.h:
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsicCall):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasHeapPrediction):
(JSC::DFG::Node::hasArrayMode):
- dfg/DFGNodeType.h:
- dfg/DFGPredictionPropagationPhase.cpp:
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArraySlice):
- dfg/DFGSpeculativeJIT.h:
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileArraySlice):
- jit/AssemblyHelpers.cpp:
(JSC::AssemblyHelpers::emitLoadStructure):
- runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::finishCreation):
(JSC::speciesWatchpointIsValid):
(JSC::speciesConstructArray):
(JSC::arrayProtoFuncSlice):
(JSC::arrayProtoPrivateFuncConcatMemcpy):
(JSC::ArrayPrototype::initializeSpeciesWatchpoint):
(JSC::ArrayPrototypeAdaptiveInferredPropertyWatchpoint::handleFire):
(JSC::speciesWatchpointsValid): Deleted.
(JSC::ArrayPrototype::attemptToInitializeSpeciesWatchpoint): Deleted.
- runtime/ArrayPrototype.h:
(JSC::ArrayPrototype::speciesWatchpointStatus): Deleted.
(): Deleted.
- runtime/Intrinsic.h:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::init):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::arraySpeciesWatchpoint):
- 11:42 PM Changeset in webkit [210475] by
-
- 2 edits in trunk/Source/WebKit2
Attempt to fix the EFL build following <http://trac.webkit.org/changeset/210461>
(https://bugs.webkit.org/show_bug.cgi?id=166781)
- UIProcess/API/C/WKWebsitePolicies.cpp:
(WKWebsitePoliciesGetAutoplayPolicy): Invoke ASSERT_NOT_REACHED() and return kWKWebsiteAutoplayPolicyUseHeuristics
if the specified policy is not covered by a switch case.
(WKWebsitePoliciesSetAutoplayPolicy): Substituted "return" for "break" in each switch case and
invoke ASSERT_NOT_REACHED() if the specified policy is not covered by a switch case.
- 11:14 PM Changeset in webkit [210474] by
-
- 7 edits in trunk/Source/WebCore
Ensure navigation only allowed for documents not in the page cache
https://bugs.webkit.org/show_bug.cgi?id=166773
<rdar://problem/29762809>
Reviewed by Brent Fulgham.
It is wise to ensure that navigation is only allowed when initiated from a document that
is not in- or about to be put in- the page cache. Such a navigation would surprise a
person that had navigated away from the initiating document among other issues.
- dom/Document.cpp:
(WebCore::Document::canNavigate): Only allow navigation if the document is not in the
page cache.
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::handleClick): Ditto.
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::handleClick): Ditto.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::urlSelected): Assert triggering event's document is not in the
page cache.
(WebCore::FrameLoader::submitForm): Allow submission if the document is not in the
page cache.
(WebCore::FrameLoader::loadFrameRequest): Assert triggering event's document is not in
the page cache.
- mathml/MathMLElement.cpp:
(WebCore::MathMLElement::defaultEventHandler): Only allow navigation if the document is
not in the page cache.
- svg/SVGAElement.cpp:
(WebCore::SVGAElement::defaultEventHandler): Ditto.
- 11:12 PM Changeset in webkit [210473] by
-
- 2 edits in trunk/Source/WebCore
Crash in WebCore::MediaPlayerPrivateMediaSourceAVFObjC::sizeWillChangeAtTime(const MediaTime&, const FloatSize&)::block_invoke
https://bugs.webkit.org/show_bug.cgi?id=166738
Reviewed by Eric Carlson.
AVFoundation can potentially call the same boundary time observer multiple times, and
in that case, it's possible that the observer queue will be empty when we attempt
to remove the first item from the queue. There's an ASSERT() in Deque for this case,
but we need to explicitly protect against this case.
Drive-by fix: Explicitly unregister the observer before releasing it.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::sizeWillChangeAtTime):
- 10:53 PM Changeset in webkit [210472] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r208886) Web Inspector: Toggling CSS Properties in Styles Sidebar (comment / uncomment)
https://bugs.webkit.org/show_bug.cgi?id=166786
<rdar://problem/29767412>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-01-06
Reviewed by Brian Burg.
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::populateAllProperties):
Match earlier behavior and don't send the frontend information about
disabled (commented out) properties. Follow-up later to send this
information when implementing proper handling of them in the frontend.
- 10:52 PM Changeset in webkit [210471] by
-
- 2 edits in trunk/LayoutTests/imported/w3c
Unreviewed, rebaseline W3C test after r210468.
The test now fails differently due the the behavior change in r210468.
The test fails because we do not support History.scrollRestoration.
- web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-cross-origin-expected.txt:
- 10:19 PM Changeset in webkit [210470] by
-
- 6 edits in trunk/Source/WebCore
[WebIDL] Remove custom bindings from CanvasRenderingContext2D
https://bugs.webkit.org/show_bug.cgi?id=166793
Reviewed by Darin Adler.
- WebCore.xcodeproj/project.pbxproj:
Move JSCanvasRenderingContext2DCustom.cpp to the GC only group.
- bindings/js/JSCanvasRenderingContext2DCustom.cpp:
(WebCore::toJS): Deleted.
(WebCore::toHTMLCanvasStyle): Deleted.
(WebCore::JSCanvasRenderingContext2D::strokeStyle): Deleted.
(WebCore::JSCanvasRenderingContext2D::setStrokeStyle): Deleted.
(WebCore::JSCanvasRenderingContext2D::fillStyle): Deleted.
(WebCore::JSCanvasRenderingContext2D::setFillStyle): Deleted.
Remove non-GC related custom bindings.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setStrokeStyle):
(WebCore::CanvasRenderingContext2D::setFillStyle):
(WebCore::toStyle):
(WebCore::CanvasRenderingContext2D::strokeStyle):
(WebCore::CanvasRenderingContext2D::fillStyle):
- html/canvas/CanvasRenderingContext2D.h:
- html/canvas/CanvasRenderingContext2D.idl:
Made existing setStrokeStyle/setFillStyle functions (which take CanvasStyle's)
private, and implemented new ones that operate on Variants, matching the spec.
- 9:23 PM Changeset in webkit [210469] by
-
- 17 edits in trunk/Source/WebCore
Remove PassRefPtr use from "rendering" directory, other improvements
https://bugs.webkit.org/show_bug.cgi?id=166717
Reviewed by Sam Weinig.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::shapePropertyValue): Use auto.
- css/CSSFilterImageValue.cpp:
(WebCore::CSSFilterImageValue::image): Use auto. Pass references.
(WebCore::CSSFilterImageValue::filterImageChanged): Use modern for loop.
- css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::convertShapeValue): Use overloaded
ShapeValue::create function instead of differently named functions.
- page/animation/CSSPropertyAnimation.cpp:
(WebCore::blendFunc): Ditto.
- platform/graphics/filters/Filter.h: Added a protected constructor that takes
a filter resolution.
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::FilterEffectRenderer): Use new constructor so
we don't have to call setFilterResolution and can initialize m_sourceGraphic.
(WebCore::FilterEffectRenderer::create): Moved here from the header.
(WebCore::FilterEffectRenderer::buildReferenceFilter): Take references and not
PssRefPtr. Use auto and references.
(WebCore::FilterEffectRenderer::build): Take a reference. Updated to work with
references rather than pointer. Use auto.
(WebCore::FilterEffectRenderer::allocateBackingStoreIfNeeded): Use early return.
(WebCore::FilterEffectRenderer::clearIntermediateResults): Use modern for loop.
(WebCore::FilterEffectRenderer::apply): Use references.
(WebCore::FilterEffectRenderer::output): Moved here from header.
(WebCore::FilterEffectRenderer::setMaxEffectRects): Moved here from header.
(WebCore::FilterEffectRenderer::outputRect): Moved here from header.
(WebCore::FilterEffectRendererHelper::prepareFilterEffect): Take references.
(WebCore::FilterEffectRendererHelper::beginFilterEffect): Use auto and references.
(WebCore::FilterEffectRendererHelper::applyFilterEffect): Ditto.
- rendering/FilterEffectRenderer.h: Updated for the above changes. Made a lot more
things private.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::filterPainter): Added. Helper so setupFilters does not
have to do things twice.
(WebCore::RenderLayer::hasFilterThatIsPainting): Updated to call filterPainter.
(WebCore::RenderLayer::setupFilters): Ditto.
(WebCore::RenderLayer::calculateClipRects): Pass reference.
- rendering/RenderLayer.h: Updated for the above changes.
- rendering/style/ContentData.cpp:
(WebCore::ContentData::clone): Use auto.
(WebCore::ImageContentData::createContentRenderer): Updated for reference.
- rendering/style/ContentData.h: Use Ref&& instead of PassRefPtr. Made more
things private.
- rendering/style/NinePieceImage.cpp:
(WebCore::NinePieceImage::defaultData): Made this a static member so it can
get at the now-private class NinePieceImage::Data.
(WebCore::NinePieceImage::NinePieceImage): Use RefPtr&& instead of PassRefPtr.
Use construction instead of calling m_data.access() over and over again.
(WebCore::NinePieceImage::Data::Data): Renamed from NinePieceImageData.
Moved initialization to class definition. Added a new overload for the normal
creation case.
(WebCore::NinePieceImage::Data::create): Ditto.
(WebCore::NinePieceImage::Data::copy): Ditto.
(WebCore::NinePieceImage::Data::operator==): Ditto.
- rendering/style/NinePieceImage.h: Cut down on includes. Moved the class
named NinePieceImageData in to become the private struct NinePieceImage::Data.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setContent): Pass Ref&& instead of RefPtr&& when
creating ImageContentData.
- rendering/style/ShapeValue.cpp:
(WebCore::ShapeValue::isImageValid): Tighten up by using data member directly
and using a local variabel.
(WebCore::pointersOrValuesEqual): Deleted.
(WebCore::ShapeValue::operator==): Use arePointingToEqualData instead the
above deleted function template. Wrote as a single return statement for clarity.
- rendering/style/ShapeValue.h: Changed all the create function names to just
create, using overloading instead of separate names. Use Ref&& instead of PassRefPtr.
Removed unused constructor that took a type but no data.
- 8:02 PM Changeset in webkit [210468] by
-
- 8 edits3 adds in trunk
Regression(r189230): DOM Callbacks may use wrong global object
https://bugs.webkit.org/show_bug.cgi?id=166784
Reviewed by Mark Lam.
Source/WebCore:
DOM Callbacks could end up using the wrong global object after r189230
because we were getting the globalObject from the callback object
instead of the one at the point the callback object was passed in by
JavaScript. This patch fixes the issue.
Test: fast/frames/frame-window-as-callback.html
- bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
- bindings/js/JSCallbackData.h:
(WebCore::JSCallbackData::globalObject):
(WebCore::JSCallbackData::JSCallbackData):
(WebCore::JSCallbackDataStrong::JSCallbackDataStrong):
(WebCore::JSCallbackDataStrong::callback):
(WebCore::JSCallbackDataStrong::invokeCallback):
(WebCore::JSCallbackDataWeak::JSCallbackDataWeak):
(WebCore::JSCallbackDataWeak::callback):
(WebCore::JSCallbackDataWeak::invokeCallback):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallbackImplementationContent):
LayoutTests:
Add layout test coverage.
- fast/frames/frame-window-as-callback-expected.txt: Added.
- fast/frames/frame-window-as-callback.html: Added.
- fast/frames/resources/wrong-global-object.html: Added.
- 7:49 PM Changeset in webkit [210467] by
-
- 12 edits1 copy2 adds4 deletes in trunk
[Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
https://bugs.webkit.org/show_bug.cgi?id=166789
Reviewed by Alex Christensen.
Source/WebCore:
There were duplicate implementations of WebArchiveDumpSupport in DumpRenderTree and
WebKitTestRunner. This change consolidates these into a single implementation in
WebCoreTestSupport.
- PlatformMac.cmake: Added WebArchiveDumpSupport.mm to WebCoreTestSupport.
- WebCore.xcodeproj/project.pbxproj: Ditto. Also made WebArchiveDumpSupport.h a Private header.
- platform/spi/cf/CFNetworkSPI.h: Moved CFNetwork forward declarations from
WebArchiveDumpSupport to here.
- testing/cocoa/WebArchiveDumpSupport.h: Added.
- testing/cocoa/WebArchiveDumpSupport.mm: Merged WebArchiveDumpSupport.cpp and
WebArchiveDumpSupport{Cocoa,Mac}.mm into a single file.
Tools:
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/PlatformMac.cmake:
- DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
- DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
- DumpRenderTree/mac/DumpRenderTree.mm:
Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
createXMLStringFromWebArchiveData().
- DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
- WebKitTestRunner/Configurations/Base.xcconfig:
Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dumpDOMAsWebArchive):
Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
createXMLStringFromWebArchiveData().
- WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
- WebKitTestRunner/PlatformMac.cmake:
- WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
- WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
- 6:59 PM Changeset in webkit [210466] by
-
- 8 edits in trunk
Minor cleanups to IndentOutdentCommand and related code
https://bugs.webkit.org/show_bug.cgi?id=166791
Reviewed by Simon Fraser.
Source/WebCore:
- editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::IndentOutdentCommand):
(WebCore::IndentOutdentCommand::outdentRegion):
- editing/IndentOutdentCommand.h:
(WebCore::IndentOutdentCommand::create):
Remove the unused m_marginInPixels and fix the copyright header.
Tools:
- WebEditingTester/EditingOperations.m:
(editingOperations):
Add the outdent operation to WebEditingTester.
LayoutTests:
- editing/execCommand/19653-1-expected.txt:
- editing/execCommand/19653-1.html:
Adjust this indenting test. It had a mislabeled test case (it outdents, not indents),
and also was copy-pasted wrong (it wasn't indented in the first place).
However, since this technically reduces test coverage, keep the existing
(but now correctly labeled) test case, since it caught a bug in code I was changing.
- 6:41 PM Changeset in webkit [210465] by
-
- 3 edits in trunk/Source/WebCore
Fix WinCairo build after r210319.
https://bugs.webkit.org/show_bug.cgi?id=166635
- DerivedSources.cpp:
A toJS call was ambiguous, but only if the generated IndexedDB bindings are compiled all-in-one in DerivedSources.cpp.
Compiling these few files separately (which happens automatically in the CMake build) fixes the build and won't increase
the total object files beyond MSVC's current 2GB limit.
- bindings/js/JSWebGLRenderingContextBaseCustom.cpp:
(WebCore::JSWebGLRenderingContextBaseOwner::isReachableFromOpaqueRoots):
Unknown was an ambiguous symbol. It's also defined in winioctl.h.
- 6:13 PM Changeset in webkit [210464] by
-
- 1 copy in tags/Safari-603.1.19
New tag.
- 5:41 PM Changeset in webkit [210463] by
-
- 1 edit2 moves in trunk/Tools
Create a plan and a patch files for MotionMark and delete the Animometer's ones
https://bugs.webkit.org/show_bug.cgi?id=166785
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-01-06
Reviewed by Ryosuke Niwa.
- Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
- Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
- 5:20 PM Changeset in webkit [210462] by
-
- 3 edits in tags/Safari-603.1.18.0.1/Source/JavaScriptCore
Merge r210458. rdar://problem/29761198
- 5:06 PM Changeset in webkit [210461] by
-
- 7 edits in trunk/Source/WebKit2
Add infrastructure for sending autoplay website policies to WebKit
https://bugs.webkit.org/show_bug.cgi?id=166781
Patch by Matt Rajca <mrajca@apple.com> on 2017-01-06
Reviewed by Alex Christensen.
- Shared/WebsitePolicies.h:
(WebKit::WebsitePolicies::encode):
(WebKit::WebsitePolicies::decode):
- UIProcess/API/APIWebsitePolicies.h:
- UIProcess/API/C/WKWebsitePolicies.cpp:
(WKWebsitePoliciesGetAutoplayPolicy):
(WKWebsitePoliciesSetAutoplayPolicy):
- UIProcess/API/C/WKWebsitePolicies.h:
- UIProcess/API/Cocoa/_WKWebsitePolicies.h:
- UIProcess/API/Cocoa/_WKWebsitePolicies.mm:
(-[_WKWebsitePolicies setAutoplayPolicy:]):
(-[_WKWebsitePolicies autoplayPolicy]):
- 4:34 PM Changeset in webkit [210460] by
-
- 2 edits in trunk/Source/WebInspectorUI
Unreviewed, rolling out r210110.
https://bugs.webkit.org/show_bug.cgi?id=166783
Introduced a regression commenting out individual properties
(Requested by JoePeck on #webkit).
Reverted changeset:
"Web Inspector: Styles sidebar: Uncommenting CSS rules of
pseudo-elements doesn't work"
https://bugs.webkit.org/show_bug.cgi?id=165831
http://trac.webkit.org/changeset/210110
- 3:38 PM Changeset in webkit [210459] by
-
- 1 edit108 copies18 adds1 delete in trunk/PerformanceTests
Rename the directory and the files of MotionMark from Animometer to MotionMark
https://bugs.webkit.org/show_bug.cgi?id=166659
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-01-06
Reviewed by Jon Lee.
Rename the directory and the files of the benchmark to its new name.
- MotionMark/developer.html: Renamed from PerformanceTests/Animometer/developer.html.
- MotionMark/index.html: Renamed from PerformanceTests/Animometer/index.html.
- MotionMark/resources/debug-runner/d3.min.js: Renamed from PerformanceTests/Animometer/resources/debug-runner/d3.min.js.
- MotionMark/resources/debug-runner/graph.js: Renamed from PerformanceTests/Animometer/resources/debug-runner/graph.js.
- MotionMark/resources/debug-runner/motionmark.css: Renamed from PerformanceTests/Animometer/resources/debug-runner/animometer.css.
- MotionMark/resources/debug-runner/motionmark.js: Renamed from PerformanceTests/Animometer/resources/debug-runner/animometer.js.
- MotionMark/resources/debug-runner/tests.js: Renamed from PerformanceTests/Animometer/resources/debug-runner/tests.js.
- MotionMark/resources/extensions.js: Renamed from PerformanceTests/Animometer/resources/extensions.js.
- MotionMark/resources/runner/benchmark-runner.js: Renamed from PerformanceTests/Animometer/resources/runner/benchmark-runner.js.
- MotionMark/resources/runner/crystal.svg: Renamed from PerformanceTests/Animometer/resources/runner/crystal.svg.
- MotionMark/resources/runner/lines.svg: Renamed from PerformanceTests/Animometer/resources/runner/lines.svg.
- MotionMark/resources/runner/logo.svg: Renamed from PerformanceTests/Animometer/resources/runner/logo.svg.
- MotionMark/resources/runner/motionmark.css: Renamed from PerformanceTests/Animometer/resources/runner/animometer.css.
- MotionMark/resources/runner/motionmark.js: Renamed from PerformanceTests/Animometer/resources/runner/animometer.js.
- MotionMark/resources/runner/tests.js: Renamed from PerformanceTests/Animometer/resources/runner/tests.js.
- MotionMark/resources/statistics.js: Renamed from PerformanceTests/Animometer/resources/statistics.js.
- MotionMark/resources/strings.js: Renamed from PerformanceTests/Animometer/resources/strings.js.
- MotionMark/tests/3d/resources/webgl.js: Renamed from PerformanceTests/Animometer/tests/3d/resources/webgl.js.
- MotionMark/tests/3d/webgl.html: Renamed from PerformanceTests/Animometer/tests/3d/webgl.html.
- MotionMark/tests/bouncing-particles/bouncing-canvas-images.html: Renamed from PerformanceTests/Animometer/tests/bouncing-particles/bouncing-canvas-images.html.
- MotionMark/tests/bouncing-particles/bouncing-canvas-shapes.html: Renamed from PerformanceTests/Animometer/tests/bouncing-particles/bouncing-canvas-shapes.html.
- MotionMark/tests/bouncing-particles/bouncing-css-images.html: Renamed from PerformanceTests/Animometer/tests/bouncing-particles/bouncing-css-images.html.
- MotionMark/tests/bouncing-particles/bouncing-css-shapes.html: Renamed from PerformanceTests/Animometer/tests/bouncing-particles/bouncing-css-shapes.html.
- MotionMark/tests/bouncing-particles/bouncing-svg-images.html: Renamed from PerformanceTests/Animometer/tests/bouncing-particles/bouncing-svg-images.html.
- MotionMark/tests/bouncing-particles/bouncing-svg-shapes.html: Renamed from PerformanceTests/Animometer/tests/bouncing-particles/bouncing-svg-shapes.html.
- MotionMark/tests/bouncing-particles/bouncing-tagged-images.html: Renamed from PerformanceTests/Animometer/tests/bouncing-particles/bouncing-tagged-images.html.
- MotionMark/tests/bouncing-particles/resources/bouncing-canvas-images.js: Renamed from PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-canvas-images.js.
- MotionMark/tests/bouncing-particles/resources/bouncing-canvas-particles.js: Renamed from PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-canvas-particles.js.
- MotionMark/tests/bouncing-particles/resources/bouncing-canvas-shapes.js: Renamed from PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-canvas-shapes.js.
- MotionMark/tests/bouncing-particles/resources/bouncing-css-images.js: Renamed from PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-css-images.js.
- MotionMark/tests/bouncing-particles/resources/bouncing-css-shapes.js: Renamed from PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-css-shapes.js.
- MotionMark/tests/bouncing-particles/resources/bouncing-svg-images.js: Renamed from PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-svg-images.js.
- MotionMark/tests/bouncing-particles/resources/bouncing-svg-particles.js: Renamed from PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-svg-particles.js.
- MotionMark/tests/bouncing-particles/resources/bouncing-svg-shapes.js: Renamed from PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-svg-shapes.js.
- MotionMark/tests/bouncing-particles/resources/bouncing-tagged-images.js: Renamed from PerformanceTests/Animometer/tests/bouncing-particles/resources/bouncing-tagged-images.js.
- MotionMark/tests/bouncing-particles/resources/image1.jpg: Renamed from PerformanceTests/Animometer/tests/bouncing-particles/resources/image1.jpg.
- MotionMark/tests/bouncing-particles/resources/image2.jpg: Renamed from PerformanceTests/Animometer/tests/bouncing-particles/resources/image2.jpg.
- MotionMark/tests/bouncing-particles/resources/image3.jpg: Renamed from PerformanceTests/Animometer/tests/bouncing-particles/resources/image3.jpg.
- MotionMark/tests/bouncing-particles/resources/image4.jpg: Renamed from PerformanceTests/Animometer/tests/bouncing-particles/resources/image4.jpg.
- MotionMark/tests/bouncing-particles/resources/image5.jpg: Renamed from PerformanceTests/Animometer/tests/bouncing-particles/resources/image5.jpg.
- MotionMark/tests/dom/compositing-transforms.html: Renamed from PerformanceTests/Animometer/tests/dom/compositing-transforms.html.
- MotionMark/tests/dom/focus.html: Renamed from PerformanceTests/Animometer/tests/dom/focus.html.
- MotionMark/tests/dom/leaves.html: Renamed from PerformanceTests/Animometer/tests/dom/leaves.html.
- MotionMark/tests/dom/particles.html: Renamed from PerformanceTests/Animometer/tests/dom/particles.html.
- MotionMark/tests/dom/resources/compositing-transforms.js: Renamed from PerformanceTests/Animometer/tests/dom/resources/compositing-transforms.js.
- MotionMark/tests/dom/resources/dom-particles.js: Renamed from PerformanceTests/Animometer/tests/dom/resources/dom-particles.js.
- MotionMark/tests/dom/resources/focus.js: Renamed from PerformanceTests/Animometer/tests/dom/resources/focus.js.
- MotionMark/tests/dom/resources/leaves.js: Renamed from PerformanceTests/Animometer/tests/dom/resources/leaves.js.
- MotionMark/tests/master/canvas-stage.html: Renamed from PerformanceTests/Animometer/tests/master/canvas-stage.html.
- MotionMark/tests/master/focus.html: Renamed from PerformanceTests/Animometer/tests/master/focus.html.
- MotionMark/tests/master/image-data.html: Renamed from PerformanceTests/Animometer/tests/master/image-data.html.
- MotionMark/tests/master/leaves.html: Renamed from PerformanceTests/Animometer/tests/master/leaves.html.
- MotionMark/tests/master/multiply.html: Renamed from PerformanceTests/Animometer/tests/master/multiply.html.
- MotionMark/tests/master/resources/canvas-stage.js: Renamed from PerformanceTests/Animometer/tests/master/resources/canvas-stage.js.
- MotionMark/tests/master/resources/canvas-tests.js: Renamed from PerformanceTests/Animometer/tests/master/resources/canvas-tests.js.
- MotionMark/tests/master/resources/compass.svg: Renamed from PerformanceTests/Animometer/tests/master/resources/compass.svg.
- MotionMark/tests/master/resources/compass100.png: Renamed from PerformanceTests/Animometer/tests/master/resources/compass100.png.
- MotionMark/tests/master/resources/console.svg: Renamed from PerformanceTests/Animometer/tests/master/resources/console.svg.
- MotionMark/tests/master/resources/console100.png: Renamed from PerformanceTests/Animometer/tests/master/resources/console100.png.
- MotionMark/tests/master/resources/contribute.svg: Renamed from PerformanceTests/Animometer/tests/master/resources/contribute.svg.
- MotionMark/tests/master/resources/contribute100.png: Renamed from PerformanceTests/Animometer/tests/master/resources/contribute100.png.
- MotionMark/tests/master/resources/debugger.svg: Renamed from PerformanceTests/Animometer/tests/master/resources/debugger.svg.
- MotionMark/tests/master/resources/debugger100.png: Renamed from PerformanceTests/Animometer/tests/master/resources/debugger100.png.
- MotionMark/tests/master/resources/focus.js: Renamed from PerformanceTests/Animometer/tests/master/resources/focus.js.
- MotionMark/tests/master/resources/image-data.js: Renamed from PerformanceTests/Animometer/tests/master/resources/image-data.js.
- MotionMark/tests/master/resources/inspector.svg: Renamed from PerformanceTests/Animometer/tests/master/resources/inspector.svg.
- MotionMark/tests/master/resources/inspector100.png: Renamed from PerformanceTests/Animometer/tests/master/resources/inspector100.png.
- MotionMark/tests/master/resources/layout.svg: Renamed from PerformanceTests/Animometer/tests/master/resources/layout.svg.
- MotionMark/tests/master/resources/layout100.png: Renamed from PerformanceTests/Animometer/tests/master/resources/layout100.png.
- MotionMark/tests/master/resources/leaves.js: Renamed from PerformanceTests/Animometer/tests/master/resources/leaves.js.
- MotionMark/tests/master/resources/multiply.js: Renamed from PerformanceTests/Animometer/tests/master/resources/multiply.js.
- MotionMark/tests/master/resources/particles.js: Renamed from PerformanceTests/Animometer/tests/master/resources/particles.js.
- MotionMark/tests/master/resources/performance.svg: Renamed from PerformanceTests/Animometer/tests/master/resources/performance.svg.
- MotionMark/tests/master/resources/performance100.png: Renamed from PerformanceTests/Animometer/tests/master/resources/performance100.png.
- MotionMark/tests/master/resources/script.svg: Renamed from PerformanceTests/Animometer/tests/master/resources/script.svg.
- MotionMark/tests/master/resources/script100.png: Renamed from PerformanceTests/Animometer/tests/master/resources/script100.png.
- MotionMark/tests/master/resources/shortcuts.svg: Renamed from PerformanceTests/Animometer/tests/master/resources/shortcuts.svg.
- MotionMark/tests/master/resources/shortcuts100.png: Renamed from PerformanceTests/Animometer/tests/master/resources/shortcuts100.png.
- MotionMark/tests/master/resources/standards.svg: Renamed from PerformanceTests/Animometer/tests/master/resources/standards.svg.
- MotionMark/tests/master/resources/standards100.png: Renamed from PerformanceTests/Animometer/tests/master/resources/standards100.png.
- MotionMark/tests/master/resources/storage.svg: Renamed from PerformanceTests/Animometer/tests/master/resources/storage.svg.
- MotionMark/tests/master/resources/storage100.png: Renamed from PerformanceTests/Animometer/tests/master/resources/storage100.png.
- MotionMark/tests/master/resources/styles.svg: Renamed from PerformanceTests/Animometer/tests/master/resources/styles.svg.
- MotionMark/tests/master/resources/styles100.png: Renamed from PerformanceTests/Animometer/tests/master/resources/styles100.png.
- MotionMark/tests/master/resources/svg-particles.js: Renamed from PerformanceTests/Animometer/tests/master/resources/svg-particles.js.
- MotionMark/tests/master/resources/text.js: Renamed from PerformanceTests/Animometer/tests/master/resources/text.js.
- MotionMark/tests/master/resources/timeline.svg: Renamed from PerformanceTests/Animometer/tests/master/resources/timeline.svg.
- MotionMark/tests/master/resources/timeline100.png: Renamed from PerformanceTests/Animometer/tests/master/resources/timeline100.png.
- MotionMark/tests/master/svg-particles.html: Renamed from PerformanceTests/Animometer/tests/master/svg-particles.html.
- MotionMark/tests/master/text.html: Renamed from PerformanceTests/Animometer/tests/master/text.html.
- MotionMark/tests/resources/main.js: Renamed from PerformanceTests/Animometer/tests/resources/main.js.
- MotionMark/tests/resources/math.js: Renamed from PerformanceTests/Animometer/tests/resources/math.js.
- MotionMark/tests/resources/stage.css: Renamed from PerformanceTests/Animometer/tests/resources/stage.css.
- MotionMark/tests/resources/star.svg: Renamed from PerformanceTests/Animometer/tests/resources/star.svg.
- MotionMark/tests/resources/yin-yang.png: Renamed from PerformanceTests/Animometer/tests/resources/yin-yang.png.
- MotionMark/tests/resources/yin-yang.svg: Renamed from PerformanceTests/Animometer/tests/resources/yin-yang.svg.
- MotionMark/tests/simple/resources/simple-canvas-paths.js: Renamed from PerformanceTests/Animometer/tests/simple/resources/simple-canvas-paths.js.
- MotionMark/tests/simple/resources/simple-canvas.js: Renamed from PerformanceTests/Animometer/tests/simple/resources/simple-canvas.js.
- MotionMark/tests/simple/resources/tiled-canvas-image.js: Renamed from PerformanceTests/Animometer/tests/simple/resources/tiled-canvas-image.js.
- MotionMark/tests/simple/simple-canvas-paths.html: Renamed from PerformanceTests/Animometer/tests/simple/simple-canvas-paths.html.
- MotionMark/tests/simple/tiled-canvas-image.html: Renamed from PerformanceTests/Animometer/tests/simple/tiled-canvas-image.html.
- MotionMark/tests/template/resources/template-canvas.js: Renamed from PerformanceTests/Animometer/tests/template/resources/template-canvas.js.
- MotionMark/tests/template/resources/template-css.js: Renamed from PerformanceTests/Animometer/tests/template/resources/template-css.js.
- MotionMark/tests/template/resources/template-svg.js: Renamed from PerformanceTests/Animometer/tests/template/resources/template-svg.js.
- MotionMark/tests/template/template-canvas.html: Renamed from PerformanceTests/Animometer/tests/template/template-canvas.html.
- MotionMark/tests/template/template-css.html: Renamed from PerformanceTests/Animometer/tests/template/template-css.html.
- MotionMark/tests/template/template-svg.html: Renamed from PerformanceTests/Animometer/tests/template/template-svg.html.
- 3:38 PM Changeset in webkit [210458] by
-
- 3 edits in trunk/Source/JavaScriptCore
The ObjC API's JSVirtualMachine's map tables need to be guarded by a lock.
https://bugs.webkit.org/show_bug.cgi?id=166778
<rdar://problem/29761198>
Reviewed by Filip Pizlo.
Now that we have a concurrent GC, access to JSVirtualMachine's
m_externalObjectGraph and m_externalRememberedSet need to be guarded by a lock
since both the GC marker thread and the mutator thread may access them at the
same time.
- API/JSVirtualMachine.mm:
(-[JSVirtualMachine addExternalRememberedObject:]):
(-[JSVirtualMachine addManagedReference:withOwner:]):
(-[JSVirtualMachine removeManagedReference:withOwner:]):
(-[JSVirtualMachine externalDataMutex]):
(scanExternalObjectGraph):
(scanExternalRememberedSet):
- API/JSVirtualMachineInternal.h:
- Deleted externalObjectGraph method. There's no need to expose this.
- 3:30 PM Changeset in webkit [210457] by
-
- 3 edits1 add in trunk
@putByValDirect in Array.of and Array.from overwrites non-writable/configurable properties
https://bugs.webkit.org/show_bug.cgi?id=153486
Reviewed by Saam Barati.
JSTests:
New regression test.
- stress/regress-153486.js: Added.
(shouldEqual):
(makeUnwriteableUnconfigurableObject):
(testArrayOf):
(testArrayFrom):
(runTest):
Source/JavaScriptCore:
Moved read only check in putDirect() to all paths.
- runtime/SparseArrayValueMap.cpp:
(JSC::SparseArrayValueMap::putDirect):
- 3:29 PM Changeset in webkit [210456] by
-
- 3 edits in trunk/Source/WebCore
Text highlight causes Yoon Gothic webfont to reflow.
https://bugs.webkit.org/show_bug.cgi?id=166753
Reviewed by Darin Adler.
Add word-break: keep-all; support for CJK and breaking NBSPs.
Add test later. Need to figure out what font file to use.
- rendering/SimpleLineLayoutTextFragmentIterator.cpp:
(WebCore::SimpleLineLayout::TextFragmentIterator::Style::Style):
(WebCore::SimpleLineLayout::TextFragmentIterator::nextBreakablePosition): Use BreakingContext's helper functions
to figure out the next breakable position.
(WebCore::SimpleLineLayout::TextFragmentIterator::skipToNextPosition):
- rendering/SimpleLineLayoutTextFragmentIterator.h:
- 12:46 PM Changeset in webkit [210455] by
-
- 2 edits in tags/Safari-603.1.18.0.1/Source/JavaScriptCore
Merge r210444. rdar://problem/29906144
- 12:38 PM Changeset in webkit [210454] by
-
- 5 edits in tags/Safari-603.1.18.0.1/Source
Versioning.
- 12:38 PM Changeset in webkit [210453] by
-
- 2 edits in trunk/LayoutTests
Marking fast/text/variations/advances.html as failing on Sierra.
https://bugs.webkit.org/show_bug.cgi?id=166672
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 12:36 PM Changeset in webkit [210452] by
-
- 1 copy in tags/Safari-603.1.18.0.1
New tag.
- 12:23 PM Changeset in webkit [210451] by
-
- 10 edits in trunk
DeferGC::~DeferGC should be super cheap
https://bugs.webkit.org/show_bug.cgi?id=166626
Reviewed by Saam Barati.
JSTests:
- stress/slow-path-generator-updating-current-node-dfg.js:
- stress/unshift-array-storage.js:
Source/JavaScriptCore:
Right now, ~DeferGC requires running the collector's full collectIfNecessaryOrDefer()
hook, which is super big. Normally, that hook would only be called from GC slow paths,
so it ought to be possible to add complex logic to it. It benefits the GC algorithm to
make that code smart, not necessarily fast.
The right thing for it to do is to have ~DeferGC check a boolean to see if
collectIfNecessaryOrDefer() had previously deferred anything, and only call it if that
is true. That's what this patch does.
Unfortunately, this means that we lose the collectAccordingToDeferGCProbability mode,
which we used for two tests. Since I could only see two tests that used this mode, I
felt that it was better to enhance the GC than to keep the tests. I filed bug 166627 to
bring back something like that mode.
Although this patch does make some paths faster, its real goal is to ensure that bug
165963 can add more logic to collectIfNecessaryOrDefer() without introducing a big
regression. Until then, I wouldn't be surprised if this patch was a progression, but I'm
not betting on it.
- heap/Heap.cpp:
(JSC::Heap::collectIfNecessaryOrDefer):
(JSC::Heap::decrementDeferralDepthAndGCIfNeededSlow):
(JSC::Heap::canCollect): Deleted.
(JSC::Heap::shouldCollectHeuristic): Deleted.
(JSC::Heap::shouldCollect): Deleted.
(JSC::Heap::collectAccordingToDeferGCProbability): Deleted.
(JSC::Heap::decrementDeferralDepthAndGCIfNeeded): Deleted.
- heap/Heap.h:
- heap/HeapInlines.h:
(JSC::Heap::incrementDeferralDepth):
(JSC::Heap::decrementDeferralDepth):
(JSC::Heap::decrementDeferralDepthAndGCIfNeeded):
(JSC::Heap::mayNeedToStop):
(JSC::Heap::stopIfNecessary):
- runtime/Options.h:
- 12:17 PM Changeset in webkit [210450] by
-
- 2 edits in trunk/LayoutTests
Skip editing/caret/emoji.html on ios-simulator since it relies on EventSender.keydown().
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 12:02 PM Changeset in webkit [210449] by
-
- 10 edits in trunk
Add some missing longhand properties to CSSComputedStyleDeclaration and fix default values
https://bugs.webkit.org/show_bug.cgi?id=166674
<rdar://problem/6026159>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-01-06
Reviewed by Darin Adler.
Source/WebCore:
- css/CSSComputedStyleDeclaration.cpp:
Add some missing longhand properties to the list of all longhand properties.
(WebCore::counterToCSSValue):
The default value for counter-increment and counter-reset should be "none"
not the empty string.
LayoutTests:
- fast/css/getComputedStyle/computed-style-font-family.html:
Skip font-variation-settings which is only available if the feature flag is enabled.
- fast/css/getComputedStyle/counterIncrement-without-counter-expected.txt:
- fast/css/getComputedStyle/counterIncrement-without-counter.html:
Fix the default value to be "none" instead of the empty string.
- svg/css/getComputedStyle-basic-expected.txt:
- fast/css/getComputedStyle/computed-style-expected.txt:
- fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- fast/css/getComputedStyle/resources/property-names.js:
Add some always expected to be available longhand properties to check.
- 11:54 AM Changeset in webkit [210448] by
-
- 90 edits80 deletes in branches/safari-603-branch
Roll out r209979-r210282 and r210259 as part of disabling Web Assembly. rdar://problem/29890343
- 10:55 AM Changeset in webkit [210447] by
-
- 9 edits3 adds in trunk
[Form Validation] "character" in maxlength validation message should be singular when maxlength is 1
https://bugs.webkit.org/show_bug.cgi?id=166712
<rdar://problem/29872292>
Reviewed by Darin Adler.
Source/WebCore:
Fix validation message to use singular form of "character" when maxLength value is 1.
Test: fast/forms/validation-message-maxLength.html
- English.lproj/Localizable.strings:
- English.lproj/Localizable.stringsdict: Added.
- WebCore.xcodeproj/project.pbxproj:
- extract-localizable-strings.pl:
- platform/LocalizedStrings.cpp:
- platform/LocalizedStrings.h:
- platform/cocoa/LocalizedStringsCocoa.mm:
(WebCore::localizedNString):
(WebCore::localizedString):
(WebCore::validationMessageTooLongText):
LayoutTests:
Add layout test coverage.
- fast/forms/validation-message-maxLength-expected.txt: Added.
- fast/forms/validation-message-maxLength.html: Added.
- platform/ios-simulator/TestExpectations:
- 10:50 AM Changeset in webkit [210446] by
-
- 5 edits in trunk/Tools
Support webkit-test-runner key-value pairs in http tests
https://bugs.webkit.org/show_bug.cgi?id=149812
Patch by Antoine Quint <Antoine Quint> on 2017-01-06
Reviewed by Alex Christensen.
We pass the absolute path for a test through to WKTR so that we can parse
tests that are running as URLs for webkit-test-runner options.
- DumpRenderTree/DumpRenderTreeCommon.cpp:
(parseInputLine):
Explicitly skip the --absolute-path option in DRT or else we'd crash.
- Scripts/webkitpy/port/driver.py:
(Driver._command_from_driver_input):
Pass the absolute path to the file through the CLI.
- WebKitTestRunner/TestController.cpp:
(WTR::updateTestOptionsFromTestHeader):
(WTR::TestController::testOptionsForTest):
(WTR::parseInputLine):
(WTR::TestController::runTest):
- WebKitTestRunner/TestController.h:
- 10:48 AM Changeset in webkit [210445] by
-
- 16 edits1 copy2 adds in trunk
Add support for MediaKeySystemAccess.createMediaKeys()
https://bugs.webkit.org/show_bug.cgi?id=166749
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/encrypted-media/mock-MediaKeySystemAccess.html
Implement MediaKeySystemAccess::createMediaKeys(). This requires some
additions to CDM, CDMPrivate, and a new interface CDMInstance to support
eventual platform adoption and to implement mock support for testing.
- Modules/encryptedmedia/CDM.cpp:
(WebCore::CDM::loadAndInitialize):
(WebCore::CDM::createInstance):
- Modules/encryptedmedia/CDM.h:
- Modules/encryptedmedia/CDMInstance.h:
(WebCore::CDMInstance::~CDMInstance):
- Modules/encryptedmedia/CDMPrivate.h:
- Modules/encryptedmedia/MediaKeySystemAccess.cpp:
(WebCore::MediaKeySystemAccess::createMediaKeys):
- Modules/encryptedmedia/MediaKeySystemAccess.h:
- Modules/encryptedmedia/MediaKeys.cpp:
(WebCore::MediaKeys::MediaKeys):
- Modules/encryptedmedia/MediaKeys.h:
(WebCore::MediaKeys::create):
- Modules/encryptedmedia/MediaKeys.idl:
- Modules/encryptedmedia/NavigatorEME.cpp:
(WebCore::tryNextSupportedConfiguration):
- WebCore.xcodeproj/project.pbxproj:
- testing/MockCDMFactory.cpp:
(WebCore::MockCDM::MockCDM):
(WebCore::MockCDM::createInstance):
(WebCore::MockCDM::loadAndInitialize):
(WebCore::MockCDMInstance::MockCDMInstance):
(WebCore::MockCDMInstance::initializeWithConfiguration):
(WebCore::MockCDMInstance::setDistinctiveIdentifiersAllowed):
(WebCore::MockCDMInstance::setPersistentStateAllowed):
- testing/MockCDMFactory.h:
(WebCore::MockCDMFactory::canCreateInstances):
(WebCore::MockCDMFactory::setCanCreateInstances):
(WebCore::MockCDM::factory):
- testing/MockCDMFactory.idl:
LayoutTests:
- media/encrypted-media/mock-MediaKeySystemAccess-expected.txt: Added.
- media/encrypted-media/mock-MediaKeySystemAccess.html: Added.
- platform/mac/TestExpectations:
- 9:55 AM Changeset in webkit [210444] by
-
- 2 edits in branches/safari-603-branch/Source/JavaScriptCore
Disable WebAssembly. rdar://problem/29890343
- 9:32 AM Changeset in webkit [210443] by
-
- 2 edits in trunk/LayoutTests
Add pass expectation for fast/text/emoji-num-glyphs.html on Sierra.
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 9:23 AM Changeset in webkit [210442] by
-
- 2 edits in branches/safari-603-branch/LayoutTests
Merge r210377.
- 9:13 AM Changeset in webkit [210441] by
-
- 2 edits in trunk/LayoutTests
Marking three pointer-lock tests as crashing on mac-wk2 debug.
https://bugs.webkit.org/show_bug.cgi?id=166765
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 7:38 AM Changeset in webkit [210440] by
-
- 2 edits in branches/safari-603-branch/JSTests
Merge r210285. rdar://problem/29779182
- 7:38 AM Changeset in webkit [210439] by
-
- 4 edits1 add in branches/safari-603-branch
Merge r210276. rdar://problem/28867002
- 7:38 AM Changeset in webkit [210438] by
-
- 2 edits in branches/safari-603-branch/Source/JavaScriptCore
Merge r210259. rdar://problem/29856455
- 7:38 AM Changeset in webkit [210437] by
-
- 19 edits in branches/safari-603-branch
Merge r210221. rdar://problem/29449474
- 6:05 AM Changeset in webkit [210436] by
-
- 30 edits in trunk/Source/WebCore
Give RenderObject a Page& getter.
<https://webkit.org/b/166735>
Reviewed by Darin Adler.
The render tree should now only ever be live while in a Frame that's connected to a Page.
Hence we can give RenderObject a Page& getter and simplify a lot of code that previously
had to get the Page from Document (or Frame) and perform null checks on it.
- dom/Document.cpp:
(WebCore::Document::destroyRenderTree): Assert that the Page is present when we tear the render tree down.
- page/Frame.cpp:
(WebCore::Frame::willDetachPage): Assert that there's no render tree when we're about to detach from the Page.
Also added a comment explaining the two main ways that render trees die.
- rendering/RenderObject.h:
(WebCore::RenderObject::page): Added. So neat!
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::estimatedLoadingProgress):
- rendering/ImageQualityController.cpp:
(WebCore::ImageQualityController::chooseInterpolationQuality):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
- rendering/RenderAttachment.cpp:
(WebCore::RenderAttachment::layout):
(WebCore::RenderAttachment::baselinePosition):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintCaret):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
(WebCore::setupWheelEventTestTrigger):
(WebCore::RenderBox::setScrollLeft):
(WebCore::RenderBox::setScrollTop):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::paintFocusRing):
- rendering/RenderEmbeddedObject.cpp:
(WebCore::shouldUnavailablePluginMessageBeButton):
(WebCore::RenderEmbeddedObject::paint):
(WebCore::RenderEmbeddedObject::paintReplaced):
(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):
(WebCore::RenderEmbeddedObject::handleUnavailablePluginIndicatorEvent):
(WebCore::RenderEmbeddedObject::getCursor):
- rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::paintReplaced):
- rendering/RenderIFrame.cpp:
(WebCore::RenderIFrame::flattenFrame):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::paintReplaced):
(WebCore::RenderImage::paintAreaElementFocusRing):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::~RenderLayer):
(WebCore::RenderLayer::forceUpdateScrollbarsOnMainThreadForPerformanceTesting):
(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::isActive):
(WebCore::RenderLayer::didStartScroll):
(WebCore::RenderLayer::didEndScroll):
(WebCore::RenderLayer::didUpdateScroll):
(WebCore::RenderLayer::createScrollbar):
(WebCore::RenderLayer::setupFontSubpixelQuantization):
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):
(WebCore::RenderLayerBacking::createGraphicsLayer):
(WebCore::RenderLayerBacking::updateOverflowControlsLayers):
(WebCore::RenderLayerBacking::detachFromScrollingCoordinator):
(WebCore::RenderLayerBacking::paintContents):
(WebCore::RenderLayerBacking::shouldAggressivelyRetainTiles):
(WebCore::RenderLayerBacking::shouldTemporarilyRetainTileCohorts):
(WebCore::RenderLayerBacking::useGiantTiles):
(WebCore::RenderLayerBacking::verifyNotPainting):
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::scrollingCoordinatorFromLayer): Deleted.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
(WebCore::RenderLayerCompositor::scheduleLayerFlushNow):
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::updateScrollingLayerWithClient):
(WebCore::RenderLayerCompositor::updateCustomLayersAfterFlush):
(WebCore::RenderLayerCompositor::notifyFlushBeforeDisplayRefresh):
(WebCore::RenderLayerCompositor::layerTiledBackingUsageChanged):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::appendDocumentOverlayLayers):
(WebCore::RenderLayerCompositor::layerBecameNonComposited):
(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::pageScaleFactor):
(WebCore::RenderLayerCompositor::zoomedOutPageScaleFactor):
(WebCore::RenderLayerCompositor::contentsScaleMultiplierForNewTiles):
(WebCore::RenderLayerCompositor::updateLayerForHeader):
(WebCore::RenderLayerCompositor::updateLayerForFooter):
(WebCore::RenderLayerCompositor::setRootExtendedBackgroundColor):
(WebCore::RenderLayerCompositor::attachRootLayer):
(WebCore::RenderLayerCompositor::detachRootLayer):
(WebCore::RenderLayerCompositor::rootLayerAttachmentChanged):
(WebCore::RenderLayerCompositor::registerAllScrollingLayers):
(WebCore::RenderLayerCompositor::scrollingCoordinator):
(WebCore::RenderLayerCompositor::graphicsLayerFactory):
(WebCore::RenderLayerCompositor::createDisplayRefreshMonitor):
(WebCore::RenderLayerCompositor::page):
- rendering/RenderLayerCompositor.h:
- rendering/RenderListBox.cpp:
(WebCore::setupWheelEventTestTrigger):
(WebCore::RenderListBox::setScrollTop):
(WebCore::RenderListBox::isActive):
(WebCore::RenderListBox::forceUpdateScrollbarsOnMainThreadForPerformanceTesting):
(WebCore::RenderListBox::createScrollbar):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::theme):
- rendering/RenderObject.h:
(WebCore::RenderObject::page):
- rendering/RenderSearchField.cpp:
(WebCore::RenderSearchField::addSearchResult):
(WebCore::RenderSearchField::showPopup):
(WebCore::RenderSearchField::valueChanged):
- rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::updateSnapshot):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::updateControlStatesForRenderer):
(WebCore::RenderTheme::isActive):
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintCellAndSetFocusedElementNeedsRepaintIfNecessary):
(WebCore::RenderThemeMac::paintSliderThumb):
- rendering/RenderVideo.cpp:
(WebCore::RenderVideo::paintReplaced):
- rendering/RenderView.cpp:
(WebCore::RenderView::pageNumberForBlockProgressionOffset):
(WebCore::RenderView::pageCount):
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::paintReplaced):
- style/StyleResolveForDocument.cpp:
(WebCore::Style::resolveForDocument):
- 1:47 AM Changeset in webkit [210435] by
-
- 2 edits in trunk/LayoutTests
Fixed duplicate test expectation entries on Windows.
Unreviewed test gardening.
- platform/win/TestExpectations:
- 1:16 AM Changeset in webkit [210434] by
-
- 2 edits in trunk/Tools
Warning about unconnectable outlets when opening a MiniBrowser window
https://bugs.webkit.org/show_bug.cgi?id=166756
Reviewed by Dan Bernstein.
- MiniBrowser/mac/BrowserWindow.xib:
When launching MiniBrowser, it says:
Failed to connect (Share) outlet from (WK1BrowserWindowController) to
(MBToolbarItem): missing setter or instance variable
Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
(NSButtonCell): missing setter or instance variable.
It looks like someone added the connection from the share button
to the BrowserWindowController three times; only one of the connections
is valid. Remove the other two.
Jan 5, 2017:
- 8:09 PM Changeset in webkit [210433] by
-
- 3 edits in trunk/Source/WebCore
TextFragmentIterator::runWidth does not need typename CharacterType<> anymore.
https://bugs.webkit.org/show_bug.cgi?id=166751
Reviewed by Simon Fraser.
No change in functionality.
- rendering/SimpleLineLayoutTextFragmentIterator.cpp:
(WebCore::SimpleLineLayout::TextFragmentIterator::textWidth):
- rendering/SimpleLineLayoutTextFragmentIterator.h:
- 7:45 PM Changeset in webkit [210432] by
-
- 24 edits2 adds in trunk
Finding text doesn't work across shadow boundary
https://bugs.webkit.org/show_bug.cgi?id=158503
Reviewed by Antti Koivisto.
Source/WebCore:
Added a new TextIterator behavior flag, TextIteratorTraversesFlatTree, which makes TextIterator traverse
the flat tree instead of the DOM tree, and made this behavior default in findPlainText.
Also added a new find options flag, DoNotTraverseFlatTree, to suppress this behavior in window.find(~)
and execCommand('FindString', false, ~) as they should not be able to peek information inside shadow trees.
Unfortunately these APIs have been deprecated in the standards so there is no specification to follow.
For now, we don't support finding a word or a keyword across a shadow boundary as this would require
making rangeOfString and other related functions return a Range-like object that can cross shadow boundaries.
Also added internals.rangeOfString to test Editor::rangeOfString, and replaced the bit-flag arguments
to internals.countMatchesForText and internals.countFindMatches by an array of strings for better portability.
Test: editing/text-iterator/find-string-on-flat-tree.html
- editing/Editor.cpp:
(WebCore::Editor::rangeOfString): Use the modern containingShadowRoot instead of nonBoundaryShadowTreeRootNode
since the start container can be a shadow root, which nonBoundaryShadowTreeRootNode asserts not be the case.
- editing/Editor.h:
- editing/EditorCommand.cpp:
(WebCore::executeFindString): Don't traverse across shadow boundaries.
- editing/FindOptions.h: Added DoNotTraverseFlatTree.
- editing/TextIterator.cpp:
(WebCore::assignedAuthorSlot): Added.
(WebCore::authorShadowRoot): Added.
(WebCore::firstChildInFlatTreeIgnoringUserAgentShadow): Added.
(WebCore::nextSiblingInFlatTreeIgnoringUserAgentShadow): Added.
(WebCore::firstChild): Added. Traverses the flat tree when TextIteratorTraversesFlatTree is set.
(WebCore::nextSibling): Ditto.
(WebCore::parentNodeOrShadowHost): Ditto.
(WebCore::TextIterator::advance): Don't set m_handledChildren to true when the current node has display: contents.
(WebCore::findPlainText): Use TextIteratorTraversesFlatTree unless DoNotTraverseFlatTree is set.
- editing/TextIteratorBehavior.h: Added TextIteratorTraversesFlatTree.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::find): Don't traverse across shadow boundaries.
- testing/Internals.cpp:
(WebCore::parseFindOptions): Added.
(WebCore::Internals::rangeOfString): Added.
(WebCore::Internals::countMatchesForText): Replaced the find options by an array of strings instead of a bit mask.
(WebCore::Internals::countFindMatches): Ditto.
- testing/Internals.h:
- testing/Internals.idl: Added rangeOfString, and replaced find options bit-flag in countMatchesForText and
countFindMatches by an array of strings so that the tests themselves don't rely on a specific value of each bit flag.
LayoutTests:
Updated the existing tests per changes to use an array of find options instead of raw bit mask,
and added a regression test for finding text by traversing flat tree along with testing
window.find and execCommand('FindString', false, ~) not walking across shadow boundaries.
- editing/text-iterator/count-mark-lineboxes-expected.txt:
- editing/text-iterator/count-mark-lineboxes.html:
- editing/text-iterator/count-mark-simple-lines-expected.txt:
- editing/text-iterator/count-mark-simple-lines.html:
- editing/text-iterator/count-matches-in-form-expected.txt:
- editing/text-iterator/count-matches-in-form.html:
- editing/text-iterator/count-matches-in-frames.html:
- editing/text-iterator/find-string-on-flat-tree-expected.txt: Added.
- editing/text-iterator/find-string-on-flat-tree.html: Added.
- fast/text/mark-matches-broken-line-rendering.html:
- fast/text/mark-matches-overflow-clip.html:
- fast/text/mark-matches-rendering-simple-lines-expected.html:
- fast/text/mark-matches-rendering-simple-lines.html:
- fast/text/mark-matches-rendering.html:
- 7:30 PM Changeset in webkit [210431] by
-
- 5 edits in branches/safari-602-branch/Source
Versioning.
- 7:27 PM Changeset in webkit [210430] by
-
- 1 copy in tags/Safari-602.4.8
New tag.
- 7:27 PM Changeset in webkit [210429] by
-
- 5 edits in branches/safari-602-branch/Source
Versioning.
- 7:25 PM Changeset in webkit [210428] by
-
- 2 edits in branches/safari-602-branch/Source/WebCore
Merged r210328. rdar://problem/29885151
- 7:14 PM Changeset in webkit [210427] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, teach run-javascriptcore-tests that this is a slow test.
- js/script-tests/regress-139548.js:
- 6:48 PM Changeset in webkit [210426] by
-
- 1 copy in tags/Safari-602.4.7
New tag.
- 6:47 PM Changeset in webkit [210425] by
-
- 3 edits in trunk/Source/WebCore
[Form Validation] lengthy validation messages should be truncated with an ellipsis
https://bugs.webkit.org/show_bug.cgi?id=166747
<rdar://problem/29872021>
Reviewed by Simon Fraser.
Lengthy HTML validation messages should be truncated with an ellipsis.
Previously, they were truncated but there was no ellipsis.
No new tests, not easily testable. Manually tested on
- http://codepen.io/cdumez/full/zoOZmZ/ (last field)
- platform/ios/ValidationBubbleIOS.mm:
(WebCore::ValidationBubble::ValidationBubble):
- platform/mac/ValidationBubbleMac.mm:
(WebCore::ValidationBubble::ValidationBubble):
- 6:05 PM Changeset in webkit [210424] by
-
- 2 edits in branches/safari-602-branch/Source/WebCore
Roll out r210328. rdar://problem/29885151
- 5:55 PM Changeset in webkit [210423] by
-
- 3 edits2 adds in trunk
Radio buttons have a fixed border radius making them look square when resized
https://bugs.webkit.org/show_bug.cgi?id=148676
Source/WebCore:
rdar://problem/29889892
Reviewed by Tim Horton.
Change the 8px border-radius of iOS radio buttons to 50% so they remain circular
when the page overrides the size.
Test: fast/forms/ios/large-radio-button-is-round.html
- css/html.css:
(#if defined(WTF_PLATFORM_IOS) && WTF_PLATFORM_IOS):
LayoutTests:
Reviewed by Tim Horton.
- fast/forms/ios/large-radio-button-is-round-expected.html: Added.
- fast/forms/ios/large-radio-button-is-round.html: Added.
- 5:49 PM Changeset in webkit [210422] by
-
- 7 edits1 add in branches/safari-603-branch
Merge r210282. rdar://problem/29760326
- 5:49 PM Changeset in webkit [210421] by
-
- 41 edits1 copy2 adds in branches/safari-603-branch
Merge r210229. rdar://problem/29760322
- 5:49 PM Changeset in webkit [210420] by
-
- 2 edits in branches/safari-603-branch/Source/JavaScriptCore
Merge r210202. rdar://problem/29803676
- 5:49 PM Changeset in webkit [210419] by
-
- 40 edits5 adds in branches/safari-603-branch
Merge r210201. rdar://problem/29803676
- 5:49 PM Changeset in webkit [210418] by
-
- 19 edits in branches/safari-603-branch
Merge r210073. rdar://problem/29762017
- 5:48 PM Changeset in webkit [210417] by
-
- 8 edits4 adds in branches/safari-603-branch
Merge r210244. rdar://problem/29844107
- 5:48 PM Changeset in webkit [210416] by
-
- 4 edits1 add in branches/safari-603-branch
Merge r210228. rdar://problem/29841541
- 5:48 PM Changeset in webkit [210415] by
-
- 57 edits in branches/safari-603-branch/JSTests
Merge r210204. rdar://problem/29814999
- 5:48 PM Changeset in webkit [210414] by
-
- 4 edits1 add in branches/safari-603-branch
Merge r210203. rdar://problem/29815000
- 5:48 PM Changeset in webkit [210413] by
-
- 8 edits in branches/safari-603-branch
Merge r210137. rdar://problem/29760386
- 5:48 PM Changeset in webkit [210412] by
-
- 5 edits in branches/safari-603-branch
Merge r210127. rdar://problem/29795709
- 5:48 PM Changeset in webkit [210411] by
-
- 5 edits1 add in branches/safari-603-branch
Merge r210126. rdar://problem/29793949
- 5:48 PM Changeset in webkit [210410] by
-
- 4 edits in branches/safari-603-branch
Merge r210115. rdar://problem/29793220
- 5:48 PM Changeset in webkit [210409] by
-
- 7 edits in branches/safari-603-branch
Merge r210111. rdar://problem/29791695
- 5:48 PM Changeset in webkit [210408] by
-
- 7 edits in branches/safari-603-branch
Merge r210102. rdar://problem/29784532
- 5:48 PM Changeset in webkit [210407] by
-
- 4 edits in branches/safari-603-branch
Merge r210091. rdar://problem/29782833
- 5:47 PM Changeset in webkit [210406] by
-
- 9 edits4 adds in branches/safari-603-branch
Merge r210090. rdar://problem/29782821
- 5:47 PM Changeset in webkit [210405] by
-
- 4 edits57 adds in branches/safari-603-branch
Merge r210087. rdar://problem/29760621
- 5:47 PM Changeset in webkit [210404] by
-
- 8 edits in branches/safari-603-branch/Source/JavaScriptCore
Merge r210047. rdar://problem/29758107
- 5:47 PM Changeset in webkit [210403] by
-
- 10 edits in branches/safari-603-branch/Source/JavaScriptCore
Merge r210038. rdar://problem/29759741
- 5:47 PM Changeset in webkit [210402] by
-
- 25 edits3 adds in branches/safari-603-branch
Merge r210026. rdar://problem/29735737
- 5:47 PM Changeset in webkit [210401] by
-
- 9 edits2 adds in branches/safari-603-branch
Merge r209979. rdar://problem/29735737
- 5:06 PM Changeset in webkit [210400] by
-
- 2 edits in trunk/Source/WebCore
CoreText variation axis identifiers don't work with 64-bit numbers
https://bugs.webkit.org/show_bug.cgi?id=166745
<rdar://problem/29856541>
<rdar://problem/29848883>
Reviewed by Tim Horton.
There is a bug where some CFNumbers are getting garbage results when
being placed into a 64-bit field. Luckily, we don't need the full
64-bits; 32-bits is sufficient.
Test: fast/text/international/system-language/hindi-system-font-punctuation.html
- platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::defaultVariationValues):
- 5:04 PM Changeset in webkit [210399] by
-
- 4 edits4 adds in trunk
Carets can split up marriages and families
https://bugs.webkit.org/show_bug.cgi?id=166711
<rdar://problem/29019333>
Reviewed by Alex Christensen.
Source/WTF:
There are four code points which should be allowed to accept emoji modifiers:
- U+1F46A FAMILY
- U+1F46B MAN AND WOMAN HOLDING HANDS
- U+1F46C TWO MEN HOLDING HANDS
- U+1F46D TWO WOMEN HOLDING HANDS
Even though macOS's and iOS's emoji keyboard don't allow users to actually type
these combinations, we may still receive them from other platforms. We should
therefore treat these as joining sequences. Rendering isn't a problem because
the fonts accept the emoji modifiers, but our caret placement code isn't educated
about it. Currently, we treat these emoji groups as ligatures, allowing the caret
to be placed between the two code points, which visually shows as being horizontally
centered in the glyph. Instead, we should treat these code points as accepting
emoji modifiers.
Tests: editing/caret/emoji.html
editing/caret/ios/emoji.html
- wtf/text/TextBreakIterator.cpp:
(WTF::cursorMovementIterator):
LayoutTests:
AFAICT we don't have a test where we arrow-through a set of emoji. We do
have tests where we backspace-through a set of emoji. Add a new test for
the arrow keys.
- platform/ios/TestExpectations:
- platform/mac/editing/caret/emoji-expected.txt: Added.
- editing/caret/emoji.html: Added.
- editing/caret/ios/emoji-expected.txt: Added.
- editing/caret/ios/emoji.html: Added.
- 4:24 PM Changeset in webkit [210398] by
-
- 5 edits in trunk/Source
AutomaticThread timeout shutdown leaves a small window where notify() would think that the thread is still running
https://bugs.webkit.org/show_bug.cgi?id=166742
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
Update to new AutomaticThread API.
- dfg/DFGWorklist.cpp:
Source/WTF:
Remove the use of the RAII ThreadScope, since the use of RAII helped make this bug possible:
we'd do ~ThreadScope after we had done ~LockHolder, so in between when we decided to shut
down a thread and when it reported itself as being shut down, there was a window where a
notify() call would get confused.
Now, we run all thread shutdown stuff while the lock is held. We release the lock last. One
API implication is that threadWillStop becomes threadIsStopping and it's called while the
lock is held. This seems benign.
- wtf/AutomaticThread.cpp:
(WTF::AutomaticThread::start):
(WTF::AutomaticThread::threadIsStopping):
(WTF::AutomaticThread::ThreadScope::ThreadScope): Deleted.
(WTF::AutomaticThread::ThreadScope::~ThreadScope): Deleted.
(WTF::AutomaticThread::threadWillStop): Deleted.
- wtf/AutomaticThread.h:
- 3:50 PM Changeset in webkit [210397] by
-
- 4 edits in branches/safari-603-branch/Source
Merge r210372. rdar://problem/29870033
- 3:49 PM Changeset in webkit [210396] by
-
- 3 edits2 adds in branches/safari-603-branch
Merge r210369. rdar://problem/29100419
- 3:49 PM Changeset in webkit [210395] by
-
- 2 edits in branches/safari-603-branch/Source/WebCore
Merge r210368. rdar://problem/28908164
- 3:49 PM Changeset in webkit [210394] by
-
- 5 edits in branches/safari-603-branch
Merge r210361. rdar://problem/29870245
- 3:49 PM Changeset in webkit [210393] by
-
- 2 edits in branches/safari-603-branch/Source/WebKit2
Merge r210363. rdar://problem/19595567
- 3:49 PM Changeset in webkit [210392] by
-
- 12 edits in branches/safari-603-branch/Source
Merge r210360. rdar://problem/19595567
- 3:49 PM Changeset in webkit [210391] by
-
- 6 edits in branches/safari-603-branch/Source
Merge r210359. rdar://problem/29882478
- 3:49 PM Changeset in webkit [210390] by
-
- 2 edits in branches/safari-603-branch/Source/WebCore
Merge r210328. rdar://problem/29870673
- 3:49 PM Changeset in webkit [210389] by
-
- 2 edits in branches/safari-603-branch/JSTests
Merge r210312. rdar://problem/29876342
- 3:49 PM Changeset in webkit [210388] by
-
- 2 edits in branches/safari-603-branch/Source/WebInspectorUI
Merge r210311. rdar://problem/29871716
- 3:49 PM Changeset in webkit [210387] by
-
- 4 edits in branches/safari-603-branch/Source/WebCore
Merge r210288. rdar://problem/29741862
- 3:49 PM Changeset in webkit [210386] by
-
- 5 edits4 adds in branches/safari-603-branch
Merge r210284. rdar://problem/29865854
- 3:49 PM Changeset in webkit [210385] by
-
- 8 edits6 adds in branches/safari-603-branch
Merge r210279. rdar://problem/29607569
- 3:49 PM Changeset in webkit [210384] by
-
- 10 edits4 adds in branches/safari-603-branch
Merge r210267. rdar://problem/29796608
- 3:49 PM Changeset in webkit [210383] by
-
- 2 edits in branches/safari-603-branch/Source/WebInspectorUI
Merge r210252. rdar://problem/29854762
- 3:49 PM Changeset in webkit [210382] by
-
- 2 edits in branches/safari-603-branch/Source/WebInspectorUI
Merge r210046. rdar://problem/27553228
- 3:49 PM Changeset in webkit [210381] by
-
- 9 edits in branches/safari-603-branch/Tools
Merge r210048. rdar://problem/29316054
- 3:49 PM Changeset in webkit [210380] by
-
- 2 edits in branches/safari-603-branch/LayoutTests
Merge r210022. rdar://problem/29316054
- 3:42 PM Changeset in webkit [210379] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Remove unused delegate from VisualStyleSelectorSection
https://bugs.webkit.org/show_bug.cgi?id=166744
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-01-05
Reviewed by Alex Christensen.
- UserInterface/Views/VisualStyleDetailsPanel.js:
(WebInspector.VisualStyleDetailsPanel.prototype.initialLayout):
- UserInterface/Views/VisualStyleSelectorSection.js:
(WebInspector.VisualStyleSelectorSection):
- 3:37 PM Changeset in webkit [210378] by
-
- 2 edits in trunk/Source/WebCore
Start hittesting a clean tree in RenderEmbeddedObject::isReplacementObscured
https://bugs.webkit.org/show_bug.cgi?id=166743
<rdar://problem/29024384>
Reviewed by Simon Fraser.
Unable to reproduce.
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::isReplacementObscured):
- 2:40 PM Changeset in webkit [210377] by
-
- 2 edits in trunk/LayoutTests
Rebaseline fast/canvas/webgl/context-creation-attributes.html after r210372.
Unreviewed test gardening.
- fast/canvas/webgl/context-creation-attributes-expected.txt:
- 2:18 PM Changeset in webkit [210376] by
-
- 2 edits in trunk/Source/WebCore
Crash inside Editor::styleForSelectionStart
https://bugs.webkit.org/show_bug.cgi?id=166710
Reviewed by Chris Dumez.
Added a null pointer check. This crash can happen when the DOM is mutated as editorState tries
to compute the style at the selection start.
No new tests since there is no reproducible test case, and I couldn't come up with one either.
This crash seems to retire some intricate dependency between when DOM is mutated, selection is
updated, and then performPostLayoutTasks ends up updating the editor state in response to
the element's editabilty changing.
- editing/cocoa/EditorCocoa.mm:
(WebCore::Editor::styleForSelectionStart):
- 1:35 PM Changeset in webkit [210375] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r210370.
This change caused hundreds of LayoutTest failures on Sierra.
Reverted changeset:
"[Cocoa] Variation fonts without variations specified are not
rendered as if the default variations were specified"
https://bugs.webkit.org/show_bug.cgi?id=166672
http://trac.webkit.org/changeset/210370
- 1:27 PM Changeset in webkit [210374] by
-
- 13 edits1 add2 deletes in trunk/Source
[SOUP] Network process crash in WebKit::CustomProtocolManagerImpl::didFailWithError
https://bugs.webkit.org/show_bug.cgi?id=165082
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2017-01-05
Reviewed by Alex Christensen.
Source/WebCore:
Simplified WebKitSoupRequestGenericClient.
- platform/network/soup/WebKitSoupRequestGeneric.cpp:
(webkitSoupRequestGenericSendAsync):
(webkitSoupRequestGenericSendFinish):
(webkitSoupRequestGenericGetRequest):
- platform/network/soup/WebKitSoupRequestGeneric.h:
- platform/network/soup/WebKitSoupRequestGenericClient.h:
Source/WebKit2:
CustomProtocolManager uses a Workqueue to receive the IPC messages since r149194. Then we added the Soup
implementation adopting that approach, but without making our implementation thread safe. The crash happens
because the CustomProtocolManager implementation is used by two threads at the same time, the main thread
because of a ping load (probably caused by an image load in the unload handler, I haven't been able to
reproduce the crash) and the work queue thread. The reasons to make CustomProtocolManager use a WorkQueue
are no longer valid because CustomProtocolManager is now only used in the network process and sync loads don't
use any nested run loop, they are just an IPC sync message. So this patch makes CustomProtocolManager a normal
message receiver again to ensure messages are handled in the main thread. It also adds the common implementation
to a new CustomProtocolManager.cpp file shared by Cocoa and Soup based ports.
- CMakeLists.txt: Add CustomProtocolManager.cpp.
- NetworkProcess/CustomProtocols/Cocoa/CustomProtocolManagerCocoa.mm:
(-[WKCustomProtocol initWithRequest:cachedResponse:client:]): Use new CustomProtocolManager API.
(-[WKCustomProtocol startLoading]): Ditto.
(-[WKCustomProtocol stopLoading]): Ditto.
(WebKit::CustomProtocolManager::registerProtocolClass): Register the NSURLProtocol class when not using the
network session.
(WebKit::CustomProtocolManager::didFailWithError): removeCustomProtocol now receives an ID.
(WebKit::CustomProtocolManager::didFinishLoading): Ditto.
- NetworkProcess/CustomProtocols/CustomProtocolManager.cpp: Added.
(WebKit::generateCustomProtocolID): Moved from CustomProtocolManagerCocoa.mm and CustomProtocolManagerSoup.cpp.
(WebKit::CustomProtocolManager::supplementName): Ditto.
(WebKit::CustomProtocolManager::CustomProtocolManager): Also removes the work queue initialization.
(WebKit::CustomProtocolManager::initialize): Copied and modernized the loop.
(WebKit::CustomProtocolManager::addCustomProtocol): Copied from CustomProtocolManagerCocoa.mm.
(WebKit::CustomProtocolManager::removeCustomProtocol): Ditto.
(WebKit::CustomProtocolManager::startLoading): Send the StartLoading message to the proxy.
(WebKit::CustomProtocolManager::stopLoading): Send the StopLoading message to the proxy.
- NetworkProcess/CustomProtocols/CustomProtocolManager.h:
- NetworkProcess/CustomProtocols/soup/CustomProtocolManagerImpl.cpp: Removed.
- NetworkProcess/CustomProtocols/soup/CustomProtocolManagerImpl.h: Removed.
- NetworkProcess/CustomProtocols/soup/CustomProtocolManagerSoup.cpp: Moved the implementation from
CustomProtocolManagerImpl and updated to the new CustomProtocolManager API.
(WebKit::CustomProtocolManager::WebSoupRequestAsyncData::WebSoupRequestAsyncData):
(WebKit::CustomProtocolManager::WebSoupRequestAsyncData::~WebSoupRequestAsyncData):
(WebKit::CustomProtocolManager::registerProtocolClass):
(WebKit::CustomProtocolManager::registerScheme):
(WebKit::CustomProtocolManager::supportsScheme):
(WebKit::CustomProtocolManager::didFailWithError):
(WebKit::CustomProtocolManager::didLoadData):
(WebKit::CustomProtocolManager::didReceiveResponse):
(WebKit::CustomProtocolManager::didFinishLoading):
(WebKit::CustomProtocolManager::wasRedirectedToRequest):
- NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::globalCustomProtocolManager):
(WebKit::NetworkSessionCocoa::defaultSession):
CustomProtocolManager is no longer refcounted, so just pass a pointer.
A static pointer has the same lifetime as the NetworkProcess object in the NetworkProcess,
and in the WebProcess it will remain nullptr, just like it used to.
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- WebKit2.xcodeproj/project.pbxproj:
- 1:03 PM Changeset in webkit [210373] by
-
- 4 edits in branches/safari-602-branch/Source
Merged r210372. rdar://problem/29870651
- 12:56 PM Changeset in webkit [210372] by
-
- 4 edits in trunk/Source
Turn preferLowPowerWebGLRendering setting on by default
https://bugs.webkit.org/show_bug.cgi?id=166737
<rdar://problem/29870033>
Reviewed by Dean Jackson.
Temporarily turn preferLowPowerWebGLRendering setting on by default until
we deal better with WebGL content in background tabs.
Source/WebCore:
- page/Settings.in:
Source/WebKit/mac:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
- 12:37 PM Changeset in webkit [210371] by
-
- 4 edits in trunk/LayoutTests
Update pointer-lock test expectations, enabling passing tests.
https://bugs.webkit.org/show_bug.cgi?id=166656
rdar://problem/29851126
Patch by Jeremy Jones <jeremyj@apple.com> on 2017-01-05
Reviewed by Alex Christensen.
Several pointer lock tests are passing and are now marked as passing.
pointer-lock/lock-already-locked.html Pass
pointer-lock/lock-element-not-in-dom.html Pass
http/tests/pointer-lock/iframe-sandboxed-allow-pointer-lock.html Pass
http/tests/pointer-lock/iframe-sandboxed-nested-allow-pointer-lock.html Pass
http/tests/pointer-lock/pointerlockelement-different-origin.html Pass
http/tests/pointer-lock/pointerlockelement-same-origin.html Pass
http/tests/pointer-lock/requestPointerLock-can-not-transfer-between-documents.html Pass
http/tests/pointer-lock/iframe-sandboxed.html Pass
http/tests/pointer-lock/iframe-sandboxed-nested-disallow-then-allow-pointer-lock.html Pass
- platform/mac/TestExpectations:
- http/tests/pointer-lock/iframe-sandboxed-expected.txt: Updated.
- http/tests/pointer-lock/iframe-sandboxed-nested-disallow-then-allow-pointer-lock-expected.txt: Updated
- 12:31 PM Changeset in webkit [210370] by
-
- 2 edits in trunk/Source/WebCore
[Cocoa] Variation fonts without variations specified are not rendered as if the default variations were specified
https://bugs.webkit.org/show_bug.cgi?id=166672
<rdar://problem/29779119>
<rdar://problem/29848883>
Reviewed by Simon Fraser.
CoreText has a bug (<rdar://problem/29859207>) where variation fonts without
a specified variation value are rendered as if the minimum value is specified,
rather than the default value. The solution is to apply default values where
they are omitted.
Test: fast/text/variations/advances.html
- platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::preparePlatformFont):
- 12:24 PM Changeset in webkit [210369] by
-
- 3 edits2 adds in trunk
Mark the dedicated root linebox for trailing floats in empty inlines dirty.
https://bugs.webkit.org/show_bug.cgi?id=166732
<rdar://problem/29100419>
Reviewed by Antti Koivisto.
Source/WebCore:
We normally attach floating boxes to the last root linebox. However when the floatbox is preceded by a <br>
we generate a dedicated root linebox (TrailingFloatsRootInlineBox) for the floatbox.
When this floatbox is a RenderInline descendant and this RenderInline does not generate lineboxes (it's ancestor RenderBlockFlow does)
we have to make sure that this special root linebox gets marked dirty when the associated floatbox changes.
(Unfortunately through the recursive calls on dirtyLinesFromChangedChild(), we lose the information about
the "changed child" since the inlines propagates the marking logic to the RenderBlockFlow, see FIXME.)
Test: fast/inline/trailing-floats-inline-crash2.html
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
LayoutTests:
- fast/inline/trailing-floats-inline-crash2-expected.txt: Added.
- fast/inline/trailing-floats-inline-crash2.html: Added.
- 12:15 PM Changeset in webkit [210368] by
-
- 2 edits in trunk/Source/WebCore
[Cocoa] Both modern-media-controls/images/iOS modern-media-controls/images/macOS are installed on both platforms
https://bugs.webkit.org/show_bug.cgi?id=163871
Patch by Antoine Quint <Antoine Quint> on 2017-01-05
Reviewed by Eric Carlson.
We now only copy modern media controls images, if any, for the current platform.
- WebCore.xcodeproj/project.pbxproj:
- 12:07 PM Changeset in webkit [210367] by
-
- 11 edits12 adds in trunk
Web Inspector: Test.html should support globals reportInternalError, reportUnhandledRejection, reportUncaughtException
https://bugs.webkit.org/show_bug.cgi?id=161358
<rdar://problem/28066446>
Reviewed by Joseph Pecoraro.
Source/WebInspectorUI:
We have a hodgepodge of redundant code that reports uncaught exceptions in the inspector page.
There is better handling of uncaught exceptions in the inspected page, such as including stack traces.
This patch consolidates a lot of this code and makes it possible to report
unhandled promise rejections, top-level uncaught exceptions, and exceptions
caught in a try-catch block. The formatting and sanitization code for all of
these things is shared and consistent. Finally, some tests have been added to
catch regressions in unhandled rejection/uncaught exception reporting.
- UserInterface/Test/FrontendTestHarness.js:
(FrontendTestHarness): Explicitly set initial flag state here so it's easy to find all flags.
(FrontendTestHarness.prototype.redirectConsoleToTestOutput):
Extract this code to sanitize stack frames and put it in TestHarness. It is used
by other methods that need to print stack frames.
(FrontendTestHarness.prototype.reportUnhandledRejection):
(FrontendTestHarness.prototype.reportUncaughtException):
Added. Sanitize stack trace data so it is deterministic. Log the message to the
original window.console but don't exit early. Sometimes the test page is not
fully loaded if we throw an exception quite early in the test() method, and there's
no harm in not early returning. If we do early return in this case, then a test that
uses reportUncaughtException on purpose may not complete because the call to completeTest()
would be skipped by returning early.
(FrontendTestHarness.prototype.reportUncaughtExceptionFromEvent):
Renamed from reportUncaughtException since the signature of that method suggests
it should have a single exception argument rather than lots of data arguments.
- UserInterface/Test/Test.js: Add globals.
- UserInterface/Test/TestHarness.js:
(TestHarness): Document class flags.
(TestHarness.sanitizeURL):
(TestHarness.sanitizeStackFrame):
(TestHarness.prototype.sanitizeStack):
Extract this code from other parts of the test harness. Make sanitizeStack
an instance method so that there is only one place that needs to check the
'suppressStackTraces' flag.
- UserInterface/Test/TestSuite.js:
(TestSuite.prototype.logThrownObject):
(TestSuite):
(AsyncTestSuite.prototype.runTestCases):
(AsyncTestSuite):
(SyncTestSuite.prototype.runTestCases):
(SyncTestSuite):
(TestSuite.messageFromThrownObject): Deleted.
Inline some helpers with only one use-site and consolidate redundant code
for adding an exception and message to the test results.
LayoutTests:
Improve uncaught exception reporting and add some tests to document
new and existing behavior.
- http/tests/inspector/resources/inspector-test.js:
(runTest.runTestMethodInFrontend):
(runTest): Outsource reporting of an uncaught exception while injecting
a method into the frontend. By doing this, we can make the report using
the actual exception object since it doesn't go through window.onerror.
- inspector/unit-tests/async-test-suite-expected.txt:
- inspector/unit-tests/async-test-suite.html:
- inspector/unit-tests/sync-test-suite-expected.txt:
- inspector/unit-tests/sync-test-suite.html:
Rebaseline and force suppression of stack traces, which are not deterministic
across commits due to logging specific lines and columns in TestCombined.js.
- inspector/unit-tests/globals-uncaught-exception-from-timer-callback-expected.txt: Added.
- inspector/unit-tests/globals-uncaught-exception-from-timer-callback.html: Added.
- inspector/unit-tests/globals-uncaught-exception-in-test-function-expected.txt: Added.
- inspector/unit-tests/globals-uncaught-exception-in-test-function.html: Added.
- inspector/unit-tests/globals-uncaught-exception-in-test-suite-expected.txt: Added.
- inspector/unit-tests/globals-uncaught-exception-in-test-suite.html: Added.
- inspector/unit-tests/globals-unhandled-rejection-in-test-function-expected.txt: Added.
- inspector/unit-tests/globals-unhandled-rejection-in-test-function.html: Added.
- inspector/unit-tests/globals-unhandled-rejection-in-test-suite-expected.txt: Added.
- inspector/unit-tests/globals-unhandled-rejection-in-test-suite.html: Added.
- inspector/unit-tests/globals-unhandled-rejection-in-timer-callback-expected.txt: Added.
- inspector/unit-tests/globals-unhandled-rejection-in-timer-callback.html: Added.
- 11:51 AM Changeset in webkit [210366] by
-
- 2 edits in trunk/LayoutTests
Skip fast/scrolling/page-cache-back-overflow-scroll-restore.html on iOS simulator.
<https://webkit.org/b/166736>
- platform/ios-simulator/TestExpectations:
- 11:18 AM Changeset in webkit [210365] by
-
- 5 edits in trunk
Add WebCore::URL::protocolHostAndPort
https://bugs.webkit.org/show_bug.cgi?id=166426
Reviewed by Alex Christensen.
Source/WebCore:
Added to support record/replay mechanism, which needs it in order to
implement fuzzy-matching of URLs that are similar to each other but
that nonetheless come from the same source/host.
Updated TestWebKitAPI/Tests/WebCore/URL.cpp.
- platform/URL.cpp:
(WebCore::URL::protocolHostAndPort):
- platform/URL.h:
Tools:
Add test for protocolHostAndPort.
- TestWebKitAPI/Tests/WebCore/URL.cpp:
(TestWebKitAPI::TEST_F):
- 11:10 AM Changeset in webkit [210364] by
-
- 13 edits in trunk/Source/WebKit2
Use WTF::Function instead of std::function in network cache code
https://bugs.webkit.org/show_bug.cgi?id=166721
Reviewed by Andreas Kling.
Use better move-only type. Fix some unnecessary function copies.
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::Cache::retrieve):
(WebKit::NetworkCache::Cache::clear):
- NetworkProcess/cache/NetworkCache.h:
- NetworkProcess/cache/NetworkCacheData.h:
- NetworkProcess/cache/NetworkCacheDataCocoa.mm:
(WebKit::NetworkCache::Data::apply):
- NetworkProcess/cache/NetworkCacheDataSoup.cpp:
(WebKit::NetworkCache::Data::apply):
- NetworkProcess/cache/NetworkCacheFileSystem.cpp:
(WebKit::NetworkCache::traverseDirectory):
- NetworkProcess/cache/NetworkCacheFileSystem.h:
- NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:
(WebKit::NetworkCache::SpeculativeLoadManager::canRetrieve):
(WebKit::NetworkCache::SpeculativeLoadManager::retrieve):
Split retrieve() to canRetrieve() and retrieve() functions.
This avoids the need to copy the completion handler in the caller.
- NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.h:
- NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::ReadOperation::ReadOperation):
(WebKit::NetworkCache::Storage::traverse):
(WebKit::NetworkCache::Storage::clear):
- NetworkProcess/cache/NetworkCacheStorage.h:
- 10:54 AM Changeset in webkit [210363] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix after https://trac.webkit.org/changeset/210360
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::performDragOperation):
- 10:32 AM Changeset in webkit [210362] by
-
- 2 edits in branches/safari-602-branch/Source/WebCore
Merged r210328. rdar://problem/29885151
- 10:31 AM Changeset in webkit [210361] by
-
- 5 edits in trunk
Form validation: Align email validation with the latest HTML specification
https://bugs.webkit.org/show_bug.cgi?id=166697
<rdar://problem/29870245>
Reviewed by Alex Christensen.
Source/WebCore:
Align email validation with the latest HTML specification:
It particular, the following changes were made:
- The first and last character of the domain now needs to be a letter or a digit
- Parts of the domain can only be 63 characters in length
No new tests, extended existing test.
- html/EmailInputType.cpp:
LayoutTests:
Extended / updated existing layout test to cover behavior changes.
- fast/forms/ValidityState-typeMismatch-email-expected.txt:
- fast/forms/resources/ValidityState-typeMismatch-email.js:
- 10:29 AM Changeset in webkit [210360] by
-
- 12 edits in trunk/Source
Support File Promise during drag for macOS.
https://bugs.webkit.org/show_bug.cgi?id=165204
rdar://problem/19595567
Reviewed by Tim Horton.
Source/WebCore:
Adds the support for handling File Promise type during
drag. DragData now has the knowledge of the NSFilesPromisePboardType and
checks for the data type during drag.
- page/mac/DragControllerMac.mm:
(WebCore::DragController::dragOperation):
- platform/DragData.h:
(WebCore::DragData::setFileNames):
(WebCore::DragData::fileNames):
- platform/mac/DragDataMac.mm:
(WebCore::DragData::containsFiles):
(WebCore::DragData::numberOfFiles):
(WebCore::DragData::asFilenames):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::containsPromise):
(WebCore::DragData::asURL):
Source/WebKit/mac:
Adds support for dropping a File Promise in a WebView.
The implementation uses new File Promise API available in Sierra.
- Misc/WebNSPasteboardExtras.mm:
(+[NSPasteboard _web_dragTypesForURL]):
- WebView/WebView.mm:
(-[WebView performDragOperation:]):
Source/WebKit2:
Adds support for dropping a File Promise in a WKWebView.
The implementation uses new File Promise API available in Sierra.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<DragData>::encode):
(IPC::ArgumentCoder<DragData>::decode):
- Shared/mac/PasteboardTypes.mm:
(WebKit::PasteboardTypes::forURL):
- UIProcess/Cocoa/WebViewImpl.h:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::createSandboxExtensionsIfNeeded):
(WebKit::WebViewImpl::performDragOperation):
(WebKit::maybeCreateSandboxExtensionFromPasteboard): Deleted.
(WebKit::createSandboxExtensionsForFileUpload): Deleted.
- 10:05 AM Changeset in webkit [210359] by
-
- 6 edits in trunk/Source
[Win] Compile error.
https://bugs.webkit.org/show_bug.cgi?id=166726
Source/JavaScriptCore:
Reviewed by Alex Christensen.
Add include folder.
- CMakeLists.txt:
Source/WebCore:
Reviewed by Alex Christensen.
Add include folder.
- CMakeLists.txt:
Source/WebKit:
Add include folder.
- CMakeLists.txt:
- 9:42 AM WebKitGTK/2.14.x edited by
- (diff)
- 9:34 AM Changeset in webkit [210358] by
-
- 2 edits in trunk/Tools
[Win] Archive test result is failing.
https://bugs.webkit.org/show_bug.cgi?id=166720
Reviewed by Alex Christensen.
Deleting the layout test result folder is sometimes failing
on Windows. This is not a critical error.
- BuildSlaveSupport/test-result-archive:
(archiveTestResults):
- 9:30 AM Changeset in webkit [210357] by
-
- 2 edits in trunk/Source/WebCore
[SOUP] AddressSanitizer: heap-use-after-free under WTF::String::fromUTF8()
https://bugs.webkit.org/show_bug.cgi?id=166722
Patch by Milan Crha <mcrha@redhat.com> on 2017-01-05
Reviewed by Alex Christensen.
- platform/soup/PublicSuffixSoup.cpp:
(WebCore::topPrivatelyControlledDomain):
Use a variable to hold UTF-8 version of the domain, because
the soup_tld_get_base_domain() returns a pointer into the passed-in
string, which could be freed due to the temporary object being freed.
- 9:09 AM Changeset in webkit [210356] by
-
- 10 edits in branches/safari-603-branch
Merge r210273. rdar://problem/29834093
- 9:09 AM Changeset in webkit [210355] by
-
- 30 edits4 adds in branches/safari-603-branch
Merge r210266. rdar://problem/29447824
- 9:09 AM Changeset in webkit [210354] by
-
- 6 edits2 adds in branches/safari-603-branch
Merge r210142. rdar://problem/29109053
- 9:09 AM Changeset in webkit [210353] by
-
- 5 edits3 adds in branches/safari-603-branch
Merge r210122. rdar://problem/29763012
- 9:09 AM Changeset in webkit [210352] by
-
- 3 edits2 adds in branches/safari-603-branch
Merge r210120. rdar://problem/29772233
- 9:09 AM Changeset in webkit [210351] by
-
- 2 edits in branches/safari-603-branch/Source/WebKit2
Merge r210118. rdar://problem/29732407
- 9:09 AM Changeset in webkit [210350] by
-
- 3 edits6 adds in branches/safari-603-branch
Merge r210112. rdar://problem/29742039
- 9:09 AM Changeset in webkit [210349] by
-
- 4 edits in branches/safari-603-branch/Source/WebCore
Merge r210104. rdar://problem/29139619
- 9:09 AM Changeset in webkit [210348] by
-
- 3 edits in branches/safari-603-branch/Tools
Merge r210101. rdar://problem/28475977
- 9:09 AM Changeset in webkit [210347] by
-
- 5 edits1 add in branches/safari-603-branch
Merge r210100. rdar://problem/28388000
- 9:09 AM Changeset in webkit [210346] by
-
- 2 edits in branches/safari-603-branch/Tools
Merge r210093. rdar://problem/29758423
- 9:09 AM Changeset in webkit [210345] by
-
- 2 edits in branches/safari-603-branch/Source/WebCore
Merge r210083. rdar://problem/25391382
- 9:09 AM Changeset in webkit [210344] by
-
- 2 edits in branches/safari-603-branch/Tools
Merge r210082. rdar://problem/29758428
- 9:09 AM Changeset in webkit [210343] by
-
- 2 edits in branches/safari-603-branch/Source/WebCore
Merge r210061. rdar://problem/29763143
- 9:09 AM Changeset in webkit [210342] by
-
- 7 edits3 adds in branches/safari-603-branch
Merge r210059. rdar://problem/29727145
- 9:08 AM Changeset in webkit [210341] by
-
- 2 edits in branches/safari-603-branch/Tools
Merge r210050. rdar://problem/29758419
- 9:08 AM Changeset in webkit [210340] by
-
- 2 edits in branches/safari-603-branch/Source/WebKit2
Merge r210041. rdar://problem/29593525
- 9:08 AM Changeset in webkit [210339] by
-
- 5 edits2 adds in branches/safari-603-branch
Merge r210035. rdar://problem/29704862
- 9:08 AM Changeset in webkit [210338] by
-
- 6 edits in branches/safari-603-branch
Merge r210033. rdar://problem/29755339
- 9:08 AM Changeset in webkit [210337] by
-
- 20 edits in branches/safari-603-branch/Source/WebInspectorUI
Merge r210032. rdar://problem/29744608
- 9:08 AM Changeset in webkit [210336] by
-
- 17 edits5 copies1 add in branches/safari-603-branch
Merge r210028. rdar://problem/29747874
- 9:08 AM Changeset in webkit [210335] by
-
- 2 edits in branches/safari-603-branch/Source/JavaScriptCore
Merge r209998. rdar://problem/29554366
- 9:08 AM Changeset in webkit [210334] by
-
- 2 edits in branches/safari-603-branch/Source/WebKit2
Merge r209995. rdar://problem/29626731
- 9:08 AM Changeset in webkit [210333] by
-
- 4 edits2 adds in branches/safari-603-branch
Merge r209990. rdar://problem/29705967
- 9:08 AM Changeset in webkit [210332] by
-
- 8 edits in branches/safari-603-branch
Merge r210045. rdar://problem/29560853
- 9:08 AM Changeset in webkit [210331] by
-
- 4 edits in branches/safari-603-branch/Source/WebCore
Merge r210034. rdar://problem/29560853
- 8:17 AM Changeset in webkit [210330] by
-
- 5 edits in trunk/Source/WebCore
Remove some unnecessary page cache checks in render tree code.
<https://webkit.org/b/166728>
Reviewed by Antti Koivisto.
There is no render tree in the page cache, so we don't need to be checking
for it in renderer code.
- rendering/RenderElement.cpp:
(WebCore::shouldRepaintForImageAnimation):
(WebCore::RenderElement::newImageAnimationFrameAvailable):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::imageChanged):
- rendering/RenderObject.cpp:
(WebCore::printRenderTreeForLiveDocuments):
(WebCore::printLayerTreeForLiveDocuments):
- rendering/RenderView.cpp:
(WebCore::RenderView::lazyRepaintTimerFired):
- 8:02 AM Changeset in webkit [210329] by
-
- 3 edits2 adds in trunk
REGRESSION(r210226): overflow:scroll scroll position not restored on back navigation
<https://webkit.org/b/166724>
Reviewed by Antti Koivisto.
Source/WebCore:
Before r210226, the render tree being torn down and the document being destroyed
were roughly the same thing, since they would always happen together, from the
render tree's perspective.
Changing this caused us to skip over the code that saves the scroll position
for an element's RenderLayer when going into the page cache. Navigating back to
that page would then scroll the layer to (0,0) instead of the previous position.
The fix is simply to remove the check for documentBeingDestroyed() in ~RenderLayer().
Note that two checks are being removed, there was also a weird "optimization"
to avoid nulling out EventHandler's m_resizeLayer if it points to this layer.
That pointer would eventually get nulled out in EventHandler::clear() anyway,
but it feels better to not let that pointer dangle.
Test: fast/scrolling/page-cache-back-overflow-scroll-restore.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::~RenderLayer):
LayoutTests:
Add a test that navigates back to a page with a scrolled overflow:scroll element.
The test verifies that the scroll position is restored.
- fast/scrolling/page-cache-back-overflow-scroll-restore-expected.txt: Added.
- fast/scrolling/page-cache-back-overflow-scroll-restore.html: Added.
- 7:51 AM Changeset in webkit [210328] by
-
- 2 edits in trunk/Source/WebCore
Disable smooth playhead animation for main content media in the Touch Bar
https://bugs.webkit.org/show_bug.cgi?id=166715
<rdar://problem/29870673>
Reviewed by Eric Carlson.
Passing in a non-zero playback rate to WebPlaybackControlsManager's timing property causes unintended effects
further down the stack. Please see the Radar for more details.
- platform/mac/WebPlaybackSessionInterfaceMac.mm:
(WebCore::WebPlaybackSessionInterfaceMac::updatePlaybackControlsManagerTiming):
- 7:12 AM Changeset in webkit [210327] by
-
- 2 edits in trunk/Source/WebCore
Fix iOS build due to missing #include's.
- history/CachedFrame.cpp:
- 5:47 AM Changeset in webkit [210326] by
-
- 12 edits in trunk/Source
Remove ChromeClient::needTouchEvents().
<https://webkit.org/b/166723>
Rubber-stamped by Antti Koivisto.
Source/WebCore:
Remove this hook since it's a no-op in every port.
- dom/Document.cpp:
(WebCore::Document::didBecomeCurrentDocumentInFrame):
(WebCore::Document::didAddTouchEventHandler):
(WebCore::Document::didRemoveTouchEventHandler):
- history/CachedFrame.cpp:
(WebCore::CachedFrameBase::restore):
- loader/EmptyClients.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::transitionToCommitted):
- page/ChromeClient.h:
Source/WebKit/mac:
- WebCoreSupport/WebChromeClient.h:
Source/WebKit/win:
- WebCoreSupport/WebChromeClient.h:
Source/WebKit2:
- WebProcess/WebCoreSupport/WebChromeClient.h:
- 5:14 AM Changeset in webkit [210325] by
-
- 2 edits in trunk/LayoutTests
Unreviewed test gardening.
Update test expectations on Windows for failing tests. These failures are tracked in
https://bugs.webkit.org/show_bug.cgi?id=160447.
- platform/win/TestExpectations:
- 5:12 AM WebKitGTK/2.14.x edited by
- (diff)
- 5:08 AM WebKitGTK/2.14.x edited by
- (diff)
- 4:07 AM Changeset in webkit [210324] by
-
- 2 edits in trunk/Tools
[GTK] Minibrowser: Add printing support
https://bugs.webkit.org/show_bug.cgi?id=165298
Open a print dialog when the Ctrl + P shortcut is pressed. If there is
an error during the print, it's printed on the console.
Reviewed by Michael Catanzaro.
- MiniBrowser/gtk/BrowserWindow.c:
(webKitPrintOperationFailedCallback):
(printPage):
(browser_window_init):
- 12:46 AM Changeset in webkit [210323] by
-
- 13 edits2 deletes in trunk/Source/WebCore
Remove PassRefPtr use from "bindings/scripts", "svg", "testing", and "workers"
https://bugs.webkit.org/show_bug.cgi?id=166718
Reviewed by Alex Christensen.
- bindings/scripts/test/JS/JSFloat64Array.cpp: Removed. Stale unused test
result expectation file.
- bindings/scripts/test/JS/JSFloat64Array.h: Ditto.
- svg/SVGElement.cpp:
(WebCore::SVGElement::removeEventListener): Fix comment that incorrectly
mentions PassRefPtr.
- testing/Internals.cpp:
(WebCore::Internals::computedStyleIncludingVisitedInfo): Return Ref instead
of RefPtr.
(WebCore::Internals::serializeObject): Ditto.
(WebCore::Internals::deserializeBuffer): Ditto.
(WebCore::Internals::observeGC): Streamlined code a bit.
- testing/Internals.h: Updated for above changes.
- testing/Internals.idl: Marked various function results as nullable.
- workers/DedicatedWorkerThread.cpp:
(WebCore::DedicatedWorkerThread::createWorkerGlobalScope): Take a RefPtr&&
instead of a PassRefPtr.
- workers/DedicatedWorkerThread.h: Updated for above change.
- workers/Worker.cpp:
(WebCore::Worker::Worker): Passs a reference to WorkerGlobalScopeProxy::create.
(WebCore::Worker::~Worker): Updated since m_contentProxy is a reference.
(WebCore::Worker::postMessage): Ditto.
(WebCore::Worker::terminate): Ditto.
(WebCore::Worker::hasPendingActivity): Ditto.
(WebCore::Worker::notifyNetworkStateChange): Ditto.
(WebCore::Worker::notifyFinished): Ditto.
- workers/Worker.h: Made m_contextProxy a reference rather than a pointer.
- workers/WorkerGlobalScopeProxy.h: Reduced includes. Made destructor
protected instead of public since this class destroys itself.
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerGlobalScopeProxy::create): Take and return a reference.
(WebCore::WorkerMessagingProxy::WorkerMessagingProxy): Moved most initialization
to the calass definition. Take a reference instead of a pointer.
(WebCore::WorkerMessagingProxy::startWorkerGlobalScope): Use auto.
(WebCore::WorkerMessagingProxy::workerThreadCreated): Take a reference
rather than a PassRefPtr.
- workers/WorkerMessagingProxy.h: Updated for above changes.
(WebCore::WorkerMessagingProxy::askedToTerminate): Deleted.
(WebCore::WorkerMessagingProxy::workerObject): Deleted.
- workers/WorkerThread.h: Take a RefPtr&& instead of a PassRefPtr.
- 12:08 AM Changeset in webkit [210322] by
-
- 2 edits in trunk/LayoutTests
[EFL] Fully update TestExpectations
Unreviewed EFL gardening.
EFL layout test has been broken too long time. Besides many tests have not maintained
as well. Now many tests are passingi, or some tests are being failed, crash, or timeout.
To update current test results, this patch updates all test results in TextExpectation.
After this update, I hope to track layout test failures efficiently.
- platform/efl/TestExpectations:
