Timeline

Jan 11, 2017:

11:18 PM Changeset in webkit [210626] by rniwa@webkit.org

• 16 edits
  1 move
  1 add in trunk/Websites/perf.webkit.org

Hide the UI to trigger an A/B testing when there are no triggerables
​https://bugs.webkit.org/show_bug.cgi?id=166964

Reviewed by Yusuke Suzuki.

Hide the "Start A/B Testing" button on analysis task pages instead of showing it and failing later
when the user tries to create one it with a TriggerableNotFound error.

Added the list of triggerables to the manifest JSON so that we can determine this condition without
having to fetch /api/triggerable for each analysis task as done in v2 UI.

• public/admin/reprocess-report.php:
• public/api/manifest.php:
• public/api/report.php:
• public/include/admin-header.php:
• public/include/manifest-generator.php: Moved from public/include/manifest.php.

(ManifestGenerator::generate):
(ManifestGenerator::triggerables): Added. Include the list of repositories this triggerable accepts
as well as the list of (test, platform) pairs on which this triggerable is available.
Use [testId, platformId] instead of a dictionary to reduce the file size.

• public/v3/components/customizable-test-group-form.js:

(CustomizableTestGroupForm): Removed this._disabled. This variable was used in TestGroupFrom to
disable the "Start A/B Testing" button when no range is selected but this ended up racy. Compute
the visibility of the button in render() function instead.
(CustomizableTestGroupForm.prototype.setRootSetMap):
(CustomizableTestGroupForm.prototype._submitted):
(CustomizableTestGroupForm.prototype.render): Hide the customize link and the button as needed.
The "Start A/B Testing" button must be hidden when either no range is selected or no title is typed.
"Customize" button must be hidden when no range is selected.

• public/v3/components/test-group-form.js:

(TestGroupForm): Removed _disabled since it's no longer used.
(TestGroupForm.prototype.setDisabled): Ditto.
(TestGroupForm.prototype.render): Ditto.

• public/v3/index.html: Include triggerable.js.
• public/v3/models/manifest.js:

(Manifest._didFetchManifest): Modernized. Create Triggerable objects from the manifest JSON.

• public/v3/models/triggerable.js: Added.

(Triggerable): Add this triggerable object to the static map of (test id, platform id) pair.
(Triggerable.prototype.acceptedRepositories): Added.
(Triggerable.findByTestConfiguration): Added. Finds a triggerable in the aforementioned static map.

• public/v3/pages/analysis-task-page.js:

(AnalysisTaskChartPane.prototype._updateStatus): Added. Re-render the page since time series data
points that were previously not available may have become available. The lack of this update was
causing a race condition in which the "Start A/B Testing" button for the charts is disabled even
after a group name had been specified because setRootSetMap was never called with a valid set.
(AnalysisTaskPage): Added this._triggerable.
(AnalysisTaskPage.prototype._didFetchTask): Find the triggerable now that we've fetched the task.
(AnalysisTaskPage.prototype.render): Hide the group view (the table of A/B testing results) entirely
when there are no groups to show. Also hide the forms to start A/B testing when there are no matching
triggerable, which is the main feature of this patch.

• server-tests/api-manifest.js: Added a test for including a list of triggerables in the manifest JSON.
• server-tests/resources/mock-data.js:

(MockData.resetV3Models): Reset Triggerable's static map.

• server-tests/tools-buildbot-triggerable-tests.js: Assert that Triggerable objects are constructed

with appropriate list of repositories and (test, platform) associations.

• tools/js/database.js:

(tableToPrefixMap): Added triggerable_repositories's prefix.

• tools/js/remote.js:

(RemoteAPI.prototype.getJSON): Log the entire response to stderr when JSON.parse fails to aid debugging.

• tools/js/v3-models.js: Import triggerable.js.

10:50 PM Changeset in webkit [210625] by rniwa@webkit.org

• 2 edits in trunk/Websites/perf.webkit.org

fetch-from-remote doesn’t work with some websites
​https://bugs.webkit.org/show_bug.cgi?id=166963

Reviewed by Yusuke Suzuki.

Apparently file_get_contents is not compatible with some SSL/TLS connections.
Use curl_* functions to access remote servers instead.

• public/admin/fetch-from-remote.php:

(fetch_remote):

10:16 PM Changeset in webkit [210624] by beidson@apple.com

• 2 edits in trunk/Source/WebKit2

Add IconLoadingDelegate functionality to WKView.
​https://bugs.webkit.org/show_bug.cgi?id=166951

Reviewed by Tim Horton.

• UIProcess/API/mac/WKView.mm:

(-[WKView dealloc]):
(-[WKView maybeInstallIconLoadingClient]): If the subclass implements the delegate method, install the

icon loading client. Otherwise, maintain the normal IconDatabase loading behavior.

(-[WKView initWithFrame:processPool:configuration:webView:]):

9:59 PM Changeset in webkit [210623] by commit-queue@webkit.org

• 1 edit
  3 adds in trunk/Source/WebInspectorUI

Web Inspector: Add another Protocol Version
​https://bugs.webkit.org/show_bug.cgi?id=166953
<rdar://problem/29980631>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-01-11
Reviewed by Timothy Hatcher.

• UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js: Added.
• Versions/Inspector-iOS-10.3.json: Added.

9:56 PM Changeset in webkit [210622] by commit-queue@webkit.org

• 4 edits in trunk/LayoutTests

REGRESSION(r206133): LayoutTest inspector/css/manager-preferredInspectorStyleSheetForFrame.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=162305
<rdar://problem/28389364>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-01-11
Reviewed by Timothy Hatcher.

• inspector/css/manager-preferredInspectorStyleSheetForFrame-expected.txt:
• inspector/css/manager-preferredInspectorStyleSheetForFrame.html:

Revert the change that broke this and move to more deterministic callbacks
that don't include the extra variance in producing output.

9:22 PM Changeset in webkit [210621] by eric.carlson@apple.com

• 24 edits
  1 delete in trunk/Source

[MediaStream, Mac] Render media stream audio buffers
​https://bugs.webkit.org/show_bug.cgi?id=159836
<rdar://problem/27380390>

Reviewed by Jer Noble.

No new tests, it isn't possible to test audio rendering directly. A follow-up patch will
add a mock audio source that will enable audio testing.

• platform/cf/CoreMediaSoftLink.cpp: Include new functions used.
• platform/cf/CoreMediaSoftLink.h:

• WebCore.xcodeproj/project.pbxproj: Remove references to the deleted previews.

• platform/Logging.h: Add MediaCaptureSamples.

• platform/MediaSample.h: Add outputPresentationTime and outputDuration.

• platform/cf/CoreMediaSoftLink.cpp: Add CMSampleBufferGetOutputDuration, CMSampleBufferGetOutputPresentationTimeStamp,

CMTimeConvertScale, CMTimebaseGetEffectiveRate, CMAudioSampleBufferCreateWithPacketDescriptions,
CMSampleBufferSetDataBufferFromAudioBufferList, CMSampleBufferSetDataReady,
CMAudioFormatDescriptionCreate, CMClockGetHostTimeClock, and CMClockGetTime.

• platform/cf/CoreMediaSoftLink.h:

Create and use an AVSampleBufferAudioRenderer each audio stream track, when it is available,
to render for audio samples. Store the offset between the first sample received from a track's
output presentation and the synchronizer time so we can adjust sample timestamps to be
relative to the synchronizer's timeline regardless of their source. Remove the use of source
previews because not all sources will have them.

• platform/graphics/avfoundation/MediaSampleAVFObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

Add an ObjC helper to catch renderer status changes.
(-[WebAVSampleBufferStatusChangeListener initWithParent:]):
(-[WebAVSampleBufferStatusChangeListener dealloc]):
(-[WebAVSampleBufferStatusChangeListener invalidate]):
(-[WebAVSampleBufferStatusChangeListener beginObservingLayer:]):
(-[WebAVSampleBufferStatusChangeListener stopObservingLayer:]):
(-[WebAVSampleBufferStatusChangeListener beginObservingRenderer:]):
(-[WebAVSampleBufferStatusChangeListener stopObservingRenderer:]):
(-[WebAVSampleBufferStatusChangeListener observeValueForKeyPath:ofObject:change:context:]):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::MediaPlayerPrivateMediaStreamAVFObjC):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::~MediaPlayerPrivateMediaStreamAVFObjC):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::removeOldSamplesFromPendingQueue):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::addSampleToPendingQueue):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateSampleTimes):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::enqueueAudioSample):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::enqueueVideoSample):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::requestNotificationWhenReadyForVideoData):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::requestNotificationWhenReadyForAudioData):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::createAudioRenderer):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::destroyAudioRenderer):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::destroyAudioRenderers):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::audioSourceProvider):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::rendererStatusDidChange):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::layerStatusDidChange):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::flushRenderers):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::ensureLayer):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::destroyLayer):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::platformLayer):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::currentDisplayMode):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::play):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::enqueueAudioSampleBufferFromTrack): Deleted.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::requestNotificationWhenReadyForMediaData): Deleted.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::enqueueVideoSampleBuffer): Deleted.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::prepareVideoSampleBufferFromTrack): Deleted.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::internalSetVolume): Deleted.

• platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:

(WebCore::MediaSampleAVFObjC::outputPresentationTime): New.
(WebCore::MediaSampleAVFObjC::outputDuration): New.
(WebCore::MediaSampleAVFObjC::dump): Log outputPresentationTime.

• platform/mediastream/AudioTrackPrivateMediaStream.h: Add timelineOffset.

• platform/mediastream/MediaStreamTrackPrivate.cpp:

(WebCore::MediaStreamTrackPrivate::setEnabled): No more m_preview.
(WebCore::MediaStreamTrackPrivate::endTrack): Ditto.
(WebCore::MediaStreamTrackPrivate::preview): Deleted.

• platform/mediastream/MediaStreamTrackPrivate.h:

• platform/mediastream/RealtimeMediaSource.h:

(WebCore::RealtimeMediaSource::preview): Deleted.

• platform/mediastream/RealtimeMediaSourcePreview.h: Removed.

• platform/mediastream/VideoTrackPrivateMediaStream.h: Add timelineOffset.

• platform/mediastream/mac/AVAudioCaptureSource.h:
• platform/mediastream/mac/AVAudioCaptureSource.mm:

(WebCore::AVAudioCaptureSource::updateSettings):
(WebCore::AVAudioCaptureSource::captureOutputDidOutputSampleBufferFromConnection): Pass the
sample buffer up the chain.
(WebCore::AVAudioSourcePreview::create): Deleted.
(WebCore::AVAudioSourcePreview::AVAudioSourcePreview): Deleted.
(WebCore::AVAudioSourcePreview::invalidate): Deleted.
(WebCore::AVAudioSourcePreview::play): Deleted.
(WebCore::AVAudioSourcePreview::pause): Deleted.
(WebCore::AVAudioSourcePreview::setEnabled): Deleted.
(WebCore::AVAudioSourcePreview::setVolume): Deleted.
(WebCore::AVAudioSourcePreview::updateState): Deleted.
(WebCore::AVAudioCaptureSource::createPreview): Deleted.

• platform/mediastream/mac/AVMediaCaptureSource.h:

(WebCore::AVMediaSourcePreview): Deleted.
(WebCore::AVMediaCaptureSource::createWeakPtr): Deleted.

• platform/mediastream/mac/AVMediaCaptureSource.mm:

(WebCore::AVMediaCaptureSource::AVMediaCaptureSource): No more preview.
(WebCore::AVMediaCaptureSource::reset):
(WebCore::AVMediaCaptureSource::preview): Deleted.
(WebCore::AVMediaCaptureSource::removePreview): Deleted.
(WebCore::AVMediaSourcePreview::AVMediaSourcePreview): Deleted.
(WebCore::AVMediaSourcePreview::~AVMediaSourcePreview): Deleted.
(WebCore::AVMediaSourcePreview::invalidate): Deleted.

• platform/mediastream/mac/AVVideoCaptureSource.h:
• platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::processNewFrame): Don't set the "display immediately" attachment.
(WebCore::AVVideoSourcePreview::create): Deleted.
(WebCore::AVVideoSourcePreview::AVVideoSourcePreview): Deleted.
(WebCore::AVVideoSourcePreview::backgroundLayerBoundsChanged): Deleted.
(WebCore::AVVideoSourcePreview::invalidate): Deleted.
(WebCore::AVVideoSourcePreview::play): Deleted.
(WebCore::AVVideoSourcePreview::pause): Deleted.
(WebCore::AVVideoSourcePreview::setPaused): Deleted.
(WebCore::AVVideoSourcePreview::setEnabled): Deleted.
(WebCore::AVVideoCaptureSource::createPreview): Deleted.
(-[WebCoreAVVideoCaptureSourceObserver setParent:]): Deleted.
(-[WebCoreAVVideoCaptureSourceObserver observeValueForKeyPath:ofObject:change:context:]): Deleted.

• platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:

(WebCore::MockRealtimeVideoSourceMac::CMSampleBufferFromPixelBuffer): Use a more typical video
time scale. Set the sample decode time.
(WebCore::MockRealtimeVideoSourceMac::pixelBufferFromCGImage): Use a static for colorspace
instead of fetching it for every frame.

• platform/mock/mediasource/MockSourceBufferPrivate.cpp: Add outputPresentationTime and outputDuration.

9:15 PM Changeset in webkit [210620] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

REGRESSION: [mac-wk2] LayoutTest inspector/debugger/breakpoint-columns.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=161774
<rdar://problem/28217256>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-01-11
Reviewed by Mark Lam.

• platform/mac-wk2/TestExpectations:

Remove flaky expectations for a test that hasn't failed in a month.

9:03 PM Changeset in webkit [210619] by Brent Fulgham

• 2 edits in trunk/Source/WebKit2

[WK2][Cocoa] Avoid null dereference in FullScreen code.
​https://bugs.webkit.org/show_bug.cgi?id=166957
<rdar://problem/27745004>

Reviewed by Eric Carlson.

• WebProcess/cocoa/WebVideoFullscreenManager.mm:

(WebKit::WebVideoFullscreenManager::didSetupFullscreen): Use protected reference to 'this', and check for valid
page before attempting to use it.

8:11 PM Changeset in webkit [210618] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: spring function editor has unusual layout, should have left-aligned labels and slider tracks
​https://bugs.webkit.org/show_bug.cgi?id=166933

Patch by Devin Rousso <Devin Rousso> on 2017-01-11
Reviewed by Brian Burg.

• UserInterface/Views/Main.css:

(input[type=range]::-webkit-slider-thumb):
(input[type=range]::-webkit-slider-runnable-track):
(input[type=range]::-webkit-slider-runnable-track::before): Deleted.
Fix slider styles.

• UserInterface/Views/SpringEditor.css:

(.spring-editor):
(.spring-editor > .spring-preview):
(.spring-editor > .spring-timing):
(.spring-editor > .number-input-container > .number-input-row > .number-input-row-title):
(.spring-editor > .number-input-container > .number-input-row > input):
(.spring-editor > .number-input-container > .number-input-row > input::-webkit-inner-spin-button):
(.spring-editor > .number-input-container > .number-input-row > input[type="range"]):
Decrease spacing and left-align text.

• UserInterface/Views/SpringEditor.js:

(WebInspector.SpringEditor.prototype._handleNumberInputKeydown):
(WebInspector.SpringEditor.prototype._changeSpringForInput):
Only update editor values when the new value of any input has changed. This allows users to
enter decimal values ("." was being stripped by parseFloat).

8:03 PM Changeset in webkit [210617] by Megan Gardner

• 2 edits in trunk/Tools

Add committer status for Megan
​https://bugs.webkit.org/show_bug.cgi?id=166954

Reviewed by Tim Horton.

Add committer status for Megan Gardner

• Scripts/webkitpy/common/config/contributors.json:

6:44 PM Changeset in webkit [210616] by commit-queue@webkit.org

• 7 edits in trunk

Remove request.formData property until it gets implemented
​https://bugs.webkit.org/show_bug.cgi?id=166920
<rdar://problem/29971105>

Patch by Youenn Fablet <​youenn@apple.com> on 2017-01-11
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

• web-platform-tests/fetch/api/request/request-consume-empty-expected.txt:
• web-platform-tests/fetch/api/request/request-consume-expected.txt:
• web-platform-tests/fetch/api/request/request-idl-expected.txt:
• web-platform-tests/fetch/api/request/request-structure-expected.txt:

Source/WebCore:

Covered by rebased tests.

• Modules/fetch/FetchBody.idl:

6:08 PM Changeset in webkit [210615] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: color, gradient, cubic-bezier, spring editors should be dismissable using ESC
​https://bugs.webkit.org/show_bug.cgi?id=166934

Patch by Devin Rousso <Devin Rousso> on 2017-01-11
Reviewed by Brian Burg.

• UserInterface/Views/Popover.js:

(WebInspector.Popover):
(WebInspector.Popover.prototype.dismiss):
(WebInspector.Popover.prototype.handleEvent):
(WebInspector.Popover.prototype._addListenersIfNeeded):
Adds a keydown listener while visible for the Escape key that dismisses the popover.

• UserInterface/Views/QuickConsole.js:

(WebInspector.QuickConsole.prototype.set keyboardShortcutDisabled):
Expose the ability to disable the global keyboard shortcut. This allows the Popover to have
its own Escape keyboard shortcut to take precedence.

5:57 PM Changeset in webkit [210614] by matthew_hanson@apple.com

• 1 copy in tags/Safari-604.1.3

New tag.

5:55 PM Changeset in webkit [210613] by matthew_hanson@apple.com

• 5 edits in trunk/Source

Versioning.

5:52 PM Changeset in webkit [210612] by Ryan Haddad

• 2 edits in trunk/Source/WebCore

Reverting r210598, r210597, and r210591 to fix the iOS simulator build.
​https://bugs.webkit.org/show_bug.cgi?id=166672

Unreviewed build fix.

• platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::preparePlatformFont):
(WebCore::fontIsSystemFont): Deleted.

5:24 PM Changeset in webkit [210611] by commit-queue@webkit.org

• 5 edits in trunk/LayoutTests

REGRESSION: LayoutTest inspector/debugger/csp-exceptions.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=165292
<rdar://problem/29471892>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-01-11
Reviewed by Geoffrey Garen.

• inspector/debugger/csp-exceptions-expected.txt:
• inspector/debugger/csp-exceptions.html:
• inspector/debugger/resources/csp-exception-iframe.html:

Improve the test to handle all console messages more carefully,
including outputing the console messages to test them as well.

• platform/mac-wk2/TestExpectations:

Unskip the test, it should no longer be flakey.

5:18 PM Changeset in webkit [210610] by Brent Fulgham

• 3 edits in trunk/LayoutTests

Rebaseline two tests after r210599.

• fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt:
• storage/domstorage/sessionstorage/blocked-file-access-expected.txt:

4:55 PM Changeset in webkit [210609] by akling@apple.com

• 7 edits in trunk/Source

Crash when WebCore's GC heap grows way too large.
<​https://webkit.org/b/166875>
<rdar://problem/27896585>

Reviewed by Mark Lam.

Source/JavaScriptCore:

Add a simple API to JSC::Heap that allows setting a hard limit on the amount
of live bytes. If this is exceeded, we crash with a recognizable signature.
By default there is no limit.

• heap/Heap.cpp:

(JSC::Heap::didExceedMaxLiveSize):
(JSC::Heap::updateAllocationLimits):

• heap/Heap.h:

(JSC::Heap::setMaxLiveSize):

Source/WebCore:

Cap the common WebCore VM at 4 GB of live JavaScript heap objects.

• bindings/js/CommonVM.cpp:

(WebCore::commonVMSlow):

Source/WTF:

Publish the WTF::GB constant.

• wtf/StdLibExtras.h:

4:44 PM Changeset in webkit [210608] by Brent Fulgham

• 2 edits in trunk/Tools

Unreviewed test fix after r210599.

• TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:

(TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.

4:38 PM Changeset in webkit [210607] by bshafiei@apple.com

• 5 edits in tags/Safari-602.4.8.0.1/Source

Versioning.

4:35 PM Changeset in webkit [210606] by bshafiei@apple.com

• 1 copy in tags/Safari-602.4.8.0.1

New tag.

4:11 PM Changeset in webkit [210605] by n_wang@apple.com

• 3 edits
  2 adds in trunk

AX: role=treeitem accessible name not spoken to VoiceOver macOS when using string contained inside element
​https://bugs.webkit.org/show_bug.cgi?id=164950
<rdar://problem/29337573>

Reviewed by Chris Fleizach.

Source/WebCore:

From the spec: ​https://www.w3.org/TR/wai-aria-practices/#TreeView
The element with role treeitem missing a label is labeled by its child elements.

Test: accessibility/mac/aria-tree-item-name.html

• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::alternativeText):

LayoutTests:

• accessibility/mac/aria-tree-item-name-expected.txt: Added.
• accessibility/mac/aria-tree-item-name.html: Added.

4:05 PM Changeset in webkit [210604] by Brent Fulgham

• 2 edits in trunk/Source/WebCore

[GTK] Unreviewed build fix after r210600.

• platform/glib/FileSystemGlib.cpp:

(WebCore::getFileDeviceId): Attempting to use proper API here.

3:55 PM Changeset in webkit [210603] by andersca@apple.com

• 4 edits in trunk/Source

navigator.plugins.refresh and WKContextRefreshPlugIns doesn't pick up changes to already-present plug-ins
​https://bugs.webkit.org/show_bug.cgi?id=166942
rdar://problem/29839194

Reviewed by Sam Weinig.

Source/WebKit2:

Use _CFBundleCreateUnique so the resulting bundle won't be cached.

• Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

(WebKit::NetscapePluginModule::getPluginInfo):

Source/WTF:

• wtf/spi/cf/CFBundleSPI.h:

Add SPI declaration.

3:07 PM Changeset in webkit [210602] by Brent Fulgham

• 2 edits in trunk/Source/WebCore

[GTK] Unreviewed build fix after r210599.

• platform/glib/FileSystemGlib.cpp:

(WebCore::getFileDeviceId): Revise for new signature.

3:06 PM Changeset in webkit [210601] by mmaxfield@apple.com

• 3 edits
  2 adds in trunk

ASSERTION FAILED: run->m_stop > 0 in *WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment
​https://bugs.webkit.org/show_bug.cgi?id=166030

Reviewed by Ryosuke Niwa.

Source/WebCore:

Ordinarily, we don't process empty BiDi runs (because we filter them out).
However, when using isolates, we invoke extra machinery to create a
placeholder BiDi run, and replace it with the runs for the isolate. The
isolate's runs, though, can be empty, and rather than just deleting the
placeholder run, we will keep it around so that the m_logicallyLastRun is
still valid. This means that it is possible when all is said and done to
have empty runs, and computeInlineDirectionPositionsForSegment() needs to
not ASSERT() in this case.

Test: fast/text/bidi-isolate-empty-run.html

• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForSegment):

LayoutTests:

• fast/text/bidi-isolate-empty-run-expected.txt: Added.
• fast/text/bidi-isolate-empty-run.html: Added.

2:44 PM Changeset in webkit [210600] by Brent Fulgham

• 1 edit
  2 adds in trunk/Tools

Unreviewed build fix after r210599.

Add missing files.

• TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
• TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.

1:55 PM Changeset in webkit [210599] by Brent Fulgham

• 11 edits in trunk

File scheme should not allow access of a resource on a different volume.
​https://bugs.webkit.org/show_bug.cgi?id=158552
<rdar://problem/15307582>

Reviewed by Alex Christensen.

Source/WebCore:

Revise SecurityOrigin to prevent files from one storage device (volume) from accessing content
on a different storage device (volume) unless universal access is enabled.

Pass the current file device as part of the NSURLRequest so that CFNetwork can reject loads
where the device changes in the midst of a load.

Also properly reflect that SecurityOrigin is never null by passing as a reference,
rather than as a pointer.

Tests: Tools/TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm

• page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::canAccess): Pass argument as reference.
(WebCore::SecurityOrigin::canDisplay): Add check that files share the same volume.
(WebCore::SecurityOrigin::isSameSchemeHostPort): Pass argument as reference.

• page/SecurityOrigin.h:
• platform/FileSystem.cpp:

(WebCore::filesHaveSameVolume): Added.

• platform/FileSystem.h:
• platform/network/cocoa/ResourceRequestCocoa.mm:

(WebCore::ResourceRequest::doUpdatePlatformRequest): If loading a file URL, tell CFNetwork
the storage device at the time of the start of the load so we can trigger a failure if this
changes during the load operation.

• platform/posix/FileSystemPOSIX.cpp:

(WebCore::getFileDeviceId): Added.

• platform/win/FileSystemWin.cpp:

(WebCore::getFileDeviceId): Added.

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
• TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
• TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.

1:46 PM Changeset in webkit [210598] by mmaxfield@apple.com

• 2 edits in trunk/Source/WebCore

[Cocoa] Testing fix after r210597
​https://bugs.webkit.org/show_bug.cgi?id=166672

Unreviewed.

• platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::preparePlatformFont):

1:40 PM Changeset in webkit [210597] by mmaxfield@apple.com

• 2 edits in trunk/Source/WebCore

[Cocoa] Testing fix after r210591
​https://bugs.webkit.org/show_bug.cgi?id=166672

Unreviewed.

Fixes fast/text/trak-optimizeLegibility.html and
fast/text/system-font-features.html

• platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::fontIsSystemFont):
(WebCore::preparePlatformFont):

1:28 PM Changeset in webkit [210596] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

REGRESSION: Crash in com.apple.WebKit: IPC::Connection::sendMessage(std::1::unique_ptr<IPC::MachMessage, std::__1::default_delete<IPC::MachMessage> >) + 27
​https://bugs.webkit.org/show_bug.cgi?id=165854
rdar://problem/29757269

Reviewed by Tim Horton.

• Platform/IPC/mac/ConnectionMac.mm:

(IPC::Connection::sendMessage):
Add assertion.

(IPC::Connection::initializeSendSource):
Turns out the event handler can be called spuriously, so guard against that.

1:07 PM Changeset in webkit [210595] by mitz@apple.com

• 8 copies
  1 add in releases/Apple/Safari Technology Preview 21

Added a tag for Safari Technology Preview release 21.

12:30 PM Changeset in webkit [210594] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: fix UIString for Print Styles button
​https://bugs.webkit.org/show_bug.cgi?id=166892

Patch by Devin Rousso <Devin Rousso> on 2017-01-11
Reviewed by Brian Burg.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Views/DOMTreeContentView.js:

(WebInspector.DOMTreeContentView):
Changed UIString to better match documentation.

11:18 AM Changeset in webkit [210593] by Chris Dumez

• 7 edits
  2 adds in trunk

Iterating over URLSearchParams does not work
​https://bugs.webkit.org/show_bug.cgi?id=166921
<rdar://problem/29970907>

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline W3C test now that more checks are passing.

• web-platform-tests/url/urlsearchparams-foreach-expected.txt:

Source/WebCore:

Make URLSearchParams iterable, as per:

• ​https://url.spec.whatwg.org/#urlsearchparams

Test: fast/dom/DOMURL/searchparams-iterable.html

• html/URLSearchParams.cpp:

(WebCore::URLSearchParams::Iterator::next):
(WebCore::URLSearchParams::Iterator::Iterator):

• html/URLSearchParams.h:

(WebCore::URLSearchParams::createIterator):

• html/URLSearchParams.idl:

LayoutTests:

Add layout test coverage.

• fast/dom/DOMURL/searchparams-iterable-expected.txt: Added.
• fast/dom/DOMURL/searchparams-iterable.html: Added.

10:48 AM Changeset in webkit [210592] by Ryan Haddad

• 2 edits in trunk/JSTests

Mark es6/typed_arrays_correct_prototype_chains.js as failing after r210570.
​https://bugs.webkit.org/show_bug.cgi?id=166931i

Unreviewed test gardening.

• es6.yaml:

10:26 AM Changeset in webkit [210591] by mmaxfield@apple.com

• 2 edits in trunk/Source/WebCore

[Cocoa] Variation fonts without variations specified are not rendered as if the default variations were specified
​https://bugs.webkit.org/show_bug.cgi?id=166672
<rdar://problem/29779119>
<rdar://problem/29848883>

Reviewed by Simon Fraser.

CoreText has a bug (<rdar://problem/29859207>) where variation fonts without
a specified variation value are rendered as if the minimum value is specified,
rather than the default value. The solution is to apply default values where
they are omitted.

Test: fast/text/variations/advances.html

• platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::preparePlatformFont):

10:08 AM Changeset in webkit [210590] by Ryan Haddad

• 2 edits in trunk/Source/WebCore

Attempt to fix the Windows build after r210588.

Unreviewed build fix.

• bindings/js/JSBindingsAllInOne.cpp:

9:42 AM Changeset in webkit [210589] by weinig@apple.com

• 2 edits in trunk/Source/WebCore

Address some feedback from r210567.

• bindings/scripts/CodeGeneratorJS.pm:

(NativeToJSValueDOMConvertNeedsState):
(NativeToJSValueDOMConvertNeedsGlobalObject):
Fix typo. robost -> robust.

9:38 AM Changeset in webkit [210588] by weinig@apple.com

• 3 edits
  1 move in trunk/Source/WebCore

Rename JSCustomSQLStatementErrorCallback.cpp to JSSQLStatementErrorCallbackCustom.cpp
​https://bugs.webkit.org/show_bug.cgi?id=166913

Reviewed by Alex Christensen.

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSCustomSQLStatementErrorCallback.cpp: Removed.
• bindings/js/JSSQLStatementErrorCallbackCustom.cpp: Copied from Source/WebCore/bindings/js/JSCustomSQLStatementErrorCallback.cpp.

Rename to match conventions.

8:00 AM Changeset in webkit [210587] by Ryan Haddad

• 10 edits
  2 deletes in trunk

Unreviewed, rolling out r210571.

This change broke the 32-bit macOS build and caused LayoutTest
failures.

Reverted changeset:

"File scheme should not allow access of a resource on a
different volume."
​https://bugs.webkit.org/show_bug.cgi?id=158552
​http://trac.webkit.org/changeset/210571

7:45 AM Changeset in webkit [210586] by Chris Dumez

• 5 edits
  2 adds in trunk

[iOS][WK2] KeyboardEvent.key always returns an empty string
​https://bugs.webkit.org/show_bug.cgi?id=166918
<rdar://problem/29861147>

Reviewed by Wenson Hsieh.

Source/WebKit2:

Make sure that KeyboardEvent.key gets properly initialized on iOS / WK2.

• Shared/WebEvent.h:
• Shared/WebKeyboardEvent.cpp:

(WebKit::WebKeyboardEvent::WebKeyboardEvent):

• Shared/ios/WebIOSEventFactory.mm:

(WebIOSEventFactory::createWebKeyboardEvent):

LayoutTests:

Add layout test coverage.

• fast/events/ios/keyboard-event-key-attribute-expected.txt: Added.
• fast/events/ios/keyboard-event-key-attribute.html: Added.

4:12 AM Changeset in webkit [210585] by Yusuke Suzuki

• 32 edits
  4 copies
  1 add in trunk/Source

Decouple module loading initiator from ScriptElement
​https://bugs.webkit.org/show_bug.cgi?id=166888

Reviewed by Saam Barati and Ryosuke Niwa.

Source/JavaScriptCore:

Add ScriptFetcher and JSScriptFetcher.

• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• builtins/ModuleLoaderPrototype.js:

(requestFetch):
(requestInstantiate):
(requestSatisfy):
(requestInstantiateAll):
(requestLink):
(moduleEvaluation):
(loadAndEvaluateModule):
(importModule):

• llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

• llint/LowLevelInterpreter.asm:
• runtime/Completion.cpp:

(JSC::loadAndEvaluateModule):
(JSC::loadModule):
(JSC::linkAndEvaluateModule):

• runtime/Completion.h:
• runtime/JSModuleLoader.cpp:

(JSC::JSModuleLoader::loadAndEvaluateModule):
(JSC::JSModuleLoader::loadModule):
(JSC::JSModuleLoader::linkAndEvaluateModule):
(JSC::JSModuleLoader::resolve):
(JSC::JSModuleLoader::fetch):
(JSC::JSModuleLoader::instantiate):
(JSC::JSModuleLoader::evaluate):

• runtime/JSModuleLoader.h:
• runtime/JSScriptFetcher.cpp: Copied from Source/WebCore/dom/LoadableScript.cpp.

(JSC::JSScriptFetcher::destroy):

• runtime/JSScriptFetcher.h: Added.

(JSC::JSScriptFetcher::createStructure):
(JSC::JSScriptFetcher::create):
(JSC::JSScriptFetcher::fetcher):
(JSC::JSScriptFetcher::JSScriptFetcher):

• runtime/JSType.h:
• runtime/ScriptFetcher.h: Copied from Source/WebCore/dom/LoadableScript.cpp.

(JSC::ScriptFetcher::~ScriptFetcher):

• runtime/VM.cpp:

(JSC::VM::VM):

• runtime/VM.h:

Source/WebCore:

Previously, we use ScriptElement (JSElement for ScriptElement) as the module loading initiator.
This element is used to transfer the metadata like charset throughout the module pipeline.
As a result, our module loader in the browser side is tightly coupled with ScriptElement.
It is not good since it prevent us from using the module loader in the non-DOM environment like
Web Workers.

So we decouple the necessary informations from ScriptElement. We move these information to
LoadableScript. And we use JSScriptFetcher to transfer LoadableScript through the JS implemented
module loader pipeline. We select LoadableScript instead of LoadableModuleScript since this initiator
information will be leveraged even in classic scripts once we implement the dynamic import.

No behavior change.

• ForwardingHeaders/runtime/JSScriptFetcher.h: Copied from Source/WebCore/dom/LoadableScript.cpp.
• ForwardingHeaders/runtime/ScriptFetcher.h: Copied from Source/WebCore/dom/LoadableScript.cpp.
• bindings/js/CachedModuleScript.cpp:

(WebCore::CachedModuleScript::create):
(WebCore::CachedModuleScript::load):
(WebCore::CachedModuleScript::CachedModuleScript): Deleted.

• bindings/js/CachedModuleScript.h:

Now we can merge CachedModuleScript to LoadableScript. But we do not do this in this patch since
we focus on decoupling the initiator information from ScriptElement.

(WebCore::CachedModuleScript::nonce): Deleted.
(WebCore::CachedModuleScript::crossOriginMode): Deleted.

• bindings/js/CachedModuleScriptLoader.cpp:

(WebCore::CachedModuleScriptLoader::load):

• bindings/js/CachedModuleScriptLoader.h:
• bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::moduleLoaderResolve):
(WebCore::JSDOMWindowBase::moduleLoaderFetch):
(WebCore::JSDOMWindowBase::moduleLoaderEvaluate):

• bindings/js/JSMainThreadExecState.h:

(WebCore::JSMainThreadExecState::loadModule):
(WebCore::JSMainThreadExecState::linkAndEvaluateModule):

• bindings/js/ScriptController.cpp:

(WebCore::ScriptController::loadModuleScriptInWorld):
(WebCore::ScriptController::loadModuleScript):
(WebCore::ScriptController::linkAndEvaluateModuleScriptInWorld):
(WebCore::ScriptController::linkAndEvaluateModuleScript):

• bindings/js/ScriptController.h:
• bindings/js/ScriptModuleLoader.cpp:

(WebCore::ScriptModuleLoader::fetch):

• bindings/js/ScriptModuleLoader.h:
• dom/LoadableClassicScript.cpp:

(WebCore::LoadableClassicScript::create):
(WebCore::LoadableClassicScript::~LoadableClassicScript):
(WebCore::LoadableClassicScript::isLoaded):
(WebCore::LoadableClassicScript::error):
(WebCore::LoadableClassicScript::wasCanceled):
(WebCore::LoadableClassicScript::notifyFinished):
(WebCore::LoadableClassicScript::load):

• dom/LoadableClassicScript.h:
• dom/LoadableModuleScript.cpp:

(WebCore::LoadableModuleScript::create):
(WebCore::LoadableModuleScript::LoadableModuleScript):
(WebCore::LoadableModuleScript::load):

• dom/LoadableModuleScript.h:
• dom/LoadableScript.cpp:

(WebCore::LoadableScript::requestScriptWithCache):

• dom/LoadableScript.h:

(WebCore::LoadableScript::LoadableScript):

• dom/ScriptElement.cpp:

(WebCore::ScriptElement::requestClassicScript):
(WebCore::ScriptElement::requestModuleScript):
(WebCore::ScriptElement::executeModuleScript):
(WebCore::ScriptElement::requestScriptWithCacheForModuleScript): Deleted.
(WebCore::ScriptElement::requestScriptWithCache): Deleted.

• dom/ScriptElement.h:

3:27 AM Changeset in webkit [210584] by Carlos Garcia Campos

• 7 edits in trunk/Source/WebCore

[GStreamer] Use smart pointers and modernize code in WebKitWebAudioSourceGStreamer
​https://bugs.webkit.org/show_bug.cgi?id=166886

Reviewed by Xabier Rodriguez-Calvar.

This patch doesn't change the behavior, so it's covered by existing Web Audio tests. It replaces pointers with
smart pointers, uses WTF::Vector instead of GSList and simplifies the code to map/unmap GstBuffers.

• platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webKitWebAudioSrcConstructed):
(webKitWebAudioSrcFinalize):
(webKitWebAudioSrcLoop):
(webKitWebAudioSrcChangeState):

• platform/graphics/gstreamer/GRefPtrGStreamer.cpp:

(WTF::derefGPtr<GstBufferList>):
(WTF::adoptGRef):
(WTF::refGPtr<GstBufferPool>):
(WTF::derefGPtr<GstBufferPool>):

• platform/graphics/gstreamer/GRefPtrGStreamer.h:
• platform/graphics/gstreamer/GStreamerUtilities.cpp:

(WebCore::mapGstBuffer):

• platform/graphics/gstreamer/GStreamerUtilities.h:
• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(StreamingClient::createReadBuffer):

2:08 AM WebKitGTK edited by rakuco@webkit.org

Link to WebKitGTK/Debugging (diff)

1:08 AM Changeset in webkit [210583] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r182947.
​https://bugs.webkit.org/show_bug.cgi?id=166922

Caused huge memory leak see ​https://webkit.org/b/166884
(Requested by KaL on #webkit).

Reverted changeset:

"[GStreamer] Silent WebAudio buffers support"
​https://bugs.webkit.org/show_bug.cgi?id=143869
​http://trac.webkit.org/changeset/182947

12:55 AM Changeset in webkit [210582] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r210579.

That was not the right fix

Reverted changeset:

"Unreviewed GTK buildfix after r210571."
​http://trac.webkit.org/changeset/210579

12:53 AM Changeset in webkit [210581] by Gyuyoung Kim

• 2 edits in trunk/LayoutTests

[EFL] Update TestExpectation file for Ubuntu 16.04.

Unreviewed EFL gardening.

After bumping Ubuntu version to 16.04, there are many tests are failed.
This gardening is to update all failure tests on Ubuntu 16.04.

• platform/efl/TestExpectations:

12:52 AM Changeset in webkit [210580] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

Unreviewed. Fix GTK+ build after r210571.

Add getFileDeviceId implementation to FileSystemGlib.cpp.

• platform/glib/FileSystemGlib.cpp:

(WebCore::getFileDeviceId):

12:47 AM Changeset in webkit [210579] by Csaba Osztrogonác

• 2 edits in trunk/Source/WebCore

Unreviewed GTK buildfix after r210571.

• PlatformGTK.cmake:

Jan 10, 2017:

11:53 PM Changeset in webkit [210578] by rniwa@webkit.org

• 2 edits in trunk/Websites/perf.webkit.org

Another build fix. Always use UTC when expressing commit times in UNIX-epoch timestamps.

• public/api/measurement-set.php:

8:53 PM Changeset in webkit [210577] by rniwa@webkit.org

• 2 edits in trunk/Websites/perf.webkit.org

Fix a typo in the previous commit.

• public/api/measurement-set.php:

8:51 PM Changeset in webkit [210576] by rniwa@webkit.org

• 4 edits in trunk/Websites/perf.webkit.org

Build fixes for older versions of Postgres.

Also redirect / and /# to /v3/ as intended in r200820.

• public/api/measurement-set.php:
• public/api/runs.php:
• public/index.html:

8:07 PM Changeset in webkit [210575] by clopez@igalia.com

• 2 edits in trunk/Tools

[GTK] install-dependencies script misses gdb
​https://bugs.webkit.org/show_bug.cgi?id=166917

Reviewed by Michael Catanzaro.

gdb is needed for generating the crash logs.

• gtk/install-dependencies:

7:56 PM Changeset in webkit [210574] by Michael Catanzaro

• 14 edits in trunk

[GTK] No way for applications to set notification permissions without waiting for permission request
​https://bugs.webkit.org/show_bug.cgi?id=163366

Reviewed by Carlos Garcia Campos.

Source/WebKit2:

Websites can check the Notification.permission DOM property to check if they have permission
to show notifications *without triggering a permission request*. But the WebKitGTK+ API has
no way to affirmatively indicate notifications are allowed without a permission request. The
only way is via the permission request API, which is too late. It's a problem for Epiphany.
For example, open the Riot Matrix client in a web app; you will immediately see an info bar
informing the user that Riot does not have permission to send desktop notifications, even
though Epiphany automatically grants notification permission in web app mode when requested.
This problem is not exclusive to web apps; there is simply no way for notification
permission to be set correctly prior to a permission request for it. Fix this by introducing
a webkit_web_context_initialize_notification_permissions() API, and add a signal
WebKitWebContext::initialize-notification-permissions to indicate when it should be called.

• UIProcess/API/gtk/WebKitNotificationProvider.cpp:

(notificationPermissionsCallback):
(WebKitNotificationProvider::create):
(WebKitNotificationProvider::WebKitNotificationProvider):
(WebKitNotificationProvider::notificationPermissions):
(WebKitNotificationProvider::setNotificationPermissions):

• UIProcess/API/gtk/WebKitNotificationProvider.h:
• UIProcess/API/gtk/WebKitSecurityOrigin.cpp:

(webkitSecurityOriginGetSecurityOrigin):

• UIProcess/API/gtk/WebKitSecurityOriginPrivate.h:
• UIProcess/API/gtk/WebKitWebContext.cpp:

(webkitWebContextConstructed):
(webkit_web_context_class_init):
(addOriginToMap):
(webkit_web_context_initialize_notification_permissions):
(webkitWebContextInitializeNotificationPermissions):

• UIProcess/API/gtk/WebKitWebContext.h:
• UIProcess/API/gtk/WebKitWebContextPrivate.h:
• UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:

Tools:

• TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:

(testWebViewNotification):
(setInitialNotificationPermissionsAllowedCallback):
(setInitialNotificationPermissionsDisallowedCallback):
(testWebViewNotificationInitialPermissionAllowed):
(testWebViewNotificationInitialPermissionDisallowed):
(beforeAll):

• TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
• TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:

(WebViewTest::WebViewTest):
(WebViewTest::initializeWebView):

• TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:

6:26 PM Changeset in webkit [210573] by Yusuke Suzuki

• 19 edits
  3 adds in trunk

Implement JSSourceCode to propagate SourceCode in module pipeline
​https://bugs.webkit.org/show_bug.cgi?id=166861

Reviewed by Saam Barati.

Source/JavaScriptCore:

Instead of propagating source code string, we propagate JSSourceCode
cell in the module pipeline. This allows us to attach a metadata
to the propagated source code string. In particular, it propagates
SourceOrigin through the module pipeline.

And it also fixes JSC shell to use Module source type for module source code.

• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• builtins/ModuleLoaderPrototype.js:

(fulfillFetch):
(requestFetch):

• jsc.cpp:

(GlobalObject::moduleLoaderFetch):
(runWithScripts):

• llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

• llint/LowLevelInterpreter.asm:
• runtime/Completion.cpp:

(JSC::loadAndEvaluateModule):
(JSC::loadModule):

• runtime/JSModuleLoader.cpp:

(JSC::JSModuleLoader::provide):

• runtime/JSModuleLoader.h:
• runtime/JSSourceCode.cpp: Added.

(JSC::JSSourceCode::destroy):

• runtime/JSSourceCode.h: Added.

(JSC::JSSourceCode::createStructure):
(JSC::JSSourceCode::create):
(JSC::JSSourceCode::sourceCode):
(JSC::JSSourceCode::JSSourceCode):

• runtime/JSType.h:
• runtime/ModuleLoaderPrototype.cpp:

(JSC::moduleLoaderPrototypeParseModule):

• runtime/VM.cpp:

(JSC::VM::VM):

• runtime/VM.h:

Source/WebCore:

Now SourceOrigin is correctly propagated through the module pipeline.
So the error reported by http/tests/security/contentSecurityPolicy/module-eval-blocked-expected.html
is updated.

• ForwardingHeaders/runtime/JSSourceCode.h: Added.
• bindings/js/JSDOMPromise.h:

(WebCore::DeferredPromise::resolveWithCallback):

• bindings/js/ScriptModuleLoader.cpp:

(WebCore::ScriptModuleLoader::notifyFinished):

LayoutTests:

• http/tests/security/contentSecurityPolicy/module-eval-blocked-expected.txt:

5:54 PM Changeset in webkit [210572] by timothy_horton@apple.com

• 1 edit
  3 adds in trunk/Tools

MobileMiniBrowser tests don't work by default
​https://bugs.webkit.org/show_bug.cgi?id=166910

Reviewed by Alex Christensen.

• MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.

Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.

5:51 PM Changeset in webkit [210571] by Brent Fulgham

• 10 edits
  2 adds in trunk

File scheme should not allow access of a resource on a different volume.
​https://bugs.webkit.org/show_bug.cgi?id=158552
<rdar://problem/15307582>

Reviewed by Alex Christensen.

Source/WebCore:

Revise SecurityOrigin to prevent files from one storage device (volume) from accessing content
on a different storage device (volume) unless universal access is enabled.

Pass the current file device as part of the NSURLRequest so that CFNetwork can reject loads
where the device changes in the midst of a load.

Also properly reflect that SecurityOrigin is never null by passing as a reference,
rather than as a pointer.

Tests: Tools/TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm

• page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::canAccess): Pass argument as reference.
(WebCore::SecurityOrigin::passesFileCheck): Add check that file URLs refer to files in
the same storage volume.
(WebCore::SecurityOrigin::canDisplay): Add check that files share the same volume.
(WebCore::SecurityOrigin::isSameSchemeHostPort): Pass argument as reference.

• page/SecurityOrigin.h:
• platform/FileSystem.cpp:

(WebCore::filesHaveSameVolume): Added.

• platform/FileSystem.h:
• platform/network/cocoa/ResourceRequestCocoa.mm:

(WebCore::ResourceRequest::doUpdatePlatformRequest): If loading a file URL, tell CFNetwork
the storage device at the time of the start of the load so we can trigger a failure if this
changes during the load operation.

• platform/posix/FileSystemPOSIX.cpp:

(WebCore::getFileDeviceId): Added.

• platform/win/FileSystemWin.cpp:

(WebCore::getFileDeviceId): Added.

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
• TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
• TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.

5:35 PM Changeset in webkit [210570] by commit-queue@webkit.org

• 6 edits
  1 delete in trunk

Unreviewed, rolling out r210052.
​https://bugs.webkit.org/show_bug.cgi?id=166915

"breaks web compatability" (Requested by keith_miller on
#webkit).

Reverted changeset:

"Add support for global"
​https://bugs.webkit.org/show_bug.cgi?id=165171
​http://trac.webkit.org/changeset/210052

5:28 PM Changeset in webkit [210569] by mark.lam@apple.com

• 2 edits in trunk/Tools

Reverting run-jsc-stress-tests' $buildType to use string values.
​https://bugs.webkit.org/show_bug.cgi?id=166912

Rubber stamped by Filip Pizlo.

This is so that we can test for it in the tests e.g.
@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end

• Scripts/run-jsc-stress-tests:

5:22 PM Changeset in webkit [210568] by matthew_hanson@apple.com

• 17 edits
  6 deletes in branches/safari-603-branch

Roll out r210028 via r210336. rdar://problem/29912353

5:02 PM Changeset in webkit [210567] by commit-queue@webkit.org

• 25 edits
  1 add in trunk

[WebIDL] Remove most of the custom bindings for the WebGL code
​https://bugs.webkit.org/show_bug.cgi?id=166834

Patch by Sam Weinig <​sam@webkit.org> on 2017-01-10
Reviewed by Alex Christensen.

Source/JavaScriptCore:

• runtime/ArrayPrototype.h:
• runtime/ObjectPrototype.h:

Export the ClassInfo so it can be used from WebCore.

Source/WebCore:

Removes all but one custom getter (getExtension) from the WebGL code.

• Modules/indexeddb/IDBKeyRange.idl:

Replace use of non-standard type, with new OverrideIDLType extended attribute, allowing us
to stay more consistent with the IDL files spec's provide.

• WebCore.xcodeproj/project.pbxproj:

Move JSWebGL2RenderingContextCustom to the GC/Wrapping only group.

• bindings/IDLTypes.h:

Add IDLWebGLAny, and simplify IDLIDBKey to not be templatized.

• bindings/js/JSDOMConvert.h:

(WebCore::Converter<IDLLong>::convert):
(WebCore::Converter<IDLFloat>::convert):
(WebCore::Converter<IDLUnrestrictedFloat>::convert):
(WebCore::Converter<IDLDouble>::convert):
(WebCore::Converter<IDLUnrestrictedDouble>::convert):
Add overloads of convert that convert a double to the numeric type.

(WebCore::Detail::GenericSequenceConverter::convert):
Add optimized specialization for JSArrays that does not use the iterator protocol.

(WebCore::Detail::NumericSequenceConverter::convert):
Add an even more optimized specialization for numeric types, which checks to see
if the array's butterfly has an optimized shape, and extracts the numeric values
from that.

(WebCore::Detail::SequenceConverter::convert):
(WebCore::Detail::SequenceConverter<IDLLong>::convert):
(WebCore::Detail::SequenceConverter<IDLFloat>::convert):
(WebCore::Detail::SequenceConverter<IDLUnrestrictedFloat>::convert):
(WebCore::Detail::SequenceConverter<IDLDouble>::convert):
(WebCore::Detail::SequenceConverter<IDLUnrestrictedDouble>::convert):
Select the right specialization based on type.

(WebCore::Converter<IDLSequence<T>>::convert):
(WebCore::Converter<IDLFrozenArray<T>>::convert):
Rename converter to be more accurate.

(WebCore::JSConverter<IDLWebGLAny>::convert):
Added. Calls through to converter in WebGLAny.h. We should replace this with a
call to the IDLUnion JSConverter when feasible.

• bindings/js/JSWebGL2RenderingContextCustom.cpp:

(WebCore::JSWebGL2RenderingContext::getInternalformatParameter): Deleted.
(WebCore::JSWebGL2RenderingContext::getQueryParameter): Deleted.
(WebCore::JSWebGL2RenderingContext::getSamplerParameter): Deleted.
(WebCore::JSWebGL2RenderingContext::getSyncParameter): Deleted.
(WebCore::JSWebGL2RenderingContext::getIndexedParameter): Deleted.
(WebCore::JSWebGL2RenderingContext::getActiveUniformBlockParameter): Deleted.
(WebCore::JSWebGL2RenderingContext::getActiveUniformBlockName): Deleted.
Remove unnecessary custom functions.

• bindings/js/JSWebGLRenderingContextBaseCustom.cpp:

(WebCore::objectParameter): Deleted.
(WebCore::JSWebGLRenderingContextBase::getAttachedShaders): Deleted.
(WebCore::JSWebGLRenderingContextBase::getBufferParameter): Deleted.
(WebCore::JSWebGLRenderingContextBase::getFramebufferAttachmentParameter): Deleted.
(WebCore::JSWebGLRenderingContextBase::getParameter): Deleted.
(WebCore::JSWebGLRenderingContextBase::getProgramParameter): Deleted.
(WebCore::JSWebGLRenderingContextBase::getRenderbufferParameter): Deleted.
(WebCore::JSWebGLRenderingContextBase::getShaderParameter): Deleted.
(WebCore::JSWebGLRenderingContextBase::getSupportedExtensions): Deleted.
(WebCore::JSWebGLRenderingContextBase::getTexParameter): Deleted.
(WebCore::JSWebGLRenderingContextBase::getUniform): Deleted.
(WebCore::JSWebGLRenderingContextBase::getVertexAttrib): Deleted.
(WebCore::toNumberVector): Deleted.
(WebCore::functionForUniform): Deleted.
(WebCore::dataFunctionf): Deleted.
(WebCore::dataFunctioni): Deleted.
(WebCore::dataFunctionMatrix): Deleted.
(WebCore::JSWebGLRenderingContextBase::uniform1fv): Deleted.
(WebCore::JSWebGLRenderingContextBase::uniform1iv): Deleted.
(WebCore::JSWebGLRenderingContextBase::uniform2fv): Deleted.
(WebCore::JSWebGLRenderingContextBase::uniform2iv): Deleted.
(WebCore::JSWebGLRenderingContextBase::uniform3fv): Deleted.
(WebCore::JSWebGLRenderingContextBase::uniform3iv): Deleted.
(WebCore::JSWebGLRenderingContextBase::uniform4fv): Deleted.
(WebCore::JSWebGLRenderingContextBase::uniform4iv): Deleted.
(WebCore::JSWebGLRenderingContextBase::uniformMatrix2fv): Deleted.
(WebCore::JSWebGLRenderingContextBase::uniformMatrix3fv): Deleted.
(WebCore::JSWebGLRenderingContextBase::uniformMatrix4fv): Deleted.
(WebCore::JSWebGLRenderingContextBase::vertexAttrib1fv): Deleted.
(WebCore::JSWebGLRenderingContextBase::vertexAttrib2fv): Deleted.
(WebCore::JSWebGLRenderingContextBase::vertexAttrib3fv): Deleted.
(WebCore::JSWebGLRenderingContextBase::vertexAttrib4fv): Deleted.
Remove unnecessary custom functions.

• bindings/scripts/CodeGenerator.pm:

(IsBuiltinType):
Remove specialization of IDBKey.

• bindings/scripts/CodeGeneratorJS.pm:

(GetBaseIDLType):
(GetIDLType):
(NativeToJSValueDOMConvertNeedsState):
(NativeToJSValueDOMConvertNeedsGlobalObject):
(NativeToJSValue):
Allow IDL files to override the type of signature using a new OverrideIDLType
extended attribute. Currently this only works conversion to JS, but could be
extended to support more.

• bindings/scripts/IDLAttributes.txt:

Add OverrideIDLType.

• html/canvas/WebGL2RenderingContext.idl:

Add OverrideIDLType=IDLWebGLAny annotations to remove the need for custom functions.

• html/canvas/WebGLAny.cpp:

(WebCore::convertToJSValue):
(WebCore::toJS): Deleted.

• html/canvas/WebGLAny.h:

Rename the toJS function to convertToJSValue to avoid a template specialization issue.

• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::getAttachedShaders):
Update signature to match IDL, replacing bool return value plus out parameter with an
optional return value. Modernize the code a bit.

(WebCore::WebGLRenderingContextBase::uniform2f):
(WebCore::WebGLRenderingContextBase::uniform3f):
(WebCore::WebGLRenderingContextBase::uniform4f):
(WebCore::WebGLRenderingContextBase::uniform1i):
(WebCore::WebGLRenderingContextBase::uniform3i):
(WebCore::WebGLRenderingContextBase::uniform4i):
(WebCore::WebGLRenderingContextBase::uniform1fv):
(WebCore::WebGLRenderingContextBase::uniform2fv):
(WebCore::WebGLRenderingContextBase::uniform3fv):
(WebCore::WebGLRenderingContextBase::uniform4fv):
(WebCore::WebGLRenderingContextBase::uniform1iv):
(WebCore::WebGLRenderingContextBase::uniform2iv):
(WebCore::WebGLRenderingContextBase::uniform3iv):
(WebCore::WebGLRenderingContextBase::uniform4iv):
(WebCore::WebGLRenderingContextBase::uniformMatrix2fv):
(WebCore::WebGLRenderingContextBase::uniformMatrix3fv):
(WebCore::WebGLRenderingContextBase::uniformMatrix4fv):
(WebCore::WebGLRenderingContextBase::vertexAttrib4f):
(WebCore::WebGLRenderingContextBase::vertexAttrib1fv):
(WebCore::WebGLRenderingContextBase::vertexAttrib2fv):
(WebCore::WebGLRenderingContextBase::vertexAttrib3fv):
(WebCore::WebGLRenderingContextBase::vertexAttrib4fv):
(WebCore::WebGLRenderingContextBase::validateUniformParameters):
(WebCore::WebGLRenderingContextBase::validateUniformMatrixParameters):
(WebCore::WebGLRenderingContextBase::vertexAttribfvImpl):

• html/canvas/WebGLRenderingContextBase.h:

(WebCore::WebGLRenderingContextBase::TypedList::TypedList):
(WebCore::WebGLRenderingContextBase::TypedList::data):
(WebCore::WebGLRenderingContextBase::TypedList::length):
Re-order/group to match order in the IDL file. Remove overloads taking a pointer and
length, and replace it by having the main function take a specialized TypedList. TypedList
allows the bindings to pass the correct Variant type, but then the code to only think in
terms of the data() and length() functions.

• html/canvas/WebGLRenderingContextBase.idl:

Remove [Custom] annotations and re-order/group to match the spec. Update types of uniform*fv/iv
functions to take typedef'd unions.

LayoutTests:

• fast/canvas/webgl/gl-object-get-calls-expected.txt:

Update result for better error message.

3:45 PM Changeset in webkit [210566] by rniwa@webkit.org

• 1 edit
  1 copy in trunk/Tools

Temporarily add back the file removed in r210463 to unbreak internal bots.

• Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.

3:41 PM Changeset in webkit [210565] by fpizlo@apple.com

• 13 edits
  2 deletes in trunk/Source/JavaScriptCore

Streamline the GC barrier slowpath
​https://bugs.webkit.org/show_bug.cgi?id=166878

Reviewed by Geoffrey Garen and Saam Barati.

This implements two optimizations to the barrier:

• Removes the write barrier buffer. This was just overhead.

• Teaches the slow path how to white an object that was black but unmarked, ensuring that we don't take slow path for this object again.

• JavaScriptCore.xcodeproj/project.pbxproj:
• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileStoreBarrier):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::emitStoreBarrier):

• heap/CellState.h:
• heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::markToFixpoint):
(JSC::Heap::addToRememberedSet):
(JSC::Heap::stopTheWorld):
(JSC::Heap::writeBarrierSlowPath):
(JSC::Heap::buildConstraintSet):
(JSC::Heap::flushWriteBarrierBuffer): Deleted.

• heap/Heap.h:

(JSC::Heap::writeBarrierBuffer): Deleted.

• heap/SlotVisitor.cpp:

(JSC::SlotVisitor::appendJSCellOrAuxiliary):
(JSC::SlotVisitor::setMarkedAndAppendToMarkStack):
(JSC::SlotVisitor::appendToMarkStack):
(JSC::SlotVisitor::visitChildren):

• heap/WriteBarrierBuffer.cpp: Removed.
• heap/WriteBarrierBuffer.h: Removed.
• jit/JITOperations.cpp:
• jit/JITOperations.h:
• runtime/JSCellInlines.h:

(JSC::JSCell::JSCell):

• runtime/StructureIDBlob.h:

(JSC::StructureIDBlob::StructureIDBlob):

3:34 PM Changeset in webkit [210564] by rniwa@webkit.org

• 6 edits
  4 adds in trunk

:active and :hover states may not be updated across slots
​https://bugs.webkit.org/show_bug.cgi?id=166881
<rdar://problem/29944582>

Reviewed by Antti Koivisto.

Source/WebCore:

The bug was caused by updateHoverActiveState not updating :hover and :active states on elements
when nodes are assigned to slots because they were walking up the tree using parentOrShadowHostElement
and parentNode. Fixed the bug by using parentElementInComposedTree instead since :hover and :active
states need to be updated in accordance with the render tree, which is created from the "flat tree"
or the "composed tree" in WebKit's terminology (this is old terminology in the spec).

Tests: fast/shadow-dom/clear-active-state-in-shadow.html

fast/shadow-dom/hover-over-nested-slotted-content.html

• dom/Document.cpp:

(WebCore::Document::updateHoverActiveState): Fixed the bug.

• dom/Node.cpp:

(WebCore::Node::parentElementInComposedTree): Added.

• dom/Node.h:

LayoutTests:

Added two regression tests; one for clearing :active state across a slot, and another one for clearing
a hover state on an ancestor of a slot to which a slot with the hovered element is assigned.

• fast/shadow-dom/clear-active-state-in-shadow-expected.html: Added.
• fast/shadow-dom/clear-active-state-in-shadow.html: Added.
• fast/shadow-dom/hover-over-nested-slotted-content-expected.html: Added.
• fast/shadow-dom/hover-over-nested-slotted-content.html: Added.
• platform/ios-simulator/TestExpectations:

3:17 PM Changeset in webkit [210563] by mark.lam@apple.com

• 5 edits
  1 add in trunk

Property setters should not be called for bound arguments list entries.
​https://bugs.webkit.org/show_bug.cgi?id=165631

Reviewed by Filip Pizlo.

JSTests:

• stress/property-setters-should-not-be-called-for-bound-arguments-list-entries.js: Added.

Source/JavaScriptCore:

• builtins/FunctionPrototype.js:

(bind):

• use @putByValDirect to set the bound arguments so that we don't consult the prototype chain for setters.

• runtime/IntlDateTimeFormatPrototype.cpp:

(JSC::IntlDateTimeFormatPrototypeGetterFormat):

• runtime/IntlNumberFormatPrototype.cpp:

(JSC::IntlNumberFormatPrototypeGetterFormat):

• no need to create a bound arguments array because these bound functions binds no arguments according to the spec.

3:09 PM Changeset in webkit [210562] by Keith Rollin

• 2 edits in trunk/Source/WebCore

Missing logging in IconLoader::startLoading
​https://bugs.webkit.org/show_bug.cgi?id=166904

Reviewed by Sam Weinig.

The LOG_ERROR in startLoading references 'resourceRequest', which has
been WTF::Moved as part of a preceding function call. As such, the
logging statement doesn't print out a possibly useful URL. Fix this by
making a copy of the URL before it's affected by the Move.

No new tests -- change only affects logging code.

• loader/icon/IconLoader.cpp:

(WebCore::IconLoader::startLoading):

2:31 PM Changeset in webkit [210561] by Keith Rollin

• 5 edits in trunk/Source/WebKit2

Record/replay: fix range used for fuzzy matching
​https://bugs.webkit.org/show_bug.cgi?id=166041

Reviewed by Darin Adler and Alex Christensen.

Because of two bugs, the attempt to determine the range of URLs to
check as part of the process of fuzzy matching was failing. The intent
was to find the range of URLs that started with the same
<scheme://host:port> as a given URL. However, because of a reversed
test, the upper end of the range ended up being the "end()" iterator
of the entire collection of URLs. With that fixed, there was another
bug due to one URL being given as <scheme://host:port> and the other
given as <scheme://host:port/> (note the trailing slash). Both of
these issues are now fixed.

• NetworkProcess/capture/NetworkCaptureManager.cpp:

(WebKit::NetworkCapture::Manager::initialize):
(WebKit::NetworkCapture::Manager::findBestFuzzyMatch):
(WebKit::NetworkCapture::Manager::urlIdentifyingCommonDomain):

• NetworkProcess/capture/NetworkCaptureManager.h:
• NetworkProcess/capture/NetworkCaptureResource.cpp:

(WebKit::NetworkCapture::Resource::url):
(WebKit::NetworkCapture::Resource::urlIdentifyingCommonDomain):
(WebKit::NetworkCapture::Resource::baseURL): Deleted.

• NetworkProcess/capture/NetworkCaptureResource.h:

2:26 PM Changeset in webkit [210560] by Wenson Hsieh

• 47 edits
  1 copy
  6 adds in trunk

Implement "proximity" scroll snapping
​https://bugs.webkit.org/show_bug.cgi?id=135994
<rdar://problem/18162418>

Reviewed by Dean Jackson.

Source/WebCore:

Adds support for proximity scroll snapping. To do this, we introduce scroll offset ranges, a list of scroll
offset ranges that are plumbed alongside the list of scroll snap offsets. Similar to a snap offset, a snap
offset range contains scroll offsets on which scrolling is allowed to come to a rest within a scroll snapping
container. However, unlike normal snap offsets, scrolling may only come to rest within a snap offset range if
the predicted scroll offset already lies within the range. The new algorithm for selecting a target scroll snap
position given a destination offset is now:

• If the scroll destination lies within a snap offset range, return the scroll destination
• Otherwise, compute the nearest lower/upper snap offsets and lower/upper snap offset ranges
• If scrolling ended with no velocity, return the nearest snap offset
• If scrolling ended with positive velocity, choose the upper snap offset only if there is no snap offset

range in between the scroll destination and the snap offset; else, choose the lower snap offset

• If scrolling ended with negative velocity, choose the lower snap offset only if there is no snap offset

range in between the scroll destination and the snap offset; else, choose the upper snap offset

The extra rule accounting for scroll offset ranges in between the scroll destination and a potential snap offset
handles the corner case where the user scrolls with momentum very lightly away from a snap offset, such that the
predicted scroll destination is still within proximity of the snap offset. In this case, the regular (mandatory
scroll snapping) behavior would be to snap to the next offset in the direction of momentum scrolling, but
instead, it is more intuitive to return to the original snap position.

We also move scrolling prediction logic into ScrollingMomentumCalculator and adopt the platform
_NSScrollingMomentumCalculator's destinationOrigin property when computing the predicted scroll destination.
Previously, we were simply multiplying by an empirically-derived constant to approximate the scroll destination,
but now that we are supporting proximity scroll snapping, we need more exact scroll destinaton prediction in
order to make sure that scrolling to a snap offset range feels natural.

Tests: tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-then-proximity.html

tiled-drawing/scrolling/scroll-snap/scroll-snap-proximity-mainframe.html
tiled-drawing/scrolling/scroll-snap/scroll-snap-proximity-overflow.html

• WebCore.xcodeproj/project.pbxproj:
• page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::setStateScrollingNodeSnapOffsetsAsFloat):
(WebCore::AsyncScrollingCoordinator::updateOverflowScrollingNode):
(WebCore::AsyncScrollingCoordinator::updateScrollSnapPropertiesWithFrameView):

Make boilerplate changes to plumb lists of horizontal and vertical snap offset ranges alongside the lists of
horizontal and vertical snap offsets.

• page/scrolling/AxisScrollSnapOffsets.cpp:

(WebCore::snapOffsetRangesToString):
(WebCore::indicesOfNearestSnapOffsetRanges):
(WebCore::indicesOfNearestSnapOffsets):
(WebCore::adjustAxisSnapOffsetsForScrollExtent):
(WebCore::computeAxisProximitySnapOffsetRanges):
(WebCore::updateSnapOffsetsForScrollableArea):
(WebCore::closestSnapOffset):

Adjust the snap offset selection algorithm to take snap offset ranges into account. See above for more details.
Additionally, augment snap offset update logic to emit snap offset ranges for proximity scroll snapping. To do
this, we run the following steps on the final list of processed snap offsets:

• Compute the proximity distance, which (for now) is arbitrarily 0.3 * the length or width of the scroll snap

port, depending on whether scroll snapping is taking place in the X or Y axis.

• For each pair of adjacent snap offsets, if they are more than 2 * proximity distance away from each other,

emit a snap offset range starting from (lower snap offset + proximity distance) and ending on (upper snap
offset + proximity distance).

• page/scrolling/AxisScrollSnapOffsets.h:

(WebCore::closestSnapOffset): Deleted.

• page/scrolling/ScrollSnapOffsetsInfo.h:

Introduce ScrollSnapOffsetsInfo, a struct which contains data relevant to scroll snapping. This includes
vertical and horizontal snap offsets, as well as vertical and horizontal snap offset ranges. Snap offset ranges
consist of a vector of ranges of scroll offsets.

• page/scrolling/ScrollingCoordinator.h:
• page/scrolling/ScrollingMomentumCalculator.cpp:

(WebCore::projectedInertialScrollDistance):
(WebCore::ScrollingMomentumCalculator::ScrollingMomentumCalculator):
(WebCore::ScrollingMomentumCalculator::setRetargetedScrollOffset):
(WebCore::ScrollingMomentumCalculator::predictedDestinationOffset):
(WebCore::ScrollingMomentumCalculator::create):
(WebCore::ScrollingMomentumCalculator::setPlatformMomentumScrollingPredictionEnabled):
(WebCore::BasicScrollingMomentumCalculator::BasicScrollingMomentumCalculator):
(WebCore::BasicScrollingMomentumCalculator::linearlyInterpolatedOffsetAtProgress):
(WebCore::BasicScrollingMomentumCalculator::initializeInterpolationCoefficientsIfNecessary):
(WebCore::BasicScrollingMomentumCalculator::initializeSnapProgressCurve):

• page/scrolling/ScrollingMomentumCalculator.h:

(WebCore::ScrollingMomentumCalculator::retargetedScrollOffset):
(WebCore::ScrollingMomentumCalculator::retargetedScrollOffsetDidChange):

Currently, the ScrollingMomentumCalculator is responsible for taking an initial position, initial velocity, and
target position and animating the scroll offset from the initial to target position. Now, we refactor the
ScrollingMomentumCalculator interface to no longer take a target offset upon initialization, and instead compute
the predicted scroll destination given initial position and velocity; clients of the ScrollingMomentumCalculator
then use this predicted scroll destination to compute a retargeted scroll offset and then call
setRetargetedScrollOffset on the calculator, which sets up an animation curve to the new retargeted offset. This
allows both the AppKit-based scrolling momentum calculator and platform-invariant momentum calculator to be used
interchangeably, while still allowing them to compute a destination offset from initial parameters of the
scroll.

• page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode):
(WebCore::ScrollingStateScrollingNode::setHorizontalSnapOffsets):
(WebCore::ScrollingStateScrollingNode::setVerticalSnapOffsets):
(WebCore::ScrollingStateScrollingNode::setHorizontalSnapOffsetRanges):
(WebCore::ScrollingStateScrollingNode::setVerticalSnapOffsetRanges):

• page/scrolling/ScrollingStateScrollingNode.h:

(WebCore::ScrollingStateScrollingNode::horizontalSnapOffsets):
(WebCore::ScrollingStateScrollingNode::verticalSnapOffsets):
(WebCore::ScrollingStateScrollingNode::horizontalSnapOffsetRanges):
(WebCore::ScrollingStateScrollingNode::verticalSnapOffsetRanges):

• page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::commitStateBeforeChildren):
(WebCore::ScrollingTreeScrollingNode::dumpProperties):

• page/scrolling/ScrollingTreeScrollingNode.h:

(WebCore::ScrollingTreeScrollingNode::horizontalSnapOffsets):
(WebCore::ScrollingTreeScrollingNode::verticalSnapOffsets):
(WebCore::ScrollingTreeScrollingNode::horizontalSnapOffsetRanges):
(WebCore::ScrollingTreeScrollingNode::verticalSnapOffsetRanges):

Add more boilerplate support for snap offset ranges.

• page/scrolling/mac/ScrollingMomentumCalculatorMac.h:
• page/scrolling/mac/ScrollingMomentumCalculatorMac.mm:

(WebCore::ScrollingMomentumCalculator::create):
(WebCore::ScrollingMomentumCalculator::setPlatformMomentumScrollingPredictionEnabled):
(WebCore::ScrollingMomentumCalculatorMac::ScrollingMomentumCalculatorMac):
(WebCore::ScrollingMomentumCalculatorMac::scrollOffsetAfterElapsedTime):
(WebCore::ScrollingMomentumCalculatorMac::predictedDestinationOffset):
(WebCore::ScrollingMomentumCalculatorMac::retargetedScrollOffsetDidChange):
(WebCore::ScrollingMomentumCalculatorMac::animationDuration):
(WebCore::ScrollingMomentumCalculatorMac::requiresMomentumScrolling):
(WebCore::ScrollingMomentumCalculatorMac::ensurePlatformMomentumCalculator):

Hook into AppKit momentum scroll offset prediction.

• page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:

(WebCore::convertToLayoutUnits):
(WebCore::ScrollingTreeFrameScrollingNodeMac::commitStateBeforeChildren):

• platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::ensureSnapOffsetsInfo):
(WebCore::ScrollableArea::horizontalSnapOffsets):
(WebCore::ScrollableArea::horizontalSnapOffsetRanges):
(WebCore::ScrollableArea::verticalSnapOffsetRanges):
(WebCore::ScrollableArea::verticalSnapOffsets):
(WebCore::ScrollableArea::setHorizontalSnapOffsets):
(WebCore::ScrollableArea::setVerticalSnapOffsets):
(WebCore::ScrollableArea::setHorizontalSnapOffsetRanges):
(WebCore::ScrollableArea::setVerticalSnapOffsetRanges):
(WebCore::ScrollableArea::clearHorizontalSnapOffsets):
(WebCore::ScrollableArea::clearVerticalSnapOffsets):

• platform/ScrollableArea.h:

(WebCore::ScrollableArea::horizontalSnapOffsets): Deleted.
(WebCore::ScrollableArea::verticalSnapOffsets): Deleted.

• platform/cocoa/ScrollController.h:
• platform/cocoa/ScrollController.mm:

(WebCore::ScrollController::processWheelEventForScrollSnap):

Fix an issue where initial scrolling velocity would be set to zero at the end of a drag gesture.

(WebCore::ScrollController::updateScrollSnapState):
(WebCore::ScrollController::updateScrollSnapPoints):
(WebCore::ScrollController::setNearestScrollSnapIndexForAxisAndOffset):

• platform/cocoa/ScrollSnapAnimatorState.h:

(WebCore::ScrollSnapAnimatorState::snapOffsetsForAxis):
(WebCore::ScrollSnapAnimatorState::snapOffsetRangesForAxis):
(WebCore::ScrollSnapAnimatorState::setSnapOffsetsAndPositionRangesForAxis):
(WebCore::ScrollSnapAnimatorState::setSnapOffsetsForAxis): Deleted.

• platform/cocoa/ScrollSnapAnimatorState.mm:

(WebCore::ScrollSnapAnimatorState::setupAnimationForState):
(WebCore::ScrollSnapAnimatorState::targetOffsetForStartOffset):
(WebCore::projectedInertialScrollDistance): Deleted.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):

• testing/Internals.cpp:

(WebCore::Internals::setPlatformMomentumScrollingPredictionEnabled):

Add a new hook for layout tests to force scrolling momentum calculators to use the platform-invariant momentum
scrolling prediction heuristic instead of the platform-dependent one.

(WebCore::Internals::scrollSnapOffsets):

• testing/Internals.h:
• testing/Internals.idl:

Source/WebKit2:

Adds boilerplate support for plumbing lists of snap offset ranges from the web process to the UI process
alongside the list of snap offsets.

• Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:

(ArgumentCoder<ScrollingStateScrollingNode>::encode):
(ArgumentCoder<ScrollingStateScrollingNode>::decode):

• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<ScrollOffsetRange<float>>::encode):
(IPC::ArgumentCoder<ScrollOffsetRange<float>>::decode):

• Shared/WebCoreArgumentCoders.h:
• UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:

(-[WKOverflowScrollViewDelegate scrollViewWillEndDragging:withVelocity:targetContentOffset:]):

• UIProcess/ios/RemoteScrollingCoordinatorProxyIOS.mm:

Adjust mainframe proximity scroll snapping logic to not subtract out the top content inset when there is no
active snap offset (i.e. when snapping rests in a snap offset range). Attempting to subtract out the top inset
in this case caused the scroll offset to jump after ending a drag with no momentum in a snap offset range.

(WebKit::RemoteScrollingCoordinatorProxy::adjustTargetContentOffsetForSnapping):
(WebKit::RemoteScrollingCoordinatorProxy::shouldSnapForMainFrameScrolling):
(WebKit::RemoteScrollingCoordinatorProxy::closestSnapOffsetForMainFrameScrolling):

LayoutTests:

Adds 3 new layout tests for proximity scroll snapping. Also tweaks some existing tests that test scroll snapping
after scrolling with momentum to use the custom heuristic for predicting scroll destination instead of platform
momentum scrolling. This ensures that the results of our layout tests that depend on predicting momentum scroll
destination are consistent across runs.

• tiled-drawing/scrolling/latched-div-with-scroll-snap.html:
• tiled-drawing/scrolling/scroll-snap/scroll-snap-iframe.html:
• tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-2d-overflow.html:
• tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-borders.html:
• tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-hidden-scrollbars.html:
• tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-horizontal.html:
• tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-slow-horizontal.html:
• tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-slow-vertical.html:
• tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-vertical-then-horizontal.html:
• tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-vertical.html:
• tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow-stateless.html:
• tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow.html:
• tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-padding.html:
• tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-rotated.html:

Force these tests to use platform-independent scrolling momentum prediction, by multiplying the last scroll
delta upon release by a constant factor.

• tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-then-proximity-expected.txt: Added.
• tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-then-proximity.html: Added.

Tests that after changing scroll-snap-type from mandatory to proximity, swiping downwards no longer snaps the
scroll offset to the second box, but instead leaves the scroll offset somewhere in the middle of the first box.

• tiled-drawing/scrolling/scroll-snap/scroll-snap-proximity-mainframe-expected.txt: Added.
• tiled-drawing/scrolling/scroll-snap/scroll-snap-proximity-mainframe.html: Added.

Tests that when scroll-snap-type is proximity in the mainframe, scrolling slightly downwards snaps the scroll
offset back up to the top; scrolling somewhere in the middle of the first box does not snap the scroll offset;
and scrolling near the end of the first box snaps the scroll offset to the second box.

• tiled-drawing/scrolling/scroll-snap/scroll-snap-proximity-overflow-expected.txt: Added.
• tiled-drawing/scrolling/scroll-snap/scroll-snap-proximity-overflow.html: Added.

Similar to scroll-snap-proximity-mainframe.html, except for overflow scrolling instead of the mainframe.

• tiled-drawing/scrolling/scroll-snap/scroll-snap-scrolling-jumps-to-top.html:

1:59 PM Changeset in webkit [210559] by Chris Dumez

• 5 edits
  2 adds in trunk

Make Event.initEvent()'s first parameter mandatory
​https://bugs.webkit.org/show_bug.cgi?id=166894

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline existing W3C test now that we're closing to the specification.

• web-platform-tests/dom/interfaces-expected.txt:

Source/WebCore:

Make Event.initEvent()'s first parameter mandatory. As per the
specification, all parameters should be mandatory and we are
currently dicussing the possibility of making them optional in
the specification. However, having the first parameter optional
makes little sense as it would set the event's type to the string
"undefined".

Test: fast/events/initEvent-parameters.html

• dom/Event.idl:

LayoutTests:

Add layout test coverage.

• fast/events/initEvent-parameters-expected.txt: Added.
• fast/events/initEvent-parameters.html: Added.

1:36 PM EnvironmentVariables edited by clopez@igalia.com

(diff)

1:13 PM Changeset in webkit [210558] by gskachkov@gmail.com

• 5 edits
  1 add in trunk

Calling async arrow function which is in a class's member function will cause error
​https://bugs.webkit.org/show_bug.cgi?id=166879

Reviewed by Saam Barati.

JSTests:

• stress/async-arrow-functions-lexical-binding-in-class.js: Added.

(shouldBe):
(shouldBeAsync):
(BaseClass.prototype.baseClassValue):
(BaseClass.prototype.get property):
(BaseClass):
(runSomething):
(ChildClass.prototype.classValue):
(ChildClass.prototype.get classProperty):
(ChildClass.prototype.asyncValueExp):
(ChildClass.prototype.asyncValueBody):
(ChildClass.prototype.asyncThisPropExp):
(ChildClass.prototype.asyncThisPropBody):
(ChildClass.prototype.asyncThisPropInEvalExp):
(ChildClass.prototype.asyncThisPropInEvalBody):
(ChildClass.prototype.asyncThisValueExp):
(ChildClass.prototype.asyncThisValueBody):
(ChildClass.prototype.asyncThisValueInEvalExp):
(ChildClass.prototype.asyncThisValueInEvalBody):
(ChildClass):
(ChildClass2):
(ChildClass2.prototype.classValue):
(ChildClass2.prototype.get classProperty):

• stress/async-arrow-functions-lexical-super-binding.js:

Source/JavaScriptCore:

Current patch fixed loading 'super' in async arrow function. Errored appear becuase
super was loaded always nevertherless if it used in async arrow function or not, but bytecompiler
put to arrow function context only if it used within arrow function. So to fix this issue we need to
check if super was used in arrow function.

• bytecompiler/BytecodeGenerator.h:
• bytecompiler/NodesCodegen.cpp:

(JSC::FunctionNode::emitBytecode):

12:42 PM Changeset in webkit [210557] by Ryan Haddad

• 19 edits
  3 deletes in trunk

Unreviewed, rolling out r210537.
​https://bugs.webkit.org/show_bug.cgi?id=166903

This change introduced JSC test failures (Requested by
ryanhaddad on #webkit).

Reverted changeset:

"Implement JSSourceCode to propagate SourceCode in module
pipeline"
​https://bugs.webkit.org/show_bug.cgi?id=166861
​http://trac.webkit.org/changeset/210537

Patch by Commit Queue <​commit-queue@webkit.org> on 2017-01-10

12:12 PM Changeset in webkit [210556] by Chris Dumez

• 2 edits in trunk/Source/WebCore

REGRESSION(r189555): ImageDocument title no longer includes the size of the image
​https://bugs.webkit.org/show_bug.cgi?id=166876
<rdar://problem/29939970>

Reviewed by Ryosuke Niwa.

Add a code comment to clarify fix that was made in r210536.

• html/ImageDocument.cpp:

(WebCore::ImageDocument::createDocumentStructure):

12:09 PM Changeset in webkit [210555] by jer.noble@apple.com

• 19 edits
  1 copy
  3 adds in trunk

Add support for MediaKeys.generateRequest().
​https://bugs.webkit.org/show_bug.cgi?id=166880

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

Test: media/encrypted-media/mock-MediaKeySession-generateRequest.html

Implement MediaKeySession::generateRequest(). This requires some additions
to CDM, CDMPrivate, and CDMInstance to support platform adoption and to
implement mock support for testing. Additionally, add an InitDataRegistry
object which can sanitize and extract key data from various initData types.
(At the moment, only the "keyids" initData type is implemented.)

Drive-by fixes: Change all instances of initDataType from String -> AtomicString.
Add "const" flags to all CDMPrivate methods that might be called from a const
reference.

• CMakeLists.txt:
• Modules/encryptedmedia/CDM.cpp:

(WebCore::CDM::supportsInitDataType):
(WebCore::CDM::sanitizeInitData):
(WebCore::CDM::supportsInitData):

• Modules/encryptedmedia/CDM.h:
• Modules/encryptedmedia/CDMInstance.h:
• Modules/encryptedmedia/CDMPrivate.h:
• Modules/encryptedmedia/InitDataRegistry.cpp: Added.

(WebCore::extractKeyIDsKeyids):
(WebCore::sanitizeKeyids):
(WebCore::sanitizeCenc):
(WebCore::extractKeyIDsCenc):
(WebCore::sanitizeWebM):
(WebCore::extractKeyIDsWebM):
(WebCore::InitDataRegistry::shared):
(WebCore::InitDataRegistry::InitDataRegistry):
(WebCore::InitDataRegistry::sanitizeInitData):
(WebCore::InitDataRegistry::extractKeyIDs):
(WebCore::InitDataRegistry::registerInitDataType):

• Modules/encryptedmedia/InitDataRegistry.h:
• Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::messageEventName):
(WebCore::MediaKeySession::MediaKeySession):
(WebCore::MediaKeySession::generateRequest):
(WebCore::MediaKeySession::enqueueMessage):

• Modules/encryptedmedia/MediaKeySession.h:
• Modules/encryptedmedia/MediaKeys.cpp:

(WebCore::MediaKeys::setServerCertificate):

• WebCore.xcodeproj/project.pbxproj:
• testing/MockCDMFactory.cpp:

(WebCore::MockCDMFactory::addKeysToSessionWithID):
(WebCore::MockCDMFactory::setSupportedDataTypes):
(WebCore::MockCDM::supportsInitDataType):
(WebCore::MockCDM::supportsConfiguration):
(WebCore::MockCDM::supportsConfigurationWithRestrictions):
(WebCore::MockCDM::supportsSessionTypeWithConfiguration):
(WebCore::MockCDM::supportsRobustness):
(WebCore::MockCDM::distinctiveIdentifiersRequirement):
(WebCore::MockCDM::persistentStateRequirement):
(WebCore::MockCDM::distinctiveIdentifiersAreUniquePerOriginAndClearable):
(WebCore::MockCDM::supportsInitData):
(WebCore::MockCDMInstance::setServerCertificate):
(WebCore::MockCDMInstance::requestLicense):

• testing/MockCDMFactory.h:

(WebCore::MockCDMFactory::supportedDataTypes):
(WebCore::MockCDMFactory::hasSessionWithID):
(WebCore::MockCDMFactory::removeSessionWithID):
(WebCore::MockCDMFactory::setSupportedDataTypes): Deleted.

LayoutTests:

Add shouldResolve() and shouldReject() to video-test.js and update existing
tests to use these new functions.

• media/encrypted-media/mock-MediaKeys-createSession-expected.txt: Added.
• media/encrypted-media/mock-MediaKeys-createSession.html: Added.
• media/encrypted-media/mock-MediaKeys-setServerCertificate.html:
• media/encrypted-media/mock-MediaKeySession-generateRequest.html:
• media/encrypted-media/mock-MediaKeySystemAccess.html:
• media/encrypted-media/mock-navigator-requestMediaKeySystemAccess.html:
• media/video-test.js:

(shouldResolve):
(shouldReject):

• platform/mac/TestExpectations:

11:13 AM Changeset in webkit [210554] by commit-queue@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r210540.
​https://bugs.webkit.org/show_bug.cgi?id=166896

too crude for non-WebCore clients (Requested by kling on
#webkit).

Reverted changeset:

"Crash when GC heap grows way too large."
​https://bugs.webkit.org/show_bug.cgi?id=166875
​http://trac.webkit.org/changeset/210540

10:44 AM Changeset in webkit [210553] by fpizlo@apple.com

• 5 edits in trunk/Source/JavaScriptCore

JSArray has some object scanning races
​https://bugs.webkit.org/show_bug.cgi?id=166874

Reviewed by Mark Lam.

This fixes two separate bugs, both of which I detected by running
array-splice-contiguous.js in extreme anger:

1) Some of the paths of shifting and unshifting were not grabbing the internal cell

lock. This was causing the array storage scan to crash, even though it was well
synchronized (the scan does hold the lock). The fix is just to hold the lock anywhere
that memmoves the innards of the butterfly.

2) Out of line property scanning was synchronized using double collect snapshot. Array

storage scanning was synchronized using locks. But what if array storage
transformations messed up the out of line properties? It turns out that we actually
need to hoist the array storage scanner's locking up into the double collect
snapshot.

I don't know how to write a test that does any better of a job of catching this than
array-splice-contiguous.js.

• heap/DeferGC.h: Make DisallowGC usable even if NDEBUG.
• runtime/JSArray.cpp:

(JSC::JSArray::unshiftCountSlowCase):
(JSC::JSArray::shiftCountWithArrayStorage):
(JSC::JSArray::unshiftCountWithArrayStorage):

• runtime/JSObject.cpp:

(JSC::JSObject::visitButterflyImpl):

10:41 AM Changeset in webkit [210552] by jer.noble@apple.com

• 17 edits
  2 adds in trunk

Add support for MediaKeys.createSession().
​https://bugs.webkit.org/show_bug.cgi?id=166796

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/encrypted-media/mock-MediaKeys-createSession.html

Implement MediaKeys::createSession(). This requires some additions to
CDM, CDMPrivate, and CDMInstance to support platform adoption and to
implement mock support for testing. Because the CDMInstance will now
be shared between MediaKeys and MediaKeySession, it cannot be a unique_ptr.
Make CDMInterface ref-counted and store it as a Ref.

• Modules/encryptedmedia/CDM.cpp:

(WebCore::CDM::createInstance):
(WebCore::CDM::supportsSessions):

• Modules/encryptedmedia/CDM.h:
• Modules/encryptedmedia/CDMInstance.h:
• Modules/encryptedmedia/CDMPrivate.h:
• Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::create):
(WebCore::MediaKeySession::MediaKeySession):
(WebCore::MediaKeySession::sessionId):
(WebCore::MediaKeySession::expiration):
(WebCore::MediaKeySession::keyStatuses):

• Modules/encryptedmedia/MediaKeySession.h:
• Modules/encryptedmedia/MediaKeySessionType.idl:
• Modules/encryptedmedia/MediaKeySystemAccess.cpp:

(WebCore::MediaKeySystemAccess::createMediaKeys):

• Modules/encryptedmedia/MediaKeys.cpp:

(WebCore::MediaKeys::MediaKeys):
(WebCore::MediaKeys::createSession):

• Modules/encryptedmedia/MediaKeys.h:

(WebCore::MediaKeys::create):

• Modules/encryptedmedia/MediaKeys.idl:

LayoutTests:

• media/encrypted-media/mock-MediaKeys-createSession-expected.txt: Added.
• media/encrypted-media/mock-MediaKeys-createSession.html: Added.
• platform/mac/TestExpectations:

10:05 AM Changeset in webkit [210551] by Jonathan Bedard

• 3 edits in trunk/Tools

svn-apply failed to apply a patch (deleting file with svn property)
​https://bugs.webkit.org/show_bug.cgi?id=165953

Reviewed by Daniel Bates.

• Scripts/VCSUtils.pm:

(parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.

• Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.

9:54 AM Changeset in webkit [210550] by rniwa@webkit.org

• 2 edits in trunk/Source/WebKit/mac

Remove pointerLockElement from DOMDocumentPrivate.h
​https://bugs.webkit.org/show_bug.cgi?id=166882

Reviewed by Simon Fraser.

Removed pointerLockElement declaration that was supposed to be removed in r209637.

• DOM/DOMDocumentPrivate.h:

9:25 AM Changeset in webkit [210549] by jer.noble@apple.com

• 13 edits
  2 adds in trunk

Add support for MediaKeys.setServerCertificate()
​https://bugs.webkit.org/show_bug.cgi?id=166772

Reviewed by Darin Adler.

Source/WebCore:

Test: media/encrypted-media/mock-MediaKeys-setServerCertificate.html

Implement MediaKeys::setServerCertificate(). This requires some additions
to CDM, CDMPrivate, and CDMInstance to support platform adoption and to
implement mock support for testing.

• Modules/encryptedmedia/CDM.cpp:

(WebCore::CDM::supportsServerCertificates):

• Modules/encryptedmedia/CDM.h:
• Modules/encryptedmedia/CDMInstance.h:
• Modules/encryptedmedia/CDMPrivate.h:
• Modules/encryptedmedia/MediaKeys.cpp:

(WebCore::MediaKeys::setServerCertificate):

• Modules/encryptedmedia/MediaKeys.h:
• testing/MockCDMFactory.cpp:

(WebCore::MockCDM::supportsServerCertificates):
(WebCore::MockCDMInstance::setServerCertificate):

• testing/MockCDMFactory.h:

(WebCore::MockCDMFactory::supportsServerCertificates):
(WebCore::MockCDMFactory::setSupportsServerCertificates):

• testing/MockCDMFactory.idl:

LayoutTests:

• media/encrypted-media/mock-MediaKeys-setServerCertificate-expected.txt: Added.
• media/encrypted-media/mock-MediaKeys-setServerCertificate.html: Added.

9:18 AM Changeset in webkit [210548] by Ryan Haddad

• 3 edits in trunk/Tools

Update flakiness dashboard configuration.
​https://bugs.webkit.org/show_bug.cgi?id=166869

Reviewed by Alexey Proskuryakov.

• TestResultServer/static-dashboards/builders.jsonp:
• TestResultServer/static-dashboards/flakiness_dashboard.js:

9:07 AM Changeset in webkit [210547] by clopez@igalia.com

• 2 edits in trunk/Tools

[GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
​https://bugs.webkit.org/show_bug.cgi?id=165232

Unreviewed follow-up patch after r210539 and r210523.

Instead of using that environment variable, the argument
--display-server=xorg should be passed now.

The GTK+ performance bot was the only bot using this, and is
already passing --display-server=xorg after r210539.

• Scripts/webkitpy/port/gtk.py:

(GtkPort._driver_class):

7:07 AM Changeset in webkit [210546] by commit-queue@webkit.org

• 7 edits in trunk

CachedScript cloning does not clone encodedSize
​https://bugs.webkit.org/show_bug.cgi?id=166865

Patch by Youenn Fablet <​youenn@apple.com> on 2017-01-10
Reviewed by Darin Adler.

Source/WebCore:

Covered by updated test.

• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::setBodyDataFrom): set encoded size based on being cloned resource.

• loader/cache/CachedScript.cpp:

(WebCore::CachedScript::script):
(WebCore::CachedScript::setBodyDataFrom): Making use of CachedResource::setBodyDataFrom for complete cloning.

LayoutTests:

• http/tests/security/cross-origin-cached-scripts-expected.txt:
• http/tests/security/cross-origin-cached-scripts.html:
• http/tests/security/resources/notify-loaded.js:

6:51 AM Changeset in webkit [210545] by zandobersek@gmail.com

• 3 edits in trunk/Source/WebKit2

ThreadedCoordinatedLayerTreeHost::renderNextFrame() should short-cut to layer flushing
​https://bugs.webkit.org/show_bug.cgi?id=157614

Reviewed by Carlos Garcia Campos.

CoordinatedLayerTreeHost prevents any layer flushes while a previously-commited scene
state is still being rendered on the composition thread. renderNextFrame() is called
once that is complete, and a new layer flush is scheduled.

This change improves the whole ordeal by immediately performing the layer flush only if
it was requested during the time we were waiting on the renderer (i.e. when the latest
scene state was being composited), instead of scheduling it unconditionally.
m_scheduledWhileWaitingForRenderer member variable is added to track that occurrence.

• WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::scheduleLayerFlush):
(WebKit::CoordinatedLayerTreeHost::renderNextFrame):

• WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:

6:49 AM Changeset in webkit [210544] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

Unreviewed. Remove the unused gReadyStateTimerInterval global from
the MediaPlayerPrivateGStreamerMSE implementation file as it's only
springing up a compiler warning.

• platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

4:32 AM Changeset in webkit [210543] by zandobersek@gmail.com

• 3 edits in trunk/Source/WebCore

[CoordinatedGraphics] TextureMapperPlatformLayerProxy is constantly getting activated
​https://bugs.webkit.org/show_bug.cgi?id=166856

Reviewed by Michael Catanzaro.

When CoordinatedGraphicsLayer::setContentsNeedsDisplay() is called, currently with
the threaded CoordinatedGraphics mode the platform layer is marked for synchronizing.
This means that at flush-time this layer swaps the buffer of the wrapped platform
layer and updates the layer state to indicate that the underlying
TextureMapperPlatformLayerProxy object has to be activated on the composition thread.

This current logic results in the TextureMapperPlatformLayerProxy object being
reactivated for every display request that arrives via setContentsNeedsDisplay().
This is pretty wasteful since this activation heap-allocates a RunLoop::Timer object
which internally also locks up the GLib main context to attach a new source, and
that's only after the source on the previous RunLoop::Timer was detached before
that RunLoop::Timer was destroyed.

To avoid this, CoordinatedGraphicsLayer::setContentsNeedsDisplay() sets a new flag,
m_shouldUpdatePlatformLayer. During flush, this flag is checked in
CoordinatedGraphicsLayer::updatePlatformLayer(), with the buffer swap performed in
case it's set. CoordinatedGraphicsLayer::syncPlatformLayer() now only sets the
platform layer proxy object for that layer's state.

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::setContentsNeedsDisplay):
(WebCore::CoordinatedGraphicsLayer::syncPlatformLayer):
(WebCore::CoordinatedGraphicsLayer::updatePlatformLayer):
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):

• platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

4:29 AM Changeset in webkit [210542] by zandobersek@gmail.com

• 3 edits in trunk/Source/WebCore

[TexMap] Use WTF::Function in TextureMapperPlatformLayerProxy
​https://bugs.webkit.org/show_bug.cgi?id=166853

Reviewed by Michael Catanzaro.

Use WTF::Function in the TextureMapperPlatformLayerProxy, instead of
the std::function bloat.

• platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp:

(WebCore::TextureMapperPlatformLayerProxy::scheduleUpdateOnCompositorThread):
(WebCore::TextureMapperPlatformLayerProxy::compositorThreadUpdateTimerFired):

• platform/graphics/texmap/TextureMapperPlatformLayerProxy.h:

4:28 AM Changeset in webkit [210541] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

[TextureMapper] TextureMapperPlatformLayerProxy::swapBuffers() should hold the lock throughout invocation
​https://bugs.webkit.org/show_bug.cgi?id=166852

Reviewed by Michael Catanzaro.

• platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp:

(WebCore::TextureMapperPlatformLayerProxy::swapBuffer): Append to previous buffer
to the m_usedBuffers Vector while the object's lock is held. Everywhere else the
m_usedBuffers Vector is used under the lock, no reason to not do the same here.

4:16 AM Changeset in webkit [210540] by akling@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Crash when GC heap grows way too large.
<​https://webkit.org/b/166875>
<rdar://problem/27896585>

Reviewed by Mark Lam.

Hard cap the JavaScript heap at 4GB of live objects (determined post-GC.)
If we go past this limit, crash with a recognizable signature.

• heap/Heap.cpp:

(JSC::Heap::didExceedHeapSizeLimit):
(JSC::Heap::updateAllocationLimits):

3:03 AM Changeset in webkit [210539] by clopez@igalia.com

• 4 edits in trunk/Tools

[GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
​https://bugs.webkit.org/show_bug.cgi?id=166872

Reviewed by Michael Catanzaro.

Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
Define the required "--display-server=driver" in the bot additionalArguments config entry.
Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
The step RunWebKitTests already has support for it.

• BuildSlaveSupport/build.webkit.org-config/config.json:
• BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunGtkAPITests.start):
(RunAndUploadPerfTests.start):

• BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: