Timeline

Jan 14, 2017:

11:22 PM Changeset in webkit [210775] by Yusuke Suzuki

• 17 edits in trunk

Annotate large string tests with largeHeap
​https://bugs.webkit.org/show_bug.cgi?id=167054

Reviewed by Filip Pizlo.

JSTests:

• microbenchmarks/dense-set.js:
• microbenchmarks/lots-of-fields.js:
• stress/joined-strings-should-not-exceed-max-string-length.js:
• stress/make-large-string-jit-strcat.js:
• stress/make-large-string-jit.js:
• stress/make-large-string-strcat.js:
• stress/make-large-string.js:
• stress/string-joining-long-strings-should-not-crash.js:
• stress/string-prototype-replace-should-throw-out-of-memory-error-when-using-too-much-memory.js:

Tools:

• Scripts/run-javascriptcore-tests:
• Scripts/run-jsc-stress-tests:

LayoutTests:

• js/script-tests/stringimpl-to-jsstring-on-large-strings-1.js:
• js/script-tests/stringimpl-to-jsstring-on-large-strings-2.js:
• js/script-tests/stringimpl-to-jsstring-on-large-strings-3.js:

10:59 PM Changeset in webkit [210774] by Chris Dumez

• 7 edits in trunk/Source/WebCore

Report CPU usage of tabs after they become non-visible using diagnostic logging
​https://bugs.webkit.org/show_bug.cgi?id=167019
<rdar://problem/30019773>

Reviewed by Darin Adler.

Report CPU usage of tabs after they become non-visible using diagnostic logging.
We start measure CPU usage 5 seconds after a tab goes to the background, for 5
minutes and report how much CPU the tab used during those 5 minutes. We will
not log if the tab gets closed or moved to the foreground during those 5
minutes.

• page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::postPageBackgroundingKey):

• page/DiagnosticLoggingKeys.h:
• page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::didStartProvisionalLoad):
(WebCore::Page::didFinishLoad):
(WebCore::foregroundCPUUsageToDiagnosticLogginKey):
(WebCore::Page::measurePostLoadCPUUsage):
(WebCore::backgroundCPUUsageToDiagnosticLogginKey):
(WebCore::Page::measurePostBackgroundingCPUUsage):
(WebCore::Page::setIsVisibleInternal):

• page/Page.h:
• page/Settings.cpp:

(WebCore::Settings::isPostBackgroundingCPUUsageMeasurementEnabled):

• page/Settings.h:

10:45 PM Changeset in webkit [210773] by timothy_horton@apple.com

• 7 edits in trunk/Source/WebCore

De-duplicate some (nearly) identical code in Editor(Mac|IOS).mm
​https://bugs.webkit.org/show_bug.cgi?id=167062

Reviewed by Dan Bernstein.

No new tests, just refactoring.

• editing/Editor.cpp:

(WebCore::Editor::fontForSelection):
(WebCore::Editor::styleForSelectionStart):
(WebCore::Editor::adjustedSelectionRange):

• editing/Editor.h:

Move these three functions to Editor and unguard them, because they're
not Cocoa specific.

• platform/spi/cocoa/NSAttributedStringSPI.h:

Move some iOS-only NSAttributedString IPI (so no Internal SDK switch)
to NSAttributedStringSPI.h.

• editing/cocoa/EditorCocoa.mm:

(WebCore::Editor::writeSelectionToPasteboard):
(WebCore::Editor::selectionInWebArchiveFormat):
(WebCore::Editor::replaceSelectionWithAttributedString):
(WebCore::Editor::createFragmentForImageResourceAndAddResource):
(WebCore::Editor::dataInRTFDFormat):
(WebCore::Editor::dataInRTFFormat):
Move these six functions here.
selectionInWebArchiveFormat and replaceSelectionWithAttributedString are
entirely identical; writeSelectionToPasteboard and createFragment...
both have slightly suspicious-looking differences that I left intact
and wrote comments about (especially createFragment..., the other one
is somewhat explicable). The two dataInRTF(D)Format functions used to
be static functions, but for now are required from both EditorCocoa
and Editor(Mac|IOS), so we'll make them static member functions.

• editing/ios/EditorIOS.mm:

(WebCore::Editor::fontForSelection): Deleted.
(WebCore::Editor::selectionInWebArchiveFormat): Deleted.
(WebCore::dataInRTFDFormat): Deleted.
(WebCore::dataInRTFFormat): Deleted.
(WebCore::Editor::writeSelectionToPasteboard): Deleted.
(WebCore::Editor::createFragmentForImageResourceAndAddResource): Deleted.
(WebCore::Editor::replaceSelectionWithAttributedString): Deleted.

• editing/mac/EditorMac.mm:

(WebCore::Editor::fontForSelection): Deleted.
(WebCore::Editor::selectionInWebArchiveFormat): Deleted.
(WebCore::dataInRTFDFormat): Deleted.
(WebCore::dataInRTFFormat): Deleted.
(WebCore::Editor::writeSelectionToPasteboard): Deleted.
(WebCore::Editor::createFragmentForImageResourceAndAddResource): Deleted.
(WebCore::Editor::replaceSelectionWithAttributedString): Deleted.

10:27 PM Changeset in webkit [210772] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Cmd-, should open Settings tab
​https://bugs.webkit.org/show_bug.cgi?id=167028

Patch by Devin Rousso <Devin Rousso> on 2017-01-14
Reviewed by Timothy Hatcher.

• UserInterface/Base/Main.js:

(WebInspector.contentLoaded):
(WebInspector._showSettingsTab): Added.

9:06 PM Changeset in webkit [210771] by commit-queue@webkit.org

• 5 edits in trunk

Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
​https://bugs.webkit.org/show_bug.cgi?id=167043

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-01-14
Reviewed by Darin Adler.

.:

• Source/cmake/tools/vsprops/FeatureDefines.props:
• Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Tools:

• Scripts/webkitperl/FeatureList.pm:

8:44 PM WebKitGTK/2.14.x edited by Michael Catanzaro

Propose r209821 (diff)

8:35 PM WebKitGTK/2.14.x edited by Michael Catanzaro

Propose bug #165073 (diff)

11:59 AM Changeset in webkit [210770] by Alan Bujtas

• 2 edits in trunk/Source/WebCore

Small code cleanup after r210760
​https://bugs.webkit.org/show_bug.cgi?id=167047

Reviewed by Sam Weinig.

No change in functionality.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPosition):

11:35 AM Changeset in webkit [210769] by Yusuke Suzuki

• 6 edits in trunk/Source

WebAssembly: Suppress warnings & errors in GCC
​https://bugs.webkit.org/show_bug.cgi?id=167049

Reviewed by Sam Weinig.

Source/JavaScriptCore:

• wasm/WasmFunctionParser.h:

Add missing { } after the switch. Ideally, it is not necessary.
But in GCC, it is required. Since this function is fairly large,
I think the code generated by this does not cause performance
regression.

• wasm/WasmPageCount.h:

UINT_MAX is defined in limits.h.

• wasm/generateWasmValidateInlinesHeader.py:

On the other hand, we use this suppress pragma here to solve the
same problem in wasm/WasmFunctionParser.h. Since the load function
is fairly small, the additional return { }; may generate some
suboptimal code. See bug 150794 for more detail.

Source/WTF:

• wtf/LEBDecoder.h:

(WTF::LEBDecoder::decodeInt):
If T = int, it performs -1 << shift. It causes
warning in GCC. Instead, we first cast it to the
UnsignedT, perform operation and re-cast to the
T.

10:45 AM Changeset in webkit [210768] by Alan Bujtas

• 23 edits in trunk/Source/WebCore

Renderers should have a simple way to access Settings.
​https://bugs.webkit.org/show_bug.cgi?id=167048

Now that RenderObjects can never outlive the Page, we can just access the Settings
through Page instead of Document::settings/Frame::settings.

Reviewed by Andreas Kling.

No change in functionality.

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintCaret):
(WebCore::RenderBlock::shouldPaintSelectionGaps):

• rendering/RenderBlockFlow.cpp:

(WebCore::needsAppleMailPaginationQuirk):

• rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::startAlignedOffsetForLine):

• rendering/RenderBox.cpp:

(WebCore::RenderBox::layoutOverflowRectForPropagation):

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):

• rendering/RenderElement.cpp:

(WebCore::RenderElement::styleWillChange):
(WebCore::RenderElement::willBeRemovedFromTree):
(WebCore::RenderElement::shouldRespectImageOrientation):

• rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::getReplacementTextGeometry):

• rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::flattenFrameSet):

• rendering/RenderIFrame.cpp:

(WebCore::RenderIFrame::flattenFrame):

• rendering/RenderImage.cpp:

(WebCore::RenderImage::paintIntoRect):

• rendering/RenderInline.cpp:

(WebCore::RenderInline::addChildIgnoringContinuation):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::acceleratedCompositingForOverflowScrollEnabled):
(WebCore::RenderLayer::forceUpdateScrollbarsOnMainThreadForPerformanceTesting):
(WebCore::RenderLayer::hasAcceleratedTouchScrolling):
(WebCore::RenderLayer::getRectToExpose):
(WebCore::RenderLayer::overhangAmount):
(WebCore::RenderLayer::setHasHorizontalScrollbar):
(WebCore::RenderLayer::setHasVerticalScrollbar):
(WebCore::RenderLayer::calculateClipRects):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):
(WebCore::RenderLayerBacking::shouldAggressivelyRetainTiles):
(WebCore::RenderLayerBacking::shouldTemporarilyRetainTileCohorts):
(WebCore::RenderLayerBacking::useGiantTiles):
(WebCore::RenderLayerBacking::startAnimation):

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
(WebCore::RenderLayerCompositor::updateBacking):
(WebCore::RenderLayerCompositor::addToOverlapMap):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
(WebCore::RenderLayerCompositor::needsFixedRootBackgroundLayer):
(WebCore::RenderLayerCompositor::requiresContentShadowLayer):
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):

• rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::shouldPlaceBlockDirectionScrollbarOnLeft):

• rendering/RenderListBox.cpp:

(WebCore::RenderListBox::forceUpdateScrollbarsOnMainThreadForPerformanceTesting):

• rendering/RenderObject.h:

(WebCore::RenderObject::settings):

• rendering/RenderText.cpp:

(WebCore::SecureTextTimer::restart):

• rendering/RenderView.cpp:

(WebCore::RenderView::clientLogicalWidthForFixedPosition):
(WebCore::RenderView::clientLogicalHeightForFixedPosition):
(WebCore::RenderView::paintBoxDecorations):

• rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseForWithReason):

• rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::paintFlow):

• rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::applyResource):

9:35 AM Changeset in webkit [210767] by Chris Dumez

• 9 edits
  2 adds in trunk

Align the innerText setter with the HTML spec and Gecko
​https://bugs.webkit.org/show_bug.cgi?id=160971

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline several W3C tests now that more checks are passing.

• web-platform-tests/domparsing/createContextualFragment-expected.txt:
• web-platform-tests/innerText/setter-expected.txt:

Source/WebCore:

Align the innerText setter and createContextualFragment() with the
HTML specification and Gecko. In particular, they no longer throw
when the context element is a void element. This behavior was there
to match an old IE behavior but Edge dropped this behavior.

Test: fast/dom/br-set-outerText.html

• dom/Element.cpp:
• dom/Element.h:
• editing/markup.cpp:

(WebCore::createContextualFragment):

• html/HTMLElement.cpp:

(WebCore::HTMLElement::setInnerText):
(WebCore::HTMLElement::setOuterText):

LayoutTests:

Add test coverage for outerText, which is non-standard.

• fast/dom/br-set-outerText-expected.txt: Added.
• fast/dom/br-set-outerText.html: Added.

8:19 AM Changeset in webkit [210766] by Yusuke Suzuki

• 3 edits
  1 add in trunk

Reserve capacity for StringBuilder in unescape
​https://bugs.webkit.org/show_bug.cgi?id=167008

Reviewed by Sam Weinig.

JSTests:

• stress/unescape.js: Added.

(shouldBe):

Source/JavaScriptCore:

unescape function is frequently called in Kraken sha256-iterative.
This patch just reserves the capacity for the StringBuilder.

Currently, we select the length of the string for the reserved capacity.
It improves the performance 2.73%.

Benchmark report for Kraken on sakura-trick.

VMs tested:
"baseline" at /home/yusukesuzuki/dev/WebKit/WebKitBuild/untot/Release/bin/jsc
"patched" at /home/yusukesuzuki/dev/WebKit/WebKitBuild/un/Release/bin/jsc

Collected 100 samples per benchmark/VM, with 100 VM invocations per benchmark. Emitted a call to gc() between
sample measurements. Used 1 benchmark iteration per VM invocation for warm-up. Used the jsc-specific preciseTime()
function to get microsecond-level timing. Reporting benchmark execution times with 95% confidence intervals in
milliseconds.

baseline patched

stanford-crypto-sha256-iterative 51.609+-0.672 50.237+-0.860 might be 1.0273x faster

<arithmetic> 51.609+-0.672 50.237+-0.860 might be 1.0273x faster

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncUnescape):

1:01 AM Changeset in webkit [210765] by timothy_horton@apple.com

• 3 edits in trunk/Source/WebKit2

Remove unused WKView initializer parameter
​https://bugs.webkit.org/show_bug.cgi?id=167046

Reviewed by Dan Bernstein.

• UIProcess/API/mac/WKView.mm:

(-[WKView initWithFrame:processPool:configuration:]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
(-[WKView initWithFrame:configurationRef:]):
(-[WKView initWithFrame:processPool:configuration:webView:]): Deleted.

• UIProcess/API/mac/WKViewInternal.h:

Ever since WKWebView stopped having WKView inside it, this parameter
has never been used. Now, it only leads to confusion.

Jan 13, 2017:

11:09 PM Changeset in webkit [210764] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Settings tab is restored when reopening inspector
​https://bugs.webkit.org/show_bug.cgi?id=167025

Patch by Devin Rousso <Devin Rousso> on 2017-01-13
Reviewed by Matt Baker.

• UserInterface/Base/Main.js:

(WebInspector._tabBrowserSelectedTabContentViewDidChange):
Only save the selectedTabIndex if the current tab should be saved and reloaded upon opening
the WebInspector window.

9:59 PM Changeset in webkit [210763] by commit-queue@webkit.org

• 30 edits in trunk

Remove ENABLE(DETAILS_ELEMENT) guards
​https://bugs.webkit.org/show_bug.cgi?id=167042

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-01-13
Reviewed by Alex Christensen.

.:

• Source/cmake/OptionsMac.cmake:
• Source/cmake/OptionsWin.cmake:
• Source/cmake/WebKitFeatures.cmake:
• Source/cmake/tools/vsprops/FeatureDefines.props:
• Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

• Configurations/FeatureDefines.xcconfig:
• DerivedSources.make:
• accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::setIsExpanded):

• html/HTMLDetailsElement.cpp:
• html/HTMLDetailsElement.idl:
• html/HTMLSummaryElement.cpp:
• html/HTMLTagNames.in:
• html/shadow/DetailsMarkerControl.cpp:
• rendering/RenderDetailsMarker.cpp:
• rendering/RenderDetailsMarker.h:
• rendering/RenderObject.h:

(WebCore::RenderObject::isDetailsMarker):

• rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):

Source/WebKit/mac:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

• Configurations/FeatureDefines.xcconfig:

Source/WTF:

• wtf/FeatureDefines.h:

Tools:

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

9:52 PM Changeset in webkit [210762] by achristensen@apple.com

• 2 edits in trunk/Source/WebCore

Fix WinCairo build after r210753.
​https://bugs.webkit.org/show_bug.cgi?id=166730

• platform/WebGLStateTracker.h:

WTF::Function apparently needs to explicitly be differentiated from JSC::Attribute Function in PropertySlot.h.

8:04 PM Changeset in webkit [210761] by beidson@apple.com

• 4 edits in trunk/Source/WebKit2

Crash when visiting a webpage that uses Gamepads in a new WebProcess after a previous page has used gamepads..
​https://bugs.webkit.org/show_bug.cgi?id=167033

Reviewed by Alex Christensen.

• UIProcess/Gamepad/UIGamepadProvider.cpp:

(WebKit::UIGamepadProvider::processPoolStartedUsingGamepads): Don't schedule a state update here.
(WebKit::UIGamepadProvider::processPoolStoppedUsingGamepads): Ditto.

• UIProcess/Gamepad/UIGamepadProvider.h:

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::startedUsingGamepads): Populate the WebProcess with initial gamepads.

7:42 PM Changeset in webkit [210760] by Brent Fulgham

• 2 edits in trunk/Source/WebCore

Potential nullptr dereference in RenderLayer::updateLayerPosition()
​https://bugs.webkit.org/show_bug.cgi?id=167036
<rdar://problem/30023019>

Reviewed by Dean Jackson.

A value was being used without nullptr checking, even though it had been checked for null a
few lines prior.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPosition): Add missing nullptr check.

7:40 PM Changeset in webkit [210759] by Nikita Vasilyev

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Resources disappear from the network tab when iframe gets removed from DOM
​https://bugs.webkit.org/show_bug.cgi?id=166776
<rdar://problem/29909640>

Reviewed by Matt Baker.

• UserInterface/Views/NetworkSidebarPanel.js:

(WebInspector.NetworkSidebarPanel):
Don't remove resource tree elements from Network tab when iframe gets detached from the DOM.

7:35 PM Changeset in webkit [210758] by Darin Adler

• 166 edits
  3 deletes in trunk/Source

Remove PassRefPtr from more of "platform"
​https://bugs.webkit.org/show_bug.cgi?id=166809

Reviewed by Sam Weinig.

Source/JavaScriptCore:

• inspector/JSInjectedScriptHost.h:

(Inspector::JSInjectedScriptHost::impl): Simplified code since we don't need a
const_cast here any more.

• runtime/PrivateName.h:

(JSC::PrivateName::uid): Ditto.

Source/WebCore:

• CMakeLists.txt: Removed DeviceMotionClientMock.cpp.

• Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.h:

Added now-needed include.

• Modules/speech/SpeechSynthesisUtterance.cpp:

(WebCore::SpeechSynthesisUtterance::SpeechSynthesisUtterance):
Pass a reference instead of a pointer.

• Modules/speech/SpeechSynthesisUtterance.h: Tweaks, msade a few things

more private and final.

• bindings/js/JSDOMConvert.h:

(WebCore::Detail::getPtrOrRef): Removed no-longer-needed const_cast.

• bindings/js/JSDOMWrapper.h:

(WebCore::JSDOMWrapper::wrapped): Ditto.

• bindings/js/ScriptModuleLoader.cpp:

(WebCore::ScriptModuleLoader::~ScriptModuleLoader): Ditto.

• css/BasicShapeFunctions.cpp:

(WebCore::convertToLengthSize): Updated for LengthSize struct.
(WebCore::convertToCenterCoordinate): Ditto.

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::createPositionListForLayer): Take a reference.
(WebCore::getBorderRadiusCornerValues): Updated for LengthSize struct.
(WebCore::getBorderRadiusCornerValue): Ditto.
(WebCore::getBorderRadiusShorthandValue): Ditto.
(WebCore::fillSizeToCSSValue): Ditto.
(WebCore::ComputedStyleExtractor::propertyValue): Updated many properties
since the layer properties now return references rather than pointers.

• css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::CachedGeneratedImage::image): Removed
no-longer-needed const_cast.

• css/CSSKeyframesRule.cpp:

(WebCore::CSSKeyframesRule::item): Ditto.

• css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::init): Updated for LengthSize struct.

• css/CSSStyleRule.h: Removed no-longer-needed const_cast.

• css/CSSToStyleMap.cpp:

(WebCore::convertToLengthSize): Updated for LengthSize struct.

• css/FontFace.cpp:

(WebCore::FontFace::family): Removed no-longer-needed const_cast.
(WebCore::FontFace::style): Ditto.
(WebCore::FontFace::weight): Ditto.
(WebCore::FontFace::unicodeRange): Ditto.
(WebCore::FontFace::variant): Ditto.
(WebCore::FontFace::featureSettings): Ditto.

• css/LengthFunctions.cpp:

(WebCore::sizeForLengthSize): Added.
(WebCore::floatSizeForLengthSize): Updated for LengthSize struct.

• css/LengthFunctions.h: Added sizeForLengthSize.

• css/SVGCSSComputedStyleDeclaration.cpp:

(WebCore::paintOrder): Cut down on creation of unused objects.
We now create only what we actually use.

• css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertRadius): Updated for
LengthSize struct.
(WebCore::StyleBuilderConverter::convertShapeValue): Pass references
when creating ShapeValue.

• css/StyleBuilderCustom.h:

(WebCore::forwardInheritedValue): Added. This set of overloaded
functions allows us to use move semantics for some types, but copy
them when inheriting. Doing it with special cases here allows us to
resolve this without adding overloads someone might be tempted to
call outside the style builder, and without adding special cases to
the JSON file for each property.
(WebCore::StyleBuilderCustom::applyValueWebkitDashboardRegion):
Add WTFMove as needed to work with rvalue references.
(WebCore::StyleBuilderCustom::applyValueSize): Ditto.
(WebCore::StyleBuilderCustom::applyInheritTextIndent): Ditto.
(WebCore::StyleBuilderCustom::applyValueTextIndent): Ditto.
(WebCore::StyleBuilderCustom::applyInheritLineHeight): Ditto.
(WebCore::StyleBuilderCustom::applyValueLineHeight): Ditto.
(WebCore::StyleBuilderCustom::applyInheritClip): Ditto.
(WebCore::StyleBuilderCustom::applyValueClip): Ditto.

• css/StyleResolver.cpp:

(WebCore::StyleResolver::State::cacheBorderAndBackground): Use
references instead of pointers.
(WebCore::StyleResolver::applyMatchedProperties): Ditto.
(WebCore::StyleResolver::applyProperty): Update for changes to the
custom property data in RenderStyle.

• css/makeprop.pl: Use auto quite a bit more in the generated code.

Updated special cases for layers to expect references. Added a WTFMove
so we can get move semantics for converted values that come out in
an optional. Added call to forwardInheritedValue (see above).

• dom/Document.cpp:

(WebCore::Document::pageSizeAndMarginsInPixels): Use auto and update
since LengthSize is a struct.

• dom/EventPath.cpp:

(WebCore::EventPath::computePathUnclosedToTarget): Use auto.

• dom/LiveNodeList.h:

(WebCore::LiveNodeList::ownerNode): Removed no-longer-needed const_cast.

• dom/MessageEvent.cpp:

(WebCore::MessageEvent::source): Removed unneeded static_cast.

• dom/Node.cpp:

(WebCore::nodeSetPreTransformedFromNodeOrStringVector): Tweaked formatting.

• dom/Range.h:

(WebCore::Range::ownerDocument): Removed no-longer-needed const_cast.

• dom/RegisteredEventListener.h:

(WebCore::RegisteredEventListener::callback): Ditto.

• dom/ScriptRunner.cpp:

(WebCore::ScriptRunner::~ScriptRunner): Ditto.

• html/HTMLCollection.h:

(WebCore::HTMLCollection::ownerNode): Ditto.

• html/parser/HTMLStackItem.h:

(WebCore::HTMLStackItem::node): Ditto.

• inspector/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::setJavaScriptPaused): Cut down on the number
of different functions here. Also use reference rather than pointer.

• inspector/PageScriptDebugServer.h: Updated for above change.

• loader/HistoryController.cpp:

(WebCore::HistoryController::recursiveSetProvisionalItem): Removed
no-longer-needed const_cast.
(WebCore::HistoryController::recursiveGoToItem): Ditto.

• page/Frame.cpp:

(WebCore::Frame::ownerRenderer): Use auto. Let the is<> function do null
checking for us.
(WebCore::Frame::frameForWidget): Take a reference rather than a pointer.

• page/Frame.h: Updated for the above.

• page/FrameView.cpp:

(WebCore::FrameView::invalidateRect): Use Chrome directly instead of using
HostWindow. HostWindow is an abstraction for the platform layer, and there
is no good reason to use it here.
(WebCore::FrameView::scheduleAnimation): Ditto.
(WebCore::FrameView::graphicsLayerForPlatformWidget): Updated to use reference
when calling RenderWidget::find.
(WebCore::FrameView::scrollContentsFastPath): Use Chrome instead of HostWindow.
(WebCore::FrameView::hostWindow): Use early return.
(WebCore::FrameView::updateScrollCorner): Removed unneeded call through to base
class function, which was empty.
(WebCore::FrameView::hasCustomScrollbars): Updated since the children set now
contains Ref rather than RefPtr.
(WebCore::FrameView::parentFrameView): Use early return.
(WebCore::FrameView::updateWidgetPositions): Use reference instead of pointer.

• page/FrameView.h: Use final instead of override. Remove now-unneeded const_cast.

• page/Page.cpp:

(WebCore::Page::pluginViews): Updated since the children set now contains
Ref rather than RefPtr.

• page/PrintContext.cpp:

(WebCore::PrintContext::pageProperty): Updated for LengthSize struct.

• page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::fireAnimationEventsIfNeeded): Updated for changes to
the types in animation function members.
(WebCore::AnimationBase::timeToNextService): Ditto.
(WebCore::AnimationBase::progress): Ditto.
(WebCore::AnimationBase::getElapsedTime): Ditto.

• page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc): Updated for LengthSize struct.
(WebCore::LengthPropertyWrapper::LengthPropertyWrapper): Updated since we now
use rvalue references and move semantics when setting length properties.

• page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::absoluteEventTrackingRegionsForFrame): Tweaked to
use auto, pass references.

• platform/KeyedCoding.h: Return RefPtr instead of PassRefPtr.

• platform/LengthBox.h: Added a constructor that moves the lengths in, rather

than always copying them.

• platform/LengthSize.cpp:

(WebCore::operator<<): Updated since LengthSize is a struct.

• platform/LengthSize.h: Turned LengthSize into a struct and removed all the

getter and setter code.

• platform/PlatformSpeechSynthesis.h: Removed. Unused.

• platform/PlatformSpeechSynthesisUtterance.cpp:

(WebCore::PlatformSpeechSynthesisUtterance::create): Return Ref rather than PassRefPtr.
(WebCore::PlatformSpeechSynthesisUtterance::PlatformSpeechSynthesisUtterance): Take
a reference. Initialize data members in class definition.

• platform/PlatformSpeechSynthesisUtterance.h: Updated for the above.

• platform/PlatformSpeechSynthesisVoice.cpp:

(WebCore::PlatformSpeechSynthesisVoice::create): Return Ref rather than PassRefPtr.

• platform/PlatformSpeechSynthesisVoice.h: Updated for the above.

• platform/ScrollView.cpp:

(WebCore::ScrollView::addChild): Take a reference rather than a PassRefPtr.
(WebCore::ScrollView::setHasScrollbarInternal): Updated for change to addChild
(WebCore::ScrollView::scrollContentsFastPath): Deleted. This was never called,
so made it pure virtual.
(WebCore::ScrollView::frameRectsChanged): Use a modern for loop.
(WebCore::ScrollView::clipRectChanged): Ditto.
(WebCore::ScrollView::updateScrollCorner): Deleted. This was empty so made it pure
virtual and changed FrameView to not call it.
(WebCore::ScrollView::setParentVisible): Use a modern for loop.
(WebCore::ScrollView::show): Ditto.
(WebCore::ScrollView::hide): Ditto.

• platform/ScrollView.h: Changed the children set to contain Ref instead of RefPtr.

Changed functions that were never overridden to either be final or non-virtual,
Changed functions that were never called to be pure virtual.

• platform/Theme.h:

(WebCore::Theme::minimumControlSize): Updated for LengthSize struct.

• platform/animation/Animation.h: Changed timingFunction and trigger to return

raw pointers instead of PassRefPtr. Changed setTimingFunction and setTrigger to
take RefPtr&& and Ref&& instead of PassRefPtr. CHanged initialTimingfunction and
initialTrigger to return Ref.

• platform/animation/AnimationList.cpp: Removed redundant check in FILL_UNSET_PROPERTY.

(WebCore::AnimationList::AnimationList): Use modern for loop, reserveInitialCapacity,
and uncheckedAppend.

• platform/animation/AnimationList.h: Changed append to take Ref&& instead of PassRefPtr.

changed vecto to contain Ref instead of RefPtr. Added move constructor and assignment
operator.

• platform/animation/AnimationTrigger.h:

(WebCore::AutoAnimationTrigger::clone): Return Ref instead of PassRefPtr.
(WebCore::AutoAnimationTrigger::create): Ditto.
(WebCore::AutoAnimationTrigger::clone): Ditto.
(WebCore::ScrollAnimationTrigger::create): Ditto.
(WebCore::ScrollAnimationTrigger::clone): Ditto.

• platform/animation/TimingFunction.h:

(WebCore::LinearTimingFunction::create): Return Ref instead of PassRefPtr.
(WebCore::CubicBezierTimingFunction::create): Ditto.
(WebCore::CubicBezierTimingFunction::defaultTimingFunction): Return a reference
instead of a pointer.
(WebCore::CubicBezierTimingFunction::createReversed): Return Ref instead of PassRefPtr.
(WebCore::CubicBezierTimingFunction::clone): Ditto.
(WebCore::StepsTimingFunction::create): Ditto.
(WebCore::StepsTimingFunction::clone): Ditto.
(WebCore::SpringTimingFunction::create): Ditto.
(WebCore::SpringTimingFunction::clone): Ditto.

• platform/audio/AudioBus.h:

(WebCore::AudioBus::channel): Removed no-longer-needed const_cast.

• platform/cf/KeyedEncoderCF.cpp:

(WebCore::KeyedEncoderCF::finishEncoding): Return RefPtr instead of PassRefPtr.

• platform/cf/KeyedEncoderCF.h: Use final instead of override. Made even more

private. Changed return value of finishEncoding to Ref instead of PassRefPtr.

• platform/efl/PlatformSpeechSynthesisProviderEfl.h: Removed include of PassRefPtr.h.

• platform/glib/KeyedEncoderGlib.cpp:

(WebCore::KeyedEncoderGlib::finishEncoding): Return RefPtr instead of PassRefPtr.

• platform/glib/KeyedEncoderGlib.h: Use final instead of override. Made even more

private. Changed return value of finishEncoding to Ref instead of PassRefPtr.

• platform/graphics/filters/FilterOperations.cpp:

(WebCore::outsetSizeForBlur): Simplified, removing unnecessary floating point math.
(WebCore::FilterOperations::FilterOperations): Deleted. Let the compiler generate this.
(WebCore::FilterOperations::operator=): Deleted. Let the compiler generate this.
(WebCore::FilterOperations::operator==): Streamlined.
(WebCore::FilterOperations::operationsMatch): Ditto.
(WebCore::FilterOperations::hasReferenceFilter): Ditto.
(WebCore::FilterOperations::hasOutsets): Ditto.
(WebCore::FilterOperations::outsets): Ditto.
(WebCore::FilterOperations::hasFilterThatAffectsOpacity): Ditto.
(WebCore::FilterOperations::hasFilterThatMovesPixels): Ditto.

• platform/graphics/filters/FilterOperations.h: Updated for above changes.

• platform/graphics/FontCache.h: Removed included of PassRefPtr.h.

• platform/graphics/FontPlatformData.h: Tweaked formatting. Removed nesting

from #if since our formatting makes it hard to see nesting. Let the compiler
generate the default move and copy constructors and assignemnt operators except
in the USE(FREETYPE) case.

• platform/graphics/GraphicsLayer.h:

(WebCore::AnimationValue::AnimationValue): Updated since clone now returns a Ref
rather than a RefPtr.
(WebCore::FloatAnimationValue::FloatAnimationValue): Deleted. Let the compiler
generate the copy constructor without defining it explicitly.
(WebCore::TransformAnimationValue::TransformAnimationValue): Use a modern for
loop, reserveInitialCapacity, and unchecked append. Also tell the compiler to
generate the move constructor, since the special work is only needed for the
copy constructor.
(WebCore::FilterAnimationValue::FilterAnimationValue): Ditto.
(WebCore::KeyframeValueList::KeyframeValueList): Ditto.

• platform/graphics/LegacyCDMSession.h: Removed include of PassRefPtr.h.

• platform/graphics/PathUtilities.cpp:

(WebCore::PathUtilities::pathWithShrinkWrappedRectsForOutline): Updated
for LengthSize struct.

• platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.cpp:

(WebCore::CDMSessionAVFoundationCF::CDMSessionAVFoundationCF): Take a reference.
Don't bother setting m_client since we never use it.
(WebCore::CDMSessionAVFoundationCF::generateKeyRequest): Clean up code a bit
by using auto a lot more.

• platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.h: Added include

that is now needed since it was removed from the base class. Tidied the class
up a bit, marking it final, making everything private, taking a reference, and
removing an unused data member, m_client.

• platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::createSession): Pass a reference.

• platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.h:

added include of WTFString.h, now needed because of removing an unneeded
include from another header file.

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::animationCanBeAccelerated): Updated since trigger
is a raw pointer now.
(WebCore::GraphicsLayerCA::timingFunctionForAnimationValue): Updated to
return a reference rather than a pointer.
(WebCore::GraphicsLayerCA::setAnimationEndpoints): Updated for the above change.
(WebCore::GraphicsLayerCA::setAnimationKeyframes): Ditto.
(WebCore::GraphicsLayerCA::setTransformAnimationEndpoints): Ditto.
(WebCore::GraphicsLayerCA::setTransformAnimationKeyframes): Ditto.
(WebCore::GraphicsLayerCA::setFilterAnimationEndpoints): Ditto.
(WebCore::GraphicsLayerCA::setFilterAnimationKeyframes): Ditto.

• platform/graphics/ca/GraphicsLayerCA.h: Ditto.

• platform/ios/PlatformSpeechSynthesizerIOS.mm:

(-[WebSpeechSynthesisWrapper speakUtterance:]): CHanged argument to be a
RefPtr&& instead of a PassRefPtr.

• platform/mac/ThemeMac.mm:

(WebCore::sizeFromNSControlSize): Updated for LenghtSize struct.
(WebCore::checkboxSize): Ditto.
(WebCore::radioSize): Ditto.
(WebCore::ThemeMac::controlSize): Ditto.
(WebCore::ThemeMac::minimumControlSize): Ditto.

• platform/mac/WidgetMac.mm:

(WebCore::Widget::setFocus): Updated to pass a reference.

• platform/mock/DeviceMotionClientMock.cpp: Removed. Unused.
• platform/mock/DeviceMotionClientMock.h: Removed. Unused.

• platform/win/CursorWin.cpp:

(WebCore::createSharedCursor): Return a Ref instead of a PassRefPtr.
(WebCore::loadSharedCursor): Ditto.
(WebCore::loadCursorByName): Ditto.

• rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::output): Removed a no-longer-needed const_cast.
(WebCore::FilterEffectRenderer::outputRect): Ditto.

• rendering/ImageQualityController.cpp:

(WebCore::ImageQualityController::chooseInterpolationQuality): Tweaked formatting.

• rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::paintFillLayers): Updated to take a reference. Also
used a vector to iterate the linked list in reverse order instead of recursion.
(WebCore::InlineFlowBox::paintFillLayer): Take a reference.
(WebCore::InlineFlowBox::paintMask):

• rendering/InlineFlowBox.h: Updated for the above.

• rendering/RenderBox.cpp:

(WebCore::RenderBox::paintRootBoxFillLayers): Use auto a bit.
(WebCore::RenderBox::getBackgroundPaintedExtent): Use reference for the layers.
(WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect): Ditto.
(WebCore::RenderBox::backgroundHasOpaqueTopLayer): Ditto.
(WebCore::RenderBox::paintMaskImages): Ditto.
(WebCore::RenderBox::maskClipRect): Ditto.
(WebCore::RenderBox::paintFillLayers): Ditto.
(WebCore::RenderBox::paintFillLayer): Ditto.
(WebCore::layersUseImage): Ditto.
(WebCore::RenderBox::repaintLayerRectsForImage): Ditto.

• rendering/RenderBox.h: Updated for the above.

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended): Use reference for
the layers.
(WebCore::RenderBoxModelObject::calculateFillTileSize): Ditto.
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Ditto.
(WebCore::RenderBoxModelObject::getGeometryForBackgroundImage): Ditto.
(WebCore::RenderBoxModelObject::boxShadowShouldBeAppliedToBackground): Ditto.

• rendering/RenderBoxModelObject.h: Updated for the above.

• rendering/RenderElement.cpp:

(WebCore::RenderElement::~RenderElement): Use references for the layers.
(WebCore::RenderElement::adjustStyleDifference): Ditto.
(WebCore::RenderElement::updateFillImages): Ditto.
(WebCore::RenderElement::setStyle): Use RenderStyle::replace to replace the
old style with the new style, and get the old one out at the same time.
(WebCore::RenderElement::styleDidChange): Use references for the layers.
(WebCore::mustRepaintFillLayers): Ditto.
(WebCore::RenderElement::repaintAfterLayoutIfNeeded): Ditto.

• rendering/RenderElement.h: Updated for the above.

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computeContentPositionAndDistributionOffset):
Refactor so we don't need so many functions in RenderStyle.

• rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::adjustInnerStyle): Ditto.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::createScrollbar): Pass widget as reference to addChild.
Also did a few other tweaks and used more specific types.

• rendering/RenderLayerBacking.cpp:

(WebCore::canCreateTiledImage): Updated since layers are references.
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundImage): Ditto.

• rendering/RenderListBox.cpp:

(WebCore::RenderListBox::createScrollbar): Pass widget as reference to addChild.

• rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintBackgroundsBehindCell): Updated to use
references for layers.

• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::adjustStyle): Use WTFMove to pass a LengthBox.
(WebCore::RenderTheme::isControlStyled): Updated since LengthSize is a struct,
more WTFMove, change since layers are ferences.

• rendering/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::adjustSizeConstraints): Update for Length and
LengthSize changes.
(WebCore::RenderThemeEfl::paintThemePart): Use reference instead of pointer.
(WebCore::RenderThemeEfl::applyPartDescriptionFallback): Update for Length and
LengthSize changes.
(WebCore::RenderThemeEfl::applyPartDescription): Ditto.
(WebCore::RenderThemeEfl::adjustCheckboxStyle): Ditto.
(WebCore::RenderThemeEfl::adjustRadioStyle): Ditto.

• rendering/RenderThemeGtk.cpp:

(WebCore::borderRadiiFromStyle): Update for Length and LengthSize changes.

• rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::adjustCheckboxStyle): Update for Length and
LengthSize changes.
(WebCore::RenderThemeIOS::isControlStyled): Ditto.
(WebCore::RenderThemeIOS::adjustRadioStyle): Ditto.
(WebCore::RenderThemeIOS::adjustRoundBorderRadius): Ditto.
(WebCore::RenderThemeIOS::paintMenuListButtonDecorations): Ditto.
(WebCore::RenderThemeIOS::adjustSliderTrackStyle): Ditto.
(WebCore::RenderThemeIOS::adjustSliderThumbSize): Ditto.

• rendering/RenderWidget.cpp:

(WebCore::WidgetHierarchyUpdatesSuspensionScope::moveWidgets): Use move
insteead of swap and modern for loop instead of iterators.
(WebCore::moveWidgetToParentSoon): Take a reference instead of a pointer.
(WebCore::RenderWidget::setWidget): Update for above change.
(WebCore::RenderWidget::find): Take a reference instead of a pointer.

• rendering/RenderWidget.h: Updated for above changes.

• rendering/TextAutoSizing.cpp:

(WebCore::TextAutoSizingValue::reset): Updated since Length is passed as
rvalue reference now.

• rendering/mathml/MathMLStyle.cpp:

(WebCore::MathMLStyle::getMathMLStyle): Updated since mathMLStyle returns
a reference.
(WebCore::MathMLStyle::resolveMathMLStyleTree): Ditto.

• rendering/mathml/RenderMathMLBlock.h:

(WebCore::RenderMathMLBlock::mathMLStyle): Removed no-longer needed const_cast,
changed to return a reference rather than a pointer.
(WebCore::RenderMathMLTable::mathMLStyle): Ditto.

• rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::fractionParameters): Updated since mathMLStyle
returns a reference.
(WebCore::RenderMathMLFraction::stackParameters): Ditto.

• rendering/mathml/RenderMathMLOperator.h:

(WebCore::RenderMathMLOperator::isLargeOperatorInDisplayStyle): Ditto.
(WebCore::RenderMathMLOperator::shouldMoveLimits): Ditto.

• rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::verticalParameters): Ditto.

• rendering/mathml/RenderMathMLToken.cpp:

(WebCore::RenderMathMLToken::updateMathVariantGlyph): Ditto.

• rendering/style/BasicShapes.cpp:

(WebCore::floatSizeForLengthSize): Updated for LengthSize struct.

• rendering/style/BorderData.h:

(WebCore::BorderData::BorderData): Ditto.
(WebCore::BorderData::hasBorderRadius): Ditto.

• rendering/style/ContentData.cpp:

(WebCore::ContentData::clone): Updated member names.

• rendering/style/ContentData.h: Ditto.

• rendering/style/NinePieceImage.cpp:

(WebCore::NinePieceImage::computeSlices): Use initializer lists so we get
move optimization without requiring explicit WTFMove.

• rendering/style/DataRef.h:

(WebCore::DataRef::DataRef): Removed no-longer needed const_cast.
(WebCore::DataRef::replace): Added. This function is like Ref::replace, and
can be used to put a new value in and get an old value out without running into
the rule Ref has about not being reused once it becomes null because of being
moved out of. This function is a lot like std::exchange.
(WebCore::DataRef::operator const T&): Added operator so we can use these
as references without any function call in read-only contexts.
(WebCore::DataRef::get): Changed to return a reference rather than pointer.
(WebCore::DataRef::access): Ditto.

• rendering/style/KeyframeList.cpp:

(WebCore::KeyframeValue::timingFunction): Updated since timingFunction
returns a raw pointer.
(WebCore::KeyframeList::~KeyframeList): Removed unneeded call to clear,
which does things that are redundant since we are about to destroy all the
data members.
(WebCore::KeyframeList::operator==): Tweaked codign style a bit.

• rendering/style/NinePieceImage.h: Updated most functions in this class

for the changes to DataRef.

• rendering/style/RenderStyle.cpp: Updated nearly every function in this

class for the changes to DataRef, to eliminate the peculiar naming and use
our standard data member naming, m_memberName in a class, and memberName in a
struct or struct-like class for publicly accessible members, to pass, take,
and return more references and rvalue references, and to use modern for loops.
Other changes listed below function by function.
(WebCore::RenderStyle::defaultStyle): Use NeverDestroyed instead of allocating
on the heap.
(WebCore::RenderStyle::RenderStyle): Added a new constructor that performs
the replace operation, using a combination of DataRef::replace and std::exchange.
(WebCore::RenderStyle::replace): Added. Calls the above constructor.
(WebCore::RenderStyle::setScrollSnapType): Use SET_NESTED_VAR so we get equality
checks on this property, for the normal efficiency benefit.
(WebCore::RenderStyle::setDashboardRegion): Moved this here from the header.
(WebCore::RenderStyle::appendContent): Deleted.
(WebCore::RenderStyle::setContent): Refactored this set of functions to simplify.

• rendering/style/RenderStyle.h: Updated most functions as mentioned above.

Also updated macros to use the do/while(0) technique. Removed the long list of
friend classes with the elaborate comments; turned out none needed friendship
despite the comments. Made more things private. Moved large functions out of the
class definition.
(WebCore::RenderStyle::getTextShadowExtent): Deleted.
(WebCore::RenderStyle::getTextShadowHorizontalExtent): Deleted.
(WebCore::RenderStyle::getTextShadowVerticalExtent): Deleted.
(WebCore::RenderStyle::aspectRatio): Deleted.
(WebCore::RenderStyle::alignContentPosition): Deleted.
(WebCore::RenderStyle::alignContentDistribution): Deleted.
(WebCore::RenderStyle::alignContentOverflowAlignment): Deleted.
(WebCore::RenderStyle::alignItemsPosition): Deleted.
(WebCore::RenderStyle::alignItemsOverflowAlignment): Deleted.
(WebCore::RenderStyle::alignSelfPosition): Deleted.
(WebCore::RenderStyle::alignSelfOverflowAlignment): Deleted.
(WebCore::RenderStyle::justifyContentPosition): Deleted.
(WebCore::RenderStyle::justifyContentDistribution): Deleted.
(WebCore::RenderStyle::justifyContentOverflowAlignment): Deleted.
(WebCore::RenderStyle::justifyItemsPosition): Deleted.
(WebCore::RenderStyle::justifyItemsOverflowAlignment): Deleted.
(WebCore::RenderStyle::justifyItemsPositionType): Deleted.
(WebCore::RenderStyle::justifySelfPosition): Deleted.
(WebCore::RenderStyle::justifySelfOverflowAlignment): Deleted.
(WebCore::RenderStyle::setAlignContentPosition): Deleted.
(WebCore::RenderStyle::setAlignContentOverflow): Deleted.
(WebCore::RenderStyle::setAlignContentDistribution): Deleted.
(WebCore::RenderStyle::setAlignItemsOverflow): Deleted.
(WebCore::RenderStyle::setAlignSelfOverflow): Deleted.
(WebCore::RenderStyle::setJustifyContentOverflow): Deleted.
(WebCore::RenderStyle::setJustifyContentDistribution): Deleted.
(WebCore::RenderStyle::setJustifyItemsPosition): Deleted.
(WebCore::RenderStyle::setJustifyItemsOverflow): Deleted.
(WebCore::RenderStyle::setJustifyItemsPositionType): Deleted.
(WebCore::RenderStyle::setJustifySelfPosition): Deleted.
(WebCore::RenderStyle::setJustifySelfOverflow): Deleted.
(WebCore::RenderStyle::noninheritedFlagsMemoryOffset): Deleted.

• rendering/style/SVGRenderStyle.cpp: Similar changes to RenderStyle.cpp above.
• rendering/style/SVGRenderStyle.h: Ditto.

• rendering/style/ShapeValue.h:

(WebCore::ShapeValue::create): Take a Ref&& instead of a RefPtr.
(WebCore::ShapeValue::ShapeValue): Ditto.

• rendering/style/StyleBackgroundData.cpp: Update data member names.
• rendering/style/StyleBackgroundData.h: Ditto; make them public and remove the

getter functions.

• rendering/style/StyleCachedImage.cpp:

(WebCore::StyleCachedImage::cssValue): Removed no-longer-needed const_cast.

• rendering/style/StyleCustomPropertyData.h: Update data member names.

(WebCore::StyleCustomPropertyData::operator==): Removed unnecessary reference
count churn.
(WebCore::StyleCustomPropertyData::setCustomPropertyValue): Take an rvalue
reference.
(WebCore::StyleCustomPropertyData::getCustomPropertyValue): Deleted.
(WebCore::StyleCustomPropertyData::values): Deleted.
(WebCore::StyleCustomPropertyData::hasCustomProperty): Deleted.
(WebCore::StyleCustomPropertyData::containsVariables): Deleted.
(WebCore::StyleCustomPropertyData::setContainsVariables): Deleted.

• rendering/style/StyleFilterData.cpp: Update data member names.
• rendering/style/StyleFilterData.h: Ditto.
• rendering/style/StyleFlexibleBoxData.cpp: Ditto.
• rendering/style/StyleFlexibleBoxData.h: Ditto.
• rendering/style/StyleGridData.cpp: Ditto.
• rendering/style/StyleGridData.h: Ditto.
• rendering/style/StyleGridItemData.cpp: Ditto.
• rendering/style/StyleGridItemData.h: Ditto.

• rendering/style/StyleGeneratedImage.cpp:

(WebCore::StyleGeneratedImage::cssValue): Removed no-longer-needed const_cast.
(WebCore::StyleGeneratedImage::imageSize): Ditto.
(WebCore::StyleGeneratedImage::image): Ditto.

• rendering/style/StyleInheritedData.cpp: Update data member names.
• rendering/style/StyleInheritedData.h: Ditto.
• rendering/style/StyleRareInheritedData.cpp: Ditto.
• rendering/style/StyleRareInheritedData.h: Ditto.
• rendering/style/StyleMultiColData.cpp: Ditto.
• rendering/style/StyleMultiColData.h: Ditto.
• rendering/style/StyleRareNonInheritedData.cpp: Ditto.
• rendering/style/StyleRareNonInheritedData.h: Ditto.
• rendering/style/StyleTransformData.cpp: Ditto.
• rendering/style/StyleTransformData.h: Ditto.
• rendering/style/StyleVisualData.cpp: Ditto.
• rendering/style/StyleVisualData.h: Ditto.

• style/StylePendingResources.cpp:

(WebCore::Style::loadPendingResources): Update since layers are references.

Source/WebKit/mac:

• WebCoreSupport/WebFrameLoaderClient.mm:

(NetscapePluginWidget::handleEvent): Pass a reference.

• WebView/WebView.mm:

(-[WebView _addScrollerDashboardRegionsForFrameView:dashboardRegions:]):
Updated since the children set now contains Ref instead of RefPtr.

Source/WebKit2:

• Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(IPC::ArgumentCoder<TextureMapperAnimation>::encode): Updated since timing function
returns a raw pointer.
(IPC::ArgumentCoder<TextureMapperAnimation>::decode): Updated since timing function
setters now takes an rvalue reference.

• WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm:

(WebKit::PDFPlugin::createScrollbar): Updated since addChild now takes a reference.

Source/WTF:

• wtf/Ref.h: Changed the template so that a const Ref<T> does not prohibit non-const

use of T. We can still use const Ref<const T> to express that. The earlier design
was intentional, but was not consistent with either actual references or with
other smart pointer classes like RefPtr. One way to see how much better this is,
is to see all the many, many cases where we have const_cast just to work around
this. I searched for those and included fixes for many in this patch.

7:17 PM Changeset in webkit [210757] by commit-queue@webkit.org

• 4 edits in trunk

26 MotionMark performance tests failing
​https://bugs.webkit.org/show_bug.cgi?id=166854

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2017-01-13
Reviewed by Ryosuke Niwa.
PerformanceTests:

Skip running MotionMark on WebKit perf bots.

• Skipped:

Tools:

Unrelated change. This is the last place that we need to rename Animometer
to MotionMark.

• Scripts/webkitpy/common/config/watchlist:

7:07 PM Changeset in webkit [210756] by Nikita Vasilyev

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: the 'lock' icon for non-editable rules in the Style Rules sidebar lacks a tooltip
​https://bugs.webkit.org/show_bug.cgi?id=166909
<rdar://problem/29959406>

Reviewed by Matt Baker.

Convert the lock icon from a pseudo-element to an 'img' element and add a title attribute.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Views/CSSStyleDeclarationSection.css:

(.style-declaration-section.locked > .header > .locked-icon):
(.style-declaration-section.locked > .header::before): Deleted.

• UserInterface/Views/CSSStyleDeclarationSection.js:

(WebInspector.CSSStyleDeclarationSection):

6:53 PM Changeset in webkit [210755] by rniwa@webkit.org

• 23 edits in trunk/Websites/perf.webkit.org

Instrument calls to render()
​https://bugs.webkit.org/show_bug.cgi?id=167037

Reviewed by Sam Weinig.

Wrap every call to render() by newly added ComponentBase.updateRendering() to instrument it.
Also, use arrow functions instead of this.render.bind or regular closures for simplicity.

Currently, we're making 5100 calls to render() while opening the summary page, and that's way too high.

• public/v3/components/analysis-results-viewer.js:

(AnalysisResultsViewer.prototype._expandBetween):

• public/v3/components/bar-graph-group.js:

(BarGraphGroup.prototype.updateGroupRendering): Renamed form render() as BarGraphGroup is not a component.

• public/v3/components/base.js:

(ComponentBase.prototype.updateRendering): Added. Instruments render() call.

• public/v3/components/chart-pane-base.js:

(ChartPaneBase.prototype.fetchAnalysisTasks):
(ChartPaneBase.prototype._mainSelectionDidZoom):
(ChartPaneBase.prototype._updateStatus):
(ChartPaneBase.prototype._requestOpeningCommitViewer):
(ChartPaneBase.prototype._keyup):
(ChartPaneBase.prototype.render):

• public/v3/components/commit-log-viewer.js:
• public/v3/components/customizable-test-group-form.js:

(CustomizableTestGroupForm):
(CustomizableTestGroupForm.prototype._customize):

• public/v3/components/editable-text.js:

(EditableText.prototype._didUpdate):

• public/v3/components/pane-selector.js:

(PaneSelector.prototype._selectedItem):

• public/v3/components/results-table.js:

(ResultsTable.prototype.render):

• public/v3/components/time-series-chart.js:

(TimeSeriesChart._renderEnqueuedCharts):

• public/v3/pages/analysis-category-page.js:

(AnalysisCategoryPage.prototype.open):
(AnalysisCategoryPage.prototype.updateFromSerializedState):
(AnalysisCategoryPage.prototype.filterDidChange):
(AnalysisCategoryPage.prototype.render):

• public/v3/pages/analysis-task-page.js:

(AnalysisTaskChartPane.prototype._updateStatus):
(AnalysisTaskPage.prototype.updateFromSerializedState):
(AnalysisTaskPage.prototype._didFetchTask):
(AnalysisTaskPage.prototype._didFetchRelatedAnalysisTasks):
(AnalysisTaskPage.prototype._didFetchMeasurement):
(AnalysisTaskPage.prototype._didFetchTestGroups):
(AnalysisTaskPage.prototype._showAllTestGroups):
(AnalysisTaskPage.prototype._didFetchAnalysisResults):
(AnalysisTaskPage.prototype.render):
(AnalysisTaskPage.prototype._renderTestGroupList.):
(AnalysisTaskPage.prototype._renderTestGroupList):
(AnalysisTaskPage.prototype._createTestGroupListItem):
(AnalysisTaskPage.prototype._showTestGroup):
(AnalysisTaskPage.prototype._didStartEditingTaskName):
(AnalysisTaskPage.prototype._updateTaskName):
(AnalysisTaskPage.prototype._updateTestGroupName):
(AnalysisTaskPage.prototype._hideCurrentTestGroup):
(AnalysisTaskPage.prototype._updateChangeType):
(AnalysisTaskPage.prototype._associateBug):
(AnalysisTaskPage.prototype._dissociateBug):
(AnalysisTaskPage.prototype._associateCommit):
(AnalysisTaskPage.prototype._dissociateCommit):
(AnalysisTaskPage.prototype._chartSelectionDidChange):
(AnalysisTaskPage.prototype._selectedRowInAnalysisResultsViewer):

• public/v3/pages/build-request-queue-page.js:

(BuildRequestQueuePage.prototype.open.):
(BuildRequestQueuePage.prototype.open):

• public/v3/pages/chart-pane.js:

(ChartPane.prototype.setOpenRepository):
(ChartPane.prototype._trendLineTypeDidChange):
(ChartPane.prototype._updateTrendLine):

• public/v3/pages/charts-page.js:

(ChartsPage.prototype.updateFromSerializedState):
(ChartsPage.prototype._updateDomainsFromSerializedState):
(ChartsPage.prototype.setNumberOfDaysFromToolbar):
(ChartsPage.prototype._didMutatePaneList):
(ChartsPage.prototype.render):

• public/v3/pages/charts-toolbar.js:

(ChartsToolbar.prototype.render):

• public/v3/pages/create-analysis-task-page.js:

(CreateAnalysisTaskPage.prototype.updateFromSerializedState):

• public/v3/pages/dashboard-page.js:

(DashboardPage.prototype.updateFromSerializedState):
(DashboardPage.prototype._fetchedData):

• public/v3/pages/heading.js:

(Heading.prototype.render):

• public/v3/pages/page-with-heading.js:

(PageWithHeading.prototype.render):

• public/v3/pages/page.js:

(Page.prototype.open):

• public/v3/pages/summary-page.js:

(SummaryPage.prototype.open):
(SummaryPage.prototype.this._renderQueue.push):
(SummaryPage):
(SummaryPage.prototype._renderCell):

5:32 PM Changeset in webkit [210754] by Ryan Haddad

• 3 edits in trunk/LayoutTests

Marking inspector/worker/debugger-scripts.html as flaky on macOS.
​https://trac.webkit.org/changeset/209517

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:
• platform/mac/TestExpectations:

5:05 PM Changeset in webkit [210753] by Chris Dumez

• 19 edits
  3 copies
  1 add in trunk/Source

[WK2] Add diagnostic logging to measure WebGL usage
​https://bugs.webkit.org/show_bug.cgi?id=166730
<rdar://problem/29883469>

Reviewed by Alex Christensen.

Add diagnostic logging to measure high performance WebGL usage. We report
at regular intervals in which WebGL state Safari is:

• Inactive
• ActiveInForegroundTab
• ActiveInBackgroundTabOnly

This should give us an estimate of:

• What % of the time is Safari using high performance graphics
• What % of this time is only due to background tabs

Source/WebCore:

No new tests, no Web-facing behavior change.

• WebCore.xcodeproj/project.pbxproj:
• html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::create):
(WebCore::WebGLRenderingContextBase::WebGLRenderingContextBase):
(WebCore::WebGLRenderingContextBase::registerWithWebGLStateTracker):

• html/canvas/WebGLRenderingContextBase.h:
• page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::inactiveKey):
(WebCore::DiagnosticLoggingKeys::activeInForegroundTabKey):
(WebCore::DiagnosticLoggingKeys::activeInBackgroundTabOnlyKey):
(WebCore::DiagnosticLoggingKeys::stateKey):
(WebCore::WebCore::DiagnosticLoggingKeys::webGLKey):

• page/DiagnosticLoggingKeys.h:
• page/Page.cpp:

(WebCore::Page::Page):

• page/Page.h:

(WebCore::Page::webGLStateTracker):

• page/PageConfiguration.cpp:
• page/PageConfiguration.h:
• platform/WebGLStateTracker.cpp: Copied from Source/WebCore/platform/graphics/GraphicsContext3DAttributes.h.

(WebCore::WebGLStateTracker::WebGLStateTracker):
(WebCore::m_stateChangeHandler):
(WebCore::WebGLStateTracker::updateWebGLState):

• platform/WebGLStateTracker.h: Copied from Source/WebCore/platform/graphics/GraphicsContext3DAttributes.h.
• platform/graphics/GraphicsContext3DAttributes.h:

Source/WebKit2:

• UIProcess/HighPerformanceGraphicsUsageSampler.cpp: Added.

(WebKit::HighPerformanceGraphicsUsageSampler::HighPerformanceGraphicsUsageSampler):
(WebKit::HighPerformanceGraphicsUsageSampler::timerFired):

• UIProcess/HighPerformanceGraphicsUsageSampler.h: Copied from Source/WebCore/platform/graphics/GraphicsContext3DAttributes.h.
• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::setIsUsingHighPerformanceWebGL):
(WebKit::WebPageProxy::isUsingHighPerformanceWebGL):

• UIProcess/WebPageProxy.messages.in:
• UIProcess/WebProcessPool.cpp:

(WebKit::m_highPerformanceGraphicsUsageSampler):

• UIProcess/WebProcessPool.h:
• WebKit2.xcodeproj/project.pbxproj:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::m_userInterfaceLayoutDirection):

5:03 PM Changeset in webkit [210752] by Ryan Haddad

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r210735.

This change introduced LayoutTest and JSC test flakiness.

Reverted changeset:

"Reserve capacity for StringBuilder in unescape"
​https://bugs.webkit.org/show_bug.cgi?id=167008
​http://trac.webkit.org/changeset/210735

4:46 PM Changeset in webkit [210751] by Chris Dumez

• 1 edit
  8 adds in trunk/LayoutTests/imported/w3c

Import innerText/ w3c web-platform-tests
​https://bugs.webkit.org/show_bug.cgi?id=167024

Reviewed by Alex Christensen.

Import innerText/ w3c web-platform-tests from upstream 4b4b2eeb.

• web-platform-tests/innerText/getter-expected.txt: Added.
• web-platform-tests/innerText/getter-tests.js: Added.

(CSS.supports):

• web-platform-tests/innerText/getter.html: Added.
• web-platform-tests/innerText/setter-expected.txt: Added.
• web-platform-tests/innerText/setter-tests.js: Added.

(string_appeared_here.forEach):

• web-platform-tests/innerText/setter.html: Added.
• web-platform-tests/innerText/w3c-import.log: Added.

4:36 PM Changeset in webkit [210750] by Brent Fulgham

• 2 edits in trunk/Source/WebCore

Avoid nullptr frame dereference when scrollTo is called on a disconnected DOMWindow
​https://bugs.webkit.org/show_bug.cgi?id=167030
<rdar://problem/29995070>

Reviewed by Dean Jackson.

Correct DOMWindow::scrollTo to match all other functions in the class so that the it
checks that the current frame is valid before attempting to use it.

• page/DOMWindow.cpp:

(WebCore::DOMWindow::scrollTo):

4:16 PM Changeset in webkit [210749] by Chris Dumez

• 4 edits
  10 adds in trunk/LayoutTests/imported/w3c

Resync domparsing/ web-platform-tests from upstream
​https://bugs.webkit.org/show_bug.cgi?id=167023

Reviewed by Alex Christensen.

Resync domparsing/ web-platform-tests from upstream 4b4b2eeb.

• web-platform-tests/domparsing/DOMParser-parseFromString-xml-doctype-expected.txt: Added.
• web-platform-tests/domparsing/DOMParser-parseFromString-xml-doctype.html: Added.
• web-platform-tests/domparsing/DOMParser-parseFromString-xml-expected.txt: Added.
• web-platform-tests/domparsing/DOMParser-parseFromString-xml.html: Added.
• web-platform-tests/domparsing/XMLSerializer-serializeToString-expected.txt: Added.
• web-platform-tests/domparsing/XMLSerializer-serializeToString.html: Added.
• web-platform-tests/domparsing/createContextualFragment-expected.txt:
• web-platform-tests/domparsing/createContextualFragment.html:
• web-platform-tests/domparsing/insert_adjacent_html-xhtml-expected.txt: Added.
• web-platform-tests/domparsing/insert_adjacent_html-xhtml.xhtml: Added.
• web-platform-tests/domparsing/style_attribute_html-expected.txt: Added.
• web-platform-tests/domparsing/style_attribute_html.html: Added.
• web-platform-tests/domparsing/w3c-import.log:

3:46 PM Changeset in webkit [210748] by jer.noble@apple.com

• 2 edits in trunk/Source/WebCore

Use a strong reference when calling callOnMainThread to schedule events in AudioScheduledSourceNode.
​https://bugs.webkit.org/show_bug.cgi?id=166983

Reviewed by Brent Fulgham.

• Modules/webaudio/AudioScheduledSourceNode.cpp:

(WebCore::AudioScheduledSourceNode::finish):

• Modules/webaudio/AudioScheduledSourceNode.h:

3:42 PM Changeset in webkit [210747] by jer.noble@apple.com

• 5 edits in trunk/Source/WebCore

Protect MediaPlayer from being destroyed mid-load()
​https://bugs.webkit.org/show_bug.cgi?id=166976

Reviewed by Eric Carlson.

It's possible for a message sent by MediaPlayer to HTMLMediaElement to cause
MediaPlayer to be destroyed before MediaPlayer::load() completes. We have
previously protected against this same problem in HTMLMediaElement::loadResource()
by ref'ing at the beginning of the function and deref'ing on exit. To do the
same in MediaPlayer, it must become RefCounted.

To keep the same semantics about m_client in MediaPlayer (always available without
requiring a null-check), make a new static MediaPlayerClient object which can
replace the real (HTMLMediaElement) client when the MediaPlayer is invalidated.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::clearMediaPlayer):
(WebCore::HTMLMediaElement::createMediaPlayer):

• html/HTMLMediaElement.h:
• platform/graphics/MediaPlayer.cpp:

(WebCore::nullMediaPlayerClient):
(WebCore::MediaPlayer::create):
(WebCore::MediaPlayer::MediaPlayer):
(WebCore::MediaPlayer::invalidate):
(WebCore::MediaPlayer::load):
(WebCore::MediaPlayer::loadWithNextMediaEngine):
(WebCore::MediaPlayer::inMediaDocument):
(WebCore::MediaPlayer::fullscreenMode):
(WebCore::MediaPlayer::requestedRate):
(WebCore::MediaPlayer::currentPlaybackTargetIsWirelessChanged):
(WebCore::MediaPlayer::networkStateChanged):
(WebCore::MediaPlayer::readyStateChanged):
(WebCore::MediaPlayer::volumeChanged):
(WebCore::MediaPlayer::muteChanged):
(WebCore::MediaPlayer::timeChanged):
(WebCore::MediaPlayer::sizeChanged):
(WebCore::MediaPlayer::repaint):
(WebCore::MediaPlayer::durationChanged):
(WebCore::MediaPlayer::rateChanged):
(WebCore::MediaPlayer::playbackStateChanged):
(WebCore::MediaPlayer::firstVideoFrameAvailable):
(WebCore::MediaPlayer::characteristicChanged):
(WebCore::MediaPlayer::cachedKeyForKeyId):
(WebCore::MediaPlayer::keyNeeded):
(WebCore::MediaPlayer::mediaKeysStorageDirectory):
(WebCore::MediaPlayer::referrer):
(WebCore::MediaPlayer::userAgent):
(WebCore::MediaPlayer::graphicsDeviceAdapter):
(WebCore::MediaPlayer::cachedResourceLoader):
(WebCore::MediaPlayer::createResourceLoader):
(WebCore::MediaPlayer::addAudioTrack):
(WebCore::MediaPlayer::removeAudioTrack):
(WebCore::MediaPlayer::addTextTrack):
(WebCore::MediaPlayer::removeTextTrack):
(WebCore::MediaPlayer::addVideoTrack):
(WebCore::MediaPlayer::removeVideoTrack):
(WebCore::MediaPlayer::outOfBandTrackSources):
(WebCore::MediaPlayer::shouldWaitForResponseToAuthenticationChallenge):
(WebCore::MediaPlayer::handlePlaybackCommand):
(WebCore::MediaPlayer::sourceApplicationIdentifier):
(WebCore::MediaPlayer::preferredAudioCharacteristics):
(WebCore::MediaPlayer::doesHaveAttribute):
(WebCore::MediaPlayer::mediaPlayerNetworkInterfaceName):
(WebCore::MediaPlayer::getRawCookies):
(WebCore::MediaPlayer::shouldDisableSleep):

• platform/graphics/MediaPlayer.h:

(WebCore::MediaPlayer::platformVolumeConfigurationRequired):
(WebCore::MediaPlayer::client):

3:39 PM Changeset in webkit [210746] by ggaren@apple.com

• 12 edits
  2 adds in trunk/Source/bmalloc

bmalloc: Use a separate zone when using system malloc
​https://bugs.webkit.org/show_bug.cgi?id=167014

Reviewed by Filip Pizlo.

Harris asked for this so he could separate Safari and WebKit memory use
when doing memory analysis.

This patch adds an explicit DebugHeap class that contains all our
code for specialized allocation with debugging.

• bmalloc.xcodeproj/project.pbxproj:

• bmalloc/Allocator.cpp:

(bmalloc::Allocator::Allocator):
(bmalloc::Allocator::tryAllocate):
(bmalloc::Allocator::allocateImpl):
(bmalloc::Allocator::reallocate):
(bmalloc::Allocator::allocateSlowCase):

• bmalloc/Allocator.h: Forward to DebugHeap instead of inlining all the

code. This is required for our new interface, and it is also a nice
simplification that moves some not-very-important code out of the way.

• bmalloc/Deallocator.cpp:

(bmalloc::Deallocator::Deallocator):
(bmalloc::Deallocator::scavenge):
(bmalloc::Deallocator::deallocateSlowCase):

• bmalloc/Deallocator.h: Ditto.

• bmalloc/DebugHeap.cpp: Added.

(bmalloc::DebugHeap::DebugHeap):
(bmalloc::DebugHeap::malloc):
(bmalloc::DebugHeap::memalign):
(bmalloc::DebugHeap::realloc):
(bmalloc::DebugHeap::free):

• bmalloc/DebugHeap.h: Added. New class for overriding normal heap

behavior. Right now, it just adds a malloc zone and then forwards to
system malloc -- but we can add lots more kinds of debug heaps in the
future if we find them useful.

• bmalloc/Environment.cpp:

(bmalloc::Environment::Environment):
(bmalloc::Environment::computeIsDebugHeapEnabled):
(bmalloc::Environment::computeIsBmallocEnabled): Deleted.

• bmalloc/Environment.h:

(bmalloc::Environment::isDebugHeapEnabled):
(bmalloc::Environment::isBmallocEnabled): Deleted. Renamed everything to
reflect our new use of DebugHeap.

• bmalloc/Heap.cpp:

(bmalloc::Heap::Heap):

• bmalloc/Heap.h:

(bmalloc::Heap::debugHeap): Updated to use DebugHeap.
(bmalloc::Heap::environment): Deleted.

• bmalloc/bmalloc.h:

(bmalloc::api::isEnabled): Updated to use DebugHeap.

3:30 PM Changeset in webkit [210745] by sbarati@apple.com

• 5 edits in trunk/Source/JavaScriptCore

Initialize the ArraySpecies watchpoint as Clear and transition to IsWatched once slice is called for the first time
​https://bugs.webkit.org/show_bug.cgi?id=167017
<rdar://problem/30019309>

Reviewed by Keith Miller and Filip Pizlo.

This patch is to reverse the JSBench regression from r210695.

The new state diagram for the array species watchpoint is as
follows:

1. On GlobalObject construction, it starts life out as ClearWatchpoint.
2. When slice is called for the first time, we observe the state

of the world, and either transition it to IsWatched if we were able
to set up the object property conditions, or to IsInvalidated if we
were not.

3. The DFG compiler will now only lower slice as an intrinsic if

it observed the speciesWatchpoint.state() as IsWatched.

4. The IsWatched => IsInvalidated transition happens only when

one of the object property condition watchpoints fire.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicCall):

• runtime/ArrayPrototype.cpp:

(JSC::speciesWatchpointIsValid):
(JSC::speciesConstructArray):
(JSC::arrayProtoPrivateFuncConcatMemcpy):
(JSC::ArrayPrototype::tryInitializeSpeciesWatchpoint):
(JSC::ArrayPrototype::initializeSpeciesWatchpoint): Deleted.

• runtime/ArrayPrototype.h:
• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::JSGlobalObject):
(JSC::JSGlobalObject::init):

3:02 PM Changeset in webkit [210744] by matthew_hanson@apple.com

• 5 edits in branches/safari-603-branch/Source

Versioning.

3:01 PM Changeset in webkit [210743] by matthew_hanson@apple.com

• 1 copy in tags/Safari-603.1.20

New tag.

1:27 PM Changeset in webkit [210742] by eric.carlson@apple.com

• 12 edits
  1 copy
  3 adds in trunk

[MediaStream, Mac] Add mock audio source
​https://bugs.webkit.org/show_bug.cgi?id=166974

Reviewed by Jer Noble.
Source/WebCore:

Add a mock audio source for testing media streams.

No new tests, updated webaudio/mediastreamaudiosourcenode.html.

• WebCore.xcodeproj/project.pbxproj:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::enqueueAudioSample):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::enqueueVideoSample):

• platform/mediastream/mac/AVAudioCaptureSource.h:

(WebCore::AVAudioCaptureSource::Observer::~Observer): Deleted.

• platform/mediastream/mac/AVAudioCaptureSource.mm:

(WebCore::AVAudioCaptureSource::addObserver):
(WebCore::AVAudioCaptureSource::removeObserver):
(WebCore::AVAudioCaptureSource::start):

• platform/mediastream/mac/MockRealtimeAudioSourceMac.h: Added.
• platform/mediastream/mac/MockRealtimeAudioSourceMac.mm: Added.

(WebCore::MockRealtimeAudioSource::create):
(WebCore::MockRealtimeAudioSourceMac::MockRealtimeAudioSourceMac):
(WebCore::MockRealtimeAudioSource::createMuted):
(WebCore::MockRealtimeAudioSourceMac::addObserver):
(WebCore::MockRealtimeAudioSourceMac::removeObserver):
(WebCore::MockRealtimeAudioSourceMac::start):
(WebCore::MockRealtimeAudioSourceMac::emitSampleBuffers):
(WebCore::MockRealtimeAudioSourceMac::reconfigure):
(WebCore::MockRealtimeAudioSourceMac::render):
(WebCore::MockRealtimeAudioSourceMac::applySampleRate):
(WebCore::MockRealtimeAudioSourceMac::audioSourceProvider):

• platform/mediastream/mac/WebAudioSourceProviderAVFObjC.h:
• platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm:

(WebCore::WebAudioSourceProviderAVFObjC::create):
(WebCore::WebAudioSourceProviderAVFObjC::WebAudioSourceProviderAVFObjC):
(WebCore::WebAudioSourceProviderAVFObjC::~WebAudioSourceProviderAVFObjC):
(WebCore::WebAudioSourceProviderAVFObjC::provideInput):
(WebCore::WebAudioSourceProviderAVFObjC::setClient):
(WebCore::WebAudioSourceProviderAVFObjC::startProducingData): Deleted.
(WebCore::WebAudioSourceProviderAVFObjC::stopProducingData): Deleted.

• platform/mock/MockRealtimeAudioSource.cpp:

(WebCore::MockRealtimeAudioSource::MockRealtimeAudioSource):
(WebCore::MockRealtimeAudioSource::startProducingData):
(WebCore::MockRealtimeAudioSource::stopProducingData):
(WebCore::MockRealtimeAudioSource::elapsedTime):
(WebCore::MockRealtimeAudioSource::tick):

• platform/mock/MockRealtimeAudioSource.h:

(WebCore::MockRealtimeAudioSource::render):
(WebCore::MockRealtimeAudioSource::renderInterval):
(WebCore::MockRealtimeAudioSource::~MockRealtimeAudioSource): Deleted.

LayoutTests:

• webaudio/mediastreamaudiosourcenode-expected.txt:
• webaudio/mediastreamaudiosourcenode.html:

1:19 PM Changeset in webkit [210741] by weinig@apple.com

• 22 edits
  2 deletes in trunk

[WebIDL] Remove custom bindings for DeviceMotionEvent and DeviceOrientationEvent
​https://bugs.webkit.org/show_bug.cgi?id=167006

Reviewed by Geoffrey Garen.

Source/WebCore:

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSBindingsAllInOne.cpp:
• bindings/js/JSDeviceMotionEventCustom.cpp: Removed.
• bindings/js/JSDeviceOrientationEventCustom.cpp: Removed.

Remove Custom bindings files.

• dom/DeviceMotionData.cpp:

(WebCore::DeviceMotionData::create):
(WebCore::DeviceMotionData::DeviceMotionData):
(WebCore::DeviceMotionData::Acceleration::create): Deleted.
(WebCore::DeviceMotionData::Acceleration::Acceleration): Deleted.
(WebCore::DeviceMotionData::RotationRate::create): Deleted.
(WebCore::DeviceMotionData::RotationRate::RotationRate): Deleted.

• dom/DeviceMotionData.h:

(WebCore::DeviceMotionData::Acceleration::create):
(WebCore::DeviceMotionData::Acceleration::x):
(WebCore::DeviceMotionData::Acceleration::y):
(WebCore::DeviceMotionData::Acceleration::z):
(WebCore::DeviceMotionData::Acceleration::Acceleration):
(WebCore::DeviceMotionData::RotationRate::create):
(WebCore::DeviceMotionData::RotationRate::alpha):
(WebCore::DeviceMotionData::RotationRate::beta):
(WebCore::DeviceMotionData::RotationRate::gamma):
(WebCore::DeviceMotionData::RotationRate::RotationRate):
(WebCore::DeviceMotionData::interval):
(WebCore::DeviceMotionData::Acceleration::canProvideX): Deleted.
(WebCore::DeviceMotionData::Acceleration::canProvideY): Deleted.
(WebCore::DeviceMotionData::Acceleration::canProvideZ): Deleted.
(WebCore::DeviceMotionData::RotationRate::canProvideAlpha): Deleted.
(WebCore::DeviceMotionData::RotationRate::canProvideBeta): Deleted.
(WebCore::DeviceMotionData::RotationRate::canProvideGamma): Deleted.
(WebCore::DeviceMotionData::canProvideInterval): Deleted.
Re-work using std::optional rather than an explicit bool/value pair.

• dom/DeviceMotionEvent.cpp:

(WebCore::convert):
(WebCore::DeviceMotionEvent::acceleration):
(WebCore::DeviceMotionEvent::accelerationIncludingGravity):
(WebCore::DeviceMotionEvent::rotationRate):
(WebCore::DeviceMotionEvent::interval):
(WebCore::DeviceMotionEvent::initDeviceMotionEvent):

• dom/DeviceMotionEvent.h:

Implement IDL interface. For now, we have duplicate structs for
Acceleration and RotationRate (one here, one in DeviceMotionData)
which can be consolidated in the future.

• dom/DeviceMotionEvent.idl:

Add dictionaries for Acceleration and RotationRate, and update IDL to
specify the correct nullability of attributes and arguments.

• dom/DeviceOrientationData.cpp:

(WebCore::DeviceOrientationData::create):
(WebCore::DeviceOrientationData::DeviceOrientationData):
(WebCore::DeviceOrientationData::alpha): Deleted.
(WebCore::DeviceOrientationData::beta): Deleted.
(WebCore::DeviceOrientationData::gamma): Deleted.
(WebCore::DeviceOrientationData::absolute): Deleted.
(WebCore::DeviceOrientationData::canProvideAlpha): Deleted.
(WebCore::DeviceOrientationData::canProvideBeta): Deleted.
(WebCore::DeviceOrientationData::canProvideGamma): Deleted.
(WebCore::DeviceOrientationData::compassHeading): Deleted.
(WebCore::DeviceOrientationData::compassAccuracy): Deleted.
(WebCore::DeviceOrientationData::canProvideCompassHeading): Deleted.
(WebCore::DeviceOrientationData::canProvideCompassAccuracy): Deleted.
(WebCore::DeviceOrientationData::canProvideAbsolute): Deleted.

• dom/DeviceOrientationData.h:

(WebCore::DeviceOrientationData::create):
(WebCore::DeviceOrientationData::alpha):
(WebCore::DeviceOrientationData::beta):
(WebCore::DeviceOrientationData::gamma):
(WebCore::DeviceOrientationData::compassHeading):
(WebCore::DeviceOrientationData::compassAccuracy):
(WebCore::DeviceOrientationData::absolute):
Re-work using std::optional rather than an explicit bool/value pair.

• dom/DeviceOrientationEvent.cpp:

(WebCore::DeviceOrientationEvent::alpha):
(WebCore::DeviceOrientationEvent::beta):
(WebCore::DeviceOrientationEvent::gamma):
(WebCore::DeviceOrientationEvent::compassHeading):
(WebCore::DeviceOrientationEvent::compassAccuracy):
(WebCore::DeviceOrientationEvent::initDeviceOrientationEvent):
(WebCore::DeviceOrientationEvent::absolute):

• dom/DeviceOrientationEvent.h:

Implement IDL interface.

• dom/DeviceOrientationEvent.idl:

Update IDL to specify the correct nullability of attributes and arguments.

• platform/ios/DeviceMotionClientIOS.mm:

(WebCore::DeviceMotionClientIOS::motionChanged):

• platform/ios/DeviceOrientationClientIOS.mm:

(WebCore::DeviceOrientationClientIOS::orientationChanged):
Update for use of std:optional.

Source/WebKit/mac:

• WebView/WebDeviceOrientation.mm:

(convert):
(-[WebDeviceOrientation initWithCanProvideAlpha:alpha:canProvideBeta:beta:canProvideGamma:gamma:]):
Update for new use of std::optional.

LayoutTests:

• fast/dom/DeviceMotion/optional-event-properties-expected.txt:
• fast/dom/DeviceMotion/script-tests/optional-event-properties.js:

Update test to account for slightly stricter, but more consistent IDL conversion rules.

12:53 PM Changeset in webkit [210740] by zandobersek@gmail.com

• 4 edits in trunk/Source/WebCore

[GStreamer] Cache the accelerated capability of MediaPlayerClient in MediaPlayerPrivateGStreamerBase
​https://bugs.webkit.org/show_bug.cgi?id=167015

Reviewed by Jer Noble.

In MediaPlayerPrivateGStreamerBase, avoid continuously querying the MediaPlayerClient
object about the accelerated compositing capabilities. Instead, cache this information
when creating the video sink (which is most affected by this information anyway), storing
it in a new protected boolean member variable in the MediaPlayerPrivateGStreamerBase class.

All calls to MediaPlayerClient::mediaPlayerRenderingCanBeAccelerated() and
MediaPlayerClient::mediaPlayerAcceleratedCompositingEnabled() are replaced by tests
on the value of this new member variable.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::naturalSize):
(WebCore::MediaPlayerPrivateGStreamerBase::repaint):
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
(WebCore::MediaPlayerPrivateGStreamerBase::paint):
(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:

11:18 AM Changeset in webkit [210739] by matthew_hanson@apple.com

• 12 edits in branches/safari-603-branch/Source/WebKit2

Roll out r209189 via r210726. rdar://problem/29428877

11:18 AM Changeset in webkit [210738] by matthew_hanson@apple.com

• 9 edits in branches/safari-603-branch/Source/JavaScriptCore

Merge r210694. rdar://problem/29983526

11:16 AM Changeset in webkit [210737] by commit-queue@webkit.org

• 7 edits in trunk/Source/WebKit2

Defer use of autoplay heuristics to clients
​https://bugs.webkit.org/show_bug.cgi?id=167010

Patch by Matt Rajca <​mrajca@apple.com> on 2017-01-13
Reviewed by Alex Christensen.

Switch the autoplay policy tristate to an on/off option since clients should run any
heuristics and simply send their final decision to WebKit.

• Shared/WebsitePolicies.h:

(WebKit::WebsitePolicies::encode):
(WebKit::WebsitePolicies::decode):

• UIProcess/API/APIWebsitePolicies.h:
• UIProcess/API/C/WKWebsitePolicies.cpp:

(WKWebsitePoliciesGetAutoplayEnabled):
(WKWebsitePoliciesSetAutoplayEnabled):
(WKWebsitePoliciesGetAutoplayPolicy): Replaced.
(WKWebsitePoliciesSetAutoplayPolicy): Replaced.

• UIProcess/API/C/WKWebsitePolicies.h:
• UIProcess/API/Cocoa/_WKWebsitePolicies.h:
• UIProcess/API/Cocoa/_WKWebsitePolicies.mm:

(-[_WKWebsitePolicies setAutoplayEnabled:]):
(-[_WKWebsitePolicies autoplayEnabled]):
(-[_WKWebsitePolicies setAutoplayPolicy:]): Replaced.
(-[_WKWebsitePolicies autoplayPolicy]): Replaced.

11:00 AM Changeset in webkit [210736] by Yusuke Suzuki

• 2 edits in trunk/Tools

run-jsc-benchmarks' echo should have -e option
​https://bugs.webkit.org/show_bug.cgi?id=167009

Reviewed by Sam Weinig.

echo requires -e option to use escape sequence.
Without it, in some environment (in my Fedora 25), the escape sequence is not
recognized and just dumped as \c etc.

• Scripts/run-jsc-benchmarks:

10:30 AM Changeset in webkit [210735] by Yusuke Suzuki

• 2 edits in trunk/Source/JavaScriptCore

Reserve capacity for StringBuilder in unescape
​https://bugs.webkit.org/show_bug.cgi?id=167008

Reviewed by Sam Weinig.

unescape function is frequently called in Kraken sha256-iterative.
This patch just reserves the capacity for the StringBuilder.

Currently, we select the length of the string for the reserved capacity.
It improves the performance 2.73%.

Benchmark report for Kraken on sakura-trick.

VMs tested:
"baseline" at /home/yusukesuzuki/dev/WebKit/WebKitBuild/untot/Release/bin/jsc
"patched" at /home/yusukesuzuki/dev/WebKit/WebKitBuild/un/Release/bin/jsc

Collected 100 samples per benchmark/VM, with 100 VM invocations per benchmark. Emitted a call to gc() between
sample measurements. Used 1 benchmark iteration per VM invocation for warm-up. Used the jsc-specific preciseTime()
function to get microsecond-level timing. Reporting benchmark execution times with 95% confidence intervals in
milliseconds.

baseline patched

stanford-crypto-sha256-iterative 51.609+-0.672 50.237+-0.860 might be 1.0273x faster

<arithmetic> 51.609+-0.672 50.237+-0.860 might be 1.0273x faster

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncUnescape):

10:09 AM Changeset in webkit [210734] by Michael Catanzaro

• 2 edits in trunk

[CMake] Clean up SHARED_CORE option
​https://bugs.webkit.org/show_bug.cgi?id=167004

Reviewed by Alex Christensen.

• CMakeLists.txt:

9:54 AM Changeset in webkit [210733] by Chris Dumez

• 10 edits
  3 adds in trunk/Source/WebCore

Report post-page load CPU usage using diagnostic logging
​https://bugs.webkit.org/show_bug.cgi?id=166950
<rdar://problem/30014496>

Reviewed by Alex Christensen.

Shortly after page load (5 seconds), we measure the WebContent process'
CPU usage over 10 seconds and report the percentage back via release
logging. We also log the percentage using diagnostic logging using the
following buckets:

• Below 10%
• 10 to 20%
• 20 to 40%
• 60 to 80%
• Over 80%

The logging works on both Mac and iOS. I verified that I get results
consistent with Activity Monitor or top.

No new tests, no Web-facing behavior change, only extra logging.

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:
• loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkLoadCompleteForThisFrame):

• page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::postPageLoadKey):
(WebCore::DiagnosticLoggingKeys::cpuUsageKey):

• page/DiagnosticLoggingKeys.h:
• page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::didFinishLoad):
(WebCore::cpuUsageToDiagnosticLogginKey):
(WebCore::Page::measurePostLoadCPUUsage):

• page/Page.h:
• page/Settings.cpp:

(WebCore::Settings::isPostLoadCPUUsageMeasurementEnabled):

• page/Settings.h:
• platform/CPUTime.cpp: Added.

(WebCore::getCPUTime):
(WebCore::CPUTime::percentageCPUUsageSince):

• platform/CPUTime.h: Added.
• platform/cocoa/CPUTimeCocoa.mm: Added.

(WebCore::timeValueToMicroseconds):
(WebCore::getCPUTime):

9:54 AM Changeset in webkit [210732] by Michael Catanzaro

• 5 edits in trunk/Source/WebCore

Unreviewed, rolling out r210677.
​https://bugs.webkit.org/show_bug.cgi?id=167007

Caused many layout test timeouts on GTK+ bots

Reverted changeset:

"Protect MediaPlayer from being destroyed mid-load()"
​https://bugs.webkit.org/show_bug.cgi?id=166976
​http://trac.webkit.org/changeset/210677

9:23 AM Changeset in webkit [210731] by Konstantin Tokarev

• 2 edits in trunk/Source/WebCore

Added preprocessor guard for iOS-specific piece of code in GraphicsContext3DOpenGL
​https://bugs.webkit.org/show_bug.cgi?id=167005

Reviewed by Alex Christensen.

Variable "boundFrameBuffer" is used only in iOS-specific code

No new tests needed.

• platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary):

6:26 AM Changeset in webkit [210730] by eric.carlson@apple.com

• 6 edits in trunk

REGRESSION (r210621): [mac-wk2] LayoutTest fast/mediastream/MediaStream-video-element-video-tracks-disabled-then-enabled.html timing out
​https://bugs.webkit.org/show_bug.cgi?id=166980
Source/WebCore:

Unreviewed, fix test broken by r210621.

No new tests, updated fast/mediastream/MediaStream-video-element-video-tracks-disabled-then-enabled.html
and results.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(-[WebAVSampleBufferStatusChangeListener observeValueForKeyPath:ofObject:change:context:]):

Drive-by fix: null-check parent.

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::layerStatusDidChange): Do nothing if the layer

has changed since the KVO notification.

LayoutTests:

Unreviewed, fix test broken by r210621.

• fast/mediastream/MediaStream-video-element-video-tracks-disabled-then-enabled-expected.txt:
• fast/mediastream/MediaStream-video-element-video-tracks-disabled-then-enabled.html:
• platform/mac-wk2/TestExpectations: Un-skip fixed test.

12:24 AM Changeset in webkit [210729] by Carlos Garcia Campos

• 16 edits
  1 delete in trunk/Source

[SOUP] Simplify cookie storage handling
​https://bugs.webkit.org/show_bug.cgi?id=166967

Reviewed by Sergio Villar Senin.

Source/WebCore:

We currently have a global cookie storage, and several create() methods in SoupNetworkSession to create sessions
with different cookie jars. This could be simplified by moving the cookie storage handling to
NetworkStorageSession and removing all create() methods from SoupNetworkSession. This patch also removes the
default SoupNetworkSession in favor of using the default NetworkStorageSession.

• platform/network/NetworkStorageSession.h: Add a default cookie storage to be used when the

NetworkStorageSession doesn't have a platform soup session.

• platform/network/soup/CookieJarSoup.cpp: Remove the global cookie storage handling.

(WebCore::setCookiesFromDOM): Use NetworkStorageSession::cookieStorage() instead.
(WebCore::cookiesForSession): Ditto.
(WebCore::cookiesEnabled): Check the policy instead like all other ports do, since now we will always have a
default shared cookie jar.
(WebCore::getRawCookies): Use NetworkStorageSession::cookieStorage() instead.
(WebCore::deleteCookie): Ditto.
(WebCore::addCookie): Ditto.
(WebCore::getHostnamesWithCookies): Ditto.
(WebCore::deleteCookiesForHostnames): Ditto.
(WebCore::deleteAllCookies): Ditto.

• platform/network/soup/CookieJarSoup.h: Removed.
• platform/network/soup/CookieStorageSoup.cpp:

(WebCore::soupCookiesChanged): Use the cookie storage from the NetworkStorageSession::defaultStorageSession().
(WebCore::startObservingCookieChanges): Ditto.
(WebCore::stopObservingCookieChanges): Ditto.

• platform/network/soup/DNSSoup.cpp:

(WebCore::DNSResolveQueue::updateIsUsingProxy): Get the SoupSession from the NetworkStorageSession::defaultStorageSession().
(WebCore::DNSResolveQueue::platformResolve): Ditto.

• platform/network/soup/NetworkStorageSessionSoup.cpp:

(WebCore::NetworkStorageSession::NetworkStorageSession):
(WebCore::NetworkStorageSession::ensurePrivateBrowsingSession): Create a new SoupNetworkSession without
providing a cookie storage to ensure it creates its own private one.
(WebCore::NetworkStorageSession::switchToNewTestingSession): Ditto.
(WebCore::NetworkStorageSession::soupNetworkSession): Create the SoupNetworkSession on demand passing the global
shared cookie storage.
(WebCore::NetworkStorageSession::cookieStorage): Return the cookie storage from the SoupNetworkSession if we
have one, otherwise create the global shared one and return it.

• platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::sessionFromContext): Get the SoupSession from the NetworkStorageSession::defaultStorageSession().

• platform/network/soup/SoupNetworkSession.cpp:

(WebCore::SoupNetworkSession::SoupNetworkSession): Remove all create methods and the unused constructor that
receives a SoupSession. Allow to pass a nullptr SoupCookieJar and create one in such case.

• platform/network/soup/SoupNetworkSession.h:

Source/WebKit2:

Get the SoupSession from NetworkStorageSession::defaultStorageSession().

• NetworkProcess/CustomProtocols/soup/CustomProtocolManagerSoup.cpp:

(WebKit::CustomProtocolManager::registerScheme): Get the SoupSession from NetworkStorageSession::defaultStorageSession().

• NetworkProcess/efl/NetworkProcessMainEfl.cpp: Ditto.
• NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::userPreferredLanguagesChanged): Ditto.
(WebKit::NetworkProcess::platformInitializeNetworkProcess): SoupNetworkSession::clearOldSoupCache is static.

• WebProcess/Cookies/soup/WebCookieManagerSoup.cpp:

(WebKit::WebCookieManager::platformGetHTTPCookieAcceptPolicy): Use the cookie storage from NetworkStorageSession::defaultStorageSession().
(WebKit::WebCookieManager::setCookiePersistentStorage): Ditto.

• WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:

(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts): Ditto.

• WebProcess/efl/WebProcessMainEfl.cpp:

12:17 AM Changeset in webkit [210728] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit2

[SOUP] Do not use the legacy session ID in WebFrameNetworkingContext::storageSession()
​https://bugs.webkit.org/show_bug.cgi?id=166970

Reviewed by Sergio Villar Senin.

Get the session for the current page instead.

• WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:

(WebKit::WebFrameNetworkingContext::storageSession):