Context Navigation

← Previous Period
Next Period →

Timeline

Jan 21, 2017:

10:44 PM Changeset in webkit [211025] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

REGRESSION (r210959): LayoutTest fast/mediastream/MediaStream-video-element-video-tracks-disabled.html is failing
https://bugs.webkit.org/show_bug.cgi?id=167260

Unreviewed test gardening.

Since this test checks against a black frame as its expected output, we need to use the legacy
media controls so that there is no start button.

Patch by Antoine Quint <Antoine Quint> on 2017-01-21

fast/mediastream/MediaStream-video-element-video-tracks-disabled.html:
platform/mac-wk2/TestExpectations:

9:48 PM Changeset in webkit [211024] by Chris Dumez

9 edits
9 adds in trunk

JavaScript for-of does not work on a lot of collection types (e.g. HTMLCollection)
https://bugs.webkit.org/show_bug.cgi?id=167091

Reviewed by Darin Adler.

Source/JavaScriptCore:

Update Array methods to throw a TypeError when (this === null

this === undefined)

instead of when (this == null). This is because (this == null) returns true for types
that masquerades as undefined (such as document.all) and this prevented use of the
Array API on such types. The specification only stays to use ToObject(), which throws
when the input is undefined or null.

The corresponding specification is at:

builtins/ArrayPrototype.js:

(values):
(keys):
(entries):
(reduce):
(reduceRight):
(every):
(forEach):
(filter):
(map):
(some):
(fill):
(find):
(findIndex):
(includes):
(sort):
(concatSlowPath):
(copyWithin):

Source/WebCore:

As per the Web IDL specification [1], https://heycam.github.io/webidl/#es-iterator
an interface should get an iterator if it has:

an indexed property getter and an integer-typed attribute named "length".

We now comply with this part of the Web IDL specification. This adds an iterator
to the following interfaces:

AudioTrackList, ClientRectList, CSSRuleList, CSSStyleDeclaration, CSSValueList, MimeTypeArray, WebKitNamedFlowCollection, Plugin, PluginArray, DOMStringList, FileList, HTMLAllCollection, HTMLCollection, HTMLFormElement, HTMLOptionsCollection, HTMLSelectElement, MediaList, NamedNodeMap, SourceBufferList, StyleSheetList, TextTrackCueList, TextTrackList, TouchList, VideoTrackList, VTTRegionList.

As a result, it is now possible to use for ... of for those types.

Tests: fast/dom/FileList-iterator.html

fast/dom/collection-iterators.html
fast/dom/document-all-undefined.html
fast/events/touch/ios/touchlist-iterator.html

bindings/scripts/CodeGeneratorJS.pm:

(GetAttributeWithName):
(InterfaceNeedsIterator):
(GenerateImplementation):
(addIterableProperties):

LayoutTests:

fast/dom/FileList-iterator-expected.txt: Added.
fast/dom/FileList-iterator.html: Added.
fast/dom/collection-iterators-expected.txt: Added.
fast/dom/collection-iterators.html: Added.
fast/events/touch/ios/touchlist-iterator-expected.txt: Added.
fast/events/touch/ios/touchlist-iterator.html: Added.

Add layout test coverage for all types that gained an iterator.

fast/dom/document-all-undefined-expected.txt: Added.
fast/dom/document-all-undefined.html: Added.

Add layout test to cover the fact that HTMLAllCollection masquerades as
undefined, as per:

https://html.spec.whatwg.org/multipage/obsolete.html#dom-document-all

inspector/model/remote-object-get-properties-expected.txt:

Rebaseline now that there is an extra Symbol.iterator property.

platform/wk2/TestExpectations:

Skip that requires beginDragWithFiles() as this is unimplemented in
WebKitTestRunner.

9:19 PM Changeset in webkit [211023] by Chris Dumez

11 edits in trunk

innerText should replace existing text node
https://bugs.webkit.org/show_bug.cgi?id=167116

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline existing test now that one more check is passing.

web-platform-tests/innerText/setter-expected.txt:

Source/WebCore:

Update setInnerText() to use ContainerNode::replaceAllChildren()
instead of replaceChildrenWithText(). replaceAllChildren() is
implemented as per specification:

As a result, we now correctly remove existing children before
inserting the new one.

No new tests, updated existing one.

editing/markup.cpp:

(WebCore::replaceChildrenWithText): Deleted.

editing/markup.h:
html/HTMLElement.cpp:

(WebCore::HTMLElement::setInnerText):

LayoutTests:

accessibility/mac/aria-liveregions-changedtext.html:

The text is using innerText and changed behavior now that we stopped
reusing the existing Text child. Code in RenderObject::willBeDestroyed()
is supposed to call AXObjectCache::childrenChanged(parent()) to fire
the AXLiveRegionChanged notification. However, it did not because the
parent renderer did not have an associated AccessibilityObject.

fast/dom/HTMLElement/set-inner-outer-optimization.html:

Update existing test which expected the non spec-compliant Text child
optimization.

fast/repaint/vertical-text-repaint-expected.txt:
fast/repaint/vertical-text-repaint.html:

Update / rebaseline test. We now repaint each 80x80 rectangle instead of
only repainting the text rects because we remove the Text node then add
a new one instead of only updating the existing Text node's test. The
output looks exactly the same otherwise.

6:29 PM Changeset in webkit [211022] by Chris Dumez

5 edits in trunk

AccessibilityRenderObject::textChanged() bypasses AXLiveRegionChanged notification coalescing
https://bugs.webkit.org/show_bug.cgi?id=167286
<rdar://problem/30133211>

Reviewed by Ryosuke Niwa.

Source/WebCore:

AccessibilityRenderObject::textChanged() bypasses AXLiveRegionChanged notification
coalescing. This patch fixes the issue.

No new tests, updated existing test.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textChanged):

LayoutTests:

Update test to use a longer timer delay. When using this longer delay, we were getting 4
AXLiveRegionChanged notifications instead of the expected 2 because
AccessibilityRenderObject::textChanged() was bypassing AXLiveRegionChanged notification
coalescing.

accessibility/mac/aria-multiple-liveregions-notification-expected.txt:
accessibility/mac/aria-multiple-liveregions-notification.html:

6:16 PM Changeset in webkit [211021] by Simon Fraser

3 edits in trunk/Source/WebKit/mac

Remove -[WebFrame sendOrientationChangeEvent:] which is unused
https://bugs.webkit.org/show_bug.cgi?id=167276

Reviewed by Alex Christensen.

It was usurped by -deviceOrientationChanged in 2014.

WebView/WebFrame.mm:

(-[WebFrame sendOrientationChangeEvent:]): Deleted.

WebView/WebFramePrivate.h:

5:52 PM Changeset in webkit [211020] by Simon Fraser

3 edits in trunk/Source/WebKit/mac

Remove -[WebView _contentsSizeRespectingOverflow] which is no longer needed
https://bugs.webkit.org/show_bug.cgi?id=167271

Reviewed by Alex Christensen.

-_contentsSizeRespectingOverflow was added to try to make viewport sizing on iOS respect
overflow:hidden on the body (webkit.org/b/146924) but that was reverted (webkit.org/b/152803),

WebView/WebView.mm:

(-[WebView _contentsSizeRespectingOverflow]): Deleted.

WebView/WebViewPrivate.h:

5:52 PM Changeset in webkit [211019] by Simon Fraser

3 edits in trunk/Source/WebKit/ios

Remove the unused -[WebFixedPositionContent minimumOffsetFromFixedPositionLayersToAnchorEdge:ofRect:inLayer:]
https://bugs.webkit.org/show_bug.cgi?id=167273

Reviewed by Alex Christensen.

This function was added for an experiment, but is no longer used, so remove it.

WebCoreSupport/WebFixedPositionContent.h:
WebCoreSupport/WebFixedPositionContent.mm:

(anchorEdgeFlagsForAnchorEdge): Deleted.
(-[WebFixedPositionContent minimumOffsetFromFixedPositionLayersToAnchorEdge:ofRect:inLayer:]): Deleted.

2:22 PM Changeset in webkit [211018] by Yusuke Suzuki

9 edits in trunk/Source/JavaScriptCore

[JSC] export JSC::importModule API for WebCore dynamic import
https://bugs.webkit.org/show_bug.cgi?id=167099

Reviewed by Darin Adler.

We newly expose JSC::importModule API. This can be used later
from WebCore to implement WebCore side dynamic import.
And JSC shell also uses this API.

And this patch also cleans up module loader a bit:
Dropping requestInstantiateAll.

builtins/BuiltinNames.h:
builtins/ModuleLoaderPrototype.js:

(requestLink):
(requestImportModule):
(requestInstantiateAll): Deleted.
(importModule): Deleted.

jsc.cpp:

(GlobalObject::moduleLoaderImportModule):

runtime/Completion.cpp:

(JSC::importModule):

runtime/Completion.h:
runtime/JSModuleLoader.cpp:

(JSC::JSModuleLoader::requestImportModule):

runtime/JSModuleLoader.h:
runtime/ModuleLoaderPrototype.cpp:

2:10 PM Changeset in webkit [211017] by Yusuke Suzuki

4 edits
3 adds in trunk

dynamic import is ambiguous with import declaration at module code
https://bugs.webkit.org/show_bug.cgi?id=167098

Reviewed by Darin Adler.

JSTests:

modules/import-call.js: Added.

(from.string_appeared_here.import.string_appeared_here.then):

modules/import-call/main.js: Added.
stress/import-syntax.js:

(async):

Source/JavaScriptCore:

This patch fixes two syntax issues related to dynamic import.

Fix member expression parsing with dynamic import results

We should not return import expression immediately after parsing
it in parseMemberExpression. This prohibits us to parse the following
code,

import("...").then(function () {
});

dynamic import with import declaration under the module context

Before this patch, we always attempt to parse IMPORT as import declaration
under the module context. It means that import call in the top level
expression statement fails to be parsed since the parser attempts to parse
it as import declaration.

import("...") module top level statement.

In this patch, we check the condition [lookahead != (] before starting
parsing import declaration. This allows us to put import call in the module
top level statement.

parser/Parser.cpp:

(JSC::Parser<LexerType>::parseModuleSourceElements):
(JSC::Parser<LexerType>::parseMemberExpression):

12:46 PM Changeset in webkit [211016] by commit-queue@webkit.org

3 edits in trunk/LayoutTests

REGRESSION (r210959): LayoutTest inspector/css/pseudo-element-matches.html timing out
https://bugs.webkit.org/show_bug.cgi?id=167246

Unreviewed test gardening.

This test expects elements with legacy media controls pseudo classes so we turn off
modern media controls for it and stop expecting a timeout.

Patch by Antoine Quint <Antoine Quint> on 2017-01-21

inspector/css/pseudo-element-matches.html:
platform/mac/TestExpectations:

2:21 AM Changeset in webkit [211015] by Carlos Garcia Campos

2 edits in trunk/Tools

Unreviewed. Bring back gtk-doc error messages after r209981.

Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
impossible to know what's wrong.

gtk/gtkdoc.py:

(GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.

1:22 AM Changeset in webkit [211014] by Carlos Garcia Campos

5 edits in trunk/Source

Unreviewed, rolling out r211012.

It caused a lot of crashes in the network process

Reverted changeset:

"[SOUP] Custom protocols don't work in private browsing mode"
https://bugs.webkit.org/show_bug.cgi?id=167236
http://trac.webkit.org/changeset/211012

Jan 20, 2017:

11:52 PM Changeset in webkit [211013] by commit-queue@webkit.org

20 edits in trunk/Source

Remove never changing IndexedDB RuntimeEnabledFeature
https://bugs.webkit.org/show_bug.cgi?id=167278

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-01-20
Reviewed by Darin Adler.

Source/WebCore:

This RuntimeEnabledFeature flag is always true and there are
no existing ways to change it. So lets just remove it.

Modules/indexeddb/DOMWindowIndexedDatabase.idl:
Modules/indexeddb/IDBCursor.idl:
Modules/indexeddb/IDBCursorWithValue.idl:
Modules/indexeddb/IDBDatabase.idl:
Modules/indexeddb/IDBFactory.idl:
Modules/indexeddb/IDBIndex.idl:
Modules/indexeddb/IDBKeyRange.idl:
Modules/indexeddb/IDBObjectStore.idl:
Modules/indexeddb/IDBOpenDBRequest.idl:
Modules/indexeddb/IDBRequest.idl:
Modules/indexeddb/IDBTransaction.idl:
Modules/indexeddb/IDBVersionChangeEvent.idl:
page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setIndexedDBEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::indexedDBEnabled): Deleted.

Source/WebKit/mac:

WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit/win:

WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WebKit2:

WebProcess/WebProcess.cpp:

(WebKit::m_resourceLoadStatisticsStorage):

11:40 PM Changeset in webkit [211012] by Carlos Garcia Campos

5 edits in trunk/Source

[SOUP] Custom protocols don't work in private browsing mode
https://bugs.webkit.org/show_bug.cgi?id=167236

Reviewed by Sergio Villar Senin.

Source/WebCore:

Add static method to set the global custom protocols request type and setup method to add the feature to the session.

platform/network/soup/SoupNetworkSession.cpp:

(WebCore::SoupNetworkSession::SoupNetworkSession):
(WebCore::SoupNetworkSession::setCustomProtocolRequestType):
(WebCore::SoupNetworkSession::setupCustomProtocols):

platform/network/soup/SoupNetworkSession.h:

Source/WebKit2:

We only register them in the default session.

NetworkProcess/CustomProtocols/soup/CustomProtocolManagerSoup.cpp:

(WebKit::CustomProtocolManager::registerProtocolClass): Set the WEBKIT_TYPE_SOUP_REQUEST_GENERIC as type for
custom protocols, and setup custom protocols in all existing sessions.
(WebKit::CustomProtocolManager::registerScheme): Use g_type_class_peek instead of g_type_class_ref since we know
the class was already created in registerProtocolClass().

10:36 PM Changeset in webkit [211011] by Chris Dumez

2 edits in trunk/LayoutTests/imported/w3c

Unreviewed, rebaseline html/dom/interfaces.html.

web-platform-tests/html/dom/interfaces-expected.txt:

8:51 PM Changeset in webkit [211010] by commit-queue@webkit.org

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Search Tab should display search results immediately when closing and reopening Inspector
https://bugs.webkit.org/show_bug.cgi?id=167073

Patch by Devin Rousso <Devin Rousso> on 2017-01-20
Reviewed by Timothy Hatcher.

UserInterface/Views/SearchSidebarPanel.js:

(WebInspector.SearchSidebarPanel.prototype.focusSearchField):
Add parameter that will trigger a search with the current input value when true.

UserInterface/Views/SearchTabContentView.js:

(WebInspector.SearchTabContentView):
(WebInspector.SearchTabContentView.prototype.focusSearchField):
(WebInspector.SearchTabContentView.prototype.initialLayout):

6:36 PM Changeset in webkit [211009] by commit-queue@webkit.org

4 edits in trunk

[WebRTC] Update build system to make G711 optional in libwebrtc
https://bugs.webkit.org/show_bug.cgi?id=167256

Patch by Youenn Fablet <youennf@gmail.com> on 2017-01-20
Reviewed by Alex Christensen.

Source/ThirdParty/libwebrtc:

CMakeLists.txt: Updating to add compilation of generic pcm encoder functions.

Tools:

Scripts/webkitpy/libwebrtc/generate_cmake.py:

(CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.

6:31 PM Changeset in webkit [211008] by commit-queue@webkit.org

6 edits
1 add in trunk/Source/WebCore

Record whether a media element was prevented from playing without user interaction
https://bugs.webkit.org/show_bug.cgi?id=167214

Patch by Matt Rajca <mrajca@apple.com> on 2017-01-20
Reviewed by Eric Carlson.

This state will be used to notify clients when a user explicitly starts playback
of a media element that was prevented from autoplaying.

Tests will be added after a WebKit callback API is added.

WebCore.xcodeproj/project.pbxproj:
dom/SuccessOr.h: Added.

(WebCore::SuccessOr::SuccessOr):
(WebCore::SuccessOr::operator bool):

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::canTransitionFromAutoplayToPlay):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::play):
(WebCore::HTMLMediaElement::playInternal):

html/HTMLMediaElement.h:
html/MediaElementSession.cpp:

(WebCore::MediaElementSession::playbackPermitted):

html/MediaElementSession.h:

6:24 PM Changeset in webkit [211007] by beidson@apple.com

27 edits
2 adds in trunk

Require a button press on a gamepad for them to be exposed to the DOM.
<rdar://problem/28620919> and https://bugs.webkit.org/show_bug.cgi?id=167272

Reviewed by Alex Christensen.

Source/WebCore:

Test: gamepad/gamepad-visibility-1.html

Modules/gamepad/GamepadManager.cpp:

(WebCore::GamepadManager::platformGamepadInputActivity):

Modules/gamepad/GamepadManager.h:

platform/gamepad/GamepadProvider.cpp:

(WebCore::GamepadProvider::dispatchPlatformGamepadInputActivity):

platform/gamepad/GamepadProvider.h:

(WebCore::GamepadProvider::~GamepadProvider): Deleted.
(WebCore::GamepadProvider::isMockGamepadProvider): Deleted.

platform/gamepad/GamepadProviderClient.h:

platform/gamepad/cocoa/GameControllerGamepad.h:
platform/gamepad/cocoa/GameControllerGamepad.mm:

(WebCore::GameControllerGamepad::setupAsExtendedGamepad):
(WebCore::GameControllerGamepad::setupAsGamepad):

platform/gamepad/cocoa/GameControllerGamepadProvider.h:
platform/gamepad/cocoa/GameControllerGamepadProvider.mm:

(WebCore::GameControllerGamepadProvider::gamepadHadInput):
(WebCore::GameControllerGamepadProvider::inputNotificationTimerFired):

platform/gamepad/mac/HIDGamepad.cpp:

(WebCore::HIDGamepad::valueChanged):

platform/gamepad/mac/HIDGamepad.h:

platform/gamepad/mac/HIDGamepadProvider.cpp:

(WebCore::HIDGamepadProvider::valuesChanged):
(WebCore::HIDGamepadProvider::inputNotificationTimerFired):

platform/gamepad/mac/HIDGamepadProvider.h:

testing/MockGamepadProvider.cpp:

(WebCore::MockGamepadProvider::setMockGamepadButtonValue):
(WebCore::MockGamepadProvider::gamepadInputActivity):

testing/MockGamepadProvider.h:

Source/WebKit2:

UIProcess/Gamepad/UIGamepadProvider.cpp:

(WebKit::UIGamepadProvider::gamepadSyncTimerFired):
(WebKit::UIGamepadProvider::platformGamepadInputActivity):

UIProcess/Gamepad/UIGamepadProvider.h:

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::gamepadActivity):

UIProcess/WebPageProxy.h:

WebProcess/Gamepad/WebGamepadProvider.cpp:

(WebKit::WebGamepadProvider::gamepadActivity):

WebProcess/Gamepad/WebGamepadProvider.h:

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::gamepadActivity):

WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

LayoutTests:

gamepad/gamepad-visibility-1-expected.txt: Added.
gamepad/gamepad-visibility-1.html: Added.

6:23 PM Changeset in webkit [211006] by Joseph Pecoraro

75 edits
1 delete in trunk

Cleanup RuntimeEnabledFeatures
https://bugs.webkit.org/show_bug.cgi?id=167228

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

web-platform-tests/resource-timing/resource_cached-expected.txt:
web-platform-tests/resource-timing/resource_connection_reuse-expected.txt:
web-platform-tests/resource-timing/resource_dynamic_insertion-expected.txt:

The previous internals API didn't appear to be working. Making it work
improved these results.

Source/WebCore:

RuntimeEnabledFeatures::reset() is bad for tests. It was getting called
after the TestRunners had set up all the Settings and RuntimeEnabledFeatures
they expected, so it was clearing the "consistent state" set by TestRunners.

Cleanup within RuntimeEnabledFeatures:

Initialize all members.
Remove unused features.
Remove reset() no longer used.
Document features that do not change (potentially removable).
Document features that are not used but have APIs (use or remove later).
Drop webkit prefix for these internal only apis.
Move things around a bit to make it more readable.
Enable the Fetch API by default (WebKit levels all were enabling it).

Cleanup within Internals:

Move all RuntimeEnabledFeature toggling to InternalSettings
Save and restore these RuntimeEnabledFeatures in InternalSettings

Modules/mediastream/MediaStreamEvent.idl:
Modules/mediastream/NavigatorMediaDevices.idl:
Modules/mediastream/NavigatorUserMedia.idl:
Modules/mediastream/RTCDTMFToneChangeEvent.idl:
Modules/mediastream/RTCIceCandidate.idl:
Modules/mediastream/RTCPeerConnection.idl:
Modules/mediastream/RTCRtpReceiver.idl:
Modules/mediastream/RTCRtpSender.idl:
Modules/mediastream/RTCRtpTransceiver.idl:
Modules/mediastream/RTCSessionDescription.idl:
Modules/mediastream/RTCTrackEvent.idl:

Canonical usage is to start with a capital letter.

dom/EventNames.in:

No port has API/SPI to disable this feature at runtime and the default is
to have the feature enabled, so this is no different from the runtime flag.

page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):
These features were always enabled and not toggleable. So drop the runtime
feature check.

page/csp/ContentSecurityPolicy.h:
page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::experimentalFeaturesEnabled): Deleted.
Nobody calls this method. Drop it.

page/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::reset):
(WebCore::RuntimeEnabledFeatures::javaScriptI18NAPIEnabled): Deleted.

page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::langAttributeAwareFormControlUIEnabled):
(WebCore::RuntimeEnabledFeatures::setLangAttributeAwareFormControlUIEnabled):
(WebCore::RuntimeEnabledFeatures::setLinkPreloadEnabled):
(WebCore::RuntimeEnabledFeatures::linkPreloadEnabled):
(WebCore::RuntimeEnabledFeatures::setResourceTimingEnabled):
(WebCore::RuntimeEnabledFeatures::resourceTimingEnabled):
(WebCore::RuntimeEnabledFeatures::setShadowDOMEnabled):
(WebCore::RuntimeEnabledFeatures::shadowDOMEnabled):
(WebCore::RuntimeEnabledFeatures::setInputEventsEnabled):
(WebCore::RuntimeEnabledFeatures::inputEventsEnabled):
(WebCore::RuntimeEnabledFeatures::setInteractiveFormValidationEnabled):
(WebCore::RuntimeEnabledFeatures::interactiveFormValidationEnabled):
(WebCore::RuntimeEnabledFeatures::setCustomElementsEnabled):
(WebCore::RuntimeEnabledFeatures::customElementsEnabled):
(WebCore::RuntimeEnabledFeatures::setModernMediaControlsEnabled):
(WebCore::RuntimeEnabledFeatures::modernMediaControlsEnabled):
(WebCore::RuntimeEnabledFeatures::setIndexedDBEnabled):
(WebCore::RuntimeEnabledFeatures::fontLoadEventsEnabled):
(WebCore::RuntimeEnabledFeatures::setMediaStreamEnabled):
(WebCore::RuntimeEnabledFeatures::setPeerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::setLocalStorageEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::localStorageEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setSessionStorageEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::sessionStorageEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setWebkitNotificationsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webkitNotificationsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setApplicationCacheEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::applicationCacheEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setDataTransferItemsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::dataTransferItemsEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setWebkitIndexedDBEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webkitIndexedDBEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::touchEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setTouchEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setDeviceMotionEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::deviceMotionEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::deviceMotionEventEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::ondevicemotionEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setDeviceOrientationEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::deviceOrientationEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::deviceOrientationEventEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::ondeviceorientationEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setJavaScriptI18NAPIEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webkitGetUserMediaEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webkitMediaStreamEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::webkitRTCPeerConnectionEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::experimentalContentSecurityPolicyFeaturesEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setExperimentalContentSecurityPolicyFeaturesEnabled): Deleted.

testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setLangAttributeAwareFormControlUIEnabled):
(WebCore::InternalSettings::setResourceTimingEnabled):
(WebCore::InternalSettings::setLinkPreloadEnabled):
(WebCore::InternalSettings::setCSSGridLayoutEnabled):
(WebCore::InternalSettings::setWebGL2Enabled):

testing/InternalSettings.h:
testing/InternalSettings.idl:
testing/Internals.cpp:

(WebCore::Internals::Internals):
(WebCore::Internals::setLinkPreloadSupport): Deleted.
(WebCore::Internals::setCSSGridLayoutEnabled): Deleted.
(WebCore::Internals::webGL2Enabled): Deleted.
(WebCore::Internals::setWebGL2Enabled): Deleted.
(WebCore::Internals::setResourceTimingSupport): Deleted.

testing/Internals.h:
testing/Internals.idl:

Move toggling of RuntimeEnabledFeatures to InternalSettings and
properly remember to save and restore them in Internals.

Source/WebKit/mac:

WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit/win:

WebView.cpp:

(WebView::notifyPreferencesChanged):

Source/WebKit2:

WebProcess/WebProcess.cpp:

(WebKit::m_resourceLoadStatisticsStorage):

Tools:

DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures):
(resetWebPreferencesToConsistentValues):
(setWebPreferencesForTestOptions):
(resetWebViewToConsistentStateBeforeTesting):

DumpRenderTree/win/DumpRenderTree.cpp:

(enableExperimentalFeatures):
(resetWebPreferencesToConsistentValues):
More closely match WebKitTestRunner initialization of preferences
for experimental features.

LayoutTests:

Update tests that toggle runtime enabled features to use
consistently named internals.settings.setFooEnabled setters.

css3/flexbox/flexbox-lines-must-be-stretched-by-default.html:
css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled.html:
fast/canvas/webgl/bufferData-offset-length.html:
fast/canvas/webgl/copyBufferSubData.html:
fast/canvas/webgl/getBufferSubData-webgl1.html:
fast/canvas/webgl/webgl2-buffer-targets.html:
fast/canvas/webgl/webgl2-buffers.html:
fast/canvas/webgl/webgl2-context-creation.html:
fast/canvas/webgl/webgl2-runtime-flag.html:
fast/canvas/webgl/webgl2-texStorage.html:
fast/canvas/webgl/webgl2-texture-upload-enums.html:
fast/css-grid-layout/grid-disable.html:
fast/css/ensure-flexbox-compatibility-with-initial-values.html:
fast/dom/Window/window-properties-performance-resource-timing.html:
http/tests/fetch/redirectmode-and-preload.html:
http/tests/misc/resource-timing-resolution.html:
http/tests/performance/performance-resource-timing-cached-entries.html:
http/tests/performance/performance-resource-timing-entries-iterable.html:
http/tests/performance/performance-resource-timing-entries.html:
http/tests/performance/performance-resource-timing-initiator-css.html:
http/tests/performance/performance-resource-timing-initiator-no-override.html:
http/tests/performance/performance-resource-timing-xhr-single-entry.html:
http/tests/preload/delaying_onload_link_preload_after_discovery.html:
http/tests/preload/delaying_onload_link_preload_after_discovery_image.html:
http/tests/preload/download_resources.html:
http/tests/preload/download_resources_from_header_iframe.html:
http/tests/preload/download_resources_from_invalid_headers.html:
http/tests/preload/dynamic_adding_preload.html:
http/tests/preload/dynamic_remove_preload_href.html:
http/tests/preload/not_delaying_window_onload_before_discovery.html:
http/tests/preload/onerror_event.html:
http/tests/preload/onload_event.html:
http/tests/preload/resources/download_resources_from_header.php:
http/tests/preload/resources/invalid_resources_from_header.php:
http/tests/preload/single_download_preload_runner.html:
http/tests/security/cached-cross-origin-preloading-css-stylesheet.html:
resources/testharnessreport.js:

5:46 PM Changeset in webkit [211005] by matthew_hanson@apple.com

5 edits in branches/safari-603-branch/Source

Versioning.

5:21 PM Changeset in webkit [211004] by commit-queue@webkit.org

2 edits in trunk/Source/ThirdParty/libwebrtc

[WebRTC] Update libwertc AudioRtpSender::SetAudioSend
https://bugs.webkit.org/show_bug.cgi?id=167243

Patch by Youenn Fablet <youennf@gmail.com> on 2017-01-20
Reviewed by Alex Christensen.

Introducing WEBRTC_WEBKIT_BUILD macro to match existing WEBRTC_CHROMIUM_BUILD.
WEBRTC_WEBKIT_BUILD is defined by current WebKit libwebrtc build system.

Source/webrtc/api/rtpsender.cc:

5:08 PM Changeset in webkit [211003] by matthew_hanson@apple.com

1 copy in tags/Safari-603.1.21

New tag.

5:05 PM Changeset in webkit [211002] by Megan Gardner

2 edits in trunk/LayoutTests

REGRESSION (r210941): LayoutTest scrollingcoordinator/ios/sync-layer-positions-after-scroll.html failing
https://bugs.webkit.org/show_bug.cgi?id=167262

Updating Tests to comply with change in bug 167171.
Change is correct, but causes the results for this test to be different.

Unreviewed test gardening.

scrollingcoordinator/ios/sync-layer-positions-after-scroll-expected.txt:

4:44 PM Changeset in webkit [211001] by achristensen@apple.com

2 edits in trunk/Source/WebCore

Add debugging code to compare URLParser with URL::parse
https://bugs.webkit.org/show_bug.cgi?id=167267

Reviewed by Brady Eidson.

platform/URLParser.cpp:

(WebCore::URLParser::URLParser):
(WebCore::URLParser::parse):

4:35 PM Changeset in webkit [211000] by Ryan Haddad

2 edits in trunk/LayoutTests

Marking media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=167266

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

4:30 PM Changeset in webkit [210999] by jmarcell@apple.com

5 edits in tags/Safari-604.1.4.1/Source

Versioning.

4:28 PM Changeset in webkit [210998] by Ryan Haddad

2 edits in trunk/LayoutTests

Marking inspector/network/client-blocked-load.html as a flaky timeout.
https://bugs.webkit.org/show_bug.cgi?id=167265

Unreviewed test gardening.

platform/mac/TestExpectations:

4:21 PM Changeset in webkit [210997] by Ryan Haddad

7 edits in trunk/Source/WebCore

Unreviewed, rolling out r210778.

This change caused multiple LayoutTests to crash.

Reverted changeset:

"[Cocoa] Unify FontPlatformData's hashing and equality
operators"
https://bugs.webkit.org/show_bug.cgi?id=167061
http://trac.webkit.org/changeset/210778

4:17 PM Changeset in webkit [210996] by jmarcell@apple.com

1 copy in tags/Safari-604.1.4.1

New tag.

4:08 PM Changeset in webkit [210995] by Ryan Haddad

2 edits in trunk/LayoutTests

Marking media/modern-media-controls/pip-support/pip-support-enabled.html as crashing on macOS WK1.
https://bugs.webkit.org/show_bug.cgi?id=164336

Unreviewed test gardening.

platform/mac-wk1/TestExpectations:

4:00 PM Changeset in webkit [210994] by Ryan Haddad

3 edits in trunk/LayoutTests

More media test gardening.

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:
platform/mac/TestExpectations:

3:33 PM Changeset in webkit [210993] by achristensen@apple.com

6 edits in trunk

Build Fix for Windows DumpRenderTree after r210976
https://bugs.webkit.org/show_bug.cgi?id=167115

Source/WebKit/win:

WebPreferences.h:

Remove extra space.

IWebPreferencesPrivate.idl:

Add new interface functions.

WebView.cpp:

We use new functions that are only in IWebPreferencesPrivate4,
so instantiate that COM object instead of version 3.

Tools:

DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):

3:23 PM Changeset in webkit [210992] by commit-queue@webkit.org

27 edits in trunk

Remove outdated ENABLE(CSP_NEXT) build flag
https://bugs.webkit.org/show_bug.cgi?id=167252

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-01-20
Reviewed by Brent Fulgham.

Source/cmake/OptionsMac.cmake:
Source/cmake/OptionsWin.cmake:
Source/cmake/WebKitFeatures.cmake:
Source/cmake/tools/vsprops/FeatureDefines.props:
Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:
dom/Document.idl:
page/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::reset):

page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::experimentalContentSecurityPolicyFeaturesEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::setExperimentalContentSecurityPolicyFeaturesEnabled): Deleted.

page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::experimentalFeaturesEnabled): Deleted.

page/csp/ContentSecurityPolicy.h:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:

Source/WTF:

wtf/FeatureDefines.h:

Tools:

Scripts/webkitperl/FeatureList.pm:
TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

fast/dom/event-handler-attributes.html:
http/tests/security/contentSecurityPolicy/1.1/securitypolicyviolation-basics.html:

2:54 PM Changeset in webkit [210991] by Joseph Pecoraro

7 edits in trunk

Build Fix for Windows DumpRenderTree after r210976

Source/WebKit/win:

WebPreferenceKeysPrivate.h:
WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::setWebAnimationsEnabled):
(WebPreferences::webAnimationsEnabled):

WebPreferences.h:
WebView.cpp:

Add toggle APIs for WebAnimations.

Tools:

DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):

2:53 PM Changeset in webkit [210990] by Ryan Haddad

3 edits in trunk/LayoutTests

Cleaning up TestExpectations for inspector/css/pseudo-element-matches.html.

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:
platform/mac/TestExpectations:

2:48 PM Changeset in webkit [210989] by Ryan Haddad

2 edits in trunk/LayoutTests

Marking media/modern-media-controls/audio/audio-controls-metrics.html as failing on iOS.
https://bugs.webkit.org/show_bug.cgi?id=167258

Unreviewed test gardening.

platform/ios-simulator-wk2/TestExpectations:

2:40 PM Changeset in webkit [210988] by rniwa@webkit.org

2 edits in trunk/Websites/perf.webkit.org

Build fix after r210783. Didn't mean to require custom elements API.

public/v3/main.js:

(main):

2:30 PM Changeset in webkit [210987] by commit-queue@webkit.org

16 edits in trunk/Source/ThirdParty/libwebrtc

[WebRTC] libwebrtc headers are incompatible with WebKit compilation flags
https://bugs.webkit.org/show_bug.cgi?id=167242

Patch by Youenn Fablet <youenn@apple.com> on 2017-01-20
Reviewed by Alex Christensen.

WebKit is enforcing -Wunused-parameter and -Wunused-variable which conflict with some included libwertc headers.
Removed unused parameter names for inlined functions.

Source/webrtc/api/jsep.h:

(webrtc::SessionDescriptionInterface::RemoveCandidates):

Source/webrtc/api/mediastreaminterface.h:

(webrtc::AudioSourceInterface::SetVolume):
(webrtc::AudioSourceInterface::RegisterAudioObserver):
(webrtc::AudioSourceInterface::UnregisterAudioObserver):
(webrtc::AudioSourceInterface::AddSink):
(webrtc::AudioSourceInterface::RemoveSink):
(webrtc::AudioTrackInterface::GetSignalLevel):

Source/webrtc/api/peerconnectionfactory.h:
Source/webrtc/api/peerconnectioninterface.h:

(webrtc::MetricsObserverInterface::IncrementEnumCounter):
(webrtc::PeerConnectionInterface::AddTrack):
(webrtc::PeerConnectionInterface::RemoveTrack):
(webrtc::PeerConnectionInterface::CreateSender):
(webrtc::PeerConnectionInterface::GetStats):
(webrtc::PeerConnectionInterface::CreateOffer):
(webrtc::PeerConnectionInterface::CreateAnswer):
(webrtc::PeerConnectionInterface::UpdateIce):
(webrtc::PeerConnectionInterface::SetConfiguration):
(webrtc::PeerConnectionInterface::RemoveIceCandidates):
(webrtc::PeerConnectionInterface::StartRtcEventLog):
(webrtc::PeerConnectionObserver::OnAddStream):
(webrtc::PeerConnectionObserver::OnRemoveStream):
(webrtc::PeerConnectionObserver::OnDataChannel):
(webrtc::PeerConnectionObserver::OnIceCandidatesRemoved):
(webrtc::PeerConnectionObserver::OnIceConnectionReceivingChange):

Source/webrtc/api/rtpsender.cc:
Source/webrtc/base/messagehandler.h:

(rtc::FunctorMessageHandler::OnMessage):

Source/webrtc/base/sanitizer.h:

(rtc_AsanPoison):
(rtc_AsanUnpoison):
(rtc_MsanMarkUninitialized):
(rtc_MsanCheckInitialized):

Source/webrtc/base/stream.h:

(rtc::StreamInterface::ConsumeReadData):
(rtc::StreamInterface::ConsumeWriteBuffer):

Source/webrtc/media/base/mediachannel.h:

(cricket::DataMediaChannel::GetStats):
(cricket::DataMediaChannel::OnNetworkRouteChanged):

Source/webrtc/media/engine/webrtcvideodecoderfactory.h:

(cricket::WebRtcVideoDecoderFactory::CreateVideoDecoderWithParams):

Source/webrtc/media/engine/webrtcvideoencoderfactory.h:

(cricket::WebRtcVideoEncoderFactory::VideoCodec::VideoCodec):
(cricket::WebRtcVideoEncoderFactory::EncoderTypeHasInternalSource):

Source/webrtc/media/engine/webrtcvideoengine2.cc:
Source/webrtc/modules/include/module.h:

(webrtc::Module::ProcessThreadAttached):

Source/webrtc/modules/video_coding/codecs/vp9/vp9_noop.cc:
Source/webrtc/p2p/base/port.h:

(cricket::Port::HandleIncomingPacket):
(cricket::Port::HandleConnectionDestroyed):
(cricket::Connection::set_receiving_timeout):

Source/webrtc/p2p/base/stun.h:

(cricket::StunAttribute::SetOwner):

Source/webrtc/p2p/base/stunrequest.h:

(cricket::StunRequest::Prepare):
(cricket::StunRequest::OnResponse):
(cricket::StunRequest::OnErrorResponse):

Source/webrtc/p2p/base/transport.h:

(cricket::Transport::SetLocalCertificate):
(cricket::Transport::GetLocalCertificate):
(cricket::Transport::GetSslRole):
(cricket::Transport::SetSslMaxProtocolVersion):

Source/webrtc/sdk/objc/Framework/Classes/videotoolboxvideocodecfactory.cc:
Source/webrtc/typedefs.h:

2:19 PM Changeset in webkit [210986] by Ryan Haddad

2 edits in trunk/LayoutTests

Marking media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=167254

Unreviewed test gardening.

platform/mac/TestExpectations:

2:12 PM Changeset in webkit [210985] by Alan Bujtas

6 edits in trunk

Simple line layout: Add support for non-breaking space character.
https://bugs.webkit.org/show_bug.cgi?id=167250
<rdar://problem/30119638>

Reviewed by Antti Koivisto.
Source/WebCore:

Do not bail out on noBreakSpace character.
The line breaking logic already takes noBreakSpace characters into account.
(except the peculiar "-webkit-nbsp-mode: space" mode)

Covered by existing test cases.

rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseForText):
(WebCore::SimpleLineLayout::canUseForStyle):
(WebCore::SimpleLineLayout::printReason):

LayoutTests:

These are output progressions (they do not reflect changes in functionality).

fast/block/float/br-with-clear-2-expected.txt:
platform/mac/css1/text_properties/text_transform-expected.txt:
platform/mac/tables/mozilla/bugs/bug4427-expected.txt:

2:07 PM Changeset in webkit [210984] by Ryan Haddad

2 edits in trunk/LayoutTests

Marking macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html as flaky on mac-wk1.
https://bugs.webkit.org/show_bug.cgi?id=167253

Unreviewed test gardening.

platform/mac-wk1/TestExpectations:

2:07 PM Changeset in webkit [210983] by Ryan Haddad

2 edits in trunk/LayoutTests

Marking inspector/css/pseudo-element-matches.html as a timeout on macOS.
https://bugs.webkit.org/show_bug.cgi?id=167246

Unreviewed test gardening.

platform/mac/TestExpectations:

2:04 PM Changeset in webkit [210982] by rniwa@webkit.org

3 edits in trunk/Websites/perf.webkit.org

Make sync-commits.py robust against missing Subversion authors and missing parent Git commits
https://bugs.webkit.org/show_bug.cgi?id=167231

Reviewed by Antti Koivisto.

Fixed a bug that a subversion commit that's missing author name (anonymous commit) results in an out of bound
exception, and a bug that syncing a git repository starts failing once there was a merge commit which pulled
in a commit data earlier than that of the last reported commit.

For the latter fix, added --max-ancestor-fetch-count to specify the number of maximum commits to look back.

tools/sync-commits.py:

(main): Added --max-ancestor-fetch-count.
(Repository.fetch_commits_and_submit): If submit_commits fails with FailedToFindParentCommit, fetch the parent
commit's information until we've resolved them all.
(Repository.fetch_next_commit): Renamed from fetch_commit.
(SVNRepository.fetch_next_commit): Renamed from fetch_commit. Don't try to get the author name if it's missing
due to an anonymous commit. It's important to never include the "author" field in the JSON submitted to
a dashboard since it rejects when "author" field is not an array (e.g. null).
(GitRepository.fetch_next_commit): Renamed from fetch_commit.
(GitRepository.fetch_commit): Added. Fetches the commit information for a given git hash. Used to retrieve
missing parent commits.
(GitRepository._revision_from_tokens): Extracted from fetch_commit.

tools/util.py:

(submit_commits): Optionally takes status_to_accept to avoid throwing in the case of FailedToFindParentCommit
and returns the response JSON.

2:02 PM Changeset in webkit [210981] by rniwa@webkit.org

3 edits
1 add in trunk/Websites/perf.webkit.org

REGRESSION(r198234): /api/commits/%revision% always fails
https://bugs.webkit.org/show_bug.cgi?id=167235

Reviewed by Antti Koivisto.

The bug was caused by a typo in CommitLogFetcher::fetch_revision, which was calling commit_for_revision on
$this->db instead of $this. This had been monkey-patched in the internal dashboard so it was working there.

Also fixed a bug that /latest wasn't doing what it claimed to do, and a bug that /oldest /latest,
and /last-reported would return a commit with all values set to null instead of an empty list.

Finally, added server API tests for /api/commits.

public/api/commits.php:

(main): Add a comment for APIs that only exist for v2 UI.

public/include/commit-log-fetcher.php:

(CommitLogFetcher::fetch_latest): Fixed the bug that this function was returning the oldest commit, not the
the latest commit as desired.
(CommitLogFetcher::fetch_revision): Fixed the bug that this function would always encounter an exception
because commit_for_revision is defined on $this, not $this->db.
(CommitLogFetcher::format_single_commit): Return an empty list instead of an array with a single commit with
all values set to null.

server-tests/api-commits.js: Added. Added tests for the JSON API at /api/commits.

(.assertCommitIsSameAsOneSubmitted): Added. A helper function to compare a commit returned by /api/commits
to one sent to /api/report-commits.

1:50 PM Changeset in webkit [210980] by achristensen@apple.com

3 edits in trunk/Source/WebKit2

Fix Mac CMake build.

CMakeLists.txt:
PlatformMac.cmake:

1:35 PM Changeset in webkit [210979] by Ryan Haddad

2 edits in trunk/LayoutTests

Marking media/modern-media-controls/placard-support/placard-support-airplay.html as flaky on macOS.
https://bugs.webkit.org/show_bug.cgi?id=164298

Unreviewed test gardening.

platform/mac/TestExpectations:

1:35 PM Changeset in webkit [210978] by Ryan Haddad

2 edits in trunk/LayoutTests

Marking media/modern-media-controls/tracks-panel/tracks-panel-hide-click-outside.html as flaky on macOS.
https://bugs.webkit.org/show_bug.cgi?id=165290

Unreviewed test gardening.

platform/mac/TestExpectations:

1:25 PM Changeset in webkit [210977] by commit-queue@webkit.org

2 edits in trunk/Source/ThirdParty/libwebrtc

[WebRTC] Update libwertc AudioRtpSender::SetAudioSend
https://bugs.webkit.org/show_bug.cgi?id=167243

Patch by Youenn Fablet <youennf@gmail.com> on 2017-01-20
Reviewed by Alex Christensen.

Introducing WEBRTC_WEBKIT_BUILD macro to match existing WEBRTC_CHROMIUM_BUILD.
WEBRTC_WEBKIT_BUILD is defined by current WebKit libwebrtc build system.

Source/webrtc/api/rtpsender.cc:

1:04 PM Changeset in webkit [210976] by commit-queue@webkit.org

19 edits in trunk

Web Animations should be off by default and enabled as an experimental feature
https://bugs.webkit.org/show_bug.cgi?id=167115
<rdar://problem/30048963>

Patch by Antoine Quint <Antoine Quint> on 2017-01-20
Reviewed by Joseph Pecoraro.

Source/WebCore:

Conditionalize the existing parts of the Web Animations API so that they may be
toggled at runtime.

animation/Animatable.idl:
animation/AnimationEffect.idl:
animation/AnimationTimeline.idl:
animation/DocumentAnimation.idl:
animation/DocumentTimeline.idl:
animation/KeyframeEffect.idl:
animation/WebAnimation.idl:
page/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::reset):

page/RuntimeEnabledFeatures.h:

Source/WebKit2:

Promote, or relegate depending on how you see things, the Web Animations preference
to an experimental feature.

Shared/WebPreferencesDefinitions.h:

Tools:

Turn Web Animations on in DRT.

DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):

Websites/webkit.org:

Add a test for Web Animations feature detection.

experimental-features.html:

LayoutTests:

No need for an explicit preference anymore.

webanimations/script-tests/Document.js:

12:44 PM Changeset in webkit [210975] by Ryan Haddad

2 edits in trunk/LayoutTests

Skipping pointer-lock tests on macOS WK2.
https://bugs.webkit.org/show_bug.cgi?id=167246

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

11:41 AM Changeset in webkit [210974] by commit-queue@webkit.org

2 edits in trunk/Source/ThirdParty/libwebrtc

[WebRTC] libwebrtc H.264 codec is using VTB only for IOS
https://bugs.webkit.org/show_bug.cgi?id=167245

Patch by Youenn Fablet <youennf@gmail.com> on 2017-01-20
Reviewed by Alex Christensen.

Source/webrtc/sdk/objc/Framework/Classes/videotoolboxvideocodecfactory.cc: Removing WEBRTC_IOS flag.

10:43 AM Changeset in webkit [210973] by commit-queue@webkit.org

4 edits
11 adds in trunk

[WebRTC] Add libwebrtc build infrastructure
https://bugs.webkit.org/show_bug.cgi?id=167207

Patch by Youenn Fablet <youenn@apple.com> on 2017-01-20
Reviewed by Alex Christensen.

WebKit.xcworkspace/contents.xcworkspacedata:

Source/ThirdParty:

Checking-in files used for building libwebrtc.
The principle is the following:

Select a revision of libwebrtc
Ask libwebrtc build system to generate the project.json (something like gn gen --ide json ...)
Copy project.json here and the libwebrtc selected revision in a libwebrtc/libwebrtc folder.
Call Tools/Scripts/generate-libwebrtc-cmake which will update CMakeLists.txt
Build libwebrtc with CMake

libwebrtc/CMakeLists.txt: Added (Generated by Tools/Scripts/generate-libwebrtc-cmake using project.json as input).
libwebrtc/Makefile: Added.
libwebrtc/WebKit/project.json: Added (Generated by libwebrtc build system).
libwebrtc/WebKit/rtc_sdk_framework_objc_info_plist.plist: Added.
libwebrtc/libwebrtc.xcodeproj/project.pbxproj: Added.

Tools:

Adding a script doing the libwebrtc project json to CMake file conversion.

Scripts/generate-libwebrtc-cmake: Added.
Scripts/webkitpy/libwebrtc/init.py: Added.
Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.

10:21 AM Changeset in webkit [210972] by Chris Dumez

2 edits in trunk/LayoutTests/imported/w3c

Unreviewed, unskip innerText/ folder in ImportExpectations

This is needed so that the tests in this folder gets re-sync'ed
from upstream next time.

resources/ImportExpectations:

10:10 AM Changeset in webkit [210971] by sbarati@apple.com

4 edits in trunk/Source/JavaScriptCore

We should flash a safepoint before each DFG/FTL phase
https://bugs.webkit.org/show_bug.cgi?id=167234

Reviewed by Filip Pizlo.

The recent GC changes caused us to regress Kraken because of a
longstanding issue that happened to be hit with higher frequency because
of a change in timing between when a particular GC was happening and
when a particular FTL compilation was happening. The regression is caused
by the GC was waiting for a large function to make it through the DFG portion
of an FTL compilation. This was taking 20ms-30ms and started happened during a
particular test with much higher frequency.

This means that anytime the GC waits for this compilation, the test ran at least
~20ms slower because the GC waits for the compiler threads the mutator is stopped.

It's good that we have such an easily reproducible case of this performance
issue because it will effect many real JS programs, especially ones with
large functions that get hot.

The most straight forward solution to fix this is to flash a safepoint before
each phase, allowing the GC to suspend the compiler if needed. In my testing,
this progresses Kraken in the browser, and doesn't regress anything else. This
solution also makes the most sense. I did some analysis on the compilation time
of this function that took ~20-30ms to pass through the DFG phases, and
the phase times were mostly evenly distributed. Some took longer than others,
but no phase was longer than 3ms. Most were in the 0.25ms to 1.5ms range.

dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

dfg/DFGSafepoint.cpp:

(JSC::DFG::Safepoint::begin):

runtime/Options.h:

10:09 AM Changeset in webkit [210970] by matthew_hanson@apple.com

3 edits
4 adds in branches/safari-603-branch

Merge r210951. rdar://problem/29562247

10:09 AM Changeset in webkit [210969] by matthew_hanson@apple.com

29 edits in branches/safari-603-branch

Merge r210949. rdar://problem/30108531

10:09 AM Changeset in webkit [210968] by matthew_hanson@apple.com

5 edits in branches/safari-603-branch/Source/JavaScriptCore

Merge r210947. rdar://problem/30108809

10:09 AM Changeset in webkit [210967] by matthew_hanson@apple.com

3 edits
2 adds in branches/safari-603-branch

Merge r210945. rdar://problem/28745101

9:59 AM Changeset in webkit [210966] by commit-queue@webkit.org

2 edits in trunk/Tools

Mini Browser: Show tooltip for Experimental Features
https://bugs.webkit.org/show_bug.cgi?id=167225

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-01-20
Reviewed by Alex Christensen.

MiniBrowser/mac/SettingsController.m:

(-[SettingsController _populateMenu]):
Include the full details string as a tooltip.

9:50 AM Changeset in webkit [210965] by pvollan@apple.com

2 edits in trunk/Tools

[Win] Test output results should not be written twice.
https://bugs.webkit.org/show_bug.cgi?id=167197

Reviewed by Brent Fulgham.

Prevent test output from being written twice by returning early from
the dump() function, if it already has been called.
This patch also adds a missing newline to a test output line.

DumpRenderTree/win/DumpRenderTree.cpp:

(dump):

8:56 AM Changeset in webkit [210964] by matthew_hanson@apple.com

19 edits
2 copies
2 adds in branches/safari-603-branch/Source

Merge r210936. rdar://problem/30058349

8:25 AM Changeset in webkit [210963] by matthew_hanson@apple.com

2 edits in branches/safari-603-branch/Source/WebCore

Merge r210473. rdar://problem/29204422

8:25 AM Changeset in webkit [210962] by matthew_hanson@apple.com

7 edits in branches/safari-603-branch/Source/WebKit2

Merge r210913. rdar://problem/30086738

8:25 AM Changeset in webkit [210961] by matthew_hanson@apple.com

10 edits
5 adds in branches/safari-603-branch

Merge r210939. rdar://problem/29885052

8:25 AM Changeset in webkit [210960] by matthew_hanson@apple.com

2 edits in branches/safari-603-branch/Source/JavaScriptCore

Merge r210935. rdar://problem/30101860

4:17 AM Changeset in webkit [210959] by graouts@webkit.org

220 edits
4 copies
10 adds in trunk

[Modern Media Controls] Turn modern media controls on by default
https://bugs.webkit.org/show_bug.cgi?id=165668

Reviewed by Dean Jackson.

Source/WebCore:

Tests: media/modern-media-controls/fullscreen-support/ipad/fullscreen-support-tap.html

media/modern-media-controls/pip-support/ipad/pip-support-enabled.html
media/modern-media-controls/pip-support/ipad/pip-support-tap.html
media/modern-media-controls/placard-support/ipad/placard-support-pip.html
media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag.html

Fix an error which may be triggered prior to Sierra where we would assume the presentation
mode API was avaiable when it might not be, which caused a few tests to fail.

We also ensure that we always inject the UA styles for legacy media controls as otherwise
toggling from modern media controls to legacy media controls would not inject those styles.
To facilitate this we add a dedicated method for modern media controls styles in RenderTheme
that is only used in the case of modern media controls when the shadow root asks for the styles
to inject in the shadow root.

Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::shadowRootCSSText):

Modules/modern-media-controls/media/pip-support.js:

(PiPSupport.prototype.syncControl):
(PiPSupport):

css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):

rendering/RenderTheme.h:

(WebCore::RenderTheme::modernMediaControlsStyleSheet):

rendering/RenderThemeIOS.h:
rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::mediaControlsStyleSheet):
(WebCore::RenderThemeIOS::modernMediaControlsStyleSheet):

rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::mediaControlsStyleSheet):
(WebCore::RenderThemeMac::modernMediaControlsStyleSheet):

Source/WebKit/mac:

Enabled modern media controls by default in WK1.

WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

Source/WebKit2:

Use DEFAULT_EXPERIMENTAL_FEATURES_ENABLED as the default value for modern media controls, which is true.

Shared/WebPreferencesDefinitions.h:

Tools:

Enabled modern media controls by default in test runners.

DumpRenderTree/TestOptions.h:
WebKitTestRunner/TestOptions.h:

LayoutTests:

Turn modern media controls off for a majority of pre-existing tests that made assumptions on the implementation
of media controls.

For tests designed for modern media controls, we don't need to opt out since modern media controls are now on
by default, and we turn them back on since they were skipped. But we make these tests more resilient by:

adding iPad-specific tests
adding platform-agnostic ways to press an element, using either eventSender or uiController
checking that elements that are sized asynchronously are indeed sized before making assumptions to that effect
ensuring that we don't have additional scheduler.frameDidFire callbacks after we no longer need them

TestExpectations:
accessibility/mac/video-tag-hit-test.html:
accessibility/mac/video-volume-slider-accessibility.html:
accessibility/media-element.html:
accessibility/media-emits-object-replacement.html:
compositing/video/poster-expected.html:
compositing/video/poster.html:
fast/hidpi/video-controls-in-hidpi.html:
fast/layers/video-layer.html:
fullscreen/video-controls-drag.html:
fullscreen/video-controls-override.html:
fullscreen/video-controls-rtl.html:
fullscreen/video-controls-timeline.html:
http/tests/media/hls/video-controls-live-stream.html:
http/tests/media/hls/video-duration-accessibility.html:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-allowed.html:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked.html:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/default-src-object-data-url-blocked2.html:
http/tests/security/contentSecurityPolicy/userAgentShadowDOM/video-controls-allowed.html:
media/accessibility-closed-captions-has-aria-owns.html:
media/adopt-node-crash.html:
media/airplay-autoplay.html:
media/audio-as-video-fullscreen.html:
media/audio-controls-do-not-fade-out.html:
media/audio-controls-rendering.html:
media/audio-controls-timeline-in-media-document.html:
media/audio-delete-while-slider-thumb-clicked.html:
media/audio-repaint.html:
media/click-placeholder-not-pausing.html:
media/click-volume-bar-not-pausing.html:
media/controls-after-reload.html:
media/controls-drag-timebar.html:
media/controls-right-click-on-timebar.html:
media/controls-strict.html:
media/controls-styling.html:
media/controls-without-preload.html:
media/controls/airplay-controls.html:
media/controls/airplay-picker.html:
media/controls/basic.html:
media/controls/elementOrder.html:
media/controls/forced-tracks-only.html:
media/controls/fullscreen-button-inline-layout.html:
media/controls/inline-elements-dropoff-order.html:
media/controls/picture-in-picture.html:
media/controls/pip-placeholder-without-video-controls.html:
media/controls/showControlsButton.html:
media/controls/statusDisplay.html:
media/controls/statusDisplayBad.html:
media/controls/track-menu.html:
media/mac/controls-panel-not-clipped-out-expected.html:
media/mac/controls-panel-not-clipped-out.html:
media/media-captions-no-controls.html:
media/media-controller-drag-crash.html:
media/media-controls-accessibility.html:
media/media-controls-cancel-events.html:
media/media-controls-clone.html:
media/media-controls-drag-timeline-set-controls-property.html:
media/media-controls-timeline-updates-after-playing.html:
media/media-controls-timeline-updates-when-hovered.html:
media/media-controls-timeline-updates.html:
media/media-document-audio-controls-visible.html:
media/media-document-audio-repaint.html:
media/media-fullscreen-return-to-inline.html:
media/modern-media-controls/airplay-button/airplay-button-on.html:
media/modern-media-controls/airplay-button/airplay-button.html:
media/modern-media-controls/airplay-placard/airplay-placard-text-section.html:
media/modern-media-controls/audio/audio-controls-buttons-expected.txt:
media/modern-media-controls/audio/audio-controls-buttons.html:
media/modern-media-controls/audio/audio-controls-metrics.html:
media/modern-media-controls/button/button.html:
media/modern-media-controls/buttons-container/buttons-container-buttons-property.html:
media/modern-media-controls/forward-button/forward-button.html:
media/modern-media-controls/fullscreen-button/fullscreen-button.html:
media/modern-media-controls/fullscreen-support/fullscreen-support-click.html:
media/modern-media-controls/fullscreen-support/ipad/fullscreen-support-tap-expected.txt: Added.
media/modern-media-controls/fullscreen-support/ipad/fullscreen-support-tap.html: Added.
media/modern-media-controls/icon-button/icon-button-active-state.html:
media/modern-media-controls/icon-button/icon-button-on.html:
media/modern-media-controls/icon-button/icon-button.html:
media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-buttons-styles.html:
media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-controls-bar-styles.html:
media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-layout.html:
media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-time-control-styles.html:
media/modern-media-controls/ios-inline-media-controls/ios-inline-media-dropping-controls.html:
media/modern-media-controls/layout-node/addChild.html:
media/modern-media-controls/layout-node/children.html:
media/modern-media-controls/layout-node/height.html:
media/modern-media-controls/layout-node/insertAfter.html:
media/modern-media-controls/layout-node/insertBefore.html:
media/modern-media-controls/layout-node/node-made-dirty-during-layout.html:
media/modern-media-controls/layout-node/remove.html:
media/modern-media-controls/layout-node/removeChild.html:
media/modern-media-controls/layout-node/subclassing.html:
media/modern-media-controls/layout-node/visible.html:
media/modern-media-controls/layout-node/width.html:
media/modern-media-controls/layout-node/x.html:
media/modern-media-controls/layout-node/y.html:
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html:
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html:
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-controls-bar-styles.html:
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html:
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-right-container-margin.html:
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-time-control-styles.html:
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-volume-styles.html:
media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-buttons-styles.html:
media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-controls-bar-styles.html:
media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-layout.html:
media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-status-label.html:
media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-time-control-styles.html:
media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-volume-styles.html:
media/modern-media-controls/macos-inline-media-controls/macos-inline-media-dropping-controls.html:
media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-and-mouse-leave.html:
media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-enter-over-controls-bar.html:
media/modern-media-controls/media-controller/media-controller-auto-hide-mouse-leave-after-play.html:
media/modern-media-controls/media-controller/media-controller-auto-hide-pause.html:
media/modern-media-controls/media-controller/media-controller-auto-hide-rewind-with-mouse-enter.html:
media/modern-media-controls/media-controller/media-controller-auto-hide.html:
media/modern-media-controls/media-controller/media-controller-fade-controls-when-entering-fullscreen.html:
media/modern-media-controls/media-controller/media-controller-fullscreen-ltr.html:
media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-inline.html:
media/modern-media-controls/media-controller/media-controller-inline-to-fullscreen-to-pip-to-inline.html:
media/modern-media-controls/media-controller/media-controller-resize.html:
media/modern-media-controls/media-controller/media-controller-scale-factor.html:
media/modern-media-controls/media-controller/media-controller-single-container.html:
media/modern-media-controls/mute-button/mute-button.html:
media/modern-media-controls/pip-button/pip-button.html:
media/modern-media-controls/pip-placard/pip-placard-text-section.html:
media/modern-media-controls/pip-support/ipad/pip-support-enabled-expected.txt: Added.
media/modern-media-controls/pip-support/ipad/pip-support-enabled.html: Copied from LayoutTests/media/modern-media-controls/pip-support/pip-support-enabled.html.
media/modern-media-controls/pip-support/ipad/pip-support-tap-expected.txt: Added.
media/modern-media-controls/pip-support/ipad/pip-support-tap.html: Copied from LayoutTests/media/modern-media-controls/pip-support/pip-support-click.html.
media/modern-media-controls/pip-support/pip-support-click.html:
media/modern-media-controls/pip-support/pip-support-enabled.html:
media/modern-media-controls/placard-support/ipad/placard-support-pip-expected.txt: Copied from LayoutTests/media/modern-media-controls/placard-support/placard-support-airplay-expected.txt.
media/modern-media-controls/placard-support/ipad/placard-support-pip.html: Added.
media/modern-media-controls/placard-support/placard-support-airplay-expected.txt:
media/modern-media-controls/play-pause-button/play-pause-button.html:
media/modern-media-controls/playback-support/playback-support-button-click-expected.txt:
media/modern-media-controls/playback-support/playback-support-button-click.html:
media/modern-media-controls/resources/media-controls-utils.js:

(pressOnElement):
(finishMediaControlsTest):

media/modern-media-controls/rewind-button/rewind-button.html:
media/modern-media-controls/scheduler/not-reentrant.html:
media/modern-media-controls/scheduler/single-callback-when-registered-multiple-times.html:
media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag-expected.txt: Copied from LayoutTests/media/modern-media-controls/scrubber-support/scrubber-support-drag-expected.txt.
media/modern-media-controls/scrubber-support/ipad/scrubber-support-drag.html: Added.
media/modern-media-controls/scrubber-support/scrubber-support-click.html:
media/modern-media-controls/scrubber-support/scrubber-support-drag-expected.txt:
media/modern-media-controls/scrubber-support/scrubber-support-drag.html:
media/modern-media-controls/seek-backward-support/seek-backward-support.html:
media/modern-media-controls/seek-forward-support/seek-forward-support.html:
media/modern-media-controls/skip-back-button/skip-back-button.html:
media/modern-media-controls/slider/slider-fill.html:
media/modern-media-controls/slider/slider-styles.html:
media/modern-media-controls/start-support/start-support-click-to-start-expected.txt:
media/modern-media-controls/start-support/start-support-click-to-start.html:
media/modern-media-controls/status-label/status-label-font.html:
media/modern-media-controls/status-label/status-label-text-selection.html:
media/modern-media-controls/status-label/status-label.html:
media/modern-media-controls/time-label/time-label.html:
media/modern-media-controls/tracks-button/tracks-button.html:
media/modern-media-controls/tracks-panel/tracks-panel-right-x.html:
media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-keyboard.html:
media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html:
media/modern-media-controls/tracks-support/tracks-support-show-and-populate-panel.html:
media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls-expected.txt:
media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html:
media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html:
media/modern-media-controls/volume-slider/volume-slider-value.html:
media/modern-media-controls/volume-support/volume-support-click.html:
media/modern-media-controls/volume-support/volume-support-drag.html:
media/nodesFromRect-shadowContent.html:
media/progress-events-generated-correctly.html:
media/require-user-gesture-to-load-video.html:
media/tab-focus-inside-media-elements.html:
media/track/track-cue-rendering-horizontal.html:
media/track/track-cue-rendering-vertical.html:
media/track/track-cues-cuechange.html:
media/track/track-cues-enter-exit.html:
media/track/track-in-band-duplicate-tracks-when-source-changes.html:
media/track/track-manual-mode.html:
media/video-controls-audiotracks-trackmenu.html:
media/video-controls-captions-trackmenu-localized.html:
media/video-controls-captions-trackmenu-only-captions-descriptions-and-subtitles.html:
media/video-controls-captions-trackmenu-sorted.html:
media/video-controls-captions-trackmenu.html:
media/video-controls-drop-and-restore-timeline.html:
media/video-controls-in-media-document.html:
media/video-controls-no-display-with-text-track.html:
media/video-controls-rendering.html:
media/video-controls-show-on-kb-or-ax-event.html:
media/video-controls-toggling.html:
media/video-controls-transformed.html:
media/video-controls-visible-audio-only.html:
media/video-controls-visible-exiting-fullscreen.html:
media/video-controls-zoomed.html:
media/video-display-toggle.html:
media/video-empty-source.html:
media/video-fullscreeen-only-controls.html:
media/video-fullscreeen-only-playback.html:
media/video-initially-hidden-volume-slider-up.html:
media/video-no-audio.html:
media/video-play-audio-require-user-gesture.html:
media/video-play-require-user-gesture.html:
media/video-trackmenu-selection.html:
media/video-volume-slider-drag.html:
media/video-volume-slider.html:
media/video-zoom-controls.html:
media/volume-bar-empty-when-muted.html:
platform/gtk/TestExpectations:
platform/ios-simulator/TestExpectations:
platform/ios-simulator/media/video-play-glyph-composited-outside-overflow-scrolling-touch-container.html:
platform/mac-wk1/TestExpectations:
platform/mac/TestExpectations:

3:43 AM Changeset in webkit [210958] by gskachkov@gmail.com

8 edits in trunk

Super property access in base class constructor doesn't work
https://bugs.webkit.org/show_bug.cgi?id=166665

Reviewed by Ryosuke Niwa.

Source/JavaScriptCore:

Allow to use super inside of the constructor for classes
without parent class.
Parser checks if super used within the constructor and
add this information to function metedata, and later it is used
during byte code generation.

bytecompiler/NodesCodegen.cpp:

(JSC::ClassExprNode::emitBytecode):

parser/Parser.cpp:

(JSC::Parser<LexerType>::parseFunctionBody):
(JSC::Parser<LexerType>::parseFunctionInfo):

parser/Parser.h:

(JSC::Scope::usesEval):
(JSC::Scope::fillParametersForSourceProviderCache):
(JSC::Scope::restoreFromSourceProviderCache):
(JSC::Parser::adjustSuperBindingForBaseConstructor):