Timeline

Jan 22, 2017:

11:28 PM Changeset in webkit [211035] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

Database file not removed for origins after deleting all databases
​https://bugs.webkit.org/show_bug.cgi?id=167281

Reviewed by Darin Adler.

When DatabaseTracker::deleteDatabasesModifiedSince() is called with a min time, all databases for every origin
are deleted. For each origin if all databases are removed DatabaseTracker::deleteOrigin() is called to remove
also the origin database file. However, DatabaseTracker::deleteOrigin() returns early if the origin doesn't have
databases and in this particular case it never has databases, because we have just removed them.

This will be covered by GTK+ unit tests.

• Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::deleteDatabasesModifiedSince): Instead of removing the databases while iterating
them, add the ones to be removed to a vector. If after the iteration all databases should be removed call
DatabaseTracker::deleteOrigin() to ensure both the databases and the database file are removed for the origin,
otherwhise call DatabaseTracker::deleteDatabase() for every database to delete.

11:25 PM Changeset in webkit [211034] by Michael Catanzaro

• 2 edits in trunk/Source/WebCore

[GTK] Update Safari version in user agent
​https://bugs.webkit.org/show_bug.cgi?id=167290

Reviewed by Carlos Garcia Campos.

Update Safari version from 10 to 11.

• platform/gtk/UserAgentGtk.cpp:

(WebCore::buildUserAgentString):

10:24 PM Changeset in webkit [211033] by Darin Adler

• 135 edits in trunk/Source

Remove PassRefPtr from "page" directory of WebCore, also deploy references
​https://bugs.webkit.org/show_bug.cgi?id=167224

Reviewed by Chris Dumez.

Source/WebCore:

• Modules/fetch/DOMWindowFetch.cpp:

(WebCore::DOMWindowFetch::fetch): Use DOMWindow::document instead of
scriptExecutionContext.

• Modules/webdatabase/DatabaseContext.cpp:

(WebCore::DatabaseContext::databaseExceededQuota): Pass a reference.

• accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityShowContextMenu]):
Pass a reference.

• bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertySlot): Pass a reference.

• dom/Document.cpp:

(WebCore::Document::childrenChanged): Pass a reference. Also made the
didReceiveDocType code unconditional instead of iOS-only.
(WebCore::Document::platformSuspendOrStopActiveDOMObjects): Ditto.
(WebCore::Document::updateViewportArguments): Ditto.
(WebCore::Document::setFocusedElement): Ditto.
(WebCore::Document::createDOMWindow): Ditto.
(WebCore::Document::takeDOMWindowFrom): Ditto.
(WebCore::Document::requestFullScreenForElement): Ditto.
(WebCore::Document::webkitExitFullscreen): Ditto.

• dom/Element.cpp:

(WebCore::Element::focus): Ditto.
(WebCore::Element::blur): Ditto.
(WebCore::Element::dispatchFocusEvent): Ditto.
(WebCore::Element::dispatchBlurEvent): Ditto.

• dom/Node.cpp:

(WebCore::Node::defaultEventHandler): Ditto.

• editing/EditorCommand.cpp:

(WebCore::executePrint): Ditto.

• editing/FrameSelection.cpp:

(WebCore::FrameSelection::setFocusedElementIfNeeded): Ditto.

• history/CachedFrame.cpp:

(WebCore::CachedFrameBase::restore): Ditto.
(WebCore::CachedFrame::CachedFrame): Ditto.

• html/ColorInputType.cpp:

(WebCore::ColorInputType::handleDOMActivateEvent): Ditto.

• html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::isKeyboardFocusable): Ditto.

• html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::isKeyboardFocusable): Pass a reference,
and also rewrote to use && for clarity.

• html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::supportsFullscreen): Pass a reference.

• html/shadow/SpinButtonElement.cpp:

(WebCore::SpinButtonElement::defaultEventHandler): Ditto.
(WebCore::SpinButtonElement::releaseCapture): Ditto.

• html/shadow/mac/ImageControlsButtonElementMac.cpp:

(WebCore::ImageControlsButtonElementMac::defaultEventHandler): Ditto.

• inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::showContextMenu): Ditto.
(WebCore::InspectorFrontendHost::dispatchEventAsContextMenuEvent): Ditto.

• loader/EmptyClients.cpp:

(WebCore::EmptyChromeClient::createPopupMenu): Updated to take reference.
(WebCore::EmptyChromeClient::createSearchPopupMenu): Ditto.
(WebCore::EmptyChromeClient::createColorChooser): Ditto.

• loader/EmptyClients.h: Ditto.

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::submitForm): Pass a reference.
(WebCore::FrameLoader::commitProvisionalLoad): Ditto.
(WebCore::FrameLoader::closeAndRemoveChild): Take a reference.
(WebCore::FrameLoader::detachFromParent): Pass a reference.
(WebCore::FrameLoader::dispatchBeforeUnloadEvent): Ditto.
(WebCore::createWindow): Ditto.

• loader/FrameLoader.h: Updated for the above.

• loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNewWindowPolicy): Pass a reference.

• loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::recalculateAvailableSpaceInQuota): Ditto.

• loader/appcache/ApplicationCacheGroup.h: Return a reference from origin.

• loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::calculateQuotaForOrigin): Take a reference.
(WebCore::ApplicationCacheStorage::calculateRemainingSizeForOriginExcludingCache):
Ditto.
(WebCore::ApplicationCacheStorage::store): Pass a reference.
(WebCore::ApplicationCacheStorage::checkOriginQuota): Updated since origin
now returns areference.

• loader/appcache/ApplicationCacheStorage.h: Updated for the above.

• loader/archive/mhtml/MHTMLArchive.cpp:

(WebCore::MHTMLArchive::generateMHTMLData): Pass a reference.

• mathml/MathMLElement.cpp:

(WebCore::MathMLElement::isKeyboardFocusable): Ditto.

• page/Chrome.cpp:

(WebCore::Chrome::Chrome): Moved initialization of data members to the
class definition.
(WebCore::Chrome::contentsSizeChanged): Take a reference.
(WebCore::Chrome::createWindow): Ditto.
(WebCore::Chrome::runBeforeUnloadConfirmPanel): Ditto.
(WebCore::Chrome::runJavaScriptAlert): Ditto.
(WebCore::Chrome::runJavaScriptConfirm): Ditto.
(WebCore::Chrome::runJavaScriptPrompt): Ditto.
(WebCore::Chrome::setStatusbarText): Ditto.
(WebCore::Chrome::print): Ditto.
(WebCore::Chrome::createColorChooser): Ditto.
(WebCore::Chrome::createPopupMenu): Ditto.
(WebCore::Chrome::createSearchPopupMenu): Ditto.
(WebCore::Chrome::didReceiveDocType): Ditto. Also made unconditional, but
empty for non-iOS platforms.
(WebCore::Chrome::registerPopupOpeningObserver): Take a reference.
(WebCore::Chrome::unregisterPopupOpeningObserver): Ditto.

• page/Chrome.h: Updated for the above.

• page/ChromeClient.h: Take references. Also updated some arguments from

Node to Element.

• page/ContextMenuController.cpp:

(WebCore::ContextMenuController::handleContextMenuEvent): Take a reference.
(WebCore::ContextMenuController::showContextMenu): Ditto.
(WebCore::ContextMenuController::maybeCreateContextMenu): Ditto. Also use
make_unique instead of unique_ptr plus new.
(WebCore::openNewWindow): Ditto.
(WebCore::insertUnicodeCharacter): Ditto.
(WebCore::ContextMenuController::contextMenuItemSelected): Ditto.
(WebCore::ContextMenuController::showContextMenuAt): Ditto.
(WebCore::ContextMenuController::showImageControlsMenu): Ditto.

• page/ContextMenuController.h: Updated for the above.

• page/DOMTimer.cpp:

(WebCore::DOMTimer::fired): Pass a reference.

• page/DOMWindow.cpp:

(WebCore::PostMessageTimer::PostMessageTimer): Take Ref&& instead of
PassRefPtr.
(WebCore::DOMWindow::adjustWindowRect): Use a reference.

(WebCore::DOMWindow::allowPopUp): Ditto. Also rewrite to use

instead

of successive if statements.
(WebCore::DOMWindow::canShowModalDialog): Ditto.
(WebCore::DOMWindow::DOMWindow): Ditto.
(WebCore::DOMWindow::didSecureTransitionTo): Ditto.
(WebCore::DOMWindow::registerProperty): Ditto.
(WebCore::DOMWindow::unregisterProperty): Ditto.
(WebCore::DOMWindow::postMessageTimerFired): Merge with the function
immediately followed, called only from here.
(WebCore::DOMWindow::dispatchMessageEventWithOriginCheck): Deleted.
(WebCore::DOMWindow::print): Pass a reference.
(WebCore::DOMWindow::alert): Ditto.
(WebCore::DOMWindow::confirm): Ditto.
(WebCore::DOMWindow::prompt): Ditto.
(WebCore::DOMWindow::setStatus): Ditto.
(WebCore::DOMWindow::setDefaultStatus): Ditto.
(WebCore::DOMWindow::moveBy): Ditto.
(WebCore::DOMWindow::moveTo): Ditto.
(WebCore::DOMWindow::resizeBy): Ditto.
(WebCore::DOMWindow::resizeTo): Ditto.
(WebCore::DOMWindow::clearTimeout): Ditto.
(WebCore::DOMWindow::incrementScrollEventListenersCount): Ditto.
(WebCore::DOMWindow::decrementScrollEventListenersCount): Ditto.
(WebCore::DOMWindow::showModalDialog): Ditto.

• page/DOMWindow.h: Updated for the above. ALso made functions private

and final.

• page/DOMWindowProperty.cpp:

(WebCore::DOMWindowProperty::DOMWindowProperty): Pass a reference.
(WebCore::DOMWindowProperty::~DOMWindowProperty): Ditto.
(WebCore::DOMWindowProperty::willDestroyGlobalObjectInCachedFrame): Ditto.
(WebCore::DOMWindowProperty::willDestroyGlobalObjectInFrame): Ditto.

• page/DebugPageOverlays.cpp:

(WebCore::RegionOverlay::create): Return RefPtr instead of PassRefPtr.
(WebCore::RegionOverlay::~RegionOverlay): Pass a reference.
(WebCore::DebugPageOverlays::showRegionOverlay): Ditto.
(WebCore::DebugPageOverlays::hideRegionOverlay): Ditto.

• page/DragController.cpp:

(WebCore::DragController::dragExited): Pass a reference.
(WebCore::DragController::performDragOperation): Ditto.
(WebCore::DragController::concludeEditDrag): Ditto.
(WebCore::DragController::tryDHTMLDrag): Ditto.

• page/EventHandler.cpp: Replaced OptionalCursor with std::optional<Cursor>.

(WebCore::EventHandler::updateCursor): Refactor into two functions so we
can share more code with selectCursor.
(WebCore::EventHandler::selectCursor): Updated to use std::optional.
(WebCore::EventHandler::handleMouseMoveEvent): Use the new updateCursor.
(WebCore::EventHandler::startPanScrolling): Use a reference.
(WebCore::EventHandler::updateDragAndDrop): Ditto.
(WebCore::EventHandler::cancelDragAndDrop): Ditto.
(WebCore::EventHandler::performDragAndDrop): Ditto.
(WebCore::EventHandler::setCapturingMouseEventsElement): Take a raw pointer
instead of a PassRefPtr.
(WebCore::EventHandler::dispatchMouseEvent): Use a reference.
(WebCore::EventHandler::updateDragStateAfterEditDragIfNeeded): Ditto.
(WebCore::EventHandler::isKeyboardOptionTab): Ditto.
(WebCore::EventHandler::eventInvertsTabsToLinksClientCallResult): Ditto.
(WebCore::EventHandler::tabsToLinks): Ditto.

• page/EventHandler.h: Updated for the above.

• page/FocusController.cpp:

(WebCore::FocusController::setFocusedFrame): Take pointer instead
of PassRefPtr.
(WebCore::FocusController::setFocusedElement): Take reference instead of
PassRefPtr.

• page/FocusController.h: Updated for the above changes.

• page/FrameTree.cpp:

(WebCore::FrameTree::transferChild): Deleted. Unused function.
(WebCore::FrameTree::appendChild): Merged with the following function
since it's now only used here. Take reference instead of PassRefPtr.
(WebCore::FrameTree::actuallyAppendChild): Deleted.
(WebCore::FrameTree::removeChild): Take reference instead of pointer.
Use move instead of trickier swap.

• page/FrameTree.h: Updated for the above.

• page/FrameView.cpp:

(WebCore::FrameView::setContentsSize): Use a reference.

• page/MainFrame.cpp:

(WebCore::MainFrame::dropChildren): Ditto.

• page/Page.cpp:

(WebCore::Page::scrollingCoordinator): Ditto.

• page/PageOverlay.cpp:

(WebCore::PageOverlay::fadeAnimationTimerFired): Ditto.

• page/PageOverlayController.cpp:

(WebCore::PageOverlayController::installPageOverlay): Take reference
instead of PassRefPtr.
(WebCore::PageOverlayController::uninstallPageOverlay): Take reference
intead of pointer.

• page/PageOverlayController.h: Updated for the above.

• page/PageSerializer.cpp:

(WebCore::PageSerializer::PageSerializer): Moved most initialization to the
class definition.
(WebCore::PageSerializer::serialize): Use reference.
(WebCore::PageSerializer::serializeFrame): Use initializer list instead of
constructor for resource.
(WebCore::PageSerializer::serializeCSSStyleSheet): Ditto.
(WebCore::PageSerializer::addImageToResources): Ditto.

• page/PageSerializer.h: Removed constructors from PageSerializer::Resource

struct since structures don't really need them. Updated for the above.
Changed SerializerMarkupAccumulator into a nested class.

• page/PerformanceEntry.h:

(WebCore::PerformanceEntry::startTimeCompareLessThan): Use const RefPtr&
instead of PassRefPtr to compare RefPtr in place.

• page/PerformanceUserTiming.cpp:

(WebCore::insertPerformanceEntry): Take Ref&& instead of PassRefPtr.

• page/ResourceUsageOverlay.cpp:

(WebCore::ResourceUsageOverlay::~ResourceUsageOverlay): Use refrence.
(WebCore::ResourceUsageOverlay::initialize): Ditto.

• page/animation/AnimationBase.h: Removed unneeded include.

• page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::clear): Use reference.
(WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle): Ditto.
(WebCore::AnimationControllerPrivate::addEventToDispatch): Use the
append function instead of a hand-written alternative.
(WebCore::AnimationControllerPrivate::addElementChangeToDispatch):
Take a reference rather than a Ref&& since no caller is passing ownership.

• page/animation/AnimationControllerPrivate.h: Updated for the above.

• page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc): Return RefPtr instead of PassRefPtr.
(WebCore::blendFilter): Ditto.
(WebCore::crossfadeBlend): Ditto.

• page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::updateTransitions): Updated to use
animationForProperty, which returns a raw pointer.
(WebCore::CompositeAnimation::animationForProperty): Renamed from
getAnimationForProperty and changed to return raw pointer instead
of PassRefPtr.

• page/animation/CompositeAnimation.h: Updated for the above.

• page/animation/ImplicitAnimation.cpp:

(WebCore::ImplicitAnimation::onAnimationEnd): Use animationForProperty.
(WebCore::ImplicitAnimation::sendTransitionEvent): Pass reference.

• page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::sendAnimationEvent): Ditto.

• page/efl/EventHandlerEfl.cpp:

(WebCore::EventHandler::tabsToAllFormControls): Take reference.
(WebCore::EventHandler::createDraggingDataTransfer): Return Ref.

• page/gtk/EventHandlerGtk.cpp:

(WebCore::EventHandler::tabsToAllFormControls): Ditto.
(WebCore::EventHandler::createDraggingDataTransfer): Ditto.

• page/ios/EventHandlerIOS.mm:

(WebCore::EventHandler::tabsToAllFormControls): Ditto.

• page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::createDraggingDataTransfer): Ditto.
(WebCore::EventHandler::tabsToAllFormControls): Ditto.
(WebCore::EventHandler::platformPrepareForWheelEvents): Ditto.

• page/mac/ServicesOverlayController.h: Take Ref&& for ranges instead

of PassRefPtr. Use references.

• page/mac/ServicesOverlayController.mm:

(WebCore::ServicesOverlayController::Highlight::createForSelection): Ditto.
(WebCore::ServicesOverlayController::Highlight::createForTelephoneNumber): Ditto.
(WebCore::ServicesOverlayController::Highlight::Highlight): Ditto.
(WebCore::ServicesOverlayController::buildPotentialHighlightsIfNeeded): Ditto.
(WebCore::ServicesOverlayController::buildPhoneNumberHighlights): Ditto.
(WebCore::ServicesOverlayController::buildSelectionHighlight): Ditto.
(WebCore::ServicesOverlayController::highlightsAreEquivalent): Ditto.
(WebCore::ServicesOverlayController::findTelephoneNumberHighlightContainingSelectionHighlight): Ditto.
(WebCore::ServicesOverlayController::handleClick): Ditto.

• page/mac/TextIndicatorWindow.mm:

(-[WebTextIndicatorView initWithFrame:textIndicator:margin:offset:]):
Take a reference instead of PassRefPtr.
(WebCore::TextIndicatorWindow::setTextIndicator): Updated for the above.

• page/scrolling/AsyncScrollingCoordinator.h: Use Ref&& and RefPtr intead

of PsasRefPtr.

• page/scrolling/ScrollLatchingState.cpp:

(WebCore::ScrollLatchingState::ScrollLatchingState): Initialize data members
in class definition.
(WebCore::ScrollLatchingState::setWheelEventElement): Use raw pointer instead
of PassRefPtr.
(WebCore::ScrollLatchingState::setPreviousWheelScrolledElement): Use raw
pointer instead of RefPtr&&.
(WebCore::ScrollLatchingState::setScrollableContainer): Use raw pointer instead
of PassRefPtr.

• page/scrolling/ScrollLatchingState.h: Updated for the above.

• page/scrolling/ScrollingStateNode.cpp:

(WebCore::ScrollingStateNode::cloneAndReset): Use Ref instead of PassRefPtr.
(WebCore::ScrollingStateNode::appendChild): Use Ref&& instead of PassRefPtr.

• page/scrolling/ScrollingStateNode.h: Updated for the above.

• page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::createNode): Use Ref instead of PassRefPtr.
(WebCore::ScrollingStateTree::attachNode): Updated for the abve.
(WebCore::ScrollingStateTree::commit): Ditto.

• page/scrolling/ScrollingStateTree.h: Ditto.

• page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::updateTreeFromStateNode): Use reference.

• page/scrolling/ScrollingTree.h: Return Ref instead of PassRefPtr.

• page/scrolling/ScrollingTreeNode.cpp:

(WebCore::ScrollingTreeNode::appendChild): Take Ref&& instead of PassRefPtr.
(WebCore::ScrollingTreeNode::removeChild): Take reference instead of pointer.

• page/scrolling/ScrollingTreeNode.h: Updated for the above.

• page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::ThreadedScrollingTree): Take reference
instead of pointer.

• page/scrolling/ThreadedScrollingTree.h: Updated for the above.

• page/scrolling/ios/ScrollingCoordinatorIOS.mm:

(WebCore::ScrollingCoordinatorIOS::ScrollingCoordinatorIOS): Pass reference.

• page/scrolling/ios/ScrollingTreeIOS.cpp:

(WebCore::ScrollingTreeIOS::create): Take a reference.
(WebCore::ScrollingTreeIOS::ScrollingTreeIOS): Ditto.
(WebCore::ScrollingTreeIOS::createScrollingTreeNode): Return Ref instead of
PassRefPtr.

• page/scrolling/ios/ScrollingTreeIOS.h: Updated for the above.

• page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::ScrollingCoordinatorMac): Use reference.

• page/scrolling/mac/ScrollingTreeMac.cpp:

(ScrollingTreeMac::create): Take a reference.
(ScrollingTreeMac::ScrollingTreeMac): Ditto.
(ScrollingTreeMac::createScrollingTreeNode): Return a Ref instead of a
PassRefPtr.

• page/scrolling/mac/ScrollingTreeMac.h: Updated for the above.

• page/win/EventHandlerWin.cpp:

(WebCore::EventHandler::tabsToAllFormControls): Take reference.
(WebCore::EventHandler::createDraggingDataTransfer): Return Ref.

• platform/Cursor.h: Rearranged the header a bit. Got rid of the explicit

copy constructor, assignment operator, and destructor. Using the ones
that the compiler automatically generates will work for all platforms and
we then also get move constructor and move assignment operator.

• platform/efl/CursorEfl.cpp:

(WebCore::Cursor::Cursor): Deleted.
(WebCore::Cursor::~Cursor): Deleted.
(WebCore::Cursor::operator=): Deleted.

• platform/gtk/CursorGtk.cpp:

(WebCore::Cursor::Cursor): Deleted.
(WebCore::Cursor::operator=): Deleted.
(WebCore::Cursor::~Cursor): Deleted.

• platform/mac/CursorMac.mm:

(WebCore::Cursor::Cursor): Deleted.
(WebCore::Cursor::operator=): Deleted.
(WebCore::Cursor::~Cursor): Deleted.

• platform/win/CursorWin.cpp:

(WebCore::SharedCursor::SharedCursor): Moved this here from the header
since it is only used within this file.
(WebCore::SharedCursor::create): Ditto.
(WebCore::Cursor::Cursor): Deleted.
(WebCore::Cursor::operator=): Deleted.
(WebCore::Cursor::~Cursor): Deleted.

• rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::handleUnavailablePluginIndicatorEvent):
Pass reference.

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking): Get to FrameView
through the render tree itself, rather than through the frame.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateLayerForHeader): Use reference.
(WebCore::RenderLayerCompositor::updateLayerForFooter): Ditto.
(WebCore::RenderLayerCompositor::attachRootLayer): Ditto.
(WebCore::RenderLayerCompositor::detachRootLayer): Ditto.

• rendering/RenderMenuList.cpp:

(RenderMenuList::showPopup): Ditto.

• rendering/RenderSearchField.cpp:

(WebCore::RenderSearchField::addSearchResult): Ditto.
(WebCore::RenderSearchField::showPopup): Ditto.
(WebCore::RenderSearchField::valueChanged): Ditto.

• svg/SVGAElement.cpp:

(WebCore::SVGAElement::isKeyboardFocusable): Ditto.

• testing/MockPageOverlayClient.cpp:

(WebCore::MockPageOverlayClient::installOverlay): Ditto.
(WebCore::MockPageOverlayClient::uninstallAllOverlays): Ditto.

Source/WebKit/ios:

• WebCoreSupport/WebChromeClientIOS.h: Update for changes to ChromeClient.
• WebCoreSupport/WebChromeClientIOS.mm:

(WebChromeClientIOS::runJavaScriptAlert): Ditto.
(WebChromeClientIOS::runJavaScriptConfirm): Ditto.
(WebChromeClientIOS::runJavaScriptPrompt): Ditto.
(WebChromeClientIOS::setNeedsScrollNotifications): Ditto.
(WebChromeClientIOS::observedContentChange): Ditto.
(WebChromeClientIOS::clearContentChangeObservers): Ditto.
(WebChromeClientIOS::notifyRevealedSelectionByScrollingFrame): Ditto.
(WebChromeClientIOS::elementDidFocus): Ditto.
(WebChromeClientIOS::elementDidBlur): Ditto.
(WebChromeClientIOS::createPopupMenu): Ditto.
(WebChromeClientIOS::createSearchPopupMenu): Ditto.
(WebChromeClientIOS::attachRootGraphicsLayer): Ditto.

Source/WebKit/mac:

• WebCoreSupport/WebApplicationCacheQuotaManager.mm:

(-[WebApplicationCacheQuotaManager quota]): Pass reference.

• WebCoreSupport/WebChromeClient.h: Updated for changes to ChromeClient.
• WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::focusedElementChanged): Ditto.
(WebChromeClient::createWindow): Ditto.
(WebChromeClient::runBeforeUnloadConfirmPanel): Ditto.
(WebChromeClient::runJavaScriptAlert): Ditto.
(WebChromeClient::runJavaScriptConfirm): Ditto.
(WebChromeClient::runJavaScriptPrompt): Ditto.
(WebChromeClient::contentsSizeChanged): Ditto.
(WebChromeClient::unavailablePluginButtonClicked): Ditto.
(WebChromeClient::print): Ditto.
(WebChromeClient::exceededDatabaseQuota): Ditto.
(WebChromeClient::reachedApplicationCacheOriginQuota): Ditto.
(WebChromeClient::createColorChooser): Ditto.
(WebChromeClient::elementDidFocus): Ditto.
(WebChromeClient::elementDidBlur): Ditto.
(WebChromeClient::createPopupMenu): Ditto.
(WebChromeClient::createSearchPopupMenu): Ditto.
(WebChromeClient::attachRootGraphicsLayer): Ditto.
(WebChromeClient::attachViewOverlayGraphicsLayer): Ditto.
(WebChromeClient::supportsFullScreenForElement): Ditto.
(WebChromeClient::enterFullScreenForElement): Ditto.
(WebChromeClient::exitFullScreenForElement): Ditto.

• WebView/WebFrame.mm:

(+[WebFrame _createFrameWithPage:frameName:frameView:ownerElement:]):
Updated for change to the appendChild function.

Source/WebKit/win:

• Plugins/PluginView.cpp:

(WebCore::PluginView::status): Pass reference.
(WebCore::PluginView::focusPluginElement): Ditto.

• WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::createWindow): Updated for change to ChromeClient.
(WebChromeClient::runBeforeUnloadConfirmPanel): Ditto.
(WebChromeClient::runJavaScriptAlert): Ditto.
(WebChromeClient::runJavaScriptConfirm): Ditto.
(WebChromeClient::runJavaScriptPrompt): Ditto.
(WebChromeClient::contentsSizeChanged): Ditto.
(WebChromeClient::unavailablePluginButtonClicked): Ditto.
(WebChromeClient::print): Ditto.
(WebChromeClient::exceededDatabaseQuota): Ditto.
(WebChromeClient::reachedApplicationCacheOriginQuota): Ditto.
(WebChromeClient::attachRootGraphicsLayer): Ditto.
(WebChromeClient::attachViewOverlayGraphicsLayer): Ditto.
(WebChromeClient::enterVideoFullscreenForVideoElement): Ditto.
(WebChromeClient::createPopupMenu): Ditto.
(WebChromeClient::createSearchPopupMenu): Ditto.
(WebChromeClient::supportsFullScreenForElement): Ditto.
(WebChromeClient::enterFullScreenForElement): Ditto.
(WebChromeClient::exitFullScreenForElement): Ditto.
(WebChromeClient::shouldUseTiledBackingForFrameView): Ditto.

• WebCoreSupport/WebChromeClient.h: Ditto.

Source/WebKit2:

• UIProcess/Scrolling/RemoteScrollingTree.cpp:

(WebKit::RemoteScrollingTree::createScrollingTreeNode): Return a Ref
instead of PassRefPtr.

• UIProcess/Scrolling/RemoteScrollingTree.h: Updated for the above.

• WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageInstallPageOverlay): Pass a reference.
(WKBundlePageUninstallPageOverlay): Ditto.
(WKBundlePageInstallPageOverlayWithAnimation): Ditto.
(WKBundlePageUninstallPageOverlayWithAnimation): Ditto.

• WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm:

(WebKit::PDFPlugin::jsPDFDocPrint): Ditto.

• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::focusPluginElement): Ditto.
(WebKit::PluginView::setStatusbarText): Ditto.

• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::elementDidFocus): Updated for changes to ChromeClient.
(WebKit::WebChromeClient::elementDidBlur): Ditto.
(WebKit::WebChromeClient::makeFirstResponder): Ditto.
(WebKit::WebChromeClient::createWindow): Ditto.
(WebKit::WebChromeClient::runBeforeUnloadConfirmPanel): Ditto.
(WebKit::WebChromeClient::runJavaScriptAlert): Ditto.
(WebKit::WebChromeClient::runJavaScriptConfirm): Ditto.
(WebKit::WebChromeClient::runJavaScriptPrompt): Ditto.
(WebKit::WebChromeClient::contentsSizeChanged): Ditto.
(WebKit::WebChromeClient::unavailablePluginButtonClicked): Ditto.
(WebKit::WebChromeClient::print): Ditto.
(WebKit::WebChromeClient::exceededDatabaseQuota): Ditto.
(WebKit::WebChromeClient::reachedApplicationCacheOriginQuota): Ditto.
(WebKit::WebChromeClient::createColorChooser): Ditto.
(WebKit::WebChromeClient::createPopupMenu): Ditto.
(WebKit::WebChromeClient::createSearchPopupMenu): Ditto.
(WebKit::WebChromeClient::attachRootGraphicsLayer): Ditto.
(WebKit::WebChromeClient::attachViewOverlayGraphicsLayer): Ditto.
(WebKit::WebChromeClient::createScrollingCoordinator): Ditto.
(WebKit::WebChromeClient::supportsFullScreenForElement): Ditto.
(WebKit::WebChromeClient::enterFullScreenForElement): Ditto.
(WebKit::WebChromeClient::exitFullScreenForElement): Ditto.
(WebKit::WebChromeClient::didAddHeaderLayer): Ditto.
(WebKit::WebChromeClient::didAddFooterLayer): Ditto.
(WebKit::WebChromeClient::shouldUseTiledBackingForFrameView): Ditto.

• WebProcess/WebCoreSupport/WebChromeClient.h: Ditto.
• WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:

(WebKit::WebChromeClient::elementDidRefocus): Ditto.
(WebKit::WebChromeClient::didReceiveMobileDocType): Ditto.
(WebKit::WebChromeClient::observedContentChange): Ditto.
(WebKit::WebChromeClient::clearContentChangeObservers): Ditto.
(WebKit::WebChromeClient::notifyRevealedSelectionByScrollingFrame): Ditto.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchCreatePage): Pass reference.

• WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::~WebInspectorClient): Ditto.
(WebKit::WebInspectorClient::hideHighlight): Ditto.
(WebKit::WebInspectorClient::showPaintRect): Ditto.

• WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindUIAfterPageScroll): Ditto.
(WebKit::FindController::hideFindUI): Ditto.

• WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::createWithCoreMainFrame): Return Ref instead of
PassRefPtr.
(WebKit::WebFrame::createSubframe): Ditto.
(WebKit::WebFrame::create): Ditto.

• WebProcess/WebPage/WebFrame.h: Updated for the above.

• WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::openInNewTab): Pass reference.

• WebProcess/WebPage/ios/FindControllerIOS.mm:

(WebKit::FindController::updateFindIndicator): Use reference.
(WebKit::FindController::hideFindIndicator): Ditto.

10:21 PM Changeset in webkit [211032] by Joseph Pecoraro

• 2 edits in trunk/LayoutTests

Rebaseline WebKit1 results after r211006.

Unreviewed test gardening.

• platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:

9:13 PM Changeset in webkit [211031] by bshafiei@apple.com

• 5 edits in tags/Safari-604.1.4.2/Source

Versioning.

9:09 PM Changeset in webkit [211030] by bshafiei@apple.com

• 1 copy in tags/Safari-604.1.4.2

New tag.

7:52 PM Changeset in webkit [211029] by mmaxfield@apple.com

• 7 edits in trunk/Source/WebCore

[Cocoa] Unify FontPlatformData's hashing and equality operators
​https://bugs.webkit.org/show_bug.cgi?id=167061

Reviewed by Darin Adler.

On iOS, we were using CFEqual() and CFHash(), while on macOS
we were using pointer hashing and pointer equality. Instead,
we should be consistent about these operators.

Right now, FontPlatformData holds two internal CTFontRefs, and
switching to these higher-level CFEqual() and CFHash()
functions is required for eliminating one of these two
internal font objects.

No new tests because there is no behavior change.

• platform/graphics/FontPlatformData.h:

(WebCore::FontPlatformData::hash): Deleted.

• platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::hash):
(WebCore::FontPlatformData::platformIsEqual):
(WebCore::cascadeToLastResortAttributesDictionary):

• platform/graphics/freetype/FontPlatformDataFreeType.cpp:

(WebCore::FontPlatformData::hash):

• platform/graphics/win/FontPlatformDataCGWin.cpp:

(WebCore::FontPlatformData::hash):

• platform/graphics/win/FontPlatformDataCairoWin.cpp:

(WebCore::FontPlatformData::hash):

• platform/graphics/win/FontPlatformDataDirect2D.cpp:

(WebCore::FontPlatformData::hash):

10:51 AM Changeset in webkit [211028] by dino@apple.com

• 2 edits in trunk/Source/WebCore

[WebGL] Do not allow GPU muxing on some old Mac hardware
​https://bugs.webkit.org/show_bug.cgi?id=167259
<rdar://problem/30060378>

Reviewed by Simon Fraser and Darin Adler.

Some old Macbook Pro models should never use the
integrated GPU for WebGL, because they are unstable
when swapping between that and the discrete GPU.

Unfortunately this hardware configuration isn't in our
testing infrastructure, so it was confirmed manually.
Meanwhile, our existing tests make sure this patch
doesn't break anything elsewhere.

• platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::attachToAppleGraphicsControl): Helper function
to get a mach port that talks to Apple's Graphics Control
system.
(WebCore::hasMuxCapability): Decides whether a system
can do live GPU switching, based on whether or not it
has a muxable GPU, and if that GPU is not the old hardware
we know is problematic.
(WebCore::hasMuxableGPU): Helper to return the static hasMuxCapability value.
(WebCore::setPixelFormat): Only request the integrated card when the
GPU is muxable.

9:24 AM Changeset in webkit [211027] by mmaxfield@apple.com

• 29 edits
  6 copies
  20 adds
  1 delete in trunk

Introducing the Platform Abstraction Layer (PAL)
​https://bugs.webkit.org/show_bug.cgi?id=143358

Reviewed by Alex Christensen.

.:

• CMakeLists.txt:
• Source/CMakeLists.txt:
• Source/cmake/WebKitFS.cmake:

Source/WebCore:

In order to enforce layering and promote testability, WebCore/platform files
should be compiled in their own project. This new project can enforce layering
and can be tested with unit tests in addition to layout tests.

The name of this new project is the Platform Abstraction Layer, or "PAL."
This comprises of a new directory in WebCore which will be the destination
for files migrated from WebCore/platform. This new folder, and its associated
project, will maintain layering invariants. These invariants are enforced at
build-time by setting the #include path for PAL to not include the rest of
WebCore (which is the same layering enforcement mechanism for WTF). Files will
be migrated into this new target/directory piece-by-piece, and the migration
of a file will be performed as soon as it can be migrated without violating
layering.

Within WebCore, files should include PAL files using the convention
#include <pal/foo.h>. Symbols within PAL are placed within a new top-level
namespace, "PAL," and therefore when used should be referred to as PAL::Foo.

The first set of files to move into the new platform is the crypto/ subdirectory
because it is both simple but also includes platform-dependent files.

No new tests because there is no behavior change.

• CMakeLists.txt:
• Configurations/WebCore.xcconfig: Add PAL to the include path
• PAL/Configurations/Base.xcconfig: Added.
• PAL/Configurations/DebugRelease.xcconfig: Added.
• PAL/Configurations/PAL.xcconfig: Added. Sets up some PAL-specific

variables.

• PAL/Configurations/FeatureDefines.xcconfig: Added.
• PAL/Configurations/Version.xcconfig: Added.
• PAL/PAL.xcodeproj/project.pbxproj: Added. New project file.
• PAL/config.h: Added. Simplified from WebCore/config.h.
• PAL/pal/CMakeLists.txt: Added.
• PAL/pal/PlatformEfl.cmake: Added.
• PAL/pal/PlatformGTK.cmake: Added.
• PAL/pal/PlatformMac.cmake: Added.
• PAL/pal/PlatformWin.cmake: Added.
• PAL/pal/crypto/CryptoDigest.h: Renamed from Source/WebCore/platform/crypto/CryptoDigest.h.
• PAL/pal/crypto/commoncrypto/CryptoDigestCommonCrypto.cpp: Renamed from Source/WebCore/platform/crypto/commoncrypto/CryptoDigestCommonCrypto.cpp.
• PAL/pal/crypto/gcrypt/CryptoDigestGCrypt.cpp: Renamed from Source/WebCore/platform/crypto/gcrypt/CryptoDigestGCrypt.cpp.
• PAL/pal/crypto/gnutls/CryptoDigestGnuTLS.cpp: Renamed from Source/WebCore/platform/crypto/gnutls/CryptoDigestGnuTLS.cpp.
• PAL/pal/crypto/win/CryptoDigestWin.cpp: Renamed from Source/WebCore/platform/crypto/win/CryptoDigestWin.cpp.
• PlatformEfl.cmake:
• PlatformGTK.cmake:
• PlatformMac.cmake:
• PlatformWin.cmake:
• WebCore.xcodeproj/project.pbxproj: Create a project link so WebCore

knows that it needs to build PAL as a dependency.

• crypto/algorithms/CryptoAlgorithmSHA1.cpp:

(WebCore::CryptoAlgorithmSHA1::digest): Update #include and namespace.

• crypto/algorithms/CryptoAlgorithmSHA224.cpp:

(WebCore::CryptoAlgorithmSHA224::digest): Ditto.

• crypto/algorithms/CryptoAlgorithmSHA256.cpp:

(WebCore::CryptoAlgorithmSHA256::digest): Ditto.

• crypto/algorithms/CryptoAlgorithmSHA384.cpp:

(WebCore::CryptoAlgorithmSHA384::digest): Ditto.

• crypto/algorithms/CryptoAlgorithmSHA512.cpp:

(WebCore::CryptoAlgorithmSHA512::digest): Ditto.

• crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:

(WebCore::cryptoDigestAlgorithm): Ditto.
(WebCore::signRSASSA_PKCS1_v1_5): Ditto.
(WebCore::verifyRSASSA_PKCS1_v1_5): Ditto.

• inspector/InspectorDOMAgent.cpp:

(WebCore::computeContentSecurityPolicySHA256Hash): Ditto.

• page/csp/ContentSecurityPolicy.cpp:

(WebCore::toCryptoDigestAlgorithm): Ditto.
(WebCore::ContentSecurityPolicy::findHashOfContentInPolicies): Ditto.

• platform/network/soup/SoupNetworkSession.cpp:

(WebCore::HostTLSCertificateSet::computeCertificateHash): Ditto.

12:29 AM Changeset in webkit [211026] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

[GStreamer] Clear out m_appsinkCaps in AppendPipeline::appsinkCapsChanged() before using outPtr()
​https://bugs.webkit.org/show_bug.cgi?id=167165

Reviewed by Carlos Garcia Campos.

• platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::appsinkCapsChanged): Replace the gst_caps_replace() call
with a simple comparison and, in case the current appsink caps differ from the caps
on the sink's pad, move the reference to the latter into the m_appsinkCaps member
variable. This removes the use of GRefPtr<>::outPtr() which asserted in debug
configurations in the case of m_appsinkCaps not being null.

Jan 21, 2017:

10:44 PM Changeset in webkit [211025] by commit-queue@webkit.org

• 3 edits in trunk/LayoutTests

REGRESSION (r210959): LayoutTest fast/mediastream/MediaStream-video-element-video-tracks-disabled.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=167260

Unreviewed test gardening.

Since this test checks against a black frame as its expected output, we need to use the legacy
media controls so that there is no start button.

Patch by Antoine Quint <Antoine Quint> on 2017-01-21

• fast/mediastream/MediaStream-video-element-video-tracks-disabled.html:
• platform/mac-wk2/TestExpectations:

9:48 PM Changeset in webkit [211024] by Chris Dumez

• 9 edits
  9 adds in trunk

JavaScript for-of does not work on a lot of collection types (e.g. HTMLCollection)
​https://bugs.webkit.org/show_bug.cgi?id=167091

Reviewed by Darin Adler.

Source/JavaScriptCore:

Update Array methods to throw a TypeError when (this === null

this === undefined)

instead of when (this == null). This is because (this == null) returns true for types
that masquerades as undefined (such as document.all) and this prevented use of the
Array API on such types. The specification only stays to use ToObject(), which throws
when the input is undefined or null.

The corresponding specification is at:

• ​https://www.ecma-international.org/ecma-262/7.0/index.html#sec-array.prototype.values
• ​https://www.ecma-international.org/ecma-262/7.0/index.html#sec-toobject

• builtins/ArrayPrototype.js:

(values):
(keys):
(entries):
(reduce):
(reduceRight):
(every):
(forEach):
(filter):
(map):
(some):
(fill):
(find):
(findIndex):
(includes):
(sort):
(concatSlowPath):
(copyWithin):

Source/WebCore:

As per the Web IDL specification [1], ​https://heycam.github.io/webidl/#es-iterator
an interface should get an iterator if it has:

• an indexed property getter and an integer-typed attribute named "length".

We now comply with this part of the Web IDL specification. This adds an iterator
to the following interfaces:

• AudioTrackList, ClientRectList, CSSRuleList, CSSStyleDeclaration, CSSValueList, MimeTypeArray, WebKitNamedFlowCollection, Plugin, PluginArray, DOMStringList, FileList, HTMLAllCollection, HTMLCollection, HTMLFormElement, HTMLOptionsCollection, HTMLSelectElement, MediaList, NamedNodeMap, SourceBufferList, StyleSheetList, TextTrackCueList, TextTrackList, TouchList, VideoTrackList, VTTRegionList.

As a result, it is now possible to use for ... of for those types.

Tests: fast/dom/FileList-iterator.html

fast/dom/collection-iterators.html
fast/dom/document-all-undefined.html
fast/events/touch/ios/touchlist-iterator.html

• bindings/scripts/CodeGeneratorJS.pm:

(GetAttributeWithName):
(InterfaceNeedsIterator):
(GenerateImplementation):
(addIterableProperties):

LayoutTests:

• fast/dom/FileList-iterator-expected.txt: Added.
• fast/dom/FileList-iterator.html: Added.
• fast/dom/collection-iterators-expected.txt: Added.
• fast/dom/collection-iterators.html: Added.
• fast/events/touch/ios/touchlist-iterator-expected.txt: Added.
• fast/events/touch/ios/touchlist-iterator.html: Added.

Add layout test coverage for all types that gained an iterator.

• fast/dom/document-all-undefined-expected.txt: Added.
• fast/dom/document-all-undefined.html: Added.

Add layout test to cover the fact that HTMLAllCollection masquerades as
undefined, as per:

• ​https://html.spec.whatwg.org/multipage/obsolete.html#dom-document-all

• inspector/model/remote-object-get-properties-expected.txt:

Rebaseline now that there is an extra Symbol.iterator property.

• platform/wk2/TestExpectations:

Skip that requires beginDragWithFiles() as this is unimplemented in
WebKitTestRunner.

9:19 PM Changeset in webkit [211023] by Chris Dumez

• 11 edits in trunk

innerText should replace existing text node
​https://bugs.webkit.org/show_bug.cgi?id=167116

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline existing test now that one more check is passing.

• web-platform-tests/innerText/setter-expected.txt:

Source/WebCore:

Update setInnerText() to use ContainerNode::replaceAllChildren()
instead of replaceChildrenWithText(). replaceAllChildren() is
implemented as per specification:

• ​https://html.spec.whatwg.org/multipage/dom.html#the-innertext-idl-attribute
• ​https://dom.spec.whatwg.org/#concept-node-replace-all

As a result, we now correctly remove existing children before
inserting the new one.

No new tests, updated existing one.

• editing/markup.cpp:

(WebCore::replaceChildrenWithText): Deleted.

• editing/markup.h:
• html/HTMLElement.cpp:

(WebCore::HTMLElement::setInnerText):

LayoutTests:

• accessibility/mac/aria-liveregions-changedtext.html:

The text is using innerText and changed behavior now that we stopped
reusing the existing Text child. Code in RenderObject::willBeDestroyed()
is supposed to call AXObjectCache::childrenChanged(parent()) to fire
the AXLiveRegionChanged notification. However, it did not because the
parent renderer did not have an associated AccessibilityObject.

• fast/dom/HTMLElement/set-inner-outer-optimization.html:

Update existing test which expected the non spec-compliant Text child
optimization.

• fast/repaint/vertical-text-repaint-expected.txt:
• fast/repaint/vertical-text-repaint.html:

Update / rebaseline test. We now repaint each 80x80 rectangle instead of
only repainting the text rects because we remove the Text node then add
a new one instead of only updating the existing Text node's test. The
output looks exactly the same otherwise.

6:29 PM Changeset in webkit [211022] by Chris Dumez

• 5 edits in trunk

AccessibilityRenderObject::textChanged() bypasses AXLiveRegionChanged notification coalescing
​https://bugs.webkit.org/show_bug.cgi?id=167286
<rdar://problem/30133211>

Reviewed by Ryosuke Niwa.

Source/WebCore:

AccessibilityRenderObject::textChanged() bypasses AXLiveRegionChanged notification
coalescing. This patch fixes the issue.

No new tests, updated existing test.

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textChanged):

LayoutTests:

Update test to use a longer timer delay. When using this longer delay, we were getting 4
AXLiveRegionChanged notifications instead of the expected 2 because
AccessibilityRenderObject::textChanged() was bypassing AXLiveRegionChanged notification
coalescing.

• accessibility/mac/aria-multiple-liveregions-notification-expected.txt:
• accessibility/mac/aria-multiple-liveregions-notification.html:

6:16 PM Changeset in webkit [211021] by Simon Fraser

• 3 edits in trunk/Source/WebKit/mac

Remove -[WebFrame sendOrientationChangeEvent:] which is unused
​https://bugs.webkit.org/show_bug.cgi?id=167276

Reviewed by Alex Christensen.

It was usurped by -deviceOrientationChanged in 2014.

• WebView/WebFrame.mm:

(-[WebFrame sendOrientationChangeEvent:]): Deleted.

• WebView/WebFramePrivate.h:

5:52 PM Changeset in webkit [211020] by Simon Fraser

• 3 edits in trunk/Source/WebKit/mac

Remove -[WebView _contentsSizeRespectingOverflow] which is no longer needed
​https://bugs.webkit.org/show_bug.cgi?id=167271

Reviewed by Alex Christensen.

-_contentsSizeRespectingOverflow was added to try to make viewport sizing on iOS respect
overflow:hidden on the body (webkit.org/b/146924) but that was reverted (webkit.org/b/152803),

• WebView/WebView.mm:

(-[WebView _contentsSizeRespectingOverflow]): Deleted.

• WebView/WebViewPrivate.h:

5:52 PM Changeset in webkit [211019] by Simon Fraser

• 3 edits in trunk/Source/WebKit/ios

Remove the unused -[WebFixedPositionContent minimumOffsetFromFixedPositionLayersToAnchorEdge:ofRect:inLayer:]
​https://bugs.webkit.org/show_bug.cgi?id=167273

Reviewed by Alex Christensen.

This function was added for an experiment, but is no longer used, so remove it.

• WebCoreSupport/WebFixedPositionContent.h:
• WebCoreSupport/WebFixedPositionContent.mm:

(anchorEdgeFlagsForAnchorEdge): Deleted.
(-[WebFixedPositionContent minimumOffsetFromFixedPositionLayersToAnchorEdge:ofRect:inLayer:]): Deleted.

2:22 PM Changeset in webkit [211018] by Yusuke Suzuki

• 9 edits in trunk/Source/JavaScriptCore

[JSC] export JSC::importModule API for WebCore dynamic import
​https://bugs.webkit.org/show_bug.cgi?id=167099

Reviewed by Darin Adler.

We newly expose JSC::importModule API. This can be used later
from WebCore to implement WebCore side dynamic import.
And JSC shell also uses this API.

And this patch also cleans up module loader a bit:
Dropping requestInstantiateAll.

• builtins/BuiltinNames.h:
• builtins/ModuleLoaderPrototype.js:

(requestLink):
(requestImportModule):
(requestInstantiateAll): Deleted.
(importModule): Deleted.

• jsc.cpp:

(GlobalObject::moduleLoaderImportModule):

• runtime/Completion.cpp:

(JSC::importModule):

• runtime/Completion.h:
• runtime/JSModuleLoader.cpp:

(JSC::JSModuleLoader::requestImportModule):

• runtime/JSModuleLoader.h:
• runtime/ModuleLoaderPrototype.cpp:

2:10 PM Changeset in webkit [211017] by Yusuke Suzuki

• 4 edits
  3 adds in trunk

dynamic import is ambiguous with import declaration at module code
​https://bugs.webkit.org/show_bug.cgi?id=167098

Reviewed by Darin Adler.

JSTests:

• modules/import-call.js: Added.

(from.string_appeared_here.import.string_appeared_here.then):

• modules/import-call/main.js: Added.
• stress/import-syntax.js:

(async):

Source/JavaScriptCore:

This patch fixes two syntax issues related to dynamic import.

1. Fix member expression parsing with dynamic import results

We should not return import expression immediately after parsing
it in parseMemberExpression. This prohibits us to parse the following
code,

import("...").then(function () {
});

2. dynamic import with import declaration under the module context

Before this patch, we always attempt to parse IMPORT as import declaration
under the module context. It means that import call in the top level
expression statement fails to be parsed since the parser attempts to parse
it as import declaration.

import("...") module top level statement.

In this patch, we check the condition [lookahead != (] before starting
parsing import declaration. This allows us to put import call in the module
top level statement.

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseModuleSourceElements):
(JSC::Parser<LexerType>::parseMemberExpression):

12:46 PM Changeset in webkit [211016] by commit-queue@webkit.org

• 3 edits in trunk/LayoutTests

REGRESSION (r210959): LayoutTest inspector/css/pseudo-element-matches.html timing out
​https://bugs.webkit.org/show_bug.cgi?id=167246

Unreviewed test gardening.

This test expects elements with legacy media controls pseudo classes so we turn off
modern media controls for it and stop expecting a timeout.

Patch by Antoine Quint <Antoine Quint> on 2017-01-21

• inspector/css/pseudo-element-matches.html:
• platform/mac/TestExpectations:

2:21 AM Changeset in webkit [211015] by Carlos Garcia Campos

• 2 edits in trunk/Tools

Unreviewed. Bring back gtk-doc error messages after r209981.

Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
impossible to know what's wrong.

• gtk/gtkdoc.py:

(GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.

1:22 AM Changeset in webkit [211014] by Carlos Garcia Campos

• 5 edits in trunk/Source

Unreviewed, rolling out r211012.

It caused a lot of crashes in the network process

Reverted changeset:

"[SOUP] Custom protocols don't work in private browsing mode"
​https://bugs.webkit.org/show_bug.cgi?id=167236
​http://trac.webkit.org/changeset/211012