Timeline
Jan 28, 2017:
- 11:54 PM WindowsWithoutCygwin edited by
- (diff)
- 11:30 PM Changeset in webkit [211349] by
-
- 2 edits93 moves4 deletes in trunk/LayoutTests
Migrate 97 *-disabled tests to use TestExpectations
<https://webkit.org/b/167537>
Reviewed by Darin Adler.
- TestExpectations: Skip renamed tests.
- fast/dom/HTMLDataGridElement/DataGridColumns-basic-expected.txt: Removed.
- fast/dom/HTMLDataGridElement/DataGridColumns-basic.html-disabled: Removed.
- fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes-expected.txt: Removed.
- fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html-disabled: Removed.
- fast/dom/HTMLDataGridElement/DataGridColumns-dom-expected.txt: Removed.
- fast/dom/HTMLDataGridElement/DataGridColumns-dom.html-disabled: Removed.
- fast/dom/HTMLDataGridElement/DataGridDataSource-basic-expected.txt: Removed.
- fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html-disabled: Removed.
- Tests disabled in r52512. DataGrid feature removed in r84991.
- http/tests/appcache/dynamic-entries-no-cache-expected.txt: Removed.
- http/tests/appcache/dynamic-entries-no-cache.html-disabled: Removed.
- Test disabled in r39816. AppCache dynamic entry feature removed in r95486.
- svg/W3C-SVG-1.1/resources/filters-comptran-01-f.svg-disabled: Removed.
- Unused. Same as LayoutTests/svg/W3C-SVG-1.1/filters-comptran-01-b.svg.
- animations/font-size-using-ems.html: Renamed from LayoutTests/animations/font-size-using-ems.html-disabled.
- compositing/objects/composited-object-alignment.html: Renamed from LayoutTests/compositing/objects/composited-object-alignment.html-disabled.
- compositing/tiling/huge-layer-resize.html: Renamed from LayoutTests/compositing/tiling/huge-layer-resize.html-disabled.
- compositing/tiling/huge-layer.html: Renamed from LayoutTests/compositing/tiling/huge-layer.html-disabled.
- css2.1/t1202-counter-10-b.html: Renamed from LayoutTests/css2.1/t1202-counter-10-b.html-disabled.
- css2.1/t1202-counters-10-b.html: Renamed from LayoutTests/css2.1/t1202-counters-10-b.html-disabled.
- css2.1/t1204-increment-00-c-o.html: Renamed from LayoutTests/css2.1/t1204-increment-00-c-o.html-disabled.
- css2.1/t1204-increment-01-c-o.html: Renamed from LayoutTests/css2.1/t1204-increment-01-c-o.html-disabled.
- css2.1/t1204-increment-02-c-o.html: Renamed from LayoutTests/css2.1/t1204-increment-02-c-o.html-disabled.
- css2.1/t1204-reset-00-c-o.html: Renamed from LayoutTests/css2.1/t1204-reset-00-c-o.html-disabled.
- css2.1/t1204-reset-01-c-o.html: Renamed from LayoutTests/css2.1/t1204-reset-01-c-o.html-disabled.
- css2.1/t1204-reset-02-c-o.html: Renamed from LayoutTests/css2.1/t1204-reset-02-c-o.html-disabled.
- dom/xhtml/level2/html/HTMLFrameElement09.xhtml: Renamed from LayoutTests/dom/xhtml/level2/html/HTMLFrameElement09.xhtml-disabled.
- dom/xhtml/level3/core/documentadoptnode22.xhtml: Renamed from LayoutTests/dom/xhtml/level3/core/documentadoptnode22.xhtml-disabled.
- dom/xhtml/level3/core/documentnormalizedocument06.xhtml: Renamed from LayoutTests/dom/xhtml/level3/core/documentnormalizedocument06.xhtml-disabled.
- dom/xhtml/level3/core/documentsetdocumenturi01.xhtml: Renamed from LayoutTests/dom/xhtml/level3/core/documentsetdocumenturi01.xhtml-disabled.
- dom/xhtml/level3/core/documentsetdocumenturi02.xhtml: Renamed from LayoutTests/dom/xhtml/level3/core/documentsetdocumenturi02.xhtml-disabled.
- dom/xhtml/level3/core/domimplementationregistry12.xhtml: Renamed from LayoutTests/dom/xhtml/level3/core/domimplementationregistry12.xhtml-disabled.
- dom/xhtml/level3/core/domimplementationregistry23.xhtml: Renamed from LayoutTests/dom/xhtml/level3/core/domimplementationregistry23.xhtml-disabled.
- dom/xhtml/level3/core/nodecomparedocumentposition14.xhtml: Renamed from LayoutTests/dom/xhtml/level3/core/nodecomparedocumentposition14.xhtml-disabled.
- dom/xhtml/level3/core/nodecomparedocumentposition15.xhtml: Renamed from LayoutTests/dom/xhtml/level3/core/nodecomparedocumentposition15.xhtml-disabled.
- dom/xhtml/level3/core/noderemovechild03.xhtml: Renamed from LayoutTests/dom/xhtml/level3/core/noderemovechild03.xhtml-disabled.
- dom/xhtml/level3/core/nodereplacechild06.xhtml: Renamed from LayoutTests/dom/xhtml/level3/core/nodereplacechild06.xhtml-disabled.
- dom/xhtml/level3/core/nodereplacechild07.xhtml: Renamed from LayoutTests/dom/xhtml/level3/core/nodereplacechild07.xhtml-disabled.
- dom/xhtml/level3/core/nodereplacechild08.xhtml: Renamed from LayoutTests/dom/xhtml/level3/core/nodereplacechild08.xhtml-disabled.
- editing/execCommand/create-list-1.html: Renamed from LayoutTests/editing/execCommand/create-list-1.html-disabled.
- editing/input/attributed-substring-from-range-lines.html: Renamed from LayoutTests/editing/input/attributed-substring-from-range-lines.html-disabled.
- editing/pasteboard/paste-empty-startcontainer.html: Renamed from LayoutTests/editing/pasteboard/paste-empty-startcontainer.html-disabled.
- editing/selection/inconsistent-in-removeChildNode.html: Renamed from LayoutTests/editing/selection/inconsistent-in-removeChildNode.html-disabled.
- editing/style/5091898.html: Renamed from LayoutTests/editing/style/5091898.html-disabled.
- fast/css/css2-system-color.html: Renamed from LayoutTests/fast/css/css2-system-color.html-disabled.
- fast/css/font-face-in-shadow-DOM.html: Renamed from LayoutTests/fast/css/font-face-in-shadow-DOM.html-disabled.
- fast/css/limited-vendor-prefix-behavior.html: Renamed from LayoutTests/fast/css/limited-vendor-prefix-behavior.html-disabled.
- fast/dom/Window/timeout-released-on-close.html: Renamed from LayoutTests/fast/dom/Window/timeout-released-on-close.html-disabled.
- fast/dom/Window/window-resize-nan.html: Renamed from LayoutTests/fast/dom/Window/window-resize-nan.html-disabled.
- fast/dom/gc-8.html: Renamed from LayoutTests/fast/dom/gc-8.html-disabled.
- fast/dynamic/crash-paint-no-documentElement-renderer.html: Renamed from LayoutTests/fast/dynamic/crash-paint-no-documentElement-renderer.html-disabled.
- fast/events/destroyed-atomic-string.html: Renamed from LayoutTests/fast/events/destroyed-atomic-string.html-disabled.
- fast/events/key-events-in-frame.html: Renamed from LayoutTests/fast/events/key-events-in-frame.html-disabled.
- fast/frames/iframe-scroll-page-up-down.html: Renamed from LayoutTests/fast/frames/iframe-scroll-page-up-down.html-disabled.
- fast/html/marquee-alternate.html: Renamed from LayoutTests/fast/html/marquee-alternate.html-disabled.
- fast/leaks/003.html: Renamed from LayoutTests/fast/leaks/003.html-disabled.
- fast/loader/api-test-go-to-current-back-forward-item.html: Renamed from LayoutTests/fast/loader/api-test-go-to-current-back-forward-item.html-disabled.
- fast/loader/api-test-new-window-data-load-base-url.html: Renamed from LayoutTests/fast/loader/api-test-new-window-data-load-base-url.html-disabled.
- fast/loader/form-events-back-forward.html: Renamed from LayoutTests/fast/loader/form-events-back-forward.html-disabled.
- fast/notifications/notifications-event-stop-propagation.html: Renamed from LayoutTests/fast/notifications/notifications-event-stop-propagation.html-disabled.
- fast/notifications/notifications-multi-events.html: Renamed from LayoutTests/fast/notifications/notifications-multi-events.html-disabled.
- fast/ruby/after-block-doesnt-crash.html: Renamed from LayoutTests/fast/ruby/after-block-doesnt-crash.html-disabled.
- fast/ruby/after-table-doesnt-crash.html: Renamed from LayoutTests/fast/ruby/after-table-doesnt-crash.html-disabled.
- fast/ruby/generated-after-counter-doesnt-crash.html: Renamed from LayoutTests/fast/ruby/generated-after-counter-doesnt-crash.html-disabled.
- fast/ruby/generated-before-and-after-counter-doesnt-crash.html: Renamed from LayoutTests/fast/ruby/generated-before-and-after-counter-doesnt-crash.html-disabled.
- fast/shadow-dom/copy-shadow-tree.html: Renamed from LayoutTests/fast/shadow-dom/copy-shadow-tree.html-disabled.
- fast/table/double-height-table-no-tbody.html: Renamed from LayoutTests/fast/table/double-height-table-no-tbody.html-disabled.
- fast/text/large-text-composed-char-dos.html: Renamed from LayoutTests/fast/text/large-text-composed-char-dos.html-disabled.
- http/tests/multipart/win-boundary-crash.html: Renamed from LayoutTests/http/tests/multipart/win-boundary-crash.html-disabled.
- http/tests/navigation/post-goback-repost-policy.html: Renamed from LayoutTests/http/tests/navigation/post-goback-repost-policy.html-disabled.
- http/tests/navigation/success200-frames-goback.html: Renamed from LayoutTests/http/tests/navigation/success200-frames-goback.html-disabled.
- http/tests/navigation/success200-frames-reload.html: Renamed from LayoutTests/http/tests/navigation/success200-frames-reload.html-disabled.
- http/tests/navigation/success200-subframeload-goback.html: Renamed from LayoutTests/http/tests/navigation/success200-subframeload-goback.html-disabled.
- java/lc3/ArrayMethods/object-001.html: Renamed from LayoutTests/java/lc3/ArrayMethods/object-001.html-disabled.
- java/lc3/forin/array-001.html: Renamed from LayoutTests/java/lc3/forin/array-001.html-disabled.
- jquery/effects.html: Renamed from LayoutTests/jquery/effects.html-disabled.
- js/garbage-collect-after-string-appends.html: Renamed from LayoutTests/js/garbage-collect-after-string-appends.html-disabled.
- js/kde/Date.html: Renamed from LayoutTests/js/kde/Date.html-disabled.
- js/resources/garbage-collect-after-string-appends.js: Renamed from LayoutTests/js/resources/garbage-collect-after-string-appends.js-disabled.
- js/string-concatenate-outofmemory.html: Renamed from LayoutTests/js/string-concatenate-outofmemory.html-disabled.
- media/video-canvas.html: Renamed from LayoutTests/media/video-canvas.html-disabled.
- platform/mac/plugins/pluginDocumentView-deallocated-dataSource.html: Renamed from LayoutTests/platform/mac/plugins/pluginDocumentView-deallocated-dataSource.html-disabled.
- sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.1_decodeURI/S15.1.3.1_A2.5_T1.html: Renamed from LayoutTests/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.1_decodeURI/S15.1.3.1_A2.5_T1.html-disabled.
- sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.2_decodeURIComponent/S15.1.3.2_A2.5_T1.html: Renamed from LayoutTests/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.2_decodeURIComponent/S15.1.3.2_A2.5_T1.html-disabled.
- sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T1.html: Renamed from LayoutTests/sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T1.html-disabled.
- sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T2.html: Renamed from LayoutTests/sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T2.html-disabled.
- sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T3.html: Renamed from LayoutTests/sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T3.html-disabled.
- sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T4.html: Renamed from LayoutTests/sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T4.html-disabled.
- sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T5.html: Renamed from LayoutTests/sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T5.html-disabled.
- sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T6.html: Renamed from LayoutTests/sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T6.html-disabled.
- sputnik/Unicode/Unicode_218/S7.6_A1.1_T5.html: Renamed from LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A1.1_T5.html-disabled.
- sputnik/Unicode/Unicode_218/S7.6_A3.1.html: Renamed from LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A3.1.html-disabled.
- sputnik/Unicode/Unicode_218/S7.6_A3.2.html: Renamed from LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A3.2.html-disabled.
- sputnik/Unicode/Unicode_218/S7.6_A5.2_T5.html: Renamed from LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.2_T5.html-disabled.
- sputnik/Unicode/Unicode_320/S7.6_A1.1_T5.html: Renamed from LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A1.1_T5.html-disabled.
- sputnik/Unicode/Unicode_320/S7.6_A5.2_T5.html: Renamed from LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.2_T5.html-disabled.
- sputnik/Unicode/Unicode_410/S7.6_A1.1_T5.html: Renamed from LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A1.1_T5.html-disabled.
- sputnik/Unicode/Unicode_410/S7.6_A5.2_T5.html: Renamed from LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A5.2_T5.html-disabled.
- sputnik/Unicode/Unicode_500/S7.6_A1.1_T5.html: Renamed from LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A1.1_T5.html-disabled.
- sputnik/Unicode/Unicode_500/S7.6_A5.2_T5.html: Renamed from LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A5.2_T5.html-disabled.
- sputnik/Unicode/Unicode_510/S7.6_A1.1_T5.html: Renamed from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A1.1_T5.html-disabled.
- sputnik/Unicode/Unicode_510/S7.6_A5.2_T5.html: Renamed from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.2_T5.html-disabled.
- svg/batik/text/textBiDi.svg: Renamed from LayoutTests/svg/batik/text/textBiDi.svg-disabled.
- svg/custom/filter-source-alpha.svg: Renamed from LayoutTests/svg/custom/filter-source-alpha.svg-disabled.
- svg/custom/font-face-fallback.svg: Renamed from LayoutTests/svg/custom/font-face-fallback.svg-disabled.
- svg/custom/js-font-test.svg: Renamed from LayoutTests/svg/custom/js-font-test.svg-disabled.
- svg/zoom/page/zoom-svg-through-object-with-text.xhtml: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-text.xhtml-disabled.
- Renamed disabled tests now that they're skipped in TestExpectations.
- 11:16 PM Changeset in webkit [211348] by
-
- 2 edits in trunk/Source/WebKit2
[Threaded Compositor] Crash when detaching the CoordinatedGraphicsScene
https://bugs.webkit.org/show_bug.cgi?id=167547
Reviewed by Michael Catanzaro.
It seems that commitSceneState() can be called after the CoordinatedGraphicsScene has been detached.
- Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
(WebKit::CoordinatedGraphicsScene::commitSceneState): Return early if scene has been detached.
(WebKit::CoordinatedGraphicsScene::detach): Take the render queue lock before clearing the render queue.
- 11:15 PM Changeset in webkit [211347] by
-
- 2 edits in trunk/Source/WebKit2
[Threaded Compositor] Crash when deleting the compositor run loop
https://bugs.webkit.org/show_bug.cgi?id=167545
Reviewed by Michael Catanzaro.
The problem is that we are releasing the WorkQueue before the update timer that keeps a reference to the run
loop, destroyed by the WorkQueue. So, invalidate the WorkQueue in the next run loop iteration to ensure it
happens after the CompositingRunLoop destructor.
- Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:
(WebKit::CompositingRunLoop::~CompositingRunLoop):
- 11:14 PM Changeset in webkit [211346] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] ASSERTION FAILED: !m_layerTreeHost in DrawingAreaImpl::display()
https://bugs.webkit.org/show_bug.cgi?id=167548
Reviewed by Michael Catanzaro.
The problem is that non accelerated compositing forceRepaint implementation is doing a layout and then calling
display. The layout makes the drawing area enter in AC mode and display asserts that we have a layer tree
host. forceRepaint shouldn't do the layout because display already does that and it correctly handles the case
of entering AC mode during the layout. It shouldn't call setNeedsDisplay either, because that schedules a
display, but we are going to display synchronously.
- WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::forceRepaint):
- 5:02 PM Changeset in webkit [211345] by
-
- 15 edits1 copy2 adds in trunk
Web Inspector: Need some limit on Async Call Stacks for async loops (rAF loops)
https://bugs.webkit.org/show_bug.cgi?id=165633
<rdar://problem/29738502>
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
This patch limits the memory used by the Inspector backend to store async
stack trace data.
Asynchronous stack traces are stored as a disjoint set of parent pointer
trees. Tree nodes represent asynchronous operations, and hold a copy of
the stack trace at the time the operation was scheduled. Each tree can
be regarded as a set of stack traces, stored as singly linked lists that
share part of their structure (specifically their tails). Traces belonging
to the same tree will at least share a common root. A stack trace begins
at a leaf node and follows the chain of parent pointers to the root of
of the tree. Leaf nodes always contain pending asynchronous calls.
When an asynchronous operation is scheduled with requestAnimationFrame,
setInterval, etc, a node is created containing the current call stack and
some bookkeeping data for the operation. An unique identifier comprised
of an operation type and callback identifier is mapped to the node. If
scheduling the callback was itself the result of an asynchronous call,
the node becomes a child of the node associated with that call, otherwise
it becomes the root of a new tree.
A node is either
pending,active,dispatched, orcanceled. Nodes
start out as pending. After a callback for a pending node is dispatched
the node is marked as such, unless it is a repeating callback such as
setInterval, in which case it remains pending. Once a node is no longer
pending it is removed, as long as it has no children. Since nodes are
reference counted, it is a property of the stack trace tree that nodes
that are no longer pending and have no children pointing to them will be
automatically pruned from the tree.
If an async operation is canceled (e.g. cancelTimeout), the associated
node is marked as such. If the callback is not being dispatched at the
time, and has no children, it is removed.
Because async operations can be chained indefinitely, stack traces are
limited to a maximum depth. The depth of a stack trace is equal to the
sum of the depths of its nodes, with a node's depth equal to the number
of frames in its associated call stack. For any stack trace,
S = { s𝟶, s𝟷, …, s𝑘 }, with endpoints s𝟶, s𝑘
depth(S) = depth(s𝟶) + depth(s𝟷) + … + depth(s𝑘)
A stack trace is truncated when it exceeds the maximum depth. Truncation
occurs on node boundaries, not call frames, consequently the maximum depth
is more of a target than a guarantee:
d = maximum stack trace depth
for all S, depth(S) ≤ d + depth(s𝑘)
Because nodes can belong to multiple stack traces, it may be necessary
to clone the tail of a stack trace being truncated to prevent other traces
from being effected.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- inspector/AsyncStackTrace.cpp: Added.
(Inspector::AsyncStackTrace::create):
(Inspector::AsyncStackTrace::AsyncStackTrace):
(Inspector::AsyncStackTrace::~AsyncStackTrace):
(Inspector::AsyncStackTrace::isPending):
(Inspector::AsyncStackTrace::isLocked):
(Inspector::AsyncStackTrace::willDispatchAsyncCall):
(Inspector::AsyncStackTrace::didDispatchAsyncCall):
(Inspector::AsyncStackTrace::didCancelAsyncCall):
(Inspector::AsyncStackTrace::buildInspectorObject):
(Inspector::AsyncStackTrace::truncate):
(Inspector::AsyncStackTrace::remove):
- inspector/AsyncStackTrace.h:
- inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::InspectorDebuggerAgent::didScheduleAsyncCall):
(Inspector::InspectorDebuggerAgent::didCancelAsyncCall):
(Inspector::InspectorDebuggerAgent::willDispatchAsyncCall):
(Inspector::InspectorDebuggerAgent::didDispatchAsyncCall):
(Inspector::InspectorDebuggerAgent::didPause):
(Inspector::InspectorDebuggerAgent::clearAsyncStackTraceData):
(Inspector::InspectorDebuggerAgent::buildAsyncStackTrace): Deleted.
(Inspector::InspectorDebuggerAgent::refAsyncCallData): Deleted.
(Inspector::InspectorDebuggerAgent::derefAsyncCallData): Deleted.
- inspector/agents/InspectorDebuggerAgent.h:
- inspector/protocol/Console.json:
Source/WebInspectorUI:
- Localizations/en.lproj/localizedStrings.js:
Text for "Truncated" marker tree element.
- UserInterface/Models/StackTrace.js:
(WebInspector.StackTrace):
(WebInspector.StackTrace.fromPayload):
(WebInspector.StackTrace.prototype.get truncated):
Plumbing for new Console.StackTrace propertytruncated.
- UserInterface/Views/ThreadTreeElement.css:
(.tree-outline > .item.thread + ol > .item.truncated-call-frames):
(.tree-outline > .item.thread + ol > .item.truncated-call-frames .icon):
Styles for "Truncated" marker tree element.
- UserInterface/Views/ThreadTreeElement.js:
(WebInspector.ThreadTreeElement.prototype.refresh):
Append "Truncated" marker tree element if necessary.
- Versions/Inspector-iOS-10.3.json:
LayoutTests:
Add truncation test cases and cleanup call frame logging.
- inspector/debugger/async-stack-trace-expected.txt:
- inspector/debugger/async-stack-trace.html:
- inspector/debugger/resources/log-active-stack-trace.js: Added.
(TestPage.registerInitializer.window.getActiveStackTrace):
(TestPage.registerInitializer.logStackTrace.logCallFrame):
(TestPage.registerInitializer.):
(TestPage.registerInitializer.window.logActiveStackTrace):
(TestPage.registerInitializer):
- 4:39 PM Changeset in webkit [211344] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remote Inspector: Listing should be updated when a target gains or loses a debugger session
https://bugs.webkit.org/show_bug.cgi?id=167449
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-01-28
Reviewed by Brian Burg.
- inspector/remote/RemoteInspector.h:
- inspector/remote/RemoteInspector.mm:
(Inspector::RemoteInspector::setupFailed):
(Inspector::RemoteInspector::updateTargetListing):
(Inspector::RemoteInspector::receivedSetupMessage):
(Inspector::RemoteInspector::receivedDidCloseMessage):
(Inspector::RemoteInspector::receivedConnectionDiedMessage):
Whenever we add/remove a connection we should update the listing properties
for that target that corresponded to that connection. In this way group
updating active sessions, the target, and pushing listing together.
- 4:16 PM Changeset in webkit [211343] by
-
- 4 edits in trunk/Source
Don't flash a tap highlight for the entirety of an editable WKWebView
https://bugs.webkit.org/show_bug.cgi?id=167486
<rdar://problem/30193996>
Reviewed by Dan Bernstein.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::sendTapHighlightForNodeIfNecessary):
Bail from providing a tap highlight if we are about to highlight
the entire body of an editable web view.
- dom/Document.h:
Export.
- 3:13 PM Changeset in webkit [211342] by
-
- 12 edits in trunk/Source
Check USE(APPLE_INTERNAL_SDK) instead of specific headers when importing from WebKitAdditions
https://bugs.webkit.org/show_bug.cgi?id=167555
Reviewed by Dan Bernstein.
Instead of guarding #import <WebKitAdditions/*> on the existence of the imported file, consult
USE(APPLE_INTERNAL_SDK) instead.
Source/WebCore:
- page/ios/EventHandlerIOS.mm:
- platform/ios/DragImageIOS.mm:
- platform/ios/PasteboardIOS.mm:
- platform/mac/DragDataMac.mm:
Source/WebKit2:
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
Source/WTF:
- wtf/Platform.h:
- 2:53 PM Changeset in webkit [211341] by
-
- 46 edits in trunk
Add Link Preload as an off-by-default experimental feature menu item.
https://bugs.webkit.org/show_bug.cgi?id=167201
Reviewed by Ryosuke Niwa.
Source/WebCore:
Removed the explicit setting of the Link Preload experimental feature,
as it is now on by default for testing.
No new tests as this just removes methods from settings.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
- testing/InternalSettings.h:
- testing/InternalSettings.idl:
Source/WebKit/mac:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(-[WebPreferences linkPreloadEnabled]):
(-[WebPreferences setLinkPreloadEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit/win:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::valueForKey):
(WebPreferences::setLinkPreloadEnabled):
(WebPreferences::linkPreloadEnabled):
- WebPreferences.h:
- Interfaces/IWebPreferencesPrivate.idl:
Source/WebKit2:
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetLinkPreloadEnabled):
(WKPreferencesGetLinkPreloadEnabled):
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
- DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebPreferencesToConsistentValues):
Websites/webkit.org:
- experimental-features.html: Added Link Preload.
LayoutTests:
Removed code explicitly enabling Link preload from the tests, as it is now
turned on by default for testing. Corrected expectation files accordingly.
- http/tests/fetch/redirectmode-and-preload.html:
- http/tests/preload/delaying_onload_link_preload_after_discovery.html:
- http/tests/preload/delaying_onload_link_preload_after_discovery_image.html:
- http/tests/preload/download_resources-expected.txt:
- http/tests/preload/download_resources.html:
- http/tests/preload/download_resources_from_header_iframe.html:
- http/tests/preload/download_resources_from_invalid_headers.html:
- http/tests/preload/dynamic_adding_preload.html:
- http/tests/preload/dynamic_remove_preload_href-expected.txt:
- http/tests/preload/dynamic_remove_preload_href.html:
- http/tests/preload/not_delaying_window_onload_before_discovery.html:
- http/tests/preload/onerror_event-expected.txt:
- http/tests/preload/onerror_event.html:
- http/tests/preload/onload_event-expected.txt:
- http/tests/preload/onload_event.html:
- http/tests/preload/resources/download_resources_from_header.php:
- http/tests/preload/resources/invalid_resources_from_header.php:
- http/tests/preload/single_download_preload-expected.txt:
- http/tests/preload/single_download_preload.html:
- http/tests/security/cached-cross-origin-preloaded-css-stylesheet.html:
- http/tests/security/cached-cross-origin-preloading-css-stylesheet.html:
- 2:35 PM Changeset in webkit [211340] by
-
- 2 edits in trunk/Source/WebCore
Fix typo in error message
https://bugs.webkit.org/show_bug.cgi?id=167554
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-01-28
Reviewed by Sam Weinig.
- bindings/scripts/CodeGenerator.pm:
(GetEnumByType):
- 10:16 AM Changeset in webkit [211339] by
-
- 4 edits2 adds in trunk
[Modern Media Controls] REGRESSION: Video stops playing after going into Full Screen in media documents
https://bugs.webkit.org/show_bug.cgi?id=167552
<rdar://problem/29601646>
Patch by Antoine Quint <Antoine Quint> on 2017-01-28
Reviewed by Eric Carlson.
Source/WebCore:
In the case of media documents, there is a built-in behavior, implemented in MediaDocument::defaultEventHandler(),
that toggles playback when clicking or double-clicking the video. We disable this behavior by adding a "click" event
handler on the entire media shadow root and calling "preventDefault()".
Test: media/modern-media-controls/media-documents/click-on-video-should-not-pause.html
- Modules/modern-media-controls/media/media-controller.js:
(MediaController):
(MediaController.prototype.handleEvent):
(MediaController.prototype._containerWasClicked):
LayoutTests:
Add a new test that checks that clicking on a <video> within a media document does not paused after being clicked.
Since this behavior uses click events, we use window.eventSender and skip this test on iOS.
- media/modern-media-controls/media-documents/click-on-video-should-not-pause-expected.txt: Added.
- media/modern-media-controls/media-documents/click-on-video-should-not-pause.html: Added.
- platform/ios-simulator/TestExpectations:
- 10:05 AM Changeset in webkit [211338] by
-
- 7 edits1 add in trunk/Source/WebCore
[Xcode] Clean up PAL and WebCore’s build settings a little
https://bugs.webkit.org/show_bug.cgi?id=167292
Reviewed by Sam Weinig.
Source/WebCore:
- Configurations/Base.xcconfig: Simplified the definition of GCC_WARN_64_TO_32_BIT_CONVERSION, removed the unused build setting PREBINDING, removed a duplicate definition of GCC_GENERATE_DEBUGGING_SYMBOLS, and removed definitions specific to OS X versions that are no longer supported.
- Configurations/DebugRelease.xcconfig: Removed definitions specific to OS X versions that are no longer supported.
Source/WebCore/PAL:
- ChangeLog: Created this file.
- Configurations/Base.xcconfig: Simplified the definition of GCC_WARN_64_TO_32_BIT_CONVERSION, removed the unused build setting PREBINDING, removed a duplicate definition of GCC_GENERATE_DEBUGGING_SYMBOLS, and removed definitions specific to OS X versions that are no longer supported.
- Configurations/DebugRelease.xcconfig: Removed definitions specific to OS X versions that are no longer supported.
- Configurations/PAL.xcconfig: Removed header search paths that do not exist or do not make sense. Simplified the definitions of INSTALL_PATH and SKIP_INSTALL. Removed the unusued build settings PRODUCT_BUNDLE_IDENTIFIER and WK_PREFIXED_IPHONEOS_DEPLOYMENT_TARGET. Removed the redundant definition of EXECUTABLE_PREFIX.
- PAL.xcodeproj/project.pbxproj: Sorted the Configurations group.
- 8:26 AM Changeset in webkit [211337] by
-
- 5 edits2 adds in trunk
Resolve beforeChild's render tree position before calling addChildIgnoringContinuation.
https://bugs.webkit.org/show_bug.cgi?id=167540
<rdar://problem/30126535>
Reviewed by Simon Fraser.
Source/WebCore:
Use the actual render tree position for the beforeChild when inside a flow thread.
Test: fast/multicol/assert-on-continuation-with-spanner.html
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::addChild):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::addChild):
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::resolveMovedChild):
LayoutTests:
- fast/multicol/assert-on-continuation-with-spanner-expected.txt: Added.
- fast/multicol/assert-on-continuation-with-spanner.html: Added.
- 7:19 AM Changeset in webkit [211336] by
-
- 2 edits in trunk/Source/WebCore
Avoid synchronous style recalc in dispatchUnloadEvents().
<https://webkit.org/b/167551>
Reviewed by Antti Koivisto.
It shouldn't be necessary to force a synchronous style resolution in an unloading document.
This call has been here since the import of KHTMLPart.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::dispatchUnloadEvents):
- 4:16 AM Changeset in webkit [211335] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r196383): Automatic shrink-to-fit of RuleSet no longer works.
<https://webkit.org/b/167543>
Reviewed by Antti Koivisto.
Re-enable the automatic shrink-to-fit optimization in RuleSet.
This was disabled accidentally, which I discovered while investigating
the memory footprint of extension stylesheets.
- css/RuleSet.h:
- 4:04 AM Changeset in webkit [211334] by
-
- 2 edits in trunk/Source/WebCore
Give scripts 'high' load priority
https://bugs.webkit.org/show_bug.cgi?id=167550
Reviewed by Andreas Kling.
For historical reasons it is currently 'medium', same as web fonts and some other non-parsing blocking things.
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::defaultPriorityForResourceType):
- 1:26 AM Changeset in webkit [211333] by
-
- 2 edits34 adds in trunk/LayoutTests/imported/w3c
Import web-platform-tests/user-timing
https://bugs.webkit.org/show_bug.cgi?id=167542
<rdar://problem/22746307>
Rubber-stamped by Ryosuke Niwa.
Only failures are ones where User Timing Level 2 differs
from User Timing Level 1.
- resources/ImportExpectations:
- web-platform-tests/user-timing/OWNERS: Added.
- web-platform-tests/user-timing/idlharness-expected.txt: Added.
- web-platform-tests/user-timing/idlharness.html: Added.
- web-platform-tests/user-timing/resources/w3c-import.log: Added.
- web-platform-tests/user-timing/resources/webperftestharness.js: Added.
- web-platform-tests/user-timing/resources/webperftestharnessextension.js: Added.
- web-platform-tests/user-timing/test_user_timing_clear_marks-expected.txt: Added.
- web-platform-tests/user-timing/test_user_timing_clear_marks.html: Added.
- web-platform-tests/user-timing/test_user_timing_clear_measures-expected.txt: Added.
- web-platform-tests/user-timing/test_user_timing_clear_measures.html: Added.
- web-platform-tests/user-timing/test_user_timing_entry_type-expected.txt: Added.
- web-platform-tests/user-timing/test_user_timing_entry_type.html: Added.
- web-platform-tests/user-timing/test_user_timing_exists-expected.txt: Added.
- web-platform-tests/user-timing/test_user_timing_exists.html: Added.
- web-platform-tests/user-timing/test_user_timing_mark-expected.txt: Added.
- web-platform-tests/user-timing/test_user_timing_mark.html: Added.
- web-platform-tests/user-timing/test_user_timing_mark_and_measure_exception_when_invoke_with_timing_attributes-expected.txt: Added.
- web-platform-tests/user-timing/test_user_timing_mark_and_measure_exception_when_invoke_with_timing_attributes.html: Added.
- web-platform-tests/user-timing/test_user_timing_mark_and_measure_exception_when_invoke_with_timing_attributes.js: Added.
- web-platform-tests/user-timing/test_user_timing_mark_and_measure_exception_when_invoke_without_parameter-expected.txt: Added.
- web-platform-tests/user-timing/test_user_timing_mark_and_measure_exception_when_invoke_without_parameter.html: Added.
- web-platform-tests/user-timing/test_user_timing_mark_exceptions-expected.txt: Added.
- web-platform-tests/user-timing/test_user_timing_mark_exceptions.html: Added.
- web-platform-tests/user-timing/test_user_timing_mark_with_name_of_navigation_timing_optional_attribute-expected.txt: Added.
- web-platform-tests/user-timing/test_user_timing_mark_with_name_of_navigation_timing_optional_attribute.html: Added.
- web-platform-tests/user-timing/test_user_timing_measure-expected.txt: Added.
- web-platform-tests/user-timing/test_user_timing_measure.html: Added.
- web-platform-tests/user-timing/test_user_timing_measure_exceptions-expected.txt: Added.
- web-platform-tests/user-timing/test_user_timing_measure_exceptions.html: Added.
- web-platform-tests/user-timing/test_user_timing_measure_navigation_timing-expected.txt: Added.
- web-platform-tests/user-timing/test_user_timing_measure_navigation_timing.html: Added.
- web-platform-tests/user-timing/w3c-import.log: Added.
- 1:26 AM Changeset in webkit [211332] by
-
- 36 edits in trunk
Add User Timing Experimental Feature
https://bugs.webkit.org/show_bug.cgi?id=167542
<rdar://problem/22746307>
Reviewed by Ryosuke Niwa.
Source/WebCore:
- page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::performanceTimelineEnabled):
- page/Performance.idl:
- page/PerformanceEntry.idl:
Make a better RuntimeEnabledFeature named "PerformanceTiming" which
is enabled if either UserTiming or ResourceTiming is enabled. This
will then expose the APIs that are only useful when at least one of
the APIs are available.
- page/PerformanceEntry.cpp:
(WebCore::PerformanceEntry::name): Deleted.
(WebCore::PerformanceEntry::entryType): Deleted.
(WebCore::PerformanceEntry::startTime): Deleted.
(WebCore::PerformanceEntry::duration): Deleted.
- page/PerformanceEntry.h:
(WebCore::PerformanceEntry::name):
(WebCore::PerformanceEntry::entryType):
(WebCore::PerformanceEntry::startTime):
(WebCore::PerformanceEntry::duration):
Inline simple accessors.
- page/PerformanceUserTiming.cpp:
(WebCore::UserTiming::measure):
Fix a bug introduced by ExceptionOr refactoring.
(WebCore::UserTiming::clearMarks):
(WebCore::UserTiming::clearMeasures):
(WebCore::clearPerformanceEntries):
(WebCore::clearPeformanceEntries): Deleted.
Fix method name typo.
Source/WebKit/mac:
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences userTimingEnabled]):
(-[WebPreferences setUserTimingEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Add setting for User Timing runtime enabled feature.
Source/WebKit/win:
- Interfaces/IWebPreferencesPrivate.idl:
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::setUserTimingEnabled):
(WebPreferences::userTimingEnabled):
- WebPreferences.h:
- WebView.cpp:
(WebView::notifyPreferencesChanged):
Add setting for User Timing runtime enabled feature.
Source/WebKit2:
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetUserTimingEnabled):
(WKPreferencesGetUserTimingEnabled):
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Experimental feature. Off for now while we update ResourceTiming
and NavigationTiming to be compatible with Performance Timing 2.
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):
(resetWebPreferencesToConsistentValues):
- DumpRenderTree/win/DumpRenderTree.cpp:
(enableExperimentalFeatures):
Websites/webkit.org:
- experimental-features.html:
LayoutTests:
- platform/efl/js/dom/global-constructors-attributes-expected.txt:
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
- platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- platform/win/js/dom/global-constructors-attributes-expected.txt:
Update results now that experimental User Timing feature is enabled in tests.
- 1:25 AM Changeset in webkit [211331] by
-
- 4 edits in trunk
Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
https://bugs.webkit.org/show_bug.cgi?id=167519
Reviewed by Ryosuke Niwa.
Tools:
- QueueStatusServer/templates/statusbubble.html:
To measure the bubbleContainer's width, it must not be wrapping based
on its parent container. So when measuring the width temporarily set
the parent to a very large width so as to not artificially wrap us.
Restore the parent's width after measuring.
Websites/bugs.webkit.org:
While we do post message to determine the size, the fact that we have
constrained the iframe to a size of 450px meant its body is 450px and
the div containing the bubbles wraps at 450px. Its full size (~458px)
is not returned. Although we solve this artifical constraint problem
inside of the bubble containerMetrics measuring, up this default value
from 450 to 460 to reduce UI jitter (the current measurement on my
machine is 458px).
- PrettyPatch/PrettyPatch.rb:
- 12:19 AM Changeset in webkit [211330] by
-
- 3 edits in tags/Safari-604.1.5.0.1/Source/WebKit2
Merged r211329. rdar://problem/30247736
- 12:02 AM Changeset in webkit [211329] by
-
- 3 edits in trunk/Source/WebKit2
<rdar://problem/30247736> WebKit2-7604.1.5 has failed to build: error: only virtual member functions can be marked 'override'
- UIProcess/ios/PageClientImplIOS.h: Guard the declaration of requestPasswordForQuickLookDocument with USE(QUICK_LOOK) to match the base class.
- UIProcess/ios/PageClientImplIOS.mm: Guard the implementation as well.
Jan 27, 2017:
- 11:08 PM Changeset in webkit [211328] by
-
- 4 edits in trunk/Source
Ignore Xcode’s project.xcworkspace and userdata directories in this new project like we do
in other projects.
Source/ThirdParty/libwebrtc:
- libwebrtc.xcodeproj: Added property svn:ignore.
Source/WebCore:
- PAL/PAL.xcodeproj: Added property svn:ignore.
- 11:03 PM Changeset in webkit [211327] by
-
- 3 edits in tags/Safari-604.1.5.0.1/Source/WebCore
Merged r211324. rdar://problem/30247500
- 11:02 PM Changeset in webkit [211326] by
-
- 6 edits in tags/Safari-604.1.5.0.1/Source
Versioning.
- 10:57 PM Changeset in webkit [211325] by
-
- 1 copy in tags/Safari-604.1.5.0.1
New tag.
- 10:49 PM Changeset in webkit [211324] by
-
- 3 edits in trunk/Source/WebCore
Fix the iOS build when USE(QUICK_LOOK) is disabled.
- testing/Internals.cpp:
(WebCore::Internals::setQuickLookPassword):
- testing/Internals.h:
- 9:08 PM Changeset in webkit [211323] by
-
- 3 edits in trunk/Source/WebKit/mac
[WK1] Do not prevent the drag client from initializing on Mac
https://bugs.webkit.org/show_bug.cgi?id=167541
Reviewed by Dan Bernstein.
Fixes fallout from r211192. To ensure compability with WebKit clients, we need to ensure that WebDragClient is
initialized everywhere when creating a WebView. Stub out method implementations as no-ops for non-Mac platforms.
This caused certain clients, such as Mail, to crash when a webView closes due to null dereference.
- WebCoreSupport/WebDragClient.mm:
(WebDragClient::WebDragClient):
(WebDragClient::actionMaskForDrag):
(WebDragClient::willPerformDragDestinationAction):
(WebDragClient::dragSourceActionMaskForPoint):
(WebDragClient::willPerformDragSourceAction):
(WebDragClient::startDrag):
(WebDragClient::declareAndWriteDragImage):
(WebDragClient::declareAndWriteAttachment):
- WebView/WebView.mm:
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
- 9:05 PM Changeset in webkit [211322] by
-
- 2 edits1 add in trunk/Tools
[iOS] Add a test for _WKNSFileManagerExtras
https://bugs.webkit.org/show_bug.cgi?id=167478
Reviewed by Andreas Kling.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
(expectAttributes):
(TEST):
- 8:50 PM Changeset in webkit [211321] by
-
- 5 edits in trunk/Source/WebKit2
[Cocoa] No way to get the text from a WKWebProcessPlugInRangeHandle
https://bugs.webkit.org/show_bug.cgi?id=167535
Reviewed by Sam Weinig.
Added a text property to WKWebProcessPlugInRangeHandle.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInRangeHandle.h: Declare new property.
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInRangeHandle.mm:
(-[WKWebProcessPlugInRangeHandle text]): Added. Calls InjectedBundleRangeHandle::text.
- WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:
(WebKit::InjectedBundleRangeHandle::text): Added. Calls WebCore::Range::text.
- WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:
- 7:12 PM Changeset in webkit [211320] by
-
- 1 copy in tags/Safari-603.1.23
Tag Safari-603.1.23.
- 7:09 PM Changeset in webkit [211319] by
-
- 21 edits1 add in trunk
Lift template escape sequence restrictions in tagged templates
https://bugs.webkit.org/show_bug.cgi?id=166871
Reviewed by Saam Barati.
JSTests:
Update the error messages and add new tests.
- ChakraCore/test/es6/unicode_6_identifier_Blue524737.baseline-jsc:
- stress/lift-template-literal.js: Added.
(dump):
(testTag.return.tag):
(testTag):
- stress/template-literal-syntax.js:
Source/JavaScriptCore:
This patch implements stage 3 Lifting Template Literal Restriction[1].
Prior to this patch, template literal becomes syntax error if it contains
invalid escape sequences. But it is too restricted; Template literal
can have cooked and raw representations and only cooked representation
can escape sequences. So even if invalid escape sequences are included,
the raw representation can be valid.
Lifting Template Literal Restriction relaxes the above restriction.
When invalid escape sequence is included, if target template literals
are used as tagged templates, we make the result of the template including
the invalid escape sequenceundefinedinstead of making it SyntaxError
immediately. It allows us to accept the templates including invalid
escape sequences in the raw representations in tagged templates.
On the other hand, the raw representation is only used in tagged templates.
So if invalid escape sequences are included in the usual template literals,
we just make it SyntaxError as before.
[1]: https://github.com/tc39/proposal-template-literal-revision
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitGetTemplateObject):
- bytecompiler/NodesCodegen.cpp:
(JSC::TemplateStringNode::emitBytecode):
(JSC::TemplateLiteralNode::emitBytecode):
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createTemplateString):
- parser/Lexer.cpp:
(JSC::Lexer<CharacterType>::parseUnicodeEscape):
(JSC::Lexer<T>::parseTemplateLiteral):
(JSC::Lexer<T>::lex):
(JSC::Lexer<T>::scanTemplateString):
(JSC::Lexer<T>::scanTrailingTemplateString): Deleted.
- parser/Lexer.h:
- parser/NodeConstructors.h:
(JSC::TemplateStringNode::TemplateStringNode):
- parser/Nodes.h:
(JSC::TemplateStringNode::cooked):
(JSC::TemplateStringNode::raw):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseAssignmentElement):
(JSC::Parser<LexerType>::parseTemplateString):
(JSC::Parser<LexerType>::parseTemplateLiteral):
(JSC::Parser<LexerType>::parsePrimaryExpression):
(JSC::Parser<LexerType>::parseMemberExpression):
- parser/ParserTokens.h:
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createTemplateString):
- runtime/TemplateRegistry.cpp:
(JSC::TemplateRegistry::getTemplateObject):
- runtime/TemplateRegistryKey.h:
(JSC::TemplateRegistryKey::cookedStrings):
(JSC::TemplateRegistryKey::create):
(JSC::TemplateRegistryKey::TemplateRegistryKey):
- runtime/TemplateRegistryKeyTable.cpp:
(JSC::TemplateRegistryKeyTable::createKey):
- runtime/TemplateRegistryKeyTable.h:
LayoutTests:
Update the error messages.
- inspector/runtime/parse-expected.txt:
- js/unicode-escape-sequences-expected.txt:
- 6:27 PM Changeset in webkit [211318] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: gradient editor should provide horizontal slider for 'angle' value where applicable
https://bugs.webkit.org/show_bug.cgi?id=166937
Patch by Devin Rousso <Devin Rousso> on 2017-01-27
Reviewed by Joseph Pecoraro.
- UserInterface/Views/GradientEditor.css:
(.gradient-editor):
(.gradient-editor > .gradient-angle):
(.gradient-editor > .gradient-angle > input[type="range"]):
(.gradient-editor > .gradient-angle > input[type="number"]):
(.gradient-editor > .gradient-angle > input::-webkit-inner-spin-button):
(.gradient-editor > .gradient-angle > input): Deleted.
- UserInterface/Views/GradientEditor.js:
(WebInspector.GradientEditor):
(WebInspector.GradientEditor.prototype.set gradient):
(WebInspector.GradientEditor.prototype.gradientSliderStopWasSelected):
(WebInspector.GradientEditor.prototype._gradientTypeChanged):
(WebInspector.GradientEditor.prototype._angleChanged):
(WebInspector.GradientEditor.prototype.dragToAdjustControllerWasAdjustedByAmount): Deleted.
(WebInspector.GradientEditor.prototype._angleInputValueDidChange): Deleted.
Remove the DragToAdjustController and replace with an <input type="range">.
- 5:50 PM Changeset in webkit [211317] by
-
- 6 edits in trunk/Source
Versioning.
- 5:04 PM Changeset in webkit [211316] by
-
- 5 edits in trunk/Source/JavaScriptCore
Make the CLI for the sampling profiler better for inlined call site indices
https://bugs.webkit.org/show_bug.cgi?id=167482
Reviewed by Mark Lam.
This patches changes the command line interface for the sampling
profiler to also dump the machine frame that the semantic code
origin is in if the semantic code origin is inlined. This helps
when doing performance work because it's helpful to know the
context that an inlined frame is in. Before, we used to just
say it was in the baseline JIT if it didn't have its own optimized
compile. Now, we can tell that its inlined into a DFG or FTL frame.
- inspector/agents/InspectorScriptProfilerAgent.cpp:
(Inspector::buildSamples):
- runtime/Options.h:
- runtime/SamplingProfiler.cpp:
(JSC::SamplingProfiler::processUnverifiedStackTraces):
(JSC::SamplingProfiler::reportTopFunctions):
(JSC::SamplingProfiler::reportTopBytecodes):
- runtime/SamplingProfiler.h:
(JSC::SamplingProfiler::StackFrame::CodeLocation::hasCodeBlockHash):
(JSC::SamplingProfiler::StackFrame::CodeLocation::hasBytecodeIndex):
(JSC::SamplingProfiler::StackFrame::CodeLocation::hasExpressionInfo):
(JSC::SamplingProfiler::StackFrame::hasExpressionInfo):
(JSC::SamplingProfiler::StackFrame::lineNumber):
(JSC::SamplingProfiler::StackFrame::columnNumber):
(JSC::SamplingProfiler::StackFrame::hasBytecodeIndex): Deleted.
(JSC::SamplingProfiler::StackFrame::hasCodeBlockHash): Deleted.
- 4:55 PM Changeset in webkit [211315] by
-
- 2 edits in trunk/Tools
run-benchmarks should make sure it passes the test url to the right application
https://bugs.webkit.org/show_bug.cgi?id=167533
Reviewed by Joseph Pecoraro.
This fixes an issue when trying to run-benchmark script with the
system default browser set to STP. Previously, it would run
the test in STP rather than the provided build. Now, it should run
in the provided build.
- Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
(OSXSafariDriver.launch_url):
- 4:49 PM Changeset in webkit [211314] by
-
- 3 edits4 adds in trunk
setTimeout / setInterval's string execution should inherit SourceOrigin correctly
https://bugs.webkit.org/show_bug.cgi?id=167097
Reviewed by Darin Adler.
Source/WebCore:
Tests: js/dom/modules/import-from-set-interval.html
js/dom/modules/import-from-set-timeout.html
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::executeScriptInWorld):
LayoutTests:
We set the default SourceOrigin for the ScriptController::executeScriptInWorld.
The default SourceOrigin has the document baseURL and CachedScriptFetcher.
setTimeout and setInterval use this interface. And it uses the default SourceOrigin
for the document (Realm of the setTimeout / setInterval). This is the expected
behavior in the dynamic import proposal.
- js/dom/modules/import-from-set-interval-expected.txt: Added.
- js/dom/modules/import-from-set-interval.html: Added.
- js/dom/modules/import-from-set-timeout-expected.txt: Added.
- js/dom/modules/import-from-set-timeout.html: Added.
- 4:47 PM Changeset in webkit [211313] by
-
- 10 edits3 deletes in trunk/Source/WebCore
Merge CachedModuleScript and LoadableModuleScript
https://bugs.webkit.org/show_bug.cgi?id=167500
Reviewed by Darin Adler.
CachedModuleScript becomes duplicate with LoadableModuleScript.
And CachedModuleScript does not offer any meaningful functionality
to LoadableModuleScript.
This patch merges CachedModuleScript to LoadableModuleScript.
No behavior change.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/CachedModuleScript.cpp: Removed.
- bindings/js/CachedModuleScript.h: Removed.
- bindings/js/CachedModuleScriptClient.h: Removed.
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::loadModuleScriptInWorld):
(WebCore::ScriptController::loadModuleScript):
(WebCore::ScriptController::linkAndEvaluateModuleScriptInWorld):
(WebCore::ScriptController::linkAndEvaluateModuleScript):
(WebCore::ScriptController::setupModuleScriptHandlers):
- bindings/js/ScriptController.h:
- dom/LoadableModuleScript.cpp:
(WebCore::LoadableModuleScript::create):
(WebCore::LoadableModuleScript::LoadableModuleScript):
(WebCore::LoadableModuleScript::~LoadableModuleScript):
(WebCore::LoadableModuleScript::isLoaded):
(WebCore::LoadableModuleScript::error):
(WebCore::LoadableModuleScript::wasCanceled):
(WebCore::LoadableModuleScript::notifyLoadCompleted):
(WebCore::LoadableModuleScript::notifyLoadFailed):
(WebCore::LoadableModuleScript::notifyLoadWasCanceled):
(WebCore::LoadableModuleScript::execute):
(WebCore::LoadableModuleScript::load):
(WebCore::LoadableModuleScript::notifyFinished): Deleted.
- dom/LoadableModuleScript.h:
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::executeModuleScript):
- dom/ScriptElement.h:
- 4:33 PM Changeset in webkit [211312] by
-
- 8 edits in trunk/Source/WebKit2
Move smartInsertDeleteEnabled to WebPageCreationParameters
https://bugs.webkit.org/show_bug.cgi?id=167530
Reviewed by Brady Eidson.
- Shared/WebPageCreationParameters.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::creationParameters):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::create):
(WebKit::WebPage::WebPage):
(WebKit::m_userInterfaceLayoutDirection):
(WebKit::WebPage::reinitializeWebPage):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::createWebPage):
- WebProcess/WebProcess.h:
Instead of making a WebPage then immediately sending it a message to set smartInsertDeleteEnabled,
just call setSmartInsertDeleteEnabled at the end of the WebPage creation. No change in behaviour.
- 4:27 PM Changeset in webkit [211311] by
-
- 1 edit2 adds in trunk/Websites/webkit.org
Add a simple demo for Touch stylus events
https://bugs.webkit.org/show_bug.cgi?id=167534
Reviewed by Simon Fraser.
- demos/touch/stylus.html: Added.
- 4:10 PM Changeset in webkit [211310] by
-
- 6 edits in trunk/Source/WebKit2
IconLoadingClient API doesn't work asynchronously.
<rdar://problem/30243429> and https://bugs.webkit.org/show_bug.cgi?id=167532
Reviewed by Alex Christensen.
Make a WTF::Function (inherently not compatible with ObjC blocks as they must be copyable)
into a std::function, which is copyable.
- UIProcess/API/APIIconLoadingClient.h:
(API::IconLoadingClient::getLoadDecisionForIcon):
- UIProcess/API/mac/WKView.mm:
(-[WKView maybeInstallIconLoadingClient]):
- UIProcess/Cocoa/IconLoadingDelegate.h:
- UIProcess/Cocoa/IconLoadingDelegate.mm:
(WebKit::IconLoadingDelegate::IconLoadingClient::getLoadDecisionForIcon):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getLoadDecisionForIcon):
- 4:03 PM Changeset in webkit [211309] by
-
- 2 edits in trunk/Source/WebCore
JSCustomElementInterface::invokeCallback can be called with a null callback because Weak<>
https://bugs.webkit.org/show_bug.cgi?id=167522
Reviewed by Filip Pizlo.
Added all provided callbacks to the global object with a private name the same way
that the constructor was added. This will keep these callbacks from being GC'ed.
- bindings/js/JSCustomElementRegistryCustom.cpp:
(WebCore::JSCustomElementRegistry::define):
- 3:56 PM Changeset in webkit [211308] by
-
- 6 edits in trunk
[Cocoa] Prepare ComplexTextController for unit testing
https://bugs.webkit.org/show_bug.cgi?id=167493
Reviewed by Simon Fraser.
Addressing post-review comments from Simon Fraser.
Source/WebCore:
- platform/graphics/FontCascade.h:
- platform/graphics/mac/ComplexTextController.h:
(WebCore::ComplexTextController::ComplexTextRun::createForTesting):
- platform/graphics/mac/ComplexTextControllerCoreText.h:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
Tools:
- TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
(TestWebKitAPI::TEST_F):
- 3:43 PM Changeset in webkit [211307] by
-
- 3 edits in trunk/LayoutTests
Tweak the test to avoid one pixel of difference on some hardware.
- css3/filters/backdrop/backdrop-filter-uneven-corner-radii-expected.html:
- css3/filters/backdrop/backdrop-filter-uneven-corner-radii.html:
- 3:29 PM Changeset in webkit [211306] by
-
- 3 edits in trunk/Source/JavaScriptCore
Extend create_hash_table to specify Intrinsic
https://bugs.webkit.org/show_bug.cgi?id=167505
Reviewed by Sam Weinig.
This patch extends create_hash_table to specify Intrinsic.
We can set Intrinsic in the static property table definition
in runtime/XXX.h.
And drop the adhoc code for String.fromCharCode in create_hash_table.
- create_hash_table:
- runtime/StringConstructor.cpp:
- 3:16 PM Changeset in webkit [211305] by
-
- 4 edits2 adds in trunk
Element with a backdrop-filter and a mask may not correctly mask the backdrop
https://bugs.webkit.org/show_bug.cgi?id=167456
rdar://problem/29320059
Reviewed by Antoine Quint.
Source/WebCore:
If a layer had a backdrop filter, but also corner radii that triggered using a mask layer,
then the call to updateClippingStrategy() in GraphicsLayerCA::updateBackdropFiltersRect() would
set the backdrop layer's mask, but GraphicsLayerCA::updateMaskLayer() would promptly then set
the mask layer back to nil.
Fix by having GraphicsLayerCA::updateMaskLayer() put the mask on the structural layer, if there
is one. We always have a structural layer with backdrops, so this will mask both the layer
and the backdrop.
Test: css3/filters/backdrop/backdrop-filter-uneven-corner-radii.html
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateMaskLayer):
- platform/graphics/mac/WebLayer.mm:
(-[CALayer _descriptionWithPrefix:]): Dump the mask layer.
LayoutTests:
- css3/filters/backdrop/backdrop-filter-uneven-corner-radii-expected.html: Added.
- css3/filters/backdrop/backdrop-filter-uneven-corner-radii.html: Added.
- 3:11 PM Changeset in webkit [211304] by
-
- 7 edits in trunk/Source
Fix remaining bad uses of logDiagnosticMessageWithValue()
https://bugs.webkit.org/show_bug.cgi?id=167526
Reviewed by Alex Christensen.
Source/WebCore:
Drop unused keys, add new ones.
- page/DiagnosticLoggingKeys.cpp:
(WebCore::DiagnosticLoggingKeys::networkCacheFailureReasonKey):
(WebCore::DiagnosticLoggingKeys::networkCacheUnusedReasonKey):
(WebCore::DiagnosticLoggingKeys::networkCacheReuseFailureKey):
(WebCore::DiagnosticLoggingKeys::backNavigationDeltaKey):
(WebCore::DiagnosticLoggingKeys::userZoomActionKey):
(WebCore::DiagnosticLoggingKeys::deltaKey): Deleted.
(WebCore::DiagnosticLoggingKeys::backNavigationKey): Deleted.
(WebCore::DiagnosticLoggingKeys::requestKey): Deleted.
(WebCore::DiagnosticLoggingKeys::unusableCachedEntryKey): Deleted.
(WebCore::DiagnosticLoggingKeys::userKey): Deleted.
(WebCore::DiagnosticLoggingKeys::zoomedKey): Deleted.
(WebCore::DiagnosticLoggingKeys::notInCacheKey): Deleted.
- page/DiagnosticLoggingKeys.h:
Source/WebKit2:
Fix remaining bad uses of logDiagnosticMessageWithValue(). It can only
be called with numeric values.
- NetworkProcess/cache/NetworkCacheStatistics.cpp:
(WebKit::NetworkCache::Statistics::recordNotUsingCacheForRequest):
(WebKit::NetworkCache::Statistics::recordRetrievalFailure):
(WebKit::NetworkCache::Statistics::recordRetrievedCachedEntry):
- UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::goToItem):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::willStartUserTriggeredZooming):
- 2:39 PM Changeset in webkit [211303] by
-
- 2 edits in trunk/Source/WebCore
Proclaim that we are considering font-display, rhythmic sizing, and text decoration level 4
https://bugs.webkit.org/show_bug.cgi?id=167340
Reviewed by Saam Barati.
- features.json:
- 2:23 PM Changeset in webkit [211302] by
-
- 4 edits in trunk/LayoutTests
media/track/track-in-band-style.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=167516
Reviewed by Eric Carlson.
Update the test to use 'cuechange' rather than a 200ms timer.
- media/track/track-in-band-style-expected.txt:
- media/track/track-in-band-style.html:
- platform/mac/TestExpectations:
- 1:07 PM Changeset in webkit [211301] by
-
- 6 edits in trunk/Source/WebCore
Fix diagnostic logging under loader/
https://bugs.webkit.org/show_bug.cgi?id=167512
Reviewed by Alex Christensen.
Fix diagnostic logging under loader/. We should not be using logDiagnosticLoggingWithValue()
without a numeric value.
- loader/ResourceLoader.cpp:
(WebCore::logResourceResponseSource):
- loader/SubresourceLoader.cpp:
(WebCore::logResourceLoaded):
- loader/cache/CachedResourceLoader.cpp:
(WebCore::logMemoryCacheResourceRequest):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::logRevalidation):
- page/DiagnosticLoggingKeys.cpp:
(WebCore::DiagnosticLoggingKeys::memoryCacheEntryDecisionKey):
(WebCore::DiagnosticLoggingKeys::memoryCacheUsageKey):
(WebCore::DiagnosticLoggingKeys::cachedResourceRevalidationReasonKey):
(WebCore::DiagnosticLoggingKeys::resourceLoadedKey):
(WebCore::DiagnosticLoggingKeys::resourceResponseSourceKey):
- page/DiagnosticLoggingKeys.h:
- 1:01 PM Changeset in webkit [211300] by
-
- 2 edits in trunk/Source/JavaScriptCore
scanExternalRememberedSet needs to mergeIfNecessary
https://bugs.webkit.org/show_bug.cgi?id=167523
Reviewed by Keith Miller.
The protocol for opaque roots is that if you add to them outside of draining, then you need to call
mergeIfNecessary.
This means that every MarkingConstraint that adds opaque roots needs to mergeIfNecessary after.
scanExternalRememberedSet transitively calls addOpaqueRoot, is called from a MarkingConstraint, and
was missing a call to mergeIfNecessary. This fixes it.
- API/JSVirtualMachine.mm:
(scanExternalRememberedSet):
- 12:41 PM Changeset in webkit [211299] by
-
- 1 delete in tags/Safari-604.1.5.1
Deleting tag.
- 12:35 PM Changeset in webkit [211298] by
-
- 4 edits in trunk/Source/WebCore
Fix diagnostic logging in media code
https://bugs.webkit.org/show_bug.cgi?id=167510
Reviewed by Alex Christensen.
Fix diagnostic logging in media code. It should not use logDiagnosticMessageWithValue()
with a non-numeric value.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::loadResource):
(WebCore::HTMLMediaElement::updatePlayState):
- 12:35 PM Changeset in webkit [211297] by
-
- 1 copy in tags/Safari-604.1.5.1
New tag.
- 12:34 PM Changeset in webkit [211296] by
-
- 1 copy in tags/Safari-604.1.5
New tag.
- 12:33 PM Changeset in webkit [211295] by
-
- 2 edits in trunk/Source/WebKit2
Round CPU Usage diagnostic logging to 2 significant digits
https://bugs.webkit.org/show_bug.cgi?id=167515
<rdar://problem/30236297>
Reviewed by Antti Koivisto.
Round CPU Usage diagnostic logging to 2 significant digits
as requested by diagnostic logging team.
- UIProcess/PerActivityStateCPUUsageSampler.cpp:
(WebKit::toStringRoundingSignificantFigures):
(WebKit::PerActivityStateCPUUsageSampler::loggingTimerFired):
- 12:28 PM Changeset in webkit [211294] by
-
- 9 edits1 add in trunk
[Cocoa] Prepare ComplexTextController for unit testing
https://bugs.webkit.org/show_bug.cgi?id=167493
Reviewed by Dean Jackson.
Source/WebCore:
ComplexTextController has three phases:
- Interrogate Core Text about some text
- Compute layout advances and paint advances from the information retrieved from
Core Text
- Iterate through the layout advances or paint advances.
This patch tests phases 2 and 3 by chopping ComplexTextController between
phases 1 and 2, and injecting foreign metrics from a unit test. These metrics
have been gathered from real-world uses; however, a layout test is not appropriate
because the fonts which produced these metrics are not licensed appropriately.
The tests can enforce the correct behavior by using ComplexTextController's
public API.
This is in preparation for https://bugs.webkit.org/show_bug.cgi?id=166013.
However, the fix for that bug is quite large, so I've split out this smaller piece
to ease the reviewing burden. The tests I've added are disabled for now (because
they fail), but will be enabled by the fix to that bug.
No new tests because there is no behavior change.
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/FontCascade.h:
- platform/graphics/FontDescription.h:
- platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::finishConstruction):
- platform/graphics/mac/ComplexTextController.h:
(WebCore::ComplexTextController::ComplexTextRun::createForTesting):
- platform/graphics/mac/ComplexTextControllerCoreText.mm:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
Tools:
Create four unit tests.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
(TestWebKitAPI::ComplexTextControllerTest::SetUp):
(TestWebKitAPI::TEST_F):
- 11:37 AM Changeset in webkit [211293] by
-
- 2 edits in trunk/LayoutTests
LayoutTest fast/mediastream/getUserMedia-webaudio.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=167513
Unreviewed.
Patch by Youenn Fablet <youenn@apple.com> on 2017-01-27
- TestExpectations: Not yet ready to run this test.
- 11:24 AM Changeset in webkit [211292] by
-
- 3 edits2 adds in trunk
Simple line layout: Do not bail out on -webkit-line-box-contain: block glyphs unless text overflows vertically.
https://bugs.webkit.org/show_bug.cgi?id=167481
<rdar://problem/30180150>
Reviewed by Antti Koivisto.
Source/WebCore:
Since -webkit-line-box-contain: glyphs requires variable line height support, we can use simple line layout
only when each line happen to have the same height ('block' property value is set, glyphs do not overflow the block line height).
Test: fast/text/simple-line-layout-line-box-contain-glyphs.html
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::canUseForText):
(WebCore::SimpleLineLayout::canUseForFontAndText):
(WebCore::SimpleLineLayout::canUseForStyle):
(WebCore::SimpleLineLayout::printReason):
LayoutTests:
- fast/text/simple-line-layout-line-box-contain-glyphs-expected.html: Added.
- fast/text/simple-line-layout-line-box-contain-glyphs.html: Added.
- 11:14 AM Changeset in webkit [211291] by
-
- 4 edits in trunk/Source/WebCore
Fix PageCache diagnostic logging
https://bugs.webkit.org/show_bug.cgi?id=167508
Reviewed by Sam Weinig.
Fix PageCache diagnostic logging. It should not call logDiagnosticMessageWithValue()
with a non-numeric value. Use logDiagnosticMessage() instead.
- history/PageCache.cpp:
(WebCore::logPageCacheFailureDiagnosticMessage):
(WebCore::canCacheFrame):
- page/DiagnosticLoggingKeys.cpp:
(WebCore::DiagnosticLoggingKeys::pageCacheFailureKey):
(WebCore::DiagnosticLoggingKeys::successKey): Deleted.
(WebCore::DiagnosticLoggingKeys::failureKey): Deleted.
- page/DiagnosticLoggingKeys.h:
- 11:07 AM Changeset in webkit [211290] by
-
- 15 edits3 deletes in branches/safari-603-branch
- 10:58 AM Changeset in webkit [211289] by
-
- 5 edits2 adds in trunk
Styles should not show background-repeat-x/y, or -webkit-mask-repeat-x/y
https://bugs.webkit.org/show_bug.cgi?id=167255
Patch by Devin Rousso <Devin Rousso> on 2017-01-27
Reviewed by Joseph Pecoraro.
Source/WebCore:
Test: inspector/css/css-property.html
- css/makeprop.pl:
(addProperty):
Add a generated functionisInternalCSSPropertythat checks the given CSSPropertyID against
a derived list of properties from CSSProperties.json with "internal-only".
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::getSupportedCSSProperties):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::styleWithProperties):
Only pass CSS property payloads to the frontend if they are not internal.
LayoutTests:
Checks that internal-only CSS properties are marked as invalid when passed to WebInspector.
- inspector/css/css-property-expected.txt: Added.
- inspector/css/css-property.html: Added.
- 10:44 AM Changeset in webkit [211288] by
-
- 7 edits6 adds in trunk
Implement Cache-control: immutable
https://bugs.webkit.org/show_bug.cgi?id=167497
Reviewed by Chris Dumez.
Source/WebCore:
Cache-control value 'immutable' indicates that a subresource does not change and so does not need to be
revalidated on a normal reload. This can significantly speed up reloads and reduce network traffic.
It is has been implemented in Firefox and is already used by Facebook.
https://tools.ietf.org/html/draft-mcmanus-immutable-00
https://hacks.mozilla.org/2017/01/using-immutable-caching-to-speed-up-the-web/
This patch implements Cache-control: immutable for memory cache only. A disk cache implementation
doesn't seem necessary as the resource is basically always expected to be in memory cache on reload.
Immutable is only supported for https as suggested by the draft specification (and Gecko implementation).
Test: http/tests/cache/cache-control-immutable-http.html
http/tests/cache/cache-control-immutable-https.html
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::makeRevalidationDecision):
On normal reloads (CachePolicyRevalidate) of https resources check for 'Cache-control: immutable'.
If the resource is not expired don't revalidate it.
- platform/network/CacheValidation.cpp:
(WebCore::parseCacheControlDirectives):
- platform/network/CacheValidation.h:
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::cacheControlContainsImmutable):
- platform/network/ResourceResponseBase.h:
LayoutTests:
- http/tests/cache/cache-control-immutable-http-expected.txt: Added.
- http/tests/cache/cache-control-immutable-http.html: Added.
- http/tests/cache/cache-control-immutable-https-expected.txt: Added.
- http/tests/cache/cache-control-immutable-https.html: Added.
- http/tests/cache/resources/cache-control-immutable.js: Added.
- http/tests/cache/resources/iframe-with-script.cgi: Added.
- 10:39 AM Changeset in webkit [211287] by
-
- 4 edits in branches/safari-603-branch/Source/WebCore
Merge r211285.
- 10:20 AM Changeset in webkit [211286] by
-
- 2 edits in trunk/Source/WebCore
[WebRTC] Use MediaEndPointPeerConnection if not using libwebrtc
https://bugs.webkit.org/show_bug.cgi?id=167504
Patch by Youenn Fablet <youennf@gmail.com> on 2017-01-27
Reviewed by Alex Christensen.
No change of behavior.
- Modules/mediastream/MediaEndpointPeerConnection.cpp: If libwebrtc, we should use libwebrtc peer connection backend.
- 10:06 AM WebKitGTK/Debugging edited by
- (diff)
- 10:04 AM WebKitGTK/Debugging edited by
- (diff)
- 9:29 AM Changeset in webkit [211285] by
-
- 4 edits in trunk/Source/WebCore
Rebaseline bindings tests after r211238.
Unreviewed test gardening.
- bindings/scripts/test/JS/JSTestDOMJIT.cpp:
(WebCore::JSTestDOMJIT::visitChildren):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTarget::visitChildren):
- bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNode::visitChildren):
- 9:29 AM Changeset in webkit [211284] by
-
- 2 edits in trunk/LayoutTests
Marking media/modern-media-controls/layout-node/addChild.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=167461
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 8:28 AM Changeset in webkit [211283] by
-
- 5 edits2 adds in trunk/Source/WebCore
[css-grid] Move Grid class out of RenderGrid
https://bugs.webkit.org/show_bug.cgi?id=167418
Reviewed by Antti Koivisto.
The RenderGrid should be able to use different implementations of
the Grid class. The latter is big enough to be in its own file. That
would help on the effort of moving the grid track sizing algorithm
out of RenderGrid too.
No new tests required as we're just moving code.
- CMakeLists.txt:
- rendering/Grid.cpp: Added.
(WebCore::Grid::Grid):
(WebCore::Grid::numTracks):
(WebCore::Grid::ensureGridSize):
(WebCore::Grid::insert):
(WebCore::Grid::setSmallestTracksStart):
(WebCore::Grid::smallestTrackStart):
(WebCore::Grid::gridItemArea):
(WebCore::Grid::setGridItemArea):
(WebCore::Grid::setAutoRepeatTracks):
(WebCore::Grid::autoRepeatTracks):
(WebCore::Grid::setAutoRepeatEmptyColumns):
(WebCore::Grid::setAutoRepeatEmptyRows):
(WebCore::Grid::hasAutoRepeatEmptyTracks):
(WebCore::Grid::isEmptyAutoRepeatTrack):
(WebCore::Grid::autoRepeatEmptyTracks):
(WebCore::Grid::gridItemSpan):
(WebCore::Grid::setNeedsItemsPlacement):
(WebCore::GridIterator::GridIterator):
(WebCore::GridIterator::nextGridItem):
(WebCore::GridIterator::isEmptyAreaEnough):
(WebCore::GridIterator::nextEmptyGridArea):
- rendering/Grid.h: Added.
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeEmptyTracksForAutoRepeat):
(WebCore::RenderGrid::Grid::numTracks): Deleted.
(WebCore::RenderGrid::Grid::ensureGridSize): Deleted.
(WebCore::RenderGrid::Grid::insert): Deleted.
(WebCore::RenderGrid::Grid::setSmallestTracksStart): Deleted.
(WebCore::RenderGrid::Grid::smallestTrackStart): Deleted.
(WebCore::RenderGrid::Grid::gridItemArea): Deleted.
(WebCore::RenderGrid::Grid::setGridItemArea): Deleted.
(WebCore::RenderGrid::Grid::setAutoRepeatTracks): Deleted.
(WebCore::RenderGrid::Grid::autoRepeatTracks): Deleted.
(WebCore::RenderGrid::Grid::setAutoRepeatEmptyColumns): Deleted.
(WebCore::RenderGrid::Grid::setAutoRepeatEmptyRows): Deleted.
(WebCore::RenderGrid::Grid::hasAutoRepeatEmptyTracks): Deleted.
(WebCore::RenderGrid::Grid::isEmptyAutoRepeatTrack): Deleted.
(WebCore::RenderGrid::Grid::autoRepeatEmptyTracks): Deleted.
(WebCore::RenderGrid::Grid::gridItemSpan): Deleted.
(WebCore::RenderGrid::Grid::setNeedsItemsPlacement): Deleted.
(WebCore::RenderGrid::GridIterator::GridIterator): Deleted.
(WebCore::RenderGrid::GridIterator::nextGridItem): Deleted.
(WebCore::RenderGrid::GridIterator::isEmptyAreaEnough): Deleted.
(WebCore::RenderGrid::GridIterator::nextEmptyGridArea): Deleted.
- rendering/RenderGrid.h:
- 7:58 AM Changeset in webkit [211282] by
-
- 2 edits in trunk/Websites/webkit.org
Unreviewed, update scroll snapping demos to use current Module 1 spec
- demos/scroll-snap/index.html:
Adopt the new CSS properties scroll-snap-type and scroll-snap-align.
- 4:10 AM Changeset in webkit [211281] by
-
- 3 edits in trunk/Source/WebKit2
[Threaded Compositor] Stop creating the GLContext on demand the first time makeContextCurrent is called
https://bugs.webkit.org/show_bug.cgi?id=167496
Reviewed by Žan Doberšek.
This is causing problems with animations when entering AC mode on demand. What happens is that the threaded
compositor is created, then the animation is scheduled and during the first animation iteration the GLContext is
created, making the first frame of the animation quite slow. In my computer creating the GLContext takes 0.8
seconds. If the animation duration is less than the time it takes to create the GLContext, the animation ends
without iterating. This causing timeouts in the bots in tests like
animations/animation-iteration-event-destroy-renderer.html that expect webkitAnimationIteration events that
never fire.
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
(WebKit::ThreadedCompositor::ThreadedCompositor): Create the GLContext right after the compositing thread is
created if we already have a native surface handle.
(WebKit::ThreadedCompositor::createGLContext): Helper to create the GLContext.
(WebKit::ThreadedCompositor::setNativeSurfaceHandleForCompositing): Create the GLContext when a native surface
handle is given.
(WebKit::ThreadedCompositor::makeContextCurrent): Deleted.
(WebKit::ThreadedCompositor::renderLayerTree): Make the context cunrrent directly here.
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
- 2:49 AM Changeset in webkit [211280] by
-
- 41 edits10 copies70 adds in trunk
Implement dynamic-import for WebCore
https://bugs.webkit.org/show_bug.cgi?id=166926
Reviewed by Ryosuke Niwa.
Source/WebCore:
This patch introduces browser side dynamic-import implementation.
The dynamic-import is new ES feature which is now stage 3.
The JSC shell already implements it.
The dynamic-import allows us to kick module loading in a dynamic manner.
For example, you can write,
await module = import(
${HOST}/hello.js);
The dynamic
importoperator (this is not a function) returns a promise with
module namespace object if the module loading succeeds. Otherwise, it returns
a rejected promise.
And importantly, this feature allows us to kick module loading from classic script.
Previously, module loading can be only used from <script type="module"> tag. And
all the module loading is done statically.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/CachedModuleScriptLoader.cpp:
(WebCore::CachedModuleScriptLoader::load):
- bindings/js/CachedScriptFetcher.cpp:
(WebCore::CachedScriptFetcher::create):
(WebCore::CachedScriptFetcher::requestModuleScript):
requestModuleScript function is used only when loading a new module script.
So, LoadableClassicScript should use requestScriptWithCache to load itself.
We pass String() for cross origin mode for null cross origin attribute as
specified.
(WebCore::CachedScriptFetcher::requestScriptWithCache):
- bindings/js/CachedScriptFetcher.h:
(WebCore::CachedScriptFetcher::CachedScriptFetcher):
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::moduleLoaderImportModule):
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::initializeJSFunction):
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::executeScript):
- bindings/js/ScriptModuleLoader.cpp:
(WebCore::resolveModuleSpecifier):
Extract the part of resolving module specifier to a static function to use
it in ScriptModuleLoader::resolve and ScriptModuleLoader::importModule.
(WebCore::ScriptModuleLoader::resolve):
(WebCore::rejectPromise):
(WebCore::ScriptModuleLoader::importModule):
New hook moduleLoaderImportModule is implemented. This hook is called when
importoperator is used. This hook is responsible to
- resolve the module name to obtain module specifier. (like, resolve the
relative URL to get absolute URL.)
- kick module loading with the resolved specifier.
When resolving the module name, the referrer information is needed.
For example, "./script.js" will be resolved to "http://example.com/script.js" if
the referrer module specifier is "http://example.com/".
Ifimport("./script.js")is executed in the classic script
src="http://example.com/test.js", it starts loading "http://example.com/script.js".
So the information of the caller ofimportoperator is necessary here.
This appropriate referrer is propagated by SourceOrigin.
- bindings/js/ScriptModuleLoader.h:
- dom/InlineClassicScript.h:
- dom/LoadableClassicScript.cpp:
(WebCore::LoadableClassicScript::load):
- dom/LoadableClassicScript.h:
- dom/LoadableModuleScript.h:
- dom/LoadableScript.h:
(WebCore::LoadableScript::LoadableScript):
(WebCore::LoadableScript::isClassicScript): Deleted.
(WebCore::LoadableScript::isModuleScript): Deleted.
- dom/ScriptElement.h:
- dom/ScriptElementCachedScriptFetcher.cpp: Copied from Source/WebCore/dom/InlineClassicScript.h.
(WebCore::ScriptElementCachedScriptFetcher::requestModuleScript):
This requestModuleScript will be used when the script tag (or modules imported from the script tag) usesimportoperator.
In classic scripts,crossoriginmode always becomes "omit" while module scripts
propagate the originalcrossoriginvalue.
- dom/ScriptElementCachedScriptFetcher.h: Copied from Source/WebCore/bindings/js/CachedScriptFetcher.h.
(WebCore::ScriptElementCachedScriptFetcher::crossOriginMode):
(WebCore::ScriptElementCachedScriptFetcher::ScriptElementCachedScriptFetcher):
LayoutTests:
- http/tests/misc/import-absolute-url-expected.txt: Added.
- http/tests/misc/import-absolute-url.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/import-scriptnonce-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/1.1/import-scriptnonce.html: Added.
- http/tests/security/contentSecurityPolicy/1.1/resources/import-scriptnonce-allowed1.js: Added.
- http/tests/security/contentSecurityPolicy/1.1/resources/import-scriptnonce-allowed2.js: Added.
- http/tests/security/contentSecurityPolicy/1.1/resources/import-scriptnonce-allowed3.js: Added.
- http/tests/security/contentSecurityPolicy/1.1/resources/import-scriptnonce-allowed4.js: Added.
- http/tests/security/contentSecurityPolicy/1.1/resources/import-scriptnonce-allowed5.js: Added.
- http/tests/security/contentSecurityPolicy/1.1/resources/import-scriptnonce-allowed6.js: Added.
- http/tests/security/contentSecurityPolicy/1.1/resources/import-scriptnonce-blocked1.js: Added.
- http/tests/security/contentSecurityPolicy/1.1/resources/import-scriptnonce-blocked2.js: Added.
- http/tests/security/contentSecurityPolicy/1.1/resources/import-scriptnonce-blocked3.js: Added.
- http/tests/security/contentSecurityPolicy/1.1/resources/import-scriptnonce-blocked4.js: Added.
- http/tests/security/contentSecurityPolicy/1.1/resources/import-scriptnonce-blocked5.js: Added.
- http/tests/security/contentSecurityPolicy/1.1/resources/import-scriptnonce-blocked6.js: Added.
- http/tests/security/import-module-crossorigin-loads-error-expected.txt: Added.
- http/tests/security/import-module-crossorigin-loads-error-src-expected.txt: Added.
- http/tests/security/import-module-crossorigin-loads-error-src.html: Added.
- http/tests/security/import-module-crossorigin-loads-error.html: Added.
- http/tests/security/import-module-crossorigin-loads-expected.txt: Added.
- http/tests/security/import-module-crossorigin-loads-src-expected.txt: Added.
- http/tests/security/import-module-crossorigin-loads-src.html: Added.
- http/tests/security/import-module-crossorigin-loads.html: Added.
- http/tests/security/import-script-crossorigin-loads-error-expected.txt: Added.
- http/tests/security/import-script-crossorigin-loads-error.html: Added.
- http/tests/security/import-script-crossorigin-loads-omit-expected.txt: Added.
- http/tests/security/import-script-crossorigin-loads-omit.html: Added.
- http/tests/security/resources/cors-deny.php: Added.
- http/tests/security/resources/import-module-crossorigin-loads-error-src.js: Added.
(import.string_appeared_here.then):
- http/tests/security/resources/import-module-crossorigin-loads-src.js: Added.
(import.string_appeared_here.then):
- js/dom/modules/import-execution-order-expected.txt: Added.
- js/dom/modules/import-execution-order.html: Copied from LayoutTests/js/dom/modules/module-execution-error-inside-dependent-module-should-be-propagated-to-onerror.html.
- js/dom/modules/import-from-handler-expected.txt: Added.
- js/dom/modules/import-from-handler.html: Copied from LayoutTests/js/dom/modules/module-src-simple.html.
- js/dom/modules/import-from-javascript-url-expected.txt: Added.
- js/dom/modules/import-from-javascript-url.html: Copied from LayoutTests/js/dom/modules/module-execution-error-inside-dependent-module-should-be-propagated-to-onerror.html.
- js/dom/modules/import-from-loaded-classic-expected.txt: Added.
- js/dom/modules/import-from-loaded-classic.html: Copied from LayoutTests/js/dom/modules/module-src-simple.html.
- js/dom/modules/import-from-loaded-module-expected.txt: Added.
- js/dom/modules/import-from-loaded-module.html: Copied from LayoutTests/js/dom/modules/module-src-simple.html.
- js/dom/modules/import-from-module-expected.txt: Added.
- js/dom/modules/import-from-module.html: Copied from LayoutTests/js/dom/modules/module-src-simple.html.
- js/dom/modules/import-incorrect-relative-specifier-expected.txt: Added.
- js/dom/modules/import-incorrect-relative-specifier.html: Copied from LayoutTests/js/dom/modules/module-src-simple.html.
- js/dom/modules/import-simple-expected.txt: Added.
- js/dom/modules/import-simple.html: Copied from LayoutTests/js/dom/modules/module-src-simple.html.
- js/dom/modules/module-document-write-src.html:
- js/dom/modules/module-execution-error-inside-dependent-module-should-be-propagated-to-onerror.html:
- js/dom/modules/module-execution-order-mixed-with-classic-scripts.html:
- js/dom/modules/module-execution-order-mixed.html:
- js/dom/modules/module-inline-dynamic.html:
- js/dom/modules/module-inline-simple.html:
- js/dom/modules/module-load-event-with-src.html:
- js/dom/modules/module-load-same-module-from-different-entry-point-dynamic.html:
- js/dom/modules/module-load-same-module-from-different-entry-point-in-src.html:
- js/dom/modules/module-load-same-module-from-different-entry-point.html:
- js/dom/modules/module-not-found-error-event-with-src-and-import.html:
- js/dom/modules/module-src-current-script.html:
- js/dom/modules/module-src-dynamic.html:
- js/dom/modules/module-src-simple.html:
- js/dom/modules/module-type-case-insensitive.html:
- js/dom/modules/module-will-fire-beforeload.html:
- js/dom/modules/nomodule-dynamic-classic-src.html:
- js/dom/modules/nomodule-has-no-effect-on-module-inline.html:
- js/dom/modules/nomodule-has-no-effect-on-module-src.html:
- js/dom/modules/nomodule-prevents-execution-classic-script-src.html:
- js/dom/modules/nomodule-reflect.html:
- js/dom/modules/resources/error-classic-script.js: Renamed from LayoutTests/js/dom/modules/script-tests/error-classic-script.js.
- js/dom/modules/resources/import-from-loaded-classic-finish.js: Added.
- js/dom/modules/resources/import-from-loaded-classic.js: Added.
- js/dom/modules/resources/import-from-loaded-module-finish.js: Added.
- js/dom/modules/resources/import-from-loaded-module.js: Added.
- js/dom/modules/resources/module-document-write-src.js: Renamed from LayoutTests/js/dom/modules/script-tests/module-document-write-src.js.
- js/dom/modules/resources/module-execution-error-inside-dependent-module-should-be-propagated-to-onerror-throw.js: Renamed from LayoutTests/js/dom/modules/script-tests/module-execution-error-inside-dependent-module-should-be-propagated-to-onerror-throw.js.
- js/dom/modules/resources/module-execution-error-inside-dependent-module-should-be-propagated-to-onerror.js: Renamed from LayoutTests/js/dom/modules/script-tests/module-execution-error-inside-dependent-module-should-be-propagated-to-onerror.js.
- js/dom/modules/resources/module-execution-order-mixed-2.js: Renamed from LayoutTests/js/dom/modules/script-tests/module-execution-order-mixed-2.js.
- js/dom/modules/resources/module-execution-order-mixed-cappuccino.js: Renamed from LayoutTests/js/dom/modules/script-tests/module-execution-order-mixed-cappuccino.js.
- js/dom/modules/resources/module-execution-order-mixed-cocoa.js: Renamed from LayoutTests/js/dom/modules/script-tests/module-execution-order-mixed-cocoa.js.
- js/dom/modules/resources/module-execution-order-mixed-matcha.js: Renamed from LayoutTests/js/dom/modules/script-tests/module-execution-order-mixed-matcha.js.
- js/dom/modules/resources/module-execution-order-mixed-with-classic-scripts-2.js: Renamed from LayoutTests/js/dom/modules/script-tests/module-execution-order-mixed-with-classic-scripts-2.js.
- js/dom/modules/resources/module-execution-order-mixed-with-classic-scripts-cappuccino.js: Renamed from LayoutTests/js/dom/modules/script-tests/module-execution-order-mixed-with-classic-scripts-cappuccino.js.
- js/dom/modules/resources/module-execution-order-mixed-with-classic-scripts-cocoa.js: Renamed from LayoutTests/js/dom/modules/script-tests/module-execution-order-mixed-with-classic-scripts-cocoa.js.
- js/dom/modules/resources/module-execution-order-mixed-with-classic-scripts-matcha.js: Renamed from LayoutTests/js/dom/modules/script-tests/module-execution-order-mixed-with-classic-scripts-matcha.js.
- js/dom/modules/resources/module-execution-order-mixed-with-classic-scripts.js: Renamed from LayoutTests/js/dom/modules/script-tests/module-execution-order-mixed-with-classic-scripts.js.
- js/dom/modules/resources/module-execution-order-mixed.js: Renamed from LayoutTests/js/dom/modules/script-tests/module-execution-order-mixed.js.
- js/dom/modules/resources/module-inline-dynamic.js: Renamed from LayoutTests/js/dom/modules/script-tests/module-inline-dynamic.js.
- js/dom/modules/resources/module-inline-simple.js: Renamed from LayoutTests/js/dom/modules/script-tests/module-inline-simple.js.
- js/dom/modules/resources/module-load-event-with-src.js: Renamed from LayoutTests/js/dom/modules/script-tests/module-load-event-with-src.js.
- js/dom/modules/resources/module-load-same-module-from-different-entry-point.js: Renamed from LayoutTests/js/dom/modules/script-tests/module-load-same-module-from-different-entry-point.js.
- js/dom/modules/resources/module-not-found-error-event-with-src-and-import.js: Renamed from LayoutTests/js/dom/modules/script-tests/module-not-found-error-event-with-src-and-import.js.
- js/dom/modules/resources/module-src-current-script.js: Renamed from LayoutTests/js/dom/modules/script-tests/module-src-current-script.js.
- js/dom/modules/resources/module-src-dynamic-cocoa.js: Renamed from LayoutTests/js/dom/modules/script-tests/module-src-dynamic-cocoa.js.
- js/dom/modules/resources/module-src-dynamic.js: Renamed from LayoutTests/js/dom/modules/script-tests/module-src-dynamic.js.
- js/dom/modules/resources/module-src-simple-cocoa.js: Renamed from LayoutTests/js/dom/modules/script-tests/module-src-simple-cocoa.js.
- js/dom/modules/resources/module-src-simple.js: Renamed from LayoutTests/js/dom/modules/script-tests/module-src-simple.js.
- js/dom/modules/resources/module-will-fire-beforeload.js: Renamed from LayoutTests/js/dom/modules/script-tests/module-will-fire-beforeload.js.
- 1:19 AM Changeset in webkit [211279] by
-
- 46 edits2 copies1 move1 delete in branches/safari-603-branch/Source
Merge r211237. rdar://problem/30179506
- 1:18 AM Changeset in webkit [211278] by
-
- 3 edits1 add in branches/safari-603-branch
Merge r211246. rdar://problem/29916672
- 12:54 AM Changeset in webkit [211277] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Stop forcing accelerated compositing by default
https://bugs.webkit.org/show_bug.cgi?id=167492
Reviewed by Žan Doberšek.
We are now ready to bring back the on demand accelerated compositing mode with the threaded
compositor. Unfortunately, having AC always enabled brought a lot of issues for many people. Not only it
requires a lot more memory but also caused rendering issues (or even nothing rendered at all) with some graphics
drivers. People started to use WEBKIT_DISABLE_COMPOSITING_MODE as a workaround, but that was not expected to be
used by users. So, entering/leaving AC when required by web contents is not actually the solution but a huge
improvement for many people. If we are eventually ready to force AC mode again, we'll change this again. Note
that we still have WEBKIT_DISABLE_COMPOSITING_MODE, but now also WEBKIT_FORCE_COMPOSITING_MODE for testing and debugging.
- UIProcess/gtk/WebPreferencesGtk.cpp:
(WebKit::WebPreferences::platformInitializeStore):
- 12:37 AM WikiStart edited by
- (diff)
- 12:26 AM Changeset in webkit [211276] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed. Fix GTK+ debug build after r211247.
- heap/GCAssertions.h:
- 12:02 AM Changeset in webkit [211275] by
-
- 3 edits in branches/safari-603-branch/Source/WebCore
Merge r211244. rdar://problem/29956321
- 12:02 AM Changeset in webkit [211274] by
-
- 2 edits in branches/safari-603-branch/Source/WebKit/mac
Merge r211243. rdar://problem/30149809
- 12:02 AM Changeset in webkit [211273] by
-
- 2 edits in branches/safari-603-branch/Source/WebCore
Merge r211242. rdar://problem/29957753
- 12:02 AM Changeset in webkit [211272] by
-
- 2 edits in branches/safari-603-branch/Source/WebCore
Merge r211241. rdar://problem/30099051
- 12:02 AM Changeset in webkit [211271] by
-
- 2 edits in branches/safari-603-branch/Source/WebKit2
Merge r211239. rdar://problem/30221723
- 12:02 AM Changeset in webkit [211270] by
-
- 8 edits in branches/safari-603-branch
Merge r211235. rdar://problem/30058933
- 12:02 AM Changeset in webkit [211269] by
-
- 4 edits in branches/safari-603-branch
Merge r211234. rdar://problem/29899862
- 12:02 AM Changeset in webkit [211268] by
-
- 5 edits in branches/safari-603-branch/Source/WebCore
Merge r211233. rdar://problem/30220959
- 12:02 AM Changeset in webkit [211267] by
-
- 2 edits in branches/safari-603-branch/Source/WebCore
Merge r211231. rdar://problem/30217518
- 12:02 AM Changeset in webkit [211266] by
-
- 2 edits in branches/safari-603-branch/Source/WebCore
Merge r211230. rdar://problem/30009849
- 12:02 AM Changeset in webkit [211265] by
-
- 6 edits in branches/safari-603-branch/Source
Merge r211229. rdar://problem/30216981
- 12:02 AM Changeset in webkit [211264] by
-
- 2 edits in branches/safari-603-branch/Source/WebKit2
Merge r211223. rdar://problem/30181179
- 12:01 AM Changeset in webkit [211263] by
-
- 3 edits in branches/safari-603-branch/Source/WebCore
Merge r211220. rdar://problem/29578619
- 12:01 AM Changeset in webkit [211262] by
-
- 4 edits2 adds in branches/safari-603-branch
Merge r211201. rdar://problem/30134866
- 12:01 AM Changeset in webkit [211261] by
-
- 3 edits1 add in branches/safari-603-branch
Merge r211168. rdar://problem/30154148
- 12:01 AM Changeset in webkit [211260] by
-
- 2 edits in branches/safari-603-branch/LayoutTests
Merge r210441. rdar://problem/29899862
- 12:01 AM Changeset in webkit [211259] by
-
- 6 edits in branches/safari-603-branch/Source/WebCore
Merge r211238. rdar://problem/30216742
- 12:01 AM Changeset in webkit [211258] by
-
- 15 edits1 copy2 adds in branches/safari-603-branch
Merge r211224. rdar://problem/29144126
- 12:01 AM Changeset in webkit [211257] by
-
- 2 edits in branches/safari-603-branch/Source/JavaScriptCore
Merge r211167. rdar://problem/30192652
