Timeline

Jan 29, 2017:

9:55 PM Changeset in webkit [211357] by Carlos Garcia Campos

• 4 edits in trunk/Source

[Threaded Compositor] Crash on WebCore::GLContext::version()
​https://bugs.webkit.org/show_bug.cgi?id=167559

Reviewed by Michael Catanzaro.

Source/WebCore:

Fixes crashes in several media tests.

• platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp:

(WebCore::TextureMapperPlatformLayerProxy::invalidate): Clear m_compositorThreadUpdateTimer and call the update function.

Source/WebKit2:

This is happening because TextureMapperPlatformLayerProxy::compositorThreadUpdateTimerFired() is fired after the
threaded compositor is deleted. CoordinatedGraphicsScene::purgeGLResources() should invalidate the proxies
before clearing the map.

• Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::purgeGLResources):

9:03 PM Changeset in webkit [211356] by n_wang@apple.com

• 20 edits
  2 adds in trunk

AX: WKContentView needs to implement UITextInput methods to make speak selection highlighting work
​https://bugs.webkit.org/show_bug.cgi?id=166955

Reviewed by Ryosuke Niwa.

Source/WebCore:

Created a new version of Range::collectSelectionRect() that returns rects for each
line, so that Speak Selection doesn't need to handle searching for soft line breaks.
Also added a variant of findPlainText to search for the closest matched range to the given position.

Test: editing/text-iterator/range-of-string-closest-to-position.html

• dom/Range.cpp:

(WebCore::Range::collectSelectionRectsWithoutUnionInteriorLines):
(WebCore::Range::collectSelectionRects):

• dom/Range.h:
• editing/TextIterator.cpp:

(WebCore::findPlainTextMatches):
(WebCore::updateSearchBuffer):
(WebCore::findIteratorOptions):
(WebCore::rangeMatches):
(WebCore::findClosestPlainText):
(WebCore::findPlainText):
(WebCore::findPlainTextOffset): Deleted.

• editing/TextIterator.h:
• editing/htmlediting.h:
• testing/Internals.cpp:

(WebCore::Internals::rangeOfStringNearLocation):

• testing/Internals.h:
• testing/Internals.idl:

Source/WebKit2:

Implemented methods that Speak Selection can use to retrieve the word/sentence highlighting rects.

• Scripts/webkit/messages.py:

(headers_for_type):

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView webSelectionRectsForSelectionRects:]):
(-[WKContentView webSelectionRects]):
(-[WKContentView _accessibilityRetrieveRectsEnclosingSelectionOffset:withGranularity:]):
(-[WKContentView _accessibilityRetrieveRectsAtSelectionOffset:withText:]):

• UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::selectionRectsCallback):
(WebKit::WebPageProxy::requestRectsForGranularityWithSelectionOffset):
(WebKit::WebPageProxy::requestRectsAtSelectionOffsetWithText):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:
• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::visiblePositionForPositionWithOffset):
(WebKit::WebPage::getRectsForGranularityWithSelectionOffset):
(WebKit::rangeNearPositionMatchesText):
(WebKit::WebPage::getRectsAtSelectionOffsetWithText):

LayoutTests:

• editing/text-iterator/range-of-string-closest-to-position-expected.txt: Added.
• editing/text-iterator/range-of-string-closest-to-position.html: Added.

7:08 PM WebKitGTK/Debugging edited by clopez@igalia.com

(diff)

5:40 PM Changeset in webkit [211355] by aestes@apple.com

• 15 edits in trunk

[QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
​https://bugs.webkit.org/show_bug.cgi?id=167563
<rdar://problem/30253207>

Reviewed by Andreas Kling.

Source/WebCore:

• loader/ios/QuickLook.h: Removed unused declarations.

(WebCore::QuickLookHandle::firstRequestURL): Deleted.

• loader/ios/QuickLook.mm:

(WebCore::removeQLPreviewConverterForURL): Stopped deleting the temporary file here; that's
now done in QuickLookDocumentWriter.
(addQLPreviewConverterWithFileForURL): Changed from an exported function to a static
function since it's now only called inside QuickLook.mm.
(WebCore::QuickLookHandle::QuickLookHandle): Stopped initializing m_firstRequestURL.
(WebCore::addQLPreviewConverterWithFileForURL): Deleted.
(WebCore::qlPreviewConverterFileNameForURL): Deleted.
(WebCore::qlPreviewConverterUTIForURL): Deleted.
(WebCore::QuickLookHandle::previewRequestURL): Deleted.
(WebCore::QuickLookHandle::converter): Deleted.

Source/WebKit/mac:

Instead of only saving QuickLook documents to a temporary file when the client is
MobileSafari, base this decision on a WebPreference that clients can choose to enable.

This also changes the SPI for accessing the temporary file path and UTI. Instead of
-[WebView quickLookContentForURL:], which requires the client to pass the response URL of
the frame that saved the QuickLook document, the content dictionary is now stored as a
property of WebDataSource.

This also removes the manual lifetime management of the QLPreviewConverter from
QuickLookDocumentWriter. The QLPreviewConverter is kept alive by DocumentLoader these days,
which ensures it lives long enough to respond to subresource requests.

New API test: QuickLook.LegacyQuickLookContent

• WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::didCreateQuickLookHandle): Moved the logic of deciding whether to
write a temporary file to here from the QuickLookDocumentWriter constructor.

• WebView/WebDataSource.mm: Declared _quickLookContent.

(-[WebDataSource _quickLookContent]):
(-[WebDataSource _setQuickLookContent:]):

• WebView/WebDataSourceInternal.h: Overrode _quickLookContent as a read/write property.
• WebView/WebDataSourcePrivate.h: Declared _quickLookContent as a readonly property.
• WebView/WebPreferenceKeysPrivate.h: Defined WebKitQuickLookDocumentSavingPreferenceKey.
• WebView/WebPreferences.mm:

(-[WebPreferences quickLookDocumentSavingEnabled]):
(-[WebPreferences setQuickLookDocumentSavingEnabled:]):

• WebView/WebPreferencesPrivate.h: Declared property quickLookDocumentSavingEnabled.
• WebView/WebView.mm:

(-[WebView quickLookContentForURL:]): Changed to always return nil.

• WebView/WebViewPrivate.h: Added a comment stating that clients should use

-[WebDataSource _quickLookContent] instead.

Tools:

• TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:

(-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
(-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
(runTest):
(-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
(TEST):

4:26 PM Changeset in webkit [211354] by mitz@apple.com

• 8 edits
  5 adds in trunk

[iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
​https://bugs.webkit.org/show_bug.cgi?id=167565

Reviewed by Sam Weinig.

Source/WebKit2:

Test: TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm

• Shared/API/Cocoa/WKDataDetectorTypes.h: Added. Moved the enum definition from WKWebViewConfiguration.h to here.
• Shared/API/Cocoa/WKDataDetectorTypesInternal.h: Added.

(fromWKDataDetectorTypes): Moved from WKWebView.mm.

• UIProcess/API/Cocoa/WKWebView.mm:

(fromWKDataDetectorTypes): Moved to WKDataDetectorTypesInternal.h.

• UIProcess/API/Cocoa/WKWebViewConfiguration.h: Moved WKDataDetectorTypes definition out to WKDataDetectorTypes.h.

• WebKit2.xcodeproj/project.pbxproj: Added references to new files.

• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInRangeHandle.h:
• WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInRangeHandle.mm:

(-[WKWebProcessPlugInRangeHandle detectDataWithTypes:context:]): Added. Calls

DataDetection::detectContentInRange.

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.

(-[BundleRangeHandleRemoteObject textFromBodyRange:]):
(-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
(TEST):

• TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.

(-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
(-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):

• TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.

12:21 PM Changeset in webkit [211353] by Alan Bujtas

• 5 edits in trunk/Source/WebCore

Simple line layout: PerformanceTests/Layout/simple-line-layout-innertext.html regressed at r211108
​https://bugs.webkit.org/show_bug.cgi?id=167562

Reviewed by Antti Koivisto.

Apparently RunResolver::Run::constructStringForHyphenIfNeeded() is in a superhot codepath.
The Run should not have any additional members anyway, so let's construct the hyphenated
string on demand.
Progression on simple-line-layout-innertext.html is from ~34runs/sec back to ~50runs/sec.

Covered by existing text.

• rendering/RenderTreeAsText.cpp:

(WebCore::writeSimpleLine):

• rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::paintFlow):

• rendering/SimpleLineLayoutResolver.cpp:

(WebCore::SimpleLineLayout::RunResolver::Run::Run):
(WebCore::SimpleLineLayout::RunResolver::Run::textWithHyphen):
(WebCore::SimpleLineLayout::RunResolver::Run::text):
(WebCore::SimpleLineLayout::RunResolver::Run::constructStringForHyphenIfNeeded): Deleted.

• rendering/SimpleLineLayoutResolver.h:

7:13 AM Changeset in webkit [211352] by yoav@yoav.ws

• 4 edits in trunk/LayoutTests

Add invalid value tests to Link header handling.
​https://bugs.webkit.org/show_bug.cgi?id=167366

Reviewed by Alex Christensen.

• http/tests/preload/download_resources_from_invalid_headers-expected.txt:
• http/tests/preload/resources/download_resources_from_header.php:
• http/tests/preload/resources/invalid_resources_from_header.php:

6:30 AM Changeset in webkit [211351] by Gyuyoung Kim

• 2 edits in trunk/LayoutTests

[EFL] Gardening on 29th Jan.

Unreviewed EFL gardening. Update flaky tests and crash tests.

• platform/efl/TestExpectations:

2:06 AM Changeset in webkit [211350] by Carlos Garcia Campos

• 10 edits in trunk/Source/WebKit2

[Coordinated Graphics] WebPage shouldn't use the layerTreeHost directly
​https://bugs.webkit.org/show_bug.cgi?id=167494

Reviewed by Michael Catanzaro.

In Coordinated Graphics we have a couple of methods that the WebPage uses directly from the layer tree host,
instead of using the drawing area interface. This patch adds DrawingArea::didChangeViewportAttributes and
DrawingArea::deviceOrPageScaleFactorChanged and renames LayerTreeHost::didChangeViewportProperties as
LayerTreeHost::didChangeViewportAttributes for consistency.

• Shared/CoordinatedGraphics/SimpleViewportController.cpp:

(WebKit::SimpleViewportController::didChangeViewportAttributes): Receive an rvalue reference to avoid copies.

• Shared/CoordinatedGraphics/SimpleViewportController.h:
• WebProcess/WebPage/AcceleratedDrawingArea.cpp:

(WebKit::AcceleratedDrawingArea::didChangeViewportAttributes): Forward it to the layer tree host if any.
(WebKit::AcceleratedDrawingArea::deviceOrPageScaleFactorChanged): Ditto.

• WebProcess/WebPage/AcceleratedDrawingArea.h:
• WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:

(WebKit::ThreadedCoordinatedLayerTreeHost::didChangeViewportAttributes): Renamed and updated to pass an rvalue reference.
(WebKit::ThreadedCoordinatedLayerTreeHost::didChangeViewportProperties): Deleted.

• WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:
• WebProcess/WebPage/DrawingArea.h:
• WebProcess/WebPage/LayerTreeHost.h:

(WebKit::LayerTreeHost::didChangeViewportAttributes): Renamed and updated to pass an rvalue reference.
(WebKit::LayerTreeHost::didChangeViewportProperties): Deleted.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::sendViewportAttributesChanged): Use the drawing area.
(WebKit::WebPage::scalePage): Ditto
(WebKit::WebPage::setDeviceScaleFactor): Ditto.
(WebKit::WebPage::viewportPropertiesDidChange): Ditto.

Jan 28, 2017:

11:54 PM WindowsWithoutCygwin edited by mmaxfield@apple.com

(diff)

11:30 PM Changeset in webkit [211349] by ddkilzer@apple.com

• 2 edits
  93 moves
  4 deletes in trunk/LayoutTests

Migrate 97 *-disabled tests to use TestExpectations
<​https://webkit.org/b/167537>

Reviewed by Darin Adler.

• TestExpectations: Skip renamed tests.

• fast/dom/HTMLDataGridElement/DataGridColumns-basic-expected.txt: Removed.
• fast/dom/HTMLDataGridElement/DataGridColumns-basic.html-disabled: Removed.
• fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes-expected.txt: Removed.
• fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html-disabled: Removed.
• fast/dom/HTMLDataGridElement/DataGridColumns-dom-expected.txt: Removed.
• fast/dom/HTMLDataGridElement/DataGridColumns-dom.html-disabled: Removed.
• fast/dom/HTMLDataGridElement/DataGridDataSource-basic-expected.txt: Removed.
• fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html-disabled: Removed.
• Tests disabled in r52512. DataGrid feature removed in r84991.

• http/tests/appcache/dynamic-entries-no-cache-expected.txt: Removed.
• http/tests/appcache/dynamic-entries-no-cache.html-disabled: Removed.
• Test disabled in r39816. AppCache dynamic entry feature removed in r95486.

• svg/W3C-SVG-1.1/resources/filters-comptran-01-f.svg-disabled: Removed.
• Unused. Same as LayoutTests/svg/W3C-SVG-1.1/filters-comptran-01-b.svg.

• animations/font-size-using-ems.html: Renamed from LayoutTests/animations/font-size-using-ems.html-disabled.
• compositing/objects/composited-object-alignment.html: Renamed from LayoutTests/compositing/objects/composited-object-alignment.html-disabled.
• compositing/tiling/huge-layer-resize.html: Renamed from LayoutTests/compositing/tiling/huge-layer-resize.html-disabled.
• compositing/tiling/huge-layer.html: Renamed from LayoutTests/compositing/tiling/huge-layer.html-disabled.
• css2.1/t1202-counter-10-b.html: Renamed from LayoutTests/css2.1/t1202-counter-10-b.html-disabled.
• css2.1/t1202-counters-10-b.html: Renamed from LayoutTests/css2.1/t1202-counters-10-b.html-disabled.
• css2.1/t1204-increment-00-c-o.html: Renamed from LayoutTests/css2.1/t1204-increment-00-c-o.html-disabled.
• css2.1/t1204-increment-01-c-o.html: Renamed from LayoutTests/css2.1/t1204-increment-01-c-o.html-disabled.
• css2.1/t1204-increment-02-c-o.html: Renamed from LayoutTests/css2.1/t1204-increment-02-c-o.html-disabled.
• css2.1/t1204-reset-00-c-o.html: Renamed from LayoutTests/css2.1/t1204-reset-00-c-o.html-disabled.
• css2.1/t1204-reset-01-c-o.html: Renamed from LayoutTests/css2.1/t1204-reset-01-c-o.html-disabled.
• css2.1/t1204-reset-02-c-o.html: Renamed from LayoutTests/css2.1/t1204-reset-02-c-o.html-disabled.
• dom/xhtml/level2/html/HTMLFrameElement09.xhtml: Renamed from LayoutTests/dom/xhtml/level2/html/HTMLFrameElement09.xhtml-disabled.
• dom/xhtml/level3/core/documentadoptnode22.xhtml: Renamed from LayoutTests/dom/xhtml/level3/core/documentadoptnode22.xhtml-disabled.
• dom/xhtml/level3/core/documentnormalizedocument06.xhtml: Renamed from LayoutTests/dom/xhtml/level3/core/documentnormalizedocument06.xhtml-disabled.
• dom/xhtml/level3/core/documentsetdocumenturi01.xhtml: Renamed from LayoutTests/dom/xhtml/level3/core/documentsetdocumenturi01.xhtml-disabled.
• dom/xhtml/level3/core/documentsetdocumenturi02.xhtml: Renamed from LayoutTests/dom/xhtml/level3/core/documentsetdocumenturi02.xhtml-disabled.
• dom/xhtml/level3/core/domimplementationregistry12.xhtml: Renamed from LayoutTests/dom/xhtml/level3/core/domimplementationregistry12.xhtml-disabled.
• dom/xhtml/level3/core/domimplementationregistry23.xhtml: Renamed from LayoutTests/dom/xhtml/level3/core/domimplementationregistry23.xhtml-disabled.
• dom/xhtml/level3/core/nodecomparedocumentposition14.xhtml: Renamed from LayoutTests/dom/xhtml/level3/core/nodecomparedocumentposition14.xhtml-disabled.
• dom/xhtml/level3/core/nodecomparedocumentposition15.xhtml: Renamed from LayoutTests/dom/xhtml/level3/core/nodecomparedocumentposition15.xhtml-disabled.
• dom/xhtml/level3/core/noderemovechild03.xhtml: Renamed from LayoutTests/dom/xhtml/level3/core/noderemovechild03.xhtml-disabled.
• dom/xhtml/level3/core/nodereplacechild06.xhtml: Renamed from LayoutTests/dom/xhtml/level3/core/nodereplacechild06.xhtml-disabled.
• dom/xhtml/level3/core/nodereplacechild07.xhtml: Renamed from LayoutTests/dom/xhtml/level3/core/nodereplacechild07.xhtml-disabled.
• dom/xhtml/level3/core/nodereplacechild08.xhtml: Renamed from LayoutTests/dom/xhtml/level3/core/nodereplacechild08.xhtml-disabled.
• editing/execCommand/create-list-1.html: Renamed from LayoutTests/editing/execCommand/create-list-1.html-disabled.
• editing/input/attributed-substring-from-range-lines.html: Renamed from LayoutTests/editing/input/attributed-substring-from-range-lines.html-disabled.
• editing/pasteboard/paste-empty-startcontainer.html: Renamed from LayoutTests/editing/pasteboard/paste-empty-startcontainer.html-disabled.
• editing/selection/inconsistent-in-removeChildNode.html: Renamed from LayoutTests/editing/selection/inconsistent-in-removeChildNode.html-disabled.
• editing/style/5091898.html: Renamed from LayoutTests/editing/style/5091898.html-disabled.
• fast/css/css2-system-color.html: Renamed from LayoutTests/fast/css/css2-system-color.html-disabled.
• fast/css/font-face-in-shadow-DOM.html: Renamed from LayoutTests/fast/css/font-face-in-shadow-DOM.html-disabled.
• fast/css/limited-vendor-prefix-behavior.html: Renamed from LayoutTests/fast/css/limited-vendor-prefix-behavior.html-disabled.
• fast/dom/Window/timeout-released-on-close.html: Renamed from LayoutTests/fast/dom/Window/timeout-released-on-close.html-disabled.
• fast/dom/Window/window-resize-nan.html: Renamed from LayoutTests/fast/dom/Window/window-resize-nan.html-disabled.
• fast/dom/gc-8.html: Renamed from LayoutTests/fast/dom/gc-8.html-disabled.
• fast/dynamic/crash-paint-no-documentElement-renderer.html: Renamed from LayoutTests/fast/dynamic/crash-paint-no-documentElement-renderer.html-disabled.
• fast/events/destroyed-atomic-string.html: Renamed from LayoutTests/fast/events/destroyed-atomic-string.html-disabled.
• fast/events/key-events-in-frame.html: Renamed from LayoutTests/fast/events/key-events-in-frame.html-disabled.
• fast/frames/iframe-scroll-page-up-down.html: Renamed from LayoutTests/fast/frames/iframe-scroll-page-up-down.html-disabled.
• fast/html/marquee-alternate.html: Renamed from LayoutTests/fast/html/marquee-alternate.html-disabled.
• fast/leaks/003.html: Renamed from LayoutTests/fast/leaks/003.html-disabled.
• fast/loader/api-test-go-to-current-back-forward-item.html: Renamed from LayoutTests/fast/loader/api-test-go-to-current-back-forward-item.html-disabled.
• fast/loader/api-test-new-window-data-load-base-url.html: Renamed from LayoutTests/fast/loader/api-test-new-window-data-load-base-url.html-disabled.
• fast/loader/form-events-back-forward.html: Renamed from LayoutTests/fast/loader/form-events-back-forward.html-disabled.
• fast/notifications/notifications-event-stop-propagation.html: Renamed from LayoutTests/fast/notifications/notifications-event-stop-propagation.html-disabled.
• fast/notifications/notifications-multi-events.html: Renamed from LayoutTests/fast/notifications/notifications-multi-events.html-disabled.
• fast/ruby/after-block-doesnt-crash.html: Renamed from LayoutTests/fast/ruby/after-block-doesnt-crash.html-disabled.
• fast/ruby/after-table-doesnt-crash.html: Renamed from LayoutTests/fast/ruby/after-table-doesnt-crash.html-disabled.
• fast/ruby/generated-after-counter-doesnt-crash.html: Renamed from LayoutTests/fast/ruby/generated-after-counter-doesnt-crash.html-disabled.
• fast/ruby/generated-before-and-after-counter-doesnt-crash.html: Renamed from LayoutTests/fast/ruby/generated-before-and-after-counter-doesnt-crash.html-disabled.
• fast/shadow-dom/copy-shadow-tree.html: Renamed from LayoutTests/fast/shadow-dom/copy-shadow-tree.html-disabled.
• fast/table/double-height-table-no-tbody.html: Renamed from LayoutTests/fast/table/double-height-table-no-tbody.html-disabled.
• fast/text/large-text-composed-char-dos.html: Renamed from LayoutTests/fast/text/large-text-composed-char-dos.html-disabled.
• http/tests/multipart/win-boundary-crash.html: Renamed from LayoutTests/http/tests/multipart/win-boundary-crash.html-disabled.
• http/tests/navigation/post-goback-repost-policy.html: Renamed from LayoutTests/http/tests/navigation/post-goback-repost-policy.html-disabled.
• http/tests/navigation/success200-frames-goback.html: Renamed from LayoutTests/http/tests/navigation/success200-frames-goback.html-disabled.
• http/tests/navigation/success200-frames-reload.html: Renamed from LayoutTests/http/tests/navigation/success200-frames-reload.html-disabled.
• http/tests/navigation/success200-subframeload-goback.html: Renamed from LayoutTests/http/tests/navigation/success200-subframeload-goback.html-disabled.
• java/lc3/ArrayMethods/object-001.html: Renamed from LayoutTests/java/lc3/ArrayMethods/object-001.html-disabled.
• java/lc3/forin/array-001.html: Renamed from LayoutTests/java/lc3/forin/array-001.html-disabled.
• jquery/effects.html: Renamed from LayoutTests/jquery/effects.html-disabled.
• js/garbage-collect-after-string-appends.html: Renamed from LayoutTests/js/garbage-collect-after-string-appends.html-disabled.
• js/kde/Date.html: Renamed from LayoutTests/js/kde/Date.html-disabled.
• js/resources/garbage-collect-after-string-appends.js: Renamed from LayoutTests/js/resources/garbage-collect-after-string-appends.js-disabled.
• js/string-concatenate-outofmemory.html: Renamed from LayoutTests/js/string-concatenate-outofmemory.html-disabled.
• media/video-canvas.html: Renamed from LayoutTests/media/video-canvas.html-disabled.
• platform/mac/plugins/pluginDocumentView-deallocated-dataSource.html: Renamed from LayoutTests/platform/mac/plugins/pluginDocumentView-deallocated-dataSource.html-disabled.
• sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.1_decodeURI/S15.1.3.1_A2.5_T1.html: Renamed from LayoutTests/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.1_decodeURI/S15.1.3.1_A2.5_T1.html-disabled.
• sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.2_decodeURIComponent/S15.1.3.2_A2.5_T1.html: Renamed from LayoutTests/sputnik/Conformance/15_Native_Objects/15.1_The_Global_Object/15.1.3/15.1.3.2_decodeURIComponent/S15.1.3.2_A2.5_T1.html-disabled.
• sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T1.html: Renamed from LayoutTests/sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T1.html-disabled.
• sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T2.html: Renamed from LayoutTests/sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T2.html-disabled.
• sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T3.html: Renamed from LayoutTests/sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T3.html-disabled.
• sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T4.html: Renamed from LayoutTests/sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T4.html-disabled.
• sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T5.html: Renamed from LayoutTests/sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T5.html-disabled.
• sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T6.html: Renamed from LayoutTests/sputnik/Conformance/15_Native_Objects/15.9_Date/15.9.3/S15.9.3.1_A5_T6.html-disabled.
• sputnik/Unicode/Unicode_218/S7.6_A1.1_T5.html: Renamed from LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A1.1_T5.html-disabled.
• sputnik/Unicode/Unicode_218/S7.6_A3.1.html: Renamed from LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A3.1.html-disabled.
• sputnik/Unicode/Unicode_218/S7.6_A3.2.html: Renamed from LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A3.2.html-disabled.
• sputnik/Unicode/Unicode_218/S7.6_A5.2_T5.html: Renamed from LayoutTests/sputnik/Unicode/Unicode_218/S7.6_A5.2_T5.html-disabled.
• sputnik/Unicode/Unicode_320/S7.6_A1.1_T5.html: Renamed from LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A1.1_T5.html-disabled.
• sputnik/Unicode/Unicode_320/S7.6_A5.2_T5.html: Renamed from LayoutTests/sputnik/Unicode/Unicode_320/S7.6_A5.2_T5.html-disabled.
• sputnik/Unicode/Unicode_410/S7.6_A1.1_T5.html: Renamed from LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A1.1_T5.html-disabled.
• sputnik/Unicode/Unicode_410/S7.6_A5.2_T5.html: Renamed from LayoutTests/sputnik/Unicode/Unicode_410/S7.6_A5.2_T5.html-disabled.
• sputnik/Unicode/Unicode_500/S7.6_A1.1_T5.html: Renamed from LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A1.1_T5.html-disabled.
• sputnik/Unicode/Unicode_500/S7.6_A5.2_T5.html: Renamed from LayoutTests/sputnik/Unicode/Unicode_500/S7.6_A5.2_T5.html-disabled.
• sputnik/Unicode/Unicode_510/S7.6_A1.1_T5.html: Renamed from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A1.1_T5.html-disabled.
• sputnik/Unicode/Unicode_510/S7.6_A5.2_T5.html: Renamed from LayoutTests/sputnik/Unicode/Unicode_510/S7.6_A5.2_T5.html-disabled.
• svg/batik/text/textBiDi.svg: Renamed from LayoutTests/svg/batik/text/textBiDi.svg-disabled.
• svg/custom/filter-source-alpha.svg: Renamed from LayoutTests/svg/custom/filter-source-alpha.svg-disabled.
• svg/custom/font-face-fallback.svg: Renamed from LayoutTests/svg/custom/font-face-fallback.svg-disabled.
• svg/custom/js-font-test.svg: Renamed from LayoutTests/svg/custom/js-font-test.svg-disabled.
• svg/zoom/page/zoom-svg-through-object-with-text.xhtml: Renamed from LayoutTests/svg/zoom/page/zoom-svg-through-object-with-text.xhtml-disabled.
• Renamed disabled tests now that they're skipped in TestExpectations.

11:16 PM Changeset in webkit [211348] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit2

[Threaded Compositor] Crash when detaching the CoordinatedGraphicsScene
​https://bugs.webkit.org/show_bug.cgi?id=167547

Reviewed by Michael Catanzaro.

It seems that commitSceneState() can be called after the CoordinatedGraphicsScene has been detached.

• Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::commitSceneState): Return early if scene has been detached.
(WebKit::CoordinatedGraphicsScene::detach): Take the render queue lock before clearing the render queue.

11:15 PM Changeset in webkit [211347] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit2

[Threaded Compositor] Crash when deleting the compositor run loop
​https://bugs.webkit.org/show_bug.cgi?id=167545

Reviewed by Michael Catanzaro.

The problem is that we are releasing the WorkQueue before the update timer that keeps a reference to the run
loop, destroyed by the WorkQueue. So, invalidate the WorkQueue in the next run loop iteration to ensure it
happens after the CompositingRunLoop destructor.

• Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:

(WebKit::CompositingRunLoop::~CompositingRunLoop):

11:14 PM Changeset in webkit [211346] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit2

[GTK] ASSERTION FAILED: !m_layerTreeHost in DrawingAreaImpl::display()
​https://bugs.webkit.org/show_bug.cgi?id=167548

Reviewed by Michael Catanzaro.

The problem is that non accelerated compositing forceRepaint implementation is doing a layout and then calling
display. The layout makes the drawing area enter in AC mode and display asserts that we have a layer tree
host. forceRepaint shouldn't do the layout because display already does that and it correctly handles the case
of entering AC mode during the layout. It shouldn't call setNeedsDisplay either, because that schedules a
display, but we are going to display synchronously.

• WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::forceRepaint):

5:02 PM Changeset in webkit [211345] by Matt Baker

• 15 edits
  1 copy
  2 adds in trunk

Web Inspector: Need some limit on Async Call Stacks for async loops (rAF loops)
​https://bugs.webkit.org/show_bug.cgi?id=165633
<rdar://problem/29738502>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

This patch limits the memory used by the Inspector backend to store async
stack trace data.

Asynchronous stack traces are stored as a disjoint set of parent pointer
trees. Tree nodes represent asynchronous operations, and hold a copy of
the stack trace at the time the operation was scheduled. Each tree can
be regarded as a set of stack traces, stored as singly linked lists that
share part of their structure (specifically their tails). Traces belonging
to the same tree will at least share a common root. A stack trace begins
at a leaf node and follows the chain of parent pointers to the root of
of the tree. Leaf nodes always contain pending asynchronous calls.

When an asynchronous operation is scheduled with requestAnimationFrame,
setInterval, etc, a node is created containing the current call stack and
some bookkeeping data for the operation. An unique identifier comprised
of an operation type and callback identifier is mapped to the node. If
scheduling the callback was itself the result of an asynchronous call,
the node becomes a child of the node associated with that call, otherwise
it becomes the root of a new tree.

A node is either pending, active, dispatched, or canceled. Nodes
start out as pending. After a callback for a pending node is dispatched
the node is marked as such, unless it is a repeating callback such as
setInterval, in which case it remains pending. Once a node is no longer
pending it is removed, as long as it has no children. Since nodes are
reference counted, it is a property of the stack trace tree that nodes
that are no longer pending and have no children pointing to them will be
automatically pruned from the tree.

If an async operation is canceled (e.g. cancelTimeout), the associated
node is marked as such. If the callback is not being dispatched at the
time, and has no children, it is removed.

Because async operations can be chained indefinitely, stack traces are
limited to a maximum depth. The depth of a stack trace is equal to the
sum of the depths of its nodes, with a node's depth equal to the number
of frames in its associated call stack. For any stack trace,

S = { s𝟶, s𝟷, …, s𝑘 }, with endpoints s𝟶, s𝑘
depth(S) = depth(s𝟶) + depth(s𝟷) + … + depth(s𝑘)

A stack trace is truncated when it exceeds the maximum depth. Truncation
occurs on node boundaries, not call frames, consequently the maximum depth
is more of a target than a guarantee:

d = maximum stack trace depth
for all S, depth(S) ≤ d + depth(s𝑘)

Because nodes can belong to multiple stack traces, it may be necessary
to clone the tail of a stack trace being truncated to prevent other traces
from being effected.

• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• inspector/AsyncStackTrace.cpp: Added.

(Inspector::AsyncStackTrace::create):
(Inspector::AsyncStackTrace::AsyncStackTrace):
(Inspector::AsyncStackTrace::~AsyncStackTrace):
(Inspector::AsyncStackTrace::isPending):
(Inspector::AsyncStackTrace::isLocked):
(Inspector::AsyncStackTrace::willDispatchAsyncCall):
(Inspector::AsyncStackTrace::didDispatchAsyncCall):
(Inspector::AsyncStackTrace::didCancelAsyncCall):
(Inspector::AsyncStackTrace::buildInspectorObject):
(Inspector::AsyncStackTrace::truncate):
(Inspector::AsyncStackTrace::remove):

• inspector/AsyncStackTrace.h:
• inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::didScheduleAsyncCall):
(Inspector::InspectorDebuggerAgent::didCancelAsyncCall):
(Inspector::InspectorDebuggerAgent::willDispatchAsyncCall):
(Inspector::InspectorDebuggerAgent::didDispatchAsyncCall):
(Inspector::InspectorDebuggerAgent::didPause):
(Inspector::InspectorDebuggerAgent::clearAsyncStackTraceData):
(Inspector::InspectorDebuggerAgent::buildAsyncStackTrace): Deleted.
(Inspector::InspectorDebuggerAgent::refAsyncCallData): Deleted.
(Inspector::InspectorDebuggerAgent::derefAsyncCallData): Deleted.

• inspector/agents/InspectorDebuggerAgent.h:
• inspector/protocol/Console.json:

Source/WebInspectorUI:

• Localizations/en.lproj/localizedStrings.js:

Text for "Truncated" marker tree element.

• UserInterface/Models/StackTrace.js:

(WebInspector.StackTrace):
(WebInspector.StackTrace.fromPayload):
(WebInspector.StackTrace.prototype.get truncated):
Plumbing for new Console.StackTrace property truncated.

• UserInterface/Views/ThreadTreeElement.css:

(.tree-outline > .item.thread + ol > .item.truncated-call-frames):
(.tree-outline > .item.thread + ol > .item.truncated-call-frames .icon):
Styles for "Truncated" marker tree element.

• UserInterface/Views/ThreadTreeElement.js:

(WebInspector.ThreadTreeElement.prototype.refresh):
Append "Truncated" marker tree element if necessary.

• Versions/Inspector-iOS-10.3.json:

LayoutTests:

Add truncation test cases and cleanup call frame logging.

• inspector/debugger/async-stack-trace-expected.txt:
• inspector/debugger/async-stack-trace.html:
• inspector/debugger/resources/log-active-stack-trace.js: Added.

(TestPage.registerInitializer.window.getActiveStackTrace):
(TestPage.registerInitializer.logStackTrace.logCallFrame):
(TestPage.registerInitializer.):
(TestPage.registerInitializer.window.logActiveStackTrace):
(TestPage.registerInitializer):

4:39 PM Changeset in webkit [211344] by commit-queue@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

Remote Inspector: Listing should be updated when a target gains or loses a debugger session
​https://bugs.webkit.org/show_bug.cgi?id=167449

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-01-28
Reviewed by Brian Burg.

• inspector/remote/RemoteInspector.h:
• inspector/remote/RemoteInspector.mm:

(Inspector::RemoteInspector::setupFailed):
(Inspector::RemoteInspector::updateTargetListing):
(Inspector::RemoteInspector::receivedSetupMessage):
(Inspector::RemoteInspector::receivedDidCloseMessage):
(Inspector::RemoteInspector::receivedConnectionDiedMessage):
Whenever we add/remove a connection we should update the listing properties
for that target that corresponded to that connection. In this way group
updating active sessions, the target, and pushing listing together.

4:16 PM Changeset in webkit [211343] by timothy_horton@apple.com

• 4 edits in trunk/Source

Don't flash a tap highlight for the entirety of an editable WKWebView
​https://bugs.webkit.org/show_bug.cgi?id=167486
<rdar://problem/30193996>

Reviewed by Dan Bernstein.

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::sendTapHighlightForNodeIfNecessary):
Bail from providing a tap highlight if we are about to highlight
the entire body of an editable web view.

• dom/Document.h:

Export.

3:13 PM Changeset in webkit [211342] by Wenson Hsieh

• 12 edits in trunk/Source

Check USE(APPLE_INTERNAL_SDK) instead of specific headers when importing from WebKitAdditions
​https://bugs.webkit.org/show_bug.cgi?id=167555

Reviewed by Dan Bernstein.

Instead of guarding #import <WebKitAdditions/*> on the existence of the imported file, consult
USE(APPLE_INTERNAL_SDK) instead.

Source/WebCore:

• page/ios/EventHandlerIOS.mm:
• platform/ios/DragImageIOS.mm:
• platform/ios/PasteboardIOS.mm:
• platform/mac/DragDataMac.mm:

Source/WebKit2:

• UIProcess/Cocoa/WebPageProxyCocoa.mm:
• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:
• WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

Source/WTF:

• wtf/Platform.h:

2:53 PM Changeset in webkit [211341] by yoav@yoav.ws

• 46 edits in trunk

Add Link Preload as an off-by-default experimental feature menu item.
​https://bugs.webkit.org/show_bug.cgi?id=167201

Reviewed by Ryosuke Niwa.

Source/WebCore:

Removed the explicit setting of the Link Preload experimental feature,
as it is now on by default for testing.

No new tests as this just removes methods from settings.

• testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):

• testing/InternalSettings.h:
• testing/InternalSettings.idl:

Source/WebKit/mac:

• WebView/WebPreferenceKeysPrivate.h:
• WebView/WebPreferences.mm:

(-[WebPreferences linkPreloadEnabled]):
(-[WebPreferences setLinkPreloadEnabled:]):

• WebView/WebPreferencesPrivate.h:
• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit/win:

• WebPreferenceKeysPrivate.h:
• WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::valueForKey):
(WebPreferences::setLinkPreloadEnabled):
(WebPreferences::linkPreloadEnabled):

• WebPreferences.h:
• Interfaces/IWebPreferencesPrivate.idl:

Source/WebKit2:

• Shared/WebPreferencesDefinitions.h:
• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetLinkPreloadEnabled):
(WKPreferencesGetLinkPreloadEnabled):

• UIProcess/API/C/WKPreferencesRefPrivate.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

• DumpRenderTree/mac/DumpRenderTree.mm:

(resetWebPreferencesToConsistentValues):

• DumpRenderTree/win/DumpRenderTree.cpp:

(resetWebPreferencesToConsistentValues):

Websites/webkit.org:

• experimental-features.html: Added Link Preload.

LayoutTests:

Removed code explicitly enabling Link preload from the tests, as it is now
turned on by default for testing. Corrected expectation files accordingly.

• http/tests/fetch/redirectmode-and-preload.html:
• http/tests/preload/delaying_onload_link_preload_after_discovery.html:
• http/tests/preload/delaying_onload_link_preload_after_discovery_image.html:
• http/tests/preload/download_resources-expected.txt:
• http/tests/preload/download_resources.html:
• http/tests/preload/download_resources_from_header_iframe.html:
• http/tests/preload/download_resources_from_invalid_headers.html:
• http/tests/preload/dynamic_adding_preload.html:
• http/tests/preload/dynamic_remove_preload_href-expected.txt:
• http/tests/preload/dynamic_remove_preload_href.html:
• http/tests/preload/not_delaying_window_onload_before_discovery.html:
• http/tests/preload/onerror_event-expected.txt:
• http/tests/preload/onerror_event.html:
• http/tests/preload/onload_event-expected.txt:
• http/tests/preload/onload_event.html:
• http/tests/preload/resources/download_resources_from_header.php:
• http/tests/preload/resources/invalid_resources_from_header.php:
• http/tests/preload/single_download_preload-expected.txt:
• http/tests/preload/single_download_preload.html:
• http/tests/security/cached-cross-origin-preloaded-css-stylesheet.html:
• http/tests/security/cached-cross-origin-preloading-css-stylesheet.html:

2:35 PM Changeset in webkit [211340] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Fix typo in error message
​https://bugs.webkit.org/show_bug.cgi?id=167554

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-01-28
Reviewed by Sam Weinig.

• bindings/scripts/CodeGenerator.pm:

(GetEnumByType):

10:16 AM Changeset in webkit [211339] by commit-queue@webkit.org

• 4 edits
  2 adds in trunk

[Modern Media Controls] REGRESSION: Video stops playing after going into Full Screen in media documents
​https://bugs.webkit.org/show_bug.cgi?id=167552
<rdar://problem/29601646>

Patch by Antoine Quint <Antoine Quint> on 2017-01-28
Reviewed by Eric Carlson.

Source/WebCore:

In the case of media documents, there is a built-in behavior, implemented in MediaDocument::defaultEventHandler(),
that toggles playback when clicking or double-clicking the video. We disable this behavior by adding a "click" event
handler on the entire media shadow root and calling "preventDefault()".

Test: media/modern-media-controls/media-documents/click-on-video-should-not-pause.html

• Modules/modern-media-controls/media/media-controller.js:

(MediaController):
(MediaController.prototype.handleEvent):
(MediaController.prototype._containerWasClicked):

LayoutTests:

Add a new test that checks that clicking on a <video> within a media document does not paused after being clicked.
Since this behavior uses click events, we use window.eventSender and skip this test on iOS.

• media/modern-media-controls/media-documents/click-on-video-should-not-pause-expected.txt: Added.
• media/modern-media-controls/media-documents/click-on-video-should-not-pause.html: Added.
• platform/ios-simulator/TestExpectations:

10:05 AM Changeset in webkit [211338] by mitz@apple.com

• 7 edits
  1 add in trunk/Source/WebCore

[Xcode] Clean up PAL and WebCore’s build settings a little
​https://bugs.webkit.org/show_bug.cgi?id=167292

Reviewed by Sam Weinig.

Source/WebCore:

• Configurations/Base.xcconfig: Simplified the definition of GCC_WARN_64_TO_32_BIT_CONVERSION, removed the unused build setting PREBINDING, removed a duplicate definition of GCC_GENERATE_DEBUGGING_SYMBOLS, and removed definitions specific to OS X versions that are no longer supported.

• Configurations/DebugRelease.xcconfig: Removed definitions specific to OS X versions that are no longer supported.

Source/WebCore/PAL:

• ChangeLog: Created this file.

• Configurations/Base.xcconfig: Simplified the definition of GCC_WARN_64_TO_32_BIT_CONVERSION, removed the unused build setting PREBINDING, removed a duplicate definition of GCC_GENERATE_DEBUGGING_SYMBOLS, and removed definitions specific to OS X versions that are no longer supported.

• Configurations/DebugRelease.xcconfig: Removed definitions specific to OS X versions that are no longer supported.

• Configurations/PAL.xcconfig: Removed header search paths that do not exist or do not make sense. Simplified the definitions of INSTALL_PATH and SKIP_INSTALL. Removed the unusued build settings PRODUCT_BUNDLE_IDENTIFIER and WK_PREFIXED_IPHONEOS_DEPLOYMENT_TARGET. Removed the redundant definition of EXECUTABLE_PREFIX.

• PAL.xcodeproj/project.pbxproj: Sorted the Configurations group.

8:26 AM Changeset in webkit [211337] by Alan Bujtas

• 5 edits
  2 adds in trunk

Resolve beforeChild's render tree position before calling addChildIgnoringContinuation.
​https://bugs.webkit.org/show_bug.cgi?id=167540
<rdar://problem/30126535>

Reviewed by Simon Fraser.

Source/WebCore:

Use the actual render tree position for the beforeChild when inside a flow thread.

Test: fast/multicol/assert-on-continuation-with-spanner.html

• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::addChild):

• rendering/RenderInline.cpp:

(WebCore::RenderInline::addChild):

• rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::resolveMovedChild):

LayoutTests:

• fast/multicol/assert-on-continuation-with-spanner-expected.txt: Added.
• fast/multicol/assert-on-continuation-with-spanner.html: Added.

7:19 AM Changeset in webkit [211336] by akling@apple.com

• 2 edits in trunk/Source/WebCore

Avoid synchronous style recalc in dispatchUnloadEvents().
<​https://webkit.org/b/167551>

Reviewed by Antti Koivisto.

It shouldn't be necessary to force a synchronous style resolution in an unloading document.
This call has been here since the import of KHTMLPart.

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::dispatchUnloadEvents):

4:16 AM Changeset in webkit [211335] by akling@apple.com

• 2 edits in trunk/Source/WebCore

REGRESSION(r196383): Automatic shrink-to-fit of RuleSet no longer works.
<​https://webkit.org/b/167543>

Reviewed by Antti Koivisto.

Re-enable the automatic shrink-to-fit optimization in RuleSet.
This was disabled accidentally, which I discovered while investigating
the memory footprint of extension stylesheets.

• css/RuleSet.h:

4:04 AM Changeset in webkit [211334] by Antti Koivisto

• 2 edits in trunk/Source/WebCore

Give scripts 'high' load priority
​https://bugs.webkit.org/show_bug.cgi?id=167550

Reviewed by Andreas Kling.

For historical reasons it is currently 'medium', same as web fonts and some other non-parsing blocking things.

• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::defaultPriorityForResourceType):

1:26 AM Changeset in webkit [211333] by Joseph Pecoraro

• 2 edits
  34 adds in trunk/LayoutTests/imported/w3c

Import web-platform-tests/user-timing
​https://bugs.webkit.org/show_bug.cgi?id=167542
<rdar://problem/22746307>

Rubber-stamped by Ryosuke Niwa.

Only failures are ones where User Timing Level 2 differs
from User Timing Level 1.

• resources/ImportExpectations:
• web-platform-tests/user-timing/OWNERS: Added.
• web-platform-tests/user-timing/idlharness-expected.txt: Added.
• web-platform-tests/user-timing/idlharness.html: Added.
• web-platform-tests/user-timing/resources/w3c-import.log: Added.
• web-platform-tests/user-timing/resources/webperftestharness.js: Added.
• web-platform-tests/user-timing/resources/webperftestharnessextension.js: Added.
• web-platform-tests/user-timing/test_user_timing_clear_marks-expected.txt: Added.
• web-platform-tests/user-timing/test_user_timing_clear_marks.html: Added.
• web-platform-tests/user-timing/test_user_timing_clear_measures-expected.txt: Added.
• web-platform-tests/user-timing/test_user_timing_clear_measures.html: Added.
• web-platform-tests/user-timing/test_user_timing_entry_type-expected.txt: Added.
• web-platform-tests/user-timing/test_user_timing_entry_type.html: Added.
• web-platform-tests/user-timing/test_user_timing_exists-expected.txt: Added.
• web-platform-tests/user-timing/test_user_timing_exists.html: Added.
• web-platform-tests/user-timing/test_user_timing_mark-expected.txt: Added.
• web-platform-tests/user-timing/test_user_timing_mark.html: Added.
• web-platform-tests/user-timing/test_user_timing_mark_and_measure_exception_when_invoke_with_timing_attributes-expected.txt: Added.
• web-platform-tests/user-timing/test_user_timing_mark_and_measure_exception_when_invoke_with_timing_attributes.html: Added.
• web-platform-tests/user-timing/test_user_timing_mark_and_measure_exception_when_invoke_with_timing_attributes.js: Added.
• web-platform-tests/user-timing/test_user_timing_mark_and_measure_exception_when_invoke_without_parameter-expected.txt: Added.
• web-platform-tests/user-timing/test_user_timing_mark_and_measure_exception_when_invoke_without_parameter.html: Added.
• web-platform-tests/user-timing/test_user_timing_mark_exceptions-expected.txt: Added.
• web-platform-tests/user-timing/test_user_timing_mark_exceptions.html: Added.
• web-platform-tests/user-timing/test_user_timing_mark_with_name_of_navigation_timing_optional_attribute-expected.txt: Added.
• web-platform-tests/user-timing/test_user_timing_mark_with_name_of_navigation_timing_optional_attribute.html: Added.
• web-platform-tests/user-timing/test_user_timing_measure-expected.txt: Added.
• web-platform-tests/user-timing/test_user_timing_measure.html: Added.
• web-platform-tests/user-timing/test_user_timing_measure_exceptions-expected.txt: Added.
• web-platform-tests/user-timing/test_user_timing_measure_exceptions.html: Added.
• web-platform-tests/user-timing/test_user_timing_measure_navigation_timing-expected.txt: Added.
• web-platform-tests/user-timing/test_user_timing_measure_navigation_timing.html: Added.
• web-platform-tests/user-timing/w3c-import.log: Added.

1:26 AM Changeset in webkit [211332] by Joseph Pecoraro

• 36 edits in trunk

Add User Timing Experimental Feature
​https://bugs.webkit.org/show_bug.cgi?id=167542
<rdar://problem/22746307>

Reviewed by Ryosuke Niwa.

Source/WebCore:

• page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::performanceTimelineEnabled):

• page/Performance.idl:
• page/PerformanceEntry.idl:

Make a better RuntimeEnabledFeature named "PerformanceTiming" which
is enabled if either UserTiming or ResourceTiming is enabled. This
will then expose the APIs that are only useful when at least one of
the APIs are available.

• page/PerformanceEntry.cpp:

(WebCore::PerformanceEntry::name): Deleted.
(WebCore::PerformanceEntry::entryType): Deleted.
(WebCore::PerformanceEntry::startTime): Deleted.
(WebCore::PerformanceEntry::duration): Deleted.

• page/PerformanceEntry.h:

(WebCore::PerformanceEntry::name):
(WebCore::PerformanceEntry::entryType):
(WebCore::PerformanceEntry::startTime):
(WebCore::PerformanceEntry::duration):
Inline simple accessors.

• page/PerformanceUserTiming.cpp:

(WebCore::UserTiming::measure):
Fix a bug introduced by ExceptionOr refactoring.

(WebCore::UserTiming::clearMarks):
(WebCore::UserTiming::clearMeasures):
(WebCore::clearPerformanceEntries):
(WebCore::clearPeformanceEntries): Deleted.
Fix method name typo.

Source/WebKit/mac:

• WebView/WebPreferenceKeysPrivate.h:
• WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences userTimingEnabled]):
(-[WebPreferences setUserTimingEnabled:]):

• WebView/WebPreferencesPrivate.h:
• WebView/WebView.mm:

(-[WebView _preferencesChanged:]):
Add setting for User Timing runtime enabled feature.

Source/WebKit/win:

• Interfaces/IWebPreferencesPrivate.idl:
• WebPreferenceKeysPrivate.h:
• WebPreferences.cpp:

(WebPreferences::initializeDefaultSettings):
(WebPreferences::setUserTimingEnabled):
(WebPreferences::userTimingEnabled):

• WebPreferences.h:
• WebView.cpp:

(WebView::notifyPreferencesChanged):
Add setting for User Timing runtime enabled feature.

Source/WebKit2:

• Shared/WebPreferencesDefinitions.h:
• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetUserTimingEnabled):
(WKPreferencesGetUserTimingEnabled):

• UIProcess/API/C/WKPreferencesRefPrivate.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Experimental feature. Off for now while we update ResourceTiming
and NavigationTiming to be compatible with Performance Timing 2.

Tools:

• DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures):
(resetWebPreferencesToConsistentValues):

• DumpRenderTree/win/DumpRenderTree.cpp:

(enableExperimentalFeatures):

Websites/webkit.org:

• experimental-features.html:

LayoutTests:

• platform/efl/js/dom/global-constructors-attributes-expected.txt:
• platform/gtk/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
• platform/mac/js/dom/global-constructors-attributes-expected.txt:
• platform/win/js/dom/global-constructors-attributes-expected.txt:

Update results now that experimental User Timing feature is enabled in tests.

1:25 AM Changeset in webkit [211331] by Joseph Pecoraro

• 4 edits in trunk

Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
​https://bugs.webkit.org/show_bug.cgi?id=167519

Reviewed by Ryosuke Niwa.

Tools:

• QueueStatusServer/templates/statusbubble.html:

To measure the bubbleContainer's width, it must not be wrapping based
on its parent container. So when measuring the width temporarily set
the parent to a very large width so as to not artificially wrap us.
Restore the parent's width after measuring.

Websites/bugs.webkit.org:

While we do post message to determine the size, the fact that we have
constrained the iframe to a size of 450px meant its body is 450px and
the div containing the bubbles wraps at 450px. Its full size (~458px)
is not returned. Although we solve this artifical constraint problem
inside of the bubble containerMetrics measuring, up this default value
from 450 to 460 to reduce UI jitter (the current measurement on my
machine is 458px).

• PrettyPatch/PrettyPatch.rb:

12:19 AM Changeset in webkit [211330] by bshafiei@apple.com

• 3 edits in tags/Safari-604.1.5.0.1/Source/WebKit2

Merged r211329. rdar://problem/30247736

12:02 AM Changeset in webkit [211329] by mitz@apple.com

• 3 edits in trunk/Source/WebKit2

<rdar://problem/30247736> WebKit2-7604.1.5 has failed to build: error: only virtual member functions can be marked 'override'

• UIProcess/ios/PageClientImplIOS.h: Guard the declaration of requestPasswordForQuickLookDocument with USE(QUICK_LOOK) to match the base class.
• UIProcess/ios/PageClientImplIOS.mm: Guard the implementation as well.