Timeline
Feb 2, 2017:
- 11:25 PM Changeset in webkit [211622] by
-
- 19 edits2 copies in trunk/Source
[Mac] In-process memory pressure monitor for WebContent processes AKA websam
<https://webkit.org/b/167491>
<rdar://problem/30116072>
Reviewed by Antti Koivisto.
Source/JavaScriptCore:
Remove the sloppy "max live heap size" mechanism from JSC in favor of the new
WebCore-side memory footprint monitor.
- heap/Heap.cpp:
(JSC::Heap::updateAllocationLimits):
(JSC::Heap::didExceedMaxLiveSize): Deleted.
- heap/Heap.h:
(JSC::Heap::setMaxLiveSize): Deleted.
Source/WebCore:
Add a new timer-based memory pressure monitor that checks the process memory
footprint every 30 seconds and reacts to changes by setting a MemoryUsagePolicy.
There are four MemoryUsagePolicy values:
- Unrestricted (below 1GB)
- Conservative (above 1GB)
- Strict (above 2GB)
- Panic (above 4GB, or 3GB if 32-bit)
For Strict and above, the old-style "isUnderMemoryPressure()" API will return true.
Transitioning to a higher policy will cause memory pressure handlers to run:
At Strict, we run the "non-critical" memory pressure handler, then carry on.
At Panic, we run the "critical" memory pressure handler. If that fails to recover
enough memory to bring us back below 4GB, we may kill the process:
A process is eligible to get killed for using too much memory if:
- It's not visible on screen (i.e it's a background tab.)
- It's not playing audio.
- It has not performed a main frame navigation in the last hour.
Before killing the process, an exit-time callback will run. This patch installs such
a callback that prints out some time-of-death statistics about C++ and JavaScript memory
usage to hopefully help understand what was soaking up all the memory.
- bindings/js/CommonVM.cpp:
(WebCore::commonVMSlow):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::setState):
- page/MainFrame.cpp:
(WebCore::MainFrame::didCompleteLoad):
- page/MainFrame.h:
- page/MemoryRelease.cpp:
(WebCore::pageCount):
(WebCore::logMemoryStatisticsAtTimeOfDeath):
(WebCore::didExceedMemoryLimitAndFailedToRecover):
(WebCore::processIsEligibleForMemoryKill):
- page/MemoryRelease.h:
- page/ResourceUsageThread.h:
- page/cocoa/ResourceUsageThreadCocoa.mm:
(WebCore::vmPageSize):
- platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::MemoryPressureHandler):
(WebCore::MemoryPressureHandler::setShouldUsePeriodicMemoryMonitor):
(WebCore::toString):
(WebCore::thresholdForPolicy):
(WebCore::policyForFootprint):
(WebCore::MemoryPressureHandler::measurementTimerFired):
- platform/MemoryPressureHandler.h:
(WebCore::MemoryPressureHandler::setMemoryKillCallback):
(WebCore::MemoryPressureHandler::setProcessIsEligibleForMemoryKillCallback):
(WebCore::MemoryPressureHandler::isUnderMemoryPressure):
Source/WebKit2:
Enable the in-process memory monitor for WebContent processes on macOS 10.12+
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
Source/WTF:
Add a WTF helper function for getting the current process's memory footprint.
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/MemoryFootprint.cpp:
(WTF::memoryFootprint):
- wtf/MemoryFootprint.h:
- 10:30 PM Changeset in webkit [211621] by
-
- 5 edits in trunk
URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
https://bugs.webkit.org/show_bug.cgi?id=167773
<rdar://problem/30221102>
Reviewed by Ryosuke Niwa.
Source/WebCore:
If an invalid IPv4 address contains the first syntaxViolation (difference between input and canonicalized URL),
an iterator is used to calculate how far we have parsed in the input string to copy all the syntax-violation-free
characters into a Vector. If a URL contains only ASCII that doesn't contain anything percent-encoded in the host,
there is a fast path to parse ASCII hosts. All my existing invalid IPv4 tests followed this path.
If there is a non-ASCII character, we need to use an iterator to the original string instead of an iterator
to the string after converting the input string's host to ASCII.
Covered by a new API test which used to RELEASE_ASSERT.
- platform/URLParser.cpp:
(WebCore::URLParser::parseIPv4Host):
(WebCore::URLParser::parseIPv6Host):
(WebCore::URLParser::parseHostAndPort):
- platform/URLParser.h:
Tools:
- TestWebKitAPI/Tests/WebCore/URLParser.cpp:
(TestWebKitAPI::TEST_F):
- 10:25 PM WebKitGTK/2.14.x edited by
- (diff)
- 10:20 PM Changeset in webkit [211620] by
-
- 18 edits2 adds in trunk/LayoutTests/imported/w3c
Update URL web platform tests
https://bugs.webkit.org/show_bug.cgi?id=167777
Reviewed by Ryosuke Niwa.
- web-platform-tests/url/a-element-expected.txt:
- web-platform-tests/url/a-element-origin-expected.txt:
- web-platform-tests/url/a-element-origin-xhtml-expected.txt:
- web-platform-tests/url/a-element-origin-xhtml.xhtml:
- web-platform-tests/url/a-element-origin.html:
- web-platform-tests/url/a-element-xhtml-expected.txt:
- web-platform-tests/url/a-element-xhtml.xhtml:
- web-platform-tests/url/a-element.html:
- web-platform-tests/url/setters_tests.json:
- web-platform-tests/url/url-constructor-expected.txt:
- web-platform-tests/url/url-origin-expected.txt:
- web-platform-tests/url/url-setters-expected.txt:
- web-platform-tests/url/urlencoded-parser-expected.txt: Added.
- web-platform-tests/url/urlencoded-parser.html: Added.
- web-platform-tests/url/urlsearchparams-constructor-expected.txt:
- web-platform-tests/url/urlsearchparams-constructor.html:
- web-platform-tests/url/urlsearchparams-sort-expected.txt:
- web-platform-tests/url/urlsearchparams-sort.html:
- web-platform-tests/url/urltestdata.json:
- 8:50 PM Changeset in webkit [211619] by
-
- 6 edits in tags/Safari-604.1.5.3.1/Source
Versioning.
- 8:46 PM Changeset in webkit [211618] by
-
- 1 copy in tags/Safari-604.1.5.3.1
New tag.
- 5:54 PM Changeset in webkit [211617] by
-
- 5 edits in branches/safari-603-branch/Source
Versioning.
- 5:46 PM Changeset in webkit [211616] by
-
- 16 edits2 moves2 adds2 deletes in trunk/LayoutTests
Multiple HTTP tests fail with Apache 2.4.25
https://bugs.webkit.org/show_bug.cgi?id=167678
<rdar://problem/30060142>
Reviewed by Sam Weinig.
Newer versions of Apache have a security fix where they generate an internal server
error upon seeing an invalid HTTP header field. There is an opt-out configuration
option which didn't quite work in my testing, but regardless, we should only use
"nph-" CGIs for invalid responses. This is how Apache knows that it shouldn't
attempt to parse the response.
This also uncovered a test bug.
- http/tests/cache/disk-cache/resources/cache-test.js: (generateTestURL):
Without escaping, we were getting a broken response in attachment tests:
Content-Disposition: attachment
filename: "f.txt"
Note how ";" turned into a newline.
- http/tests/misc/non-utf8-header-name-expected.txt: Removed.
- http/tests/misc/non-utf8-header-name.php: Removed.
- http/tests/misc/nph-non-utf8-header-name-expected.txt: Copied from LayoutTests/http/tests/misc/non-utf8-header-name-expected.txt.
- http/tests/misc/nph-non-utf8-header-name.pl: Copied from LayoutTests/http/tests/misc/non-utf8-header-name.php.
- http/tests/preload/download_resources_from_invalid_headers.html:
- http/tests/preload/resources/invalid_resources_from_header.php: Removed.
- http/tests/preload/resources/nph-invalid_resources_from_header.pl: Copied from LayoutTests/http/tests/preload/resources/invalid_resources_from_header.php.
- http/tests/security/contentSecurityPolicy/directive-parsing-01.html:
- http/tests/security/contentSecurityPolicy/directive-parsing-02.html:
- http/tests/security/contentSecurityPolicy/directive-parsing-03.html:
- http/tests/security/contentSecurityPolicy/directive-parsing-04.html:
- http/tests/security/contentSecurityPolicy/directive-parsing-05.html:
- http/tests/security/contentSecurityPolicy/resources/echo-script-src.pl: Removed.
- http/tests/security/contentSecurityPolicy/resources/multiple-iframe-test.js:
- http/tests/security/contentSecurityPolicy/resources/nph-echo-script-src.pl: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/resources/echo-script-src.pl.
- http/tests/security/contentSecurityPolicy/script-loads-with-img-src.html:
- http/tests/security/contentSecurityPolicy/script-src-none.html:
- http/tests/security/contentSecurityPolicy/script-src-self-blocked-01.html:
- http/tests/security/contentSecurityPolicy/script-src-self-blocked-02.html:
- http/tests/security/contentSecurityPolicy/script-src-self-blocked-03.html:
- http/tests/security/contentSecurityPolicy/script-src-self.html:
- http/tests/security/contentSecurityPolicy/script-src-star-cross-scheme.html:
Changed scripts that are used to generate invalid responses to "nph-" ones.
- 5:36 PM Changeset in webkit [211615] by
-
- 6 edits in branches/safari-604.1.5-branch/Source
Versioning.
- 5:15 PM Changeset in webkit [211614] by
-
- 1 copy in tags/Safari-604.1.5.3
Tag Safari-604.1.5.3.
- 5:01 PM Changeset in webkit [211613] by
-
- 2 edits in trunk/Source/WebCore
CrashTracer: [USER] com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::URL::host const + 9
https://bugs.webkit.org/show_bug.cgi?id=167766
<rdar://problem/30132707>
Reviewed by Chris Dumez.
The mainframe's document pointer may be null when tearing down a page upon navigation to a page that is in the
page cache. If this triggers a GC sweep, we will attempt to reload touch bar media controls, which (as a part of
the media controller heuristic) checks the mainframe's document URL to see if quirks should be enabled. This
assumes that the mainframe's document exists, which is not a safe assumption if page navigation is occurring. As
such, we need a null check for the mainframe's document in needsPlaybackControlsManagerQuirk().
No test, as we were unable to reproduce this crash.
- html/HTMLMediaElement.cpp:
(WebCore::needsPlaybackControlsManagerQuirk):
- 5:00 PM Changeset in webkit [211612] by
-
- 9 edits2 adds in trunk
Suspend SVG animations in hidden pages
https://bugs.webkit.org/show_bug.cgi?id=167763
<rdar://problem/29986313>
Reviewed by Simon Fraser.
Source/WebCore:
Suspend SVG animations in hidden pages to save power, similarly to what
we already do for another types of animations.
Test: svg/animations/animations-paused-page-non-visible.html
- page/Page.cpp:
(WebCore::setSVGAnimationSuspended):
(WebCore::Page::setIsVisibleInternal):
- svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::pauseAnimations):
(WebCore::SVGDocumentExtensions::unpauseAnimations):
- svg/SVGDocumentExtensions.h:
(WebCore::SVGDocumentExtensions::areAnimationsPaused):
- testing/Internals.cpp:
(WebCore::Internals::areSVGAnimationsPaused):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
Add layout test coverage.
- svg/animations/animations-paused-page-non-visible-expected.txt: Added.
- svg/animations/animations-paused-page-non-visible.html: Added.
- 4:53 PM Changeset in webkit [211611] by
-
- 1 copy in tags/Safari-603.1.24
Tag Safari-603.1.24.
- 4:35 PM Changeset in webkit [211610] by
-
- 2 edits4 deletes in trunk/Source/WebCore
Unreviewed, rolling out r211596 and r211605.
https://bugs.webkit.org/show_bug.cgi?id=167767
This change broke certain build configurations (Requested by
ryanhaddad on #webkit).
Reverted changesets:
"[Mac] Add classes to manage audio samples"
https://bugs.webkit.org/show_bug.cgi?id=167739
http://trac.webkit.org/changeset/211596
"Unreviewed speculative build fix."
http://trac.webkit.org/changeset/211605
Patch by Commit Queue <commit-queue@webkit.org> on 2017-02-02
- 4:26 PM Changeset in webkit [211609] by
-
- 2 edits in trunk/Source/JavaScriptCore
Add a SIGILL crash analyzer to make debugging SIGILLs easier.
https://bugs.webkit.org/show_bug.cgi?id=167714
<rdar://problem/30318237>
Not reviewed.
Build fix for CLOOP build.
- tools/VMInspector.cpp:
- 4:22 PM Changeset in webkit [211608] by
-
- 7 edits in trunk/Source/WebInspectorUI
Web Inspector: can't jump from Search Tab result to see resource in other tabs (Resource, Debugger, Network)
https://bugs.webkit.org/show_bug.cgi?id=167072
Patch by Devin Rousso <Devin Rousso> on 2017-02-02
Reviewed by Timothy Hatcher.
- UserInterface/Base/Main.js:
(WebInspector.tabContentViewForRepresentedObject):
(WebInspector.showRepresentedObject):
(WebInspector.showMainFrameDOMTree):
(WebInspector.showSourceCodeForFrame):
(WebInspector.showSourceCode):
(WebInspector.showSourceCodeLocation):
(WebInspector.showOriginalUnformattedSourceCodeLocation):
(WebInspector.showOriginalOrFormattedSourceCodeLocation):
(WebInspector.showOriginalOrFormattedSourceCodeTextRange):
(WebInspector.showResourceRequest):
Rework parameters to add optionaloptionsdictionary that can be used to indicate
additional functionality.
- UserInterface/Views/TabBrowser.js:
(WebInspector.TabBrowser.prototype.bestTabContentViewForRepresentedObject):
Ignore instances of SearchTabContentView as it can display content views for all types of
searchable data. Determined by a newly added optionaloptionsparameter.
- UserInterface/Base/Utilities.js:
(Object.shallowMerge):
Merges the keys of two objects into a new one.
- UserInterface/Views/ComputedStyleDetailsPanel.js:
(WebInspector.ComputedStyleDetailsPanel.prototype._goToRegionFlowArrowWasClicked):
(WebInspector.ComputedStyleDetailsPanel.prototype._goToContentFlowArrowWasClicked):
- UserInterface/Views/SearchSidebarPanel.js:
(WebInspector.SearchSidebarPanel.prototype.performSearch.createTreeElementForMatchObject):
(WebInspector.SearchSidebarPanel.prototype.performSearch.resourceCallback):
(WebInspector.SearchSidebarPanel.prototype.performSearch.resourcesCallback):
(WebInspector.SearchSidebarPanel.prototype.performSearch.searchScripts.scriptCallback):
(WebInspector.SearchSidebarPanel.prototype.performSearch.searchScripts):
(WebInspector.SearchSidebarPanel.prototype.performSearch.domSearchResults):
(WebInspector.SearchSidebarPanel.prototype.performSearch.domCallback):
(WebInspector.SearchSidebarPanel.prototype.performSearch):
(WebInspector.SearchSidebarPanel.prototype._treeElementDoubleClick):
- UserInterface/Views/TreeElement.js:
(WebInspector.TreeElement.treeElementDoubleClicked):
Add an event dispatch whenever a TreeElement is double clicked via thedblclickevent.
- 4:15 PM Changeset in webkit [211607] by
-
- 2 edits in trunk
Build fix after r211602
https://bugs.webkit.org/show_bug.cgi?id=167758
- Source/Makefile:
Don't build libwebrtc by default. It's not used yet anyway.
- 4:09 PM Changeset in webkit [211606] by
-
- 2 edits in trunk/Tools
Remove check for SkipSafariExecutableEntitlementChecks
https://bugs.webkit.org/show_bug.cgi?id=167762
rdar://problem/22480673
Reviewed by Dan Bernstein.
- Scripts/webkitdirs.pm:
(safariPathFromSafariBundle):
(skipSafariExecutableEntitlementChecks): Deleted.
- 4:05 PM Changeset in webkit [211605] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed speculative build fix.
- platform/audio/mac/AudioSampleDataSource.cpp:
(WebCore::AudioSampleDataSource::setupConverter):
(WebCore::AudioSampleDataSource::pushSamples):
- 3:39 PM Changeset in webkit [211604] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, rolling out r211535, r211566, and r211568.
https://bugs.webkit.org/show_bug.cgi?id=167765
Causing timeouts? (Requested by andersca_ on #webkit).
Reverted changesets:
"IPC::Connection receive ports should be guarded"
https://bugs.webkit.org/show_bug.cgi?id=167704
http://trac.webkit.org/changeset/211535
"<rdar://problem/30323148> Webkit Nightly on 10.10 broken"
http://trac.webkit.org/changeset/211566
"<rdar://problem/30323148> Webkit Nightly on 10.10 broken"
http://trac.webkit.org/changeset/211568
- 3:32 PM Changeset in webkit [211603] by
-
- 17 edits5 adds in trunk/Source
Add a SIGILL crash analyzer to make debugging SIGILLs easier.
https://bugs.webkit.org/show_bug.cgi?id=167714
<rdar://problem/30318237>
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
The current implementation is only for X86_64 and ARM64 on OS(DARWIN). The
analyzer is not enabled for all other ports.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- API/JSVirtualMachine.mm:
- assembler/ARM64Assembler.h:
(JSC::ARM64Assembler::illegalInstruction):
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::illegalInstruction):
- assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::illegalInstruction):
- assembler/X86Assembler.h:
(JSC::X86Assembler::illegalInstruction):
- heap/Heap.cpp:
(JSC::Heap::forEachCodeBlockIgnoringJITPlansImpl):
- heap/Heap.h:
- heap/HeapInlines.h:
(JSC::Heap::forEachCodeBlockIgnoringJITPlans):
- runtime/Options.cpp:
(JSC::Options::isAvailable):
(JSC::recomputeDependentOptions):
- runtime/Options.h:
- runtime/VM.cpp:
(JSC::VM::VM):
(JSC::VM::~VM):
- runtime/VM.h:
- tools/SigillCrashAnalyzer.cpp: Added.
(JSC::SignalContext::SignalContext):
(JSC::SignalContext::dump):
(JSC::handleCrash):
(JSC::initializeCrashHandler):
(JSC::ensureSigillCrashAnalyzer):
(JSC::SigillCrashAnalyzer::analyze):
(JSC::SigillCrashAnalyzer::dumpCodeBlock):
- tools/SigillCrashAnalyzer.h: Added.
- tools/VMInspector.cpp: Added.
(JSC::VMInspector::instance):
(JSC::VMInspector::add):
(JSC::VMInspector::remove):
(JSC::ensureIsSafeToLock):
- tools/VMInspector.h: Added.
(JSC::VMInspector::iterate):
Source/WTF:
- wtf/StdLibExtras.h:
- 3:31 PM Changeset in webkit [211602] by
-
- 5 edits6 adds in trunk/Source
Build libwebrtc and dependencies with Xcode
https://bugs.webkit.org/show_bug.cgi?id=167758
Reviewed by Dean Jackson.
Source/ThirdParty/libwebrtc:
- Configurations: Added.
- Configurations/Base.xcconfig: Added.
- Configurations/DebugRelease.xcconfig: Added.
- Configurations/boringssl.xcconfig: Added.
- Configurations/libwebrtc.xcconfig: Added.
- Configurations/opus.xcconfig: Added.
- libwebrtc.xcodeproj/project.pbxproj:
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
- 3:21 PM Changeset in webkit [211601] by
-
- 3 edits in trunk/Source/WebKit2
Don't attempt wide gammut on older OSes
https://bugs.webkit.org/show_bug.cgi?id=167754
<rdar://problem/29931587>
Reviewed by Tim Horton.
We need to guard our extended color checks the same way throughout the code, or we will attempt to set up
support for wide gamut partially, which causes crashes when using sharable bitmap.
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::convertImageToBitmap):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation):
- 3:18 PM Changeset in webkit [211600] by
-
- 14 edits in trunk
{}.toString.call(crossOriginWindow) should return "[object Object]"
https://bugs.webkit.org/show_bug.cgi?id=167701
<rdar://problem/30330797>
Reviewed by Keith Miller.
LayoutTests/imported/w3c:
Rebaseline W3C test now that one more check is passing.
- web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt:
Source/JavaScriptCore:
Have JSProxy forward toStringName calls to its target so Window
can override it.
- runtime/JSProxy.cpp:
(JSC::JSProxy::toStringName):
- runtime/JSProxy.h:
Source/WebCore:
{}.toString.call() to should "[object Object] for cross origin
Window / Location objects. This new behavior is consistent with
Firefox and Chrome.
No new tests, rebaselined existing tests.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::toStringName):
- bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::toStringName):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
- bindings/scripts/IDLAttributes.txt:
- page/DOMWindow.idl:
- page/Location.idl:
LayoutTests:
Rebaselined existing test now that more checks are passing.
- http/tests/security/symbols-cross-origin-expected.txt:
- 3:15 PM Changeset in webkit [211599] by
-
- 2 edits in trunk/LayoutTests
Mark inspector/debugger/breakpoint-scope.html as flaky on macOS debug.
https://bugs.webkit.org/show_bug.cgi?id=164293
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 3:12 PM Changeset in webkit [211598] by
-
- 2 edits in trunk/Source/WebKit2
WK2: cannot tap on candidate view with hardware keyboard.
https://bugs.webkit.org/show_bug.cgi?id=167761
rdar://problem/28775395
Reviewed by Tim Horton.
The candidate view is a subview of the view returned by
automaticallySelectedOverlay and it should be the unscaled view
instead of the WKContentView.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView automaticallySelectedOverlay]):
- 3:03 PM Changeset in webkit [211597] by
-
- 26 edits in trunk/Source
Drag images should be anchored to the mouse location
https://bugs.webkit.org/show_bug.cgi?id=167690
<rdar://problem/30295261>
Reviewed by Enrica Casucci.
Source/WebCore:
Adds logic to compute the mouse anchor point. This is a point in the unit square indicating where the drag
origin is relative to the bounds of the drag image. There is no behavior change, since this anchor point is not
used by any client yet; this patch only computes and vends this information from WebCore.
- loader/EmptyClients.cpp:
- page/DragClient.h:
- page/DragController.cpp:
(WebCore::DragController::startDrag):
(WebCore::DragController::doImageDrag):
(WebCore::DragController::doSystemDrag):
- page/DragController.h:
- platform/DragImage.h:
Source/WebKit/mac:
Adds some plumbing for the anchor point in the WK1 client layer.
- WebCoreSupport/WebDragClient.h:
- WebCoreSupport/WebDragClient.mm:
(WebDragClient::startDrag):
Source/WebKit/win:
Adds some plumbing for the anchor point in the WK1 client layer.
- WebCoreSupport/WebDragClient.cpp:
(WebDragClient::startDrag):
- WebCoreSupport/WebDragClient.h:
Source/WebKit2:
Adds some plumbing for the mouse anchor point in the UI process. Additionally, refactors some unrelated code
for handling data interaction.
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::startDataInteractionWithImage):
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::startDataInteractionWithImage):
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::setDragImage):
- WebProcess/WebCoreSupport/WebDragClient.cpp:
(WebKit::WebDragClient::startDrag):
- WebProcess/WebCoreSupport/WebDragClient.h:
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
(WebKit::WebDragClient::startDrag):
- 3:01 PM Changeset in webkit [211596] by
-
- 2 edits4 adds in trunk/Source/WebCore
[Mac] Add classes to manage audio samples
https://bugs.webkit.org/show_bug.cgi?id=167739
Reviewed by Jer Noble.
No new tests, this code isn't used yet.
- WebCore.xcodeproj/project.pbxproj:
- platform/audio/mac/AudioSampleBufferList.cpp: Added.
(WebCore::AudioSampleBufferList::create):
(WebCore::AudioSampleBufferList::AudioSampleBufferList):
(WebCore::AudioSampleBufferList::~AudioSampleBufferList):
(WebCore::AudioSampleBufferList::setSampleCount):
(WebCore::AudioSampleBufferList::applyGain):
(WebCore::AudioSampleBufferList::mixFrom):
(WebCore::AudioSampleBufferList::copyFrom):
(WebCore::AudioSampleBufferList::copyTo):
(WebCore::AudioSampleBufferList::reset):
(WebCore::AudioSampleBufferList::zero):
(WebCore::AudioSampleBufferList::zeroABL):
(WebCore::AudioSampleBufferList::convertInput):
(WebCore::AudioSampleBufferList::audioConverterCallback):
(WebCore::AudioSampleBufferList::configureBufferListForStream):
- platform/audio/mac/AudioSampleBufferList.h: Added.
(WebCore::AudioSampleBufferList::streamDescription):
(WebCore::AudioSampleBufferList::bufferList):
(WebCore::AudioSampleBufferList::sampleCapacity):
(WebCore::AudioSampleBufferList::sampleCount):
(WebCore::AudioSampleBufferList::timestamp):
(WebCore::AudioSampleBufferList::hostTime):
(WebCore::AudioSampleBufferList::setTimes):
(WebCore::AudioSampleBufferList::audioBufferListSizeForStream):
- platform/audio/mac/AudioSampleDataSource.cpp: Added.
(WebCore::AudioSampleDataSource::create):
(WebCore::AudioSampleDataSource::AudioSampleDataSource):
(WebCore::AudioSampleDataSource::~AudioSampleDataSource):
(WebCore::AudioSampleDataSource::setPaused):
(WebCore::AudioSampleDataSource::setupConverter):
(WebCore::AudioSampleDataSource::setInputFormat):
(WebCore::AudioSampleDataSource::setOutputFormat):
(WebCore::AudioSampleDataSource::hostTime):
(WebCore::AudioSampleDataSource::pushSamplesInternal):
(WebCore::AudioSampleDataSource::pushSamples):
(WebCore::AudioSampleDataSource::pullSamplesInternal):
(WebCore::AudioSampleDataSource::pullSamples):
- platform/audio/mac/AudioSampleDataSource.h: Added.
(WebCore::AudioSampleDataSource::setVolume):
(WebCore::AudioSampleDataSource::volume):
(WebCore::AudioSampleDataSource::setMuted):
(WebCore::AudioSampleDataSource::muted):
- 2:45 PM Changeset in webkit [211595] by
-
- 2 edits in trunk/LayoutTests
Mark workesr/bomb/html as flaky on macOS.
https://bugs.webkit.org/show_bug.cgi?id=167757
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 2:07 PM Changeset in webkit [211594] by
-
- 37 edits4 copies13 adds in trunk
Support Performance API (performance.now(), UserTiming) in Workers
https://bugs.webkit.org/show_bug.cgi?id=167717
Reviewed by Ryosuke Niwa.
Source/WebCore:
Tests: performance-api/performance-mark-name.html
performance-api/performance-now-api.html
performance-api/performance-now-time-origin-in-worker.html
performance-api/user-timing-apis.html
- CMakeLists.txt:
- DerivedSources.make:
New files.
- page/DOMWindow.idl:
- page/GlobalPerformance.idl:
- workers/WorkerGlobalScope.idl:
Add partial interface for performance attribute.
- page/Performance.idl:
- page/PerformanceEntry.idl:
- page/PerformanceMark.idl:
- page/PerformanceMeasure.idl:
- page/PerformanceObserver.idl:
- page/PerformanceObserverEntryList.idl:
Expose these to Workers.
- page/Performance.cpp:
(WebCore::Performance::Performance):
(WebCore::Performance::contextDestroyed):
- page/Performance.h:
Use the EventQueue variant that works with any ScriptExectionContext.
- page/PerformanceObserver.cpp:
(WebCore::PerformanceObserver::PerformanceObserver):
Get the Performance base in a Worker context.
- page/PerformanceUserTiming.cpp:
(WebCore::UserTiming::mark):
Only reject legacy special mark names in a Window, not a Worker.
(WebCore::UserTiming::findExistingMarkStartTime):
Simple implementation returns 0 as the start time in Workers. The spec
is currently imprecise here, but it does not have the unusual
PerformanceTiming behavior in a Window which is part of User Timing 1.
- workers/Worker.cpp:
(WebCore::Worker::create):
(WebCore::Worker::notifyFinished):
- workers/Worker.h:
Record the moment of Worker creation.
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::WorkerGlobalScope):
(WebCore::WorkerGlobalScope::performance):
- workers/WorkerGlobalScope.h:
Construct the Performance object with the moment of creation (timeOrigin).
- workers/DedicatedWorkerGlobalScope.cpp:
(WebCore::DedicatedWorkerGlobalScope::create):
(WebCore::DedicatedWorkerGlobalScope::DedicatedWorkerGlobalScope):
- workers/DedicatedWorkerGlobalScope.h:
- workers/DedicatedWorkerThread.cpp:
(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
(WebCore::DedicatedWorkerThread::createWorkerGlobalScope):
- workers/DedicatedWorkerThread.h:
- workers/WorkerGlobalScopeProxy.h:
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
- workers/WorkerMessagingProxy.h:
- workers/WorkerThread.cpp:
(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::workerThread):
- workers/WorkerThread.h:
Pass the moment of creation (timeOrigin) through to WorkerGlobalScope creation.
LayoutTests:
- js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
Updated now that Performance classes are in Workers.
- performance-api/performance-now-api-expected.txt: Added.
- performance-api/performance-now-api.html: Added.
- performance-api/performance-now-time-origin-in-worker-expected.txt: Added.
- performance-api/performance-now-time-origin-in-worker.html: Added.
New tests to cover performance.now.
- performance-api/performance-mark-name-expected.txt: Added.
- performance-api/performance-mark-name.html: Added.
- performance-api/resources/mark-name.js: Added.
- performance-api/resources/user-timing-api.js: Added.
- performance-api/user-timing-apis-expected.txt: Added.
- performance-api/user-timing-apis.html: Added.
New tests to cover user-timing and performance.mark behavior.
- performance-api/performance-observer-api-expected.txt:
- performance-api/performance-observer-api.html:
- performance-api/performance-observer-basic-expected.txt:
- performance-api/performance-observer-basic.html:
- performance-api/performance-timeline-api-expected.txt:
- performance-api/performance-timeline-api.html:
- performance-api/resources/now-api.js: Added.
- performance-api/resources/observer-api.js: Copied from LayoutTests/performance-api/performance-observer-api.html.
- performance-api/resources/observer-basic.js: Copied from LayoutTests/performance-api/performance-observer-basic.html.
- performance-api/resources/time-origin-in-worker.js: Added.
- performance-api/resources/timeline-api.js: Copied from LayoutTests/performance-api/performance-timeline-api.html.
Update some of the existing tests to check in a Document and Worker.
- imported/w3c/web-platform-tests/user-timing/test_user_timing_mark_and_measure_exception_when_invoke_with_timing_attributes-expected.txt:
Minor progression.
- 1:36 PM Changeset in webkit [211593] by
-
- 2 edits in trunk/LayoutTests
Mark imported/w3c/web-platform-tests/shadow-dom/slotchange.html as flaky on macOS.
https://bugs.webkit.org/show_bug.cgi?id=167652
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 1:31 PM Changeset in webkit [211592] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r211579.
https://bugs.webkit.org/show_bug.cgi?id=167753
Caused mediastream crashes. (Requested by bfulgham_ on
#webkit).
Reverted changeset:
"Correct memory leak in MediaConstraints"
https://bugs.webkit.org/show_bug.cgi?id=167744
http://trac.webkit.org/changeset/211579
- 1:29 PM Changeset in webkit [211591] by
-
- 93 edits in trunk/Source
Rename Node::inDocument() to isConnected()
https://bugs.webkit.org/show_bug.cgi?id=167743
Reviewed by Sam Weinig.
Rename Node::inDocument() to isConnected() to match the DOM specification more closely:
Source/WebKit/mac:
- DOM/DOMNode.mm:
(-[DOMNode isConnected]):
- WebView/WebFrame.mm:
(-[WebFrame selectNSRange:onElement:]):
- 1:25 PM Changeset in webkit [211590] by
-
- 26 edits4 copies21 adds in trunk
[Modern Media Controls] Provide a compact mode for when the controls are small
https://bugs.webkit.org/show_bug.cgi?id=167746
<rdar://problem/29565842>
Reviewed by Dean Jackson.
Source/WebCore:
When the macOS inline media controls become too narrow to display both the volume and fullscreen
buttons in their right container (width < 242), we switch to a compact mode where the controls bar
is shorter and the buttons smaller.
To facilitate this, we provide a new subclass of MacOSInlineMediaControls called MacOSCompactInlineMediaControls
which changes some of the layout properties of the buttons to have shorter margins around buttons.
We also added a new "Compact" LayoutTrait and improved IconService to provide specific icons
for this mode for the buttons that can exist in compact mode.
To correctly implement the design, we needed to add a way to provide different margins around the
left and right edges of the container, so the "padding" property is now split between "leftMargin"
and "rightMargin", and to make property naming cleaner, the "margin" property which specifies the
space between each button in a container is now called "buttonMargin". We also set the default
values for those properties to be 24 (instead of 0) which are the most widely used values, requiring
less customization.
Tests: media/modern-media-controls/macos-compact-inline-media-controls/macos-compact-inline-media-controls-buttons-styles.html
media/modern-media-controls/macos-compact-inline-media-controls/macos-compact-inline-media-controls-constructor.html
media/modern-media-controls/macos-compact-inline-media-controls/macos-compact-inline-media-controls-controls-bar-styles.html
media/modern-media-controls/macos-compact-inline-media-controls/macos-compact-inline-media-controls-layout.html
media/modern-media-controls/macos-compact-inline-media-controls/macos-compact-inline-media-controls-volume-styles.html
media/modern-media-controls/media-controller/media-controller-toggle-compact-mode.html
- Modules/modern-media-controls/controls/buttons-container.js:
(ButtonsContainer.prototype.layout): Refactor the "margin" and "padding" properties into
"leftMargin", "rightMargin" and "buttonMargin".
- Modules/modern-media-controls/controls/icon-button.js:
(IconButton.prototype._updateImage): Fix a small bug that would prevent the image source
change to occur after changing the "iconName" property should the previous and new icons
share the same metrics, which is the case for the "play" and "pause" icons in compact mode.
- Modules/modern-media-controls/controls/icon-service.js: Add support for compact variants.
(const.iconService.new.IconService.prototype._fileNameAndPlatformForIconNameAndLayoutTraits):
(const.iconService.new.IconService):
- Modules/modern-media-controls/controls/ios-inline-media-controls.js: Adopt new margin defaults.
- Modules/modern-media-controls/controls/layout-item.js: Add the new "Compact" LayoutTrait.
- Modules/modern-media-controls/controls/macos-compact-inline-media-controls.css: Added.
(.media-controls.mac.inline.compact > .controls-bar):
(.media-controls.mac.inline.compact button.play-pause):
(.media-controls.mac.inline.compact button.skip-back):
(.media-controls.mac.inline.compact .scrubber.slider):
(.media-controls.mac.inline.compact button.mute):
(.media-controls.mac.inline.compact button.fullscreen):
(.media-controls.mac.inline.compact .time-label,):
(.media-controls.mac.inline.compact .volume-slider-container):
(.media-controls.mac.inline.compact .volume.slider):
(.media-controls.mac.inline.compact .scrubber.slider > input::-webkit-slider-thumb):
- Modules/modern-media-controls/controls/macos-compact-inline-media-controls.js: Added.
(MacOSCompactInlineMediaControls):
- Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js: Adopt new margin defaults.
(MacOSFullscreenMediaControls.prototype.layout):
- Modules/modern-media-controls/controls/macos-inline-media-controls.js: Adopt new margin defaults
and make the _leftContainer and _rightContainer properties public such that the MacOSCompactInlineMediaControls
subclass may customize them without accessing a private property.
(MacOSInlineMediaControls.prototype.layout):
(MacOSInlineMediaControls.prototype.showTracksPanel):
- Modules/modern-media-controls/images/macOS/enter-fullscreen-compact@1x.png: Added.
- Modules/modern-media-controls/images/macOS/enter-fullscreen-compact@2x.png: Added.
- Modules/modern-media-controls/images/macOS/interval-skip-back-compact@1x.png: Added.
- Modules/modern-media-controls/images/macOS/interval-skip-back-compact@2x.png: Added.
- Modules/modern-media-controls/images/macOS/pause-compact@1x.png: Added.
- Modules/modern-media-controls/images/macOS/pause-compact@2x.png: Added.
- Modules/modern-media-controls/images/macOS/play-compact@1x.png: Added.
- Modules/modern-media-controls/images/macOS/play-compact@2x.png: Added.
- Modules/modern-media-controls/images/macOS/volume-compact@1x.png: Added.
- Modules/modern-media-controls/images/macOS/volume-compact@2x.png: Added.
- Modules/modern-media-controls/js-files: Add the new files so they are concatenated by the build script.
- Modules/modern-media-controls/media/media-controller.js: Toggle compact mode if controls
are below the 242px width threshold.
(MediaController.prototype.get layoutTraits):
(MediaController.prototype.handleEvent):
(MediaController.prototype._updateControlsIfNeeded):
(MediaController.prototype._shouldFadeBetweenControls):
(MediaController.prototype._updateControlsSize):
(MediaController.prototype._controlsWidth):
(MediaController.prototype._controlsClass):
(MediaController):
- WebCore.xcodeproj/project.pbxproj: Add new files and perform some cleanup so that the
project accurately lists all the existing project files and remove some older ones.
LayoutTests:
Add some new tests for the compact mode and update some tests after the ButtonsContainer
"padding" and "margin" properties refactoring.
- media/modern-media-controls/buttons-container/buttons-container-buttons-property.html:
- media/modern-media-controls/buttons-container/buttons-container-constructor-expected.txt:
- media/modern-media-controls/buttons-container/buttons-container-constructor.html:
- media/modern-media-controls/buttons-container/buttons-container-layout.html:
- media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-constructor-expected.txt:
- media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-constructor.html:
- media/modern-media-controls/macos-compact-inline-media-controls/macos-compact-inline-media-controls-buttons-styles-expected.txt: Added.
- media/modern-media-controls/macos-compact-inline-media-controls/macos-compact-inline-media-controls-buttons-styles.html: Added.
- media/modern-media-controls/macos-compact-inline-media-controls/macos-compact-inline-media-controls-constructor-expected.txt: Added.
- media/modern-media-controls/macos-compact-inline-media-controls/macos-compact-inline-media-controls-constructor.html: Added.
- media/modern-media-controls/macos-compact-inline-media-controls/macos-compact-inline-media-controls-controls-bar-styles-expected.txt: Added.
- media/modern-media-controls/macos-compact-inline-media-controls/macos-compact-inline-media-controls-controls-bar-styles.html: Added.
- media/modern-media-controls/macos-compact-inline-media-controls/macos-compact-inline-media-controls-layout-expected.txt: Added.
- media/modern-media-controls/macos-compact-inline-media-controls/macos-compact-inline-media-controls-layout.html: Added.
- media/modern-media-controls/macos-compact-inline-media-controls/macos-compact-inline-media-controls-volume-styles-expected.txt: Added.
- media/modern-media-controls/macos-compact-inline-media-controls/macos-compact-inline-media-controls-volume-styles.html: Added.
- media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-constructor-expected.txt:
- media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-constructor.html:
- media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-right-container-margin-expected.txt:
- media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-right-container-margin.html:
- media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-constructor-expected.txt:
- media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-constructor.html:
- media/modern-media-controls/media-controller/media-controller-toggle-compact-mode-expected.txt: Added.
- media/modern-media-controls/media-controller/media-controller-toggle-compact-mode.html: Added.
- media/modern-media-controls/resources/media-controls-loader.js:
- platform/ios-simulator/TestExpectations:
- 1:24 PM Changeset in webkit [211589] by
-
- 19 edits2 deletes in trunk/Source
Unreviewed, rolling out r211571 and r211582.
https://bugs.webkit.org/show_bug.cgi?id=167751
This change caused API test WebKit1.MemoryPressureHandler to
fail with an assertion. (Requested by ryanhaddad on #webkit).
Reverted changesets:
"[Mac] In-process memory pressure monitor for WebContent
processes."
https://bugs.webkit.org/show_bug.cgi?id=167491
http://trac.webkit.org/changeset/211571
"Unreviewed attempt to fix the Windows build after r211571."
http://trac.webkit.org/changeset/211582
- 1:05 PM Changeset in webkit [211588] by
-
- 2 edits in trunk/Source/WebKit2
The Make Frameworks Symbolic Link build phase can end up creating a symlink inside the Frameworks subdirectory
https://bugs.webkit.org/show_bug.cgi?id=167745
Reviewed by Tim Horton.
- WebKit2.xcodeproj/project.pbxproj: Pass the -h option to ln(1) so that it will replace, rather than follow, an existing symlink.
- 1:00 PM Changeset in webkit [211587] by
-
- 6 edits in trunk/Source
Versioning.
- 12:56 PM Changeset in webkit [211586] by
-
- 2 edits in trunk/LayoutTests
Mark imported/w3c/web-platform-tests/html/semantics/interactive-elements/the-details-element/toggleEvent.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=164041
Unreviewed test gardening.
- 12:45 PM Changeset in webkit [211585] by
-
- 1 delete in tags/Safari-604.1.6
Deleting Tag.
- 12:42 PM Changeset in webkit [211584] by
-
- 2 edits in trunk/Source/WebKit/win
[Win][HiDPI] Scale factor is applied twice in accelerated compositing mode.
https://bugs.webkit.org/show_bug.cgi?id=167732
Reviewed by Brent Fulgham.
Backing layer should not be scaled when CACFLayerSetContentsScale is used for scaling.
- WebView.cpp:
(WebView::setAcceleratedCompositing):
- 12:24 PM Changeset in webkit [211583] by
-
- 3 edits in trunk/LayoutTests
Unreviewed ios-simulator test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- platform/ios-simulator/TestExpectations:
- 12:22 PM Changeset in webkit [211582] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed attempt to fix the Windows build after r211571.
- platform/MemoryPressureHandler.cpp:
(WebCore::thresholdForPolicy):
(WebCore::policyForFootprint):
- 12:21 PM Changeset in webkit [211581] by
-
- 3 edits in trunk/LayoutTests
Clean up css3/filters/backdrop/dynamic-with-clip-path.html
This test used a clip-path that was entirely outside the element, making it confusing.
Move the clipping circle to the center.
- css3/filters/backdrop/dynamic-with-clip-path-expected.html:
- css3/filters/backdrop/dynamic-with-clip-path.html:
- 11:34 AM Changeset in webkit [211580] by
-
- 2 edits in trunk
Make the Makefile great again after r211570, r211572
- Makefile: Restore tabs and ending newline.
- 11:33 AM Changeset in webkit [211579] by
-
- 2 edits in trunk/Source/WebCore
Correct memory leak in MediaConstraints
https://bugs.webkit.org/show_bug.cgi?id=167744
<rdar://problem/30331444>
Reviewed by Anders Carlsson.
ConstraintHolder returns a reference to an object created by operator new. When the
returned value is assigned or stored in Vector or other containers we leak memory.
Instead, this value should just be returned as a regular object so that the return
value optimization can make sure memory is properly (and efficiently) used.
- platform/mediastream/MediaConstraints.h:
(WebCore::FlattenedConstraint::ConstraintHolder::create): Return by value.
- 11:20 AM Changeset in webkit [211578] by
-
- 5 edits in branches/safari-604.1.5-branch
Merge r211502. rdar://problem/30319184
- 11:20 AM Changeset in webkit [211577] by
-
- 3 edits2 adds in branches/safari-604.1.5-branch
Merge r211495. rdar://problem/30106362
- 11:20 AM Changeset in webkit [211576] by
-
- 4 edits2 adds in branches/safari-604.1.5-branch
Merge r211339. rdar://problem/29601646
- 11:20 AM Changeset in webkit [211575] by
-
- 12 edits in branches/safari-604.1.5-branch/Source
Merge r211438.
- 11:12 AM Changeset in webkit [211574] by
-
- 2 edits in trunk/LayoutTests
Marking http/tests/inspector/worker/blob-script-with-cross-domain-imported-scripts.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=167607
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 10:55 AM Changeset in webkit [211573] by
-
- 29 edits1 copy in trunk/LayoutTests
Clean up accessibility & animations tests to stop calling testRunner.waitUntilDone() twice
<https://webkit.org/b/167598>
Reviewed by Alexey Proskuryakov.
- accessibility/frame-disconnect-textmarker-cache-crash.html:
- accessibility/loading-iframe-sends-notification.html:
- accessibility/mac/combobox-activedescendant-notifications.html:
- accessibility/mac/ordered-textmarker-crash.html:
- accessibility/mac/stale-textmarker-crash.html:
- accessibility/notification-listeners.html:
- accessibility/scroll-to-global-point-iframe-nested.html:
- accessibility/scroll-to-global-point-iframe.html:
- accessibility/scroll-to-make-visible-iframe.html:
- accessibility/svg-element-press.html:
- Remove call to testRunner.waitUntilDone() since window.jsTestIsAsync is set to true, and thus waitUntilDone() is called from either js-test.js or js-test-post.js.
- animations/animation-delay-changed.html:
- animations/change-keyframes-name.html:
- animations/font-variations/font-variation-settings-order.html:
- animations/font-variations/font-variation-settings-unlike.html:
- animations/font-variations/font-variation-settings.html:
- animations/longhand-timing-function.html:
- animations/transition-and-animation-3.html:
- animations/unanimated-style.html:
- Remove call to testRunner.waitUntilDone() since that's moved into animation-test-helpers.js.
- animations/resources/animation-test-helpers.js:
(runAnimationTest): Call testRunner.waitUntilDone() when this
script resource is included instead of when runAnimationTest()
is called since runAnimationTest() expects it to be set anyway.
- animations/animation-direction-reverse-fill-mode-hardware.html:
- animations/animation-direction-reverse-fill-mode.html:
- animations/animation-hit-test-transform.html:
- animations/animation-hit-test.html:
- animations/animation-internals-api-multiple-keyframes.html:
- animations/animation-internals-api.html:
- animations/change-transform-style-during-animation.html:
- animations/keyframes-iteration-count-non-integer.html:
- Remove call to testRunner.waitUntilDone() since that now happens when loading animation-test-helpers.js. These tests don't currently call runAnimationTest(), but they manage their own state by calling testRunner.notifyDone() themselves.
- animations/crash-on-removing-animation.html:
- animations/resources/crash-on-removing-animation-window.html: Copied from LayoutTests/animations/crash-on-removing-animation.html.
- Split this test into a main resource and a window resource. Previously testRunner.waitUntilDone() was being called twice when js-test-post.js was loaded in the main window and then loaded a second time when the window was opened. The new resource file doesn't load either js-test-pre.js or js-test-post.js, avoiding the duplicate call.
- 10:42 AM Changeset in webkit [211572] by
-
- 1 edit1 add in trunk
Unreviewed build fix after r211570
- Makefile: Placed back.
- 10:35 AM Changeset in webkit [211571] by
-
- 19 edits2 copies in trunk/Source
Source/JavaScriptCore:
[Mac] In-process memory pressure monitor for WebContent processes.
<https://webkit.org/b/167491>
<rdar://problem/30116072>
Reviewed by Antti Koivisto.
Remove the sloppy "max live heap size" mechanism from JSC in favor of the new
WebCore-side memory footprint monitor.
- heap/Heap.cpp:
(JSC::Heap::updateAllocationLimits):
(JSC::Heap::didExceedMaxLiveSize): Deleted.
- heap/Heap.h:
(JSC::Heap::setMaxLiveSize): Deleted.
Source/WebCore:
[Mac] In-process memory pressure monitor for WebContent processes AKA websam
<https://webkit.org/b/167491>
<rdar://problem/30116072>
Reviewed by Antti Koivisto.
Add a new timer-based memory pressure monitor that checks the process memory
footprint every 30 seconds and reacts to changes by setting a MemoryUsagePolicy.
There are four MemoryUsagePolicy values:
- Unrestricted (below 1GB)
- Conservative (above 1GB)
- Strict (above 2GB)
- Panic (above 4GB, or 3GB if 32-bit)
For Strict and above, the old-style "isUnderMemoryPressure()" API will return true.
Transitioning to a higher policy will cause memory pressure handlers to run:
At Strict, we run the "non-critical" memory pressure handler, then carry on.
At Panic, we run the "critical" memory pressure handler. If that fails to recover
enough memory to bring us back below 4GB, we may kill the process:
A process is eligible to get killed for using too much memory if:
- It's not visible on screen (i.e it's a background tab.)
- It's not playing audio.
- It has not performed a main frame navigation in the last hour.
Before killing the process, an exit-time callback will run. This patch installs such
a callback that prints out some time-of-death statistics about C++ and JavaScript memory
usage to hopefully help understand what was soaking up all the memory.
- bindings/js/CommonVM.cpp:
(WebCore::commonVMSlow):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::setState):
- page/MainFrame.cpp:
(WebCore::MainFrame::didCompleteLoad):
- page/MainFrame.h:
- page/MemoryRelease.cpp:
(WebCore::pageCount):
(WebCore::logMemoryStatisticsAtTimeOfDeath):
(WebCore::didExceedMemoryLimitAndFailedToRecover):
(WebCore::processIsEligibleForMemoryKill):
- page/MemoryRelease.h:
- page/ResourceUsageThread.h:
- page/cocoa/ResourceUsageThreadCocoa.mm:
(WebCore::vmPageSize):
- platform/MemoryPressureHandler.cpp:
(WebCore::MemoryPressureHandler::MemoryPressureHandler):
(WebCore::MemoryPressureHandler::setShouldUsePeriodicMemoryMonitor):
(WebCore::toString):
(WebCore::thresholdForPolicy):
(WebCore::policyForFootprint):
(WebCore::MemoryPressureHandler::measurementTimerFired):
- platform/MemoryPressureHandler.h:
(WebCore::MemoryPressureHandler::setMemoryKillCallback):
(WebCore::MemoryPressureHandler::setProcessIsEligibleForMemoryKillCallback):
(WebCore::MemoryPressureHandler::isUnderMemoryPressure):
Source/WebKit2:
[Mac] In-process memory pressure monitor for WebContent processes.
<https://webkit.org/b/167491>
<rdar://problem/30116072>
Reviewed by Antti Koivisto.
Enable the in-process memory monitor for WebContent processes on macOS 10.12+
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
Source/WTF:
[Mac] In-process memory pressure monitor for WebContent processes.
<https://webkit.org/b/167491>
<rdar://problem/30116072>
Reviewed by Antti Koivisto.
Add a WTF helper function for getting the current process's memory footprint.
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/MemoryFootprint.cpp:
(WTF::memoryFootprint):
- wtf/MemoryFootprint.h:
- 10:33 AM Changeset in webkit [211570] by
-
- 2 edits1 delete in trunk
Undefined subroutine in svn-create-patch
https://bugs.webkit.org/show_bug.cgi?id=167742
Unreviewed build-fix after r211543.
- Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
- 10:31 AM Changeset in webkit [211569] by
-
- 13 edits in trunk/Source
[Crash] com.apple.WebKit.WebContent at WebKit: WebKit::WebPage::fromCorePage()
https://bugs.webkit.org/show_bug.cgi?id=167738
<rdar://problem/30229990>
Reviewed by Andreas Kling.
Source/WebCore:
Upon destruction of a Page, we destroy the BackForwardClient, which is supposed
to keep track of HistoryItems associated to this particular page and remove them
from the PageCache. Given the crash trace, the issue seems to be that some
HistoryItems associated with the Page sometimes linger in the PageCache *after*
the Page has been destroyed, which leads to crashes later on when pruning the
PageCache.
In order to make the process more robust, this patch refactors the code so that
the Page is now in charge of removing all its associated HistoryItems from the
PageCache instead of relying on the BackForwardClient. Also, instead of having
the Page keep track of which HistoryItems are associated with it (which is
error prone), we now scan all PageCache entries instead to find which ones are
associated with the Page. While this is in theory slower, this is much safer
and in practice not an issue because the PageCache usually has 3-5 entries.
No new tests, could not reproduce.
- history/CachedPage.cpp:
(WebCore::CachedPage::CachedPage):
- history/CachedPage.h:
(WebCore::CachedPage::page):
- history/PageCache.cpp:
(WebCore::PageCache::removeAllItemsForPage):
- history/PageCache.h:
- page/Page.cpp:
(WebCore::Page::~Page):
Source/WebKit/mac:
The BackForwardClient no longer needs to worry about removing HistoryItems
from the PageCache now that WebCore takes care of it.
- History/BackForwardList.mm:
(BackForwardList::close):
Source/WebKit/win:
The BackForwardClient no longer needs to worry about removing HistoryItems
from the PageCache now that WebCore takes care of it.
- BackForwardList.cpp:
(BackForwardList::close):
Source/WebKit2:
The BackForwardClient no longer needs to worry about removing HistoryItems
from the PageCache now that WebCore takes care of it.
- WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::WebBackForwardListProxy::addItemFromUIProcess):
(WebKit::WebBackForwardListProxy::addItem):
(WebKit::WebBackForwardListProxy::close):
- WebProcess/WebPage/WebBackForwardListProxy.h:
- 9:52 AM Changeset in webkit [211568] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/30323148> Webkit Nightly on 10.10 broken
Follow-up fix.
- Platform/IPC/mac/ConnectionMac.mm:
(IPC::Connection::open):
- 9:46 AM Changeset in webkit [211567] by
-
- 2 edits in trunk/Tools
Unreviewed. Fix jhbuild dependencies build.
- gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
Patch updated.
- 9:39 AM Changeset in webkit [211566] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/30323148> Webkit Nightly on 10.10 broken
Try to fix the 10.10 build.
- Platform/IPC/mac/ConnectionMac.mm:
(IPC::Connection::open):
- 9:37 AM Changeset in webkit [211565] by
-
- 2 edits in trunk/Source/WebKit2
Handle m_processLauncher being null in ChildProcessProxy::processIdentifier()
https://bugs.webkit.org/show_bug.cgi?id=167713
rdar://problem/28896113
Reviewed by Dan Bernstein.
This can happen if the process has been explicitly terminated.
- UIProcess/ChildProcessProxy.h:
(WebKit::ChildProcessProxy::processIdentifier):
- 9:06 AM Changeset in webkit [211564] by
-
- 3 edits2 adds in trunk
Column progression wrong after enabling pagination on RTL document
https://bugs.webkit.org/show_bug.cgi?id=167733
<rdar://problem/29012252>
Reviewed by Zalan Bujtas.
Source/WebCore:
Column progression depends on document direction but was not updated when direction changed.
Test: fast/multicol/pagination/pagination-dynamic-rtl.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::styleDidChange):
Update column styles if document direction changes.
LayoutTests:
- fast/multicol/pagination/pagination-dynamic-rtl-expected.html: Added.
- fast/multicol/pagination/pagination-dynamic-rtl.html: Added.
- 9:04 AM Changeset in webkit [211563] by
-
- 2 edits in trunk/LayoutTests
Marking http/tests/contentextensions/block-everything-unless-domain.html as flaky on macOS.
https://bugs.webkit.org/show_bug.cgi?id=167653
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 8:54 AM Changeset in webkit [211562] by
-
- 13 edits2 adds in trunk
[EME][GStreamer] Fixed decryptor selection
https://bugs.webkit.org/show_bug.cgi?id=167588
Reviewed by Žan Doberšek.
Source/WebCore:
GStreamer selected a decryptor automatically but we need to be
able to tell it which decryptor we want because one file can be
encrypted with more than one system and the one we want to use can
depend on what the user tells us.
Now when the demuxer is about to select the demuxer, it runs a
GstContext query with the events, which are forwarded through the
EME api to the application, which will answer the the
generateKeyRequest and then we can instruct the demuxer to select
the one we tell it, not the one that is selected automatically. If
the demuxer has already a preferred decryptor, the codepath will
be similar to the older one.
Something that is also fixed is the report of the keyneeded event,
which will contain all pssh boxes as requested by the spec.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Intercept
the event and handle it.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
Initialize the CDM session.
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
Unlock the protection condition just in case and set CDM to null.
(WebCore::extractEventsAndSystemsFromMessage): Access the events
and accepted key systems coming at the message from the demuxer.
(WebCore::MediaPlayerPrivateGStreamerBase::handleSyncMessage):
Handle the protection event not as an element event but as a
context request. It also concatenates all the initdatas in case
there is more than one. The event is sent in the main thread and
the current one blocks until a timeout is hit or the
generateKeyRequest is called.
(WebCore::MediaPlayerPrivateGStreamerBase::handleProtectionEvent):
Check if the event was already handled and if not, run the need
key event.
(WebCore::MediaPlayerPrivateGStreamerBase::receivedGenerateKeyRequest):
Notify the that the query arrived so that we can unlock the
demuxer thread.
(WebCore::keySystemIdToUuid): Translates ids to uuids, meaning
the ones coming from JS to the ones coming from the media engine.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
Attributes and methods.
- platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:
(webkit_media_clear_key_decrypt_class_init):
(webKitMediaClearKeyDecryptorRequestDecryptionKey): Deleted.
- platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.h:
Added the ui and uuid.
- platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:
(webkitMediaCommonEncryptionDecryptSinkEventHandler): Do not rely
on the subclass, just forward the event to the pipeline inside a message.
- platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.h:
Remove unused function signature.
- platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::appendPipelineNeedContextMessageCallback): Renamed from
appendPipelineElementMessageCallback.
(WebCore::AppendPipeline::AppendPipeline): Connect to the
need-context message instead of the element one.
(WebCore::AppendPipeline::dispatchPendingDecryptionKey):
Dispatches the drm-cypher message if there is one pending.
(WebCore::AppendPipeline::dispatchDecryptionKey): Dispatches the
drm-cypher.
(WebCore::AppendPipeline::handleNeedContextSyncMessage): Handles
the need-context event instead of the element one.
(WebCore::AppendPipeline::connectDemuxerSrcPadToAppsinkFromAnyThread):
Dispatches the key to the pipeline if there's any pending.
(WebCore::appendPipelineElementMessageCallback): Deleted.
(WebCore::AppendPipeline::handleElementMessage): Deleted.
- platform/graphics/gstreamer/mse/AppendPipeline.h: New methods
and attributes.
- platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::dispatchDecryptionKey):
Use the dispatchDecryptionKey method of the AppendPipeline.
Tools:
This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
- gtk/jhbuild.modules: Added patches to gstreamer and
gst-plugins-good packages.
- gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
- gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
- 8:30 AM Changeset in webkit [211561] by
-
- 2 edits in trunk/LayoutTests
LayoutTest media/modern-media-controls/buttons-container/buttons-container-buttons-property.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=167371
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 8:08 AM Changeset in webkit [211560] by
-
- 2 edits in trunk/LayoutTests
Skip fast/visual-viewport/ios/bottom-bar-with-keyboard.html on ios-simulator.
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 8:04 AM Changeset in webkit [211559] by
-
- 1 edit1 move2 adds in trunk/LayoutTests
Unreviewed, rolling out r211529.
This change caused the test to fail on macOS.
Reverted changeset:
"Clean up css3/filters/backdrop/backdrop-filter-with-clip-
path.html expected results."
http://trac.webkit.org/changeset/211529
- 6:59 AM Changeset in webkit [211558] by
-
- 2 edits in trunk/LayoutTests
LayoutTest media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=167372
Unreviewed test gardening.
Patch by Antoine Quint <Antoine Quint> on 2017-02-02
- platform/mac-wk1/TestExpectations:
- 6:26 AM Changeset in webkit [211557] by
-
- 2 edits in trunk/LayoutTests
LayoutTest media/modern-media-controls/media-controller/media-controller-resize.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=164571
Unreviewed test gardening.
Patch by Antoine Quint <Antoine Quint> on 2017-02-02
- platform/mac-wk1/TestExpectations:
- 6:22 AM Changeset in webkit [211556] by
-
- 2 edits in trunk/LayoutTests
LayoutTest media/modern-media-controls/rewind-button/rewind-button.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=167352
Unreviewed test gardening.
Patch by Antoine Quint <Antoine Quint> on 2017-02-02
- platform/mac-wk1/TestExpectations:
- 2:38 AM Changeset in webkit [211555] by
-
- 7 edits in trunk/Source/WebCore
Removed unused EventHandler members
https://bugs.webkit.org/show_bug.cgi?id=167723
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-02-02
Reviewed by Yusuke Suzuki.
- page/EventHandler.cpp:
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleWheelEvent):
- page/EventHandler.h:
Remove unused members.
- editing/FrameSelection.cpp:
- html/HTMLTextAreaElement.cpp:
- rendering/RenderObject.cpp:
- rendering/RenderSlider.cpp:
Remove unnecessary includes.
- 2:31 AM Changeset in webkit [211554] by
-
- 16 edits2 adds in trunk
Web Inspector: Upgrade Esprima to the latest one to support dynamic import
https://bugs.webkit.org/show_bug.cgi?id=167698
Reviewed by Joseph Pecoraro.
Source/WebInspectorUI:
- UserInterface/External/Esprima/esprima.js:
Update to Esprima@5307e30 (4.0.0-dev).
- UserInterface/Models/ScriptSyntaxTree.js:
(WebInspector.ScriptSyntaxTree.prototype._gatherIdentifiersInDeclaration.gatherIdentifiers):
(WebInspector.ScriptSyntaxTree.prototype._gatherIdentifiersInDeclaration):
(WebInspector.ScriptSyntaxTree.prototype._recurse):
(WebInspector.ScriptSyntaxTree.prototype._createInternalSyntaxTree):
(WebInspector.ScriptSyntaxTree):
- UserInterface/Workers/Formatter/ESTreeWalker.js:
(ESTreeWalker.prototype._walkChildren):
(ESTreeWalker):
Add new nodes, SpreadProperty, RestProperty, and Import.
SpreadProperty and RestProperty are the part of ES2018 rest and spread properties.
https://github.com/sebmarkbage/ecmascript-rest-spread
Import is dynamic import node. The syntax is similar to Super.
https://github.com/tc39/proposal-dynamic-import
- UserInterface/Workers/Formatter/EsprimaFormatter.js:
(EsprimaFormatter.prototype._handleTokenAtNode):
LayoutTests:
- inspector/formatting/formatting-javascript-expected.txt:
- inspector/formatting/formatting-javascript.html:
- inspector/formatting/resources/javascript-tests/import-expected.js: Added.
(async.load):
- inspector/formatting/resources/javascript-tests/import.js: Added.
(async.load):
- inspector/formatting/resources/javascript-tests/object-array-literal-expected.js:
- inspector/formatting/resources/javascript-tests/object-array-literal.js:
- inspector/formatting/resources/javascript-tests/variable-declaration-expected.js:
- inspector/formatting/resources/javascript-tests/variable-declaration.js:
- inspector/formatting/resources/utilities.js:
(TestPage.registerInitializer.):
(TestPage.registerInitializer):
Fix a bug which occurs when output is not expected one.
- inspector/model/parse-script-syntax-tree-expected.txt:
- inspector/model/parse-script-syntax-tree.html:
- 2:30 AM Changeset in webkit [211553] by
-
- 3 edits in trunk/Source/WebCore
Removed unused m_navigationStart from NavigatorGamepad
https://bugs.webkit.org/show_bug.cgi?id=167722
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-02-02
Reviewed by Yusuke Suzuki.
- Modules/gamepad/NavigatorGamepad.cpp:
(WebCore::NavigatorGamepad::NavigatorGamepad):
(WebCore::NavigatorGamepad::from):
- Modules/gamepad/NavigatorGamepad.h:
(WebCore::NavigatorGamepad::navigationStart): Deleted.
- 1:49 AM Changeset in webkit [211552] by
-
- 3 edits in trunk/Source/JavaScriptCore
Removed unused m_errorHandlingModeReentry from Interpreter
https://bugs.webkit.org/show_bug.cgi?id=167726
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-02-02
Reviewed by Yusuke Suzuki.
- interpreter/Interpreter.cpp:
(JSC::Interpreter::Interpreter):
- interpreter/Interpreter.h:
- 12:33 AM Changeset in webkit [211551] by
-
- 14 edits3 copies1 add1 delete in trunk/Source
In iOS, we should take background assertion when accessing localstorage databases.
https://bugs.webkit.org/show_bug.cgi?id=165478
Source/WebCore:
Move WebSQLiteDatabaseTrackerClient from WebKitLegacy to WebCore so that it can be accessible from
WebKit1 and WebKit2. Previously, to avoid dependencies on UIKit, WebKitLegacy introduced several
global methods for UIKit to setup the start/end background task blocks on runtime (WebKitSetStartBackgroundTaskBlock,
WebKitSetInvalidWebBackgroundTaskIdentifier and WebKitSetEndBackgroundTaskBlock). Since we have to
move the background task handling to WebCore, to avoid adding WebCore dependencies on UIKit, this
patch introdues a new WebCore class WebBackgroundTaskController which holds the start/end background
task blocks. The existing WebKitSetStartBackgroundTaskBlock and WebKitSetEndBackgroundTaskBlock methods
in WebKit1 will use WebBackgroundTaskController to store the blocks set by UIKit.
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2017-02-02
Reviewed by Brady Eidson.
No new test since this is code refactoring.
- WebCore.xcodeproj/project.pbxproj: Add a new class WebBackgroundTaskController to the project. Also move
WebSQLiteDatabaseTrackerClient from WebKitLegacy to WebCore.
- platform/ios/WebBackgroundTaskController.h: Use properties to hold the blocks for starting or ending background tasks.
- platform/ios/WebBackgroundTaskController.mm:
(+[WebBackgroundTaskController sharedController]):
(-[WebBackgroundTaskController dealloc]):
(-[WebBackgroundTaskController startBackgroundTaskWithExpirationHandler:]): Start a background task with a expiration handler;
to start the background task, we will use backgroundTaskStartBlock set up by UIKit.
(-[WebBackgroundTaskController endBackgroundTaskWithIdentifier:]): Call backgroundTaskEndBlack to end a background task.
- platform/ios/WebSQLiteDatabaseTrackerClient.h: Copied from Source/WebKit/ios/Storage/WebSQLiteDatabaseTrackerClient.h.
- platform/ios/WebSQLiteDatabaseTrackerClient.mm: Copied from Source/WebKit/ios/Storage/WebSQLiteDatabaseTrackerClient.mm.
(WebCore::WebSQLiteDatabaseTrackerClient::sharedWebSQLiteDatabaseTrackerClient): Make WebSQLiteDatabaseTrackerClient a singleton.
(WebCore::WebSQLiteDatabaseTrackerClient::WebSQLiteDatabaseTrackerClient):
(WebCore::WebSQLiteDatabaseTrackerClient::~WebSQLiteDatabaseTrackerClient):
(WebCore::WebSQLiteDatabaseTrackerClient::willBeginFirstTransaction): Use a utility class WebDatabaseTransactionBackgroundTaskController
to schedule database transaction background task.
(WebCore::WebSQLiteDatabaseTrackerClient::didFinishLastTransaction): Use WebDatabaseTransactionBackgroundTaskController to stop
databas transaction background task.
(transactionBackgroundTaskIdentifierLock: Moved from Source/WebKit/mac/Storage/WebDatabaseManager.mm.
(setTransactionBackgroundTaskIdentifier): Ditto.
(getTransactionBackgroundTaskIdentifier): Ditto.
(+[WebDatabaseTransactionBackgroundTaskController startBackgroundTask]): Ditto.
(+[WebDatabaseTransactionBackgroundTaskController endBackgroundTask]): Ditto.
Source/WebKit:
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2017-02-02
Reviewed by Brady Eidson.
- WebKit.xcodeproj/project.pbxproj: Moved WebSQLiteDatabaseTrackerClient to WebCore.
Source/WebKit/ios:
Move application background task handling code from WebKit to WebCore.
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2017-02-02
Reviewed by Brady Eidson.
- Misc/WebUIKitSupport.h: Remove several methods that only used internally for background
task handling. They are not needed in WebKit any more since background task handling
is moved to WebCore and wrapped in WebBackgroundTaskController class.
- Misc/WebUIKitSupport.mm:
(WebKitSetInvalidWebBackgroundTaskIdentifier): Instead of storing the value in a static global
variable, save it in WebBackgroundTaskController.
(WebKitSetStartBackgroundTaskBlock): Ditto.
(WebKitSetEndBackgroundTaskBlock): Ditto.
Source/WebKit/mac:
Move database transaction background task handling code from WebDatabaseManager to
WebCore's WebSQLiteDatabaseTrackerClient.
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2017-02-02
Reviewed by Brady Eidson.
- Storage/WebDatabaseManager.mm:
- Storage/WebDatabaseManagerInternal.h: Remove a category for background task handling.
- WebCoreSupport/WebApplicationCache.mm:
(+[WebApplicationCache initializeWithBundleIdentifier:]): Use WebCore::WebSQLiteDatabaseTrackerClient.
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]): Ditto.
Source/WebKit2:
Just like in WebKit1, when initializing a WKWebView, initialize the database transaction
tracker client. Also, we should set up the start and end background task blocks here. In
WebKit1, this is done inside UIKit.
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2017-02-02
Reviewed by Brady Eidson.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):
(-[WKWebView _setUpSQLiteDatabaseTrackerClient]): Set up the start/end background task blocks
and database transaction tracker client.
Feb 1, 2017:
- 10:28 PM Changeset in webkit [211550] by
-
- 12 edits2 adds in trunk
[EME] Implement MediaKeySession::update()
https://bugs.webkit.org/show_bug.cgi?id=167636
Reviewed by Xabier Rodriguez-Calvar.
Source/WebCore:
Implement the MediaKeySession::update() method by following the steps as
they are described in the specification.
In order to sanitize the passed-in response data, CDM::sanitizeResponse()
is added. It passes the SharedBuffer object by reference to the CDMPrivate
interface implementor, which returns a SharedBuffer object containing
sanitized response data.
CDMInstance::updateLicense() virtual method is added to perform the license
update for some specific CDMInstance object. After the update the CDMInstance
invokes the callback that's passed to updateLicense(), providing information
about session being closed, changed keys or expiration value, any message
that has to be enqueued, and whether the update was successful.
After that callback is invoked, MediaKeySession::update() goes on to handle
all the provided information in a future task, finally resolving the promise
(or rejecting it beforehand in case of any failure during response handling
or license update).
Three algorithms that can be invoked from MediaKeySession::update() (key
status update, expiration update and session closure) will be implemented
separately. Placeholder methods are provided until then.
MockCDM::sanitizeResponse() and MockCDMInstance::updateLicense() are
implemented for testing purposes. For now only the response sanitization
and sanitized response format are checked there. Key status update,
expiration update and session closure should be tested once the
implementations for those algorithms are added.
Test: media/encrypted-media/mock-MediaKeySession-update.html
- Modules/encryptedmedia/CDM.cpp:
(WebCore::CDM::sanitizeResponse):
- Modules/encryptedmedia/CDM.h:
- Modules/encryptedmedia/CDMInstance.h:
- Modules/encryptedmedia/CDMPrivate.h:
- Modules/encryptedmedia/MediaKeySession.cpp:
(WebCore::MediaKeySession::update):
(WebCore::MediaKeySession::updateKeyStatuses):
(WebCore::MediaKeySession::updateExpiration):
(WebCore::MediaKeySession::sessionClosed):
- Modules/encryptedmedia/MediaKeySession.h:
- testing/MockCDMFactory.cpp:
(WebCore::MockCDM::sanitizeResponse):
(WebCore::MockCDMInstance::updateLicense):
- testing/MockCDMFactory.h:
LayoutTests:
Add the mock-MediaKeySession-update.html test, cotaining a few cases that check
the basic operations of MediaKeySession::update(), focusing on proper promise
resolution and rejection based on the state of the object and the passed-in
response argument. Skip the test on all platforms for now.
- media/encrypted-media/mock-MediaKeySession-update-expected.txt: Added.
- media/encrypted-media/mock-MediaKeySession-update.html: Added.
- platform/efl/TestExpectations:
- platform/mac/TestExpectations:
- 7:10 PM Changeset in webkit [211549] by
-
- 8 edits in trunk/Tools
Make run-benchmark script supports 'config' key in test plan.
https://bugs.webkit.org/show_bug.cgi?id=167715
Reviewed by Ryosuke Niwa.
Add support for 'config' key in test paln.
'config' key is a dictionary that specifies environment configurations while test is running.
Specifies orientation to be portrait in MotionMark benchmark.
- Scripts/webkitpy/benchmark_runner/README.md:
- Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
(BenchmarkRunner.init):
(BenchmarkRunner._run_benchmark):
- Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
(BrowserDriver.prepare_env):
- Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
(LinuxBrowserDriver.prepare_env):
- Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
(OSXBrowserDriver.prepare_env):
- Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
(OSXSafariDriver.prepare_env):
- Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
- 5:57 PM Changeset in webkit [211548] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r211461.
https://bugs.webkit.org/show_bug.cgi?id=167721
Big regression on kraken (Requested by jfbastien on #webkit).
Reverted changeset:
"OSR entry: delay outer-loop compilation when at inner-loop"
https://bugs.webkit.org/show_bug.cgi?id=167149
http://trac.webkit.org/changeset/211461
- 5:54 PM Changeset in webkit [211547] by
-
- 5 edits in trunk/Source/WebKit2
Unreviewed, fix the nightly open source build.
Adds more header checks when importing from WebKitAdditions.
- UIProcess/Cocoa/WebPageProxyCocoa.mm:
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
- WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:
- 5:49 PM Changeset in webkit [211546] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fix unintended change.
- runtime/SamplingProfiler.cpp:
(JSC::SamplingProfiler::StackFrame::displayName):
- 5:48 PM Changeset in webkit [211545] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Update CARingBuffer class
https://bugs.webkit.org/show_bug.cgi?id=167656
<rdar://problem/30318329>
Unreviewed fix the 32-bit build after r211539.
- platform/audio/mac/CAAudioStreamDescription.cpp:
(WebCore::CAAudioStreamDescription::CAAudioStreamDescription):
- 5:47 PM Changeset in webkit [211544] by
-
- 2 edits in trunk/LayoutTests
Rebaseline compositing/geometry/fixed-in-composited.html for ios-simulator.
Unreviewed test gardening.
- platform/ios-simulator/compositing/geometry/fixed-in-composited-expected.txt:
- 5:41 PM Changeset in webkit [211543] by
-
- 3 edits1 add in trunk/Tools
REGRESSION (r210820): svn-create-patch does not emit property change only diff
https://bugs.webkit.org/show_bug.cgi?id=167169
Reviewed by David Kilzer.
More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
- a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
header from the output of "svn diff" on a file that was copied or moved.
Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
line followed by a separator line) with an empty body; => no chunk range lines. However a diff
of a file with only a property change also does not contain any chunk range lines. Therefore
svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
a SVN diff header with an empty body by counting the number of chunk range lines in the diff
we should directly test for the presence of a leading SVN diff header with an empty body and
remove such lines from the diff.
- Scripts/VCSUtils.pm:
(fixSVNPatchForAdditionWithHistory): Added.
- Scripts/svn-create-patch:
(generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
we have a non empty patch for an added file with history (i.e. a copied or moved file).
- Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
- 5:23 PM Changeset in webkit [211542] by
-
- 4 edits in trunk/Source/JavaScriptCore
The sampling profile should have an option to sample from C frames.
https://bugs.webkit.org/show_bug.cgi?id=167614
Reviewed by Saam Barati.
We should be able to use the sampling profiler, at least
internally, to trace C calls. This patch only modifies the JSC
shell although it would be nice to add it to the Web Inspector in
a future patch.
- runtime/Options.h:
- runtime/SamplingProfiler.cpp:
(JSC::FrameWalker::FrameWalker):
(JSC::FrameWalker::walk):
(JSC::FrameWalker::recordJSFrame):
(JSC::CFrameWalker::CFrameWalker):
(JSC::CFrameWalker::walk):
(JSC::CFrameWalker::isCFrame):
(JSC::CFrameWalker::advanceToParentFrame):
(JSC::CFrameWalker::frame):
(JSC::SamplingProfiler::takeSample):
(JSC::SamplingProfiler::processUnverifiedStackTraces):
(JSC::SamplingProfiler::StackFrame::displayName):
- runtime/SamplingProfiler.h:
(JSC::SamplingProfiler::UnprocessedStackFrame::UnprocessedStackFrame):
- 5:12 PM Changeset in webkit [211541] by
-
- 5 edits2 adds in trunk
[iOS WK2] With visual viewports, a fixed bottom bar can be clipped out when the keyboard is visible
https://bugs.webkit.org/show_bug.cgi?id=167710
rdar://problem/30100286
Reviewed by Wenson Hsieh.
Source/WebCore:
Add a bit of logging to show when RLC decides to not composite a fixed element which
is out of bounds.
Test: fast/visual-viewport/ios/bottom-bar-with-keyboard.html
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
Source/WebKit2:
The unobscuredRectInContentCoordinates passed to -didUpdateVisibleRect:... could project outside
of the bounds of the document, which is OK when rubber-banding, but not when we're in a stable state,
because that can cause fixed elements to get pushed outside the doc. This happened when the keyboard
triggered bottom content insets on the scroll view.
LayoutTests:
- fast/visual-viewport/ios/bottom-bar-with-keyboard-expected.txt: Added.
- fast/visual-viewport/ios/bottom-bar-with-keyboard.html: Added.
- 3:49 PM Changeset in webkit [211540] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Update CARingBuffer class
https://bugs.webkit.org/show_bug.cgi?id=167656
Unreviewed build fix after r211539.
- platform/audio/mac/CAAudioStreamDescription.cpp:
(WebCore::CAAudioStreamDescription::CAAudioStreamDescription): Initialize a variable to fix
release builds.
- 3:38 PM Changeset in webkit [211539] by
-
- 11 edits1 add in trunk
[Mac] Update CARingBuffer class
https://bugs.webkit.org/show_bug.cgi?id=167656
Reviewed by NOBODY (OOPS!).
Source/WebCore:
API test CARingBufferTest added.
- WebCore.xcodeproj/project.pbxproj: Add headers to framework so they can be used from the API test.
- platform/audio/AudioStreamDescription.h: Add Int32.
- platform/audio/mac/CAAudioStreamDescription.cpp:
(WebCore::CAAudioStreamDescription::CAAudioStreamDescription):
(WebCore::CAAudioStreamDescription::~CAAudioStreamDescription):
(WebCore::CAAudioStreamDescription::format): Support Int32.
(WebCore::CAAudioStreamDescription::operator==): Make inline.
- platform/audio/mac/CAAudioStreamDescription.h:
- platform/audio/mac/CARingBuffer.cpp:
(WebCore::CARingBuffer::CARingBuffer): Move initializers into class declaration.
(WebCore::CARingBuffer::allocate): Use flush method, get allocation info from a CAAudioStreamDescription.
(WebCore::FetchABL): Add a mode parameter to allow samples to replace or mix into destination.
(WebCore::CARingBuffer::flush): New.
(WebCore::CARingBuffer::fetch): Add mode parameter.
(WebCore::CARingBuffer::~CARingBuffer): Deleted.
- platform/audio/mac/CARingBuffer.h:
(WebCore::CARingBuffer::~CARingBuffer):
- platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:
(WebCore::AudioSourceProviderAVFObjC::prepare): Use new CARingBuffer constructor.
(WebCore::operator==): Deleted.
(WebCore::operator!=): Deleted.
- platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm:
(WebCore::WebAudioSourceProviderAVFObjC::prepare): Use new CARingBuffer constructor
(WebCore::operator==): Deleted.
(WebCore::operator!=): Deleted.
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
(TestWebKitAPI::CARingBufferTest::SetUp):
(TestWebKitAPI::CARingBufferTest::setup):
(TestWebKitAPI::CARingBufferTest::setListDataBuffer):
(TestWebKitAPI::CARingBufferTest::description):
(TestWebKitAPI::CARingBufferTest::bufferList):
(TestWebKitAPI::CARingBufferTest::ringBuffer):
(TestWebKitAPI::CARingBufferTest::capacity):
(TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
(TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
(TestWebKitAPI::TEST_F):
(TestWebKitAPI::MixingTest::run):
- 3:25 PM Changeset in webkit [211538] by
-
- 2 edits in trunk/Source/WebKit2
WebProcess crashes in int WTF::throw_bad_variant_access<int> when expanding/shrinking a block selection.
https://bugs.webkit.org/show_bug.cgi?id=167673
rdar://problem/30229620
Reviewed by Anders Carlsson
This is a speculative fix for a bug that might have been introduced
with http://trac.webkit.org/changeset/208479.
The code in containsRange inline fuction in WebPageIOS.mm has not been
updated when the return value of Range::compareBoundaryPoints was changed
to ExceptionOr<short>.
Since there is already a method containsRange in the Range class that
does the right thing, expandedRangeFromHandle now uses that.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::expandedRangeFromHandle):
(WebKit::containsRange): Deleted.
- 3:16 PM Changeset in webkit [211537] by
-
- 6 edits in trunk/Source
Versioning.
- 3:08 PM Changeset in webkit [211536] by
-
- 2 edits in trunk/LayoutTests
Marking compositing/repaint/fixed-background-scroll.html as flaky on macOS WK1.
https://bugs.webkit.org/show_bug.cgi?id=154612
Unreviewed test gardening.
- platform/mac-wk1/TestExpectations:
- 2:52 PM Changeset in webkit [211535] by
-
- 2 edits in trunk/Source/WebKit2
IPC::Connection receive ports should be guarded
https://bugs.webkit.org/show_bug.cgi?id=167704
Reviewed by Tim Horton.
Guarding receive rights will make sure that they won't be closed accidentally. They are created
with a context pointer and can only be unguarded or destructed with the same context pointer.
- Platform/IPC/mac/ConnectionMac.mm:
(IPC::Connection::platformInvalidate):
Use mach_port_destruct and pass the connection pointer as the context.
(IPC::Connection::platformInitialize):
Guard the server port with the connection pointer as the context.
(IPC::Connection::open):
Use mach_port_construct to create the port which lets us avoid a call to mach_port_set_attributes and setMachPortQueueLength.
Make the port guarded and use the connection pointer as the context.
(IPC::createReceiveSource):
Get rid of this and just duplicate the five lines of code in two places. For the receive port we want to use mach_port_destruct
in our cancel handler.
- 2:41 PM Changeset in webkit [211534] by
-
- 2 edits in trunk/LayoutTests
Rebaselining compositing/geometry/fixed-in-composited.html for macOS after r211523.
https://bugs.webkit.org/show_bug.cgi?id=167620
Unreviewed test gardening.
- platform/mac/compositing/geometry/fixed-in-composited-expected.txt:
- 2:41 PM Changeset in webkit [211533] by
-
- 2 edits in trunk/LayoutTests
Marking inspector/debugger/probe-manager-add-remove-actions.html as slow on macOS debug.
https://bugs.webkit.org/show_bug.cgi?id=167711
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 2:34 PM Changeset in webkit [211532] by
-
- 2 edits in trunk/LayoutTests
Marking inspector/worker/debugger-shared-breakpoint.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=167203
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 2:25 PM Changeset in webkit [211531] by
-
- 4 edits in trunk/Source/WebCore
Simple line layout: Move TextFragmentIterator::runWidth to ::textWidth.
https://bugs.webkit.org/show_bug.cgi?id=167705
<rdar://problem/30314393>
Reviewed by Antti Koivisto.
We also don't need to compute logicalHeight for logicalLeft/right since the
cases where it matters (floating boxes) are not supported by simple line layout.
Covered by existing test.
- rendering/SimpleLineLayout.cpp:
(WebCore::SimpleLineLayout::updateLineConstrains):
- rendering/SimpleLineLayoutTextFragmentIterator.cpp:
(WebCore::SimpleLineLayout::nextBreakablePositionInSegment):
(WebCore::SimpleLineLayout::TextFragmentIterator::textWidth):
(WebCore::SimpleLineLayout::TextFragmentIterator::runWidth): Deleted.
- rendering/SimpleLineLayoutTextFragmentIterator.h:
- 2:15 PM Changeset in webkit [211530] by
-
- 2 edits in trunk/Source/WebCore
Fix compilation error under recent clang update
https://bugs.webkit.org/show_bug.cgi?id=167707
Reviewed by Eric Carlson.
Include TypedArrayInlines.h to fix a "missing symbol" link error when compiling under a recent clang update.
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
- 2:13 PM Changeset in webkit [211529] by
-
- 1 edit1 move2 deletes in trunk/LayoutTests
Clean up css3/filters/backdrop/backdrop-filter-with-clip-path.html expected results.
https://trac.webkit.org/changeset/201374 added some very confused results for this test.
Just move the -expected.html next to the test, and remove the .txt and .png results.
- css3/filters/backdrop/backdrop-filter-with-clip-path-expected.html: Renamed from LayoutTests/platform/ios-simulator/css3/filters/backdrop/backdrop-filter-with-clip-path-expected.html.
- css3/filters/backdrop/backdrop-filter-with-clip-path-expected.txt: Removed.
- platform/mac/css3/filters/backdrop/backdrop-filter-with-clip-path-expected.png: Removed.
- 2:08 PM Changeset in webkit [211528] by
-
- 2 edits in trunk/Websites/bugs.webkit.org
Patch Details: EWS Bubbles wrap on Patch Details page
https://bugs.webkit.org/show_bug.cgi?id=167709
Reviewed by Ryosuke Niwa.
- template/en/default/attachment/edit.html.tmpl:
Match the iframe size in list.html.tmpl.
- 2:08 PM Changeset in webkit [211527] by
-
- 9 edits in trunk/Source/WebCore
Performance Timeline: Prepare for Worker support
https://bugs.webkit.org/show_bug.cgi?id=167633
Reviewed by Ryosuke Niwa.
Remove references to Document/Frame in Performance. Instead use
ScriptExecutionContext and pass in the time origin / SecurityOrigin
where it is relevant. No tests should change this is just refactoring.
- loader/ResourceTimingInformation.cpp:
(WebCore::ResourceTimingInformation::addResourceTiming):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::performance):
- page/Performance.cpp:
(WebCore::Performance::Performance):
(WebCore::Performance::now):
(WebCore::Performance::reduceTimeResolution):
(WebCore::Performance::navigation):
(WebCore::Performance::timing):
(WebCore::Performance::addResourceTiming):
(WebCore::Performance::scriptExecutionContext): Deleted.
- page/Performance.h:
- page/Performance.idl:
- page/PerformanceResourceTiming.cpp:
(WebCore::monotonicTimeToDOMHighResTimeStamp):
(WebCore::passesTimingAllowCheck):
(WebCore::PerformanceResourceTiming::PerformanceResourceTiming):
(WebCore::PerformanceResourceTiming::redirectStart):
(WebCore::PerformanceResourceTiming::redirectEnd):
(WebCore::PerformanceResourceTiming::fetchStart):
(WebCore::PerformanceResourceTiming::domainLookupStart):
(WebCore::PerformanceResourceTiming::domainLookupEnd):
(WebCore::PerformanceResourceTiming::connectStart):
(WebCore::PerformanceResourceTiming::connectEnd):
(WebCore::PerformanceResourceTiming::secureConnectionStart):
(WebCore::PerformanceResourceTiming::requestStart):
(WebCore::PerformanceResourceTiming::responseStart):
(WebCore::PerformanceResourceTiming::responseEnd):
(WebCore::PerformanceResourceTiming::networkLoadTimeToDOMHighResTimeStamp):
(WebCore::monotonicTimeToDocumentMilliseconds): Deleted.
(WebCore::PerformanceResourceTiming::initiatorType): Deleted.
(WebCore::PerformanceResourceTiming::resourceTimeToDocumentMilliseconds): Deleted.
- page/PerformanceResourceTiming.h:
- page/PerformanceUserTiming.cpp:
(WebCore::UserTiming::findExistingMarkStartTime):
- 2:02 PM Changeset in webkit [211526] by
-
- 2 edits in trunk/Tools
[Mac] TestWebKitAPI includes system frameworks incorrectly
https://bugs.webkit.org/show_bug.cgi?id=167703
rdar://problem/30301498
Reviewed by Ryosuke Niwa.
FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
Also, reduced the number of subframework search paths, looks like we only need one now.
- TestWebKitAPI/Configurations/Base.xcconfig:
- 1:49 PM Changeset in webkit [211525] by
-
- 5 edits in tags/Safari-603.1.23.1
Merge r211502. rdar://problem/30298722
- 1:49 PM Changeset in webkit [211524] by
-
- 5 edits in tags/Safari-603.1.23.1/Source
Versioning.
- 1:44 PM Changeset in webkit [211523] by
-
- 3 edits in trunk/LayoutTests
REGRESSION (r211379): [ios-simulator] LayoutTest compositing/geometry/fixed-in-composited.html is failing
https://bugs.webkit.org/show_bug.cgi?id=167620
rdar://problem/30309207
The body needs to be taller to allow the scrollBy() to be a stable scroll.
- compositing/geometry/fixed-in-composited.html:
- 1:26 PM Changeset in webkit [211522] by
-
- 5 edits in branches/safari-603-branch
Merge r211502. rdar://problem/30298722
- 1:26 PM Changeset in webkit [211521] by
-
- 6 edits2 adds in branches/safari-603-branch
Merge r211387. rdar://problem/29500273
- 1:26 PM Changeset in webkit [211520] by
-
- 2 edits in branches/safari-603-branch/Source/WebCore
Merge r211386. rdar://problem/30204866
- 1:26 PM Changeset in webkit [211519] by
-
- 15 edits1 copy2 adds in branches/safari-603-branch
Merge r211385. rdar://problem/29738502
- 1:26 PM Changeset in webkit [211518] by
-
- 5 edits2 adds in branches/safari-603-branch
Merge r211337. rdar://problem/30126535
- 1:26 PM Changeset in webkit [211517] by
-
- 2 edits in branches/safari-603-branch/Source/WebCore
Merge r211309. rdar://problem/30240378
- 1:26 PM Changeset in webkit [211516] by
-
- 3 edits in branches/safari-603-branch/LayoutTests
Merge r211307. rdar://problem/29320059
- 1:26 PM Changeset in webkit [211515] by
-
- 4 edits2 adds in branches/safari-603-branch
Merge r211305. rdar://problem/29320059
- 1:26 PM Changeset in webkit [211514] by
-
- 2 edits in branches/safari-603-branch/Source/JavaScriptCore
Merge r211300. rdar://problem/30135571
- 1:26 PM Changeset in webkit [211513] by
-
- 2 edits in branches/safari-603-branch/Source/WebKit2
Merge r211295. rdar://problem/30236297
- 1:26 PM Changeset in webkit [211512] by
-
- 6 edits in branches/safari-603-branch
Merge r211249. rdar://problem/29539389
- 1:26 PM Changeset in webkit [211511] by
-
- 11 edits1 add in branches/safari-603-branch
Merge r211240. rdar://problem/30247467b
- 1:26 PM Changeset in webkit [211510] by
-
- 2 edits in branches/safari-603-branch/Source/WebCore
Merge r210217. rdar://problem/30260068
- 1:26 PM Changeset in webkit [211509] by
-
- 4 edits1 add in branches/safari-603-branch
Merge r211194. rdar://problem/30201008
- 1:26 PM Changeset in webkit [211508] by
-
- 5 edits in branches/safari-603-branch/Source
Versioning.
- 1:18 PM Changeset in webkit [211507] by
-
- 1 copy in tags/Safari-604.1.6
Tag Safari-604.1.6.
- 1:06 PM Changeset in webkit [211506] by
-
- 1 copy in tags/Safari-603.1.23.1
Tag Safari-603.1.23.1.
- 12:20 PM Changeset in webkit [211505] by
-
- 1 delete in tags/Safari-604.1.6
Deleting tag.
- 12:13 PM Changeset in webkit [211504] by
-
- 6 edits2 adds in trunk
REGRESSION(r205136): {}.toString.call(crossOriginWindow) should not throw
https://bugs.webkit.org/show_bug.cgi?id=167681
<rdar://problem/30301117>
Reviewed by Mark Lam.
LayoutTests/imported/w3c:
Rebaseline W3C test now that we passing one more check. We're still failing
later because {}.toString.call(crossOriginWindow) returns "[object Window]"
instead of "[object Object]". I am planning to fix this in a follow-up.
This is not a regression since we were returning "[object Window]" before
r205136.
- web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt:
Source/WebCore:
As per https://html.spec.whatwg.org/#crossorigingetownpropertyhelper-(-o,-p-):
"""
If P is @@toStringTag, @@hasInstance, or @@isConcatSpreadable, then return
PropertyDescriptor{ Value: undefined, Writable: false, Enumerable: false, Configurable: true }.
"""
We now implement this behavior instead of throwing.
Test: http/tests/security/symbols-cross-origin.html
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess):
- bindings/js/JSLocationCustom.cpp:
(WebCore::JSLocation::getOwnPropertySlotDelegate):
LayoutTests:
Add layout test coverage.
- http/tests/security/symbols-cross-origin-expected.txt: Added.
- http/tests/security/symbols-cross-origin.html: Added.
- 12:03 PM Changeset in webkit [211503] by
-
- 2 edits in trunk/Source/WTF
Unreviewed, fix the WebKit nightly open source build
<rdar://problem/30308635>
We cannot assume all internal SDKs have the latest WebKitAdditions, so we need an explicit header check here.
- wtf/Platform.h:
- 12:00 PM Changeset in webkit [211502] by
-
- 5 edits in trunk
Correct "filesHaveSameVolume" predicate
https://bugs.webkit.org/show_bug.cgi?id=167696
<rdar://problem/30298722>
Reviewed by David Kilzer.
Source/WebCore:
We are passing %-encoded strings to the underlying operating system's file system APIs.
This doesn't work. Instead, we need to present a decoded version of the file path
that matches what the system APIs expect.
Tested by new TestWebKitAPI Test.
- platform/FileSystem.cpp:
(WebCore::filesHaveSameVolume): Make sure the file paths we give to the underlying
operating system are not percent encoded.
- platform/FileSystem.h: Export 'filesHaveSameVolume' for use by testing system.
Tools:
Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
percent-escaped path inputs.
- TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
(TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
(TestWebKitAPI::FileSystemTest::bangContainingFilePath):
(TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
(TestWebKitAPI::TEST_F):
- 11:54 AM Changeset in webkit [211501] by
-
- 8 edits in trunk
[mac-wk1] LayoutTest media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=165319
<rdar://problem/30284104>
Patch by Antoine Quint <Antoine Quint> on 2017-02-01
Reviewed by Dean Jackson.
Source/WebCore:
Running media/controls/track-menu.html before media/modern-media-controls/tracks-support/tracks-
support-click-track-in-panel.html makes that test time out in all test runs. The root of the issue
is that animations are suspended by media/controls/track-menu.html with a call to
internals.suspendAnimations(), and that state isn't reset with a call to internals.resumeAnimations().
Then, media/modern-media-controls/tracks-support/tracks-support-click-track-in-panel.html fails because
the selection animation for the tracks panel menu item that is clicked never completes and the delegate
to notify that an item in the tracks panel was selected is never fired, which leads to the test failure.
We change Internals::suspendAnimations() and Internals::resumeAnimations() to only affect the current
document, rather than calling into AnimationController::suspendAnimations() which would do just that,
but also set a Frame-wide flag that would prevent further animations from running, even in a subsequent
document load.
- dom/Document.cpp:
(WebCore::Document::prepareForDestruction): Ensure the document that is about to be destroyed is no longer
associated with an AnimationController.
- page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::ensureCompositeAnimation): Update the animation's suspend state in case
the document its renderer is associated with is suspended. This is required since previously CompositeAnimations
would set their suspend state in their constructor, based on the Frame-wide suspended state, but there is no
document to use as a basis to query its suspended state in that constructor.
(WebCore::AnimationControllerPrivate::animationsAreSuspendedForDocument):
(WebCore::AnimationControllerPrivate::detachFromDocument):
(WebCore::AnimationControllerPrivate::suspendAnimationsForDocument):
(WebCore::AnimationControllerPrivate::resumeAnimationsForDocument):
(WebCore::AnimationControllerPrivate::startAnimationsIfNotSuspended):
(WebCore::AnimationController::animationsAreSuspendedForDocument):
(WebCore::AnimationController::detachFromDocument):
- page/animation/AnimationController.h:
- page/animation/AnimationControllerPrivate.h:
- testing/Internals.cpp:
(WebCore::Internals::animationsAreSuspended):
(WebCore::Internals::suspendAnimations):
(WebCore::Internals::resumeAnimations):
LayoutTests:
Since we've fixed the root cause of this test's flakiness, we no longer need to mark it as flaky.
- platform/mac/TestExpectations:
- 11:44 AM Changeset in webkit [211500] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r211488.
- accessibility/AXObjectCache.h: Removed property svn:executable.
- 11:25 AM Changeset in webkit [211499] by
-
- 6 edits in branches/safari-604.1.5-branch/Source
Versioning.
- 10:34 AM Changeset in webkit [211498] by
-
- 2 edits in trunk/JSTests
Unreviewed, remove loop
https://bugs.webkit.org/show_bug.cgi?id=167694
It causes timeout.
Original bug can be tested even without this loop.
- stress/arity-fixup-should-not-touch-stack-area-below-sp.js:
- 10:31 AM Changeset in webkit [211497] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix.
- html/HTMLMediaElement.h: Removed property svn:executable.
- 10:22 AM Changeset in webkit [211496] by
-
- 1 copy in tags/Safari-604.1.5.2
New Tag.
- 10:22 AM Changeset in webkit [211495] by
-
- 3 edits2 adds in trunk
NULL-deref crash in TextTrack::removeCue()
https://bugs.webkit.org/show_bug.cgi?id=167615
Reviewed by Eric Carlson.
Source/WebCore:
Test: http/tests/media/track-in-band-hls-metadata-crash.html
Follow-up to r211401. When passing around a reference to an object, the assumption is that
the caller is retaining the underlying object. This breaks down for
InbandDataTextTrack::removeDataCue(), which releases its own ownership of the cue object,
then passes the reference to that object to its superclass to do further remove steps. The
retain count of the cue can thus drop to zero within the scope of
InbandTextTrack::removeCue(). Use "take" semantics to remove the cue from the
m_incompleteCueMap without releasing ownership, and pass a reference to that retained object
on to removeCue(), guaranteeing that the cue will not be destroyed until after the
romeveDataCue() method returns.
- html/track/InbandDataTextTrack.cpp:
(WebCore::InbandDataTextTrack::removeDataCue):
LayoutTests:
- http/tests/media/track-in-band-hls-metadata-crash-expected.txt: Added.
- http/tests/media/track-in-band-hls-metadata-crash.html: Added.
- 10:20 AM Changeset in webkit [211494] by
-
- 2 edits in branches/safari-604.1.5-branch/Source/WebKit/mac
Merge r211492. rdar://problem/30305390
- 10:17 AM Changeset in webkit [211493] by
-
- 6 edits in branches/safari-604.1.5-branch/Source
Versioning.
- 10:15 AM Changeset in webkit [211492] by
-
- 2 edits in trunk/Source/WebKit/mac
[WK1] Allow the drag client to be initialized on platforms that do not support drag and drop
https://bugs.webkit.org/show_bug.cgi?id=167695
<rdar://problem/30305390>
Reviewed by Sam Weinig.
Due to the common codepath for destroying the drag client, we need to ensure that the drag client actually
exists, even on platforms that do not support drag and drop, in order to avoid crashing when the DragController
is destroyed.
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):
- 10:12 AM Changeset in webkit [211491] by
-
- 3 edits2 adds in trunk
AX: Incorrect range from index and length in text controls when there are newlines
https://bugs.webkit.org/show_bug.cgi?id=167677
<rdar://problem/30300099>
Reviewed by Chris Fleizach.
Source/WebCore:
When there are newlines in text controls, the VisiblePosition that is created
from the index could be wrong. Because the index doesn't include the information
regarding a position's affinity. Fixed it by using CharacterOffset instead, since
it doesn't require that information.
Test: accessibility/mac/range-for-contenteditable-newline.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::traverseToOffsetInRange):
(WebCore::AXObjectCache::nextCharacterOffset):
(WebCore::AXObjectCache::characterOffsetForIndex):
LayoutTests:
- accessibility/mac/range-for-contenteditable-newline-expected.txt: Added.
- accessibility/mac/range-for-contenteditable-newline.html: Added.
- 10:08 AM Changeset in webkit [211490] by
-
- 1 copy in tags/Safari-604.1.6
Tag Safari-604.1.6.
- 9:54 AM Changeset in webkit [211489] by
-
- 2 edits in trunk/LayoutTests
ios-simulator TestExpectations gardening.
Unreviewed test gardening.
- platform/ios-simulator/TestExpectations:
- 9:46 AM Changeset in webkit [211488] by
-
- 2 edits in trunk/Source/WebCore
AXObjectCache is missing two functions at link time when !HAVE(ACCESSIBILITY)
https://bugs.webkit.org/show_bug.cgi?id=167691
Reviewed by Chris Fleizach.
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::recomputeDeferredIsIgnored): Added empty stub.
(WebCore::AXObjectCache::performDeferredIsIgnoredChange): Added empty stub.
- 9:37 AM Changeset in webkit [211487] by
-
- 2 edits in trunk/Source/WebCore
HTMLMediaElement.h fails to build when ENABLE(MEDIA_CONTROLS_SCRIPT) is false
https://bugs.webkit.org/show_bug.cgi?id=167689
Reviewed by Joseph Pecoraro.
- html/HTMLMediaElement.h: Move mediaControlsHost() into the ENABLE(MEDIA_CONTROLS_SCRIPT)
block that is just above it to match m_mediaControlsHost.
- 9:34 AM Changeset in webkit [211486] by
-
- 3 edits in trunk/Source/JavaScriptCore
Web Inspector: Use guaranteed RunLoop instead of RunLoop::current for dispatching inspector GC event
https://bugs.webkit.org/show_bug.cgi?id=167683
<rdar://problem/30167791>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-02-01
Reviewed by Timothy Hatcher.
- inspector/agents/InspectorHeapAgent.cpp:
(Inspector::SendGarbageCollectionEventsTask::SendGarbageCollectionEventsTask):
Use RunLoop::main instead of RunLoop::current which may go away.
- runtime/InitializeThreading.cpp:
(JSC::initializeThreading):
Ensure RunLoop::main is initialized when using JSC APIs.
- 9:33 AM Changeset in webkit [211485] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Remove keyboard shortcut to close tab - does not match expectations
https://bugs.webkit.org/show_bug.cgi?id=167672
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-02-01
Reviewed by Timothy Hatcher.
- UserInterface/Views/TabBrowser.js:
(WebInspector.TabBrowser):
- 8:17 AM Changeset in webkit [211484] by
-
- 5 edits in trunk
[Readable Streams API] Implement ReadableByteStreamController pull()
https://bugs.webkit.org/show_bug.cgi?id=167593
Patch by Romain Bellessort <romain.bellessort@crf.canon.fr> on 2017-02-01
Reviewed by Youenn Fablet.
Source/WebCore:
Implemented pull() method for ReadableByteStreamController. Also updated
pendingPullIntos attribute, which was a more complex object than necessary
(an array is enough).
Added 2 tests that allow covering most of new code. Code not yet tested will
become reachable as the rest of the spec is implemented (new tests will then
be added).
- Modules/streams/ReadableByteStreamInternals.js:
(privateInitializeReadableByteStreamController): Updated pendingPullIntos.
(readableByteStreamControllerCancel): Updated pendingPullIntos.
(readableByteStreamControllerClose): Updated pendingPullIntos.
(readableByteStreamControllerHandleQueueDrain): Added.
(readableByteStreamControllerPull): Added.
LayoutTests:
Added 2 tests that allow covering most of new code. Code not yet tested will
become reachable as the rest of the spec is implemented (new tests will then
be added).
- streams/readable-byte-stream-controller-expected.txt:
- streams/readable-byte-stream-controller.js:
- 7:28 AM Changeset in webkit [211483] by
-
- 2 edits in trunk/Tools
Unreviewed. Fix coding style in MiniBrowser
- MiniBrowser/gtk/BrowserWindow.c:
(editingCommandCallback):
(insertImageCommandCallback):
(insertLinkCommandCallback):
- 6:55 AM Changeset in webkit [211482] by
-
- 22 edits in trunk/Source
Implement the alwaysRunsAtBackgroundPriority WK2 setting using thread QoS.
<https://webkit.org/b/167387>
<rdar://problem/29711409>
Reviewed by Antti Koivisto.
Source/bmalloc:
Support changing the QoS level of the scavenger thread asynchronously through
a request variable. This is not the most elegant thing in the world, but since
threads are only allowed to change their own QoS class, our options are limited.
- bmalloc/Heap.cpp:
(bmalloc::Heap::concurrentScavenge):
- bmalloc/Heap.h:
(bmalloc::Heap::takeRequestedScavengerThreadQOSClass):
(bmalloc::Heap::setScavengerThreadQOSClass):
- bmalloc/bmalloc.h:
(bmalloc::api::setScavengerThreadQOSClass):
Source/WebKit2:
Remove the old ProcessThrottlerClient implementation of alwaysRunsAtBackgroundPriority
and replace it with WTF::setGlobalMaxQOSClass().
If the setting is enabled, it's passed over to each WK2 child process along with its
bootstrap parameter, and we notify WTF in XPCServiceInitializer(), before anything
too threading related happens.
- Platform/IPC/Connection.cpp:
(IPC::Connection::processIncomingMessage):
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:
(WebKit::XPCServiceInitializer):
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:
(WebKit::XPCServiceInitializerDelegate::getExtraInitializationData):
- UIProcess/API/APIProcessPoolConfiguration.h:
- UIProcess/ChildProcessProxy.cpp:
(WebKit::ChildProcessProxy::ChildProcessProxy):
(WebKit::ChildProcessProxy::getLaunchOptions):
- UIProcess/ChildProcessProxy.h:
- UIProcess/Databases/DatabaseProcessProxy.cpp:
(WebKit::DatabaseProcessProxy::DatabaseProcessProxy):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::NetworkProcessProxy):
(WebKit::NetworkProcessProxy::alwaysRunsAtBackgroundPriority): Deleted.
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/ProcessThrottler.cpp:
(WebKit::ProcessThrottler::assertionState):
- UIProcess/ProcessThrottlerClient.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::alwaysRunsAtBackgroundPriority): Deleted.
- UIProcess/WebProcessProxy.h:
Source/WTF:
Add a new mechanism for overriding the max thread QoS level globally:
void setGlobalMaxQOSClass(qos_class_t)
qos_class_t adjustedQOSClass(qos_class_t)
The QoS cap applies to all newly created threads, threads that try to override
their QoS class manually, and also passed down to bmalloc.
- wtf/Threading.cpp:
(WTF::setCurrentThreadIsUserInteractive):
(WTF::setCurrentThreadIsUserInitiated):
(WTF::setGlobalMaxQOSClass):
(WTF::adjustedQOSClass):
- wtf/Threading.h:
- wtf/ThreadingPthreads.cpp:
(WTF::createThreadInternal):
- wtf/cocoa/WorkQueueCocoa.cpp:
(WTF::dispatchQOSClass):
- 6:14 AM Changeset in webkit [211481] by
-
- 10 edits3 adds in trunk
[GTK] Add an API to add a custom tab into the print dialog
https://bugs.webkit.org/show_bug.cgi?id=151998
Reviewed by Carlos Garcia Campos.
Source/WebKit2:
Add a new create-custom-widget signal to the WebKitPrintOperation. The
signal is emitted before the dialog is displayed and it gives an
opportunity to embed a custom widget in the dialog. You can do so by
creating a new WebKitPrintCustomWidget and returning it from the
create-custom-widget signal handler. The WebKitPrintCustomWidget is
emitting two signals:
- update - emitted when the currently selected printer is changed,
to be able to actualize the custom widget based on the
current printer
- apply - emitted when the dialog is closed, just before the
printing will start, to be able e.g. to change content
based on the custom widget state.
- PlatformGTK.cmake:
- UIProcess/API/gtk/WebKitAutocleanups.h:
- UIProcess/API/gtk/WebKitPrintCustomWidget.cpp: Added.
(webkitPrintCustomWidgetSetProperty):
(webkit_print_custom_widget_class_init):
(webkit_print_custom_widget_new):
(webkit_print_custom_widget_get_widget):
(webkit_print_custom_widget_get_title):
(webkitPrintCustomWidgetEmitCustomWidgetApplySignal):
(webkitPrintCustomWidgetEmitUpdateCustomWidgetSignal):
- UIProcess/API/gtk/WebKitPrintCustomWidget.h: Added.
- UIProcess/API/gtk/WebKitPrintCustomWidgetPrivate.h: Added.
- UIProcess/API/gtk/WebKitPrintOperation.cpp:
(webkitPrintOperationAccumulatorObjectHandled):
(webkit_print_operation_class_init):
(notifySelectedPrinterCallback):
(webkitPrintOperationRunDialog):
- UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
- UIProcess/API/gtk/docs/webkit2gtk-4.0.types:
- UIProcess/API/gtk/docs/webkit2gtk-docs.sgml:
- UIProcess/API/gtk/webkit2.h:
Tools:
Add a new WebKitPrintOperation/custom-widget test in TestPrinting
that is testing a newly added API.
- TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
(testPrintCustomWidget):
(beforeAll):
- 5:38 AM Changeset in webkit [211480] by
-
- 9 edits in trunk/Source/WebKit2
Load resources speculatively
https://bugs.webkit.org/show_bug.cgi?id=167660
Reviewed by Andreas Kling.
- NetworkProcess/cache/NetworkCache.cpp:
(WebKit::NetworkCache::Cache::makeEntry):
Factor to a function.
(WebKit::NetworkCache::Cache::store):
- NetworkProcess/cache/NetworkCache.h:
- NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:
(WebKit::NetworkCache::SpeculativeLoad::SpeculativeLoad):
Support loads where we don't have existing cache entry to validate.
(WebKit::NetworkCache::SpeculativeLoad::didReceiveBuffer):
Synthesize a NetworkCache::Entry if we can't store it.
(WebKit::NetworkCache::SpeculativeLoad::didFinishLoading):
(WebKit::NetworkCache::SpeculativeLoad::didFailLoading):
(WebKit::NetworkCache::SpeculativeLoad::abort):
(WebKit::NetworkCache::SpeculativeLoad::didComplete):
- NetworkProcess/cache/NetworkCacheSpeculativeLoad.h:
- NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:
(WebKit::NetworkCache::constructRevalidationRequest):
Make having existing cache entry optional.
(WebKit::NetworkCache::SpeculativeLoadManager::retrieveEntryFromStorage):
Allow validation without validation headers (that is, normal load).
(WebKit::NetworkCache::SpeculativeLoadManager::revalidateSubresource):
Make having existing cache entry optional.
(WebKit::NetworkCache::canRevalidate):
Allow speculative loads without validation headers if we have high confidence that the
page is going to request this resource again. This is based on the time span we have
seen this resource being loaded on a given page and how much time has elapsed since we
last loaded it.
For example if we have seen the resource over the last 10 days we'll speculate that it will
be required for the next 5 days.
(WebKit::NetworkCache::SpeculativeLoadManager::preloadEntry):
(WebKit::NetworkCache::SpeculativeLoadManager::revalidateEntry): Deleted.
- NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.h:
- NetworkProcess/cache/NetworkCacheSubresourcesEntry.cpp:
(WebKit::NetworkCache::SubresourceInfo::encode):
(WebKit::NetworkCache::SubresourceInfo::decode):
Encode the firstSeen and lastSeen time stamps.
(WebKit::NetworkCache::SubresourceInfo::SubresourceInfo):
(WebKit::NetworkCache::makeSubresourceInfoVector):
(WebKit::NetworkCache::SubresourcesEntry::SubresourcesEntry):
(WebKit::NetworkCache::SubresourcesEntry::updateSubresourceLoads):
- NetworkProcess/cache/NetworkCacheSubresourcesEntry.h:
(WebKit::NetworkCache::SubresourceInfo::lastSeen):
(WebKit::NetworkCache::SubresourceInfo::firstSeen):
(WebKit::NetworkCache::SubresourceInfo::setNonTransient):
(WebKit::NetworkCache::SubresourceInfo::SubresourceInfo): Deleted.
(WebKit::NetworkCache::SubresourceInfo::setTransient): Deleted.
- 3:29 AM Changeset in webkit [211479] by
-
- 5 edits1 add in trunk
ArityFixup should adjust SP first
https://bugs.webkit.org/show_bug.cgi?id=167239
Reviewed by Michael Saboff.
JSTests:
Significantly large arity fixup reliably causes this crash.
- stress/arity-fixup-should-not-touch-stack-area-below-sp.js: Added.
Source/JavaScriptCore:
Arity fixup extends the stack and copy/fill the stack with
the values. At that time, we accidentally read/write stack
space below the stack pointer. As a result, we touch the area
of the stack space below the x64 red zone. These areas are unsafe.
OS may corrupt this space when constructing a signal stack.
The Linux kernel could not populate the pages for this space
and causes segmentation fault. This patch changes the stack
pointer before performing the arity fixup.
- jit/ThunkGenerators.cpp:
(JSC::arityFixupGenerator):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- 2:59 AM Changeset in webkit [211478] by
-
- 4 edits in trunk
[GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
https://bugs.webkit.org/show_bug.cgi?id=166529
Reviewed by Xabier Rodriguez-Calvar.
Source/WebCore:
- platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::AppendPipeline): Don't use the "always-honor-tfdt" property
in qtdemux anymore.
Tools:
- gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
New patch version accepted in GStreamer upstream.
- 2:58 AM Changeset in webkit [211477] by
-
- 2 edits in trunk/Tools
[GTK] Install either libxfont1-dev or libxfont-dev as dependency
https://bugs.webkit.org/show_bug.cgi?id=167498
Reviewed by Carlos Garcia Campos.
Depending on the distro version you can need either libxfont1-dev
or libfont-dev to build with jhbuild.
- gtk/install-dependencies:
- 2:46 AM Changeset in webkit [211476] by
-
- 2 edits in trunk/Source/WebKit2
[Mac][cmake] Unreviewed speculative buildfix after r211403.
https://bugs.webkit.org/show_bug.cgi?id=167601
- UIProcess/API/Cocoa/WKWebView.mm:
- 2:42 AM Changeset in webkit [211475] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, build fix for macOS and iOS ports, part 2
Annotate the function with static.
- bindings/js/ScriptModuleLoader.cpp:
(WebCore::rejectToPropagateNetworkError):
- 2:32 AM Changeset in webkit [211474] by
-
- 1 edit1 move in trunk/Source/WebCore
Unreviewed, build fix for macOS and iOS ports
- bindings/js/ModuleFetchFailureKind.h: Renamed from Source/ModuleFetchFailureKind.h.
- 2:00 AM Changeset in webkit [211473] by
-
- 9 edits6 adds in trunk
Propagate networking errors correctly for import() operator
https://bugs.webkit.org/show_bug.cgi?id=167501
Reviewed by Ryosuke Niwa.
.:
- Source/ModuleFetchFailureKind.h: Added.
Source/WebCore:
We use the promise chain inside the module loader pipeline.
The problem is that,
- The errors of loading module scripts are propagated through the promise's rejection.
- Some module related errors like syntax error (when scanning module dependencies) are reported at loading time (evaluating time). These errors are propagated through the promise rejections and dumped to the console. LoadableModuleScript set catch handler for that and print these errors to the console for ScriptElement.
- Some of errors are already reported to the console. For example, networking errors are reported by the CachedModuleLoader.
- But there is no way to distinguish between (2) and (3) at the catch handler.
Previously, we propagate the special symbol for the already reported errors to distinguish
that. This was OK because these errors cannot be catched by the user code. However,
recentimport()call needs to expose these errors to the user code. So now, accidentally,
the special purpose symbol is exposed.
Instead of propagating the special symbol, this patch just propagates the errors. But these
error objects are annotated with the private symbol. So these errors can be distinguished
from the other ones.
Currently, we do not have the way to expose the error details to the client of the
CachedScript. So we just report the error with the failed / canceled. This should be
more descriptive error messages in the separate patch[1].
[1]: https://bugs.webkit.org/show_bug.cgi?id=167553
Tests: http/tests/security/mixedContent/import-insecure-script-in-iframe.html
js/dom/modules/import-not-found-error.html
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSDOMPromise.h:
(WebCore::DeferredPromise::resolveWithCallback):
(WebCore::DeferredPromise::rejectWithCallback):
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::setupModuleScriptHandlers):
- bindings/js/ScriptController.h:
(WebCore::ScriptController::moduleLoaderAlreadyReportedErrorSymbol): Deleted.
(WebCore::ScriptController::moduleLoaderFetchingIsCanceledSymbol): Deleted.
- bindings/js/ScriptModuleLoader.cpp:
(WebCore::rejectToPropagateNetworkError):
(WebCore::ScriptModuleLoader::fetch):
(WebCore::ScriptModuleLoader::notifyFinished):
- bindings/js/WebCoreBuiltinNames.h:
LayoutTests:
- http/tests/security/mixedContent/import-insecure-script-in-iframe-expected.txt: Added.
- http/tests/security/mixedContent/import-insecure-script-in-iframe.html: Added.
- http/tests/security/mixedContent/resources/frame-with-insecure-import.html: Added.
- js/dom/modules/import-not-found-error-expected.txt: Added.
- js/dom/modules/import-not-found-error.html: Added.
