Timeline

Feb 7, 2017:

10:54 PM Changeset in webkit [211854] by Carlos Garcia Campos

• 3 edits in trunk/Source/WebCore

REGRESSION(r210740): [GTK] 2.15 broke embedded videos in GNOME's yelp app
​https://bugs.webkit.org/show_bug.cgi?id=167887

Reviewed by Michael Catanzaro.

Update the m_renderingCanBeAccelerated when accelerated rendering state changes.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::acceleratedRenderingStateChanged):
(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:

10:41 PM Changeset in webkit [211853] by Carlos Garcia Campos

• 7 edits in trunk/Source/WebCore

[GTK] Handle extended colors in cairo and texture mapper backends
​https://bugs.webkit.org/show_bug.cgi?id=167943

Reviewed by Michael Catanzaro.

Fixes: css3/color/backgrounds-and-borders.html

css3/color/box-shadows.html
css3/color/canvas.html
css3/color/composited-solid-backgrounds.html
css3/color/text.html

• platform/graphics/Color.cpp:

(WebCore::premultipliedARGBFromColor): Handle the case of color being extended.

• platform/graphics/cairo/CairoUtilities.cpp:

(WebCore::setSourceRGBAFromColor): Ditto.

• platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::fillRectWithColor): Use isVisible() instead of alpha().
(WebCore::GraphicsContext::drawEllipse): Ditto.

• platform/graphics/gtk/ColorGtk.cpp:

(WebCore::Color::operator GdkRGBA): Handle the case of color being extended.

• platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawNumber): Ditto.

• platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::blendWithOpacity): Ditto.
(WebCore::TextureMapperLayer::paintSelf): Use isVisible() instead of alpha().
(WebCore::TextureMapperLayer::computeOverlapRegions): Ditto.

5:47 PM Changeset in webkit [211852] by Wenson Hsieh

• 2 edits in trunk/Source/WebCore

WebItemProviderPasteboard should use -registerLoadHandlersToItemProvider: when creating a new UIItemProvider
​https://bugs.webkit.org/show_bug.cgi?id=167918
<rdar://problem/30382347>

Reviewed by Tim Horton.

Adopts SPI in WebItemProviderPasteboard for object types that the platform knows how to serialize. Since we use
-createObjectOfClass: to initialize data when reading off of the pasteboard, we need to match the format that
objects conforming to UIItemProviderReading will expect. Thus, for all given objects that conform to
UIItemProviderWriting, we have them register themselves to the item provider.

We register other UTI types due to the fact that PlatformPasteboardIOS does not care about the specific
pasteboard used. This should not be necessary, however, since data written to the WebItemProviderPasteboard
should never need to be read by an actual UIPasteboard. This will be refactored in a future patch to add a
special type of WebItemProviderPasteboard-aware PlatformPasteboard.

Also fixes some reference counting issues in WebItemProviderPasteboard by changing the array of _itemProviders
to be a RetainPtr.

• platform/ios/WebItemProviderPasteboard.mm:

(-[WebItemProviderPasteboard init]):
(-[WebItemProviderPasteboard pasteboardTypes]):
(-[WebItemProviderPasteboard itemProviders]):
(-[WebItemProviderPasteboard setItemProviders:]):
(-[WebItemProviderPasteboard numberOfItems]):
(-[WebItemProviderPasteboard setItems:]):
(-[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:]):
(-[WebItemProviderPasteboard itemProviderAtIndex:]):
(-[WebItemProviderPasteboard dealloc]): Deleted.

5:25 PM Changeset in webkit [211851] by Ryan Haddad

• 2 edits in trunk/Tools

Update flakiness dashboard configuration.
​https://bugs.webkit.org/show_bug.cgi?id=167957

Reviewed by Alexey Proskuryakov.

• TestResultServer/static-dashboards/builders.jsonp:

5:14 PM Changeset in webkit [211850] by matthew_hanson@apple.com

• 1 copy in tags/Safari-604.1.5.4

Tag Safari-604.1.5.4.

5:12 PM Changeset in webkit [211849] by achristensen@apple.com

• 2 edits in trunk/Source/ThirdParty/libwebrtc

Fix libwebrtcpcrtc target include path
​https://bugs.webkit.org/show_bug.cgi?id=167971

Patch by Youenn Fablet <​youenn@apple.com> on 2017-02-07
Reviewed by Alex Christensen.

• Configurations/libwebrtcpcrtc.xcconfig:

5:07 PM Changeset in webkit [211848] by achristensen@apple.com

• 3 edits
  12 deletes in trunk/Source/ThirdParty/libwebrtc

[WebRTC] usrsctp (libwebrtc third party library) is not compiling
​https://bugs.webkit.org/show_bug.cgi?id=167969

Patch by Youenn Fablet <​youenn@apple.com> on 2017-02-07
Reviewed by Alex Christensen.

Also removing .gitignore files in libwebrtc directory.

• Source/.gitignore: Removed.
• Source/third_party/boringssl/src/.gitignore: Removed.
• Source/third_party/gflags/src/.gitignore: Removed.
• Source/third_party/jsoncpp/source/.gitignore: Removed.
• Source/third_party/libyuv/.gitignore: Removed.
• Source/third_party/protobuf/.gitignore: Removed.
• Source/third_party/protobuf/csharp/.gitignore: Removed.
• Source/third_party/protobuf/ruby/.gitignore: Removed.
• Source/third_party/usrsctp/usrsctplib/.gitignore: Removed.
• Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_input.c:

(sctp_process_cookie_existing):

• Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_output.c:
• Source/tools/.gitignore: Removed.
• Source/webrtc/.gitignore: Removed.

5:04 PM Changeset in webkit [211847] by achristensen@apple.com

• 2 edits
  1 add in trunk/Source/ThirdParty/libwebrtc

Move webrtc/pc to own Xcode target
​https://bugs.webkit.org/show_bug.cgi?id=167970

Reviewed by Youenn Fablet.

It needs to include different directories than the rest of libwebrtc.
Also moved some target names so liblibsrtp.a is changed to libsrtp.a, etc.

• Configurations/libwebrtcpcrtc.xcconfig: Added.
• libwebrtc.xcodeproj/project.pbxproj:

5:04 PM Changeset in webkit [211846] by Ryan Haddad

• 2 edits in trunk/Tools

Replace a bot that has an incorrect configuration.
​https://bugs.webkit.org/show_bug.cgi?id=167747

Rubber-stamped by Alexey Proskuryakov.

• BuildSlaveSupport/build.webkit.org-config/config.json:

4:58 PM Changeset in webkit [211845] by rniwa@webkit.org

• 4 edits in trunk

WebContent process repeatedly jetsams on BuzzFeed's Another Round page
​https://bugs.webkit.org/show_bug.cgi?id=167830
<rdar://problem/30187368>

Reviewed by Simon Fraser.

Source/WebCore:

The jetsams on ​https://www.buzzfeed.com/anotherround were caused by WebKit creating the backing store
for every iframe's layer on the page regardless of whether they're in the viewport or not.

This was caused by GraphicsLayerCA's setVisibleAndCoverageRects not setting CoverageRectChanged on
m_uncommittedChanges on the very first call. Fixed the bug by initializing m_uncommittedChanges
to always have CoverageRectChanged so that the coverage rect would get updated properly.

Unfortunately, no new tests since somehow the backing store doesn't get created inside the test runner.

• platform/graphics/ca/GraphicsLayerCA.h:

(WebCore::GraphicsLayerCA):

LayoutTests:

Rebaseline the test now that some overlay repaints are avoided properly by updating the overlay coverage rects.

• platform/ios-simulator-wk2/pageoverlay/overlay-remove-reinsert-view-expected.txt:

4:47 PM Changeset in webkit [211844] by achristensen@apple.com

• 3 edits
  2 adds in trunk/Source/ThirdParty/libwebrtc

[libwebrtc] Move libsrtp and libyuv to own Xcode targets
​https://bugs.webkit.org/show_bug.cgi?id=167966

Reviewed by Youenn Fablet.

• Configurations/libsrtp.xcconfig: Added.
• Configurations/libyuv.xcconfig: Added.
• Configurations/usrsctp.xcconfig:
• libwebrtc.xcodeproj/project.pbxproj:

4:46 PM Changeset in webkit [211843] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark mathml/opentype/large-operators-displaystyle-dynamic.html as flaky on Sierra WK2 Release.
​https://bugs.webkit.org/show_bug.cgi?id=167206

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

4:21 PM Changeset in webkit [211842] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Skip http/tests/security/bypassing-cors-checks-for-extension-urls.html on ios-simulator.

Unreviewed test gardening.

• platform/ios-simulator/TestExpectations:

4:07 PM Changeset in webkit [211841] by Brent Fulgham

• 8 edits in trunk/Source/WebKit2

Correct initialization of Resource Load Statistics for use in WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=167960

Reviewed by Andy Estes.

WebKit2 starts up with different process configuration settings depending on the type of
WebView and client application. This led to two problems:

1. Registering the shared resource load observer did not start at UIProcess launch. Instead, it was lazily initialized as messages from the various WebProcess started getting received. This is too slow for WebKitTestRunner, which needs this object to be initialized right at launch time.

A new 'registerSharedResourceLoadObserver' method was needed, so that the WebProcess can ask
the WebsiteDataStore to register a resource load observer during platform initialization.

2. Some WebView uses do not enable WebsiteDataStore, and should not activate a resource load statistics observer.

• UIProcess/API/APIWebsiteDataStore.cpp:

(API::WebsiteDataStore::registerSharedResourceLoadObserver): Added.

• UIProcess/API/APIWebsiteDataStore.h:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitialize): If the web process is using a WebsiteDataStore,
register a resource load observer.

• UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver): Added.

• UIProcess/WebResourceLoadStatisticsStore.h:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::registerSharedResourceLoadObserver): Added.

• UIProcess/WebsiteData/WebsiteDataStore.h:

2:31 PM Changeset in webkit [211840] by commit-queue@webkit.org

• 6 edits
  2 adds in trunk

Web Inspector: gradient editor should allow switching the units of the 'angle' parameter
​https://bugs.webkit.org/show_bug.cgi?id=166938

Patch by Devin Rousso <Devin Rousso> on 2017-02-07
Reviewed by Brian Burg.

Source/WebInspectorUI:

• UserInterface/Test.html:

Add WebInspector.Gradient for new model object tests.

• UserInterface/Models/Gradient.js:

(WebInspector.Gradient.fromString):
(WebInspector.LinearGradient):
(WebInspector.LinearGradient.fromComponents):
(WebInspector.LinearGradient.prototype.set angleValue):
(WebInspector.LinearGradient.prototype.get angleValue):
(WebInspector.LinearGradient.prototype.set angleUnits):
(WebInspector.LinearGradient.prototype.get angleUnits):
(WebInspector.LinearGradient.prototype.copy):
(WebInspector.LinearGradient.prototype.toString):
(WebInspector.LinearGradient.prototype._angleValueForUnits):
Rework part of WebInspector.LinearGradient to support units other than "deg".

• UserInterface/Views/GradientEditor.css:

(.gradient-editor > .gradient-angle > input[type="range"]):
(.gradient-editor > .gradient-angle > input[type="number"]):

• UserInterface/Views/GradientEditor.js:

(WebInspector.GradientEditor):
(WebInspector.GradientEditor.prototype.set gradient):
(WebInspector.GradientEditor.prototype._gradientTypeChanged):
(WebInspector.GradientEditor.prototype._angleValueChanged):
(WebInspector.GradientEditor.prototype._angleUnitsChanged):
(WebInspector.GradientEditor.prototype._angleChanged): Deleted.
Add <select> for each unit type that will change the units of the gradient.

LayoutTests:

• inspector/model/gradient-expected.txt: Added.
• inspector/model/gradient.html: Added.

New tests for WebInspector.Gradient.

2:29 PM Changeset in webkit [211839] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=167275

Unreviewed test gardening.

• platform/mac/TestExpectations:

2:09 PM Changeset in webkit [211838] by andersca@apple.com

• 3 edits in trunk/Source/WebKit2

REGRESSION (r211819): [ios-simulator] API tests Coding.WKWebView and Coding.WKWebView_SameConfiguration crashing
​https://bugs.webkit.org/show_bug.cgi?id=167947

Reviewed by Tim Horton.

• Platform/spi/ios/UIKitSPI.h:

Add SPI declaration.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):
Make sure to call setDrawsBackground here.

(-[WKWebView _populateArchivedSubviews:]):
We don't want to archive the scroll view and the fixed overlay view.

(-[WKWebView setOpaque:]):
Return early if this is called before we have a page (like from -[UIView initWithCoder:]).

1:56 PM Changeset in webkit [211837] by commit-queue@webkit.org

• 13 edits
  4 adds in trunk

[WebRTC] LibWebRTCEndpoint should not own objects that should be destroyed on the main thread
​https://bugs.webkit.org/show_bug.cgi?id=167816

Patch by Youenn Fablet <​youennf@gmail.com> on 2017-02-07
Reviewed by Alex Christensen.

Source/WebCore:

Tests: webrtc/libwebrtc/release-while-creating-offer.html

webrtc/libwebrtc/release-while-getting-stats.html
webrtc/libwebrtc/release-while-setting-local-description.html

Moving AV sources, stats promises, ICE candidates from LibWebRTCEndpoint to LibWebRTCPeerConnectionBackend.
This allows ensuring these are destroyed in the main thread.

• Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::MediaEndpointPeerConnection::getStats):

• Modules/mediastream/MediaEndpointPeerConnection.h:
• Modules/mediastream/PeerConnectionBackend.h:
• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::getStats):

• Modules/mediastream/RTCPeerConnection.h:
• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::doCreateOffer):
(WebCore::LibWebRTCMediaEndpoint::doCreateAnswer):
(WebCore::LibWebRTCMediaEndpoint::getStats):
(WebCore::LibWebRTCMediaEndpoint::StatsCollector::StatsCollector):
(WebCore::LibWebRTCMediaEndpoint::StatsCollector::OnStatsDelivered):

• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:

(WebCore::LibWebRTCMediaEndpoint::addIceCandidate):
(WebCore::LibWebRTCMediaEndpoint::isStopped):

• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::LibWebRTCPeerConnectionBackend::~LibWebRTCPeerConnectionBackend):
(WebCore::LibWebRTCPeerConnectionBackend::getStats):
(WebCore::LibWebRTCPeerConnectionBackend::iceCandidateSucceeded):
(WebCore::LibWebRTCPeerConnectionBackend::iceCandidateFailed):
(WebCore::LibWebRTCPeerConnectionBackend::doSetLocalDescription):
(WebCore::LibWebRTCPeerConnectionBackend::doSetRemoteDescription):
(WebCore::LibWebRTCPeerConnectionBackend::doAddIceCandidate):
(WebCore::LibWebRTCPeerConnectionBackend::addAudioSource):
(WebCore::LibWebRTCPeerConnectionBackend::addVideoSource):

• Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
• testing/MockLibWebRTCPeerConnection.cpp:

(WebCore::MockLibWebRTCPeerConnectionReleasedInNetworkThreadWhileCreatingOffer::MockLibWebRTCPeerConnectionReleasedInNetworkThreadWhileCreatingOffer):
(WebCore::releaseInNetworkThread):
(WebCore::MockLibWebRTCPeerConnectionReleasedInNetworkThreadWhileCreatingOffer::CreateOffer):
(WebCore::MockLibWebRTCPeerConnectionReleasedInNetworkThreadWhileGettingStats::MockLibWebRTCPeerConnectionReleasedInNetworkThreadWhileGettingStats):
(WebCore::MockLibWebRTCPeerConnectionReleasedInNetworkThreadWhileGettingStats::GetStats):
(WebCore::MockLibWebRTCPeerConnectionReleasedInNetworkThreadWhileSettingDescription::MockLibWebRTCPeerConnectionReleasedInNetworkThreadWhileSettingDescription):
(WebCore::MockLibWebRTCPeerConnectionReleasedInNetworkThreadWhileSettingDescription::SetLocalDescription):
(WebCore::MockLibWebRTCPeerConnectionFactory::CreatePeerConnection):

• testing/MockLibWebRTCPeerConnection.h:

LayoutTests:

• webrtc/libwebrtc/release-while-creating-offer.html: Added.
• webrtc/libwebrtc/release-while-getting-stats.html: Added.
• webrtc/libwebrtc/release-while-setting-local-description.html: Added.

1:37 PM Changeset in webkit [211836] by mmaxfield@apple.com

• 18 edits
  2 adds in trunk

[Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
​https://bugs.webkit.org/show_bug.cgi?id=167927

Reviewed by Brent Fulgham.

Source/WebCore:

This patch simply moves some functions around to enable the Win, GTK, and EFL ports to compile the
platform-independent pieces of ComplexTextController. Those parts of ComplexTextController have
some dependencies which were previously only available on the Cocoa ports; however, those
dependencies are easily created or moved from elsewhere. The next step is to populate the
ComplexTextController::collectComplexTextRunsForCharacters() function for DirectWrite and HarfBuzz.
Once that is done, UniscribeController and HarfBuzzShaper can be deleted.

Adds ComplexTextController TestWebKitAPI tests to the Win and GTK ports.

• CMakeLists.txt: Everyone can compile the platform-independent piece of ComplexTextController.
• PlatformEfl.cmake: Add the HarfBuzz-specific piece.
• PlatformGTK.cmake: Ditto.
• PlatformWin.cmake: Add the DirectWrite-specific piece.
• platform/graphics/ComplexTextController.cpp:

(WebCore::TextLayoutDeleter::operator()): ComplexTextController shouldn't be enabled yet for Win,
GTK, or EFL.
(WebCore::FontCascade::createLayout): Ditto.
(WebCore::FontCascade::width): Ditto.
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Moved shared code to the shared
file.

• platform/graphics/Font.cpp:

(WebCore::Font::noSynthesizableFeaturesFont): Default implementation for other ports.
(WebCore::Font::variantCapsSupportsCharacterForSynthesis): Ditto.

• platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::fontForCombiningCharacterSequence): Ditto.
(WebCore::FontCascade::drawEmphasisMarksForComplexText): Ditto.
(WebCore::FontCascade::createLayout): Deleted. Moved to ComplexTextController.
(WebCore::TextLayoutDeleter::operator()): Deleted. Ditto.

• platform/graphics/FontCascade.h: fontForCombiningCharacterSequence() should exist on all ports.
• platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:

(WebCore::FontCascade::drawEmphasisMarksForComplexText): Deleted. Shared among all ports.

• platform/graphics/cocoa/FontCascadeCocoa.mm:

(WebCore::FontCascade::drawEmphasisMarksForComplexText): Deleted. Ditto.

• platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp: Added.

(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Empty implementation of
HarfBuzz-specific piece of ComplexTextController.

• platform/graphics/mac/ComplexTextControllerCoreText.mm: Moved constructors to shared file.
• platform/graphics/win/ComplexTextControllerDirectWrite.cpp: Added.

(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Empty implementation of
Direct Write-specific piece of ComplexTextController.

• platform/graphics/win/FontWin.cpp:

(WebCore::FontCascade::drawEmphasisMarksForComplexText): Deleted. Shared among all ports.

Tools:

Enable ComplexTextController API tests on the Win and GTK ports.

• TestWebKitAPI/PlatformGTK.cmake:
• TestWebKitAPI/PlatformWin.cmake:

1:29 PM Changeset in webkit [211835] by achristensen@apple.com

• 6 edits in trunk/Source

Revert r166597
​https://bugs.webkit.org/show_bug.cgi?id=167951

Reviewed by Andreas Kling.

Source/WebCore:

• platform/spi/cf/CFNetworkSPI.h:

Remove now-unused SPI declaration.

Source/WebKit2:

CFURLConnectionInvalidateConnectionCache is not commonly called and is likely causing
CFNetwork to be in a strange state when using NSURLSession and invalidating the connection
cache during authentication, especially server trust evaluation. Right now we only call
it when handling memory pressure, and it isn't worth getting into such a strange state
in a poorly tested situation. See rdar://problem/27439617

• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::lowMemoryHandler):
(WebKit::NetworkProcess::initializeSandbox):
(WebKit::NetworkProcess::platformLowMemoryHandler): Deleted.

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformLowMemoryHandler): Deleted.

1:22 PM Changeset in webkit [211834] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

SigillCrashAnalyzer::analyze() should use a do-while loop instead of a lambda.
​https://bugs.webkit.org/show_bug.cgi?id=167950

Reviewed by Michael Saboff.

Lambdas aren't free (apparently, the compiler isn't able to detect that the
lambda does not escape and can be inlined completely). So, use a do-while loop
instead since we don't really need a lambda here.

• tools/SigillCrashAnalyzer.cpp:

1:02 PM Changeset in webkit [211833] by Jonathan Bedard

• 3 edits in trunk/Tools

File index appended to previous file in svn-create-patch with SVN 1.9
​https://bugs.webkit.org/show_bug.cgi?id=167903
<rdar://problem/30387395>

Reviewed by Daniel Bates.

• Scripts/VCSUtils.pm:

(fixSVNPatchForAdditionWithHistory): Append a trailing newline character.

• Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove

trailing newline character from the expected result before comparing it to the actual result.

12:56 PM Changeset in webkit [211832] by weinig@apple.com

• 2 edits in trunk/Source/WebCore

Try to fix the windows build.

• bindings/js/ReadableStreamDefaultController.cpp:

12:44 PM Changeset in webkit [211831] by BJ Burg

• 2 edits in trunk/Source/WebKit2

[Mac] Web Automation: NSEventType not initialized in WebAutomationSession::platformSimulateMouseInteraction
​https://bugs.webkit.org/show_bug.cgi?id=167902

Reviewed by Joseph Pecoraro.

• UIProcess/Automation/mac/WebAutomationSessionMac.mm:

(WebKit::WebAutomationSession::platformSimulateMouseInteraction):
Initialize these to 0, which is not a valid NSEventType. Assert that
each NSEventType has a valid value before attempting to use it.

12:19 PM Changeset in webkit [211830] by commit-queue@webkit.org

• 10 edits
  3 adds in trunk

[WebRTC] LibWebRTC WK2 network stack is not providing correct ports for ICE candidates
​https://bugs.webkit.org/show_bug.cgi?id=167939

Patch by Youenn Fablet <​youennf@gmail.com> on 2017-02-07
Reviewed by Sam Weinig.

Source/WebCore:

Test: webrtc/no-port-zero-in-upd-candidates.html

• testing/MockLibWebRTCPeerConnection.cpp:

(WebCore::MockLibWebRTCPeerConnectionFactory::MockLibWebRTCPeerConnectionFactory): Adding a way to create one real PC in WTR environment.

Source/WebKit2:

AddressReady signalling was done by the WebProcess for UDP and ServerTCP as real async sockets in those case do
not send it. But the WebProcess does not have information on the port, as it is assigned by the socket factory
which is in the network process.

Fixed that bug by signalling AddressReady in the network process for UDP, ServerTCP and ClientTCP.

• NetworkProcess/webrtc/LibWebRTCSocketClient.cpp:

(WebKit::LibWebRTCSocketClient::LibWebRTCSocketClient):
(WebKit::LibWebRTCSocketClient::signalAddressReady):

• NetworkProcess/webrtc/LibWebRTCSocketClient.h:
• NetworkProcess/webrtc/NetworkRTCProvider.cpp:

(WebKit::NetworkRTCProvider::createUDPSocket):
(WebKit::NetworkRTCProvider::createServerTCPSocket):
(WebKit::NetworkRTCProvider::createClientTCPSocket):

• WebProcess/Network/webrtc/LibWebRTCSocket.cpp:

(WebKit::LibWebRTCSocket::LibWebRTCSocket):
(WebKit::LibWebRTCSocket::signalAddressReady):

LayoutTests:

• webrtc/no-port-zero-in-upd-candidates.html: Added.
• webrtc/no-port-zero-in-upd-candidates-expected.txt: Added.
• webrtc/video.html:
• webrtc/video-expected.txt: Added.

12:09 PM Changeset in webkit [211829] by Matt Baker

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: DOMTreeOutline becomes collapsed after switching back to Elements tab
​https://bugs.webkit.org/show_bug.cgi?id=167924

Reviewed by Brian Burg.

• UserInterface/Views/DOMTreeOutline.js:

(WebInspector.DOMTreeOutline.prototype.update):
Drive-by fix: move variable initialization below the early return.

• UserInterface/Views/ElementsTabContentView.js:

(WebInspector.ElementsTabContentView.prototype.shown): Deleted.
Calling this._showDOMTreeContentView isn't necessary. The base class
implementation will call shown on the content view.

12:01 PM Changeset in webkit [211828] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

The SigillCrashAnalyzer should play nicer with client code that may install its own SIGILL handler.
​https://bugs.webkit.org/show_bug.cgi?id=167858

Reviewed by Michael Saboff.

Here are the scenarios that may come up:

1. Client code did not install a SIGILL handler.
   • In this case, once we're done analyzing the SIGILL, we can just restore the default handler and return to let the OS do the default action i.e. capture a core dump.

2. Client code installed a SIGILL handler before JSC does.
   • In this case, we will see a non-null handler returned as the old signal handler when we install ours.
   • In our signal handler, after doing our crash analysis, we should invoke the client handler to let it do its work.
   • Our analyzer can also tell us if the SIGILL source is from JSC code in general (right now, this would just mean JIT code).
   • If the SIGILL source is not from JSC, we'll just let the client handler decided how to proceed. We assume that the client handler will do the right thing (which is how the old behavior is before the SigillCrashAnalyzer was introduced).
   • If the SIGILL source is from JSC, then we know the SIGILL is an unrecoverable condition. Hence, after we have given the client handler a chance to run, we should restore the default handler and let the OS capture a core dump. This intentionally overrides whatever signal settings the client handler may have set.

3. Client code installed a SIGILL handler after JSC does.
   • In this case, we are dependent on the client handler to call our handler after it does its work. This is compatible with the old behavior before SigillCrashAnalyzer was introduced.
   • In our signal handler, if we determine that the SIGILL source is from JSC code, then the SIGILL is not recoverable. We should then restore the default handler and get a core dump.
   • If the SIGILL source is not from JSC, we check to see if there's a client handler installed after us.
   • If we detect a client handler installed after us, we defer judgement on what to do to the client handler. Since the client handler did not uninstall itself, it must have considered itself to have recovered from the SIGILL. We'll trust the client handler and take no restore action of our own (which is compatible with old code behavior).
   • If we detect no client handler and we have no previous handler, then we should restore the default handler and get a core dump.

• tools/SigillCrashAnalyzer.cpp:

(JSC::handleCrash):
(JSC::installCrashHandler):
(JSC::SigillCrashAnalyzer::analyze): Deleted.

11:51 AM Changeset in webkit [211827] by achristensen@apple.com

• 2 edits in trunk/Source/ThirdParty/libwebrtc

Fix libwebrtc build after r211817
​https://bugs.webkit.org/show_bug.cgi?id=167944

• Configurations/usrsctp.xcconfig:

Disable more warnings.

11:49 AM Changeset in webkit [211826] by weinig@apple.com

• 3 edits in trunk/Source/WebCore

Update bindings tests results for additional include.

• bindings/scripts/test/JS/JSTestObj.cpp:
• bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

11:47 AM Changeset in webkit [211825] by weinig@apple.com

• 2 edits in trunk/Source/WebCore

Try to fix the windows build.

• bindings/js/JSDOMConvertNumbers.h:

11:44 AM Changeset in webkit [211824] by weinig@apple.com

• 2 edits in trunk/Source/WebKit2

Try to fix the EFL build.

• WebProcess/InjectedBundle/InjectedBundle.cpp:

11:34 AM Changeset in webkit [211823] by achristensen@apple.com

• 6 edits in trunk/Source/WebCore

Fix libwebrtc build after r211728
​https://bugs.webkit.org/show_bug.cgi?id=167821

• platform/mediastream/mac/RealtimeIncomingVideoSource.cpp:

(WebCore::RealtimeIncomingVideoSource::processNewSample):

• platform/mediastream/mac/RealtimeOutgoingAudioSource.cpp:

(WebCore::RealtimeOutgoingAudioSource::audioSamplesAvailable):
(WebCore::RealtimeOutgoingAudioSource::sourceHasMoreMediaData): Deleted.

• platform/mediastream/mac/RealtimeOutgoingAudioSource.h:
• platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:

(WebCore::RealtimeOutgoingVideoSource::RealtimeOutgoingVideoSource):
(WebCore::RealtimeOutgoingVideoSource::videoSampleAvailable):
(WebCore::RealtimeOutgoingVideoSource::sourceHasMoreMediaData): Deleted.

• platform/mediastream/mac/RealtimeOutgoingVideoSource.h:

11:15 AM Changeset in webkit [211822] by timothy_horton@apple.com

• 1 edit
  1 delete in trunk/Source/WebCore

Remove accidentally-added (in r211409) patch reject file

• bindings/scripts/test/JS/JSTestSerialization.cpp.rej: Removed.

10:55 AM Changeset in webkit [211821] by weinig@apple.com

• 17 edits
  27 copies in trunk/Source/WebCore

JSDOMConvert is too big. Split it up!
​https://bugs.webkit.org/show_bug.cgi?id=167806

Rubber-stamped by Geoff Garen.

Split JSDOMConvert up roughly by IDL type. Some are grouped for convenience, e.g. all the
string types are together, all the numeric types are together. Also moved helpers from
JSDOMBinding to their respective JSDOMConvertFoo header. For now, JSDOMConvert.h as an
umbrella of all the sub headers, but it will be removed, and the code generator taught
to include the right header in a subsequent patch.

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:

Add new files.

• bindings/js/IDBBindingUtilities.cpp:
• bindings/js/IDBBindingUtilities.h:

Remove toJS that takes a std::optional<IDBKeyPath>, it was unused, and update date code
to only call valueToDate once, and pass things by reference.

• bindings/js/JSDOMBinding.cpp:
• bindings/js/JSDOMBinding.h:

Move most of the conversion helpers into their respective JSDOMConvertFoo header.

• bindings/js/JSDOMConvert.h:

Leave for now, just has includes of all the broken out headers.

• bindings/js/JSDOMConvertAny.h: Copied from Source/WebCore/bindings/js/JSDOMConvert.h.
• bindings/js/JSDOMConvertBase.h: Copied from Source/WebCore/bindings/js/JSDOMConvert.h.
• bindings/js/JSDOMConvertBoolean.h: Copied from Source/WebCore/bindings/js/JSDOMConvert.h.
• bindings/js/JSDOMConvertBufferSource.h: Copied from Source/WebCore/bindings/js/JSDOMConvert.h.
• bindings/js/JSDOMConvertCallbacks.h: Copied from Source/WebCore/bindings/js/JSDOMConvert.h.
• bindings/js/JSDOMConvertDate.cpp: Copied from Source/WebCore/bindings/js/JSDOMBinding.cpp.
• bindings/js/JSDOMConvertDate.h: Copied from Source/WebCore/bindings/js/JSDOMConvert.h.
• bindings/js/JSDOMConvertDictionary.h: Copied from Source/WebCore/bindings/js/JSDOMConvert.h.
• bindings/js/JSDOMConvertEnumeration.h: Copied from Source/WebCore/bindings/js/JSDOMConvert.h.
• bindings/js/JSDOMConvertEventListener.h: Copied from Source/WebCore/bindings/js/JSDOMConvert.h.
• bindings/js/JSDOMConvertIndexedDB.h: Copied from Source/WebCore/bindings/js/JSDOMConvert.h.
• bindings/js/JSDOMConvertInterface.h: Copied from Source/WebCore/bindings/js/JSDOMConvert.h.
• bindings/js/JSDOMConvertJSON.h: Copied from Source/WebCore/bindings/js/JSDOMConvert.h.
• bindings/js/JSDOMConvertNull.h: Copied from Source/WebCore/bindings/js/JSDOMConvert.h.
• bindings/js/JSDOMConvertNullable.h: Copied from Source/WebCore/bindings/js/JSDOMConvert.h.
• bindings/js/JSDOMConvertNumbers.cpp: Copied from Source/WebCore/bindings/js/JSDOMBinding.cpp.
• bindings/js/JSDOMConvertNumbers.h: Copied from Source/WebCore/bindings/js/JSDOMConvert.h.
• bindings/js/JSDOMConvertObject.h: Copied from Source/WebCore/bindings/js/JSDOMConvert.h.
• bindings/js/JSDOMConvertRecord.h: Copied from Source/WebCore/bindings/js/JSDOMConvert.h.
• bindings/js/JSDOMConvertSequences.h: Copied from Source/WebCore/bindings/js/JSDOMConvert.h.
• bindings/js/JSDOMConvertSerializedScriptValue.h: Copied from Source/WebCore/bindings/js/JSDOMConvert.h.
• bindings/js/JSDOMConvertStrings.cpp: Copied from Source/WebCore/bindings/js/JSDOMBinding.cpp.
• bindings/js/JSDOMConvertStrings.h: Copied from Source/WebCore/bindings/js/JSDOMConvert.h.
• bindings/js/JSDOMConvertUnion.h: Copied from Source/WebCore/bindings/js/JSDOMConvert.h.
• bindings/js/JSDOMConvertVariadic.h: Copied from Source/WebCore/bindings/js/JSDOMConvert.h.
• bindings/js/JSDOMConvertWebGL.h: Copied from Source/WebCore/bindings/js/JSDOMConvert.h.
• bindings/js/JSDOMConvertXPathNSResolver.h: Copied from Source/WebCore/bindings/js/JSDOMConvert.h.

• bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheck):
Add include of JSDOMConvertVariadic.h rather than JSDOMConvert.

• bindings/js/JSCryptoCustom.cpp:
• bindings/js/JSCryptoOperationData.cpp:
• bindings/js/JSImageDataCustom.cpp:
• bindings/js/ReadableStreamDefaultController.h:
• bindings/js/WebCoreTypedArrayController.cpp:
• html/canvas/WebGLAny.cpp:
• platform/mac/SerializedPlatformRepresentationMac.mm:

Add includes for specific JSDOMConvert header now that helpers have
been moved their from JSDOMBinding.h

10:53 AM Changeset in webkit [211820] by weinig@apple.com

• 2 edits in trunk/Source/WebCore

Remove unnecessary exports on inline functions. They were causing build failures
with some compilers.

• Modules/mediasource/SampleMap.h:

(WebCore::PresentationOrderSampleMap::begin):
(WebCore::PresentationOrderSampleMap::end):
(WebCore::PresentationOrderSampleMap::rbegin):
(WebCore::PresentationOrderSampleMap::rend):
(WebCore::DecodeOrderSampleMap::begin):
(WebCore::DecodeOrderSampleMap::end):
(WebCore::DecodeOrderSampleMap::rbegin):
(WebCore::DecodeOrderSampleMap::rend):
(WebCore::SampleMap::sizeInBytes):
(WebCore::SampleMap::decodeOrder):
(WebCore::SampleMap::presentationOrder):
(WebCore::SampleMap::addRange):
(WebCore::SampleMap::SampleMap): Deleted.

10:42 AM Changeset in webkit [211819] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

-[WKWebView encodeWithCoder:] needs to call super
​https://bugs.webkit.org/show_bug.cgi?id=167945
rdar://problem/29777668

Reviewed by Geoffrey Garen.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView encodeWithCoder:]):
Call super.

10:24 AM Changeset in webkit [211818] by Yusuke Suzuki

• 8 edits
  1 delete in trunk

Unreviewed, manual roll out of r211777
​https://bugs.webkit.org/show_bug.cgi?id=167457

Source/JavaScriptCore:

• jsc.cpp:

(GlobalObject::moduleLoaderImportModule):

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncImportModule):

Source/WebCore:

• bindings/js/ScriptModuleLoader.cpp:

(WebCore::ScriptModuleLoader::importModule):

LayoutTests:

Later, I'll reland it with the deterministic tests.

• inspector/controller/resources/cappuccino.js: Removed.
• inspector/controller/resources/cocoa.js: Removed.
• inspector/controller/resources/drink.js: Removed.
• inspector/controller/runtime-controller-expected.txt:
• inspector/controller/runtime-controller.html:

10:24 AM Changeset in webkit [211817] by achristensen@apple.com

• 5 edits in trunk/Source/ThirdParty/libwebrtc

build usrsctp with Xcode
​https://bugs.webkit.org/show_bug.cgi?id=167944

Reviewed by Youenn Fablet.

• Configurations/usrsctp.xcconfig:
• Source/third_party/usrsctp/usrsctplib/usrsctplib/netinet/sctp_pcb.c:
• Source/third_party/usrsctp/usrsctplib/usrsctplib/user_atomic.h:
• libwebrtc.xcodeproj/project.pbxproj:

10:08 AM Changeset in webkit [211816] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit2

[Soup] WebKitSoupRequestInputStream can still leave requests unfinished after r211773
​https://bugs.webkit.org/show_bug.cgi?id=167929

Reviewed by Michael Catanzaro.

The while loop to process the pending data requests was not a good idea, because having a new pending request
doesn't mean we have more data available, but that more data was requested.

• WebProcess/soup/WebKitSoupRequestInputStream.cpp:

(webkitSoupRequestInputStreamPendingReadAsyncComplete): Process only one request if needed.

10:04 AM Changeset in webkit [211815] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

[GStreamer] Deadlock when media player is destroyed
​https://bugs.webkit.org/show_bug.cgi?id=167861

Reviewed by Michael Catanzaro.

The problem is that we are calling notifyOne() for the draw mutex without taking the lock.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::repaint):

9:59 AM Changeset in webkit [211814] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

MediaSourceClientGStreamerMSE: wrap FastMalloc-ed memory into pipeline-bound GstBuffers
​https://bugs.webkit.org/show_bug.cgi?id=167928

Reviewed by Xabier Rodriguez-Calvar.

The buffers created in MediaSourceClientGStreamerMSE can be large enough in size
that repetitive allocations can cause larger heap fragmentation in different libc
allocators. To avoid that occurrence, we should simply use FastMalloc to allocate
memory for these buffers.

• platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp:

(WebCore::MediaSourceClientGStreamerMSE::append):

9:38 AM WebKitGTK/2.14.x edited by Michael Catanzaro

(diff)

9:36 AM WebKitGTK/2.14.x edited by Michael Catanzaro

Propose more merges… (diff)

9:20 AM Changeset in webkit [211813] by commit-queue@webkit.org

• 3 edits in trunk

[GTK][Efl] Do not require LibXslt if XSLT is disabled
​https://bugs.webkit.org/show_bug.cgi?id=167931

This fixes build with --no-xslt, when the libxslt dev files are not installed.

Patch by Olivier Blin <Olivier Blin> on 2017-02-07
Reviewed by Michael Catanzaro.

• Source/cmake/OptionsEfl.cmake:
• Source/cmake/OptionsGTK.cmake:

8:59 AM Changeset in webkit [211812] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[webkitdirs] remove unused host_processor variable in determineArchitecture()
​https://bugs.webkit.org/show_bug.cgi?id=167936

Patch by Olivier Blin <Olivier Blin> on 2017-02-07
Reviewed by Michael Catanzaro.

• Scripts/webkitdirs.pm:

(determineArchitecture):
The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
since r195083.

8:14 AM Changeset in webkit [211811] by commit-queue@webkit.org

• 5 edits
  1 add
  1 delete in trunk

Use a JSON file to define which WPT files/folders to import
​https://bugs.webkit.org/show_bug.cgi?id=167923

Patch by Youenn Fablet <​youenn@apple.com> on 2017-02-07
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• resources/ImportExpectations: Removed.
• resources/import-expectations.json: Added.

Tools:

• Scripts/webkitpy/w3c/test_downloader.py:

(TestDownloader.init):
(TestDownloader._init_paths_from_expectations):

• Scripts/webkitpy/w3c/test_importer.py:

(parse_args):

• Scripts/webkitpy/w3c/test_importer_unittest.py:

6:50 AM Changeset in webkit [211810] by matthew_hanson@apple.com

• 2 edits in branches/safari-604.1.5-branch/Source/WebKit2

Merge r211752. rdar://problem/30119091

6:50 AM Changeset in webkit [211809] by matthew_hanson@apple.com

• 3 edits
  2 adds in branches/safari-604.1.5-branch

Merge r211659. rdar://problem/30386165

6:49 AM Changeset in webkit [211808] by matthew_hanson@apple.com

• 2 edits in branches/safari-604.1.5-branch/Source/JavaScriptCore

Merge r211630. rdar://problem/30357032

6:30 AM Changeset in webkit [211807] by commit-queue@webkit.org

• 7 edits
  4 copies
  1 move
  6 adds
  3 deletes in trunk

[Modern Media Controls] Handle media durations of an hour or more gracefully
​https://bugs.webkit.org/show_bug.cgi?id=167882
<rdar://problem/29601260>

Patch by Antoine Quint <Antoine Quint> on 2017-02-07
Reviewed by Eric Carlson.

Source/WebCore:

We add a new "labelsMayDisplayTimesOverAnHour" to TimeControl so that time labels
to the left and right of the scrubber may have extra room to display to account for
the extra "xx:" characters that may appear. We don't lay the time out dynamically
such that we don't see layout jumps as the times shown in the labels go around
the hour mark.

We also refactor the ElapsedTimeSupport and RemainingTimeSupport in a single
TimeLabelsSupport class which updates both elapsed and remaining time labels
and sets the "labelsMayDisplayTimesOverAnHour" on the TimeControl should a
"durationchange" happen to make the media duration reach or go past the hour mark.

Tests: http/tests/media/modern-media-controls/time-labels-support/long-time.html

media/modern-media-controls/time-control/time-control-labels-may-display-times-over-an-hour.html
media/modern-media-controls/time-labels-support/elapsed-time.html
media/modern-media-controls/time-labels-support/remaining-time.html

• Modules/modern-media-controls/controls/time-control.js:

(TimeControl.prototype.get labelsMayDisplayTimesOverAnHour):
(TimeControl.prototype.set labelsMayDisplayTimesOverAnHour):
(TimeControl.prototype.set width):

• Modules/modern-media-controls/controls/time-label.css:

(.time-label):

• Modules/modern-media-controls/js-files:
• Modules/modern-media-controls/media/elapsed-time-support.js: Removed.
• Modules/modern-media-controls/media/media-controller.js:

(MediaController.prototype._updateControlsIfNeeded):

• Modules/modern-media-controls/media/time-labels-support.js: Renamed from Source/WebCore/Modules/modern-media-controls/media/remaining-time-support.js.

(TimeLabelsSupport.prototype.get control):
(TimeLabelsSupport.prototype.syncControl):
(TimeLabelsSupport):

• WebCore.xcodeproj/project.pbxproj:

LayoutTests:

Add new tests to check that we correctly handle times at or past the hour mark.

• http/tests/media/modern-media-controls/time-labels-support/long-time-expected.txt: Added.
• http/tests/media/modern-media-controls/time-labels-support/long-time.html: Added.
• media/modern-media-controls/time-control/time-control-labels-may-display-times-over-an-hour-expected.txt: Added.
• media/modern-media-controls/time-control/time-control-labels-may-display-times-over-an-hour.html: Added.
• media/modern-media-controls/time-labels-support/elapsed-time-expected.txt: Renamed from LayoutTests/media/modern-media-controls/elapsed-time-support/elapsed-time-support-expected.txt.
• media/modern-media-controls/time-labels-support/elapsed-time.html: Renamed from LayoutTests/media/modern-media-controls/elapsed-time-support/elapsed-time-support.html.
• media/modern-media-controls/time-labels-support/remaining-time-expected.txt: Renamed from LayoutTests/media/modern-media-controls/remaining-time-support/remaining-time-support-expected.txt.
• media/modern-media-controls/time-labels-support/remaining-time.html: Renamed from LayoutTests/media/modern-media-controls/remaining-time-support/remaining-time-support.html.

6:07 AM Changeset in webkit [211806] by commit-queue@webkit.org

• 3 edits in trunk/LayoutTests

LayoutTet media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=167275

Patch by Antoine Quint <Antoine Quint> on 2017-02-07
Reviewed by Eric Carlson.

After bringing fullscreen controls up to spec as part of ​https://bugs.webkit.org/show_bug.cgi?id=167875,
we need to initiate dragging on an area that is not covered by controls, so we shift further right to
initiate dragging.

• media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html:
• platform/mac/TestExpectations:

5:46 AM Changeset in webkit [211805] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

LayoutTest media/modern-media-controls/layout-node/addChild.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=167461

Unreviewed test gardening, this test is no longer flaky.

Patch by Antoine Quint <Antoine Quint> on 2017-02-07

• platform/mac/TestExpectations:

5:22 AM Changeset in webkit [211804] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[mac-wk1] LayoutTest media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-buttons-styles.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=163598

Unreviewed test gardening, this test is no longer flaky.

Patch by Antoine Quint <Antoine Quint> on 2017-02-07

• platform/mac-wk1/TestExpectations:

5:09 AM Changeset in webkit [211803] by pvollan@apple.com

• 5 edits in trunk/Source/WebCore

Read stroke width of subtitles from MediaAccessibility framework.
​https://bugs.webkit.org/show_bug.cgi?id=167871
<rdar://problem/29265906>

Reviewed by Brent Fulgham.

Read MACaptionFontAttributeStrokeWidth from CTFontDescriptorRef.

• page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::strokeWidth):
(WebCore::CaptionUserPreferencesMediaAF::captionsTextEdgeCSS):

• page/CaptionUserPreferencesMediaAF.h:
• platform/cf/MediaAccessibilitySoftLink.cpp:
• platform/cf/MediaAccessibilitySoftLink.h:

2:53 AM Changeset in webkit [211802] by commit-queue@webkit.org

• 11 edits
  2 adds in trunk

[Modern Media Controls] Improve handling of <video> with only audio tracks
​https://bugs.webkit.org/show_bug.cgi?id=167836
<rdar://problem/30255812>

Patch by Antoine Quint <Antoine Quint> on 2017-02-07
Reviewed by Dean Jackson.

Source/WebCore:

We now check for the availability of video tracks before considering a <video>
element is displaying an actual video file and turning auto-hide on. We also
check that we have video tracks before enabling the fullscreen button. This
brings the behavior of a <video> pointing to a resource with no video tracks
to be the same as an <audio> element.

Test: media/modern-media-controls/media-controller/media-controller-video-with-only-audio.html

• Modules/modern-media-controls/media/controls-visibility-support.js:

(ControlsVisibilitySupport.prototype.get tracksToMonitor):
(ControlsVisibilitySupport.prototype._updateControls):
(ControlsVisibilitySupport):

• Modules/modern-media-controls/media/fullscreen-support.js:

(FullscreenSupport.prototype.syncControl):
(FullscreenSupport):

LayoutTests:

Add a new test to check that a <video> with a resource that only has audio tracks
does not auto-hide nor show the fullscreen button. We also rebaseline a few existing
tests for this change of behavior.

• fast/regions/inline-block-inside-anonymous-overflow-with-covered-controls-expected.html:
• fast/regions/inline-block-inside-anonymous-overflow-with-covered-controls.html:
• media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-on-expected.txt:
• media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-on.html:
• media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-toggle-expected.txt:
• media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-toggle.html:
• media/modern-media-controls/media-controller/media-controller-video-with-only-audio-expected.txt: Added.
• media/modern-media-controls/media-controller/media-controller-video-with-only-audio.html: Added.
• media/modern-media-controls/time-label/time-label-white-space-nowrap.html:

2:01 AM WebKitGTK/2.14.x edited by Carlos Garcia Campos

(diff)

1:51 AM Changeset in webkit [211801] by Carlos Garcia Campos

• 6 edits
  2 adds in releases/WebKitGTK/webkit-2.14

Merge r211775 - Overlay scrolling with iframe-s broken
​https://bugs.webkit.org/show_bug.cgi?id=165056

Reviewed by Antonio Gomes.

Source/WebCore:

Mouse press events for overlay scrollbars are ignored if there's a subframe under the scrollbar. This doesn't
happen with normal scrollbars, because the subframe is not really under the scrollbar, so events are always
correctly passed to the scrollbar. With overlay scrollbars, the hit test detects the scrollbar, but events are
always passed first to the subframe. Scrollbars are correctly updated on hover though, because
handleMouseMoveEvent checks the presence of scrollbars before checking for subframes and move events are
actually passed to both, the scrollbar and the subframe. Overlay scrollbars should always take precedence over
subframes to handle mouse press events, so we should check first if mouse is over a scrollbar and never pass the
event to a subframe in that case. Another problem is that the cursor is not updated either when the overlay
scrollbar is hovered and there's a subframe. This is because in handleMouseMoveEvent we pass the event to both
the scrollbar and subframe but we never update the cursor when a suframe was found. So, here again we need to make
an exception for scrollbars and upate the cursor when mouse is over the scrollbar even if a subframe was found.

Test: fast/scrolling/scroll-animator-overlay-scrollbars-clicked.html

• page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent): Move the scrollbar check before the subframe check.
(WebCore::EventHandler::handleMouseMoveEvent): Update the cursor when hovering a scrollbar even if a subframe
was found.
(WebCore::EventHandler::updateLastScrollbarUnderMouse): Use an enum instead of a boolean for setLast parameter.

• page/EventHandler.h:

LayoutTests:

Add a new test to check that clicking on an overlay scrollbar works even it's over a subframe.

• fast/scrolling/scroll-animator-overlay-scrollbars-clicked-expected.txt: Added.
• fast/scrolling/scroll-animator-overlay-scrollbars-clicked.html: Added.
• platform/ios-simulator/TestExpectations:
• platform/mac-wk1/TestExpectations:

1:39 AM Changeset in webkit [211800] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.14/Source/WebKit2

Merge r211366 - Unreviewed. Fix GTK+ debug build after r211365.

Remove invalid assert.

• WebProcess/WebPage/AcceleratedDrawingArea.cpp:

(WebKit::AcceleratedDrawingArea::exitAcceleratedCompositingModeNow):

1:38 AM Changeset in webkit [211799] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.14/Source/WebCore

Merge r211206 - ImageBufferCairo: cairo_image_surface should use bmalloc-allocated memory
​https://bugs.webkit.org/show_bug.cgi?id=165751

Reviewed by Carlos Garcia Campos.

Allocate the underlying memory for cairo_image_surface objects through FastMalloc.
This way we can steer such large allocations away from the default libc allocator.

Objects of this class can create Cairo surfaces that need as much as 4MB of memory
for the underlying pixel buffer. Allocating such objects through the default
libc allocator can lead to increased memory usage because of non-optimal allocation
strategy in libc. In contrast, bmalloc performs large allocations by directly using
mmap() to reserve the necessary memory.

The improvements can be significant. On nytimes.com, with the threaded version of
the CoordinatedGraphics system, the memory consumption can drop by roughly 20%.

• platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::ImageBuffer): Zero-allocate the necessary memory via FastMalloc.
Tie that memory lifetime to the lifetime of the surface by using
cairo_surface_set_user_data() with the specific user data key.

1:34 AM Changeset in webkit [211798] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.14/Source/WebKit2

Merge r211277 - [GTK] Stop forcing accelerated compositing by default
​https://bugs.webkit.org/show_bug.cgi?id=167492

Reviewed by Žan Doberšek.

We are now ready to bring back the on demand accelerated compositing mode with the threaded
compositor. Unfortunately, having AC always enabled brought a lot of issues for many people. Not only it
requires a lot more memory but also caused rendering issues (or even nothing rendered at all) with some graphics
drivers. People started to use WEBKIT_DISABLE_COMPOSITING_MODE as a workaround, but that was not expected to be
used by users. So, entering/leaving AC when required by web contents is not actually the solution but a huge
improvement for many people. If we are eventually ready to force AC mode again, we'll change this again. Note
that we still have WEBKIT_DISABLE_COMPOSITING_MODE, but now also WEBKIT_FORCE_COMPOSITING_MODE for testing and debugging.

• UIProcess/gtk/WebPreferencesGtk.cpp:

(WebKit::WebPreferences::platformInitializeStore):

1:34 AM Changeset in webkit [211797] by Carlos Garcia Campos

• 7 edits in releases/WebKitGTK/webkit-2.14/Source/WebKit2

Merge r211365 - [GTK] Do not release OpenGL resource immediately when leaving accelerated compositing mode
​https://bugs.webkit.org/show_bug.cgi?id=167544

Reviewed by Michael Catanzaro.

Sometimes the conditions to be in AC mode or not change quickly, and then we leave AC mode just enter it again
after a very short period of time. In those cases we are dropping all the GL resources and the compositor
thread, and creating it again. We could keep the layer tree host alive for a while when exiting AC mode, and
reuse it if we enter AC mode before the previous one has been discarded. While the previous layer tree host is
alive we still need to keep it up to date, for example if the web view is resized or contents size change, and
synchronize with the threaded compositor when it becomes the layer tree host again.

• WebProcess/WebPage/AcceleratedDrawingArea.cpp:

(WebKit::AcceleratedDrawingArea::~AcceleratedDrawingArea): Discard the previous layer tree host.
(WebKit::AcceleratedDrawingArea::AcceleratedDrawingArea): Initialize the timer to discard the previous layer
tree host.
(WebKit::AcceleratedDrawingArea::pageBackgroundTransparencyChanged): Notify the previous layer tree host if needed.
(WebKit::AcceleratedDrawingArea::mainFrameContentSizeChanged): Ditto.
(WebKit::AcceleratedDrawingArea::updateBackingStoreState): Ditto.
(WebKit::AcceleratedDrawingArea::enterAcceleratedCompositingMode): Reuse the previous layer tree host if possible.
(WebKit::AcceleratedDrawingArea::exitAcceleratedCompositingModeNow): Exit AC mode and save the layer tree host
starting a timer of 5 seconds to discard it if not reused.
(WebKit::AcceleratedDrawingArea::discardPreviousLayerTreeHost): Invalidate and destroy the previous layer tree host.
(WebKit::AcceleratedDrawingArea::didChangeViewportAttributes): Notify the previous layer tree host if needed.
(WebKit::AcceleratedDrawingArea::deviceOrPageScaleFactorChanged): Ditto.

• WebProcess/WebPage/AcceleratedDrawingArea.h:
• WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:

(WebKit::ThreadedCoordinatedLayerTreeHost::scrollNonCompositedContents): If it's discardable add the action to
be synchronized instead.
(WebKit::ThreadedCoordinatedLayerTreeHost::contentsSizeChanged): Ditto.
(WebKit::ThreadedCoordinatedLayerTreeHost::deviceOrPageScaleFactorChanged): Ditto.
(WebKit::ThreadedCoordinatedLayerTreeHost::pageBackgroundTransparencyChanged): Ditto.
(WebKit::ThreadedCoordinatedLayerTreeHost::sizeDidChange): Ditto.
(WebKit::ThreadedCoordinatedLayerTreeHost::didChangeViewportAttributes): Ditto.
(WebKit::ThreadedCoordinatedLayerTreeHost::setIsDiscardable): When the layer tree host becomes discardable,
reset the sync actions and return. When it becomes the real layer tree host again, apply all pending actions to
synchronize with the threaded compositor.

• WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:
• WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::scroll): Notify the previous layer tree host if needed.
(WebKit::DrawingAreaImpl::mainFrameContentSizeChanged): Ditto.
(WebKit::DrawingAreaImpl::exitAcceleratedCompositingMode): Use AcceleratedDrawingArea::exitAcceleratedCompositingModeNow().

• WebProcess/WebPage/LayerTreeHost.h:

(WebKit::LayerTreeHost::setIsDiscardable): Added.

1:34 AM Changeset in webkit [211796] by Carlos Garcia Campos

• 10 edits in releases/WebKitGTK/webkit-2.14/Source/WebKit2

Merge r211350 - [Coordinated Graphics] WebPage shouldn't use the layerTreeHost directly
​https://bugs.webkit.org/show_bug.cgi?id=167494

Reviewed by Michael Catanzaro.

In Coordinated Graphics we have a couple of methods that the WebPage uses directly from the layer tree host,
instead of using the drawing area interface. This patch adds DrawingArea::didChangeViewportAttributes and
DrawingArea::deviceOrPageScaleFactorChanged and renames LayerTreeHost::didChangeViewportProperties as
LayerTreeHost::didChangeViewportAttributes for consistency.

• Shared/CoordinatedGraphics/SimpleViewportController.cpp:

(WebKit::SimpleViewportController::didChangeViewportAttributes): Receive an rvalue reference to avoid copies.

• Shared/CoordinatedGraphics/SimpleViewportController.h:
• WebProcess/WebPage/AcceleratedDrawingArea.cpp:

(WebKit::AcceleratedDrawingArea::didChangeViewportAttributes): Forward it to the layer tree host if any.
(WebKit::AcceleratedDrawingArea::deviceOrPageScaleFactorChanged): Ditto.

• WebProcess/WebPage/AcceleratedDrawingArea.h:
• WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:

(WebKit::ThreadedCoordinatedLayerTreeHost::didChangeViewportAttributes): Renamed and updated to pass an rvalue reference.
(WebKit::ThreadedCoordinatedLayerTreeHost::didChangeViewportProperties): Deleted.

• WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:
• WebProcess/WebPage/DrawingArea.h:
• WebProcess/WebPage/LayerTreeHost.h:

(WebKit::LayerTreeHost::didChangeViewportAttributes): Renamed and updated to pass an rvalue reference.
(WebKit::LayerTreeHost::didChangeViewportProperties): Deleted.

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::sendViewportAttributesChanged): Use the drawing area.
(WebKit::WebPage::scalePage): Ditto
(WebKit::WebPage::setDeviceScaleFactor): Ditto.
(WebKit::WebPage::viewportPropertiesDidChange): Ditto.

1:33 AM Changeset in webkit [211795] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.14/Source/WebCore

Merge r211358 - [Threaded Compositor] Crash in GraphicsContext3D::deleteTexture when destroying TextureMapperPlatformLayerProxy
​https://bugs.webkit.org/show_bug.cgi?id=167575

Reviewed by Žan Doberšek.

We should clear all the buffers on invalidate to ensure we don't have textures alive after CoordinatedGraphicsScene::purgeGLResources().

Fix crash in media/video-poster-background.html.

• platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp:

(WebCore::TextureMapperPlatformLayerProxy::invalidate): Clear current, pending and all used buffers.

1:33 AM Changeset in webkit [211794] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.14/Source

Merge r211357 - [Threaded Compositor] Crash on WebCore::GLContext::version()
​https://bugs.webkit.org/show_bug.cgi?id=167559

Reviewed by Michael Catanzaro.

Source/WebCore:

Fixes crashes in several media tests.

• platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp:

(WebCore::TextureMapperPlatformLayerProxy::invalidate): Clear m_compositorThreadUpdateTimer and call the update function.

Source/WebKit2:

This is happening because TextureMapperPlatformLayerProxy::compositorThreadUpdateTimerFired() is fired after the
threaded compositor is deleted. CoordinatedGraphicsScene::purgeGLResources() should invalidate the proxies
before clearing the map.

• Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::purgeGLResources):

1:33 AM Changeset in webkit [211793] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.14/Source/WebKit2

Merge r211367 - [GTK] Scrolling iframes, doesn't redraw their content
​https://bugs.webkit.org/show_bug.cgi?id=167581

Reviewed by Carlos Garcia Campos.

Take into account whether we are using AC or not in order to repaint an area after scrolling.

No behaviour change, no new tests.

• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::invalidateContentsForSlowScroll):

1:33 AM Changeset in webkit [211792] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.14/Source/WebKit2

Merge r211348 - [Threaded Compositor] Crash when detaching the CoordinatedGraphicsScene
​https://bugs.webkit.org/show_bug.cgi?id=167547

Reviewed by Michael Catanzaro.

It seems that commitSceneState() can be called after the CoordinatedGraphicsScene has been detached.

• Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::commitSceneState): Return early if scene has been detached.
(WebKit::CoordinatedGraphicsScene::detach): Take the render queue lock before clearing the render queue.

1:33 AM Changeset in webkit [211791] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.14/Source/WebKit2

Merge r211347 - [Threaded Compositor] Crash when deleting the compositor run loop
​https://bugs.webkit.org/show_bug.cgi?id=167545

Reviewed by Michael Catanzaro.

The problem is that we are releasing the WorkQueue before the update timer that keeps a reference to the run
loop, destroyed by the WorkQueue. So, invalidate the WorkQueue in the next run loop iteration to ensure it
happens after the CompositingRunLoop destructor.

• Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:

(WebKit::CompositingRunLoop::~CompositingRunLoop):

1:33 AM Changeset in webkit [211790] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.14/Source/WebKit2

Merge r211346 - [GTK] ASSERTION FAILED: !m_layerTreeHost in DrawingAreaImpl::display()
​https://bugs.webkit.org/show_bug.cgi?id=167548

Reviewed by Michael Catanzaro.

The problem is that non accelerated compositing forceRepaint implementation is doing a layout and then calling
display. The layout makes the drawing area enter in AC mode and display asserts that we have a layer tree
host. forceRepaint shouldn't do the layout because display already does that and it correctly handles the case
of entering AC mode during the layout. It shouldn't call setNeedsDisplay either, because that schedules a
display, but we are going to display synchronously.

• WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::forceRepaint):

1:33 AM Changeset in webkit [211789] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.14/Source/WebKit2

Merge r211281 - [Threaded Compositor] Stop creating the GLContext on demand the first time makeContextCurrent is called
​https://bugs.webkit.org/show_bug.cgi?id=167496

Reviewed by Žan Doberšek.

This is causing problems with animations when entering AC mode on demand. What happens is that the threaded
compositor is created, then the animation is scheduled and during the first animation iteration the GLContext is
created, making the first frame of the animation quite slow. In my computer creating the GLContext takes 0.8
seconds. If the animation duration is less than the time it takes to create the GLContext, the animation ends
without iterating. This causing timeouts in the bots in tests like
animations/animation-iteration-event-destroy-renderer.html that expect webkitAnimationIteration events that
never fire.

• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::ThreadedCompositor::ThreadedCompositor): Create the GLContext right after the compositing thread is
created if we already have a native surface handle.
(WebKit::ThreadedCompositor::createGLContext): Helper to create the GLContext.
(WebKit::ThreadedCompositor::setNativeSurfaceHandleForCompositing): Create the GLContext when a native surface
handle is given.
(WebKit::ThreadedCompositor::makeContextCurrent): Deleted.
(WebKit::ThreadedCompositor::renderLayerTree): Make the context cunrrent directly here.

• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:

1:33 AM Changeset in webkit [211788] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.14/Source/WebKit2

Merge r211205 - [Threaded Compositor] Update also the contents size when creating the threaded compositor
​https://bugs.webkit.org/show_bug.cgi?id=167452

Reviewed by Žan Doberšek.

In r210954 we ensured that the threaded compositor and the viewport controller were created with the initial web
page size. If we don't update the contents size, the visible rectangle will be empty and tiles won't be created
until contentsSizeDidChange is called. It's even possible, when entering AC mode on demand, that we create the
layer tree host after the contents size changed, in which case nothing is rendered unless we resize the window.

• WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:

(WebKit::ThreadedCoordinatedLayerTreeHost::ThreadedCoordinatedLayerTreeHost):

1:32 AM Changeset in webkit [211787] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.14/Source/WebCore

Merge r211204 - [GTK] WebProcess from WebKitGtk+ 2.15.3 SIGSEVs in WebCore::GraphicsContext3D::drawArrays(unsigned int, int, int) at Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:740
​https://bugs.webkit.org/show_bug.cgi?id=167296

Reviewed by Sergio Villar Senin.

Use a VBO to pass the vertex data when using the stencil for clipping. Passing a custom array without
using an VBO is deprecated when using OpenGL >= 3.0 and a Core profile.

No behaviour change, no new tests.

• platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::beginClip):

1:32 AM Changeset in webkit [211786] by Carlos Garcia Campos

• 6 edits in releases/WebKitGTK/webkit-2.14/Source

Merge r211145 - [GTK] UIProcess from WebKitGtk+ 2.15.x SIGSEGVs because of X Error BadDamage in WebKit::AcceleratedBackingStoreX11::update(WebKit::LayerTreeContext const&) () at Source/WebKit2/UIProcess/gtk/AcceleratedBackingStoreX11.cpp:145
​https://bugs.webkit.org/show_bug.cgi?id=165656

Reviewed by Michael Catanzaro.

Source/WebCore:

Also return the base error code from PlatformDisplayX11::supportsXDamage().

• platform/graphics/x11/PlatformDisplayX11.cpp:

(WebCore::PlatformDisplayX11::supportsXDamage):

• platform/graphics/x11/PlatformDisplayX11.h:

Source/WebKit2:

We are incorrectly handling BadDamage errors because the BadDamage value we pass to the XErrorTrapper is not
the actual error code used by X11. Since XDamage is an extension, it has its own errors and a base error
code. We need to use the base error code we get when calling XDamageQueryExtension to pass the right error code
to the XErrorTrapper.

• UIProcess/gtk/AcceleratedBackingStoreX11.cpp:

(WebKit::AcceleratedBackingStoreX11::create): Get also the damage base error.
(WebKit::xDamageErrorCode): Helper to get the actual error code.
(WebKit::AcceleratedBackingStoreX11::~AcceleratedBackingStoreX11): Use xDamageErrorCode().
(WebKit::AcceleratedBackingStoreX11::update): Ditto.

1:32 AM Changeset in webkit [211785] by Carlos Garcia Campos

• 6 edits in releases/WebKitGTK/webkit-2.14/Source

Merge r211141 - [GTK] The inspector is broken when AC support is disabled
​https://bugs.webkit.org/show_bug.cgi?id=165237

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Ensure that PageOverlayController destroys its root GraphicsLayers when leaving AC. They
will be recreated if we enter AC again, avoiding a crash because the layers don't belong to
the appropriate compositor. Also, don't append the document overlay layers if we are not
in compositing mode.

No new tests added.

• page/PageOverlayController.cpp:

(WebCore::PageOverlayController::willDetachRootLayer):

• page/PageOverlayController.h:
• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::appendDocumentOverlayLayers):
(WebCore::RenderLayerCompositor::detachRootLayer):

Source/WebKit2:

WebInspector must not use PageOverlays or GraphicsLayers when AC is not avaialable.

No new tests added.

• WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::highlight):
(WebKit::WebInspectorClient::showPaintRect):

1:32 AM Changeset in webkit [211784] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.14/Source/WebCore

Merge r211084 - [GTK] Do not paint non composited content into the window when using the threaded compositor
​https://bugs.webkit.org/show_bug.cgi?id=167367

Reviewed by Carlos Garcia Campos.

When using the threaded compositor we need to send the non composited content for compositing as well,
not painting it directly into the window.

No new tests.

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintsIntoWindow):

1:32 AM Changeset in webkit [211783] by Carlos Garcia Campos

• 6 edits in releases/WebKitGTK/webkit-2.14/Source/WebKit2

Merge r210954 - [Threaded Compositor] Initialize the threaded compositor with the current size
​https://bugs.webkit.org/show_bug.cgi?id=167196

Reviewed by Žan Doberšek.

We are always creating the threaded compositor with an empty size and then a sizeDidChange always happen when
the backing store state changes. This is always happening because the threaded compositor is created before the
first backing store state, but if we wanted to create it later, for example to enter/leave AC mode on demand,
the threaded compositor will not have the viewport size unless the window is resized, or sizeDidChange is called
manually when entering AC mode. Creating the threaded compositor is sync and changing the size too, so it's
better to do both things at the same time using the same sync operation.

• Shared/CoordinatedGraphics/SimpleViewportController.cpp:

(WebKit::SimpleViewportController::SimpleViewportController): Pass an initial size to the constructor.

• Shared/CoordinatedGraphics/SimpleViewportController.h:
• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::ThreadedCompositor::create): Add viewportSize and scaleFactor construction parameters,
(WebKit::ThreadedCompositor::ThreadedCompositor): Ditto. Also mark as needs resize if the given size is not empty.

• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
• WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:

(WebKit::ThreadedCoordinatedLayerTreeHost::ThreadedCoordinatedLayerTreeHost): Initialize the threaded compositor
with an initial viewport size and scale factor.

1:32 AM Changeset in webkit [211782] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.14/Source/WebKit2

Merge r211083 - [Coordinated Graphics] Ensure that we're in AC mode before trying to create GraphicsLayers
​https://bugs.webkit.org/show_bug.cgi?id=167365

Reviewed by Carlos Garcia Campos.

When entering AC on demand, the RenderLayerCompositor wants to create the root GraphicsLayer before the
AcceleratedDrawingArea is in AC mode. This means there's no LayerTreeHost to request the GraphicsLayerFactory,
so no layers are created. Ensure that we are in AC mode before requesting the GraphicsLayerFactory.

No behaviour change, no new tests.

• WebProcess/WebPage/AcceleratedDrawingArea.cpp:

(WebKit::AcceleratedDrawingArea::graphicsLayerFactory):

1:32 AM Changeset in webkit [211781] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.14/Source/WebKit2

Merge r210920 - [GTK] Do not update the backing store state unnecessarily when page visibility changes
​https://bugs.webkit.org/show_bug.cgi?id=167195

Reviewed by Sergio Villar Senin.

I've noticed that we are receiving UpdateBackingStoreState messages in the web process even when size and scale
factor didn't change. That's quite unfortunate because we do a lot of work unnecessarily and we tell the
threaded compositor that the size changed. This is not only a problem because it's not true, but also because
changing the size is a sync operation in the threaded compositor, so we block the compositing thread for
nothing. This is happening because the WebPageProxy notifies the drawing area that the backing store is
discardable when the page is not visible, and that always produces a new backing store state. In accelerating
compositing mode we don't even have a backing store to discard, so we should check we have something to discard
and also make sure we only generate a new backing store state if we really discarded the backing store.

• UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::discardBackingStoreSoon):
(WebKit::DrawingAreaProxyImpl::discardBackingStore):

1:31 AM Changeset in webkit [211780] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.14/Source/WebCore

Merge r210847 - [GTK] [TextureMapper] [GLES2] Draw repeated patterns for NPOT textures manually
​https://bugs.webkit.org/show_bug.cgi?id=167118

Reviewed by Žan Doberšek.

When using GLES2 without the GL_OES_texture_npot extension, some implementations fail to properly
draw repeated patters from a texture (using GL_REPEAT). For those cases, perform the repetition
manually using the shader.

Covered by existent tests.

• platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::driverSupportsNPOTTextures):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::drawTexturedQuadWithProgram):

• platform/graphics/texmap/TextureMapperShaderProgram.cpp:

(WebCore::TextureMapperShaderProgram::create):

• platform/graphics/texmap/TextureMapperShaderProgram.h:

1:00 AM Changeset in webkit [211779] by commit-queue@webkit.org

• 7 edits in trunk

[Readable Streams API] Implement ReadableByteStreamController enqueue()
​https://bugs.webkit.org/show_bug.cgi?id=167786

Patch by Romain Bellessort <​romain.bellessort@crf.canon.fr> on 2017-02-07
Reviewed by Youenn Fablet.

Source/WebCore:

Implemented ReadableByteStreamController enqueue() method. Also replaced
@queue by an Array instead of a dedicated queue object (said object is
useful for ReadableStreamDefaultController, but not for ReadableByteStreamController).

Added 8 tests to cover newly added code as well as code that was previously unreachable.

• Modules/streams/ReadableByteStreamController.js:

(enqueue): Implemented as defined by spec.

• Modules/streams/ReadableByteStreamInternals.js:

(privateInitializeReadableByteStreamController): Updated @queue.
(readableByteStreamControllerCancel): Updated @queue.
(readableByteStreamControllerError): Updated @queue.
(readableByteStreamControllerPull): Updated @queue.
(readableByteStreamControllerEnqueue): Added.
(readableByteStreamControllerEnqueueChunkToQueue): Added.

• Modules/streams/ReadableStreamInternals.js:

(readableStreamFulfillReadRequest): Added (used at different places).

LayoutTests:

Added 8 tests to cover newly added code as well as code that was previously unreachable.

• streams/readable-byte-stream-controller-expected.txt:
• streams/readable-byte-stream-controller.js:

12:51 AM Changeset in webkit [211778] by Chris Dumez

• 7 edits in trunk

Object.preventExtensions() on a Location object should throw a TypeError
​https://bugs.webkit.org/show_bug.cgi?id=167917

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline web platform test now that one more check is passing.

• web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt:

Source/WebCore:

Object.preventExtensions() on a Location object should throw a TypeError:

• ​https://html.spec.whatwg.org/#location-preventextensions
• ​https://www.ecma-international.org/ecma-262/7.0/index.html#sec-object.preventextensions

Firefox already implements this.

No new tests, rebaselined existing tests.

• bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::preventExtensions):

LayoutTests:

Rebaseline test now that more checks are passing.

• http/tests/security/preventExtensions-window-location-expected.txt:
• http/tests/security/preventExtensions-window-location.html:

12:17 AM Changeset in webkit [211777] by Yusuke Suzuki

• 8 edits
  4 adds in trunk

Web Inspector: allow import() inside the inspector
​https://bugs.webkit.org/show_bug.cgi?id=167457

Reviewed by Ryosuke Niwa.

Source/JavaScriptCore:

We relax import module hook to accept null SourceOrigin.
Such a script can be evaluated from the inspector console.

• jsc.cpp:

(GlobalObject::moduleLoaderImportModule):

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncImportModule):

Source/WebCore:

When evaluating import("..."), we need the caller's context to resolve
the module specifier correctly. For example, if import("./cocoa.js") is
evaluated in the script "drinks/hot.js", this module name is resolved to
"drinks/cocoa.js". If the same import operator is evaluated in the script
"menu/all.js", the module specifier becomes "menu/cocoa.js".

Previously we reject the import operator if the caller does not have such
a context. These context is SourceOrigin and its ScriptFetcher. While they
are offered in the script tag and other code evaluations, the inspector
console does not offer that. These class are offered in the WebCore side
and we should not touch these classes in the JSC's inspector code.

Now we relax the above restriction. If the above caller information is not
offered, we fallback to the default one. In the web page, we use the page's
URL as the caller's source origin. This allows us to evaluate the import
operator in the inspector console.

And as of r167698, the console recognizes await import("...") form. We use
this to test this import() in the console functionality.

• bindings/js/ScriptModuleLoader.cpp:

(WebCore::ScriptModuleLoader::importModule):

LayoutTests:

• inspector/controller/resources/cappuccino.js: Added.
• inspector/controller/resources/cocoa.js: Added.
• inspector/controller/resources/drink.js: Added.
• inspector/controller/runtime-controller-expected.txt:
• inspector/controller/runtime-controller.html:

12:14 AM Changeset in webkit [211776] by mmaxfield@apple.com

• 2 edits
  2 moves in trunk/Source/WebCore

Move platform-independent parts of ComplexTextController out of mac/ subfolder
​https://bugs.webkit.org/show_bug.cgi?id=167922

Reviewed by Jon Lee.

Just a mechanical git mv, and updating the Xcode projects.

No new tests because there is no behavior change.

• WebCore.xcodeproj/project.pbxproj:
• platform/graphics/ComplexTextController.cpp: Renamed from Source/WebCore/platform/graphics/mac/ComplexTextController.cpp.
• platform/graphics/ComplexTextController.h: Renamed from Source/WebCore/platform/graphics/mac/ComplexTextController.h.

Feb 6, 2017:

10:45 PM Changeset in webkit [211775] by Carlos Garcia Campos

• 6 edits
  2 adds in trunk

Overlay scrolling with iframe-s broken
​https://bugs.webkit.org/show_bug.cgi?id=165056

Reviewed by Antonio Gomes.

Source/WebCore:

Mouse press events for overlay scrollbars are ignored if there's a subframe under the scrollbar. This doesn't
happen with normal scrollbars, because the subframe is not really under the scrollbar, so events are always
correctly passed to the scrollbar. With overlay scrollbars, the hit test detects the scrollbar, but events are
always passed first to the subframe. Scrollbars are correctly updated on hover though, because
handleMouseMoveEvent checks the presence of scrollbars before checking for subframes and move events are
actually passed to both, the scrollbar and the subframe. Overlay scrollbars should always take precedence over
subframes to handle mouse press events, so we should check first if mouse is over a scrollbar and never pass the
event to a subframe in that case. Another problem is that the cursor is not updated either when the overlay
scrollbar is hovered and there's a subframe. This is because in handleMouseMoveEvent we pass the event to both
the scrollbar and subframe but we never update the cursor when a suframe was found. So, here again we need to make
an exception for scrollbars and upate the cursor when mouse is over the scrollbar even if a subframe was found.

Test: fast/scrolling/scroll-animator-overlay-scrollbars-clicked.html

• page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent): Move the scrollbar check before the subframe check.
(WebCore::EventHandler::handleMouseMoveEvent): Update the cursor when hovering a scrollbar even if a subframe
was found.
(WebCore::EventHandler::updateLastScrollbarUnderMouse): Use an enum instead of a boolean for setLast parameter.

• page/EventHandler.h:

LayoutTests:

Add a new test to check that clicking on an overlay scrollbar works even it's over a subframe.

• fast/scrolling/scroll-animator-overlay-scrollbars-clicked-expected.txt: Added.
• fast/scrolling/scroll-animator-overlay-scrollbars-clicked.html: Added.
• platform/ios-simulator/TestExpectations:
• platform/mac-wk1/TestExpectations:

10:34 PM Changeset in webkit [211774] by commit-queue@webkit.org

• 2 edits in trunk/Tools

[GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
​https://bugs.webkit.org/show_bug.cgi?id=167916

Patch by Fujii Hironori <Fujii Hironori> on 2017-02-06
Reviewed by Carlos Garcia Campos.

URL of mesa-11.0.6.tar.xz has been moved.

• gtk/jhbuild.modules: Fix the module path.

10:12 PM Changeset in webkit [211773] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit2

[Soup] Long resources loaded by custom protocols sometimes never finish loading
​https://bugs.webkit.org/show_bug.cgi?id=167890

Reviewed by Michael Catanzaro.

It's another bug that has appeared in WebKitSoupRequestInputStream after moving the custom protocols handling to
the main thread. The problem is that webkitSoupRequestInputStreamPendingReadAsyncComplete invalidates
pendingAsyncRead after calling webkitSoupRequestInputStreamReadAsyncResultComplete, but in some cases
webkitSoupRequestInputStreamReadAsyncResultComplete completes the task in the same run loop iteration. In that
case webkitSoupRequestInputStreamReadAsync is called again creating a new AsyncReadData that is destroyed right
after webkitSoupRequestInputStreamReadAsyncResultComplete returns.

• WebProcess/soup/WebKitSoupRequestInputStream.cpp:

(AsyncReadData::AsyncReadData): Use an rvalue reference for the task.
(webkitSoupRequestInputStreamPendingReadAsyncComplete): Use WTFMove to ensure pendingAsyncRead is cleared before
webkitSoupRequestInputStreamReadAsyncResultComplete is called, and continue processing pending requests if there
are new ones after webkitSoupRequestInputStreamReadAsyncResultComplete.
(webkitSoupRequestInputStreamReadAsync): Use WTFMove to transfer the task to AsyncReadData.
(webkitSoupRequestInputStreamDidFailWithError): Use WTFMove to ensure pendingAsyncRead is cleared.

8:47 PM Changeset in webkit [211772] by Chris Dumez

• 5 edits in trunk

Symbols exposed on cross-origin Window / Location objects should be configurable
​https://bugs.webkit.org/show_bug.cgi?id=167920

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline web platform test now that more checks are passing.

• web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt:

Source/WebCore:

Symbols exposed on cross-origin Window / Location objects should be configurable:

• ​https://html.spec.whatwg.org/#crossorigingetownpropertyhelper-(-o,-p-) (Step 1)

Firefox behaves as per specification.

No new tests, rebaselined existing test.

• bindings/js/JSDOMWindowCustom.cpp:

(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess):

• bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::getOwnPropertySlotDelegate):

8:27 PM Changeset in webkit [211771] by commit-queue@webkit.org

• 11 edits
  1 copy
  1 add in trunk/Source

Web Inspector: Do not use RunLoop when dispatching inspector GC event
​https://bugs.webkit.org/show_bug.cgi?id=167683
<rdar://problem/30167791>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-02-06
Reviewed by Brian Burg.

Source/JavaScriptCore:

Move the RunLoop deferred implementation to WebCore. It is not needed
for JSContext inspection, and in JSContext inspection we are not
guarenteed a RunLoop to defer to.

• inspector/agents/InspectorHeapAgent.h:
• inspector/agents/InspectorHeapAgent.cpp:

(Inspector::InspectorHeapAgent::InspectorHeapAgent):
(Inspector::InspectorHeapAgent::~InspectorHeapAgent):
(Inspector::InspectorHeapAgent::disable):
(Inspector::InspectorHeapAgent::didGarbageCollect):
(Inspector::SendGarbageCollectionEventsTask::SendGarbageCollectionEventsTask): Deleted.
(Inspector::SendGarbageCollectionEventsTask::addGarbageCollection): Deleted.
(Inspector::SendGarbageCollectionEventsTask::reset): Deleted.
(Inspector::SendGarbageCollectionEventsTask::timerFired): Deleted.

(Inspector::InspectorHeapAgent::dispatchGarbageCollectedEvent):
Make a virtual method so that WebCore implementations of this agent can choose
to dispatch this event asynchronously.

• inspector/agents/InspectorScriptProfilerAgent.cpp:

Remove unnecessary RunLoop include.

Source/WebCore:

Covered by existing tests.

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:
• inspector/InspectorAllInOne.cpp:

Add new file.

• inspector/PageHeapAgent.cpp:

(WebCore::PageHeapAgent::PageHeapAgent):
(WebCore::PageHeapAgent::enable):
(WebCore::PageHeapAgent::disable):

• inspector/PageHeapAgent.h:

Extend WebHeapAgent.

• inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):
Use WebHeapAgent.

• inspector/WebHeapAgent.cpp: Added.

(WebCore::SendGarbageCollectionEventsTask::SendGarbageCollectionEventsTask):
(WebCore::SendGarbageCollectionEventsTask::addGarbageCollection):
(WebCore::SendGarbageCollectionEventsTask::reset):
(WebCore::SendGarbageCollectionEventsTask::timerFired):
(WebCore::WebHeapAgent::WebHeapAgent):
(WebCore::WebHeapAgent::~WebHeapAgent):
(WebCore::WebHeapAgent::disable):
(WebCore::WebHeapAgent::dispatchGarbageCollectedEvent):
(WebCore::WebHeapAgent::dispatchGarbageCollectionEventsAfterDelay):

• inspector/WebHeapAgent.h:

Move the defered event dispatch from InspectorHeapAgent here where a RunLoop is guarenteed.

8:23 PM Changeset in webkit [211770] by mitz@apple.com

• 4 edits in trunk/Source/WebKit2

[iOS] -[WKWebView becomeFirstResponder] and -[WKWebView resignFirstResponder] don’t get called when non-programmatic first responder changes happen
​https://bugs.webkit.org/show_bug.cgi?id=167898

Reviewed by Tim Horton.

Made WKContentView’s -becomeFirstResponder and -resignFirstResponder forward to the
WKWebView, giving subclasses an opportunity to override these methods. Changed the WKWebView
implementations to call back into WKContentView methods that actually do the work.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView becomeFirstResponder]): If the current content view is a WKContentView, call

-becomeFirstResponderForWebView. Added a check that the content view has a superview to
get the right behavior when this is called during the transition from not having to having
a custom content view.

(-[WKWebView canBecomeFirstResponder]): If the current content view is a WKContentView, call

-canBecomeFirstResponderForWebView.

(-[WKWebView resignFirstResponder]): If the current content view is a WKContentView, call

-resignFirstResponderForWebView.

(-[WKWebView _setHasCustomContentView:loadedMIMEType:]): If the new content view is a

WKContentView, use -canBecomeFirstResponderForWebView.

• UIProcess/ios/WKContentViewInteraction.h: Added _becomingFirstResponder ivar.
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView canBecomeFirstResponder]): Return _becomingFirstResponder. Normally this is

NO, so code that hit-tests then walks up the view hierarchy to select a first responder
will continue to the WKWebView. But we need to return YES around the call to super’s
-becomeFirstResponder in -becomeFirstResponderForWebView.

(-[WKContentView canBecomeFirstResponderForWebView]): Moved the old

-becomeFirstResponderForWebView implementation here.

(-[WKContentView becomeFirstResponder]): Forward to the WKWebView.
(-[WKContentView becomeFirstResponderForWebView]): Moved the old -becomeFirstResponder

implementation here, setting _becomingFirstResponder to YES around the call to super.

(-[WKContentView resignFirstResponder]): Forward to the WKWebView.
(-[WKContentView resignFirstResponderForWebView]): Moved the old -resignFirstResponder

implementation here.

8:19 PM Changeset in webkit [211769] by commit-queue@webkit.org

• 4 edits in trunk/Tools

Static Analyzer: Address some leaks in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=167897

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-02-06
Reviewed by Alexey Proskuryakov.

• MiniBrowser/mac/BrowserWindowController.m:

(-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):

• MiniBrowser/mac/ExtensionManagerWindowController.m:

(-[ExtensionManagerWindowController add:]):
(-[ExtensionManagerWindowController remove:]):

• MiniBrowser/mac/SettingsController.m:

(-[SettingsController _populateMenu]):
(-[SettingsController togglePerWindowWebProcessesDisabled:]):
Address obvious leaks caught by the static analyzer.

6:40 PM Changeset in webkit [211768] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

ExtendedColor leaks seen on leaks bot
​https://bugs.webkit.org/show_bug.cgi?id=167912

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-02-06
Reviewed by Alexey Proskuryakov.

• platform/graphics/Color.cpp:

(WebCore::Color::operator=):
Before overwriting m_colorData, we must deref the extended color inside it.

6:19 PM Changeset in webkit [211767] by Simon Fraser

• 2 edits in trunk/Source/WebKit2

Remove assertion in WebViewImpl::performKeyEquivalent()

Reviewed by Wenson Hsieh.

The assertion ASSERT(event == [NSApp currentEvent]) fires when using certain key combinations
in MiniBrowser's location field (e.g. Option-Shift-Arrow to select). The assertion is not correct,
so remove it.

• UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::performKeyEquivalent):

6:19 PM Changeset in webkit [211766] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Re-land r210095 (avoid a tile revalidation on scale change)
​https://bugs.webkit.org/show_bug.cgi?id=167866

Reviewed by Tim Horton.

r210095 was rolled out in r211230 but now that all TileControllers unparent
offscreen tiles, we can roll it back it.

Also add more Tiling logging.

• platform/graphics/ca/TileGrid.cpp:

(WebCore::validationPolicyAsString):
(WebCore::TileGrid::setScale):
(WebCore::TileGrid::prepopulateRect):
(WebCore::TileGrid::revalidateTiles):
(WebCore::TileGrid::ensureTilesForRect):

6:14 PM Changeset in webkit [211765] by mmaxfield@apple.com

• 9 edits in trunk

Migrate ComplexTextController to use platform-independent types
​https://bugs.webkit.org/show_bug.cgi?id=167833

Reviewed by Brent Fulgham.

Source/WebCore:

ComplexTextController will eventually be used on all ports to perform complex text layout.
This is a mechanical patch which migrates the shared parts of ComplexTextController away from
using CoreGraphics and CoreFoundation types in favor of WebCore/platform types. Eventually,
ComplexTextController will get moved to PAL but there is a layering violation (TextLayout) to
fix first.

No new tests because there is no behavior change.

• platform/graphics/GlyphBuffer.h:

(WebCore::GlyphBufferAdvance::GlyphBufferAdvance):

• platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::offsetForPosition):
(WebCore::advanceByCombiningCharacterSequence):
(WebCore::ComplexTextController::ComplexTextRun::indexAt):
(WebCore::ComplexTextController::ComplexTextRun::setIsNonMonotonic):
(WebCore::ComplexTextController::advance):
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

• platform/graphics/mac/ComplexTextController.h:

(WebCore::ComplexTextController::ComplexTextRun::create):
(WebCore::ComplexTextController::ComplexTextRun::stringLength):
(WebCore::ComplexTextController::ComplexTextRun::indexBegin):
(WebCore::ComplexTextController::ComplexTextRun::indexEnd):
(WebCore::ComplexTextController::ComplexTextRun::endOffsetAt):
(WebCore::ComplexTextController::ComplexTextRun::glyphs):
(WebCore::ComplexTextController::ComplexTextRun::growInitialAdvanceHorizontally):
(WebCore::ComplexTextController::ComplexTextRun::initialAdvance):
(WebCore::ComplexTextController::ComplexTextRun::baseAdvances):
(WebCore::ComplexTextController::ComplexTextRun::glyphOrigins):
(WebCore::ComplexTextController::glyphOrigin):
(WebCore::ComplexTextController::ComplexTextRun::createForTesting): Deleted.

• platform/graphics/mac/ComplexTextControllerCoreText.mm:

(SOFT_LINK):
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):

Tools:

Migrate tests away from platform-dependent types.

• TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:

(TestWebKitAPI::TEST_F):

LayoutTests:

Rebaseline tiny rounding result.

• platform/mac/fast/text/complex-text-opacity-expected.txt:

6:08 PM Changeset in webkit [211764] by Simon Fraser

• 2 edits in trunk/Source/WebKit2

[iOS WK2] Keep the tiled scrolling indicator on-screen when pinching
​https://bugs.webkit.org/show_bug.cgi?id=167915

Reviewed by Tim Horton.

Clamp the location to the larger of the location of .unobscuredContentRect() and 0,0.

• UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::indicatorLocation):

5:48 PM Changeset in webkit [211763] by Brent Fulgham

• 6 edits in trunk

Correct File Path Handling in SecurityOrigin and FileSystem
​https://bugs.webkit.org/show_bug.cgi?id=167894
<rdar://problem/30380080>

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Roll out the URL decoding being done in the FileSystem class (added in Bug 167894), and instead ensure that
SecurityOrigin properly handles file URLs, and only passes valid file strings to the FileSystem interface.

Tested by FileSystemTests and SecurityOriginTests in TestWebKitAPI.

• page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::SecurityOrigin): Initialize m_filePath using the url's fileSystemPath, not
the %-encoded 'path' property.
(WebCore::SecurityOrigin::canDisplay): Pass the 'fileSystemPath' to 'filesHaveSameVolume', rather than
the %-encoded 'path' property.

• page/SecurityOrigin.h:
• platform/FileSystem.cpp:

(WebCore::filesHaveSameVolume): Do not use 'decodeURLEscapeSequences' in 'filesHaveSameVolume'.

Tools:

• TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,

and perform same-volume checks using filesystem-compatible paths.

• TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from

filesystem paths, and perform validation of same-volume checks.
(TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
(TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
(TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
(TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.

5:39 PM Changeset in webkit [211762] by aestes@apple.com

• 4 edits
  1 copy in trunk/Source/WebCore

[Cocoa] Split FileSystemMac.mm into Mac and Cocoa parts
​https://bugs.webkit.org/show_bug.cgi?id=167908

Reviewed by Sam Weinig.

Kept the Mac-only functions in FileSystemMac.mm and moved the rest into FileSystemCocoa.mm.

• PlatformMac.cmake:
• WebCore.xcodeproj/project.pbxproj:
• platform/cocoa/FileSystemCocoa.mm: Copied from Source/WebCore/platform/mac/FileSystemMac.mm.
• platform/mac/FileSystemMac.mm:

(-[WebFileManagerDelegate fileManager:shouldProceedAfterError:movingItemAtURL:toURL:]): Moved to FileSystemCocoa.mm.
(WebCore::homeDirectoryPath): Ditto.
(WebCore::openTemporaryFile): Ditto.
(WebCore::moveFile): Ditto.
(WebCore::getVolumeFreeSpace): Ditto.

5:33 PM Changeset in webkit [211761] by eric.carlson@apple.com

• 5 edits in trunk/Source/WebCore

[MediaStream Mac] Remove some unused code
​https://bugs.webkit.org/show_bug.cgi?id=167913

Reviewed by Jer Noble.

No new tests, no functional change.

• platform/mediastream/CaptureDeviceManager.h:

(WebCore::CaptureSessionInfo::~CaptureSessionInfo): Deleted.
(WebCore::CaptureSessionInfo::supportsVideoSize): Deleted.
(WebCore::CaptureSessionInfo::bestSessionPresetForVideoDimensions): Deleted.

• platform/mediastream/mac/AVCaptureDeviceManager.h:
• platform/mediastream/mac/AVCaptureDeviceManager.mm:

(WebCore::AVCaptureDeviceManager::refreshCaptureDeviceList):
(WebCore::AVCaptureSessionInfo::AVCaptureSessionInfo): Deleted.
(WebCore::AVCaptureSessionInfo::supportsVideoSize): Deleted.
(WebCore::AVCaptureSessionInfo::bestSessionPresetForVideoDimensions): Deleted.

• platform/mediastream/mac/AVMediaCaptureSource.mm:

(WebCore::AVMediaCaptureSource::AVMediaCaptureSource):

5:20 PM Changeset in webkit [211760] by Simon Fraser

• 2 edits in trunk/Source/WebKit2

Tiled scrolling indicator gets doubled up on navigation
​https://bugs.webkit.org/show_bug.cgi?id=167909

Reviewed by Tim Horton.

TiledCoreAnimationDrawingArea::updateDebugInfoLayer() would parent a new m_debugInfoLayer
in m_hostingLayer without removing the old one, causing the old tiled scrolling indicator layer
hierarchy to get left in the layer tree.

Also a couple of nullptr/0 -> nil.

• WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
(WebKit::TiledCoreAnimationDrawingArea::updateDebugInfoLayer):

4:29 PM Changeset in webkit [211759] by matthew_hanson@apple.com

• 1 copy in tags/Safari-603.1.25

Tag Safari-603.1.25.

4:25 PM Changeset in webkit [211758] by commit-queue@webkit.org

• 10 edits
  2 adds in trunk

Allow some schemes to opt-out of CORS
​https://bugs.webkit.org/show_bug.cgi?id=167795

Patch by Youenn Fablet <​youennf@gmail.com> on 2017-02-06
Reviewed by Alex Christensen.

Source/WebCore:

Test: http/tests/security/bypassing-cors-checks-for-extension-urls.html

Adding the possibility to opt out of CORS for DocumentThreadableLoader clients (fetch and XHR).
This is made specific to the case of user extension URLs for pages running user scripts.
Introducing a boolean flag in Page for that purpose.
Introducing a helper routine in SchemeRegistry to centralize the various user script extension schemes.

• loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::DocumentThreadableLoader):

• page/Frame.cpp:

(WebCore::Frame::injectUserScripts):

• page/Page.h:

(WebCore::Page::setAsRunningUserScripts):
(WebCore::Page::isRunningUserScripts):

• platform/SchemeRegistry.cpp:

(WebCore::SchemeRegistry::isUserExtensionScheme):

• platform/SchemeRegistry.h:
• testing/Internals.cpp:

(WebCore::Internals::setAsRunningUserScripts):

• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

• http/tests/security/bypassing-cors-checks-for-extension-urls-expected.txt: Added.
• http/tests/security/bypassing-cors-checks-for-extension-urls.html: Added.

3:56 PM Changeset in webkit [211757] by achristensen@apple.com

• 2 edits in trunk/Source/WebKit2

More build fixes after r211751
​https://bugs.webkit.org/show_bug.cgi?id=166998

• NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::NetworkDataTaskSoup):
(WebKit::NetworkDataTaskSoup::authenticate):
(WebKit::NetworkDataTaskSoup::continueAuthenticate):
(WebKit::NetworkDataTaskSoup::continueHTTPRedirection):
Use the correct partition for credentials.

3:50 PM Changeset in webkit [211756] by Chris Dumez

• 11 edits in trunk

Align OwnPropertyKeys with the HTML specification for cross-origin Window / Location objects
​https://bugs.webkit.org/show_bug.cgi?id=167647
<rdar://problem/30339489>

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline web platform test now that more checks are passing.

• web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt:

Source/WebCore:

Align OwnPropertyKeys with the HTML specification for cross-origin Window / Location objects:

• ​https://html.spec.whatwg.org/#windowproxy-ownpropertykeys [1]
• ​https://html.spec.whatwg.org/#crossoriginownpropertykeys-(-o-) [2]
• ​https://html.spec.whatwg.org/#crossoriginproperties-(-o-) [3]

In particular, the following changes were made:

• Location:
  • We now return the following symbols as well: @@toStringTag, @@hasInstance, @@isConcatSpreadable as per [2].
• Window:
  • We now return the following symbols as well: @@toStringTag, @@hasInstance, @@isConcatSpreadable as per [2].
  • We now return the indices of the child browsing contexts as per [1].
  • We now return the names of the child browsing contexts as per [3].

No new tests, updated / rebaselined existing tests.

• bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
Index properties should be configurable as per:

• ​https://html.spec.whatwg.org/#windowproxy-getownproperty (step 2.5)

(WebCore::inScope):
(WebCore::addScopedChildrenNames):
(WebCore::addCrossOriginPropertyNames):
(WebCore::addScopedChildrenIndexes):
(WebCore::addCrossOriginOwnPropertyNames):
(WebCore::JSDOMWindow::getOwnPropertyNames):

• bindings/js/JSLocationCustom.cpp:

(WebCore::addCrossOriginPropertyNames):
(WebCore::addCrossOriginOwnPropertyNames):
(WebCore::JSLocation::getOwnPropertyNames):

LayoutTests:

Extend test coverage for OwnPropertyKeys for cross-origin Window / Location objects.

• http/tests/security/cross-frame-access-enumeration-expected.txt:
• http/tests/security/cross-frame-access-enumeration.html:
• http/tests/security/resources/cross-frame-iframe-for-enumeration-test.html:
• js/dom/getOwnPropertyDescriptor-expected.txt:
• js/resources/getOwnPropertyDescriptor.js:

3:47 PM Changeset in webkit [211755] by yoav@yoav.ws

• 10 edits in trunk

http/tests/preload/dynamic_removing_preload.html fails to test what it should
​https://bugs.webkit.org/show_bug.cgi?id=167792

Reviewed by Ryosuke Niwa.

Source/WebCore:

Cancel the link preload resource load when the link element is removed from the DOM.

No new tests, but unskipping an existing test: http/tests/preload/dynamic_removing_preload.html

• html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::removedFrom): Call m_linkLoader.cancelLoad().

• loader/LinkLoader.cpp:

(WebCore::LinkLoader::cancelLoad): Clear m_preloadResourceClient.

• loader/LinkLoader.h:
• loader/LinkPreloadResourceClients.h:

(WebCore::LinkPreloadResourceClient::clearResource): Call m_resource->cancelLoad().

• loader/SubresourceLoader.cpp:

(WebCore::LinkPreloadResourceClient::didFinishLoading): Change ASSERT to exempt cancelled loads.

LayoutTests:

• TestExpectations: Unskip dynamic_removing_preload.html
• http/tests/preload/dynamic_removing_preload-expected.txt:
• http/tests/preload/dynamic_removing_preload.html: Switch test to use ResourceTiming.

3:47 PM Changeset in webkit [211754] by achristensen@apple.com

• 5 edits in trunk/Source

More build fixes after r211751
​https://bugs.webkit.org/show_bug.cgi?id=166998

Source/WebCore:

• platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::applyAuthenticationToRequest):

• platform/network/soup/SocketStreamHandleImplSoup.cpp:

(WebCore::SocketStreamHandleImpl::create):

Source/WebKit/win:

• WebDownloadCFNet.cpp:

(WebDownload::didReceiveAuthenticationChallenge):

3:27 PM Changeset in webkit [211753] by achristensen@apple.com

• 5 edits in trunk/Source/WebCore

Fix non-cocoa builds after r211751.
​https://bugs.webkit.org/show_bug.cgi?id=166998

• platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::createCFURLConnection):
(WebCore::ResourceHandle::willSendRequest):
(WebCore::ResourceHandle::tryHandlePasswordBasedAuthentication):
(WebCore::ResourceHandle::receivedCredential):

• platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):

• platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::applyAuthenticationToRequest):

• platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::applyAuthenticationToRequest):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):

3:02 PM Changeset in webkit [211752] by jer.noble@apple.com

• 2 edits in trunk/Source/WebKit2

Update sandbox to allow CoreMedia to perform custom media loading.
​https://bugs.webkit.org/show_bug.cgi?id=167700

Reviewed by Alexey Proskuryakov.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:

2:45 PM Changeset in webkit [211751] by achristensen@apple.com

• 25 edits
  14 adds in trunk

credentials should be partitioned by main document domain
​https://bugs.webkit.org/show_bug.cgi?id=166998
Source/WebCore:

rdar://problem/22901123

Reviewed by Brady Eidson.

Covered by http/tests/security/credentials-iframes.html
Also added http/tests/security/credentials-from-different-domains.html to verify existing behavior without iframes.

• Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::connect):

• dom/Document.h:
• page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::domainForCachePartition):
Return emptyString instead of a null String because it is used as a key in a HashMap, and hashing null strings dereferences null.

• page/SocketProvider.cpp:

(WebCore::SocketProvider::createSocketStreamHandle):

• page/SocketProvider.h:
• platform/network/CredentialStorage.cpp:

(WebCore::CredentialStorage::set):
(WebCore::CredentialStorage::get):
(WebCore::CredentialStorage::remove):

• platform/network/CredentialStorage.h:

Partition credentials.

• platform/network/ResourceHandleInternal.h:

(WebCore::ResourceHandleInternal::ResourceHandleInternal):

• platform/network/cf/SocketStreamHandleImpl.h:

(WebCore::SocketStreamHandleImpl::create):

• platform/network/cf/SocketStreamHandleImplCFNet.cpp:

(WebCore::SocketStreamHandleImpl::SocketStreamHandleImpl):
(WebCore::SocketStreamHandleImpl::getStoredCONNECTProxyCredentials):

• platform/network/curl/SocketStreamHandleImpl.h:

(WebCore::SocketStreamHandleImpl::create):

• platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::createNSURLConnection):
(WebCore::ResourceHandle::willSendRequest):
(WebCore::ResourceHandle::tryHandlePasswordBasedAuthentication):
(WebCore::ResourceHandle::receivedCredential):

• platform/network/soup/SocketStreamHandleImpl.h:

Source/WebKit/mac:

rdar://problem/22901123

Reviewed by Brady Eidson.

• Misc/WebDownload.mm:
• Plugins/WebBaseNetscapePluginView.mm:

(WebKit::getAuthenticationInfo):
Don't use partitioned credentials for WebKit1 plugins or downloads.
Downloads should be authenticated before becoming a download anyways.

Source/WebKit2:

rdar://problem/22901123

Reviewed by Brady Eidson.

• NetworkProcess/NetworkDataTask.cpp:

(WebKit::NetworkDataTask::NetworkDataTask):

• NetworkProcess/NetworkDataTask.h:

(WebKit::NetworkDataTask::partition):

• NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::NetworkDataTaskCocoa):
(WebKit::NetworkDataTaskCocoa::willPerformHTTPRedirection):
(WebKit::NetworkDataTaskCocoa::tryPasswordBasedAuthentication):

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):

• WebProcess/Network/WebSocketProvider.cpp:

(WebKit::WebSocketProvider::createSocketStreamHandle):

• WebProcess/Network/WebSocketProvider.h:
• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::getAuthenticationInfo):

LayoutTests:

<rdar://problem/22901123>

Reviewed by Brady Eidson.

• http/tests/security/credentials-from-different-domains-expected.txt: Added.
• http/tests/security/credentials-from-different-domains.html: Added.
• http/tests/security/credentials-iframes-expected.txt: Added.
• http/tests/security/credentials-iframes.html: Added.
• http/tests/security/resources/cors-basic-auth.php: Added.
• http/tests/security/resources/credentials-from-different-domains-continued-1.html: Added.
• http/tests/security/resources/credentials-from-different-domains-continued-2.html: Added.
• http/tests/security/resources/credentials-iframes-continued.html: Added.
• http/tests/security/resources/credentials-iframes-different-domain.html: Added.
• http/tests/security/resources/credentials-iframes-same-domain.html: Added.
• platform/mac-wk1/http: Added.
• platform/mac-wk1/http/security: Added.
• platform/mac-wk1/http/security/credentials-iframes-expected.txt: Added.

DumpRenderTree prints out the entire URL of the authentication challenge.
WebKitTestRunner only prints out the host and port.
Both results show the fact that no credentials were sent on the second request.

2:33 PM Changeset in webkit [211750] by Simon Fraser

• 8 edits in trunk

Safari pages are blank sometimes (missing tiles)
​https://bugs.webkit.org/show_bug.cgi?id=167904

Reviewed by Tim Horton.

Source/WebCore:

After r211683 we failed to udpate the "inWindow" flag on the page tiled layer, because
usingTiledBacking() on GraphicsLayer confusingly was false for the page tiled layer.

Fix by removing usingTiledBacking() entirely, and checking for tiledBacking(),
looking at the layer type when necessary.

Tested by tiled-drawing/tiled-backing-in-window.html

• platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::GraphicsLayer):
(WebCore::GraphicsLayer::setIsInWindowIncludingDescendants): This is the bug fix.
(WebCore::GraphicsLayer::getDebugBorderInfo):
(WebCore::GraphicsLayer::dumpProperties):

• platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::usingTiledBacking): Deleted.

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::recursiveCommitChanges):
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::changeLayerTypeTo):

• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::willDestroyLayer):
(WebCore::RenderLayerBacking::compositingLayerType):

• rendering/RenderLayerCompositor.cpp: A bit more logging.

(WebCore::RenderLayerCompositor::setIsInWindow):
(WebCore::RenderLayerCompositor::attachRootLayer):

LayoutTests:

New result; this test detected the bug.

• tiled-drawing/tiled-backing-in-window-expected.txt:

2:20 PM Changeset in webkit [211749] by achristensen@apple.com

• 1 edit
  1 delete in trunk/Source/ThirdParty/libwebrtc

[WebRTC] Remove unneeded build directory accidentally checked in with libwebrtc source.

Reviewed by Youenn Fablet.

• third_party/usrsctp/build: Removed.

1:58 PM Changeset in webkit [211748] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

Change the CSS animation timer a to be little more than 60fps to ensure we hit that frame rate
​https://bugs.webkit.org/show_bug.cgi?id=167825

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2017-02-06
Reviewed by Simon Fraser.

The system timer fires little bit slower than 60fps. This might cause the
frame to be missed and hence it can lower the frame rate significantly. The
rAF timer was set to 15ms for the same reason. So set the repeated CSS
animation timer also to 15ms.

• page/animation/CSSAnimationController.cpp:

1:49 PM Changeset in webkit [211747] by andersca@apple.com

• 12 edits
  1 add in trunk/Source/WebKit2

Crash child processes if they receive an invalid message
​https://bugs.webkit.org/show_bug.cgi?id=167900

Reviewed by Dan Bernstein.

Previously, some processes would try to gracefully exit, others would just drop messages leading to weird bugs.
Instead, set app-specific crash information to the message that failed to be decoded, and then crash.

• DatabaseProcess/DatabaseProcess.cpp:

(WebKit::DatabaseProcess::didReceiveInvalidMessage): Deleted.

• DatabaseProcess/DatabaseProcess.h:
• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::didReceiveInvalidMessage): Deleted.

• NetworkProcess/NetworkProcess.h:
• PluginProcess/PluginProcess.cpp:

(WebKit::PluginProcess::didReceiveInvalidMessage): Deleted.

• PluginProcess/PluginProcess.h:
• Shared/ChildProcess.h:
• Shared/Cocoa/ChildProcessCocoa.mm: Added.

(WebKit::ChildProcess::didReceiveInvalidMessage):

• WebKit2.xcodeproj/project.pbxproj:
• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveInvalidMessage): Deleted.

• WebProcess/WebProcess.h:

1:49 PM Changeset in webkit [211746] by jer.noble@apple.com

• 14 edits
  10 adds in trunk

Playback stalls when a SourceBuffer append causes frame eviction
​https://bugs.webkit.org/show_bug.cgi?id=167834

Reviewed by Eric Carlson.

PerformanceTests:

Add an in-page performance test measuring the amount of time required
to append a large amount of media data to a SourceBuffer, and then to
completely remove that data 30s at a time.

Add a microbenchmark for MediaTime which measures the amount of time
required to create a 1M entry std::map and traverse the map 1M times.

• Media/MSERemoveCodedFrames.html: Added.
• Media/media-source-loader.js:

(MediaSourceLoader.prototype.get duration):

• MediaTime/Configurations/Base.xcconfig: Added.
• MediaTime/Configurations/DebugRelease.xcconfig: Added.
• MediaTime/Makefile: Added.
• MediaTime/MediaTime.xcodeproj/project.pbxproj: Added.
• MediaTime/main.cpp: Added.

(performTest):
(test):
(main):

• Skipped:

Source/WebCore:

Test: PerformanceTests/Media/MSERemoveCodedFrames.html

Optimize searching through SampleMap by presentationTime.

Many of the methods exposed by PresentationOrderSampleMap used the bare std::equal_range,
lower_bound, or upper_bound methods. Unlike those methods exposed on std::map, the bare
search methods perform a linear O(n) search, rather than a the binary O(log(n)) search used
by std::map. Rewrite those methods using the bare methods in terms of the std::map search
methods.

Drive-by fix: rename findSampleOnOrAfterPresentationTime to
findSampleStartingOnOrAfterPresentationTime to make the behavior of the method more
explicit.

• Modules/mediasource/SampleMap.cpp:

(WebCore::PresentationOrderSampleMap::findSampleContainingPresentationTime):
(WebCore::PresentationOrderSampleMap::findSampleStartingOnOrAfterPresentationTime):
(WebCore::PresentationOrderSampleMap::reverseFindSampleBeforePresentationTime):
(WebCore::DecodeOrderSampleMap::findSyncSampleAfterPresentationTime):
(WebCore::PresentationOrderSampleMap::findSamplesBetweenPresentationTimes):
(WebCore::PresentationOrderSampleMap::findSamplesWithinPresentationRange):
(WebCore::PresentationOrderSampleMap::findSampleOnOrAfterPresentationTime): Deleted.

• Modules/mediasource/SampleMap.h:

(WebCore::PresentationOrderSampleMap::begin):
(WebCore::PresentationOrderSampleMap::end):
(WebCore::PresentationOrderSampleMap::rbegin):
(WebCore::PresentationOrderSampleMap::rend):
(WebCore::DecodeOrderSampleMap::begin):
(WebCore::DecodeOrderSampleMap::end):
(WebCore::DecodeOrderSampleMap::rbegin):
(WebCore::DecodeOrderSampleMap::rend):
(WebCore::SampleMap::SampleMap):
(WebCore::SampleMap::sizeInBytes):
(WebCore::SampleMap::decodeOrder):
(WebCore::SampleMap::presentationOrder):

• Modules/mediasource/SourceBuffer.cpp:

(WebCore::removeSamplesFromTrackBuffer):
(WebCore::SourceBuffer::removeCodedFrames):
(WebCore::SourceBuffer::reenqueueMediaForTime):

• WebCore.xcodeproj/project.pbxproj:

Source/WTF:

Optimize the MediaTime class; specifically the compare() method. The class only
needs 6 bits to store the TimeFlags, so make that a uint8_t rather than uint32_t.
The implementation is slightly simpler if the TimeScale is unsigned, so make that
a uint32_t rather than int32_t. Inline the comparison operators. Optimize the equality
comparison by bitwise-and'ing the flags together and masking the result. Optimize for
common comparison scenarios (equal timeScales, equal timeValues(), etc.). Attempt the
mathematically simpler simpler method for comparing ratios, and only fall back to the
complex method if the results of multiplying the timeScale by the timeValue overflows.

• wtf/MediaTime.cpp:

(WTF::greatestCommonDivisor):
(WTF::leastCommonMultiple):
(WTF::signum):
(WTF::MediaTime::MediaTime):
(WTF::MediaTime::createWithFloat):
(WTF::MediaTime::createWithDouble):
(WTF::MediaTime::operator+):
(WTF::MediaTime::operator-):
(WTF::MediaTime::operator!):
(WTF::MediaTime::operator bool):
(WTF::MediaTime::compare):
(WTF::MediaTime::setTimeScale):
(WTF::abs):
(WTF::MediaTime::operator<): Deleted.
(WTF::MediaTime::operator>): Deleted.
(WTF::MediaTime::operator!=): Deleted.
(WTF::MediaTime::operator==): Deleted.
(WTF::MediaTime::operator>=): Deleted.
(WTF::MediaTime::operator<=): Deleted.

• wtf/MediaTime.h:

Tools:

Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
for the WTF::MediaTime class.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WTF/MediaTime.cpp:

(TestWebKitAPI::TEST):

• TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.

(WTF::operator<<):
(TestWebKitAPI::TestSample::create):
(TestWebKitAPI::TestSample::TestSample):
(TestWebKitAPI::TEST_F):

12:49 PM Changeset in webkit [211745] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Skip media/audio-dealloc-crash.html on ios-simulator.

Unreviewed test gardening.

• platform/ios-simulator/TestExpectations:

12:18 PM Changeset in webkit [211744] by Chris Dumez

• 8 edits
  3 deletes in trunk/Source/WebKit2

[WK2] Drop legacy WKBundlePageDiagnosticLoggingClient API
​https://bugs.webkit.org/show_bug.cgi?id=167883
<rdar://problem/30376695>

Reviewed by Sam Weinig.

Drop legacy WKBundlePageDiagnosticLoggingClient API as I am not aware of any remaining client.
All clients have now switched to the equivalent UIProcess-side API.

• WebKit2.xcodeproj/project.pbxproj:
• WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSetDiagnosticLoggingClient): Deleted.

• WebProcess/InjectedBundle/API/c/WKBundlePage.h:
• WebProcess/InjectedBundle/API/c/WKBundlePageDiagnosticLoggingClient.h: Removed.
• WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp: Removed.
• WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h: Removed.
• WebProcess/WebCoreSupport/WebDiagnosticLoggingClient.cpp:

(WebKit::WebDiagnosticLoggingClient::logDiagnosticMessage):
(WebKit::WebDiagnosticLoggingClient::logDiagnosticMessageWithResult):
(WebKit::WebDiagnosticLoggingClient::logDiagnosticMessageWithValue):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::close):
(WebKit::WebPage::initializeInjectedBundleDiagnosticLoggingClient): Deleted.

• WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::injectedBundleUIClient):
(WebKit::WebPage::injectedBundleDiagnosticLoggingClient): Deleted.

12:06 PM Changeset in webkit [211743] by sbarati@apple.com

• 3 edits in trunk/PerformanceTests

Make ARES-6 work from the CLI again
​https://bugs.webkit.org/show_bug.cgi?id=167895

Reviewed by Michael Saboff.

• ARES-6/driver.js:

(Driver.prototype.readyTrigger):
(Driver.prototype.disableTrigger):

• ARES-6/stats.js:

(Stats.prototype.toString.span.span):
(Stats.prototype.toString.return.span):
(Stats.prototype.toString):

11:46 AM Changeset in webkit [211742] by Ryan Haddad

• 2 edits in trunk/Tools

Change capitalization in platform name after r211735.

Unreviewed dashboard fix.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):

11:21 AM Changeset in webkit [211741] by commit-queue@webkit.org

• 30 edits
  3 moves in trunk/Source

Rename AnimationController to CSSAnimationController
​https://bugs.webkit.org/show_bug.cgi?id=167829

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2017-02-06
Reviewed by Simon Fraser.

Source/WebCore:

AnimationController is a very generic name. The current function of this
class is CSS animation.

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:
• css/CSSComputedStyleDeclaration.cpp:

(WebCore::computeRenderStyleForProperty):

• dom/Document.cpp:
• history/CachedFrame.cpp:
• page/Frame.cpp:

(WebCore::Frame::Frame):

• page/Frame.h:

(WebCore::Frame::animation):

• page/FrameView.cpp:
• page/Page.cpp:
• page/animation/AnimationBase.cpp:
• page/animation/CSSAnimationController.cpp: Renamed from Source/WebCore/page/animation/AnimationController.cpp.

(WebCore::AnimationPrivateUpdateBlock::AnimationPrivateUpdateBlock):
(WebCore::AnimationPrivateUpdateBlock::~AnimationPrivateUpdateBlock):
(WebCore::CSSAnimationControllerPrivate::CSSAnimationControllerPrivate):
(WebCore::CSSAnimationControllerPrivate::~CSSAnimationControllerPrivate):
(WebCore::CSSAnimationControllerPrivate::ensureCompositeAnimation):
(WebCore::CSSAnimationControllerPrivate::clear):
(WebCore::CSSAnimationControllerPrivate::updateAnimations):
(WebCore::CSSAnimationControllerPrivate::updateAnimationTimerForRenderer):
(WebCore::CSSAnimationControllerPrivate::updateAnimationTimer):
(WebCore::CSSAnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
(WebCore::CSSAnimationControllerPrivate::fireEventsAndUpdateStyle):
(WebCore::CSSAnimationControllerPrivate::startUpdateStyleIfNeededDispatcher):
(WebCore::CSSAnimationControllerPrivate::addEventToDispatch):
(WebCore::CSSAnimationControllerPrivate::addElementChangeToDispatch):
(WebCore::CSSAnimationControllerPrivate::animationFrameCallbackFired):
(WebCore::CSSAnimationControllerPrivate::animationTimerFired):
(WebCore::CSSAnimationControllerPrivate::isRunningAnimationOnRenderer):
(WebCore::CSSAnimationControllerPrivate::isRunningAcceleratedAnimationOnRenderer):
(WebCore::CSSAnimationControllerPrivate::suspendAnimations):
(WebCore::CSSAnimationControllerPrivate::resumeAnimations):
(WebCore::CSSAnimationControllerPrivate::animationsAreSuspendedForDocument):
(WebCore::CSSAnimationControllerPrivate::detachFromDocument):
(WebCore::CSSAnimationControllerPrivate::suspendAnimationsForDocument):
(WebCore::CSSAnimationControllerPrivate::resumeAnimationsForDocument):
(WebCore::CSSAnimationControllerPrivate::startAnimationsIfNotSuspended):
(WebCore::CSSAnimationControllerPrivate::setAllowsNewAnimationsWhileSuspended):
(WebCore::CSSAnimationControllerPrivate::pauseAnimationAtTime):
(WebCore::CSSAnimationControllerPrivate::pauseTransitionAtTime):
(WebCore::CSSAnimationControllerPrivate::beginAnimationUpdateTime):
(WebCore::CSSAnimationControllerPrivate::beginAnimationUpdate):
(WebCore::CSSAnimationControllerPrivate::endAnimationUpdate):
(WebCore::CSSAnimationControllerPrivate::receivedStartTimeResponse):
(WebCore::CSSAnimationControllerPrivate::getAnimatedStyleForRenderer):
(WebCore::CSSAnimationControllerPrivate::computeExtentOfAnimation):
(WebCore::CSSAnimationControllerPrivate::numberOfActiveAnimations):
(WebCore::CSSAnimationControllerPrivate::addToAnimationsWaitingForStyle):
(WebCore::CSSAnimationControllerPrivate::removeFromAnimationsWaitingForStyle):
(WebCore::CSSAnimationControllerPrivate::styleAvailable):
(WebCore::CSSAnimationControllerPrivate::addToAnimationsWaitingForStartTimeResponse):
(WebCore::CSSAnimationControllerPrivate::removeFromAnimationsWaitingForStartTimeResponse):
(WebCore::CSSAnimationControllerPrivate::startTimeResponse):
(WebCore::CSSAnimationControllerPrivate::animationWillBeRemoved):
(WebCore::CSSAnimationControllerPrivate::addToAnimationsDependentOnScroll):
(WebCore::CSSAnimationControllerPrivate::removeFromAnimationsDependentOnScroll):
(WebCore::CSSAnimationControllerPrivate::scrollWasUpdated):
(WebCore::CSSAnimationController::CSSAnimationController):
(WebCore::CSSAnimationController::~CSSAnimationController):
(WebCore::CSSAnimationController::cancelAnimations):
(WebCore::CSSAnimationController::updateAnimations):
(WebCore::CSSAnimationController::getAnimatedStyleForRenderer):
(WebCore::CSSAnimationController::computeExtentOfAnimation):
(WebCore::CSSAnimationController::notifyAnimationStarted):
(WebCore::CSSAnimationController::pauseAnimationAtTime):
(WebCore::CSSAnimationController::numberOfActiveAnimations):
(WebCore::CSSAnimationController::pauseTransitionAtTime):
(WebCore::CSSAnimationController::isRunningAnimationOnRenderer):
(WebCore::CSSAnimationController::isRunningAcceleratedAnimationOnRenderer):
(WebCore::CSSAnimationController::isSuspended):
(WebCore::CSSAnimationController::suspendAnimations):
(WebCore::CSSAnimationController::resumeAnimations):
(WebCore::CSSAnimationController::allowsNewAnimationsWhileSuspended):
(WebCore::CSSAnimationController::setAllowsNewAnimationsWhileSuspended):
(WebCore::CSSAnimationController::serviceAnimations):
(WebCore::CSSAnimationController::animationsAreSuspendedForDocument):
(WebCore::CSSAnimationController::detachFromDocument):
(WebCore::CSSAnimationController::suspendAnimationsForDocument):
(WebCore::CSSAnimationController::resumeAnimationsForDocument):
(WebCore::CSSAnimationController::startAnimationsIfNotSuspended):
(WebCore::CSSAnimationController::beginAnimationUpdate):
(WebCore::CSSAnimationController::endAnimationUpdate):
(WebCore::CSSAnimationController::supportsAcceleratedAnimationOfProperty):
(WebCore::CSSAnimationController::wantsScrollUpdates):
(WebCore::CSSAnimationController::scrollWasUpdated):
(WebCore::CSSAnimationController::hasAnimations):

• page/animation/CSSAnimationController.h: Renamed from Source/WebCore/page/animation/AnimationController.h.

(WebCore::AnimationUpdateBlock::AnimationUpdateBlock):
(WebCore::AnimationUpdateBlock::~AnimationUpdateBlock):

• page/animation/CSSAnimationControllerPrivate.h: Renamed from Source/WebCore/page/animation/AnimationControllerPrivate.h.

(WebCore::CSSAnimationControllerPrivate::hasAnimations):
(WebCore::CSSAnimationControllerPrivate::isSuspended):
(WebCore::CSSAnimationControllerPrivate::setBeginAnimationUpdateTime):
(WebCore::CSSAnimationControllerPrivate::allowsNewAnimationsWhileSuspended):
(WebCore::CSSAnimationControllerPrivate::wantsScrollUpdates):
(WebCore::CSSAnimationControllerPrivate::scrollPosition):

• page/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::singleton):

• page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::CompositeAnimation):

• page/animation/CompositeAnimation.h:

(WebCore::CompositeAnimation::create):
(WebCore::CompositeAnimation::animationController):

• page/animation/ImplicitAnimation.cpp:
• page/animation/KeyframeAnimation.cpp:
• page/ios/FrameIOS.mm:
• platform/graphics/GraphicsLayer.h:
• rendering/RenderElement.h:
• rendering/RenderLayer.cpp:
• rendering/RenderLayerBacking.cpp:
• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForAnimation):

• rendering/RenderObject.cpp:
• rendering/RenderObject.h:

(WebCore::RenderObject::animation):

• testing/Internals.cpp:

Source/WebKit/mac:

• WebView/WebFrame.mm:
• WebView/WebView.mm:

Source/WebKit/win:

• WebFrame.cpp:

11:16 AM Changeset in webkit [211740] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Static Analyzer: JSContext.mm: Incorrect decrement of the reference count of an object
​https://bugs.webkit.org/show_bug.cgi?id=167848

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-02-06
Reviewed by Saam Barati.

Source/JavaScriptCore/API/JSContext.mm:87:5: warning: Incorrect decrement of the reference count of an object that is not owned at this point by the caller

[self.exceptionHandler release];

1 warning generated.

• API/JSContext.mm:

(-[JSContext dealloc]):
Use the ivar in dealloc instead of going through the getter.

11:13 AM Changeset in webkit [211739] by Jon Davis

• 3 edits
  2 adds in trunk/Websites/webkit.org

Add a survey to learn how people use WebKit Nightly builds
​https://bugs.webkit.org/show_bug.cgi?id=167748

Reviewed by Joseph Pecoraro.

• wp-content/themes/webkit/functions.php:
• wp-content/themes/webkit/nightly-start.php:
• wp-content/themes/webkit/nightly-survey.php: Added.
• wp-content/themes/webkit/survey.json: Added.

11:06 AM Changeset in webkit [211738] by Alan Bujtas

• 11 edits in trunk/Source/WebCore

Simple line layout: Use simplified text measuring when possible.
​https://bugs.webkit.org/show_bug.cgi?id=167843
<rdar://problem/30364907>

Reviewed by Antti Koivisto.

This patch adds a simplified version of text width measuring.
Certain type of text runs (no spacing etc) only require a subset of what we
currently do in FontCascade::width().

• platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::widthForSimpleText):

• platform/graphics/FontCascade.h:
• platform/graphics/WidthCache.h:

(WebCore::WidthCache::add):
(WebCore::WidthCache::addSlowCase):

• platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::advanceInternal):

• rendering/RenderText.cpp:

(WebCore::RenderText::styleDidChange):
(WebCore::RenderText::setRenderedText):
(WebCore::RenderText::computeCanUseSimplifiedTextMeasuring):

• rendering/RenderText.h:

(WebCore::RenderText::canUseSimplifiedTextMeasuring):

• rendering/SimpleLineLayoutFlowContents.cpp:

(WebCore::SimpleLineLayout::initializeSegments):

• rendering/SimpleLineLayoutFlowContents.h:
• rendering/SimpleLineLayoutTextFragmentIterator.cpp:

(WebCore::SimpleLineLayout::TextFragmentIterator::Style::Style):
(WebCore::SimpleLineLayout::TextFragmentIterator::TextFragmentIterator):
(WebCore::SimpleLineLayout::TextFragmentIterator::textWidth):

• rendering/SimpleLineLayoutTextFragmentIterator.h:

10:59 AM Changeset in webkit [211737] by matthew_hanson@apple.com

• 4 edits in branches/safari-603-branch/Source

Merge r211666. rdar://problem/30167791

10:55 AM Changeset in webkit [211736] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Null check the WebKit::RemoteObjectProxy object before calling it
​https://bugs.webkit.org/show_bug.cgi?id=167891
rdar://problem/30229358

Reviewed by Tim Horton.

If a _WKRemoteObjectRegistry invocation reply block outlives its underlying WebKit::RemoteObjectProxy object,
we'll crash trying to send an unused reply to it. Work around this crash by adding a null check before calling
sendUnusedReply.

While this fixes the crash it will lead to leaks in the process that holds on to the reply block. A more long term fix
would be to manage the reply block checkers and call sendUnusedReply when invalidating the _WKRemoteObjectRegistry.

• Shared/API/Cocoa/_WKRemoteObjectRegistry.mm:

(-[_WKRemoteObjectRegistry _invokeMethod:]):

10:38 AM Changeset in webkit [211735] by ap@apple.com

• 5 edits in trunk/Tools

Move the Leaks bot to Sierra
​https://bugs.webkit.org/show_bug.cgi?id=167886

Reviewed by Daniel Bates.

• BuildSlaveSupport/build.webkit.org-config/config.json:
• BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
• BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:

(LeaksViewer._displayURLPrompt):

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):

10:35 AM WebKitGTK/2.14.x edited by Michael Catanzaro

(diff)

10:00 AM Changeset in webkit [211734] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit2

[Soup] Deadlock in NetworkProcess
​https://bugs.webkit.org/show_bug.cgi?id=167876

Reviewed by Michael Catanzaro.

WebKitSoupRequestInputStream uses a read lock. What is happening is that webkitSoupRequestInputStreamAddData
takes the lock, and it calls webkitSoupRequestInputStreamPendingReadAsyncComplete with the lock help. That
causes webkitSoupRequestInputStreamReadAsync to be called again to read the next chunk, but in the same run loop
operation. We don't really need the read lock because both webkitSoupRequestInputStreamAddData and
webkitSoupRequestInputStreamReadAsync shoudl always be called from the main thread.

• WebProcess/soup/WebKitSoupRequestInputStream.cpp:

(webkitSoupRequestInputStreamReadAsync): Remove the read lock and assert if called from a secondary thread.
(webkitSoupRequestInputStreamAddData): Ditto.

9:49 AM Changeset in webkit [211733] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebCore

Resource usage overlay should ignore mouse events outside bounds by default
​https://bugs.webkit.org/show_bug.cgi?id=167874

Reviewed by Andreas Kling.

It's overriding the default causing that the first click after the overlay is shown is always handled by the
overlay even when clicked outside bounds. It should only be set false while dragging.

• page/ResourceUsageOverlay.cpp:

(WebCore::ResourceUsageOverlay::initialize):

9:47 AM Changeset in webkit [211732] by Chris Dumez

• 5 edits
  2 deletes in trunk/LayoutTests/imported/w3c

Re-sync html/browsers/origin/cross-origin-objects tests
​https://bugs.webkit.org/show_bug.cgi?id=167881

Reviewed by Youenn Fablet.

Re-sync html/browsers/origin/cross-origin-objects tests from upstream a052787d.

• web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions-expected.txt: Removed.
• web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions.html: Removed.
• web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects-expected.txt:
• web-platform-tests/html/browsers/origin/cross-origin-objects/cross-origin-objects.html:
• web-platform-tests/html/browsers/origin/cross-origin-objects/frame.html:
• web-platform-tests/html/browsers/origin/cross-origin-objects/w3c-import.log:

9:36 AM Changeset in webkit [211731] by Ryan Haddad

• 2 edits in trunk/PerformanceTests

Skip ARES-6 on performance bots
​https://bugs.webkit.org/show_bug.cgi?id=167863

Unreviewed test gardening.

ES6SampleBench was renamed to ARES-6, so this should be updated in PerformanceTests/Skipped as well.

• Skipped:

9:35 AM Changeset in webkit [211730] by Antti Koivisto

• 2 edits in trunk/Source/WebCore

CrashTracer: com.apple.WebKit.WebContent at WebCore: WebCore::Node::invalidateStyle
​https://bugs.webkit.org/show_bug.cgi?id=167878
rdar://problem/30251840

Reviewed by Andreas Kling.

Speculative fix.

We are trying to invalidate a null node from ~PostResolutionCallbackDisabler. Looks like the only way
this could happen is if HTMLFrameOwnerElement::scheduleinvalidateStyleAndLayerComposition is called
with null 'this'. There is one place where this might happen.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::attachRootLayer): Add null check.

9:28 AM Changeset in webkit [211729] by Ryan Haddad

• 11 edits
  2 deletes in trunk

Unreviewed, rolling out r211722.

This change introduced a LayoutTest failure on mac-wk2.

Reverted changeset:

"[Modern Media Controls] Improve handling of <video> with only
audio tracks"
​https://bugs.webkit.org/show_bug.cgi?id=167836
​http://trac.webkit.org/changeset/211722

9:22 AM Changeset in webkit [211728] by eric.carlson@apple.com

• 19 edits
  2 adds in trunk/Source/WebCore

[MediaStream Mac] Stop using AVSampleBufferAudioRenderer
​https://bugs.webkit.org/show_bug.cgi?id=167821

Reviewed by Jer Noble.

• WebCore.xcodeproj/project.pbxproj: Add new files.

• platform/audio/mac/AudioSampleDataSource.cpp:

(WebCore::AudioSampleDataSource::pullSamplesInternal): Don't assume the first timestamp from the
render proc after a pause is zero.

Stop using an audio renderer for each audio track. No audio renderers means we don't need to use
an AVSampleBufferRenderSynchronizer.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(-[WebAVSampleBufferStatusChangeListener invalidate]): No more audio renderers.
(-[WebAVSampleBufferStatusChangeListener observeValueForKeyPath:ofObject:change:context:]): Ditto.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::MediaPlayerPrivateMediaStreamAVFObjC): Ditto.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::~MediaPlayerPrivateMediaStreamAVFObjC): Pause

audio tracks explicitly.

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::audioSourceProvider): Remove the existing code,

it was incorrect and not thread safe.

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::flushRenderers): No more audio renderers.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::ensureLayer): No more render synchronizer.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::destroyLayer): Ditto.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::play): Start each audio track.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::pause): Pause each audio track.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setVolume): Pass the command to each audio track.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::setMuted): Ditto.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::streamTime): No more render synchronizer.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::sampleBufferUpdated): Don't handle audio samples.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateTracks): Update for audio track class change. No
more render synchronizer.
(-[WebAVSampleBufferStatusChangeListener beginObservingRenderer:]): Deleted.
(-[WebAVSampleBufferStatusChangeListener stopObservingRenderer:]): Deleted.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::enqueueAudioSample): Deleted.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::requestNotificationWhenReadyForAudioData): Deleted.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::createAudioRenderer): Deleted.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::destroyAudioRenderer): Deleted.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::destroyAudioRenderers): Deleted.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::rendererStatusDidChange): Deleted.

• platform/mediastream/AudioTrackPrivateMediaStream.h:

• platform/mediastream/MediaStreamTrackPrivate.cpp:

(WebCore::MediaStreamTrackPrivate::MediaStreamTrackPrivate): add/removeObserver takes a reference,
not a pointer.
(WebCore::MediaStreamTrackPrivate::~MediaStreamTrackPrivate): Ditto.
(WebCore::MediaStreamTrackPrivate::videoSampleAvailable): Renamed from sourceHasMoreMediaData.
(WebCore::MediaStreamTrackPrivate::sourceHasMoreMediaData): Deleted.

• platform/mediastream/MediaStreamTrackPrivate.h:

• platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::addObserver): Take a reference, not a pointer.
(WebCore::RealtimeMediaSource::removeObserver): Ditto.
(WebCore::RealtimeMediaSource::videoSampleAvailable): Renamed from mediaDataUpdated.
(WebCore::RealtimeMediaSource::audioSamplesAvailable): New.
(WebCore::RealtimeMediaSource::stop): Drive-by cleanup.
(WebCore::RealtimeMediaSource::requestStop): Ditto.
(WebCore::RealtimeMediaSource::mediaDataUpdated): Deleted.

• platform/mediastream/RealtimeMediaSource.h:

• platform/mediastream/mac/AVAudioCaptureSource.h:
• platform/mediastream/mac/AVAudioCaptureSource.mm:

(WebCore::AVAudioCaptureSource::AVAudioCaptureSource):
(WebCore::AVAudioCaptureSource::addObserver):
(WebCore::AVAudioCaptureSource::shutdownCaptureSession):
(WebCore::AVAudioCaptureSource::captureOutputDidOutputSampleBufferFromConnection):
(WebCore::operator==): Deleted.
(WebCore::operator!=): Deleted.

• platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::processNewFrame): Call videoSampleAvailable, not mediaDataUpdated.

Render audio with a CoreAudio output unit.

• platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.cpp: Added.

(WebCore::AudioTrackPrivateMediaStreamCocoa::AudioTrackPrivateMediaStreamCocoa):
(WebCore::AudioTrackPrivateMediaStreamCocoa::~AudioTrackPrivateMediaStreamCocoa):
(WebCore::AudioTrackPrivateMediaStreamCocoa::playInternal):
(WebCore::AudioTrackPrivateMediaStreamCocoa::play):
(WebCore::AudioTrackPrivateMediaStreamCocoa::pause):
(WebCore::AudioTrackPrivateMediaStreamCocoa::setVolume):
(WebCore::AudioTrackPrivateMediaStreamCocoa::setupAudioUnit):
(WebCore::AudioTrackPrivateMediaStreamCocoa::audioSamplesAvailable):
(WebCore::AudioTrackPrivateMediaStreamCocoa::sourceStopped):
(WebCore::AudioTrackPrivateMediaStreamCocoa::render):
(WebCore::AudioTrackPrivateMediaStreamCocoa::inputProc):

• platform/mediastream/mac/AudioTrackPrivateMediaStreamCocoa.h: Added.

• platform/mediastream/mac/MockRealtimeAudioSourceMac.h:
• platform/mediastream/mac/MockRealtimeAudioSourceMac.mm:

(WebCore::alignTo16Bytes):
(WebCore::MockRealtimeAudioSourceMac::emitSampleBuffers):
(WebCore::MockRealtimeAudioSourceMac::reconfigure): Minor cleanup.
(WebCore::MockRealtimeAudioSourceMac::render): Ditto.

• platform/mediastream/mac/MockRealtimeVideoSourceMac.mm:

(WebCore::MockRealtimeVideoSourceMac::updateSampleBuffer): Call videoSampleAvailable, not mediaDataUpdated.

• platform/mediastream/mac/WebAudioSourceProviderAVFObjC.h:
• platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm:

(WebCore::WebAudioSourceProviderAVFObjC::~WebAudioSourceProviderAVFObjC):
(WebCore::WebAudioSourceProviderAVFObjC::provideInput): Use a mutex. Get rid of m_writeAheadCount,
it is always 0.
(WebCore::WebAudioSourceProviderAVFObjC::prepare): Use a lock.
(WebCore::WebAudioSourceProviderAVFObjC::unprepare): Ditto.
(WebCore::WebAudioSourceProviderAVFObjC::process): Ditto.

• platform/mock/MockRealtimeAudioSource.h:

(WebCore::MockRealtimeAudioSource::renderInterval): Decrease the render interval.

9:17 AM WebKitGTK/2.14.x edited by Michael Catanzaro

(diff)

9:07 AM Changeset in webkit [211727] by matthew_hanson@apple.com

• 11 edits
  2 adds in branches/safari-603-branch

Merge r211653. rdar://problem/29872943

8:54 AM Changeset in webkit [211726] by andersca@apple.com

• 2 edits in trunk/Source/WebKit2

Guard and unguard ports in a much less intrusive way
​https://bugs.webkit.org/show_bug.cgi?id=167813

Reviewed by Sam Weinig.

Instead of adopting mach_port_construct/mach_port_destruct, just guard and unguard the ports where appropriate.

• Platform/IPC/mac/ConnectionMac.mm:

(IPC::Connection::platformInitialize):
(IPC::Connection::open):

8:21 AM Changeset in webkit [211725] by Jonathan Bedard

• 3 edits in trunk/Tools

Prevent app crash on launch during simctl install workaround
​https://bugs.webkit.org/show_bug.cgi?id=167685

Reviewed by Daniel Bates.

• Scripts/webkitpy/port/simulator_process.py:

(SimulatorProcess.init): Pass environment to install.

• Scripts/webkitpy/xcode/simulator.py:

(Device.install_app): Accept environment, pass environment to launch.

8:19 AM Changeset in webkit [211724] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

[Modern Media Controls] Add a backdrop filter to the start button on macOS
​https://bugs.webkit.org/show_bug.cgi?id=167879
<rdar://problem/30375174>

Patch by Antoine Quint <Antoine Quint> on 2017-02-06
Reviewed by Eric Carlson.

Source/WebCore:

Add a backdrop filter to the start button on macOS.

Test: media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-start-button-style.html

• Modules/modern-media-controls/controls/macos-inline-media-controls.css:

(.media-controls.mac.inline > button.start > div):

LayoutTests:

Add a new test that checks that the expected backdrop filter is applied to the start button on macOS.

• media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-start-button-style-expected.txt: Added.
• media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-start-button-style.html: Added.

8:16 AM Changeset in webkit [211723] by commit-queue@webkit.org

• 22 edits
  4 copies
  10 adds in trunk

[Modern Media Controls] Bring fullscreen controls up to spec
​https://bugs.webkit.org/show_bug.cgi?id=167875
<rdar://problem/29611222>

Patch by Antoine Quint <Antoine Quint> on 2017-02-06
Reviewed by Eric Carlson.

Source/WebCore:

We update the fullscreen PiP icon to have the correct size and add two new buttons
around the volume slider, "volume-down" to bring the volume to 0 and "volume-up"
to bring the volume to 1.

To accomodate the new volume buttons, we move the volume slider inside an additional
ButtonsContainer object, along with the two new buttons.

Tests: media/modern-media-controls/volume-down-support/volume-down-support.html

media/modern-media-controls/volume-up-support/volume-up-support.html

• Modules/modern-media-controls/controls/icon-service.js:
• Modules/modern-media-controls/controls/macos-fullscreen-media-controls.css:

(.media-controls.mac.fullscreen button.volume-down):
(.media-controls.mac.fullscreen button.volume-up):

• Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js:
• Modules/modern-media-controls/controls/volume-down-button.js: Added.

(VolumeDownButton):

• Modules/modern-media-controls/controls/volume-slider.js:

(VolumeSlider):

• Modules/modern-media-controls/controls/volume-up-button.js: Added.

(VolumeUpButton):

• Modules/modern-media-controls/images/macOS/​pip-in-fullscreen@1x.png:
• Modules/modern-media-controls/images/macOS/​pip-in-fullscreen@2x.png:
• Modules/modern-media-controls/images/macOS/​volume-down-fullscreen@1x.png: Added.
• Modules/modern-media-controls/images/macOS/​volume-down-fullscreen@2x.png: Added.
• Modules/modern-media-controls/images/macOS/​volume-up-fullscreen@1x.png: Added.
• Modules/modern-media-controls/images/macOS/​volume-up-fullscreen@2x.png: Added.
• Modules/modern-media-controls/js-files:
• Modules/modern-media-controls/media/media-controller.js:

(MediaController.prototype._updateControlsIfNeeded):

• Modules/modern-media-controls/media/volume-down-support.js: Added.

(VolumeDownSupport.prototype.get control):
(VolumeDownSupport.prototype.buttonWasPressed):
(VolumeDownSupport):

• Modules/modern-media-controls/media/volume-up-support.js: Added.

(VolumeUpSupport.prototype.get control):
(VolumeUpSupport.prototype.buttonWasPressed):
(VolumeUpSupport):

• WebCore.xcodeproj/project.pbxproj:

LayoutTests:

Rebaseline some existing tests due to the addition of the volume-down and volume-up
buttons as well as the width change of the PiP icon and add a couple of new tests to
check the behavior of the volume-down and volume-up buttons.

• media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles-expected.txt:
• media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html:
• media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles-expected.txt:
• media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html:
• media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-constructor-expected.txt:
• media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-constructor.html:
• media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html:
• media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-volume-styles-expected.txt:
• media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-volume-styles.html:
• media/modern-media-controls/media-controller/media-controller-fullscreen-ltr.html:
• media/modern-media-controls/volume-down-support/volume-down-support-expected.txt: Added.
• media/modern-media-controls/volume-down-support/volume-down-support.html: Added.
• media/modern-media-controls/volume-up-support/volume-up-support-expected.txt: Added.
• media/modern-media-controls/volume-up-support/volume-up-support.html: Added.
• platform/ios-simulator/TestExpectations:

8:09 AM WebKitGTK/2.14.x edited by Michael Catanzaro

(diff)

5:48 AM Changeset in webkit [211722] by commit-queue@webkit.org

• 11 edits
  2 adds in trunk

[Modern Media Controls] Improve handling of <video> with only audio tracks
​https://bugs.webkit.org/show_bug.cgi?id=167836
<rdar://problem/30255812>

Patch by Antoine Quint <Antoine Quint> on 2017-02-06
Reviewed by Dean Jackson.

Source/WebCore:

We now check for the availability of video tracks before considering a <video>
element is displaying an actual video file and turning auto-hide on. We also
check that we have video tracks before enabling the fullscreen button. This
brings the behavior of a <video> pointing to a resource with no video tracks
to be the same as an <audio> element.

Test: media/modern-media-controls/media-controller/media-controller-video-with-only-audio.html

• Modules/modern-media-controls/media/controls-visibility-support.js:

(ControlsVisibilitySupport.prototype.get tracksToMonitor):
(ControlsVisibilitySupport.prototype._updateControls):
(ControlsVisibilitySupport):

• Modules/modern-media-controls/media/fullscreen-support.js:

(FullscreenSupport.prototype.syncControl):
(FullscreenSupport):

LayoutTests:

Add a new test to check that a <video> with a resource that only has audio tracks
does not auto-hide nor show the fullscreen button. We also rebaseline a few existing
tests for this change of behavior.

• fast/regions/inline-block-inside-anonymous-overflow-with-covered-controls-expected.html:
• fast/regions/inline-block-inside-anonymous-overflow-with-covered-controls.html:
• media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-on-expected.txt:
• media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-on.html:
• media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-toggle-expected.txt:
• media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-toggle.html:
• media/modern-media-controls/media-controller/media-controller-video-with-only-audio-expected.txt: Added.
• media/modern-media-controls/media-controller/media-controller-video-with-only-audio.html: Added.
• media/modern-media-controls/time-label/time-label-white-space-nowrap.html:

4:22 AM Changeset in webkit [211721] by magomez@igalia.com

• 3 edits in trunk/Source/WebKit2

[GTK][EFL] Release unused UpdateAtlas when in memory pressure situation
​https://bugs.webkit.org/show_bug.cgi?id=167872

Reviewed by Carlos Garcia Campos.

In a memory pressure situation, release all the unused UpdateAtlas as soon as possible, instead
of waiting 3 seconds before releasing them.

• WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::CompositingCoordinator::releaseInactiveAtlasesTimerFired):
(WebKit::CompositingCoordinator::releaseAtlases):

• WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:

3:15 AM Changeset in webkit [211720] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: sibling elements's disclosure triangles aren't vertically aligned in DOM tree outline in certain ports
​https://bugs.webkit.org/show_bug.cgi?id=167568

Patch by Fujii Hironori <Fujii Hironori> on 2017-02-06
Reviewed by Brian Burg.

The triangle has 13px height and has float:left. If the line-height
is smaller than 13px, the sibling element's triangles aren't
vertically aligned.

• UserInterface/Views/DOMTreeOutline.css:

(.tree-outline.dom li.parent): Set line-height 13px explicitly.

1:28 AM Changeset in webkit [211719] by achristensen@apple.com

• 2 edits in trunk/Tools

Rebase API tests after r211638
​https://bugs.webkit.org/show_bug.cgi?id=167779

• TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::TEST_F):
URLs with non-special schemes and characters like % in the host now fail to parse,
more like their special counterparts and according to spec.

12:51 AM Changeset in webkit [211718] by achristensen@apple.com

• 2 edits in trunk/Source/WebCore

Fix WinCairo build after r211681
​https://bugs.webkit.org/show_bug.cgi?id=167096

• platform/graphics/texmap/TextureMapperGC3DPlatformLayer.cpp:

Include some necessary GLES headers.

12:35 AM Changeset in webkit [211717] by Csaba Osztrogonác

• 2 edits in trunk/Tools

Unreviewed trivial fix after r211697.
​https://bugs.webkit.org/show_bug.cgi?id=167863

• Scripts/run-javascriptcore-tests:

(runJSCStressTests): Renamed ES6SampleBench to ARES-6.