⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Feb 14, 2017:

11:50 PM Changeset in webkit [212350] by Brent Fulgham
  • 8 edits
    4 adds in trunk

Revalidate URL after events that could trigger navigations
​https://bugs.webkit.org/show_bug.cgi?id=168071
<rdar://problem/30450379>

Reviewed by Ryosuke Niwa.

Source/WebCore:

When arbitary javascript runs during a load, we should revalidate
the URLs involved to make sure they are still valid.

Tests: http/tests/plugins/navigation-during-load-embed.html

http/tests/plugins/navigation-during-load.html

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::updateWidget): Confirm we are still allowed to
load the URL after executing JS callbacks.

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::isURLAllowed): Split existing function into
existing protected method, and a new public method that checks a passed URL
for validity.

  • html/HTMLFrameElementBase.h:
  • html/HTMLFrameOwnerElement.h:

(WebCore::HTMLFrameOwnerElement::isURLAllowed):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateWidget): Confirm we are still allowed to
load the URL after executing JS callbacks.

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::requestFrame): Ditto.

LayoutTests:

  • http/tests/plugins/navigation-during-load-embed-expected.txt: Added.
  • http/tests/plugins/navigation-during-load-embed.html: Added.
  • http/tests/plugins/navigation-during-load-expected.txt: Added.
  • http/tests/plugins/navigation-during-load.html: Added.
11:44 PM Changeset in webkit [212349] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebCore

[GStreamer] Implement MediaPlayerPrivate::hasSingleSecurityOrigin()
​https://bugs.webkit.org/show_bug.cgi?id=168322

Reviewed by Žan Doberšek.

It currently returns true unconditionally. Add resolved-location property to WebKitWebSourceGStreamer to track
the resolved url returned by the server and use that from MediaPlayerPrivate to check if there was a cross
origin redirection.

Fixes: http/tests/security/canvas-remote-read-remote-video-redirect.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::hasSingleSecurityOrigin):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcFinalize):
(webKitWebSrcGetProperty):
(webKitWebSrcStart):
(webKitWebSrcQueryWithParent):
(webKitWebSrcGetUri):
(webKitWebSrcSetUri):
(StreamingClient::handleResponseReceived):
(ResourceHandleStreamingClient::wasBlocked):
(ResourceHandleStreamingClient::cannotShowURL):

11:40 PM Changeset in webkit [212348] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.14/Source/WebCore

Merge r212346 - Unreviewed, rolling out r211967.

Caused rendering issues in HiDPI

Reverted changeset:

"[GTK] scroll with transparent background not repainted after
scrollY >= 32768"
​https://bugs.webkit.org/show_bug.cgi?id=154283
​http://trac.webkit.org/changeset/211967

11:40 PM Changeset in webkit [212347] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.14/Source/WebCore

Merge r212228 - [GTK] Non-accelerated drawing is broken with HiDPI
​https://bugs.webkit.org/show_bug.cgi?id=168128

Reviewed by Michael Catanzaro.

When device scale factor changes, the page notifies the page overlay controller about it. Then overlay root
layers are created to be notified about the device scale factor. That causes us to enter in accelerated
compositing mode, because the graphics layer factory is called. But the render layer compositor doesn't really
enter in accelerated mode, because there aren't page overlays, the accelerated mode is not forced and the website
doesn't require acceleration either. This leaves our drawing area in an inconsistent state, it thinks it's in AC
mode because it has a layer tree host, but without a root layer attached, so nothing is rendered. The page
overlay controller doesn't need to create the layers when device scale factor changes, when an overlay is
installed, layers will be created with the current device scale factor anyway.

  • page/PageOverlayController.cpp:

(WebCore::PageOverlayController::didChangeDeviceScaleFactor): Return early if not initialized yet.

11:37 PM Changeset in webkit [212346] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r211967.

Caused rendering issues in HiDPI

Reverted changeset:

"[GTK] scroll with transparent background not repainted after
scrollY >= 32768"
​https://bugs.webkit.org/show_bug.cgi?id=154283
​http://trac.webkit.org/changeset/211967

11:34 PM Changeset in webkit [212345] by Carlos Garcia Campos
  • 27 edits in trunk

[GTK] Update cookie manager API to properly work with ephemeral sessions
​https://bugs.webkit.org/show_bug.cgi?id=168230

Reviewed by Michael Catanzaro.

Source/WebCore:

Add implementation for deleteAllCookiesModifiedSince. Note that this only works when the timespan is 0, we need
new libsoup API to support removing recently modified cookies.

  • platform/network/soup/CookieJarSoup.cpp:

(WebCore::deleteAllCookiesModifiedSince):

Source/WebKit2:

WebKitCookieManager is associated to a particular WebKitWebContext and uses the default session ID
unconditionally. It should be associated to a WebKitWebsiteDataManager instead and use its session ID. This
patch also adds support for handling cookies with WebKitWebsiteDataManager and deprecates
webkit_cookie_manager_get_domains_with_cookies(), webkit_cookie_manager_delete_cookies_for_domain() and
webkit_cookie_manager_delete_all_cookies(). It also adds API to get the the WebKitWebsiteDataManager of a
WebKitWebView, since it's the only way to get the WebKitCookieManager associated to an ephemeral web view.

  • UIProcess/API/gtk/WebKitCookieManager.cpp:

(webkitCookieManagerDispose): Stop observing cookie changes.
(webkit_cookie_manager_class_init): Add dispose implementation.
(webkitCookieManagerCreate): Create the WebKitCookieManager with a WebKitWebsiteDataManager.
(webkit_cookie_manager_set_persistent_storage): Work with all contexts having the session.
(webkit_cookie_manager_set_accept_policy): Ditto.
(webkit_cookie_manager_get_accept_policy): Use any context having the session.
(webkit_cookie_manager_get_domains_with_cookies): Deprecate and implement using WebKitWebsiteDataManager.
(webkit_cookie_manager_get_domains_with_cookies_finish): Ditto.
(webkit_cookie_manager_delete_cookies_for_domain): Ditto.
(webkit_cookie_manager_delete_all_cookies): Ditto.

  • UIProcess/API/gtk/WebKitCookieManager.h:
  • UIProcess/API/gtk/WebKitCookieManagerPrivate.h:
  • UIProcess/API/gtk/WebKitCustomProtocolManagerClient.cpp:

(attachCustomProtocolManagerClientToContext):

  • UIProcess/API/gtk/WebKitDownloadClient.cpp:

(attachDownloadClientToContext):

  • UIProcess/API/gtk/WebKitInjectedBundleClient.cpp:

(attachInjectedBundleClientToContext):

  • UIProcess/API/gtk/WebKitSecurityManager.cpp:

(registerSecurityPolicyForURIScheme):

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(webkitWebContextConstructed): Call webkitWebsiteDataManagerAddProcessPool.
(webkitWebContextDispose): Call webkitWebsiteDataManagerRemoveProcessPool.
(webkit_web_context_get_cookie_manager): Return the WebKitCookieManager of the WebKitWebsiteDataManager.
(webkitWebContextGetProcessPool): Make it return a reference.

  • UIProcess/API/gtk/WebKitWebContextPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed): Call webkitWebsiteDataManagerAddProcessPool when creating a ephemeral web view.
(webkitWebViewDispose): Call webkitWebsiteDataManagerRemoveProcessPool if needed.
(webkit_web_view_get_website_data_manager): Return the WebKitWebsiteDataManager or the context one.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/WebKitWebsiteData.cpp: Add support for Cookies type.

(recordContainsSupportedDataTypes):
(toWebKitWebsiteDataTypes):

  • UIProcess/API/gtk/WebKitWebsiteData.h:
  • UIProcess/API/gtk/WebKitWebsiteDataManager.cpp:

(_WebKitWebsiteDataManagerPrivate::~_WebKitWebsiteDataManagerPrivate): Ensure all contexts were unregistered.
(webkitWebsiteDataManagerAddProcessPool): Register the process pool in the session.
(webkitWebsiteDataManagerRemoveProcessPool): Unregister the process poll from the session.
(webkitWebsiteDataManagerGetProcessPools): Return the list of proces pools registered.
(webkit_website_data_manager_get_cookie_manager): Return the WebKitCookieManager.
(toWebsiteDataTypes): Add Cookies.

  • UIProcess/API/gtk/WebKitWebsiteDataManager.h:
  • UIProcess/API/gtk/WebKitWebsiteDataManagerPrivate.h:
  • UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt: Add new symbols.
  • UIProcess/WebsiteData/WebsiteDataRecord.cpp:

(WebKit::WebsiteDataRecord::displayNameForCookieHostName): Handle localhost as a special case here for backwards
compatibility.

Tools:

Update unit tests and add new cases for the new API.

  • MiniBrowser/gtk/main.c:

(gotWebsiteDataCallback):

  • TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:

(testCookieManagerEphemeral):

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:

(testWebContextEphemeral):

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:

(testWebViewEphemeral):

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:

(serverCallback):
(testWebsiteDataEphemeral):
(testWebsiteDataCookies):
(beforeAll):

11:12 PM Changeset in webkit [212344] by commit-queue@webkit.org
  • 12 edits in trunk/Source/WebCore

[WebIDL] Improve serializer = { inherit }
​https://bugs.webkit.org/show_bug.cgi?id=168293

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-02-14
Reviewed by Youenn Fablet.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
Expose a serialize() method on the interface.

(GenerateSerializerFunction):
(GenerateSerializerAttributesForInterface): Deleted.
Subclasses that have serializer = { inherit } can use
their parent's serialize() method to get the initial object.
We can now collapse everything back into a single function
because we only generate code for our own attributes.

  • bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::JSTestNode::serialize):
(WebCore::jsTestNodePrototypeFunctionToJSONCaller):

  • bindings/scripts/test/JS/JSTestNode.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::serialize):
(WebCore::jsTestObjPrototypeFunctionToJSONCaller):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/JS/JSTestSerialization.cpp:

(WebCore::JSTestSerialization::serialize):
(WebCore::jsTestSerializationPrototypeFunctionToJSONCaller):

  • bindings/scripts/test/JS/JSTestSerialization.h:
  • bindings/scripts/test/JS/JSTestSerializationInherit.cpp:

(WebCore::JSTestSerializationInherit::serialize):
(WebCore::jsTestSerializationInheritPrototypeFunctionToJSONCaller):

  • bindings/scripts/test/JS/JSTestSerializationInherit.h:
  • bindings/scripts/test/JS/JSTestSerializationInheritFinal.cpp:

(WebCore::JSTestSerializationInheritFinal::serialize):
(WebCore::jsTestSerializationInheritFinalPrototypeFunctionToJSONCaller):

  • bindings/scripts/test/JS/JSTestSerializationInheritFinal.h:

Updated results.

9:19 PM Changeset in webkit [212343] by aakash_jain@apple.com
  • 12 edits in trunk/Source/WebCore

Move methods from WebCoreThread.h to WebCoreThreadInternal.h
​https://bugs.webkit.org/show_bug.cgi?id=168326

Reviewed by Alexey Proskuryakov.

  • platform/ios/wak/WebCoreThread.h: Move methods WebThreadRunLoop and WebThreadCurrentContext to WebCoreThreadInternal.h
  • platform/ios/wak/WebCoreThreadInternal.h: Ditto.
  • platform/ios/wak/WebCoreThreadRun.cpp: Removed WebCoreThread.h as it is already included by WebCoreThreadInternal.h
  • platform/ios/wak/WKGraphics.mm: Included WebCoreThreadInternal.h, it subsequently includes WebCoreThread.h
  • inspector/InspectorTimelineAgent.cpp: Ditto.
  • page/mac/PageMac.mm: Ditto.
  • platform/cf/MainThreadSharedTimerCF.cpp: Ditto.
  • platform/cocoa/MemoryPressureHandlerCocoa.mm: Ditto.
  • platform/graphics/ca/cocoa/LayerFlushSchedulerMac.cpp: Ditto.
  • platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp: Ditto.
  • bindings/js/CommonVM.cpp: included WebCoreThreadInternal.h
9:05 PM Changeset in webkit [212342] by Wenson Hsieh
  • 17 edits
    2 adds in trunk

[WK2] Support data interaction on links
​https://bugs.webkit.org/show_bug.cgi?id=168331
<rdar://problem/30200837>

Reviewed by Tim Horton.

Source/WebCore:

Adds support for data interaction on links at the WebCore layer, refactoring some drag-and-drop code on the Mac
along the way. Also adds two new TestWebKitAPI unit tests in DataInteractionTests.mm: LinkToInput and
BackgroundImageLinkToInput (see Tools/ChangeLog for more information).

  • page/DragController.cpp:

(WebCore::DragController::startDrag):
(WebCore::DragController::doImageDrag):
(WebCore::DragController::doSystemDrag):

Introduce platformAdjustDragImageForDeviceScaleFactor, and special-case drag images for links to anchor at the
bottom center.

  • platform/DragImage.cpp:

(WebCore::platformAdjustDragImageForDeviceScaleFactor):

Scale the drag image up by the device scale factor. In WebDragClient, we scale the image back down to the
original size. It seems the reason we do this extra dance is because the image sizing heuristic in between
assumes that the image dimensions are for a non-retina device, but this work should really not be necessary if
we tweak the heuristic to account for deviceScaleFactor. We should address this in a separate patch.

  • platform/DragImage.h:
  • platform/graphics/Path.h:

Source/WebKit2:

Adds support for data interaction on links at the client layer for WebKit2. This involves several changes,
detailed in the per-method changes below:

  • Shared/ios/InteractionInformationAtPosition.h:
  • Shared/ios/InteractionInformationAtPosition.mm:

(WebKit::InteractionInformationAtPosition::encode):
(WebKit::InteractionInformationAtPosition::decode):

Add adjustedPointForNodeRespondingToClickEvents (the request point, adjusted to take nodeRespondingToClickEvents
into account) to InteractionInformationAtPosition. The web process sends this adjusted point over to the UI
process so that the UI process will be able to begin a data interaction at the adjusted point rather than the
request point, which is necessary for small clickable (and data-interactive) elements such as links.

  • UIProcess/ios/WKActionSheet.h:
  • UIProcess/ios/WKActionSheet.mm:

(-[WKActionSheet presentSheet:]):
(-[WKActionSheet _presentationRectForStyle:]):
(-[WKActionSheet updateSheetPosition]):

  • UIProcess/ios/WKActionSheetAssistant.h:
  • UIProcess/ios/WKActionSheetAssistant.mm:

(-[WKActionSheetAssistant presentationRectForElementUsingClosestIndicatedRect]):
(-[WKActionSheetAssistant presentationRectForIndicatedElement]):
(-[WKActionSheetAssistant showImageSheet]):
(-[WKActionSheetAssistant _shouldPresentAtTouchLocationForElementRect:]):
(-[WKActionSheetAssistant needsLinkIndicator]):
(-[WKActionSheetAssistant showLinkSheet]):
(-[WKActionSheetAssistant cleanupSheet]):
(-[WKActionSheetAssistant _presentationStyleForImageAtElementRect:]): Deleted.

Add support for the WKActionSheetPresentAtClosestIndicatorRect style of presenting an action sheet. When
showing the action sheet for a link and there is space along the margins to show a popover in the first place,
we will now target the popover rect to the bounding rect of the set of adjacent (or nearly-adjacent) element
rects closest to the user's touch location. This covers cases where the link is split into multiple rects due to
a line break, when the link is on multiple lines with a jagged rect per line, and when both of the above are
true.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView pointIsInDataInteractionContent:]):
(-[WKContentView _positionInformationDidChange:]):
(-[WKContentView positionInformationForActionSheetAssistant:]):
(-[WKContentView updatePositionInformationForActionSheetAssistant:]):

Include link indicator data in the position information request if needed. As the FIXME suggests, this can be
improved by asynchronously presenting the action sheet assistant after the request returns, and is something we
should address in the future.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getPositionInformation):

Tools:

Adds 2 unit tests checking that data interaction from a link (with or without a background image) into an
editable area results in the link URL being inserted.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
  • TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
  • TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(TestWebKitAPI::TEST):

7:06 PM Changeset in webkit [212341] by bshafiei@apple.com
  • 1 copy in tags/Safari-604.1.5.6

Tag Safari-604.1.5.6.

6:50 PM Changeset in webkit [212340] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[CURL] ResourceError created with error information should have default type Type::General
​https://bugs.webkit.org/show_bug.cgi?id=168345

Patch by Basuke Suzuki <​Basuke.Suzuki@am.sony.com> on 2017-02-14
Reviewed by Alex Christensen.

ResourceError has separate implementaion for each platform
so that the interface should be same.
On CURL port, the constructor with error information has
different default value on type parameter. It is Type::Null but other implementaitons have Type::General.
This causes some ResourceError is created inconsistent.

  • platform/network/curl/ResourceError.h:

(WebCore::ResourceError::ResourceError):

5:50 PM Changeset in webkit [212339] by BJ Burg
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: adjust padding of dashboard icons
​https://bugs.webkit.org/show_bug.cgi?id=168340

Reviewed by Matt Baker.

Extract the direction-dependent padding into a "local" variable.
Use two rules to apply it to whichever is the leading side.

While we tend to use leading/trailing in Apple layout technologies,
I think the CSS logical properties specification sticks to using
-start and -end, so let's use that nomenclature where we can.

  • UserInterface/Views/DefaultDashboardView.css:

(.toolbar .dashboard.default > .item > div):
(body[dir=ltr] .toolbar .dashboard.default > .item > div):
(body[dir=rtl] .toolbar .dashboard.default > .item > div):

5:23 PM Changeset in webkit [212338] by commit-queue@webkit.org
  • 11 edits
    1 copy
    3 adds in trunk

[WebRTC] Add support for libwebrtc negotiation needed event
​https://bugs.webkit.org/show_bug.cgi?id=168267

Patch by Youenn Fablet <​youennf@gmail.com> on 2017-02-14
Reviewed by Eric Carlson.

Source/WebCore:

Test: webrtc/negotiatedneeded-event-addStream.html

Moving generic code (markAsNeedingNegotiation) from MediaEndpointPeerConnection to PeerConnectionBackend.
This code handles the control of sending or not the negotiationneeded event.

Updating mock to use markAsNeedingNegotiation when streams are changed.
Updating libwebrtc backend to call markAsNeedingNegotiation when required by libwebrtc implementation.

  • Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::MediaEndpointPeerConnection::setLocalDescriptionTask):

  • Modules/mediastream/MediaEndpointPeerConnection.h:
  • Modules/mediastream/PeerConnectionBackend.cpp:

(WebCore::PeerConnectionBackend::markAsNeedingNegotiation):

  • Modules/mediastream/PeerConnectionBackend.h:

(WebCore::PeerConnectionBackend::isNegotiationNeeded):
(WebCore::PeerConnectionBackend::clearNegotiationNeededState):

  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::OnRenegotiationNeeded):

  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
  • testing/MockLibWebRTCPeerConnection.cpp:

(WebCore::MockLibWebRTCPeerConnection::AddStream):
(WebCore::MockLibWebRTCPeerConnection::RemoveStream):

LayoutTests:

  • fast/mediastream/RTCPeerConnection-more-media-to-negotiate-expected.txt:
  • platform/gtk/fast/mediastream/RTCPeerConnection-more-media-to-negotiate-expected.txt: Copied from LayoutTests/fast/mediastream/RTCPeerConnection-more-media-to-negotiate-expected.txt.
  • webrtc/negotiatedneeded-event-addStream-expected.txt: Added.
  • webrtc/negotiatedneeded-event-addStream.html: Added.
4:35 PM Changeset in webkit [212337] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/placard-support/placard-support-airplay.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=167441

Unreviewed test gardening.

  • platform/mac/TestExpectations:
4:29 PM Changeset in webkit [212336] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark media/video-zoom.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=168087

Unreviewed test gardening.

  • platform/mac/TestExpectations:
4:20 PM Changeset in webkit [212335] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed followup to r212330 to fix Debug builds

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Add call to relaxAdoptionRequirement().

4:11 PM Changeset in webkit [212334] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk

Source/WebKit2:
Add new WKWebKit Cocoa API for getContentsAsString.
​https://bugs.webkit.org/show_bug.cgi?id=168147
<rdar://problem/30502539>

Patch by Jason Rinn <​jrinn@apple.com> on 2017-02-14
Reviewed by Tim Horton.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _getContentsAsStringWithCompletionHandler:]): New API for getContentsAsString.

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:

Tools:
Add a test for new WebKit Cocoa API, _getContentsAsString.
​https://bugs.webkit.org/show_bug.cgi?id=168147
<rdar://problem/30502539>

Patch by Jason Rinn <​jrinn@apple.com> on 2017-02-14
Reviewed by Tim Horton.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewGetContents.mm: Added.

(TEST):

4:08 PM Changeset in webkit [212333] by Ryan Haddad
  • 28 edits
    1 delete in trunk/Source/ThirdParty/libwebrtc

Unreviewed, rolling out r212326.

This change broke certain build configurations.

Reverted changeset:

"Make libwebrtc.dylib"
​https://bugs.webkit.org/show_bug.cgi?id=168335
​http://trac.webkit.org/changeset/212326

3:37 PM Changeset in webkit [212332] by mrajca@apple.com
  • 5 edits
    2 adds in trunk

Website policies: iframes should respect the autoplay policy of the top-level document
​https://bugs.webkit.org/show_bug.cgi?id=168333

Reviewed by Alex Christensen.

Source/WebCore:

API tests were added.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):

Tools:

  • TestWebKitAPI/Tests/WebKit2/autoplay-check-frame.html: Added.
  • TestWebKitAPI/Tests/WebKit2/autoplay-check-in-iframe.html: Added.
  • TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:

(-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
(TEST):

3:31 PM Changeset in webkit [212331] by dino@apple.com
  • 8 edits in trunk/Source

Rename preferLowPowerWebGLRendering setting to forceWebGLUsesLowPower
​https://bugs.webkit.org/show_bug.cgi?id=168339
Source/WebCore:

<rdar://problem/30522092>

Reviewed by Simon Fraser.

Use a setting name that more clearly reflects what it is doing. It's not
preferring to use the low-power GPU, it's forcing it.

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::create):

  • page/Settings.in:

Source/WebKit/mac:

Reviewed by Simon Fraser.

Use a better name.

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences forceLowPowerGPUForWebGL]):
(-[WebPreferences setForceLowPowerGPUForWebGL:]):
(-[WebPreferences preferLowPowerWebGLRendering]): Deleted.
(-[WebPreferences setPreferLowPowerWebGLRendering:]): Deleted.

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

3:26 PM Changeset in webkit [212330] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Speculative fix for: Crash in DocumentThreadableLoader::redirectReceived.
<rdar://problem/29899473> and ​https://bugs.webkit.org/show_bug.cgi?id=168337

Reviewed by Geoffrey Garen.

No new tests (Unable to find a reproduction).

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadRequest):

3:17 PM Changeset in webkit [212329] by commit-queue@webkit.org
  • 15 edits
    5 deletes in trunk/Source/WebCore

[WebRTC] Remove obsolete WebRTC stats API
​https://bugs.webkit.org/show_bug.cgi?id=167910

Patch by Youenn Fablet <​youenn@apple.com> on 2017-02-14
Reviewed by Alex Christensen.

No change of behavior as removed constructs are not functional.
Removing RTCStatsResponse which no longer exists and made RTCStatsReport an empty container for now.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • Modules/mediastream/MediaEndpointPeerConnection.cpp:

(WebCore::MediaEndpointPeerConnection::getStats):

  • Modules/mediastream/MediaEndpointPeerConnection.h:
  • Modules/mediastream/PeerConnectionBackend.h:
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::getStats):

  • Modules/mediastream/RTCStatsReport.cpp:

(WebCore::RTCStatsReport::create): Deleted.
(WebCore::RTCStatsReport::RTCStatsReport): Deleted.
(WebCore::RTCStatsReport::names): Deleted.
(WebCore::RTCStatsReport::local): Deleted.
(WebCore::RTCStatsReport::remote): Deleted.
(WebCore::RTCStatsReport::addStatistic): Deleted.

  • Modules/mediastream/RTCStatsReport.h:

(WebCore::RTCStatsReport::create):
(WebCore::RTCStatsReport::timestamp): Deleted.
(WebCore::RTCStatsReport::id): Deleted.
(WebCore::RTCStatsReport::type): Deleted.
(WebCore::RTCStatsReport::stat): Deleted.

  • Modules/mediastream/RTCStatsReport.idl:
  • Modules/mediastream/RTCStatsResponse.cpp: Removed.
  • Modules/mediastream/RTCStatsResponse.h: Removed.
  • Modules/mediastream/RTCStatsResponse.idl: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mediastream/MediaEndpoint.h:

(WebCore::MediaEndpoint::getStats):

  • platform/mediastream/RTCStatsRequest.h: Removed.
  • platform/mediastream/RTCStatsResponseBase.h: Removed.
3:16 PM Changeset in webkit [212328] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/streams/readable-streams/garbage-collection.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=168336

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
3:16 PM Changeset in webkit [212327] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Removed unused methods of WebCore::FileStream
​https://bugs.webkit.org/show_bug.cgi?id=168025

Patch by Karim H <​karim@karhm.com> on 2017-02-14
Reviewed by Michael Catanzaro.

  • fileapi/AsyncFileStream.cpp:

(WebCore::AsyncFileStream::openForWrite): Deleted.
(WebCore::AsyncFileStream::write): Deleted.
(WebCore::AsyncFileStream::truncate): Deleted.

  • fileapi/AsyncFileStream.h:
  • platform/FileStream.cpp:

(WebCore::FileStream::openForWrite): Deleted.
(WebCore::FileStream::write): Deleted.
(WebCore::FileStream::truncate): Deleted.

  • platform/FileStream.h:
3:11 PM Changeset in webkit [212326] by achristensen@apple.com
  • 28 edits
    3 adds in trunk/Source/ThirdParty/libwebrtc

Make libwebrtc.dylib
​https://bugs.webkit.org/show_bug.cgi?id=168335

Reviewed by Dan Bernstein.

We were building libwebrtc as a static library, which would prevent us from weak linking with it.
We need to explicitly export what we use from WebCore or WebKit2, and RTCLogging.mm now needs to
be built on Mac, so we make it not automatically reference counted to make it work on 32-bit El Capitan.

  • Configurations/libwebrtc.xcconfig:
  • Source/webrtc/api/jsep.h:
  • Source/webrtc/api/mediastream.h:
  • Source/webrtc/api/notifier.h:

(webrtc::Notifier::Notifier): Deleted.
(webrtc::Notifier::RegisterObserver): Deleted.
(webrtc::Notifier::UnregisterObserver): Deleted.
(webrtc::Notifier::FireOnChanged): Deleted.

  • Source/webrtc/api/peerconnectioninterface.h:
  • Source/webrtc/base/asyncpacketsocket.h:
  • Source/webrtc/base/asyncresolverinterface.h:

(rtc::AsyncResolverInterface::address): Deleted.

  • Source/webrtc/base/copyonwritebuffer.h:

(rtc::CopyOnWriteBuffer::CopyOnWriteBuffer): Deleted.
(rtc::CopyOnWriteBuffer::data): Deleted.
(rtc::CopyOnWriteBuffer::cdata): Deleted.
(rtc::CopyOnWriteBuffer::size): Deleted.
(rtc::CopyOnWriteBuffer::capacity): Deleted.
(rtc::CopyOnWriteBuffer::operator=): Deleted.
(rtc::CopyOnWriteBuffer::operator!=): Deleted.
(rtc::CopyOnWriteBuffer::operator[]): Deleted.
(rtc::CopyOnWriteBuffer::SetData): Deleted.
(rtc::CopyOnWriteBuffer::AppendData): Deleted.
(rtc::CopyOnWriteBuffer::swap): Deleted.
(rtc::CopyOnWriteBuffer::IsConsistent): Deleted.

  • Source/webrtc/base/event.h:
  • Source/webrtc/base/export.h: Added.
  • Source/webrtc/base/helpers.h:
  • Source/webrtc/base/ipaddress.h:

(rtc::IPAddress::IPAddress): Deleted.
(rtc::IPAddress::~IPAddress): Deleted.
(rtc::IPAddress::operator=): Deleted.
(rtc::IPAddress::family): Deleted.

  • Source/webrtc/base/location.h:

(rtc::Location::function_name): Deleted.
(rtc::Location::file_and_line): Deleted.

  • Source/webrtc/base/messagehandler.h:

(rtc::MessageHandler::MessageHandler): Deleted.

  • Source/webrtc/base/network.h:

(rtc::NetworkManagerBase::ipv6_enabled): Deleted.
(rtc::NetworkManagerBase::set_ipv6_enabled): Deleted.
(rtc::NetworkManagerBase::set_max_ipv6_networks): Deleted.
(rtc::NetworkManagerBase::max_ipv6_networks): Deleted.
(rtc::NetworkManagerBase::set_enumeration_permission): Deleted.
(rtc::BasicNetworkManager::started): Deleted.
(rtc::BasicNetworkManager::set_network_ignore_list): Deleted.
(rtc::BasicNetworkManager::set_ignore_non_default_routes): Deleted.
(rtc::Network::default_local_address_provider): Deleted.
(rtc::Network::set_default_local_address_provider): Deleted.
(rtc::Network::name): Deleted.
(rtc::Network::description): Deleted.
(rtc::Network::prefix): Deleted.
(rtc::Network::prefix_length): Deleted.
(rtc::Network::key): Deleted.
(rtc::Network::ip): Deleted.
(rtc::Network::AddIP): Deleted.
(rtc::Network::GetIPs): Deleted.
(rtc::Network::ClearIPs): Deleted.
(rtc::Network::scope_id): Deleted.
(rtc::Network::set_scope_id): Deleted.
(rtc::Network::ignored): Deleted.
(rtc::Network::set_ignored): Deleted.
(rtc::Network::type): Deleted.
(rtc::Network::set_type): Deleted.
(rtc::Network::GetCost): Deleted.
(rtc::Network::id): Deleted.
(rtc::Network::set_id): Deleted.
(rtc::Network::preference): Deleted.
(rtc::Network::set_preference): Deleted.
(rtc::Network::active): Deleted.
(rtc::Network::set_active): Deleted.

  • Source/webrtc/base/proxyinfo.h:
  • Source/webrtc/base/refcountedobject.h:

(rtc::RefCountedObject::RefCountedObject): Deleted.
(rtc::RefCountedObject::AddRef): Deleted.
(rtc::RefCountedObject::Release): Deleted.
(rtc::RefCountedObject::HasOneRef): Deleted.
(rtc::RefCountedObject::~RefCountedObject): Deleted.

  • Source/webrtc/base/socketaddress.h:

(rtc::SocketAddress::hostname): Deleted.
(rtc::SocketAddress::family): Deleted.
(rtc::SocketAddress::scope_id): Deleted.
(rtc::SocketAddress::SetScopeID): Deleted.
(rtc::SocketAddress::operator !=): Deleted.

  • Source/webrtc/base/thread.h:
  • Source/webrtc/common_types.h:
  • Source/webrtc/common_video/include/video_frame_buffer.h:

(webrtc::I420Buffer::Copy): Deleted.
(webrtc::I420Buffer::CropAndScaleFrom): Deleted.
(webrtc::I420Buffer::ScaleFrom): Deleted.

  • Source/webrtc/common_video/libyuv/include/webrtc_libyuv.h:
  • Source/webrtc/p2p/base/basicpacketsocketfactory.h:
  • Source/webrtc/p2p/client/basicportallocator.h:

(cricket::BasicPortAllocator::network_ignore_mask): Deleted.
(cricket::BasicPortAllocator::network_manager): Deleted.
(cricket::BasicPortAllocator::socket_factory): Deleted.

  • Source/webrtc/sdk/objc/Framework/Classes/RTCLogging.mm:

(RTCFileName):

  • Source/webrtc/sdk/objc/Framework/Classes/videotoolboxvideocodecfactory.h:
  • Source/webrtc/video_frame.h:

(webrtc::VideoFrame::timestamp_us): Deleted.
(webrtc::VideoFrame::set_timestamp_us): Deleted.
(webrtc::VideoFrame::set_timestamp): Deleted.
(webrtc::VideoFrame::timestamp): Deleted.
(webrtc::VideoFrame::transport_frame_id): Deleted.
(webrtc::VideoFrame::set_ntp_time_ms): Deleted.
(webrtc::VideoFrame::ntp_time_ms): Deleted.
(webrtc::VideoFrame::rotation): Deleted.
(webrtc::VideoFrame::set_rotation): Deleted.
(webrtc::VideoFrame::set_render_time_ms): Deleted.
(webrtc::VideoFrame::render_time_ms): Deleted.
(webrtc::VideoFrame::is_texture): Deleted.

  • build: Added.
  • build/Debug: Added.
  • libwebrtc.xcodeproj/project.pbxproj:
3:11 PM Changeset in webkit [212325] by Chris Dumez
  • 25 edits
    2 adds in trunk

HTML Form Validation bubble should take minimum font size setting into consideration
​https://bugs.webkit.org/show_bug.cgi?id=168271
<rdar://problem/29869869>

Reviewed by Simon Fraser.

Source/WebCore:

HTML Form Validation bubble should take minimum font size setting into consideration
for better accessibility.

Test: fast/forms/validation-message-minimum-font-size.html

  • platform/ValidationBubble.h:

(WebCore::ValidationBubble::create):
(WebCore::ValidationBubble::fontSize):

  • platform/ios/ValidationBubbleIOS.mm:

(WebCore::ValidationBubble::ValidationBubble):

  • platform/mac/ValidationBubbleMac.mm:

(WebCore::ValidationBubble::ValidationBubble):
Update the ValidationBubble constructor to take in Settings. For now, there is a
single setting that is the minimum font size and that is taken into account when
setting the font size of the validation bubble text.

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _contentsOfUserInterfaceItem:]):
Return font size used in the validation bubble.

(-[WebView showFormValidationMessage:withAnchorRect:]):
Pass minimum font size setting when constructing the validation bubble.

Source/WebKit2:

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _contentsOfUserInterfaceItem:]):
Return font size used in the validation bubble.

  • UIProcess/PageClient.h:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::createValidationBubble):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::showValidationMessage):

  • UIProcess/mac/PageClientImpl.h:
  • UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::createValidationBubble):

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::showValidationMessage):
Pass minimum font size setting when constructing the form validation bubble.

Tools:

Extend UIScriptController's contentsOfUserInterfaceItem() to also return the
font size of the validation bubble.

Add an overridePreference() method to UIScriptController. This is currently
used to override the value of the minimumFontSize setting. testRunner's
overridePreference() is not usable on WK2 because it does not update the
value of the preference on the UIProcess side.

  • DumpRenderTree/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::overridePreference):

  • DumpRenderTree/mac/UIScriptControllerMac.mm:

(WTR::UIScriptController::overridePreference):

  • TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
  • TestRunnerShared/UIScriptContext/UIScriptController.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):

  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::overridePreference):

  • WebKitTestRunner/mac/UIScriptControllerMac.mm:

(WTR::UIScriptController::contentsOfUserInterfaceItem):
(WTR::UIScriptController::overridePreference):

LayoutTests:

Add layout test coverage.

  • fast/forms/validation-message-minimum-font-size-expected.txt: Added.
  • fast/forms/validation-message-minimum-font-size.html: Added.
2:51 PM Changeset in webkit [212324] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Remove debug flag from flaky test imported/w3c/web-platform-tests/dom/events/EventListener-invoke-legacy.html.
​https://bugs.webkit.org/show_bug.cgi?id=168238

Unreviewed test gardening.

2:34 PM Changeset in webkit [212323] by eric.carlson@apple.com
  • 14 edits
    6 adds in trunk

[MediaStream] add navigator.getUserMedia for compatibility with legacy content
​https://bugs.webkit.org/show_bug.cgi?id=168324
<rdar://problem/30513125>

Reviewed by Youenn Fablet.

Source/WebCore:

Tests: fast/mediastream/argument-types.html

fast/mediastream/getusermedia.html
fast/mediastream/webkitGetUserMedia-shadowing-then.html

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • Modules/mediastream/MediaDevices.idl:
  • Modules/mediastream/NavigatorUserMedia.idl: Added.
  • Modules/mediastream/NavigatorUserMedia.js: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/WebCoreBuiltinNames.h:
  • page/Navigator.idl:

Source/WebInspectorUI:

  • UserInterface/Models/NativeFunctionParameters.js:

LayoutTests:

  • fast/mediastream/argument-types-expected.txt:
  • fast/mediastream/argument-types.html: Added.
  • fast/mediastream/getusermedia-expected.txt:
  • fast/mediastream/getusermedia.html: Added.
  • fast/mediastream/script-tests/argument-types.js: Added.
  • fast/mediastream/webkitGetUserMedia-shadowing-then.html: Added.
1:15 PM Changeset in webkit [212322] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

Unreviewed, rolling out r211879.
​https://bugs.webkit.org/show_bug.cgi?id=168330

Not ready for the menu yet (Requested by eric_car_ on
#webkit).

Reverted changeset:

"Add WebRTC as an off-by-default experimental feature menu
item."
​https://bugs.webkit.org/show_bug.cgi?id=167972
​http://trac.webkit.org/changeset/211879

1:11 PM Changeset in webkit [212321] by Chris Dumez
  • 5 edits in trunk

Fallback to legacy type only when event is trusted
​https://bugs.webkit.org/show_bug.cgi?id=168301

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline web-platform-test now tha more checks are passing.

  • web-platform-tests/dom/events/EventListener-invoke-legacy-expected.txt:

Source/WebCore:

Fallback to legacy type only when event is trusted as per a recent
DOM specification change:

No new tests, rebaselined existing test.

  • dom/EventTarget.cpp:

(WebCore::legacyType):
(WebCore::EventTarget::fireEventListeners):

1:08 PM Changeset in webkit [212320] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Remove an unused delegate method
​https://bugs.webkit.org/show_bug.cgi?id=168328

Reviewed by Wenson Hsieh.

  • DefaultDelegates/WebDefaultUIDelegate.m:

(-[WebDefaultUIDelegate webView:shouldBeginDragForElement:dragImage:mouseDownEvent:mouseDraggedEvent:]): Deleted.

1:01 PM Changeset in webkit [212319] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Use a set instead of a list for tests when parsing expectations
​https://bugs.webkit.org/show_bug.cgi?id=168304

In _collect_matching_tests, a lot of membership tests are done on a giant list
of strings. By making it a set instead, we can make those much faster, and
there's no reason for it to be a list.

With ~45k tests and some 1000 expectations, this reduces the parse time from 34s
to 3s on my machine.

Patch by Florian Bruhin <​git@the-compiler.org> on 2017-02-14
Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser.init):
(TestExpectationParser._collect_matching_tests):

12:56 PM Changeset in webkit [212318] by matthew_hanson@apple.com
  • 6 edits in branches/safari-604.1.5-branch/Source

Versioning.

12:56 PM Changeset in webkit [212317] by matthew_hanson@apple.com
  • 2 edits in branches/safari-604.1.5-branch/Source/WebCore

Merge r211530. rdar://problem/30112683

12:12 PM Changeset in webkit [212316] by dino@apple.com
  • 11 edits in trunk

Rename preferLowPowerToHighPerformance to powerPreference
​https://bugs.webkit.org/show_bug.cgi?id=168269
<rdar://problem/30504444>

Reviewed by Chris Dumez.

Source/WebCore:

Based on the discussion in ​https://github.com/KhronosGroup/WebGL/pull/2283.

Change WebGLContextAttributes's preferLowPowerToHighPerformance boolean
into a powerPreference enum taking three values. The implementation
of the enum is in GraphicsContext3DAttributes.

While the name and values have changed, there should be no change in
behaviour caused by this patch.

  • html/canvas/WebGLContextAttributes.h: Use GraphicsContext3DAttributes

enum GraphicsContext3DPowerPreference.

  • html/canvas/WebGLContextAttributes.idl: Rename and add the WebIDL enum.
  • html/canvas/WebGLRenderingContextBase.cpp: Use the new values.

(WebCore::WebGLRenderingContextBase::create):
(WebCore::WebGLRenderingContextBase::registerWithWebGLStateTracker):

  • platform/WebGLStateTracker.cpp:
  • platform/WebGLStateTracker.h: Update the state tracker to use the new

values.

  • platform/graphics/GraphicsContext3DAttributes.h:
  • platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::setPixelFormat): Accept GraphicsContext3DPowerPreference as a parameter.
(WebCore::GraphicsContext3D::GraphicsContext3D):

LayoutTests:

Handle the rename in the test case. Since Settings.in has
preferLowPowerWebGLRendering initial=true
we will override the incoming request and set the value to
"low-power". This behaviour will change in a subsequent bug.

  • fast/canvas/webgl/context-creation-attributes-expected.txt:
  • fast/canvas/webgl/context-creation-attributes.html:
11:40 AM Changeset in webkit [212315] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[WebRTC] Implement description getters for libwebrtc RTCPeerConnection
​https://bugs.webkit.org/show_bug.cgi?id=168234

Patch by Youenn Fablet <​youennf@gmail.com> on 2017-02-14
Reviewed by Alex Christensen.

Allows passing W3C webrtc tests.

Implementing localDescription/remoteDescription using libwebrtc backend.
current and pending description getters are made the same as local/remote getters for the moment.
This should be fixed when upgrading to latest libwebrtc revision.

  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::toSessionDescriptionType):
(WebCore::fromSessionDescriptionType):
(WebCore::fromSessionDescription):
(WebCore::LibWebRTCMediaEndpoint::localDescription):
(WebCore::LibWebRTCMediaEndpoint::remoteDescription):
(WebCore::LibWebRTCMediaEndpoint::doSetLocalDescription):
(WebCore::LibWebRTCMediaEndpoint::doSetRemoteDescription):

  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::LibWebRTCPeerConnectionBackend::localDescription):

  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.h:
11:34 AM Changeset in webkit [212314] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

When playing inline after fullscreen, set a flag instead of adding attribute plays inline, and use in requiresFullscreenForVideoPlayback.
​https://bugs.webkit.org/show_bug.cgi?id=167815
rdar://problem/27685077

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-02-14
Reviewed by Jer Noble.

Source/WebCore:

Test: media/media-fullscreen-loop-inline.html

When video is allowed to play inline after fullscreen. Looped video causes play state to update, which can send video back to fullscreen when
allowsInline is false. This change will set a new flag when allowsInlineMediaPlaybackAfterFullscreen allows inline playback that can be tested
in requiresFullscreenForVideoPlayback to prevent sending video back into fullscreen when video loops.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::enterFullscreen):
(WebCore::HTMLMediaElement::exitFullscreen):

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::isTemporarilyAllowingInlinePlaybackAfterFullscreen): Added.

  • html/MediaElementSession.cpp:

(WebCore::MediaElementSession::requiresFullscreenForVideoPlayback):

LayoutTests:

Add a new test that tests inline after fullscreen behavior of looping video.

  • media/media-fullscreen-loop-inline-expected.txt: Added.
  • media/media-fullscreen-loop-inline.html: Added.
  • platform/mac-wk2/TestExpectations: Skipped on webkit2.
11:24 AM Changeset in webkit [212313] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Rebaseline media/modern-media-controls/airplay-button/airplay-button-on.html for ios-simulator.

Unreviewed test gardening.

  • platform/ios-simulator/media/modern-media-controls/airplay-button/airplay-button-on-expected.txt:
11:20 AM Changeset in webkit [212312] by Simon Fraser
  • 9 edits in trunk/Source/WebKit2

Add logging and defensive fixes to try to detect problems causing blank tabs
​https://bugs.webkit.org/show_bug.cgi?id=168270
rdar://problem/30505482

Reviewed by Jon Lee.

Add release logging when -[WKWebView _beginAnimatedResizeWithUpdates:] and -[WKWebView _endAnimatedResize]
are unbalanced across a commit, to detect cases where _endAnimatedResize wasn't called enough times.

Also log when RemoteLayerTreeHost::updateLayerTree() fails to find a root layer, which should never happen.

In WebPageProxy, clear m_firstLayerTreeTransactionIdAfterDidCommitLoad on a web process crash.

  • Platform/Logging.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLayerTree:]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
(-[WKWebView _endAnimatedResize]):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::resetState):

  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::isAlwaysOnLoggingAllowed):

  • UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::updateLayerTree):
(WebKit::RemoteLayerTreeHost::clearLayers):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::WebFrame):

  • WebProcess/WebPage/WebFrame.h:
11:17 AM Changeset in webkit [212311] by jer.noble@apple.com
  • 16 edits
    2 adds
    3 deletes in trunk

Video elements with MediaSource objects set by srcObject are not cleared when srcObject is set to null
​https://bugs.webkit.org/show_bug.cgi?id=168268

Reviewed by Eric Carlson.

Source/WebCore:

Test: fast/mediastream/MediaStream-MediaElement-setObject-null.html

Make the setSrcObject() operation compliant with the HTML spec. Since the specification defines
srcObject in terms of either a MediaSource, MediaStream, or Blob object, add the variant typedef
to HTMLMediaElement and move the definition out of the Modules/mediastream extension IDL and into
HTMLMediaElement.idl. Then bring the "media elements load" and "resource selection" algorithms up
to their most recent definitions in the HTML5 spec.

Drive-by fix: Allow the (admittedly weird) single-element-union type in IDL.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • Modules/mediastream/HTMLMediaElementMediaStream.cpp: Removed.
  • Modules/mediastream/HTMLMediaElementMediaStream.h: Removed.
  • Modules/mediastream/HTMLMediaElementMediaStream.idl: Removed.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/scripts/IDLParser.pm:

(parseUnionType):

  • html/HTMLAudioElement.cpp:

(WebCore::HTMLAudioElement::createForJSConstructor):

  • html/HTMLMediaElement.cpp:

(WebCore::actionName):
(WebCore::HTMLMediaElement::parseAttribute):
(WebCore::HTMLMediaElement::insertedInto):
(WebCore::HTMLMediaElement::scheduleDelayedAction):
(WebCore::HTMLMediaElement::scheduleNextSourceChild):
(WebCore::HTMLMediaElement::pendingActionTimerFired):
(WebCore::HTMLMediaElement::setSrcObject):
(WebCore::HTMLMediaElement::load):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::selectMediaResource):
(WebCore::HTMLMediaElement::loadResource):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::pauseInternal):
(WebCore::HTMLMediaElement::sourceWasAdded):
(WebCore::HTMLMediaElement::clearMediaPlayer):
(WebCore::HTMLMediaElement::resume):
(WebCore::HTMLMediaElement::mediaCanStart):
(WebCore::HTMLMediaElement::createMediaPlayer):
(WebCore::HTMLMediaElement::loadInternal): Deleted.

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::srcObject):

  • html/HTMLMediaElement.idl:
  • platform/ContentType.h:

LayoutTests:

  • fast/mediastream/MediaStream-MediaElement-setObject-null-expected.txt: Added.
  • fast/mediastream/MediaStream-MediaElement-setObject-null.html: Added.
  • fast/mediastream/MediaStream-video-element-expected.txt:
  • fast/mediastream/MediaStream-video-element-track-stop-expected.txt:
  • fast/mediastream/MediaStream-video-element-track-stop.html:
  • fast/mediastream/MediaStream-video-element.html:
11:13 AM Changeset in webkit [212310] by mark.lam@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Add JSC_sweepSynchronously and fix JSC_useZombieMode options.
​https://bugs.webkit.org/show_bug.cgi?id=168257
<rdar://problem/30451496>

Reviewed by Filip Pizlo.

JSC_useZombieMode now basically enables JSC_sweepSynchronously and
JSC_scribbleFreeCells, which together does the job of zombifying dead objects
immediately after a GC.

  • heap/Heap.cpp:

(JSC::Heap::sweepSynchronously):
(JSC::Heap::collectAllGarbage):
(JSC::Heap::finalize):
(JSC::Heap::didFinishCollection):
(JSC::Zombify::visit): Deleted.
(JSC::Zombify::operator()): Deleted.
(JSC::Heap::zombifyDeadObjects): Deleted.

  • heap/Heap.h:

(JSC::Heap::isZombified): Deleted.

  • runtime/Options.cpp:

(JSC::recomputeDependentOptions):

  • runtime/Options.h:
11:09 AM Changeset in webkit [212309] by Jonathan Bedard
  • 2 edits in trunk/Tools

Unreviewed build-fix after r212297.

  • Scripts/webkitpy/port/simulator_process.py:

(SimulatorProcess.stop): Should return value of the ServerProcess's stop.

10:52 AM Changeset in webkit [212308] by achristensen@apple.com
  • 2 edits
    23 deletes in trunk/Source/ThirdParty/libwebrtc

Remove android-specific files from ThirdParty/libwebrtc
​https://bugs.webkit.org/show_bug.cgi?id=168272

Reviewed by Brady Eidson.

  • Source/third_party/boringssl/src/third_party/android-cmake: Removed.
  • Source/third_party/boringssl/src/third_party/android-cmake/AndroidNdkGdb.cmake: Removed.
  • Source/third_party/boringssl/src/third_party/android-cmake/AndroidNdkModules.cmake: Removed.
  • Source/third_party/boringssl/src/third_party/android-cmake/LICENSE: Removed.
  • Source/third_party/boringssl/src/third_party/android-cmake/METADATA: Removed.
  • Source/third_party/boringssl/src/third_party/android-cmake/README.md: Removed.
  • Source/third_party/boringssl/src/third_party/android-cmake/android.toolchain.cmake: Removed.
  • Source/third_party/boringssl/src/third_party/android-cmake/ndk_links.md: Removed.
  • Source/third_party/boringssl/src/util/run_android_tests.go: Removed.
  • Source/third_party/libyuv/util/android: Removed.
  • Source/third_party/libyuv/util/android/test_runner.py: Removed.
  • Source/webrtc/androidjunit: Removed.
  • Source/webrtc/androidjunit/OWNERS: Removed.
  • Source/webrtc/androidjunit/src: Removed.
  • Source/webrtc/androidjunit/src/org: Removed.
  • Source/webrtc/androidjunit/src/org/webrtc: Removed.
  • Source/webrtc/androidjunit/src/org/webrtc/CameraEnumerationTest.java: Removed.
  • Source/webrtc/api/android: Removed.
  • Source/webrtc/api/android/PRESUBMIT.py: Removed.
  • Source/webrtc/api/android/README: Removed.
  • Source/webrtc/api/android/java: Removed.
  • Source/webrtc/api/android/java/src: Removed.
  • Source/webrtc/api/android/java/src/org: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/AudioSource.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/AudioTrack.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/CallSessionFileRotatingLogSink.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/Camera1Capturer.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/Camera1Enumerator.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/Camera1Session.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/Camera2Capturer.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/Camera2Enumerator.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/Camera2Session.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/CameraCapturer.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/CameraEnumerationAndroid.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/CameraEnumerator.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/CameraSession.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/CameraVideoCapturer.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/DataChannel.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/EglBase.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/EglBase10.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/EglBase14.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/EglRenderer.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/FileVideoCapturer.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/GlRectDrawer.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/GlShader.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/GlTextureFrameBuffer.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/GlUtil.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/IceCandidate.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/MediaCodecVideoDecoder.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/MediaCodecVideoEncoder.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/MediaConstraints.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/MediaSource.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/MediaStream.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/MediaStreamTrack.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/Metrics.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/NetworkMonitor.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/NetworkMonitorAutoDetect.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/OWNERS: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/PeerConnection.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/PeerConnectionFactory.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/RendererCommon.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/RtpParameters.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/RtpReceiver.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/RtpSender.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/ScreenCapturerAndroid.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/SdpObserver.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/SessionDescription.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/StatsObserver.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/StatsReport.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/SurfaceTextureHelper.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/SurfaceViewRenderer.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/VideoCapturer.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/VideoCapturerAndroid.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/VideoFileRenderer.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/VideoRenderer.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/VideoRendererGui.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/VideoSource.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/VideoTrack.java: Removed.
  • Source/webrtc/api/android/java/src/org/webrtc/YuvConverter.java: Removed.
  • Source/webrtc/api/android/jni: Removed.
  • Source/webrtc/api/android/jni/OWNERS: Removed.
  • Source/webrtc/api/android/jni/androidmediacodeccommon.h: Removed.
  • Source/webrtc/api/android/jni/androidmediadecoder_jni.cc: Removed.
  • Source/webrtc/api/android/jni/androidmediadecoder_jni.h: Removed.
  • Source/webrtc/api/android/jni/androidmediaencoder_jni.cc: Removed.
  • Source/webrtc/api/android/jni/androidmediaencoder_jni.h: Removed.
  • Source/webrtc/api/android/jni/androidmetrics_jni.cc: Removed.
  • Source/webrtc/api/android/jni/androidnetworkmonitor_jni.cc: Removed.
  • Source/webrtc/api/android/jni/androidnetworkmonitor_jni.h: Removed.
  • Source/webrtc/api/android/jni/androidvideotracksource_jni.cc: Removed.
  • Source/webrtc/api/android/jni/classreferenceholder.cc: Removed.
  • Source/webrtc/api/android/jni/classreferenceholder.h: Removed.
  • Source/webrtc/api/android/jni/jni_helpers.cc: Removed.
  • Source/webrtc/api/android/jni/jni_helpers.h: Removed.
  • Source/webrtc/api/android/jni/jni_onload.cc: Removed.
  • Source/webrtc/api/android/jni/native_handle_impl.cc: Removed.
  • Source/webrtc/api/android/jni/native_handle_impl.h: Removed.
  • Source/webrtc/api/android/jni/peerconnection_jni.cc: Removed.
  • Source/webrtc/api/android/jni/surfacetexturehelper_jni.cc: Removed.
  • Source/webrtc/api/android/jni/surfacetexturehelper_jni.h: Removed.
  • Source/webrtc/api/androidtests: Removed.
  • Source/webrtc/api/androidtests/AndroidManifest.xml: Removed.
  • Source/webrtc/api/androidtests/OWNERS: Removed.
  • Source/webrtc/api/androidtests/ant.properties: Removed.
  • Source/webrtc/api/androidtests/build.xml: Removed.
  • Source/webrtc/api/androidtests/project.properties: Removed.
  • Source/webrtc/api/androidtests/res: Removed.
  • Source/webrtc/api/androidtests/res/drawable-hdpi: Removed.
  • Source/webrtc/api/androidtests/res/drawable-hdpi/ic_launcher.png: Removed.
  • Source/webrtc/api/androidtests/res/drawable-ldpi: Removed.
  • Source/webrtc/api/androidtests/res/drawable-ldpi/ic_launcher.png: Removed.
  • Source/webrtc/api/androidtests/res/drawable-mdpi: Removed.
  • Source/webrtc/api/androidtests/res/drawable-mdpi/ic_launcher.png: Removed.
  • Source/webrtc/api/androidtests/res/drawable-xhdpi: Removed.
  • Source/webrtc/api/androidtests/res/drawable-xhdpi/ic_launcher.png: Removed.
  • Source/webrtc/api/androidtests/res/values: Removed.
  • Source/webrtc/api/androidtests/res/values/strings.xml: Removed.
  • Source/webrtc/api/androidtests/src: Removed.
  • Source/webrtc/api/androidtests/src/org: Removed.
  • Source/webrtc/api/androidtests/src/org/webrtc: Removed.
  • Source/webrtc/api/androidtests/src/org/webrtc/Camera1CapturerUsingByteBufferTest.java: Removed.
  • Source/webrtc/api/androidtests/src/org/webrtc/Camera1CapturerUsingTextureTest.java: Removed.
  • Source/webrtc/api/androidtests/src/org/webrtc/Camera2CapturerTest.java: Removed.
  • Source/webrtc/api/androidtests/src/org/webrtc/CameraVideoCapturerTestFixtures.java: Removed.
  • Source/webrtc/api/androidtests/src/org/webrtc/EglRendererTest.java: Removed.
  • Source/webrtc/api/androidtests/src/org/webrtc/GlRectDrawerTest.java: Removed.
  • Source/webrtc/api/androidtests/src/org/webrtc/MediaCodecVideoEncoderTest.java: Removed.
  • Source/webrtc/api/androidtests/src/org/webrtc/NetworkMonitorTest.java: Removed.
  • Source/webrtc/api/androidtests/src/org/webrtc/PeerConnectionTest.java: Removed.
  • Source/webrtc/api/androidtests/src/org/webrtc/RendererCommonTest.java: Removed.
  • Source/webrtc/api/androidtests/src/org/webrtc/SurfaceTextureHelperTest.java: Removed.
  • Source/webrtc/api/androidtests/src/org/webrtc/SurfaceViewRendererOnMeasureTest.java: Removed.
  • Source/webrtc/api/androidtests/src/org/webrtc/WebRtcJniBootTest.java: Removed.
  • Source/webrtc/api/androidvideotracksource.cc: Removed.
  • Source/webrtc/api/androidvideotracksource.h: Removed.
  • Source/webrtc/api/test/androidtestinitializer.cc: Removed.
  • Source/webrtc/api/test/androidtestinitializer.h: Removed.
  • Source/webrtc/base/ifaddrs-android.cc: Removed.
  • Source/webrtc/base/ifaddrs-android.h: Removed.
  • Source/webrtc/build/android: Removed.
  • Source/webrtc/build/android/AndroidManifest.xml: Removed.
  • Source/webrtc/build/android/suppressions.xml: Removed.
  • Source/webrtc/build/android/test_runner.py: Removed.
  • Source/webrtc/examples/androidapp: Removed.
  • Source/webrtc/examples/androidapp/AndroidManifest.xml: Removed.
  • Source/webrtc/examples/androidapp/OWNERS: Removed.
  • Source/webrtc/examples/androidapp/README: Removed.
  • Source/webrtc/examples/androidapp/ant.properties: Removed.
  • Source/webrtc/examples/androidapp/build.xml: Removed.
  • Source/webrtc/examples/androidapp/project.properties: Removed.
  • Source/webrtc/examples/androidapp/res: Removed.
  • Source/webrtc/examples/androidapp/res/drawable-hdpi: Removed.
  • Source/webrtc/examples/androidapp/res/drawable-hdpi/disconnect.png: Removed.
  • Source/webrtc/examples/androidapp/res/drawable-hdpi/ic_action_full_screen.png: Removed.
  • Source/webrtc/examples/androidapp/res/drawable-hdpi/ic_action_return_from_full_screen.png: Removed.
  • Source/webrtc/examples/androidapp/res/drawable-hdpi/ic_launcher.png: Removed.
  • Source/webrtc/examples/androidapp/res/drawable-hdpi/ic_loopback_call.png: Removed.
  • Source/webrtc/examples/androidapp/res/drawable-ldpi: Removed.
  • Source/webrtc/examples/androidapp/res/drawable-ldpi/disconnect.png: Removed.
  • Source/webrtc/examples/androidapp/res/drawable-ldpi/ic_action_full_screen.png: Removed.
  • Source/webrtc/examples/androidapp/res/drawable-ldpi/ic_action_return_from_full_screen.png: Removed.
  • Source/webrtc/examples/androidapp/res/drawable-ldpi/ic_launcher.png: Removed.
  • Source/webrtc/examples/androidapp/res/drawable-ldpi/ic_loopback_call.png: Removed.
  • Source/webrtc/examples/androidapp/res/drawable-mdpi: Removed.
  • Source/webrtc/examples/androidapp/res/drawable-mdpi/disconnect.png: Removed.
  • Source/webrtc/examples/androidapp/res/drawable-mdpi/ic_action_full_screen.png: Removed.
  • Source/webrtc/examples/androidapp/res/drawable-mdpi/ic_action_return_from_full_screen.png: Removed.
  • Source/webrtc/examples/androidapp/res/drawable-mdpi/ic_launcher.png: Removed.
  • Source/webrtc/examples/androidapp/res/drawable-mdpi/ic_loopback_call.png: Removed.
  • Source/webrtc/examples/androidapp/res/drawable-xhdpi: Removed.
  • Source/webrtc/examples/androidapp/res/drawable-xhdpi/disconnect.png: Removed.
  • Source/webrtc/examples/androidapp/res/drawable-xhdpi/ic_action_full_screen.png: Removed.
  • Source/webrtc/examples/androidapp/res/drawable-xhdpi/ic_action_return_from_full_screen.png: Removed.
  • Source/webrtc/examples/androidapp/res/drawable-xhdpi/ic_launcher.png: Removed.
  • Source/webrtc/examples/androidapp/res/drawable-xhdpi/ic_loopback_call.png: Removed.
  • Source/webrtc/examples/androidapp/res/layout: Removed.
  • Source/webrtc/examples/androidapp/res/layout/activity_call.xml: Removed.
  • Source/webrtc/examples/androidapp/res/layout/activity_connect.xml: Removed.
  • Source/webrtc/examples/androidapp/res/layout/fragment_call.xml: Removed.
  • Source/webrtc/examples/androidapp/res/layout/fragment_hud.xml: Removed.
  • Source/webrtc/examples/androidapp/res/menu: Removed.
  • Source/webrtc/examples/androidapp/res/menu/connect_menu.xml: Removed.
  • Source/webrtc/examples/androidapp/res/values: Removed.
  • Source/webrtc/examples/androidapp/res/values-v17: Removed.
  • Source/webrtc/examples/androidapp/res/values-v17/styles.xml: Removed.
  • Source/webrtc/examples/androidapp/res/values-v21: Removed.
  • Source/webrtc/examples/androidapp/res/values-v21/styles.xml: Removed.
  • Source/webrtc/examples/androidapp/res/values/arrays.xml: Removed.
  • Source/webrtc/examples/androidapp/res/values/strings.xml: Removed.
  • Source/webrtc/examples/androidapp/res/xml: Removed.
  • Source/webrtc/examples/androidapp/res/xml/preferences.xml: Removed.
  • Source/webrtc/examples/androidapp/src: Removed.
  • Source/webrtc/examples/androidapp/src/org: Removed.
  • Source/webrtc/examples/androidapp/src/org/appspot: Removed.
  • Source/webrtc/examples/androidapp/src/org/appspot/apprtc: Removed.
  • Source/webrtc/examples/androidapp/src/org/appspot/apprtc/AppRTCAudioManager.java: Removed.
  • Source/webrtc/examples/androidapp/src/org/appspot/apprtc/AppRTCClient.java: Removed.
  • Source/webrtc/examples/androidapp/src/org/appspot/apprtc/AppRTCProximitySensor.java: Removed.
  • Source/webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java: Removed.
  • Source/webrtc/examples/androidapp/src/org/appspot/apprtc/CallFragment.java: Removed.
  • Source/webrtc/examples/androidapp/src/org/appspot/apprtc/CaptureQualityController.java: Removed.
  • Source/webrtc/examples/androidapp/src/org/appspot/apprtc/ConnectActivity.java: Removed.
  • Source/webrtc/examples/androidapp/src/org/appspot/apprtc/CpuMonitor.java: Removed.
  • Source/webrtc/examples/androidapp/src/org/appspot/apprtc/DirectRTCClient.java: Removed.
  • Source/webrtc/examples/androidapp/src/org/appspot/apprtc/HudFragment.java: Removed.
  • Source/webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java: Removed.
  • Source/webrtc/examples/androidapp/src/org/appspot/apprtc/PercentFrameLayout.java: Removed.
  • Source/webrtc/examples/androidapp/src/org/appspot/apprtc/RoomParametersFetcher.java: Removed.
  • Source/webrtc/examples/androidapp/src/org/appspot/apprtc/SettingsActivity.java: Removed.
  • Source/webrtc/examples/androidapp/src/org/appspot/apprtc/SettingsFragment.java: Removed.
  • Source/webrtc/examples/androidapp/src/org/appspot/apprtc/TCPChannelClient.java: Removed.
  • Source/webrtc/examples/androidapp/src/org/appspot/apprtc/UnhandledExceptionHandler.java: Removed.
  • Source/webrtc/examples/androidapp/src/org/appspot/apprtc/WebSocketChannelClient.java: Removed.
  • Source/webrtc/examples/androidapp/src/org/appspot/apprtc/WebSocketRTCClient.java: Removed.
  • Source/webrtc/examples/androidapp/src/org/appspot/apprtc/util: Removed.
  • Source/webrtc/examples/androidapp/src/org/appspot/apprtc/util/AppRTCUtils.java: Removed.
  • Source/webrtc/examples/androidapp/src/org/appspot/apprtc/util/AsyncHttpURLConnection.java: Removed.
  • Source/webrtc/examples/androidapp/start_loopback_stubbed_camera_saved_video_out.py: Removed.
  • Source/webrtc/examples/androidapp/third_party: Removed.
  • Source/webrtc/examples/androidapp/third_party/autobanh: Removed.
  • Source/webrtc/examples/androidapp/third_party/autobanh/BUILD.gn: Removed.
  • Source/webrtc/examples/androidapp/third_party/autobanh/LICENSE: Removed.
  • Source/webrtc/examples/androidapp/third_party/autobanh/LICENSE.md: Removed.
  • Source/webrtc/examples/androidapp/third_party/autobanh/NOTICE: Removed.
  • Source/webrtc/examples/androidapp/third_party/autobanh/lib: Removed.
  • Source/webrtc/examples/androidapp/third_party/autobanh/lib/autobanh.jar: Removed.
  • Source/webrtc/examples/androidjunit: Removed.
  • Source/webrtc/examples/androidjunit/README: Removed.
  • Source/webrtc/examples/androidjunit/src: Removed.
  • Source/webrtc/examples/androidjunit/src/org: Removed.
  • Source/webrtc/examples/androidjunit/src/org/appspot: Removed.
  • Source/webrtc/examples/androidjunit/src/org/appspot/apprtc: Removed.
  • Source/webrtc/examples/androidjunit/src/org/appspot/apprtc/DirectRTCClientTest.java: Removed.
  • Source/webrtc/examples/androidjunit/src/org/appspot/apprtc/TCPChannelClientTest.java: Removed.
  • Source/webrtc/examples/androidtests: Removed.
  • Source/webrtc/examples/androidtests/AndroidManifest.xml: Removed.
  • Source/webrtc/examples/androidtests/README: Removed.
  • Source/webrtc/examples/androidtests/ant.properties: Removed.
  • Source/webrtc/examples/androidtests/build.xml: Removed.
  • Source/webrtc/examples/androidtests/project.properties: Removed.
  • Source/webrtc/examples/androidtests/src: Removed.
  • Source/webrtc/examples/androidtests/src/org: Removed.
  • Source/webrtc/examples/androidtests/src/org/appspot: Removed.
  • Source/webrtc/examples/androidtests/src/org/appspot/apprtc: Removed.
  • Source/webrtc/examples/androidtests/src/org/appspot/apprtc/test: Removed.
  • Source/webrtc/examples/androidtests/src/org/appspot/apprtc/test/FileVideoCapturerTest.java: Removed.
  • Source/webrtc/examples/androidtests/src/org/appspot/apprtc/test/PeerConnectionClientTest.java: Removed.
  • Source/webrtc/examples/androidtests/src/org/appspot/apprtc/test/VideoFileRendererTest.java: Removed.
  • Source/webrtc/examples/androidtests/src/org/appspot/apprtc/test/capturetestvideo.y4m: Removed.
  • Source/webrtc/modules/audio_device/android: Removed.
  • Source/webrtc/modules/audio_device/android/audio_common.h: Removed.
  • Source/webrtc/modules/audio_device/android/audio_device_template.h: Removed.
  • Source/webrtc/modules/audio_device/android/audio_device_unittest.cc: Removed.
  • Source/webrtc/modules/audio_device/android/audio_manager.cc: Removed.
  • Source/webrtc/modules/audio_device/android/audio_manager.h: Removed.
  • Source/webrtc/modules/audio_device/android/audio_manager_unittest.cc: Removed.
  • Source/webrtc/modules/audio_device/android/audio_record_jni.cc: Removed.
  • Source/webrtc/modules/audio_device/android/audio_record_jni.h: Removed.
  • Source/webrtc/modules/audio_device/android/audio_track_jni.cc: Removed.
  • Source/webrtc/modules/audio_device/android/audio_track_jni.h: Removed.
  • Source/webrtc/modules/audio_device/android/build_info.cc: Removed.
  • Source/webrtc/modules/audio_device/android/build_info.h: Removed.
  • Source/webrtc/modules/audio_device/android/ensure_initialized.cc: Removed.
  • Source/webrtc/modules/audio_device/android/ensure_initialized.h: Removed.
  • Source/webrtc/modules/audio_device/android/java: Removed.
  • Source/webrtc/modules/audio_device/android/java/src: Removed.
  • Source/webrtc/modules/audio_device/android/java/src/org: Removed.
  • Source/webrtc/modules/audio_device/android/java/src/org/webrtc: Removed.
  • Source/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine: Removed.
  • Source/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/BuildInfo.java: Removed.
  • Source/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioEffects.java: Removed.
  • Source/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioManager.java: Removed.
  • Source/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioRecord.java: Removed.
  • Source/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java: Removed.
  • Source/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioUtils.java: Removed.
  • Source/webrtc/modules/audio_device/android/opensles_common.cc: Removed.
  • Source/webrtc/modules/audio_device/android/opensles_common.h: Removed.
  • Source/webrtc/modules/audio_device/android/opensles_player.cc: Removed.
  • Source/webrtc/modules/audio_device/android/opensles_player.h: Removed.
  • Source/webrtc/modules/audio_device/android/opensles_recorder.cc: Removed.
  • Source/webrtc/modules/audio_device/android/opensles_recorder.h: Removed.
  • Source/webrtc/modules/audio_processing/test/android: Removed.
  • Source/webrtc/modules/audio_processing/test/android/apmtest: Removed.
  • Source/webrtc/modules/audio_processing/test/android/apmtest/AndroidManifest.xml: Removed.
  • Source/webrtc/modules/audio_processing/test/android/apmtest/default.properties: Removed.
  • Source/webrtc/modules/audio_processing/test/android/apmtest/jni: Removed.
  • Source/webrtc/modules/audio_processing/test/android/apmtest/jni/main.c: Removed.
  • Source/webrtc/modules/audio_processing/test/android/apmtest/res: Removed.
  • Source/webrtc/modules/audio_processing/test/android/apmtest/res/values: Removed.
  • Source/webrtc/modules/audio_processing/test/android/apmtest/res/values/strings.xml: Removed.
  • Source/webrtc/modules/utility/include/helpers_android.h: Removed.
  • Source/webrtc/modules/utility/include/jvm_android.h: Removed.
  • Source/webrtc/modules/utility/source/helpers_android.cc: Removed.
  • Source/webrtc/modules/utility/source/jvm_android.cc: Removed.
  • Source/webrtc/system_wrappers/source/cpu_features_android.c: Removed.
  • libwebrtc.xcodeproj/project.pbxproj:
10:51 AM Changeset in webkit [212307] by aakash_jain@apple.com
  • 3 edits in trunk/Source/WebCore

Remove unused WebThreadContextIsCurrent method from WebCoreThread.h
​https://bugs.webkit.org/show_bug.cgi?id=168254

Reviewed by Dan Bernstein.

  • platform/ios/wak/WebCoreThread.h: Removed unused WebThreadContextIsCurrent.
  • platform/ios/wak/WebCoreThread.mm:

(WebThreadContextIsCurrent): Deleted.

10:07 AM Changeset in webkit [212306] by clopez@igalia.com
  • 2 edits in trunk/Tools

[CMake] build-webkit should allow building with the default cmake configuration
​https://bugs.webkit.org/show_bug.cgi?id=168323

Reviewed by Michael Catanzaro.

Add a --default-cmake-features switch that makes the script pass
no value for any of the features defined by build-webkit, that
way the default values from the port cmake config will be used.

  • Scripts/build-webkit:

(cMakeArgsFromFeatures):

9:51 AM Changeset in webkit [212305] by Jonathan Bedard
  • 2 edits in trunk/Tools

Unreviewed build-fix after r212297.

  • Scripts/webkitpy/port/simulator_process.py:

(SimulatorProcess.stop): Handle case where there is no process to kill.

9:29 AM Changeset in webkit [212304] by graouts@webkit.org
  • 4 edits in trunk/LayoutTests

[mac-wk1] LayoutTest media/modern-media-controls/forward-button/forward-button.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=168265

Unreviewed test gardening.

  • media/modern-media-controls/forward-button/forward-button-expected.txt:
  • media/modern-media-controls/forward-button/forward-button.html:
  • platform/mac-wk1/TestExpectations:
9:27 AM Changeset in webkit [212303] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[GTK] [l10n] Updated Brazilian Portuguese translation of WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=168303

Patch by Rafael Fontenelle <​rafaelff@gnome.org> on 2017-02-14
Rubber-stamped by Michael Catanzaro.

  • pt_BR.po:
9:12 AM Changeset in webkit [212302] by ap@apple.com
  • 4 edits in trunk/Source

WebCore shouldn't export SystemMemory.h
​https://bugs.webkit.org/show_bug.cgi?id=168285

Reviewed by Alex Christensen.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit/mac:

  • MigrateHeaders.make: And WebKit shouldn't re-export it.
9:07 AM Changeset in webkit [212301] by fpizlo@apple.com
  • 3 edits
    3 adds
    3 deletes in trunk

worker.postMessage should throw a TypeError if a SharedArrayBuffer is in the transfer list
​https://bugs.webkit.org/show_bug.cgi?id=168277

Reviewed by Mark Lam.
Source/WebCore:

Test: workers/sab/postMessage-transfer-type-error.html

This is a simple spec compliance change. The title says it all.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::create):

LayoutTests:


Add a test of the new behavior, and remove tests for the old behavior.

Most of the SharedArrayBuffer tests use the new style, where the buffer is not in the
transfer list, and the tests being removed are clones of the no-transfer tests. So, we
aren't losing any coverage.

  • workers/sab/null-worker.js: Added.
  • workers/sab/postMessage-transfer-type-error-expected.txt: Added.
  • workers/sab/postMessage-transfer-type-error.html: Added.
  • workers/sab/sab-creator-transfer.js: Removed. (Sibling: sab-creator-no-transfer.js)
  • workers/sab/sent-from-worker-transfer.html: Removed. (Sibling: sent-from-worker-no-transfer.html)
  • workers/sab/simple.html: Removed. (Sibling: no-transfer.html)
9:01 AM Changeset in webkit [212300] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[mac-wk1] LayoutTest media/modern-media-controls/airplay-button/airplay-button-on.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=167347

Unreviewed test gardening.

Patch by Antoine Quint <Antoine Quint> on 2017-02-14

  • media/modern-media-controls/airplay-button/airplay-button-on-expected.txt:
  • media/modern-media-controls/airplay-button/airplay-button-on.html:
  • platform/mac-wk1/TestExpectations:
8:48 AM Changeset in webkit [212299] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

LayoutTest media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=167589

Unreviewed test gardening.

Patch by Antoine Quint <Antoine Quint> on 2017-02-14

  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles-expected.txt:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html:
8:46 AM Changeset in webkit [212298] by clopez@igalia.com
  • 2 edits in trunk/Tools

[CMake] build-webkit should print the cmake command executed
​https://bugs.webkit.org/show_bug.cgi?id=168318

Reviewed by Michael Catanzaro.

Run the cmake commands to configure or start the build through
a wrapper that prints the command before executing it.

  • Scripts/webkitdirs.pm:

(systemVerbose):
(generateBuildSystemFromCMakeProject):
(buildCMakeGeneratedProject):
(cleanCMakeGeneratedProject):

8:33 AM Changeset in webkit [212297] by Jonathan Bedard
  • 3 edits in trunk/Tools

run-webkit-tests for iOS Simulator always complains that stopping WebKitTestRunnerApp.app times out
​https://bugs.webkit.org/show_bug.cgi?id=168150

Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/port/simulator_process.py:

(SimulatorProcess.stop): Close app before calling ServerProcess's stop.
(SimulatorProcess._kill): Move closing of app into stop().

  • Scripts/webkitpy/xcode/simulator.py:

(Device.launch_app):
(Device.terminate_app): Deleted.

8:31 AM Changeset in webkit [212296] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

LayoutTest media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-buttons-styles.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=168125

Unreviewed test gardening.

Patch by Antoine Quint <Antoine Quint> on 2017-02-14

  • media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-buttons-styles-expected.txt:
  • media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-buttons-styles.html:
8:29 AM Changeset in webkit [212295] by matthew_hanson@apple.com
  • 5 edits in branches/safari-603-branch/Source

Versioning.

8:28 AM Changeset in webkit [212294] by achristensen@apple.com
  • 2 edits in trunk/LayoutTests

Rebase URL test after r212279.
​https://bugs.webkit.org/show_bug.cgi?id=168260

  • fast/url/ipv4-expected.txt:

​http://0X12C0a80001/ is an invalid IPv4 address, so parsing should fail.
This matches Chrome and the URL specification.

8:23 AM Changeset in webkit [212293] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

LayoutTest media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=167372

Unreviewed test gardening.

Patch by Antoine Quint <Antoine Quint> on 2017-02-14

  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles-expected.txt:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html:
7:45 AM Changeset in webkit [212292] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

[mac-wk1] LayoutTest media/modern-media-controls/layout-node/addChild.html is a flaky timeout
​https://bugs.webkit.org/show_bug.cgi?id=168074

Unreviewed test gardening.

Patch by Antoine Quint <Antoine Quint> on 2017-02-14

  • media/modern-media-controls/layout-node/addChild-expected.txt:
  • media/modern-media-controls/layout-node/addChild.html:
  • platform/mac-wk1/TestExpectations:
5:08 AM Changeset in webkit [212291] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Allow to use stored credentials also for downloads started by DownloadManager::startDownload
​https://bugs.webkit.org/show_bug.cgi?id=167584

Reviewed by Michael Catanzaro.

Cliking on a link that triggers a download works on an already HTTP authenticated site works, but right clicking
and downloading from the context menu shows the HTTP auth dialog again. This is because PendingDownload uses
DoNotAllowStoredCredentials unconditionally. We want to allow using cached credentials at least for
non-ephemeral sessions.

  • NetworkProcess/Downloads/DownloadManager.cpp:

(WebKit::DownloadManager::startDownload):

5:03 AM Changeset in webkit [212290] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

REGRESSION(r212192): [GTK] Broke downloads API tests
​https://bugs.webkit.org/show_bug.cgi?id=168193

Unreviewed. Update test expectations after r212192.

The suggested filename now includes a file extensions if the MIME type is known.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:

(testDownloadRemoteFile):
(testDownloadMIMEType):

4:56 AM Changeset in webkit [212289] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

HTMLMediaElement: WebKitMediaKeys member name should be prefixed
​https://bugs.webkit.org/show_bug.cgi?id=168297

Reviewed by Xabier Rodriguez-Calvar.

Rename the LEGACY_ENCRYPTED_MEDIA m_mediaKeys variable to m_webkitMediaKeys
so that it contains the legacy prefix, just like the API. This will make
room for the MediaKeys member variable that will be implemented under
the ENCRYPTED_MEDIA guards.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerCachedKeyForKeyId):
(WebCore::HTMLMediaElement::webkitSetMediaKeys):

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::webkitKeys):

4:03 AM Changeset in webkit [212288] by Carlos Garcia Campos
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed GTK+ gardening. Add platform specific resuls for http/tests/security/module-no-mime-type.html.

libsoup sniffer correctly guesses the perl MIME type as text/plain which is still an invalid JavaScript MIME type.

  • platform/gtk/http/tests/security/module-no-mime-type-expected.txt: Added.
3:58 AM Changeset in webkit [212287] by Carlos Garcia Campos
  • 5 edits in trunk/Source

[GTK] Make DragImageRef a RefPtr instead of a plain pointer
​https://bugs.webkit.org/show_bug.cgi?id=168296

Reviewed by Sergio Villar Senin.

Source/WebCore:

Use RefPtr<cairo_surface_t> as DragImageRef for GTK+ port to avoid memory leaks.

  • platform/DragImage.h:
  • platform/gtk/DragImageGtk.cpp:

(WebCore::dragImageSize):
(WebCore::deleteDragImage):
(WebCore::scaleDragImage):
(WebCore::dissolveDragImageToFraction):
(WebCore::createDragImageFromImage):
(WebCore::createDragImageIconForCachedImageFilename):

Source/WebKit2:

  • WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:

(WebKit::WebDragClient::startDrag):

3:54 AM Changeset in webkit [212286] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[SOUP] Ensure a response MIME type when Content-Type is missing and sniffing not allowed
​https://bugs.webkit.org/show_bug.cgi?id=168299

Reviewed by Sergio Villar Senin.

Sniffing is not allowed but we can try to guess the MIME using the response path, or at least fallback to
default MIME type instead of leaving an empty string. This matches what mac port does.

Fixes: http/tests/inspector/network/fetch-response-body.html

http/tests/inspector/network/xhr-response-body.html

  • NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::didSendRequest):

3:30 AM Changeset in webkit [212285] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[GStreamer][MSE] Some GStreamer log messages are generated with the 'default' category
​https://bugs.webkit.org/show_bug.cgi?id=168015

Patch by Vanessa Chipirrás Navalón <​vchipirras@igalia.com> on 2017-02-14
Reviewed by Xabier Rodriguez-Calvar.

The elements AppendPipeline, PlaybackPipeline, MediaSourceClientGstreamerMSE do not have
a defined Gstreamer log category, then the webkitmse category has been added to them.
WebKitMediaSourceGstreamer has its own category but was not declared at the beginning of
the .cpp file.

  • platform/graphics/gstreamer/mse/AppendPipeline.cpp: Added webkitmse category.
  • platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp:

Added webkitmse category and gst header.

  • platform/graphics/gstreamer/mse/PlaybackPipeline.cpp: Added webkitmse category.
  • platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:

Added webkitmediasrc category.

2:50 AM Changeset in webkit [212284] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r212237.
​https://bugs.webkit.org/show_bug.cgi?id=168298

This was a wrong fix (Requested by rniwa on #webkit).

Reverted changeset:

"Nwtr unexpectedly passes mismatch ref test if the hashes
doesn't match but no diff"
​https://bugs.webkit.org/show_bug.cgi?id=168221
​http://trac.webkit.org/changeset/212237

2:43 AM Changeset in webkit [212283] by Carlos Garcia Campos
  • 15 edits in trunk/Source

CookieManager only works with the default session
​https://bugs.webkit.org/show_bug.cgi?id=168229

Reviewed by Alex Christensen.

Source/WebCore:

Update cookie observer API to use a std::function instead of a function pointer and make it work with multiple
sessions in the backends that support it.

  • platform/network/CookieStorage.h:
  • platform/network/cf/CookieStorageCFNet.cpp:

(WebCore::cookieChangeCallbackMap):
(WebCore::notifyCookiesChanged):
(WebCore::startObservingCookieChanges):
(WebCore::stopObservingCookieChanges):

  • platform/network/mac/CookieStorageMac.mm:

(-[WebCookieStorageObjCAdapter startListeningForCookieChangeNotificationsWithCallback:]):
(-[WebCookieStorageObjCAdapter stopListeningForCookieChangeNotifications]):
(WebCore::startObservingCookieChanges):
(WebCore::stopObservingCookieChanges):

  • platform/network/soup/CookieStorageSoup.cpp:

(WebCore::cookieChangeCallbackMap):
(WebCore::soupCookiesChanged):
(WebCore::startObservingCookieChanges):
(WebCore::stopObservingCookieChanges):

Source/WebKit2:

Make CookieManager session aware by adding a SessionID parameter to all its functions, and update all the callers
to pass the default session ID, preserving the current
behavior. WebCookieManagerProxy::startObservingCookieChanges() now also receives an optional callback to be
called on every change.

  • UIProcess/API/C/WKCookieManager.cpp:

(WKCookieManagerGetHostnamesWithCookies):
(WKCookieManagerDeleteCookiesForHostname):
(WKCookieManagerDeleteAllCookies):
(WKCookieManagerDeleteAllCookiesModifiedAfterDate):
(WKCookieManagerStartObservingCookieChanges):
(WKCookieManagerStopObservingCookieChanges):

  • UIProcess/API/gtk/WebKitCookieManager.cpp:

(_WebKitCookieManagerPrivate::~_WebKitCookieManagerPrivate):
(webkitCookieManagerCreate):
(webkit_cookie_manager_set_persistent_storage):
(webkit_cookie_manager_get_domains_with_cookies):
(webkit_cookie_manager_delete_cookies_for_domain):
(webkit_cookie_manager_delete_all_cookies):

  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::addSingleCookie):
(WebKit::WebAutomationSession::deleteAllCookies):

  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::getHostnamesWithCookies):
(WebKit::WebCookieManagerProxy::deleteCookiesForHostname):
(WebKit::WebCookieManagerProxy::deleteAllCookies):
(WebKit::WebCookieManagerProxy::deleteAllCookiesModifiedSince):
(WebKit::WebCookieManagerProxy::addCookie):
(WebKit::WebCookieManagerProxy::startObservingCookieChanges):
(WebKit::WebCookieManagerProxy::stopObservingCookieChanges):
(WebKit::WebCookieManagerProxy::cookiesDidChange):

  • UIProcess/WebCookieManagerProxy.h:
  • UIProcess/WebCookieManagerProxy.messages.in:
  • WebProcess/Cookies/WebCookieManager.cpp:

(WebKit::WebCookieManager::WebCookieManager):
(WebKit::WebCookieManager::getHostnamesWithCookies):
(WebKit::WebCookieManager::deleteCookiesForHostname):
(WebKit::WebCookieManager::deleteAllCookies):
(WebKit::WebCookieManager::deleteAllCookiesModifiedSince):
(WebKit::WebCookieManager::addCookie):
(WebKit::WebCookieManager::startObservingCookieChanges):
(WebKit::WebCookieManager::stopObservingCookieChanges):

  • WebProcess/Cookies/WebCookieManager.h:
  • WebProcess/Cookies/WebCookieManager.messages.in:
2:09 AM Changeset in webkit [212282] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

Fix typo in performance-observer-callback-mutate.html
​https://bugs.webkit.org/show_bug.cgi?id=168294

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-02-14
Reviewed by Ryosuke Niwa.

  • performance-api/performance-observer-callback-mutate-expected.txt:
  • performance-api/performance-observer-callback-mutate.html:
1:43 AM Changeset in webkit [212281] by tpopela@redhat.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed, fix documentation typo

  • UIProcess/API/gtk/WebKitEditingCommands.h:
12:11 AM Changeset in webkit [212280] by graouts@webkit.org
  • 65 edits
    3 copies
    3 adds
    3 deletes in trunk

REGRESSION: Update volume and scrubbing slider to match HI designs
​https://bugs.webkit.org/show_bug.cgi?id=168170
<rdar://problem/28095266>

Reviewed by Dean Jackson.

Source/WebCore:

We bring the designs of the control's background materials, scrubber and
volume slider up to spec.

The first important set of changes is that, on macOS, the materials and colors
were incorrect. Buttons and time labels now set a mix-blend-mode to correctly
appear vibrant against the media, and the controls bar, volume container
and tracks menu now use a new BackgroundTint node to correctly apply both
a backdrop-filter and blended tint above it.

The second important set of changes is the rendering of the sliders. Up to now
we would simply style the <input type="range"> track and thumb, applying solid
fills and strokes. We now draw sliders in two ways depending on the platform.

On macOS, we draw the whole slider with a <canvas> element with "mix-blend-mode"
set to "plus-lighter". On iOS, we draw the track as a <div> with "mix-blend-mode"
set to "plus-darker" and draw the fill (up to the thumb) in the <canvas> with
no blend mode to obtain a pure white color, finally the thumb is rendered by the
<input> element. We couldn't draw the pure white color with the track in the
same <canvas> due to the "plus-darker" blend mode.

Test: media/modern-media-controls/background-tint/background-tint.html

  • Modules/modern-media-controls/controls/airplay-button.css:

(button.airplay.on):

  • Modules/modern-media-controls/controls/background-tint.css: Added.

(.background-tint):
(.background-tint,):
(.background-tint > .blur):
(.background-tint > .tint):

  • Modules/modern-media-controls/controls/background-tint.js: Added.

(BackgroundTint):

  • Modules/modern-media-controls/controls/ios-inline-media-controls.css:

(.media-controls.ios.inline .scrubber.slider):
(.media-controls.ios.inline .scrubber.slider > div):
(.media-controls.ios.inline .scrubber.slider > input::-webkit-slider-thumb):
(.media-controls.ios.inline .scrubber.slider > .fill): Deleted.

  • Modules/modern-media-controls/controls/macos-compact-inline-media-controls.css:

(.media-controls.mac.inline.compact .volume-slider-container):
(.media-controls.mac.inline.compact .volume.slider):
(.media-controls.mac.inline.compact .scrubber.slider > input::-webkit-slider-thumb): Deleted.

  • Modules/modern-media-controls/controls/macos-fullscreen-media-controls.css:

(.media-controls.mac.fullscreen > .controls-bar):
(.media-controls.mac.fullscreen > .controls-bar > .background-tint > div):
(.media-controls.mac.fullscreen .volume.slider):
(.media-controls.mac.fullscreen button.volume-up):
(.media-controls.mac.fullscreen button.rewind):
(.media-controls.mac.fullscreen button.forward):
(.media-controls.mac.fullscreen .buttons-container.right button):
(.media-controls.mac.fullscreen .scrubber):
(.media-controls.mac.fullscreen > .controls-bar button): Deleted.
(.media-controls.mac.fullscreen button.airplay): Deleted.
(.media-controls.mac.fullscreen button.aspect-ratio): Deleted.
(.media-controls.mac.fullscreen button.pip): Deleted.
(.media-controls.mac.fullscreen button.tracks): Deleted.
(.media-controls.mac.fullscreen button.fullscreen): Deleted.

  • Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js:
  • Modules/modern-media-controls/controls/macos-inline-media-controls.css:

(.media-controls.mac.inline .scrubber.slider):
(.media-controls.mac.inline .volume-slider-container):
(.media-controls.mac.inline .volume-slider-container > .background-tint):
(.media-controls.mac.inline .volume-slider-container > .background-tint > div):
(.media-controls.mac.inline .volume.slider):
(.media-controls.mac.inline button): Deleted.
(.media-controls.mac.inline button:active): Deleted.
(.media-controls.mac.inline > .controls-bar button): Deleted.
(.media-controls.mac.inline > .controls-bar,): Deleted.
(.media-controls.mac.inline .volume-slider-container:before): Deleted.

  • Modules/modern-media-controls/controls/macos-inline-media-controls.js:

(MacOSInlineMediaControls.prototype.layout):

  • Modules/modern-media-controls/controls/macos-media-controls.css: Added.

(.media-controls.mac button:active):
(.media-controls.mac > .controls-bar button):
(.media-controls.mac > .controls-bar .time-label):
(.media-controls.mac > .controls-bar .slider > canvas):
(.media-controls.mac > .controls-bar .slider > input::-webkit-slider-thumb):

  • Modules/modern-media-controls/controls/scrubber.css: Removed.
  • Modules/modern-media-controls/controls/scrubber.js:

(Scrubber):
(Scrubber.prototype.get buffered):
(Scrubber.prototype.set buffered):
(Scrubber.prototype.draw):
(Scrubber.prototype._drawMacOS):
(Scrubber.prototype._drawiOS):

  • Modules/modern-media-controls/controls/slider.css:

(.slider):
(.slider > canvas,):
(.slider > canvas):
(.slider > input):
(.slider > input,): Deleted.
(.slider > .fill): Deleted.
(.slider > input::-webkit-slider-thumb): Deleted.

  • Modules/modern-media-controls/controls/slider.js:

(Slider.prototype.set value):
(Slider.prototype.set width):
(Slider.prototype.commitProperty):
(Slider.prototype.layout):
(Slider.prototype.draw):
(Slider.prototype._handleInputEvent):
(Slider.prototype._handleChangeEvent):
(addRoundedRect):
(Slider.prototype._updateFill): Deleted.

  • Modules/modern-media-controls/controls/start-button.css:

(button.start):

  • Modules/modern-media-controls/controls/time-control.js:
  • Modules/modern-media-controls/controls/time-label.css:

(.time-label):

  • Modules/modern-media-controls/controls/tracks-panel.css:

(.tracks-panel):
(.tracks-panel > .background-tint > div):
(.tracks-panel > section):
(.tracks-panel > section:first-of-type):
(.tracks-panel > section > h3):
(.tracks-panel > section > ul):
(.tracks-panel > section > ul > li):
(.tracks-panel > section > ul > li:focus):
(.tracks-panel > section > ul > li.selected:before):
(.tracks-panel > section > ul > li.animated):
(.tracks-panel-section): Deleted.
(.tracks-panel-section:first-of-type): Deleted.
(.tracks-panel-section > h3): Deleted.
(.tracks-panel-section > ul): Deleted.
(.tracks-panel-section > ul > li): Deleted.
(.tracks-panel-section > ul > li:focus): Deleted.
(.tracks-panel-section > ul > li.selected:before): Deleted.
(.tracks-panel-section > ul > li.animated): Deleted.

  • Modules/modern-media-controls/controls/tracks-panel.js:

(TracksPanel.prototype._childrenFromDataSource):
(TracksPanel.prototype._childrenFromDataSource.): Deleted.

  • Modules/modern-media-controls/controls/volume-slider.js:

(VolumeSlider):
(VolumeSlider.prototype.handleEvent):
(VolumeSlider.prototype.draw):

  • Modules/modern-media-controls/js-files:
  • Modules/modern-media-controls/media/scrubbing-support.js:

(ScrubbingSupport.prototype.get mediaEvents):
(ScrubbingSupport.prototype.syncControl):
(ScrubbingSupport):

LayoutTests:

Rebaselining a host of existing tests to account for new DOM structure, metrics,
colors, blend modes, etc. We're also adding a new test for the BackgroundTint
class and removing one for the slider fill which is no longer appopriate since
we're drawing the slider's fill with a <canvas> element rather than a DOM element.

  • media/modern-media-controls/background-tint/background-tint-expected.txt: Added.
  • media/modern-media-controls/background-tint/background-tint.html: Added.
  • media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-time-control-styles-expected.txt:
  • media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-time-control-styles.html:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles-expected.txt:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-constructor-expected.txt:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-constructor.html:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-controls-bar-styles-expected.txt:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-controls-bar-styles.html:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-right-container-margin.html:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-time-control-styles-expected.txt:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-time-control-styles.html:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-volume-styles-expected.txt:
  • media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-volume-styles.html:
  • media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-buttons-styles-expected.txt:
  • media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-buttons-styles.html:
  • media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-constructor-expected.txt:
  • media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-constructor.html:
  • media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-controls-bar-styles-expected.txt:
  • media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-controls-bar-styles.html:
  • media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-layout-expected.txt:
  • media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-layout.html:
  • media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-resize-with-hidden-controls-bar.html:
  • media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-time-control-styles-expected.txt:
  • media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-time-control-styles.html:
  • media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-volume-styles-expected.txt:
  • media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-volume-styles.html:
  • media/modern-media-controls/resources/media-controls-loader.js:
  • media/modern-media-controls/scrubber/scrubber.html:
  • media/modern-media-controls/slider/slider-constructor-expected.txt:
  • media/modern-media-controls/slider/slider-constructor.html:
  • media/modern-media-controls/slider/slider-fill-expected.txt: Removed.
  • media/modern-media-controls/slider/slider-fill.html: Removed.
  • media/modern-media-controls/slider/slider-styles-expected.txt:
  • media/modern-media-controls/slider/slider-styles.html:
  • media/modern-media-controls/time-label/time-label-expected.txt:
  • media/modern-media-controls/time-label/time-label.html:
  • media/modern-media-controls/tracks-panel/tracks-panel-population-expected.txt:
  • media/modern-media-controls/tracks-panel/tracks-panel-population.html:
  • media/modern-media-controls/tracks-support/tracks-support-show-and-populate-panel.html:
  • media/modern-media-controls/volume-slider/volume-slider-value-expected.txt:
  • media/modern-media-controls/volume-slider/volume-slider-value.html:
  • media/modern-media-controls/volume-slider/volume-slider.html:
  • media/modern-media-controls/volume-support/volume-support-click-expected.txt:
  • media/modern-media-controls/volume-support/volume-support-click.html:
  • media/modern-media-controls/volume-support/volume-support-drag-expected.txt:
  • media/modern-media-controls/volume-support/volume-support-drag.html:

Feb 13, 2017:

11:43 PM Changeset in webkit [212279] by achristensen@apple.com
  • 13 edits in trunk

URLs with an invalid IPv4 address should be invalid
​https://bugs.webkit.org/show_bug.cgi?id=168260

Reviewed by Tim Horton.

LayoutTests/imported/w3c:

  • web-platform-tests/url/a-element-expected.txt:
  • web-platform-tests/url/a-element-xhtml-expected.txt:
  • web-platform-tests/url/url-constructor-expected.txt:

Source/WebCore:

All URL hosts are fed through the IPv4 parser. ​https://webkit.org/ doesn't
look enough like an IPv4 address to be considered an invalid IPv4 address, so
we continue to the String host processing. ​http://127.0.0.257 does, though, and
according to ​https://url.spec.whatwg.org/#concept-ipv4-parser parsing that URL
should fail.

Covered by newly passing web platform tests.

  • platform/URLParser.cpp:

(WebCore::URLParser::parseIPv4Host):
(WebCore::URLParser::parseHostAndPort):

  • platform/URLParser.h:

Source/WTF:

  • wtf/Expected.h:

(WTF::Expected::value):
Added missing WTFMove for rvalue Expected::value().

Tools:

  • TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::TEST_F):
Update tests to reflect new correct behavior.

LayoutTests:

  • fetch/fetch-url-serialization-expected.txt:
11:16 PM Changeset in webkit [212278] by ap@apple.com
  • 2 edits in trunk/Source/WebKit/mac

WebKit shouldn't re-export ScrollTypes.h and WebCoreFrameView.h
​https://bugs.webkit.org/show_bug.cgi?id=168282

Reviewed by Dan Bernstein.

  • MigrateHeaders.make:
11:00 PM Changeset in webkit [212277] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Reverted r212275. It still breaks some Apple-internal builds.

  • platform/spi/mac/TUCallSPI.h:
9:57 PM Changeset in webkit [212276] by commit-queue@webkit.org
  • 16 edits in trunk/Source/WebCore

Address ESLint warnings in modern-media-controls
​https://bugs.webkit.org/show_bug.cgi?id=168224

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-02-13
Reviewed by Alexey Proskuryakov.

  • Modules/modern-media-controls/controls/controls-bar.js:
  • Modules/modern-media-controls/controls/fullscreen-button.js:
  • Modules/modern-media-controls/controls/layout-node.js:
  • Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js:
  • Modules/modern-media-controls/controls/media-controls.js:
  • Modules/modern-media-controls/controls/scheduler.js:
  • Modules/modern-media-controls/controls/seek-button.js:
  • Modules/modern-media-controls/controls/tracks-panel.js:
  • Modules/modern-media-controls/controls/volume-slider.js:
  • Modules/modern-media-controls/gesture-recognizers/gesture-recognizer.js:
  • Modules/modern-media-controls/gesture-recognizers/pinch.js:
  • Modules/modern-media-controls/media/fullscreen-support.js:
  • Modules/modern-media-controls/media/media-controller.js:
  • Modules/modern-media-controls/media/placard-support.js:
  • Modules/modern-media-controls/media/status-support.js:

Address pedantic warnings.

9:40 PM Changeset in webkit [212275] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Restored changes from r212210 in a way that does not break the build.

  • platform/spi/mac/TUCallSPI.h:
7:27 PM Changeset in webkit [212274] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

FontCascade::widthForSimpleText should skip applyTransforms() when kerning and ligatures are off.
​https://bugs.webkit.org/show_bug.cgi?id=168251
<rdar://problem/30498102>

Reviewed by Antti Koivisto.

Covered by existing (perf)tests.

  • platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::widthForSimpleText):

6:29 PM Changeset in webkit [212273] by commit-queue@webkit.org
  • 7 edits
    1 add in trunk/Source/WebInspectorUI

Web Inspector: provide a way to show current value of CSS variables in style rules
​https://bugs.webkit.org/show_bug.cgi?id=168172

Patch by Devin Rousso <Devin Rousso> on 2017-02-13
Reviewed by Timothy Hatcher.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Images/CSSVariable.svg: Added.
  • UserInterface/Models/TextMarker.js:

(WebInspector.TextMarker.Type):

  • UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor._createInlineSwatches.update):

  • UserInterface/Views/CodeMirrorTextMarkers.js:

(createCodeMirrorTextMarkers):
(createCodeMirrorVariableTextMarkers):

  • UserInterface/Views/InlineSwatch.css:

(.inline-swatch.variable):
(.inline-swatch:matches(.bezier, .spring, .variable)):
(.inline-swatch:matches(.bezier, .spring, .variable):hover):
(.inline-swatch:matches(.bezier, .spring, .variable):active):
(.inline-swatch-variable-popover):
(.inline-swatch-variable-popover .CodeMirror):
(.inline-swatch-variable-popover .CodeMirror pre):
(.inline-swatch:matches(.bezier, .spring):hover): Deleted.
(.inline-swatch:matches(.bezier, .spring):active): Deleted.

  • UserInterface/Views/InlineSwatch.js:

(WebInspector.InlineSwatch):
(WebInspector.InlineSwatch.prototype._fallbackValue):
(WebInspector.InlineSwatch.prototype._swatchElementClicked):
(WebInspector.InlineSwatch.prototype._valueEditorValueDidChange):
(WebInspector.InlineSwatch.Type):

6:28 PM Changeset in webkit [212272] by BJ Burg
  • 13 edits in trunk/Source

Web Inspector: expose system user interface layout direction through InspectorFrontendHost
​https://bugs.webkit.org/show_bug.cgi?id=168209
<rdar://problem/11573736>

Reviewed by Joseph Pecoraro.

Forward the UserInterfaceLayoutDirection of the inspector page. If the WebKit client has
properly set the UI directionality from system settings in PageClient, this will get inherited
automatically by the Inspector's WebPage instance.

Source/WebCore:

  • inspector/InspectorFrontendClient.h:
  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::userInterfaceLayoutDirection):

  • inspector/InspectorFrontendClientLocal.h:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::userInterfaceLayoutDirection):
Expose the directionality to the frontend as "ltr" or "rtl" strings.

Source/WebKit2:

  • WebProcess/WebPage/RemoteWebInspectorUI.cpp:

(WebKit::RemoteWebInspectorUI::userInterfaceLayoutDirection):

  • WebProcess/WebPage/RemoteWebInspectorUI.h:
  • WebProcess/WebPage/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::userInterfaceLayoutDirection):

  • WebProcess/WebPage/WebInspectorUI.h:
6:20 PM Changeset in webkit [212271] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

Simple line layout: Do not measure runs with trailing whitespace when kerning and ligatures are off.
​https://bugs.webkit.org/show_bug.cgi?id=168247
<rdar://problem/30497288>

Reviewed by Antti Koivisto.

The width of the run is supposed to be the same with or without the trailing whitespace.

Covered by performance test.

  • rendering/SimpleLineLayoutTextFragmentIterator.cpp:

(WebCore::SimpleLineLayout::TextFragmentIterator::Style::Style):
(WebCore::SimpleLineLayout::TextFragmentIterator::textWidth):

  • rendering/SimpleLineLayoutTextFragmentIterator.h:
6:11 PM Changeset in webkit [212270] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Source/WebCore:
Added the other missing BSTR roles tag names.
​https://bugs.webkit.org/show_bug.cgi?id=165545

Patch by Karim H <​karim@karhm.com> on 2017-02-13
Reviewed by Chris Fleizach.

Test: accessibility/win/bstr-elements-role.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::shouldReturnTagNameAsRoleForMSAA):

LayoutTests:
Added the BSTR roles tag test for Windows.
​https://bugs.webkit.org/show_bug.cgi?id=165545

Patch by Karim H <​karim@karhm.com> on 2017-02-13
Reviewed by Chris Fleizach.

  • accessibility/win/bstr-elements-role-expected.txt: Added.
  • accessibility/win/bstr-elements-role.html: Added.
6:09 PM Changeset in webkit [212269] by commit-queue@webkit.org
  • 16 edits
    1 move
    1 delete in trunk/Source

[WebRTC] Creating RTCPeerConnection with libwebrtc backend is crashing on rwt
​https://bugs.webkit.org/show_bug.cgi?id=168250

Patch by Youenn Fablet <​youennf@gmail.com> on 2017-02-13
Reviewed by Alex Christensen.

Source/WebCore:

Covered by webrtc tests in LayoutTests and in web-platform-tests.
Making mock peer connection factory keep a ref of the real libwebrtc peer connection factory.
That way, it can create real libwebrtc backends whenever requested by tests.

Moving LibWebRTCUtils.h routines as static LibWebRTCProvider methods.
In the future, we should make them no longer static.

  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::doCreateOffer):
(WebCore::LibWebRTCMediaEndpoint::doCreateAnswer):

  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mediastream/libwebrtc/LibWebRTCProvider.cpp: Renamed from Source/WebCore/platform/mediastream/libwebrtc/LibWebRTCUtils.cpp.

(WebCore::LibWebRTCProvider::callOnWebRTCNetworkThread):
(WebCore::LibWebRTCProvider::callOnWebRTCSignalingThread):
(WebCore::LibWebRTCProvider::factory):
(WebCore::LibWebRTCProvider::setPeerConnectionFactory):
(WebCore::createActualPeerConnection):
(WebCore::LibWebRTCProvider::createPeerConnection):

  • platform/mediastream/libwebrtc/LibWebRTCProvider.h:
  • platform/mediastream/libwebrtc/LibWebRTCUtils.h: Removed.
  • platform/mediastream/mac/RealtimeOutgoingAudioSource.cpp:

(WebCore::RealtimeOutgoingAudioSource::audioSamplesAvailable):

  • testing/Internals.cpp:
  • testing/MockLibWebRTCPeerConnection.cpp:

(WebCore::useMockRTCPeerConnectionFactory):
(WebCore::MockLibWebRTCPeerConnectionForIceCandidates::gotLocalDescription):
(WebCore::releaseInNetworkThread):
(WebCore::MockLibWebRTCPeerConnection::SetLocalDescription):
(WebCore::MockLibWebRTCPeerConnection::SetRemoteDescription):
(WebCore::MockLibWebRTCPeerConnection::CreateOffer):
(WebCore::MockLibWebRTCPeerConnection::CreateAnswer):

Source/WebKit2:

  • WebProcess/Network/webrtc/LibWebRTCProvider.cpp:

(WebKit::LibWebRTCProvider::createPeerConnection):

  • WebProcess/Network/webrtc/LibWebRTCProvider.h:
  • WebProcess/Network/webrtc/LibWebRTCSocket.h:
  • WebProcess/Network/webrtc/WebRTCMonitor.cpp:

(WebKit::WebRTCMonitor::StartUpdating):
(WebKit::WebRTCMonitor::networksChanged):

  • WebProcess/Network/webrtc/WebRTCMonitor.h:
  • WebProcess/Network/webrtc/WebRTCResolver.cpp:

(WebKit::WebRTCResolver::setResolvedAddress):
(WebKit::WebRTCResolver::resolvedAddressError):

  • WebProcess/Network/webrtc/WebRTCSocket.cpp:

(WebKit::WebRTCSocket::signalOnNetworkThread):

5:46 PM Changeset in webkit [212268] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[WinCairo] Add Build Slave
​https://bugs.webkit.org/show_bug.cgi?id=168263

Patch by Don Olmstead <​don.olmstead@am.sony.com> on 2017-02-13
Reviewed by Lucas Forschler.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
5:44 PM Changeset in webkit [212267] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Simplify DragController::startDrag
​https://bugs.webkit.org/show_bug.cgi?id=168240

Reviewed by Tim Horton.

Use early returns instead of assigning to a variable that's returned at the end of the function.

  • page/DragController.cpp:

(WebCore::DragController::startDrag):

5:32 PM Changeset in webkit [212266] by Megan Gardner
  • 5 edits in trunk/Source/WebKit2

Implement Drag cancels
​https://bugs.webkit.org/show_bug.cgi?id=168266

Reviewed by Wenson Hsieh.

Adds support for the UI Process to cancel already started drag events.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::cancelledDrag):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::cancelledDrag):

  • WebProcess/WebPage/WebPage.messages.in:
5:29 PM Changeset in webkit [212265] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

The current frame of an image should not deleted if another frame is asynchronously being decoded
​https://bugs.webkit.org/show_bug.cgi?id=167618

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2017-02-13
Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/images/animated-image-draw-while-decode.html

If the memory cache asks the BitmapImage to destroy all its frames while
the next frame is being decoded, a thread contention may happen. This can
happen when BitmapImage::draw() is called and the next frame is not ready
yet for drawing, so the current frame has to be drawn. This will invoke
a frame decoding in the same image from the drawing committing thread.

We can avoid that by destroying all the frames except the current frame if
the image is asynchronously decoding its frames. This should not add extra
memory overhead because building the image frame cache and then destroying
it, when needed, is an on-going process. The frames will be allocated and
decoded all the time and all of them can be destroyed except the current one.

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::destroyDecodedData):
(WebCore::BitmapImage::destroyDecodedDataIfNecessary):
The logic of destroying the ImageFrames was split among BitmapImage, ImageSource
and ImageFrameCache. Move all the logic to BitmapImage and have ImageFrameCache
be responsible only for destroying a range of ImageFrames.

(WebCore::BitmapImage::draw): add an ASSERT_IMPLIES to ensure the current frame
is ready to be rendered if the next frame is being decoded.

  • platform/graphics/BitmapImage.h: Move a const from ImageFrameCache.h to BitmapImage.h.
  • platform/graphics/ImageFrameCache.cpp:

(WebCore::ImageFrameCache::destroyDecodedData):
(WebCore::ImageFrameCache::destroyDecodedDataIfNecessary): Deleted.

  • platform/graphics/ImageFrameCache.h:

(WebCore::ImageFrameCache::destroyAllDecodedData):
(WebCore::ImageFrameCache::destroyAllDecodedDataExcludeFrame):
(WebCore::ImageFrameCache::destroyDecodedDataBeforeFrame):
Make ImageFrameCache be responsible for destroying a range of ImageFrames.
This range might include all the frames, all the frames but up to a specific
frame, or all the frames but exclude one frame in the middle.

  • platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::clear): No need to call clearFrameBufferCache() from clear().
The decision to call clearFrameBufferCache() or clear() is moved to
BitmapImage::destroyDecodedData().

(WebCore::ImageSource::destroyDecodedData): Deleted.
(WebCore::ImageSource::destroyDecodedDataIfNecessary): Deleted.
These functions are replaced by another set of functions in ImageSource.h.

  • platform/graphics/ImageSource.h:

(WebCore::ImageSource::destroyAllDecodedData):
(WebCore::ImageSource::destroyAllDecodedDataExcludeFrame):
(WebCore::ImageSource::destroyDecodedDataBeforeFrame):
(WebCore::ImageSource::hasDecodingQueue):
These are new wrappers which call the corresponding ImageFrameCache functions.

Source/WTF:

Add ASSERT_IMPLIES() which should fire when a condition is true but the
assertion is false.

  • wtf/Assertions.h:

LayoutTests:

This test did not crash on Mac when running it without this patch. But
the new ASSERT_IMPLIES(), which is added to BitmapImage::draw(), fires
when the other changes are not included. So the bug could have happened
without the patch but the crash did not since it requires a thread
contention in the system underlying components.

  • fast/images/animated-image-draw-while-decode-expected.txt: Added.
  • fast/images/animated-image-draw-while-decode.html: Added.
5:18 PM Changeset in webkit [212264] by Wenson Hsieh
  • 2 edits in trunk/Tools

Fix the build after r212254

  • TestWebKitAPI/ios/DataInteractionSimulator.mm:

(-[DataInteractionSimulator _currentLocation]):

5:17 PM Changeset in webkit [212263] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

[Cocoa] Stop soft-linking CTRunGetBaseAdvancesAndOrigins()
​https://bugs.webkit.org/show_bug.cgi?id=168256

Reviewed by Alex Christensen.

Use of this function is already behind a platform guard.

No new tests because there is no behavior change.

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

(SOFT_LINK): Deleted.

5:08 PM Changeset in webkit [212262] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

asyncDisassembly crashes on iOS
​https://bugs.webkit.org/show_bug.cgi?id=168259

Reviewed by Filip Pizlo.

Eliminated the dumping of the disassembly for the JIT write thunk.
Not only does it fix the crash, but given the nature of the JIT
write thunk, we probably don't want to disassemble it anyway.

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(JSC::FixedVMPoolExecutableAllocator::jitWriteThunkGenerator):

5:07 PM Changeset in webkit [212261] by jiewen_tan@apple.com
  • 62 edits in trunk

[WebCrypto] WebInspector should indicate webkitSubtle is deprecated
​https://bugs.webkit.org/show_bug.cgi?id=165913
<rdar://problem/30477222>

Reviewed by Joseph Pecoraro.

Source/WebCore:

Covered by existing tests.

  • page/Crypto.cpp:

(WebCore::Crypto::webkitSubtle):

LayoutTests:

  • crypto/subtle/rsassa-pkcs1-v1_5-generate-key-with-leading-zeroes-in-exponent.html:

Change webkitSubtle to subtle.

  • crypto/webkitSubtle/aes-cbc-192-encrypt-decrypt-expected.txt:
  • crypto/webkitSubtle/aes-cbc-256-encrypt-decrypt-expected.txt:
  • crypto/webkitSubtle/aes-cbc-encrypt-decrypt-expected.txt:
  • crypto/webkitSubtle/aes-cbc-encrypt-decrypt-with-padding-expected.txt:
  • crypto/webkitSubtle/aes-cbc-generate-key-expected.txt:
  • crypto/webkitSubtle/aes-cbc-import-jwk-expected.txt:
  • crypto/webkitSubtle/aes-cbc-invalid-length-expected.txt:
  • crypto/webkitSubtle/aes-cbc-unwrap-failure-expected.txt:
  • crypto/webkitSubtle/aes-cbc-unwrap-rsa-expected.txt:
  • crypto/webkitSubtle/aes-cbc-wrap-rsa-expected.txt:
  • crypto/webkitSubtle/aes-cbc-wrap-rsa-non-extractable-expected.txt:
  • crypto/webkitSubtle/aes-cbc-wrong-key-class-expected.txt:
  • crypto/webkitSubtle/aes-export-key-expected.txt:
  • crypto/webkitSubtle/aes-kw-key-manipulation-expected.txt:
  • crypto/webkitSubtle/aes-kw-wrap-unwrap-aes-expected.txt:
  • crypto/webkitSubtle/aes-postMessage-expected.txt:
  • crypto/webkitSubtle/argument-conversion-expected.txt:
  • crypto/webkitSubtle/array-buffer-view-offset-expected.txt:
  • crypto/webkitSubtle/gc-2-expected.txt:
  • crypto/webkitSubtle/gc-expected.txt:
  • crypto/webkitSubtle/hmac-check-algorithm-expected.txt:
  • crypto/webkitSubtle/hmac-export-key-expected.txt:
  • crypto/webkitSubtle/hmac-generate-key-expected.txt:
  • crypto/webkitSubtle/hmac-import-jwk-expected.txt:
  • crypto/webkitSubtle/hmac-postMessage-expected.txt:
  • crypto/webkitSubtle/hmac-sign-verify-empty-key-expected.txt:
  • crypto/webkitSubtle/hmac-sign-verify-expected.txt:
  • crypto/webkitSubtle/import-jwk-expected.txt:
  • crypto/webkitSubtle/jwk-export-use-values-expected.txt:
  • crypto/webkitSubtle/jwk-import-use-values-expected.txt:
  • crypto/webkitSubtle/rsa-export-generated-keys-expected.txt:
  • crypto/webkitSubtle/rsa-export-key-expected.txt:
  • crypto/webkitSubtle/rsa-export-private-key-expected.txt:
  • crypto/webkitSubtle/rsa-indexeddb-expected.txt:
  • crypto/webkitSubtle/rsa-indexeddb-non-exportable-expected.txt:
  • crypto/webkitSubtle/rsa-indexeddb-non-exportable-private-expected.txt:
  • crypto/webkitSubtle/rsa-indexeddb-private-expected.txt:
  • crypto/webkitSubtle/rsa-oaep-generate-non-extractable-key-expected.txt:
  • crypto/webkitSubtle/rsa-oaep-key-manipulation-expected.txt:
  • crypto/webkitSubtle/rsa-oaep-plaintext-length-expected.txt:
  • crypto/webkitSubtle/rsa-oaep-wrap-unwrap-aes-expected.txt:
  • crypto/webkitSubtle/rsa-postMessage-expected.txt:
  • crypto/webkitSubtle/rsaes-pkcs1-v1_5-decrypt-expected.txt:
  • crypto/webkitSubtle/rsaes-pkcs1-v1_5-wrap-unwrap-aes-expected.txt:
  • crypto/webkitSubtle/rsassa-pkcs1-v1_5-generate-key-expected.txt:
  • crypto/webkitSubtle/rsassa-pkcs1-v1_5-generate-key-with-leading-zeroes-in-exponent-expected.txt:
  • crypto/webkitSubtle/rsassa-pkcs1-v1_5-import-jwk-expected.txt:
  • crypto/webkitSubtle/rsassa-pkcs1-v1_5-import-jwk-small-key-expected.txt:
  • crypto/webkitSubtle/rsassa-pkcs1-v1_5-sign-verify-expected.txt:
  • crypto/webkitSubtle/sha-1-expected.txt:
  • crypto/webkitSubtle/sha-224-expected.txt:
  • crypto/webkitSubtle/sha-256-expected.txt:
  • crypto/webkitSubtle/sha-384-expected.txt:
  • crypto/webkitSubtle/sha-512-expected.txt:
  • crypto/webkitSubtle/unimplemented-unwrap-crash-expected.txt:
  • crypto/webkitSubtle/unwrapKey-check-usage-expected.txt:
  • crypto/webkitSubtle/wrapKey-check-usage-expected.txt:
  • fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt:
4:47 PM Changeset in webkit [212260] by Simon Fraser
  • 8 edits in trunk/Source

Call WKDestroyRenderingResources() on iOS when tabs are backgrounded
​https://bugs.webkit.org/show_bug.cgi?id=168261
rdar://problem/30481079

Reviewed by Tim Horton.

Source/WebCore:

Add CABackingStoreCollectBlocking() to QuartzCoreSPI.h, and fix files in WebCore
that do a framework include.

  • platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:
  • platform/graphics/cocoa/WebActionDisablingCALayerDelegate.h:
  • platform/spi/cocoa/QuartzCoreSPI.h:
  • platform/spi/mac/NSViewSPI.h:

Source/WebKit2:

There's code to call CABackingStoreCollectBlocking() on a 10s timer that exists for Mac, but on iOS
the web processes are suspended before this timer fires. So call CABackingStoreCollectBlocking()
from WebProcess::actualPrepareToSuspend(), which is where we also trigger the markAllLayersVolatile()
code.

Also add CABackingStoreCollectBlocking() to QuartzCoreSPI.h so we can use it without using WKSI.

Release-log how long this takes, in case we get reports of bad performance. In my testing it could be up to 10ms.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::actualPrepareToSuspend):

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::destroyRenderingResources):

4:44 PM Changeset in webkit [212259] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/layout-node/addChild.html as flaky on El Capitan WK1.
​https://bugs.webkit.org/show_bug.cgi?id=168074

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
4:26 PM Changeset in webkit [212258] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/forward-button/forward-button.html as flaky on mac-wk1.
​https://bugs.webkit.org/show_bug.cgi?id=168265

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
4:16 PM Changeset in webkit [212257] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

ASSERTION FAILED: !m_bodyLoader
​https://bugs.webkit.org/show_bug.cgi?id=166986

Patch by Youenn Fablet <​youenn@apple.com> on 2017-02-13
Reviewed by Sam Weinig.

Refactoring to make the unset/set pending activity part of body loader.
This allows ensuring to not forget to do that by simply deleting the body loader.

  • Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::fetch):
(WebCore::FetchResponse::BodyLoader::didSucceed):
(WebCore::FetchResponse::BodyLoader::didFail):
(WebCore::FetchResponse::BodyLoader::BodyLoader):
(WebCore::FetchResponse::BodyLoader::~BodyLoader):
(WebCore::FetchResponse::stop):

  • Modules/fetch/FetchResponse.h:
3:26 PM Changeset in webkit [212256] by beidson@apple.com
  • 4 edits in trunk/Source

Followup to: Replace all WebKit Library Version checks in WK2 with SDK version checks.
​https://bugs.webkit.org/show_bug.cgi?id=168124

Reviewed by Geoffrey Garen.

Source/WebKit2:

  • UIProcess/Cocoa/VersionChecks.h:

Source/WTF:

  • wtf/spi/darwin/dyldSPI.h:
3:10 PM Changeset in webkit [212255] by aakash_jain@apple.com
  • 3 edits
    1 delete in trunk/Source/WebCore

Remove unused WebCoreThreadSafe.h
​https://bugs.webkit.org/show_bug.cgi?id=168236

Reviewed by Dan Bernstein.

  • platform/ios/wak/WebCoreThreadSafe.h: Removed.
  • WebCore.xcodeproj/project.pbxproj: Removed WebCoreThreadSafe.h
  • platform/ios/wak/WebCoreThread.mm: Removed WebCoreThreadSafe.h and included WAKWindow.h directly
3:10 PM Changeset in webkit [212254] by Wenson Hsieh
  • 9 edits
    7 adds in trunk

[WK2] Add test infrastructure and unit tests for data interaction
​https://bugs.webkit.org/show_bug.cgi?id=168159
<rdar://problem/30477634>

Reviewed by Tim Horton.

Source/WebKit2:

Adds support at the WebKit2 layer for testing data interaction. Introduces the _WKTestingDelegate, which a
protocol which can specified for a WKWebView and used to install mock objects and simulate the state of the
platform. By default, this delegate is nil, which results in normal behavior. For data interaction, we are able
to specify a mock data interaction gesture recognizer for use by the WKContentView to simulate firing a long
press and subsequent movement. This gesture recognizer is used in place of the regular data interaction gesture
recognizer, and allows for TestWebKitAPI to drive interaction without actually sending events through the
UIApplication. The _WKTestingDelegate also contains optional method hooks which are invoked at key points in
time when performing a data interaction gesture.

Since all methods of the testing delegate are optional, the testing delegate can be easily extended to support
testing for other features -- the idea is that leaving all but the relevant methods in the protocol
unimplemented will result in default behavior for everything other than those methods, so a client need only
implement and add WebKit2 hooks for a few methods to support testing for a new feature.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _testingDelegate]):
(-[WKWebView _setTestingDelegate:]):

Specify the testing delegate to use for this WKWebView (see above for more details).

(-[WKWebView _simulateDataInteractionGestureRecognized]):
(-[WKWebView _simulateDataInteractionEntered:]):
(-[WKWebView _simulateDataInteractionUpdated:]):
(-[WKWebView _simulateDataInteractionPerformOperation:]):
(-[WKWebView _simulateDataInteractionEnded:]):
(-[WKWebView _simulateDataInteractionSessionDidEnd:withOperation:]):
(-[WKWebView _simulateFailedDataInteractionWithIndex:]):
(-[WKWebView _simulateWillBeginDataInteractionWithIndex:withSession:]):
(-[WKWebView _simulatedItemsForDataInteractionWithIndex:]):

Used by TestWebKitAPI to drive data interaction tests. See DataInteractionTests.mm.

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/API/Cocoa/_WKTestingDelegate.h: Added.
  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):
(-[WKContentView _dataInteractionGestureRecognizer]):

  • WebKit2.xcodeproj/project.pbxproj:

Tools:

Uses the testing delegate introduced in WebKit2 to override the gesture recognizer used to initiate data
interaction. Instead of being driven by UIKit, the DataInteractionSimulator drives this overridden gesture
recognizer by making the WKContentView call its dataInteractionGestureRecognized method. To simulate an actual
gesture being performed, we fire the gesture recognizer (or call the data interaction delegate methods, if the
gesture has already been recognized) at regular intervals over the course of the test.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
  • TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
  • TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.

New test pages for data interaction.

  • TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Added.

(TestWebKitAPI::runTestsExpectingToObserveEvents):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/cocoa/TestWKWebView.mm:

(-[TestWKWebView stringByEvaluatingJavaScript:]):

  • TestWebKitAPI/ios/DataInteractionSimulator.h: Added.
  • TestWebKitAPI/ios/DataInteractionSimulator.mm: Added.

(-[MockLongPressGestureRecognizer initWithWindow:]):
(-[MockLongPressGestureRecognizer locationInView:]):
(-[MockLongPressGestureRecognizer state]):
(-[MockLongPressGestureRecognizer numberOfTouches]):
(-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]):
(-[DataInteractionSimulator dealloc]):
(-[DataInteractionSimulator run]):

Performs a data interaction gesture from the start location to the end location with linear interpolation. For
now, the timestep and progress per tick are 30ms and 3.33%, respectively, which means that tests should complete
in a little under 1 second, though this can be easily changed to be configurable in the future if needed.

(-[DataInteractionSimulator _advanceProgress]):

Fired periodically to drive the data interaction gesture. Schedules a call of itself until the test is
completed, and calls _finishDataInteraction when progress is at 1.

(-[DataInteractionSimulator _finishDataInteraction]):
(-[DataInteractionSimulator _currentLocation]):
(-[DataInteractionSimulator _scheduleAdvanceProgress]):
(-[DataInteractionSimulator _recognizeGestureAtLocation:withState:]):
(-[DataInteractionSimulator dataInteractionGestureRecognizer]):
(-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
(-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):

3:07 PM Changeset in webkit [212253] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix iOS build.

  • platform/ios/DragImageIOS.mm:

(WebCore::deleteDragImage):

3:06 PM Changeset in webkit [212252] by commit-queue@webkit.org
  • 7 edits
    2 moves in trunk/Source/WebCore

Rename MediaQueryExp.h/cpp to MediaQueryExpression.h/cpp
​https://bugs.webkit.org/show_bug.cgi?id=168249

Patch by Sam Weinig <​sam@webkit.org> on 2017-02-13
Reviewed by Dean Jackson.

Fix a FIXME and rename MediaQueryExp.h/cpp to match the class it contains, MediaQueryExpression.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSAllInOne.cpp:
  • css/MediaQuery.h:
  • css/MediaQueryEvaluator.h:
  • css/MediaQueryExp.cpp: Removed.
  • css/MediaQueryExp.h: Removed.
  • css/MediaQueryExpression.cpp: Copied from Source/WebCore/css/MediaQueryExp.cpp.
  • css/MediaQueryExpression.h: Copied from Source/WebCore/css/MediaQueryExp.h.
  • css/parser/MediaQueryParser.h:
2:55 PM Changeset in webkit [212251] by aakash_jain@apple.com
  • 2 edits in trunk/Source/WebCore

WAKResponder should be exported from WebCore
​https://bugs.webkit.org/show_bug.cgi?id=168245

Reviewed by Dan Bernstein.

  • platform/ios/wak/WAKResponder.h:
2:53 PM Changeset in webkit [212250] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Log to the History Channel in a few more places
​https://bugs.webkit.org/show_bug.cgi?id=168252

Reviewed by Brady Eidson.

* Aliens *

  • loader/HistoryController.cpp:

(WebCore::HistoryController::restoreScrollPositionAndViewState):
(WebCore::HistoryController::updateForReload):

  • loader/NavigationScheduler.cpp:

(WebCore::NavigationScheduler::scheduleHistoryNavigation):
(WebCore::NavigationScheduler::timerFired):
(WebCore::NavigationScheduler::cancel):

  • page/History.cpp:

(WebCore::History::go):

2:52 PM Changeset in webkit [212249] by achristensen@apple.com
  • 9 edits in trunk

Percent should be allowed in non-special URL hosts
​https://bugs.webkit.org/show_bug.cgi?id=168255

Reviewed by Tim Horton.

LayoutTests/imported/w3c:

  • web-platform-tests/url/a-element-expected.txt:
  • web-platform-tests/url/a-element-xhtml-expected.txt:
  • web-platform-tests/url/url-constructor-expected.txt:

Source/WebCore:

In the last few weeks, the spec has consolidated its sets of code points.
Now forbidden host code points replace the old invalid host code points with
the modification that percents are allowed in non-special hosts because we
percent-encode non-ascii code points in non-special hosts.
See ​https://url.spec.whatwg.org/#concept-opaque-host-parser

Covered by newly passing web platform tests.

  • platform/URLParser.cpp:

(WebCore::isC0Control):
(WebCore::isInUserInfoEncodeSet):
(WebCore::URLParser::hasForbiddenHostCodePoint):
(WebCore::URLParser::parseHostAndPort):
(WebCore::isInvalidDomainCharacter): Deleted.
(WebCore::URLParser::hasInvalidDomainCharacter): Deleted.

  • platform/URLParser.h:

Tools:

  • TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::TEST_F):

1:55 PM Changeset in webkit [212248] by Alan Bujtas
  • 1 edit
    1 add in trunk/PerformanceTests

Simple line layout: Add performance test with text-rendering: optimizeSpeed
​https://bugs.webkit.org/show_bug.cgi?id=168248

Reviewed by Simon Fraser.

  • Layout/simple-line-layout-with-varying-content-and-optimized-speed.html: Added.
1:39 PM Changeset in webkit [212247] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebKit2

[MediaStream Mac] Video capture needs access to /Library/CoreMediaIO/Plug-Ins/DAL/
​https://bugs.webkit.org/show_bug.cgi?id=168244
<rdar://problem/30461158>

Reviewed by Brady Eidson.

  • WebProcess/com.apple.WebProcess.sb.in: Grant read-access to the video capture

plug-in directory when enabling video capture.

1:37 PM Changeset in webkit [212246] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark tiled-drawing/scrolling/latched-to-deleted-node.html as flaky on mac-wk2.
​https://bugs.webkit.org/show_bug.cgi?id=168085

Unreviewed testg gardening.

  • platform/mac-wk2/TestExpectations:
1:37 PM Changeset in webkit [212245] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/dom/events/EventListener-invoke-legacy.html as flaky on debug.
​https://bugs.webkit.org/show_bug.cgi?id=168238

Unreviewed test gardening.

1:30 PM Changeset in webkit [212244] by Antti Koivisto
  • 8 edits in trunk/Source/WebKit2

Disable mmap'd cache files if container is class A
​https://bugs.webkit.org/show_bug.cgi?id=168241
<rdar://problem/23676252>

Reviewed by JF Bastien and Chris Dumez.

If the mmap'd cache file gets evicted and the device is locked,
then WebContent won't be able to bring the file back in under
class A, causing SIGBUS.

In those circumstances, don't use mmap'd files.

  • NetworkProcess/cache/NetworkCache.h:

(WebKit::NetworkCache::Cache::canUseSharedMemoryForBodyData):

  • NetworkProcess/cache/NetworkCacheEntry.cpp:

(WebKit::NetworkCache::Entry::initializeShareableResourceHandleFromStorageRecord):

Don't initialize the shareable resource handle for the map if forbidden.

  • NetworkProcess/cache/NetworkCacheFileSystem.cpp:

(WebKit::NetworkCache::canUseSharedMemoryForPath):

Query the system for the protection status of the cache path.

  • NetworkProcess/cache/NetworkCacheFileSystem.h:
  • NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::Storage):

  • NetworkProcess/cache/NetworkCacheStorage.h:

(WebKit::NetworkCache::Storage::canUseSharedMemoryForBodyData):

1:11 PM Changeset in webkit [212243] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix Windows build.

  • platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::setDragImage):

1:05 PM Changeset in webkit [212242] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

TestExpectations gardening for imported/w3c/web-platform-tests/html/semantics/embedded-content/the-area-element/area-download-click.html.

Unreviewed test gardening.

  • platform/ios-simulator/TestExpectations:
  • platform/mac-wk1/TestExpectations:
12:57 PM Changeset in webkit [212241] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Fix Yosemite build after r211765
​https://bugs.webkit.org/show_bug.cgi?id=168246
<rdar://problem/30494174>

Reviewed by Brady Eidson.

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

(SOFT_LINK):

12:35 PM Changeset in webkit [212240] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-603.1.27

Tag Safari-603.1.27.

12:31 PM Changeset in webkit [212239] by andersca@apple.com
  • 11 edits in trunk/Source/WebCore

Add a DragImage class that wraps a DragImageRef
​https://bugs.webkit.org/show_bug.cgi?id=168131

Reviewed by Beth Dakin.

This allows us to get rid of the explicit deleteDragImage calls and will make additional cleanup of the
various drag code paths possible. No functionality change.

  • dom/DataTransfer.cpp:

(WebCore::DataTransfer::updateDragImage):

  • page/DragController.cpp:

(WebCore::DragController::startDrag):
(WebCore::DragController::doImageDrag):
(WebCore::DragController::doSystemDrag):

  • page/DragController.h:
  • platform/DragImage.cpp:

(WebCore::DragImage::DragImage):
(WebCore::DragImage::operator=):
(WebCore::DragImage::~DragImage):

  • platform/DragImage.h:
  • platform/Pasteboard.h:
  • platform/StaticPasteboard.h:
  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::setDragImage):

12:19 PM Changeset in webkit [212238] by Chris Dumez
  • 2 edits in trunk/Source/WebCore
Regression(r211455): ASSERTION FAILED: frameView
pageCacheState() == InPageCache in com.apple.WebCore: WebCore::Document::destroyRenderTree

​https://bugs.webkit.org/show_bug.cgi?id=168237
<rdar://problem/30494165>

Reviewed by Gavin Barraclough.

Drop bad assertion under document::destroyRenderTree() that was introduced in r211455.
The assertion seemed like a good idea but the issue is that CachedFrame::destroy()
reset's the document's pageCacheState before calling Document::prepareForDestruction().

No new tests, this fixes assertion hits on our bots.

  • dom/Document.cpp:

(WebCore::Document::destroyRenderTree):

11:58 AM Changeset in webkit [212237] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Nwtr unexpectedly passes mismatch ref test if the hashes doesn't match but no diff
​https://bugs.webkit.org/show_bug.cgi?id=168221

Patch by Fujii Hironori <Fujii Hironori> on 2017-02-13
Reviewed by Ryosuke Niwa.

There is a logic error in comparing mismatch ref test images. In
mismatch ref tests, it should be failed if two images has no diff.
But, if the hashes are different, nwtr unexpectedly pass the
mismatch ref test.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner._compare_output_with_reference): Fail the
mismatch ref test if hashes of two images are equal. Invoke
ImageDiff if the hashes don't match.

11:14 AM Changeset in webkit [212236] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

REGRESSION(r188138): Web Inspector: cannot edit next/previous DOM attribute by using tab/shift-tab
​https://bugs.webkit.org/show_bug.cgi?id=168120
<rdar://problem/30466065>

Reviewed by Joseph Pecoraro.

DOMTreeElement's attribute editing committed handler shouldn't early return
when a moveDirection has been specified.

  • UserInterface/Views/DOMTreeElement.js:
11:07 AM Changeset in webkit [212235] by mmaxfield@apple.com
  • 14 edits
    1 copy
    2 adds
    1 delete in trunk

Update custom line breaking iterators to the latest version of Unicode
​https://bugs.webkit.org/show_bug.cgi?id=168182

Reviewed by Zalan Bujtas.

Source/WebCore:

Clean up our breaking code to be more descriptive about the difference between
line-break: auto vs line-break: loose | normal | strict. The only difference is
that we have some hardcoded tables to speed up character iteration for
line-break: auto.

Tests: TestWebKitAPI WebKit2.LineBreaking

  • rendering/BreakLines.h:

(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):
(WebCore::nextBreakablePositionWithoutShortcut):
(WebCore::nextBreakablePositionIgnoringNBSPWithoutShortcut):
(WebCore::isBreakable):
(WebCore::nextBreakablePositionNonLoosely): Deleted.
(WebCore::nextBreakablePositionLoosely): Deleted.
(WebCore::nextBreakablePositionLoose): Deleted.
(WebCore::nextBreakablePositionIgnoringNBSPLoose): Deleted.

  • rendering/RenderText.cpp:

(WebCore::RenderText::computePreferredLogicalWidths):

  • rendering/SimpleLineLayoutTextFragmentIterator.cpp:

(WebCore::SimpleLineLayout::nextBreakablePositionInSegment):

  • rendering/line/BreakingContext.h:

(WebCore::BreakingContext::handleText):
(WebCore::BreakingContext::optimalLineBreakLocationForTrailingWord):

Source/WTF:

ICU 55.1 supports loose / normal / strict line breaking rules. The oldest platform we ship
on has a version of ICU >= that one. Therefore, we don't need to compile our own rules;
we can just use ICU's rules.

  • wtf/text/LineBreakIteratorPoolICU.h:

(WTF::LineBreakIteratorPool::makeLocaleWithBreakKeyword):
(WTF::LineBreakIteratorPool::take):

  • wtf/text/TextBreakIterator.cpp:

(WTF::acquireLineBreakIterator):
(WTF::openLineBreakIterator):
(WTF::mapLineIteratorModeToRules): Deleted.
(WTF::isCJKLocale): Deleted.

  • wtf/text/TextBreakIterator.h:

(WTF::LazyLineBreakIterator::LazyLineBreakIterator):
(WTF::LazyLineBreakIterator::mode):
(WTF::LazyLineBreakIterator::get):
(WTF::LazyLineBreakIterator::resetStringAndReleaseIterator):
(WTF::LazyLineBreakIterator::isLooseCJKMode): Deleted.

Tools:

Treat the system's ICU as the source of truth to compare breaking positions against.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebCore/LineBreaking.mm: Added.

(generateJavaScriptForTest):
(breakingLocationsFromICU):
(testAFewStrings):
(TEST):

  • TestWebKitAPI/Tests/WebKit2Cocoa/AllAhem.svg: Renamed from LayoutTests/css3/line-break/resources/AllAhem.svg.
  • TestWebKitAPI/Tests/WebKit2Cocoa/LineBreaking.html: Added.

LayoutTests:

Migrated to TestWebKitAPI.

  • css3/line-break/line-break-auto-centered-2-expected.html: Removed.
  • css3/line-break/line-break-auto-centered-2.html: Removed.
  • css3/line-break/line-break-auto-centered-expected.html: Removed.
  • css3/line-break/line-break-auto-centered.html: Removed.
  • css3/line-break/line-break-auto-half-kana-2-expected.html: Removed.
  • css3/line-break/line-break-auto-half-kana-2.html: Removed.
  • css3/line-break/line-break-auto-half-kana-3-expected.html: Removed.
  • css3/line-break/line-break-auto-half-kana-3.html: Removed.
  • css3/line-break/line-break-auto-half-kana-4-expected.html: Removed.
  • css3/line-break/line-break-auto-half-kana-4.html: Removed.
  • css3/line-break/line-break-auto-half-kana-5-expected.html: Removed.
  • css3/line-break/line-break-auto-half-kana-5.html: Removed.
  • css3/line-break/line-break-auto-half-kana-expected.html: Removed.
  • css3/line-break/line-break-auto-half-kana.html: Removed.
  • css3/line-break/line-break-auto-hyphens-expected.html: Removed.
  • css3/line-break/line-break-auto-hyphens.html: Removed.
  • css3/line-break/line-break-auto-inseparables-expected.html: Removed.
  • css3/line-break/line-break-auto-inseparables.html: Removed.
  • css3/line-break/line-break-auto-iteration-marks-expected.html: Removed.
  • css3/line-break/line-break-auto-iteration-marks.html: Removed.
  • css3/line-break/line-break-auto-postfixes-expected.html: Removed.
  • css3/line-break/line-break-auto-postfixes.html: Removed.
  • css3/line-break/line-break-auto-prefixes-expected.html: Removed.
  • css3/line-break/line-break-auto-prefixes.html: Removed.
  • css3/line-break/line-break-auto-sound-marks-expected.html: Removed.
  • css3/line-break/line-break-auto-sound-marks.html: Removed.
  • css3/line-break/line-break-loose-centered-2-expected.html: Removed.
  • css3/line-break/line-break-loose-centered-2.html: Removed.
  • css3/line-break/line-break-loose-centered-expected.html: Removed.
  • css3/line-break/line-break-loose-centered.html: Removed.
  • css3/line-break/line-break-loose-half-kana-2-expected.html: Removed.
  • css3/line-break/line-break-loose-half-kana-2.html: Removed.
  • css3/line-break/line-break-loose-half-kana-3-expected.html: Removed.
  • css3/line-break/line-break-loose-half-kana-3.html: Removed.
  • css3/line-break/line-break-loose-half-kana-4-expected.html: Removed.
  • css3/line-break/line-break-loose-half-kana-4.html: Removed.
  • css3/line-break/line-break-loose-half-kana-5-expected.html: Removed.
  • css3/line-break/line-break-loose-half-kana-5.html: Removed.
  • css3/line-break/line-break-loose-half-kana-expected.html: Removed.
  • css3/line-break/line-break-loose-half-kana.html: Removed.
  • css3/line-break/line-break-loose-hyphens-expected.html: Removed.
  • css3/line-break/line-break-loose-hyphens.html: Removed.
  • css3/line-break/line-break-loose-inseparables-expected.html: Removed.
  • css3/line-break/line-break-loose-inseparables.html: Removed.
  • css3/line-break/line-break-loose-iteration-marks-expected.html: Removed.
  • css3/line-break/line-break-loose-iteration-marks.html: Removed.
  • css3/line-break/line-break-loose-postfixes-expected.html: Removed.
  • css3/line-break/line-break-loose-postfixes.html: Removed.
  • css3/line-break/line-break-loose-prefixes-expected.html: Removed.
  • css3/line-break/line-break-loose-prefixes.html: Removed.
  • css3/line-break/line-break-loose-sound-marks-expected.html: Removed.
  • css3/line-break/line-break-loose-sound-marks.html: Removed.
  • css3/line-break/line-break-normal-centered-2-expected.html: Removed.
  • css3/line-break/line-break-normal-centered-2.html: Removed.
  • css3/line-break/line-break-normal-centered-expected.html: Removed.
  • css3/line-break/line-break-normal-centered.html: Removed.
  • css3/line-break/line-break-normal-half-kana-2-expected.html: Removed.
  • css3/line-break/line-break-normal-half-kana-2.html: Removed.
  • css3/line-break/line-break-normal-half-kana-3-expected.html: Removed.
  • css3/line-break/line-break-normal-half-kana-3.html: Removed.
  • css3/line-break/line-break-normal-half-kana-4-expected.html: Removed.
  • css3/line-break/line-break-normal-half-kana-4.html: Removed.
  • css3/line-break/line-break-normal-half-kana-5-expected.html: Removed.
  • css3/line-break/line-break-normal-half-kana-5.html: Removed.
  • css3/line-break/line-break-normal-half-kana-expected.html: Removed.
  • css3/line-break/line-break-normal-half-kana.html: Removed.
  • css3/line-break/line-break-normal-hyphens-expected.html: Removed.
  • css3/line-break/line-break-normal-hyphens.html: Removed.
  • css3/line-break/line-break-normal-inseparables-expected.html: Removed.
  • css3/line-break/line-break-normal-inseparables.html: Removed.
  • css3/line-break/line-break-normal-iteration-marks-expected.html: Removed.
  • css3/line-break/line-break-normal-iteration-marks.html: Removed.
  • css3/line-break/line-break-normal-postfixes-expected.html: Removed.
  • css3/line-break/line-break-normal-postfixes.html: Removed.
  • css3/line-break/line-break-normal-prefixes-expected.html: Removed.
  • css3/line-break/line-break-normal-prefixes.html: Removed.
  • css3/line-break/line-break-normal-sound-marks-expected.html: Removed.
  • css3/line-break/line-break-normal-sound-marks.html: Removed.
  • css3/line-break/line-break-strict-centered-2-expected.html: Removed.
  • css3/line-break/line-break-strict-centered-2.html: Removed.
  • css3/line-break/line-break-strict-centered-expected.html: Removed.
  • css3/line-break/line-break-strict-centered.html: Removed.
  • css3/line-break/line-break-strict-half-kana-2-expected.html: Removed.
  • css3/line-break/line-break-strict-half-kana-2.html: Removed.
  • css3/line-break/line-break-strict-half-kana-3-expected.html: Removed.
  • css3/line-break/line-break-strict-half-kana-3.html: Removed.
  • css3/line-break/line-break-strict-half-kana-4-expected.html: Removed.
  • css3/line-break/line-break-strict-half-kana-4.html: Removed.
  • css3/line-break/line-break-strict-half-kana-5-expected.html: Removed.
  • css3/line-break/line-break-strict-half-kana-5.html: Removed.
  • css3/line-break/line-break-strict-half-kana-expected.html: Removed.
  • css3/line-break/line-break-strict-half-kana.html: Removed.
  • css3/line-break/line-break-strict-hyphens-expected.html: Removed.
  • css3/line-break/line-break-strict-hyphens.html: Removed.
  • css3/line-break/line-break-strict-inseparables-expected.html: Removed.
  • css3/line-break/line-break-strict-inseparables.html: Removed.
  • css3/line-break/line-break-strict-iteration-marks-expected.html: Removed.
  • css3/line-break/line-break-strict-iteration-marks.html: Removed.
  • css3/line-break/line-break-strict-postfixes-expected.html: Removed.
  • css3/line-break/line-break-strict-postfixes.html: Removed.
  • css3/line-break/line-break-strict-prefixes-expected.html: Removed.
  • css3/line-break/line-break-strict-prefixes.html: Removed.
  • css3/line-break/line-break-strict-sound-marks-expected.html: Removed.
  • css3/line-break/line-break-strict-sound-marks.html: Removed.
  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator/TestExpectations:
10:58 AM Changeset in webkit [212234] by Ryan Haddad
  • 4 edits in trunk/LayoutTests

TestExpectations gardening for imported/w3c/web-platform-tests/html/semantics/text-level-semantics/the-a-element/a-download-click.html.

Unreviewed test gardening.

  • platform/ios-simulator/TestExpectations:
  • platform/mac-wk1/TestExpectations:
  • platform/mac-wk2/TestExpectations:
10:45 AM Changeset in webkit [212233] by matthew_hanson@apple.com
  • 5 edits in branches/safari-603-branch/Source

Versioning.

10:37 AM Changeset in webkit [212232] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WebRTC] libwebrtc socket factory is not assigning the right socket type
​https://bugs.webkit.org/show_bug.cgi?id=168233

Patch by Youenn Fablet <​youennf@gmail.com> on 2017-02-13
Reviewed by Brent Fulgham.

  • WebProcess/Network/webrtc/LibWebRTCSocketFactory.cpp:

(WebKit::LibWebRTCSocketFactory::CreateUdpSocket):
(WebKit::LibWebRTCSocketFactory::CreateClientTcpSocket):

10:32 AM Changeset in webkit [212231] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove @getUserMedia identifier
​https://bugs.webkit.org/show_bug.cgi?id=168216

Patch by Youenn Fablet <​youenn@apple.com> on 2017-02-13
Reviewed by Sam Weinig.

No change of behavior.

  • Modules/mediastream/MediaDevices.idl:
  • bindings/js/WebCoreBuiltinNames.h:
9:28 AM Changeset in webkit [212230] by Michael Catanzaro
  • 2 edits in trunk/Source/WebKit2

[GTK] Unreviewed, add missing precondition check

  • WebProcess/InjectedBundle/API/gtk/WebKitWebEditor.cpp:

(webkit_web_editor_get_page):

9:26 AM Changeset in webkit [212229] by Michael Catanzaro
  • 2 edits in trunk/Source/WebKit2

Unreviewed, fix another docs typo.

  • UIProcess/API/gtk/WebKitEditingCommands.h:
9:12 AM UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
9:07 AM UpdatingBugzilla edited by ddkilzer@apple.com
(diff)
5:42 AM Changeset in webkit [212228] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

[GTK] Non-accelerated drawing is broken with HiDPI
​https://bugs.webkit.org/show_bug.cgi?id=168128

Reviewed by Michael Catanzaro.

When device scale factor changes, the page notifies the page overlay controller about it. Then overlay root
layers are created to be notified about the device scale factor. That causes us to enter in accelerated
compositing mode, because the graphics layer factory is called. But the render layer compositor doesn't really
enter in accelerated mode, because there aren't page overlays, the accelerated mode is not forced and the website
doesn't require acceleration either. This leaves our drawing area in an inconsistent state, it thinks it's in AC
mode because it has a layer tree host, but without a root layer attached, so nothing is rendered. The page
overlay controller doesn't need to create the layers when device scale factor changes, when an overlay is
installed, layers will be created with the current device scale factor anyway.

  • page/PageOverlayController.cpp:

(WebCore::PageOverlayController::didChangeDeviceScaleFactor): Return early if not initialized yet.

1:53 AM Changeset in webkit [212227] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

REGRESSION(r210845) Build broken with ENABLE_MHTML disabled
​https://bugs.webkit.org/show_bug.cgi?id=167771

Reviewed by Daniel Bates.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::commitData):

Note: See TracTimeline for information about the timeline view.