Timeline

Feb 24, 2017:

11:53 PM Changeset in webkit [212996] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: add support for Error page
​https://bugs.webkit.org/show_bug.cgi?id=168855

Patch by Devin Rousso <Devin Rousso> on 2017-02-24
Reviewed by Brian Burg.

• UserInterface/Debug/UncaughtExceptionReporter.css:

(.uncaught-exception-sheet):
(body[dir=ltr] .uncaught-exception-sheet):
(body[dir=rtl] .uncaught-exception-sheet):
(.uncaught-exception-sheet h1 > img):
(body[dir=ltr] .uncaught-exception-sheet h1 > img):
(body[dir=rtl] .uncaught-exception-sheet h1 > img):
(.uncaught-exception-sheet h2 > img):
(body[dir=ltr] .uncaught-exception-sheet h2 > img):
(body[dir=rtl] .uncaught-exception-sheet h2 > img):
(.uncaught-exception-sheet dd):
(body[dir=ltr] .uncaught-exception-sheet dd):
(body[dir=rtl] .uncaught-exception-sheet dd):
(.uncaught-exception-sheet ul):
(body[dir=ltr] .uncaught-exception-sheet ul):
(body[dir=rtl] .uncaught-exception-sheet ul):

11:50 PM Changeset in webkit [212995] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught Exception: Unknown angle units "undefined"
​https://bugs.webkit.org/show_bug.cgi?id=168851

Patch by Devin Rousso <Devin Rousso> on 2017-02-24
Reviewed by Brian Burg.

• UserInterface/Views/GradientEditor.js:

(WebInspector.GradientEditor.prototype._gradientTypeChanged):

11:50 PM Changeset in webkit [212994] by Joseph Pecoraro

• 9 edits in trunk

[Resource Timing] Media elements initiated loads should set the initiatorType to their element name (video/audio)
​https://bugs.webkit.org/show_bug.cgi?id=168680

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

• web-platform-tests/resource-timing/rt-initiatorType-media-expected.txt:

Progression on the initiatorType.

Source/WebCore:

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerCreateResourceLoader):
Pass in the element so it may be used as the initiator.

• html/HTMLVideoElement.h:

Export create() for TestWebKitAPI to use.

• loader/MediaResourceLoader.cpp:

(WebCore::MediaResourceLoader::MediaResourceLoader):
(WebCore::MediaResourceLoader::contextDestroyed):
(WebCore::MediaResourceLoader::requestResource):

• loader/MediaResourceLoader.h:

Include the HTMLMediaElement as the initiator.

Tools:

• TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:

(TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
Include a dummy HTMLVideoElement.

9:48 PM Changeset in webkit [212993] by Joseph Pecoraro

• 97 edits
  2 moves
  13 adds in trunk

[Resource Timing] Gather timing information with reliable responseEnd time
​https://bugs.webkit.org/show_bug.cgi?id=168351

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/fetch/api/redirect/redirect-count-cross-origin-expected.txt:
• web-platform-tests/fetch/api/redirect/redirect-count-cross-origin-worker-expected.txt:
• web-platform-tests/fetch/api/redirect/redirect-count-expected.txt:
• web-platform-tests/fetch/api/redirect/redirect-count-worker-expected.txt:
• web-platform-tests/fetch/api/redirect/redirect-location-expected.txt:
• web-platform-tests/fetch/api/redirect/redirect-location-worker-expected.txt:

New behavior for too many redirects caused by <rdar://problem/30610988>.

• web-platform-tests/resource-timing/rt-nextHopProtocol-expected.txt: Added.
• web-platform-tests/resource-timing/rt-nextHopProtocol.html: Added.
• web-platform-tests/resource-timing/rt-nextHopProtocol.js: Added.
• web-platform-tests/resource-timing/rt-nextHopProtocol.worker-expected.txt: Added.
• web-platform-tests/resource-timing/rt-nextHopProtocol.worker.html: Added.
• web-platform-tests/resource-timing/rt-nextHopProtocol.worker.js: Added.

New tests specific to just checking the nextHopProtocol property with
a non-cached resource to avoid flakeyness.

Source/WebCore:

This patch replaces the unused double finishTime in ResourceLoader's
didFinishLoad with a complete WebCore::NetworkLoadMetrics object. This
allows the NetworkProcess to give complete timing information, and more
final metrics about the load, to WebCore. Currently this is only used
by ResourceTiming, but it will soon be used by Web Inspector as well.
We may also end up extending this to the didFail path as well, since it
is possible that we have some metrics for load failures.

At the same time we want to start moving away from the legacy path that
populated a subset of this information in ResourceResponse's NetworkLoadMetrics.
It doesn't make sense to store this information on the ResourceResponse
for a few reasons: We don't want to store the metrics in our Network Cache and
not all of the load timing metrics have been populated yet (responseEnd).
In an effort to move off of this data we've renamed the accessor to
"deprecatedNetworkLoadMetrics". There are a few remaining clients
(ResourceHandle, PerformanceTiming, InspectorNetworkAgent) which can be
migrated separately from this patch.

Having both the legacy and new code paths adds a little bit of complexity.
One advantage of the new path is that the complete load timing data
(fetchStart -> dns -> connect -> request -> response -> responseEnd) can
be packaged together. The legacy path could not include a responseEnd, so
WebCore faked that value with its own timestamp. Having the fake responseEnd
caused issues as timestamps / clocks are different between processes. In order
for PerformanceResponseTiming to know whether or not the NetworkLoadMetrics
has the complete network timing metrics it checks isComplete(). If true
it knows it can use the responseEnd time from NetworkLoadMetrics, otherwise
it must fallback to the legacy value from LoadTiming. Once all of the
deprecatedNetworkLoadMetrics clients go away, we should always have the
complete data and this can be eliminated.

Tests: imported/w3c/web-platform-tests/resource-timing/rt-nextHopProtocol.html

imported/w3c/web-platform-tests/resource-timing/rt-nextHopProtocol.worker.html

• PlatformMac.cmake:
• WebCore.xcodeproj/project.pbxproj:

Rename NetworkLoadTiming -> NetworkLoadMetrics.

• page/PerformanceResourceTiming.cpp:

(WebCore::entryStartTime):
(WebCore::entryEndTime):
(WebCore::PerformanceResourceTiming::PerformanceResourceTiming):
(WebCore::PerformanceResourceTiming::nextHopProtocol):
(WebCore::PerformanceResourceTiming::domainLookupStart):
(WebCore::PerformanceResourceTiming::domainLookupEnd):
(WebCore::PerformanceResourceTiming::connectStart):
(WebCore::PerformanceResourceTiming::connectEnd):
(WebCore::PerformanceResourceTiming::secureConnectionStart):
(WebCore::PerformanceResourceTiming::requestStart):
(WebCore::PerformanceResourceTiming::responseStart):
(WebCore::PerformanceResourceTiming::responseEnd):
(WebCore::PerformanceResourceTiming::networkLoadTimeToDOMHighResTimeStamp):

• page/PerformanceResourceTiming.h:

Mostly just updating names and types. This does however need to get the
correct endTime based on whether the NetworkLoadMetrics are complete
(meaning includes responseEnd) or not (legacy, use LoadTiming value).

• page/PerformanceResourceTiming.idl:

Add nextHopProtocol.

• page/PerformanceTiming.cpp:

(WebCore::PerformanceTiming::domainLookupStart):
(WebCore::PerformanceTiming::domainLookupEnd):
(WebCore::PerformanceTiming::connectStart):
(WebCore::PerformanceTiming::connectEnd):
(WebCore::PerformanceTiming::secureConnectionStart):
(WebCore::PerformanceTiming::requestStart):
(WebCore::PerformanceTiming::responseStart):
(WebCore::PerformanceTiming::resourceLoadTimeRelativeToFetchStart):

• page/PerformanceTiming.h:

Navigation Timing values still uses the NetworkLoadTiming values stored on
the DocumentLoader. This should be moved off of the deprecated path separately.

• platform/network/NetworkLoadMetrics.h: Renamed from Source/WebCore/platform/network/NetworkLoadTiming.h.

(WebCore::NetworkLoadMetrics::NetworkLoadMetrics):
(WebCore::NetworkLoadMetrics::isolatedCopy):
(WebCore::NetworkLoadMetrics::reset):
(WebCore::NetworkLoadMetrics::operator==):
(WebCore::NetworkLoadMetrics::operator!=):
(WebCore::NetworkLoadMetrics::isComplete):
(WebCore::NetworkLoadMetrics::markComplete):
(WebCore::NetworkLoadMetrics::encode):
(WebCore::NetworkLoadMetrics::decode):
Re-introduce a reset() method (for NetworkLoadSoup to reset between redirects).
Add protocolName and "complete" boolean.

• platform/network/cocoa/NetworkLoadMetrics.mm: Renamed from Source/WebCore/platform/network/cocoa/NetworkLoadTiming.mm.

(WebCore::timingValue):
(WebCore::copyTimingData):
(WebCore::setCollectsTimingData):
Use this opportunity to convert NetworkLoadTiming timestamps to WTF::Seconds.
Since we already have to modify all the clients this moves us to use the more
strongly typed units that are less ambiguous then "double". The rest of the
Performance API has already moved to these units.

• inspector/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::buildObjectForTiming):
(WebCore::InspectorNetworkAgent::buildObjectForResourceResponse):
(WebCore::InspectorNetworkAgent::didFinishLoading):

• inspector/InspectorNetworkAgent.h:

Inspector was the only client of the finishTime, and since the value was
erratically coming from clients in different ways it was almost certainly
inaccurate. Simplify this in preparation for using NetworkLoadMetrics.

• Modules/fetch/FetchLoader.cpp:

(WebCore::FetchLoader::didFinishLoading):

• Modules/fetch/FetchLoader.h:
• fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::didFinishLoading):

• fileapi/FileReaderLoader.h:
• html/MediaFragmentURIParser.cpp:

(WebCore::MediaFragmentURIParser::parseNPTTime):

• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didFinishLoadingImpl):

• inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didFinishLoading):

• loader/CrossOriginPreflightChecker.cpp:

(WebCore::CrossOriginPreflightChecker::validatePreflightResponse):

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::notifyFinished):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::continueAfterContentPolicy):
(WebCore::DocumentLoader::maybeLoadEmpty):

• loader/DocumentLoader.h:
• loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::didReceiveResponse):
(WebCore::DocumentThreadableLoader::notifyFinished):
(WebCore::DocumentThreadableLoader::didFinishLoading):
(WebCore::DocumentThreadableLoader::loadRequest):

• loader/DocumentThreadableLoader.h:
• loader/NetscapePlugInStreamLoader.cpp:

(WebCore::NetscapePlugInStreamLoader::didFinishLoading):

• loader/NetscapePlugInStreamLoader.h:
• loader/ResourceLoadNotifier.cpp:

(WebCore::ResourceLoadNotifier::didFinishLoad):
(WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
(WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):

• loader/ResourceLoadNotifier.h:
• loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::deliverResponseAndData):
(WebCore::ResourceLoader::loadDataURL):
(WebCore::ResourceLoader::didFinishLoading):
(WebCore::ResourceLoader::didFinishLoadingOnePart):

• loader/ResourceLoader.h:
• loader/ResourceTiming.cpp:

(WebCore::ResourceTiming::fromLoad):
(WebCore::ResourceTiming::fromSynchronousLoad):
(WebCore::ResourceTiming::ResourceTiming):
(WebCore::ResourceTiming::isolatedCopy):

• loader/ResourceTiming.h:

(WebCore::ResourceTiming::networkLoadMetrics):
(WebCore::ResourceTiming::ResourceTiming):
(WebCore::ResourceTiming::networkLoadTiming): Deleted.

• loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::SubresourceLoader):
(WebCore::SubresourceLoader::willSendRequestInternal):
(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::didFinishLoading):
(WebCore::SubresourceLoader::reportResourceTiming):

• loader/SubresourceLoader.h:
• loader/ThreadableLoaderClient.h:

(WebCore::ThreadableLoaderClient::didFinishLoading):

• loader/ThreadableLoaderClientWrapper.h:

(WebCore::ThreadableLoaderClientWrapper::didFinishLoading):

• loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):

• loader/WorkerThreadableLoader.h:
• loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didFinishLoading):

• loader/appcache/ApplicationCacheGroup.h:
• loader/cache/CachedResource.h:

(WebCore::CachedResource::setLoadFinishTime):

• loader/ios/QuickLook.mm:

(-[WebPreviewLoader connectionDidFinishLoading:]):

• page/EventSource.cpp:

(WebCore::EventSource::didFinishLoading):

• page/EventSource.h:
• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(ResourceHandleStreamingClient::didFinishLoading):

• platform/network/BlobResourceHandle.cpp:

(WebCore::doNotifyFinish):

• platform/network/PingHandle.h:
• platform/network/ResourceHandle.h:
• platform/network/ResourceHandleClient.h:

(WebCore::ResourceHandleClient::didFinishLoading):

• platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::crossThreadData):
(WebCore::ResourceResponseBase::fromCrossThreadData):
(WebCore::ResourceResponseBase::compare):

• platform/network/ResourceResponseBase.h:

(WebCore::ResourceResponseBase::deprecatedNetworkLoadMetrics):
(WebCore::ResourceResponseBase::encode):
(WebCore::ResourceResponseBase::decode):
(WebCore::ResourceResponseBase::networkLoadTiming): Deleted.

• platform/network/SynchronousLoaderClient.cpp:

(WebCore::SynchronousLoaderClient::didFinishLoading):

• platform/network/SynchronousLoaderClient.h:
• platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:

(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didFinishLoading):

• platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp:

(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveResponse):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didFinishLoading):

• platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::WebCoreSynchronousLoader::didFinishLoading):

• platform/network/curl/ResourceHandleManager.cpp:

(WebCore::calculateWebTimingInformations):
(WebCore::ResourceHandleManager::downloadTimerCallback):
(WebCore::handleDataURL):
(WebCore::milisecondsSinceRequest): Deleted.

• platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::getConnectionTimingData):

• platform/network/mac/WebCoreResourceHandleAsDelegate.mm:

(-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
(-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]):

• platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connectionDidFinishLoading:]):

• platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::restartedCallback):
(WebCore::nextMultipartResponsePartCallback):
(WebCore::sendRequestCallback):
(WebCore::ResourceHandle::didStartRequest):
(WebCore::networkEventCallback):
(WebCore::ResourceHandle::sendPendingRequest):
(WebCore::readCallback):
(WebCore::milisecondsSinceRequest): Deleted.

• workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::didFinishLoading):

• workers/WorkerScriptLoader.h:
• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::didFinishLoading):

• xml/XMLHttpRequest.h:

Eliminate the unused finishTime double.

Source/WebKit2:

Change from an unused double finishTime to a complete WebCore::NetworkLoadMetrics
object in the didFinishLoad ResourceLoader path. We may also extend this in the
didFail path later on. This allows the NetworkProcess to give complete timing
information, and more final metrics about the load, to WebCore.

• NetworkProcess/NetworkDataTask.h:

(WebKit::NetworkDataTaskClient::didCompleteWithError):
Give the NetworkDataTaskClient a basic didCompleteWithError for a completion
without metrics. For loads that complete with an error, or haven't populated
any metrics, this will pass empty metrics onward.

• NetworkProcess/Downloads/BlobDownloadClient.cpp:

(WebKit::BlobDownloadClient::didFinishLoading):

• NetworkProcess/Downloads/BlobDownloadClient.h:
• NetworkProcess/Downloads/PendingDownload.h:
• NetworkProcess/PingLoad.h:
• NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:

(WebKit::NetworkCache::SpeculativeLoad::didFinishLoading):

• NetworkProcess/cache/NetworkCacheSpeculativeLoad.h:
• NetworkProcess/NetworkDataTaskBlob.cpp:

(WebKit::NetworkDataTaskBlob::didFail):

• NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::continueWillSendRequest):
(WebKit::NetworkLoad::didCompleteWithError):
(WebKit::NetworkLoad::didFinishLoading):

• NetworkProcess/NetworkLoad.h:
• NetworkProcess/NetworkLoadClient.h:
• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didFinishLoading):
(WebKit::NetworkResourceLoader::sendResultForCacheEntry):

• NetworkProcess/NetworkResourceLoader.h:
• WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::didFinishResourceLoad):
(WebKit::WebResourceLoader::didReceiveResource):

• WebProcess/Network/WebResourceLoader.h:
• WebProcess/Network/WebResourceLoader.messages.in:

Change didFinishLoad paths to take a NetworkLoadMetrics object instead of finishTime.
Change didCompleteWithError pathes to include a NetworkLoadMetrics object instead of finishTime.

• NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
• NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::didCompleteWithError):
Own a NetworkLoadTiming that will be populated with the load.

• NetworkProcess/cocoa/NetworkSessionCocoa.h:
• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:didCompleteWithError:]):
(-[WKNetworkSessionDelegate URLSession:task:didFinishCollectingMetrics:]):
(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
Populate NetworkLoadMetrics in the didFinishCollectingMetrics NSURLSessionTaskDelegate method.

• NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::NetworkDataTaskSoup):
(WebKit::NetworkDataTaskSoup::timeoutFired):
(WebKit::NetworkDataTaskSoup::didSendRequest):
(WebKit::NetworkDataTaskSoup::dispatchDidReceiveResponse):
(WebKit::NetworkDataTaskSoup::dispatchDidCompleteWithError):
(WebKit::NetworkDataTaskSoup::tlsErrorsChanged):
(WebKit::NetworkDataTaskSoup::continueHTTPRedirection):
(WebKit::NetworkDataTaskSoup::didFinishRead):
(WebKit::NetworkDataTaskSoup::didFinishRequestNextPart):
(WebKit::NetworkDataTaskSoup::didFailDownload):
(WebKit::NetworkDataTaskSoup::didFail):
(WebKit::NetworkDataTaskSoup::networkEvent):
(WebKit::NetworkDataTaskSoup::didStartRequest):
(WebKit::NetworkDataTaskSoup::didRestart):

• NetworkProcess/soup/NetworkDataTaskSoup.h:

Instead of populating the NetworkLoadMetrics on the ResourceResponse, populate
a member variable during the entire load and dispatch didFinishCollectingMetrics
right before didCompleteLoadWithError.

Source/WTF:

• wtf/persistence/Coders.h:

(WTF::Persistence::Coder<Seconds>::encode):
(WTF::Persistence::Coder<Seconds>::decode):

LayoutTests:

• TestExpectations:

Now that nextHopProtocol is available on Mac mark the test as flakey
because the value can be set or not depending on whether or not the
resource was loaded from a cache.

• platform/ios-simulator/TestExpectations:
• platform/gtk/TestExpectations:
• platform/mac/TestExpectations:
• platform/win/TestExpectations:

Mark nextHopProtocol tests as expected to fail on ports that do not
yet support those values. Mark redirect tests as failing on ports
that encounter the CFNetwork issue causing unexpected callbacks.

• performance-api/resource-timing-apis-expected.txt:
• performance-api/resources/resource-timing-api.js:

Progressions.

• platform/mac-elcapitan/imported/w3c/web-platform-tests/resource-timing/test_resource_timing-expected.txt: Added.
• platform/mac/imported/w3c/web-platform-tests/resource-timing/test_resource_timing-expected.txt: Added.

Expected passing values on mac, except el capitan where this new resource timing data is unavailable.

8:54 PM Changeset in webkit [212992] by keith_miller@apple.com

• 3 edits in trunk/Source/WTF

Rubber-stamped by Chris Dumez.

Replace typename Bool with typename BoolType because X11 has
#define Bool int for some unknown reason...

• wtf/HashFunctions.h:

(WTF::TupleHash::allTrue):

• wtf/HashTraits.h:

(WTF::TupleHashTraits::allTrue):

8:27 PM Changeset in webkit [212991] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Unreviewed GTK build fix after r212965

• CMakeLists.txt:

8:05 PM Changeset in webkit [212990] by Wenson Hsieh

• 4 edits in trunk/Tools

Unreviewed, temporarily disable all data interaction tests.

They will be reenabled once the bots are ready to build and run them.

• TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
• TestWebKitAPI/ios/DataInteractionSimulator.h:
• TestWebKitAPI/ios/DataInteractionSimulator.mm:

7:34 PM Changeset in webkit [212989] by Chris Dumez

• 96 edits
  2 moves
  8 deletes in trunk

Unreviewed, rolling out r212944.

Caused a lot of failures on the debug bots

Reverted changeset:

"[Resource Timing] Gather timing information with reliable
responseEnd time"
​https://bugs.webkit.org/show_bug.cgi?id=168351
​http://trac.webkit.org/changeset/212944

7:24 PM Changeset in webkit [212988] by Wenson Hsieh

• 2 edits in trunk/Tools

Unreviewed, fix the internal build.

• TestWebKitAPI/ios/DataInteractionSimulator.mm:

(-[DataInteractionSimulator _advanceProgress]):

7:23 PM Changeset in webkit [212987] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Unreviewed, follow-up fix after r212972.

Fixes a few assertions on the debug build bots.
URL needs to be exactly the same as the parsed one given
that we are calling the ParsedURLString constructor.

• platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::sanitizeSuggestedFilename):

6:14 PM Changeset in webkit [212986] by Alan Bujtas

• 7 edits
  2 adds in trunk/Source/WebCore

Simple line layout: Re-adjust paginated lines when block height changes.
​https://bugs.webkit.org/show_bug.cgi?id=168838
<rdar://problem/30701233>

Reviewed by Antti Koivisto.

When the estimated block height is wrong, we issue an additional layout on the inline children
so that we get the pagination right (this layout is setChildNeedsLayout(MarkOnlyThis) only).
Since the height change only affects the struts and page breaks (and again, the relayoutChildren flag is false)
we don't need to re-layout the content, but instead we just need to re-adjust the pagination for the simple lines.
This patch also moves the pagination logic to SimpleLineLayoutPagination.cpp.

Not enabled yet.

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:
• rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::layoutSimpleLines):

• rendering/RenderingAllInOne.cpp:
• rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseForWithReason):
(WebCore::SimpleLineLayout::create):
(WebCore::SimpleLineLayout::Layout::create):
(WebCore::SimpleLineLayout::Layout::Layout):
(WebCore::SimpleLineLayout::computeLineTopAndBottomWithOverflow): Deleted.
(WebCore::SimpleLineLayout::computeLineBreakIndex): Deleted.
(WebCore::SimpleLineLayout::computeOffsetAfterLineBreak): Deleted.
(WebCore::SimpleLineLayout::setPageBreakForLine): Deleted.
(WebCore::SimpleLineLayout::updateMinimumPageHeight): Deleted.
(WebCore::SimpleLineLayout::adjustLinePositionsForPagination): Deleted.

• rendering/SimpleLineLayout.h:

(WebCore::SimpleLineLayout::Layout::setIsPaginated):
(WebCore::SimpleLineLayout::Layout::setLineStruts):

• rendering/SimpleLineLayoutPagination.cpp: Added.

(WebCore::SimpleLineLayout::computeLineTopAndBottomWithOverflow):
(WebCore::SimpleLineLayout::computeLineBreakIndex):
(WebCore::SimpleLineLayout::computeOffsetAfterLineBreak):
(WebCore::SimpleLineLayout::setPageBreakForLine):
(WebCore::SimpleLineLayout::updateMinimumPageHeight):
(WebCore::SimpleLineLayout::adjustLinePositionsForPagination):

• rendering/SimpleLineLayoutPagination.h: Added.

6:07 PM Changeset in webkit [212985] by jonlee@apple.com

• 44 edits in trunk

Alias "system-ui" for the System font name
​https://bugs.webkit.org/show_bug.cgi?id=151493

Reviewed by Tim Horton and Joseph Pecoraro.

Source/WebCore:

Updated existing tests.

• WebCore.xcodeproj/project.pbxproj: Add WebKitFontFamilyNames.in for

convenience.

• css/CSSValueKeywords.in: Add system-ui as a keyword.
• css/WebKitFontFamilyNames.in: Add system-ui.

• platform/graphics/ios/FontCacheIOS.mm:

(WebCore::platformFontWithFamilySpecialCase): Include "system-ui" as an
alias.

• platform/graphics/mac/FontCacheMac.mm:

(WebCore::platformFontWithFamilySpecialCase): Ditto.

• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::updateCachedSystemFontDescription): Update
serialization to "system-ui" from "-apple-system".

• css/CSSComputedStyleDeclaration.cpp:

(WebCore::identifierForFamily):

• css/CSSFontFaceSet.cpp:

(WebCore::CSSFontFaceSet::familyNameFromPrimitive):

• css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyValueFontFamily):

Source/WebInspectorUI:

• UserInterface/Models/CSSKeywordCompletions.js: Ditto.

LayoutTests:

Add "system-ui" to the test.

• fast/css/font-family-builtins.html:
• fast/css/font-family-builtins-expected.txt:
• fast/text/system-font-features.html:
• fast/text/system-font-features-expected.html:
• fast/text/system-font-legacy-name.html:
• fast/text/system-font-legacy-name-expected.txt:
• platform/ios-simulator/ios/fast/text/opticalFont.html:
• platform/ios-simulator/ios/fast/text/opticalFont-expected.txt:
• platform/ios-simulator/ios/fast/text/opticalFontWithTextStyle-expected.txt:

Unskip opticalFont* tests.

• platform/ios-simulator/TestExpectations:

Update tests to use "system-ui" instead of "-apple-system" or the even
older "-apple-system-font".

• fast/css/multiple-tabs-expected.html:
• fast/css/multiple-tabs.html:
• fast/text/international/system-language/han-quotes-expected-mismatch.html:
• fast/text/international/system-language/han-quotes.html:
• fast/text/international/system-language/hindi-system-font-punctuation-expected.html:
• fast/text/international/system-language/hindi-system-font-punctuation.html:
• fast/text/letterpress-different-expected-mismatch.html:
• fast/text/letterpress-different.html:
• fast/text/letterpress-paint.html:
• fast/text/system-font-weight-italic.html:
• fast/text/system-font-weight.html:
• fast/text/text-node-remains-dirty-after-calling-surroundContents-expected.html:
• fast/text/text-node-remains-dirty-after-calling-surroundContents.html:
• fast/text/trak-optimizeLegibility.html:
• fast/text/weighted-italicized-system-font-expected.html:
• fast/text/weighted-italicized-system-font.html:
• platform/ios-simulator/ios/fast/text/apple-logo.html:
• platform/ios-simulator/ios/fast/text/opticalFontWithWeight-expected.txt:
• platform/ios-simulator/ios/fast/text/opticalFontWithWeight.html:
• platform/ios-simulator/ios/fast/text/underline-scaling.html:
• platform/mac/fast/css/css2-system-fonts-expected.txt:

6:07 PM Changeset in webkit [212984] by Wenson Hsieh

• 2 edits in trunk/Source/WebKit2

Unreviewed, fix the internal build

• UIProcess/ios/WKContentViewInteraction.h:

6:02 PM Changeset in webkit [212983] by jfbastien@apple.com

• 14 edits in trunk

WebAssembly: miscellaneous spec fixes
​https://bugs.webkit.org/show_bug.cgi?id=168822

Reviewed by Saam Barati.

JSTests:

• wasm.yaml: mark some skip tests as normal, now that they pass
• wasm/Builder.js: error message was wrong, causing extra error if hit
• wasm/js-api/global-error.js: new tests

(assert.throws):

• wasm/spec-tests/call.wast.js: comment out stack check tests
• wasm/spec-tests/call_indirect.wast.js: comment out stack check tests
• wasm/spec-tests/fac.wast.js: comment out stack check tests
• wasm/spec-tests/float_exprs.wast.js: wabt is wrong, bug reported, we should update
• wasm/spec-tests/imports.wast.js: bug in old wabt, fixed in recent wabt

(assert_unlinkable):

Source/JavaScriptCore:

• wasm/WasmModuleParser.cpp: "unknown" sections are now called "custom" sections
• wasm/WasmSections.h:

(JSC::Wasm::validateOrder):
(JSC::Wasm::makeString): fix ASSERT_UNREACHABLE bug in printing

• wasm/js/WebAssemblyInstanceConstructor.cpp:

(JSC::constructJSWebAssemblyInstance): disallow i64 import

• wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::link): disallow i64 export
(JSC::WebAssemblyModuleRecord::evaluate):

5:17 PM Changeset in webkit [212982] by mrajca@apple.com

• 15 edits
  1 add in trunk

Media: notify clients when autoplay is denied
​https://bugs.webkit.org/show_bug.cgi?id=168840

Reviewed by Alex Christensen.

Source/WebCore:

Added API tests.

• WebCore.xcodeproj/project.pbxproj:
• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::play):
(WebCore::HTMLMediaElement::playInternal):

• page/AutoplayEvent.h: Added.
• page/ChromeClient.h:

Source/WebKit2:

• UIProcess/API/APIUIClient.h:

(API::UIClient::handleAutoplayEvent):
(API::UIClient::didPlayMediaPreventedFromPlayingWithoutUserGesture): Deleted.

• UIProcess/API/C/WKPage.cpp:

(WKPageSetPageUIClient):

• UIProcess/API/C/WKPageUIClient.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::handleAutoplayEvent):
(WebKit::WebPageProxy::didPlayMediaPreventedFromPlayingWithoutUserGesture): Deleted.

• UIProcess/WebPageProxy.h:
• UIProcess/WebPageProxy.messages.in:
• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::handleAutoplayEvent):
(WebKit::WebChromeClient::didPlayMediaPreventedFromPlayingWithoutUserGesture): Deleted.

• WebProcess/WebCoreSupport/WebChromeClient.h:

Tools:

• TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:

(handleAutoplayEvent):
(runUntilReceivesAutoplayEvent):
(TEST): Added.

5:08 PM Changeset in webkit [212981] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

curl: Improve errors by including the domain
​https://bugs.webkit.org/show_bug.cgi?id=134340

Patch by Basuke Suzuki <​Basuke.Suzuki@am.sony.com> on 2017-02-24
Reviewed by Alex Christensen.

Added proper error domain to ResourceError created by
Curl problem.

• platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::downloadTimerCallback):
(WebCore::ResourceHandleManager::dispatchSynchronousJob):

5:03 PM Changeset in webkit [212980] by commit-queue@webkit.org

• 8 edits
  2 copies in trunk

[Modern Media Controls] <audio> controls should center in their container when the page is scaled
​https://bugs.webkit.org/show_bug.cgi?id=168841
<rdar://problem/28612794>

Patch by Antoine Quint <Antoine Quint> on 2017-02-24
Reviewed by Eric Carlson.

Source/WebCore:

When dealing with <audio> elements, we vertically center the controls relative to their containing
media element such that if the controls visually overflow, they overflow equally above and below
to minimize the likelihood of overlap with surrounding elements.

Test: media/modern-media-controls/media-controller/media-controller-scale-factor-audio.html

• Modules/modern-media-controls/controls/media-controls.js:

(MediaControls.prototype.get shouldCenterControlsVertically):
(MediaControls.prototype.set shouldCenterControlsVertically):
(MediaControls.prototype.commitProperty):

• Modules/modern-media-controls/media/media-controller.js:

(MediaController.prototype.get isAudio):
(MediaController.prototype.get layoutTraits):
(MediaController.prototype._updateControlsSize):

LayoutTests:

Adding test coverage for the "top" property set on the media controls to achieve vertical centering,
and creating a new test that checks the behavior for an <audio> element on iOS.

• TestExpectations:
• media/modern-media-controls/media-controller/media-controller-scale-factor-audio-expected.txt: Added.
• media/modern-media-controls/media-controller/media-controller-scale-factor-audio.html: Added.
• media/modern-media-controls/media-controller/media-controller-scale-factor-expected.txt:
• media/modern-media-controls/media-controller/media-controller-scale-factor.html:
• platform/ios-simulator/TestExpectations:

4:47 PM Changeset in webkit [212979] by jmarcell@apple.com

• 1 copy in tags/Safari-603.1.30.1.30

Tag Safari-603.1.30.1.30.

4:46 PM Changeset in webkit [212978] by jmarcell@apple.com

• 1 copy in tags/Safari-603.1.30.0.30

Tag Safari-603.1.30.0.30.

4:36 PM Changeset in webkit [212977] by achristensen@apple.com

• 6 edits in trunk

Non-special relative URLs should not ignore extra slashes
​https://bugs.webkit.org/show_bug.cgi?id=168834

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

• web-platform-tests/url/a-element-expected.txt:
• web-platform-tests/url/a-element-xhtml-expected.txt:
• web-platform-tests/url/url-constructor-expected.txt:

Source/WebCore:

Special authority ignore slashes state should, as its name implies,
only be reached by special URLs. See ​https://url.spec.whatwg.org/#relative-slash-state

Covered by newly passing web platform tests.

• platform/URLParser.cpp:

(WebCore::URLParser::parse):

4:20 PM Changeset in webkit [212976] by ap@apple.com

• 2 edits in trunk/Source/WebCore

Build fix for newer clang
​https://bugs.webkit.org/show_bug.cgi?id=168849
rdar://problem/30638741

Reviewed by Ryosuke Niwa.

• dom/Range.cpp: (WebCore::Range::toString): std::max(0, <unsigned>) is not meaningful,

and now triggers a warning.

4:17 PM Changeset in webkit [212975] by mrajca@apple.com

• 2 edits in trunk/Tools

API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay is timing out
​https://bugs.webkit.org/show_bug.cgi?id=167466

Reviewed by Alex Christensen.

• TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:

(TEST): Use the correct API version.

4:05 PM Changeset in webkit [212974] by Wenson Hsieh

• 11 edits in trunk

Refactor data interaction to use new WKDataInteraction SPI
​https://bugs.webkit.org/show_bug.cgi?id=168602
Work towards <rdar://problem/30313681>

Reviewed by Tim Horton.

Source/WebKit2:

Adjust testing SPI to match new data interaction interfaces.

• Platform/spi/ios/UIKitSPI.h:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _simulateDataInteractionEntered:]):
(-[WKWebView _simulateDataInteractionUpdated:]):
(-[WKWebView _simulateDataInteractionPerformOperation:]):
(-[WKWebView _simulateDataInteractionEnded:]):
(-[WKWebView _simulateDataInteractionSessionDidEnd:]):
(-[WKWebView _simulateWillBeginDataInteractionWithSession:]):
(-[WKWebView _simulatedItemsForSession:]):
(-[WKWebView _simulatePrepareForDataInteractionSession:completion:]):
(-[WKWebView _simulateDataInteractionSessionDidEnd:withOperation:]): Deleted.
(-[WKWebView _simulateFailedDataInteractionWithIndex:]): Deleted.
(-[WKWebView _simulateWillBeginDataInteractionWithIndex:withSession:]): Deleted.
(-[WKWebView _simulatedItemsForDataInteractionWithIndex:]): Deleted.

• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _positionInformationDidChange:]):

• UIProcess/ios/WKScrollView.h:
• UIProcess/ios/WKScrollView.mm:

Tools:

Update DataInteractionSimulator to simulate data interaction using updated SPI. See changes in WebKit2 for more details.

• TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/ios/DataInteractionSimulator.h:
• TestWebKitAPI/ios/DataInteractionSimulator.mm:

(-[DataInteractionSimulator _resetSimulatedState]):
(-[DataInteractionSimulator runFrom:to:]):
(-[DataInteractionSimulator _advanceProgress]):
(-[DataInteractionSimulator _currentLocation]):
(-[DataInteractionSimulator _finishDataInteraction]): Deleted.
(-[DataInteractionSimulator webViewDidSendDataInteractionStartRequest:]): Deleted.
(-[DataInteractionSimulator webView:didReceiveDataInteractionStartResponse:]): Deleted.

4:05 PM Changeset in webkit [212973] by Wenson Hsieh

• 8 edits in trunk

Remove the data interaction gesture recognizer
​https://bugs.webkit.org/show_bug.cgi?id=168600
<rdar://problem/30313681>

Reviewed by Anders Carlsson.

Source/WebKit2:

The data interaction gesture recognizer will no longer be needed moving forward.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _simulateDataInteractionGestureRecognized]): Deleted.

• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView _removeDefaultGestureRecognizers]):
(-[WKContentView _addDefaultGestureRecognizers]):
(-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKContentView gestureRecognizerShouldBegin:]):
(-[WKContentView _dataInteractionGestureRecognizer]): Deleted.

Tools:

Adjust TestWebKitAPI for changes in WebKit2.

• TestWebKitAPI/ios/DataInteractionSimulator.h:
• TestWebKitAPI/ios/DataInteractionSimulator.mm:

(-[DataInteractionSimulator initWithWebView:]):
(-[DataInteractionSimulator runFrom:to:]):
(-[DataInteractionSimulator _advanceProgress]):
(-[DataInteractionSimulator _finishDataInteraction]):
(-[MockLongPressGestureRecognizer initWithWindow:]): Deleted.
(-[MockLongPressGestureRecognizer locationInView:]): Deleted.
(-[MockLongPressGestureRecognizer state]): Deleted.
(-[MockLongPressGestureRecognizer numberOfTouches]): Deleted.
(-[DataInteractionSimulator _recognizeGestureAtLocation:withState:]): Deleted.
(-[DataInteractionSimulator dataInteractionGestureRecognizer]): Deleted.
(-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]): Deleted.

4:02 PM Changeset in webkit [212972] by Chris Dumez

• 9 edits
  6 adds in trunk

Download attribute should be sanitized before being used as suggested filename
​https://bugs.webkit.org/show_bug.cgi?id=168839
<rdar://problem/30683109>

Reviewed by Darin Adler.

Source/WebCore:

Sanitize Download attribute before using it as a suggested filename for the download.
We rely on ResourceResponse's sanitizing of the suggested filename to do so, which has
the benefit of being consistent with downloads without the download attribute.

Tests: fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-doublequote.html

fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-slashes.html
fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-unicode.html

• html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::handleClick):

• platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::sanitizeSuggestedFilename):

• platform/network/ResourceResponseBase.h:

LayoutTests:

Add layout test coverage.

• fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-doublequote-expected.txt: Added.
• fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-doublequote.html: Added.
• fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-slashes-expected.txt: Added.
• fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-slashes.html: Added.
• fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-unicode-expected.txt: Added.
• fast/dom/HTMLAnchorElement/anchor-file-blob-download-includes-unicode.html: Added.
• platform/ios-simulator-wk1/TestExpectations:
• platform/ios-simulator-wk2/TestExpectations:
• platform/mac-wk1/TestExpectations:
• platform/win/TestExpectations:

3:16 PM Changeset in webkit [212971] by achristensen@apple.com

• 1 edit
  1 delete in trunk/Source/ThirdParty/libwebrtc

Remove unneeded protobuf tests directory.

Rubber-stamped by Joe Pecoraro.

This directory contained a swift file that was causing problems in an internal verification step.

• Source/third_party/protobuf/objectivec/Tests: Removed.

(And everything in this subdirectory)

2:50 PM Changeset in webkit [212970] by fpizlo@apple.com

• 48 edits
  4 adds in trunk/Source/JavaScriptCore

Move Arg::Type and Arg::Width out into the B3 namespace, since they are general concepts
​https://bugs.webkit.org/show_bug.cgi?id=168833

Reviewed by Saam Barati.

I want to use the Air::Arg::Type and Air::Arg::Width concepts in B3. We are already
doing this a bit, and it's akward because of the namespacing. Throughout B3 we take the
approach that if something is not specific to Air, then it should be in the B3
namespace.

This moves Air::Arg::Type to B3::Bank. This moves Air::Arg::Width to B3::Width.

I renamed Arg::Type to Bank because there is already a B3::Type and because Arg::Type
was never really a type. Its purpose was always to identify register banks, and we use
this enum when the thing we care about is whether the value is most appropriate for
GPRs or FPRs.

I kept both as non-enum classes because I think that we've learned that terse compiler
code is a good thing. I don't want to say Bank::GP when I can say GP. With Width, the
argument is even stronger, since you cannot say Width::8 but you can say Width8.

• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• b3/B3Bank.cpp: Added.

(WTF::printInternal):

• b3/B3Bank.h: Added.

(JSC::B3::forEachBank):
(JSC::B3::bankForType):

• b3/B3CheckSpecial.cpp:

(JSC::B3::CheckSpecial::forEachArg):

• b3/B3LegalizeMemoryOffsets.cpp:
• b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::run):
(JSC::B3::Air::LowerToAir::tmp):
(JSC::B3::Air::LowerToAir::scaleForShl):
(JSC::B3::Air::LowerToAir::effectiveAddr):
(JSC::B3::Air::LowerToAir::addr):
(JSC::B3::Air::LowerToAir::createGenericCompare):
(JSC::B3::Air::LowerToAir::createBranch):
(JSC::B3::Air::LowerToAir::createCompare):
(JSC::B3::Air::LowerToAir::createSelect):
(JSC::B3::Air::LowerToAir::lower):

• b3/B3MemoryValue.cpp:

(JSC::B3::MemoryValue::accessWidth):

• b3/B3MemoryValue.h:
• b3/B3MoveConstants.cpp:
• b3/B3PatchpointSpecial.cpp:

(JSC::B3::PatchpointSpecial::forEachArg):

• b3/B3StackmapSpecial.cpp:

(JSC::B3::StackmapSpecial::forEachArgImpl):

• b3/B3Value.h:
• b3/B3Variable.h:

(JSC::B3::Variable::width):
(JSC::B3::Variable::bank):

• b3/B3WasmAddressValue.h:
• b3/B3Width.cpp: Added.

(WTF::printInternal):

• b3/B3Width.h: Added.

(JSC::B3::pointerWidth):
(JSC::B3::widthForType):
(JSC::B3::conservativeWidth):
(JSC::B3::minimumWidth):
(JSC::B3::bytes):
(JSC::B3::widthForBytes):

• b3/air/AirAllocateRegistersByGraphColoring.cpp:
• b3/air/AirAllocateStack.cpp:

(JSC::B3::Air::allocateStack):

• b3/air/AirArg.cpp:

(JSC::B3::Air::Arg::canRepresent):
(JSC::B3::Air::Arg::isCompatibleBank):
(JSC::B3::Air::Arg::isCompatibleType): Deleted.

• b3/air/AirArg.h:

(JSC::B3::Air::Arg::hasBank):
(JSC::B3::Air::Arg::bank):
(JSC::B3::Air::Arg::isBank):
(JSC::B3::Air::Arg::forEachTmp):
(JSC::B3::Air::Arg::forEachType): Deleted.
(JSC::B3::Air::Arg::pointerWidth): Deleted.
(JSC::B3::Air::Arg::typeForB3Type): Deleted.
(JSC::B3::Air::Arg::widthForB3Type): Deleted.
(JSC::B3::Air::Arg::conservativeWidth): Deleted.
(JSC::B3::Air::Arg::minimumWidth): Deleted.
(JSC::B3::Air::Arg::bytes): Deleted.
(JSC::B3::Air::Arg::widthForBytes): Deleted.
(JSC::B3::Air::Arg::hasType): Deleted.
(JSC::B3::Air::Arg::type): Deleted.
(JSC::B3::Air::Arg::isType): Deleted.

• b3/air/AirArgInlines.h:

(JSC::B3::Air::ArgThingHelper<Tmp>::forEach):
(JSC::B3::Air::ArgThingHelper<Arg>::forEach):
(JSC::B3::Air::ArgThingHelper<Reg>::forEach):
(JSC::B3::Air::Arg::forEach):

• b3/air/AirCCallSpecial.cpp:

(JSC::B3::Air::CCallSpecial::forEachArg):

• b3/air/AirCCallingConvention.cpp:
• b3/air/AirCode.cpp:

(JSC::B3::Air::Code::Code):
(JSC::B3::Air::Code::setRegsInPriorityOrder):
(JSC::B3::Air::Code::pinRegister):

• b3/air/AirCode.h:

(JSC::B3::Air::Code::regsInPriorityOrder):
(JSC::B3::Air::Code::newTmp):
(JSC::B3::Air::Code::numTmps):
(JSC::B3::Air::Code::regsInPriorityOrderImpl):

• b3/air/AirCustom.cpp:

(JSC::B3::Air::PatchCustom::isValidForm):
(JSC::B3::Air::ShuffleCustom::isValidForm):

• b3/air/AirCustom.h:

(JSC::B3::Air::PatchCustom::forEachArg):
(JSC::B3::Air::CCallCustom::forEachArg):
(JSC::B3::Air::ColdCCallCustom::forEachArg):
(JSC::B3::Air::ShuffleCustom::forEachArg):
(JSC::B3::Air::WasmBoundsCheckCustom::forEachArg):

• b3/air/AirDumpAsJS.cpp:

(JSC::B3::Air::dumpAsJS):

• b3/air/AirEliminateDeadCode.cpp:

(JSC::B3::Air::eliminateDeadCode):

• b3/air/AirEmitShuffle.cpp:

(JSC::B3::Air::emitShuffle):

• b3/air/AirEmitShuffle.h:

(JSC::B3::Air::ShufflePair::ShufflePair):
(JSC::B3::Air::ShufflePair::width):

• b3/air/AirFixObviousSpills.cpp:
• b3/air/AirFixPartialRegisterStalls.cpp:

(JSC::B3::Air::fixPartialRegisterStalls):

• b3/air/AirInst.cpp:

(JSC::B3::Air::Inst::hasArgEffects):

• b3/air/AirInst.h:

(JSC::B3::Air::Inst::forEachTmp):

• b3/air/AirInstInlines.h:

(JSC::B3::Air::Inst::forEach):
(JSC::B3::Air::Inst::forEachDef):
(JSC::B3::Air::Inst::forEachDefWithExtraClobberedRegs):

• b3/air/AirLiveness.h:

(JSC::B3::Air::TmpLivenessAdapter::numIndices):
(JSC::B3::Air::TmpLivenessAdapter::acceptsBank):
(JSC::B3::Air::TmpLivenessAdapter::valueToIndex):
(JSC::B3::Air::TmpLivenessAdapter::indexToValue):
(JSC::B3::Air::StackSlotLivenessAdapter::acceptsBank):
(JSC::B3::Air::RegLivenessAdapter::acceptsBank):
(JSC::B3::Air::AbstractLiveness::AbstractLiveness):
(JSC::B3::Air::AbstractLiveness::LocalCalc::execute):
(JSC::B3::Air::TmpLivenessAdapter::acceptsType): Deleted.
(JSC::B3::Air::StackSlotLivenessAdapter::acceptsType): Deleted.
(JSC::B3::Air::RegLivenessAdapter::acceptsType): Deleted.

• b3/air/AirLogRegisterPressure.cpp:

(JSC::B3::Air::logRegisterPressure):

• b3/air/AirLowerAfterRegAlloc.cpp:

(JSC::B3::Air::lowerAfterRegAlloc):

• b3/air/AirLowerMacros.cpp:

(JSC::B3::Air::lowerMacros):

• b3/air/AirPadInterference.cpp:

(JSC::B3::Air::padInterference):

• b3/air/AirReportUsedRegisters.cpp:

(JSC::B3::Air::reportUsedRegisters):

• b3/air/AirSpillEverything.cpp:

(JSC::B3::Air::spillEverything):

• b3/air/AirTmpInlines.h:

(JSC::B3::Air::AbsoluteTmpMapper<Arg::GP>::absoluteIndex): Deleted.
(JSC::B3::Air::AbsoluteTmpMapper<Arg::GP>::lastMachineRegisterIndex): Deleted.
(JSC::B3::Air::AbsoluteTmpMapper<Arg::GP>::tmpFromAbsoluteIndex): Deleted.
(JSC::B3::Air::AbsoluteTmpMapper<Arg::FP>::absoluteIndex): Deleted.
(JSC::B3::Air::AbsoluteTmpMapper<Arg::FP>::lastMachineRegisterIndex): Deleted.
(JSC::B3::Air::AbsoluteTmpMapper<Arg::FP>::tmpFromAbsoluteIndex): Deleted.

• b3/air/AirTmpWidth.cpp:

(JSC::B3::Air::TmpWidth::recompute):

• b3/air/AirTmpWidth.h:

(JSC::B3::Air::TmpWidth::width):
(JSC::B3::Air::TmpWidth::requiredWidth):
(JSC::B3::Air::TmpWidth::defWidth):
(JSC::B3::Air::TmpWidth::useWidth):
(JSC::B3::Air::TmpWidth::Widths::Widths):

• b3/air/AirUseCounts.h:

(JSC::B3::Air::UseCounts::UseCounts):

• b3/air/AirValidate.cpp:
• b3/air/opcode_generator.rb:
• b3/air/testair.cpp:

(JSC::B3::Air::compile): Deleted.
(JSC::B3::Air::invoke): Deleted.
(JSC::B3::Air::compileAndRun): Deleted.
(JSC::B3::Air::testSimple): Deleted.
(JSC::B3::Air::loadConstantImpl): Deleted.
(JSC::B3::Air::loadConstant): Deleted.
(JSC::B3::Air::loadDoubleConstant): Deleted.
(JSC::B3::Air::testShuffleSimpleSwap): Deleted.
(JSC::B3::Air::testShuffleSimpleShift): Deleted.
(JSC::B3::Air::testShuffleLongShift): Deleted.
(JSC::B3::Air::testShuffleLongShiftBackwards): Deleted.
(JSC::B3::Air::testShuffleSimpleRotate): Deleted.
(JSC::B3::Air::testShuffleSimpleBroadcast): Deleted.
(JSC::B3::Air::testShuffleBroadcastAllRegs): Deleted.
(JSC::B3::Air::testShuffleTreeShift): Deleted.
(JSC::B3::Air::testShuffleTreeShiftBackward): Deleted.
(JSC::B3::Air::testShuffleTreeShiftOtherBackward): Deleted.
(JSC::B3::Air::testShuffleMultipleShifts): Deleted.
(JSC::B3::Air::testShuffleRotateWithFringe): Deleted.
(JSC::B3::Air::testShuffleRotateWithFringeInWeirdOrder): Deleted.
(JSC::B3::Air::testShuffleRotateWithLongFringe): Deleted.
(JSC::B3::Air::testShuffleMultipleRotates): Deleted.
(JSC::B3::Air::testShuffleShiftAndRotate): Deleted.
(JSC::B3::Air::testShuffleShiftAllRegs): Deleted.
(JSC::B3::Air::testShuffleRotateAllRegs): Deleted.
(JSC::B3::Air::testShuffleSimpleSwap64): Deleted.
(JSC::B3::Air::testShuffleSimpleShift64): Deleted.
(JSC::B3::Air::testShuffleSwapMixedWidth): Deleted.
(JSC::B3::Air::testShuffleShiftMixedWidth): Deleted.
(JSC::B3::Air::testShuffleShiftMemory): Deleted.
(JSC::B3::Air::testShuffleShiftMemoryLong): Deleted.
(JSC::B3::Air::testShuffleShiftMemoryAllRegs): Deleted.
(JSC::B3::Air::testShuffleShiftMemoryAllRegs64): Deleted.
(JSC::B3::Air::combineHiLo): Deleted.
(JSC::B3::Air::testShuffleShiftMemoryAllRegsMixedWidth): Deleted.
(JSC::B3::Air::testShuffleRotateMemory): Deleted.
(JSC::B3::Air::testShuffleRotateMemory64): Deleted.
(JSC::B3::Air::testShuffleRotateMemoryMixedWidth): Deleted.
(JSC::B3::Air::testShuffleRotateMemoryAllRegs64): Deleted.
(JSC::B3::Air::testShuffleRotateMemoryAllRegsMixedWidth): Deleted.
(JSC::B3::Air::testShuffleSwapDouble): Deleted.
(JSC::B3::Air::testShuffleShiftDouble): Deleted.
(JSC::B3::Air::testX86VMULSD): Deleted.
(JSC::B3::Air::testX86VMULSDDestRex): Deleted.
(JSC::B3::Air::testX86VMULSDOp1DestRex): Deleted.
(JSC::B3::Air::testX86VMULSDOp2DestRex): Deleted.
(JSC::B3::Air::testX86VMULSDOpsDestRex): Deleted.
(JSC::B3::Air::testX86VMULSDAddr): Deleted.
(JSC::B3::Air::testX86VMULSDAddrOpRexAddr): Deleted.
(JSC::B3::Air::testX86VMULSDDestRexAddr): Deleted.
(JSC::B3::Air::testX86VMULSDRegOpDestRexAddr): Deleted.
(JSC::B3::Air::testX86VMULSDAddrOpDestRexAddr): Deleted.
(JSC::B3::Air::testX86VMULSDBaseNeedsRex): Deleted.
(JSC::B3::Air::testX86VMULSDIndexNeedsRex): Deleted.
(JSC::B3::Air::testX86VMULSDBaseIndexNeedRex): Deleted.
(JSC::B3::Air::run): Deleted.

2:14 PM Changeset in webkit [212969] by keith_miller@apple.com

• 7 edits in trunk/Source

We should be able to use std::tuples as keys in HashMap
​https://bugs.webkit.org/show_bug.cgi?id=168805

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Convert the mess of std::pairs we used as the keys in PrototypeMap
to a std::tuple. I also plan on using this for a HashMap in wasm.

• JavaScriptCore.xcodeproj/project.pbxproj:
• runtime/PrototypeMap.cpp:

(JSC::PrototypeMap::createEmptyStructure):
(JSC::PrototypeMap::clearEmptyObjectStructureForPrototype):

• runtime/PrototypeMap.h:

Source/WTF:

This patch adds support for using std::tupeles as the key
type in HashMap. It is equivalent to doing a sequence of
std::pairs but has a nicer syntax.

• wtf/HashFunctions.h:

(WTF::TupleHash::hash):
(WTF::TupleHash::equal):
(WTF::TupleHash::allTrue):

• wtf/HashTraits.h:

(WTF::TupleHashTraits::allTrue):
(WTF::TupleHashTraits::emptyValue):
(WTF::TupleHashTraits::constructDeletedValue):
(WTF::TupleHashTraits::isDeletedValue):

12:44 PM Changeset in webkit [212968] by magomez@igalia.com

• 2 edits in trunk/Source/WebCore

[GTK] WebkitWebProcess crashes on exit on nvidia if threaded compositing is enabled
​https://bugs.webkit.org/show_bug.cgi?id=165522

Reviewed by Carlos Garcia Campos.

Before destrying a GLContextGLX we need to set the default framebufer to avoid a bug
in some nvidia drivers. Ensure that we set the context as current before performing
that operation, and set the appropriate current context after doing so.

No new tests.

• platform/graphics/glx/GLContextGLX.cpp:

(WebCore::GLContextGLX::~GLContextGLX):

12:09 PM Changeset in webkit [212967] by commit-queue@webkit.org

• 2 edits in trunk/Source/WTF

Prepare to enable WebRTC on iOS
​https://bugs.webkit.org/show_bug.cgi?id=168811

Patch by Alex Christensen <​achristensen@webkit.org> on 2017-02-24
Reviewed by Youenn Fablet.

• wtf/Platform.h:

12:04 PM Changeset in webkit [212966] by Antti Koivisto

• 1 edit
  2 deletes in trunk/LayoutTests

Remove leftover html files.

• http/tests/cache/disk-cache/shattered-deduplication-expected.html: Removed.
• http/tests/cache/disk-cache/shattered-deduplication.html: Removed.

11:51 AM Changeset in webkit [212965] by Chris Dumez

• 5 edits
  3 adds in trunk/Source

[iOS][WK2] Disable network cache speculative revalidation / loading in low power mode
​https://bugs.webkit.org/show_bug.cgi?id=168832
<rdar://problem/30697911>

Reviewed by Antti Koivisto.

Source/WebCore:

Add LowPowerModeNotifier class to monitor low power mode state on iOS.

• WebCore.xcodeproj/project.pbxproj:
• platform/LowPowerModeNotifier.cpp: Added.

(WebCore::LowPowerModeNotifier::LowPowerModeNotifier):
(WebCore::LowPowerModeNotifier::isLowPowerModeEnabled):

• platform/LowPowerModeNotifier.h: Added.
• platform/ios/LowPowerModeNotifierIOS.mm: Added.

(-[WebLowPowerModeObserver initWithNotifier:]):
(-[WebLowPowerModeObserver dealloc]):
(-[WebLowPowerModeObserver _didReceiveLowPowerModeChange]):
(WebCore::LowPowerModeNotifier::LowPowerModeNotifier):
(WebCore::LowPowerModeNotifier::isLowPowerModeEnabled):
(WebCore::LowPowerModeNotifier::notifyLowPowerModeChanged):
(WebCore::notifyLowPowerModeChanged):

Source/WebKit2:

Disable network cache speculative revalidation / loading in low power mode on iOS to
save battery.

• NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::initialize):

• NetworkProcess/cache/NetworkCache.h:

11:41 AM Changeset in webkit [212964] by matthew_hanson@apple.com

• 19 edits in branches/safari-603.1.30.1-branch

Roll out r212459 via r212537. rdar://problem/30699480

11:41 AM Changeset in webkit [212963] by matthew_hanson@apple.com

• 5 edits in branches/safari-603.1.30.1-branch/Source

Versioning.

11:36 AM Changeset in webkit [212962] by sbarati@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Remove inaccurate copy-paste comment from r212939.

• dfg/DFGOperations.cpp:

11:24 AM Changeset in webkit [212961] by Chris Dumez

• 4 edits in trunk/Source/WebCore

[Mac] Report domains using abnormally high memory usage via enhanced privacy logging
​https://bugs.webkit.org/show_bug.cgi?id=168797
<rdar://problem/29964017>

Reviewed by Andreas Kling.

Report domains using abnormally high memory usage (> 2GB) via enhanced privacy
logging on Mac.

• page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::domainCausingJetsamKey):

• page/DiagnosticLoggingKeys.h:
• page/PerformanceMonitor.cpp:

(WebCore::reportPageOverPostLoadResourceThreshold):
(WebCore::PerformanceMonitor::measurePostLoadCPUUsage):
(WebCore::PerformanceMonitor::measurePostLoadMemoryUsage):
(WebCore::reportPageOverPostLoadCPUUsageThreshold): Deleted.

9:50 AM Changeset in webkit [212960] by matthew_hanson@apple.com

• 5 edits in branches/safari-603.1.30.0-branch/Source

Versioning.

9:10 AM Changeset in webkit [212959] by matthew_hanson@apple.com

• 5 edits in branches/safari-603.1.30.4-branch/Source

Versioning.

9:07 AM Changeset in webkit [212958] by matthew_hanson@apple.com

• 2 edits in branches/safari-603.1.30.4-branch/Source/WebCore

Merge r212822. rdar://problem/30682429

9:02 AM Changeset in webkit [212957] by matthew_hanson@apple.com

• 2 edits in branches/safari-603.1.30.0-branch/Source/JavaScriptCore

rdar://problem/30675867

8:59 AM Changeset in webkit [212956]

• in /

This is an empty revision for padding.

8:59 AM Changeset in webkit [212955] by matthew_hanson@apple.com

• 5 edits in branches/safari-603.1.30.0-branch/Source

Versioning.

8:57 AM Changeset in webkit [212954] by matthew_hanson@apple.com

• 5 edits in branches/safari-603.1.30.1-branch/Source

Versioning.

8:45 AM Changeset in webkit [212953] by achristensen@apple.com

• 11 edits in trunk

.. should not remove windows drive letters in paths of file URLs
​https://bugs.webkit.org/show_bug.cgi?id=168824

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

• web-platform-tests/url/a-element-expected.txt:
• web-platform-tests/url/a-element-xhtml-expected.txt:
• web-platform-tests/url/url-constructor-expected.txt:

Source/WebCore:

It's specified in ​https://url.spec.whatwg.org/#shorten-a-urls-path and helps behavior for browsers on Windows.
It can't hurt to pass a few more web platform tests, though.

• platform/URLParser.cpp:

(WebCore::URLParser::copyURLPartsUntil):
(WebCore::URLParser::shouldPopPath):
(WebCore::URLParser::popPath):
(WebCore::URLParser::parse):

• platform/URLParser.h:

LayoutTests:

• fast/url/file-expected.txt:
• fast/url/file-http-base-expected.txt:
• fast/url/relative-win-expected.txt:

5:17 AM Changeset in webkit [212952] by Antti Koivisto

• 1 edit
  3 deletes in trunk/LayoutTests

Reverting ​https://trac.webkit.org/r212951, landing this doesn't actually work due to Git infrastucture.

• http/tests/cache/disk-cache/resources/shattered-1-nocollision.pdf: Removed.
• http/tests/cache/disk-cache/resources/shattered-1.pdf: Removed.
• http/tests/cache/disk-cache/resources/shattered-2-nocollision.pdf: Removed.

4:45 AM Changeset in webkit [212951] by Antti Koivisto

• 1 edit
  5 adds in trunk/LayoutTests

Add a test verifying cache deduplication is not sensitive to SHA1 collision attack
​https://bugs.webkit.org/show_bug.cgi?id=168774

Reviewed by Sam Weinig.

We use SHA1 for deduplicating disk cache resources. Since a real world SHA1 collision was demonstrated
recently (​http://shattered.io/) we can add a test that shows it can't be used for cache poisoning.

There are two protections in the cache code that both individually stop this type of attack:

• When deduplicating the data is verified to be equal by a bytewise comparison.
• SHA1 computations include random salt unique to cache instance.

Commenting out both protections is needed to make this test fail.

• http/tests/cache/disk-cache/resources/shattered-1-nocollision.pdf: Added.
• http/tests/cache/disk-cache/resources/shattered-1.pdf: Added.
• http/tests/cache/disk-cache/resources/shattered-2-nocollision.pdf: Added.
• http/tests/cache/disk-cache/resources/shattered-2.pdf: Added.

Files shattered-1.pdf and shattered-2.pdf differ visually but have the same SHA1.
The nocollision versions for the ref have the same pixels but don't collide.

• http/tests/cache/disk-cache/shattered-deduplication-expected.html: Added.
• http/tests/cache/disk-cache/shattered-deduplication.html: Added.

1:34 AM Changeset in webkit [212950] by Csaba Osztrogonác

• 2 edits in trunk/Source/WebCore

[Mac][cmake] Unreviewed buildfix after r212736.

• PlatformMac.cmake:

1:19 AM Changeset in webkit [212949] by wilander@apple.com

• 29 edits
  3 copies
  19 adds in trunk

Resource Load Statistics: Add alternate classification method
​https://bugs.webkit.org/show_bug.cgi?id=168347
<rdar://problem/30352793>
<rdar://problem/30646710>
<rdar://problem/30660708>

Reviewed by Alex Christensen.

Source/WebCore:

This patch only adds test infrastructure in WebCore.

Tests: http/tests/loading/resourceLoadStatistics/classify-as-non-prevalent-based-on-mixed-statistics.html

http/tests/loading/resourceLoadStatistics/classify-as-non-prevalent-based-on-sub-frame-under-top-frame-origins.html
http/tests/loading/resourceLoadStatistics/classify-as-non-prevalent-based-on-subresource-under-top-frame-origins.html
http/tests/loading/resourceLoadStatistics/classify-as-non-prevalent-based-on-subresource-unique-redirects-to.html
http/tests/loading/resourceLoadStatistics/classify-as-prevalent-based-on-mixed-statistics.html
http/tests/loading/resourceLoadStatistics/classify-as-prevalent-based-on-sub-frame-under-top-frame-origins.html
http/tests/loading/resourceLoadStatistics/classify-as-prevalent-based-on-subresource-under-top-frame-origins.html
http/tests/loading/resourceLoadStatistics/classify-as-prevalent-based-on-subresource-unique-redirects-to.html

• loader/ResourceLoadObserver.cpp:

(WebCore::ResourceLoadObserver::setSubframeUnderTopFrameOrigin):
(WebCore::ResourceLoadObserver::setSubresourceUnderTopFrameOrigin):
(WebCore::ResourceLoadObserver::setSubresourceUniqueRedirectTo):

• loader/ResourceLoadObserver.h:

Source/WebKit2:

This patch adds a CorePrediction-based classifier to the WebResourceLoadStatisticsStore.
The CorePrediction framework is introduced as a dependency for macOS and iOS. The patch
also adds functions to support layout tests of the feature.

• Platform/Logging.h:

Added channel ResourceLoadStatistics.

• Platform/classifier/ResourceLoadStatisticsClassifier.h: Added.

Pulls in the Cocoa-specific classifier for Cocoa-based platforms.

(WebKit::ResourceLoadStatisticsClassifier::ResourceLoadStatisticsClassifier):

• Platform/classifier/ResourceLoadStatisticsClassifierBase.cpp: Added.

(WebKit::ResourceLoadStatisticsClassifierBase::hasPrevalentResourceCharacteristics):

Shared classifier logic.

(WebKit::ResourceLoadStatisticsClassifierBase::classifyWithVectorThreshold):

Fallback classifier for when we don't have CorePrediction.

• Platform/classifier/ResourceLoadStatisticsClassifierBase.h: Added.

(WebKit::ResourceLoadStatisticsClassifierBase::ResourceLoadStatisticsClassifierBase):
(WebKit::ResourceLoadStatisticsClassifierBase::~ResourceLoadStatisticsClassifierBase):

• Platform/classifier/cocoa/CorePredictionSoftLink.h: Added.

Soft links to CorePrediction and the two functions we use from it.

• Platform/classifier/cocoa/ResourceLoadStatisticsClassifierCocoa.cpp: Added.

(WebKit::ResourceLoadStatisticsClassifier::classify):
(WebKit::ResourceLoadStatisticsClassifier::storagePath):
(WebKit::ResourceLoadStatisticsClassifier::shouldUseCorePredictionAndHaveModelLoaded):
(WebKit::ResourceLoadStatisticsClassifier::singletonPredictionModel):

The new classifier for Cocoa platforms.

• Platform/classifier/cocoa/ResourceLoadStatisticsClassifierCocoa.h: Added.
• PlatformGTK.cmake:

Added Platform/classifier directory and ResourceLoadStatisticsClassifierBase.cpp.

• PlatformMac.cmake:

Added Platform/classifier and Platform/classifier/cocoa directories, and
source files ResourceLoadStatisticsClassifierBase.cpp and
ResourceLoadStatisticsClassifierCocoa.cpp

• Resources/ResourceLoadStatistics/corePrediction_model: Added.

Model file to load into CorePrediction.

• UIProcess/API/C/WKResourceLoadStatisticsManager.cpp:

(WKResourceLoadStatisticsManagerSetSubframeUnderTopFrameOrigin):
(WKResourceLoadStatisticsManagerSetSubresourceUnderTopFrameOrigin):
(WKResourceLoadStatisticsManagerSetSubresourceUniqueRedirectTo):

Test infrastructure.

• UIProcess/API/C/WKResourceLoadStatisticsManager.h:
• UIProcess/WebResourceLoadStatisticsManager.cpp:

(WebKit::WebResourceLoadStatisticsManager::setSubframeUnderTopFrameOrigin):
(WebKit::WebResourceLoadStatisticsManager::setSubresourceUnderTopFrameOrigin):
(WebKit::WebResourceLoadStatisticsManager::setSubresourceUniqueRedirectTo):

Test infrastructure.

• UIProcess/WebResourceLoadStatisticsManager.h:
• UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore):

Renamed m_storagePath to m_statisticsStoragePath for clarity.

(WebKit::WebResourceLoadStatisticsStore::classifyResource):

Now calls the classifier through its ResourceLoadStatisticsClassifier
member variable.

(WebKit::WebResourceLoadStatisticsStore::persistentStoragePath):

Renamed m_storagePath to m_statisticsStoragePath for clarity.

(WebKit::WebResourceLoadStatisticsStore::writeEncoderToDisk):

Renamed m_storagePath to m_statisticsStoragePath for clarity.

(WebKit::WebResourceLoadStatisticsStore::hasPrevalentResourceCharacteristics): Deleted.

• UIProcess/WebResourceLoadStatisticsStore.h:
• WebKit2.xcodeproj/project.pbxproj:

Added the new classifier source files under Platform/classifier and the
corePrediction_model file under Resources/ResourceLoadStatistics.

Tools:

Added three testRunner functions to facilitate layout tests:

• setStatisticsSubframeUnderTopFrameOrigin()
• setStatisticsSubresourceUnderTopFrameOrigin()
• setStatisticsSubresourceUniqueRedirectTo()

• WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
• WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
(WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
(WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):

• WebKitTestRunner/InjectedBundle/TestRunner.h:
• WebKitTestRunner/TestController.cpp:

(WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
(WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
(WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):

• WebKitTestRunner/TestController.h:
• WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

• http/tests/loading/resourceLoadStatistics/classify-as-non-prevalent-based-on-mixed-statistics-expected.txt: Added.
• http/tests/loading/resourceLoadStatistics/classify-as-non-prevalent-based-on-mixed-statistics.html: Added.
• http/tests/loading/resourceLoadStatistics/classify-as-non-prevalent-based-on-sub-frame-under-top-frame-origins-expected.txt: Added.
• http/tests/loading/resourceLoadStatistics/classify-as-non-prevalent-based-on-sub-frame-under-top-frame-origins.html: Added.
• http/tests/loading/resourceLoadStatistics/classify-as-non-prevalent-based-on-subresource-under-top-frame-origins-expected.txt: Added.
• http/tests/loading/resourceLoadStatistics/classify-as-non-prevalent-based-on-subresource-under-top-frame-origins.html: Added.
• http/tests/loading/resourceLoadStatistics/classify-as-non-prevalent-based-on-subresource-unique-redirects-to-expected.txt: Added.
• http/tests/loading/resourceLoadStatistics/classify-as-non-prevalent-based-on-subresource-unique-redirects-to.html: Added.
• http/tests/loading/resourceLoadStatistics/classify-as-prevalent-based-on-mixed-statistics-expected.txt: Added.
• http/tests/loading/resourceLoadStatistics/classify-as-prevalent-based-on-mixed-statistics.html: Added.
• http/tests/loading/resourceLoadStatistics/classify-as-prevalent-based-on-sub-frame-under-top-frame-origins-expected.txt: Added.
• http/tests/loading/resourceLoadStatistics/classify-as-prevalent-based-on-sub-frame-under-top-frame-origins.html: Added.
• http/tests/loading/resourceLoadStatistics/classify-as-prevalent-based-on-subresource-under-top-frame-origins-expected.txt: Added.
• http/tests/loading/resourceLoadStatistics/classify-as-prevalent-based-on-subresource-under-top-frame-origins.html: Added.
• http/tests/loading/resourceLoadStatistics/classify-as-prevalent-based-on-subresource-unique-redirects-to-expected.txt: Added.
• http/tests/loading/resourceLoadStatistics/classify-as-prevalent-based-on-subresource-unique-redirects-to.html: Added.
• http/tests/loading/resourceLoadStatistics/non-prevalent-resource-with-user-interaction.html:

Added a call to internals.setResourceLoadStatisticsEnabled(false) before testRunner.notifyDone().

• http/tests/loading/resourceLoadStatistics/non-prevalent-resource-without-user-interaction.html:

Added a call to internals.setResourceLoadStatisticsEnabled(false) before testRunner.notifyDone().

• http/tests/loading/resourceLoadStatistics/prevalent-resource-with-user-interaction-timeout.html:

Added a call to internals.setResourceLoadStatisticsEnabled(false) before testRunner.notifyDone().

• http/tests/loading/resourceLoadStatistics/prevalent-resource-with-user-interaction.html:

Added a call to internals.setResourceLoadStatisticsEnabled(false) before testRunner.notifyDone().

• http/tests/loading/resourceLoadStatistics/prevalent-resource-without-user-interaction.html:

Added a call to internals.setResourceLoadStatisticsEnabled(false) before testRunner.notifyDone().

• platform/gtk/TestExpectations:

The whole http/tests/loading/resourceLoadStatistics marked as crashing based on
Carlos Garcia Campos's assessment in ​https://bugs.webkit.org/show_bug.cgi?id=168171.

• platform/wk2/TestExpectations:

The above tests are only valid for WebKit2. Marked as [ Pass ].

Feb 23, 2017:

11:38 PM Changeset in webkit [212948] by commit-queue@webkit.org

• 10 edits in trunk

[Modern Media Controls] No controls are shown for <audio preload="none">
​https://bugs.webkit.org/show_bug.cgi?id=168800
<rdar://problem/30652142>

Patch by Antoine Quint <Antoine Quint> on 2017-02-23
Reviewed by Eric Carlson.

Source/WebCore:

A media element's currentSrc property will only be set when data has started
to load. In the case where preload="none" is used, regardless of whether a
source is specified, currentSrc would be the empty string and we wouldn't
show controls at all. Identifying whether a source is specified is a little
tricky because it could be specified in a variety of ways and dynamically
as well.

So instead we optimistically show controls always provided the "controls"
attribute is set.

• Modules/modern-media-controls/media/controls-visibility-support.js:

(ControlsVisibilitySupport.prototype._updateControls):
(ControlsVisibilitySupport):

• Modules/modern-media-controls/media/start-support.js:

(StartSupport.prototype._shouldShowStartButton):
(StartSupport):

LayoutTests:

Update tests to account for the new rules for controls visibility and force an older test
not to use modern media controls since we now show the play button and there is a bug
that prevents the play button from being positioned correctly when inside a region
(see ​https://bugs.webkit.org/show_bug.cgi?id=168823).

• fast/regions/inline-block-inside-anonymous-overflow-with-covered-controls-expected.html
• fast/regions/inline-block-inside-anonymous-overflow-with-covered-controls.html
• media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-on-audio-expected.txt:
• media/modern-media-controls/controls-visibility-support/controls-visibility-support-controls-on-audio.html:
• media/modern-media-controls/start-support/start-support-no-source-expected.txt:
• media/modern-media-controls/start-support/start-support-no-source.html:

11:17 PM Changeset in webkit [212947] by Dewei Zhu

• 8 edits in trunk/Websites/perf.webkit.org

Rename 'commit_parent' in 'commits' table to 'commit_previous_commit'.
​https://bugs.webkit.org/show_bug.cgi?id=168816

Reviewed by Ryosuke Niwa.

Rename 'commit_parent' to avoid ambiguity in the coming feature.
For exisiting database, run

"ALTER TABLE commits RENAME commit_parent TO commit_previous_commit;"

to update the database.

• init-database.sql:
• public/api/report-commits.php:
• public/include/commit-log-fetcher.php:
• server-tests/api-commits.js:

(then):

• server-tests/api-report-commits-tests.js:

(then):

• tools/sync-commits.py:

(main):
(Repository.fetch_commits_and_submit):
(GitRepository._revision_from_tokens):

• unit-tests/analysis-task-tests.js:

(sampleAnalysisTask):

10:57 PM Changeset in webkit [212946] by rniwa@webkit.org

• 7 edits in trunk/Websites/perf.webkit.org

New sampling algorithm shows very few points when zoomed out
​https://bugs.webkit.org/show_bug.cgi?id=168813

Reviewed by Saam Barati.

When a chart is zoomed out to a large time interval, the new sampling algorithm introduced in r212853 can
hide most of the data points because the difference between the preceding point's time and the succeeding
point's time of most points will be below the threshold we computed.

Instead, rank each data point based on the aforementioned time interval difference, and pick the first M data
points when M data points are to be shown.

This makes the new algorithm behave like our old algorithm while keeping it stable still. Note that this
algorithm still biases data points without a close neighboring point but this seems to work out in practice
because such a point tends to be an important sample anyway, and we don't have a lot of space between
data points since we aim to show about one point per pixel.

• browser-tests/index.html:

(CanvasTest.canvasContainsColor): Extracted from one of the test cases and generalized. Returns true when
the specified region of the canvas contains a specified color (alpha is optional).

• browser-tests/time-series-chart-tests.js: Added a test case for sampling. It checks that sampling happens

and that we always show some data point even when zoomed out to a large time interval.
(createChartWithSampleCluster):

• public/v3/components/interactive-time-series-chart.js:

(InteractiveTimeSeriesChart.prototype._sampleTimeSeries):

• public/v3/components/time-series-chart.js:

(TimeSeriesChart.prototype._ensureSampledTimeSeries): M, the number of data points we pick must be computed
based on the width of data points we're about to draw constrained by the canvas size. e.g. when the canvas
is only half filled, we shouldn't be showing two points per pixel in the filled region.
(TimeSeriesChart.prototype._sampleTimeSeries): Refined the algorithm. First, compute the time difference or
the rank for each N data points. Sort those ranks in descending order (in the order we prefer), and include
all data points above the M-th rank in the sample.
(TimeSeriesChart.prototype.computeTimeGrid): Revert the inadvertent change in r212935.

• public/v3/models/time-series.js:

(TimeSeriesView.prototype.filter): Fixed a bug that the indices passed onto the callback were shifted by the
starting index.

• unit-tests/time-series-tests.js: Added a test case to ensure callbacks are called with correct data points

and indices.

10:52 PM Changeset in webkit [212945] by Joseph Pecoraro

• 7 edits in trunk

[Resource Timing] Add Experimental Feature Flag
​https://bugs.webkit.org/show_bug.cgi?id=167147

Reviewed by Ryosuke Niwa.

Source/WebKit2:

• Shared/WebPreferencesDefinitions.h:

Move ResourceTiming to experimental section.
Disable it for El Capitan due to known issues.

Tools:

• DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures):
(resetWebPreferencesToConsistentValues):

• DumpRenderTree/win/DumpRenderTree.cpp:

(enableExperimentalFeatures):
(resetWebPreferencesToConsistentValues):
Put experimental flags in the experimental section.

Websites/webkit.org:

• experimental-features.html:

Test for Resource Timing.

10:51 PM Changeset in webkit [212944] by Joseph Pecoraro

• 96 edits
  2 moves
  13 adds in trunk

[Resource Timing] Gather timing information with reliable responseEnd time
​https://bugs.webkit.org/show_bug.cgi?id=168351

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/fetch/api/redirect/redirect-count-cross-origin-expected.txt:
• web-platform-tests/fetch/api/redirect/redirect-count-cross-origin-worker-expected.txt:
• web-platform-tests/fetch/api/redirect/redirect-count-expected.txt:
• web-platform-tests/fetch/api/redirect/redirect-count-worker-expected.txt:
• web-platform-tests/fetch/api/redirect/redirect-location-expected.txt:
• web-platform-tests/fetch/api/redirect/redirect-location-worker-expected.txt:

New behavior for too many redirects caused by <rdar://problem/30610988>.

• web-platform-tests/resource-timing/rt-nextHopProtocol-expected.txt: Added.
• web-platform-tests/resource-timing/rt-nextHopProtocol.html: Added.
• web-platform-tests/resource-timing/rt-nextHopProtocol.js: Added.
• web-platform-tests/resource-timing/rt-nextHopProtocol.worker-expected.txt: Added.
• web-platform-tests/resource-timing/rt-nextHopProtocol.worker.html: Added.
• web-platform-tests/resource-timing/rt-nextHopProtocol.worker.js: Added.

New tests specific to just checking the nextHopProtocol property with
a non-cached resource to avoid flakeyness.

Source/WebCore:

This patch replaces the unused double finishTime in ResourceLoader's
didFinishLoad with a complete WebCore::NetworkLoadMetrics object. This
allows the NetworkProcess to give complete timing information, and more
final metrics about the load, to WebCore. Currently this is only used
by ResourceTiming, but it will soon be used by Web Inspector as well.
We may also end up extending this to the didFail path as well, since it
is possible that we have some metrics for load failures.

At the same time we want to start moving away from the legacy path that
populated a subset of this information in ResourceResponse's NetworkLoadMetrics.
It doesn't make sense to store this information on the ResourceResponse
for a few reasons: We don't want to store the metrics in our Network Cache and
not all of the load timing metrics have been populated yet (responseEnd).
In an effort to move off of this data we've renamed the accessor to
"deprecatedNetworkLoadMetrics". There are a few remaining clients
(ResourceHandle, PerformanceTiming, InspectorNetworkAgent) which can be
migrated separately from this patch.

Having both the legacy and new code paths adds a little bit of complexity.
One advantage of the new path is that the complete load timing data
(fetchStart -> dns -> connect -> request -> response -> responseEnd) can
be packaged together. The legacy path could not include a responseEnd, so
WebCore faked that value with its own timestamp. Having the fake responseEnd
caused issues as timestamps / clocks are different between processes. In order
for PerformanceResponseTiming to know whether or not the NetworkLoadMetrics
has the complete network timing metrics it checks isComplete(). If true
it knows it can use the responseEnd time from NetworkLoadMetrics, otherwise
it must fallback to the legacy value from LoadTiming. Once all of the
deprecatedNetworkLoadMetrics clients go away, we should always have the
complete data and this can be eliminated.

Tests: imported/w3c/web-platform-tests/resource-timing/rt-nextHopProtocol.html

imported/w3c/web-platform-tests/resource-timing/rt-nextHopProtocol.worker.html

• PlatformMac.cmake:
• WebCore.xcodeproj/project.pbxproj:

Rename NetworkLoadTiming -> NetworkLoadMetrics.

• page/PerformanceResourceTiming.cpp:

(WebCore::entryStartTime):
(WebCore::entryEndTime):
(WebCore::PerformanceResourceTiming::PerformanceResourceTiming):
(WebCore::PerformanceResourceTiming::nextHopProtocol):
(WebCore::PerformanceResourceTiming::domainLookupStart):
(WebCore::PerformanceResourceTiming::domainLookupEnd):
(WebCore::PerformanceResourceTiming::connectStart):
(WebCore::PerformanceResourceTiming::connectEnd):
(WebCore::PerformanceResourceTiming::secureConnectionStart):
(WebCore::PerformanceResourceTiming::requestStart):
(WebCore::PerformanceResourceTiming::responseStart):
(WebCore::PerformanceResourceTiming::responseEnd):
(WebCore::PerformanceResourceTiming::networkLoadTimeToDOMHighResTimeStamp):

• page/PerformanceResourceTiming.h:

Mostly just updating names and types. This does however need to get the
correct endTime based on whether the NetworkLoadMetrics are complete
(meaning includes responseEnd) or not (legacy, use LoadTiming value).

• page/PerformanceResourceTiming.idl:

Add nextHopProtocol.

• page/PerformanceTiming.cpp:

(WebCore::PerformanceTiming::domainLookupStart):
(WebCore::PerformanceTiming::domainLookupEnd):
(WebCore::PerformanceTiming::connectStart):
(WebCore::PerformanceTiming::connectEnd):
(WebCore::PerformanceTiming::secureConnectionStart):
(WebCore::PerformanceTiming::requestStart):
(WebCore::PerformanceTiming::responseStart):
(WebCore::PerformanceTiming::resourceLoadTimeRelativeToFetchStart):

• page/PerformanceTiming.h:

Navigation Timing values still uses the NetworkLoadTiming values stored on
the DocumentLoader. This should be moved off of the deprecated path separately.

• platform/network/NetworkLoadMetrics.h: Renamed from Source/WebCore/platform/network/NetworkLoadTiming.h.

(WebCore::NetworkLoadMetrics::NetworkLoadMetrics):
(WebCore::NetworkLoadMetrics::isolatedCopy):
(WebCore::NetworkLoadMetrics::reset):
(WebCore::NetworkLoadMetrics::operator==):
(WebCore::NetworkLoadMetrics::operator!=):
(WebCore::NetworkLoadMetrics::isComplete):
(WebCore::NetworkLoadMetrics::markComplete):
(WebCore::NetworkLoadMetrics::encode):
(WebCore::NetworkLoadMetrics::decode):
Re-introduce a reset() method (for NetworkLoadSoup to reset between redirects).
Add protocolName and "complete" boolean.

• platform/network/cocoa/NetworkLoadMetrics.mm: Renamed from Source/WebCore/platform/network/cocoa/NetworkLoadTiming.mm.

(WebCore::timingValue):
(WebCore::copyTimingData):
(WebCore::setCollectsTimingData):
Use this opportunity to convert NetworkLoadTiming timestamps to WTF::Seconds.
Since we already have to modify all the clients this moves us to use the more
strongly typed units that are less ambiguous then "double". The rest of the
Performance API has already moved to these units.

• inspector/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::buildObjectForTiming):
(WebCore::InspectorNetworkAgent::buildObjectForResourceResponse):
(WebCore::InspectorNetworkAgent::didFinishLoading):

• inspector/InspectorNetworkAgent.h:

Inspector was the only client of the finishTime, and since the value was
erratically coming from clients in different ways it was almost certainly
inaccurate. Simplify this in preparation for using NetworkLoadMetrics.

• Modules/fetch/FetchLoader.cpp:

(WebCore::FetchLoader::didFinishLoading):

• Modules/fetch/FetchLoader.h:
• fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::didFinishLoading):

• fileapi/FileReaderLoader.h:
• html/MediaFragmentURIParser.cpp:

(WebCore::MediaFragmentURIParser::parseNPTTime):

• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didFinishLoadingImpl):

• inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didFinishLoading):

• loader/CrossOriginPreflightChecker.cpp:

(WebCore::CrossOriginPreflightChecker::validatePreflightResponse):

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::notifyFinished):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::continueAfterContentPolicy):
(WebCore::DocumentLoader::maybeLoadEmpty):

• loader/DocumentLoader.h:
• loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::didReceiveResponse):
(WebCore::DocumentThreadableLoader::notifyFinished):
(WebCore::DocumentThreadableLoader::didFinishLoading):
(WebCore::DocumentThreadableLoader::loadRequest):

• loader/DocumentThreadableLoader.h:
• loader/NetscapePlugInStreamLoader.cpp:

(WebCore::NetscapePlugInStreamLoader::didFinishLoading):

• loader/NetscapePlugInStreamLoader.h:
• loader/ResourceLoadNotifier.cpp:

(WebCore::ResourceLoadNotifier::didFinishLoad):
(WebCore::ResourceLoadNotifier::dispatchDidFinishLoading):
(WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages):

• loader/ResourceLoadNotifier.h:
• loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::deliverResponseAndData):
(WebCore::ResourceLoader::loadDataURL):
(WebCore::ResourceLoader::didFinishLoading):
(WebCore::ResourceLoader::didFinishLoadingOnePart):

• loader/ResourceLoader.h:
• loader/ResourceTiming.cpp:

(WebCore::ResourceTiming::fromLoad):
(WebCore::ResourceTiming::fromSynchronousLoad):
(WebCore::ResourceTiming::ResourceTiming):
(WebCore::ResourceTiming::isolatedCopy):

• loader/ResourceTiming.h:

(WebCore::ResourceTiming::networkLoadMetrics):
(WebCore::ResourceTiming::ResourceTiming):
(WebCore::ResourceTiming::networkLoadTiming): Deleted.

• loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::SubresourceLoader):
(WebCore::SubresourceLoader::willSendRequestInternal):
(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::didFinishLoading):
(WebCore::SubresourceLoader::reportResourceTiming):

• loader/SubresourceLoader.h:
• loader/ThreadableLoaderClient.h:

(WebCore::ThreadableLoaderClient::didFinishLoading):

• loader/ThreadableLoaderClientWrapper.h:

(WebCore::ThreadableLoaderClientWrapper::didFinishLoading):

• loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):

• loader/WorkerThreadableLoader.h:
• loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didFinishLoading):

• loader/appcache/ApplicationCacheGroup.h:
• loader/cache/CachedResource.h:

(WebCore::CachedResource::setLoadFinishTime):

• loader/ios/QuickLook.mm:

(-[WebPreviewLoader connectionDidFinishLoading:]):

• page/EventSource.cpp:

(WebCore::EventSource::didFinishLoading):

• page/EventSource.h:
• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(ResourceHandleStreamingClient::didFinishLoading):

• platform/network/BlobResourceHandle.cpp:

(WebCore::doNotifyFinish):

• platform/network/PingHandle.h:
• platform/network/ResourceHandle.h:
• platform/network/ResourceHandleClient.h:

(WebCore::ResourceHandleClient::didFinishLoading):

• platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::crossThreadData):
(WebCore::ResourceResponseBase::fromCrossThreadData):
(WebCore::ResourceResponseBase::compare):

• platform/network/ResourceResponseBase.h:

(WebCore::ResourceResponseBase::deprecatedNetworkLoadMetrics):
(WebCore::ResourceResponseBase::encode):
(WebCore::ResourceResponseBase::decode):
(WebCore::ResourceResponseBase::networkLoadTiming): Deleted.

• platform/network/SynchronousLoaderClient.cpp:

(WebCore::SynchronousLoaderClient::didFinishLoading):

• platform/network/SynchronousLoaderClient.h:
• platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:

(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didFinishLoading):

• platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp:

(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveResponse):
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didFinishLoading):

• platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::WebCoreSynchronousLoader::didFinishLoading):

• platform/network/curl/ResourceHandleManager.cpp:

(WebCore::calculateWebTimingInformations):
(WebCore::ResourceHandleManager::downloadTimerCallback):
(WebCore::handleDataURL):
(WebCore::milisecondsSinceRequest): Deleted.

• platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::getConnectionTimingData):

• platform/network/mac/WebCoreResourceHandleAsDelegate.mm:

(-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
(-[WebCoreResourceHandleAsDelegate connectionDidFinishLoading:]):

• platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:

(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):
(-[WebCoreResourceHandleAsOperationQueueDelegate connectionDidFinishLoading:]):

• platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::restartedCallback):
(WebCore::nextMultipartResponsePartCallback):
(WebCore::sendRequestCallback):
(WebCore::ResourceHandle::didStartRequest):
(WebCore::networkEventCallback):
(WebCore::ResourceHandle::sendPendingRequest):
(WebCore::readCallback):
(WebCore::milisecondsSinceRequest): Deleted.

• workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::didFinishLoading):

• workers/WorkerScriptLoader.h:
• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::didFinishLoading):

• xml/XMLHttpRequest.h:

Eliminate the unused finishTime double.

Source/WebKit2:

Change from an unused double finishTime to a complete WebCore::NetworkLoadMetrics
object in the didFinishLoad ResourceLoader path. We may also extend this in the
didFail path later on. This allows the NetworkProcess to give complete timing
information, and more final metrics about the load, to WebCore.

• NetworkProcess/NetworkDataTask.h:

(WebKit::NetworkDataTaskClient::didCompleteWithError):
Give the NetworkDataTaskClient a basic didCompleteWithError for a completion
without metrics. For loads that complete with an error, or haven't populated
any metrics, this will pass empty metrics onward.

• NetworkProcess/Downloads/BlobDownloadClient.cpp:

(WebKit::BlobDownloadClient::didFinishLoading):

• NetworkProcess/Downloads/BlobDownloadClient.h:
• NetworkProcess/Downloads/PendingDownload.h:
• NetworkProcess/PingLoad.h:
• NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:

(WebKit::NetworkCache::SpeculativeLoad::didFinishLoading):

• NetworkProcess/cache/NetworkCacheSpeculativeLoad.h:
• NetworkProcess/NetworkDataTaskBlob.cpp:

(WebKit::NetworkDataTaskBlob::didFail):

• NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::continueWillSendRequest):
(WebKit::NetworkLoad::didCompleteWithError):
(WebKit::NetworkLoad::didFinishLoading):

• NetworkProcess/NetworkLoad.h:
• NetworkProcess/NetworkLoadClient.h:
• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didFinishLoading):
(WebKit::NetworkResourceLoader::sendResultForCacheEntry):

• NetworkProcess/NetworkResourceLoader.h:
• WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::didFinishResourceLoad):
(WebKit::WebResourceLoader::didReceiveResource):

• WebProcess/Network/WebResourceLoader.h:
• WebProcess/Network/WebResourceLoader.messages.in:

Change didFinishLoad paths to take a NetworkLoadMetrics object instead of finishTime.
Change didCompleteWithError pathes to include a NetworkLoadMetrics object instead of finishTime.

• NetworkProcess/cocoa/NetworkDataTaskCocoa.h:
• NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::didCompleteWithError):
Own a NetworkLoadTiming that will be populated with the load.

• NetworkProcess/cocoa/NetworkSessionCocoa.h:
• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:didCompleteWithError:]):
(-[WKNetworkSessionDelegate URLSession:task:didFinishCollectingMetrics:]):
(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
Populate NetworkLoadMetrics in the didFinishCollectingMetrics NSURLSessionTaskDelegate method.

• NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::NetworkDataTaskSoup):
(WebKit::NetworkDataTaskSoup::timeoutFired):
(WebKit::NetworkDataTaskSoup::didSendRequest):
(WebKit::NetworkDataTaskSoup::dispatchDidReceiveResponse):
(WebKit::NetworkDataTaskSoup::dispatchDidCompleteWithError):
(WebKit::NetworkDataTaskSoup::tlsErrorsChanged):
(WebKit::NetworkDataTaskSoup::continueHTTPRedirection):
(WebKit::NetworkDataTaskSoup::didFinishRead):
(WebKit::NetworkDataTaskSoup::didFinishRequestNextPart):
(WebKit::NetworkDataTaskSoup::didFailDownload):
(WebKit::NetworkDataTaskSoup::didFail):
(WebKit::NetworkDataTaskSoup::networkEvent):
(WebKit::NetworkDataTaskSoup::didStartRequest):
(WebKit::NetworkDataTaskSoup::didRestart):

• NetworkProcess/soup/NetworkDataTaskSoup.h:

Instead of populating the NetworkLoadMetrics on the ResourceResponse, populate
a member variable during the entire load and dispatch didFinishCollectingMetrics
right before didCompleteLoadWithError.

Source/WTF:

• wtf/persistence/Coders.h:

(WTF::Persistence::Coder<Seconds>::encode):
(WTF::Persistence::Coder<Seconds>::decode):

LayoutTests:

• TestExpectations:

Now that nextHopProtocol is available on Mac mark the test as flakey
because the value can be set or not depending on whether or not the
resource was loaded from a cache.

• platform/ios-simulator/TestExpectations:
• platform/gtk/TestExpectations:
• platform/mac/TestExpectations:
• platform/win/TestExpectations:

Mark nextHopProtocol tests as expected to fail on ports that do not
yet support those values. Mark redirect tests as failing on ports
that encounter the CFNetwork issue causing unexpected callbacks.

• performance-api/resource-timing-apis-expected.txt:
• performance-api/resources/resource-timing-api.js:

Progressions.

• platform/mac-elcapitan/imported/w3c/web-platform-tests/resource-timing/test_resource_timing-expected.txt: Added.
• platform/mac/imported/w3c/web-platform-tests/resource-timing/test_resource_timing-expected.txt: Added.

Expected passing values on mac, except el capitan where this new resource timing data is unavailable.

10:40 PM Changeset in webkit [212943] by commit-queue@webkit.org

• 17 edits
  2 adds in trunk

[Modern Media Controls] Controls overflow when media element has border or padding
​https://bugs.webkit.org/show_bug.cgi?id=168818
<rdar://problem/30689780>

Patch by Antoine Quint <Antoine Quint> on 2017-02-23
Reviewed by Jon Lee.

Source/WebCore:

We used to query the media element's layout size to compute the size of the media controls,
which would account for border and padding. Instead, we should use the size of the container,
at the root of the ShadowRoot, which will always match the size of the media.

Test: media/modern-media-controls/media-controller/media-controller-controls-sizing-with-border-and-padding.html

• Modules/modern-media-controls/controls/media-controls.css:

(.media-controls-container,):

• Modules/modern-media-controls/media/media-controller.js:

(MediaController.prototype._updateControlsSize):
(MediaController.prototype._controlsWidth):

LayoutTests:

Updating a host of tests to ensure they have an explicitly host and add a new test
to check that we have the correct size with borders and padding.

• media/modern-media-controls/fullscreen-support/fullscreen-support-click.html:
• media/modern-media-controls/media-controller/media-controller-compact-expected.txt:
• media/modern-media-controls/media-controller/media-controller-compact.html:
• media/modern-media-controls/media-controller/media-controller-controls-sizing-with-border-and-padding-expected.txt: Added.
• media/modern-media-controls/media-controller/media-controller-controls-sizing-with-border-and-padding.html: Added.
• media/modern-media-controls/media-controller/media-controller-reduced-padding-expected.txt:
• media/modern-media-controls/media-controller/media-controller-reduced-padding.html:
• media/modern-media-controls/media-controller/media-controller-tight-padding-expected.txt:
• media/modern-media-controls/media-controller/media-controller-tight-padding.html:
• media/modern-media-controls/pip-support/pip-support-click.html:
• media/modern-media-controls/scrubber-support/scrubber-support-click.html:
• media/modern-media-controls/scrubber-support/scrubber-support-drag.html:
• media/modern-media-controls/volume-support/volume-support-click.html:
• media/modern-media-controls/volume-support/volume-support-drag.html:
• media/track/track-cue-rendering-snap-to-lines-not-set.html: Turn modern media controls off for this test to pass.

9:41 PM Changeset in webkit [212942] by commit-queue@webkit.org

• 5 edits
  1 copy
  1 add in trunk

[Modern Media Controls] Dragging controls in fullscreen on macOS prevents scrubbing or interacting with controls
​https://bugs.webkit.org/show_bug.cgi?id=168820
<rdar://problem/30690281>

Patch by Antoine Quint <Antoine Quint> on 2017-02-23
Reviewed by Jon Lee.

Source/WebCore:

We broke this in ​https://bugs.webkit.org/show_bug.cgi?id=168755. We restore the check that the
event target when initiating a drag is the controls bar itself and not some of its content.

Since this wasn't caught by our existing tests, we add a test that attemps to initiate a drag
starting over one of the controls and notice that no dragging occurs.

Test: media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html

• Modules/modern-media-controls/controls/macos-fullscreen-media-controls.js:

(MacOSFullscreenMediaControls.prototype._handleMousedown):

LayoutTests:

Making the existing test more robust and adding a new test that checks what happens
when we initiate a drag over some controls.

• media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-expected.txt:
• media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button-expected.txt: Added.
• media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html: Added.
• media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html:

9:33 PM Changeset in webkit [212941] by Simon Fraser

• 3 edits
  2 adds in trunk

REGRESSION (r211305): Masks on composited elements with preserve-3d broken
​https://bugs.webkit.org/show_bug.cgi?id=168815
rdar://problem/30676846

Reviewed by Jon Lee.

Source/WebCore:

r211305 moved the mask layer to be on the structural layer if there is one, to fix
masking backdrops. However, with preserve-3d the structural layer can be a CATransformLayer,
which doesn't take a mask, so limit the previous change to backdrops only.

Test: compositing/masks/mask-with-preserve-3d.html

• platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::updateMaskLayer):

LayoutTests:

• compositing/masks/mask-with-preserve-3d-expected.html: Added.
• compositing/masks/mask-with-preserve-3d.html: Added.

9:27 PM Changeset in webkit [212940] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Modern Media Controls] Show "Loading" until playback starts
​https://bugs.webkit.org/show_bug.cgi?id=168809
<rdar://problem/30687468>

Patch by Antoine Quint <Antoine Quint> on 2017-02-23
Reviewed by Jon Lee.

We now display the "Loading" status as soon as we've started loading and
until we've obtained enough data to play. No test provided since we don't
have a way to specifically set networkState and readyState to the satisfactory
values.

• Modules/modern-media-controls/media/status-support.js:

(StatusSupport.prototype.syncControl):
(StatusSupport):

8:07 PM Changeset in webkit [212939] by sbarati@apple.com

• 28 edits
  2 adds in trunk

Intrinsicify parseInt
​https://bugs.webkit.org/show_bug.cgi?id=168627

Reviewed by Filip Pizlo.

JSTests:

• stress/parse-int-intrinsic.js: Added.

(assert):
(testIntrinsic.let.s):
(testIntrinsic):
(testIntrinsic2.baz):
(testIntrinsic2):
(testIntrinsic3.foo):
(testIntrinsic3):
(testIntrinsic4.foo):
(testIntrinsic4):
(testIntrinsic5.foo):
(testIntrinsic5):
(testIntrinsic6.foo):
(testIntrinsic6):
(testIntrinsic7.foo):
(testIntrinsic7):

Source/JavaScriptCore:

This patch makes parseInt an intrinsic in the DFG and FTL.
We do our best to eliminate this node. If we speculate that
the first operand to the operation is an int32, and that there
isn't a second operand, we convert to the identity of the first
operand. That's because parseInt(someInt) === someInt.

If the first operand is proven to be an integer, and the second
operand is the integer 0 or the integer 10, we can eliminate the
node by making it an identity over its first operand. That's
because parseInt(someInt, 0) === someInt and parseInt(someInt, 10) === someInt.

If we are not able to constant fold the node away, we try to remove
checks. The most common use case of parseInt is that its first operand
is a proven string. The DFG might be able to remove type checks in this
case. We also set up CSE rules for parseInt(someString, someIntRadix)
because it's a "pure" operation (modulo resolving a rope).

This looks to be a 4% Octane/Box2D progression.

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicCall):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGNode.h:

(JSC::DFG::Node::hasHeapPrediction):

• dfg/DFGNodeType.h:
• dfg/DFGOperations.cpp:

(JSC::DFG::parseIntResult):

• dfg/DFGOperations.h:
• dfg/DFGPredictionPropagationPhase.cpp:
• dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileParseInt):

• dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):
(JSC::DFG::SpeculativeJIT::appendCallSetResult):

• dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileParseInt):

• jit/JITOperations.h:
• parser/Lexer.cpp:
• runtime/ErrorInstance.cpp:
• runtime/Intrinsic.h:
• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

• runtime/JSGlobalObjectFunctions.cpp:

(JSC::toStringView): Deleted.
(JSC::isStrWhiteSpace): Deleted.
(JSC::parseDigit): Deleted.
(JSC::parseIntOverflow): Deleted.
(JSC::parseInt): Deleted.

• runtime/JSGlobalObjectFunctions.h:
• runtime/ParseInt.h: Added.

(JSC::parseDigit):
(JSC::parseIntOverflow):
(JSC::isStrWhiteSpace):
(JSC::parseInt):
(JSC::toStringView):

• runtime/StringPrototype.cpp:

7:22 PM Changeset in webkit [212938] by Chris Dumez

• 5 edits in trunk/LayoutTests

Unreviewed, try to reduce flakiness to timer throttling tests

Try to reduce flakiness to timer throttling tests by increasing
tolerance.

• fast/dom/timer-throttling-hidden-page-expected.txt:
• fast/dom/timer-throttling-hidden-page-non-nested-expected.txt:
• fast/dom/timer-throttling-hidden-page-non-nested.html:
• fast/dom/timer-throttling-hidden-page.html:

7:13 PM Changeset in webkit [212937] by matthew_hanson@apple.com

• 1 copy in tags/Safari-603.1.30.1.20

Tag Safari-603.1.30.1.20.

7:12 PM Changeset in webkit [212936] by matthew_hanson@apple.com

• 1 copy in tags/Safari-603.1.30.0.20

Tag Safari-603.1.30.0.20.

7:12 PM Changeset in webkit [212935] by rniwa@webkit.org

• 3 edits in trunk/Websites/perf.webkit.org

REGRESSION(r212542): Make TimeSeriesChart.computeTimeGrid stops x-axis grid prematurely
​https://bugs.webkit.org/show_bug.cgi?id=168812

Reviewed by Joseph Pecoraro.

Add time iterator of two months, three months, and four months with some tests.

Also for one-month time iterator, round the day of month to 1 or 15 whichever is closer.

• browser-tests/time-series-chart-tests.js: Added more tests.
• public/v3/components/time-series-chart.js:

(TimeSeriesChart._timeIterators.next):
(TimeSeriesChart._timeIterators):

7:11 PM Changeset in webkit [212934] by jfernandez@igalia.com

• 2 edits in trunk/LayoutTests

[GTK] Layout test imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/track-api-texttracks.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=168799

Unreviewed test gardening.

• platform/gtk/TestExpectations:

5:44 PM Changeset in webkit [212933] by commit-queue@webkit.org

• 5 edits in trunk

[Modern Media Controls] Enforce a minimum layout height of 50pt for <audio>
​https://bugs.webkit.org/show_bug.cgi?id=168801
<rdar://problem/30683453>

Patch by Antoine Quint <Antoine Quint> on 2017-02-23
Reviewed by Eric Carlson.

Source/WebCore:

We enforce a 50pt minimum layout height for <audio> elements. There is no way
for the page author to override this value since the min-height property is set
as !important in a <style> element contained in a ShadowRoot.

• Modules/modern-media-controls/controls/media-controls.css:

(:host(audio)):

LayoutTests:

Update the existing <audio> metrics test to check that we correctly maintain
a 50pt minimum height even if an inline style attribute sets a shorter height
on an <audio> element, and also check that providing a taller height is respected.

• media/modern-media-controls/audio/audio-controls-metrics-expected.txt:
• media/modern-media-controls/audio/audio-controls-metrics.html:

5:22 PM Changeset in webkit [212932] by matthew_hanson@apple.com

• 3 edits
  2 deletes in tags/Safari-603.1.30.0.4

Roll out r212737 via r212740. rdar://problem/30636274

5:00 PM Changeset in webkit [212931] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[WebRTC] Outgoing video quality is poor
​https://bugs.webkit.org/show_bug.cgi?id=168778
<rdar://problem/30674673>

Patch by Youenn Fablet <​youenn@apple.com> on 2017-02-23
Reviewed by Eric Carlson.

Covered by manually ensuring the voice process thread is not spinning.

• platform/mediastream/libwebrtc/LibWebRTCAudioModule.h: Setting the next call to max was not a good idea since the thread process is adding some value to it, making it a negative value.

3:38 PM Changeset in webkit [212930] by Wenson Hsieh

• 4 edits in trunk/Source/WebCore

Data interaction with a URL should navigate the page if the operation is not handled
​https://bugs.webkit.org/show_bug.cgi?id=168798
<rdar://problem/30665969>

Reviewed by Tim Horton.

Refactors some drag and drop code on the Mac, and implements PlatformPasteboard::stringForType.

• page/DragController.cpp:

(WebCore::DragController::performDragOperation):

• platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::stringForType):

• platform/mac/DragDataMac.mm:

3:33 PM Changeset in webkit [212929] by Beth Dakin

• 6 edits
  3 adds in trunk

Source/WebKit2:
No reliable way to get a snapshot of WKWebView
​https://bugs.webkit.org/show_bug.cgi?id=161450
-and corresponding-
<rdar://problem/23846039>

Patch by Beth Dakin <Beth Dakin> + Dan Saunders <​dasau@microsoft.com> on 2017-02-23
Reviewed by Tim Horton.

This patch adds a new API to WKWebView to snapshot a rect:
takeSnapshotWithConfiguration:completionHandler:

It also adds a new API object WKSnapshotConfiguration.

• UIProcess/API/Cocoa/WKSnapshotConfiguration.h: Added.
• UIProcess/API/Cocoa/WKSnapshotConfiguration.mm: Added.

(-[WKSnapshotConfiguration copyWithZone:]):

• UIProcess/API/Cocoa/WKWebView.h:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView takeSnapshotWithConfiguration:completionHandler:]):

• WebKit2.xcodeproj/project.pbxproj:

Tools:
No reliable way to get a snapshot of WKWebView (macOS)
​https://bugs.webkit.org/show_bug.cgi?id=161450
-and corresponding-
<rdar://problem/23846039>

Patch by Beth Dakin <Beth Dakin> + Dan Saunders <​dasau@microsoft.com> on 2017-02-23
Reviewed by Tim Horton.

Test for WKWebView’s new API takeSnapshotWithConfiguration:completionHandler:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewSnapshot.mm: Added.

(convertToCGImage):
(getPixelIndex):
(TEST):

3:05 PM Changeset in webkit [212928] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[WebRTC] RealtimeOutgoingAudioSource does not need to upsample audio buffers
​https://bugs.webkit.org/show_bug.cgi?id=168796

Patch by Youenn Fablet <​youenn@apple.com> on 2017-02-23
Reviewed by Jer Noble.

Covered by manual testing.
Limiting RealtimeOutgoingAudioSource conversion to interleaving and float-to-integer.
Removed the sample rate conversion.

• platform/mediastream/mac/RealtimeOutgoingAudioSource.cpp:

(WebCore::libwebrtcAudioFormat):
(WebCore::RealtimeOutgoingAudioSource::audioSamplesAvailable):
(WebCore::RealtimeOutgoingAudioSource::pullAudioData):

2:52 PM Changeset in webkit [212927] by achristensen@apple.com

• 5 edits in trunk/Source/WebCore

Re-soft-link CoreVideo after r212906
​https://bugs.webkit.org/show_bug.cgi?id=168803

Reviewed by Jer Noble.

CoreVideo should be soft linked to reduce startup time.
Linking against the framework just for a few symbols used in one file was the wrong solution.

• Configurations/WebCore.xcconfig:
• platform/cocoa/CoreVideoSoftLink.cpp:
• platform/cocoa/CoreVideoSoftLink.h:
• platform/mediastream/mac/RealtimeOutgoingVideoSource.cpp:

2:51 PM Changeset in webkit [212926] by matthew_hanson@apple.com

• 5 edits in tags/Safari-603.1.30.0.4/Source

Versioning.

2:35 PM Changeset in webkit [212925] by matthew_hanson@apple.com

• 1 copy in tags/Safari-603.1.30.0.4

New Tag.

2:04 PM Changeset in webkit [212924] by jer.noble@apple.com

• 2 edits in trunk/Source/WebKit2

ASSERT in RTCNetwork::IPAddress::decode()
​https://bugs.webkit.org/show_bug.cgi?id=168792

Reviewed by Tim Horton.

An ASSERT added to RTCNetwork::IPAddress::decode in r212781 was hit due to a bad encode of SocketAddress; an
extra boolean value was added to the encoder unnecessarily, leading to garbage data being decoded in the following
IPAddress.

Drive-by-fix: allow the IPAddress encoder/decoder to pass through a value of AF_UNSPEC for an IPAddress to support
passing through an "empty" IPAddress value.

• Shared/RTCNetwork.cpp:

(WebKit::RTCNetwork::IPAddress::decode):
(WebKit::RTCNetwork::IPAddress::encode):
(WebKit::RTCNetwork::SocketAddress::encode):

1:39 PM Changeset in webkit [212923] by rniwa@webkit.org

• 8 edits in trunk/Websites/perf.webkit.org

Add tests for InteractiveTimeSeriesChart and adopt actions
​https://bugs.webkit.org/show_bug.cgi?id=168750

Reviewed by Chris Dumez.

Added tests for InteractiveTimeSeriesChart.

Also replaced selection.onchange, selection.onzoom, indicator.onchange, annotations.onclick callbacks
by "selectionChange", "zoom", "indicatorChange", and "annotationClick" actions respectively.

Also fixed various bugs and bad code I encountered while writing these tests.

• browser-tests/index.html:

(waitForComponentsToRender): Delay the call to enqueueToRender until the next run loop because there
might be outstanding promises that just got resolved. e.g. for fetching measurement sets JSONs. Let
all those promises get resolved first. Otherwise, some tests become racy.
(canvasImageData): Extracted from time-series-chart-tests.js.
(canvasRefTest): Ditto.
(CanvasTest): Ditto.
(CanvasTest.fillCanvasBeforeRedrawCheck): Ditto.
(CanvasTest.hasCanvasBeenRedrawn): Ditto.
(CanvasTest.canvasImageData): Ditto.
(CanvasTest.expectCanvasesMatch): Ditto.
(CanvasTest.expectCanvasesMismatch): Ditto.

• browser-tests/time-series-chart-tests.js: Fixed some test cases where dpr multipler was not doing

the right thing anymore in Safari under a high DPI screen. Also added a lot of test cases for interactive
time series chart and one for rendering annotations.
(scripts): Moved.
(posixTime): Added. A helper function for sampleCluster.
(dayInMilliseconds): Ditto.
(sampleCluster): Moved here. Made the same cluster more artifical for an easier testing.
(createChartWithSampleCluster): Moved out of one of the tests.
(respondWithSampleCluster): Ditto.

• public/v3/components/chart-pane-base.js:

(ChartPaneBase.prototype.configure): Adopted new actions in InteractiveTimeSeriesChart.

• public/v3/components/chart-status-view.js:

(ChartStatusView.prototype.updateStatusIfNeeded): Removed a superflous console.log.

• public/v3/components/chart-styles.js:

(ChartStyles.mainChartOptions): Set zoomButton to true. InteractiveTimeSeriesChart used to determine
whether to show the zoom button or not based on the precense of the zoom callback. We made it explicit.

• public/v3/components/interactive-time-series-chart.js:

(InteractiveTimeSeriesChart.prototype.setIndicator): Explicitly call _notifySelectionChanged with false
instead of relying on undefined to be treated as falsey.
(InteractiveTimeSeriesChart.prototype._createCanvas): Use id instead of selector to find elements.
(InteractiveTimeSeriesChart.htmlTemplate):
(InteractiveTimeSeriesChart.cssTemplate):
(InteractiveTimeSeriesChart.prototype._mouseMove): Explicitly call _startOrContinueDragging with false
instead of relying on undefined treated as falsey. Also added the missing call to enqueueToRender found
by new tests. This was working fine on the dashboard due to other components invoking enqueueToRender
but won't work in a standalone instance of InteractiveTimeSeriesChart.
(InteractiveTimeSeriesChart.prototype._mouseLeave): Ditto, adding the missing call to enqueueToRender.
(InteractiveTimeSeriesChart.prototype._click): Removed the assignment to _forceRender when calling
_mouseMove in an early exist, which does set this flag and invokes enqueueToRender, and added the missing
call to enqueueToRender in the other code path.
(InteractiveTimeSeriesChart.prototype._startOrContinueDragging): Replaced annotations.onclick callback
by the newly added "annotationClick" action, and added the missing call to enqueueToRender.
(InteractiveTimeSeriesChart.prototype._endDragging): Use arrow function.
(InteractiveTimeSeriesChart.prototype._notifyIndicatorChanged): Replaced indicator.onchange callback by
the newly added "indicatorChange" action.
(InteractiveTimeSeriesChart.prototype._notifySelectionChanged): Replaced selection.onchange callback by
the newly added "selectionChange" action.
(InteractiveTimeSeriesChart.prototype._renderChartContent): Show the zoom button when options.zoomButton
is set instead of relying on the presence of selection.onzoom especially now that the callback has been
replaced by the "zoom" action.

• public/v3/components/time-series-chart.js:

(TimeSeriesChart.prototype.setAnnotations): Added the missing call to enqueueToRender.

• public/v3/main.js:

1:36 PM Changeset in webkit [212922] by jfbastien@apple.com

• 63 edits in trunk

WebAssembly: support 0x1 version
​https://bugs.webkit.org/show_bug.cgi?id=168672

Reviewed by Keith Miller.

JSTests:

Update the version number for all the tests. Note that the spec
tests are only updated with a new version number because spec+wabt
aren't ready for 0x1 yet. This is tracked by bug #168784.

• wasm/import-spec-tests.rb: use the new spec repository layout
• wasm/js-api/test_basic_api.js:
• wasm/self-test/test_BuilderWebAssembly.js:

(EmptyModule):
(CustomSection):

• wasm/spec-tests/address.wast.js:
• wasm/spec-tests/binary.wast.js:
• wasm/spec-tests/block.wast.js:
• wasm/spec-tests/br.wast.js:
• wasm/spec-tests/br_if.wast.js:
• wasm/spec-tests/br_table.wast.js:
• wasm/spec-tests/break-drop.wast.js:
• wasm/spec-tests/call.wast.js:
• wasm/spec-tests/call_indirect.wast.js:
• wasm/spec-tests/comments.wast.js:
• wasm/spec-tests/conversions.wast.js:
• wasm/spec-tests/custom_section.wast.js:
• wasm/spec-tests/endianness.wast.js:
• wasm/spec-tests/exports.wast.js:
• wasm/spec-tests/f32.wast.js:
• wasm/spec-tests/f32_cmp.wast.js:
• wasm/spec-tests/f64.wast.js:
• wasm/spec-tests/f64_cmp.wast.js:
• wasm/spec-tests/fac.wast.js:
• wasm/spec-tests/float_exprs.wast.js:
• wasm/spec-tests/float_literals.wast.js:
• wasm/spec-tests/float_memory.wast.js:
• wasm/spec-tests/float_misc.wast.js:
• wasm/spec-tests/forward.wast.js:
• wasm/spec-tests/func.wast.js:
• wasm/spec-tests/func_ptrs.wast.js:
• wasm/spec-tests/get_local.wast.js:
• wasm/spec-tests/globals.wast.js:
• wasm/spec-tests/i32.wast.js:
• wasm/spec-tests/i64.wast.js:
• wasm/spec-tests/imports.wast.js:
• wasm/spec-tests/int_exprs.wast.js:
• wasm/spec-tests/int_literals.wast.js:
• wasm/spec-tests/left-to-right.wast.js:
• wasm/spec-tests/linking.wast.js:
• wasm/spec-tests/loop.wast.js:
• wasm/spec-tests/memory.wast.js:
• wasm/spec-tests/memory_redundancy.wast.js:
• wasm/spec-tests/memory_trap.wast.js:
• wasm/spec-tests/names.wast.js:
• wasm/spec-tests/nop.wast.js:
• wasm/spec-tests/resizing.wast.js:
• wasm/spec-tests/return.wast.js:
• wasm/spec-tests/select.wast.js:
• wasm/spec-tests/set_local.wast.js:
• wasm/spec-tests/skip-stack-guard-page.wast.js:
• wasm/spec-tests/stack.wast.js:
• wasm/spec-tests/start.wast.js:
• wasm/spec-tests/store_retval.wast.js:
• wasm/spec-tests/switch.wast.js:
• wasm/spec-tests/tee_local.wast.js:
• wasm/spec-tests/traps.wast.js:
• wasm/spec-tests/typecheck.wast.js:
• wasm/spec-tests/unreachable.wast.js:
• wasm/spec-tests/unwind.wast.js:
• wasm/wasm.json:

Source/JavaScriptCore:

• wasm/wasm.json: update the version number, everything is based

on its value

1:25 PM Changeset in webkit [212921] by sbarati@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Make Briggs fixpoint validation run only with validateGraphAtEachPhase
​https://bugs.webkit.org/show_bug.cgi?id=168795

Rubber stamped by Keith Miller.

The Briggs allocator was running intensive validation
on each step of the fixpoint. Instead, it now will just
do it when shouldValidateIRAtEachPhase() is true because
doing this for all !ASSERT_DISABLED builds takes too long.

• b3/air/AirAllocateRegistersByGraphColoring.cpp:

12:56 PM Changeset in webkit [212920] by Chris Dumez

• 4 edits in trunk/Source/WebCore

Report domains using abnormally high CPU usage via enhanced privacy logging
​https://bugs.webkit.org/show_bug.cgi?id=168794
<rdar://problem/29964018>

Reviewed by Ryosuke Niwa.

Report domains using abnormally high CPU usage (> 20%) via enhanced privacy
logging.

• page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::domainCausingEnergyDrainKey):

• page/DiagnosticLoggingKeys.h:
• page/PerformanceMonitor.cpp:

(WebCore::reportPageOverPostLoadCPUUsageThreshold):
(WebCore::PerformanceMonitor::measurePostLoadCPUUsage):

12:51 PM Changeset in webkit [212919] by matthew_hanson@apple.com

• 3 edits in branches/safari-603-branch/Source/WebCore

Merge r212828. rdar://problem/30636274

12:51 PM Changeset in webkit [212918] by matthew_hanson@apple.com

• 3 edits
  2 deletes in branches/safari-603-branch

Roll out r212737 via r212740. rdar://problem/30636274

12:51 PM Changeset in webkit [212917] by matthew_hanson@apple.com

• 4 edits in branches/safari-603-branch/Source/WebCore

Merge r212554. rdar://problem/30636115

12:51 PM Changeset in webkit [212916] by matthew_hanson@apple.com

• 2 edits in branches/safari-603-branch/Source/JavaScriptCore

rdar://problem/30635733

12:39 PM Changeset in webkit [212915] by eric.carlson@apple.com

• 2 edits in trunk/Source/WebKit2

[WebRTC][Mac][WebKit2] WebRTC requires media capture
​https://bugs.webkit.org/show_bug.cgi?id=168782
<rdar://problem/30675242>

Reviewed by Youenn Fablet.

• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess): Extend the sanbox to allow microphone access
if media stream OR WebRTC is enabled.

12:32 PM Changeset in webkit [212914] by matthew_hanson@apple.com

• 6 edits in trunk/Source

Versioning.

12:24 PM Changeset in webkit [212913] by commit-queue@webkit.org

• 4 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: DOM Tree spacing is wrong
​https://bugs.webkit.org/show_bug.cgi?id=168744

Patch by Devin Rousso <Devin Rousso> on 2017-02-23
Reviewed by Brian Burg.

• UserInterface/Base/Utilities.js:

(Element.prototype.totalOffsetRight):

• UserInterface/Views/DOMTreeOutline.css:

(.tree-outline.dom):
(.tree-outline.dom ol):
(body[dir=ltr] .tree-outline.dom ol):
(body[dir=rtl] .tree-outline.dom ol):
(.tree-outline.dom li:matches(.hovered, .selected) + ol.children.expanded):
(body[dir=ltr] .tree-outline.dom li:matches(.hovered, .selected) + ol.children.expanded):
(body[dir=rtl] .tree-outline.dom li:matches(.hovered, .selected) + ol.children.expanded):
(.tree-outline.dom li.selected + ol.children.expanded):
(.tree-outline.dom li):
(body[dir=ltr] .tree-outline.dom li):
(body[dir=rtl] .tree-outline.dom li):
(.tree-outline.dom li.pseudo-class-enabled > .selection-area::before):
(body[dir=rtl] .tree-outline.dom li.pseudo-class-enabled > .selection-area::before):
(body[dir=ltr] .tree-outline.dom.single-node li):
(body[dir=rtl] .tree-outline.dom.single-node li):
(.tree-outline.dom li.parent):
(body[dir=ltr] .tree-outline.dom li.parent):
(body[dir=rtl] .tree-outline.dom li.parent):
(body[dir=ltr] .tree-outline.dom li .html-tag.close):
(body[dir=rtl] .tree-outline.dom li .html-tag.close):
(.tree-outline.dom li.parent::before):
(body[dir=rtl] .tree-outline.dom li.parent::before):
(body[dir=ltr] .tree-outline.dom li.parent::before):
(.tree-outline.dom li.parent.shadow::after):
(body[dir=ltr] .tree-outline.dom li.parent.shadow::after):
(body[dir=rtl] .tree-outline.dom li.parent.shadow::after):
(.tree-outline.dom.single-node li): Deleted.
(.tree-outline.dom li .html-tag.close): Deleted.

• UserInterface/Views/TreeElement.js:

(WebInspector.TreeElement.prototype.isEventWithinDisclosureTriangle):
Calculate the position of the ::before triangle based on the layout direction.

12:12 PM Changeset in webkit [212912] by Alan Bujtas

• 3 edits in trunk/Source/WebCore

Simple line layout: Adjust RunResolver::lineIndexForHeight with line struts.
​https://bugs.webkit.org/show_bug.cgi?id=168783
<rdar://problem/30676449>

Reviewed by Antti Koivisto.

When there's a pagination gap between lines the simple lineIndex = y / lineHeight formula does not work anymore.
This patch takes the line gaps into account by offsetting the y position accordingly.

Not enabled yet.

• rendering/SimpleLineLayoutResolver.cpp:

(WebCore::SimpleLineLayout::RunResolver::lineIndexForHeight):

11:56 AM Changeset in webkit [212911] by sbarati@apple.com

• 2 edits in trunk/Tools

Speculative fix for jsc timing out tests
​https://bugs.webkit.org/show_bug.cgi?id=168791

Rubber Stamped by Keith Miller.

Play musical chairs with IRC and Briggs options on
ftl-eager and ftl-eager-no-cjit.

• Scripts/run-jsc-stress-tests:

11:55 AM Changeset in webkit [212910] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: RTL: navigation sidebar section disclosure triangles and tree element icons should be aligned right
​https://bugs.webkit.org/show_bug.cgi?id=168284

Patch by Devin Rousso <Devin Rousso> on 2017-02-23
Reviewed by Brian Burg.

• UserInterface/Views/TreeOutline.css:

(.tree-outline,):
(.tree-outline.large .item):
(body[dir=ltr] .tree-outline .item :matches(.disclosure-button, .icon)):
(body[dir=rtl] .tree-outline .item :matches(.disclosure-button, .icon)):
(body[dir=ltr] .tree-outline:not(.hide-disclosure-buttons) .item:not(.parent) > .icon):
(body[dir=rtl] .tree-outline:not(.hide-disclosure-buttons) .item:not(.parent) > .icon):
(.tree-outline .item .disclosure-button):
(body[dir=rtl] .tree-outline .item .disclosure-button):
(.tree-outline .item .icon):
(body[dir=ltr] .tree-outline .item .icon):
(body[dir=rtl] .tree-outline .item .icon):
(.tree-outline.large .item .icon):
(.tree-outline .item .status):
(body[dir=ltr] .tree-outline .item .status):
(body[dir=rtl] .tree-outline .item .status):
(.tree-outline:not(.hide-disclosure-buttons) .item:not(.parent) > .icon): Deleted.

• UserInterface/Views/TreeOutline.js:

(WebInspector.TreeOutline._generateStyleRulesIfNeeded):

11:47 AM Changeset in webkit [212909] by fpizlo@apple.com

• 2 edits in trunk/Source/JavaScriptCore

SpeculativeJIT::compilePutByValForIntTypedArray should only do the constant-folding optimization when the constant passes the type check
​https://bugs.webkit.org/show_bug.cgi?id=168787

Reviewed by Michael Saboff and Mark Lam.

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):

11:42 AM Changeset in webkit [212908] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Ensure that the end of the last invalidation point does not extend beyond the end of the buffer.
​https://bugs.webkit.org/show_bug.cgi?id=168786

Reviewed by Filip Pizlo.

In practice, we will always have multiple instructions after invalidation points,
and have enough room in the JIT buffer for the invalidation point to work with.
However, as a precaution, we can guarantee that there's enough room by always
emitting a label just before we link the buffer. The label will emit nop padding
if needed.

• assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::linkCode):

11:25 AM Changeset in webkit [212907] by achristensen@apple.com

• 2 edits in trunk/Websites/webkit.org

Add WebRTC to experimental-features.html
​https://bugs.webkit.org/show_bug.cgi?id=168757

Reviewed by Tim Horton.

• experimental-features.html:

11:22 AM Changeset in webkit [212906] by achristensen@apple.com

• 2 edits in trunk/Source/WebCore

Fix iOS WebRTC build after r212812
​https://bugs.webkit.org/show_bug.cgi?id=168790

Reviewed by Tim Horton.

• Configurations/WebCore.xcconfig:

11:04 AM Changeset in webkit [212905] by clopez@igalia.com

• 4 edits in trunk/Tools

Improve error message when the WPT server fails to start.
​https://bugs.webkit.org/show_bug.cgi?id=168759

Reviewed by Ryosuke Niwa.

Check if the WPT server is running after 1 second, and if is not
print useful information for helping the user to debug the issue.

Using check_running_pid() to check if the process is still running
doesn't work. A process started via subprocess popen that has ended
will be in a zombie state until a call to wait/communicate/poll
is done, or until the object is deleted or garbage collected.

This adds also support for testing the behaviour of subprocess
poll() on the unit tests that use MockProcess.

A new test is added also for the battery of tests for the WPT
server.

• Scripts/webkitpy/common/system/executive_mock.py:

(MockProcess.init):
(MockProcess.wait):
(MockProcess.communicate):
(MockProcess.poll):
(MockExecutive.popen):

• Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:

(WebPlatformTestServer.init):
(WebPlatformTestServer._prepare_config):
(WebPlatformTestServer._spawn_process):

• Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:

(TestWebPlatformTestServer.test_corrupted_subserver_files):
(TestWebPlatformTestServer):
(TestWebPlatformTestServer.test_server_fails_to_start_throws_exception):

11:01 AM Changeset in webkit [212904] by Brent Fulgham

• 2 edits in trunk/Source/WebKit2

[Mac] Remove unneeded sandbox exceptions for media elements
​https://bugs.webkit.org/show_bug.cgi?id=168767

Reviewed by Alex Christensen.

Remove several sandbox exceptions that have not been needed for the past four
or five macOS releases.

• WebProcess/com.apple.WebProcess.sb.in:

11:00 AM Changeset in webkit [212903] by aakash_jain@apple.com

• 3 edits in trunk/Source/WebKit/ios

Move instance member from WebFixedPositionContent to implementation file
​https://bugs.webkit.org/show_bug.cgi?id=168766

Reviewed by Tim Horton.

• WebCoreSupport/WebFixedPositionContent.h: Moving instance member to implementation file.
• WebCoreSupport/WebFixedPositionContent.mm: Ditto.

10:59 AM Changeset in webkit [212902] by Brent Fulgham

• 3 edits in trunk/Source/WebKit2

[Mac] Remove com.apple.audio.VDCAssistant from sandboxes
​https://bugs.webkit.org/show_bug.cgi?id=168764
<rdar://problem/16736919>

Reviewed by Alex Christensen.

Remove unneeded sandbox class.

• PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
• WebProcess/com.apple.WebProcess.sb.in:

10:25 AM Changeset in webkit [212901] by Wenson Hsieh

• 2 edits in trunk/Tools

Unreviewed, temporarily disable DataInteractionTests in TestWebKitAPI.

These will be reenabled in ​https://bugs.webkit.org/show_bug.cgi?id=168602.

• TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

10:20 AM Changeset in webkit [212900] by keith_miller@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix the cloop build. Needed a #if.

• jit/ExecutableAllocator.cpp:

10:18 AM Changeset in webkit [212899] by Jon Davis

• 2 edits in trunk/Websites/webkit.org

Fixed saving survey data
​https://bugs.webkit.org/show_bug.cgi?id=168730

Reviewed by Joseph Pecoraro.

• wp-content/themes/webkit/functions.php:

9:23 AM Changeset in webkit [212898] by Wenson Hsieh

• 9 edits in trunk

Data interaction causes selection to fall out of sync between web/UI processes
​https://bugs.webkit.org/show_bug.cgi?id=168735
<rdar://problem/30657817>

Reviewed by Tim Horton.

Source/WebKit2:

Fixes a bug with data interaction causing selection state to fall out of sync between the UI and web processes,
and also introduces testing infrastructure and tests for grabbing UI-side selection view rects in TestWebKitAPI.
While performing a data interaction operation, we now lift restrictions for assisting the focused node.

• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView cleanupInteraction]):
(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:userObject:]):

Tools:

Adds a new method to TestWKWebView for querying selection view rects from the UI process and augments data
interaction unit tests to check for selection rects using this new hook.

• TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(makeCGRectValue):
(TestWebKitAPI::TEST):

• TestWebKitAPI/cocoa/TestWKWebView.h:
• TestWebKitAPI/cocoa/TestWKWebView.mm:

(-[TestWKWebView selectionRectsAfterPresentationUpdate]):

• TestWebKitAPI/ios/DataInteractionSimulator.h:
• TestWebKitAPI/ios/DataInteractionSimulator.mm:

(-[DataInteractionSimulator _resetSimulatedState]):
(-[DataInteractionSimulator runFrom:to:]):
(-[DataInteractionSimulator finalSelectionRects]):

8:58 AM Changeset in webkit [212897] by matthew_hanson@apple.com

• 2 edits in branches/safari-603.1.30.0-branch/Source/JavaScriptCore

rdar://problem/30635733

8:58 AM Changeset in webkit [212896] by matthew_hanson@apple.com

• 5 edits in branches/safari-603.1.30.0-branch/Source

Versioning.

8:54 AM Changeset in webkit [212895] by matthew_hanson@apple.com

• 3 edits in branches/safari-603.1.30.1-branch/Source/WebCore

Merge r212828. rdar://problem/30636288

8:54 AM Changeset in webkit [212894] by matthew_hanson@apple.com

• 3 edits
  2 deletes in branches/safari-603.1.30.1-branch

Roll out r212737 via r212740. rdar://problem/30636288

8:54 AM Changeset in webkit [212893] by matthew_hanson@apple.com

• 4 edits in branches/safari-603.1.30.1-branch/Source/WebCore

Merge r212554. rdar://problem/30636115

8:54 AM Changeset in webkit [212892] by matthew_hanson@apple.com

• 5 edits in branches/safari-603.1.30.1-branch/Source

Versioning.

8:47 AM Changeset in webkit [212891] by Carlos Garcia Campos

• 5 edits in trunk/Source/WebKit2

[GTK] Crash attempting to load Flash plugin in Wayland
​https://bugs.webkit.org/show_bug.cgi?id=163159

Reviewed by Michael Catanzaro.

The problem is that we check if the current diplay is X11 or Wayland also in the plugin process, but with GTK2
plugins the display is always X11. We should early reject plugins requiring GTK2 in the UI process when the
current display is Wayland.

• UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp:

(WebKit::PluginInfoStore::getPluginInfo):

• UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:

(WebKit::PluginProcessProxy::scanPlugin):

• UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::createPluginContainer): Add an assert to ensure this message is never received on a
non-X11 display.

• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::createPluginContainer): Never send CreatePluginContainer message to the UI process if the
display is not X11.

8:39 AM Changeset in webkit [212890] by clopez@igalia.com

• 2 edits in trunk/LayoutTests

[GTK] Gardening of some flaky tests

Unreviewed.

• platform/gtk/TestExpectations: Update some expectations or add new cases of flaky tests.

8:28 AM Changeset in webkit [212889] by Carlos Garcia Campos

• 3 edits in trunk/Source/WebCore

[GStreamer] Several layout tests trigger GStreamer-CRITICAL : gst_bin_get_by_name: assertion 'GST_IS_BIN (bin)' failed
​https://bugs.webkit.org/show_bug.cgi?id=167016

Reviewed by Xabier Rodriguez-Calvar.

This is because we create AudioSourceProviderGStreamer objects that are never loaded. In the destructor the
AudioSourceProviderGStreamer calls gst_bin_get_by_name() on its m_audioSinkBin that is nullptr. We could simply
check m_audioSinkBin in the destructor, but I think it's better to simply not create
AudioSourceProviderGStreamer for nothing. MediaPlayerPrivateGStreamer should create the AudioSourceProvider on demand.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer): Do not create the AudioSourceProvider.
(WebCore::MediaPlayerPrivateGStreamer::createAudioSink): Call ensureAudioSourceProvider() before using m_audioSourceProvider.
(WebCore::MediaPlayerPrivateGStreamer::ensureAudioSourceProvider): Create the AudioSourceProvider if needed.
(WebCore::MediaPlayerPrivateGStreamer::audioSourceProvider): Ensure and return the m_audioSourceProvider.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

8:15 AM Changeset in webkit [212888] by matthew_hanson@apple.com

• 3 edits in branches/safari-603.1.30.0-branch/Source/WebCore

Merge r212828. rdar://problem/30636274

8:15 AM Changeset in webkit [212887] by matthew_hanson@apple.com

• 3 edits
  2 deletes in branches/safari-603.1.30.0-branch

Roll out r212737 via r212740. rdar://problem/30636274

8:15 AM Changeset in webkit [212886] by matthew_hanson@apple.com

• 4 edits in branches/safari-603.1.30.0-branch/Source/WebCore

Merge r212554. rdar://problem/30636115

8:15 AM Changeset in webkit [212885] by matthew_hanson@apple.com

• 5 edits in branches/safari-603.1.30.0-branch/Source

Versioning.

7:54 AM Changeset in webkit [212884] by clopez@igalia.com

• 3 edits
  1 delete in trunk/LayoutTests

[GTK] MediaStream and WebRTC layout test gardening

Unreviewed.

• TestExpectations: Clarify some comments.
• platform/gtk/TestExpectations: Unskip most of the MediaStream / WebRTC tests for GTK and mark the expected failures accordingly.
• platform/gtk/fast/mediastream/RTCPeerConnection-more-media-to-negotiate-expected.txt: Removed. The test passes on GTK with the

general test expectation.

7:13 AM Changeset in webkit [212883] by eric.carlson@apple.com

• 2 edits in trunk/Source/WebKit2

[MediaStream iOS] Allow web process sandbox to be extended for media capture
​https://bugs.webkit.org/show_bug.cgi?id=168756

Reviewed by Brent Fulgham.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: Add rules to dynamically

extend the sandbox to allow access to the camera and/or microphone.

3:27 AM Changeset in webkit [212882] by tpopela@redhat.com

• 2 edits in trunk

[GTK] Compilation fails if using ninja together with icecream and cmake > 3.5
​https://bugs.webkit.org/show_bug.cgi?id=168770

Reviewed by Carlos Garcia Campos.

If using cmake >= 3.6 together with ninja generator and icecream, the
build will fail as icecream does not correctly handle the response
files and it's not passing compiler flags from there to the compiler
itself (in our case it's not passing -fPIC which leads to the
failure while linking). Don't enable the ninja's response files
support if we fulfill the preconditions.

• Source/cmake/OptionsCommon.cmake:

3:24 AM Changeset in webkit [212881] by tpopela@redhat.com

• 9 edits
  2 adds in trunk

[GTK] Drag and drop is always moving the content even if copy is requested
​https://bugs.webkit.org/show_bug.cgi?id=168424

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Drag and drop is always moving the content around even if the copy is
requested (i.e. by pressing the Control key).

Test: editing/pasteboard/drag-drop-copy-content.html

• page/gtk/DragControllerGtk.cpp:

(WebCore::DragController::isCopyKeyDown):

Source/WebKit2:

Drag and drop is always moving the content around even if the copy is
requested (i.e. by pressing the Control key).

• UIProcess/gtk/DragAndDropHandler.cpp:

(WebKit::DragAndDropHandler::drop):

LayoutTests:

Mark the editing/pasteboard/drag-drop-copy-content.html as failing
as WTR doesn't know how to perform drag and drop in WK2. Also the
test does not pass on the mac WK1, created a bug for it.

• platform/efl/TestExpectations:
• platform/gtk-wayland/TestExpectations:
• platform/gtk/TestExpectations:
• platform/mac-wk2/TestExpectations:
• platform/mac/TestExpectations: