Context Navigation

← Previous Period
Next Period →

Timeline

Mar 4, 2017:

11:41 PM Changeset in webkit [213432] by mitz@apple.com

2 edits
1 add in trunk/Source/ThirdParty/libwebrtc

[Cocoa] libwebrtc.dylib’s current version is fixed at 1.0.0
https://bugs.webkit.org/show_bug.cgi?id=169170

Reviewed by Alex Christensen.

Configurations/Version.xcconfig: Copied from Source/JavaScriptCore/Configurations/Version.xcconfig. This defines DYLIB_CURRENT_VERSION.
Configurations/libwebrtc.xcconfig: Include Version.xcconfig.

5:06 PM Changeset in webkit [213431] by Chris Dumez

2 edits in trunk/LayoutTests/imported/w3c

Rebaseline W3C test after r213412.

web-platform-tests/html/dom/interfaces-expected.txt:

2:39 PM Changeset in webkit [213430] by eric.carlson@apple.com

4 edits
1 add in trunk/Source/WebKit2

[iOS] The web process should inherit application state from UI process
https://bugs.webkit.org/show_bug.cgi?id=169156
<rdar://problem/30845473>

Reviewed by Alexey Proskuryakov.

Platform/spi/ios/CelestialSPI.h: Added.

WebKit2.xcodeproj/project.pbxproj: Include CelestialSPI.h.

WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist: Add entitlement.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformInitialize): Set up PID proxying.

1:49 PM Changeset in webkit [213429] by Simon Fraser

3 edits in trunk/Source/WebCore

Clarify some terminology in RenderLayerBacking
https://bugs.webkit.org/show_bug.cgi?id=169174

Reviewed by Zalan Bujtas.

Rename some functions related to directly-composited background images and
box decorations for clarify.

Only behavior change is for canDirectlyCompositeBackgroundBackgroundImage() to check
GraphicsLayer::supportsContentsTiling(), which means that RenderLayerBacking::contentChanged()
will no longer trigger a updateGeometry() when it gets BackgroundImageChanged on non-
CoordinateGraphics platforms.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::RenderLayerBacking::updateAfterDescendants):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBoxDecorations):
(WebCore::canDirectlyCompositeBackgroundBackgroundImage):
(WebCore::hasPaintedBoxDecorationsOrBackgroundImage):
(WebCore::supportsDirectlyCompositedBoxDecorations):
(WebCore::RenderLayerBacking::paintsBoxDecorations):
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
(WebCore::RenderLayerBacking::contentChanged):
(WebCore::RenderLayerBacking::updateDirectlyCompositedContents): Deleted.
(WebCore::canCreateTiledImage): Deleted.
(WebCore::hasVisibleBoxDecorationsOrBackgroundImage): Deleted.
(WebCore::supportsDirectBoxDecorationsComposition): Deleted.

rendering/RenderLayerBacking.h:

1:05 PM Changeset in webkit [213428] by aakash_jain@apple.com

2 edits
1 add in trunk/Source/WebKit2

Add symbols required by TAPI from Shared/API/Cocoa/WebKit.m in a header file
https://bugs.webkit.org/show_bug.cgi?id=169162

Reviewed by Alexey Proskuryakov.

The symbols from binary and headers should match precisely, otherwise TAPI would
complain. There are few symbols which are not actually needed in header file, but
we still need to add them in a header file to make TAPI happy.

Platform/ExtraPublicSymbolsForTAPI.h: Added.
WebKit2.xcodeproj/project.pbxproj: Added ExtraPublicSymbolsForTAPI.h

11:53 AM Changeset in webkit [213427] by aakash_jain@apple.com

2 edits
1 add in trunk/Source/WebKit2

Add symbols required by TAPI in a header file
https://bugs.webkit.org/show_bug.cgi?id=169113
<rdar://problem/30772033>

Reviewed by Alexey Proskuryakov.

Platform/ExtraPrivateSymbolsForTAPI.h: Added.
WebKit2.xcodeproj/project.pbxproj: Added Platform/ExtraPrivateSymbolsForTAPI.h

11:32 AM Changeset in webkit [213426] by Michael Catanzaro

2 edits in trunk

Unreviewed, remove stray period from readme

ReadMe.md:

10:07 AM Changeset in webkit [213425] by Csaba Osztrogonác

2 edits in trunk/Source/JavaScriptCore

[ARM] Unreviewed buildfix after r213376.

assembler/ARMAssembler.h:

(JSC::ARMAssembler::isBkpt): Typo fixed.

9:31 AM Changeset in webkit [213424] by commit-queue@webkit.org

4 edits in trunk/Source

Cleanup after r213418
https://bugs.webkit.org/show_bug.cgi?id=169165

Patch by Alex Christensen <achristensen@webkit.org> on 2017-03-04
Reviewed by Youenn Fablet.

Source/ThirdParty/libwebrtc:

WebKit/patch-libwebrtc:

I made another change after the last patch I uploaded to stop crashing.
This should be reflected in our patch.

Source/WebCore:

platform/mediastream/mac/RealtimeIncomingAudioSource.cpp:

(WebCore::RealtimeIncomingAudioSource::OnData):
Restore the assertion I removed.

9:15 AM Changeset in webkit [213423] by commit-queue@webkit.org

38 edits
2 adds
22 deletes in trunk

Unreviewed, rolling out r213379.
https://bugs.webkit.org/show_bug.cgi?id=169169

broke GTK+ and Windows builds (Requested by mcatanzaro on
#webkit).

Reverted changeset:

"Enable fieldsets to be flexboxes, grids and multicolumn."
https://bugs.webkit.org/show_bug.cgi?id=169082
http://trac.webkit.org/changeset/213379

6:52 AM Changeset in webkit [213422] by Lucas Forschler

1 edit in trunk/Tools/ChangeLog

Test commit against svn.webkit.org after SHA-1 cleanup.

Unreviewed.

12:57 AM Changeset in webkit [213421] by Nikita Vasilyev

10 edits
8 adds in trunk

Web Inspector: Show Web Socket connections in Network tab
https://bugs.webkit.org/show_bug.cgi?id=167520

Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

Show Web Socket connections in Network and Resources tabs. Display HTTP headers
of Web Socket handshake request in the details sidebar.

UserInterface/Controllers/FrameResourceManager.js:

(WebInspector.FrameResourceManager.prototype.initialize):
(WebInspector.FrameResourceManager.prototype.webSocketCreated):
(WebInspector.FrameResourceManager.prototype.webSocketWillSendHandshakeRequest):
webSocketWillSendHandshakeRequest doesn't receive a request URL as one of its parameters.
Store URLs received from webSocketCreated method in _webSocketIdentifierToURL map.

(WebInspector.FrameResourceManager.prototype.webSocketHandshakeResponseReceived):
(WebInspector.FrameResourceManager.prototype.webSocketFrameReceived):
(WebInspector.FrameResourceManager.prototype.webSocketFrameSent):
(WebInspector.FrameResourceManager.prototype.webSocketClosed):
Mark resource as finished when Web Socket handshake is complete or Web Socket is closed.
This may change in the future.

(WebInspector.FrameResourceManager.prototype._webSocketFrameReceivedOrSent):

UserInterface/Main.html:

UserInterface/Models/WebSocketResource.js: Added.

(WebInspector.WebSocketResource):
(WebInspector.WebSocketResource.prototype.set readyState):
(WebInspector.WebSocketResource.prototype.get readyState):
(WebInspector.WebSocketResource.prototype.get frames):
(WebInspector.WebSocketResource.prototype.addFrame):
Introduce WebSocketResource model to store WebSocket frames (incoming and outgoing messages)
and readyState.

UserInterface/Protocol/NetworkObserver.js:

(WebInspector.NetworkObserver.prototype.webSocketCreated):
(WebInspector.NetworkObserver.prototype.webSocketWillSendHandshakeRequest):
(WebInspector.NetworkObserver.prototype.webSocketHandshakeResponseReceived):
(WebInspector.NetworkObserver.prototype.webSocketClosed):
(WebInspector.NetworkObserver.prototype.webSocketFrameReceived):
(WebInspector.NetworkObserver.prototype.webSocketFrameError):
(WebInspector.NetworkObserver.prototype.webSocketFrameSent):
(WebInspector.NetworkObserver):
Add corresponding methods for the newly added FrameResourceManager methods.

UserInterface/Test.html:
UserInterface/Views/NetworkSidebarPanel.js:

(WebInspector.NetworkSidebarPanel.prototype.treeElementAddedOrChanged):
Don't show the go to arrow for WebSocket items since WebSocketContentView isn't implemented
yet.

UserInterface/Views/ResourceClusterContentView.js:

(WebInspector.ResourceClusterContentView.prototype.get responseContentView):
Don't show any content views for WebSocket items.

UserInterface/Views/ResourceTreeElement.js:

(WebInspector.ResourceTreeElement.prototype.ondblclick):
Don't open WebSocket URL in a new browser tab.

LayoutTests:

http/tests/websocket/tests/hybi/inspector/client-close-expected.txt: Added.
http/tests/websocket/tests/hybi/inspector/client-close.html: Added.
http/tests/websocket/tests/hybi/inspector/client-close_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

http/tests/websocket/tests/hybi/inspector/server-close-expected.txt: Added.
http/tests/websocket/tests/hybi/inspector/server-close.html: Added.
http/tests/websocket/tests/hybi/inspector/server-close_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

platform/ios-simulator/TestExpectations:

12:38 AM Changeset in webkit [213420] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

Remove duplicate initialization guard in WebKit2 logging initialization
https://bugs.webkit.org/show_bug.cgi?id=169164

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-03-04
Reviewed by Dan Bernstein.

Platform/Logging.cpp:

(WebKit::initializeLogChannelsIfNecessary):

12:20 AM Changeset in webkit [213419] by achristensen@apple.com

2 edits in trunk/Source/WTF

[Win64] 'int128_t': undeclared identifier in MediaTime.cpp
https://bugs.webkit.org/show_bug.cgi?id=169123

Patch by Jer Noble <jer.noble@apple.com> on 2017-03-03
Reviewed by Alex Christensen.

Don't perform the 128-bit optimized path on Windows, where the int128_t intrinsic isn't available.

wtf/MediaTime.cpp:

(WTF::MediaTime::setTimeScale):

Mar 3, 2017:

11:57 PM Changeset in webkit [213418] by achristensen@apple.com

1413 edits
776 adds
422 deletes in trunk/Source

[WebRTC] Update libwebrtc source code
https://bugs.webkit.org/show_bug.cgi?id=168599

Patch by Youenn Fablet <youenn@apple.com> on 2017-03-03
Reviewed by Alex Christensen.

Source/ThirdParty/libwebrtc:

Very long list of file changes omitted.

We updated to git commit 716e726ef0b322e8317b749613691da043bfc61c
of https://chromium.googlesource.com/external/webrtc and applied
the changes that are now in WebKit/patch-libwebrtc

Source/WebCore:

Modules/mediastream/RTCStatsReport.h:
Modules/mediastream/RTCStatsReport.idl:

Update to match the latest spec, which matches the new structures in libwebrtc.

Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::fillRTCRTPStreamStats):
(WebCore::fillOutboundRTPStreamStats):

Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:
platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:
platform/mediastream/mac/RealtimeIncomingAudioSource.cpp:

(WebCore::RealtimeIncomingAudioSource::OnData):
Comment out an assertion that was failing. We should revisit this.

testing/MockLibWebRTCPeerConnection.h:

Source/WebKit2:

WebProcess/Network/webrtc/LibWebRTCProvider.cpp:

9:49 PM Changeset in webkit [213417] by commit-queue@webkit.org

11 edits
15 deletes in trunk

Unreviewed, rolling out r213400.
https://bugs.webkit.org/show_bug.cgi?id=169163

Caused frequent assertion failures (Requested by ap on
#webkit).

Reverted changeset:

"[Modern Media Controls] Improve media documents across macOS,
iPhone and iPad"
https://bugs.webkit.org/show_bug.cgi?id=169145
http://trac.webkit.org/changeset/213400

9:01 PM Changeset in webkit [213416] by clopez@igalia.com

2 edits in trunk/Source/JavaScriptCore

[JSC] build fix after r213399
https://bugs.webkit.org/show_bug.cgi?id=169154

Unreviewed.

runtime/ConfigFile.cpp: Include unistd.h since its where getcwd() is defined.

6:43 PM Changeset in webkit [213415] by matthew_hanson@apple.com

1 copy in tags/Safari-603.1.30.1.32

Tag Safari-603.1.30.1.32.

6:43 PM Changeset in webkit [213414] by matthew_hanson@apple.com

1 copy in tags/Safari-603.1.30.0.33

Tag Safari-603.1.30.0.33.

6:21 PM Changeset in webkit [213413] by jmarcell@apple.com

6 edits in tags/Safari-604.1.8.1.1/Source

Versioning.

6:16 PM Changeset in webkit [213412] by aestes@apple.com

15 edits
3 adds in trunk

Add support for canvas.toBlob
https://bugs.webkit.org/show_bug.cgi?id=148878
<rdar://problem/22590406>

Reviewed by Tim Horton.

LayoutTests/imported/w3c:

web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.jpeg-expected.txt:
web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.png-expected.txt:

Source/WebCore:

These tests now pass:
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.jpeg.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-canvas-element/toBlob.png.html

CMakeLists.txt:
DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
fileapi/BlobCallback.cpp: Added.

(WebCore::BlobCallback::scheduleCallback):

fileapi/BlobCallback.h: Added.

(WebCore::BlobCallback::~BlobCallback):

fileapi/BlobCallback.idl: Added.
html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::toBlob):

html/HTMLCanvasElement.h:
html/HTMLCanvasElement.idl:
platform/graphics/ImageBuffer.h:
platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::writeFunction):
(WebCore::encodeImage):
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageBuffer::toData):

platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::data):
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageBuffer::toData):
(WebCore::ImageBuffer::toCGImage):
(WebCore::cgImage):
(WebCore::dataURL):

platform/graphics/gtk/ImageBufferGtk.cpp:

(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageBuffer::toData):

platform/graphics/win/ImageBufferDirect2D.cpp:

(WebCore::ImageBuffer::toData):

6:15 PM Changeset in webkit [213411] by jmarcell@apple.com

1 copy in tags/Safari-604.1.8.1.1

Tag Safari-604.1.8.1.1.

6:08 PM Changeset in webkit [213410] by dino@apple.com

32 edits in trunk

Add WebGPU compile flag and experimental feature flag
https://bugs.webkit.org/show_bug.cgi?id=169161
<rdar://problem/30846689>

Reviewed by Tim Horton.

Add ENABLE_WEBGPU, an experimental feature flag, a RuntimeEnabledFeature,
and an InternalSetting.

Source/cmake/OptionsMac.cmake:
Source/cmake/WebKitFeatures.cmake:
Source/cmake/tools/vsprops/FeatureDefines.props:
Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Configurations/FeatureDefines.xcconfig:
page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setWebGPUEnabled):
(WebCore::RuntimeEnabledFeatures::webGPUEnabled):

testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setWebGPUEnabled):

testing/InternalSettings.h:
testing/InternalSettings.idl:

Source/WebCore/PAL:

Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Configurations/FeatureDefines.xcconfig:
WebView/WebPreferenceKeysPrivate.h:
WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences webGPUEnabled]):
(-[WebPreferences setWebGPUEnabled:]):

WebView/WebPreferencesPrivate.h:
WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Source/WebKit2:

Configurations/FeatureDefines.xcconfig:
Shared/WebPreferencesDefinitions.h:
WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Tools:

DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures):
(resetWebPreferencesToConsistentValues):

TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setWebGL2Enabled):
(WTR::TestRunner::setWebGPUEnabled):

WebKitTestRunner/InjectedBundle/TestRunner.h:

6:04 PM Changeset in webkit [213409] by jmarcell@apple.com

2 edits in tags/Safari-604.1.8.0.2/Source/WebKit/mac

Merge r213373. rdar://problem/30825660

6:04 PM Changeset in webkit [213408] by jmarcell@apple.com

2 edits in tags/Safari-604.1.8.0.2/Source/WebKit2

Merge r213394. rdar://problem/30825728

5:56 PM Changeset in webkit [213407] by jmarcell@apple.com

6 edits in tags/Safari-604.1.8.0.2/Source

Versioning.

5:52 PM Changeset in webkit [213406] by matthew_hanson@apple.com

9 edits
2 adds in branches/safari-603.1.30.0-branch

Merge r213253. rdar://problem/30773140

5:45 PM Changeset in webkit [213405] by Simon Fraser

3 edits in trunk/Source/WebCore

Clean up some RenderLayerBacking code
https://bugs.webkit.org/show_bug.cgi?id=169160

Reviewed by Dean Jackson.

Modern loops in descendantLayerPaintsIntoAncestor().

Rename RenderLayerBacking::paintsChildren() to RenderLayerBacking::paintsChildRenderers() to clarify that
it refers to renderers, not RenderLayers.

Rename RenderLayerBacking::paintsNonDirectCompositedBoxDecoration() to RenderLayerBacking::paintsBoxDecorations().
"Paints" already implies non-composited.

No behavior change.

rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateDrawsContent):
(WebCore::RenderLayerBacking::paintsBoxDecorations):
(WebCore::RenderLayerBacking::paintsChildRenderers):
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
(WebCore::descendantLayerPaintsIntoAncestor):
(WebCore::RenderLayerBacking::paintsNonDirectCompositedBoxDecoration): Deleted.
(WebCore::RenderLayerBacking::paintsChildren): Deleted.

rendering/RenderLayerBacking.h:

5:45 PM Changeset in webkit [213404] by Simon Fraser

6 edits in trunk/Source/WebCore

Clean up RenderImage and a RenderImageResource function
https://bugs.webkit.org/show_bug.cgi?id=169153

Reviewed by Zalan Bujtas.

Change all calls to imageResource().cachedImage() in RenderImage to use the inline
cachedImage() function.

In RenderImage::paintReplaced(), early return after the broken image block (and no need
to test imageResource().hasImage() again in the second condition). Convert height/width to size,
which also forces us to be explicit about using flooredIntSize() when fetching the image
(perhaps this should be a roundedIntSize, but I didn't want to change behavior).

Change RenderImageResource::image() to take an IntSize, rather than int height and width.

No behavior change.

rendering/RenderImage.cpp:

(WebCore::RenderImage::styleDidChange):
(WebCore::RenderImage::imageChanged):
(WebCore::RenderImage::notifyFinished):
(WebCore::RenderImage::paintReplaced):
(WebCore::RenderImage::paintIntoRect):
(WebCore::RenderImage::foregroundIsKnownToBeOpaqueInRect):
(WebCore::RenderImage::embeddedContentBox):

rendering/RenderImageResource.cpp:

(WebCore::RenderImageResource::image):

rendering/RenderImageResource.h:

(WebCore::RenderImageResource::image):

rendering/RenderImageResourceStyleImage.cpp:

(WebCore::RenderImageResourceStyleImage::image):

rendering/RenderImageResourceStyleImage.h:

5:45 PM Changeset in webkit [213403] by jmarcell@apple.com

1 copy in tags/Safari-604.1.8.0.2

New Tag.

5:42 PM Changeset in webkit [213402] by jmarcell@apple.com

2 edits in tags/Safari-604.1.8.0.1/Source/WebKit2

Roll out r213394 via r213396. rdar://problem/30825728

5:42 PM Changeset in webkit [213401] by jmarcell@apple.com

2 edits in tags/Safari-604.1.8.0.1/Source/WebKit/mac

Roll out r213373 via r213388. rdar://problem/30825660

5:12 PM Changeset in webkit [213400] by commit-queue@webkit.org

11 edits
2 copies
17 adds in trunk

[Modern Media Controls] Improve media documents across macOS, iPhone and iPad
https://bugs.webkit.org/show_bug.cgi?id=169145
<rdar://problem/17048858>

Patch by Antoine Quint <Antoine Quint> on 2017-03-03
Reviewed by Dean Jackson.

Source/WebCore:

There were a variety of issues with media documents, some longstanding, and some specifically
about modern media controls.

One issue was that fullscreen and picture-in-picture buttons would show for audio media documents,
due to using a <video> element to load the audio file. We now have additional logic in MediaController
to identify if the loaded media is really an audio file, and using this information to hide the
fullscreen and picture-in-picture buttons.

Another issue was that we would inject style in MediaDocument.cpp that was specific to modern media
controls when we could have the modern-media-controls module injected CSS handle this styling. We now
use the injected style in the shadow root to size media documents based on the device characteristics
and ensuring that page styles are overridden.

We also simplify how MediaDocument.cpp sets the source of the media element to simply use the "src"
attribute and not a <source> element.

Finally, we introduce a MediaDocumentController class that is instantiated when we're dealing with
a media document to hide the controls while we determine the type of media we're loading (audio vs.
video) in order to apply the appropriate styling without flashes.

As a result of the new styles applied by the modern-media-controls module, media documents have a
similar behavior on macOS and iPad, where we only enforce a min-width for video allowing them
to play at their natural size otherwise, and enforcing a fixed width for audio. On iPhone however,
we want to always play the media at full width, with some padding in the case of audio.

Tests: media/modern-media-controls/fullscreen-support/fullscreen-support-disabled-video-with-audio-tracks-only.html

media/modern-media-controls/media-documents/ipad/media-document-audio-ios-sizing.html
media/modern-media-controls/media-documents/ipad/media-document-video-ios-sizing.html
media/modern-media-controls/media-documents/media-document-audio-ios-sizing.html
media/modern-media-controls/media-documents/media-document-audio-mac-sizing.html
media/modern-media-controls/media-documents/media-document-video-ios-sizing.html
media/modern-media-controls/media-documents/media-document-video-mac-sizing.html
media/modern-media-controls/pip-support/pip-support-disabled-video-with-audio-tracks-only.html

Modules/modern-media-controls/controls/ios-inline-media-controls.css:

(:host(audio) .media-controls.ios.inline > .controls-bar:before,):
(:host(audio) .media-controls.ios.inline > .controls-bar:before): Deleted.

Modules/modern-media-controls/controls/macos-media-controls.css:

(:host(audio) .media-controls.mac.inline > .controls-bar,):
(:host(audio) .media-controls.mac.inline > .controls-bar > .background-tint,):
(:host(audio) .media-controls.mac.inline > .controls-bar): Deleted.
(:host(audio) .media-controls.mac.inline > .controls-bar > .background-tint): Deleted.

Modules/modern-media-controls/controls/media-document.css: Added.

(:host(.media-document)):
(:host(.media-document.ready)):
(:host(.media-document.audio.mac)):
(:host(.media-document.audio.ipad)):
(:host(.media-document.audio.iphone)):
(:host(.media-document.video.mac)):
(:host(.media-document.video.ipad)):
(:host(.media-document.video.iphone)):

Modules/modern-media-controls/js-files:
Modules/modern-media-controls/media/fullscreen-support.js:

(FullscreenSupport.prototype.syncControl):
(FullscreenSupport):

Modules/modern-media-controls/media/media-controller.js:

(MediaController):
(MediaController.prototype.get isAudio):

Modules/modern-media-controls/media/media-document-controller.js: Added.

(MediaDocumentController):
(MediaDocumentController.prototype.handleEvent):
(MediaDocumentController.prototype._mediaDocumentHasMetadata):
(MediaDocumentController.prototype._mediaDocumentHasSize):

Modules/modern-media-controls/media/pip-support.js:

(PiPSupport.prototype.syncControl):
(PiPSupport):

html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):

LayoutTests:

We add new tests for media documents and related features that cover the following cases:

checking <video> with only audio tracks does not show the fullscreen button
checking <video> with only audio tracks does not show the picture-in-picture button
checking the size used in media documents for audio and video across macOS, iPhone and iPad

media/modern-media-controls/fullscreen-support/fullscreen-support-disabled-video-with-audio-tracks-only-expected.txt: Added.
media/modern-media-controls/fullscreen-support/fullscreen-support-disabled-video-with-audio-tracks-only.html: Added.
media/modern-media-controls/media-documents/ipad/media-document-audio-ios-sizing-expected.txt: Added.
media/modern-media-controls/media-documents/ipad/media-document-audio-ios-sizing.html: Added.
media/modern-media-controls/media-documents/ipad/media-document-video-ios-sizing-expected.txt: Added.
media/modern-media-controls/media-documents/ipad/media-document-video-ios-sizing.html: Added.
media/modern-media-controls/media-documents/media-document-audio-ios-sizing-expected.txt: Added.
media/modern-media-controls/media-documents/media-document-audio-ios-sizing.html: Added.
media/modern-media-controls/media-documents/media-document-audio-mac-sizing-expected.txt: Added.
media/modern-media-controls/media-documents/media-document-audio-mac-sizing.html: Added.
media/modern-media-controls/media-documents/media-document-video-ios-sizing-expected.txt: Added.
media/modern-media-controls/media-documents/media-document-video-ios-sizing.html: Added.
media/modern-media-controls/media-documents/media-document-video-mac-sizing-expected.txt: Added.
media/modern-media-controls/media-documents/media-document-video-mac-sizing.html: Added.
media/modern-media-controls/pip-support/pip-support-disabled-video-with-audio-tracks-only-expected.txt: Added.
media/modern-media-controls/pip-support/pip-support-disabled-video-with-audio-tracks-only.html: Added.
platform/ios-simulator/TestExpectations:
platform/mac/TestExpectations:

5:10 PM Changeset in webkit [213399] by msaboff@apple.com

3 edits in trunk/Source/JavaScriptCore

Add support for relative pathnames to JSC config files
https://bugs.webkit.org/show_bug.cgi?id=169154

Reviewed by Saam Barati.

If the config file is a relative path, prepend the current working directory.
After canonicalizing the config file path, we extract its directory path and
use that for the directory for a relative log pathname.

runtime/ConfigFile.cpp:

(JSC::ConfigFile::ConfigFile):
(JSC::ConfigFile::parse):
(JSC::ConfigFile::canonicalizePaths):

runtime/ConfigFile.h:

5:03 PM Changeset in webkit [213398] by dino@apple.com

2 edits in trunk/Source/WebKit2

Move Input Events and Gamepad from experimental features into main preferences
https://bugs.webkit.org/show_bug.cgi?id=169157
<rdar://problems/30845587>

Reviewed by Myles C. Maxfield.

These are no longer experimental on trunk.

Shared/WebPreferencesDefinitions.h:

4:55 PM Changeset in webkit [213397] by msaboff@apple.com

3 edits in trunk/Source/JavaScriptCore

Add load / store exclusive instruction group to ARM64 disassembler
https://bugs.webkit.org/show_bug.cgi?id=169152

Reviewed by Filip Pizlo.

disassembler/ARM64/A64DOpcode.cpp:

(JSC::ARM64Disassembler::A64DOpcodeLoadStoreExclusive::format):

disassembler/ARM64/A64DOpcode.h:

(JSC::ARM64Disassembler::A64DOpcodeLoadStoreExclusive::opName):
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreExclusive::rs):
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreExclusive::rt2):
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreExclusive::o0):
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreExclusive::o1):
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreExclusive::o2):
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreExclusive::loadBit):
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreExclusive::opNumber):
(JSC::ARM64Disassembler::A64DOpcodeLoadStoreExclusive::isPairOp):

4:48 PM Changeset in webkit [213396] by jmarcell@apple.com

2 edits in tags/Safari-604.1.8.0.1/Source/WebKit2

Merge r213394. rdar://problem/30825728

4:48 PM Changeset in webkit [213395] by dino@apple.com

2 edits
1 add in trunk/Tools

Add a script to synchronize FeatureDefines.xcconfig files
https://bugs.webkit.org/show_bug.cgi?id=169151
<rdar://problem/30841856>

Reviewed by Simon Fraser.

I got sick of manually copying the FeatureDefines.xcconfig
files, so I added a script to do it. As long as you
run this after you've edited one, it will take the most
recently updated and copy it to all the others.

Scripts/sync-feature-defines: Added.
Scripts/webkitpy/style/checkers/featuredefines.py:

(FeatureDefinesChecker.check): Export the list of files,
and give a suggestion to use the sync script.

4:34 PM Changeset in webkit [213394] by Brent Fulgham

2 edits in trunk/Source/WebKit2

[MediaStream iOS] REGRESSION(r212883): Missing function definition breaks sandbox
https://bugs.webkit.org/show_bug.cgi?id=169148
<rdar://problem/30825728>

Reviewed by Alex Christensen.

The changes in r212883 added a call to 'shared-preferences-read', which is not defined
for iOS. In fact, it's not needed since 'user-preference-read' does everything we need on iOS.
Switch to the correct preference rule.

Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb: Add missing function

3:54 PM Changeset in webkit [213393] by Chris Dumez

11 edits
2 adds in trunk

[iOS] Throttle SVG SMIL animations to 30fps in low power mode
https://bugs.webkit.org/show_bug.cgi?id=169137
<rdar://problem/30833754>

Reviewed by Simon Fraser.

Source/WebCore:

Throttle SVG SMIL animations to 30fps in low power mode on iOS to save
battery.

Test: svg/animations/animations-lowPowerMode-throttling.html

svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::SVGSVGElement):

svg/SVGSVGElement.idl:
svg/animation/SMILTime.h:

(WebCore::SMILTime::SMILTime):

svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::SMILTimeContainer):
(WebCore::SMILTimeContainer::animationFrameDelay):
(WebCore::SMILTimeContainer::updateDocumentOrderIndexes):
(WebCore::SMILTimeContainer::updateAnimations):

svg/animation/SMILTimeContainer.h:
svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::calculateNextProgressTime):

testing/Internals.cpp:

(WebCore::Internals::svgAnimationsInterval):

testing/Internals.h:
testing/Internals.idl:

LayoutTests:

Add layout test coverage.

svg/animations/animations-lowPowerMode-throttling-expected.txt: Added.
svg/animations/animations-lowPowerMode-throttling.html: Added.

3:03 PM Changeset in webkit [213392] by Joseph Pecoraro

2 edits in trunk/Source/WebCore

[Mac] WebCore.framework is missing a symlink from Frameworks to Versions/Current/Frameworks when the latter exists
https://bugs.webkit.org/show_bug.cgi?id=169067

Reviewed by Dan Bernstein.

WebCore.xcodeproj/project.pbxproj:

2:38 PM Changeset in webkit [213391] by achristensen@apple.com

1 edit
1 delete in trunk/Source/ThirdParty/libwebrtc

Remove empty build directories.

build: Removed.
build/Debug: Removed.

2:35 PM Changeset in webkit [213390] by matthew_hanson@apple.com

5 edits in branches/safari-603.1.30.0-branch

Merge r213385. rdar://problem/30838985

2:35 PM Changeset in webkit [213389] by matthew_hanson@apple.com

9 edits
2 deletes in branches/safari-603.1.30.0-branch

Roll out r213253 via r213374. rdar://problem/30773140

2:34 PM Changeset in webkit [213388] by jmarcell@apple.com

2 edits in tags/Safari-604.1.8.0.1/Source/WebKit/mac

Merge r213373. rdar://problem/30825660

2:34 PM Changeset in webkit [213387] by matthew_hanson@apple.com

5 edits in branches/safari-603.1.30.1-branch

Merge r213385. rdar://problem/30838984

2:24 PM Changeset in webkit [213386] by keith_miller@apple.com

34 edits
2 copies
2 adds in trunk/Source

WASM should support faster loads.
https://bugs.webkit.org/show_bug.cgi?id=162693

Reviewed by Saam Barati.

Source/JavaScriptCore:

This patch adds support for WebAssembly using a 32-bit address
space for memory (along with some extra space for offset
overflow). With a 32-bit address space (we call them
Signaling/fast memories), we reserve the virtual address space for
2^{32 + offset bytes of memory and only mark the usable section as

read/write. If wasm code would read/write out of bounds we use a

custom signal handler to catch the SIGBUS. The signal handler then

checks if the faulting instruction is wasm code and tells the

thread to resume executing from the wasm exception

handler. Otherwise, the signal handler crashes the process, as

usual.}

All of the allocations of these memories are managed by the
Wasm::Memory class. In order to avoid TLB churn in the OS we cache
old Signaling memories that are no longer in use. Since getting
the wrong memory can cause recompiles, we try to reserve a memory
for modules that do not import a memory. If a module does import a
memory, we try to guess the type of memory we are going to get
based on the last one allocated.

This patch also changes how the wasm JS-api manages objects. Since
we can compile different versions of code, this patch adds a new
JSWebAssemblyCodeBlock class that holds all the information
specific to running a module in a particular bounds checking
mode. Additionally, the Wasm::Memory object is now a reference
counted class that is shared between the JSWebAssemblyMemory
object and the ArrayBuffer that also views it.

JavaScriptCore.xcodeproj/project.pbxproj:
jit/JITThunks.cpp:

(JSC::JITThunks::existingCTIStub):

jit/JITThunks.h:
jsc.cpp:

(jscmain):

runtime/Options.h:
runtime/VM.cpp:

(JSC::VM::VM):

runtime/VM.h:
wasm/JSWebAssemblyCodeBlock.h: Copied from Source/JavaScriptCore/wasm/js/JSWebAssemblyModule.h.

(JSC::JSWebAssemblyCodeBlock::create):
(JSC::JSWebAssemblyCodeBlock::createStructure):
(JSC::JSWebAssemblyCodeBlock::functionImportCount):
(JSC::JSWebAssemblyCodeBlock::mode):
(JSC::JSWebAssemblyCodeBlock::module):
(JSC::JSWebAssemblyCodeBlock::jsEntrypointCalleeFromFunctionIndexSpace):
(JSC::JSWebAssemblyCodeBlock::wasmEntrypointCalleeFromFunctionIndexSpace):
(JSC::JSWebAssemblyCodeBlock::setJSEntrypointCallee):
(JSC::JSWebAssemblyCodeBlock::setWasmEntrypointCallee):
(JSC::JSWebAssemblyCodeBlock::callees):
(JSC::JSWebAssemblyCodeBlock::offsetOfCallees):
(JSC::JSWebAssemblyCodeBlock::allocationSize):

wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::getMemoryBaseAndSize):
(JSC::Wasm::B3IRGenerator::emitCheckAndPreparePointer):
(JSC::Wasm::B3IRGenerator::emitLoadOp):
(JSC::Wasm::B3IRGenerator::emitStoreOp):

wasm/WasmCallingConvention.h:
wasm/WasmFaultSignalHandler.cpp: Added.

(JSC::Wasm::trapHandler):
(JSC::Wasm::registerCode):
(JSC::Wasm::unregisterCode):
(JSC::Wasm::fastMemoryEnabled):
(JSC::Wasm::enableFastMemory):

wasm/WasmFaultSignalHandler.h: Copied from Source/JavaScriptCore/wasm/js/JSWebAssemblyCallee.cpp.
wasm/WasmFormat.h:

(JSC::Wasm::ModuleInformation::importFunctionCount):
(JSC::Wasm::ModuleInformation::hasMemory): Deleted.

wasm/WasmMemory.cpp:

(JSC::Wasm::mmapBytes):
(JSC::Wasm::Memory::lastAllocatedMode):
(JSC::Wasm::availableFastMemories):
(JSC::Wasm::tryGetFastMemory):
(JSC::Wasm::releaseFastMemory):
(JSC::Wasm::Memory::Memory):
(JSC::Wasm::Memory::createImpl):
(JSC::Wasm::Memory::create):
(JSC::Wasm::Memory::~Memory):
(JSC::Wasm::Memory::grow):
(JSC::Wasm::Memory::dump):
(JSC::Wasm::Memory::makeString):

wasm/WasmMemory.h:

(JSC::Wasm::Memory::operator bool):
(JSC::Wasm::Memory::size):
(JSC::Wasm::Memory::check):
(JSC::Wasm::Memory::Memory): Deleted.
(JSC::Wasm::Memory::offsetOfMemory): Deleted.
(JSC::Wasm::Memory::offsetOfSize): Deleted.

wasm/WasmMemoryInformation.cpp:

(JSC::Wasm::MemoryInformation::MemoryInformation):

wasm/WasmMemoryInformation.h:

(JSC::Wasm::MemoryInformation::hasReservedMemory):
(JSC::Wasm::MemoryInformation::takeReservedMemory):
(JSC::Wasm::MemoryInformation::mode):

wasm/WasmModuleParser.cpp:
wasm/WasmModuleParser.h:

(JSC::Wasm::ModuleParser::ModuleParser):

wasm/WasmPlan.cpp:

(JSC::Wasm::Plan::parseAndValidateModule):
(JSC::Wasm::Plan::run):

wasm/WasmPlan.h:

(JSC::Wasm::Plan::mode):

wasm/js/JSWebAssemblyCallee.cpp:

(JSC::JSWebAssemblyCallee::finishCreation):
(JSC::JSWebAssemblyCallee::destroy):

wasm/js/JSWebAssemblyCodeBlock.cpp: Added.

(JSC::JSWebAssemblyCodeBlock::JSWebAssemblyCodeBlock):
(JSC::JSWebAssemblyCodeBlock::destroy):
(JSC::JSWebAssemblyCodeBlock::isSafeToRun):
(JSC::JSWebAssemblyCodeBlock::visitChildren):
(JSC::JSWebAssemblyCodeBlock::UnconditionalFinalizer::finalizeUnconditionally):

wasm/js/JSWebAssemblyInstance.cpp:

(JSC::JSWebAssemblyInstance::setMemory):
(JSC::JSWebAssemblyInstance::finishCreation):
(JSC::JSWebAssemblyInstance::visitChildren):

wasm/js/JSWebAssemblyInstance.h:

(JSC::JSWebAssemblyInstance::module):
(JSC::JSWebAssemblyInstance::codeBlock):
(JSC::JSWebAssemblyInstance::memoryMode):
(JSC::JSWebAssemblyInstance::setMemory): Deleted.

wasm/js/JSWebAssemblyMemory.cpp:

(JSC::JSWebAssemblyMemory::create):
(JSC::JSWebAssemblyMemory::JSWebAssemblyMemory):
(JSC::JSWebAssemblyMemory::buffer):
(JSC::JSWebAssemblyMemory::grow):
(JSC::JSWebAssemblyMemory::destroy):

wasm/js/JSWebAssemblyMemory.h:

(JSC::JSWebAssemblyMemory::memory):
(JSC::JSWebAssemblyMemory::offsetOfMemory):
(JSC::JSWebAssemblyMemory::offsetOfSize):

wasm/js/JSWebAssemblyModule.cpp:

(JSC::JSWebAssemblyModule::buildCodeBlock):
(JSC::JSWebAssemblyModule::create):
(JSC::JSWebAssemblyModule::JSWebAssemblyModule):
(JSC::JSWebAssemblyModule::codeBlock):
(JSC::JSWebAssemblyModule::finishCreation):
(JSC::JSWebAssemblyModule::visitChildren):
(JSC::JSWebAssemblyModule::UnconditionalFinalizer::finalizeUnconditionally): Deleted.

wasm/js/JSWebAssemblyModule.h:

(JSC::JSWebAssemblyModule::takeReservedMemory):
(JSC::JSWebAssemblyModule::signatureIndexFromFunctionIndexSpace):
(JSC::JSWebAssemblyModule::codeBlock):
(JSC::JSWebAssemblyModule::functionImportCount): Deleted.
(JSC::JSWebAssemblyModule::jsEntrypointCalleeFromFunctionIndexSpace): Deleted.
(JSC::JSWebAssemblyModule::wasmEntrypointCalleeFromFunctionIndexSpace): Deleted.
(JSC::JSWebAssemblyModule::setJSEntrypointCallee): Deleted.
(JSC::JSWebAssemblyModule::setWasmEntrypointCallee): Deleted.
(JSC::JSWebAssemblyModule::callees): Deleted.
(JSC::JSWebAssemblyModule::offsetOfCallees): Deleted.
(JSC::JSWebAssemblyModule::allocationSize): Deleted.

wasm/js/WebAssemblyFunction.cpp:

(JSC::callWebAssemblyFunction):

wasm/js/WebAssemblyInstanceConstructor.cpp:

(JSC::constructJSWebAssemblyInstance):

wasm/js/WebAssemblyMemoryConstructor.cpp:

(JSC::constructJSWebAssemblyMemory):

wasm/js/WebAssemblyModuleConstructor.cpp:

(JSC::WebAssemblyModuleConstructor::createModule):

wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::link):
(JSC::WebAssemblyModuleRecord::evaluate):

Source/WTF:

Add new forms of dataLog that take a boolean which describes if the log should happen. This makes cases where we have a static const bool for printing nicer since you can do:

dataLogIf(verbose, things, to, print);

instead of:

if (verbose)

dataLog(things, to, print);

Also, add a operator! to Ref that has the same semantics as C++ refs.

wtf/DataLog.h:

(WTF::dataLogLn):
(WTF::dataLogIf):
(WTF::dataLogLnIf):

wtf/Ref.h:

(WTF::Ref::operator!):

2:19 PM Changeset in webkit [213385] by weinig@apple.com

5 edits in trunk

REGRESSION (r209760): Apple Pay doesn't work on casper.com, shopspring.com, maybe other sites
<rdar://problem/30313445>
https://bugs.webkit.org/show_bug.cgi?id=169149

Reviewed by Simon Fraser.

Source/WebCore:

Relax restriction that the ApplePayShippingMethod sequence must not be empty. This
was incorrect.

Modules/applepay/ApplePaySession.cpp:

(WebCore::convertAndValidate):

LayoutTests:

http/tests/ssl/applepay/ApplePaySession-expected.txt:
http/tests/ssl/applepay/ApplePaySession.html:

Update test for relaxed ApplePayShippingMethod sequence requirements.

1:50 PM Changeset in webkit [213384] by achristensen@apple.com

8 edits in trunk

[URLParser] Fix file: as a relative file URL
https://bugs.webkit.org/show_bug.cgi?id=169122

Reviewed by Tim Horton.

Source/WebCore:

This is clearly defined in https://url.spec.whatwg.org/#file-state with the EOF code point.
I got it wrong and didn't test it. It's been added to the web platform tests since we last updated.

platform/URLParser.cpp:

(WebCore::URLParser::parse):

Tools:

TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::TEST_F):

LayoutTests:

TestExpectations:

We don't need to skip url-setters.html any more. It used to assert before the new URLParser was enabled.

fast/loader/url-parse-1-expected.txt:
fast/url/file-expected.txt:

We used to add a strange and unnecessary :/ at the end of the URL.

1:38 PM Changeset in webkit [213383] by aakash_jain@apple.com

4 edits
1 add in trunk/Source/WebKit2

Move declaration of _WKSetCrashReportApplicationSpecificInformation to header file
https://bugs.webkit.org/show_bug.cgi?id=169043

Reviewed by Alex Christensen.

WebKit2.xcodeproj/project.pbxproj: Added WebProcessCocoa.h
WebProcess/cocoa/WebProcessCocoa.h: Added.
WebProcess/cocoa/WebProcessCocoa.mm: Imported WebProcessCocoa.h
Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm: Ditto.

1:37 PM Changeset in webkit [213382] by Ryan Haddad

2 edits in trunk/LayoutTests

Add Debug flag to TestExpectation for webrtc/audio-peer-connection-webaudio.html.

Unreviewed test gardening.

TestExpectations:

1:37 PM Changeset in webkit [213381] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

Gardening: fix broken ARM64 build.
https://bugs.webkit.org/show_bug.cgi?id=169139

Not reviewed.

assembler/ARM64Assembler.h:

(JSC::ARM64Assembler::excepnGenerationImmMask):

1:29 PM Changeset in webkit [213380] by Ryan Haddad

2 edits in trunk/LayoutTests

Mark performance-api/performance-observer-periodic.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=168136

Unreviewed test gardening.

platform/mac/TestExpectations:

1:16 PM Changeset in webkit [213379] by hyatt@apple.com

38 edits
22 adds
2 deletes in trunk

Enable fieldsets to be flexboxes, grids and multicolumn.
https://bugs.webkit.org/show_bug.cgi?id=169082

Reviewed by Simon Fraser.

Source/WebCore:

Added new tests in fast/forms/fieldset.

This patch eliminates RenderFieldset and moves the functionality into RenderBlock so that
derived classes can also be fieldsets.

CMakeLists.txt:
WebCore.xcodeproj/project.pbxproj:

Remove RenderFieldset from the project.

accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::titleUIElement):
Call in to RenderBlock now instead of RenderFieldset.

html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::createElementRenderer):

html/HTMLFieldSetElement.h:

The fieldset DOM element now uses RenderElement::createFor to make renderers so that multiple display types
can be supported. A special flag has been added that indicates only to make flexbox and block-related
renderers (not table display types).

rendering/OrderIterator.cpp:

(WebCore::OrderIterator::shouldSkipChild):
(WebCore::OrderIteratorPopulator::collectChild):

rendering/OrderIterator.h:

Streamline child collection for flexboxes and grids to indicate whether the child should be skipped as a return
value from collectChild. Add a shouldSkipChild method that skips both out of flow positioned objects and
excluded children like the legends of fieldsets.

rendering/RenderBlock.cpp:

(WebCore::RenderBlockRareData::RenderBlockRareData):
When the legend is taller than the fieldset's borderBefore(), intrinsic border is added to the CSS border width.
This intrinsic border being factored in ensures that the padding and content boxes of fieldsets are correct
across any layout system, since the legend is now just treated as part of the border.

(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
Call the new computePreferredWidthsForExcludedChildren to ensure that excluded children contribute to
preferred width in their own way and not as part of a specific layout system.

(WebCore::RenderBlock::renderName):
Hacked to still return RenderFieldSet for RenderBlockFlow-backed fieldsets for layout test compatibility.

(WebCore::RenderBlock::layoutExcludedChildren):
Renamed from layoutSpecialExcludedChild to more accurately reflect the fact that multiple excluded children
can be included here (e.g., both a multicolumn flow thread and a legend). The RenderBlock base class handles
the layout of legends by both placing them and setting the correct intrinsic border before amount on the
block.

(WebCore::RenderBlock::findFieldsetLegend):
Moved from RenderFieldset.

(WebCore::RenderBlock::adjustBorderBoxRectForPainting):
(WebCore::RenderBlock::paintRectToClipOutFromBorder):
These methods are used when painting to shrink the border box as needed to account for the legend and to
provide the portion of the border that needs to be clipped out. These methods have been enhanced to
properly support all writing modes.

(WebCore::RenderBlock::intrinsicBorderForFieldset):
(WebCore::RenderBlock::setIntrinsicBorderForFieldset):
(WebCore::RenderBlock::borderTop):
(WebCore::RenderBlock::borderLeft):
(WebCore::RenderBlock::borderBottom):
(WebCore::RenderBlock::borderRight):
(WebCore::RenderBlock::borderBefore):
These methods are overridden for border to ensure that the intrinsic border added by a tall legend is
properly factored in.

(WebCore::RenderBlock::computePreferredWidthsForExcludedChildren):

rendering/RenderBlock.h:

This method computes the preferred widths for legend children in order to ensure that the legend properly
grows the width of the fieldset when it is the widest item.

(WebCore::RenderBlock::adjustBorderBoxLogicalHeightForBoxSizing):
(WebCore::RenderBlock::adjustContentBoxLogicalHeightForBoxSizing):
Preserve the behavior of fieldsets in that the available content size includes the space lost accounting
for the legend. I don't think this makes much sense, but it matches the behavior of other browsers
(and our old behavior).

(WebCore::RenderBlock::paintExcludedChildrenInBorder):
Method for painting the excluded children that might be present in our border. We only do this if the
paint phase is a box decoration painting phase and if the legend isn't self-painting.

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::willCreateColumns):
Allow fieldsets to create columns now.

(WebCore::RenderBlockFlow::layoutBlockChildren):
(WebCore::RenderBlockFlow::layoutExcludedChildren):
Renamed this method and change it to call the base class to ensure that legends in multicolumn fieldsets
get handled properly.

(WebCore::RenderBlockFlow::addChild):
Patched to make sure legends don't get put into the multicolumn flow thread, as they need to
remain outside of it.

(WebCore::RenderBlockFlow::layoutSpecialExcludedChild): Deleted.
Renamed to layoutExcludedChildren.

rendering/RenderBlockFlow.h:
rendering/RenderBox.cpp:

(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::paintMask):
Patched to call the new adjustBorderBoxRectForPainting and paintRectToClipOutFromBorder methods in
order to properly shrink the border box rect for painting and to clip out the portion of the border
covered by the legend.

(WebCore::RenderBox::avoidsFloats):
Add fieldsets as avoiding floats. RenderFieldset used to subclass this method to return true, but with
its removal, we need to put this in the base class along with legends.

rendering/RenderBox.h:

(WebCore::RenderBox::isGridItem):
(WebCore::RenderBox::isFlexItem):
Patched to exclude legends so that they don't try to size like they are really in the grid or flexbox.

(WebCore::RenderBox::adjustBorderBoxRectForPainting):
This method is overridden by RenderBLock to handle adjusting fieldset border rects for painting.

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintBorder):

rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::paintRectToClipOutFromBorder):
Patched to properly paint fieldsets using the new helpers.

rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::FlexBoxIterator::next):
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
Make sure deprecated flexible boxes lay out their legends properly by calling layoutExcludedChildren.

rendering/RenderElement.cpp:

(WebCore::RenderElement::createFor):

rendering/RenderElement.h:

Patched to take a flag that limits what renderers can be created so that fieldsets don't make table
display types.

rendering/RenderFieldset.cpp: Removed.
rendering/RenderFieldset.h: Removed.

Remove RenderFieldset files from the tree.

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeIntrinsicLogicalWidths):
(WebCore::RenderFlexibleBox::firstLineBaseline):
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::prepareOrderIteratorAndMargins):
Make sure flexible boxes lay out their legends properly by calling layoutExcludedChildren.
Patch methods to use the OrderIterator's new shouldSkipChild method to ensure legends aren't
part of the flexible box layout.

rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
(WebCore::RenderGrid::placeItemsOnGrid):
(WebCore::RenderGrid::populateExplicitGridAndOrderIterator):
(WebCore::RenderGrid::layoutGridItems):
Make sure grids lay out their legends properly by calling layoutExcludedChildren.
Patch methods to use the OrderIterator's new shouldSkipChild method to ensure legends aren't
part of the grid's layout.

rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::populate):
Pull legends back up into the block and don't let them be part of the flow thread.

rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::requiresBalancing):
Fix an assert to allow legends to exist as siblings of multicolumn sets.

rendering/RenderObject.cpp:

(WebCore::RenderObject::isFieldset):
Changed to examine the HTML element rather than RenderFieldset.

rendering/RenderObject.h:

(WebCore::RenderObject::isExcludedFromNormalLayout):
(WebCore::RenderObject::setIsExcludedFromNormalLayout):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
RenderObjects now have a new bit that is set for excluded objects like legends, flow threads,
placeholders, and ruby text. This bit lets code easily detect that an object is excluded from
the layout system and can be skipped.

(WebCore::RenderObject::isExcludedAndPlacedInBorder):
Helper method for asking if an object is painting inside the border. Used to know we
need to factor it into preferred width calculations outside of any one layout system
and also to know that we need to paint it when we paint the fieldset's border instead of
later (after we might have scrolled or clipped the child painting area).

rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::layoutExcludedChildren):
(WebCore::RenderRubyRun::layoutSpecialExcludedChild): Deleted.

rendering/RenderRubyRun.h:

Rename layoutSpecialExcludedChild to layoutExcludedChildren.

rendering/RenderTable.cpp:

(WebCore::RenderTable::adjustBorderBoxRectForPainting):
(WebCore::RenderTable::paintBoxDecorations):
(WebCore::RenderTable::paintMask):
(WebCore::RenderTable::subtractCaptionRect): Deleted.

rendering/RenderTable.h:

Patched tables to share the same border box rect adjustment used by fieldsets when subtracting
out captions. This is prep work to allow tables to be fieldsets, but for now I didn't go all the
way.

rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::paintBoxDecorations):
(WebCore::RenderTableCell::paintMask):
Make sure table cells adjust their border box rects for painting. Again this is prep work for
cells potentially being fieldsets, but not supported yet.

rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::layoutExcludedChildren):
(WebCore::RenderTextControl::layoutSpecialExcludedChild): Deleted.

rendering/RenderTextControl.h:
rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::layoutExcludedChildren):
(WebCore::RenderTextControlMultiLine::layoutSpecialExcludedChild): Deleted.

rendering/RenderTextControlMultiLine.h:

Renamed the methods for doing the excluded child layout.

rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):
Make sure to dump the original fieldset border and not the border with the extra legend stuff in it.

LayoutTests:

fast/forms/fieldset/abs-pos-child-sizing-expected.html: Added.
fast/forms/fieldset/abs-pos-child-sizing.html: Added.
fast/forms/fieldset/fieldset-deprecated-flexbox-expected.html: Added.
fast/forms/fieldset/fieldset-deprecated-flexbox.html: Added.
fast/forms/fieldset/fieldset-flexbox-expected.html: Added.
fast/forms/fieldset/fieldset-flexbox.html: Added.
fast/forms/fieldset/fieldset-grid-expected.html: Added.
fast/forms/fieldset/fieldset-grid.html: Added.
fast/forms/fieldset/fieldset-multicolumn-expected.html: Added.
fast/forms/fieldset/fieldset-multicolumn.html: Added.
fast/forms/fieldset/fieldset-overflow-auto-expected.html: Added.
fast/forms/fieldset/fieldset-overflow-auto.html: Added.
fast/forms/fieldset/fieldset-overflow-hidden-expected.html: Added.
fast/forms/fieldset/fieldset-overflow-hidden.html: Added.
fast/forms/fieldset/fieldset-positioned-children-expected.html: Added.
fast/forms/fieldset/fieldset-positioned-children.html: Added.
fast/forms/fieldset/fieldset-positioned-legend-expected.html: Added.
fast/forms/fieldset/fieldset-positioned-legend.html: Added.
fast/forms/fieldset/fieldset-self-painting-legend-expected.html: Added.
fast/forms/fieldset/fieldset-self-painting-legend.html: Added.
fast/forms/fieldset/fieldset-writing-modes-expected.html: Added.
fast/forms/fieldset/fieldset-writing-modes.html: Added.

1:15 PM Changeset in webkit [213378] by Ryan Haddad

15 edits
3 deletes in trunk

Unreviewed, rolling out r213344.

This changed caused LayoutTest crashes under GuardMalloc.

Reverted changeset:

"Add support for canvas.toBlob"
https://bugs.webkit.org/show_bug.cgi?id=148878
http://trac.webkit.org/changeset/213344

1:14 PM Changeset in webkit [213377] by Ryan Haddad

2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/IndexedDB/idbcursor_iterating.htm as flaky on El Capitan Release builds.
https://bugs.webkit.org/show_bug.cgi?id=164870

Unreviewed test gardening.

platform/mac-wk2/TestExpectations:

1:05 PM Changeset in webkit [213376] by mark.lam@apple.com

11 edits in trunk/Source/JavaScriptCore

Add MacroAssembler::isBreakpoint() query function.
https://bugs.webkit.org/show_bug.cgi?id=169139

Reviewed by Michael Saboff.

This will be needed soon when we use breakpoint instructions to implement
non-polling VM traps, and need to discern between a VM trap signal and a genuine
assertion breakpoint.

assembler/ARM64Assembler.h:

(JSC::ARM64Assembler::isBrk):
(JSC::ARM64Assembler::excepnGenerationImmMask):

assembler/ARMAssembler.h:

(JSC::ARMAssembler::isBkpt):

assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::isBkpt):

assembler/MIPSAssembler.h:

(JSC::MIPSAssembler::isBkpt):

assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::isBreakpoint):

assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::isBreakpoint):

assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::isBreakpoint):

assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::isBreakpoint):

assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::isBreakpoint):

assembler/X86Assembler.h:

(JSC::X86Assembler::isInt3):

11:38 AM Changeset in webkit [213375] by Konstantin Tokarev

2 edits in trunk/Source/WebCore

Unreviewed typo fix

features.json:

11:36 AM Changeset in webkit [213374] by matthew_hanson@apple.com

9 edits
2 adds in branches/safari-603.1.30.0-branch

Merge r213253. rdar://problem/30773140

10:59 AM Changeset in webkit [213373] by ap@apple.com

2 edits in trunk/Source/WebKit/mac

Build fix
rdar://problem/30825660

Suggested by Dan Bernstein.

Configurations/WebKitLegacy.xcconfig:

10:20 AM Changeset in webkit [213372] by eric.carlson@apple.com

2 edits in trunk/Source/WebCore

[MediaStream] Remove #if USE(VIDEOTOOLBOX) from AVVideoCaptureSource
https://bugs.webkit.org/show_bug.cgi?id=169131

Reviewed by Youenn Fablet.

platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::currentFrameCGImage):

10:12 AM Changeset in webkit [213371] by matthew_hanson@apple.com

5 edits in branches/safari-603.1.30.0-branch/Source

Versioning.

10:10 AM Changeset in webkit [213370] by matthew_hanson@apple.com

5 edits in branches/safari-603.1.30.1-branch/Source

Versioning.

9:51 AM Changeset in webkit [213369] by Chris Dumez

2 edits in trunk/Source/WebCore

Add assertion in Frame::setView() to make sure associated document has no living render tree
https://bugs.webkit.org/show_bug.cgi?id=169134

Reviewed by Brent Fulgham.

Add assertion in Frame::setView() to make sure associated document has no living render tree.
This is not supposed to happen and r213311 fixed one case where this could happen. We need
to find out if it can still happen.

page/Frame.cpp:

(WebCore::Frame::setView):

9:50 AM Changeset in webkit [213368] by matthew_hanson@apple.com

5 edits in branches/safari-603.1.30.4-branch/Source

Versioning.

9:48 AM Changeset in webkit [213367] by mark.lam@apple.com

4 edits in trunk/Source/JavaScriptCore

We should only check for traps that we're able to handle.
https://bugs.webkit.org/show_bug.cgi?id=169136

Reviewed by Michael Saboff.

The execute methods in interpreter were checking for the existence of any traps
(without masking) and only handling a subset of those via a mask. This can
result in a failed assertion on debug builds.

This patch fixes this by applying the same mask for both the needTrapHandling()
check and the handleTraps() call. Also added a few assertions.

interpreter/Interpreter.cpp:

(JSC::Interpreter::executeProgram):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::execute):

jit/JITOperations.cpp:
llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

9:24 AM Changeset in webkit [213366] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

[GTK] Ensure WebKitWebView always have a user content manager
https://bugs.webkit.org/show_bug.cgi?id=169130

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2017-03-03
Reviewed by Michael Catanzaro.

User content manager is a construct only property, so if not set by the user the web view doesn't have any. We
can create a default one, like we do for settings, when user didn't provide one.

UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewConstructed):

6:16 AM Changeset in webkit [213365] by jfernandez@igalia.com

2 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=169127

Unreviewed GTK+ gardening. Removed duplicated TestExpectations entry.

platform/gtk/TestExpectations:
editing/selection/extend-by-character-007.html fails in GTK as well, so using the general TestExpectations entry.

5:07 AM Changeset in webkit [213364] by commit-queue@webkit.org

4 edits in trunk/LayoutTests

LayoutTest media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=167275
<rdar://problem/30824290>

Patch by Antoine Quint <Antoine Quint> on 2017-03-03
Reviewed by Dean Jackson.

Ensure that we have metrics for buttons before attempting to click on them and let dragging interaction
apply changes to CSS on the next rAF before trying to pursue the next step.

media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls-expected.txt:
media/modern-media-controls/tracks-support/tracks-support-show-panel-after-dragging-controls.html:
platform/mac/TestExpectations:

5:02 AM Changeset in webkit [213363] by Manuel Rego Casasnovas