⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Mar 5, 2017:

11:38 PM Changeset in webkit [213443] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline fast/css/css2-system-fonts.html after r213267.

  • platform/gtk/fast/css/css2-system-fonts-expected.txt:
9:51 PM Changeset in webkit [213442] by beidson@apple.com
  • 1 edit
    3 deletes in trunk/Source/WebKit2

Remove new files accidentally added in r213441

Unreviewed.

  • UIProcess/WebLoadingProviderProxy.cpp: Removed.
  • UIProcess/WebLoadingProviderProxy.h: Removed.
  • UIProcess/WebLoadingProviderProxy.messages.in: Removed.
6:53 PM Changeset in webkit [213441] by beidson@apple.com
  • 23 edits
    3 copies
    9 moves
    1 add
    1 delete in trunk/Source/WebKit2

Rename CustomProtocolFoo to LegacyCustomProtocolFoo.
​https://bugs.webkit.org/show_bug.cgi?id=169188

Reviewed by Andy Estes.

  • CMakeLists.txt:
  • DerivedSources.make:
  • NetworkProcess/CustomProtocols/Cocoa/LegacyCustomProtocolManagerCocoa.mm: Renamed from Source/WebKit2/NetworkProcess/CustomProtocols/Cocoa/CustomProtocolManagerCocoa.mm.

(+[WKCustomProtocol canInitWithRequest:]):
(+[WKCustomProtocol canonicalRequestForRequest:]):
(+[WKCustomProtocol requestIsCacheEquivalent:toRequest:]):
(-[WKCustomProtocol initWithRequest:cachedResponse:client:]):
(-[WKCustomProtocol initializationRunLoop]):
(-[WKCustomProtocol startLoading]):
(-[WKCustomProtocol stopLoading]):
(WebKit::LegacyCustomProtocolManager::registerProtocolClass):
(WebKit::LegacyCustomProtocolManager::registerScheme):
(WebKit::LegacyCustomProtocolManager::unregisterScheme):
(WebKit::LegacyCustomProtocolManager::supportsScheme):
(WebKit::dispatchOnInitializationRunLoop):
(WebKit::LegacyCustomProtocolManager::didFailWithError):
(WebKit::LegacyCustomProtocolManager::didLoadData):
(WebKit::LegacyCustomProtocolManager::didReceiveResponse):
(WebKit::LegacyCustomProtocolManager::didFinishLoading):
(WebKit::LegacyCustomProtocolManager::wasRedirectedToRequest):
(WebKit::LegacyCustomProtocolManager::protocolForID):

  • NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.cpp: Renamed from Source/WebKit2/NetworkProcess/CustomProtocols/CustomProtocolManager.cpp.

(WebKit::generateCustomProtocolID):
(WebKit::LegacyCustomProtocolManager::supplementName):
(WebKit::LegacyCustomProtocolManager::LegacyCustomProtocolManager):
(WebKit::LegacyCustomProtocolManager::initialize):
(WebKit::LegacyCustomProtocolManager::addCustomProtocol):
(WebKit::LegacyCustomProtocolManager::removeCustomProtocol):
(WebKit::LegacyCustomProtocolManager::startLoading):
(WebKit::LegacyCustomProtocolManager::stopLoading):

  • NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.h: Renamed from Source/WebKit2/NetworkProcess/CustomProtocols/CustomProtocolManager.h.
  • NetworkProcess/CustomProtocols/LegacyCustomProtocolManager.messages.in: Renamed from Source/WebKit2/NetworkProcess/CustomProtocols/CustomProtocolManager.messages.in.
  • NetworkProcess/CustomProtocols/soup/LegacyCustomProtocolManagerSoup.cpp: Renamed from Source/WebKit2/NetworkProcess/CustomProtocols/soup/CustomProtocolManagerSoup.cpp.

(WebKit::CustomProtocolManager::WebSoupRequestAsyncData::WebSoupRequestAsyncData):
(WebKit::CustomProtocolManager::WebSoupRequestAsyncData::~WebSoupRequestAsyncData):
(WebKit::CustomProtocolManager::registerProtocolClass):
(WebKit::CustomProtocolManager::registerScheme):
(WebKit::CustomProtocolManager::unregisterScheme):
(WebKit::CustomProtocolManager::supportsScheme):
(WebKit::CustomProtocolManager::didFailWithError):
(WebKit::CustomProtocolManager::didLoadData):
(WebKit::CustomProtocolManager::didReceiveResponse):
(WebKit::CustomProtocolManager::didFinishLoading):
(WebKit::CustomProtocolManager::wasRedirectedToRequest):

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::NetworkProcess):

  • NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::create):

  • NetworkProcess/NetworkSession.h:
  • NetworkProcess/cocoa/NetworkSessionCocoa.h:
  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::globalLegacyCustomProtocolManager):
(WebKit::NetworkSessionCocoa::setLegacyCustomProtocolManager):
(WebKit::NetworkSessionCocoa::create):
(WebKit::NetworkSessionCocoa::defaultSession):
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
(WebKit::globalCustomProtocolManager): Deleted.
(WebKit::NetworkSessionCocoa::setCustomProtocolManager): Deleted.

  • NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):

  • UIProcess/API/APICustomProtocolManagerClient.h:

(API::LegacyCustomProtocolManagerClient::~LegacyCustomProtocolManagerClient):
(API::LegacyCustomProtocolManagerClient::startLoading):
(API::LegacyCustomProtocolManagerClient::stopLoading):
(API::LegacyCustomProtocolManagerClient::invalidate):
(API::CustomProtocolManagerClient::~CustomProtocolManagerClient): Deleted.
(API::CustomProtocolManagerClient::startLoading): Deleted.
(API::CustomProtocolManagerClient::stopLoading): Deleted.
(API::CustomProtocolManagerClient::invalidate): Deleted.

  • UIProcess/Cocoa/LegacyCustomProtocolManagerClient.h: Renamed from Source/WebKit2/UIProcess/Cocoa/CustomProtocolManagerClient.h.
  • UIProcess/Cocoa/LegacyCustomProtocolManagerClient.mm: Renamed from Source/WebKit2/UIProcess/Cocoa/CustomProtocolManagerClient.mm.

(-[WKCustomProtocolLoader initWithLegacyCustomProtocolManagerProxy:customProtocolID:request:]):
(-[WKCustomProtocolLoader dealloc]):
(-[WKCustomProtocolLoader customProtocolManagerProxyDestroyed]):
(-[WKCustomProtocolLoader connection:didFailWithError:]):
(-[WKCustomProtocolLoader connection:willCacheResponse:]):
(-[WKCustomProtocolLoader connection:didReceiveResponse:]):
(-[WKCustomProtocolLoader connection:didReceiveData:]):
(-[WKCustomProtocolLoader connection:willSendRequest:redirectResponse:]):
(-[WKCustomProtocolLoader connectionDidFinishLoading:]):
(WebKit::LegacyCustomProtocolManagerClient::startLoading):
(WebKit::LegacyCustomProtocolManagerClient::stopLoading):
(WebKit::LegacyCustomProtocolManagerClient::invalidate):

  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitialize):

  • UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.cpp: Removed.
  • UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.cpp: Added.

(WebKit::LegacyCustomProtocolManagerProxy::LegacyCustomProtocolManagerProxy):
(WebKit::LegacyCustomProtocolManagerProxy::~LegacyCustomProtocolManagerProxy):
(WebKit::LegacyCustomProtocolManagerProxy::startLoading):
(WebKit::LegacyCustomProtocolManagerProxy::stopLoading):
(WebKit::LegacyCustomProtocolManagerProxy::processDidClose):
(WebKit::LegacyCustomProtocolManagerProxy::wasRedirectedToRequest):
(WebKit::LegacyCustomProtocolManagerProxy::didReceiveResponse):
(WebKit::LegacyCustomProtocolManagerProxy::didLoadData):
(WebKit::LegacyCustomProtocolManagerProxy::didFailWithError):
(WebKit::LegacyCustomProtocolManagerProxy::didFinishLoading):

  • UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.h: Renamed from Source/WebKit2/UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h.
  • UIProcess/Network/CustomProtocols/LegacyCustomProtocolManagerProxy.messages.in: Renamed from Source/WebKit2/UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.messages.in.
  • UIProcess/Network/NetworkProcessProxy.cpp:
  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::WebProcessPool):
(WebKit::WebProcessPool::setLegacyCustomProtocolManagerClient):
(WebKit::WebProcessPool::registerSchemeForCustomProtocol):
(WebKit::WebProcessPool::unregisterSchemeForCustomProtocol):
(WebKit::WebProcessPool::setCustomProtocolManagerClient): Deleted.

  • UIProcess/WebProcessPool.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/cocoa/WebProcessCocoa.mm:
6:48 PM Changeset in webkit [213440] by Simon Fraser
  • 9 edits in trunk

Avoid backing store for layers with empty text nodes in a few more cases
​https://bugs.webkit.org/show_bug.cgi?id=169185

Reviewed by Dan Bernstein.

Source/WebCore:

In hasPaintingNonLayerDescendants() we can check whether the RenderText's linesBoundingBox()
is empty to avoid backing store in a few more cases. Also use containsOnlyWhitespace() rather
than isAllCollapsibleWhitespace(), because there's no need for backing store for non-selectable
whitespace text.

Covered by existing tests.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

LayoutTests:

inline-block-no-backing.html enhanced to have a layer with non-collapsible whitespace (an  ).

Rebaselined other tests.

  • compositing/backing/inline-block-no-backing-expected.txt:
  • compositing/backing/inline-block-no-backing.html:
  • compositing/iframes/page-cache-layer-tree-expected.txt:
  • css3/blending/blend-mode-clip-accelerated-blending-canvas-expected.txt:
  • platform/ios-simulator-wk2/compositing/backing/inline-block-no-backing-expected.txt:
  • platform/ios-simulator-wk2/compositing/iframes/page-cache-layer-tree-expected.txt:
5:37 PM Changeset in webkit [213439] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Drop unnecessary backslash in ResourceResponse::sanitizeSuggestedFilename()
​https://bugs.webkit.org/show_bug.cgi?id=169066

Reviewed by Sam Weinig.

Drop unnecessary backslash in ResourceResponse::sanitizeSuggestedFilename().

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::sanitizeSuggestedFilename):

5:36 PM Changeset in webkit [213438] by Chris Dumez
  • 3 edits
    2 adds in trunk

Using <form> in <template> causes following <form> to get swallowed
​https://bugs.webkit.org/show_bug.cgi?id=163552

Reviewed by Sam Weinig.

Source/WebCore:

As per the HTML specification [1], when finding a "form" tag in the "in body"
insertion mode, we should insert an HTML element for the token, and, if there
is no template element on the stack of open elements, set the form element
pointer to point to the element created.

We were missing the "if there is no template element on the stack of open
elements" check and setting the form element pointer unconditionally.
This patch fixes the issue.

[1] ​https://html.spec.whatwg.org/multipage/syntax.html#parsing-main-inbody:form-element-pointer-2

Test: fast/parser/form-after-template.html

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertHTMLFormElement):

LayoutTests:

Add layout test coverage.

  • fast/parser/form-after-template-expected.html: Added.
  • fast/parser/form-after-template.html: Added.
12:31 PM Changeset in webkit [213437] by aestes@apple.com
  • 3 edits in trunk/Source/WebCore

Add support for canvas.toBlob
​https://bugs.webkit.org/show_bug.cgi?id=148878

Reviewed by Tim Horton.

Address additional review feedback received after r213412 landed.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::toBlob): Passed null to the blob callback if blob conversion
fails for any reason.

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::cgImage): Removed an unnecessary local variable.

12:14 PM Changeset in webkit [213436] by mmaxfield@apple.com
  • 19 edits
    2 adds in trunk

Update CSSFontSelector's matching algorithm to understand ranges
​https://bugs.webkit.org/show_bug.cgi?id=168892

Reviewed by Jon Lee.

Source/WebCore:

This patch migrates the font selection algorithm out of FontCacheCoreText and into its own file which can be shared
among all ports. It then migrates our web font selection algorithm to use it.

This patch doesn't actually change the parsing rules; it just changes the internal machinery for how fonts get
selected. Therefore, this patch simply makes zero-length ranges from the discrete values the parser emits, and passes
those zero-length ranges to the range-based font selection routine. This means that this patch doesn't actually
change the results of the font selection algorithm.

One of the inputs to the new font selection algorithm is font-stretch, which previously was not parsed inside
@font-face blocks or the CSS Font Loading API. This patch therefore adds parsing support and modifies the existing
tests for these pieces to expect parsing to work. Because the font selection algorithm itself is shared between
installed fonts and webfonts, this patch doesn't add any additional tests for it (because it is already covered under
existing tests).

No new tests because there is no behavior change.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj: Add new file for the font selection algorithm.
  • css/CSSFontFace.cpp:

(WebCore::CSSFontFace::calculateStretch): Used on @font-face blocks and the CSS Font Loading API.
(WebCore::CSSFontFace::setStretch): Fill out the previously stubbed function.

  • css/CSSFontFace.h: Add the range member variable to CSSFontFaces.
  • css/CSSFontFaceSet.cpp:

(WebCore::CSSFontFaceSet::ensureLocalFontFacesForFamilyRegistered): Now that we care about font-stretch, we need to
look it up for local fonts too. This current approach of an extra FontSelectionValue hanging around with a
FontTraitsMask is very ugly and will be removed soon (​https://bugs.webkit.org/show_bug.cgi?id=168889 and
​https://bugs.webkit.org/show_bug.cgi?id=168890).
(WebCore::computeFontStretch): Used on @font-face blocks and the CSS Font Loading API.
(WebCore::CSSFontFaceSet::matchingFaces): Educate about font-stretch.
(WebCore::CSSFontFaceSet::fontFace): Migrate to the new font-selection algorithm.
(WebCore::fontFaceComparator): Deleted.

  • css/CSSFontFaceSet.h:
  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::addFontFaceRule): Educate about font-stretch.
(WebCore::CSSFontSelector::fontRangesForFamily): Ditto.

  • css/FontFace.cpp:

(WebCore::FontFace::setStretch): Ditto.
(WebCore::FontFace::stretch): Ditto.

  • css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::parseFontFaceDescriptor): Ditto.

  • platform/graphics/FontCache.h: Ditto.
  • platform/graphics/FontDescription.h:
  • platform/graphics/FontSelectionAlgorithm.cpp: Added.

(WebCore::FontSelectionAlgorithm::filterCapability):
(WebCore::FontSelectionAlgorithm::indexOfBestCapabilities):
(WebCore::fontSelectionRequestForTraitsMask):
(WebCore::initialFontSelectionCapabilitiesForTraitsMask):
(WebCore::fontSelectionCapabilitiesForTraitsMask):

  • platform/graphics/FontSelectionAlgorithm.h: Added. Taken from FontCacheCoreText.cpp.

(WebCore::FontSelectionValue::FontSelectionValue):
(WebCore::FontSelectionValue::operator float):
(WebCore::FontSelectionValue::rawValue):
(WebCore::FontSelectionValue::maximumValue):
(WebCore::FontSelectionValue::minimumValue):
(WebCore::FontSelectionValue::operator+):
(WebCore::FontSelectionValue::operator-):
(WebCore::FontSelectionValue::operator*):
(WebCore::FontSelectionValue::operator/):
(WebCore::FontSelectionValue::operator==):
(WebCore::FontSelectionValue::operator!=):
(WebCore::FontSelectionValue::operator<):
(WebCore::FontSelectionValue::operator<=):
(WebCore::FontSelectionValue::operator>):
(WebCore::FontSelectionValue::operator>=):
(WebCore::FontSelectionRange::isValid):
(WebCore::FontSelectionRange::expand):
(WebCore::FontSelectionRange::includes):
(WebCore::FontSelectionRequest::operator==):
(WebCore::FontSelectionRequest::operator!=):
(WebCore::FontSelectionRequestKey::FontSelectionRequestKey):
(WebCore::FontSelectionRequestKey::isHashTableDeletedValue):
(WebCore::FontSelectionRequestKey::operator==):
(WebCore::FontSelectionRequestKeyHash::hash):
(WebCore::FontSelectionRequestKeyHash::equal):
(WebCore::FontSelectionCapabilities::expand):
(WebCore::FontSelectionAlgorithm::FontSelectionAlgorithm):
(WebCore::FontSelectionAlgorithm::iterateActiveCapabilitiesWithReturn):
(WebCore::FontSelectionAlgorithm::iterateActiveCapabilities):

  • platform/graphics/cocoa/FontCacheCoreText.cpp: Moved to FontSelectionAlgorithm.

(WebCore::stretchFromCoreTextTraits):
(WebCore::FontDatabase::capabilitiesForFontDescriptor):
(WebCore::findClosestFont):
(WebCore::calculateFontSelectionRequest):
(WebCore::platformFontLookupWithFamily):
(WebCore::FontCache::getTraitsInFamily): Deleted.
(WebCore::iterateActiveFontsWithReturn): Deleted.
(WebCore::iterateActiveFonts): Deleted.
(WebCore::findClosestStretch): Deleted.
(WebCore::filterStretch): Deleted.
(WebCore::findClosestStyle): Deleted.
(WebCore::filterStyle): Deleted.
(WebCore::findClosestWeight): Deleted.
(WebCore::filterWeight): Deleted.
(WebCore::computeTargetWeight): Deleted.

  • platform/text/TextFlags.h: Moved to FontSelectionAlgorithm.

(WebCore::FontSelectionValue::FontSelectionValue): Deleted.
(WebCore::FontSelectionValue::operator float): Deleted.
(WebCore::FontSelectionValue::operator+): Deleted.
(WebCore::FontSelectionValue::operator-): Deleted.
(WebCore::FontSelectionValue::operator*): Deleted.
(WebCore::FontSelectionValue::operator/): Deleted.
(WebCore::FontSelectionValue::operator==): Deleted.
(WebCore::FontSelectionValue::operator!=): Deleted.
(WebCore::FontSelectionValue::operator<): Deleted.
(WebCore::FontSelectionValue::operator<=): Deleted.
(WebCore::FontSelectionValue::operator>): Deleted.
(WebCore::FontSelectionValue::operator>=): Deleted.
(WebCore::FontSelectionValue::rawValue): Deleted.
(WebCore::FontSelectionValue::maximumValue): Deleted.
(WebCore::FontSelectionValue::minimumValue): Deleted.
(WebCore::FontSelectionRange::isValid): Deleted.
(WebCore::FontSelectionRange::expand): Deleted.
(WebCore::FontSelectionRange::includes): Deleted.
(WebCore::FontSelectionCapabilities::expand): Deleted.

LayoutTests:

Update CSS Font Loading API test to accept font-stretch values.

  • fast/text/font-face-javascript-expected.txt:
  • fast/text/font-face-javascript.html:
11:14 AM Changeset in webkit [213435] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Make some RenderLayer tree traversal in RenderLayerBacking more generic
​https://bugs.webkit.org/show_bug.cgi?id=169177

Reviewed by Zalan Bujtas.

The real goal of this patch is reduce the number of callers of
RenderLayerBacking::isPaintDestinationForDescendantLayers() to one. To achieve that,
have the setContentsVisible() logic (which is really just about the CSS 'visibility' property)
do its own tree traversal which just consults layer.hasVisibleContent(). So
make descendantLayerPaintsIntoAncestor() a generic traversal function which walks
descendant layers which may paint into the target layer. The "Visible" in the name
reflects the fact that it can bypass a subtree for a layer with !hasVisibleDescendant().

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateAfterDescendants):
(WebCore::traverseVisibleNonCompositedDescendantLayers):
(WebCore::RenderLayerBacking::isPaintDestinationForDescendantLayers):
(WebCore::RenderLayerBacking::hasVisibleNonCompositedDescendants):
(WebCore::descendantLayerPaintsIntoAncestor): Deleted.

  • rendering/RenderLayerBacking.h:
3:10 AM Changeset in webkit [213434] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[GTK] Two file reset tests are failing in the bots since they were added in r213042
​https://bugs.webkit.org/show_bug.cgi?id=169126

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2017-03-05
Reviewed by Michael Catanzaro.

They are failing because the GTK+ event sender is not firing the second UIHelper.activateAt() after the change
event. In one case this causes that the reset button is not clicked, and in the other one the file input is not
unfocused. This is because the change event is emitted before the mouse up, and the GTK+ event sender ignores
mouse down events when the button is already down to not confuse Xvfb. So, we can easily fix theses tests by
using a timeout to ensure the next UIHelper.activateAt() happens in a different run loop iteration, after the
mouse up.

  • fast/forms/file/file-input-reset-using-open-panel.html:
  • fast/forms/file/file-reset-in-change-using-open-panel.html:
12:37 AM Changeset in webkit [213433] by Yusuke Suzuki
  • 3 edits in trunk/Source/JavaScriptCore

[JSCOnly][GTK] Suppress warnings on return type in B3 and WASM
​https://bugs.webkit.org/show_bug.cgi?id=168869

Reviewed by Keith Miller.

  • b3/B3Width.h:
  • wasm/WasmSections.h:

Mar 4, 2017:

11:41 PM Changeset in webkit [213432] by mitz@apple.com
  • 2 edits
    1 add in trunk/Source/ThirdParty/libwebrtc

[Cocoa] libwebrtc.dylib’s current version is fixed at 1.0.0
​https://bugs.webkit.org/show_bug.cgi?id=169170

Reviewed by Alex Christensen.

  • Configurations/Version.xcconfig: Copied from Source/JavaScriptCore/Configurations/Version.xcconfig. This defines DYLIB_CURRENT_VERSION.
  • Configurations/libwebrtc.xcconfig: Include Version.xcconfig.
5:06 PM Changeset in webkit [213431] by Chris Dumez
  • 2 edits in trunk/LayoutTests/imported/w3c

Rebaseline W3C test after r213412.

  • web-platform-tests/html/dom/interfaces-expected.txt:
2:39 PM Changeset in webkit [213430] by eric.carlson@apple.com
  • 4 edits
    1 add in trunk/Source/WebKit2

[iOS] The web process should inherit application state from UI process
​https://bugs.webkit.org/show_bug.cgi?id=169156
<rdar://problem/30845473>

Reviewed by Alexey Proskuryakov.

  • Platform/spi/ios/CelestialSPI.h: Added.
  • WebKit2.xcodeproj/project.pbxproj: Include CelestialSPI.h.
  • WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist: Add entitlement.
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformInitialize): Set up PID proxying.

1:49 PM Changeset in webkit [213429] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Clarify some terminology in RenderLayerBacking
​https://bugs.webkit.org/show_bug.cgi?id=169174

Reviewed by Zalan Bujtas.

Rename some functions related to directly-composited background images and
box decorations for clarify.

Only behavior change is for canDirectlyCompositeBackgroundBackgroundImage() to check
GraphicsLayer::supportsContentsTiling(), which means that RenderLayerBacking::contentChanged()
will no longer trigger a updateGeometry() when it gets BackgroundImageChanged on non-
CoordinateGraphics platforms.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::RenderLayerBacking::updateAfterDescendants):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBoxDecorations):
(WebCore::canDirectlyCompositeBackgroundBackgroundImage):
(WebCore::hasPaintedBoxDecorationsOrBackgroundImage):
(WebCore::supportsDirectlyCompositedBoxDecorations):
(WebCore::RenderLayerBacking::paintsBoxDecorations):
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
(WebCore::RenderLayerBacking::contentChanged):
(WebCore::RenderLayerBacking::updateDirectlyCompositedContents): Deleted.
(WebCore::canCreateTiledImage): Deleted.
(WebCore::hasVisibleBoxDecorationsOrBackgroundImage): Deleted.
(WebCore::supportsDirectBoxDecorationsComposition): Deleted.

  • rendering/RenderLayerBacking.h:
1:05 PM Changeset in webkit [213428] by aakash_jain@apple.com
  • 2 edits
    1 add in trunk/Source/WebKit2

Add symbols required by TAPI from Shared/API/Cocoa/WebKit.m in a header file
​https://bugs.webkit.org/show_bug.cgi?id=169162

Reviewed by Alexey Proskuryakov.

The symbols from binary and headers should match precisely, otherwise TAPI would
complain. There are few symbols which are not actually needed in header file, but
we still need to add them in a header file to make TAPI happy.

  • Platform/ExtraPublicSymbolsForTAPI.h: Added.
  • WebKit2.xcodeproj/project.pbxproj: Added ExtraPublicSymbolsForTAPI.h
11:53 AM Changeset in webkit [213427] by aakash_jain@apple.com
  • 2 edits
    1 add in trunk/Source/WebKit2

Add symbols required by TAPI in a header file
​https://bugs.webkit.org/show_bug.cgi?id=169113
<rdar://problem/30772033>

Reviewed by Alexey Proskuryakov.

The symbols from binary and headers should match precisely, otherwise TAPI would
complain. There are few symbols which are not actually needed in header file, but
we still need to add them in a header file to make TAPI happy.

  • Platform/ExtraPrivateSymbolsForTAPI.h: Added.
  • WebKit2.xcodeproj/project.pbxproj: Added Platform/ExtraPrivateSymbolsForTAPI.h
11:32 AM Changeset in webkit [213426] by Michael Catanzaro
  • 2 edits in trunk

Unreviewed, remove stray period from readme

  • ReadMe.md:
10:07 AM Changeset in webkit [213425] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

[ARM] Unreviewed buildfix after r213376.

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::isBkpt): Typo fixed.

9:31 AM Changeset in webkit [213424] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Cleanup after r213418
​https://bugs.webkit.org/show_bug.cgi?id=169165

Patch by Alex Christensen <​achristensen@webkit.org> on 2017-03-04
Reviewed by Youenn Fablet.

Source/ThirdParty/libwebrtc:

  • WebKit/patch-libwebrtc:

I made another change after the last patch I uploaded to stop crashing.
This should be reflected in our patch.

Source/WebCore:

  • platform/mediastream/mac/RealtimeIncomingAudioSource.cpp:

(WebCore::RealtimeIncomingAudioSource::OnData):
Restore the assertion I removed.

9:15 AM Changeset in webkit [213423] by commit-queue@webkit.org
  • 38 edits
    2 adds
    22 deletes in trunk

Unreviewed, rolling out r213379.
​https://bugs.webkit.org/show_bug.cgi?id=169169

broke GTK+ and Windows builds (Requested by mcatanzaro on
#webkit).

Reverted changeset:

"Enable fieldsets to be flexboxes, grids and multicolumn."
​https://bugs.webkit.org/show_bug.cgi?id=169082
​http://trac.webkit.org/changeset/213379

6:52 AM Changeset in webkit [213422] by Lucas Forschler
  • 1 edit in trunk/Tools/ChangeLog

Test commit against svn.webkit.org after SHA-1 cleanup.

Unreviewed.

12:57 AM Changeset in webkit [213421] by Nikita Vasilyev
  • 10 edits
    8 adds in trunk

Web Inspector: Show Web Socket connections in Network tab
​https://bugs.webkit.org/show_bug.cgi?id=167520

Reviewed by Joseph Pecoraro.

Source/WebInspectorUI:

Show Web Socket connections in Network and Resources tabs. Display HTTP headers
of Web Socket handshake request in the details sidebar.

  • UserInterface/Controllers/FrameResourceManager.js:

(WebInspector.FrameResourceManager.prototype.initialize):
(WebInspector.FrameResourceManager.prototype.webSocketCreated):
(WebInspector.FrameResourceManager.prototype.webSocketWillSendHandshakeRequest):
webSocketWillSendHandshakeRequest doesn't receive a request URL as one of its parameters.
Store URLs received from webSocketCreated method in _webSocketIdentifierToURL map.

(WebInspector.FrameResourceManager.prototype.webSocketHandshakeResponseReceived):
(WebInspector.FrameResourceManager.prototype.webSocketFrameReceived):
(WebInspector.FrameResourceManager.prototype.webSocketFrameSent):
(WebInspector.FrameResourceManager.prototype.webSocketClosed):
Mark resource as finished when Web Socket handshake is complete or Web Socket is closed.
This may change in the future.

(WebInspector.FrameResourceManager.prototype._webSocketFrameReceivedOrSent):

  • UserInterface/Main.html:
  • UserInterface/Models/WebSocketResource.js: Added.

(WebInspector.WebSocketResource):
(WebInspector.WebSocketResource.prototype.set readyState):
(WebInspector.WebSocketResource.prototype.get readyState):
(WebInspector.WebSocketResource.prototype.get frames):
(WebInspector.WebSocketResource.prototype.addFrame):
Introduce WebSocketResource model to store WebSocket frames (incoming and outgoing messages)
and readyState.

  • UserInterface/Protocol/NetworkObserver.js:

(WebInspector.NetworkObserver.prototype.webSocketCreated):
(WebInspector.NetworkObserver.prototype.webSocketWillSendHandshakeRequest):
(WebInspector.NetworkObserver.prototype.webSocketHandshakeResponseReceived):
(WebInspector.NetworkObserver.prototype.webSocketClosed):
(WebInspector.NetworkObserver.prototype.webSocketFrameReceived):
(WebInspector.NetworkObserver.prototype.webSocketFrameError):
(WebInspector.NetworkObserver.prototype.webSocketFrameSent):
(WebInspector.NetworkObserver):
Add corresponding methods for the newly added FrameResourceManager methods.

  • UserInterface/Test.html:
  • UserInterface/Views/NetworkSidebarPanel.js:

(WebInspector.NetworkSidebarPanel.prototype.treeElementAddedOrChanged):
Don't show the go to arrow for WebSocket items since WebSocketContentView isn't implemented
yet.

  • UserInterface/Views/ResourceClusterContentView.js:

(WebInspector.ResourceClusterContentView.prototype.get responseContentView):
Don't show any content views for WebSocket items.

  • UserInterface/Views/ResourceTreeElement.js:

(WebInspector.ResourceTreeElement.prototype.ondblclick):
Don't open WebSocket URL in a new browser tab.

LayoutTests:

  • http/tests/websocket/tests/hybi/inspector/client-close-expected.txt: Added.
  • http/tests/websocket/tests/hybi/inspector/client-close.html: Added.
  • http/tests/websocket/tests/hybi/inspector/client-close_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

  • http/tests/websocket/tests/hybi/inspector/server-close-expected.txt: Added.
  • http/tests/websocket/tests/hybi/inspector/server-close.html: Added.
  • http/tests/websocket/tests/hybi/inspector/server-close_wsh.py: Added.

(web_socket_do_extra_handshake):
(web_socket_transfer_data):

  • platform/ios-simulator/TestExpectations:
12:38 AM Changeset in webkit [213420] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Remove duplicate initialization guard in WebKit2 logging initialization
​https://bugs.webkit.org/show_bug.cgi?id=169164

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-03-04
Reviewed by Dan Bernstein.

  • Platform/Logging.cpp:

(WebKit::initializeLogChannelsIfNecessary):

12:20 AM Changeset in webkit [213419] by achristensen@apple.com
  • 2 edits in trunk/Source/WTF

[Win64] 'int128_t': undeclared identifier in MediaTime.cpp
​https://bugs.webkit.org/show_bug.cgi?id=169123

Patch by Jer Noble <​jer.noble@apple.com> on 2017-03-03
Reviewed by Alex Christensen.

Don't perform the 128-bit optimized path on Windows, where the int128_t intrinsic isn't available.

  • wtf/MediaTime.cpp:

(WTF::MediaTime::setTimeScale):

Note: See TracTimeline for information about the timeline view.